Changeset 98804 in webkit


Ignore:
Timestamp:
Oct 29, 2011 7:45:23 AM (12 years ago)
Author:
kbalazs@webkit.org
Message:

new-run-webkit-tests: MASTER BUG: Switch all webkit.org bots over
https://bugs.webkit.org/show_bug.cgi?id=34984

Patch by Eric Seidel <eric@webkit.org> on 2011-10-29
Reviewed by Adam Barth.

Move run-webkit-tests from using a white-list of supported NRWT ports
to a blacklist of ports requiring ORWT.

I've also added the ability to opt-in to parallel testing on a per-port basis.

With these changes I'm going to officially declare this bug dead and
work on remaining polish issues and individual developer complaints.

  • Scripts/run-webkit-tests:

(useNewRunWebKitTests):
(platformIsReadyForParallelTesting):

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r98801 r98804  
     12011-10-29  Eric Seidel  <eric@webkit.org>
     2
     3        new-run-webkit-tests: MASTER BUG: Switch all webkit.org bots over
     4        https://bugs.webkit.org/show_bug.cgi?id=34984
     5
     6        Reviewed by Adam Barth.
     7
     8        Move run-webkit-tests from using a white-list of supported NRWT ports
     9        to a blacklist of ports requiring ORWT.
     10
     11        I've also added the ability to opt-in to parallel testing on a per-port basis.
     12
     13        With these changes I'm going to officially declare this bug dead and
     14        work on remaining polish issues and individual developer complaints.
     15
     16        * Scripts/run-webkit-tests:
     17        (useNewRunWebKitTests):
     18        (platformIsReadyForParallelTesting):
     19
    1202011-10-29  Sheriff Bot  <webkit.review.bot@gmail.com>
    221
  • trunk/Tools/Scripts/run-webkit-tests

    r98801 r98804  
    5858sub useNewRunWebKitTests()
    5959{
    60     # Change this check to control which platforms use new-run-webkit-tests by default.
    61     # Example: return runningOnBuildBot() && isLeopard();
    62     # would enable new-run-webkit-tests on only the leopard buildbots.
     60    # NRWT Windows support still needs work: https://bugs.webkit.org/show_bug.cgi?id=38756
     61    return 0 if isWindows() or isCygwin();
     62    # NRWT does not support qt-arm: https://bugs.webkit.org/show_bug.cgi?id=64086
     63    return 0 if isQt() and isARM();
     64    # All other platforms should use NRWT by default.
     65    return 1;
     66}
    6367
    64     # Note: We use a whitelist here to avoid calling isPORT() for ports
    65     # for which we haven't explicitly added support.  Calling isPORT()
    66     # will remove the --PORT argument from @ARGV, causing us to fail to pass it to the test harness.
     68sub platformIsReadyForParallelTesting()
     69{
     70    # NRWT is able to run the tests in parallel, ORWT was not.
     71    # When we run the tests in parallel, tests which (incorrectly)
     72    # interact with each other can start failing.
     73    # To reduce the failure burden during the transition individual
     74    # platforms can opt-in to parallel test execution by default.
    6775
    68     # NRWT Windows support still needs work: https://bugs.webkit.org/show_bug.cgi?id=38756
    69 
    70     # NRWT doesn't support qt-arm and qt-4.8 platforms now: https://bugs.webkit.org/show_bug.cgi?id=64071 and https://bugs.webkit.org/show_bug.cgi?id=64086
    71     if (isQt()) {
    72         return (!isARM());
    73     }
    74 
    75     return (isLeopard() or isSnowLeopard() or isLion() or isGtk());
     76    # Platforms interested in dog-fooding faster test runs on their bots
     77    # should add themselves to this blacklist, e.g.:
     78    # return isGtk() or isQt();
     79    # This will likely require skipping tests or marking tests as flaky in test_expectations.txt
     80    return 0;
    7681}
    7782
     
    8186    $harnessName = "new-run-webkit-tests";
    8287
    83     if (!grep(/--child-processes/, @ARGV)) {
     88    if (!grep(/--child-processes/, @ARGV) and !platformIsReadyForParallelTesting()) {
    8489        push(@ARGV, "--child-processes=1");
    8590        print "Running new-run-webkit-tests with one child process.\n";
     
    9297}
    9398
    94 # FIXME: We need a cleaner way to do --platform handling.
    9599# webkitdirs.pm strips --qt and --gtk from @ARGV when we call isQt/isGtk.
    96100# We have to add back any --PORT arguments which may have been removed by isPort() checks above.
Note: See TracChangeset for help on using the changeset viewer.