Changeset 99471 in webkit

Timestamp:

Nov 7, 2011 1:59:19 PM (12 years ago)

Author:

dominicc@chromium.org

Message:

Remove initPopStateEvent method
​https://bugs.webkit.org/show_bug.cgi?id=71691

Reviewed by Ojan Vafai.

Source/WebCore:

• dom/PopStateEvent.cpp:
• dom/PopStateEvent.h:
• dom/PopStateEvent.idl:

LayoutTests:

• fast/events/fire-popstate-event.html: use 'new PopStateEvent' now

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/events/fire-popstate-event.html (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/PopStateEvent.cpp (modified) (1 diff)
• Source/WebCore/dom/PopStateEvent.h (modified) (1 diff)
• Source/WebCore/dom/PopStateEvent.idl (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-11-07  Dominic Cooney  <dominicc@chromium.org>
+
+        Remove initPopStateEvent method
+        https://bugs.webkit.org/show_bug.cgi?id=71691
+
+        Reviewed by Ojan Vafai.
+
+        * fast/events/fire-popstate-event.html: use 'new PopStateEvent' now
+
 2011-11-07  Adam Barth  <abarth@webkit.org>
 

trunk/LayoutTests/fast/events/fire-popstate-event.html

@@ -16 +16 @@
 onload = function()
 {
-    var evt = document.createEvent("PopStateEvent");
-    evt.initPopStateEvent("popstate", false, false, { testValue: "Success"} );
+    var evt = new PopStateEvent('popstate', {
+            bubbles: false,
+            cancelable: false,
+            state: { testValue: 'Success' }
+        });
     window.dispatchEvent(evt);
 }

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-11-07  Dominic Cooney  <dominicc@chromium.org>
+
+        Remove initPopStateEvent method
+        https://bugs.webkit.org/show_bug.cgi?id=71691
+
+        Reviewed by Ojan Vafai.
+
+        * dom/PopStateEvent.cpp:
+        * dom/PopStateEvent.h:
+        * dom/PopStateEvent.idl:
+
 2011-11-07  Andreas Kling  <kling@webkit.org>
 

trunk/Source/WebCore/dom/PopStateEvent.cpp

@@ -86 +86 @@
 }
 
-void PopStateEvent::initPopStateEvent(const AtomicString& type, bool canBubble, bool cancelable, const ScriptValue& state)
-{
-    if (dispatched())
-        return;
-
-    initEvent(type, canBubble, cancelable);
-
-    m_state = state;
-}
-
 const AtomicString& PopStateEvent::interfaceName() const
 {

trunk/Source/WebCore/dom/PopStateEvent.h

@@ -47 +47 @@
     static PassRefPtr<PopStateEvent> create(PassRefPtr<SerializedScriptValue>);
     static PassRefPtr<PopStateEvent> create(const AtomicString&, const PopStateEventInit&);
-    void initPopStateEvent(const AtomicString& type, bool canBubble, bool cancelable, const ScriptValue&);
 
     SerializedScriptValue* serializedState() const { return m_serializedState.get(); }

trunk/Source/WebCore/dom/PopStateEvent.idl

@@ -32 +32 @@
         CustomConstructor,
     ] PopStateEvent : Event {
-        void initPopStateEvent(in [Optional=CallWithDefaultValue] DOMString typeArg, 
-                               in [Optional=CallWithDefaultValue] boolean canBubbleArg, 
-                               in [Optional=CallWithDefaultValue] boolean cancelableArg, 
-                               in [Optional=CallWithDefaultValue] DOMObject stateArg);
-
         readonly attribute [CustomGetter] DOMObject state;
     };