Changeset 99566 in webkit


Ignore:
Timestamp:
Nov 8, 2011 7:16:16 AM (12 years ago)
Author:
Nikolas Zimmermann
Message:

2011-11-08 Nikolas Zimmermann <nzimmermann@rim.com>

[Qt] 4 new tests fail introduced in r98852
https://bugs.webkit.org/show_bug.cgi?id=71253

Reviewed by Rob Buis.

Address some problems seen on Qt/Chromium:

  • Remove the scaled png which is the source of the problem in zoom-background-images.html, we really only want to test zooming in the SVGImage there.
  • Don't zoom out more than three times, otherwise its ignored on Mac/DRT, where the minimum zoom factor is clamped to 0.5f. Qt doesn't have this limit, and currently zooms more than Mac does. There's no need to zoom out that often, three times is enough.
  • platform/mac/svg/zoom/page/zoom-background-images-expected.png: Updated.
  • platform/mac/svg/zoom/page/zoom-background-images-expected.txt: Update.
  • svg/zoom/page/zoom-background-image-tiled.html: Don't set shouldZoomOut to false, it's the default.
  • svg/zoom/page/zoom-background-images.html: Don't zoom out more than three times.
  • svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm: Ditto.
  • svg/zoom/page/zoom-svg-as-background-with-relative-size.html: Ditto.
  • svg/zoom/page/zoom-svg-as-image.html: There is no shouldZoomIn, just remove it, zooming in is the default.
Location:
trunk/LayoutTests
Files:
8 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r99565 r99566  
     12011-11-08  Nikolas Zimmermann  <nzimmermann@rim.com>
     2
     3        [Qt] 4 new tests fail introduced in r98852
     4        https://bugs.webkit.org/show_bug.cgi?id=71253
     5
     6        Reviewed by Rob Buis.
     7
     8        Address some problems seen on Qt/Chromium:
     9        - Remove the scaled png which is the source of the problem in zoom-background-images.html, we really only want to test zooming in the SVGImage there.
     10        - Don't zoom out more than three times, otherwise its ignored on Mac/DRT, where the minimum zoom factor is clamped to 0.5f.
     11          Qt doesn't have this limit, and currently zooms more than Mac does. There's no need to zoom out that often, three times is enough.
     12
     13        * platform/mac/svg/zoom/page/zoom-background-images-expected.png: Updated.
     14        * platform/mac/svg/zoom/page/zoom-background-images-expected.txt: Update.
     15        * svg/zoom/page/zoom-background-image-tiled.html: Don't set shouldZoomOut to false, it's the default.
     16        * svg/zoom/page/zoom-background-images.html: Don't zoom out more than three times.
     17        * svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm: Ditto.
     18        * svg/zoom/page/zoom-svg-as-background-with-relative-size.html: Ditto.
     19        * svg/zoom/page/zoom-svg-as-image.html: There is no shouldZoomIn, just remove it, zooming in is the default.
     20
    1212011-11-08  Gavin Peters  <gavinp@chromium.org>
    222
  • trunk/LayoutTests/platform/mac/svg/zoom/page/zoom-background-images-expected.txt

    r98852 r99566  
    1414        text run at (457,143) width 2: " "
    1515      RenderImage {IMG} at (470,11) size 129x129 [border: (1px solid #000000)]
    16       RenderText {#text} at (610,143) size 2x10
    17         text run at (610,143) width 2: " "
    18       RenderImage {IMG} at (623,11) size 129x129 [border: (1px solid #000000)]
    1916      RenderText {#text} at (0,0) size 0x0
    2017      RenderText {#text} at (0,0) size 0x0
  • trunk/LayoutTests/svg/zoom/page/zoom-background-image-tiled.html

    r98852 r99566  
    1818<div></div>
    1919
    20 <script>var zoomCount = 4; window.shouldZoomOut = false;</script>
     20<script>var zoomCount = 4;</script>
    2121<script src="../resources/testPageZoom.js"></script>
    2222
  • trunk/LayoutTests/svg/zoom/page/zoom-background-images.html

    r98852 r99566  
    3232<div class="gradient"></div>
    3333<img src="resources/circle.svg"></img>
    34 <img src="../../custom/resources/green-checker.png"></img>
    3534
    36 <script>var zoomCount = 5; window.shouldZoomOut = true;</script>
     35<script>var zoomCount = 3; window.shouldZoomOut = true;</script>
    3736<script src="../resources/testPageZoom.js"></script>
    3837
  • trunk/LayoutTests/svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm

    r88913 r99566  
    4141  <p id="p3"><object id="img3" type="image/svg+xml" data="resources/intrinsic-ratio.svg">This test won't work because you do not have images enabled.</object></p>
    4242
    43   <script>var zoomCount = 4; window.shouldZoomOut = true;</script>
     43  <script>var zoomCount = 3; window.shouldZoomOut = true;</script>
    4444  <script src="../resources/testPageZoom.js"></script>
    4545 </body>
  • trunk/LayoutTests/svg/zoom/page/zoom-svg-as-background-with-relative-size.html

    r98852 r99566  
    1515<div>&nbsp;</div>
    1616
    17 <script>var zoomCount = 4; window.shouldZoomOut = true;</script>
     17<script>var zoomCount = 3; window.shouldZoomOut = true;</script>
    1818<script src="../resources/testPageZoom.js"></script>
    1919</body>
  • trunk/LayoutTests/svg/zoom/page/zoom-svg-as-image.html

    r98852 r99566  
    1414</div>
    1515
    16 <script>var zoomCount = 4; window.shouldZoomIn = true;</script>
     16<script>var zoomCount = 4;</script>
    1717<script src="../resources/testPageZoom.js"></script>
    1818
Note: See TracChangeset for help on using the changeset viewer.