Changeset 99693 in webkit

Timestamp:

Nov 9, 2011 5:31:59 AM (12 years ago)

Author:

Csaba Osztrogonác

Message:

Enable the DFG JIT on x86-64 Linux platforms
​https://bugs.webkit.org/show_bug.cgi?id=71373

Enable DFG JIT by default on X86 Linux and Mac platforms
​https://bugs.webkit.org/show_bug.cgi?id=71686

Buildfix for stricter compilers: -Werror=unused-but-set-variable

Reviewed by Zoltan Herczeg.

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• dfg/DFGSpeculativeJIT.cpp (modified) (2 diffs)
• dfg/DFGSpeculativeJIT32_64.cpp (modified) (2 diffs)
• dfg/DFGSpeculativeJIT64.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2011-11-09  Csaba Osztrogonác  <ossy@webkit.org>
+
+        Enable the DFG JIT on x86-64 Linux platforms
+        https://bugs.webkit.org/show_bug.cgi?id=71373
+
+        Enable DFG JIT by default on X86 Linux and Mac platforms
+        https://bugs.webkit.org/show_bug.cgi?id=71686
+
+        Buildfix for stricter compilers: -Werror=unused-but-set-variable
+
+        Reviewed by Zoltan Herczeg.
+
+        * dfg/DFGSpeculativeJIT.cpp:
+        (JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
+        * dfg/DFGSpeculativeJIT32_64.cpp:
+        (JSC::DFG::SpeculativeJIT::compile):
+        * dfg/DFGSpeculativeJIT64.cpp:
+        (JSC::DFG::SpeculativeJIT::compile):
+
 2011-11-09  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp

@@ -732 +732 @@
         m_jit.move(valueOp.gpr(), scratchReg);
         MacroAssembler::Jump inBounds = m_jit.branch32(MacroAssembler::BelowOrEqual, scratchReg, TrustedImm32(0xff));
-        MacroAssembler::Jump tooBig = m_jit.branch32(MacroAssembler::GreaterThan, scratchReg, TrustedImm32(0xff));
+        m_jit.branch32(MacroAssembler::GreaterThan, scratchReg, TrustedImm32(0xff));
         m_jit.xorPtr(scratchReg, scratchReg);
         MacroAssembler::Jump clamped = m_jit.jump();
@@ -750 +750 @@
         valueGPR = gpr;
     }
-    ASSERT(valueGPR != property);
+    ASSERT_UNUSED(valueGPR, valueGPR != property);
     ASSERT(valueGPR != base);
     GPRTemporary storage(this);

trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp

@@ -1506 +1506 @@
         // Code to handle put beyond array bounds.
         silentSpillAllRegisters(scratchReg);
-        JITCompiler::Call functionCall = callOperation(operationPutByValBeyondArrayBounds, baseReg, propertyReg, valueTagReg, valuePayloadReg);
+        callOperation(operationPutByValBeyondArrayBounds, baseReg, propertyReg, valueTagReg, valuePayloadReg);
         silentFillAllRegisters(scratchReg);
         JITCompiler::Jump wasBeyondArrayBounds = m_jit.jump();
@@ -2494 +2494 @@
         structuresNotMatch.link(&m_jit);
         silentSpillAllRegisters(resultTagGPR, resultPayloadGPR);
-        JITCompiler::Call functionCall = callOperation(operationResolveGlobal, resultTagGPR, resultPayloadGPR, resolveInfoGPR, &m_jit.codeBlock()->identifier(data.identifierNumber));
+        callOperation(operationResolveGlobal, resultTagGPR, resultPayloadGPR, resolveInfoGPR, &m_jit.codeBlock()->identifier(data.identifierNumber));
         silentFillAllRegisters(resultTagGPR, resultPayloadGPR);
 

trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp

@@ -1550 +1550 @@
         // Code to handle put beyond array bounds.
         silentSpillAllRegisters(scratchReg);
-        JITCompiler::Call functionCall = callOperation(operationPutByValBeyondArrayBounds, baseReg, propertyReg, valueReg);
+        callOperation(operationPutByValBeyondArrayBounds, baseReg, propertyReg, valueReg);
         silentFillAllRegisters(scratchReg);
         JITCompiler::Jump wasBeyondArrayBounds = m_jit.jump();
@@ -2469 +2469 @@
 
         silentSpillAllRegisters(resultGPR);
-        JITCompiler::Call functionCall = callOperation(operationResolveGlobal, resultGPR, resolveInfoGPR, &m_jit.codeBlock()->identifier(data.identifierNumber));
+        callOperation(operationResolveGlobal, resultGPR, resolveInfoGPR, &m_jit.codeBlock()->identifier(data.identifierNumber));
         silentFillAllRegisters(resultGPR);