Changeset 99762 in webkit

Timestamp:

Nov 9, 2011 2:43:05 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Implement dumpProgressFinishedCallback() for Mac layoutTestController
​https://bugs.webkit.org/show_bug.cgi?id=66772

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2011-11-09
Reviewed by Simon Fraser.

Tools:

When dumpProgressFinishedCallback is enabled, DumpRenderTree should output
"postProgressFinishedNotification" on FrameLoaderClient::postProgressFinishedNotification().

On Mac, the FrameLoaderClient post a notification. This patch add handling for this notification
in the FrameLoadDelegate and print the output in response to the notification.

• DumpRenderTree/mac/FrameLoadDelegate.mm:

(-[FrameLoadDelegate init]):
(-[FrameLoadDelegate dealloc]):
(-[FrameLoadDelegate webViewProgressFinishedNotification:]):

LayoutTests:

Unskip the skipped test.

• platform/mac/Skipped:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac/Skipped (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/DumpRenderTree/mac/FrameLoadDelegate.mm (modified) (4 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-11-09  Benjamin Poulain  <bpoulain@apple.com>
+
+        Implement dumpProgressFinishedCallback() for Mac layoutTestController
+        https://bugs.webkit.org/show_bug.cgi?id=66772
+
+        Reviewed by Simon Fraser.
+
+        Unskip the skipped test.
+
+        * platform/mac/Skipped:
+
 2011-11-09  Alexei Svitkine  <asvitkine@chromium.org>
 

trunk/LayoutTests/platform/mac/Skipped

@@ -454 +454 @@
 fast/loader/document-destruction-within-unload.html
 
-# https://bugs.webkit.org/show_bug.cgi?id=66772
-http/tests/loading/progress-finished-callback.html
-
 # https://bugs.webkit.org/show_bug.cgi?id=67716
 media/media-controls-invalid-url.html

trunk/Tools/ChangeLog

@@ +1 @@
+2011-11-09  Benjamin Poulain  <bpoulain@apple.com>
+
+        Implement dumpProgressFinishedCallback() for Mac layoutTestController
+        https://bugs.webkit.org/show_bug.cgi?id=66772
+
+        Reviewed by Simon Fraser.
+
+        When dumpProgressFinishedCallback is enabled, DumpRenderTree should output
+        "postProgressFinishedNotification" on FrameLoaderClient::postProgressFinishedNotification().
+
+        On Mac, the FrameLoaderClient post a notification. This patch add handling for this notification
+        in the FrameLoadDelegate and print the output in response to the notification.
+
+        * DumpRenderTree/mac/FrameLoadDelegate.mm:
+        (-[FrameLoadDelegate init]):
+        (-[FrameLoadDelegate dealloc]):
+        (-[FrameLoadDelegate webViewProgressFinishedNotification:]):
+
 2011-11-09  Philippe Normand  <pnormand@igalia.com>
 

trunk/Tools/DumpRenderTree/mac/FrameLoadDelegate.mm

@@ -34 +34 @@
 #import "AppleScriptController.h"
 #import "EventSendingController.h"
+#import "Foundation/NSNotification.h"
 #import "GCController.h"
 #import "LayoutTestController.h"
@@ -107 +108 @@
         gcController = new GCController;
         accessibilityController = new AccessibilityController;
+        [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(webViewProgressFinishedNotification:) name:WebViewProgressFinishedNotification object:nil];
     }
     return self;
@@ -113 +115 @@
 - (void)dealloc
 {
+    [[NSNotificationCenter defaultCenter] removeObserver:self];
     delete gcController;
     delete accessibilityController;
@@ -412 +415 @@
 }
 
-@end
+- (void)webViewProgressFinishedNotification:(NSNotification *)notification
+{
+    if (!done && gLayoutTestController->dumpProgressFinishedCallback())
+        printf ("postProgressFinishedNotification\n");
+}
+
+@end