Timeline
Jun 25, 2009:
- 9:44 PM Changeset in webkit [45247] by
-
- 4 edits1 add in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=26681
<rdar://problem/7003461> Problem updating applicationCache when server returns 304
Test: http/tests/appcache/update-cache.html
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveResponse): We're already done with the resource, don't try to load it again.
- 9:21 PM Changeset in webkit [45246] by
-
- 1 edit in branches/nitro-extreme/JavaScriptCore/ChangeLog
Fix up JavaScriptCore/ChangeLog, messed up slightly in the merge.
- 8:32 PM Changeset in webkit [45245] by
-
- 3 edits2 adds in trunk
2009-06-25 Simon Fraser <Simon Fraser>
Reviewed by Oliver Hunt.
<rdar://problem/6990481>
Handle perspective computation on non-layer objects.
Test: transforms/3d/general/perspective-non-layer.html
- rendering/RenderObject.cpp: (WebCore::RenderObject::getTransformFromContainer):
- 8:03 PM Changeset in webkit [45244] by
-
- 110 edits32 copies22 deletes in branches/nitro-extreme
Merged r45138:45243 into nitro-extreme branch.
- 7:56 PM Changeset in webkit [45243] by
-
- 3 edits2 adds in branches/nitro-extreme
Merged r45137:45138 into nitro-extreme branch.
- 7:53 PM Changeset in webkit [45242] by
-
- 125 edits49 copies in branches/nitro-extreme
Merged r45039:45137 into nitro-extreme branch.
- 7:47 PM Changeset in webkit [45241] by
-
- 7 edits2 copies in branches/nitro-extreme
Merged r45038:45039 into nitro-extreme branch.
- 7:35 PM Changeset in webkit [45240] by
-
- 67 edits26 copies in branches/nitro-extreme
Merged r45000:45038 into nitro-extreme branch.
- 7:32 PM Changeset in webkit [45239] by
-
- 3 edits1 move1 add7 deletes in trunk/LayoutTests
2009-06-25 Ryosuke Niwa <rniwa@google.com>
Reviewed by Eric Seidel.
The following pixel tests have been converted into dumpastext tests. This
fixes the bug 26336 partially.
- editing/execCommand/remove-list-1-expected.txt: Added.
- editing/execCommand/remove-list-1.html:
- editing/execCommand/remove-list-items-expected.txt: Added.
- editing/execCommand/remove-list-items.html:
- platform/mac/editing/execCommand/remove-list-1-expected.checksum: Removed.
- platform/mac/editing/execCommand/remove-list-1-expected.png: Removed.
- platform/mac/editing/execCommand/remove-list-1-expected.txt: Removed.
- platform/mac/editing/execCommand/remove-list-items-expected.checksum: Removed.
- platform/mac/editing/execCommand/remove-list-items-expected.png: Removed.
- platform/mac/editing/execCommand/remove-list-items-expected.txt: Removed.
- platform/qt/editing/execCommand/remove-list-1-expected.txt: Removed.
- platform/qt/editing/execCommand/remove-list-items-expected.txt: Removed.
- 7:31 PM Changeset in webkit [45238] by
-
- 95 edits36 copies1 delete in branches/nitro-extreme
Merged r44960:45000 into nitro-extreme branch.
- 7:20 PM Changeset in webkit [45237] by
-
- 53 edits2 adds in branches/nitro-extreme
Merged r44943:44960 into nitro-extreme branch.
- 7:19 PM Changeset in webkit [45236] by
-
- 2 edits in trunk/LayoutTests
2009-06-25 Simon Fraser <Simon Fraser>
Rubber-stamped by Eric Seidel
Update this test after the video controller changes.
- platform/mac/fast/layers/video-layer-expected.txt:
- 7:13 PM Changeset in webkit [45235] by
-
- 22 edits7 deletes in branches/nitro-extreme/WebCore
Merged r44942:44943 into nitro-extreme branch.
- 7:12 PM Changeset in webkit [45234] by
-
- 2 edits in trunk/LayoutTests
2009-06-25 Jan Michael Alonzo <jmalonzo@webkit.org>
Not reviewed. Skip another failing test due to lack of eventSender impl.
- platform/gtk/Skipped:
- 6:42 PM Changeset in webkit [45233] by
-
- 6 adds in branches/nitro-extreme/WebCore/html
Build fixes, mostly files not added.
- 6:38 PM Changeset in webkit [45232] by
-
- 2 edits in trunk/LayoutTests
2009-06-25 Jan Michael Alonzo <jmalonzo@webkit.org>
Not reviewed. Skip failing gtk tests due to missing DRT features.
- platform/gtk/Skipped:
- 6:28 PM Changeset in webkit [45231] by
-
- 2 adds in branches/nitro-extreme/WebCore/dom
Build fixes, mostly files not added.
- 6:16 PM Changeset in webkit [45230] by
-
- 1 edit3 adds in trunk/LayoutTests
2009-06-25 Simon Fraser <Simon Fraser>
Rubber-stamped by Dan Bernstein.
Add Windows-specific test results, since Windows does not have
3d transforms enabled.
- platform/win/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/media/mq-transform-02-expected.txt.
- platform/win/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/media/mq-transform-03-expected.txt.
- 6:08 PM Changeset in webkit [45229] by
-
- 1 edit in branches/nitro-extreme/WebCore/bindings/scripts/CodeGeneratorJS.pm
Build fix
- 6:06 PM Changeset in webkit [45228] by
-
- 9 edits in trunk
2009-06-25 Pierre d'Herbemont <pdherbemont@apple.com>
Reviewed by Eric Seidel.
Use flex box in the mediaControls.css style, to nicely scale if a button gets
dynamically added or removed.
Media tests results are affected by this changes.
- css/mediaControls.css:
- css/mediaControlsQT.css:
- 6:03 PM Changeset in webkit [45227] by
-
- 4 edits in trunk/WebKitLibraries
2009-06-25 Simon Fraser <Simon Fraser>
Rubber-stamped by Mark Rowe.
<rdar://problem/6999737>
Update the media controller images.
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 5:58 PM Changeset in webkit [45226] by
-
- 57 edits19 copies2 adds in branches/nitro-extreme
Merged r44920:44942 into nitro-extreme branch.
- 5:50 PM Changeset in webkit [45225] by
-
- 64 edits17 copies4 deletes in branches/nitro-extreme
Merged r44889:44920 into nitro-extreme branch.
- 5:49 PM Changeset in webkit [45224] by
-
- 4 edits3 adds10 deletes in trunk/LayoutTests
2009-06-25 Ryosuke Niwa <rniwa@google.com>
Reviewed by Eric Seidel.
The following pixel tests have been converted into dumpastext tests. This
fixes the bug 26336 partially.
- editing/execCommand/5432254-2-expected.txt: Added.
- editing/execCommand/5432254-2.html:
- editing/execCommand/5700414-1-expected.txt: Added.
- editing/execCommand/5700414-1.html:
- editing/execCommand/5700414-2-expected.txt: Added.
- editing/execCommand/5700414-2.html:
- platform/mac/editing/execCommand/5432254-2-expected.checksum: Removed.
- platform/mac/editing/execCommand/5432254-2-expected.png: Removed.
- platform/mac/editing/execCommand/5432254-2-expected.txt: Removed.
- platform/mac/editing/execCommand/5700414-1-expected.checksum: Removed.
- platform/mac/editing/execCommand/5700414-1-expected.png: Removed.
- platform/mac/editing/execCommand/5700414-1-expected.txt: Removed.
- platform/mac/editing/execCommand/5700414-2-expected.checksum: Removed.
- platform/mac/editing/execCommand/5700414-2-expected.png: Removed.
- platform/mac/editing/execCommand/5700414-2-expected.txt: Removed.
- platform/qt/editing/execCommand/5432254-2-expected.txt: Removed.
- 5:34 PM Changeset in webkit [45223] by
-
- 8 edits in branches/nitro-extreme/JavaScriptCore
Merged r44888:44889 into nitro-extreme branch.
- 5:28 PM Changeset in webkit [45222] by
-
- 15 edits in branches/nitro-extreme
Merged r44884:44888 into nitro-extreme branch.
- 5:26 PM Changeset in webkit [45221] by
-
- 2 edits in trunk/WebKitSite
2009-06-24 Brady Eidson <beidson@apple.com>
Reviewed by Mark Rowe
- demos/index.html: Fix more typos etc.
- 5:24 PM Changeset in webkit [45220] by
-
- 4 edits in trunk/WebKit/qt
2009-06-25 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Adam Treat.
Add highlight functionality to the QWebPage::findText() method. Introduced is
new HighlightAllOccurrences flag which passed to the function will make it mark
all existing occurrences of specified string in the page.
- Api/qwebpage.cpp: (QWebPage::findText):
- Api/qwebpage.h:
- Api/qwebview.cpp:
- 5:22 PM Changeset in webkit [45219] by
-
- 1 edit1 add in trunk/WebKit/gtk/po
2009-06-25 Duy Nguyen <pclouds@gmail.com>
Rubber-stamped by Jan Alonzo.
Gtk port Vietnamese translation
https://bugs.webkit.org/show_bug.cgi?id=26739
- vi.po: Added.
- 5:22 PM Changeset in webkit [45218] by
-
- 6 edits in branches/nitro-extreme/JavaScriptCore
Merged r44883:44884 into nitro-extreme branch.
- 5:16 PM Changeset in webkit [45217] by
-
- 103 edits23 copies4 deletes in branches/nitro-extreme
Merged r44844:44883 into nitro-extreme branch.
- 5:07 PM Changeset in webkit [45216] by
-
- 11 edits in branches/nitro-extreme/JavaScriptCore
Merged r44843:44844 into nitro-extreme branch.
- 4:58 PM Changeset in webkit [45215] by
-
- 5 edits in trunk/WebCore
2009-06-25 Albert J. Wong <ajwong@chromium.org>
Reviewed by Darin Fisher.
Move relavent part of setDefaultFontSize from RenderThemeChromiumWin
up into RenderThemeChromiumSkia.
- rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::setDefaultFontSize):
- rendering/RenderThemeChromiumSkia.h:
- rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::setDefaultFontSize):
- rendering/RenderThemeChromiumWin.h:
- 4:54 PM Changeset in webkit [45214] by
-
- 3 edits in trunk/WebKit/mac
2009-06-25 Anders Carlsson <andersca@apple.com>
Reviewed by Oliver Hunt.
<rdar://problem/6989017>
REGRESSION (SnowLeopard): RealPlayer content replays when opening a new tab or switching back to the RealPlayer tab
If a plug-in fails in NPP_New, we would try to recreate it whenever the preferences for a web view would change.
Fix this by setting a flag when we fail to instantiate the plug-in, so we only try once.
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView start]):
- 4:49 PM Changeset in webkit [45213] by
-
- 11 edits16 copies in branches/nitro-extreme
Merged r44838:44843 into nitro-extreme branch.
- 4:45 PM Changeset in webkit [45212] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-06-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Optimize x++ to ++x inside for loops.
Sadly, no measurable speedup, but this should help with result chaining.
- parser/Nodes.cpp: (JSC::ForNode::emitBytecode):
- 4:39 PM Changeset in webkit [45211] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
Merged r44837:44838 into nitro-extreme branch.
- 4:36 PM Changeset in webkit [45210] by
-
- 2 edits in trunk/WebKitTools
2009-06-25 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Mark Rowe.
bugzilla-tool apply-patch throws exception in Linux
https://bugs.webkit.org/show_bug.cgi?id=26738
HEAD is case-sensitive in Linux. Convert uses of head to HEAD in
the scm module.
- Scripts/modules/scm.py:
- 4:24 PM Changeset in webkit [45209] by
-
- 111 edits36 copies44 deletes in branches/nitro-extreme
Merged r44796:44837 into nitro-extreme branch.
- 4:21 PM Changeset in webkit [45208] by
-
- 3 edits in trunk/WebCore
2009-06-25 Matt Perry <mpcomplete@chromium.org>
Reviewed by Darin Fisher.
Add V8-only methods to FrameLoaderClient that V8 can use to send
out notifications when it creates/destroys a script context.
- loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::didCreateScriptContext): (WebCore::EmptyFrameLoaderClient::didDestroyScriptContext):
- loader/FrameLoaderClient.h: (WebCore::FrameLoaderClient::didCreateScriptContext): (WebCore::FrameLoaderClient::didDestroyScriptContext):
- 4:11 PM Changeset in webkit [45207] by
-
- 2 edits in trunk/WebCore
2009-06-25 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by David Levin.
Correct a few typos that snuck in when I was reformatting CodeGeneratorV8.pm
to match WebKit style.
- bindings/scripts/CodeGeneratorV8.pm: Corrected lots of typos.
- 3:42 PM Changeset in webkit [45206] by
-
- 3 edits in branches/nitro-extreme/WebCore
Build fix, revert part of last build fix.
- 3:37 PM Changeset in webkit [45205] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-06-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Standardized some more opcodes to put { tag, payload } in { regT1, regT0 }.
- jit/JITArithmetic.cpp: (JSC::JIT::emitSlow_op_bitnot): (JSC::JIT::emit_op_post_inc):
- 3:35 PM Changeset in webkit [45204] by
-
- 4 edits in trunk
Some cosmetic fixes I missed in my last checkin
- 3:32 PM Changeset in webkit [45203] by
-
- 2 edits in trunk/WebCore
2009-06-25 Adam Langley <agl@google.com>
TBRed: fix for Chromium tree.
Add missing include for r45199.
r45199 added a reference to throwError without including V8Proxy.h
- bindings/v8/WorkerScriptController.cpp:
- 3:16 PM Changeset in webkit [45202] by
-
- 3 edits9 adds in branches/nitro-extreme
Build fixes, mostly files not added.
- 3:13 PM Changeset in webkit [45201] by
-
- 2 edits in trunk/WebCore
2009-06-25 Adam Langley <agl@google.com>
TBRed: fix for Chromium tree.
Fix V8IsolatedWorld to point to the correct include file.
The deprecated v8_index.h was removed from the Chromium tree in r19291
and upstreamed into WebKit with r45193. However V8IsolatedWorld
slipped in between the cracks and broke the build.
- bindings/v8/V8IsolatedWorld.h: update with new header location.
- 3:09 PM Changeset in webkit [45200] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-06-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Standardized some more opcodes to put { tag, payload } in { regT1, regT0 }.
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_bitnot): (JSC::JIT::emit_op_post_dec): (JSC::JIT::emit_op_pre_inc): (JSC::JIT::emitSlow_op_pre_inc): (JSC::JIT::emit_op_pre_dec): (JSC::JIT::emitSlow_op_pre_dec):
- 3:03 PM Changeset in webkit [45199] by
-
- 16 edits in trunk
Preference is named "WebKitAcceleratedCompositingEnabled"
and is a boolean value. When false, prevents compositing layers from
being created, which prevents hardware animation from running.
Also forces video to do software rendering. Added a cache for
the flag in RenderLayerCompositing and made it all work
on-the-fly when the flag is changed while a page is loaded.
- 2:54 PM Changeset in webkit [45198] by
-
- 2 edits in trunk/WebCore
2009-06-25 Jian Li <jianli@chromium.org>
Reviewed by Dimitri Glazkov.
Bug 26701: Implement the missing code for "FIXME: Need to return an
exception" in WorkerScriptController::evaluate for v8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=26701
- bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::evaluate):
- 2:52 PM Changeset in webkit [45197] by
-
- 3 edits in trunk/WebKitTools
2009-06-25 Eric Seidel <eric@webkit.org>
Reviewed by Mark Rowe.
Call WebKitTools/Scripts scripts by their absolute paths
https://bugs.webkit.org/show_bug.cgi?id=26704
bugzilla-tool used to use whatever build-webkit was in your path.
That could end up building the wrong copy of WebKit.
- Scripts/bugzilla-tool:
- Scripts/modules/scm.py:
- 2:51 PM Changeset in webkit [45196] by
-
- 1 copy in tags/Safari-6530.19.1
New tag.
- 2:44 PM Changeset in webkit [45195] by
-
- 2 edits in branches/WWDC-2009-branch/JavaScriptCore
2009-06-24 Mark Rowe <mrowe@apple.com>
Merge r44117.
2009-05-24 Steve Falkenburg <sfalken@apple.com>
Build fix for experimental PGO Windows target.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- 2:42 PM Changeset in webkit [45194] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-06-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Standardized some more opcodes to put { tag, payload } in { regT1, regT0 }.
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_negate): (JSC::JIT::emitSlow_op_negate):
- jit/JITCall.cpp: (JSC::JIT::emit_op_construct_verify): (JSC::JIT::emitSlow_op_construct_verify):
- 2:39 PM Changeset in webkit [45193] by
-
- 2 edits1 add in trunk/WebCore
2009-06-25 Nate Chapin <Nate Chapin>
Reviewed by Dimitri Glazkov.
Upstream V8Index.
- bindings/v8/V8Index.cpp: Added. (WebCore::V8ClassIndex::GetFactory): Moved from src.chromium.org. (WebCore::V8ClassIndex::GetCache): Moved from src.chromium.org.
- bindings/v8/V8Index.h: (WebCore::V8ClassIndex::): Moved from src.chromium.org. (WebCore::V8ClassIndex::ToInt): Moved from src.chromium.org. (WebCore::V8ClassIndex::FromInt): Moved from src.chromium.org.
- 2:26 PM Changeset in webkit [45192] by
-
- 2 edits in trunk/WebKitTools
2009-06-25 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Dave Levin.
Use unicode() instead of str when reading from bugzilla.
Also add Simon Fraser as a reviewer.
https://bugs.webkit.org/show_bug.cgi?id=26719
- Scripts/modules/bugzilla.py:
- 2:15 PM Changeset in webkit [45191] by
-
- 3 edits in trunk/WebCore
2009-06-25 Adam Langley <agl@google.com>
Reviewed by Darin Fisher.
This is hopefully the last step before our renderers can run
cleanly in a chroot.
WebKit needs to be able to ask for the correct font to use in
the case that the current font doesn't include glyphs for
certain code points. Currently we make a fontconfig call in our
WebKit port to handle this.
This patch changes this so that the call is sent our via
ChromiumBridge.
This should not affect any layout tests.
- platform/chromium/ChromiumBridge.h:
- platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getFontDataForCharacters):
- 2:02 PM Changeset in webkit [45190] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-06-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Standardized some more opcodes to put { tag, payload } in { regT1, regT0 }.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_true): (JSC::JIT::emit_op_jfalse): (JSC::JIT::emit_op_jtrue): (JSC::JIT::emit_op_jeq_null): (JSC::JIT::emit_op_jneq_null): (JSC::JIT::emit_op_eq_null): (JSC::JIT::emit_op_neq_null):
- 1:34 PM Changeset in webkit [45189] by
-
- 1 edit4 adds in trunk/WebCore
2009-06-25 Albert J. Wong <ajwong@chromium.org>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=26566
Upstream these files from the chromium v8 code. No tests were
affected because this is essentially a code move.
- bindings/v8/NPV8Object.cpp: Added. (allocV8NPObject): (freeV8NPObject): (listFromVariantArgs): (npIdentifierToV8Identifier): (npCreateV8ScriptObject): (NPN_Invoke): (NPN_InvokeDefault): (NPN_Evaluate): (NPN_EvaluateHelper): (NPN_GetProperty): (NPN_SetProperty): (NPN_RemoveProperty): (NPN_HasProperty): (NPN_HasMethod): (NPN_SetException): (NPN_Enumerate): (NPN_Construct):
- bindings/v8/NPV8Object.h: Added. (PrivateIdentifier::):
- bindings/v8/V8NPUtils.cpp: Added. (convertV8ObjectToNPVariant): (convertNPVariantToV8Object): (getStringIdentifier):
- bindings/v8/V8NPUtils.h: Added.
- 1:34 PM Changeset in webkit [45188] by
-
- 3 edits3 adds in trunk
WebCore:
2009-06-25 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Dimitri Glazkov.
Windows Chromium bug fix: save context of destination canvas in
TransparencyWin::compositeTextComposite() before the function
modifies the context.
Test: fast/canvas/translate-text.html
- platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::compositeTextComposite):
LayoutTests:
2009-06-25 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Dimitri Glazkov.
Windows Chromium bug fix: save context of destination canvas in
TransparencyWin::compositeTextComposite() before the function
modifies the context.
- fast/canvas/resources/translate-text.js: Added. (description.pixelValueAt): (pixelToString): (pixelShouldBe):
- fast/canvas/translate-text-expected.txt: Added.
- fast/canvas/translate-text.html: Added.
- 1:34 PM Changeset in webkit [45187] by
-
- 2 edits in trunk/LayoutTests
2009-06-25 Takeshi Yoshino <tyoshino@google.com>
Reviewed by David Levin.
Bug 26207: Rebaseline the expected image for fast/forms/select-style.html for Mac.
https://bugs.webkit.org/show_bug.cgi?id=26207
Replace the expected image for fast/forms/select-style-expected.html for
Mac which need to be rebaselined due to r43903
(http://trac.webkit.org/changeset/43903).
- platform/mac/fast/forms/select-style-expected.png:
- 1:34 PM Changeset in webkit [45186] by
-
- 3 edits1 add in trunk/WebCore
2009-06-25 Patrick Mueller <Patrick_Mueller@us.ibm.com>
Reviewed by Timothy Hatcher.
Show the filename and first line for "(program)" in the Profiler/Debugger
https://bugs.webkit.org/show_bug.cgi?id=25475
Add support to associate a sourceURL with an eval()'d string
via a @sourceURL comment. Currently the sourceURL is only available
in the script debugger, not in the console or profiler, but it's
most needed in the script debugger.
- English.lproj/localizedStrings.js: added new "(program): %s" string
- inspector/front-end/Script.js: (WebInspector.Script): if no sourceURL is available for the Script, search for a comment of the form @ sourceURL=(url) to use as the sourceURL instead.
- manual-tests/inspector/named-evals.html: Added.
- 1:34 PM Changeset in webkit [45185] by
-
- 7 edits2 adds in trunk
WebCore:
2009-06-25 John Gregg <johnnyg@google.com>
Reviewed by Sam Weinig.
Bug 23721: Changing dropdown's selectedIndex within onchange handler fires another onchange
https://bugs.webkit.org/show_bug.cgi?id=23721
onchange events fire when a SELECT element has
focus and the selectedIndex is updated by script in some way--either
during another onchange, onkeypress, onfocus, or timer--and then
focus is lost.
Fixed by making a separate method for user-driven selectedIndex
changes, leaving scripts to use one which doesn't cause onchange to
be queued.
Test: fast/forms/select-script-onchange.html
- dom/SelectElement.cpp: check if the pending change is user driven before calling onchange (WebCore::SelectElement::menuListOnChange): (WebCore::SelectElement::setSelectedIndex):
- dom/SelectElement.h: store whether the pending change is user driven (WebCore::SelectElementData::userDrivenChange): (WebCore::SelectElementData::setUserDrivenChange):
- html/HTMLSelectElement.cpp: split into two methods -- script version [non-user-driven] corresponds to IDL defined property name (WebCore::HTMLSelectElement::setSelectedIndex): (WebCore::HTMLSelectElement::setSelectedIndexByUser):
- html/HTMLSelectElement.h:
- rendering/RenderMenuList.cpp: use ByUser method when coming through the renderer (WebCore::RenderMenuList::valueChanged):
LayoutTests:
2009-06-25 John Gregg <johnnyg@google.com>
Reviewed by Sam Weinig.
Bug 23721: Changing dropdown's selectedIndex within onchange handler fires another onchange
https://bugs.webkit.org/show_bug.cgi?id=23721
Check for unnecessary calls to onchange in response to script
actions.
- fast/forms/select-script-onchange-expected.txt: Added.
- fast/forms/select-script-onchange.html: Added.
- 1:10 PM Changeset in webkit [45184] by
-
- 4 edits in tags/Safari-6531.1
Versioning.
- 1:02 PM Changeset in webkit [45183] by
-
- 14 edits4 deletes in trunk/WebCore
2009-06-25 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Combined LocalStorageArea and SessionStorageArea into StorageArea since
(after my other refactorings) there are no longer substantial
differences between the two.
- GNUmakefile.am:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- storage/LocalStorage.cpp: (WebCore::LocalStorage::storageArea):
- storage/LocalStorage.h:
- storage/LocalStorageArea.cpp: Removed.
- storage/LocalStorageArea.h: Removed.
- storage/SessionStorage.cpp: (WebCore::SessionStorage::copy): (WebCore::SessionStorage::storageArea):
- storage/SessionStorage.h:
- storage/SessionStorageArea.cpp: Removed.
- storage/SessionStorageArea.h: Removed.
- storage/StorageArea.cpp: (WebCore::StorageArea::createLocalStorage): (WebCore::StorageArea::StorageArea): (WebCore::StorageArea::createSessionStorage): (WebCore::StorageArea::copy): (WebCore::StorageArea::setItem): (WebCore::StorageArea::removeItem): (WebCore::StorageArea::clear): (WebCore::StorageArea::scheduleFinalSync): (WebCore::StorageArea::blockUntilImportComplete): (WebCore::StorageArea::dispatchStorageEvent):
- storage/StorageArea.h:
- storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::StorageAreaSync): (WebCore::StorageAreaSync::scheduleFinalSync): (WebCore::StorageAreaSync::syncTimerFired): (WebCore::StorageAreaSync::performImport):
- storage/StorageAreaSync.h:
- storage/StorageSyncManager.h:
- 12:50 PM Changeset in webkit [45182] by
-
- 4 edits in trunk
Versioning.
- 12:48 PM Changeset in webkit [45181] by
-
- 1 copy in tags/Safari-6531.1
New tag.
- 12:45 PM Changeset in webkit [45180] by
-
- 5 edits2 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix https://bugs.webkit.org/show_bug.cgi?id=26671 <rdar://problem/7001880> Safari 4.0 crashes in WebCore::DOMTimer::fired()
Test: fast/dom/style-sheet-candidate-remove-unrendered-document.html
When a "style sheet candidate" element is removed from a document,
call Document::removeStyleSheetCandidateNode() regardless of whether
the document is rendered. Otherwise, the document's style sheet
candidate set can end up containing stale references.
- dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::removedFromDocument):
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::removedFromDocument):
- html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::removedFromDocument):
LayoutTests:
Reviewed by Darin Adler.
- test for https://bugs.webkit.org/show_bug.cgi?id=26671 <rdar://problem/7001880> Safari 4.0 crashes in WebCore::DOMTimer::fired()
- fast/dom/style-sheet-candidate-remove-unrendered-document-expected.txt: Added.
- fast/dom/style-sheet-candidate-remove-unrendered-document.html: Added.
- 11:53 AM Changeset in webkit [45179] by
-
- 2 edits in trunk/WebCore
2009-06-25 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Darin Fisher.
Update CodeGeneratorV8.pm to sync up with the changes downstream.
- bindings/scripts/CodeGeneratorV8.pm: Added HTMLFrameSetElement check, FileList as a ref-counted type, and DataGridColumn as typeCanFailConversion.
- 11:14 AM Changeset in webkit [45178] by
-
- 2 edits in trunk
Credit the correct reviewer.
- 10:23 AM Changeset in webkit [45177] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-06-25 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig (sort of, maybe).
Fixed some ASSERTs in http/tests/security.
These ASSERTs were introduced by http://trac.webkit.org/changeset/45057,
but the underlying problem was actually older. http://trac.webkit.org/changeset/45057
just exposed the problem by enabling optimization in more cases.
The ASSERTs fired because we tested PropertySlot::slotBase() for validity,
but slotBase() ASSERTs if it's invalid, so we would ASSERT before
the test could happen. Solution: Remove the ASSERT. Maybe it was valid
once, but it clearly goes against a pattern we've deployed of late.
The underlying problem was that WebCore would re-use a PropertySlot in
the case of a forwarding access, and the second use would not completely
overwrite the first use. Solution: Make sure to overwrite m_offset when
setting a value on a PropertySlot. (Other values already get implicitly
overwritten during reuse.)
- runtime/PropertySlot.h: (JSC::PropertySlot::PropertySlot): (JSC::PropertySlot::setValueSlot): (JSC::PropertySlot::setValue): (JSC::PropertySlot::setRegisterSlot): (JSC::PropertySlot::setUndefined): (JSC::PropertySlot::slotBase): (JSC::PropertySlot::clearOffset):
- 9:08 AM ProjectVision edited by
- (diff)
- 9:03 AM QtWebKit edited by
- (diff)
- 9:00 AM QtWebKitContrib edited by
- (diff)
- 8:54 AM QtWebKitGitInstructions edited by
- (diff)
- 8:50 AM Changeset in webkit [45176] by
-
- 2 edits in trunk/WebCore
2009-06-25 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
Add FileList.h include to fix Chromium build.
- platform/chromium/ClipboardChromium.cpp: Added FileList.h include.
- 8:48 AM UsingGitWithWebKit edited by
- (diff)
- 8:46 AM UsingGitWithWebKit edited by
- (diff)
- 8:46 AM UsingGitWithWebKit edited by
- (diff)
- 8:37 AM UsingGitWithWebKit edited by
- Make this more explicit. (diff)
- 6:14 AM Changeset in webkit [45175] by
-
- 2 edits in trunk/WebKitTools
2009-06-25 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
Use Q_ASSERT in Qt's DumpRenderTree instead of JSC's ASSERT
The WTFReportAssertionFailure function in JSC is not exported when
building QtWebKit in both debug and release on Mac, so DRT fails to
link.
We can revert this patch once the Qt port builds JSC as a separate
library, and we add the proper export macros to Assertions.cpp
- DumpRenderTree/qt/WorkQueue.cpp: (WorkQueue::queue): (WorkQueue::dequeue):
- 6:11 AM Changeset in webkit [45174] by
-
- 2 edits in trunk/WebKitTools
2009-06-25 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Jan Alonzo.
bugzilla-tool: Add Simon Hausmann as reviewer
- Scripts/modules/bugzilla.py:
- 5:42 AM Changeset in webkit [45173] by
-
- 3 edits in trunk/WebCore
2009-06-25 Joseph Pecoraro <joepeck02@gmail.com>
Reviewed by Jan Alonzo.
Bug 26489: Web Inspector: Typo in DatabaseQuery Error Message
https://bugs.webkit.org/show_bug.cgi?id=26489
Fixed a Typo in a Web Inspector error message.
- English.lproj/localizedStrings.js:
- inspector/front-end/DatabaseQueryView.js: (WebInspector.DatabaseQueryView.prototype._queryError):
- 4:11 AM Changeset in webkit [45172] by
-
- 2 edits in trunk/WebCore
2009-06-25 Simon Hausmann <simon.hausmann@nokia.com>
Fix the Qt build, add missing StorageAreaSync files to the build.
- WebCore.pro:
- 3:56 AM Changeset in webkit [45171] by
-
- 2 edits in trunk/WebCore
2009-06-25 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by and done with Tor Arne Vestbø.
Fix shortcut keyboard handling with plugins on the Qt/Mac build.
When we receive shortcut events like Ctrl+V then the text in the QKeyEvent is
empty. If we're asked to disambiguate the event into a Char keyboard event,
we try to detect this situation and still set the text, to ensure that the
general event handling sends a key press event after this disambiguation.
- platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):
- 3:05 AM Changeset in webkit [45170] by
-
- 4 edits in trunk/LayoutTests
2009-06-25 Eric Seidel <eric@webkit.org>
No review, just skipping a new test.
Skip new test on platforms missing eventSender.beginDragWithFiles
Test: http/tests/security/clipboard/clipboard-file-access.html
https://bugs.webkit.org/show_bug.cgi?id=25916
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 2:49 AM Changeset in webkit [45169] by
-
- 5 edits in trunk/WebCore
2009-06-25 Eric Seidel <eric@webkit.org>
Build fix only, no review.
Add FileList.h and NotImplemented.h includes in an attempt to fix bots.
- platform/gtk/ClipboardGtk.cpp:
- platform/qt/ClipboardQt.cpp:
- platform/win/ClipboardWin.cpp:
- platform/wx/ClipboardWx.cpp:
- 2:24 AM Changeset in webkit [45168] by
-
- 16 edits8 adds in trunk
2009-06-24 Dan Bernstein <mitz@apple.com>
Reviewed by Simon Fraser.
- test for <rdar://problem/7001817> REGRESSION (r41902): Base position track at UCSC Genome Browser doesn't work because image map prevents img from hit-testing
- fast/replaced/image-map-2-expected.txt: Added.
- fast/replaced/image-map-2.html: Added.
2009-05-21 Eric Seidel <eric@webkit.org>
Reviewed by Maciej Stachowiak.
Expose files in the clipboard in ondrop events
https://bugs.webkit.org/show_bug.cgi?id=25916
Make it possible for applications like gmail to implement
drag and drop of attachments onto email messages.
This patch exposes an event.dataTransfer.files accessor
on the drop event. No information is exposed during dragover.
This follows the HTML 5 drag and drop security model:
http://www.w3.org/TR/html5/editing.html#security-risks-in-the-drag-and-drop-model
The test http/tests/security/clipboard/clipboard-file-access.html
verifies this behavior.
Internet Explorer shows historical documentation of supporting
getData('File') as a way of exposing files on the pasteboard. The current version of their docs:
http://msdn.microsoft.com/en-us/library/ms537658(VS.85).aspx
has removed this reference (as far as I can tell IE never implemented it)
I have a printed copy of that URL from 2008 on my desk describing getData('File') in IE.
IE does not follow the HTML5 clipboard security model and always allows access to the full clipboard, even on dragover.
I choose not to use IE's getData('File') and instead added .files
so that the accessor could have a type, matching WebKit's existing
.files accessor on HTMLInputElement.
Mozilla has equivalent file access:
event.dataTransfer.mozGetDataAt("application/x-moz-file", 0);
which also does not return a typed value.
https://developer.mozilla.org/En/DragDrop/Recommended_Drag_Types#Dragging_Files
This is only implemented for Mac WebKit. All other platforms (including Apple's Win WebKit)
have incomplete Clipboard implementations and will require experts from those platforms
to add this functionality. Right now they all have Clipboard*::files() methods which call notImplemented();
Test: http/tests/security/clipboard/clipboard-file-access.html
- dom/Clipboard.h:
- dom/Clipboard.idl:
- platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::files):
- platform/chromium/ClipboardChromium.h:
- platform/gtk/ClipboardGtk.cpp: (WebCore::ClipboardGtk::files):
- platform/gtk/ClipboardGtk.h:
- platform/mac/ClipboardMac.h:
- platform/mac/ClipboardMac.mm: (WebCore::absoluteURLsFromPasteboardFilenames): (WebCore::absoluteURLsFromPasteboard): (WebCore::ClipboardMac::files):
- platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::files):
- platform/qt/ClipboardQt.h:
- platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::files):
- platform/win/ClipboardWin.h:
- platform/wx/ClipboardWx.cpp: (WebCore::ClipboardWx::files):
- platform/wx/ClipboardWx.h:
- 1:51 AM Changeset in webkit [45167] by
-
- 4 edits in branches/nitro-extreme
Merged r44794:44796 into nitro-extreme branch.
- 1:41 AM Changeset in webkit [45166] by
-
- 151 edits2 copies in branches/nitro-extreme
Merged r44747:44794 into nitro-extreme branch.
- 1:27 AM Changeset in webkit [45165] by
-
- 1 edit4 adds in trunk/WebCore
2009-06-25 Eric Seidel <eric@webkit.org>
No review, only completing revert of r45144.
Add back files deleted by r45144.
- storage/LocalStorageArea.cpp: Added. (WebCore::LocalStorageArea::create): (WebCore::LocalStorageArea::LocalStorageArea): (WebCore::LocalStorageArea::scheduleFinalSync): (WebCore::LocalStorageArea::itemChanged): (WebCore::LocalStorageArea::itemRemoved): (WebCore::LocalStorageArea::areaCleared): (WebCore::LocalStorageArea::blockUntilImportComplete): (WebCore::LocalStorageArea::dispatchStorageEvent):
- storage/LocalStorageArea.h: Added.
- storage/SessionStorageArea.cpp: Added. (WebCore::SessionStorageArea::copy): (WebCore::SessionStorageArea::SessionStorageArea): (WebCore::SessionStorageArea::itemChanged): (WebCore::SessionStorageArea::itemRemoved): (WebCore::SessionStorageArea::areaCleared): (WebCore::SessionStorageArea::blockUntilImportComplete): (WebCore::SessionStorageArea::dispatchStorageEvent):
- storage/SessionStorageArea.h: Added. (WebCore::SessionStorageArea::create):
- 1:26 AM Changeset in webkit [45164] by
-
- 6 edits in branches/nitro-extreme
Merged r44743:44747 into nitro-extreme branch.
- 1:22 AM Changeset in webkit [45163] by
-
- 4 edits in branches/nitro-extreme/JavaScriptCore
Merged r44742:44743 into nitro-extreme branch.
- 1:19 AM Changeset in webkit [45162] by
-
- 14 edits in trunk/WebCore
2009-06-25 Eric Seidel <eric@webkit.org>
No review, reverting r45144 only.
Roll out r45144 after 18 test failures appeared on the bots.
https://bugs.webkit.org/show_bug.cgi?id=26698
- GNUmakefile.am:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- storage/LocalStorage.cpp: (WebCore::LocalStorage::storageArea):
- storage/LocalStorage.h:
- storage/SessionStorage.cpp: (WebCore::SessionStorage::copy): (WebCore::SessionStorage::storageArea):
- storage/SessionStorage.h:
- storage/StorageArea.cpp: (WebCore::StorageArea::StorageArea): (WebCore::StorageArea::~StorageArea): (WebCore::StorageArea::setItem): (WebCore::StorageArea::removeItem): (WebCore::StorageArea::clear):
- storage/StorageArea.h:
- storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::StorageAreaSync): (WebCore::StorageAreaSync::scheduleFinalSync): (WebCore::StorageAreaSync::syncTimerFired): (WebCore::StorageAreaSync::performImport):
- storage/StorageAreaSync.h:
- storage/StorageSyncManager.h:
- 1:17 AM Changeset in webkit [45161] by
-
- 56 edits47 copies14 deletes in branches/nitro-extreme
Merged r44712:44742 into nitro-extreme branch.
- 1:09 AM Changeset in webkit [45160] by
-
- 4 edits in trunk/WebKitTools
2009-06-24 Eric Seidel <eric@webkit.org>
Reviewed by Dave Levin.
Support local commits during apply-patches
and let land-patches take multiple bug ids.
https://bugs.webkit.org/show_bug.cgi?id=26703
I also restructured parts of land-patches into
class methods and static methods in preparation
for future code sharing with other commands.
- Scripts/bugzilla-tool:
- Scripts/modules/bugzilla.py:
- Scripts/modules/scm.py:
- 1:09 AM Changeset in webkit [45159] by
-
- 18 edits1 copy in branches/nitro-extreme
Merged r44710:44712 into nitro-extreme branch.
- 1:03 AM Changeset in webkit [45158] by
-
- 11 edits in branches/nitro-extreme/WebCore
Merged r44705:44710 into nitro-extreme branch.
- 1:01 AM Changeset in webkit [45157] by
-
- 11 edits in branches/nitro-extreme/JavaScriptCore
Merged r44704:44705 into nitro-extreme branch.
- 12:56 AM Changeset in webkit [45156] by
-
- 2 adds in branches/nitro-extreme/JavaScriptCore/runtime
Build-fix, had failed to add JSONObject.cpp/.h.
- 12:52 AM Changeset in webkit [45155] by
-
- 19 edits in branches/nitro-extreme
Merged r44700:44704 into nitro-extreme branch.
- 12:49 AM Changeset in webkit [45154] by
-
- 4 edits in branches/nitro-extreme/JavaScriptCore
Merged r44699:44700 into nitro-extreme branch.
- 12:45 AM Changeset in webkit [45153] by
-
- 2 edits in trunk/WebKitTools
2009-06-25 Eric Seidel <eric@webkit.org>
Reviewed by Tor Arne Vestbø.
Make svn-apply work with Git too
https://bugs.webkit.org/show_bug.cgi?id=26299
Add an --force option to svn-apply and otherwise make svn-apply
exit non-zero when patch application fails.
https://bugs.webkit.org/show_bug.cgi?id=26300
I did not update svn-unapply, because it makes no sense in a Git world.
You don't roll in and out patch files. You make commits and deal with those.
Git users can just git reset --hard to get the same functionality.
- Scripts/svn-apply:
- 12:42 AM Changeset in webkit [45152] by
-
- 3 edits in trunk/WebKitTools
2009-06-25 Eric Seidel <eric@webkit.org>
Reviewed by Tor Arne Vestbø.
Remove use of os.system to fix reviewers with unicode chars in their names
https://bugs.webkit.org/show_bug.cgi?id=26713
Also change to latin1 encoding of ø to make python happy.
- Scripts/modules/bugzilla.py:
- Scripts/modules/scm.py:
- 12:42 AM Changeset in webkit [45151] by
-
- 17 edits2 copies in branches/nitro-extreme
Merged r44693:44699 into nitro-extreme branch.
- 12:34 AM Changeset in webkit [45150] by
-
- 6 edits in branches/nitro-extreme/JavaScriptCore
Merged r44692:44693 into nitro-extreme branch.
- 12:22 AM Changeset in webkit [45149] by
-
- 319 edits140 copies39 deletes in branches/nitro-extreme
Merged r44526:44692 into nitro-extreme branch.
- 12:07 AM Changeset in webkit [45148] by
-
- 4 edits in branches/nitro-extreme/JavaScriptCore
Merged r44525:44526 into nitro-extreme branch.
- 12:06 AM Changeset in webkit [45147] by
-
- 2 edits in trunk/WebKitTools
2009-06-25 Eric Seidel <eric@webkit.org>
Reviewed by Tor Arne Vestbø.
Add Adam Roben and Tor Arne Vestbø to the reviewers list.
- Scripts/modules/bugzilla.py:
- 12:00 AM Changeset in webkit [45146] by
-
- 8 edits in branches/nitro-extreme
Merged r44523:44525 into nitro-extreme branch.
Jun 24, 2009:
- 11:56 PM Changeset in webkit [45145] by
-
- 8 edits in branches/nitro-extreme/JavaScriptCore
Merged r44520:44523 into nitro-extreme branch.
- 11:16 PM Changeset in webkit [45144] by
-
- 14 edits4 deletes in trunk/WebCore
2009-06-24 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Combined LocalStorageArea and SessionStorageArea into StorageArea since
(after my other refactorings) there are no longer substantial
differences between the two.
- GNUmakefile.am:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- storage/LocalStorage.cpp: (WebCore::LocalStorage::storageArea):
- storage/LocalStorage.h:
- storage/LocalStorageArea.cpp: Removed.
- storage/LocalStorageArea.h: Removed.
- storage/SessionStorage.cpp: (WebCore::SessionStorage::copy): (WebCore::SessionStorage::storageArea):
- storage/SessionStorage.h:
- storage/SessionStorageArea.cpp: Removed.
- storage/SessionStorageArea.h: Removed.
- storage/StorageArea.cpp: (WebCore::StorageArea::createLocalStorage): (WebCore::StorageArea::StorageArea): (WebCore::StorageArea::createSessionStorage): (WebCore::StorageArea::copy): (WebCore::StorageArea::setItem): (WebCore::StorageArea::removeItem): (WebCore::StorageArea::clear): (WebCore::StorageArea::scheduleFinalSync): (WebCore::StorageArea::blockUntilImportComplete): (WebCore::StorageArea::dispatchStorageEvent):
- storage/StorageArea.h:
- storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::StorageAreaSync): (WebCore::StorageAreaSync::scheduleFinalSync): (WebCore::StorageAreaSync::syncTimerFired): (WebCore::StorageAreaSync::performImport):
- storage/StorageAreaSync.h:
- storage/StorageSyncManager.h:
- 10:01 PM Changeset in webkit [45143] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Simon Fraser.
- fix <rdar://problem/7001817> REGRESSION (r41902): Base position track at UCSC Genome Browser doesn't work because image map prevents img from hit-testing
Test: fast/replaced/image-map-2.html
- rendering/RenderImage.cpp: (WebCore::RenderImage::nodeAtPoint): Do not reset 'inside' to false if the image map failed the hit test.
LayoutTests:
Reviewed by Simon Fraser.
- test for <rdar://problem/7001817> REGRESSION (r41902): Base position track at UCSC Genome Browser doesn't work because image map prevents img from hit-testing
- fast/replaced/image-map-2-expected.txt: Added.
- fast/replaced/image-map-2.html: Added.
- 8:41 PM Changeset in webkit [45142] by
-
- 34 edits11 copies6 deletes in branches/nitro-extreme
Merged r44514:44520 into nitro-extreme branch.
- 8:34 PM Changeset in webkit [45141] by
-
- 8 edits2 copies in branches/nitro-extreme/JavaScriptCore
Merged r44513:44514 into nitro-extreme branch.
- 8:30 PM Changeset in webkit [45140] by
-
- 53 edits8 copies3 deletes in branches/nitro-extreme
Merged r44492:44513 into nitro-extreme branch.
- 8:18 PM Changeset in webkit [45139] by
-
- 4 edits in branches/nitro-extreme/JavaScriptCore
Merged r44491:44492 into nitro-extreme branch.
- 8:07 PM Changeset in webkit [45138] by
-
- 3 edits in trunk/JavaScriptCore
2009-06-24 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Make the opcode sampler work once again.
- jit/JIT.h: (JSC::JIT::compileGetByIdProto): (JSC::JIT::compileGetByIdSelfList): (JSC::JIT::compileGetByIdProtoList): (JSC::JIT::compileGetByIdChainList): (JSC::JIT::compileGetByIdChain): (JSC::JIT::compilePutByIdTransition): (JSC::JIT::compileCTIMachineTrampolines): (JSC::JIT::compilePatchGetArrayLength):
- jit/JITStubCall.h: (JSC::JITStubCall::call):
- 8:06 PM Changeset in webkit [45137] by
-
- 80 edits4 copies1 delete in branches/nitro-extreme
Merged r44460:44491 into nitro-extreme branch.
- 8:00 PM Changeset in webkit [45136] by
-
- 12 edits in branches/nitro-extreme
Merged r44455:44460 into nitro-extreme branch.
- 7:56 PM Changeset in webkit [45135] by
-
- 13 edits in branches/nitro-extreme/JavaScriptCore
Merged r44454:44455 into nitro-extreme branch.
- 7:38 PM Changeset in webkit [45134] by
-
- 5 edits2 adds in trunk/WebCore
2009-06-22 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Refactor V8DOMMap to support isolated worlds.
- bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluateInNewWorld):
- bindings/v8/ScriptController.h:
- bindings/v8/V8DOMMap.cpp: (WebCore::DOMDataStore::InternalDOMWrapperMap::InternalDOMWrapperMap): (WebCore::DOMDataStore::allStores): (WebCore::DOMDataStore::allStoresMutex): (WebCore::DOMDataStore::domData): (WebCore::ScopedDOMDataStore::ScopedDOMDataStore): (WebCore::ScopedDOMDataStore::~ScopedDOMDataStore): (WebCore::StaticDOMDataStore::StaticDOMDataStore): (WebCore::): (WebCore::MainThreadDOMData::MainThreadDOMData): (WebCore::MainThreadDOMData::getStore): (WebCore::ChildThreadDOMData::ChildThreadDOMData): (WebCore::ChildThreadDOMData::getStore): (WebCore::DOMDataStore::DOMDataStore): (WebCore::DOMDataStore::~DOMDataStore): (WebCore::DOMDataStoreHandle::DOMDataStoreHandle): (WebCore::DOMDataStoreHandle::~DOMDataStoreHandle): (WebCore::::forget): (WebCore::getDOMNodeMap): (WebCore::getDOMObjectMap): (WebCore::getActiveDOMObjectMap): (WebCore::getDOMSVGElementInstanceMap): (WebCore::getDOMSVGObjectWithContextMap): (WebCore::DOMData::getCurrent): (WebCore::DOMData::handleWeakObject): (WebCore::DOMData::ensureDeref): (WebCore::weakDOMObjectCallback): (WebCore::weakActiveDOMObjectCallback): (WebCore::weakNodeCallback): (WebCore::weakSVGElementInstanceCallback): (WebCore::weakSVGObjectWithContextCallback): (WebCore::DOMData::derefObject): (WebCore::DOMData::derefDelayedObjects): (WebCore::DOMData::derefDelayedObjectsInCurrentThread): (WebCore::DOMData::removeObjectsFromWrapperMap): (WebCore::removeAllDOMObjectsInCurrentThreadHelper): (WebCore::visitDOMNodesInCurrentThread): (WebCore::visitDOMObjectsInCurrentThread): (WebCore::visitActiveDOMObjectsInCurrentThread): (WebCore::visitDOMSVGElementInstancesInCurrentThread): (WebCore::visitSVGObjectsInCurrentThread):
- bindings/v8/V8DOMMap.h: (WebCore::DOMDataStoreHandle::getStore):
- bindings/v8/V8IsolatedWorld.cpp: Added. (WebCore::getIsolatedWorldKey): (WebCore::contextWeakReferenceCallback): (WebCore::V8IsolatedWorld::evaluate): (WebCore::V8IsolatedWorld::V8IsolatedWorld): (WebCore::V8IsolatedWorld::~V8IsolatedWorld): (WebCore::V8IsolatedWorld::getEntered):
- bindings/v8/V8IsolatedWorld.h: Added. (WebCore::V8IsolatedWorld::getDOMDataStore):
- 7:06 PM Changeset in webkit [45133] by
-
- 4 edits in branches/WWDC-2009-branch
Versioning.
- 7:04 PM Changeset in webkit [45132] by
-
- 1 copy in tags/Safari-6530.19
New tag.
- 6:52 PM Changeset in webkit [45131] by
-
- 2 edits in trunk/WebCore
2009-06-24 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Timothy Hatcher.
Bug 26604: Search doesn't work in Web Inspector Profiler
https://bugs.webkit.org/show_bug.cgi?id=26604
Seems like search was damaged in revision 42808.
- inspector/front-end/ProfileView.js: (WebInspector.ProfileView.prototype.refresh): Here and in other functions: nodes we're searching in are profile data grid nodes, so there is no more need for '_dataGridNode' references. (WebInspector.ProfileView.prototype.searchCanceled): (WebInspector.ProfileView.prototype.performSearch.matchesQuery): Fixed accidental semicolon that caused 'matchesQuery' always return true. (WebInspector.ProfileView.prototype.performSearch): To perform search correctly in the case of bottom up tree, we need to populate the tree, because there's no 1-to-1 correspondence between profile nodes and data grid nodes in this case. (WebInspector.ProfileView.prototype._jumpToSearchResult):
- 6:32 PM Changeset in webkit [45130] by
-
- 5 edits in trunk/JavaScriptCore
2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Maciej Stachowiak.
Extend FastAllocBase.h with 'using WTF::FastAllocBase' to avoid
- unnecessary WTF
- usings.
- Remove existing unnecessary WTF
- usings.
- interpreter/Interpreter.h:
- profiler/CallIdentifier.h:
- runtime/ScopeChain.h:
- wtf/FastAllocBase.h:
- 6:07 PM Changeset in webkit [45129] by
-
- 2 edits in trunk/WebCore
2009-06-24 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
<rdar://problem/6450239&6574516>
Fix flashing issues caused by compositing layers rendering content before
a deferred layout has happened. Because the -viewWillDraw machinery doesn't
work for composited layers, we need to use scheduleViewUpdate() to queue
up a layout via the run loop observer in WebKit, whenever we know we
are going to be painting soon.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::setContentsNeedDisplay): (WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
- 5:45 PM Changeset in webkit [45128] by
-
- 5 edits1 add in trunk
2009-06-24 David Levin <levin@chromium.org>
Fix all builds.
- bytecode/CodeBlock.h:
- bytecompiler/BytecodeGenerator.h:
- interpreter/Register.h:
WebCore:
2009-06-24 David Levin <levin@chromium.org>
Fix all builds.
- ForwardingHeaders/wtf/FastAllocBase.h: Added.
- 5:42 PM Changeset in webkit [45127] by
-
- 4 edits in branches/WWDC-2009-branch
Versioning.
- 5:25 PM Changeset in webkit [45126] by
-
- 64 edits11 copies1 delete in branches/nitro-extreme
Merged r44437:44454 into nitro-extreme branch.
- 5:20 PM Changeset in webkit [45125] by
-
- 6 edits in branches/nitro-extreme/JavaScriptCore
Merged r44436:44437 into nitro-extreme branch.
- 4:56 PM Changeset in webkit [45124] by
-
- 16 edits2 copies in trunk/WebCore
2009-06-24 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
Split the syncing portions of LocalStorageArea into StorageAreaSync.
This name will make more sense in the next patch (in this set) when
LocalStorageArea and SessionStorageArea are merged to become simply
StorageArea. (Thus the synching portion of StorageArea is in
StorageAreaSync.)
This looks like a big patch, but really all it's doing is splitting
code and patching split-related things up.
- GNUmakefile.am:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- storage/LocalStorageArea.cpp: (WebCore::LocalStorageArea::create): (WebCore::LocalStorageArea::LocalStorageArea): (WebCore::LocalStorageArea::scheduleFinalSync): (WebCore::LocalStorageArea::itemChanged): (WebCore::LocalStorageArea::itemRemoved): (WebCore::LocalStorageArea::areaCleared): (WebCore::LocalStorageArea::blockUntilImportComplete):
- storage/LocalStorageArea.h:
- storage/LocalStorageTask.cpp: (WebCore::LocalStorageTask::LocalStorageTask):
- storage/LocalStorageTask.h: (WebCore::LocalStorageTask::createImport): (WebCore::LocalStorageTask::createSync):
- storage/LocalStorageThread.cpp: (WebCore::LocalStorageThread::scheduleImport): (WebCore::LocalStorageThread::scheduleSync):
- storage/LocalStorageThread.h:
- storage/SessionStorageArea.cpp: (WebCore::SessionStorageArea::blockUntilImportComplete):
- storage/SessionStorageArea.h:
- storage/StorageArea.h:
- storage/StorageAreaSync.cpp: Copied from WebCore/storage/LocalStorageArea.cpp.
- storage/StorageAreaSync.h: Copied from WebCore/storage/LocalStorageArea.h.
- storage/StorageSyncManager.cpp: (WebCore::StorageSyncManager::scheduleImport): (WebCore::StorageSyncManager::scheduleSync):
- storage/StorageSyncManager.h:
- 4:55 PM Changeset in webkit [45123] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Maciej Stachowiak.
Inherits CodeBlock class from FastAllocBase because it
has been instantiated by 'new' in JavaScriptCore/bytecode/CodeBlock.h:217.
- bytecode/CodeBlock.h:
- 4:55 PM Changeset in webkit [45122] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Maciej Stachowiak.
Inherits BytecodeGenerator class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/parser/Nodes.cpp:1892.
- bytecompiler/BytecodeGenerator.h:
- 4:54 PM Changeset in webkit [45121] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Maciej Stachowiak.
Inherits Register class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/JSVariableObject.h:149.
- interpreter/Register.h:
- 4:53 PM Changeset in webkit [45120] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Inherits HashMap class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/Structure.cpp:458.
- wtf/HashMap.h:
- 4:52 PM Changeset in webkit [45119] by
-
- 49 edits11 copies in branches/nitro-extreme
Merged r44412:44436 into nitro-extreme branch.
- 4:33 PM Changeset in webkit [45118] by
-
- 10 edits in branches/nitro-extreme/JavaScriptCore
Merged r44411:44412 into nitro-extreme branch.
- 4:32 PM Changeset in webkit [45117] by
-
- 2 edits in trunk/WebCore
2009-06-24 Adam Treat <adam.treat@torchmobile.com>
Fix Qt build.
- WebCore.pro:
- 4:23 PM Changeset in webkit [45116] by
-
- 5 edits in branches/WWDC-2009-branch/WebCore
Merge r44877.
- 4:23 PM Changeset in webkit [45115] by
-
- 3 edits in branches/WWDC-2009-branch/JavaScriptCore
Merge r44845.
- 4:23 PM Changeset in webkit [45114] by
-
- 11 edits in branches/WWDC-2009-branch/JavaScriptCore
Merge r44844.
- 4:23 PM Changeset in webkit [45113] by
-
- 2 edits in branches/WWDC-2009-branch/LayoutTests
Merge r44262.
- 4:00 PM Changeset in webkit [45112] by
-
- 2 edits in trunk/WebKitTools
Windows build fix for fallout from
Bug 26668: AX: need a way to retrieve the language for an element
- 3:47 PM Changeset in webkit [45111] by
-
- 3 edits in trunk/WebCore
2009-06-24 David Levin <levin@chromium.org>
Reviewed by David Hyatt.
Bug 26696: Member functions in DataGridColumnList should return pointers instead of PassRefPtr.
https://bugs.webkit.org/show_bug.cgi?id=26696
- html/DataGridColumnList.cpp: (WebCore::DataGridColumnList::itemWithName): (WebCore::DataGridColumnList::add):
- html/DataGridColumnList.h: (WebCore::DataGridColumnList::item): (WebCore::DataGridColumnList::primaryColumn): (WebCore::DataGridColumnList::sortColumn):
- 3:19 PM Changeset in webkit [45110] by
-
- 18 edits in trunk/WebCore
2009-06-24 Sam Weinig <sam@webkit.org>
Reviewed by Dave "Messy" Hyatt.
Little bit of style cleanup.
- html/DataGridColumn.cpp:
- html/DataGridColumn.h:
- html/DataGridColumn.idl:
- html/DataGridColumnList.cpp:
- html/DataGridColumnList.h:
- html/DataGridColumnList.idl:
- html/HTMLDataGridCellElement.cpp:
- html/HTMLDataGridCellElement.h:
- html/HTMLDataGridCellElement.idl:
- html/HTMLDataGridColElement.cpp:
- html/HTMLDataGridColElement.h:
- html/HTMLDataGridColElement.idl:
- html/HTMLDataGridElement.h:
- html/HTMLDataGridElement.idl:
- html/HTMLDataGridRowElement.cpp:
- html/HTMLDataGridRowElement.h:
- html/HTMLDataGridRowElement.idl:
- 3:14 PM Changeset in webkit [45109] by
-
- 11 edits2 adds in trunk
Bug 26668: AX: need a way to retrieve the language for an element
https://bugs.webkit.org/show_bug.cgi?id=26668
- 3:12 PM Changeset in webkit [45108] by
-
- 132 edits31 copies6 deletes in branches/nitro-extreme
Merged r44350:44411 into nitro-extreme branch.
- 3:04 PM Changeset in webkit [45107] by
-
- 2 edits in trunk/WebCore
2009-06-24 Brady Eidson <beidson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6893811> Instead of downloading files linked from Google Earth, file contents displayed in browser window as text.
- platform/network/mac/WebCoreURLResponse.mm: (createBinaryExtensionsSet): Add '.kmz' to the list of known-to-be-binary extensions.
- 3:01 PM Changeset in webkit [45106] by
-
- 6 edits3 adds in trunk
<rdar://problem/6940519> REGRESSION (Safari 4 Public Beta - TOT): google.com/adplanner shows blank page instead of site details in "basic research'
Reviewed by Darin Adler.
The problem was caused by the page returned with a function using a
var declaration list containing around ~3000 variables. The solution
to this is to flatten the comma expression representation and make
codegen comma expressions and initializer lists iterative rather than
recursive.
- 2:53 PM Changeset in webkit [45105] by
-
- 29 edits3 copies in branches/nitro-extreme
Merged r44340:44350 into nitro-extreme branch.
- 2:12 PM Changeset in webkit [45104] by
-
- 1 edit in trunk/WebKit/mac/ChangeLog
Rephrased change log
- 2:10 PM Changeset in webkit [45103] by
-
- 8 edits in trunk/WebCore
2009-06-24 Nicolas Weber <thakis@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26685
Accomodate for backwards-incompatible skia api changes.
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::setCompositeOperation):
- platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::ImageBuffer):
- platform/graphics/skia/ImageSkia.cpp: (WebCore::paintSkBitmap): (WebCore::Image::drawPattern):
- platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::State::State): (PlatformContextSkia::setupPaintCommon): (PlatformContextSkia::setXfermodeMode): (PlatformContextSkia::applyClipFromImage):
- platform/graphics/skia/PlatformContextSkia.h:
- platform/graphics/skia/SkiaUtils.cpp: (WebCore::): (WebCore::WebCoreCompositeToSkiaComposite):
- platform/graphics/skia/SkiaUtils.h:
- 2:05 PM Changeset in webkit [45102] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Anders Carlsson.
Fix the most recently seen kind of crash seen in
<rdar://problem/5983224>
- WebView/WebHTMLView.mm: (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Null-check the Frame.
- 2:01 PM Changeset in webkit [45101] by
-
- 1286 edits98 copies17 deletes in branches/nitro-extreme
Merged r44170:44340 into nitro-extreme branch.
- 1:51 PM Changeset in webkit [45100] by
-
- 2 edits in trunk/WebCore
2009-06-24 Jan Michael Alonzo <jmalonzo@webkit.org>
Gtk build fix. Add files that were added in r45093 and r45096
- GNUmakefile.am:
- 1:36 PM Changeset in webkit [45099] by
-
- 242 edits60 copies9 deletes in branches/nitro-extreme
Merged r44076:44170 into nitro-extreme branch.
- 1:33 PM Changeset in webkit [45098] by
-
- 2 edits in trunk/WebCore
2009-06-24 Brady Eidson <beidson@apple.com>
Fix 64-bit SnowLeopard build.
- html/DataGridColumnList.cpp: (WebCore::DataGridColumnList::remove): (WebCore::DataGridColumnList::move):
- 1:15 PM Changeset in webkit [45097] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-06-24 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Enable JIT_OPTIMIZE_METHOD_CALLS on the branch, implementation matches current implemenatation in ToT.
- jit/JIT.h:
- jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_method_check): (JSC::JIT::emitSlow_op_method_check): (JSC::JIT::emit_op_get_by_id): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::emitSlow_op_get_by_id): (JSC::JIT::compileGetByIdSlowCase):
- 1:06 PM Changeset in webkit [45096] by
-
- 1 add in trunk/WebCore/bindings/js/JSDataGridColumnListCustom.cpp
Fix Mac build.
- 12:44 PM Changeset in webkit [45095] by
-
- 3 edits12 adds in trunk
Reviewed by Niko.
https://bugs.webkit.org/show_bug.cgi?id=26392
Bug 26392: In html, modification of xlink:href of an newly inserted svg image does not work.
https://bugs.webkit.org/show_bug.cgi?id=26328
Bug 26328: changing href attribute of svg images dows not work when changing display attribute as well
React to href updates even when there is no renderer, i.e. display=none.
Tests: svg/custom/js-update-image-and-display.svg
svg/custom/js-update-image-and-display2.svg
svg/custom/js-update-image-and-display3.svg
- 12:41 PM Changeset in webkit [45094] by
-
- 2 edits5 adds in trunk/LayoutTests
Add Windows test results for a couple of search field tests
- 12:22 PM Changeset in webkit [45093] by
-
- 16 edits8 adds in trunk
WebCore:
2009-06-24 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig.
Add basic back-end column support to datagrid.
Added fast/dom/HTMLDataGridElement/ column tests.
- DerivedSources.cpp:
- DerivedSources.make:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- html/DataGridColumn.cpp: Added. (WebCore::DataGridColumn::setPrimary):
- html/DataGridColumn.h: Added. (WebCore::DataGridColumn::create): (WebCore::DataGridColumn::id): (WebCore::DataGridColumn::setId): (WebCore::DataGridColumn::label): (WebCore::DataGridColumn::setLabel): (WebCore::DataGridColumn::type): (WebCore::DataGridColumn::setType): (WebCore::DataGridColumn::sortable): (WebCore::DataGridColumn::setSortable): (WebCore::DataGridColumn::sortDirection): (WebCore::DataGridColumn::setSortDirection): (WebCore::DataGridColumn::primary): (WebCore::DataGridColumn::detachFromColumnList): (WebCore::DataGridColumn::DataGridColumn):
- html/DataGridColumn.idl: Added.
- html/DataGridColumnList.cpp: Added. (WebCore::DataGridColumnList::~DataGridColumnList): (WebCore::DataGridColumnList::itemWithName): (WebCore::DataGridColumnList::add): (WebCore::DataGridColumnList::remove): (WebCore::DataGridColumnList::move): (WebCore::DataGridColumnList::clear): (WebCore::DataGridColumnList::primaryColumnChanged):
- html/DataGridColumnList.h: Added. (WebCore::DataGridColumnList::create): (WebCore::DataGridColumnList::length): (WebCore::DataGridColumnList::item): (WebCore::DataGridColumnList::primaryColumn): (WebCore::DataGridColumnList::sortColumn):
- html/DataGridColumnList.idl: Added.
- html/HTMLDataGridColElement.cpp: (WebCore::HTMLDataGridColElement::sortable): (WebCore::HTMLDataGridColElement::setSortable): (WebCore::HTMLDataGridColElement::sortDirection): (WebCore::HTMLDataGridColElement::setSortDirection):
- html/HTMLDataGridColElement.h:
- html/HTMLDataGridColElement.idl:
- html/HTMLDataGridElement.cpp: (WebCore::HTMLDataGridElement::HTMLDataGridElement):
- html/HTMLDataGridElement.h: (WebCore::HTMLDataGridElement::columns):
- html/HTMLDataGridElement.idl:
- rendering/RenderDataGrid.cpp: (WebCore::RenderDataGrid::paintObject): (WebCore::RenderDataGrid::paintColumnHeaders): (WebCore::RenderDataGrid::rebuildColumns):
- rendering/RenderDataGrid.h: (WebCore::RenderDataGrid::gridElement):
LayoutTests:
2009-06-24 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig.
Add test for https://bugs.webkit.org/show_bug.cgi?id=26687.
- fast/dom/HTMLDataGridElement/DataGridColumns-basic-expected.txt: Added.
- fast/dom/HTMLDataGridElement/DataGridColumns-basic.html: Added.
- 12:14 PM Changeset in webkit [45092] by
-
- 2 edits in branches/WWDC-2009-branch/WebKit/mac
Merge r44951.
- 12:13 PM Changeset in webkit [45091] by
-
- 4 edits in branches/WWDC-2009-branch
Merge r44941.
- 12:13 PM Changeset in webkit [45090] by
-
- 8 edits3 adds in branches/WWDC-2009-branch
Merge r44940.
- 12:13 PM Changeset in webkit [45089] by
-
- 3 edits3 adds in branches/WWDC-2009-branch
Merge r44908.
- 12:13 PM Changeset in webkit [45088] by
-
- 6 edits in branches/WWDC-2009-branch
Merge r44906.
- 10:29 AM Changeset in webkit [45087] by
-
- 3 edits1 add in trunk/WebCore
2009-06-24 Jessie Berlin <jberlin@apple.com>
Reviewed by Adam Roben.
Partially fixes: https://bugs.webkit.org/show_bug.cgi?id=24735
(<rdar://problem/5015942>)
Where on windows it was not possible to set an element as the drag
image using setDragImage on the dataTransfer object.
Does not "fix" the case of dragging a link where the default link image
is still used, even when the -webkit-user-drag is set to "element". This
is the same behavior as is found on OS X.
Added a manual test because it is not possible to check that what is
contained in the image snapshot is indeed the requested element.
- dom/Clipboard.h: (WebCore::Clipboard::dragImageElement): Made getting the raw pointer from the RefPtr a const operation.
- manual-tests/drag-with-div-or-image-as-data-image.html: Added.
- platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::createDragImage): Get an image of the rendered element and its subtree.
- 9:48 AM Changeset in webkit [45086] by
-
- 2 edits1 add in trunk/WebCore
2009-06-24 Darin Fisher <darin@chromium.org>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=26683
Fix Chromium build bustage: Add custom binding for HTMLDataGridElement.dataSource
This change just adds a stub implementation for now to help fix the build.
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Added.
- 8:53 AM Changeset in webkit [45085] by
-
- 2 edits in trunk/WebCore
Build fixes for ENABLE(PLUGIN_PROXY_FOR_VIDEO)
Reviewed by Adam Roben.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::deliverNotification): Removed ExceptionCode parameter from togglePlayState(). (WebCore::HTMLMediaElement::initialURL): Don't convert a KURL object to a String when assigning to a KURL variable.
- 8:44 AM Moving to Git edited by
- (diff)
- 8:00 AM Changeset in webkit [45084] by
-
- 13 edits in trunk/WebCore
Reviewed by Adam Treat.
Save memory by not storing attribute values in member variables, if not absolutely needed.
Also fixes bugs where we're substituting variables too early (noticeable with the upcoming <select> element).
- 7:35 AM Changeset in webkit [45083] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam Roben.
Forgot to initialize m_task member variable. Results in crashes sometimes.
- 7:34 AM Changeset in webkit [45082] by
-
- 1 edit1 add in trunk/WebCore
Not reviewed. Forgot to include within last patch.
- 7:30 AM Changeset in webkit [45081] by
-
- 5 edits in trunk/WebCore
Reviewed by Nikolas Zimmermann.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=26474
Adding WML <card> title attribute handling.
- 7:02 AM Changeset in webkit [45080] by
-
- 3 edits in trunk/WebKit/gtk
2009-06-24 Jiahua Huang <jhuangjiahua@gmail.com>
Reviewed by Holger Freyther.
[Gtk] Add Undo/Redo support to WebKitGtk
https://bugs.webkit.org/show_bug.cgi?id=26573
Implement EditorClient::undo and other interested funcs.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::registerCommandForUndo): (WebKit::EditorClient::registerCommandForRedo): (WebKit::EditorClient::clearUndoRedoOperations): (WebKit::EditorClient::canUndo): (WebKit::EditorClient::canRedo): (WebKit::EditorClient::undo): (WebKit::EditorClient::redo): (WebKit::EditorClient::EditorClient):
- WebCoreSupport/EditorClientGtk.h:
- 3:00 AM Changeset in webkit [45079] by
-
- 3 edits in trunk/WebCore
2009-06-24 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Fix the build without ENABLE_VIDEO.
- html/CanvasRenderingContext2D.cpp: Add #if ENABLE guards.
- html/CanvasRenderingContext2D.h: Ditto.
- 2:26 AM Changeset in webkit [45078] by
-
- 1 edit1 move in trunk/LayoutTests
Temporarily disable failing test
- 1:56 AM Changeset in webkit [45077] by
-
- 4 edits in trunk/LayoutTests
2009-06-24 Eric Seidel <eric@webkit.org>
Reviewed by Mark Rowe.
Add new drag tests to the Skipped lists for non-mac platforms.
Skipped tests:
fast/events/drag-to-navigate.html
fast/events/prevent-drag-to-navigate.html
- platform/gtk/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 1:15 AM Changeset in webkit [45076] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Maciej Stachowiak.
Inherits ScopeChainNode class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/ScopeChain.h:95.
- wtf/RefPtr.h:
- 1:12 AM Changeset in webkit [45075] by
-
- 2 edits1 add in trunk/WebCore
2009-06-24 Siddhartha Chattopadhyay <sidchat@google.com>
Reviewed by Eric Seidel.
Fix for https://bugs.webkit.org/show_bug.cgi?id=26200 which I introduced earlier. I had
the smartReplace set TRUE initially, which was wrong since the purpose of this call is
to just replace the selection, and place the caret at the end of the selection it replaced.
- editing/Editor.cpp: (WebCore::Editor::markMisspellingsAfterTypingToPosition):
- manual-tests/textarea-caret-position-after-auto-spell-correct.html: Added.
- 1:00 AM Changeset in webkit [45074] by
-
- 2 edits in trunk/WebKit/mac
2009-06-24 Jeff Johnson <opendarwin@lapcatsoftware.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=26638 WebKitErrors.m: _initWithPluginErrorCode: does not set localizedDescription
Add localized descriptions for plugin errors.
The localized strings already existed but were unused; now NSLocalizedDescriptionKey is added to the NSError userInfo.
- Misc/WebKitErrors.m: (-[NSError _initWithPluginErrorCode:contentURL:pluginPageURL:pluginName:MIMEType:]):
- 12:54 AM Changeset in webkit [45073] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Inherits Deque class from FastAllocBase because it has been
instantiated by 'new' with DEFINE_STATIC_LOCAL macro in
JavaScriptCore/wtf/MainThread.cpp:62.
- wtf/Deque.h:
- 12:53 AM Changeset in webkit [45072] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Inherits RefPtr class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/StructureChain.cpp:41.
- wtf/RefPtr.h:
- 12:52 AM Changeset in webkit [45071] by
-
- 2 edits in trunk/LayoutTests
Attempting to make test more reliable.
- 12:47 AM Changeset in webkit [45070] by
-
- 2 edits in trunk/WebCore
2009-06-24 Kevin Watters <kevinwatters@gmail.com>
Reviewed by Kevin Ollivier.
Don't use an unsigned int for intervalInMS because we sometimes initialize
it with a negative value.
- platform/wx/SharedTimerWx.cpp: (WebCore::setSharedTimerFireTime):
- 12:45 AM Changeset in webkit [45069] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Inherits HashSet class from FastAllocBase, because it has been
instantiated by 'new' in JavaScriptCore/runtime/Collector.h:116.
- wtf/HashSet.h:
- 12:40 AM Changeset in webkit [45068] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Inherits Vector class from FastAllocBase because it has been
instantiated by 'new' in JavaScriptCore/runtime/Structure.cpp:633.
- wtf/Vector.h:
- 12:34 AM Changeset in webkit [45067] by
-
- 2 edits in trunk/WebKitTools
2009-06-24 Eric Seidel <eric@webkit.org>
Reviewed by Maciej Stachowiak.
Spell Maciej's name right and add Brady Eidson.
- Scripts/modules/bugzilla.py:
- 12:26 AM Changeset in webkit [45066] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-24 Norbert Leser <norbert.leser@nokia.com>
Reviewed by Maciej Stachoviak.
The BytecodeGenerator objects were instantiated on stack, which takes up ~38kB per instance
(each instance includes copy of JSC::CodeBlock with large SymbolTable, etc.).
Specifically, since there is nested invocation (e.g., GlobalCode --> FunctionCode),
the stack overflows immediately on Symbian hardware (max. 80 kB).
Proposed change allocates generator objects on heap.
Performance impact (if any) should be negligible and change is proposed as general fix,
rather than ifdef'd for SYMBIAN.
- parser/Nodes.cpp: (JSC::ProgramNode::generateBytecode): (JSC::EvalNode::generateBytecode): (JSC::EvalNode::bytecodeForExceptionInfoReparse): (JSC::FunctionBodyNode::generateBytecode): (JSC::FunctionBodyNode::bytecodeForExceptionInfoReparse):
- 12:20 AM Changeset in webkit [45065] by
-
- 2 edits in trunk/WebCore
2009-06-24 Eric Seidel <eric@webkit.org>
No review, build fix only.
The previous checkin had an improper merge. This fixes the build.
- page/DragController.cpp: (WebCore::DragController::tryDocumentDrag):
- 12:07 AM Changeset in webkit [45064] by
-
- 4 edits6 adds in trunk
2009-06-05 Eric Seidel <eric@webkit.org>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=25922
Fix dropEffect = "none" to work as expected.
- fast/events/drag-to-navigate-expected.txt: Copied from LayoutTests/editing/selection/doubleclick-whitespace-img-crash-expected.txt.
- fast/events/drag-to-navigate.html: Added.
- fast/events/prevent-drag-to-navigate-expected.txt: Copied from LayoutTests/editing/selection/doubleclick-whitespace-img-crash-expected.txt.
- fast/events/prevent-drag-to-navigate.html: Added.
- fast/events/resources/file-for-drag-to-navigate.html: Added.
- fast/events/resources/file-for-prevent-drag-to-navigate.html: Added.
2009-06-05 Eric Seidel <eric@webkit.org>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=25922
JS setting dropEffect = "none" causes tryDHTMLDrag
to return DragOperationNone. Which is also the value
tryDHTMLDrag previously used to indicate JS did not
want to handle the drag.
Make it possible for the DragController::try* methods
to return a bool to indicate if javascript accepted
or rejected the drag event, separate from the DragOperation.
Tests:
- fast/events/drag-to-navigate.html
- fast/events/prevent-drag-to-navigate.html
- page/DragController.cpp: (WebCore::DragController::dragEnteredOrUpdated): (WebCore::DragController::tryDocumentDrag): (WebCore::defaultOperationForDrag): (WebCore::DragController::tryDHTMLDrag):
- page/DragController.h:
Jun 23, 2009:
- 11:40 PM Changeset in webkit [45063] by
-
- 1 edit1 add in trunk/LayoutTests
Add expected results for test i landed earlier
- 11:26 PM Changeset in webkit [45062] by
-
- 3 edits in trunk/WebKitTools
2009-06-23 Eric Seidel <eric@webkit.org>
Reviewed by Dave Levin.
Fix missing comment message during land-patches and SVN.commit_with_message respecting --dry-run
https://bugs.webkit.org/show_bug.cgi?id=26669
- Scripts/bugzilla-tool:
- Scripts/modules/scm.py:
- 11:25 PM Changeset in webkit [45061] by
-
- 29 edits in branches/nitro-extreme/JavaScriptCore
Merged r44075:44076 into nitro-extreme branch. (Adds infrastructure for op_method_check, but does not implement optimization.)
- 11:19 PM Changeset in webkit [45060] by
-
- 15 edits2 adds in trunk
<rdar://problem/6164797> Add Canvas API to allow drawing of <video> frames
<https://bugs.webkit.org/show_bug.cgi?id=25920>
Reviewed by Sam Weinig and Dave Hyatt.
Add support for drawing the contents of the video element to the canvas
in accordance with the current HTML5 draft.
Test: media/video-canvas.html
- 10:55 PM Changeset in webkit [45059] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-06-23 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Bit off a tiny bit more of standardizing opcode behavior to help with result
caching.
SunSpider reports no change, v8 maybe a tiny speedup.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_to_jsnumber): (JSC::JIT::emitSlow_op_to_jsnumber): (JSC::JIT::emit_op_convert_this): (JSC::JIT::emitSlow_op_convert_this):
- 10:37 PM Changeset in webkit [45058] by
-
- 90 edits9 copies2 deletes in branches/nitro-extreme
Merged r44030:44075 into nitro-extreme branch.
- 10:31 PM Changeset in webkit [45057] by
-
- 12 edits in branches/nitro-extreme/JavaScriptCore
2009-06-23 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Bit off a tiny bit more of standardizing opcode behavior to help with result
caching -- including removing my old enemy, op_resolve_function, because
it was non-standard, and removing it felt better than helping it limp along.
SunSpider reports no change, v8 maybe a tiny speedup.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
- bytecode/Opcode.h:
- bytecompiler/BytecodeGenerator.cpp:
- bytecompiler/BytecodeGenerator.h:
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_get_scoped_var): (JSC::JIT::emit_op_put_scoped_var): (JSC::JIT::emit_op_to_primitive): (JSC::JIT::emitSlow_op_to_primitive):
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- parser/Nodes.cpp: (JSC::FunctionCallResolveNode::emitBytecode):
- 10:16 PM Changeset in webkit [45056] by
-
- 17 edits1 copy in branches/nitro-extreme/JavaScriptCore
Merged r44029:44030 into nitro-extreme branch.
- 9:56 PM Changeset in webkit [45055] by
-
- 18 edits8 copies in branches/nitro-extreme
Merged r44000:44029 into nitro-extreme branch.
- 9:41 PM Changeset in webkit [45054] by
-
- 192 edits51 copies6 deletes in branches/nitro-extreme
Merged r43853:44000 into nitro-extreme branch.
- 9:33 PM Changeset in webkit [45053] by
-
- 9 edits18 copies in branches/nitro-extreme
Merged r43848:43853 into nitro-extreme branch.
- 9:26 PM Changeset in webkit [45052] by
-
- 203 edits84 copies47 deletes in branches/nitro-extreme
Merged r43781:43848 into nitro-extreme branch.
- 9:19 PM Changeset in webkit [45051] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-06-23 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Bit off a tiny bit of standardizing opcode behavior to help with result
caching.
0.6% SunSpider speedup. 0.3% v8 speedup.
- jit/JITInlineMethods.h: (JSC::JIT::emitLoad): Accomodate a base register that overlaps with payload by loading tag before payload, to avoid stomping base/payload.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_mov): Abide by the standard "tag in regT1, payload in regT0" semantics.
(JSC::JIT::emit_op_get_global_var):
(JSC::JIT::emit_op_put_global_var): Ditto. Also, removed some irrelevent
loads while I was at it. The global object's "d" pointer never changes
after construction.
- 9:16 PM Changeset in webkit [45050] by
-
- 10 edits in branches/nitro-extreme/JavaScriptCore
Merged r43780:43781 into nitro-extreme branch.
- 8:13 PM Changeset in webkit [45049] by
-
- 72 edits8 copies in branches/nitro-extreme
Merged r43750:43780 into nitro-extreme branch.
- 8:11 PM Changeset in webkit [45048] by
-
- 3 edits2 adds in branches/WWDC-2009-branch
Merge r44799.
- 8:11 PM Changeset in webkit [45047] by
-
- 14 edits in branches/WWDC-2009-branch/WebCore
Merge r44749.
- 8:11 PM Changeset in webkit [45046] by
-
- 15 edits4 adds in branches/WWDC-2009-branch
Merge r44519.
- 8:11 PM Changeset in webkit [45045] by
-
- 13 edits in branches/WWDC-2009-branch/WebCore
Merge r44266.
- 8:11 PM Changeset in webkit [45044] by
-
- 2 edits in branches/WWDC-2009-branch/LayoutTests/http/tests/security/postMessage
Merge r44134.
- 8:11 PM Changeset in webkit [45043] by
-
- 4 edits1 add in branches/WWDC-2009-branch/LayoutTests
Merge r44133.
- 8:11 PM Changeset in webkit [45042] by
-
- 1 edit in branches/WWDC-2009-branch/WebCore/ChangeLog
Merge r44125.
- 8:11 PM Changeset in webkit [45041] by
-
- 4 edits3 adds in branches/WWDC-2009-branch
Merge r44124.
- 7:59 PM Changeset in webkit [45040] by
-
- 167 edits73 copies97 deletes in branches/nitro-extreme
Merged r43666:43750 into nitro-extreme branch.
- 7:47 PM Changeset in webkit [45039] by
-
- 7 edits2 adds in trunk
<rdar://problem/6992806> REGRESSION: Enumeration can skip new properties in cases of prototypes that have more than 64 (26593)
<https://bugs.webkit.org/show_bug.cgi?id=26593>
Reviewed by Gavin Barraclough.
Add tests to ensure we correctly invalidate caching that depends on structure chains
that include dictionaries.
- 7:45 PM WikiStart edited by
- (diff)
- 7:41 PM Changeset in webkit [45038] by
-
- 3 edits in trunk/WebCore
2009-06-23 Adam Langley <agl@google.com>
Reviewed by Eric Seidel.
Chromium: Fix crash with inherited font-size in <option>
https://bugs.webkit.org/show_bug.cgi?id=26656
http://code.google.com/p/chromium/issues/detail?id=14853
In r42597 (https://bugs.webkit.org/show_bug.cgi?id=25244), I changed
the <select> handing for Chromium to fix a rendering bug. However,
although the font-size is correctly ignored, getRowHeight wasn't
updated and so was calculating the height of the rows in an
inconsistent manner. This can lead to a crash.
- manual-tests/optgroup-empty-and-nested.html: adding test case for crash
- platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupListBox::getRowHeight):
- 7:38 PM WikiStart edited by
- Add maxthon's port. (diff)
- 7:37 PM Changeset in webkit [45037] by
-
- 85 edits13 copies1 delete in branches/nitro-extreme
Merged r43660:43666 into nitro-extreme branch.
- 7:18 PM Changeset in webkit [45036] by
-
- 27 edits15 copies in branches/nitro-extreme
Merged r43642:43660 into nitro-extreme branch.
- 7:13 PM Changeset in webkit [45035] by
-
- 43 edits in branches/nitro-extreme
Merged r43641:43642 into nitro-extreme branch.
- 7:08 PM Changeset in webkit [45034] by
-
- 47 edits6 copies in branches/nitro-extreme
Merged r43619:43641 into nitro-extreme branch.
- 7:02 PM Changeset in webkit [45033] by
-
- 14 edits in branches/nitro-extreme/JavaScriptCore
Merged r43618:43619 into nitro-extreme branch.
- 6:50 PM Changeset in webkit [45032] by
-
- 2 edits in trunk/WebKitTools
2009-06-23 Takeshi Yoshino <tyoshino@google.com>
Reviewed by Mark Rowe.
Bug 26537: Builds from command-line fail if custom build product directory is set and ~/Library/Preferences/xcodebuild.plist exists
https://bugs.webkit.org/show_bug.cgi?id=26537
Let determineBaseProductDir subroutine remove
~/Library/Preferences/xcodebuild.plist. It can prevent xcodebuild from
respecting global settings such as a custom build products directory
(<rdar://problem/5585899>).
- Scripts/webkitdirs.pm:
- 6:49 PM Changeset in webkit [45031] by
-
- 2 edits in trunk/WebCore
2009-06-23 Brady Eidson <beidson@apple.com>
Patch by Antti Koivisto.
Reviewed by Brady Eidson.
<rdar://problem/6988010> Failed resources not reloaded when built against Tiger SDK
A latent bug that cache revalidation uncovered. When a CachedResource failed to load,
it should always be revalidated upon reload.
- loader/CachedResource.cpp: (WebCore::CachedResource::canUseCacheValidator): (WebCore::CachedResource::mustRevalidate):
- 6:45 PM Changeset in webkit [45030] by
-
- 25 edits13 copies in branches/nitro-extreme
Merged r43598:43618 into nitro-extreme branch.
- 6:40 PM Changeset in webkit [45029] by
-
- 32 edits21 copies2 deletes in branches/nitro-extreme
Merged r43583:43598 into nitro-extreme branch.
- 6:36 PM Changeset in webkit [45028] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
Merged r43582:43583 into nitro-extreme branch.
- 6:33 PM Changeset in webkit [45027] by
-
- 2 edits in trunk/LayoutTests
2009-06-23 Ojan Vafai <ojan@chromium.org>
Reviewed by Mark Rowe.
Resets the results for a test that was missed in
http://trac.webkit.org/changeset/45016.
- editing/execCommand/5142012-3-expected.txt:
- 6:31 PM Changeset in webkit [45026] by
-
- 3 edits in trunk/WebKitTools
2009-06-23 Eric Seidel <eric@webkit.org>
Reviewed by Dave Levin.
Make SCM.run_command smarter, and make all previous
os.system and subprocess.popen use SCM.run_command instead.
https://bugs.webkit.org/show_bug.cgi?id=26666
This makes it easier to handle errors in a standard way throughout all the code.
Since this new code raises by default when the exit_code != 0,
we should prevent future problems of bugzilla-tool continuing after
a git or svn command failed.
- Scripts/modules/scm.py:
- 6:29 PM Changeset in webkit [45025] by
-
- 21 edits4 copies in branches/nitro-extreme
Merged r43560:43582 into nitro-extreme branch.
- 6:14 PM Changeset in webkit [45024] by
-
- 8 edits in branches/nitro-extreme
Merged r43559:43560 into nitro-extreme branch.
- 6:00 PM Changeset in webkit [45023] by
-
- 4 edits in branches/WWDC-2009-branch
Versioning.
- 5:57 PM Changeset in webkit [45022] by
-
- 1 edit in branches/WWDC-2009-branch/WebKitLibraries/win/tools/scripts/PRODUCTVERSION
Versioning.
- 5:44 PM Changeset in webkit [45021] by
-
- 2 edits in trunk/WebKit/mac
2009-06-23 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6950660> REGRESSION: iSale 5.5.3 crashes after I click a template to load
Due to some subtle WebKit changes - presumably some delegate callback behavior - a latent bug in
iSale was uncovered where they aren't properly retaining their FrameLoadDelegate, and we ended up
calling back to a dealloc'ed object.
- WebView/WebView.mm: (-[WebView _needsAdobeFrameReloadingQuirk]): Use more intelligent C++-style initialization. (-[WebView _needsKeyboardEventDisambiguationQuirks]): Ditto. (-[WebView _needsFrameLoadDelegateRetainQuirk]): YES for iSale versions under 5.6 (-[WebView dealloc]): Release the delegate if the quirk is in effect. (-[WebView setFrameLoadDelegate:]): Retain the new delegate if the quirk is in effect.
- 5:41 PM Changeset in webkit [45020] by
-
- 11 edits in branches/nitro-extreme/JavaScriptCore
Merged r43558:43559 into nitro-extreme branch.
- 5:40 PM Changeset in webkit [45019] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
- fix <rdar://problem/6634228> Crash in [NSScroller mouseDown:] beneath EventHandler::passMouseDownEventToWidget()
- page/mac/EventHandlerMac.mm: (WebCore::EventHandler::passMouseDownEventToWidget): Surround the -mouseDown: call with calls to Widget::beforeMouseDown() and Widget::afterMouseDown(), which prevent the widget's view hierarchy from being removed from its parent view while the scroller is tracking the mouse.
- 5:39 PM Changeset in webkit [45018] by
-
- 10 edits7 adds in trunk
WebCore:
2009-06-23 Sam Weinig <sam@webkit.org>
Reviewed by Dave Hyatt.
Fix for https://bugs.webkit.org/show_bug.cgi?id=26516
Add initial implementation of DataGridDataSource
- Initial implementation only supports the initialize callback function.
Test: fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html
- WebCore.xcodeproj/project.pbxproj:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/JSDataGridDataSource.cpp: Added. (WebCore::JSDataGridDataSource::JSDataGridDataSource): (WebCore::JSDataGridDataSource::~JSDataGridDataSource): (WebCore::JSDataGridDataSource::initialize):
- bindings/js/JSDataGridDataSource.h: Added. (WebCore::JSDataGridDataSource::create): (WebCore::JSDataGridDataSource::isJSDataGridDataSource): (WebCore::JSDataGridDataSource::jsDataSource): (WebCore::asJSDataGridDataSource):
- bindings/js/JSHTMLDataGridElementCustom.cpp: Added. (WebCore::JSHTMLDataGridElement::listener): (WebCore::JSHTMLDataGridElement::setListener):
- html/DataGridDataSource.h: Added. (WebCore::DataGridDataSource::~DataGridDataSource): (WebCore::DataGridDataSource::isJSDataGridDataSource):
- html/HTMLDataGridElement.cpp: (WebCore::HTMLDataGridElement::HTMLDataGridElement): (WebCore::HTMLDataGridElement::setDataSource): (WebCore::HTMLDataGridElement::initializationTimerFired):
- html/HTMLDataGridElement.h: (WebCore::HTMLDataGridElement::dataSource):
- html/HTMLDataGridElement.idl:
LayoutTests:
2009-06-23 Sam Weinig <sam@webkit.org>
Reviewed by Dave Hyatt.
Test for https://bugs.webkit.org/show_bug.cgi?id=26516
Add initial implementation of DataGridDataSource
- fast/dom/HTMLDataGridElement: Added.
- fast/dom/HTMLDataGridElement/DataGridDataSource-basic-expected.txt: Added.
- fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html: Added.
- 5:09 PM Changeset in webkit [45017] by
-
- 8 edits in branches/nitro-extreme/JavaScriptCore
2009-06-23 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Remove 'arguments' field from Register union (again).
This time do so without breaking tests (radical, I know).
- interpreter/CallFrame.h: (JSC::ExecState::optionalCalleeArguments): (JSC::ExecState::setArgumentCount): (JSC::ExecState::init):
- interpreter/Interpreter.cpp: (JSC::Interpreter::dumpRegisters): (JSC::Interpreter::unwindCallFrame): (JSC::Interpreter::privateExecute): (JSC::Interpreter::retrieveArguments):
- interpreter/Register.h: (JSC::Register::withInt): (JSC::Register::): (JSC::Register::Register): (JSC::Register::i):
- jit/JITStubs.cpp: (JSC::JITStubs::cti_op_tear_off_arguments):
- runtime/Arguments.h: (JSC::JSActivation::copyRegisters): (JSC::Register::arguments):
- runtime/JSActivation.cpp: (JSC::JSActivation::argumentsGetter):
- runtime/JSActivation.h:
- 4:56 PM Changeset in webkit [45016] by
-
- 20 edits2 adds in trunk
WebCore:
2009-06-23 Ryosuke Niwa <rniwa@google.com>
Reviewed by Justin Garcia.
Undo the changeset 21212 to fix the regression bug 14062.
The changeset 21212 attempted to fix rdar://problem/5002441.
The changeset 21212 modified InsertTextCommand::input so as to convert
all spaces in text to non-breaking spaces for rdar://problem/5002441.
However, the bug was originally caused by rebalanceWhitespaceAt
and this workaround introduced a regression bug 14062.
Because rebalanceWhitespaceAt appears to behave correctly now,
the workaround introduced in 21212 is no longer needed.
Test: editing/inserting/space-after-removeformat.html
- editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input):
LayoutTests:
2009-06-23 Ryosuke Niwa <rniwa@google.com>
Reviewed by Justin Garcia.
Undo the changeset 21212 to fix the regression bug 14062.
The changeset 21212 attempted to fix rdar://problem/5002441.
The changeset 21212 modified InsertTextCommand::input so as to convert
all spaces in text to non-breaking spaces for rdar://problem/5002441.
However, the bug was originally caused by rebalanceWhitespaceAt
and this workaround introduced a regression bug 14062.
Because rebalanceWhitespaceAt appears to behave correctly now,
the workaround introduced in 21212 is no longer needed.
The following test cases are affected by this change.
This patch removes unappropriate non-breaking spaces ( ) and
inserts normal spaces instead.
- editing/deleting/2610675-1-expected.txt: Replaced.
- editing/deleting/2610675-2-expected.txt: Replaced.
- editing/deleting/2610675-3-expected.txt: Replaced.
- editing/inserting/insert-before-link-1-expected.txt: Replaced.
- editing/inserting/space-after-removeformat-expected.txt: Added.
- editing/inserting/space-after-removeformat.html: Added.
- platform/mac/editing/execCommand/5482023-expected.checksum: Replaced.
- platform/mac/editing/execCommand/5482023-expected.png: Replaced.
- platform/mac/editing/execCommand/5482023-expected.txt: Replaced.
- platform/mac/editing/input/text-input-controller-expected.txt: Replaced.
- platform/mac/editing/inserting/editable-html-element-expected.checksum: Replaced.
- platform/mac/editing/inserting/editable-html-element-expected.png: Replaced.
- platform/mac/editing/inserting/editable-html-element-expected.txt: Replaced.
- platform/mac/editing/pasteboard/4989774-expected.checksum: Replaced.
- platform/mac/editing/pasteboard/4989774-expected.png: Replaced.
- platform/mac/editing/pasteboard/4989774-expected.txt: Replaced.
- platform/mac/editing/selection/4983858-expected.checksum: Replaced.
- platform/mac/editing/selection/4983858-expected.png: Replaced.
- platform/mac/editing/selection/4983858-expected.txt: Replaced.
- 4:42 PM Changeset in webkit [45015] by
-
- 8 edits6 adds in trunk
WebCore:
2009-06-23 Beth Dakin <Beth Dakin>
Reviewed by Dave Hyatt.
Fix for https://bugs.webkit.org/show_bug.cgi?id=26523 <col>
elements width can't be changed with javascript
This patch both fixes setting the width attribute directly in
JavaScript, and setting the width on the style attribute.
- html/HTMLTableColElement.cpp: (WebCore::HTMLTableColElement::parseMappedAttribute): If we have a new width, call setNeedsLayoutAndPrefWidthsRecalc()
Call calcPrefWidths() on the table cols.
- rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn):
- rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray):
Call layoutIfNeeded on the table cols.
- rendering/RenderTable.cpp: (WebCore::RenderTable::layout):
- rendering/RenderTableCol.cpp: (WebCore::RenderTableCol::clippedOverflowRectForRepaint): Use new table() convenience function. (WebCore::RenderTableCol::calcPrefWidths): Just call setPrefWidthsDirty(false) on ourself and our children. (WebCore::RenderTableCol::table):
- rendering/RenderTableCol.h:
LayoutTests:
2009-06-23 Beth Dakin <Beth Dakin>
Reviewed by Dave Hyatt.
Test for https://bugs.webkit.org/show_bug.cgi?id=26523 <col>
elements width can't be changed with javascript
- fast/dom/HTMLTableColElement: Added.
- fast/dom/HTMLTableColElement/resize-table-using-col-width.html: Added.
- platform/mac/fast/dom/HTMLTableColElement: Added.
- platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.checksum: Added.
- platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png: Added.
- platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt: Added.
- 4:35 PM Changeset in webkit [45014] by
-
- 8 edits5 adds in trunk
WebCore:
2009-06-23 Ojan Vafai <ojan@chromium.org>
Reviewed by Dan Bernstein.
Add logic to CSSStyleDeclaration::diff to deal with font-sizes that are
keyword values. When diff is called on a CSSStyleDeclaration, we check
the keywordSize to see if font-size matches a keyword value.
This ensures that when we diff a CSSMutableStyleDeclaration returned from
copyInheritableProperties on a CSSComputedStyleDeclaration that we
correctly identify matching font-sizes.
Test: editing/inserting/font-size-clears-from-typing-style.html
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::cssPropertyMatches):
- css/CSSComputedStyleDeclaration.h:
- css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::cssPropertyMatches): (WebCore::CSSStyleDeclaration::diff):
- css/CSSStyleDeclaration.h:
LayoutTests:
2009-06-23 Ojan Vafai <ojan@chromium.org>
Reviewed by Dan Bernstein.
This test hits an edge case where typingStyle would never get cleared.
In addition to making every text insertion go into its own text node,
this caused large performance problems.
- editing/execCommand/5770834-1-expected.txt:
These results match how they were before r43243. It's not clear to me
why changes to font-size are affecting text-align styling though.
- editing/inserting/font-size-clears-from-typing-style-expected.txt: Added.
- editing/inserting/font-size-clears-from-typing-style.html: Added.
- editing/inserting/resources/TEMPLATE.html: Copied from LayoutTests/editing/execCommand/resources/TEMPLATE.html.
- editing/inserting/resources/font-size-clears-from-typing-style.js: Added.
- platform/mac/editing/execCommand/remove-formatting-2-expected.txt:
- 4:18 PM Changeset in webkit [45013] by
-
- 9 edits in branches/nitro-extreme/JavaScriptCore
2009-06-23 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Removed some result register tracking cruft in preparation for a new
result tracking mechanism.
SunSpider reports no change.
- assembler/AbstractMacroAssembler.h:
- assembler/X86Assembler.h: (JSC::X86Assembler::JmpDst::JmpDst): No need to track jump targets in machine code; we already do this in bytecode.
- jit/JIT.cpp: (JSC::JIT::JIT): (JSC::JIT::emitTimeoutCheck): Make sure to save and restore the result registers, so an opcode with a timeout check can still benefit from result register caching.
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases): Removed calls to killLastResultRegister()
in preparation for something new.
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_jnless): (JSC::JIT::emit_op_jnlesseq):
- jit/JITInlineMethods.h: (JSC::JIT::emitGetFromCallFrameHeaderPtr): (JSC::JIT::emitGetFromCallFrameHeader32):
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_jmp): (JSC::JIT::emit_op_jfalse): (JSC::JIT::emit_op_jtrue): (JSC::JIT::emit_op_jeq_null): (JSC::JIT::emit_op_jneq_null): (JSC::JIT::emit_op_jneq_ptr): (JSC::JIT::emit_op_jsr): (JSC::JIT::emit_op_sret): (JSC::JIT::emit_op_jmp_scopes): ditto
- jit/JITStubCall.h: (JSC::JITStubCall::JITStubCall): (JSC::JITStubCall::getArgument): added a mechanism for reloading an argument you passed to a JIT stub, for use in emitTimeoutCheck.
- 4:10 PM Changeset in webkit [45012] by
-
- 2 edits in trunk/WebKitTools
2009-06-23 Joe Mason <joe.mason@torchmobile.com>
Reviewed by Adam Treat.
- Scripts/prepare-ChangeLog: Added --git-index mode to list only the changes which are already staged in the index. Useful to create an entry for what you're about to commit while ignoring unstaged changes.
- 4:06 PM Changeset in webkit [45011] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-23 Yong Li <yong.li@torchmobile.com>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=26654
Add the proper export define for the JavaScriptCore API when building for WINCE.
- 3:38 PM Changeset in webkit [45010] by
-
- 3 edits in trunk/WebKit/mac
2009-06-23 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
- Fix <rdar://problem/6965672>
Defer calls to WKPCInvalidateRect, so we don't try to invalidate while waiting for a reply, since
that is too early.
- Plugins/Hosted/NetscapePluginHostProxy.h: (WebKit::NetscapePluginHostProxy::isProcessingRequests):
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): (WebKit::NetscapePluginHostProxy::processRequests): (WKPCInvalidateRect):
- 3:25 PM Changeset in webkit [45009] by
-
- 3 edits2 adds in trunk
WebCore:
2009-06-23 Kevin McCullough <kmccullough@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6994790> CrashTracer: [USER] 8 crashes in Mail trying to
add a blank line to pasted Facebook content (under
CompositeEditCommand::positionAvoidingSpecialElementBoundary)
- Just added null checks and I will create a new bug to prevent the bad behavior.
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
LayoutTests:
2009-06-23 Kevin McCullough <kmccullough@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6994790> CrashTracer: [USER] 8 crashes in Mail trying to
add a blank line to pasted Facebook content (under
CompositeEditCommand::positionAvoidingSpecialElementBoundary)
- editing/inserting/return-with-object-element-expected.txt: Added.
- editing/inserting/return-with-object-element.html: Added.
- 2:51 PM Changeset in webkit [45008] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-06-23 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Remove now-useless inplace variants of binary ops.
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_bitand): (JSC::JIT::emit_op_bitor): (JSC::JIT::emit_op_bitxor): (JSC::JIT::emit_op_add): (JSC::JIT::emit_op_sub): (JSC::JIT::emit_op_mul):
- 2:48 PM Changeset in webkit [45007] by
-
- 2 edits in trunk/WebCore
2009-06-23 Simon Fraser <Simon Fraser>
Build fix.
Wrap shouldDoSoftwarePaint() in #if USE(ACCELERATED_COMPOSITING) to avoid warning when
ACCELERATED_COMPOSITING is not defined.
- rendering/RenderLayer.cpp:
- 2:43 PM Changeset in webkit [45006] by
-
- 6 edits in branches/nitro-extreme/JavaScriptCore
2009-06-23 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Move off memory operands to aid in re-enabling result caching.
- No regression measured.
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_negate): (JSC::JIT::emit_op_jnless): (JSC::JIT::emit_op_jnlesseq): (JSC::JIT::emit_op_lshift): (JSC::JIT::emit_op_rshift): (JSC::JIT::emit_op_bitand): (JSC::JIT::emitBitAnd32Constant): (JSC::JIT::emitBitAnd32InPlace): (JSC::JIT::emit_op_bitor): (JSC::JIT::emitBitOr32Constant): (JSC::JIT::emitBitOr32InPlace): (JSC::JIT::emit_op_bitxor): (JSC::JIT::emitBitXor32Constant): (JSC::JIT::emitBitXor32InPlace): (JSC::JIT::emit_op_bitnot): (JSC::JIT::emit_op_post_inc): (JSC::JIT::emit_op_post_dec): (JSC::JIT::emit_op_pre_inc): (JSC::JIT::emitSlow_op_pre_inc): (JSC::JIT::emit_op_pre_dec): (JSC::JIT::emitSlow_op_pre_dec): (JSC::JIT::emit_op_add): (JSC::JIT::emitAdd32Constant): (JSC::JIT::emitAdd32InPlace): (JSC::JIT::emitSlow_op_add): (JSC::JIT::emitSlowAdd32Constant): (JSC::JIT::emit_op_sub): (JSC::JIT::emitSlow_op_sub): (JSC::JIT::emitSub32ConstantLeft): (JSC::JIT::emitSub32ConstantRight): (JSC::JIT::emitSub32InPlaceLeft): (JSC::JIT::emitSub32InPlaceRight): (JSC::JIT::emitBinaryDoubleOp): (JSC::JIT::emit_op_mul): (JSC::JIT::emitMul32InPlace): (JSC::JIT::emit_op_div): (JSC::JIT::emit_op_mod):
- jit/JITCall.cpp: (JSC::JIT::compileOpCallVarargs):
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_less): (JSC::JIT::emit_op_loop_if_lesseq): (JSC::JIT::emit_op_instanceof): (JSC::JIT::emit_op_to_primitive): (JSC::JIT::emit_op_not): (JSC::JIT::emit_op_jneq_ptr): (JSC::JIT::emit_op_eq): (JSC::JIT::emit_op_neq): (JSC::JIT::emit_op_to_jsnumber):
- jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emit_op_put_by_val):
- 2:25 PM Changeset in webkit [45005] by
-
- 6 edits4 adds in trunk
2009-06-23 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt.
Fix reflection painting on elements with compositing layers.
Test: compositing/reflections/reflection-on-composited.html
- rendering/RenderLayer.h: Add a new PaintLayerPaintingReflection flag which is set while painting inside reflections. (WebCore::RenderLayer::setPaintingInsideReflection): Add a setter so that RenderLayerBacking can call it.
- rendering/RenderLayer.cpp: (WebCore::shouldDoSoftwarePaint): Utility to clarify the logic of when a composited layer should do a software paint.
(WebCore::RenderLayer::paintLayer):
Use shouldDoSoftwarePaint() to determine when to software-paint a reflected layer.
Remove transform-related tests from the reflection-painting if test because they appear
to be unnecessary.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintIntoLayer): Add the code to paint reflections to the composited layer painting method.
- rendering/RenderReplica.cpp: (WebCore::RenderReplica::paint): Set the PaintLayerPaintingReflection flag.
- 1:26 PM Changeset in webkit [45004] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-06-23 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed some missing and/or misplaced labels in bytecode generation, so
we don't have to work around them in JIT code generation.
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitJumpSubroutine):
- parser/Nodes.cpp: (JSC::TryNode::emitBytecode):
- 1:01 PM Changeset in webkit [45003] by
-
- 7 edits in trunk
WebCore:
2009-06-23 Antti Koivisto <Antti Koivisto>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=26643
Memory cache should respect Cache-Control: no-store
Make resources with Cache-Control: no-store uncacheable in the memory cache.
They get evicted immediately when all clients are gone and are always
reloaded from the server.
Conforms to RFC2616 14.9.2 and seems also match Firefox behavior.
- loader/CachedResource.cpp: (WebCore::CachedResource::removeClient): (WebCore::CachedResource::canUseCacheValidator): (WebCore::CachedResource::mustRevalidate):
- platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::ResourceResponseBase): (WebCore::ResourceResponseBase::parseCacheControlDirectives): (WebCore::ResourceResponseBase::cacheControlContainsNoStore):
- platform/network/ResourceResponseBase.h:
LayoutTests:
2009-06-23 Antti Koivisto <Antti Koivisto>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=26643
Memory cache should respect Cache-Control: no-store
Update the test to cover no-store.
- http/tests/cache/subresource-expiration-expected.txt:
- http/tests/cache/subresource-expiration.html:
- 12:48 PM Changeset in webkit [45002] by
-
- 2 edits in trunk/WebCore
Windows build fix
- 12:46 PM Changeset in webkit [45001] by
-
- 6 edits in trunk/WebCore
2009-06-23 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
First part of https://bugs.webkit.org/show_bug.cgi?id=26652
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paint): (WebCore::RenderLayer::paintLayer):
- rendering/RenderLayer.h: (WebCore::RenderLayer::):
- rendering/RenderReplica.cpp: (WebCore::RenderReplica::paint): Replace the 3 boolean params to RenderLayer::paintLayer() with a bit mask for readability.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::paintIntoLayer): (WebCore::RenderLayerBacking::paintContents):
- rendering/RenderLayerBacking.h: Remove the unused 'haveTransparency' param to paintIntoLayer().
- 12:12 PM Changeset in webkit [45000] by
-
- 4 edits2 adds in trunk
WebCore:
2009-06-23 Kevin McCullough <kmccullough@apple.com>
Reviewed by Adele Peterson.
<rdar://problem/6902203> REGRESSION: 'Return' insertion point incorrect
after manually quoting blank line then hitting return
If the insertion point is both the begining and ending visible position
then we need to insert at the end instead of the begining, which is what
would normally happen if the insertion point was as the begining.
- editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply):
LayoutTests:
2009-06-23 Kevin McCullough <kmccullough@apple.com>
Reviewed by Adele Peterson.
<rdar://problem/6902203> REGRESSION: 'Return' insertion point incorrect
after manually quoting blank line then hitting return
- editing/inserting/insert-br-quoted-007-expected.txt: Added.
- editing/inserting/insert-br-quoted-007.html: Added.
- 12:05 PM Changeset in webkit [44999] by
-
- 13 edits in trunk/WebCore
2009-06-23 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig, and looked over by Eric Carlson.
<rdar://problem/6980466> Media elements should provide option for changing pitch correction
Introduce a new boolean property to HTMLMediaElement called webkitPreservesPitch for script to control this.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Currently the platforms that have a flexible pitch preservation property (Quicktime on Mac and Win) have had it on by default, so continue that default for now. (WebCore::HTMLMediaElement::loadResource): (WebCore::HTMLMediaElement::webkitPreservesPitch): (WebCore::HTMLMediaElement::setWebkitPreservesPitch):
- html/HTMLMediaElement.h:
- html/HTMLMediaElement.idl:
- platform/graphics/MediaPlayer.cpp: (WebCore::NullMediaPlayerPrivate::setPreservesPitch): (WebCore::MediaPlayer::MediaPlayer): (WebCore::MediaPlayer::preservesPitch): (WebCore::MediaPlayer::setPreservesPitch):
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::setPreservesPitch):
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::createQTMovie): Rework to allow recreation of the movie with almost the exact same attributes as before, with pitch preservation being the difference. (WebCore::MediaPlayerPrivate::setPreservesPitch): Recreate the QTMovie if the flag actually changes. (WebCore::MediaPlayerPrivate::updateStates): Restore current time and rate if this is a recreated movie. (WebCore::MediaPlayerPrivate::timeChanged): Clear the time-to-be-restored, as this callback means it has been effectively overwritten.
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::load): (WebCore::MediaPlayerPrivate::setPreservesPitch):
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
- platform/graphics/win/QTMovieWin.cpp: (QTMovieWinPrivate::QTMovieWinPrivate): (QTMovieWinPrivate::~QTMovieWinPrivate): (QTMovieWinPrivate::task): Restore current time and rate if this is a re-created movie. (QTMovieWin::play): Clear the time-to-be-restored, as this effectively overwrites it. (QTMovieWin::pause): Ditto. (QTMovieWin::setRate): Ditto. (QTMovieWin::setCurrentTime): Ditto. (QTMovieWin::setPreservesPitch): Recreate the Movie if the flag actually changes. (QTMovieWin::load): Rework to allow recreation of the Movie with similar state as the movie before it, but changing the pitch preservation flag.
- platform/graphics/win/QTMovieWin.h:
- 12:04 PM Changeset in webkit [44998] by
-
- 2 edits in trunk/WebCore
2009-06-23 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/6998286> Crash after leaving page with <video>
Don't try to post events after going into the page cache.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::documentWillBecomeInactive): Cancel pending events and stop event timers so we won't try to post events after going into the cache.
- 11:52 AM Changeset in webkit [44997] by
-
- 5 edits in trunk/WebCore
2009-06-23 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Brady Eidson.
Simplify the interaction between LocalStorageArea/SessionStorageArea
and StorageArea by creating a "blockUntilImportComplete()" function
rather than bouncing back and forth between the child and parent
classes in a somewhat unintuitive manner.
This patch also paves the way for LocalStorageArea and
SessionStorageArea being merged into one. It's part of several in a
set which are separating syncing (to disk) code from the rest of the
implementation so that local storage and session storage's code can be
unified.
- storage/LocalStorageArea.cpp: (WebCore::LocalStorageArea::blockUntilImportComplete):
- storage/LocalStorageArea.h:
- storage/StorageArea.cpp: (WebCore::StorageArea::length): (WebCore::StorageArea::key): (WebCore::StorageArea::getItem): (WebCore::StorageArea::setItem): (WebCore::StorageArea::removeItem): (WebCore::StorageArea::clear): (WebCore::StorageArea::contains):
- storage/StorageArea.h: (WebCore::StorageArea::blockUntilImportComplete):
- 11:36 AM Changeset in webkit [44996] by
-
- 3 edits in trunk/WebCore
2009-06-23 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler.
<rdar://problem/6997929> Assertion at WebCore::RenderLayer::updateClipRects with hardware acceleration
The updatingControlTints() painting pass goes through compositing layer boundaries,
so we need to ensure we don't cache clip rects computed with the wrong root by
setting temporaryClipRects to true.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::contentOffsetInCompostingLayer): Remove a printf that I left in by mistake.
- 11:03 AM Changeset in webkit [44995] by
-
- 10 edits in trunk
WebCore:
2009-06-23 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
WebCore side of <rdar://problem/6946094>.
- platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::setExternalDataObject):
- platform/win/ClipboardWin.h:
WebKit/win:
2009-06-23 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
WebKit side of <rdar://problem/6946094>.
- Interfaces/IWebUIDelegate.idl: Add a newPasteboard out parameter to willPerformDragSourceAction.
- WebCoreSupport/WebDragClient.cpp: (WebDragClient::willPerformDragSourceAction): Implement this. If the client returns a new pasteboard, use it for the drag.
- WebCoreSupport/WebInspectorDelegate.h: (WebInspectorDelegate::willPerformDragSourceAction): Add the new parameter.
WebKitTools:
2009-06-23 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Update for WebKit changes.
- DumpRenderTree/win/UIDelegate.h: (UIDelegate::willPerformDragSourceAction):
- 10:29 AM Changeset in webkit [44994] by
-
- 3 edits in trunk/WebCore
2009-06-23 Darin Fisher <darin@chromium.org>
Reviewed by Darin Adler.
Add setFormContentType and setFormData since it is awkward for Chromium
to use setFormInfoFromRequest to set the underlying members. Also, add
a clearChildren method that Chromium needs. These methods are used as
part of the Chromium code that serializes a HistoryItem for storing in
the browser's session history.
- history/HistoryItem.cpp:
- history/HistoryItem.h:
- 8:45 AM Changeset in webkit [44993] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-23 Joe Mason <joe.mason@torchmobile.com>
Reviewed by Adam Treat.
Authors: Yong Li <yong.li@torchmobile.com>, Joe Mason <joe.mason@torchmobile.com>
https://bugs.webkit.org/show_bug.cgi?id=26611
Implement currentThreadStackBase on WINCE by adding a global,
g_stackBase, which must be set to the address of a local variable
by the caller before calling any WebKit function that invokes JSC.
- 8:44 AM Changeset in webkit [44992] by
-
- 3 edits in trunk/LayoutTests
2009-06-23 Eric Carlson <eric.carlson@apple.com>
Reviewed by NOBODY, layout tests fix.
'timeupdate' events are, by definition, timing dependent so it isn't
a good idea to log them in layout test results.
- media/event-attributes-expected.txt:
- media/event-attributes.html:
- 7:49 AM Changeset in webkit [44991] by
-
- 11 edits2 adds in trunk
2009-06-23 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6978938> Need HTML 5 event attributes for media elements
Test: media/event-attributes.html
- html/HTMLAttributeNames.in: Add media event attribute names.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::parseMappedAttribute): Handle media event attributes.
2009-06-23 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6978938> Need HTML 5 event attributes for media elements
- media/event-attributes-expected.txt: Added.
- media/event-attributes.html: Added.
- media/progress-event-total.html: Cleanup, use event handler attributes.
- media/progress-event.html: Ditto.
- media/video-size-intrinsic-scale.html: Remove duplicate 'waitForEvent("ratechange")'
- media/video-source-add-src.html: Ditto.
- media/video-source-error.html: Ditto.
- media/video-timeupdate-during-playback.html: Ditto.
- platform/gtk/Skipped: Skip new test.
- 6:03 AM Changeset in webkit [44990] by
-
- 2 edits in trunk/WebCore
2009-06-23 Thiago Macieira <thiago.macieira@nokia.com>
Reviewed by Simon Hausmann.
Fix Qt build with Phonon.
The #include <phonon> header no longer exists. And the <Phonon> or
<Phonon/Phonon> headers have never existed (neither for us nor for the
Phonon sources). You have to select each and every header that you do
want now.
- 5:43 AM Changeset in webkit [44989] by
-
- 3 edits in trunk/WebCore
2009-06-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
Remove duplicated code in Qt & GTK logging initialization
We now share the getChannelFromName() function in Logging.cpp
- platform/gtk/LoggingGtk.cpp:
- platform/qt/LoggingQt.cpp:
- 5:43 AM Changeset in webkit [44988] by
-
- 12 edits in trunk/WebCore
2009-06-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
Rename the plugin logging channel to plural form 'Plugins'
This matches both the other logging channel names, as well as the
WebKit logging channel used by Safari/Mac for plugins.
- platform/Logging.cpp:
- platform/Logging.h:
- platform/gtk/LoggingGtk.cpp:
- platform/mac/LoggingMac.mm:
- platform/qt/LoggingQt.cpp:
- platform/win/LoggingWin.cpp:
- plugins/PluginDebug.h:
- plugins/gtk/PluginPackageGtk.cpp:
- plugins/mac/PluginPackageMac.cpp:
- plugins/mac/PluginViewMac.cpp:
- plugins/qt/PluginPackageQt.cpp:
- 3:17 AM Changeset in webkit [44987] by
-
- 2 edits in trunk/WebCore
2009-06-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Simon Hausmann.
Fix NPAPI mouse translation issues on Mac
The WindowRef we pass to the plugin refers to the the top level window,
so the x and y positions have to be relative to this position, but we
have to manually compensate for title bar decorations and other parents
of the QWebView since contentsToWindow() only traverses to the QWebView.
Previously we did this compensation when passing on mouse coordinates to
the plugin, which caused various issues with translations such as not
being able to close the Flash settings dialog, or the hand cursor not
appearing over links.
We now do the compensation as part of the call to NPP_SetWindow, and
then pass mouse coordinates in global context without any compensation,
similar to how both Safari and Mozilla does it.
- 3:11 AM Changeset in webkit [44986] by
-
- 2 edits in trunk/WebCore
2009-06-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Rubber-stamped by Simon Hausmann.
[Qt] Resolve absolute path to library install_name manually
Since our target.path is set to the Qt directory (to be able
to do 'make install') the 'absolute_library_soname' option
to QMake did not do the right thing.
We now compute the absolute path manually using DESTDIR.
- WebCore.pro:
- 2:17 AM Changeset in webkit [44985] by
-
- 2 edits25 copies1 delete in trunk/LayoutTests
2009-06-23 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
More tests for the XSSAuditor. (I converted the server side to Perl
after Sam reviewed the patch because the PHP scripts didn't agree with
the Tiger and Windows buildbots.)
- http/tests/security/xssAuditor/img-onerror-tricky-expected.txt: Added.
- http/tests/security/xssAuditor/img-onerror-tricky.html: Added.
- http/tests/security/xssAuditor/link-onclick-expected.txt: Added.
- http/tests/security/xssAuditor/link-onclick.html: Added.
- http/tests/security/xssAuditor/property-escape-expected.txt: Added.
- http/tests/security/xssAuditor/property-escape.html: Added.
- http/tests/security/xssAuditor/resources/echo-intertag-post-and-notify.pl: Added.
- http/tests/security/xssAuditor/resources/echo-intertag-post.pl: Added.
- http/tests/security/xssAuditor/resources/echo-intertag-utf-7.pl: Added.
- http/tests/security/xssAuditor/resources/echo-intertag.php: Removed.
- http/tests/security/xssAuditor/resources/echo-intertag.pl: Added.
- http/tests/security/xssAuditor/resources/echo-property.pl: Added.
- http/tests/security/xssAuditor/resources/redir.php: Added.
- http/tests/security/xssAuditor/resources/xss.js: Added.
- http/tests/security/xssAuditor/script-tag-convoluted-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-convoluted.html: Added.
- http/tests/security/xssAuditor/script-tag-open-redirect-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-open-redirect.html: Added.
- http/tests/security/xssAuditor/script-tag-post-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-post.html: Added.
- http/tests/security/xssAuditor/script-tag-redirect-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-redirect.html: Added.
- http/tests/security/xssAuditor/script-tag-utf-7-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-utf-7.html: Added.
- http/tests/security/xssAuditor/script-tag-with-source-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-with-source.html: Added.
- http/tests/security/xssAuditor/script-tag.html:
- 2:14 AM Changeset in webkit [44984] by
-
- 3 edits in trunk/JavaScriptCore
Fix stupid performance problem in the LiteralParser
Reviewed by Alexey Proskuryakov.
The LiteralParser was making a new UString in order to use
toDouble, however UString's toDouble allows a much wider range
of numberic strings than the LiteralParser accepts, and requires
an additional heap allocation or two for the construciton of the
UString. To rectify this we just call WTF::dtoa directly using
a stack allocated buffer to hold the validated numeric literal.
- 2:11 AM Changeset in webkit [44983] by
-
- 2 edits1 copy25 deletes in trunk/LayoutTests
Revert 44981. The buildbots hate me.
- 2:01 AM Changeset in webkit [44982] by
-
- 2 edits in trunk/WebKitTools
2009-06-23 Eric Seidel <eric@webkit.org>
Reviewed by Mark Rowe.
- Scripts/modules/scm.py: Fix commit_with_message to return the commit output.
- 1:51 AM Changeset in webkit [44981] by
-
- 2 edits25 adds1 delete in trunk/LayoutTests
2009-06-23 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
More tests for the XSSAuditor. (I converted the server side to Perl
after Sam reviewed the patch because the PHP scripts didn't agree with
the Tiger and Windows buildbots.)
- http/tests/security/xssAuditor/img-onerror-tricky-expected.txt: Added.
- http/tests/security/xssAuditor/img-onerror-tricky.html: Added.
- http/tests/security/xssAuditor/link-onclick-expected.txt: Added.
- http/tests/security/xssAuditor/link-onclick.html: Added.
- http/tests/security/xssAuditor/property-escape-expected.txt: Added.
- http/tests/security/xssAuditor/property-escape.html: Added.
- http/tests/security/xssAuditor/resources/echo-intertag-post-and-notify.pl: Added.
- http/tests/security/xssAuditor/resources/echo-intertag-post.pl: Added.
- http/tests/security/xssAuditor/resources/echo-intertag-utf-7.pl: Added.
- http/tests/security/xssAuditor/resources/echo-intertag.php: Removed.
- http/tests/security/xssAuditor/resources/echo-intertag.pl: Added.
- http/tests/security/xssAuditor/resources/echo-property.pl: Added.
- http/tests/security/xssAuditor/resources/redir.php: Added.
- http/tests/security/xssAuditor/resources/xss.js: Added.
- http/tests/security/xssAuditor/script-tag-convoluted-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-convoluted.html: Added.
- http/tests/security/xssAuditor/script-tag-open-redirect-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-open-redirect.html: Added.
- http/tests/security/xssAuditor/script-tag-post-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-post.html: Added.
- http/tests/security/xssAuditor/script-tag-redirect-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-redirect.html: Added.
- http/tests/security/xssAuditor/script-tag-utf-7-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-utf-7.html: Added.
- http/tests/security/xssAuditor/script-tag-with-source-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-with-source.html: Added.
- http/tests/security/xssAuditor/script-tag.html:
- 1:46 AM Changeset in webkit [44980] by
-
- 2 edits in trunk/WebKitTools
2009-06-23 Eric Seidel <eric@webkit.org>
Reviewed by Mark Rowe.
- Scripts/modules/scm.py: Fix error seen when commiting r44979.
- 1:40 AM Changeset in webkit [44979] by
-
- 1 edit5 adds in trunk/WebKitTools
2009-06-18 Eric Seidel <eric@webkit.org>
Reviewed by Dave Levin.
WebKit needs a script to interact with bugzilla and automate
parts of the patch posting and commit processes.
https://bugs.webkit.org/show_bug.cgi?id=26283
This is really a first-draft tool.
It's to the point where it's useful to more people than just me now though.
Git support works. SVN support is written, but mostly untested.
This tool requires BeautifulSoup and mechanize python modules to run:
sudo easy_install BeautifulSoup
sudo easy_install mechanize
More important than the tool itself are the Bugzilla, Git and SVN class abstractions
which I hope will allow easy writing of future tools.
The tool currently implements 10 commands, described below.
Helpers for scripting dealing with the commit queue:
bugs-to-commit Bugs in the commit queue
patches-to-commit Patches attached to bugs in the commit queue
Dealing with bugzilla:
reviewed-patches BUGID r+'d patches on a bug
apply-patches BUGID Applies all patches on a bug to the local working directory without committing.
land-and-update BUGID Lands the current working directory diff and updates the bug.
land-patches [options] BUGID Lands all patches on a bug optionally testing them first
obsolete-attachments BUGID Marks all attachments on a bug as obsolete.
commit-message Prints a commit message suitable for the uncommitted changes.
These effectively replace git-send-bugzilla:
post-diff BUGID Attaches the current working directory diff to a bug as a patch file.
post-commits BUGID COMMITISH Attaches a range of local commits to a bug as patch files.
post-diff works for SVN and Git, post-commits only works for SCMs with local-commit support (like Git)
land-* commands in a Git environment only work with simple patches due to svn-apply bugs:
https://bugs.webkit.org/show_bug.cgi?id=26299
https://bugs.webkit.org/show_bug.cgi?id=26300
This script follows python style (similar to how for Obj-C we follow AppKit style)
http://www.python.org/doc/essays/styleguide.html
The Python community has a strong style culture and the WebKit style guide is silent re: Python.
I've filed a bug to update the WebKit style guide to mention python:
https://bugs.webkit.org/show_bug.cgi?id=26524
- Scripts/bugzilla-tool: Added.
- 12:48 AM Changeset in webkit [44978] by
-
- 2 edits22 deletes in trunk/LayoutTests
Revert 44977 because Tiger and Windows don't like the new tests.
- 12:11 AM Changeset in webkit [44977] by
-
- 2 edits22 adds in trunk/LayoutTests
2009-06-23 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
More tests for the XSSAuditor.
- http/tests/security/xssAuditor/link-onclick-expected.txt: Added.
- http/tests/security/xssAuditor/link-onclick.html: Added.
- http/tests/security/xssAuditor/property-escape-expected.txt: Added.
- http/tests/security/xssAuditor/property-escape.html: Added.
- http/tests/security/xssAuditor/resources/echo-intertag-post-and-notify.php: Added.
- http/tests/security/xssAuditor/resources/echo-intertag-post.php: Added.
- http/tests/security/xssAuditor/resources/echo-intertag-utf-7.php: Added.
- http/tests/security/xssAuditor/resources/echo-intertag.php:
- http/tests/security/xssAuditor/resources/echo-property.php: Added.
- http/tests/security/xssAuditor/resources/redir.php: Added.
- http/tests/security/xssAuditor/resources/xss.js: Added.
- http/tests/security/xssAuditor/script-tag-convoluted-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-convoluted.html: Added.
- http/tests/security/xssAuditor/script-tag-open-redirect-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-open-redirect.html: Added.
- http/tests/security/xssAuditor/script-tag-post-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-post.html: Added.
- http/tests/security/xssAuditor/script-tag-redirect-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-redirect.html: Added.
- http/tests/security/xssAuditor/script-tag-utf-7-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-utf-7.html: Added.
- http/tests/security/xssAuditor/script-tag-with-source-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-with-source.html: Added.
- 12:00 AM Changeset in webkit [44976] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-06-22 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
For member function calls, emit "this" directly into the "this" slot
for the function call, instead of moving it there later. This reduces
time spent in op_mov during certain calls, like "a.b.c()".
1%-2% speedup on v8, mostly richards and delta-blue.
- parser/Nodes.cpp: (JSC::FunctionCallDotNode::emitBytecode):
Jun 22, 2009:
- 10:53 PM Changeset in webkit [44975] by
-
- 5 edits in trunk/LayoutTests
2009-06-22 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Alexey Proskuryakov.
Skip layout tests for DST if the test runs not in PST/PDT.
- fast/js/date-DST-time-cusps-expected.txt:
- fast/js/date-big-setdate-expected.txt:
- fast/js/resources/date-DST-time-cusps.js:
- fast/js/resources/date-big-setdate.js:
- 10:44 PM Changeset in webkit [44974] by
-
- 6 edits in trunk
Bug 26640: JSON.stringify needs to special case Boolean objects
<https://bugs.webkit.org/show_bug.cgi?id=26640>
Reviewed by Alexey Proskuryakov.
Add special case handling of the Boolean object so we match current
ES5 errata.
- 9:53 PM Changeset in webkit [44973] by
-
- 2 edits in trunk/WebCore
2009-06-22 Simon Fraser <Simon Fraser>
Reviewed by Oliver Hunt.
<rdar://problem/6991146> Scrollbars in hardware layers don't change to the
inactive look in background windows
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): Don't short-circuit the "painting" pass that is used to udpate control tints.
- 9:36 PM Changeset in webkit [44972] by
-
- 3 edits1 add in trunk/WebCore
2009-06-22 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=26567
Upstream V8 bindings code generator. With this change, also added interface ancestor
traversal to IDL parser, which is necessary for V8 bindings. The traversal is used
to determine whether an interface is a Node to facilitate proper casting and storage
in V8DOMMap.
- bindings/scripts/CodeGenerator.pm: Added parent traversal sub, needed
by V8 bindings.
- bindings/scripts/CodeGeneratorV8.pm: Added.
- bindings/scripts/IDLParser.pm: Modified to allow limited parsing for
parent traversal cases.
- 8:37 PM Changeset in webkit [44971] by
-
- 8 edits in branches/nitro-extreme/JavaScriptCore
2009-06-22 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Remove 'arguments' field from Register union. Having JSCell derived types in the union is
dangerous since it opens the possibility for the field to be written as a raw pointer but
then read as a JSValue. This will lead to statle data being read for the tag, which may
be dangerous. Having removed Arguments* types form Register, all arguments objects must
always explicitly be stored in the register file as JSValues.
- interpreter/CallFrame.h: (JSC::ExecState::optionalCalleeArguments):
- interpreter/Interpreter.cpp: (JSC::Interpreter::unwindCallFrame): (JSC::Interpreter::privateExecute): (JSC::Interpreter::retrieveArguments):
- interpreter/Register.h: (JSC::Register::):
- jit/JITStubs.cpp: (JSC::JITStubs::cti_op_tear_off_arguments):
- runtime/Arguments.h: (JSC::JSActivation::copyRegisters):
- runtime/JSActivation.cpp: (JSC::JSActivation::argumentsGetter):
- runtime/JSActivation.h:
- 8:07 PM Changeset in webkit [44970] by
-
- 2 edits in trunk/WebKitTools
Roll out r44967 as that build slave hates freedom.
- 8:05 PM Changeset in webkit [44969] by
-
- 8 edits in trunk
WebCore:
2009-06-22 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Add event handler attribute getter/setters to HTMLFrameSetElement
as specified in HTML 5. These match the ones on HTMLBodyElement.
- dom/Node.h:
- html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::parseMappedAttribute): (WebCore::HTMLFrameSetElement::onblur): (WebCore::HTMLFrameSetElement::setOnblur): (WebCore::HTMLFrameSetElement::onerror): (WebCore::HTMLFrameSetElement::setOnerror): (WebCore::HTMLFrameSetElement::onfocus): (WebCore::HTMLFrameSetElement::setOnfocus): (WebCore::HTMLFrameSetElement::onload): (WebCore::HTMLFrameSetElement::setOnload): (WebCore::HTMLFrameSetElement::onbeforeunload): (WebCore::HTMLFrameSetElement::setOnbeforeunload): (WebCore::HTMLFrameSetElement::onmessage): (WebCore::HTMLFrameSetElement::setOnmessage): (WebCore::HTMLFrameSetElement::onoffline): (WebCore::HTMLFrameSetElement::setOnoffline): (WebCore::HTMLFrameSetElement::ononline): (WebCore::HTMLFrameSetElement::setOnonline): (WebCore::HTMLFrameSetElement::onresize): (WebCore::HTMLFrameSetElement::setOnresize): (WebCore::HTMLFrameSetElement::onstorage): (WebCore::HTMLFrameSetElement::setOnstorage): (WebCore::HTMLFrameSetElement::onunload): (WebCore::HTMLFrameSetElement::setOnunload):
- html/HTMLFrameSetElement.h:
- html/HTMLFrameSetElement.idl:
LayoutTests:
2009-06-22 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Add event handler attribute getter/setters to HTMLFrameSetElement
as specified in HTML 5. These match the ones on HTMLBodyElement.
- fast/dom/event-attribute-availability-expected.txt:
- fast/dom/resources/event-attribute-availability.js:
- 6:27 PM Changeset in webkit [44968] by
-
- 5 edits in trunk
Bug 26591: Support revivers in JSON.parse
<https://bugs.webkit.org/show_bug.cgi?id=26591>
Reviewed by Darin Adler.
Add reviver support to JSON.parse. This completes the JSON object.
- 6:27 PM Changeset in webkit [44967] by
-
- 2 edits in trunk/WebKitTools
Update build.webkit.org config for new machine.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 6:04 PM Changeset in webkit [44966] by
-
- 6 edits in trunk/WebCore
2009-06-22 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Bug 25425: DOM attribute getter/setter functions should use const AtomicString& type
https://bugs.webkit.org/show_bug.cgi?id=25425
- bindings/scripts/CodeGeneratorJS.pm: Added handling for ReflectURL.
- bindings/scripts/CodeGeneratorObjC.pm: Ditto.
- dom/Element.cpp: (WebCore::Element::getURLAttribute): Added. For use implementing getters for ReflectURL.
- dom/Element.h: Added getURLAttribute.
- html/HTMLImageElement.idl: Use Reflect and ReflectURL.
- 5:41 PM Changeset in webkit [44965] by
-
- 2 edits in trunk/WebCore
2009-06-22 Jian Li <jianli@chromium.org>
Reviewed by Dimitri Glazkov.
Bug 26626: Make WorkerContextExecutionProxy::toV8Object handle exception
objects.
https://bugs.webkit.org/show_bug.cgi?id=26626
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::ToV8Object):
- 4:24 PM Changeset in webkit [44964] by
-
- 10 edits2 adds in trunk/WebCore
2009-06-22 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig.
Add RenderDataGrid to the build. Give it some basic default styling (that more or less matches a listbox). It has a default size
of 300x150.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- css/html4.css:
- html/HTMLDataGridElement.cpp: (WebCore::HTMLDataGridElement::createRenderer):
- html/HTMLDataGridElement.h:
- html/HTMLDataGridElement.idl:
- rendering/RenderDataGrid.cpp: Added. (WebCore::RenderDataGrid::RenderDataGrid): (WebCore::RenderDataGrid::~RenderDataGrid): (WebCore::RenderDataGrid::calcPrefWidths): (WebCore::RenderDataGrid::paintObject): (WebCore::RenderDataGrid::valueChanged): (WebCore::RenderDataGrid::invalidateScrollbarRect): (WebCore::RenderDataGrid::isActive):
- rendering/RenderDataGrid.h: Added. (WebCore::RenderDataGrid::renderName): (WebCore::RenderDataGrid::canHaveChildren): (WebCore::RenderDataGrid::scrollbarCornerPresent):
- 4:01 PM Changeset in webkit [44963] by
-
- 2 edits in trunk/WebKitTools
Remove errant line of code mistakenly checked in.
- DumpRenderTree/win/DumpRenderTree.cpp: (main):
- 4:00 PM Changeset in webkit [44962] by
-
- 2 edits in trunk/WebKitTools
Pass correct value to setShouldPaintNativeControls.
Rubber stamped by Mark Rowe.
- DumpRenderTree/win/DumpRenderTree.cpp: (main):
- 3:45 PM Changeset in webkit [44961] by
-
- 7 edits2 adds in trunk
2009-06-22 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=26430
<rdar://problem/6944442> Elements jump around when they become composited (WWDC checkers demo)
<rdar://problem/6989006> Lots of time spent in RenderLayerCompositor::calculateCompositedBounds()
during window resize when using hardware layers
Fix an ordering dependency which caused the compositing position of a layer
to be affected by some later sibling, which affected the compositing ancestor's
composited bounds.
The fix is to only update the compositing positions of layers in some subtree
when updateAfterLayout() has been called on all the layers in that subtree,
from the ancestor down.
Also cache the composited bounds of a RenderLayerBacking, now that we can
guarantee that those bounds are accurate.
Test: compositing/sibling-positioning.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::hitTestLayer):
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::RenderLayerBacking): (WebCore::RenderLayerBacking::updateAfterLayout): (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): (WebCore::RenderLayerBacking::contentOffsetInCompostingLayer): (WebCore::RenderLayerBacking::paintContents): (WebCore::RenderLayerBacking::compositedBounds): (WebCore::RenderLayerBacking::setCompositedBounds):
- rendering/RenderLayerBacking.h:
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateBacking): (WebCore::RenderLayerCompositor::updateLayerCompositingState): (WebCore::RenderLayerCompositor::calculateCompositedBounds): (WebCore::RenderLayerCompositor::layerWillBeRemoved): (WebCore::RenderLayerCompositor::computeCompositingRequirements): (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): (WebCore::RenderLayerCompositor::updateCompositingChildrenGeometry):
- rendering/RenderLayerCompositor.h:
- 3:41 PM Moving to Git edited by
- Add link to evmar's doc (diff)
- 3:31 PM Moving to Git edited by
- Discussion of patch review branches (diff)
- 2:59 PM Changeset in webkit [44960] by
-
- 5 edits in branches/nitro-extreme
Merged r43552:43558 into nitro-extreme branch.
- 2:58 PM Changeset in webkit [44959] by
-
- 15 edits2 copies in trunk/WebCore
2009-06-22 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
First step in https://bugs.webkit.org/show_bug.cgi?id=25376
Add StorageSyncManager.cpp/h
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
In preparation for combining SessionStorage and LocalStorage into a
single StorageManager, move the syncing bits out of LocalStorage and
into its own class.
The next step is to combine LocalStorageArea and SessionStorageArea
into one. Then SessionStorage and LocalStorage can be combined.
Note that combining them will cut down on code paths that must be
proxied, eliminate virtual dispatch, and allow Chromium to (eventually)
write historical sessionStorage to disk when memory is getting tight.
Also remove a couple bits of cruft including code for quotas which is
unnecessary (since a meta-data db is unnecessary since you can just
count bytes as you read the local storage databases into memory).
- storage/LocalStorage.cpp: (WebCore::LocalStorage::LocalStorage): (WebCore::LocalStorage::storageArea): (WebCore::LocalStorage::close):
- storage/LocalStorage.h:
- storage/LocalStorageArea.cpp: (WebCore::LocalStorageArea::LocalStorageArea): (WebCore::LocalStorageArea::scheduleFinalSync): (WebCore::LocalStorageArea::syncTimerFired): (WebCore::LocalStorageArea::performImport):
- storage/LocalStorageArea.h: (WebCore::LocalStorageArea::create):
- storage/LocalStorageTask.cpp: (WebCore::LocalStorageTask::performTask):
- storage/LocalStorageTask.h: (WebCore::LocalStorageTask::): (WebCore::LocalStorageTask::createImport):
- storage/LocalStorageThread.cpp:
- storage/LocalStorageThread.h:
- storage/SessionStorage.h:
- storage/StorageSyncManager.cpp: Copied from WebCore/storage/LocalStorage.cpp. (WebCore::StorageSyncManager::create): (WebCore::StorageSyncManager::StorageSyncManager): (WebCore::StorageSyncManager::fullDatabaseFilename): (WebCore::StorageSyncManager::close): (WebCore::StorageSyncManager::scheduleImport): (WebCore::StorageSyncManager::scheduleSync):
- storage/StorageSyncManager.h: Copied from WebCore/storage/LocalStorage.h. (WebCore::):
- 2:47 PM Changeset in webkit [44958] by
-
- 2 edits in branches/nitro-extreme
Merged r43550:43552 into nitro-extreme branch - fix error in merging changelogs.
- 2:43 PM Changeset in webkit [44957] by
-
- 5 edits7 copies in branches/nitro-extreme
Merged r43550:43552 into nitro-extreme branch.
- 2:38 PM Changeset in webkit [44956] by
-
- 3 edits in trunk/WebCore
2009-06-22 Darin Fisher <darin@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=26622
Add ChromiumDataObject::copy()
- platform/chromium/ChromiumDataObject.cpp:
- platform/chromium/ChromiumDataObject.h:
- 2:31 PM Changeset in webkit [44955] by
-
- 2 edits in trunk/WebKit/mac
Add Mail on Tiger and Leopard to the list of applications that need the WebView init thread workaround.
<rdar://problem/6929524> Console shows WebKit Threading Violations from Mail
Reviewed by Anders Carlsson.
- WebView/WebView.mm: (clientNeedsWebViewInitThreadWorkaround): Return true for com.apple.Mail.
- 2:30 PM Moving to Git edited by
- (diff)
- 2:25 PM Changeset in webkit [44954] by
-
- 2 edits1 add in trunk/WebCore
Add a silhouette image for the enable view of the Resource panel.
Reviewed by Kevin McCullough.
- inspector/front-end/Images/resourcesSilhouette.png: Added.
- inspector/front-end/inspector.css:
- 2:02 PM Changeset in webkit [44953] by
-
- 2 edits1 add in trunk/WebCore
2009-06-22 Kyle Prete <kylep@chromium.org>
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=26552
Add V8 JS bindings for Audio Constructor.
- bindings/v8/custom/V8CustomBinding.h: Added a callback declaration for audio ctor to macro.
- bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: Added the whole file.
- 1:14 PM Changeset in webkit [44952] by
-
- 2 edits in trunk/WebCore
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=26600
StringImpl::copy() no longer copies empty string correctly
- platform/text/StringImpl.cpp: (WebCore::StringImpl::ustring): Changed method calling syntax to look less like calling a static method. (WebCore::StringImpl::copy): Reverted part of r41917 that caused the problem.
- 12:51 PM Changeset in webkit [44951] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Anders Carlsson.
- speculative fix for <rdar://problem/6889082> Crash at -[WebHTMLView(WebPrivate) _updateMouseoverWithEvent:]
The crash seems to happen because lastHitView points to a deleted
object. Since -close calls -_clearLastHitViewIfSelf, I speculate that
lastHitView has been set to an already-closed view.
- WebView/WebHTMLView.mm: (-[WebHTMLView hitTest:]): Return nil if the view is closed.
- 12:34 PM Changeset in webkit [44950] by
-
- 3 edits in trunk/LayoutTests
2009-06-22 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
Fix layout tests to account for removal of DOMStringList, which was done
in http://trac.webkit.org/changeset/44943.
- fast/dom/Window/window-properties-expected.txt:
- fast/js/global-constructors-expected.txt:
- 12:20 PM Changeset in webkit [44949] by
-
- 3 edits in branches/nitro-extreme/WebCore
Merged r43544:43550 into nitro-extreme branch.
- 11:54 AM Changeset in webkit [44948] by
-
- 2 edits1 add in trunk/WebCore
2009-06-22 Xiaomei Ji <xji@chromium.org>
Reviewed by Eric Seidel
Not auto-testable since it involves sending a keyboard event to
the popup, which is not possible (eventSender sends the key
events through webview, we want to go through the webwidget).
This patch is one part of the fix for issue "keyboard selection in
Hebrew select element does not work in Windows". The other part of the
fix is in chromium's webkit/glue layer.
https://bugs.webkit.org/show_bug.cgi?id=25899
- manual-tests/keyboard_select_non_english.html: Added.
- platform/chromium/PopupMenuChromium.cpp: (WebCore::isCharacterTypeEvent): Added. Check whether the event is a character type event. "Char" in Windows or "KeyDown" in Mac is character type event. (WebCore::PopupListBox::typeAheadFind): Since m_lastCharTime is used to indicate whether user types multiple characters continuely as a search prefix or not, it should be only assigned when the event is character type event.
- 11:51 AM Changeset in webkit [44947] by
-
- 5 edits in trunk/WebCore
2009-06-22 Kevin McCullough <kmccullough@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6115819> Notify of profile start in console
Put a message in the console that announces that a profile has started,
similar to how a console message announces that a profile has finished.
- inspector/InspectorController.cpp: (WebCore::InspectorController::addProfile): Use renamed function. (WebCore::InspectorController::addProfileFinishedMessageToConsole): Renamed. (WebCore::InspectorController::addStartProfilingMessageToConsole): New function that logs the message about the profile starting. (WebCore::InspectorController::startUserInitiatedProfiling): Ditto
- inspector/InspectorController.h:
- inspector/front-end/ProfilesPanel.js: Print the "run" of the profile's title if there are multiple profiles, and take into account the fact that titles are displayed twice as much now. (WebInspector.ProfilesPanel.prototype.displayTitleForProfileLink):
- page/Console.cpp: (WebCore::Console::profile): Call new function.
- 11:47 AM Changeset in webkit [44946] by
-
- 17 edits3 adds in trunk/WebCore
2009-06-22 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig.
Add IDL interface for datagrid cell elements. Add a few more properties to the datagrid itself that
correspond to ones you find on <select> elements.
Add an expanded property to row elements.
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- html/HTMLAttributeNames.in:
- html/HTMLDataGridCellElement.cpp: Added. (WebCore::HTMLDataGridCellElement::HTMLDataGridCellElement): (WebCore::HTMLDataGridCellElement::label): (WebCore::HTMLDataGridCellElement::setLabel): (WebCore::HTMLDataGridCellElement::focused): (WebCore::HTMLDataGridCellElement::setFocused): (WebCore::HTMLDataGridCellElement::checked): (WebCore::HTMLDataGridCellElement::setChecked): (WebCore::HTMLDataGridCellElement::indeterminate): (WebCore::HTMLDataGridCellElement::setIndeterminate): (WebCore::HTMLDataGridCellElement::progress): (WebCore::HTMLDataGridCellElement::setProgress):
- html/HTMLDataGridCellElement.h: Added. (WebCore::HTMLDataGridCellElement::endTagRequirement): (WebCore::HTMLDataGridCellElement::tagPriority):
- html/HTMLDataGridCellElement.idl: Added.
- html/HTMLDataGridElement.cpp: (WebCore::HTMLDataGridElement::autofocus): (WebCore::HTMLDataGridElement::setAutofocus): (WebCore::HTMLDataGridElement::disabled): (WebCore::HTMLDataGridElement::setDisabled): (WebCore::HTMLDataGridElement::size): (WebCore::HTMLDataGridElement::setSize):
- html/HTMLDataGridElement.h:
- html/HTMLDataGridElement.idl:
- html/HTMLDataGridRowElement.cpp: (WebCore::HTMLDataGridRowElement::checkDTD): (WebCore::HTMLDataGridRowElement::expanded): (WebCore::HTMLDataGridRowElement::setExpanded):
- html/HTMLDataGridRowElement.h:
- html/HTMLDataGridRowElement.idl:
- html/HTMLElementsAllInOne.cpp:
- html/HTMLTagNames.in:
- 11:32 AM Changeset in webkit [44945] by
-
- 2 edits in trunk/WebKitTools
Fix last DumpRenderTree change to correctly set preferences flag without crashing.
Reviewed by Mark Rowe.
- DumpRenderTree/win/DumpRenderTree.cpp: (main):
- 11:32 AM Changeset in webkit [44944] by
-
- 13 edits in trunk
WebCore:
2009-06-22 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Add event handler attribute getter/setters to HTMLBodyElement
as specified in HTML 5.
- Removes erroneous inclusion of the onresize and onunload event handler attributes in Element and Document.
- dom/Document.cpp: (WebCore::Document::getWindowAttributeEventListener):
- dom/Document.h:
- dom/Document.idl:
- dom/Element.idl:
- dom/Node.cpp:
- dom/Node.h: onblur, onerror, onfocus, and onload all need to be declared virtual, since their behavior for HTMLBodyElement differs from the base implementation.
- html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::onblur): (WebCore::HTMLBodyElement::setOnblur): (WebCore::HTMLBodyElement::onerror): (WebCore::HTMLBodyElement::setOnerror): (WebCore::HTMLBodyElement::onfocus): (WebCore::HTMLBodyElement::setOnfocus): (WebCore::HTMLBodyElement::onload): (WebCore::HTMLBodyElement::setOnload): (WebCore::HTMLBodyElement::onbeforeunload): (WebCore::HTMLBodyElement::setOnbeforeunload): (WebCore::HTMLBodyElement::onmessage): (WebCore::HTMLBodyElement::setOnmessage): (WebCore::HTMLBodyElement::onoffline): (WebCore::HTMLBodyElement::setOnoffline): (WebCore::HTMLBodyElement::ononline): (WebCore::HTMLBodyElement::setOnonline): (WebCore::HTMLBodyElement::onresize): (WebCore::HTMLBodyElement::setOnresize): (WebCore::HTMLBodyElement::onstorage): (WebCore::HTMLBodyElement::setOnstorage): (WebCore::HTMLBodyElement::onunload): (WebCore::HTMLBodyElement::setOnunload):
- html/HTMLBodyElement.h:
- html/HTMLBodyElement.idl:
LayoutTests:
2009-06-22 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Add event handler attribute getter/setters to HTMLBodyElement
as specified in HTML 5.
- fast/dom/event-attribute-availability-expected.txt:
- fast/dom/resources/event-attribute-availability.js:
- 11:22 AM Changeset in webkit [44943] by
-
- 24 edits7 deletes in trunk/WebCore
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=26601
Remove disabled code for appcache dynamic entries
This also removes code for DOM 3 Core DOMStringList, which we don't use for anything else yet.
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/JSDOMStringListCustom.cpp: Removed.
- bindings/v8/custom/V8CustomBinding.h:
- bindings/v8/custom/V8DOMStringListCustom.cpp: Removed.
- dom/DOMStringList.cpp: Removed.
- dom/DOMStringList.h: Removed.
- dom/DOMStringList.idl: Removed.
- dom/StaticStringList.cpp: Removed.
- dom/StaticStringList.h: Removed.
- loader/DocumentLoader.cpp: (WebCore::DocumentLoader::shouldLoadResourceFromApplicationCache):
- loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::addResource):
- loader/appcache/ApplicationCache.h:
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
- loader/appcache/ApplicationCacheResource.cpp: (WebCore::ApplicationCacheResource::dumpType):
- loader/appcache/ApplicationCacheResource.h: (WebCore::ApplicationCacheResource::):
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::storeUpdatedType):
- loader/appcache/DOMApplicationCache.cpp:
- loader/appcache/DOMApplicationCache.h:
- loader/appcache/DOMApplicationCache.idl:
- page/DOMWindow.idl:
- 10:56 AM Changeset in webkit [44942] by
-
- 3 edits in trunk/WebCore
Windows build fix.
- DerivedSources.cpp:
- html/HTMLElementsAllInOne.cpp:
- 10:33 AM Changeset in webkit [44941] by
-
- 4 edits in trunk
Reviewed by John Sullivan.
<rdar://problem/6956606> REGRESSION (S4Beta -> Final): After the password is input,
Japanese can't be input.
WebKit uses a per-frame input context for most editable fields, and application's global
context for password fields, manually controlling secure input state and the list of available
input methods.
We were setting TSMDocument property to disable non-Roman input methods after focus changed
to a password field, but before selection was updated. This resulted in the property being
applied to a wrong TSMDocument in some cases, because TSMGetActiveDocument() uses input
context cached by +[NSApplication updateWindows], we change context based on selection,
not on focus.
- page/mac/FrameMac.mm: (WebCore::Frame::setUseSecureKeyboardEntry): Since there is only one context that we use for password fields - the global one - there is no need to get the active one.
- 10:20 AM Changeset in webkit [44940] by
-
- 8 edits3 adds in trunk
WebCore:
2009-06-22 David Levin <levin@chromium.org>
Reviewed by David Hyatt and Eric Seidel.
REGRESSION: When the main page (ScrollView) has a custom scrollbar, it crashes on destruction.
https://bugs.webkit.org/show_bug.cgi?id=26326
Test: scrollbars/scrollbar-crash-on-refresh.html
- dom/Document.cpp: (WebCore::Document::detach): Gives the FrameView a change to do any necessary cleanup on Document::detach() which is where the renderArena gets detroyed.
- page/FrameView.cpp: (WebCore::FrameView::detachCustomScrollbars): Gets rid of any custom scrollbars (if the docment supplied them).
- page/FrameView.h:
- platform/Scrollbar.h: (WebCore::Scrollbar::isCustomScrollbar):
- rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): Removed the check for document()->frame(). If frame() is 0 in this code, then the call to animation() is also incorrect (since it does document()->frame()->animation()).
- rendering/RenderScrollbar.h: (WebCore::RenderScrollbar::isCustomScrollbar):
LayoutTests:
2009-06-22 David Levin <levin@chromium.org>
Reviewed by David Hyatt and Eric Seidel.
REGRESSION: When the main page (ScrollView) has a custom scrollbar, it crashes on destruction.
https://bugs.webkit.org/show_bug.cgi?id=26326
Test that refreshing an iframe with custom scrollbars works without crashing.
- scrollbars/resources/page-with-custom-scrollbars.html: Added.
- scrollbars/scrollbar-crash-on-refresh-expected.txt: Added.
- scrollbars/scrollbar-crash-on-refresh.html: Added.
- 9:50 AM Changeset in webkit [44939] by
-
- 3 edits in trunk/WebKit/mac
Reviewed by Dave Hyatt.
- fix <rdar://problem/6990938> REGRESSION (r42787): After showing and hiding the Find banner, the WebHTMLView's height is not restored
- WebView/WebFrameView.mm: (-[WebFrameView setFrameSize:]): Mark the FrameView for layout when the WebFrameView's size changes.
- WebView/WebView.mm: (-[WebView setFrameSize:]): Left the resize logic here, but only for the single view model.
- 9:42 AM Changeset in webkit [44938] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Simon Fraser.
- fix https://bugs.webkit.org/show_bug.cgi?id=23606 <rdar://problem/6537777> CSS gradient not repainted when image load completes
Test: fast/repaint/background-generated.html
- rendering/RenderObject.cpp: (WebCore::mustRepaintFillLayers): Return true if the layer does not specify a size and the image uses the container size.
LayoutTests:
Reviewed by Simon Fraser.
- test for https://bugs.webkit.org/show_bug.cgi?id=23606 <rdar://problem/6537777> CSS gradient not repainted when image load completes
- fast/repaint/background-generated.html: Added.
- platform/mac/fast/repaint/background-generated-expected.checksum: Added.
- platform/mac/fast/repaint/background-generated-expected.png: Added.
- platform/mac/fast/repaint/background-generated-expected.txt: Added.
- 9:34 AM Changeset in webkit [44937] by
-
- 15 edits3 adds in trunk/WebCore
2009-06-22 David Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig.
Add IDL for HTMLDataGridRowElement.
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- html/HTMLAttributeNames.in:
- html/HTMLDataGridColElement.cpp: (WebCore::HTMLDataGridColElement::primary): (WebCore::HTMLDataGridColElement::setPrimary):
- html/HTMLDataGridColElement.h:
- html/HTMLDataGridColElement.idl:
- html/HTMLDataGridElement.cpp: (WebCore::HTMLDataGridElement::checkDTD): (WebCore::HTMLDataGridElement::multiple): (WebCore::HTMLDataGridElement::setMultiple):
- html/HTMLDataGridElement.h:
- html/HTMLDataGridElement.idl:
- html/HTMLDataGridRowElement.cpp: Added. (WebCore::HTMLDataGridRowElement::HTMLDataGridRowElement): (WebCore::HTMLDataGridRowElement::selected): (WebCore::HTMLDataGridRowElement::setSelected): (WebCore::HTMLDataGridRowElement::focused): (WebCore::HTMLDataGridRowElement::setFocused):
- html/HTMLDataGridRowElement.h: Added. (WebCore::HTMLDataGridRowElement::tagPriority):
- html/HTMLDataGridRowElement.idl: Added.
- html/HTMLTagNames.in:
- 9:32 AM Changeset in webkit [44936] by
-
- 2 edits in trunk/LayoutTests
2009-06-22 Darin Adler <Darin Adler>
- platform/gtk/Skipped: Skip two new tests.
- 8:44 AM Changeset in webkit [44935] by
-
- 2 edits in trunk/LayoutTests
2009-06-22 Darin Adler <Darin Adler>
- fast/js/JSON-stringify-expected.txt: Update results.
- 6:22 AM Changeset in webkit [44934] by
-
- 3 edits1 add in trunk/WebCore
2009-06-19 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Holger Freyther.
Fix a crash in case that the QNetworkReply::readReady signal is
"stuck" in deferred mode due to JavaScript alert, and in the meantime,
QNetworkreply::finished signal is received and processed before
QNetworkReply::readReady is processed.
- manual-tests/qt/unload-alert.html: Added.
- platform/network/qt/QNetworkReplyHandler.cpp:
- platform/network/qt/QNetworkReplyHandler.h:
- 4:55 AM Changeset in webkit [44933] by
-
- 2 edits in trunk/WebCore
2009-06-22 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Fix the Qt build.
- WebCore.pro:
- 12:33 AM Changeset in webkit [44932] by
-
- 2 edits in trunk/WebKitTools
Set up global native controls flag before creating the first WebView.
Reviewed by Darin Adler.
- DumpRenderTree/win/DumpRenderTree.cpp: (main):
Jun 21, 2009:
- 11:35 PM Changeset in webkit [44931] by
-
- 6 edits in trunk
Bug 26592: Support standard toJSON functions
<https://bugs.webkit.org/show_bug.cgi?id=26592>
Reviewed by Darin Adler
Add support for the standard Date.toJSON function.
- 11:17 PM Changeset in webkit [44930] by
-
- 4 edits in trunk/WebCore
2009-06-21 Darin Adler <Darin Adler>
Reviewed by Sam Weinig.
Bug 25425: DOM attribute getter/setter functions should use const AtomicString& type
https://bugs.webkit.org/show_bug.cgi?id=25425
- bindings/scripts/CodeGeneratorJS.pm: Tweaked mechanism for includes to be a bit more consistent and to make SVGElement.h be included in the header rather than in every implementation file that includes the header. Added code to use getAttribute and setAttribute directly when the [Reflect] extended attribute is used.
- bindings/scripts/CodeGeneratorObjC.pm: Ditto.
- html/HTMLElement.idl: Used [Reflect] for all the attributes in this class that reflect content attributes. Restricting this to one class for now to keep the patch small and start out slowly.
- 10:08 PM Changeset in webkit [44929] by
-
- 3 edits3 adds in trunk
Bug 26594: JSC needs to support Date.toISOString
<https://bugs.webkit.org/show_bug.cgi?id=26594>
Reviewed by Sam Weinig
Add support for Date.toISOString.
- 9:59 PM Changeset in webkit [44928] by
-
- 7 edits3 adds in trunk
WebCore:
2009-06-21 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Fix for https://bugs.webkit.org/show_bug.cgi?id=26596
Only expose event handler attributes to elements and documents.
Test: fast/dom/event-attribute-availability.html
- dom/Document.idl:
- dom/Element.idl:
- dom/Node.cpp:
- dom/Node.h:
- dom/Node.idl:
LayoutTests:
2009-06-21 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Test for https://bugs.webkit.org/show_bug.cgi?id=26596
Only expose event handler attributes to elements and documents.
- fast/dom/event-attribute-availability-expected.txt: Added.
- fast/dom/event-attribute-availability.html: Added.
- fast/dom/resources/event-attribute-availability.js: Added.
- 6:39 PM Changeset in webkit [44927] by
-
- 4 edits3 adds in trunk
WebCore:
2009-06-21 Daniel Bates <dbates@intudata.com>
Reviewed by Adam Barth.
Fix to enable XSSAuditor on child windows.
Test: http/tests/security/xssAuditor/link-opens-new-window.html
- page/XSSAuditor.cpp: (WebCore::XSSAuditor::XSSAuditor): (WebCore::XSSAuditor::isEnabled): (WebCore::XSSAuditor::canEvaluate): (WebCore::XSSAuditor::canCreateInlineEventListener): (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): (WebCore::XSSAuditor::canLoadObject):
- page/XSSAuditor.h: Removed method setXSSAuditorEnabled, and field m_isEnabled. Moved implementation of isEnabled to XSSAuditor.cpp and changed implementation to query Settings.
LayoutTests:
2009-06-21 Daniel Bates <dbates@intudata.com>
Reviewed by Adam Barth.
Tests that XSSAuditor (if enabled) prevents script execution in child window.
- http/tests/security/xssAuditor/link-opens-new-window-expected.txt: Added.
- http/tests/security/xssAuditor/link-opens-new-window.html: Added.
- http/tests/security/xssAuditor/resources/echo-intertag-and-notify.php: Added.
- 5:23 PM Changeset in webkit [44926] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Mark Rowe.
- make repaint tests more reliable when run in Safari
- fast/repaint/resources/repaint.js: (runRepaintTest): Increased the timeout from 0 to 100, to ensure that painting occurs once before repaintTest() is called.
- 5:03 PM Changeset in webkit [44925] by
-
- 2 edits in trunk/WebKitTools
Set a sensible user agent string for the HTTP requests that Sparkle makes (checking for and downloading updates).
Reviewed by Sam Weinig.
- WebKitLauncher/WebKitNightlyEnablerSparkle.m:
(userAgentStringForSparkle):
(initializeSparkle):
- 4:32 PM Changeset in webkit [44924] by
-
- 2 edits in trunk/JavaScriptCore
Fix build by removing dead code.
- 4:02 PM Changeset in webkit [44923] by
-
- 7 edits3 adds in trunk
Bug 26587: Support JSON.parse
<https://bugs.webkit.org/show_bug.cgi?id=26587>
Reviewed by Darin Adler and Cameron Zwarich.
Extend the LiteralParser to support the full strict JSON
grammar, fix a few places where the grammar was incorrectly
lenient. Doesn't yet support the JSON.parse reviver function
but that does not block the JSON.parse functionality itself.
- 3:46 PM Changeset in webkit [44922] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-21 David Levin <levin@chromium.org>
Reviewed by NOBODY (speculative build fix for windows).
Simply removed some whitespace form this file to make windows build wtf and
hopefully copy the new MessageQueque.h so that WebCore picks it up.
- wtf/Assertions.cpp:
- 3:16 PM Changeset in webkit [44921] by
-
- 2 edits in trunk/WebCore
2009-06-21 David Levin <levin@chromium.org>
Reviewed by NOBODY.
Speculative windows build fix (idea by Mark Rowe).
- WebCore.vcproj/WebCore.vcproj:
- 3:03 PM Changeset in webkit [44920] by
-
- 2 edits2 adds in trunk/WebKitTools
Add a hook to the WebKit launcher application to allow a link on the nightly build start page to
trigger an update via the built-in software update mechanism.
Reviewed by Sam Weinig.
- WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
- WebKitLauncher/WebKitLauncherURLProtocol.h: Added.
- WebKitLauncher/WebKitLauncherURLProtocol.m: Added.
(+[WebKitLauncherURLProtocol load]):
(+[WebKitLauncherURLProtocol canInitWithRequest:]): Only allow use of the x-webkit-launcher scheme from .webkit.org subdomains.
(+[WebKitLauncherURLProtocol canonicalRequestForRequest:]):
(-[WebKitLauncherURLProtocol startLoading]):
(-[WebKitLauncherURLProtocol stopLoading]):
(-[WebKitLauncherURLProtocol handleIsWebKitLauncherAvailableJS]): Return a brief JavaScript snippet that can be used to programatically
determine whether the x-webkit-launcher is available and working.
(-[WebKitLauncherURLProtocol handleCheckForUpdates]): Trigger a software update on the main thread.
(-[WebKitLauncherURLProtocol resourceNotFound]): Fail with a generic "File does not exist" error.
- 3:02 PM Changeset in webkit [44919] by
-
- 2 edits in trunk/WebCore
2009-06-21 David Levin <levin@chromium.org>
Reviewed by NOBODY (Speculative gtk build fix).
- GNUmakefile.am:
- 2:56 PM Changeset in webkit [44918] by
-
- 3 edits in trunk/WebCore
2009-06-21 David Levin <levin@chromium.org>
Reviewed by NOBODY.
Speculative tiger build fix and a windows build fix.
More fixes may still be in order.
- WebCore.vcproj/WebCoreCommon.vsprops:
- dom/default/PlatformMessagePortChannel.h: (WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage):
- 2:46 PM Changeset in webkit [44917] by
-
- 2 edits in trunk/WebCore
2009-06-21 David Levin <levin@chromium.org>
Reviewed by NOBODY (Speculative tiger build fix).
- dom/default/PlatformMessagePortChannel.h: (WebCore::PlatformMessagePortChannel::MessagePortQueue::~MessagePortQueue):
- 2:32 PM Changeset in webkit [44916] by
-
- 9 edits2 adds in trunk
WebCore:
2009-06-21 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
Added optimized GC for MessagePorts when the entangled port is run by the same thread.
Fixed bug in isProxyFor() that was not properly throwing an exception when trying to clone the entangled port.
- bindings/js/JSDOMBinding.cpp: (WebCore::markActiveObjectsForContext): Now marks remotely entangled ports as in-use, in addition to those with pending activity.
- bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::mark): Now checks if the entangled port is local (run by same thread) and if so mark()s it.
- dom/MessagePort.cpp: (WebCore::MessagePort::postMessage): (WebCore::MessagePort::disentangle): Removes cloned ports from the ScriptExecutionContext - this allows cloned ports to be GC'd as otherwise they look like remotely entangled ports. (WebCore::MessagePort::start): (WebCore::MessagePort::locallyEntangledPort): Added API for fetching the entangled port if it is run by the same thread
- dom/MessagePort.h:
- dom/MessagePortProxyWrapper.h:
- dom/default/MessagePortProxy.cpp: (WebCore::MessagePortProxyWrapper::locallyEntangledPort): Added API for fetching the entangled port if it is run by the same thread (WebCore::MessagePortProxy::hasPendingActivity): Changed definition of hasPendingActivity() to be stricter - only returns true if there are pending messages. (WebCore::MessagePortProxy::locallyEntangledPort):
- dom/default/MessagePortProxy.h:
LayoutTests:
2009-06-21 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
New tests for MessagePort GC cases that weren't previously covered.
- fast/events/message-channel-gc-4-expected.txt: Added. Test for case where both MessagePorts are in-transit (cloned) when a GC occurs.
- fast/events/message-channel-gc-4.html-disabled: Added.
- 2:32 PM Changeset in webkit [44915] by
-
- 23 edits1 move7 adds2 deletes in trunk
2009-06-21 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
<https://bugs.webkit.org/show_bug.cgi?id=25043>
Added support for multi-threaded MessagePorts.
- wtf/MessageQueue.h: (WTF::::appendAndCheckEmpty):
Added API to test whether the queue was empty before adding an element.
WebCore:
2009-06-21 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
<https://bugs.webkit.org/show_bug.cgi?id=25043>
Removed obsolete MessagePort.startConversation(), active and onclose APIs.
Refactored MessagePortProxy into MessagePortChannel and a platform-dependent PlatformMessagePortChannel
implementation. Modified APIs to simplify cross-process implementations by moving the messaging code
entirely into the platform-dependent proxy.
Created a thread-safe default PlatformMessagePortChannel implementation.
Changed DOMWindow messaging to create the MessageEvent in the target ScriptExecutionContext to match how
cross-thread MessagePorts work.
- GNUMakefile.am:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
Added MessagePortChannel/PlatformMessagePortChannel files.
- bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::mark):
Changed ports to not mark their entangled pair as reachable, per the spec.
- bindings/v8/custom/V8MessagePortCustom.cpp:
- dom/MessageChannel.cpp: (WebCore::MessageChannel::MessageChannel):
Updated to use PlatformMessagePortChannel::createChannel() to entangle the ports.
- dom/MessagePort.cpp: (WebCore::MessagePort::MessagePort): (WebCore::MessagePort::~MessagePort): (WebCore::MessagePort::postMessage): (WebCore::MessagePort::disentangle): (WebCore::MessagePort::messageAvailable): (WebCore::MessagePort::start): (WebCore::MessagePort::close): (WebCore::MessagePort::entangle): (WebCore::MessagePort::contextDestroyed): (WebCore::MessagePort::dispatchMessages): (WebCore::MessagePort::setOnmessage): (WebCore::MessagePort::hasPendingActivity):
Changed these APIs to delegate to new PlatformMessagePortChannel APIs.
- dom/MessagePort.h:
Renamed isQueueOpen() to started().
- dom/MessagePort.idl:
Removed startConversation and onclose.
- dom/MessagePortProxy.h: Removed.
- dom/MessagePortChannel.cpp: Added. (WebCore::MessagePortChannel::EventData::create): (WebCore::MessagePortChannel::EventData::EventData): (WebCore::MessagePortChannel::~MessagePortChannel):
- dom/MessagePortChannel.h: Added. (WebCore::MessagePortChannel::EventData::message): (WebCore::MessagePortChannel::EventData::channel):
Changed EventData to hold a reference to a MessagePortChannel object instead of a MessagePort to enable cross-thread messaging.
(WebCore::MessagePortChannel::MessagePortChannel):
(WebCore::MessagePortChannel::create):
- dom/ScriptExecutionContext.cpp: (WebCore:ScriptExecutionContext::dispatchMessagePortEvents):
Renamed isQueueOpen() to started().
- dom/default/PlatformMessagePortChannel.cpp: Added. (WebCore::MessagePortChannel::entangleIfOpen): (WebCore::MessagePortChannel::disentangle): (WebCore::MessagePortChannel::postMessageToRemote): (WebCore::MessagePortChannel::tryGetMessageFromRemote): (WebCore::MessagePortChannel::close): (WebCore::MessagePortChannel::isConnectedTo): (WebCore::MessagePortChannel::hasPendingActivity): (WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel): (WebCore::PlatformMessagePortChannel::~PlatformMessagePortChannel): (WebCore::PlatformMessagePortChannel::createChannel): (WebCore::PlatformMessagePortChannel::entangleIfOpen): (WebCore::PlatformMessagePortChannel::disentangle): (WebCore::PlatformMessagePortChannel::setRemotePort): (WebCore::PlatformMessagePortChannel::remotePort): (WebCore::PlatformMessagePortChannel::entangledChannel): (WebCore::PlatformMessagePortChannel::setEntangledChannel): (WebCore::PlatformMessagePortChannel::postMessageToRemote): (WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote): (WebCore::PlatformMessagePortChannel::isConnectedTo): (WebCore::PlatformMessagePortChannel::close): (WebCore::PlatformMessagePortChannel::closeInternal): (WebCore::PlatformMessagePortChannel::hasPendingActivity):
- dom/default/PlatformMessagePortChannel.h: Added. (WebCore::PlatformMessagePortChannel::MessagePortQueue::create): (WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage): (WebCore::PlatformMessagePortChannel::MessagePortQueue::appendAndCheckEmpty): (WebCore::PlatformMessagePortChannel::MessagePortQueue::isEmpty): (WebCore::PlatformMessagePortChannel::MessagePortQueue::MessagePortQueue):
- page/DOMWindow.cpp: (WebCore::PostMessageTimer::PostMessageTimer):
Changed DOMWindow messaging to create the MessageEvent in the target ScriptExecutionContext to match how cross-thread MessagePorts work.
(WebCore::PostMessageTimer::event):
(WebCore::DOMWindow::postMessage):
(WebCore::DOMWindow::postMessageTimerFired):
LayoutTests:
2009-06-21 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
<https://bugs.webkit.org/show_bug.cgi?id=25043>
Updated MessageChannel/MessagePorts tests to reflect latest spec (close event has been removed).
Added more tests of port cloning.
- fast/events/message-channel-gc-2-expected.txt:
- fast/events/message-channel-gc-2.html-disabled:
- fast/events/message-channel-gc-3-expected.txt:
- fast/events/message-channel-gc-3.html-disabled:
- fast/events/message-channel-gc-expected.txt:
- fast/events/message-channel-gc.html-disabled:
- fast/events/message-port-clone-expected.txt: Added.
- fast/events/message-port-clone.html-disabled: Added.
- fast/events/message-port-expected.txt:
- fast/events/message-port-no-wrapper-expected.txt: Added.
- fast/events/message-port-onclose-expected.txt: Removed.
- fast/events/message-port-onclose.html-disabled: Removed.
- fast/events/message-port.html-disabled:
- 1:56 PM Changeset in webkit [44914] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Sam Weinig.
- fix https://bugs.webkit.org/show_bug.cgi?id=15383 <rdar://problem/5682745> resize: vertical does not restrict to vertical resize
Test: fast/css/resize-single-axis.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::resize): Ignore movement along the non-resizing axis.
LayoutTests:
Reviewed by Sam Weinig.
- test for https://bugs.webkit.org/show_bug.cgi?id=15383 <rdar://problem/5682745> resize: vertical does not restrict to vertical resize
- fast/css/resize-single-axis-expected.txt: Added.
- fast/css/resize-single-axis.html: Added.
- 1:47 PM Changeset in webkit [44913] by
-
- 3 edits2 adds in trunk
WebCore:
2009-06-21 Sam Weinig <sam@webkit.org>
Reviewed by Eric Seidel
Fix for https://bugs.webkit.org/show_bug.cgi?id=26578
event.currentTarget for listener registered on window should point to the window object like in Firefox
Test: fast/events/event-trace.html
- dom/Node.cpp: (WebCore::Node::dispatchGenericEvent): Make the DOMWindow the currentTarget when events are dispatched to it. We previously used the document because DOMWindow was not yet an EventTarget.
LayoutTests:
2009-06-21 Sam Weinig <sam@webkit.org>
Reviewed by Eric Seidel.
Test for https://bugs.webkit.org/show_bug.cgi?id=26578
event.currentTarget for listener registered on window should point to the window object like in Firefox
- fast/events/event-trace-expected.txt: Added.
- fast/events/event-trace.html: Added.
- 1:16 PM Changeset in webkit [44912] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Sam Weinig.
- fix https://bugs.webkit.org/show_bug.cgi?id=9694 resize value not compared
Test: fast/css/resize-value-compared.html
- rendering/style/StyleRareInheritedData.cpp: (WebCore::StyleRareInheritedData::operator==): Compare the resize member.
LayoutTests:
Reviewed by Sam Weinig.
- test for https://bugs.webkit.org/show_bug.cgi?id=9694 resize value not compared
- fast/css/resize-value-compared-expected.txt: Added.
- fast/css/resize-value-compared.html: Added.
- 12:19 AM Changeset in webkit [44911] by
-
- 2 edits in trunk/LayoutTests
2009-06-21 Darin Adler <Darin Adler>
- platform/gtk/Skipped: Skip one more test.