Timeline



Jun 25, 2010:

11:37 PM Changeset in webkit [61948] by hclam@chromium.org
  • 195 edits in trunk/LayoutTests

2010-06-25 Alpha Lam <​hclam@chromium.org>

Unreviewed. Build fix.

Build fix for r61908. Updating test expectations.

  • platform/chromium-linux/css1/basic/containment-expected.checksum:
  • platform/chromium-linux/css1/basic/containment-expected.png:
  • platform/chromium-linux/css1/box_properties/padding_right-expected.checksum:
  • platform/chromium-linux/css1/box_properties/padding_right-expected.png:
  • platform/chromium-linux/css1/font_properties/font_size-expected.checksum:
  • platform/chromium-linux/css1/font_properties/font_size-expected.png:
  • platform/chromium-linux/editing/selection/5354455-1-expected.checksum:
  • platform/chromium-linux/editing/selection/5354455-1-expected.png:
  • platform/chromium-linux/editing/selection/5354455-2-expected.checksum:
  • platform/chromium-linux/editing/selection/5354455-2-expected.png:
  • platform/chromium-linux/editing/selection/move-by-line-001-expected.checksum:
  • platform/chromium-linux/editing/selection/move-by-line-001-expected.png:
  • platform/chromium-linux/fast/backgrounds/001-expected.checksum:
  • platform/chromium-linux/fast/backgrounds/001-expected.png:
  • platform/chromium-linux/fast/block/float/nested-clearance-expected.checksum:
  • platform/chromium-linux/fast/block/float/nested-clearance-expected.png:
  • platform/chromium-linux/fast/block/positioning/051-expected.checksum:
  • platform/chromium-linux/fast/block/positioning/051-expected.png:
  • platform/chromium-linux/fast/block/positioning/055-expected.checksum:
  • platform/chromium-linux/fast/block/positioning/055-expected.png:
  • platform/chromium-linux/fast/css/last-of-type-pseudo-class-expected.checksum:
  • platform/chromium-linux/fast/css/last-of-type-pseudo-class-expected.png:
  • platform/chromium-linux/fast/events/5056619-expected.checksum:
  • platform/chromium-linux/fast/events/5056619-expected.png:
  • platform/chromium-linux/fast/forms/input-text-scroll-left-on-blur-expected.checksum:
  • platform/chromium-linux/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-linux/fast/forms/search-display-none-cancel-button-expected.checksum:
  • platform/chromium-linux/fast/forms/search-display-none-cancel-button-expected.png:
  • platform/chromium-linux/fast/forms/search-placeholder-value-changed-expected.checksum:
  • platform/chromium-linux/fast/forms/search-placeholder-value-changed-expected.png:
  • platform/chromium-linux/fast/forms/select-change-listbox-size-expected.checksum:
  • platform/chromium-linux/fast/forms/select-change-listbox-size-expected.png:
  • platform/chromium-linux/fast/forms/tabbing-input-iframe-expected.checksum:
  • platform/chromium-linux/fast/forms/tabbing-input-iframe-expected.png:
  • platform/chromium-linux/fast/frames/iframe-scrolling-attribute-expected.checksum:
  • platform/chromium-linux/fast/frames/iframe-scrolling-attribute-expected.png:
  • platform/chromium-linux/fast/frames/onlyCommentInIFrame-expected.checksum:
  • platform/chromium-linux/fast/frames/onlyCommentInIFrame-expected.png:
  • platform/chromium-linux/fast/frames/viewsource-attribute-expected.checksum:
  • platform/chromium-linux/fast/frames/viewsource-attribute-expected.png:
  • platform/chromium-linux/fast/lists/drag-into-marker-expected.checksum:
  • platform/chromium-linux/fast/lists/drag-into-marker-expected.png:
  • platform/chromium-linux/fast/multicol/column-rules-stacking-expected.checksum:
  • platform/chromium-linux/fast/multicol/column-rules-stacking-expected.png:
  • platform/chromium-linux/fast/multicol/positioned-with-constrained-height-expected.checksum:
  • platform/chromium-linux/fast/multicol/positioned-with-constrained-height-expected.png:
  • platform/chromium-linux/fast/repaint/box-shadow-v-expected.checksum:
  • platform/chromium-linux/fast/repaint/box-shadow-v-expected.png:
  • platform/chromium-linux/fast/repaint/list-marker-expected.checksum:
  • platform/chromium-linux/fast/repaint/list-marker-expected.png:
  • platform/chromium-linux/fast/repaint/overflow-scroll-delete-expected.checksum:
  • platform/chromium-linux/fast/repaint/overflow-scroll-delete-expected.png:
  • platform/chromium-linux/fast/replaced/width100percent-menulist-expected.checksum:
  • platform/chromium-linux/fast/replaced/width100percent-menulist-expected.png:
  • platform/chromium-linux/fast/replaced/width100percent-searchfield-expected.checksum:
  • platform/chromium-linux/fast/replaced/width100percent-searchfield-expected.png:
  • platform/chromium-linux/fast/text/international/thai-line-breaks-expected.checksum:
  • platform/chromium-linux/fast/text/international/thai-line-breaks-expected.png:
  • platform/chromium-linux/http/tests/navigation/error404-frames-expected.checksum:
  • platform/chromium-linux/http/tests/navigation/error404-frames-expected.png:
  • platform/chromium-linux/http/tests/navigation/error404-goback-expected.checksum:
  • platform/chromium-linux/http/tests/navigation/error404-goback-expected.png:
  • platform/chromium-linux/http/tests/navigation/post-frames-expected.checksum:
  • platform/chromium-linux/http/tests/navigation/post-frames-expected.png:
  • platform/chromium-linux/http/tests/navigation/postredirect-frames-expected.checksum:
  • platform/chromium-linux/http/tests/navigation/postredirect-frames-expected.png:
  • platform/chromium-linux/platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle-expected.checksum:
  • platform/chromium-linux/platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-02-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-02-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-path-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-path-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png:
  • platform/chromium-linux/svg/carto.net/button-expected.checksum:
  • platform/chromium-linux/svg/carto.net/button-expected.png:
  • platform/chromium-linux/svg/carto.net/combobox-expected.checksum:
  • platform/chromium-linux/svg/carto.net/combobox-expected.png:
  • platform/chromium-linux/svg/carto.net/slider-expected.checksum:
  • platform/chromium-linux/svg/carto.net/slider-expected.png:
  • platform/chromium-linux/svg/carto.net/textbox-expected.checksum:
  • platform/chromium-linux/svg/carto.net/textbox-expected.png:
  • platform/chromium-linux/svg/custom/animate-path-morphing-expected.checksum:
  • platform/chromium-linux/svg/custom/animate-path-morphing-expected.png:
  • platform/chromium-linux/svg/custom/js-update-transform-changes-expected.checksum:
  • platform/chromium-linux/svg/custom/js-update-transform-changes-expected.png:
  • platform/chromium-linux/svg/custom/marker-viewBox-changes-expected.checksum:
  • platform/chromium-linux/svg/custom/marker-viewBox-changes-expected.png:
  • platform/chromium-linux/svg/custom/use-property-changes-through-svg-dom-expected.checksum:
  • platform/chromium-linux/svg/custom/use-property-changes-through-svg-dom-expected.png:
  • platform/chromium-linux/svg/custom/use-referencing-nonexisting-symbol-expected.checksum:
  • platform/chromium-linux/svg/custom/use-referencing-nonexisting-symbol-expected.png:
  • platform/chromium-linux/svg/custom/use-transform-expected.checksum:
  • platform/chromium-linux/svg/custom/use-transform-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/45621-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/45621-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug137388-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug137388-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-1-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-4-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-4-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug28341-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug28341-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug29314-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug29314-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2997-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug2997-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug32205-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug32205-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug3977-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug3977-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug43854-1-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug43854-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug44505-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug44505-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug650-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug650-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug73321-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug73321-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug96343-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug96343-expected.png:
  • platform/chromium-linux/tables/mozilla/core/captions-expected.checksum:
  • platform/chromium-linux/tables/mozilla/core/captions-expected.png:
  • platform/chromium-linux/tables/mozilla/core/cell_heights-expected.checksum:
  • platform/chromium-linux/tables/mozilla/core/cell_heights-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/other/nestedTables-expected.checksum:
  • platform/chromium-linux/tables/mozilla/other/nestedTables-expected.png:
  • platform/chromium-linux/tables/mozilla/other/test3-expected.checksum:
  • platform/chromium-linux/tables/mozilla/other/test3-expected.png:
  • platform/chromium-linux/tables/mozilla/other/wa_table_thtd_rowspan-expected.checksum:
  • platform/chromium-linux/tables/mozilla/other/wa_table_thtd_rowspan-expected.png:
  • platform/chromium-linux/tables/mozilla/other/wa_table_tr_align-expected.checksum:
  • platform/chromium-linux/tables/mozilla/other/wa_table_tr_align-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug10140-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug10140-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1055-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug106966-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug106966-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug22122-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug22122-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug80762-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug89315-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug91057-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug91057-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/backgrounds-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/backgrounds-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/col_span2-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/col_span2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/other/empty_cells-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/other/empty_cells-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/other/test4-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/other/test4-expected.png:
11:34 PM Changeset in webkit [61947] by hclam@chromium.org
  • 3 edits
    1 add in trunk/LayoutTests

Unreviewed. Build fix.

More test expectations cleanup for r61908.

  • platform/chromium-linux/printing/return-from-printing-mode-expected.checksum:
  • platform/chromium-linux/printing/return-from-printing-mode-expected.png: Added.
  • platform/chromium/test_expectations.txt:
11:25 PM Changeset in webkit [61946] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-25 Nathan Lawrence <​nlawrence@apple.com>

Reviewed by Geoffrey Garen.

We assume in testapi.c that the value aHeapRef refers to will not be
moved. When we have movable objects, this will not be the case.

  • API/tests/testapi.c: (main):
11:19 PM Changeset in webkit [61945] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-25 Adam Barth <​abarth@webkit.org>

Unreviewed.

Skip fast/events/popup-when-select-change.html because GTK doesn't have
an eventSender implementation.

  • platform/gtk/Skipped:
11:03 PM Changeset in webkit [61944] by sfalken@apple.com
  • 2 edits in trunk/WebKit2

Windows build fix.

  • win/WebKit2.vcproj:
11:02 PM Changeset in webkit [61943] by commit-queue@webkit.org
  • 4 edits
    6 adds in trunk/WebKit/chromium

2010-06-25 Jay Civelli <​jcivelli@chromium.org>

Reviewed by Darin Fisher.

[chromium] Made WebFrame not report the text from hidden frames.
(some pages contain hidden frames with garbage text that
should not be indexed or used to detect the page's language).
​https://bugs.webkit.org/show_bug.cgi?id=39456

  • DEPS:
  • WebKit.gyp:
  • src/WebFrameImpl.cpp: (WebKit::frameContentAsPlainText):
  • tests/RunAllTests.cpp: (main):
  • tests/WebFrameTest.cpp: Added.
  • tests/data: Added.
  • tests/data/iframes_test.html: Added.
  • tests/data/invisible_iframe.html: Added.
  • tests/data/visible_iframe.html: Added.
  • tests/data/zero_sized_iframe.html: Added.
10:51 PM Changeset in webkit [61942] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-06-25 Bernhard Bauer <​bauerb@chromium.org>

Reviewed by Darin Fisher.

Add plugin accessors to WebPluginContainer.
​https://bugs.webkit.org/show_bug.cgi?id=41145

  • public/WebPluginContainer.h:
  • src/WebPluginContainerImpl.h: (WebKit::WebPluginContainerImpl::setPlugin):
10:39 PM Changeset in webkit [61941] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

2010-06-25 Johnny Ding <​jnd@chromium.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=41061
Make sure the window can be opened in a user initiated event instead of blocking by popup blocker.

  • fast/events/popup-when-select-change-expected.txt: Added.
  • fast/events/popup-when-select-change.html: Added.

2010-06-25 Johnny Ding <​jnd@chromium.org>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=41061
Make sure Chromium's ScriptController::processingUserGesture follows the JSC's behavior.
Set right value in UserGestureIndicator when handling events in PopupMenuList in chromium.

Test: fast/events/popup-when-select-change.html

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture):
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupContainer::handleMouseDownEvent): (WebCore::PopupContainer::handleMouseMoveEvent): (WebCore::PopupContainer::handleMouseReleaseEvent): (WebCore::PopupContainer::handleWheelEvent): (WebCore::PopupContainer::handleKeyEvent):
10:27 PM Changeset in webkit [61940] by tonyg@chromium.org
  • 5 edits in trunk/WebCore

2010-06-25 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Eric Seidel.

Make PendingScript hold a CachedResourceClient open for its lifetime
​https://bugs.webkit.org/show_bug.cgi?id=40968

This replaces the mechanism introduced in r61374 with a simpler
appraoch for preventing unexpected purges: always keep a client open.
This approach will allow deferred scripts to add a client after
the resource may have already been loaded without having to worry about
the buffer being purged in the meantime.

No new tests because making a CachedResource purse itself is not
testable from a LayoutTest.

  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::watchForLoad): (WebCore::HTMLDocumentParser::notifyFinished):
  • html/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::~HTMLScriptRunner): (WebCore::HTMLScriptRunner::sourceFromPendingScript): (WebCore::HTMLScriptRunner::isPendingScriptReady): (WebCore::HTMLScriptRunner::executePendingScript): (WebCore::HTMLScriptRunner::watchForLoad): (WebCore::HTMLScriptRunner::stopWatchingForLoad): (WebCore::HTMLScriptRunner::executeScriptsWaitingForLoad): (WebCore::HTMLScriptRunner::requestScript): (WebCore::HTMLScriptRunner::PendingScript::~PendingScript): (WebCore::HTMLScriptRunner::PendingScript::releaseElementAndClear): (WebCore::HTMLScriptRunner::PendingScript::setCachedScript): (WebCore::HTMLScriptRunner::PendingScript::cachedScript):
  • html/HTMLScriptRunner.h: (WebCore::HTMLScriptRunner::PendingScript::PendingScript): (WebCore::HTMLScriptRunner::PendingScript::watchingForLoad): (WebCore::HTMLScriptRunner::PendingScript::setWatchingForLoad): (WebCore::HTMLScriptRunner::PendingScript::notifyFinished):
  • html/HTMLScriptRunnerHost.h:
9:53 PM Changeset in webkit [61939] by zmo@google.com
  • 6 edits
    2 adds in trunk

2010-06-25 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

getUniform will not work for fetching uniform array elements
​https://bugs.webkit.org/show_bug.cgi?id=34508

  • fast/canvas/webgl/gl-uniform-arrays-expected.txt: Added.
  • fast/canvas/webgl/gl-uniform-arrays.html: Added.
  • fast/canvas/webgl/incorrect-context-object-behaviour-expected.txt: Change the test so we test the return error explicitly.
  • fast/canvas/webgl/script-tests/incorrect-context-object-behaviour.js: Ditto.

2010-06-25 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

getUniform will not work for fetching uniform array elements
​https://bugs.webkit.org/show_bug.cgi?id=34508

Test: fast/canvas/webgl/gl-uniform-arrays.html

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::attachShader): Generate correct errors. (WebCore::WebGLRenderingContext::getUniform): Dealing with array elements. (WebCore::WebGLRenderingContext::useProgram): Deal with program==null. (WebCore::WebGLRenderingContext::validateProgram): Generate correct errors.
  • platform/graphics/mac/GraphicsContext3DMac.mm: (WebCore::GraphicsContext3D::useProgram): Deal with program==null.
9:23 PM Changeset in webkit [61938] by zmo@google.com
  • 4 edits
    5 adds in trunk

2010-06-25 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

Bring set/get state functions to GLES2 conformance
​https://bugs.webkit.org/show_bug.cgi?id=41095

  • fast/canvas/webgl/gl-enable-enum-test-expected.txt: Added.
  • fast/canvas/webgl/gl-enable-enum-test.html: Added.
  • fast/canvas/webgl/gl-enum-tests-expected.txt: Added.
  • fast/canvas/webgl/gl-enum-tests.html: Added.
  • fast/canvas/webgl/resources/desktop-gl-constants.js: Added.

2010-06-25 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

Bring set/get state functions to GLES2 conformance
​https://bugs.webkit.org/show_bug.cgi?id=41095

Tests: fast/canvas/webgl/gl-enable-enum-test.html

fast/canvas/webgl/gl-enum-tests.html

  • html/canvas/WebGLRenderingContext.cpp: Check input parameters according to GLES2 spec. (WebCore::WebGLRenderingContext::blendEquation): (WebCore::WebGLRenderingContext::blendEquationSeparate): (WebCore::WebGLRenderingContext::disable): (WebCore::WebGLRenderingContext::enable): (WebCore::WebGLRenderingContext::hint): (WebCore::WebGLRenderingContext::isEnabled): (WebCore::WebGLRenderingContext::pixelStorei): (WebCore::WebGLRenderingContext::validateBlendEquation): (WebCore::WebGLRenderingContext::validateCapability):
  • html/canvas/WebGLRenderingContext.h: Add helper function declaration.
8:40 PM Changeset in webkit [61937] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-06-25 Sterling Swigart <​sswigart@google.com>

Reviewed by David Levin.

Callback code generation fixed so that now string parameters are converted to JSString
using the jsString method instead of the toJS method which would not compile.
​https://bugs.webkit.org/show_bug.cgi?id=41119

  • bindings/scripts/CodeGeneratorJS.pm: Now generates jsString for String parameters in callbacks.
  • bindings/scripts/test/JS/JSTestCallback.cpp: Fixed test for above. (WebCore::JSTestCallback::callbackWithClass2Param): Ditto.
8:22 PM Changeset in webkit [61936] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-06-25 Sterling Swigart <​sswigart@google.com>

Reviewed by David Levin.

Resetting ENABLE_IMAGE_RESIZER to 0. Image.webkitGetImage needs to be developed under
a 0 value, at least until both the JSC and V8 bindings are in place.
​https://bugs.webkit.org/show_bug.cgi?id=41116

  • features.gypi: ENABLE_IMAGE_RESIZER=0
7:59 PM Changeset in webkit [61935] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-06-25 Luiz Agostini <​luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QtWebKit crashes if <select>'s render changes in its onchange event
​https://bugs.webkit.org/show_bug.cgi?id=41164

QtWebKit crashes if <select>'s renderer changes in its onchange event.

  • WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::~QtFallbackWebPopup):
7:47 PM Changeset in webkit [61934] by zmo@google.com
  • 5 edits
    2 adds in trunk

2010-06-25 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

A buffer should be bound to one target in its lifetime
​https://bugs.webkit.org/show_bug.cgi?id=41108

  • fast/canvas/webgl/buffer-bind-test-expected.txt: Added.
  • fast/canvas/webgl/buffer-bind-test.html: Added.

2010-06-25 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

A buffer should be bound to one target in its lifetime
​https://bugs.webkit.org/show_bug.cgi?id=41108

Test: fast/canvas/webgl/buffer-bind-test.html

  • html/canvas/WebGLBuffer.cpp: (WebCore::WebGLBuffer::WebGLBuffer): Init target to 0. (WebCore::WebGLBuffer::associateBufferData): Remove target parameter, use one byteLength member. (WebCore::WebGLBuffer::associateBufferSubData): Ditto. (WebCore::WebGLBuffer::byteLength): Ditto. (WebCore::WebGLBuffer::setTarget): Set target.
  • html/canvas/WebGLBuffer.h: Cache target in the WebGLBuffer object, use one byteLength member. (WebCore::WebGLBuffer::getTarget):
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::bindBuffer): Check if a buffer is bound to another target; set buffer object internal target. (WebCore::WebGLRenderingContext::bufferData): Remove target parameter and use the WebGLBuffer cached target instead. (WebCore::WebGLRenderingContext::bufferSubData): Ditto. (WebCore::WebGLRenderingContext::validateElementArraySize): Ditto. (WebCore::WebGLRenderingContext::validateIndexArrayConservative): Ditto. (WebCore::WebGLRenderingContext::vertexAttribPointer): Ditto.
7:01 PM Changeset in webkit [61933] by dino@apple.com
  • 4 edits
    5 adds
    4 deletes in trunk

2010-06-25 Dean Jackson <​dino@apple.com>

Reviewed by Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=41188
Animations should not require 0% and 100% keyframes

When we are generating the animation lists in CSSStyleSelector,
rather than bail if we notice that "from" or "to" are missing, we
now generate synthetic keyframes for those cases.

Tests: animations/missing-from-to-transforms.html

animations/missing-from-to.html
WebCore/manual-tests/animation-with-transition.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForKeyframe):

Moved individual keyframe generation into a new function.

(WebCore::CSSStyleSelector::keyframeStylesForAnimation):

Call the new function above for regular keyframes, and
also check for missing keyframes and generate them if
necessary.

  • css/CSSStyleSelector.h:
6:29 PM Changeset in webkit [61932] by Csaba Osztrogonác
  • 1 edit
    101 adds in trunk/LayoutTests

Unreviewed.

[Qt] Add platform specific expected results for new passing tests.
Compared to Mac png files and Mac expected files.

  • platform/qt/editing/selection/range-between-block-and-inline-expected.checksum: Added.
  • platform/qt/editing/selection/range-between-block-and-inline-expected.png: Added.
  • platform/qt/editing/selection/range-between-block-and-inline-expected.txt: Added.
  • platform/qt/fast/css-generated-content/after-duplicated-after-split-expected.checksum: Added.
  • platform/qt/fast/css-generated-content/after-duplicated-after-split-expected.png: Added.
  • platform/qt/fast/css-generated-content/after-duplicated-after-split-expected.txt: Added.
  • platform/qt/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum: Added.
  • platform/qt/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
  • platform/qt/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Added.
  • platform/qt/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum: Added.
  • platform/qt/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added.
  • platform/qt/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Added.
  • platform/qt/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: Added.
  • platform/qt/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
  • platform/qt/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Added.
  • platform/qt/fast/frames/take-focus-from-iframe-expected.checksum: Added.
  • platform/qt/fast/frames/take-focus-from-iframe-expected.png: Added.
  • platform/qt/fast/frames/take-focus-from-iframe-expected.txt: Added.
  • platform/qt/fast/images/svg-background-partial-redraw-expected.checksum: Added.
  • platform/qt/fast/images/svg-background-partial-redraw-expected.png: Added.
  • platform/qt/fast/images/svg-background-partial-redraw-expected.txt: Added.
  • platform/qt/fast/lists/alpha-boundary-values-expected.checksum: Added.
  • platform/qt/fast/lists/alpha-boundary-values-expected.png: Added.
  • platform/qt/fast/lists/alpha-boundary-values-expected.txt: Added.
  • platform/qt/fast/multicol/column-count-with-rules-expected.checksum: Added.
  • platform/qt/fast/multicol/column-count-with-rules-expected.png: Added.
  • platform/qt/fast/multicol/column-count-with-rules-expected.txt: Added.
  • platform/qt/fast/multicol/layers-in-multicol-expected.checksum: Added.
  • platform/qt/fast/multicol/layers-in-multicol-expected.png: Added.
  • platform/qt/fast/multicol/layers-in-multicol-expected.txt: Added.
  • platform/qt/fast/multicol/layers-split-across-columns-expected.checksum: Added.
  • platform/qt/fast/multicol/layers-split-across-columns-expected.png: Added.
  • platform/qt/fast/multicol/layers-split-across-columns-expected.txt: Added.
  • platform/qt/fast/multicol/nested-columns-expected.checksum: Added.
  • platform/qt/fast/multicol/nested-columns-expected.png: Added.
  • platform/qt/fast/multicol/nested-columns-expected.txt: Added.
  • platform/qt/fast/multicol/span/anonymous-style-inheritance-expected.checksum: Added.
  • platform/qt/fast/multicol/span/anonymous-style-inheritance-expected.png: Added.
  • platform/qt/fast/multicol/span/anonymous-style-inheritance-expected.txt: Added.
  • platform/qt/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.checksum: Added.
  • platform/qt/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png: Added.
  • platform/qt/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt: Added.
  • platform/qt/fast/multicol/span/span-as-immediate-child-generated-content-expected.checksum: Added.
  • platform/qt/fast/multicol/span/span-as-immediate-child-generated-content-expected.png: Added.
  • platform/qt/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Added.
  • platform/qt/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum: Added.
  • platform/qt/fast/multicol/span/span-as-immediate-child-property-removal-expected.png: Added.
  • platform/qt/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt: Added.
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.checksum: Added.
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png: Added.
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Added.
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-expected.checksum: Added.
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-expected.png: Added.
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Added.
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-removal-expected.checksum: Added.
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png: Added.
  • platform/qt/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt: Added.
  • platform/qt/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum: Added.
  • platform/qt/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Added.
  • platform/qt/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt: Added.
  • platform/qt/fast/multicol/span/span-as-nested-columns-child-expected.checksum: Added.
  • platform/qt/fast/multicol/span/span-as-nested-columns-child-expected.png: Added.
  • platform/qt/fast/multicol/span/span-as-nested-columns-child-expected.txt: Added.
  • platform/qt/fast/multicol/span/span-margin-collapsing-expected.checksum: Added.
  • platform/qt/fast/multicol/span/span-margin-collapsing-expected.png: Added.
  • platform/qt/fast/multicol/span/span-margin-collapsing-expected.txt: Added.
  • platform/qt/fast/repaint/fixed-child-move-after-scroll-expected.checksum: Added.
  • platform/qt/fast/repaint/fixed-child-move-after-scroll-expected.png: Added.
  • platform/qt/fast/repaint/fixed-child-move-after-scroll-expected.txt: Added.
  • platform/qt/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.checksum: Added.
  • platform/qt/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png: Added.
  • platform/qt/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.txt: Added.
  • platform/qt/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.checksum: Added.
  • platform/qt/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png: Added.
  • platform/qt/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.txt: Added.
  • platform/qt/fast/repaint/fixed-move-after-keyboard-scroll-expected.checksum: Added.
  • platform/qt/fast/repaint/fixed-move-after-keyboard-scroll-expected.png: Added.
  • platform/qt/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt: Added.
  • platform/qt/fast/repaint/fixed-move-after-scroll-expected.checksum: Added.
  • platform/qt/fast/repaint/fixed-move-after-scroll-expected.png: Added.
  • platform/qt/fast/repaint/fixed-move-after-scroll-expected.txt: Added.
  • platform/qt/fast/repaint/layout-state-scrolloffset-expected.checksum: Added.
  • platform/qt/fast/repaint/layout-state-scrolloffset-expected.png: Added.
  • platform/qt/fast/repaint/layout-state-scrolloffset-expected.txt: Added.
  • platform/qt/fast/repaint/layout-state-scrolloffset2-expected.checksum: Added.
  • platform/qt/fast/repaint/layout-state-scrolloffset2-expected.png: Added.
  • platform/qt/fast/repaint/layout-state-scrolloffset2-expected.txt: Added.
  • platform/qt/fast/repaint/layout-state-scrolloffset3-expected.checksum: Added.
  • platform/qt/fast/repaint/layout-state-scrolloffset3-expected.png: Added.
  • platform/qt/fast/repaint/layout-state-scrolloffset3-expected.txt: Added.
  • platform/qt/fast/repaint/positioned-document-element-expected.checksum: Added.
  • platform/qt/fast/repaint/positioned-document-element-expected.png: Added.
  • platform/qt/fast/repaint/positioned-document-element-expected.txt: Added.
  • platform/qt/fast/text/format-control-expected.checksum: Added.
  • platform/qt/fast/text/format-control-expected.png: Added.
  • platform/qt/fast/text/format-control-expected.txt: Added.
  • platform/qt/printing/page-rule-in-media-query-expected.checksum: Added.
  • platform/qt/printing/page-rule-in-media-query-expected.png: Added.
  • platform/qt/printing/page-rule-in-media-query-expected.txt: Added.
6:21 PM Changeset in webkit [61931] by Csaba Osztrogonác
  • 1 edit
    35 adds in trunk/LayoutTests

Unreviewed.

[Qt] Add platform specific expected results for new passing svg/* tests.
Compared to Mac png files and Mac expected files.

  • platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt: Added.
  • platform/qt/svg/batik/text/textDecoration-expected.checksum: Added.
  • platform/qt/svg/batik/text/textDecoration-expected.png: Added.
  • platform/qt/svg/batik/text/textDecoration-expected.txt: Added.
  • platform/qt/svg/custom/non-scaling-stroke-expected.checksum: Added.
  • platform/qt/svg/custom/non-scaling-stroke-expected.png: Added.
  • platform/qt/svg/custom/non-scaling-stroke-expected.txt: Added.
  • platform/qt/svg/custom/repaint-stroke-width-changes-expected.checksum: Added.
  • platform/qt/svg/custom/repaint-stroke-width-changes-expected.png: Added.
  • platform/qt/svg/custom/repaint-stroke-width-changes-expected.txt: Added.
  • platform/qt/svg/custom/svg-fonts-with-no-element-reference-expected.checksum: Added.
  • platform/qt/svg/custom/svg-fonts-with-no-element-reference-expected.png: Added.
  • platform/qt/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Copied from LayoutTests/platform/gtk/svg/custom/svg-fonts-with-no-element-reference-expected.txt.
  • platform/qt/svg/filters/filter-on-filter-for-text-expected.checksum: Added.
  • platform/qt/svg/filters/filter-on-filter-for-text-expected.png: Added.
  • platform/qt/svg/filters/filter-on-filter-for-text-expected.txt: Added.
  • platform/qt/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.checksum: Copied from LayoutTests/platform/mac/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.checksum.
  • platform/qt/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.png: Added.
  • platform/qt/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.txt: Copied from LayoutTests/platform/mac/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.txt.
  • platform/qt/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.checksum: Added.
  • platform/qt/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.png: Added.
  • platform/qt/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.txt: Added.
  • platform/qt/svg/foreignObject/svg-document-as-direct-child-expected.checksum: Added.
  • platform/qt/svg/foreignObject/svg-document-as-direct-child-expected.png: Added.
  • platform/qt/svg/foreignObject/svg-document-as-direct-child-expected.txt: Added.
  • platform/qt/svg/foreignObject/svg-document-in-html-document-expected.checksum: Added.
  • platform/qt/svg/foreignObject/svg-document-in-html-document-expected.png: Added.
  • platform/qt/svg/foreignObject/svg-document-in-html-document-expected.txt: Added.
  • platform/qt/svg/foreignObject/text-tref-02-b-expected.checksum: Added.
  • platform/qt/svg/foreignObject/text-tref-02-b-expected.png: Added.
  • platform/qt/svg/foreignObject/text-tref-02-b-expected.txt: Added.
6:18 PM Changeset in webkit [61930] by Csaba Osztrogonác
  • 1 edit
    63 adds in trunk/LayoutTests

Unreviewed.

[Qt] Add platform specific expected results for new passing svg/text/* tests.
Compared to Mac png files and Mac expected files.

  • platform/qt/svg/text/select-textLength-spacing-squeeze-1-expected.checksum: Added.
  • platform/qt/svg/text/select-textLength-spacing-squeeze-1-expected.png: Added.
  • platform/qt/svg/text/select-textLength-spacing-squeeze-1-expected.txt: Added.
  • platform/qt/svg/text/select-textLength-spacing-squeeze-2-expected.checksum: Added.
  • platform/qt/svg/text/select-textLength-spacing-squeeze-2-expected.png: Added.
  • platform/qt/svg/text/select-textLength-spacing-squeeze-2-expected.txt: Added.
  • platform/qt/svg/text/select-textLength-spacing-squeeze-3-expected.checksum: Added.
  • platform/qt/svg/text/select-textLength-spacing-squeeze-3-expected.png: Added.
  • platform/qt/svg/text/select-textLength-spacing-squeeze-3-expected.txt: Added.
  • platform/qt/svg/text/select-textLength-spacing-squeeze-4-expected.checksum: Added.
  • platform/qt/svg/text/select-textLength-spacing-squeeze-4-expected.png: Added.
  • platform/qt/svg/text/select-textLength-spacing-squeeze-4-expected.txt: Added.
  • platform/qt/svg/text/select-textLength-spacing-stretch-1-expected.checksum: Added.
  • platform/qt/svg/text/select-textLength-spacing-stretch-1-expected.png: Added.
  • platform/qt/svg/text/select-textLength-spacing-stretch-1-expected.txt: Added.
  • platform/qt/svg/text/select-textLength-spacing-stretch-2-expected.checksum: Added.
  • platform/qt/svg/text/select-textLength-spacing-stretch-2-expected.png: Added.
  • platform/qt/svg/text/select-textLength-spacing-stretch-2-expected.txt: Added.
  • platform/qt/svg/text/select-textLength-spacing-stretch-3-expected.checksum: Added.
  • platform/qt/svg/text/select-textLength-spacing-stretch-3-expected.png: Added.
  • platform/qt/svg/text/select-textLength-spacing-stretch-3-expected.txt: Added.
  • platform/qt/svg/text/select-textLength-spacing-stretch-4-expected.checksum: Added.
  • platform/qt/svg/text/select-textLength-spacing-stretch-4-expected.png: Added.
  • platform/qt/svg/text/select-textLength-spacing-stretch-4-expected.txt: Added.
  • platform/qt/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.checksum: Added.
  • platform/qt/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.png: Added.
  • platform/qt/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt: Added.
  • platform/qt/svg/text/select-x-list-1-expected.checksum: Added.
  • platform/qt/svg/text/select-x-list-1-expected.png: Added.
  • platform/qt/svg/text/select-x-list-1-expected.txt: Added.
  • platform/qt/svg/text/select-x-list-2-expected.checksum: Added.
  • platform/qt/svg/text/select-x-list-2-expected.png: Added.
  • platform/qt/svg/text/select-x-list-2-expected.txt: Added.
  • platform/qt/svg/text/select-x-list-3-expected.checksum: Added.
  • platform/qt/svg/text/select-x-list-3-expected.png: Added.
  • platform/qt/svg/text/select-x-list-3-expected.txt: Added.
  • platform/qt/svg/text/select-x-list-4-expected.checksum: Added.
  • platform/qt/svg/text/select-x-list-4-expected.png: Added.
  • platform/qt/svg/text/select-x-list-4-expected.txt: Added.
  • platform/qt/svg/text/select-x-list-with-tspans-1-expected.checksum: Added.
  • platform/qt/svg/text/select-x-list-with-tspans-1-expected.png: Added.
  • platform/qt/svg/text/select-x-list-with-tspans-1-expected.txt: Added.
  • platform/qt/svg/text/select-x-list-with-tspans-2-expected.checksum: Added.
  • platform/qt/svg/text/select-x-list-with-tspans-2-expected.png: Added.
  • platform/qt/svg/text/select-x-list-with-tspans-2-expected.txt: Added.
  • platform/qt/svg/text/select-x-list-with-tspans-3-expected.checksum: Added.
  • platform/qt/svg/text/select-x-list-with-tspans-3-expected.png: Added.
  • platform/qt/svg/text/select-x-list-with-tspans-3-expected.txt: Added.
  • platform/qt/svg/text/select-x-list-with-tspans-4-expected.checksum: Added.
  • platform/qt/svg/text/select-x-list-with-tspans-4-expected.png: Added.
  • platform/qt/svg/text/select-x-list-with-tspans-4-expected.txt: Added.
  • platform/qt/svg/text/text-hkern-expected.checksum: Added.
  • platform/qt/svg/text/text-hkern-expected.png: Added.
  • platform/qt/svg/text/text-hkern-expected.txt: Copied from LayoutTests/platform/gtk/svg/text/text-hkern-expected.txt.
  • platform/qt/svg/text/text-hkern-on-vertical-text-expected.checksum: Added.
  • platform/qt/svg/text/text-hkern-on-vertical-text-expected.png: Added.
  • platform/qt/svg/text/text-hkern-on-vertical-text-expected.txt: Copied from LayoutTests/platform/gtk/svg/text/text-hkern-on-vertical-text-expected.txt.
  • platform/qt/svg/text/text-vkern-expected.checksum: Added.
  • platform/qt/svg/text/text-vkern-expected.png: Added.
  • platform/qt/svg/text/text-vkern-expected.txt: Copied from LayoutTests/platform/gtk/svg/text/text-vkern-expected.txt.
  • platform/qt/svg/text/text-vkern-on-horizontal-text-expected.checksum: Added.
  • platform/qt/svg/text/text-vkern-on-horizontal-text-expected.png: Added.
  • platform/qt/svg/text/text-vkern-on-horizontal-text-expected.txt: Copied from LayoutTests/platform/gtk/svg/text/text-vkern-on-horizontal-text-expected.txt.
6:16 PM Changeset in webkit [61929] by victorw@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-06-25 Victor Wang <​victorw@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Update chromium webkit gyp so it has
option to be built as DLL.

Chromium webkit is built as webkit.dll on windows
if it is inside chromium build and variable component
is set to shared_library.

​https://bugs.webkit.org/show_bug.cgi?id=41161

  • WebKit.gyp:
6:11 PM Changeset in webkit [61928] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] fast/text/bidi-explicit-embedding-past-end.html fails
​https://bugs.webkit.org/show_bug.cgi?id=41241

  • platform/qt/Skipped: fast/text/bidi-explicit-embedding-past-end.html skipped until fix.
6:04 PM Changeset in webkit [61927] by commit-queue@webkit.org
  • 5 edits in trunk/JavaScriptCore

2010-06-25 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r61924.
​http://trac.webkit.org/changeset/61924
​https://bugs.webkit.org/show_bug.cgi?id=41240

It was rolled out, but cq+ wasn't removed (Requested by Ossy_
on #webkit).

  • runtime/RegExp.cpp: (JSC::RegExp::RegExp): (JSC::RegExp::create):
  • runtime/RegExp.h:
  • runtime/RegExpCache.cpp: (JSC::RegExpCache::lookupOrCreate): (JSC::RegExpCache::create):
  • runtime/RegExpCache.h:
5:58 PM Changeset in webkit [61926] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-25 Jesus Sanchez-Palencia <​jesus.palencia@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode).
​https://bugs.webkit.org/show_bug.cgi?id=38597

Make the reload button act as a load button as well.

  • QtTestBrowser/mainwindow.cpp: (MainWindow::buildUI): (MainWindow::changeLocation):
5:47 PM Changeset in webkit [61925] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-06-25 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

We should parse <html>
​https://bugs.webkit.org/show_bug.cgi?id=41239

This patch is hard to test, but I think this patch lets us parse a
document consisting of only an <html> start tag.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::constructTreeFromToken): (WebCore::HTMLTreeBuilder::insertHTMLStartTagBeforeHTML): (WebCore::HTMLTreeBuilder::insertHTMLStartTagInBody): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processDefaultForBeforeHTMLMode):
  • html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::ElementStack::push):
5:41 PM Changeset in webkit [61924] by commit-queue@webkit.org
  • 5 edits in trunk/JavaScriptCore

2010-06-25 Renata Hodovan <​reni@inf.u-szeged.hu>

Reviewed by Geoffrey Garen.

Merge RegExp constructor and RegExp::create methods into one.
Both of function are called with tree parameters and check whether
flags (the third param) is given or not.
Simplify hash lookups in RegExpCache::create with giving them an extra
iterator parameter.
​https://bugs.webkit.org/show_bug.cgi?id=41055

  • runtime/RegExp.cpp: (JSC::RegExp::RegExp):
  • runtime/RegExp.h:
  • runtime/RegExpCache.cpp: (JSC::RegExpCache::lookupOrCreate): (JSC::RegExpCache::create):
  • runtime/RegExpCache.h:
5:36 PM Changeset in webkit [61923] by mrowe@apple.com
  • 2 edits in tags/Safari-534.1.3/WebKit2

Merge r61918.

5:35 PM Changeset in webkit [61922] by mrowe@apple.com
  • 5 edits in tags/Safari-534.1.3

Versioning.

5:31 PM Changeset in webkit [61921] by mitz@apple.com
  • 3 edits
    4 adds in trunk

<rdar://problem/8000667> Certain text is repeated before and after a line break

Reviewed by Sam Weinig.

WebCore:

Test: fast/text/bidi-explicit-embedding-past-end.html

  • platform/text/BidiResolver.h:

(WebCore::::createBidiRunsForLine): Committing explicit embedding past the end of the range
creates BidiRuns up to the end of the range, so at that point, we can stop iterating.

LayoutTests:

  • fast/text/bidi-explicit-embedding-past-end-expected.checksum: Added.
  • fast/text/bidi-explicit-embedding-past-end-expected.png: Added.
  • fast/text/bidi-explicit-embedding-past-end-expected.txt: Added.
  • fast/text/bidi-explicit-embedding-past-end.html: Added.
5:21 PM Changeset in webkit [61920] by mrowe@apple.com
  • 1 copy in tags/Safari-534.1.3

New tag.

5:18 PM Changeset in webkit [61919] by jam@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-06-25 John Abd-El-Malek <​jam@chromium.org>

Reviewed by David Levin.

[chromium] Send unhandled events to Node's default handler
​https://bugs.webkit.org/show_bug.cgi?id=41223

  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::handleEvent):
5:13 PM Changeset in webkit [61918] by adachan@apple.com
  • 2 edits in trunk/WebKit2

Rubber-stamped by Mark Rowe.

Add additional include search paths relative to $(WebKitLibrariesDir) to fix a build.

  • win/WebKit2.vcproj:
4:56 PM Changeset in webkit [61917] by hclam@chromium.org
  • 625 edits in trunk/LayoutTests

Unreviewed. Build fix.

Updating test expectations due to r61908.

  • platform/chromium-linux/css1/basic/class_as_selector-expected.checksum:
  • platform/chromium-linux/css1/basic/comments-expected.checksum:
  • platform/chromium-linux/css1/basic/containment-expected.checksum:
  • platform/chromium-linux/css1/basic/id_as_selector-expected.checksum:
  • platform/chromium-linux/css1/basic/inheritance-expected.checksum:
  • platform/chromium-linux/css1/box_properties/border-expected.checksum:
  • platform/chromium-linux/css1/box_properties/border_bottom-expected.checksum:
  • platform/chromium-linux/css1/box_properties/border_bottom_width-expected.checksum:
  • platform/chromium-linux/css1/box_properties/border_left-expected.checksum:
  • platform/chromium-linux/css1/box_properties/border_left_width-expected.checksum:
  • platform/chromium-linux/css1/box_properties/border_right_inline-expected.checksum:
  • platform/chromium-linux/css1/box_properties/border_right_width-expected.checksum:
  • platform/chromium-linux/css1/box_properties/border_style-expected.checksum:
  • platform/chromium-linux/css1/box_properties/border_top-expected.checksum:
  • platform/chromium-linux/css1/box_properties/border_top_width-expected.checksum:
  • platform/chromium-linux/css1/box_properties/border_width-expected.checksum:
  • platform/chromium-linux/css1/box_properties/clear-expected.checksum:
  • platform/chromium-linux/css1/box_properties/clear_float-expected.checksum:
  • platform/chromium-linux/css1/box_properties/float_elements_in_series-expected.checksum:
  • platform/chromium-linux/css1/box_properties/float_margin-expected.checksum:
  • platform/chromium-linux/css1/box_properties/float_on_text_elements-expected.checksum:
  • platform/chromium-linux/css1/box_properties/height-expected.checksum:
  • platform/chromium-linux/css1/box_properties/margin-expected.checksum:
  • platform/chromium-linux/css1/box_properties/margin_bottom-expected.checksum:
  • platform/chromium-linux/css1/box_properties/margin_inline-expected.checksum:
  • platform/chromium-linux/css1/box_properties/margin_left-expected.checksum:
  • platform/chromium-linux/css1/box_properties/margin_right-expected.checksum:
  • platform/chromium-linux/css1/box_properties/margin_top-expected.checksum:
  • platform/chromium-linux/css1/box_properties/padding-expected.checksum:
  • platform/chromium-linux/css1/box_properties/padding_bottom-expected.checksum:
  • platform/chromium-linux/css1/box_properties/padding_inline-expected.checksum:
  • platform/chromium-linux/css1/box_properties/padding_left-expected.checksum:
  • platform/chromium-linux/css1/box_properties/padding_right-expected.checksum:
  • platform/chromium-linux/css1/box_properties/padding_top-expected.checksum:
  • platform/chromium-linux/css1/box_properties/width-expected.checksum:
  • platform/chromium-linux/css1/cascade/cascade_order-expected.checksum:
  • platform/chromium-linux/css1/classification/display-expected.checksum:
  • platform/chromium-linux/css1/classification/list_style_type-expected.checksum:
  • platform/chromium-linux/css1/classification/white_space-expected.checksum:
  • platform/chromium-linux/css1/color_and_background/background-expected.checksum:
  • platform/chromium-linux/css1/color_and_background/background_attachment-expected.checksum:
  • platform/chromium-linux/css1/color_and_background/background_position-expected.checksum:
  • platform/chromium-linux/css1/color_and_background/background_repeat-expected.checksum:
  • platform/chromium-linux/css1/conformance/forward_compatible_parsing-expected.checksum:
  • platform/chromium-linux/css1/font_properties/font-expected.checksum:
  • platform/chromium-linux/css1/font_properties/font_family-expected.checksum:
  • platform/chromium-linux/css1/font_properties/font_size-expected.checksum:
  • platform/chromium-linux/css1/font_properties/font_weight-expected.checksum:
  • platform/chromium-linux/css1/formatting_model/floating_elements-expected.checksum:
  • platform/chromium-linux/css1/formatting_model/height_of_lines-expected.checksum:
  • platform/chromium-linux/css1/formatting_model/horizontal_formatting-expected.checksum:
  • platform/chromium-linux/css1/formatting_model/inline_elements-expected.checksum:
  • platform/chromium-linux/css1/formatting_model/replaced_elements-expected.checksum:
  • platform/chromium-linux/css1/formatting_model/vertical_formatting-expected.checksum:
  • platform/chromium-linux/css1/pseudo/anchor-expected.checksum:
  • platform/chromium-linux/css1/pseudo/firstletter-expected.checksum:
  • platform/chromium-linux/css1/pseudo/firstline-expected.checksum:
  • platform/chromium-linux/css1/pseudo/multiple_pseudo_elements-expected.checksum:
  • platform/chromium-linux/css1/pseudo/pseudo_elements_in_selectors-expected.checksum:
  • platform/chromium-linux/css1/text_properties/letter_spacing-expected.checksum:
  • platform/chromium-linux/css1/text_properties/line_height-expected.checksum:
  • platform/chromium-linux/css1/text_properties/text_decoration-expected.checksum:
  • platform/chromium-linux/css1/text_properties/text_indent-expected.checksum:
  • platform/chromium-linux/css1/text_properties/text_transform-expected.checksum:
  • platform/chromium-linux/css1/text_properties/vertical_align-expected.checksum:
  • platform/chromium-linux/css1/text_properties/word_spacing-expected.checksum:
  • platform/chromium-linux/css1/units/color_units-expected.checksum:
  • platform/chromium-linux/css1/units/length_units-expected.checksum:
  • platform/chromium-linux/css2.1/t0803-c5502-mrgn-r-02-c-expected.checksum:
  • platform/chromium-linux/css2.1/t0803-c5505-mrgn-02-c-expected.checksum:
  • platform/chromium-linux/css2.1/t080301-c411-vt-mrgn-00-b-expected.checksum:
  • platform/chromium-linux/css2.1/t0905-c5525-fltclr-00-c-ag-expected.checksum:
  • platform/chromium-linux/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.checksum:
  • platform/chromium-linux/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
  • platform/chromium-linux/css2.1/t0905-c5526-fltclr-00-c-ag-expected.checksum:
  • platform/chromium-linux/css2.1/t1002-c5523-width-02-b-g-expected.checksum:
  • platform/chromium-linux/css2.1/t1202-counters-08-b-expected.checksum:
  • platform/chromium-linux/css2.1/t1202-counters-09-b-expected.checksum:
  • platform/chromium-linux/css2.1/t140201-c535-bg-fixd-00-b-g-expected.checksum:
  • platform/chromium-linux/css2.1/t140201-c537-bgfxps-00-c-ag-expected.checksum:
  • platform/chromium-linux/css2.1/t1508-c527-font-07-b-expected.checksum:
  • platform/chromium-linux/editing/deleting/5168598-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-after-span-ws-001-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-after-span-ws-002-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-after-span-ws-003-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-line-end-ws-001-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-line-end-ws-002-expected.checksum:
  • platform/chromium-linux/editing/input/emacs-ctrl-o-expected.checksum:
  • platform/chromium-linux/editing/inserting/12882-expected.checksum:
  • platform/chromium-linux/editing/inserting/5607069-2-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-div-023-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/emacs-cntl-y-001-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/emacs-ctrl-a-k-y-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/emacs-ctrl-k-y-001-expected.checksum:
  • platform/chromium-linux/editing/selection/5354455-1-expected.checksum:
  • platform/chromium-linux/editing/selection/5354455-2-expected.checksum:
  • platform/chromium-linux/editing/selection/designmode-no-caret-expected.checksum:
  • platform/chromium-linux/editing/selection/focus_editable_html-expected.checksum:
  • platform/chromium-linux/editing/selection/iframe-expected.checksum:
  • platform/chromium-linux/editing/selection/move-by-line-001-expected.checksum:
  • platform/chromium-linux/editing/selection/select-all-001-expected.checksum:
  • platform/chromium-linux/editing/selection/select-all-002-expected.checksum:
  • platform/chromium-linux/editing/selection/select-all-003-expected.checksum:
  • platform/chromium-linux/editing/selection/select-all-004-expected.checksum:
  • platform/chromium-linux/editing/selection/unrendered-001-expected.checksum:
  • platform/chromium-linux/editing/selection/unrendered-002-expected.checksum:
  • platform/chromium-linux/editing/selection/unrendered-003-expected.checksum:
  • platform/chromium-linux/editing/selection/unrendered-004-expected.checksum:
  • platform/chromium-linux/editing/selection/unrendered-005-expected.checksum:
  • platform/chromium-linux/fast/backgrounds/001-expected.checksum:
  • platform/chromium-linux/fast/backgrounds/background-inherit-color-bug-expected.checksum:
  • platform/chromium-linux/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.checksum:
  • platform/chromium-linux/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.checksum:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize15-expected.checksum:
  • platform/chromium-linux/fast/backgrounds/svg-as-background-1-expected.checksum:
  • platform/chromium-linux/fast/block/basic/016-expected.checksum:
  • platform/chromium-linux/fast/block/basic/fieldset-stretch-to-legend-expected.checksum:
  • platform/chromium-linux/fast/block/float/008-expected.checksum:
  • platform/chromium-linux/fast/block/float/013-expected.checksum:
  • platform/chromium-linux/fast/block/float/019-expected.checksum:
  • platform/chromium-linux/fast/block/float/021-expected.checksum:
  • platform/chromium-linux/fast/block/float/025-expected.checksum:
  • platform/chromium-linux/fast/block/float/026-expected.checksum:
  • platform/chromium-linux/fast/block/float/027-expected.checksum:
  • platform/chromium-linux/fast/block/float/028-expected.checksum:
  • platform/chromium-linux/fast/block/float/032-expected.checksum:
  • platform/chromium-linux/fast/block/float/033-expected.checksum:
  • platform/chromium-linux/fast/block/float/035-expected.checksum:
  • platform/chromium-linux/fast/block/float/avoidance-percent-width-strict-expected.checksum:
  • platform/chromium-linux/fast/block/float/br-with-clear-2-expected.checksum:
  • platform/chromium-linux/fast/block/float/float-avoidance-expected.checksum:
  • platform/chromium-linux/fast/block/float/nested-clearance-expected.checksum:
  • platform/chromium-linux/fast/block/float/relative-painted-twice-expected.checksum:
  • platform/chromium-linux/fast/block/margin-collapse/103-expected.checksum:
  • platform/chromium-linux/fast/block/margin-collapse/104-expected.checksum:
  • platform/chromium-linux/fast/block/margin-collapse/empty-clear-blocks-expected.checksum:
  • platform/chromium-linux/fast/block/positioning/047-expected.checksum:
  • platform/chromium-linux/fast/block/positioning/051-expected.checksum:
  • platform/chromium-linux/fast/block/positioning/055-expected.checksum:
  • platform/chromium-linux/fast/block/positioning/auto/007-expected.checksum:
  • platform/chromium-linux/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.checksum:
  • platform/chromium-linux/fast/block/positioning/negative-rel-position-expected.checksum:
  • platform/chromium-linux/fast/block/positioning/relative-overflow-block-expected.checksum:
  • platform/chromium-linux/fast/block/positioning/relative-overflow-replaced-expected.checksum:
  • platform/chromium-linux/fast/block/positioning/relative-overflow-replaced-float-expected.checksum:
  • platform/chromium-linux/fast/body-propagation/overflow/001-expected.checksum:
  • platform/chromium-linux/fast/body-propagation/overflow/001-xhtml-expected.checksum:
  • platform/chromium-linux/fast/body-propagation/overflow/002-expected.checksum:
  • platform/chromium-linux/fast/body-propagation/overflow/002-xhtml-expected.checksum:
  • platform/chromium-linux/fast/body-propagation/overflow/003-declarative-expected.checksum:
  • platform/chromium-linux/fast/body-propagation/overflow/003-expected.checksum:
  • platform/chromium-linux/fast/body-propagation/overflow/003-xhtml-expected.checksum:
  • platform/chromium-linux/fast/body-propagation/overflow/004-declarative-expected.checksum:
  • platform/chromium-linux/fast/body-propagation/overflow/004-expected.checksum:
  • platform/chromium-linux/fast/body-propagation/overflow/004-xhtml-expected.checksum:
  • platform/chromium-linux/fast/body-propagation/overflow/005-declarative-expected.checksum:
  • platform/chromium-linux/fast/body-propagation/overflow/005-expected.checksum:
  • platform/chromium-linux/fast/body-propagation/overflow/005-xhtml-expected.checksum:
  • platform/chromium-linux/fast/body-propagation/overflow/006-declarative-expected.checksum:
  • platform/chromium-linux/fast/body-propagation/overflow/006-expected.checksum:
  • platform/chromium-linux/fast/body-propagation/overflow/006-xhtml-expected.checksum:
  • platform/chromium-linux/fast/body-propagation/overflow/007-declarative-expected.checksum:
  • platform/chromium-linux/fast/body-propagation/overflow/007-expected.checksum:
  • platform/chromium-linux/fast/body-propagation/overflow/007-xhtml-expected.checksum:
  • platform/chromium-linux/fast/borders/inline-mask-overlay-image-expected.checksum:
  • platform/chromium-linux/fast/box-shadow/basic-shadows-expected.checksum:
  • platform/chromium-linux/fast/box-sizing/box-sizing-expected.checksum:
  • platform/chromium-linux/fast/canvas/canvas-bg-expected.checksum:
  • platform/chromium-linux/fast/canvas/canvas-text-alignment-expected.checksum:
  • platform/chromium-linux/fast/canvas/image-object-in-canvas-expected.checksum:
  • platform/chromium-linux/fast/clip/014-expected.checksum:
  • platform/chromium-linux/fast/css-generated-content/014-expected.checksum:
  • platform/chromium-linux/fast/css/005-expected.checksum:
  • platform/chromium-linux/fast/css/MarqueeLayoutTest-expected.checksum:
  • platform/chromium-linux/fast/css/border-height-expected.checksum:
  • platform/chromium-linux/fast/css/css2-system-fonts-expected.checksum:
  • platform/chromium-linux/fast/css/empty-pseudo-class-expected.checksum:
  • platform/chromium-linux/fast/css/first-child-pseudo-class-expected.checksum:
  • platform/chromium-linux/fast/css/first-of-type-pseudo-class-expected.checksum:
  • platform/chromium-linux/fast/css/font-face-descriptor-multiple-values-expected.checksum:
  • platform/chromium-linux/fast/css/font-face-implicit-local-font-expected.checksum:
  • platform/chromium-linux/fast/css/font-face-in-shadow-DOM-expected.checksum:
  • platform/chromium-linux/fast/css/font_property_normal-expected.checksum:
  • platform/chromium-linux/fast/css/hsl-color-expected.checksum:
  • platform/chromium-linux/fast/css/last-child-pseudo-class-expected.checksum:
  • platform/chromium-linux/fast/css/last-of-type-pseudo-class-expected.checksum:
  • platform/chromium-linux/fast/css/line-height-overflow-expected.checksum:
  • platform/chromium-linux/fast/css/nested-floating-relative-position-percentages-expected.checksum:
  • platform/chromium-linux/fast/css/nested-rounded-corners-expected.checksum:
  • platform/chromium-linux/fast/css/only-child-pseudo-class-expected.checksum:
  • platform/chromium-linux/fast/css/only-of-type-pseudo-class-expected.checksum:
  • platform/chromium-linux/fast/css/percentage-non-integer-expected.checksum:
  • platform/chromium-linux/fast/css/positioned-overflow-scroll-expected.checksum:
  • platform/chromium-linux/fast/css/text-overflow-ellipsis-expected.checksum:
  • platform/chromium-linux/fast/css/text-overflow-ellipsis-strict-expected.checksum:
  • platform/chromium-linux/fast/css/variables/misplaced-import-test-expected.checksum:
  • platform/chromium-linux/fast/css/word-space-extra-expected.checksum:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum:
  • platform/chromium-linux/fast/dom/clientWidthAfterDocumentIsRemoved-expected.checksum:
  • platform/chromium-linux/fast/dom/clone-node-dynamic-style-expected.checksum:
  • platform/chromium-linux/fast/dom/focus-contenteditable-expected.checksum:
  • platform/chromium-linux/fast/dom/gc-10-expected.checksum:
  • platform/chromium-linux/fast/dynamic/008-expected.checksum:
  • platform/chromium-linux/fast/dynamic/anchor-lock-expected.checksum:
  • platform/chromium-linux/fast/dynamic/insert-before-table-part-in-continuation-expected.checksum:
  • platform/chromium-linux/fast/encoding/utf-16-big-endian-expected.checksum:
  • platform/chromium-linux/fast/encoding/utf-16-little-endian-expected.checksum:
  • platform/chromium-linux/fast/events/5056619-expected.checksum:
  • platform/chromium-linux/fast/events/autoscroll-expected.checksum:
  • platform/chromium-linux/fast/events/keydown-1-expected.checksum:
  • platform/chromium-linux/fast/events/pointer-events-2-expected.checksum:
  • platform/chromium-linux/fast/events/reveal-link-when-focused-expected.checksum:
  • platform/chromium-linux/fast/events/standalone-image-drag-to-editable-expected.checksum:
  • platform/chromium-linux/fast/flexbox/009-expected.checksum:
  • platform/chromium-linux/fast/flexbox/016-expected.checksum:
  • platform/chromium-linux/fast/flexbox/flex-hang-expected.checksum:
  • platform/chromium-linux/fast/forms/001-expected.checksum:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label05-expected.checksum:
  • platform/chromium-linux/fast/forms/basic-textareas-expected.checksum:
  • platform/chromium-linux/fast/forms/basic-textareas-quirks-expected.checksum:
  • platform/chromium-linux/fast/forms/button-default-title-expected.checksum:
  • platform/chromium-linux/fast/forms/disabled-select-change-index-expected.checksum:
  • platform/chromium-linux/fast/forms/fieldset-align-expected.checksum:
  • platform/chromium-linux/fast/forms/file-input-direction-expected.checksum:
  • platform/chromium-linux/fast/forms/form-element-geometry-expected.checksum:
  • platform/chromium-linux/fast/forms/form-hides-table-expected.checksum:
  • platform/chromium-linux/fast/forms/input-appearance-selection-expected.checksum:
  • platform/chromium-linux/fast/forms/input-first-letter-expected.checksum:
  • platform/chromium-linux/fast/forms/input-table-expected.checksum:
  • platform/chromium-linux/fast/forms/input-text-double-click-expected.checksum:
  • platform/chromium-linux/fast/forms/input-text-scroll-left-on-blur-expected.checksum:
  • platform/chromium-linux/fast/forms/linebox-overflow-in-textarea-padding-expected.checksum:
  • platform/chromium-linux/fast/forms/listbox-scrollbar-incremental-load-expected.checksum:
  • platform/chromium-linux/fast/forms/listbox-width-change-expected.checksum:
  • platform/chromium-linux/fast/forms/option-strip-whitespace-expected.checksum:
  • platform/chromium-linux/fast/forms/search-display-none-cancel-button-expected.checksum:
  • platform/chromium-linux/fast/forms/search-placeholder-value-changed-expected.checksum:
  • platform/chromium-linux/fast/forms/searchfield-heights-expected.checksum:
  • platform/chromium-linux/fast/forms/select-block-background-expected.checksum:
  • platform/chromium-linux/fast/forms/select-change-listbox-size-expected.checksum:
  • platform/chromium-linux/fast/forms/select-change-popup-to-listbox-expected.checksum:
  • platform/chromium-linux/fast/forms/select-initial-position-expected.checksum:
  • platform/chromium-linux/fast/forms/select-item-background-clip-expected.checksum:
  • platform/chromium-linux/fast/forms/select-list-box-with-height-expected.checksum:
  • platform/chromium-linux/fast/forms/select-visual-hebrew-expected.checksum:
  • platform/chromium-linux/fast/forms/select-writing-direction-natural-expected.checksum:
  • platform/chromium-linux/fast/forms/tabbing-input-iframe-expected.checksum:
  • platform/chromium-linux/fast/forms/textAreaLineHeight-expected.checksum:
  • platform/chromium-linux/fast/forms/textarea-scroll-height-expected.checksum:
  • platform/chromium-linux/fast/forms/textarea-scrollbar-expected.checksum:
  • platform/chromium-linux/fast/forms/textarea-scrolled-type-expected.checksum:
  • platform/chromium-linux/fast/forms/textarea-width-expected.checksum:
  • platform/chromium-linux/fast/forms/visual-hebrew-text-field-expected.checksum:
  • platform/chromium-linux/fast/frames/frame-scrolling-attribute-expected.checksum:
  • platform/chromium-linux/fast/frames/iframe-scrolling-attribute-expected.checksum:
  • platform/chromium-linux/fast/frames/inline-object-inside-frameset-expected.checksum:
  • platform/chromium-linux/fast/frames/invalid-expected.checksum:
  • platform/chromium-linux/fast/frames/onlyCommentInIFrame-expected.checksum:
  • platform/chromium-linux/fast/frames/take-focus-from-iframe-expected.checksum:
  • platform/chromium-linux/fast/frames/valid-expected.checksum:
  • platform/chromium-linux/fast/frames/viewsource-attribute-expected.checksum:
  • platform/chromium-linux/fast/gradients/background-clipped-expected.checksum:
  • platform/chromium-linux/fast/images/pdf-as-image-expected.checksum:
  • platform/chromium-linux/fast/images/pdf-as-image-landscape-expected.checksum:
  • platform/chromium-linux/fast/inline-block/inline-block-vertical-align-expected.checksum:
  • platform/chromium-linux/fast/inline-block/tricky-baseline-expected.checksum:
  • platform/chromium-linux/fast/inline/inline-borders-with-bidi-override-expected.checksum:
  • platform/chromium-linux/fast/inline/inline-continuation-borders-expected.checksum:
  • platform/chromium-linux/fast/inline/long-wrapped-line-expected.checksum:
  • platform/chromium-linux/fast/invalid/residual-style-expected.checksum:
  • platform/chromium-linux/fast/layers/opacity-transforms-expected.checksum:
  • platform/chromium-linux/fast/layers/overflow-scroll-auto-switch-expected.checksum:
  • platform/chromium-linux/fast/layers/scroll-rect-to-visible-expected.checksum:
  • platform/chromium-linux/fast/lists/008-expected.checksum:
  • platform/chromium-linux/fast/lists/alpha-list-wrap-expected.checksum:
  • platform/chromium-linux/fast/lists/drag-into-marker-expected.checksum:
  • platform/chromium-linux/fast/lists/li-br-expected.checksum:
  • platform/chromium-linux/fast/lists/ol-start-parsing-expected.checksum:
  • platform/chromium-linux/fast/lists/olstart-expected.checksum:
  • platform/chromium-linux/fast/lists/w3-css3-list-styles-alphabetic-expected.checksum:
  • platform/chromium-linux/fast/lists/w3-css3-list-styles-numeric-expected.checksum:
  • platform/chromium-linux/fast/lists/w3-list-styles-expected.checksum:
  • platform/chromium-linux/fast/media/mq-relative-constraints-02-expected.checksum:
  • platform/chromium-linux/fast/media/mq-relative-constraints-03-expected.checksum:
  • platform/chromium-linux/fast/media/mq-relative-constraints-04-expected.checksum:
  • platform/chromium-linux/fast/media/mq-relative-constraints-05-expected.checksum:
  • platform/chromium-linux/fast/media/mq-relative-constraints-06-expected.checksum:
  • platform/chromium-linux/fast/media/mq-relative-constraints-07-expected.checksum:
  • platform/chromium-linux/fast/media/mq-relative-constraints-08-expected.checksum:
  • platform/chromium-linux/fast/media/mq-relative-constraints-09-expected.checksum:
  • platform/chromium-linux/fast/media/mq-width-absolute-01-expected.checksum:
  • platform/chromium-linux/fast/media/mq-width-absolute-02-expected.checksum:
  • platform/chromium-linux/fast/media/mq-width-absolute-03-expected.checksum:
  • platform/chromium-linux/fast/media/mq-width-absolute-04-expected.checksum:
  • platform/chromium-linux/fast/multicol/client-rects-expected.checksum:
  • platform/chromium-linux/fast/multicol/column-rules-stacking-expected.checksum:
  • platform/chromium-linux/fast/multicol/columns-shorthand-parsing-expected.checksum:
  • platform/chromium-linux/fast/multicol/float-multicol-expected.checksum:
  • platform/chromium-linux/fast/multicol/layers-in-multicol-expected.checksum:
  • platform/chromium-linux/fast/multicol/layers-split-across-columns-expected.checksum:
  • platform/chromium-linux/fast/multicol/nested-columns-expected.checksum:
  • platform/chromium-linux/fast/multicol/positioned-with-constrained-height-expected.checksum:
  • platform/chromium-linux/fast/multicol/span/anonymous-style-inheritance-expected.checksum:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.checksum:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-generated-content-expected.checksum:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.checksum:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-expected.checksum:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-removal-expected.checksum:
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum:
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-expected.checksum:
  • platform/chromium-linux/fast/multicol/span/span-margin-collapsing-expected.checksum:
  • platform/chromium-linux/fast/overflow/002-expected.checksum:
  • platform/chromium-linux/fast/overflow/003-expected.checksum:
  • platform/chromium-linux/fast/overflow/005-expected.checksum:
  • platform/chromium-linux/fast/overflow/006-expected.checksum:
  • platform/chromium-linux/fast/overflow/007-expected.checksum:
  • platform/chromium-linux/fast/overflow/008-expected.checksum:
  • platform/chromium-linux/fast/overflow/childFocusRingClip-expected.checksum:
  • platform/chromium-linux/fast/overflow/clip-rects-fixed-ancestor-expected.checksum:
  • platform/chromium-linux/fast/overflow/float-in-relpositioned-expected.checksum:
  • platform/chromium-linux/fast/overflow/hit-test-overflow-controls-expected.checksum:
  • platform/chromium-linux/fast/overflow/image-selection-highlight-expected.checksum:
  • platform/chromium-linux/fast/overflow/overflow-auto-position-absolute-expected.checksum:
  • platform/chromium-linux/fast/overflow/overflow-auto-table-expected.checksum:
  • platform/chromium-linux/fast/overflow/overflow-rtl-expected.checksum:
  • platform/chromium-linux/fast/overflow/overflow-stacking-expected.checksum:
  • platform/chromium-linux/fast/overflow/overflow-text-hit-testing-expected.checksum:
  • platform/chromium-linux/fast/overflow/overflow-with-local-background-attachment-expected.checksum:
  • platform/chromium-linux/fast/overflow/overflow-x-y-expected.checksum:
  • platform/chromium-linux/fast/overflow/position-fixed-transform-clipping-expected.checksum:
  • platform/chromium-linux/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.checksum:
  • platform/chromium-linux/fast/overflow/scrollRevealButton-expected.checksum:
  • platform/chromium-linux/fast/overflow/scrollbar-position-update-expected.checksum:
  • platform/chromium-linux/fast/overflow/table-overflow-float-expected.checksum:
  • platform/chromium-linux/fast/overflow/unreachable-overflow-rtl-bug-expected.checksum:
  • platform/chromium-linux/fast/parser/open-comment-in-textarea-expected.checksum:
  • platform/chromium-linux/fast/reflections/reflection-direction-expected.checksum:
  • platform/chromium-linux/fast/repaint/block-selection-gap-stale-cache-2-expected.checksum:
  • platform/chromium-linux/fast/repaint/box-shadow-v-expected.checksum:
  • platform/chromium-linux/fast/repaint/dynamic-table-vertical-alignment-change-expected.checksum:
  • platform/chromium-linux/fast/repaint/fixed-child-move-after-scroll-expected.checksum:
  • platform/chromium-linux/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.checksum:
  • platform/chromium-linux/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.checksum:
  • platform/chromium-linux/fast/repaint/fixed-expected.checksum:
  • platform/chromium-linux/fast/repaint/fixed-move-after-keyboard-scroll-expected.checksum:
  • platform/chromium-linux/fast/repaint/fixed-move-after-scroll-expected.checksum:
  • platform/chromium-linux/fast/repaint/fixed-tranformed-expected.checksum:
  • platform/chromium-linux/fast/repaint/layout-state-only-positioned-expected.checksum:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-1-expected.checksum:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-10-expected.checksum:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-2-expected.checksum:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-3-expected.checksum:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-4-expected.checksum:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-5-expected.checksum:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-6-expected.checksum:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-7-expected.checksum:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-8-expected.checksum:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-9-expected.checksum:
  • platform/chromium-linux/fast/repaint/list-marker-expected.checksum:
  • platform/chromium-linux/fast/repaint/moving-shadow-on-container-expected.checksum:
  • platform/chromium-linux/fast/repaint/moving-shadow-on-path-expected.checksum:
  • platform/chromium-linux/fast/repaint/overflow-scroll-body-appear-expected.checksum:
  • platform/chromium-linux/fast/repaint/overflow-scroll-delete-expected.checksum:
  • platform/chromium-linux/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.checksum:
  • platform/chromium-linux/fast/repaint/repaint-during-scroll-expected.checksum:
  • platform/chromium-linux/fast/repaint/selection-gap-overflow-scroll-2-expected.checksum:
  • platform/chromium-linux/fast/repaint/selection-gap-overflow-scroll-expected.checksum:
  • platform/chromium-linux/fast/replaced/005-expected.checksum:
  • platform/chromium-linux/fast/replaced/border-radius-clip-expected.checksum:
  • platform/chromium-linux/fast/replaced/pdf-as-image-expected.checksum:
  • platform/chromium-linux/fast/replaced/replaced-breaking-expected.checksum:
  • platform/chromium-linux/fast/replaced/width100percent-image-expected.checksum:
  • platform/chromium-linux/fast/replaced/width100percent-menulist-expected.checksum:
  • platform/chromium-linux/fast/replaced/width100percent-searchfield-expected.checksum:
  • platform/chromium-linux/fast/replaced/width100percent-textarea-expected.checksum:
  • platform/chromium-linux/fast/selectors/166-expected.checksum:
  • platform/chromium-linux/fast/table/023-expected.checksum:
  • platform/chromium-linux/fast/table/034-expected.checksum:
  • platform/chromium-linux/fast/table/040-expected.checksum:
  • platform/chromium-linux/fast/table/border-collapsing/004-expected.checksum:
  • platform/chromium-linux/fast/table/edge-offsets-expected.checksum:
  • platform/chromium-linux/fast/table/empty-cells-expected.checksum:
  • platform/chromium-linux/fast/table/frame-and-rules-expected.checksum:
  • platform/chromium-linux/fast/table/height-percent-test-expected.checksum:
  • platform/chromium-linux/fast/table/overflowHidden-expected.checksum:
  • platform/chromium-linux/fast/table/prepend-in-anonymous-table-expected.checksum:
  • platform/chromium-linux/fast/table/table-display-types-expected.checksum:
  • platform/chromium-linux/fast/table/wide-colspan-expected.checksum:
  • platform/chromium-linux/fast/table/wide-column-expected.checksum:
  • platform/chromium-linux/fast/text/drawBidiText-expected.checksum:
  • platform/chromium-linux/fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum:
  • platform/chromium-linux/fast/text/international/bidi-european-terminators-expected.checksum:
  • platform/chromium-linux/fast/text/international/bidi-listbox-atsui-expected.checksum:
  • platform/chromium-linux/fast/text/international/bidi-listbox-expected.checksum:
  • platform/chromium-linux/fast/text/international/bidi-neutral-run-expected.checksum:
  • platform/chromium-linux/fast/text/international/thai-line-breaks-expected.checksum:
  • platform/chromium-linux/fast/text/softHyphen-expected.checksum:
  • platform/chromium-linux/fast/text/text-letter-spacing-expected.checksum:
  • platform/chromium-linux/fast/text/updateNewFont-expected.checksum:
  • platform/chromium-linux/fast/text/wbr-expected.checksum:
  • platform/chromium-linux/fast/text/whitespace/024-expected.checksum:
  • platform/chromium-linux/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.checksum:
  • platform/chromium-linux/fast/text/word-break-expected.checksum:
  • platform/chromium-linux/fonts/cursive-expected.checksum:
  • platform/chromium-linux/fonts/default-expected.checksum:
  • platform/chromium-linux/fonts/fantasy-expected.checksum:
  • platform/chromium-linux/fonts/monospace-expected.checksum:
  • platform/chromium-linux/fonts/sans-serif-expected.checksum:
  • platform/chromium-linux/fonts/serif-expected.checksum:
  • platform/chromium-linux/http/tests/navigation/anchor-frames-expected.checksum:
  • platform/chromium-linux/http/tests/navigation/error404-frames-expected.checksum:
  • platform/chromium-linux/http/tests/navigation/error404-goback-expected.checksum:
  • platform/chromium-linux/http/tests/navigation/error404-subframeload-expected.checksum:
  • platform/chromium-linux/http/tests/navigation/javascriptlink-frames-expected.checksum:
  • platform/chromium-linux/http/tests/navigation/post-frames-expected.checksum:
  • platform/chromium-linux/http/tests/navigation/post-goback1-expected.checksum:
  • platform/chromium-linux/http/tests/navigation/postredirect-frames-expected.checksum:
  • platform/chromium-linux/media/video-controls-rendering-expected.checksum:
  • platform/chromium-linux/media/video-zoom-expected.checksum:
  • platform/chromium-linux/platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-02-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-03-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-04-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-05-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-06-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-07-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-path-02-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-path-05-f-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-use-01-t-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-path-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-spacing-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-01-b-expected.checksum:
  • platform/chromium-linux/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.checksum:
  • platform/chromium-linux/svg/carto.net/button-expected.checksum:
  • platform/chromium-linux/svg/carto.net/combobox-expected.checksum:
  • platform/chromium-linux/svg/carto.net/slider-expected.checksum:
  • platform/chromium-linux/svg/carto.net/textbox-expected.checksum:
  • platform/chromium-linux/svg/carto.net/window-expected.checksum:
  • platform/chromium-linux/svg/css/stars-with-shadow-expected.checksum:
  • platform/chromium-linux/svg/custom/altglyph-expected.checksum:
  • platform/chromium-linux/svg/custom/animate-path-morphing-expected.checksum:
  • platform/chromium-linux/svg/custom/invisible-text-after-scrolling-expected.checksum:
  • platform/chromium-linux/svg/custom/js-update-transform-changes-expected.checksum:
  • platform/chromium-linux/svg/custom/junk-data-expected.checksum:
  • platform/chromium-linux/svg/custom/marker-child-changes-expected.checksum:
  • platform/chromium-linux/svg/custom/marker-viewBox-changes-expected.checksum:
  • platform/chromium-linux/svg/custom/mask-changes-expected.checksum:
  • platform/chromium-linux/svg/custom/missing-xlink-expected.checksum:
  • platform/chromium-linux/svg/custom/path-bad-data-expected.checksum:
  • platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.checksum:
  • platform/chromium-linux/svg/custom/text-xy-updates-SVGList-expected.checksum:
  • platform/chromium-linux/svg/custom/use-detach-expected.checksum:
  • platform/chromium-linux/svg/custom/use-property-changes-through-svg-dom-expected.checksum:
  • platform/chromium-linux/svg/custom/use-referencing-nonexisting-symbol-expected.checksum:
  • platform/chromium-linux/svg/custom/use-transform-expected.checksum:
  • platform/chromium-linux/svg/filters/filterRes-expected.checksum:
  • platform/chromium-linux/svg/hixie/error/012-expected.checksum:
  • platform/chromium-linux/svg/hixie/links/003-broken-expected.checksum:
  • platform/chromium-linux/svg/hixie/perf/003-expected.checksum:
  • platform/chromium-linux/svg/hixie/perf/004-expected.checksum:
  • platform/chromium-linux/svg/hixie/perf/005-expected.checksum:
  • platform/chromium-linux/svg/hixie/perf/006-expected.checksum:
  • platform/chromium-linux/svg/hixie/text/003b-expected.checksum:
  • platform/chromium-linux/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.checksum:
  • platform/chromium-linux/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.checksum:
  • platform/chromium-linux/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.checksum:
  • platform/chromium-linux/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.checksum:
  • platform/chromium-linux/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.checksum:
  • platform/chromium-linux/svg/text/kerning-expected.checksum:
  • platform/chromium-linux/svg/text/multichar-glyph-expected.checksum:
  • platform/chromium-linux/svg/zoom/page/absolute-sized-document-scrollbars-expected.checksum:
  • platform/chromium-linux/svg/zoom/page/relative-sized-document-scrollbars-expected.checksum:
  • platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.checksum:
  • platform/chromium-linux/svg/zoom/page/zoom-foreignObject-expected.checksum:
  • platform/chromium-linux/svg/zoom/page/zoom-hixie-mixed-008-expected.checksum:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-float-border-padding-expected.checksum:
  • platform/chromium-linux/svg/zoom/text/zoom-svg-float-border-padding-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/45621-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug101674-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug10269-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug10296-1-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1055-1-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug113235-1-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug113235-3-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug11944-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug120364-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1302-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug131020-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug131020_iframe-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug137388-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug149275-1-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug16252-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug22019-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug23151-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-1-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-4-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug27038-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug28341-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug29314-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug2947-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug2997-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug32205-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug38916-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug3977-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug43039-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug43854-1-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug44505-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug46480-1-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug46480-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug50695-1-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug56405-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug5797-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug5835-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug625-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug650-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug67915-1-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug7112-1-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug7112-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug73321-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug8858-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug92143-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug96343-expected.checksum:
  • platform/chromium-linux/tables/mozilla/collapsing_borders/bug41262-3-expected.checksum:
  • platform/chromium-linux/tables/mozilla/core/bloomberg-expected.checksum:
  • platform/chromium-linux/tables/mozilla/core/borders-expected.checksum:
  • platform/chromium-linux/tables/mozilla/core/captions-expected.checksum:
  • platform/chromium-linux/tables/mozilla/core/cell_heights-expected.checksum:
  • platform/chromium-linux/tables/mozilla/core/col_span-expected.checksum:
  • platform/chromium-linux/tables/mozilla/core/col_widths_auto_fix-expected.checksum:
  • platform/chromium-linux/tables/mozilla/core/col_widths_fix_fixPer-expected.checksum:
  • platform/chromium-linux/tables/mozilla/core/nested1-expected.checksum:
  • platform/chromium-linux/tables/mozilla/core/one_row-expected.checksum:
  • platform/chromium-linux/tables/mozilla/core/row_span-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_index-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_layers-opacity-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_position-table-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-cell-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-group-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-group-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_bgcolor_name-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_bgcolor_name-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_bgcolor_rgb-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_height-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_nowrap-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_bgcolor_name-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_bgcolor_rgb-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_height-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_nowrap-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_bgcolor_name-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.checksum:
  • platform/chromium-linux/tables/mozilla/other/cell_widths-expected.checksum:
  • platform/chromium-linux/tables/mozilla/other/nestedTables-expected.checksum:
  • platform/chromium-linux/tables/mozilla/other/test3-expected.checksum:
  • platform/chromium-linux/tables/mozilla/other/test6-expected.checksum:
  • platform/chromium-linux/tables/mozilla/other/wa_table_thtd_rowspan-expected.checksum:
  • platform/chromium-linux/tables/mozilla/other/wa_table_tr_align-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug10140-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug101759-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug10216-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1055-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug106966-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug131020-3-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug14007-1-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug14007-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug178855-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug19526-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug220653-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug22122-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug32205-1-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug67915-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug7243-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug80762-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug85016-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug89315-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug91057-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/backgrounds-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions2-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions3-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/col_span2-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/columns-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/conflicts-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/standards1-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/other/empty_cells-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/other/test4-expected.checksum:
  • platform/chromium-linux/transforms/2d/transform-fixed-container-expected.checksum:
4:46 PM Changeset in webkit [61916] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-25 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Move decoding into DocumentParser to further simplify RawDataDocumentParser and DocumentWriter
​https://bugs.webkit.org/show_bug.cgi?id=41202

Hit the Windoze with the compile bat.

  • WebCore.vcproj/WebCore.vcproj:
4:36 PM Changeset in webkit [61915] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-06-25 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

HTMLTreeBuilder should branch first on token type and then on insertion mode
​https://bugs.webkit.org/show_bug.cgi?id=41232

This is different than how the spec is written, but it lets us remove a
lot of redudancy in the algorithm. We might even want to pull some of
the branches on token name outside the insertion mode branch, but I'll
leave that for a future patch.

Although this looks like a big patch, it's mostly just a mechanical
switch permutation.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::constructTreeFromToken): (WebCore::HTMLTreeBuilder::processToken): (WebCore::HTMLTreeBuilder::processDoctypeToken): (WebCore::HTMLTreeBuilder::processStartTag): (WebCore::HTMLTreeBuilder::processEndTag): (WebCore::HTMLTreeBuilder::processComment): (WebCore::HTMLTreeBuilder::processCharacter): (WebCore::HTMLTreeBuilder::processEndOfFile): (WebCore::HTMLTreeBuilder::processDefaultForInitialMode): (WebCore::HTMLTreeBuilder::processDefaultForBeforeHTMLMode): (WebCore::HTMLTreeBuilder::processDefaultForBeforeHeadMode): (WebCore::HTMLTreeBuilder::processDefaultForInHeadMode): (WebCore::HTMLTreeBuilder::processDefaultForInHeadNoscriptMode): (WebCore::HTMLTreeBuilder::processDefaultForAfterHeadMode):
  • html/HTMLTreeBuilder.h:
4:32 PM Changeset in webkit [61914] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-06-25 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Tree builder doesn't need to return a Node
​https://bugs.webkit.org/show_bug.cgi?id=41225

The old tree builder returned the newly inserted Node, but the new tree
builder doesn't need to do that as far as I can tell. Removing the
return value cuts down on a bunch of accounting.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::passTokenToLegacyParser): (WebCore::HTMLTreeBuilder::constructTreeFromToken): (WebCore::HTMLTreeBuilder::processToken): (WebCore::HTMLTreeBuilder::insertDoctype): (WebCore::HTMLTreeBuilder::insertComment): (WebCore::HTMLTreeBuilder::insertGenericRCDATAElement): (WebCore::HTMLTreeBuilder::insertGenericRawTextElement): (WebCore::HTMLTreeBuilder::insertScriptElement):
  • html/HTMLTreeBuilder.h:
4:14 PM Changeset in webkit [61913] by eric@webkit.org
  • 15 edits
    1 copy in trunk/WebCore

2010-06-25 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

getParameter(COLOR_WRITEMASK) needs to return Array
​https://bugs.webkit.org/show_bug.cgi?id=40437

  • bindings/js/JSWebGLRenderingContextCustom.cpp: Handling bool array. (WebCore::toJS):
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: Handling bool array. (WebCore::toV8Object):
  • html/canvas/WebGLGetInfo.cpp: Handling bool array. (WebCore::WebGLGetInfo::WebGLGetInfo): (WebCore::WebGLGetInfo::getBoolArray):
  • html/canvas/WebGLGetInfo.h: Handling bool array. (WebCore::WebGLGetInfo::):
  • html/canvas/WebGLRenderingContext.cpp: Handling bool array. (WebCore::WebGLRenderingContext::getParameter): (WebCore::WebGLRenderingContext::getBooleanArrayParameter):
  • html/canvas/WebGLRenderingContext.h: Handling bool array.
4:09 PM Changeset in webkit [61912] by hclam@chromium.org
  • 625 edits in trunk/LayoutTests

Unreviewed. Build fix.

r61908 affected all image test on Chromium linux. Rebaseline those affected tests.

  • platform/chromium-linux/css1/basic/class_as_selector-expected.png:
  • platform/chromium-linux/css1/basic/comments-expected.png:
  • platform/chromium-linux/css1/basic/containment-expected.png:
  • platform/chromium-linux/css1/basic/id_as_selector-expected.png:
  • platform/chromium-linux/css1/basic/inheritance-expected.png:
  • platform/chromium-linux/css1/box_properties/border-expected.png:
  • platform/chromium-linux/css1/box_properties/border_bottom-expected.png:
  • platform/chromium-linux/css1/box_properties/border_bottom_width-expected.png:
  • platform/chromium-linux/css1/box_properties/border_left-expected.png:
  • platform/chromium-linux/css1/box_properties/border_left_width-expected.png:
  • platform/chromium-linux/css1/box_properties/border_right_inline-expected.png:
  • platform/chromium-linux/css1/box_properties/border_right_width-expected.png:
  • platform/chromium-linux/css1/box_properties/border_style-expected.png:
  • platform/chromium-linux/css1/box_properties/border_top-expected.png:
  • platform/chromium-linux/css1/box_properties/border_top_width-expected.png:
  • platform/chromium-linux/css1/box_properties/border_width-expected.png:
  • platform/chromium-linux/css1/box_properties/clear-expected.png:
  • platform/chromium-linux/css1/box_properties/clear_float-expected.png:
  • platform/chromium-linux/css1/box_properties/float_elements_in_series-expected.png:
  • platform/chromium-linux/css1/box_properties/float_margin-expected.png:
  • platform/chromium-linux/css1/box_properties/float_on_text_elements-expected.png:
  • platform/chromium-linux/css1/box_properties/height-expected.png:
  • platform/chromium-linux/css1/box_properties/margin-expected.png:
  • platform/chromium-linux/css1/box_properties/margin_bottom-expected.png:
  • platform/chromium-linux/css1/box_properties/margin_inline-expected.png:
  • platform/chromium-linux/css1/box_properties/margin_left-expected.png:
  • platform/chromium-linux/css1/box_properties/margin_right-expected.png:
  • platform/chromium-linux/css1/box_properties/margin_top-expected.png:
  • platform/chromium-linux/css1/box_properties/padding-expected.png:
  • platform/chromium-linux/css1/box_properties/padding_bottom-expected.png:
  • platform/chromium-linux/css1/box_properties/padding_inline-expected.png:
  • platform/chromium-linux/css1/box_properties/padding_left-expected.png:
  • platform/chromium-linux/css1/box_properties/padding_right-expected.png:
  • platform/chromium-linux/css1/box_properties/padding_top-expected.png:
  • platform/chromium-linux/css1/box_properties/width-expected.png:
  • platform/chromium-linux/css1/cascade/cascade_order-expected.png:
  • platform/chromium-linux/css1/classification/display-expected.png:
  • platform/chromium-linux/css1/classification/list_style_type-expected.png:
  • platform/chromium-linux/css1/classification/white_space-expected.png:
  • platform/chromium-linux/css1/color_and_background/background-expected.png:
  • platform/chromium-linux/css1/color_and_background/background_attachment-expected.png:
  • platform/chromium-linux/css1/color_and_background/background_position-expected.png:
  • platform/chromium-linux/css1/color_and_background/background_repeat-expected.png:
  • platform/chromium-linux/css1/conformance/forward_compatible_parsing-expected.png:
  • platform/chromium-linux/css1/font_properties/font-expected.png:
  • platform/chromium-linux/css1/font_properties/font_family-expected.png:
  • platform/chromium-linux/css1/font_properties/font_size-expected.png:
  • platform/chromium-linux/css1/font_properties/font_weight-expected.png:
  • platform/chromium-linux/css1/formatting_model/floating_elements-expected.png:
  • platform/chromium-linux/css1/formatting_model/height_of_lines-expected.png:
  • platform/chromium-linux/css1/formatting_model/horizontal_formatting-expected.png:
  • platform/chromium-linux/css1/formatting_model/inline_elements-expected.png:
  • platform/chromium-linux/css1/formatting_model/replaced_elements-expected.png:
  • platform/chromium-linux/css1/formatting_model/vertical_formatting-expected.png:
  • platform/chromium-linux/css1/pseudo/anchor-expected.png:
  • platform/chromium-linux/css1/pseudo/firstletter-expected.png:
  • platform/chromium-linux/css1/pseudo/firstline-expected.png:
  • platform/chromium-linux/css1/pseudo/multiple_pseudo_elements-expected.png:
  • platform/chromium-linux/css1/pseudo/pseudo_elements_in_selectors-expected.png:
  • platform/chromium-linux/css1/text_properties/letter_spacing-expected.png:
  • platform/chromium-linux/css1/text_properties/line_height-expected.png:
  • platform/chromium-linux/css1/text_properties/text_decoration-expected.png:
  • platform/chromium-linux/css1/text_properties/text_indent-expected.png:
  • platform/chromium-linux/css1/text_properties/text_transform-expected.png:
  • platform/chromium-linux/css1/text_properties/vertical_align-expected.png:
  • platform/chromium-linux/css1/text_properties/word_spacing-expected.png:
  • platform/chromium-linux/css1/units/color_units-expected.png:
  • platform/chromium-linux/css1/units/length_units-expected.png:
  • platform/chromium-linux/css2.1/t0803-c5502-mrgn-r-02-c-expected.png:
  • platform/chromium-linux/css2.1/t0803-c5505-mrgn-02-c-expected.png:
  • platform/chromium-linux/css2.1/t080301-c411-vt-mrgn-00-b-expected.png:
  • platform/chromium-linux/css2.1/t0905-c5525-fltclr-00-c-ag-expected.png:
  • platform/chromium-linux/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png:
  • platform/chromium-linux/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
  • platform/chromium-linux/css2.1/t0905-c5526-fltclr-00-c-ag-expected.png:
  • platform/chromium-linux/css2.1/t1002-c5523-width-02-b-g-expected.png:
  • platform/chromium-linux/css2.1/t1202-counters-08-b-expected.png:
  • platform/chromium-linux/css2.1/t1202-counters-09-b-expected.png:
  • platform/chromium-linux/css2.1/t140201-c535-bg-fixd-00-b-g-expected.png:
  • platform/chromium-linux/css2.1/t140201-c537-bgfxps-00-c-ag-expected.png:
  • platform/chromium-linux/css2.1/t1508-c527-font-07-b-expected.png:
  • platform/chromium-linux/editing/deleting/5168598-expected.png:
  • platform/chromium-linux/editing/deleting/delete-after-span-ws-001-expected.png:
  • platform/chromium-linux/editing/deleting/delete-after-span-ws-002-expected.png:
  • platform/chromium-linux/editing/deleting/delete-after-span-ws-003-expected.png:
  • platform/chromium-linux/editing/deleting/delete-line-end-ws-001-expected.png:
  • platform/chromium-linux/editing/deleting/delete-line-end-ws-002-expected.png:
  • platform/chromium-linux/editing/input/emacs-ctrl-o-expected.png:
  • platform/chromium-linux/editing/inserting/12882-expected.png:
  • platform/chromium-linux/editing/inserting/5607069-2-expected.png:
  • platform/chromium-linux/editing/inserting/insert-div-023-expected.png:
  • platform/chromium-linux/editing/pasteboard/emacs-cntl-y-001-expected.png:
  • platform/chromium-linux/editing/pasteboard/emacs-ctrl-a-k-y-expected.png:
  • platform/chromium-linux/editing/pasteboard/emacs-ctrl-k-y-001-expected.png:
  • platform/chromium-linux/editing/selection/5354455-1-expected.png:
  • platform/chromium-linux/editing/selection/5354455-2-expected.png:
  • platform/chromium-linux/editing/selection/designmode-no-caret-expected.png:
  • platform/chromium-linux/editing/selection/focus_editable_html-expected.png:
  • platform/chromium-linux/editing/selection/iframe-expected.png:
  • platform/chromium-linux/editing/selection/move-by-line-001-expected.png:
  • platform/chromium-linux/editing/selection/select-all-001-expected.png:
  • platform/chromium-linux/editing/selection/select-all-002-expected.png:
  • platform/chromium-linux/editing/selection/select-all-003-expected.png:
  • platform/chromium-linux/editing/selection/select-all-004-expected.png:
  • platform/chromium-linux/editing/selection/unrendered-001-expected.png:
  • platform/chromium-linux/editing/selection/unrendered-002-expected.png:
  • platform/chromium-linux/editing/selection/unrendered-003-expected.png:
  • platform/chromium-linux/editing/selection/unrendered-004-expected.png:
  • platform/chromium-linux/editing/selection/unrendered-005-expected.png:
  • platform/chromium-linux/fast/backgrounds/001-expected.png:
  • platform/chromium-linux/fast/backgrounds/background-inherit-color-bug-expected.png:
  • platform/chromium-linux/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/chromium-linux/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-linux/fast/backgrounds/svg-as-background-1-expected.png:
  • platform/chromium-linux/fast/block/basic/016-expected.png:
  • platform/chromium-linux/fast/block/basic/fieldset-stretch-to-legend-expected.png:
  • platform/chromium-linux/fast/block/float/008-expected.png:
  • platform/chromium-linux/fast/block/float/013-expected.png:
  • platform/chromium-linux/fast/block/float/019-expected.png:
  • platform/chromium-linux/fast/block/float/021-expected.png:
  • platform/chromium-linux/fast/block/float/025-expected.png:
  • platform/chromium-linux/fast/block/float/026-expected.png:
  • platform/chromium-linux/fast/block/float/027-expected.png:
  • platform/chromium-linux/fast/block/float/028-expected.png:
  • platform/chromium-linux/fast/block/float/032-expected.png:
  • platform/chromium-linux/fast/block/float/033-expected.png:
  • platform/chromium-linux/fast/block/float/035-expected.png:
  • platform/chromium-linux/fast/block/float/avoidance-percent-width-strict-expected.png:
  • platform/chromium-linux/fast/block/float/br-with-clear-2-expected.png:
  • platform/chromium-linux/fast/block/float/float-avoidance-expected.png:
  • platform/chromium-linux/fast/block/float/nested-clearance-expected.png:
  • platform/chromium-linux/fast/block/float/relative-painted-twice-expected.png:
  • platform/chromium-linux/fast/block/margin-collapse/103-expected.png:
  • platform/chromium-linux/fast/block/margin-collapse/104-expected.png:
  • platform/chromium-linux/fast/block/margin-collapse/empty-clear-blocks-expected.png:
  • platform/chromium-linux/fast/block/positioning/047-expected.png:
  • platform/chromium-linux/fast/block/positioning/051-expected.png:
  • platform/chromium-linux/fast/block/positioning/055-expected.png:
  • platform/chromium-linux/fast/block/positioning/auto/007-expected.png:
  • platform/chromium-linux/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.png:
  • platform/chromium-linux/fast/block/positioning/negative-rel-position-expected.png:
  • platform/chromium-linux/fast/block/positioning/relative-overflow-block-expected.png:
  • platform/chromium-linux/fast/block/positioning/relative-overflow-replaced-expected.png:
  • platform/chromium-linux/fast/block/positioning/relative-overflow-replaced-float-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/001-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/001-xhtml-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/002-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/002-xhtml-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/003-declarative-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/003-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/003-xhtml-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/004-declarative-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/004-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/004-xhtml-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/005-declarative-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/005-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/005-xhtml-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/006-declarative-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/006-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/006-xhtml-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/007-declarative-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/007-expected.png:
  • platform/chromium-linux/fast/body-propagation/overflow/007-xhtml-expected.png:
  • platform/chromium-linux/fast/borders/inline-mask-overlay-image-expected.png:
  • platform/chromium-linux/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-linux/fast/box-sizing/box-sizing-expected.png:
  • platform/chromium-linux/fast/canvas/canvas-bg-expected.png:
  • platform/chromium-linux/fast/canvas/canvas-text-alignment-expected.png:
  • platform/chromium-linux/fast/canvas/image-object-in-canvas-expected.png:
  • platform/chromium-linux/fast/clip/014-expected.png:
  • platform/chromium-linux/fast/css-generated-content/014-expected.png:
  • platform/chromium-linux/fast/css/005-expected.png:
  • platform/chromium-linux/fast/css/MarqueeLayoutTest-expected.png:
  • platform/chromium-linux/fast/css/border-height-expected.png:
  • platform/chromium-linux/fast/css/css2-system-fonts-expected.png:
  • platform/chromium-linux/fast/css/empty-pseudo-class-expected.png:
  • platform/chromium-linux/fast/css/first-child-pseudo-class-expected.png:
  • platform/chromium-linux/fast/css/first-of-type-pseudo-class-expected.png:
  • platform/chromium-linux/fast/css/font-face-descriptor-multiple-values-expected.png:
  • platform/chromium-linux/fast/css/font-face-implicit-local-font-expected.png:
  • platform/chromium-linux/fast/css/font-face-in-shadow-DOM-expected.png:
  • platform/chromium-linux/fast/css/font_property_normal-expected.png:
  • platform/chromium-linux/fast/css/hsl-color-expected.png:
  • platform/chromium-linux/fast/css/last-child-pseudo-class-expected.png:
  • platform/chromium-linux/fast/css/last-of-type-pseudo-class-expected.png:
  • platform/chromium-linux/fast/css/line-height-overflow-expected.png:
  • platform/chromium-linux/fast/css/nested-floating-relative-position-percentages-expected.png:
  • platform/chromium-linux/fast/css/nested-rounded-corners-expected.png:
  • platform/chromium-linux/fast/css/only-child-pseudo-class-expected.png:
  • platform/chromium-linux/fast/css/only-of-type-pseudo-class-expected.png:
  • platform/chromium-linux/fast/css/percentage-non-integer-expected.png:
  • platform/chromium-linux/fast/css/positioned-overflow-scroll-expected.png:
  • platform/chromium-linux/fast/css/text-overflow-ellipsis-expected.png:
  • platform/chromium-linux/fast/css/text-overflow-ellipsis-strict-expected.png:
  • platform/chromium-linux/fast/css/variables/misplaced-import-test-expected.png:
  • platform/chromium-linux/fast/css/word-space-extra-expected.png:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
  • platform/chromium-linux/fast/dom/clientWidthAfterDocumentIsRemoved-expected.png:
  • platform/chromium-linux/fast/dom/clone-node-dynamic-style-expected.png:
  • platform/chromium-linux/fast/dom/focus-contenteditable-expected.png:
  • platform/chromium-linux/fast/dom/gc-10-expected.png:
  • platform/chromium-linux/fast/dynamic/008-expected.png:
  • platform/chromium-linux/fast/dynamic/anchor-lock-expected.png:
  • platform/chromium-linux/fast/dynamic/insert-before-table-part-in-continuation-expected.png:
  • platform/chromium-linux/fast/encoding/utf-16-big-endian-expected.png:
  • platform/chromium-linux/fast/encoding/utf-16-little-endian-expected.png:
  • platform/chromium-linux/fast/events/5056619-expected.png:
  • platform/chromium-linux/fast/events/autoscroll-expected.png:
  • platform/chromium-linux/fast/events/keydown-1-expected.png:
  • platform/chromium-linux/fast/events/pointer-events-2-expected.png:
  • platform/chromium-linux/fast/events/reveal-link-when-focused-expected.png:
  • platform/chromium-linux/fast/events/standalone-image-drag-to-editable-expected.png:
  • platform/chromium-linux/fast/flexbox/009-expected.png:
  • platform/chromium-linux/fast/flexbox/016-expected.png:
  • platform/chromium-linux/fast/flexbox/flex-hang-expected.png:
  • platform/chromium-linux/fast/forms/001-expected.png:
  • platform/chromium-linux/fast/forms/HTMLOptionElement_label05-expected.png:
  • platform/chromium-linux/fast/forms/basic-textareas-expected.png:
  • platform/chromium-linux/fast/forms/basic-textareas-quirks-expected.png:
  • platform/chromium-linux/fast/forms/button-default-title-expected.png:
  • platform/chromium-linux/fast/forms/disabled-select-change-index-expected.png:
  • platform/chromium-linux/fast/forms/fieldset-align-expected.png:
  • platform/chromium-linux/fast/forms/file-input-direction-expected.png:
  • platform/chromium-linux/fast/forms/form-element-geometry-expected.png:
  • platform/chromium-linux/fast/forms/form-hides-table-expected.png:
  • platform/chromium-linux/fast/forms/input-appearance-selection-expected.png:
  • platform/chromium-linux/fast/forms/input-first-letter-expected.png:
  • platform/chromium-linux/fast/forms/input-table-expected.png:
  • platform/chromium-linux/fast/forms/input-text-double-click-expected.png:
  • platform/chromium-linux/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/chromium-linux/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
  • platform/chromium-linux/fast/forms/listbox-scrollbar-incremental-load-expected.png:
  • platform/chromium-linux/fast/forms/listbox-width-change-expected.png:
  • platform/chromium-linux/fast/forms/option-strip-whitespace-expected.png:
  • platform/chromium-linux/fast/forms/search-display-none-cancel-button-expected.png:
  • platform/chromium-linux/fast/forms/search-placeholder-value-changed-expected.png:
  • platform/chromium-linux/fast/forms/searchfield-heights-expected.png:
  • platform/chromium-linux/fast/forms/select-block-background-expected.png:
  • platform/chromium-linux/fast/forms/select-change-listbox-size-expected.png:
  • platform/chromium-linux/fast/forms/select-change-popup-to-listbox-expected.png:
  • platform/chromium-linux/fast/forms/select-initial-position-expected.png:
  • platform/chromium-linux/fast/forms/select-item-background-clip-expected.png:
  • platform/chromium-linux/fast/forms/select-list-box-with-height-expected.png:
  • platform/chromium-linux/fast/forms/select-visual-hebrew-expected.png:
  • platform/chromium-linux/fast/forms/select-writing-direction-natural-expected.png:
  • platform/chromium-linux/fast/forms/tabbing-input-iframe-expected.png:
  • platform/chromium-linux/fast/forms/textAreaLineHeight-expected.png:
  • platform/chromium-linux/fast/forms/textarea-scroll-height-expected.png:
  • platform/chromium-linux/fast/forms/textarea-scrollbar-expected.png:
  • platform/chromium-linux/fast/forms/textarea-scrolled-type-expected.png:
  • platform/chromium-linux/fast/forms/textarea-width-expected.png:
  • platform/chromium-linux/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/chromium-linux/fast/frames/frame-scrolling-attribute-expected.png:
  • platform/chromium-linux/fast/frames/iframe-scrolling-attribute-expected.png:
  • platform/chromium-linux/fast/frames/inline-object-inside-frameset-expected.png:
  • platform/chromium-linux/fast/frames/invalid-expected.png:
  • platform/chromium-linux/fast/frames/onlyCommentInIFrame-expected.png:
  • platform/chromium-linux/fast/frames/take-focus-from-iframe-expected.png:
  • platform/chromium-linux/fast/frames/valid-expected.png:
  • platform/chromium-linux/fast/frames/viewsource-attribute-expected.png:
  • platform/chromium-linux/fast/gradients/background-clipped-expected.png:
  • platform/chromium-linux/fast/images/pdf-as-image-expected.png:
  • platform/chromium-linux/fast/images/pdf-as-image-landscape-expected.png:
  • platform/chromium-linux/fast/inline-block/inline-block-vertical-align-expected.png:
  • platform/chromium-linux/fast/inline-block/tricky-baseline-expected.png:
  • platform/chromium-linux/fast/inline/inline-borders-with-bidi-override-expected.png:
  • platform/chromium-linux/fast/inline/inline-continuation-borders-expected.png:
  • platform/chromium-linux/fast/inline/long-wrapped-line-expected.png:
  • platform/chromium-linux/fast/invalid/residual-style-expected.png:
  • platform/chromium-linux/fast/layers/opacity-transforms-expected.png:
  • platform/chromium-linux/fast/layers/overflow-scroll-auto-switch-expected.png:
  • platform/chromium-linux/fast/layers/scroll-rect-to-visible-expected.png:
  • platform/chromium-linux/fast/lists/008-expected.png:
  • platform/chromium-linux/fast/lists/alpha-list-wrap-expected.png:
  • platform/chromium-linux/fast/lists/drag-into-marker-expected.png:
  • platform/chromium-linux/fast/lists/li-br-expected.png:
  • platform/chromium-linux/fast/lists/ol-start-parsing-expected.png:
  • platform/chromium-linux/fast/lists/olstart-expected.png:
  • platform/chromium-linux/fast/lists/w3-css3-list-styles-alphabetic-expected.png:
  • platform/chromium-linux/fast/lists/w3-css3-list-styles-numeric-expected.png:
  • platform/chromium-linux/fast/lists/w3-list-styles-expected.png:
  • platform/chromium-linux/fast/media/mq-relative-constraints-02-expected.png:
  • platform/chromium-linux/fast/media/mq-relative-constraints-03-expected.png:
  • platform/chromium-linux/fast/media/mq-relative-constraints-04-expected.png:
  • platform/chromium-linux/fast/media/mq-relative-constraints-05-expected.png:
  • platform/chromium-linux/fast/media/mq-relative-constraints-06-expected.png:
  • platform/chromium-linux/fast/media/mq-relative-constraints-07-expected.png:
  • platform/chromium-linux/fast/media/mq-relative-constraints-08-expected.png:
  • platform/chromium-linux/fast/media/mq-relative-constraints-09-expected.png:
  • platform/chromium-linux/fast/media/mq-width-absolute-01-expected.png:
  • platform/chromium-linux/fast/media/mq-width-absolute-02-expected.png:
  • platform/chromium-linux/fast/media/mq-width-absolute-03-expected.png:
  • platform/chromium-linux/fast/media/mq-width-absolute-04-expected.png:
  • platform/chromium-linux/fast/multicol/client-rects-expected.png:
  • platform/chromium-linux/fast/multicol/column-rules-stacking-expected.png:
  • platform/chromium-linux/fast/multicol/columns-shorthand-parsing-expected.png:
  • platform/chromium-linux/fast/multicol/float-multicol-expected.png:
  • platform/chromium-linux/fast/multicol/layers-in-multicol-expected.png:
  • platform/chromium-linux/fast/multicol/layers-split-across-columns-expected.png:
  • platform/chromium-linux/fast/multicol/nested-columns-expected.png:
  • platform/chromium-linux/fast/multicol/positioned-with-constrained-height-expected.png:
  • platform/chromium-linux/fast/multicol/span/anonymous-style-inheritance-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-expected.png:
  • platform/chromium-linux/fast/multicol/span/span-margin-collapsing-expected.png:
  • platform/chromium-linux/fast/overflow/002-expected.png:
  • platform/chromium-linux/fast/overflow/003-expected.png:
  • platform/chromium-linux/fast/overflow/005-expected.png:
  • platform/chromium-linux/fast/overflow/006-expected.png:
  • platform/chromium-linux/fast/overflow/007-expected.png:
  • platform/chromium-linux/fast/overflow/008-expected.png:
  • platform/chromium-linux/fast/overflow/childFocusRingClip-expected.png:
  • platform/chromium-linux/fast/overflow/clip-rects-fixed-ancestor-expected.png:
  • platform/chromium-linux/fast/overflow/float-in-relpositioned-expected.png:
  • platform/chromium-linux/fast/overflow/hit-test-overflow-controls-expected.png:
  • platform/chromium-linux/fast/overflow/image-selection-highlight-expected.png:
  • platform/chromium-linux/fast/overflow/overflow-auto-position-absolute-expected.png:
  • platform/chromium-linux/fast/overflow/overflow-auto-table-expected.png:
  • platform/chromium-linux/fast/overflow/overflow-rtl-expected.png:
  • platform/chromium-linux/fast/overflow/overflow-stacking-expected.png:
  • platform/chromium-linux/fast/overflow/overflow-text-hit-testing-expected.png:
  • platform/chromium-linux/fast/overflow/overflow-with-local-background-attachment-expected.png:
  • platform/chromium-linux/fast/overflow/overflow-x-y-expected.png:
  • platform/chromium-linux/fast/overflow/position-fixed-transform-clipping-expected.png:
  • platform/chromium-linux/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
  • platform/chromium-linux/fast/overflow/scrollRevealButton-expected.png:
  • platform/chromium-linux/fast/overflow/scrollbar-position-update-expected.png:
  • platform/chromium-linux/fast/overflow/table-overflow-float-expected.png:
  • platform/chromium-linux/fast/overflow/unreachable-overflow-rtl-bug-expected.png:
  • platform/chromium-linux/fast/parser/open-comment-in-textarea-expected.png:
  • platform/chromium-linux/fast/reflections/reflection-direction-expected.png:
  • platform/chromium-linux/fast/repaint/block-selection-gap-stale-cache-2-expected.png:
  • platform/chromium-linux/fast/repaint/box-shadow-v-expected.png:
  • platform/chromium-linux/fast/repaint/dynamic-table-vertical-alignment-change-expected.png:
  • platform/chromium-linux/fast/repaint/fixed-child-move-after-scroll-expected.png:
  • platform/chromium-linux/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png:
  • platform/chromium-linux/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png:
  • platform/chromium-linux/fast/repaint/fixed-expected.png:
  • platform/chromium-linux/fast/repaint/fixed-move-after-keyboard-scroll-expected.png:
  • platform/chromium-linux/fast/repaint/fixed-move-after-scroll-expected.png:
  • platform/chromium-linux/fast/repaint/fixed-tranformed-expected.png:
  • platform/chromium-linux/fast/repaint/layout-state-only-positioned-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/chromium-linux/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/chromium-linux/fast/repaint/list-marker-expected.png:
  • platform/chromium-linux/fast/repaint/moving-shadow-on-container-expected.png:
  • platform/chromium-linux/fast/repaint/moving-shadow-on-path-expected.png:
  • platform/chromium-linux/fast/repaint/overflow-scroll-body-appear-expected.png:
  • platform/chromium-linux/fast/repaint/overflow-scroll-delete-expected.png:
  • platform/chromium-linux/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
  • platform/chromium-linux/fast/repaint/repaint-during-scroll-expected.png:
  • platform/chromium-linux/fast/repaint/selection-gap-overflow-scroll-2-expected.png:
  • platform/chromium-linux/fast/repaint/selection-gap-overflow-scroll-expected.png:
  • platform/chromium-linux/fast/replaced/005-expected.png:
  • platform/chromium-linux/fast/replaced/border-radius-clip-expected.png:
  • platform/chromium-linux/fast/replaced/pdf-as-image-expected.png:
  • platform/chromium-linux/fast/replaced/replaced-breaking-expected.png:
  • platform/chromium-linux/fast/replaced/width100percent-image-expected.png:
  • platform/chromium-linux/fast/replaced/width100percent-menulist-expected.png:
  • platform/chromium-linux/fast/replaced/width100percent-searchfield-expected.png:
  • platform/chromium-linux/fast/replaced/width100percent-textarea-expected.png:
  • platform/chromium-linux/fast/selectors/166-expected.png:
  • platform/chromium-linux/fast/table/023-expected.png:
  • platform/chromium-linux/fast/table/034-expected.png:
  • platform/chromium-linux/fast/table/040-expected.png:
  • platform/chromium-linux/fast/table/border-collapsing/004-expected.png:
  • platform/chromium-linux/fast/table/edge-offsets-expected.png:
  • platform/chromium-linux/fast/table/empty-cells-expected.png:
  • platform/chromium-linux/fast/table/frame-and-rules-expected.png:
  • platform/chromium-linux/fast/table/height-percent-test-expected.png:
  • platform/chromium-linux/fast/table/overflowHidden-expected.png:
  • platform/chromium-linux/fast/table/prepend-in-anonymous-table-expected.png:
  • platform/chromium-linux/fast/table/table-display-types-expected.png:
  • platform/chromium-linux/fast/table/wide-colspan-expected.png:
  • platform/chromium-linux/fast/table/wide-column-expected.png:
  • platform/chromium-linux/fast/text/drawBidiText-expected.png:
  • platform/chromium-linux/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
  • platform/chromium-linux/fast/text/international/bidi-european-terminators-expected.png:
  • platform/chromium-linux/fast/text/international/bidi-listbox-atsui-expected.png:
  • platform/chromium-linux/fast/text/international/bidi-listbox-expected.png:
  • platform/chromium-linux/fast/text/international/bidi-neutral-run-expected.png:
  • platform/chromium-linux/fast/text/international/thai-line-breaks-expected.png:
  • platform/chromium-linux/fast/text/softHyphen-expected.png:
  • platform/chromium-linux/fast/text/text-letter-spacing-expected.png:
  • platform/chromium-linux/fast/text/updateNewFont-expected.png:
  • platform/chromium-linux/fast/text/wbr-expected.png:
  • platform/chromium-linux/fast/text/whitespace/024-expected.png:
  • platform/chromium-linux/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png:
  • platform/chromium-linux/fast/text/word-break-expected.png:
  • platform/chromium-linux/fonts/cursive-expected.png:
  • platform/chromium-linux/fonts/default-expected.png:
  • platform/chromium-linux/fonts/fantasy-expected.png:
  • platform/chromium-linux/fonts/monospace-expected.png:
  • platform/chromium-linux/fonts/sans-serif-expected.png:
  • platform/chromium-linux/fonts/serif-expected.png:
  • platform/chromium-linux/http/tests/navigation/anchor-frames-expected.png:
  • platform/chromium-linux/http/tests/navigation/error404-frames-expected.png:
  • platform/chromium-linux/http/tests/navigation/error404-goback-expected.png:
  • platform/chromium-linux/http/tests/navigation/error404-subframeload-expected.png:
  • platform/chromium-linux/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/chromium-linux/http/tests/navigation/post-frames-expected.png:
  • platform/chromium-linux/http/tests/navigation/post-goback1-expected.png:
  • platform/chromium-linux/http/tests/navigation/postredirect-frames-expected.png:
  • platform/chromium-linux/media/video-controls-rendering-expected.png:
  • platform/chromium-linux/media/video-zoom-expected.png:
  • platform/chromium-linux/platform/chromium/fast/text/chromium-linux-fontconfig-renderstyle-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-02-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-04-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-05-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-06-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-07-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-path-02-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-path-05-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/struct-use-01-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-path-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-spacing-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png:
  • platform/chromium-linux/svg/carto.net/button-expected.png:
  • platform/chromium-linux/svg/carto.net/combobox-expected.png:
  • platform/chromium-linux/svg/carto.net/slider-expected.png:
  • platform/chromium-linux/svg/carto.net/textbox-expected.png:
  • platform/chromium-linux/svg/carto.net/window-expected.png:
  • platform/chromium-linux/svg/css/stars-with-shadow-expected.png:
  • platform/chromium-linux/svg/custom/altglyph-expected.png:
  • platform/chromium-linux/svg/custom/animate-path-morphing-expected.png:
  • platform/chromium-linux/svg/custom/invisible-text-after-scrolling-expected.png:
  • platform/chromium-linux/svg/custom/js-update-transform-changes-expected.png:
  • platform/chromium-linux/svg/custom/junk-data-expected.png:
  • platform/chromium-linux/svg/custom/marker-child-changes-expected.png:
  • platform/chromium-linux/svg/custom/marker-viewBox-changes-expected.png:
  • platform/chromium-linux/svg/custom/mask-changes-expected.png:
  • platform/chromium-linux/svg/custom/missing-xlink-expected.png:
  • platform/chromium-linux/svg/custom/path-bad-data-expected.png:
  • platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/chromium-linux/svg/custom/text-xy-updates-SVGList-expected.png:
  • platform/chromium-linux/svg/custom/use-detach-expected.png:
  • platform/chromium-linux/svg/custom/use-property-changes-through-svg-dom-expected.png:
  • platform/chromium-linux/svg/custom/use-referencing-nonexisting-symbol-expected.png:
  • platform/chromium-linux/svg/custom/use-transform-expected.png:
  • platform/chromium-linux/svg/filters/filterRes-expected.png:
  • platform/chromium-linux/svg/hixie/error/012-expected.png:
  • platform/chromium-linux/svg/hixie/links/003-broken-expected.png:
  • platform/chromium-linux/svg/hixie/perf/003-expected.png:
  • platform/chromium-linux/svg/hixie/perf/004-expected.png:
  • platform/chromium-linux/svg/hixie/perf/005-expected.png:
  • platform/chromium-linux/svg/hixie/perf/006-expected.png:
  • platform/chromium-linux/svg/hixie/text/003b-expected.png:
  • platform/chromium-linux/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png:
  • platform/chromium-linux/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png:
  • platform/chromium-linux/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png:
  • platform/chromium-linux/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png:
  • platform/chromium-linux/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png:
  • platform/chromium-linux/svg/text/kerning-expected.png:
  • platform/chromium-linux/svg/text/multichar-glyph-expected.png:
  • platform/chromium-linux/svg/zoom/page/absolute-sized-document-scrollbars-expected.png:
  • platform/chromium-linux/svg/zoom/page/relative-sized-document-scrollbars-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-linux/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/45621-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug101674-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug10269-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug10296-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1055-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug113235-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug113235-3-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug11944-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug120364-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1302-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug131020-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug131020_iframe-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug137388-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug149275-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug16252-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug22019-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug23151-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2479-4-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug27038-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug28341-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug29314-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2947-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug2997-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug32205-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug38916-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug3977-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug43039-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug43854-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug44505-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug46480-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug46480-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug50695-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug56405-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug5797-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug5835-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug650-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug67915-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug7112-1-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug7112-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug73321-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug8858-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug92143-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug96343-expected.png:
  • platform/chromium-linux/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
  • platform/chromium-linux/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-linux/tables/mozilla/core/borders-expected.png:
  • platform/chromium-linux/tables/mozilla/core/captions-expected.png:
  • platform/chromium-linux/tables/mozilla/core/cell_heights-expected.png:
  • platform/chromium-linux/tables/mozilla/core/col_span-expected.png:
  • platform/chromium-linux/tables/mozilla/core/col_widths_auto_fix-expected.png:
  • platform/chromium-linux/tables/mozilla/core/col_widths_fix_fixPer-expected.png:
  • platform/chromium-linux/tables/mozilla/core/nested1-expected.png:
  • platform/chromium-linux/tables/mozilla/core/one_row-expected.png:
  • platform/chromium-linux/tables/mozilla/core/row_span-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_index-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_position-table-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_bgcolor_name-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_bgcolor_name-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_bgcolor_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_height-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_td_nowrap-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_bgcolor_name-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_bgcolor_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_height-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_th_nowrap-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_bgcolor_name-expected.png:
  • platform/chromium-linux/tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.png:
  • platform/chromium-linux/tables/mozilla/other/cell_widths-expected.png:
  • platform/chromium-linux/tables/mozilla/other/nestedTables-expected.png:
  • platform/chromium-linux/tables/mozilla/other/test3-expected.png:
  • platform/chromium-linux/tables/mozilla/other/test6-expected.png:
  • platform/chromium-linux/tables/mozilla/other/wa_table_thtd_rowspan-expected.png:
  • platform/chromium-linux/tables/mozilla/other/wa_table_tr_align-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug10140-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug101759-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug10216-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug106966-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug14007-1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug178855-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug19526-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug22122-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug67915-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug7243-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug91057-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/backgrounds-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/captions3-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/col_span2-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/columns-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/conflicts-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/core/standards1-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/other/empty_cells-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/other/test4-expected.png:
  • platform/chromium-linux/transforms/2d/transform-fixed-container-expected.png:
3:58 PM Changeset in webkit [61911] by crogers@google.com
  • 1 edit in branches/audio/WebCore/audio/AudioMixer.cpp

Get rid of fastMalloc() hack

3:47 PM Changeset in webkit [61910] by commit-queue@webkit.org
  • 10 edits in trunk

2010-06-25 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

getParameter(COLOR_WRITEMASK) needs to return Array
​https://bugs.webkit.org/show_bug.cgi?id=40437

  • fast/canvas/webgl/gl-get-calls-expected.txt: getParameter(COLOR_WRITEMASK) returns bool array.
  • fast/canvas/webgl/gl-get-calls.html: Ditto.

2010-06-25 Zhenyao Mo <​zmo@google.com>

Reviewed by Dimitri Glazkov.

getParameter(COLOR_WRITEMASK) needs to return Array
​https://bugs.webkit.org/show_bug.cgi?id=40437

  • bindings/js/JSWebGLRenderingContextCustom.cpp: Handling bool array. (WebCore::toJS):
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: Handling bool array. (WebCore::toV8Object):
  • html/canvas/WebGLGetInfo.cpp: Handling bool array. (WebCore::WebGLGetInfo::WebGLGetInfo): (WebCore::WebGLGetInfo::getBoolArray):
  • html/canvas/WebGLGetInfo.h: Handling bool array. (WebCore::WebGLGetInfo::):
  • html/canvas/WebGLRenderingContext.cpp: Handling bool array. (WebCore::WebGLRenderingContext::getParameter): (WebCore::WebGLRenderingContext::getBooleanArrayParameter):
  • html/canvas/WebGLRenderingContext.h: Handling bool array.
3:34 PM Changeset in webkit [61909] by commit-queue@webkit.org
  • 9 edits in trunk/WebKitTools

2010-06-25 Prasad Tammana <​prasadt@chromium.org>

Reviewed by Dmitry Titov.

Add empty abortModal() method to all platforms.
​https://bugs.webkit.org/show_bug.cgi?id=40864

Add an empty abortModal() stub to LayoutTestController on all platforms to get rid of platform specific #ifs in
platform independent LayoutTestController code. Without this change, layout tests using LayoutTestController tests
that use abortModal will become mac specific which is not desirable.

  • DumpRenderTree/LayoutTestController.cpp: (abortModalCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::abortModal):
  • DumpRenderTree/chromium/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::abortModal):
  • DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::abortModal):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::abortModal):
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::abortModal):
3:09 PM Changeset in webkit [61908] by estade@chromium.org
  • 7 edits in trunk/WebCore

[chromium linux] Improve look of scrollbars
​https://bugs.webkit.org/show_bug.cgi?id=35775

Reviewed by Darin Fisher.

This will affect layout pixel tests, which will need to be rebaselined.

  • platform/Scrollbar.cpp: need the buttons to be invalidated when the

thumb moves as they paint differently if the thumb is at the top or
bottom
(WebCore::Scrollbar::updateThumbPosition):
(WebCore::Scrollbar::updateThumbProportion):

  • platform/chromium/ScrollbarThemeChromium.cpp:

(WebCore::ScrollbarThemeChromium::trackRect): share code between
linux/windows

  • platform/chromium/ScrollbarThemeChromiumLinux.cpp:

(WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness):
(WebCore::outlineColor): up the contrast
(WebCore::ScrollbarThemeChromiumLinux::paintButton): add custom button
drawing implementation
(WebCore::ScrollbarThemeChromiumLinux::buttonSize): add buttons

  • platform/chromium/ScrollbarThemeChromiumWin.cpp: share code between

linux/windows

  • rendering/RenderThemeChromiumLinux.cpp: improve stock colors to get

better contrast and integration with stock chrome theme

2:42 PM Changeset in webkit [61907] by crogers@google.com
  • 8 edits
    3 copies in branches/audio

merge remaining changes from trunk into audio branch: revisions 58269:61708

2:40 PM Changeset in webkit [61906] by weinig@apple.com
  • 3 edits
    6 adds in trunk/WebKitTools

Patch for ​https://bugs.webkit.org/show_bug.cgi?id=41226
Flesh out injected bundle code for WebKitTestRunner and add basic LayoutTestController.

Reviewed by Anders Carlsson.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Added.

(WTR::InjectedBundle::shared):
(WTR::InjectedBundle::InjectedBundle):
(WTR::InjectedBundle::_didCreatePage):
(WTR::InjectedBundle::_willDestroyPage):
(WTR::InjectedBundle::_didRecieveMessage):
(WTR::InjectedBundle::initialize):
(WTR::InjectedBundle::didCreatePage):
(WTR::InjectedBundle::willDestroyPage):
(WTR::InjectedBundle::didRecieveMessage):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h: Added.

(WTR::InjectedBundle::layoutTestController):

  • WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:

(WKBundleInitialize):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Added.

(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::~InjectedBundlePage):
(WTR::InjectedBundlePage::_didStartProvisionalLoadForFrame):
(WTR::InjectedBundlePage::_didReceiveServerRedirectForProvisionalLoadForFrame):
(WTR::InjectedBundlePage::_didFailProvisionalLoadWithErrorForFrame):
(WTR::InjectedBundlePage::_didCommitLoadForFrame):
(WTR::InjectedBundlePage::_didFinishLoadForFrame):
(WTR::InjectedBundlePage::_didFailLoadWithErrorForFrame):
(WTR::InjectedBundlePage::_didReceiveTitleForFrame):
(WTR::InjectedBundlePage::_didClearWindowForFrame):
(WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
(WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
(WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
(WTR::InjectedBundlePage::didCommitLoadForFrame):
(WTR::InjectedBundlePage::didFinishLoadForFrame):
(WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
(WTR::InjectedBundlePage::didReceiveTitleForFrame):
(WTR::InjectedBundlePage::didClearWindowForFrame):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added.

(WTR::InjectedBundlePage::page):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Added.

(WTR::LayoutTestController::create):
(WTR::LayoutTestController::LayoutTestController):
(WTR::LayoutTestController::~LayoutTestController):
(WTR::dumpAsTextCallback):
(WTR::layoutTestControllerObjectFinalize):
(WTR::LayoutTestController::makeWindowObject):
(WTR::LayoutTestController::getJSClass):
(WTR::LayoutTestController::staticFunctions):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added.

(WTR::LayoutTestController::dumpAsText):
(WTR::LayoutTestController::setDumpAsText):

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2:40 PM Changeset in webkit [61905] by crogers@google.com
  • 34 edits
    31 copies
    2 deletes in branches/audio

merge more changes from trunk into audio branch: revisions 58269:61708

2:37 PM Changeset in webkit [61904] by eric@webkit.org
  • 16 edits in trunk/WebCore

2010-06-25 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Split DocumentParser::write into separate append and insert calls
​https://bugs.webkit.org/show_bug.cgi?id=41197

Unfortunately this is still somewhat confusing as
"insert" means "insert this data at the current
insertion point and run the parser synchronously
unless we're in a nested write call" and "append"
means "append this data to the end and run the
parser if not in a nested call or until possibly yielding".

This at least makes clearer which document parsers implement
which behavior, and paves the way for moving the decoding
logic into DocumentParser from DocumentWriter.

No functional changes, thus no tests.

  • dom/Document.cpp: (WebCore::Document::write):
  • dom/DocumentParser.h:
  • dom/RawDataDocumentParser.h: (WebCore::RawDataDocumentParser::insert): (WebCore::RawDataDocumentParser::append):
  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::insert): (WebCore::XMLDocumentParser::append):
  • dom/XMLDocumentParser.h:
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::resumeParsing):
  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::insert): (WebCore::HTMLDocumentParser::append): (WebCore::HTMLDocumentParser::parseDocumentFragment):
  • html/HTMLDocumentParser.h:
  • html/LegacyHTMLDocumentParser.cpp: (WebCore::LegacyHTMLDocumentParser::insert): (WebCore::LegacyHTMLDocumentParser::append):
  • html/LegacyHTMLDocumentParser.h:
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::replaceDocument): (WebCore::DocumentWriter::addData):
  • loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryDocumentParser::FTPDirectoryDocumentParser): (WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate): (WebCore::FTPDirectoryDocumentParser::append):
  • loader/TextDocument.cpp: (WebCore::TextDocumentParser::insert): (WebCore::TextDocumentParser::append): (WebCore::TextDocumentParser::finish):
2:22 PM Changeset in webkit [61903] by crogers@google.com
  • 223 edits
    90 copies
    56 deletes in branches/audio/WebKitTools

merge WebKitTools changes from trunk into audio branch: revisions 58269:61708

2:18 PM Changeset in webkit [61902] by weinig@apple.com
  • 3 edits
    26 adds in trunk/WebKitTools

Make WebKitTestRunner really work with run-webkit-tests.

Reviewed by Anders Carlsson.

  • Add Forwarding headers to allow some cleanup.
  • WebKitTestRunner/ForwardingHeaders: Added.
  • WebKitTestRunner/ForwardingHeaders/wtf: Added.
  • WebKitTestRunner/ForwardingHeaders/wtf/ASCIICType.h: Added.
  • WebKitTestRunner/ForwardingHeaders/wtf/Assertions.h: Added.
  • WebKitTestRunner/ForwardingHeaders/wtf/Atomics.h: Added.
  • WebKitTestRunner/ForwardingHeaders/wtf/FastMalloc.h: Added.
  • WebKitTestRunner/ForwardingHeaders/wtf/HashMap.h: Added.
  • WebKitTestRunner/ForwardingHeaders/wtf/HashSet.h: Added.
  • WebKitTestRunner/ForwardingHeaders/wtf/HashTraits.h: Added.
  • WebKitTestRunner/ForwardingHeaders/wtf/Locker.h: Added.
  • WebKitTestRunner/ForwardingHeaders/wtf/MainThread.h: Added.
  • WebKitTestRunner/ForwardingHeaders/wtf/MathExtras.h: Added.
  • WebKitTestRunner/ForwardingHeaders/wtf/Noncopyable.h: Added.
  • WebKitTestRunner/ForwardingHeaders/wtf/OwnPtr.h: Added.
  • WebKitTestRunner/ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
  • WebKitTestRunner/ForwardingHeaders/wtf/PassOwnPtr.h: Added.
  • WebKitTestRunner/ForwardingHeaders/wtf/PassRefPtr.h: Added.
  • WebKitTestRunner/ForwardingHeaders/wtf/Platform.h: Added.
  • WebKitTestRunner/ForwardingHeaders/wtf/RefCounted.h: Added.
  • WebKitTestRunner/ForwardingHeaders/wtf/RefPtr.h: Added.
  • WebKitTestRunner/ForwardingHeaders/wtf/RetainPtr.h: Added.
  • WebKitTestRunner/ForwardingHeaders/wtf/StringExtras.h: Added.
  • WebKitTestRunner/ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
  • WebKitTestRunner/ForwardingHeaders/wtf/Threading.h: Added.
  • WebKitTestRunner/ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.
  • WebKitTestRunner/ForwardingHeaders/wtf/Vector.h: Added.
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::dump): Dump the right number of #EOFs.

  • WebKitTestRunner/TestInvocation.h:
2:08 PM Changeset in webkit [61901] by weinig@apple.com
  • 2 edits
    1 add in trunk/WebKitTools

Add support for WebKitTestRunner to old-run-webkit-tests

Reviewed by Mark Rowe.

  • Also adds a script to build WebKitTestRunner for old-run-webkit-tests to use.
  • Scripts/build-webkittestrunner: Added.
  • Scripts/old-run-webkit-tests:
1:40 PM Changeset in webkit [61900] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

Fix up test expectation for Chromium as one test is passing.

  • platform/chromium/test_expectations.txt:
1:37 PM Changeset in webkit [61899] by crogers@google.com
  • 89 edits
    43 copies
    11 deletes in branches/audio/WebKit2

merge WebKit2 changes from trunk into audio branch: revisions 58269:61708

1:36 PM Changeset in webkit [61898] by commit-queue@webkit.org
  • 8 edits in trunk

2010-06-25 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add new stubs for querying platform drag-and-drop and copy-and-paste data.

This change adds new stubs for querying for data in a clipboard or drag operation. This is
so adding support for more data types in clipboard/drag operations doesn't become
increasingly expensive, since we currently copy all the drag data we need every time a new
web drop target is entered. It also adds a new mechanism to write back to the system
clipboard that isn't tied to one data type.

​https://bugs.webkit.org/show_bug.cgi?id=40540

No new tests since we're just adding new ChromiumBridge APIs. When we switch to it, it will
be covered by the existing tests.

  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/PasteboardPrivate.h: (WebCore::PasteboardPrivate::):

2010-06-25 Daniel Cheng <​dcheng@chromium.org>

Reviewed by Darin Fisher.

[chromium] Add new stubs for querying platform drag-and-drop and copy-and-paste data.

This change adds new stubs for querying for data in a clipboard or drag operation. This is
so adding support for more data types in clipboard/drag operations doesn't become
increasingly expensive, since we currently copy all the drag data we need every time a new
web drop target is entered. It also adds a new mechanism to write back to the system
clipboard that isn't tied to one data type.

​https://bugs.webkit.org/show_bug.cgi?id=40540

  • public/WebClipboard.h: (WebKit::WebClipboard::): (WebKit::WebClipboard::isFormatAvailable): (WebKit::WebClipboard::readPlainText): (WebKit::WebClipboard::readHTML): (WebKit::WebClipboard::writePlainText): (WebKit::WebClipboard::writeHTML): (WebKit::WebClipboard::writeURL): (WebKit::WebClipboard::writeImage): (WebKit::WebClipboard::writeData): (WebKit::WebClipboard::readAvailableTypes): (WebKit::WebClipboard::readData): (WebKit::WebClipboard::readFilenames):
  • public/WebKitClient.h:
  • src/AssertMatchingEnums.cpp:
  • src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::clipboardWriteData): (WebCore::ChromiumBridge::clipboardReadAvailableTypes): (WebCore::ChromiumBridge::clipboardReadData): (WebCore::ChromiumBridge::clipboardReadFilenames):
1:35 PM Changeset in webkit [61897] by crogers@google.com
  • 381 edits
    77 copies
    6 deletes in branches/audio/WebKit

merge WebKit changes from trunk into audio branch: revisions 58269:61708

1:29 PM Changeset in webkit [61896] by crogers@google.com
  • 5 edits in branches/audio/JavaScriptGlue

merge JavaScriptGlue changes from trunk into audio branch: revisions 58269:61708

1:28 PM Changeset in webkit [61895] by crogers@google.com
  • 255 edits
    39 copies
    2 deletes in branches/audio/JavaScriptCore

merge JavaScriptCore changes from trunk into audio branch: revisions 58269:61708

1:25 PM Changeset in webkit [61894] by crogers@google.com
  • 1150 edits
    221 copies
    21 deletes in branches/audio/WebCore

merge remaining WebCore changes from trunk into audio branch: revisions 58269:61708

1:23 PM Changeset in webkit [61893] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-06-25 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Implement atk_table_get_column_header
​https://bugs.webkit.org/show_bug.cgi?id=30896

Replace g_timeout_add() with g_idle_add().

  • tests/testatk.c: (test_webkit_atk_get_text_at_offset_forms): (test_webkit_atk_get_text_at_offset): (test_webkit_atk_get_text_at_offset_newlines): (test_webkit_atk_get_text_at_offset_textarea): (test_webkit_atk_get_text_at_offset_text_input): (testWebkitAtkGetTextInParagraphAndBodySimple): (testWebkitAtkGetTextInParagraphAndBodyModerate): (testWebkitAtkGetTextInTable): (testWebkitAtkGetHeadersInTable):
1:21 PM Changeset in webkit [61892] by crogers@google.com
  • 258 edits
    69 copies
    31 deletes in branches/audio/WebCore/html

merge WebCore/html changes from trunk into audio branch: revisions 58269:61708

1:20 PM Changeset in webkit [61891] by crogers@google.com
  • 81 edits
    20 copies
    13 deletes in branches/audio/WebCore/dom

merge WebCore/dom changes from trunk into audio branch: revisions 58269:61708

1:19 PM Changeset in webkit [61890] by crogers@google.com
  • 50 edits
    2 copies in branches/audio/WebCore/css

merge WebCore/css changes from trunk into audio branch: revisions 58269:61708

1:19 PM Changeset in webkit [61889] by crogers@google.com
  • 48 edits
    1 copy in branches/audio/WebCore/bridge

merge WebCore/bridge changes from trunk into audio branch: revisions 58269:61708

1:18 PM Changeset in webkit [61888] by crogers@google.com
  • 185 edits
    104 copies
    82 deletes in branches/audio/WebCore/bindings

merge WebCore/bindings changes from trunk into audio branch: revisions 58269:61708

1:17 PM Changeset in webkit [61887] by crogers@google.com
  • 5 copies in branches/audio/WebCore/benchmarks

merge WebCore/benchmarks changes from trunk into audio branch: revisions 58269:61708

1:17 PM Changeset in webkit [61886] by crogers@google.com
  • 19 edits in branches/audio/WebCore/audio

merge WebCore/audio changes from trunk into audio branch: revisions 58269:61708

1:16 PM Changeset in webkit [61885] by crogers@google.com
  • 12 edits in branches/audio/WebCore/accessibility

merge WebCore/accessibility changes from trunk into audio branch: revisions 58269:61708

1:09 PM Changeset in webkit [61884] by commit-queue@webkit.org
  • 4 edits in trunk

2010-06-25 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Implement atk_table_get_column_header
​https://bugs.webkit.org/show_bug.cgi?id=30896

Implemented get_column_header and modified get_row_header
accordingly to keep them both coherent among themselves.
Based on a previous patch by Joanmarie Diggs.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_table_get_column_header): (webkit_accessible_table_get_row_header):

2010-06-25 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Xan Lopez.

[Gtk] Implement atk_table_get_column_header
​https://bugs.webkit.org/show_bug.cgi?id=30896

Added new test to check whether the implementation of
get_column_headers() and get_row_headers() works ok.

  • tests/testatk.c: (testWebkitAtkGetHeadersInTable): (main):
12:57 PM Changeset in webkit [61883] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-25 Adam Barth <​abarth@webkit.org>

Reviewed by David Levin.

Incremental build failed on Chromium ews
​https://bugs.webkit.org/show_bug.cgi?id=41011

The division of responsibility between update-webkit --chromium and
build-webkit --chromium is slightly unclear. In this patch, we make
build-webkit --chromium also update DEPS and re-run GYP in case the
developer has changed either since they updated.

This change is also helpful for the EWS, which wants to update DEPS and
re-run GYP after applying patches, but the EWS doesn't want to run
update-webkit --chromium because it has a dirty working copy.

  • Scripts/webkitdirs.pm:
12:57 PM Changeset in webkit [61882] by commit-queue@webkit.org
  • 3 edits
    9 adds in trunk

2010-06-25 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

Introduce to QtScript benchmarks.

The QtScript performance should be tested regularly. The patch introduces
micro benchmarks for existing API.

[Qt] Performance of the QtScript API is not tested.
​https://bugs.webkit.org/show_bug.cgi?id=40911

  • WebKit.pro:

2010-06-25 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

Introduce QtScript benchmarks.

The QtScript performance should be tested regularly. The patch introduces
micro benchmarks for existing API.

[Qt] Performance of the QtScript API is not tested.
​https://bugs.webkit.org/show_bug.cgi?id=40911

  • qt/benchmarks/benchmarks.pri: Copied from JavaScriptCore/qt/tests/tests.pri.
  • qt/benchmarks/benchmarks.pro: Added.
  • qt/benchmarks/qscriptengine/qscriptengine.pro: Added.
  • qt/benchmarks/qscriptengine/tst_qscriptengine.cpp: Added. (tst_QScriptEngine::checkSyntax_data): (tst_QScriptEngine::checkSyntax): (tst_QScriptEngine::constructor): (tst_QScriptEngine::evaluateString_data): (tst_QScriptEngine::evaluateString): (tst_QScriptEngine::evaluateProgram_data): (tst_QScriptEngine::evaluateProgram): (tst_QScriptEngine::newObject): (tst_QScriptEngine::nullValue): (tst_QScriptEngine::undefinedValue): (tst_QScriptEngine::globalObject): (tst_QScriptEngine::toStringHandle):
  • qt/benchmarks/qscriptvalue/qscriptvalue.pro: Added.
  • qt/benchmarks/qscriptvalue/tst_qscriptvalue.cpp: Added. (tst_QScriptValue::tst_QScriptValue): (tst_QScriptValue::~tst_QScriptValue): (tst_QScriptValue::values_data): (tst_QScriptValue::ctorBool): (tst_QScriptValue::ctorReal): (tst_QScriptValue::ctorNumber): (tst_QScriptValue::ctorQString): (tst_QScriptValue::ctorCString): (tst_QScriptValue::ctorSpecial): (tst_QScriptValue::ctorQScriptValue): (tst_QScriptValue::isValid_data): (tst_QScriptValue::isValid): (tst_QScriptValue::isBool_data): (tst_QScriptValue::isBool): (tst_QScriptValue::isNumber_data): (tst_QScriptValue::isNumber): (tst_QScriptValue::isFunction_data): (tst_QScriptValue::isFunction): (tst_QScriptValue::isNull_data): (tst_QScriptValue::isNull): (tst_QScriptValue::isString_data): (tst_QScriptValue::isString): (tst_QScriptValue::isUndefined_data): (tst_QScriptValue::isUndefined): (tst_QScriptValue::isObject_data): (tst_QScriptValue::isObject): (tst_QScriptValue::isError_data): (tst_QScriptValue::isError): (tst_QScriptValue::toString_data): (tst_QScriptValue::toString): (tst_QScriptValue::toNumber_data): (tst_QScriptValue::toNumber): (tst_QScriptValue::toBool_data): (tst_QScriptValue::toBool): (tst_QScriptValue::toInteger_data): (tst_QScriptValue::toInteger): (tst_QScriptValue::toInt32_data): (tst_QScriptValue::toInt32): (tst_QScriptValue::toUInt32_data): (tst_QScriptValue::toUInt32): (tst_QScriptValue::toUInt16_data): (tst_QScriptValue::toUInt16): (tst_QScriptValue::toObject_data): (tst_QScriptValue::toObject): (tst_QScriptValue::equals_data): (tst_QScriptValue::equals): (tst_QScriptValue::strictlyEquals_data): (tst_QScriptValue::strictlyEquals): (tst_QScriptValue::instanceOf_data): (tst_QScriptValue::instanceOf):
12:50 PM Changeset in webkit [61881] by Martin Robinson
  • 4 edits in trunk

2010-06-25 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Pasteboard code does not take into account the nil character when getting and setting markup/netscape-url data
​https://bugs.webkit.org/show_bug.cgi?id=41221

Take into account null-terminator when getting and setting markup and
Netscape URL pasteboard types. This means that if the selection data
contains the null terminator, it won't be included in the final String.
When setting the pasteboard data the null terminator is now included to
match the behavior of other applications.

  • platform/gtk/PasteboardHelper.cpp: (WebCore::PasteboardHelper::getClipboardContents): Create the markup string after using g_strndup to protect against non-null-terminated strings. Use String::fromUTF8 here to ensure that the string is not longer than the first null-terminator. Also fix a small indentation issue. (WebCore::PasteboardHelper::fillSelectionData): Always include the null-terminator when setting pasteboard data manually. This matches the behavior of other browser applications.

2010-06-25 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Pasteboard code does not take into account the nil character when getting and setting markup/netscape-url data
​https://bugs.webkit.org/show_bug.cgi?id=41221

Add a test for this issue which simulates a paste keyboard event into an editable
body. The pasteboard should contain a markup portion containing a null terminator.

  • tests/testcopyandpaste.c: (test_info_new): (test_info_destroy): (load_status_cb): (runPasteTestCallback): (window_object_cleared_callback): (pasting_test_get_data_callback): (pasting_test_clear_data_callback): (test_pasting_markup): (main):
12:31 PM Changeset in webkit [61880] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-06-25 Sam Magnuson <​smagnuson@netflix.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] When any geometry change happens to a node it will resize the
backing cache
​https://bugs.webkit.org/show_bug.cgi?id=40378

Continue to grow the cache, but never toss it. When the pixmap
cache gets too big it will be lost and created at the right size
next time.

No new tests: this is an optimization.

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::recache): (WebCore::GraphicsLayerQtImpl::paint): (WebCore::GraphicsLayerQtImpl::flushChanges):
12:29 PM Changeset in webkit [61879] by robert@webkit.org
  • 9 edits in trunk

2010-06-25 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Support evaluateScriptInIsolatedWorld()

​https://bugs.webkit.org/show_bug.cgi?id=40079

Remove evaluateScriptInIsolatedWorld() from QtWebKit API.
Remove QWebScriptWorld from exported headers.
Confine support to DumpRenderTreeSupportQt so that the tests can pass.

  • Api/headers.pri:
  • Api/qwebframe.cpp:
  • Api/qwebframe.h:
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::clearScriptWorlds): (DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld):
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

2010-06-25 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Support evaluateScriptInIsolatedWorld()

​https://bugs.webkit.org/show_bug.cgi?id=40079

Remove evaluateScriptInIsolatedWorld() from QtWebKit API.
Remove QWebScriptWorld from exported headers.
Confine support to DumpRenderTreeSupportQt so that the tests can pass.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::reset): (LayoutTestController::evaluateScriptInIsolatedWorld):
  • DumpRenderTree/qt/LayoutTestControllerQt.h:
12:17 PM Changeset in webkit [61878] by oliver@apple.com
  • 15 edits
    1 delete in trunk/JavaScriptCore

2010-06-25 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Remove old js parser
​https://bugs.webkit.org/show_bug.cgi?id=41222

Remove the old yacc parser, this also solves the tiger problem. Which
was a conflict between yacc generated token values and those in the
custom parser

  • Android.mk:
  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pro:
  • GNUmakefile.am:
  • JavaScriptCore.pro:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • parser/Grammar.y: Removed.
  • parser/JSParser.cpp:
  • parser/JSParser.h:
  • parser/Lexer.cpp:
  • parser/NodeConstructors.h: (JSC::Node::Node):
  • parser/Parser.cpp: (JSC::Parser::parse):
  • wtf/Platform.h:
12:15 PM Changeset in webkit [61877] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-06-25 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=41019
Canvas: Remember verified clean origins for drawImage()

Made CanvasRenderingContext2D cache the KURLs of clean origins
for fast repeated lookup.

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::checkOrigin):
  • html/canvas/CanvasRenderingContext2D.h:
11:25 AM Changeset in webkit [61876] by weinig@apple.com
  • 4 edits in trunk/WebKit2

WKBundlePageRenderTreeExternalRepresentation really needs to be
WKBundlePageCopyRenderTreeExternalRepresentation so we don't have dangling
pointers and adhere to naming conventions.

Reviewed by Anders Carlsson.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageCopyRenderTreeExternalRepresentation):

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
  • mac/WebKit2.exp:
11:10 AM Changeset in webkit [61875] by robert@webkit.org
  • 4 edits in trunk

2010-06-25 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] HTTP 307 after a 303 after a POST re-sends POST data from the original request

​https://bugs.webkit.org/show_bug.cgi?id=35301

Qt needs to use ResourceRequest::request()->httpMethod()) in order to determine
the appropriate method for a 307 redirect request.

When deciding if it needs to override a POST method with a GET method during a
redirect chain, QNetworkReplyHandler needs to check the HTTP method stored
in ResourceRequest::request()->httpMethod(). This will always contain the
original request method in a redirect chain and, more importantly, is the
method that will be used for the request created from the redirect
if it is not overridden.

Unskip http/tests/loading/307-after-303-after-post.html

  • platform/qt/Skipped:

2010-06-25 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] HTTP 307 after a 303 after a POST re-sends POST data from the original request

​https://bugs.webkit.org/show_bug.cgi?id=35301

Qt needs to use ResourceRequest::request()->httpMethod()) in order to determine
the appropriate method for a 307 redirect request.

When deciding if it needs to override a POST method with a GET method during a
redirect chain, QNetworkReplyHandler needs to check the HTTP method stored
in ResourceRequest::request()->httpMethod(). This will always contain the
original request method in a redirect chain and, more importantly, is the
method that will be used for the request created from the redirect
if it is not overridden.

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
11:08 AM Changeset in webkit [61874] by mitz@apple.com
  • 1 edit in trunk/WebKitTools/ChangeLog

Corrected change log entry

11:07 AM Changeset in webkit [61873] by andersca@apple.com
  • 3 edits in trunk/WebKitTools

Revert accidental part and add a newline.

  • MiniBrowser/mac/AppDelegate.m:
  • MiniBrowser/mac/MiniBrowser_Prefix.pch:
11:07 AM Changeset in webkit [61872] by mitz@apple.com
  • 3 edits in trunk/WebCore

Removed a one-line method that only had one internal caller.

Reviewed by Anders Carlsson.

  • rendering/RenderBlock.h: Removed bidiReorderLine()
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren): Moved the implementation of
bidiReorderLine() inline here.

11:06 AM Changeset in webkit [61871] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Build fix.

Fixed test expectations for Chromium.

  • platform/chromium/test_expectations.txt:
11:03 AM Changeset in webkit [61870] by andersca@apple.com
  • 6 edits in trunk/WebKitTools

Add a LOG macro that expands to a no-op by default.

Reviewed by Dan Bernstein.

  • MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
  • MiniBrowser/mac/AppDelegate.m:

(_didRecieveMessageFromInjectedBundle):

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController windowShouldClose:]):
(_didStartProvisionalLoadForFrame):
(_didReceiveServerRedirectForProvisionalLoadForFrame):
(_didFailProvisionalLoadWithErrorForFrame):
(_didCommitLoadForFrame):
(_didFinishLoadForFrame):
(_didFailLoadWithErrorForFrame):
(_didReceiveTitleForFrame):
(_didFirstLayoutForFrame):
(_didFirstVisuallyNonEmptyLayoutForFrame):
(_didBecomeUnresponsive):
(_didBecomeResponsive):
(_decidePolicyForNavigationAction):
(_decidePolicyForNewWindowAction):
(_createNewPage):
(_showPage):
(_closePage):
(_didNavigateWithNavigationData):
(_didPerformClientRedirect):
(_didPerformServerRedirect):
(_didUpdateHistoryTitle):

  • MiniBrowser/mac/MiniBrowser_Prefix.pch:
  • MiniBrowser/mac/WebBundle/WebBundleMain.m:

(_didClearWindowForFrame):
(_didCreatePage):
(_willDestroyPage):
(_didRecieveMessage):

10:32 AM Changeset in webkit [61869] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Build fix.

Fixed test expectations for Chromium.

  • platform/chromium/test_expectations.txt:
10:17 AM Changeset in webkit [61868] by Nate Chapin
  • 30 edits in trunk/WebCore

2010-06-25 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Take a KURL parameter in Document's constructor.
This will remove the one case where Document::url()
and FrameLoader::url() are not equal, allowing us to
remove FrameLoader::url().

​https://bugs.webkit.org/show_bug.cgi?id=41166

Refactor only, no new tests.

  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): Take a KURL and pass it through to Document. (WebCore::DOMImplementation::createHTMLDocument):
  • dom/DOMImplementation.h:
  • dom/Document.cpp: (WebCore::Document::Document): Call setURL() if a frame or a non-empty KURL is specified. (WebCore::Document::initSecurityContext): m_url is now initialized, so use it instead

of m_frame->loader()->url() for initializing the SecurityOrigin.

  • dom/Document.h: (WebCore::Document::create): (WebCore::Document::createXHTML):
  • html/HTMLDocument.cpp:
  • html/HTMLDocument.h: Add KURL parameter to create() and constructor.
  • html/HTMLViewSourceDocument.cpp:
  • html/HTMLViewSourceDocument.h: Add KURL parameter to create() and constructor.
  • loader/CachedFont.cpp: (WebCore::CachedFont::ensureSVGFontData):
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::createDocument): Take a KURL and pass it through to Document. (WebCore::DocumentWriter::begin): Pass existing url parameter to constructors, and remove

redundant Document::setURL() call.

  • loader/DocumentWriter.h:
  • loader/FTPDirectoryDocument.cpp:
  • loader/FTPDirectoryDocument.h: Add KURL parameter to create() and constructor.
  • loader/ImageDocument.cpp:
  • loader/ImageDocument.h: Add KURL parameter to create() and constructor.
  • loader/MediaDocument.cpp:
  • loader/MediaDocument.h: Add KURL parameter to create() and constructor.
  • loader/PlaceholderDocument.h: Add KURL parameter to create() and constructor.
  • loader/PluginDocument.cpp:
  • loader/PluginDocument.h: Add KURL parameter to create() and constructor.
  • loader/SinkDocument.cpp:
  • loader/SinkDocument.h: Add KURL parameter to create() and constructor.
  • loader/TextDocument.cpp:
  • loader/TextDocument.h: Add KURL parameter to create() and constructor.
  • svg/SVGDocument.cpp:
  • svg/SVGDocument.h: Add KURL parameter to create() and constructor.
  • xml/DOMParser.cpp: (WebCore::DOMParser::parseFromString):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseXML):
  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource):
9:20 AM Changeset in webkit [61867] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit

2010-06-25 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Stop frame loaders when deleting view.
Frame loaders were still alive after view is deleted, causing
segmentation fault when libsoup had something to deliver yet.
​https://bugs.webkit.org/show_bug.cgi?id=41007

  • efl/ewk/ewk_view.cpp: (_ewk_view_smart_del): stop loaders.
9:12 AM Changeset in webkit [61866] by mnaganov@chromium.org
  • 14 edits in trunk

2010-06-25 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r61812.
​http://trac.webkit.org/changeset/61812
​https://bugs.webkit.org/show_bug.cgi?id=41216

breaks Chromium workers tests (Requested by mnaganov on
#webkit).

  • fast/workers/storage/open-database-sync-inputs-expected.txt:
  • fast/workers/storage/resources/open-database-sync-inputs.js:

2010-06-25 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r61812.
​http://trac.webkit.org/changeset/61812
​https://bugs.webkit.org/show_bug.cgi?id=41216

breaks Chromium workers tests (Requested by mnaganov on
#webkit).

  • storage/AbstractDatabase.cpp:
  • storage/AbstractDatabase.h:
  • storage/Database.cpp: (WebCore::Database::databaseInfoTableName): (WebCore::guidMutex): (WebCore::guidToVersionMap): (WebCore::updateGuidVersionMap): (WebCore::guidToDatabaseMap): (WebCore::databaseVersionKey): (WebCore::DatabaseCreationCallbackTask::create): (WebCore::DatabaseCreationCallbackTask::performTask): (WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask): (WebCore::Database::openDatabase): (WebCore::Database::Database): (WebCore::Database::openAndVerifyVersion): (WebCore::retrieveTextResultFromDatabase): (WebCore::Database::getVersionFromDatabase): (WebCore::setTextValueInDatabase): (WebCore::Database::setVersionInDatabase): (WebCore::Database::versionMatchesExpected): (WebCore::Database::close): (WebCore::Database::disableAuthorizer): (WebCore::Database::enableAuthorizer): (WebCore::Database::setAuthorizerReadOnly): (WebCore::Database::lastActionChangedDatabase): (WebCore::Database::lastActionWasInsert): (WebCore::Database::resetDeletes): (WebCore::Database::hadDeletes): (WebCore::guidForOriginAndName): (WebCore::Database::resetAuthorizer): (WebCore::Database::performOpenAndVerify): (WebCore::Database::performCreationCallback): (WebCore::Database::version): (WebCore::Database::setExpectedVersion): (WebCore::Database::stringIdentifier): (WebCore::Database::displayName): (WebCore::Database::estimatedSize): (WebCore::Database::fileName):
  • storage/Database.h: (WebCore::Database::scriptExecutionContext): (WebCore::Database::opened): (WebCore::Database::isNew): (WebCore::Database::databaseDebugName):
  • storage/DatabaseAuthorizer.cpp: (WebCore::DatabaseAuthorizer::DatabaseAuthorizer): (WebCore::DatabaseAuthorizer::denyBasedOnTableName):
  • storage/DatabaseAuthorizer.h: (WebCore::DatabaseAuthorizer::create):
  • storage/DatabaseSync.cpp: (WebCore::DatabaseSync::databaseInfoTableName): (WebCore::DatabaseSync::openDatabaseSync): (WebCore::DatabaseSync::DatabaseSync): (WebCore::DatabaseSync::~DatabaseSync): (WebCore::DatabaseSync::version): (WebCore::DatabaseSync::changeVersion): (WebCore::DatabaseSync::transaction): (WebCore::DatabaseSync::scriptExecutionContext):
  • storage/DatabaseSync.h: (WebCore::DatabaseSync::databaseDebugName):
  • storage/DatabaseTask.cpp: (WebCore::DatabaseOpenTask::DatabaseOpenTask): (WebCore::DatabaseOpenTask::doPerformTask):
  • storage/DatabaseTask.h: (WebCore::DatabaseOpenTask::create):
8:45 AM Changeset in webkit [61865] by commit-queue@webkit.org
  • 5 edits in trunk

2010-06-25 Lei Zheng <​lzheng@chromium.org>

Reviewed by Dimitri Glazkov.

Add a flag to the ResourceResponse for tracking if a request was fetched when
Alternate-protocol is available.
​https://bugs.webkit.org/show_bug.cgi?id=41001

No new tests. (This is just a setter and getter.)

  • platform/network/chromium/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::wasAlternateProtocolAvailable): (WebCore::ResourceResponse::setWasAlternateProtocolAvailable):

2010-06-25 Lei Zheng <​lzheng@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Add a flag to the ResourceResponse for tracking if a request was fetched
when Alternate-Protocol is available.

​https://bugs.webkit.org/show_bug.cgi?id=41001

  • public/WebURLResponse.h:
  • src/WebURLResponse.cpp: (WebKit::WebURLResponse::wasAlternateProtocolAvailable): (WebKit::WebURLResponse::setWasAlternateProtocolAvailable):
8:29 AM Changeset in webkit [61864] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-06-25 Lyon Chen <​liachen@rim.com>

Reviewed by Darin Adler.

InspectorCSSStore.cpp is not surrounded with ENABLE(INSPECTOR)
​https://bugs.webkit.org/show_bug.cgi?id=41004

Surround InspectorCSSStore.cpp code with ENABLE(INSPECTOR) so it will not
break the build when INSPECTOR is disabled.

  • inspector/InspectorCSSStore.cpp:
8:00 AM Changeset in webkit [61863] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-06-25 No'am Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Simon Hausmann.

[Qt] WebGL: missing file
​https://bugs.webkit.org/show_bug.cgi?id=40998

Added a missing file to WebCore.pro

No new tests; build fix

  • WebCore.pro:
7:16 AM Changeset in webkit [61862] by Adam Roben
  • 2 edits in trunk/WebCore

Windows build fix

  • WebCore.vcproj/WebCore.vcproj: Added a missing </File> tag.
6:55 AM Changeset in webkit [61861] by commit-queue@webkit.org
  • 53 edits
    4 adds in trunk

2010-06-25 Alex Milowski <​alex@milowski.com>

Reviewed by Kenneth Rohde Christiansen.

Added a test for row alignment, adjusted tests to better demonstrate their
respective area of MathML, and updated the output for all the tests due to
the change in vertical alignment of all MathML constructs.

  • mathml/presentation/mo.xhtml:
  • mathml/presentation/row-alignment.xhtml: Added.
  • mathml/presentation/row.xhtml:
  • mathml/presentation/sub.xhtml:
  • platform/mac/mathml/presentation/fractions-expected.checksum:
  • platform/mac/mathml/presentation/fractions-expected.png:
  • platform/mac/mathml/presentation/fractions-expected.txt:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
  • platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
  • platform/mac/mathml/presentation/mo-expected.checksum:
  • platform/mac/mathml/presentation/mo-expected.png:
  • platform/mac/mathml/presentation/mo-expected.txt:
  • platform/mac/mathml/presentation/over-expected.checksum:
  • platform/mac/mathml/presentation/over-expected.png:
  • platform/mac/mathml/presentation/over-expected.txt:
  • platform/mac/mathml/presentation/roots-expected.checksum:
  • platform/mac/mathml/presentation/roots-expected.png:
  • platform/mac/mathml/presentation/roots-expected.txt:
  • platform/mac/mathml/presentation/row-alignment-expected.checksum: Added.
  • platform/mac/mathml/presentation/row-alignment-expected.png: Added.
  • platform/mac/mathml/presentation/row-alignment-expected.txt: Added.
  • platform/mac/mathml/presentation/row-expected.checksum:
  • platform/mac/mathml/presentation/row-expected.png:
  • platform/mac/mathml/presentation/row-expected.txt:
  • platform/mac/mathml/presentation/sub-expected.checksum:
  • platform/mac/mathml/presentation/sub-expected.png:
  • platform/mac/mathml/presentation/sub-expected.txt:
  • platform/mac/mathml/presentation/subsup-expected.checksum:
  • platform/mac/mathml/presentation/subsup-expected.png:
  • platform/mac/mathml/presentation/subsup-expected.txt:
  • platform/mac/mathml/presentation/sup-expected.checksum:
  • platform/mac/mathml/presentation/sup-expected.png:
  • platform/mac/mathml/presentation/sup-expected.txt:
  • platform/mac/mathml/presentation/tables-expected.checksum:
  • platform/mac/mathml/presentation/tables-expected.png:
  • platform/mac/mathml/presentation/tables-expected.txt:
  • platform/mac/mathml/presentation/under-expected.checksum:
  • platform/mac/mathml/presentation/under-expected.png:
  • platform/mac/mathml/presentation/under-expected.txt:
  • platform/mac/mathml/presentation/underover-expected.checksum:
  • platform/mac/mathml/presentation/underover-expected.png:
  • platform/mac/mathml/presentation/underover-expected.txt:

2010-06-25 Alex Milowski <​alex@milowski.com>

Reviewed by Kenneth Rohde Christiansen.

This patch changes the vertical alignment to rely upon baseline
alignment for all MathML rendering. This fixes a number of layout
issues and the implementation is much more clean.

Also, this patch adds a horizontal green line in the debug layout
so you can see the top padding of any RenderMathMLBlock instance.

Test: mathml/presentation/row-alignment.xhtml

  • css/mathml.css:
  • mathml/RenderMathMLBlock.cpp:
  • mathml/RenderMathMLFraction.cpp:
  • mathml/RenderMathMLFraction.h:
  • mathml/RenderMathMLOperator.cpp:
  • mathml/RenderMathMLOperator.h:
  • mathml/RenderMathMLRoot.cpp:
  • mathml/RenderMathMLRow.cpp:
  • mathml/RenderMathMLRow.h:
  • mathml/RenderMathMLSquareRoot.cpp:
  • mathml/RenderMathMLSubSup.cpp:
  • mathml/RenderMathMLUnderOver.cpp:
6:39 AM Changeset in webkit [61860] by commit-queue@webkit.org
  • 6 edits in trunk/JavaScriptCore

2010-06-25 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

New QtScript API; setPrototype() and prototype().

This patch implements QScriptValue's prototype accessors.

[Qt] QScriptValue should have accessors to a prototype.
​https://bugs.webkit.org/show_bug.cgi?id=39356

  • qt/api/qscriptvalue.cpp: (QScriptValue::prototype): (QScriptValue::setPrototype):
  • qt/api/qscriptvalue.h:
  • qt/api/qscriptvalue_p.h: (QScriptValuePrivate::prototype): (QScriptValuePrivate::setPrototype):
  • qt/tests/qscriptvalue/tst_qscriptvalue.cpp: (tst_QScriptValue::getSetPrototype):
  • qt/tests/qscriptvalue/tst_qscriptvalue.h:
6:32 AM Changeset in webkit [61859] by yurys@chromium.org
  • 5 edits
    2 adds in trunk

2010-06-25 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Can't see source when hitting debugger statement in evaled source
​https://bugs.webkit.org/show_bug.cgi?id=41058

Test: inspector/debugger-pause-in-eval-script.html

  • bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::sourceParsed): use lexical global object to figure out where the script is compiled. Otherwise scripts typed in Web Inspector console will be treated as ones evaluated in the context of Web Inspector and won't appear in the scripts list.
  • inspector/InspectorController.cpp: (WebCore::InspectorController::didParseSource): cache script sources for eval's too.

2010-06-25 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Can't see source when hitting debugger statement in evaled source
​https://bugs.webkit.org/show_bug.cgi?id=41058

Test that debugger will stop at a debugger statement in code evaluated
in Web Inspector console.

  • inspector/debugger-pause-in-eval-script-expected.txt: Added.
  • inspector/debugger-pause-in-eval-script.html: Added.
6:25 AM Changeset in webkit [61858] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit

2010-06-25 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Fix warnings about printf format
When printing uint64_t the macro PRIu64 is needed in order to be
portable across 32 and 64 bits. It was previously showing warning
messages on 32-bits systems.
​https://bugs.webkit.org/show_bug.cgi?id=40965

  • efl/ewk/ewk_view.cpp: (ewk_view_exceeded_database_quota):
6:13 AM Changeset in webkit [61857] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit

2010-06-25 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Do not load error message for download and cancellation.
When a download is made or a request is cancelled an error page should
not be shown.
​https://bugs.webkit.org/show_bug.cgi?id=40956

  • efl/WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::dispatchDidFailLoading): return if it should not fallback. (WebCore::FrameLoaderClientEfl::dispatchDidFailLoad): return if it should not fallback. (WebCore::FrameLoaderClientEfl::interruptForPolicyChangeError): fix typo in related error message. (WebCore::FrameLoaderClientEfl::shouldFallBack): if user cancelled the request or the policy changed (for example, because the request is a download) then it should not fallback.
5:59 AM Changeset in webkit [61856] by commit-queue@webkit.org
  • 4 edits in trunk/WebKit/chromium

2010-06-25 Michael Nordman <Michael Nordman>

Reviewed by Dumitru Daniliuc.

Additional API to pass additional info needed for AppCache progress events.
​https://bugs.webkit.org/show_bug.cgi?id=37602

Also, delete an obsolete method from the worker API.

  • public/WebApplicationCacheHostClient.h: define a new method
  • public/WebSharedWorker.h: remove an obsolte method
  • src/ApplicationCacheHostInternal.h: implement the new method (WebCore::ApplicationCacheHostInternal::notifyProgressEventListener):
5:48 AM Changeset in webkit [61855] by mnaganov@chromium.org
  • 3 edits in trunk/LayoutTests

2010-06-25 Mikhail Naganov <​mnaganov@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium-linux/svg/text/text-intro-05-t-expected.checksum:
  • platform/chromium-linux/svg/text/text-intro-05-t-expected.png:
5:41 AM Changeset in webkit [61854] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-06-25 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Use a descriptive string in FileChooser when multiple files can
be selected.
​https://bugs.webkit.org/show_bug.cgi?id=40943

EFL port has no tests yet, so no new tests.

  • platform/efl/FileChooserEfl.cpp: (WebCore::FileChooser::basenameForWidth):
5:28 AM Changeset in webkit [61853] by commit-queue@webkit.org
  • 5 edits in trunk

2010-06-25 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[CMake] Add option to enable JIT.
JIT is disabled by default, but now it's possible to enable it through
an option to CMake: -DENABLE_JIT will enable it.
​https://bugs.webkit.org/show_bug.cgi?id=40936

  • cmake/OptionsEfl.cmake: add new -DENABLE_JIT option.
  • cmakeconfig.h.cmake: use new -DENABLE_JIT option.

2010-06-25 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[CMake] Add option to enable JIT.
JIT is disabled by default, but now it's possible to enable it through
an option to CMake: -DENABLE_JIT will enable it.
​https://bugs.webkit.org/show_bug.cgi?id=40936

  • CMakeLists.txt: Add missing files and re-sort.
5:13 AM Changeset in webkit [61852] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-25 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Reviewed by Gustavo Noronha Silva.

[CMake] Remove unused variable in EFL build system. It was previously
being used to set the flags of each port but it was superseded by
other flags.
​https://bugs.webkit.org/show_bug.cgi?id=40931

  • jsc/CMakeLists.txt:
4:58 AM Changeset in webkit [61851] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-25 Nathan Lawrence <​nlawrence@apple.com>

Reviewed by Geoffrey Garen.

Aligning AssemblerBuffer to 128 bytes gives a 0.4% speedup on
sunspider.

  • assembler/AssemblerBuffer.h: (JSC::AssemblerBuffer::AssemblerBuffer):
4:54 AM Changeset in webkit [61850] by Nikolas Zimmermann
  • 10 edits in trunk/WebCore

2010-06-25 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

SVG Text Highlighting not yet supported (in Safari)
​https://bugs.webkit.org/show_bug.cgi?id=41200

Add text match marker highlighting support for SVG text - searching for SVG text in Safari now paints the nice yellow highlighting rect, and the
white rectangles for all text matches. Behaves exactly like HTML text, but respecting SVGs per-character/per-chunk transformations,
allowing to highlight textPaths, tspans with absolute per-character positions etc..

Only manually testable, thus no new tests.

  • rendering/InlineBox.h: Expose calculateBoundaries() in non-SVG builds as well, now used by InlineTextBox too.
  • rendering/InlineTextBox.h: Add calculateBoundaries(), which will be used to refactor some code in RenderText, see below. (WebCore::InlineTextBox::calculateBoundaries): Just return a IntRect(x(), y(), width(), height()) here. (WebCore::RenderObject::isSVGInlineText):
  • rendering/RenderSVGInlineText.h: (WebCore::RenderSVGInlineText::isSVGInlineText): Return true for isSVGInlineText(), return false for isSVGText() (default in RenderObject.h)
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::paint): Only paint box decorations in PaintPhase(Child)BlockBackground, exit afterwards just like RenderBlock does.

Otherwise the white text match marker rectangle gets drawn over the yellow highlight that Safari draws.

  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::paint): Accept a new painting phase: PaintPhaseSelection, used by Safari when drawing the yellow highlight rect.
  • rendering/RenderText.cpp: (WebCore::RenderText::absoluteQuads): Use calculateBoundaries() instead of IntRect(x(), y(), width(), height()). SVG provides different boundaries here. (WebCore::RenderText::absoluteQuadsForRange): Ditto. This is the main change, leading to correct text highlight placement.
  • rendering/SVGInlineFlowBox.cpp: Add assertion that painting is not disabled, for consistency. Change paint phase assertion to include PaintPhaseSelection. (WebCore::SVGInlineFlowBox::paint):
  • rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::selectionRectForTextChunkPart): Refactored from selectionRect(), to share code between selectionRect/computeTextMatchMarkerRect. (WebCore::SVGInlineTextBox::selectionRect): Use new helper function selectionRectForTextChunkPart(). (WebCore::SVGInlineTextBox::paint): Ditto. Call new computeTextMatchMarkerRect() function. (WebCore::SVGInlineTextBox::computeTextMatchMarkerRect): Implemented similar to HTML, but respecting SVGs concept of text chunk parts. (WebCore::SVGInlineTextBox::paintText): In PaintPhaseSelection, only paint selected text, not anything before/after the selection start/end. (WebCore::SVGInlineTextBox::calculateBoundaries): Early exit, if m_chunkTransformation is identity.
  • rendering/SVGInlineTextBox.h: Added "bool paintSelectedTextOnly" to paintText() and add new computeTextMatchMarkerRect(RenderStyle*) function.
  • rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::paint): Change paint phase assertion to include PaintPhaseSelection.
4:43 AM Changeset in webkit [61849] by commit-queue@webkit.org
  • 5 edits in trunk

2010-06-25 John Gregg <​johnnyg@google.com>

Reviewed by Darin Fisher.

Notification should expose ltr/rtl as TextDirection, not String
​https://bugs.webkit.org/show_bug.cgi?id=40871

No new tests; existing test covers this, just renaming a method.

  • notifications/Notification.h: (WebCore::Notification::direction):

2010-06-25 John Gregg <​johnnyg@google.com>

Reviewed by Darin Fisher.

Notification should expose ltr/rtl as TextDirection, not String
​https://bugs.webkit.org/show_bug.cgi?id=40871

  • public/WebNotification.h:
  • src/WebNotification.cpp: (WebKit::WebNotification::direction):
4:40 AM QtWebKitJournal edited by Simon Hausmann
(diff)
4:28 AM Changeset in webkit [61848] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit

2010-06-25 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Implement runOpenPanel method. The interface with browser was
already implemented. Now we are actually calling it.
​https://bugs.webkit.org/show_bug.cgi?id=40923

  • efl/WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::runOpenPanel): implement method.
  • efl/ewk/ewk_private.h: export to WebCoreSupport the needed method
4:07 AM Changeset in webkit [61847] by commit-queue@webkit.org
  • 5 edits
    3 deletes in trunk

2010-06-25 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r61842.
​http://trac.webkit.org/changeset/61842
​https://bugs.webkit.org/show_bug.cgi?id=41208

It broke Windows build (Requested by Ossy_ on #webkit).

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • wtf/OwnPtrCommon.h:
  • wtf/brew/OwnPtrBrew.h: Removed.
  • wtf/win/OwnPtrWin.h: Removed.

2010-06-25 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r61842.
​http://trac.webkit.org/changeset/61842
​https://bugs.webkit.org/show_bug.cgi?id=41208

It broke Windows build (Requested by Ossy_ on #webkit).

  • ForwardingHeaders/wtf/win/OwnPtrWin.h: Removed.
3:54 AM Changeset in webkit [61846] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-06-25 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Darin Adler.

Remove unneeded whitespace from svgtags.in.
​https://bugs.webkit.org/show_bug.cgi?id=40912

make_names.pl throws an error at non-empty lines
when using cl.exe as preprocessor.

  • svg/svgtags.in:
3:16 AM Changeset in webkit [61845] by commit-queue@webkit.org
  • 5 edits in trunk/JavaScriptCore

2010-06-25 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r61833.
​http://trac.webkit.org/changeset/61833
​https://bugs.webkit.org/show_bug.cgi?id=41205

It broke Leopard and GTK (Requested by Ossy_ on #webkit).

  • runtime/RegExp.cpp: (JSC::RegExp::RegExp): (JSC::RegExp::create):
  • runtime/RegExp.h:
  • runtime/RegExpCache.cpp: (JSC::RegExpCache::lookupOrCreate): (JSC::RegExpCache::create):
  • runtime/RegExpCache.h:
3:03 AM Changeset in webkit [61844] by Nikolas Zimmermann
  • 6 edits in trunk/WebCore

2010-06-25 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Rob Buis.

Split up isSVGText() in isSVGText() / isSVGInlineText()
​https://bugs.webkit.org/show_bug.cgi?id=41204

Introduce isSVGInlineText(), to provide a safe mechanism to differentiate between RenderSVGText / RenderSVGInlineText.
No change in functionality, thus no new tests.

  • rendering/RenderBlockLineLayout.cpp: (WebCore::shouldPreserveNewline): s/isSVGText/isSVGInlineText/ (WebCore::RenderBlock::findNextLineBreak): Ditto.
  • rendering/RenderObject.h: (WebCore::RenderObject::isSVGInlineText): Return false, by default.
  • rendering/RenderSVGInlineText.h: (WebCore::RenderSVGInlineText::isSVGInlineText): Return true here, don't return true anymore for isSVGText().
  • rendering/RenderText.cpp: (WebCore::RenderText::setTextInternal): s/isSVGText/isSVGInlineText/
  • rendering/RenderTreeAsText.cpp: Remove hack, now that we can properly differentiate between RenderSVGText / RenderSVGInlineText. (WebCore::write):
3:00 AM Changeset in webkit [61843] by rwlbuis@webkit.org
  • 2 edits
    1 move in trunk/LayoutTests

2010-06-25 Rob Buis <​rwlbuis@gmail.com>

Reviewed by Nikolas Zimmermann.

Remove rgb part of test and update expected result.

  • platform/mac/svg/css/rect-system-color-expected.txt: Removed.
  • svg/css/rect-system-color-expected.txt: Added.
  • svg/css/rect-system-color.xhtml:
2:48 AM Changeset in webkit [61842] by commit-queue@webkit.org
  • 5 edits
    2 copies
    2 adds in trunk

2010-06-25 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Adam Barth.

Change OwnPtrCommon to include platform-specific headers
​https://bugs.webkit.org/show_bug.cgi?id=40279

Adding new type to OwnPtrCommon needlessly causes all ports to do full rebuilds.
Change OwnPtrCommon to include platform-specific headers to avoid all ports rebuilds.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • wtf/OwnPtrCommon.h:
  • wtf/brew/OwnPtrBrew.h: Added.
  • wtf/win/OwnPtrWin.h: Added.

2010-06-25 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Adam Barth.

Change OwnPtrCommon to include platform-specific headers
​https://bugs.webkit.org/show_bug.cgi?id=40279

Adding new type to OwnPtrCommon needlessly causes all ports to do full rebuilds.
Change OwnPtrCommon to include platform-specific headers to avoid all ports rebuilds.

  • ForwardingHeaders/wtf/win: Added.
  • ForwardingHeaders/wtf/win/OwnPtrWin.h: Added.
2:24 AM Changeset in webkit [61841] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk/po

2010-06-25 Fran Diéguez <​fran.dieguez@mabishu.com>

Reviewed by Darin Adler.

Add Galician translation to webkitgtk
​https://bugs.webkit.org/show_bug.cgi?id=39547

  • gl.po: Added.
1:32 AM Changeset in webkit [61840] by rwlbuis@webkit.org
  • 1 edit
    1 move in trunk/LayoutTests

2010-06-25 Rob Buis <​rwlbuis@gmail.com>

Reviewed by Nikolas Zimmermann.

Make test result mac specific.

  • platform/mac/svg/css/rect-system-color-expected.txt: Renamed from LayoutTests/svg/css/rect-system-color-expected.txt.
1:30 AM Changeset in webkit [61839] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk/WebCore

2010-06-25 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Adam Barth.

Implement TextCodecs for WinCE port.
​https://bugs.webkit.org/show_bug.cgi?id=32169
Originally written by Yong Li <​yong.li@torchmobile.com>

  • platform/graphics/FontCache.h:
  • platform/graphics/wince/FontCacheWince.cpp: (WebCore::FontCache::getMultiLanguageInterface):
  • platform/text/wince/TextCodecWinCE.cpp: Added. (WebCore::codePageCharsets): (WebCore::knownCharsets): (WebCore::supportedCharsets): (WebCore::languageManager): (WebCore::addCharset): (WebCore::LanguageManager::LanguageManager): (WebCore::getCodePage): (WebCore::newTextCodecWinCE): (WebCore::TextCodecWinCE::TextCodecWinCE): (WebCore::TextCodecWinCE::~TextCodecWinCE): (WebCore::TextCodecWinCE::registerBaseEncodingNames): (WebCore::TextCodecWinCE::registerBaseCodecs): (WebCore::TextCodecWinCE::registerExtendedEncodingNames): (WebCore::TextCodecWinCE::registerExtendedCodecs): (WebCore::getCodePageFlags): (WebCore::findFirstNonAsciiCharacter): (WebCore::decode): (WebCore::TextCodecWinCE::decode): (WebCore::TextCodecWinCE::encode): (WebCore::TextCodecWinCE::enumerateSupportedEncodings):
  • platform/text/wince/TextCodecWinCE.h: Added.
12:30 AM Changeset in webkit [61838] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-25 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Darin Adler.

Add the possibility for a head and footer section to create_jit_stubs.
​https://bugs.webkit.org/show_bug.cgi?id=36050

  • create_jit_stubs:
12:27 AM Changeset in webkit [61837] by rwlbuis@webkit.org
  • 4 edits
    2 adds in trunk

2010-06-24 Rob Buis <​rwlbuis@gmail.com>

Reviewed by Dirk Schulze.

Bug 40880 - SVG properties fill and stroke do not accept system colors
​https://bugs.webkit.org/show_bug.cgi?id=40880

Handle css system colors in fill and stroke properties.

Test: svg/css/rect-system-color.xhtml

  • css/CSSParser.cpp: Remove comment and unneeded if condition (WebCore::CSSParser::parseValue):
  • css/SVGCSSParser.cpp: Allow css system colors (WebCore::CSSParser::parseSVGValue):
12:21 AM Changeset in webkit [61836] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-25 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/test_expectations.txt: Add <meter> expectations
12:09 AM Changeset in webkit [61835] by eric@webkit.org
  • 10 edits in trunk/WebCore

2010-06-24 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Make DocumentParser API private on subclasses to catch misuse bugs
​https://bugs.webkit.org/show_bug.cgi?id=41186

This already found one bug:
​https://bugs.webkit.org/show_bug.cgi?id=41187

Added a new HTMLDocumentParaser::parseDocumentFragment so that
DocumentFragment.cpp does not need to use private methods.

  • dom/DocumentFragment.cpp: (WebCore::DocumentFragment::parseHTML):
  • dom/XMLDocumentParser.h: (WebCore::XMLDocumentParser::setIsXHTMLDocument): (WebCore::XMLDocumentParser::isXHTMLDocument): (WebCore::XMLDocumentParser::setIsXHTMLMPDocument): (WebCore::XMLDocumentParser::isXHTMLMPDocument):
  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::parseDocumentFragment):
  • html/HTMLDocumentParser.h:
  • html/LegacyHTMLDocumentParser.cpp: (WebCore::LegacyHTMLDocumentParser::parseDocumentFragment):
  • html/LegacyHTMLDocumentParser.h: (WebCore::LegacyHTMLDocumentParser::forceSynchronous): (WebCore::LegacyHTMLDocumentParser::processingContentWrittenByScript):
  • html/LegacyHTMLTreeBuilder.cpp: (WebCore::LegacyHTMLTreeBuilder::reportErrorToConsole):
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::replaceDocument):
  • loader/TextDocument.cpp:
12:05 AM Changeset in webkit [61834] by Philippe Normand
  • 3 edits in trunk/WebCore

2010-05-28 Philippe Normand <​pnormand@igalia.com>

Reviewed by Gustavo Noronha.

[GStreamer] multiple video sink support
​https://bugs.webkit.org/show_bug.cgi?id=39472

Playbin2 video-sink is now a bin containing a tee element capable
of dispatching the buffers to multiple video sinks. By default
only our webkit video sink is used. This will allow
GStreamerGWorld to add support for autovideosink in the future.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer): (WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer): (WebCore::MediaPlayerPrivateGStreamer::naturalSize): (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

Jun 24, 2010:

11:33 PM Changeset in webkit [61833] by zherczeg@webkit.org
  • 5 edits in trunk/JavaScriptCore

Merge RegExp constructor and RegExp::create methods into one.
Both of function are called with tree parameters and check whether
flags (the third param) is given or not.
Simplify hash lookups in RegExpCache::create with giving them an extra
iterator parameter.
​https://bugs.webkit.org/show_bug.cgi?id=41055

Patch by Renata Hodovan <​reni@inf.u-szeged.hu> on 2010-06-24
Reviewed by Geoffrey Garen.

  • runtime/RegExp.cpp:

(JSC::RegExp::RegExp):

  • runtime/RegExp.h:
  • runtime/RegExpCache.cpp:

(JSC::RegExpCache::lookupOrCreate):
(JSC::RegExpCache::create):

  • runtime/RegExpCache.h:
11:26 PM Changeset in webkit [61832] by hclam@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

Unreviewed. Build fix.

Update test expectations for chromium.

  • platform/chromium-mac/fast/history/timed-refresh-in-cached-frame-expected.txt: Added.
  • platform/chromium-win/fast/history/timed-refresh-in-cached-frame-expected.txt: Added.
  • platform/chromium-win/fast/images/icon-decoding-expected.txt:
11:22 PM Changeset in webkit [61831] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2010-06-24 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

commit-queue is taking too long to land patches because of red trees
​https://bugs.webkit.org/show_bug.cgi?id=41194

Instead of checking for the tree to be green, we'll just spin hot
trying to land patches. This is probably too extreme in ignoring the
tree, but I think we should try it for a while to see if we have
trouble. That will help us find the right balance.

  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
11:18 PM Changeset in webkit [61830] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

2010-06-24 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej Stachowiak.

Incorrect use of '+ 4' and 0 instead of tag and payload offsets in JSValue32_64
​https://bugs.webkit.org/show_bug.cgi?id=41193

I noticed a use of '+ 4' in some of the 32_64 code paths and realised there
were a few places where endianness was being hardcoded. This patch fixes
the errors i could find through code inspection.

  • jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_resolve_global):
  • jit/JITPropertyAccess32_64.cpp: (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::compileGetDirectOffset): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace):
10:45 PM Changeset in webkit [61829] by mrowe@apple.com
  • 5 edits in tags/Safari-534.1.2/WebCore

Roll out r61638 to address <rdar://problem/8122799>.

10:45 PM Changeset in webkit [61828] by mrowe@apple.com
  • 1 edit
    2 adds in tags/Safari-534.1.2/WebKit2

Merge r61820.

10:45 PM Changeset in webkit [61827] by mrowe@apple.com
  • 5 edits in tags/Safari-534.1.2

Versioning.

10:37 PM Changeset in webkit [61826] by mrowe@apple.com
  • 1 copy in tags/Safari-534.1.2

New tag.

10:36 PM Changeset in webkit [61825] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-06-24 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Sketch out AfterHeadMode for tree builder
​https://bugs.webkit.org/show_bug.cgi?id=41191

This mode is fairly similar to the others. I needed to change some of
the types around w.r.t. Nodes/Elements.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::processToken): (WebCore::HTMLTreeBuilder::insertElement):
  • html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::ElementStack::push): (WebCore::HTMLTreeBuilder::ElementStack::remove):
10:35 PM Changeset in webkit [61824] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2010-06-24 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Sketch out InHeadNoscriptMode for tree builder
​https://bugs.webkit.org/show_bug.cgi?id=41189

Lots of notImplemented() calls in this state. I need to figure how to
delegate handling of a token from one state to another.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processToken):
10:33 PM Changeset in webkit [61823] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-06-24 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Sketch out InHeadMode for tree builder
​https://bugs.webkit.org/show_bug.cgi?id=41184

This state is relatively straightforward. We introduce the stack of
open elements to track that notion in the spec. The old tree builder
has a nice data structure for that, which we'll probably steal, but I'd
like to see what the full API is first.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processToken): (WebCore::HTMLTreeBuilder::insertCharacter): (WebCore::HTMLTreeBuilder::insertGenericRCDATAElement): (WebCore::HTMLTreeBuilder::insertGenericRawTextElement): (WebCore::HTMLTreeBuilder::insertScriptElement):
  • html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::ElementStack::pop): (WebCore::HTMLTreeBuilder::ElementStack::top):
10:31 PM Changeset in webkit [61822] by abarth@webkit.org
  • 4 edits in trunk/WebCore

2010-06-24 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Sketch out BeforeHeadMode tree builder state
​https://bugs.webkit.org/show_bug.cgi?id=41183

This makes procesToken recursive, which might not be the best idea.
Also, we can now make fake AtomicHTMLTokens for use by the algorithm.

  • html/HTMLToken.h: (WebCore::AtomicHTMLToken::AtomicHTMLToken):
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processToken): (WebCore::HTMLTreeBuilder::insertElement):
  • html/HTMLTreeBuilder.h:
10:24 PM Changeset in webkit [61821] by abarth@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-24 Adam Barth <​abarth@webkit.org>

Unreviewed.

Update GTK expectations for fast/images/icon-decoding.html because
Peter is lazy. :)

  • platform/gtk/fast/images/icon-decoding-expected.txt:
9:49 PM Changeset in webkit [61820] by sfalken@apple.com
  • 1 edit
    2 adds in trunk/WebKit2

Windows build fix.

  • win/WebKit2.make: Added.
  • win/WebKit2.submit.sln: Added.
9:45 PM Changeset in webkit [61819] by tonikitoo@webkit.org
  • 17 edits in trunk/LayoutTests

2010-06-24 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by Kenneth Christiansen.

Spatial Navigation: refactor spatial-navigation-utils.js to support testing nested frames deeper than one level
​https://bugs.webkit.org/show_bug.cgi?id=41157

As is today, we can not test focused nodes in inner frames nested more than one level
deep, due to spatial-navigation-utils.js limitations. Patch addresses this problem:
any time before any focus check, it retrieves the proper focused frame in any level deep.

All spatial navigation test results changed output because the parameter passed in to
shouldBeEqualToString (from js-pre-test.js) changed in spatial-navigation-utils.js.

  • fast/events/spatial-navigation/resources/spatial-navigation-utils.js: (initTest): (verifyAndAdvance): (findFocusedDocument):
  • fast/events/spatial-navigation/snav-clipped-overflowed-content-expected.txt:
  • fast/events/spatial-navigation/snav-div-scrollable-but-without-focusable-content-expected.txt:
  • fast/events/spatial-navigation/snav-fully-aligned-horizontally-expected.txt:
  • fast/events/spatial-navigation/snav-fully-aligned-vertically-expected.txt:
  • fast/events/spatial-navigation/snav-iframe-flattening-simple-expected.txt:
  • fast/events/spatial-navigation/snav-iframe-no-focusable-content-expected.txt:
  • fast/events/spatial-navigation/snav-iframe-no-scrollable-content-expected.txt:
  • fast/events/spatial-navigation/snav-iframe-recursive-offset-parent-expected.txt:
  • fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element-expected.txt:
  • fast/events/spatial-navigation/snav-offscreen-content-expected.txt:
  • fast/events/spatial-navigation/snav-only-clipped-overflow-content-expected.txt:
  • fast/events/spatial-navigation/snav-simple-content-overflow-expected.txt:
  • fast/events/spatial-navigation/snav-table-traversal-expected.txt:
  • fast/events/spatial-navigation/snav-tiny-table-traversal-expected.txt:
  • fast/events/spatial-navigation/snav-unit-overflow-and-scroll-in-direction-expected.txt:
9:30 PM Changeset in webkit [61818] by tonikitoo@webkit.org
  • 7 edits
    2 adds in trunk/WebCore

2010-06-22 Antonio Gomes <​tonikitoo@webkit.org>

Reviewed by David Hyatt.

Add a NodeList-derivated wrapper class for a ListHashSet.
​https://bugs.webkit.org/show_bug.cgi?id=41081

StaticHashSetList will work as a wrapper to ListHashSet objects that are
aimed to be exposed to the DOM.

As a use case, the rect based HitTest (bug 40197) will store the retrieved nodes
in a ListHashSet. It is going to be exposed to the DOM through are nodesFromRect
of Document returning a NodeList (i.e. StatisHashSetList) wrapping a ListHashSet.

No new tests.

8:18 PM Changeset in webkit [61817] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Build fix

Temporarily get the tiger bot working again by disabling the
new JS parser. GCC on tiger is miscompiling the parser and
I don't have access to a tiger machine right now.

8:06 PM Changeset in webkit [61816] by jschuh@chromium.org
  • 3 edits
    3 adds in trunk

2010-06-24 Cris Neckar <​cdn@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Out of bounds write in WebCore::PNGImageDecoder::rowAvailable
​https://bugs.webkit.org/show_bug.cgi?id=40798

Catches error in row callback for libPNG when extra rows are returned.

Test: fast/images/png-extra-row-crash.html

  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::rowAvailable):

2010-06-24 Cris Neckar <​cdn@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Out of bounds write in WebCore::PNGImageDecoder::rowAvailable
​https://bugs.webkit.org/show_bug.cgi?id=40798

Tests a PNG with an extra row.

  • fast/images/png-extra-row-crash-expected.txt: Added.
  • fast/images/png-extra-row-crash.html: Added.
  • fast/images/resources/png-extra-row-crash.png: Added.
6:34 PM Changeset in webkit [61815] by eric@webkit.org
  • 4 edits in trunk

2010-06-24 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Clean up and document DocumentWriter::replaceDocument code path
​https://bugs.webkit.org/show_bug.cgi?id=41182

No functional changes, thus no tests.

  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::replaceDocument):
    • Remove comment which could be misleading.

2010-06-24 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Clean up and document DocumentWriter::replaceDocument code path
​https://bugs.webkit.org/show_bug.cgi?id=41182

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::loadJavaScriptURL):
    • Make Chromium use DocumentWriter like it should.
6:28 PM Changeset in webkit [61814] by jamesr@google.com
  • 4 edits in trunk/LayoutTests

2010-06-24 James Robinson <​jamesr@chromium.org>

Unreviewed. Add mac pixel baselines for fast/images/icon-decoding and fix EOLs for text baseline.

  • platform/mac/fast/images/icon-decoding-expected.checksum:
  • platform/mac/fast/images/icon-decoding-expected.png:
  • platform/mac/fast/images/icon-decoding-expected.txt:
6:08 PM Changeset in webkit [61813] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed, updating test baseline for changed test.

Update mac text baseline. Don't have a way to get an updated pixel diff
at the moment.
​https://bugs.webkit.org/show_bug.cgi?id=41107

  • platform/mac/fast/images/icon-decoding-expected.txt:
6:00 PM Changeset in webkit [61812] by dumi@chromium.org
  • 14 edits in trunk

WebCore: Implementing DatabaseSync::openDatabaseSync().
​https://bugs.webkit.org/show_bug.cgi?id=40607

Reviewed by Adam Barth.

Moved some common code from Database to AbstractDatabase. Made
performOpenAndVerify() virtual, since DatabaseSync doesn't need to
interact with DatabaseThread. Removed the m_creationCallback
field, since it's only needed in the openDatabase{Sync} methods.

  • storage/AbstractDatabase.cpp:

(WebCore::retrieveTextResultFromDatabase):
(WebCore::setTextValueInDatabase):
(WebCore::guidMutex):
(WebCore::guidToVersionMap):
(WebCore::updateGuidVersionMap):
(WebCore::guidToDatabaseMap):
(WebCore::guidForOriginAndName):
(WebCore::AbstractDatabase::databaseInfoTableName):
(WebCore::AbstractDatabase::AbstractDatabase):
(WebCore::AbstractDatabase::closeDatabase):
(WebCore::AbstractDatabase::version):
(WebCore::AbstractDatabase::performOpenAndVerify):
(WebCore::AbstractDatabase::scriptExecutionContext):
(WebCore::AbstractDatabase::securityOrigin):
(WebCore::AbstractDatabase::stringIdentifier):
(WebCore::AbstractDatabase::displayName):
(WebCore::AbstractDatabase::estimatedSize):
(WebCore::AbstractDatabase::fileName):
(WebCore::AbstractDatabase::databaseVersionKey):
(WebCore::AbstractDatabase::getVersionFromDatabase):
(WebCore::AbstractDatabase::setVersionInDatabase):
(WebCore::AbstractDatabase::versionMatchesExpected):
(WebCore::AbstractDatabase::setExpectedVersion):
(WebCore::AbstractDatabase::disableAuthorizer):
(WebCore::AbstractDatabase::enableAuthorizer):
(WebCore::AbstractDatabase::setAuthorizerReadOnly):
(WebCore::AbstractDatabase::lastActionChangedDatabase):
(WebCore::AbstractDatabase::lastActionWasInsert):
(WebCore::AbstractDatabase::resetDeletes):
(WebCore::AbstractDatabase::hadDeletes):
(WebCore::AbstractDatabase::resetAuthorizer):

  • storage/AbstractDatabase.h:

(WebCore::AbstractDatabase::opened):
(WebCore::AbstractDatabase::isNew):
(WebCore::AbstractDatabase::databaseDebugName):

  • storage/Database.cpp:

(WebCore::DatabaseCreationCallbackTask::create):
(WebCore::DatabaseCreationCallbackTask::performTask):
(WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask):
(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::version):
(WebCore::Database::openAndVerifyVersion):
(WebCore::Database::close):
(WebCore::Database::stop):
(WebCore::Database::performOpenAndVerify):

  • storage/Database.h:

(WebCore::Database::sqliteDatabase):

  • storage/DatabaseAuthorizer.cpp:

(WebCore::DatabaseAuthorizer::create):
(WebCore::DatabaseAuthorizer::DatabaseAuthorizer):
(WebCore::DatabaseAuthorizer::denyBasedOnTableName):

  • storage/DatabaseAuthorizer.h:
  • storage/DatabaseSync.cpp:

(WebCore::DatabaseSync::openDatabaseSync):
(WebCore::DatabaseSync::DatabaseSync):
(WebCore::DatabaseSync::changeVersion):
(WebCore::DatabaseSync::transaction):
(WebCore::DatabaseSync::markAsDeletedAndClose):
(WebCore::CloseSyncDatabaseOnContextThreadTask::create):
(WebCore::CloseSyncDatabaseOnContextThreadTask::performTask):
(WebCore::CloseSyncDatabaseOnContextThreadTask::CloseSyncDatabaseOnContextThreadTask):
(WebCore::DatabaseSync::closeImmediately):

  • storage/DatabaseSync.h:
  • storage/DatabaseTask.cpp:

(WebCore::DatabaseOpenTask::DatabaseOpenTask):
(WebCore::DatabaseOpenTask::doPerformTask):

  • storage/DatabaseTask.h:

(WebCore::DatabaseOpenTask::create):

LayoutTests: Uncomment all test cases in open-database-sync-inputs.
​https://bugs.webkit.org/show_bug.cgi?id=40607

Reviewed by Adam Barth.

  • fast/workers/storage/open-database-sync-inputs-expected.txt:
  • fast/workers/storage/resources/open-database-sync-inputs.js:

(catch):

5:50 PM Changeset in webkit [61811] by Martin Robinson
  • 2 edits
    2 adds in trunk/LayoutTests

2010-06-24 Martin Robinson <​mrobinson@igalia.com>

Unreviewed.

Adding GTK+-specific results for these tests.

  • platform/gtk/Skipped: Unskipping tests that now have baselines.
  • platform/gtk/fast/block/positioning/relative-positioned-inline-container-expected.txt: Added.
  • platform/gtk/fast/repaint/inline-relative-positioned-expected.txt: Added.
5:37 PM Changeset in webkit [61810] by mrowe@apple.com
  • 4 edits in tags/Safari-534.1.1

Merge r61806.

5:37 PM Changeset in webkit [61809] by mrowe@apple.com
  • 5 edits in tags/Safari-534.1.1

Versioning.

5:29 PM Changeset in webkit [61808] by Martin Robinson
  • 4 edits in trunk

2010-06-24 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Cannot change the selection via the keyboard
​https://bugs.webkit.org/show_bug.cgi?id=41162

  • platform/gtk/Skipped: Unskip a test which is now passing.

2010-06-24 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Cannot change the selection via the keyboard
​https://bugs.webkit.org/show_bug.cgi?id=41162

Fix issue where the selection could not be extended via the keyboard by
adjusting the logic guarding against inserting text in non-editable nodes.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::handleKeyboardEvent): Allow editor commands that do not insert text in non-editable nodes. This fixes keyboard selection extension in non-editable nodes. Move the existing check to after the execution of any editor commands.
5:28 PM Changeset in webkit [61807] by mrowe@apple.com
  • 1 copy in tags/Safari-534.1.1

New tag.

5:24 PM Changeset in webkit [61806] by sfalken@apple.com
  • 4 edits in trunk

Windows build fix.

WebCore:

  • platform/network/cf/AuthenticationCF.h:

WebKit2:

  • win/WebKit2WebProcess.vcproj:
5:22 PM Changeset in webkit [61805] by Martin Robinson
  • 2 edits in trunk/WebKitTools

2010-06-24 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Clean up the use of gdk_window_get_root_coords in EventSender
​https://bugs.webkit.org/show_bug.cgi?id=40843

Define the version for old GTK+s in a way that is forward-compatible
and clean up the logic a bit.

  • DumpRenderTree/gtk/EventSender.cpp: (gdk_window_get_root_coords): Renamed and cleaned up. (prepareMouseButtonEvent): Remove #ifdefs. (mouseMoveToCallback): Remove #ifdefs.
5:22 PM Changeset in webkit [61804] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-24 Tony Chang <​tony@chromium.org>

Not reviewed, just updating a comment.

include a bug link in skipped mac test
​https://bugs.webkit.org/show_bug.cgi?id=41185

  • platform/mac/Skipped: Updating a comment to include a bug link.
5:11 PM Changeset in webkit [61803] by weinig@apple.com
  • 7 edits
    1 add in trunk/WebKit2

Add WKBundlePageRenderTreeExternalRepresentation for WebKitTestRunner.

Reviewed by Brady Eidson.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageRenderTreeExternalRepresentation):

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h: Added.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::renderTreeExternalRepresentation):
(WebKit::WebPage::getRenderTreeExternalRepresentation):

  • WebProcess/WebPage/WebPage.h:
  • mac/WebKit2.exp:
  • win/WebKit2.vcproj:
5:05 PM Changeset in webkit [61802] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-06-24 Martin Robinson <​mrobinson@igalia.com>

Unreviewed. Build fix.

Fix the build after r61798.

  • platform/gtk/PasteboardHelper.cpp: (WebCore::PasteboardHelper::getClipboardContents):
4:58 PM Changeset in webkit [61801] by ap@apple.com
  • 5 edits
    2 adds in trunk

Reviewed by Brady Eidson.

​https://bugs.webkit.org/show_bug.cgi?id=41178
Timed refresh in subframes isn't stopped when going into b/f cache

Test: fast/history/timed-refresh-in-cached-frame.html

  • history/CachedFrame.cpp: (WebCore::CachedFrame::CachedFrame): Top frame's stopLoading() won't help cached subframes; stop loading from here.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): Don't stop loading in child frames. This didn't work for cached frames due to frame tree having been already desonstructed, and it's not necessary in non-cached case because stopLoading() will be called for subframes via FrameLoader::detachFromParent() and closeURL(). (WebCore::FrameLoader::pageHidden): This was a second code path that dispatched pagehide event - it's no longer needed, because everything goes through FrameLoader::stopLoading(). (WebCore::FrameLoader::commitProvisionalLoad): Don't call pageHidden(), the code for adding frame to b/f cache will do everything.
  • loader/FrameLoader.h: Removed pageHidden().
4:57 PM Changeset in webkit [61800] by pkasting@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed.

Fix earlier test change so it actually tests anything.
​https://bugs.webkit.org/show_bug.cgi?id=41107

  • fast/images/icon-decoding.html:
4:41 PM Changeset in webkit [61799] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-24 Eric Seidel <​eric@webkit.org>

Unreviewed. Fix the build. I am a bad man.

  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::replaceDocument):
4:34 PM Changeset in webkit [61798] by Martin Robinson
  • 3 edits in trunk/WebCore

2010-06-24 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

Build fix for building against GTK+ 3.x.

No new tests as functionality has not changed.

  • platform/gtk/GtkVersioning.h:
  • platform/gtk/PasteboardHelper.cpp: (WebCore::PasteboardHelper::getClipboardContents): (WebCore::PasteboardHelper::fillSelectionData):
4:28 PM Changeset in webkit [61797] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-06-24 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Clean up and document DocumentWriter::replaceDocument code path
​https://bugs.webkit.org/show_bug.cgi?id=41182

No functional change, thus no test.

  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::replaceDocument):
  • loader/DocumentWriter.h:
4:25 PM Changeset in webkit [61796] by jer.noble@apple.com
  • 7 edits in trunk

2010-06-24 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

Full-screened content doesn't keep the display on: Safari not grabbing a power assertion?
​https://bugs.webkit.org/show_bug.cgi?id=40939
rdar://problem/7996172


Add IOKit.framework to the list of linked frameworks.

  • WebKit.xcodeproj/project.pbxproj:

2010-06-24 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

Full-screened content doesn't keep the display on: Safari not grabbing a power assertion?
​https://bugs.webkit.org/show_bug.cgi?id=40939
rdar://problem/7996172


Take a IOKit power assertion when playing video in fullscreen mode. Release the
assertion when paused in fullscreen mode, and when exiting fullscreen mode.

  • WebView/WebVideoFullscreenController.h:
  • WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController windowDidExitFullscreen]): Call updatePowerAssertions. (-[WebVideoFullscreenController windowDidEnterFullscreen]): Call updatePowerAssertions. (-[WebVideoFullscreenController _disableIdleDisplaySleep]): (-[WebVideoFullscreenController _enableIdleDisplaySleep]): (-[WebVideoFullscreenController _disableIdleSystemSleep]): (-[WebVideoFullscreenController _enableIdleSystemSleep]): (-[WebVideoFullscreenController updatePowerAssertions]): Call _(enable|disable)Idle(System|Display)sleep depending on current playback rate and fullscreen status. (-[WebVideoFullscreenController rateChanged:]): Call updatePowerAssertions.

2010-06-24 Jer Noble <​jer.noble@apple.com>

Reviewed by Eric Carlson.

Full-screened content doesn't keep the display on: Safari not grabbing a power assertion?
​https://bugs.webkit.org/show_bug.cgi?id=40939
rdar://problem/7996172


Export -[MediaElement playbackRate];


  • WebCore.Video.exp:
4:12 PM Changeset in webkit [61795] by evan@chromium.org
  • 7 edits in trunk

2010-06-21 Evan Martin <​evan@chromium.org>

Reviewed by Adam Barth.

[chromium] overlapping characters in complex text
​https://bugs.webkit.org/show_bug.cgi?id=40966

New baselines, now that bug is fixed (e.g. the /M at the end was previously overlapping).

  • platform/chromium-linux/fast/text/international/thai-baht-space-expected.checksum:
  • platform/chromium-linux/fast/text/international/thai-baht-space-expected.png:
  • platform/chromium-linux/fast/text/atsui-spacing-features-expected.checksum:
  • platform/chromium-linux/fast/text/atsui-spacing-features-expected.png:

2010-06-21 Evan Martin <​evan@chromium.org>

Reviewed by Adam Barth.

[chromium] overlapping characters in complex text
​https://bugs.webkit.org/show_bug.cgi?id=40966

We need to clear all the buffers we hand to Harfbuzz before we use them.
While I'm here, refactor the code slightly to make its behavior more
clear and correct (previously, we would repeatedly double our buffer
size when we could have just sized it correctly on the second try).

  • platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::TextRunWalker): (WebCore::TextRunWalker::nextScriptRun): (WebCore::TextRunWalker::createGlyphArrays): (WebCore::TextRunWalker::shapeGlyphs):
3:49 PM Changeset in webkit [61794] by adele@apple.com
  • 4 edits in trunk

Updated fix for <rdar://problem/8093680> "Paste and Match Style" should fire paste events
​https://bugs.webkit.org/show_bug.cgi?id=41085

Reviewed by Sam Weinig.

WebCore:

Covered by existing tests.

  • editing/EditorCommand.cpp:

(WebCore::executePasteAsPlainText): Added.
(WebCore::createCommandMap): Added pasteAsPlainText command.

WebKit/mac:

  • WebView/WebHTMLView.mm: Use the WebCore command system for the pasteAsPlainText selector.

Also remove internal methods that no one is using.

3:39 PM Changeset in webkit [61793] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-06-24 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Sketch out BeforeHTMLMode state
​https://bugs.webkit.org/show_bug.cgi?id=41133

In this patch, we switch the TreeBuidler over to using AtomicHTMLTokens
and sketch out another state. These states don't actually do anything
yet, I'm still just getting the structure of the spec into the code so
we can implement the details incrementally.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::constructTreeFromToken): (WebCore::HTMLTreeBuilder::processToken): (WebCore::HTMLTreeBuilder::insertDoctype): (WebCore::HTMLTreeBuilder::insertComment):
  • html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::parseError):
3:31 PM Changeset in webkit [61792] by Dimitri Glazkov
  • 2 edits in trunk/WebKitTools

2010-06-24 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

Fix NewRunWebKitTests to work on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=41180

  • BuildSlaveSupport/build.webkit.org-config/master.cfg: Added "perl" as first arguments,

because Windows fails to understand what we're asking of it.

3:07 PM Changeset in webkit [61791] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-06-24 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add AtomicHTMLToken
​https://bugs.webkit.org/show_bug.cgi?id=41131

We need an atomized version of the token for use in the tree builder.
Eventually, we should make the existing HTMLToken an internal detail of
the HTMLTokenizer. This new AtomicHTMLToken should be also be more
easily cached between the preload scanner and the tree builder.

  • html/HTMLToken.h: (WebCore::AtomicHTMLToken::AtomicHTMLToken): (WebCore::AtomicHTMLToken::type): (WebCore::AtomicHTMLToken::name): (WebCore::AtomicHTMLToken::selfClosing): (WebCore::AtomicHTMLToken::attributes): (WebCore::AtomicHTMLToken::characters): (WebCore::AtomicHTMLToken::comment): (WebCore::AtomicHTMLToken::publicIdentifier): (WebCore::AtomicHTMLToken::systemIdentifier): (WebCore::AtomicHTMLToken::forceQuirks):
  • html/HTMLTreeBuilder.cpp: (WebCore::convertToOldStyle): (WebCore::HTMLTreeBuilder::passTokenToLegacyParser):
3:07 PM Changeset in webkit [61790] by Martin Robinson
  • 2 edits in trunk/WebKitTools

2010-06-24 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] The url passed to the WebView during layout tests is invalid
​https://bugs.webkit.org/show_bug.cgi?id=40832

Set the test URL to the full real file URL and do a small cleanup.
Previously a URL like ​file://relative/path/to/test.html was passed
to the WebView. This malformed file URL would be returned by
webkit_web_view_get_url and webkit_web_frame_get_url.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (shouldLogFrameLoadDelegates): Change to take a const string& as the argument. (shouldOpenWebInspector): Change to take a const string& as the argument. (shouldEnableDeveloperExtras): Change to take a const string& as the argument. (runTest): Pass the full ​file:// URL to the view. Remove the superfluous url variable.
3:03 PM Changeset in webkit [61789] by eric@webkit.org
  • 10 edits
    1 copy in trunk/WebCore

2010-06-24 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add RawDataDocumentParser to get rid of a bunch of copy/paste code in DocumentParser subclasses
​https://bugs.webkit.org/show_bug.cgi?id=41136

I think this is likely far from the final design,
however this is almost entirely minus lines which is a
good thing.

The original authors of these DocumentParser subclasses
seem to have just copied the files whole, as they all
had the same includes, many of which were unnecessary for
some of the files.

I think eventually the FrameLoader will call a virtual
DocumentParser::appendData which will in turn decode
and call another write/appendData call. In the case
of these RawDataDocumentParsers, they will just override
the low-level appendData call instead of needing
DocumentWriter to have a special if based on
DocumentParser::wantsRawData.

No functional change, thus no tests.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DocumentParser.h: (WebCore::DocumentParser::writeRawData):
  • loader/ImageDocument.cpp: (WebCore::ImageDocumentParser::ImageDocumentParser): (WebCore::ImageDocumentParser::finish):
  • loader/MediaDocument.cpp: (WebCore::MediaDocumentParser::MediaDocumentParser): (WebCore::MediaDocumentParser::writeRawData):
  • loader/PluginDocument.cpp: (WebCore::PluginDocumentParser::PluginDocumentParser):
  • loader/SinkDocument.cpp: (WebCore::SinkDocument::createParser):
3:01 PM Changeset in webkit [61788] by pkasting@chromium.org
  • 5 edits
    1 add in trunk

WebCore: REGRESSION (r61619): Memory corruption in open-source ICO decoder
​https://bugs.webkit.org/show_bug.cgi?id=41107

Reviewed by Adam Barth.

  • platform/image-decoders/bmp/BMPImageReader.cpp:

(WebCore::BMPImageReader::processInfoHeader): Fix memory corruption.

  • platform/image-decoders/ico/ICOImageDecoder.cpp:

(WebCore::ICOImageDecoder::processDirectoryEntries): Handle sizing failure correctly (though failure should be impossible).

LayoutTests: REGRESSION (r61619): Memory corruption in open-source ICO decoder
​https://bugs.webkit.org/show_bug.cgi?id=41107

Reviewed by Adam Barth.

This doesn't contain the updated test results -- I'll get that off the
bots after checkin.

  • fast/images/icon-decoding.html: Add test for memory corruption while decoding broken .ico.
  • fast/images/resources/bad.ico: Added.
2:57 PM Changeset in webkit [61787] by commit-queue@webkit.org
  • 30 edits in trunk/WebCore

2010-06-24 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r61783.
​http://trac.webkit.org/changeset/61783
​https://bugs.webkit.org/show_bug.cgi?id=41179

Caused a couple of test failures (Requested by japhet on
#webkit).

  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): (WebCore::DOMImplementation::createHTMLDocument):
  • dom/DOMImplementation.h:
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::initSecurityContext):
  • dom/Document.h: (WebCore::Document::create): (WebCore::Document::createXHTML):
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::HTMLDocument):
  • html/HTMLDocument.h: (WebCore::HTMLDocument::create):
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
  • html/HTMLViewSourceDocument.h: (WebCore::HTMLViewSourceDocument::create):
  • loader/CachedFont.cpp: (WebCore::CachedFont::ensureSVGFontData):
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::createDocument): (WebCore::DocumentWriter::begin):
  • loader/DocumentWriter.h:
  • loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryDocument::FTPDirectoryDocument):
  • loader/FTPDirectoryDocument.h: (WebCore::FTPDirectoryDocument::create):
  • loader/ImageDocument.cpp: (WebCore::ImageDocument::ImageDocument):
  • loader/ImageDocument.h: (WebCore::ImageDocument::create):
  • loader/MediaDocument.cpp: (WebCore::MediaDocument::MediaDocument):
  • loader/MediaDocument.h: (WebCore::MediaDocument::create):
  • loader/PlaceholderDocument.h: (WebCore::PlaceholderDocument::create): (WebCore::PlaceholderDocument::PlaceholderDocument):
  • loader/PluginDocument.cpp: (WebCore::PluginDocument::PluginDocument):
  • loader/PluginDocument.h: (WebCore::PluginDocument::create):
  • loader/SinkDocument.cpp: (WebCore::SinkDocument::SinkDocument):
  • loader/SinkDocument.h: (WebCore::SinkDocument::create):
  • loader/TextDocument.cpp: (WebCore::TextDocument::TextDocument):
  • loader/TextDocument.h: (WebCore::TextDocument::create):
  • svg/SVGDocument.cpp: (WebCore::SVGDocument::SVGDocument):
  • svg/SVGDocument.h: (WebCore::SVGDocument::create):
  • xml/DOMParser.cpp: (WebCore::DOMParser::parseFromString):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseXML):
  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource):
2:50 PM Changeset in webkit [61786] by sullivan@apple.com
  • 2 edits in trunk/WebKit2
  • mac/WebKit2.exp:

Added _WKNavigationDataRelease and _WKNavigationDataRetain.

Rubber-stamped by Ada Chan.

2:29 PM Changeset in webkit [61785] by Martin Robinson
  • 2 edits in trunk/WebCore

2010-06-24 Martin Robinson <​mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Small code cleanup in RenderThemeGtk
​https://bugs.webkit.org/show_bug.cgi?id=40989

Reduce the amount of duplicated code slightly and prepare this section for
future improvements, such as sharing the clipping rectangle calculation with
the slow path.

No new tests as functionality has not changed.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::paintMozillaGtkWidget): Small code cleanup.
2:27 PM Changeset in webkit [61784] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-06-24 Martin Robinson <​mrobinson@igalia.com>

Unreviewed.

Updated expected results for a test that differs on the bots.

  • platform/gtk/scrollbars/overflow-scrollbar-combinations-expected.txt:
1:13 PM Changeset in webkit [61783] by Nate Chapin
  • 30 edits in trunk/WebCore

2010-06-24 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Take a KURL parameter in Document's constructor.
This will remove the one case where Document::url()
and FrameLoader::url() are not equal, allowing us to
remove FrameLoader::url().

​https://bugs.webkit.org/show_bug.cgi?id=41166

Refactor only, no new tests.

  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): Take a KURL and pass it through to Document. (WebCore::DOMImplementation::createHTMLDocument):
  • dom/DOMImplementation.h:
  • dom/Document.cpp: (WebCore::Document::Document): Call setURL() for non-empty KURL input parameters. (WebCore::Document::initSecurityContext): m_url is now initialized, so use it instead

of m_frame->loader()->url() for initializing the SecurityOrigin.

  • dom/Document.h: (WebCore::Document::create): (WebCore::Document::createXHTML):
  • html/HTMLDocument.cpp:
  • html/HTMLDocument.h: Add KURL parameter to create() and constructor.
  • html/HTMLViewSourceDocument.cpp:
  • html/HTMLViewSourceDocument.h: Add KURL parameter to create() and constructor.
  • loader/CachedFont.cpp: (WebCore::CachedFont::ensureSVGFontData):
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::createDocument): Take a KURL and pass it through to Document. (WebCore::DocumentWriter::begin): Pass existing url parameter to constructors, and remove

redundant Document::setURL() call.

  • loader/DocumentWriter.h:
  • loader/FTPDirectoryDocument.cpp:
  • loader/FTPDirectoryDocument.h: Add KURL parameter to create() and constructor.
  • loader/ImageDocument.cpp:
  • loader/ImageDocument.h: Add KURL parameter to create() and constructor.
  • loader/MediaDocument.cpp:
  • loader/MediaDocument.h: Add KURL parameter to create() and constructor.
  • loader/PlaceholderDocument.h: Add KURL parameter to create() and constructor.
  • loader/PluginDocument.cpp:
  • loader/PluginDocument.h: Add KURL parameter to create() and constructor.
  • loader/SinkDocument.cpp:
  • loader/SinkDocument.h: Add KURL parameter to create() and constructor.
  • loader/TextDocument.cpp:
  • loader/TextDocument.h: Add KURL parameter to create() and constructor.
  • svg/SVGDocument.cpp:
  • svg/SVGDocument.h: Add KURL parameter to create() and constructor.
  • xml/DOMParser.cpp: (WebCore::DOMParser::parseFromString):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseXML):
  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource):
1:04 PM Changeset in webkit [61782] by Martin Robinson
  • 2 edits
    83 adds in trunk/LayoutTests

2010-06-24 Martin Robinson <​mrobinson@igalia.com>

Unreviewed.

Skip a failing test. Clean up skipped list stragglers. Conglomerate all tests which
are timing out and don't have attached bugs. Add expected results for some tests and
unskip them.

  • platform/gtk/Skipped: Clean up skipped list stragglers.
  • platform/gtk/animations/3d/change-transform-in-end-event-expected.txt: Added.
  • platform/gtk/animations/3d/state-at-end-event-transform-expected.txt: Added.
  • platform/gtk/animations/state-at-end-event-expected.txt: Added.
  • platform/gtk/fast/backgrounds/001-expected.txt: Added.
  • platform/gtk/fast/backgrounds/animated-gif-as-background-expected.txt: Added.
  • platform/gtk/fast/backgrounds/animated-svg-as-background-expected.txt: Copied from LayoutTests/platform/qt/fast/backgrounds/animated-svg-as-background-expected.txt.
  • platform/gtk/fast/backgrounds/background-inherit-color-bug-expected.txt: Added.
  • platform/gtk/fast/backgrounds/background-origin-root-element-expected.txt: Added.
  • platform/gtk/fast/backgrounds/background-position-1-expected.txt: Added.
  • platform/gtk/fast/backgrounds/background-position-rounding-expected.txt: Added.
  • platform/gtk/fast/backgrounds/bgCompositeCopy-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/backgrounds/bgCompositeCopy-expected.txt.
  • platform/gtk/fast/backgrounds/body-generated-image-propagated-to-root-expected.txt: Added.
  • platform/gtk/fast/backgrounds/mask-composite-expected.txt: Added.
  • platform/gtk/fast/backgrounds/opacity-on-document-element-expected.txt: Added.
  • platform/gtk/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.txt: Added.
  • platform/gtk/fast/backgrounds/repeat/negative-offset-repeat-expected.txt: Added.
  • platform/gtk/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.txt: Added.
  • platform/gtk/fast/backgrounds/repeat/noRepeatCorrectClip-expected.txt: Copied from LayoutTests/platform/qt/fast/backgrounds/repeat/noRepeatCorrectClip-expected.txt.
  • platform/gtk/fast/backgrounds/size/backgroundSize01-expected.txt: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize01-expected.txt.
  • platform/gtk/fast/backgrounds/size/backgroundSize02-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/backgrounds/size/backgroundSize02-expected.txt.
  • platform/gtk/fast/backgrounds/size/backgroundSize03-expected.txt: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize03-expected.txt.
  • platform/gtk/fast/backgrounds/size/backgroundSize04-expected.txt: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize04-expected.txt.
  • platform/gtk/fast/backgrounds/size/backgroundSize05-expected.txt: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize05-expected.txt.
  • platform/gtk/fast/backgrounds/size/backgroundSize06-expected.txt: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize06-expected.txt.
  • platform/gtk/fast/backgrounds/size/backgroundSize07-expected.txt: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize07-expected.txt.
  • platform/gtk/fast/backgrounds/size/backgroundSize08-expected.txt: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize08-expected.txt.
  • platform/gtk/fast/backgrounds/size/backgroundSize09-expected.txt: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize09-expected.txt.
  • platform/gtk/fast/backgrounds/size/backgroundSize10-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/backgrounds/size/backgroundSize10-expected.txt.
  • platform/gtk/fast/backgrounds/size/backgroundSize11-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/backgrounds/size/backgroundSize11-expected.txt.
  • platform/gtk/fast/backgrounds/size/backgroundSize12-expected.txt: Copied from LayoutTests/platform/mac/fast/backgrounds/size/backgroundSize12-expected.txt.
  • platform/gtk/fast/backgrounds/size/backgroundSize13-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/backgrounds/size/backgroundSize13-expected.txt.
  • platform/gtk/fast/backgrounds/size/backgroundSize14-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/backgrounds/size/backgroundSize14-expected.txt.
  • platform/gtk/fast/backgrounds/size/backgroundSize15-expected.txt: Added.
  • platform/gtk/fast/backgrounds/size/backgroundSize16-expected.txt: Added.
  • platform/gtk/fast/backgrounds/size/backgroundSize17-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/backgrounds/size/backgroundSize17-expected.txt.
  • platform/gtk/fast/backgrounds/size/backgroundSize18-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/backgrounds/size/backgroundSize18-expected.txt.
  • platform/gtk/fast/backgrounds/size/backgroundSize19-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/backgrounds/size/backgroundSize19-expected.txt.
  • platform/gtk/fast/backgrounds/size/zero-expected.txt: Added.
  • platform/gtk/fast/backgrounds/solid-color-context-restore-expected.txt: Added.
  • platform/gtk/fast/backgrounds/svg-as-background-1-expected.txt: Copied from LayoutTests/platform/qt/fast/backgrounds/svg-as-background-1-expected.txt.
  • platform/gtk/fast/backgrounds/svg-as-background-2-expected.txt: Copied from LayoutTests/platform/qt/fast/backgrounds/svg-as-background-2-expected.txt.
  • platform/gtk/fast/backgrounds/svg-as-background-3-expected.txt: Copied from LayoutTests/platform/qt/fast/backgrounds/svg-as-background-3-expected.txt.
  • platform/gtk/fast/backgrounds/svg-as-background-4-expected.txt: Copied from LayoutTests/platform/qt/fast/backgrounds/svg-as-background-4-expected.txt.
  • platform/gtk/fast/backgrounds/svg-as-background-5-expected.txt: Copied from LayoutTests/platform/qt/fast/backgrounds/svg-as-background-5-expected.txt.
  • platform/gtk/fast/backgrounds/svg-as-background-6-expected.txt: Copied from LayoutTests/platform/qt/fast/backgrounds/svg-as-background-6-expected.txt.
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/001-expected.txt: Added.
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/002-expected.txt: Added.
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/003-expected.txt: Added.
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/004-expected.txt: Added.
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/005-expected.txt: Added.
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/006-expected.txt: Added.
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/010-expected.txt: Added.
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/011-expected.txt: Added.
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/012-expected.txt: Added.
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/015-expected.txt: Added.
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/016-expected.txt: Added.
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/017-expected.txt: Added.
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/018-expected.txt: Added.
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/019-expected.txt: Added.
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/020-expected.txt: Added.
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/021-expected.txt: Added.
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/022-expected.txt: Added.
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/025-expected.txt: Added.
  • platform/gtk/fast/css/getComputedStyle/marginComputedStyle-expected.txt: Added.
  • platform/gtk/printing/compositing-layer-printing-expected.txt: Added.
  • platform/gtk/printing/media-queries-print-expected.txt: Added.
  • platform/gtk/printing/return-from-printing-mode-expected.txt: Added.
  • platform/gtk/scrollbars/disabled-scrollbar-expected.txt: Added.
  • platform/gtk/scrollbars/listbox-scrollbar-combinations-expected.txt: Added.
  • platform/gtk/scrollbars/overflow-scrollbar-combinations-expected.txt: Added.
  • platform/gtk/scrollbars/scrollbar-buttons-expected.txt: Added.
  • platform/gtk/scrollbars/scrollbar-orientation-expected.txt: Added.
  • platform/gtk/transforms/2d/transform-fixed-container-expected.txt: Added.
  • platform/gtk/transforms/2d/zoom-menulist-expected.txt: Added.
  • platform/gtk/transitions/move-after-transition-expected.txt: Added.
  • platform/gtk/transitions/transition-end-event-rendering-expected.txt: Copied from LayoutTests/platform/mac/transitions/transition-end-event-rendering-expected.txt.
11:38 AM Changeset in webkit [61781] by beidson@apple.com
  • 3 edits
    3 adds in trunk

<rdar://problem/8044645> and ​https://bugs.webkit.org/show_bug.cgi?id=41082

Reviewed by Sam Weinig.

Webarchives will null main resource cause a repro crash.

WebCore:

Test: webarchive/loading/mainresource-null-mimetype-crash.html

  • loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::createResource): Fail to create the archive resource if the main resource's

mime type is null.

LayoutTests:

  • webarchive/loading/mainresource-null-mimetype-crash-expected.txt: Added.
  • webarchive/loading/mainresource-null-mimetype-crash.html: Added.
  • webarchive/loading/resources/mainresource-null-mimetype.webarchive: Added.
11:29 AM Changeset in webkit [61780] by weinig@apple.com
  • 2 edits in trunk/WebKitTools

Fix WebKitTestRunner Makefile typos.

Reviewed by Anders Carlsson.

  • WebKitTestRunner/Makefile:
11:29 AM Changeset in webkit [61779] by sullivan@apple.com
  • 2 edits in trunk/WebKit2
  • mac/WebKit2.exp:

Added _WKPageReloadFromOrigin.

Rubber-stamped by Anders Carlsson.

11:28 AM Changeset in webkit [61778] by sfalken@apple.com
  • 5 edits in trunk/JavaScriptCore

2010-06-21 Nathan Lawrence <​nlawrence@apple.com>

Reviewed by Geoff Garen.

​https://bugs.webkit.org/show_bug.cgi?id=40128
Fixed broken debug functionality.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::dumpRegisters):

Fixed to work with updated call frame.

  • runtime/JSImmediate.h: (JSC::JSValue::isCell):

Added assert for aligned cell.

  • runtime/JSValue.cpp: (JSC::JSValue::description):

Fixed to work with current JSValue implementation.

  • runtime/JSZombie.cpp: (JSC::JSZombie::leakedZombieStructure):

JSombies compile again.

11:14 AM Changeset in webkit [61777] by kdecker@apple.com
  • 7 edits in trunk

2010-06-24 Damian Kaleta <​dkaleta@apple.com>

Reviewed by Sam Weinig.

Provide a way to obtain the rendered rectangle for box elements.

  • WebCore.base.exp: Export the symbol so we can see it in WebKit.
  • dom/Node.cpp: (WebCore::Node::renderRect): Added new ethod that will return a rendered rectangle for box elements.
  • dom/Node.h: Ditto.

2010-06-24 Damian Kaleta <​dkaleta@apple.com>

Reviewed by Sam Weinig.

Added an ObjC wrapper to Node::renderRect(bool&).

  • DOM/WebDOMOperations.mm: (-[DOMNode _renderRect:]):
  • DOM/WebDOMOperationsPrivate.h:
11:11 AM Changeset in webkit [61776] by weinig@apple.com
  • 7 edits in trunk/WebKit2

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=41168
<rdar://problem/8124605>
Webkit2: Add WKPageReloadFromOrigin() to match old-WebKit functionality

Reviewed by Anders Carlsson.

  • UIProcess/API/C/WKPage.cpp:

(WKPageReload):
(WKPageReloadFromOrigin):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::reload):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::reload):
(WebKit::WebPage::didReceiveMessage):

  • WebProcess/WebPage/WebPage.h:
11:11 AM Changeset in webkit [61775] by darin@chromium.org
  • 8 edits
    6 adds in trunk/WebCore

2010-06-24 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Create specialized classes for Transform,
Image and WebGL layers to replace the rather monolithic LayerChromium class.
Layers can now own the GL texture they use for backing store and a different
shading program can be used by the compositor for each layer type. WebGL layers
are not yet hooked up to GraphicsContext3D.
​https://bugs.webkit.org/show_bug.cgi?id=41106

  • WebCore.gypi:
  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::GraphicsLayerChromium): (WebCore::GraphicsLayerChromium::setContentsToImage): (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
  • platform/graphics/chromium/GraphicsLayerChromium.h: (WebCore::GraphicsLayerChromium::):
  • platform/graphics/chromium/ImageLayerChromium.cpp: Added. (WebCore::ImageLayerChromium::create): (WebCore::ImageLayerChromium::ImageLayerChromium): (WebCore::ImageLayerChromium::setContents): (WebCore::ImageLayerChromium::updateTextureContents):
  • platform/graphics/chromium/ImageLayerChromium.h: Added. (WebCore::ImageLayerChromium::drawsContent):
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::create): (WebCore::LayerChromium::LayerChromium): (WebCore::LayerChromium::updateTextureContents): (WebCore::LayerChromium::updateTextureRect):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::drawsContent): (WebCore::LayerChromium::ownsTexture): (WebCore::LayerChromium::textureId): (WebCore::LayerChromium::setShaderProgramId): (WebCore::LayerChromium::shaderProgramId):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::createLayerShader): (WebCore::ShaderProgram::ShaderProgram): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::~LayerRendererChromium): (WebCore::LayerRendererChromium::useShaderProgram): (WebCore::LayerRendererChromium::drawTexturedQuad): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::drawDebugBorder): (WebCore::LayerRendererChromium::updateLayersRecursive): (WebCore::LayerRendererChromium::drawLayer): (WebCore::LayerRendererChromium::bindCommonAttribLocations): (WebCore::LayerRendererChromium::initializeSharedGLObjects):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::):
  • platform/graphics/chromium/TransformLayerChromium.cpp: Added. (WebCore::TransformLayerChromium::create): (WebCore::TransformLayerChromium::TransformLayerChromium):
  • platform/graphics/chromium/TransformLayerChromium.h: Added. (WebCore::TransformLayerChromium::drawsContent):
  • platform/graphics/chromium/WebGLLayerChromium.cpp: Added. (WebCore::WebGLLayerChromium::WebGLLayerChromium): (WebCore::WebGLLayerChromium::textureId): (WebCore::WebGLLayerChromium::updateTextureContents): (WebCore::WebGLLayerChromium::setContext):
  • platform/graphics/chromium/WebGLLayerChromium.h: Added. (WebCore::WebGLLayerChromium::drawsContent): (WebCore::WebGLLayerChromium::ownsTexture): (WebCore::WebGLLayerChromium::shaderProgramId): (WebCore::WebGLLayerChromium::setShaderProgramId):
11:08 AM Changeset in webkit [61774] by darin@chromium.org
  • 5 edits in trunk/WebKit/chromium

2010-06-24 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Darin Fisher.

[Chromium] A WebView can now own a GLES2Context which gets created on
demand. This context will typically be created for the gpu compositor
and used as a parent context for any elements on the page that use the
gpu for rendering (e.g. WebGL) and need to pass their backbuffer directly
to the compositor.
​https://bugs.webkit.org/show_bug.cgi?id=41010

  • public/WebGLES2Context.h:
  • src/GLES2Context.cpp: (WebCore::GLES2ContextInternal::getWebGLES2Context): (WebCore::GLES2ContextInternal::initialize):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::gles2Context):
  • src/WebViewImpl.h:
11:07 AM Changeset in webkit [61773] by mnaganov@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2010-06-24 Mikhail Naganov <​mnaganov@chromium.org>

Unreviewed test expectations update.

  • platform/chromium-mac/css2.1/t0804-c5510-padn-00-b-ag-expected.checksum: Copied from LayoutTests/platform/mac/css2.1/t0804-c5510-padn-00-b-ag-expected.checksum.
  • platform/chromium-mac/css2.1/t0804-c5510-padn-00-b-ag-expected.png: Added.
10:52 AM Changeset in webkit [61772] by pfeldman@chromium.org
  • 23 edits in trunk

2010-06-24 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.


Web Inspector: Inspector cleanup + better DevTools alignment with Inspector.

​https://bugs.webkit.org/show_bug.cgi?id=41094

  • Removed a bunch of unused methods from all over the place
  • Added client callbacks for states surviving navigation
  • Implemented more user-friendly stub for InspectorFrontendHost.platform
  • inspector/InspectorClient.h: (WebCore::InspectorClient::resourceTrackingWasEnabled): (WebCore::InspectorClient::resourceTrackingWasDisabled): (WebCore::InspectorClient::timelineProfilerWasStarted): (WebCore::InspectorClient::timelineProfilerWasStopped):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::enableResourceTracking): (WebCore::InspectorController::disableResourceTracking): (WebCore::InspectorController::ensureSettingsLoaded): (WebCore::InspectorController::startTimelineProfiler): (WebCore::InspectorController::stopTimelineProfiler):
  • inspector/InspectorFrontend.cpp:
  • inspector/InspectorFrontend.h:
  • inspector/front-end/InspectorBackendStub.js:
  • inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub.prototype.platform):

2010-06-24 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.


Web Inspector: Inspector cleanup + better DevTools alignment with Inspector.

​https://bugs.webkit.org/show_bug.cgi?id=41094

  • Merged InspectorClient implementation into WebDevToolsAgent
  • Changed the way WebDevToolsAgent is initialized (will break chromium bot, needs coordinated landing)
  • Removed a lot of legacy code from WebDevToolsAgentImpl
  • Removed a lot of overrides from DevTools.js
  • Simplified devtools stubs
  • Got rid of all logic from within InjectDispatch.js
  • public/WebView.h:
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidCommitLoad):
  • src/InspectorClientImpl.cpp: (WebKit::InspectorClientImpl::inspectorDestroyed): (WebKit::InspectorClientImpl::openInspectorFrontend): (WebKit::InspectorClientImpl::highlight): (WebKit::InspectorClientImpl::hideHighlight): (WebKit::InspectorClientImpl::populateSetting): (WebKit::InspectorClientImpl::storeSetting): (WebKit::InspectorClientImpl::sendMessageToFrontend): (WebKit::InspectorClientImpl::resourceTrackingWasEnabled): (WebKit::InspectorClientImpl::resourceTrackingWasDisabled): (WebKit::InspectorClientImpl::timelineProfilerWasStarted): (WebKit::InspectorClientImpl::timelineProfilerWasStopped): (WebKit::InspectorClientImpl::devToolsAgent):
  • src/InspectorClientImpl.h:
  • src/InspectorFrontendClientImpl.cpp: (WebKit::InspectorFrontendClientImpl::inspectedURLChanged):
  • src/ToolsAgent.h:
  • src/WebDevToolsAgentImpl.cpp: (WebKit::): (WebKit::WebDevToolsAgentImpl::initDevToolsAgentHost): (WebKit::WebDevToolsAgentImpl::setApuAgentEnabled): (WebKit::WebDevToolsAgentImpl::jsDispatchOnClient): (WebKit::WebDevToolsAgentImpl::inspectorDestroyed): (WebKit::WebDevToolsAgentImpl::openInspectorFrontend): (WebKit::WebDevToolsAgentImpl::highlight): (WebKit::WebDevToolsAgentImpl::hideHighlight): (WebKit::WebDevToolsAgentImpl::populateSetting): (WebKit::WebDevToolsAgentImpl::storeSetting): (WebKit::WebDevToolsAgentImpl::sendMessageToFrontend): (WebKit::WebDevToolsAgentImpl::resourceTrackingWasEnabled): (WebKit::WebDevToolsAgentImpl::resourceTrackingWasDisabled): (WebKit::WebDevToolsAgentImpl::timelineProfilerWasStarted): (WebKit::WebDevToolsAgentImpl::timelineProfilerWasStopped):
  • src/WebDevToolsAgentImpl.h:
  • src/WebDevToolsAgentPrivate.h:
  • src/WebViewImpl.cpp: (WebKit::WebView::create): (WebKit::WebViewImpl::WebViewImpl):
  • src/WebViewImpl.h:
  • src/js/DevTools.js: (devtools.ToolsAgent): (): (devtools):
  • src/js/DevToolsHostStub.js: (.window.setDebuggerScriptSource): (.window.dispatchOnInjectedScript):
  • src/js/InjectDispatch.js: (dispatch):
  • src/js/InspectorControllerImpl.js:
10:38 AM Changeset in webkit [61771] by adele@apple.com
  • 5 edits
    2 adds in trunk

WebKit/mac: Fix for <rdar://problem/8093680> "Paste and Match Style" should fire paste events
​https://bugs.webkit.org/show_bug.cgi?id=41085

Reviewed by Eric Carlson.

  • WebView/WebHTMLView.mm: (-[WebHTMLView pasteAsPlainText:]): Reuse code in WebCore

which does everything done here and also fires paste events.

WebKitTools: DumpRenderTree part of testing <rdar://problem/8093680> "Paste and Match Style" should fire paste events
​https://bugs.webkit.org/show_bug.cgi?id=41085

Reviewed by Eric Carlson.

  • DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):

Clear the general pasteboard in between tests so Cut,Copy, and setData on ClipboardData won't have lasting effects.

LayoutTests: Test for <rdar://problem/8093680> "Paste and Match Style" should fire paste events
​https://bugs.webkit.org/show_bug.cgi?id=41085

Reviewed by Eric Carlson.

  • platform/mac/editing/pasteboard/paste-and-match-style-selector-event-expected.txt: Added.
  • platform/mac/editing/pasteboard/paste-and-match-style-selector-event.html: Added.
10:17 AM Changeset in webkit [61770] by mnaganov@chromium.org
  • 3 edits in trunk/LayoutTests

2010-06-24 Mikhail Naganov <​mnaganov@chromium.org>

Unreviewed test expectations update.

  • platform/chromium-win/svg/text/text-text-05-t-expected.checksum:
  • platform/chromium-win/svg/text/text-text-05-t-expected.png:
10:04 AM Changeset in webkit [61769] by weinig@apple.com
  • 1 edit
    23 adds in trunk/WebKitTools

Patch for ​https://bugs.webkit.org/show_bug.cgi?id=41086
Add new WebKitTestRunner project (ie. DRT for WebKit2).

Reviewed by Anders Carlsson.

  • Mac only.
  • run-webkit-tests has not been modified to call it yet.
  • Only dumps the render tree at this time.
  • WebKitTestRunner: Added.
  • WebKitTestRunner/Configurations: Added.
  • WebKitTestRunner/Configurations/Base.xcconfig: Added.
  • WebKitTestRunner/Configurations/DebugRelease.xcconfig: Added.
  • WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Added.
  • WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Added.
  • WebKitTestRunner/InjectedBundle: Added.
  • WebKitTestRunner/InjectedBundle-Info.plist: Added.
  • WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp: Added.

(_didStartProvisionalLoadForFrame):
(_didReceiveServerRedirectForProvisionalLoadForFrame):
(_didFailProvisionalLoadWithErrorForFrame):
(_didCommitLoadForFrame):
(_didFinishLoadForFrame):
(_didFailLoadWithErrorForFrame):
(_didReceiveTitleForFrame):
(_didClearWindow):
(_didCreatePage):
(_willDestroyPage):
(_didRecieveMessage):
(WKBundleInitialize):

  • WebKitTestRunner/Makefile: Added.
  • WebKitTestRunner/PlatformWebView.h: Added.

(WTR::PlatformWebView::platformView):

  • WebKitTestRunner/TestController.cpp: Added.

(WTR::TestController::shared):
(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::runTest):
(WTR::TestController::runTestingServerLoop):
(WTR::TestController::run):

  • WebKitTestRunner/TestController.h: Added.

(WTR::TestController::verbose):
(WTR::TestController::injectedBundlePath):

  • WebKitTestRunner/TestInvocation.cpp: Added.

(WTR::createWKURL):
(WTR::TestInvocation::TestInvocation):
(WTR::TestInvocation::~TestInvocation):
(WTR::TestInvocation::invoke):
(WTR::TestInvocation::dump):
(WTR::TestInvocation::initializeMainWebView):
(WTR::TestInvocation::didStartProvisionalLoadForFrame):
(WTR::TestInvocation::didReceiveServerRedirectForProvisionalLoadForFrame):
(WTR::TestInvocation::didFailProvisionalLoadWithErrorForFrame):
(WTR::TestInvocation::didCommitLoadForFrame):
(WTR::TestInvocation::didFinishLoadForFrame):
(WTR::TestInvocation::didFailLoadForFrame):
(WTR::TestInvocation::renderTreeExternalRepresentationFunction):
(WTR::TestInvocation::renderTreeExternalRepresentationDisposeFunction):

  • WebKitTestRunner/TestInvocation.h: Added.
  • WebKitTestRunner/WebKitTestRunner.xcodeproj: Added.
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added.
  • WebKitTestRunner/WebKitTestRunnerPrefix.h: Added.
  • WebKitTestRunner/mac: Added.
  • WebKitTestRunner/mac/PlatformWebViewMac.mm: Added.

(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::~PlatformWebView):
(WTR::PlatformWebView::page):

  • WebKitTestRunner/mac/TestInvocationMac.mm: Added.

(WTR::TestInvocation::runUntil):

  • WebKitTestRunner/mac/main.mm: Added.

(main):

10:01 AM Changeset in webkit [61768] by ap@apple.com
  • 10 edits
    1 add in trunk/WebCore

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=41099
Assertion failure: !m_suspended when XMLHttpRequest fails

This was a general problem with load failure timer not being deferred.

Test: manual-tests/xhr-failure-behind-alert.html

  • manual-tests/xhr-failure-behind-alert.html: Added.
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::fireFailure): Added an empty case for NoFailure. Reset m_scheduledFailureType to NoFailure when firing. (WebCore::ResourceHandle::setDefersLoading): Stop failure timer when deferring, restart when un-deferring loads.
  • platform/network/ResourceHandle.h: Renamed m_failureType to m_scheduledFailureType to make it clear that it is only set when a timer is scheduled.
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal): Initialize m_scheduledFailureType to NoFailure, so that we can look at it when un-deferring loads.
  • platform/network/android/ResourceHandleAndroid.cpp: (WebCore::ResourceHandle::platformSetDefersLoading):
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::platformSetDefersLoading):
  • platform/network/curl/ResourceHandleCurl.cpp: (WebCore::ResourceHandle::platformSetDefersLoading):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::platformSetDefersLoading):
  • platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::platformSetDefersLoading):
  • platform/network/soup/ResourceHandleSoup.cpp: Platform specific parts of setDefersLoading() are now in a separate function.
9:30 AM Changeset in webkit [61767] by pfeldman@chromium.org
  • 23 edits
    1 copy
    1 add in trunk

2010-06-24 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: revert 61766.

9:02 AM Changeset in webkit [61766] by pfeldman@chromium.org
  • 23 edits
    2 deletes in trunk

2010-06-23 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Inspector cleanup + better DevTools alignment with Inspector.


​https://bugs.webkit.org/show_bug.cgi?id=41094

  • Removed a bunch of unused methods from all over the place
  • Added client callbacks for states surviving navigation
  • Implemented more user-friendly stub for InspectorFrontendHost.platform
  • inspector/InspectorClient.h: (WebCore::InspectorClient::resourceTrackingWasEnabled): (WebCore::InspectorClient::resourceTrackingWasDisabled): (WebCore::InspectorClient::timelineProfilerWasStarted): (WebCore::InspectorClient::timelineProfilerWasStopped):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::enableResourceTracking): (WebCore::InspectorController::disableResourceTracking): (WebCore::InspectorController::ensureSettingsLoaded): (WebCore::InspectorController::startTimelineProfiler): (WebCore::InspectorController::stopTimelineProfiler):
  • inspector/InspectorFrontend.cpp:
  • inspector/InspectorFrontend.h:
  • inspector/front-end/InspectorBackendStub.js:
  • inspector/front-end/InspectorFrontendHostStub.js: (.WebInspector.InspectorFrontendHostStub.prototype.platform):

2010-06-23 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Inspector cleanup + better DevTools alignment with Inspector.


​https://bugs.webkit.org/show_bug.cgi?id=41094

  • Merged InspectorClient implementation into WebDevToolsAgent
  • Changed the way WebDevToolsAgent is initialized (will break chromium bot, needs coordinated landing)
  • Removed a lot of legacy code from WebDevToolsAgentImpl
  • Removed a lot of overrides from DevTools.js
  • Simplified devtools stubs
  • Got rid of all logic from within InjectDispatch.js
  • WebKit.gyp:
  • public/WebDevToolsAgent.h:
  • public/WebView.h:
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidCommitLoad):
  • src/InspectorFrontendClientImpl.cpp: (WebKit::InspectorFrontendClientImpl::inspectedURLChanged):
  • src/ToolsAgent.h:
  • src/WebDevToolsAgentImpl.cpp: (WebKit::): (WebKit::WebDevToolsAgentImpl::initDevToolsAgentHost): (WebKit::WebDevToolsAgentImpl::setApuAgentEnabled): (WebKit::WebDevToolsAgentImpl::jsDispatchOnClient): (WebKit::WebDevToolsAgentImpl::inspectorDestroyed): (WebKit::WebDevToolsAgentImpl::openInspectorFrontend): (WebKit::WebDevToolsAgentImpl::highlight): (WebKit::WebDevToolsAgentImpl::hideHighlight): (WebKit::WebDevToolsAgentImpl::populateSetting): (WebKit::WebDevToolsAgentImpl::storeSetting): (WebKit::WebDevToolsAgentImpl::sendMessageToFrontend): (WebKit::WebDevToolsAgentImpl::resourceTrackingWasEnabled): (WebKit::WebDevToolsAgentImpl::resourceTrackingWasDisabled): (WebKit::WebDevToolsAgentImpl::timelineProfilerWasStarted): (WebKit::WebDevToolsAgentImpl::timelineProfilerWasStopped):
  • src/WebDevToolsAgentImpl.h:
  • src/WebDevToolsAgentPrivate.h:
  • src/WebViewImpl.cpp: (WebKit::WebView::create): (WebKit::WebViewImpl::WebViewImpl):
  • src/WebViewImpl.h:
  • src/WebWorkerBase.cpp: (WebKit::WebWorkerBase::initializeLoader):
  • src/js/DevTools.js: (devtools.ToolsAgent): (): (devtools):
  • src/js/DevToolsHostStub.js: (.window.setDebuggerScriptSource): (.window.dispatchOnInjectedScript):
  • src/js/InjectDispatch.js: (dispatch):
  • src/js/InspectorControllerImpl.js:
9:00 AM Changeset in webkit [61765] by luiz@webkit.org
  • 2 edits in trunk/WebKitTools

Unreviewed. Adding myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
8:46 AM Changeset in webkit [61764] by pfeldman@chromium.org
  • 145 edits
    26 adds
    24 deletes in trunk/LayoutTests

2010-06-24 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: rebaseline images for r61759 and r61762.

  • platform/chromium-linux/svg/text/selection-doubleclick-expected.checksum:
  • platform/chromium-linux/svg/text/selection-doubleclick-expected.png:
  • platform/chromium-linux/svg/text/selection-tripleclick-expected.checksum:
  • platform/chromium-linux/svg/text/selection-tripleclick-expected.png:
  • platform/chromium-linux/svg/text/text-align-01-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-align-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-align-02-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-align-02-b-expected.png:
  • platform/chromium-linux/svg/text/text-align-03-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-align-03-b-expected.png:
  • platform/chromium-linux/svg/text/text-align-04-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-align-04-b-expected.png:
  • platform/chromium-linux/svg/text/text-align-05-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-align-05-b-expected.png:
  • platform/chromium-linux/svg/text/text-align-06-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-align-06-b-expected.png:
  • platform/chromium-linux/svg/text/text-altglyph-01-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-altglyph-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-deco-01-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-deco-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-fonts-01-t-expected.checksum:
  • platform/chromium-linux/svg/text/text-fonts-01-t-expected.png:
  • platform/chromium-linux/svg/text/text-fonts-02-t-expected.checksum:
  • platform/chromium-linux/svg/text/text-fonts-02-t-expected.png:
  • platform/chromium-linux/svg/text/text-intro-05-t-expected.checksum:
  • platform/chromium-linux/svg/text/text-intro-05-t-expected.png:
  • platform/chromium-linux/svg/text/text-path-01-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-path-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-spacing-01-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-spacing-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-text-01-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-text-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-text-03-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-text-03-b-expected.png:
  • platform/chromium-linux/svg/text/text-text-04-t-expected.checksum:
  • platform/chromium-linux/svg/text/text-text-04-t-expected.png:
  • platform/chromium-linux/svg/text/text-text-05-t-expected.checksum:
  • platform/chromium-linux/svg/text/text-text-05-t-expected.png:
  • platform/chromium-linux/svg/text/text-text-06-t-expected.checksum:
  • platform/chromium-linux/svg/text/text-text-06-t-expected.png:
  • platform/chromium-linux/svg/text/text-text-07-t-expected.checksum:
  • platform/chromium-linux/svg/text/text-text-07-t-expected.png:
  • platform/chromium-linux/svg/text/text-text-08-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-text-08-b-expected.png:
  • platform/chromium-linux/svg/text/text-tref-01-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-tref-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-tselect-01-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-tselect-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-tselect-02-f-expected.checksum:
  • platform/chromium-linux/svg/text/text-tselect-02-f-expected.png:
  • platform/chromium-linux/svg/text/text-tspan-01-b-expected.checksum:
  • platform/chromium-linux/svg/text/text-tspan-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-ws-01-t-expected.checksum:
  • platform/chromium-linux/svg/text/text-ws-01-t-expected.png:
  • platform/chromium-linux/svg/text/text-ws-02-t-expected.checksum:
  • platform/chromium-linux/svg/text/text-ws-02-t-expected.png:
  • platform/chromium-linux/svg/text/textPathBoundsBug-expected.checksum:
  • platform/chromium-mac/svg/text/selection-doubleclick-expected.checksum:
  • platform/chromium-mac/svg/text/selection-doubleclick-expected.png: Removed.
  • platform/chromium-mac/svg/text/selection-tripleclick-expected.checksum:
  • platform/chromium-mac/svg/text/selection-tripleclick-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-align-01-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-align-01-b-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-align-02-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-align-02-b-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-align-03-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-align-03-b-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-align-04-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-align-04-b-expected.png:
  • platform/chromium-mac/svg/text/text-align-05-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-align-05-b-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-align-06-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-align-06-b-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-altglyph-01-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-altglyph-01-b-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-deco-01-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-deco-01-b-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-fonts-01-t-expected.checksum:
  • platform/chromium-mac/svg/text/text-fonts-01-t-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-fonts-02-t-expected.checksum:
  • platform/chromium-mac/svg/text/text-fonts-02-t-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-path-01-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-path-01-b-expected.png:
  • platform/chromium-mac/svg/text/text-spacing-01-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-spacing-01-b-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-text-01-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-text-01-b-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-text-03-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-text-03-b-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-text-04-t-expected.checksum:
  • platform/chromium-mac/svg/text/text-text-04-t-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-text-06-t-expected.checksum:
  • platform/chromium-mac/svg/text/text-text-06-t-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-text-07-t-expected.checksum:
  • platform/chromium-mac/svg/text/text-text-07-t-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-text-08-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-text-08-b-expected.png:
  • platform/chromium-mac/svg/text/text-tref-01-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-tref-01-b-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-tselect-01-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-tselect-01-b-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-tselect-02-f-expected.checksum:
  • platform/chromium-mac/svg/text/text-tselect-02-f-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-tspan-01-b-expected.checksum:
  • platform/chromium-mac/svg/text/text-tspan-01-b-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-ws-01-t-expected.checksum:
  • platform/chromium-mac/svg/text/text-ws-01-t-expected.png: Removed.
  • platform/chromium-mac/svg/text/text-ws-02-t-expected.checksum:
  • platform/chromium-mac/svg/text/text-ws-02-t-expected.png: Removed.
  • platform/chromium-mac/svg/text/textPathBoundsBug-expected.checksum:
  • platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug1430-expected.checksum.
  • platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug14929-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug14929-expected.checksum.
  • platform/chromium-mac/tables/mozilla/bugs/bug23235-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug23235-expected.checksum.
  • platform/chromium-mac/tables/mozilla/bugs/bug23235-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/bugs/bug2981-2-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug2981-2-expected.checksum.
  • platform/chromium-mac/tables/mozilla/bugs/bug4427-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug4427-expected.checksum.
  • platform/chromium-mac/tables/mozilla/bugs/bug6404-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug6404-expected.checksum.
  • platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum.
  • platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png: Added.
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum.
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum.
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/marvin/tbody_valign_middle-expected.checksum.
  • platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/marvin/tbody_valign_top-expected.checksum.
  • platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/marvin/td_valign_baseline-expected.checksum.
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum.
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum.
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum.
  • platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/marvin/tfoot_valign_top-expected.checksum.
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/marvin/thead_valign_baseline-expected.checksum.
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/marvin/thead_valign_bottom-expected.checksum.
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/marvin/thead_valign_middle-expected.checksum.
  • platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/marvin/thead_valign_top-expected.checksum.
  • platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla/marvin/tr_valign_baseline-expected.checksum.
  • platform/chromium-mac/tables/mozilla_expected_failures/bugs/97619-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/97619-expected.checksum.
  • platform/chromium-win-xp/svg/text/text-fonts-01-t-expected.checksum:
  • platform/chromium-win-xp/svg/text/text-fonts-01-t-expected.png: Removed.
  • platform/chromium-win/svg/text/selection-doubleclick-expected.checksum:
  • platform/chromium-win/svg/text/selection-doubleclick-expected.png:
  • platform/chromium-win/svg/text/selection-tripleclick-expected.checksum:
  • platform/chromium-win/svg/text/selection-tripleclick-expected.png:
  • platform/chromium-win/svg/text/text-align-01-b-expected.checksum:
  • platform/chromium-win/svg/text/text-align-01-b-expected.png:
  • platform/chromium-win/svg/text/text-align-02-b-expected.checksum:
  • platform/chromium-win/svg/text/text-align-02-b-expected.png:
  • platform/chromium-win/svg/text/text-align-03-b-expected.checksum:
  • platform/chromium-win/svg/text/text-align-03-b-expected.png:
  • platform/chromium-win/svg/text/text-align-04-b-expected.checksum:
  • platform/chromium-win/svg/text/text-align-04-b-expected.png:
  • platform/chromium-win/svg/text/text-align-05-b-expected.checksum:
  • platform/chromium-win/svg/text/text-align-05-b-expected.png:
  • platform/chromium-win/svg/text/text-align-06-b-expected.checksum:
  • platform/chromium-win/svg/text/text-align-06-b-expected.png:
  • platform/chromium-win/svg/text/text-altglyph-01-b-expected.checksum:
  • platform/chromium-win/svg/text/text-altglyph-01-b-expected.png:
  • platform/chromium-win/svg/text/text-deco-01-b-expected.checksum:
  • platform/chromium-win/svg/text/text-deco-01-b-expected.png:
  • platform/chromium-win/svg/text/text-fonts-01-t-expected.checksum:
  • platform/chromium-win/svg/text/text-fonts-01-t-expected.png:
  • platform/chromium-win/svg/text/text-fonts-02-t-expected.checksum:
  • platform/chromium-win/svg/text/text-fonts-02-t-expected.png:
  • platform/chromium-win/svg/text/text-intro-05-t-expected.checksum:
  • platform/chromium-win/svg/text/text-intro-05-t-expected.png:
  • platform/chromium-win/svg/text/text-path-01-b-expected.checksum:
  • platform/chromium-win/svg/text/text-path-01-b-expected.png:
  • platform/chromium-win/svg/text/text-spacing-01-b-expected.checksum:
  • platform/chromium-win/svg/text/text-spacing-01-b-expected.png:
  • platform/chromium-win/svg/text/text-text-01-b-expected.checksum:
  • platform/chromium-win/svg/text/text-text-01-b-expected.png:
  • platform/chromium-win/svg/text/text-text-03-b-expected.checksum:
  • platform/chromium-win/svg/text/text-text-03-b-expected.png:
  • platform/chromium-win/svg/text/text-text-04-t-expected.checksum:
  • platform/chromium-win/svg/text/text-text-04-t-expected.png:
  • platform/chromium-win/svg/text/text-text-06-t-expected.checksum:
  • platform/chromium-win/svg/text/text-text-06-t-expected.png:
  • platform/chromium-win/svg/text/text-text-07-t-expected.checksum:
  • platform/chromium-win/svg/text/text-text-07-t-expected.png:
  • platform/chromium-win/svg/text/text-text-08-b-expected.checksum:
  • platform/chromium-win/svg/text/text-text-08-b-expected.png:
  • platform/chromium-win/svg/text/text-tref-01-b-expected.checksum:
  • platform/chromium-win/svg/text/text-tref-01-b-expected.png:
  • platform/chromium-win/svg/text/text-tselect-01-b-expected.checksum:
  • platform/chromium-win/svg/text/text-tselect-01-b-expected.png:
  • platform/chromium-win/svg/text/text-tselect-02-f-expected.checksum:
  • platform/chromium-win/svg/text/text-tselect-02-f-expected.png:
  • platform/chromium-win/svg/text/text-tspan-01-b-expected.checksum:
  • platform/chromium-win/svg/text/text-tspan-01-b-expected.png:
  • platform/chromium-win/svg/text/text-ws-01-t-expected.checksum:
  • platform/chromium-win/svg/text/text-ws-01-t-expected.png:
  • platform/chromium-win/svg/text/text-ws-02-t-expected.checksum:
  • platform/chromium-win/svg/text/text-ws-02-t-expected.png:
  • platform/chromium-win/svg/text/textPathBoundsBug-expected.checksum:
  • platform/chromium-win/svg/text/textPathBoundsBug-expected.png:
8:09 AM Changeset in webkit [61763] by leandro@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-24 Leandro Pereira <​leandro@profusion.mobi>

Unreviewed build fix.

  • CMakeLists.txt: Add JSParser.cpp.
7:41 AM Changeset in webkit [61762] by Adam Roben
  • 3 edits
    1 copy
    1 add in trunk/WebKit2

Windows build fix

Fixes <​http://webkit.org/b/41158>.

Reviewed by Anders Carlsson.

  • Shared/win/UpdateChunk.cpp: Updated header name.
  • UIProcess/Plugins/win/PluginInfoStoreWin.cpp: Added.

(WebKit::PluginInfoStore::pluginDirectories):
(WebKit::PluginInfoStore::pluginPathsInDirectory):
(WebKit::PluginInfoStore::getPluginInfo):
(WebKit::PluginInfoStore::shouldUsePlugin):
Stubbed these out.

  • win/WebKit2.vcproj: Added UIProcess/Plugins to the include path for

all configurations. Added UIProcess/Plugins files to the project.

6:46 AM Changeset in webkit [61761] by senorblanco@chromium.org
  • 394 edits
    1 add
    3 deletes in trunk/LayoutTests

2010-06-23 Stephen White <​senorblanco@chromium.org>

Unreviewed; expectations fix.

This updates the pixel test baselines after r61710, and removes
them from test_expectations.txt.

  • platform/chromium-linux/css2.1/t090501-c414-flt-03-b-g-expected.checksum:
  • platform/chromium-linux/css2.1/t090501-c414-flt-03-b-g-expected.png:
  • platform/chromium-linux/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum:
  • platform/chromium-linux/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-linux/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum:
  • platform/chromium-linux/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize11-expected.checksum: Removed.
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize15-expected.checksum:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize16-expected.checksum:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize16-expected.png:
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize19-expected.checksum: Removed.
  • platform/chromium-linux/fast/backgrounds/size/backgroundSize22-expected.checksum: Removed.
  • platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.checksum: Added.
  • platform/chromium-linux/fast/css/value-list-out-of-bounds-crash-expected.checksum:
  • platform/chromium-linux/fast/events/pointer-events-2-expected.checksum:
  • platform/chromium-linux/fast/events/pointer-events-2-expected.png:
  • platform/chromium-linux/fast/forms/input-type-change-expected.checksum:
  • platform/chromium-linux/fast/forms/input-type-change-expected.png:
  • platform/chromium-linux/fast/replaced/absolute-image-sizing-expected.checksum:
  • platform/chromium-linux/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-linux/fast/replaced/image-sizing-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug101674-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug101674-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug11026-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug14929-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug14929-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug15544-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug2981-2-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug2981-2-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4093-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug4284-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug4427-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug56563-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug625-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-linux/tables/mozilla/bugs/bug6404-expected.checksum:
  • platform/chromium-linux/tables/mozilla/bugs/bug6404-expected.png:
  • platform/chromium-linux/tables/mozilla/core/bloomberg-expected.checksum:
  • platform/chromium-linux/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum:
  • platform/chromium-linux/tables/mozilla/core/misc-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_middle-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tbody_valign_top-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.checksum:
  • platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.checksum:
  • platform/chromium-linux/tables/mozilla/other/cell_widths-expected.checksum:
  • platform/chromium-linux/tables/mozilla/other/cell_widths-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/97619-expected.checksum:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/97619-expected.png:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum:
  • platform/chromium-win/css2.1/t090501-c414-flt-03-b-g-expected.checksum:
  • platform/chromium-win/css2.1/t090501-c414-flt-03-b-g-expected.png:
  • platform/chromium-win/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum:
  • platform/chromium-win/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/chromium-win/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum:
  • platform/chromium-win/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize01-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize01-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize02-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize02-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize04-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize04-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize05-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize05-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize06-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize06-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize07-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize07-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize08-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize08-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize09-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize09-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize10-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize10-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize11-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize11-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize12-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize12-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize13-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize13-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize14-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize14-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize15-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize15-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize16-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize16-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize17-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize17-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize18-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize18-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize19-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize19-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize20-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize20-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize21-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize21-expected.png:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.checksum:
  • platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.png:
  • platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.checksum:
  • platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/chromium-win/fast/css/value-list-out-of-bounds-crash-expected.checksum:
  • platform/chromium-win/fast/css/value-list-out-of-bounds-crash-expected.png:
  • platform/chromium-win/fast/events/pointer-events-2-expected.checksum:
  • platform/chromium-win/fast/events/pointer-events-2-expected.png:
  • platform/chromium-win/fast/forms/input-type-change-expected.checksum:
  • platform/chromium-win/fast/forms/input-type-change-expected.png:
  • platform/chromium-win/fast/replaced/absolute-image-sizing-expected.checksum:
  • platform/chromium-win/fast/replaced/absolute-image-sizing-expected.png:
  • platform/chromium-win/fast/replaced/image-sizing-expected.checksum:
  • platform/chromium-win/fast/replaced/image-sizing-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug101674-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug101674-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug11026-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug11026-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1188-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug1188-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1296-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug1430-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug14929-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug14929-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug15544-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug15544-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug2981-2-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug2981-2-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4093-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug4093-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4284-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug4284-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug4427-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug4427-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug56563-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug56563-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug625-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug625-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug6404-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug6404-expected.png:
  • platform/chromium-win/tables/mozilla/bugs/bug97383-expected.checksum:
  • platform/chromium-win/tables/mozilla/bugs/bug97383-expected.png:
  • platform/chromium-win/tables/mozilla/core/bloomberg-expected.checksum:
  • platform/chromium-win/tables/mozilla/core/bloomberg-expected.png:
  • platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum:
  • platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/chromium-win/tables/mozilla/core/misc-expected.checksum:
  • platform/chromium-win/tables/mozilla/core/misc-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.checksum:
  • platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/chromium-win/tables/mozilla/other/cell_widths-expected.checksum:
  • platform/chromium-win/tables/mozilla/other/cell_widths-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/97619-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/97619-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/mac/css2.1/t0804-c5510-padn-00-b-ag-expected.checksum:
  • platform/mac/css2.1/t0804-c5510-padn-00-b-ag-expected.png:
  • platform/mac/css2.1/t0905-c414-flt-01-d-g-expected.checksum:
  • platform/mac/css2.1/t0905-c414-flt-01-d-g-expected.png:
  • platform/mac/css2.1/t090501-c414-flt-02-d-g-expected.checksum:
  • platform/mac/css2.1/t090501-c414-flt-02-d-g-expected.png:
  • platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.checksum:
  • platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.png:
  • platform/mac/css2.1/t090501-c414-flt-ln-01-d-g-expected.checksum:
  • platform/mac/css2.1/t090501-c414-flt-ln-01-d-g-expected.png:
  • platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum:
  • platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
  • platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum:
  • platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
  • platform/mac/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.checksum:
  • platform/mac/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.png:
  • platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.checksum:
  • platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.png:
  • platform/mac/css2.1/t1004-c5524-width-00-b-g-expected.checksum:
  • platform/mac/css2.1/t1004-c5524-width-00-b-g-expected.png:
  • platform/mac/css2.1/t100801-c544-valgn-02-d-agi-expected.checksum:
  • platform/mac/css2.1/t100801-c544-valgn-02-d-agi-expected.png:
  • platform/mac/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum:
  • platform/mac/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
  • platform/mac/css2.1/t100801-c544-valgn-04-d-agi-expected.checksum:
  • platform/mac/css2.1/t100801-c544-valgn-04-d-agi-expected.png:
  • platform/mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.checksum:
  • platform/mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize01-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize01-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize05-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize05-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize06-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize06-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize07-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize07-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize08-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize08-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize09-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize09-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize10-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize10-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize11-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize11-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize12-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize12-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize16-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize16-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize17-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize17-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize18-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize18-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize19-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize19-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize20-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize20-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize21-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize21-expected.png:
  • platform/mac/fast/backgrounds/size/backgroundSize22-expected.checksum:
  • platform/mac/fast/backgrounds/size/backgroundSize22-expected.png:
  • platform/mac/fast/backgrounds/size/zero-expected.checksum:
  • platform/mac/fast/backgrounds/size/zero-expected.png:
  • platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.checksum:
  • platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
  • platform/mac/fast/canvas/canvas-as-image-expected.checksum:
  • platform/mac/fast/canvas/canvas-as-image-expected.png:
  • platform/mac/fast/css/value-list-out-of-bounds-crash-expected.checksum:
  • platform/mac/fast/css/value-list-out-of-bounds-crash-expected.png:
  • platform/mac/fast/forms/input-type-change-expected.checksum:
  • platform/mac/fast/forms/input-type-change-expected.png:
  • platform/mac/fast/replaced/001-expected.checksum:
  • platform/mac/fast/replaced/001-expected.png:
  • platform/mac/fast/replaced/002-expected.checksum:
  • platform/mac/fast/replaced/002-expected.png:
  • platform/mac/fast/replaced/003-expected.checksum:
  • platform/mac/fast/replaced/003-expected.png:
  • platform/mac/fast/replaced/absolute-image-sizing-expected.checksum:
  • platform/mac/fast/replaced/absolute-image-sizing-expected.png:
  • platform/mac/fast/replaced/image-sizing-expected.checksum:
  • platform/mac/fast/replaced/image-sizing-expected.png:
  • platform/mac/tables/mozilla/bugs/bug11026-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug11026-expected.png:
  • platform/mac/tables/mozilla/bugs/bug1188-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug1188-expected.png:
  • platform/mac/tables/mozilla/bugs/bug1296-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug1296-expected.png:
  • platform/mac/tables/mozilla/bugs/bug1430-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug1430-expected.png:
  • platform/mac/tables/mozilla/bugs/bug14929-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug14929-expected.png:
  • platform/mac/tables/mozilla/bugs/bug15544-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug15544-expected.png:
  • platform/mac/tables/mozilla/bugs/bug23235-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug23235-expected.png:
  • platform/mac/tables/mozilla/bugs/bug2981-2-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug2981-2-expected.png:
  • platform/mac/tables/mozilla/bugs/bug4093-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug4093-expected.png:
  • platform/mac/tables/mozilla/bugs/bug4284-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug4284-expected.png:
  • platform/mac/tables/mozilla/bugs/bug4427-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug4427-expected.png:
  • platform/mac/tables/mozilla/bugs/bug4523-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug4523-expected.png:
  • platform/mac/tables/mozilla/bugs/bug56563-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug56563-expected.png:
  • platform/mac/tables/mozilla/bugs/bug6404-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug6404-expected.png:
  • platform/mac/tables/mozilla/bugs/bug86708-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug86708-expected.png:
  • platform/mac/tables/mozilla/bugs/bug97383-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug97383-expected.png:
  • platform/mac/tables/mozilla/core/col_widths_auto_autoFix-expected.checksum:
  • platform/mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
  • platform/mac/tables/mozilla/core/misc-expected.checksum:
  • platform/mac/tables/mozilla/core/misc-expected.png:
  • platform/mac/tables/mozilla/marvin/tbody_valign_baseline-expected.checksum:
  • platform/mac/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
  • platform/mac/tables/mozilla/marvin/tbody_valign_bottom-expected.checksum:
  • platform/mac/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
  • platform/mac/tables/mozilla/marvin/tbody_valign_middle-expected.checksum:
  • platform/mac/tables/mozilla/marvin/tbody_valign_middle-expected.png:
  • platform/mac/tables/mozilla/marvin/tbody_valign_top-expected.checksum:
  • platform/mac/tables/mozilla/marvin/tbody_valign_top-expected.png:
  • platform/mac/tables/mozilla/marvin/td_valign_baseline-expected.checksum:
  • platform/mac/tables/mozilla/marvin/td_valign_baseline-expected.png:
  • platform/mac/tables/mozilla/marvin/td_valign_bottom-expected.checksum:
  • platform/mac/tables/mozilla/marvin/td_valign_bottom-expected.png:
  • platform/mac/tables/mozilla/marvin/td_valign_middle-expected.checksum:
  • platform/mac/tables/mozilla/marvin/td_valign_middle-expected.png:
  • platform/mac/tables/mozilla/marvin/td_valign_top-expected.checksum:
  • platform/mac/tables/mozilla/marvin/td_valign_top-expected.png:
  • platform/mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.checksum:
  • platform/mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
  • platform/mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.checksum:
  • platform/mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
  • platform/mac/tables/mozilla/marvin/tfoot_valign_middle-expected.checksum:
  • platform/mac/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
  • platform/mac/tables/mozilla/marvin/tfoot_valign_top-expected.checksum:
  • platform/mac/tables/mozilla/marvin/tfoot_valign_top-expected.png:
  • platform/mac/tables/mozilla/marvin/th_valign_baseline-expected.checksum:
  • platform/mac/tables/mozilla/marvin/th_valign_baseline-expected.png:
  • platform/mac/tables/mozilla/marvin/th_valign_bottom-expected.checksum:
  • platform/mac/tables/mozilla/marvin/th_valign_bottom-expected.png:
  • platform/mac/tables/mozilla/marvin/th_valign_middle-expected.checksum:
  • platform/mac/tables/mozilla/marvin/th_valign_middle-expected.png:
  • platform/mac/tables/mozilla/marvin/th_valign_top-expected.checksum:
  • platform/mac/tables/mozilla/marvin/th_valign_top-expected.png:
  • platform/mac/tables/mozilla/marvin/thead_valign_baseline-expected.checksum:
  • platform/mac/tables/mozilla/marvin/thead_valign_baseline-expected.png:
  • platform/mac/tables/mozilla/marvin/thead_valign_bottom-expected.checksum:
  • platform/mac/tables/mozilla/marvin/thead_valign_bottom-expected.png:
  • platform/mac/tables/mozilla/marvin/thead_valign_middle-expected.checksum:
  • platform/mac/tables/mozilla/marvin/thead_valign_middle-expected.png:
  • platform/mac/tables/mozilla/marvin/thead_valign_top-expected.checksum:
  • platform/mac/tables/mozilla/marvin/thead_valign_top-expected.png:
  • platform/mac/tables/mozilla/marvin/tr_valign_baseline-expected.checksum:
  • platform/mac/tables/mozilla/marvin/tr_valign_baseline-expected.png:
  • platform/mac/tables/mozilla/marvin/tr_valign_bottom-expected.checksum:
  • platform/mac/tables/mozilla/marvin/tr_valign_bottom-expected.png:
  • platform/mac/tables/mozilla/marvin/tr_valign_middle-expected.checksum:
  • platform/mac/tables/mozilla/marvin/tr_valign_middle-expected.png:
  • platform/mac/tables/mozilla/marvin/tr_valign_top-expected.checksum:
  • platform/mac/tables/mozilla/marvin/tr_valign_top-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/97619-expected.checksum:
  • platform/mac/tables/mozilla_expected_failures/bugs/97619-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug6933-expected.checksum:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
5:57 AM Changeset in webkit [61760] by tkent@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed. Build fix for Tiger.

  • platform/mac/ThemeMac.mm:

(WebCore::setControlSize):

5:38 AM Changeset in webkit [61759] by Nikolas Zimmermann
  • 15 edits in trunk/WebCore

2010-06-24 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Inspector & SVG Text have problems, kids of RenderSVGText are not properly placed.
​https://bugs.webkit.org/show_bug.cgi?id=41143

Simplify code path taken for SVG text in InspectorController, take the code path currently only used for RenderInline,
that just calls absoluteQuads(), and displays the result. Refactored code that all SVG renderers (except RenderSVGRoot)
take this code path -> highlighting now works as expected.

Don't use absoluteClippedOverlowRect() in the various RenderSVG*::absoluteQuads() methods, as we're loosing floating-point precision.
Instead use localToAbsoluteQuad(strokeBoundingBox()) in order to highlight the unclipped, unfiltered, etc.. region that this renderer would paint.

No new tests, as this is only manual testable - at least I didn't find any Inspector-Highlighting tests, if someone knows please mail me.

  • inspector/InspectorController.cpp: (WebCore::drawHighlightForLineBoxesOrSVGRenderer): (WebCore::InspectorController::drawNodeHighlight):
  • rendering/RenderSVGBlock.cpp: (WebCore::RenderSVGBlock::absoluteRects): ASSERT_NOT_REACHED() here. SVG should only be inspected through absoluteQuads().
  • rendering/RenderSVGBlock.h: Add absoluteRects() in this base class for RenderForeignObject/RenderSVGText.
  • rendering/RenderSVGHiddenContainer.cpp: Remove absoluteRects() - RenderSVGModelObject already has it.
  • rendering/RenderSVGHiddenContainer.h: Ditto.
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::absoluteRects): ASSERT_NOT_REACHED() here. (WebCore::RenderSVGImage::absoluteQuads): Don't use absoluteClippedOverlowRect() but localToAbsoluteQuad(repaintRectInLocalCoordinates()).
  • rendering/RenderSVGImage.h: (WebCore::RenderSVGImage::objectBoundingBox): Inlined
  • rendering/RenderSVGInline.cpp: (WebCore::RenderSVGInline::absoluteQuads): Take RenderSVGText translation into account, allows inspecting <tspan>/<tref> etc.
  • rendering/RenderSVGInline.h:
  • rendering/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::absoluteRects): ASSERT_NOT_REACHED() here. (WebCore::RenderSVGModelObject::absoluteQuads): Don't use absoluteClippedOverlowRect() but localToAbsoluteQuad(repaintRectInLocalCoordinates()).
  • rendering/RenderSVGModelObject.h:
  • rendering/RenderSVGRoot.cpp: Fix typo in license s/aint/along. Need to touch this file in order to let Mac build.
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::mapLocalToContainer): Remove hack, which moved the transformState by x()/y(). Not needed anymore. (WebCore::RenderSVGText::absoluteQuads): Proper implementation, respecting x/y translation.
  • rendering/RenderSVGText.h: Reorder some functions.
  • rendering/SVGRenderSupport.h: Removed last virtual function strokeBoundingBox().
5:36 AM Changeset in webkit [61758] by tkent@chromium.org
  • 2 edits in trunk/WebCore

2010-06-24 Kent Tamura <​tkent@chromium.org>

Unreviewed. Build fix for Tiger.

  • platform/mac/ThemeMac.mm: (WebCore::setControlSize): (WebCore::ThemeMac::inflateControlPaintRect):
5:24 AM Changeset in webkit [61757] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed typo fix after r61754.

  • platform/qt/Skipped:
5:02 AM Changeset in webkit [61756] by tkent@chromium.org
  • 2 edits in trunk/WebCore

2010-06-24 Kent Tamura <​tkent@chromium.org>

Unreviewed. Build fix for Chromium Mac.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isSpeechEnabled):
5:00 AM Changeset in webkit [61755] by Simon Hausmann
  • 4 edits in trunk

Unreviewed Symbian build fix.

The QML WebKit integration needs to be part of QtWebKit.sis

WebCore:

  • WebCore.pro: Deploy qmlwebkitplugin.dll.

WebKit/qt:

  • declarative/declarative.pro: Removed non-working deployment.
4:46 AM Changeset in webkit [61754] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Regression(r61749): inspector/debugger-pause-on-debugger-statement.html fails
​https://bugs.webkit.org/show_bug.cgi?id=41147

  • platform/qt/Skipped: inspector/debugger-pause-on-debugger-statement.html skipped.
  • platform/qt-linux/Skipped: revert last change, because we only use the general platform/qt/Skipped list.
4:32 AM Changeset in webkit [61753] by yurys@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-24 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed: disable new inspector test on Qt linux.

  • platform/qt-linux/Skipped:
3:40 AM Changeset in webkit [61752] by jorlow@chromium.org
  • 17 edits in trunk/WebCore

2010-06-24 Satish Sampath <​satish@chromium.org>

Reviewed by Kent Tamura.

Add a speech button to input elements, no rendering or actions yet.

Speech Input: Add a speech button to text input element (no rendering or actions yet)
​https://bugs.webkit.org/show_bug.cgi?id=40925

No new tests. Will create a layout test in a subsequent patch.

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/CSSValueKeywords.in:
  • css/html.css: (input::-webkit-input-speech-button):
  • dom/InputElement.h:
  • html/HTMLAttributeNames.in:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isSpeechEnabled):
  • html/HTMLInputElement.h:
  • platform/ThemeTypes.h: (WebCore::):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::nodeAtPoint): (WebCore::RenderTextControlSingleLine::forwardEvent): (WebCore::RenderTextControlSingleLine::styleDidChange): (WebCore::RenderTextControlSingleLine::hasControlClip): (WebCore::RenderTextControlSingleLine::controlClipRect): (WebCore::RenderTextControlSingleLine::textBlockWidth): (WebCore::RenderTextControlSingleLine::preferredContentWidth): (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight): (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded): (WebCore::RenderTextControlSingleLine::createSpeechButtonStyle): (WebCore::RenderTextControlSingleLine::clientPaddingRight):
  • rendering/RenderTextControlSingleLine.h:
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::paint): (WebCore::RenderTheme::paintBorderOnly): (WebCore::RenderTheme::paintDecorations):
  • rendering/TextControlInnerElements.cpp: (WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement): (WebCore::InputFieldSpeechButtonElement::create): (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
  • rendering/TextControlInnerElements.h:
  • rendering/style/RenderStyleConstants.h: (WebCore::):
3:07 AM Changeset in webkit [61751] by tkent@chromium.org
  • 5 edits
    4 adds in trunk

[Mac] The upper button of <input type=number> has no visual effect on click
​https://bugs.webkit.org/show_bug.cgi?id=38380

Reviewed by Adam Barth.

WebCore:

Because we have no ways to draw an NSStepperCell with its up button
highlighted, use HIThemeDrawButton() instead.

Test: platform/mac/fast/forms/input-appearance-spinbutton-up.html

  • platform/mac/ThemeMac.mm:

(WebCore::controlSizeFromPixelSize):

New function. Made from a part of setControlSize().

(WebCore::setControlSize):
(WebCore::convertControlStatesToThemeDrawState):
(WebCore::paintStepper): Use HITheme API instead of NSStepperCell.
(WebCore::ThemeMac::inflateControlPaintRect):

Use controlSizeFromPixelSize().

LayoutTests:

  • platform/mac/fast/forms/input-appearance-spinbutton-expected.checksum:
  • platform/mac/fast/forms/input-appearance-spinbutton-expected.png:
  • platform/mac/fast/forms/input-appearance-spinbutton-up-expected.checksum: Added.
  • platform/mac/fast/forms/input-appearance-spinbutton-up-expected.png: Added.
  • platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Added.
  • platform/mac/fast/forms/input-appearance-spinbutton-up.html: Added.
2:11 AM Changeset in webkit [61750] by oliver@apple.com
  • 5 edits in trunk

Single character string replacement may replace too many characters
​https://bugs.webkit.org/show_bug.cgi?id=41138
<rdar://problem/8097496>

Reviewed by Maciej Stachowiak.

Simple fix to stop the rope path of single character replacement
once the first replacement occurs.

  • runtime/JSString.cpp:

(JSC::JSString::replaceCharacter):

2:01 AM Changeset in webkit [61749] by yurys@chromium.org
  • 8 edits
    2 adds in trunk

2010-06-24 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: implement layout tests for debugger
​https://bugs.webkit.org/show_bug.cgi?id=40774

  • http/tests/inspector/inspector-test.js: (notifyDone): (frontend_showPanel): (frontend_addSniffer.receiver.methodName): (frontend_addSniffer): (frontend_createKeyEvent): (frontend_evaluateInConsole):
  • inspector/debugger-pause-on-debugger-statement-expected.txt: Added.
  • inspector/debugger-pause-on-debugger-statement.html: Added.

2010-06-24 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: implement layout tests for debugger
​https://bugs.webkit.org/show_bug.cgi?id=40774

Test: inspector/debugger-pause-on-debugger-statement.html

  • bindings/js/ScriptDebugServer.cpp: remove unused obsolete code that deals with global listeners. (WebCore::ScriptDebugServer::ScriptDebugServer): (WebCore::ScriptDebugServer::removeListener): (WebCore::ScriptDebugServer::dispatchFunctionToListeners): (WebCore::ScriptDebugServer::pauseIfNeeded): (WebCore::ScriptDebugServer::didAddListener): (WebCore::ScriptDebugServer::didRemoveListener):
  • bindings/js/ScriptDebugServer.h:
  • platform/mac/EventLoopMac.mm: (WebCore::EventLoop::cycle): wait at most 10ms for new event, otherwise layout tests would hang because in their case there may be no events ever.

2010-06-24 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: implement layout tests for debugger
​https://bugs.webkit.org/show_bug.cgi?id=40774

  • src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl):
1:57 AM Changeset in webkit [61748] by yurys@chromium.org
  • 6 edits
    3 adds in trunk

2010-06-24 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Added tests for representation of various JS values in console log.
​https://bugs.webkit.org/show_bug.cgi?id=40980

  • inspector/console-log-native-funcs-expected.txt: Added.
  • inspector/console-tests-expected.txt:
  • inspector/console-tests.html:
  • platform/chromium/inspector: Added.
  • platform/chromium/inspector/console-log-native-funcs-expected.txt: Added.

2010-06-24 Andrey Kosyakov <​caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Fixed evaluation & logging of null values in console.
Changed handling of null and undefined in ScriptValue::toString()
to match JSC bindings (i.e. "null" and "undefined" instead of "").
​https://bugs.webkit.org/show_bug.cgi?id=40980

  • bindings/v8/ScriptValue.cpp: (WebCore::ScriptValue::toString):
  • inspector/front-end/InjectedScript.js: (injectedScriptConstructor):
1:52 AM Changeset in webkit [61747] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-06-24 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: live edit doesn't work when resource tracking is off
​https://bugs.webkit.org/show_bug.cgi?id=41076

  • inspector/front-end/ScriptView.js: (WebInspector.ScriptView.prototype._sourceIDForLine): implement this method for ScriptView, it's needed for editLine to work.
12:51 AM Changeset in webkit [61746] by mjs@apple.com
  • 3 edits in trunk/LayoutTests

Update test results for IDL hidden attribute
(added for ​https://bugs.webkit.org/show_bug.cgi?id=41039)

Reviewed by Oliver.

  • fast/dom/domListEnumeration.html: Update some counts since the HTMLFormElement

and HTMLSelectElement interfaces now inherit the new hidden IDL attribute.

  • fast/dom/domListEnumeration-expected.txt:
12:48 AM Changeset in webkit [61745] by loki@webkit.org
  • 2 edits in trunk/JavaScriptCore

Fix the length of instruction stream controlled by constant pool
​https://bugs.webkit.org/show_bug.cgi?id=40293

Reviewed by Gavin Barraclough.

The initial/maximum length of instruction stream (m_maxDistance) should
be set when the first constant arrives to the constant pool. Otherwise
the constant pool could be placed into an uninterrupted sequence.

  • assembler/AssemblerBufferWithConstantPool.h:

(JSC::):

12:31 AM Changeset in webkit [61744] by aestes@apple.com
  • 1 edit
    10 adds in trunk/LayoutTests

Add additional tests for beforeload events.
​https://bugs.webkit.org/show_bug.cgi?id=41132

Reviewed by Alexey Proskuryakov.

Add tests to verify that the following elements can be removed from the
DOM during beforeload:

  • <object type="application/x-shockwave-flash">
  • <iframe>
  • <img>
  • <script src=""> (non-inline)
  • <video>
  • fast/dom/beforeload/remove-flash-in-beforeload-listener-expected.txt: Added.
  • fast/dom/beforeload/remove-flash-in-beforeload-listener.html: Added.
  • fast/dom/beforeload/remove-frame-in-beforeload-listener-expected.txt: Added.
  • fast/dom/beforeload/remove-frame-in-beforeload-listener.html: Added.
  • fast/dom/beforeload/remove-image-in-beforeload-listener-expected.txt: Added.
  • fast/dom/beforeload/remove-image-in-beforeload-listener.html: Added.
  • fast/dom/beforeload/remove-script-in-beforeload-listener-expected.txt: Added.
  • fast/dom/beforeload/remove-script-in-beforeload-listener.html: Added.
  • fast/dom/beforeload/remove-video-in-beforeload-listener-expected.txt: Added.
  • fast/dom/beforeload/remove-video-in-beforeload-listener.html: Added.
12:24 AM Changeset in webkit [61743] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix layout test failure

Reviewed by Gavin Barraclough.

We assume bytecodeOffset will always return a value > 1,
so we adjust the failure case to return 1 instead of 0.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::bytecodeOffset):

Jun 23, 2010:

11:52 PM Changeset in webkit [61742] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-06-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Sketch out InitialMode of HTML5 tree builder
​https://bugs.webkit.org/show_bug.cgi?id=41126

Transliterated from the spec. Currently doesn't do anything. Mostly
an experiment to see where this goes.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processToken): (WebCore::HTMLTreeBuilder::insertDoctype): (WebCore::HTMLTreeBuilder::insertComment):
  • html/HTMLTreeBuilder.h:
11:50 PM Changeset in webkit [61741] by aestes@apple.com
  • 11 edits in trunk/LayoutTests

Refactor beforeload layout tests to share a common implementation of
print() located in fast/dom/beforeload/resources/.
​https://bugs.webkit.org/show_bug.cgi?id=41127

Reviewed by Joseph Pecoraro.

  • fast/dom/beforeload/flash-before-load.html:
  • fast/dom/beforeload/frame-before-load.html:
  • fast/dom/beforeload/image-before-load.html:
  • fast/dom/beforeload/link-before-load.html:
  • fast/dom/beforeload/pi-before-load.xhtml:
  • fast/dom/beforeload/remove-link-in-beforeload-listener.html:
  • fast/dom/beforeload/script-before-load-dynamic.html:
  • fast/dom/beforeload/script-before-load-xhtml.xhtml:
  • fast/dom/beforeload/script-before-load.html:
  • fast/dom/beforeload/video-before-load.html:
11:41 PM Changeset in webkit [61740] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-06-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add all the HTML5 tree builder insertion modes
​https://bugs.webkit.org/show_bug.cgi?id=41124

These are just copied verbatim from the spec. No tests because these
don't do anything yet.

  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::passTokenToLegacyParser):
  • html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::):
11:30 PM Changeset in webkit [61739] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-23 Eric Seidel <​eric@webkit.org>

Unreviewed. Fix namespace indent. Just whitespace changes.

  • dom/DocumentParser.h: (WebCore::DocumentParser::~DocumentParser): (WebCore::DocumentParser::isExecutingScript): (WebCore::DocumentParser::stopParsing): (WebCore::DocumentParser::processingData): (WebCore::DocumentParser::wantsRawData): (WebCore::DocumentParser::writeRawData): (WebCore::DocumentParser::wellFormed): (WebCore::DocumentParser::lineNumber): (WebCore::DocumentParser::columnNumber): (WebCore::DocumentParser::executeScriptsWaitingForStylesheets): (WebCore::DocumentParser::htmlTreeBuilder): (WebCore::DocumentParser::asHTMLDocumentParser): (WebCore::DocumentParser::inViewSourceMode): (WebCore::DocumentParser::setInViewSourceMode): (WebCore::DocumentParser::document): (WebCore::DocumentParser::xssAuditor): (WebCore::DocumentParser::setXSSAuditor): (WebCore::DocumentParser::DocumentParser):
11:27 PM Changeset in webkit [61738] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-23 Eric Seidel <​eric@webkit.org>

Unreviewed. Speculative build fix for Qt.

Move Document* down onto DocumentParser, since every DocumentParser needs one.
​https://bugs.webkit.org/show_bug.cgi?id=41117

XMLDocumentParserQt is a huge pile of donkey barf.
I can't believe I ever r+'d the creation of this pile of
copy/paste code.

I clearly missed removing m_doc from this code as well and thus
broke Qt.

We really need to fix both XMLDocumentParserLibxml2 and
XMLDocumentParserQt not to be so poorly abstracted so
that if we're going to have two of them they can at least
share some code.

  • dom/XMLDocumentParserQt.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLDocumentParser::~XMLDocumentParser): (WebCore::XMLDocumentParser::doWrite): (WebCore::XMLDocumentParser::doEnd): (WebCore::XMLDocumentParser::parse): (WebCore::XMLDocumentParser::startDocument): (WebCore::XMLDocumentParser::parseStartElement): (WebCore::XMLDocumentParser::parseEndElement): (WebCore::XMLDocumentParser::parseProcessingInstruction): (WebCore::XMLDocumentParser::parseCdata): (WebCore::XMLDocumentParser::parseComment): (WebCore::XMLDocumentParser::parseDtd):
11:17 PM Changeset in webkit [61737] by eric@webkit.org
  • 15 edits in trunk/WebCore

2010-06-23 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Move Document* down onto DocumentParser, since every DocumentParser needs one.
​https://bugs.webkit.org/show_bug.cgi?id=41117

This eliminated the need for document() on HTMLDocumentParser.
This paves the way for more code sharing between various
DocumentParser subclasses.

  • dom/DocumentParser.h: (WebCore::DocumentParser::inViewSourceMode): (WebCore::DocumentParser::setInViewSourceMode): (WebCore::DocumentParser::document): (WebCore::DocumentParser::DocumentParser):
  • dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::isWMLDocument): (WebCore::XMLDocumentParser::pushCurrentNode): (WebCore::XMLDocumentParser::popCurrentNode): (WebCore::XMLDocumentParser::clearCurrentNodeStack): (WebCore::XMLDocumentParser::enterText): (WebCore::XMLDocumentParser::end): (WebCore::XMLDocumentParser::insertErrorMessageBlock):
  • dom/XMLDocumentParser.h:
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::XMLDocumentParser): (WebCore::XMLDocumentParser::~XMLDocumentParser): (WebCore::XMLDocumentParser::doWrite): (WebCore::XMLDocumentParser::startElementNs): (WebCore::XMLDocumentParser::endElementNs): (WebCore::XMLDocumentParser::processingInstruction): (WebCore::XMLDocumentParser::cdataBlock): (WebCore::XMLDocumentParser::comment): (WebCore::XMLDocumentParser::startDocument): (WebCore::XMLDocumentParser::internalSubset): (WebCore::XMLDocumentParser::initializeParserContext): (WebCore::XMLDocumentParser::doEnd):
  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::HTMLDocumentParser):
  • html/HTMLDocumentParser.h:
  • html/LegacyHTMLDocumentParser.cpp: (WebCore::LegacyHTMLDocumentParser::LegacyHTMLDocumentParser): (WebCore::LegacyHTMLDocumentParser::begin): (WebCore::LegacyHTMLDocumentParser::scriptHandler): (WebCore::LegacyHTMLDocumentParser::scriptExecution): (WebCore::LegacyHTMLDocumentParser::parseTag): (WebCore::LegacyHTMLDocumentParser::continueProcessing): (WebCore::LegacyHTMLDocumentParser::willWriteHTML): (WebCore::LegacyHTMLDocumentParser::didWriteHTML): (WebCore::LegacyHTMLDocumentParser::write): (WebCore::LegacyHTMLDocumentParser::stopParsing): (WebCore::LegacyHTMLDocumentParser::timerFired): (WebCore::LegacyHTMLDocumentParser::end): (WebCore::LegacyHTMLDocumentParser::processToken): (WebCore::LegacyHTMLDocumentParser::processDoctypeToken): (WebCore::LegacyHTMLDocumentParser::executeScriptsWaitingForStylesheets): (WebCore::LegacyHTMLDocumentParser::executeExternalScriptsIfReady): (WebCore::LegacyHTMLDocumentParser::executeExternalScriptsTimerFired):
  • html/LegacyHTMLDocumentParser.h:
  • loader/ImageDocument.cpp: (WebCore::ImageDocumentParser::ImageDocumentParser): (WebCore::ImageDocumentParser::imageDocument): (WebCore::ImageDocumentParser::write): (WebCore::ImageDocumentParser::writeRawData): (WebCore::ImageDocumentParser::finish): (WebCore::ImageDocumentParser::finishWasCalled): (WebCore::ImageDocumentParser::isWaitingForScripts): (WebCore::ImageDocument::createParser):
  • loader/MediaDocument.cpp: (WebCore::MediaDocumentParser::MediaDocumentParser): (WebCore::MediaDocumentParser::createDocumentStructure): (WebCore::MediaDocumentParser::finish): (WebCore::MediaDocumentParser::finishWasCalled):
  • loader/PluginDocument.cpp: (WebCore::PluginDocumentParser::PluginDocumentParser): (WebCore::PluginDocumentParser::createDocumentStructure): (WebCore::PluginDocumentParser::writeRawData): (WebCore::PluginDocumentParser::finish): (WebCore::PluginDocumentParser::finishWasCalled):
  • loader/SinkDocument.cpp: (WebCore::SinkDocumentParser::SinkDocumentParser):
  • loader/TextDocument.cpp: (WebCore::TextDocumentParser::TextDocumentParser): (WebCore::TextDocumentParser::write): (WebCore::TextDocumentParser::finish): (WebCore::TextDocumentParser::finishWasCalled):
11:14 PM Changeset in webkit [61736] by eric@webkit.org
  • 7 edits in trunk/WebCore

2010-06-23 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Start to clean up DocumentParser interface
​https://bugs.webkit.org/show_bug.cgi?id=41114

The first of many cleanups needed to the DocumentParser
interface. Rename executingScript() to isExecutingScript()
and make it return a bool instead of an int. Also added a
FIXME to XMLDocumentParser about implementing it and did
some minor other cleanup to the XMLDocumentParser header.

No functional change, thus no tests.

  • dom/Document.cpp: (WebCore::Document::open):
  • dom/DocumentParser.h: (WebCore::DocumentParser::isExecutingScript):
  • dom/XMLDocumentParser.h: (WebCore::XMLDocumentParser::wellFormed):
  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::attemptToEnd): (WebCore::HTMLDocumentParser::endIfDelayed): (WebCore::HTMLDocumentParser::isExecutingScript):
  • html/HTMLDocumentParser.h:
  • html/LegacyHTMLDocumentParser.h: (WebCore::LegacyHTMLDocumentParser::isExecutingScript):
10:50 PM Changeset in webkit [61735] by oliver@apple.com
  • 2 edits in trunk/LayoutTests

Fix testcase.

Reviewed by Maciej Stachowiak.

Make the reparsing test use syntax that is actually valid.
The old parser had a bug that would lead to it accepting
invalid code in some cases.

  • fast/js/script-tests/reparsing-semicolon-insertion.js:

(commaTest):
(varCommaTest):
(constCommaTest):
(commaParenTest):
(commaParenThrowTest):

10:43 PM Changeset in webkit [61734] by mjs@apple.com
  • 3 edits
    3 adds in trunk

2010-06-22 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Simon Fraser.

Implement IDL attribute for HTML5 hidden
​https://bugs.webkit.org/show_bug.cgi?id=41039

Test: fast/html/hidden-attr-dom.html

  • html/HTMLElement.idl: Just add to the IDL file. [Reflect] takes care of the rest.

2010-06-22 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Simon Fraser.

Implement IDL attribute for HTML5 hidden
​https://bugs.webkit.org/show_bug.cgi?id=41039

Test cases.


  • fast/html/hidden-attr-dom.html: Added.
  • fast/html/hidden-attr-dom-expected.txt: Added.
  • fast/html/script-tests/hidden-attr-dom.js: Added.
9:22 PM Changeset in webkit [61733] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit

2010-06-23 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Gustavo Noronha Silva.

[EFL] Add Libs.private to ewebkit.pc when building with SHARED_CORE.
​https://bugs.webkit.org/show_bug.cgi?id=40862

  • CMakeListsEfl.txt:
  • efl/ewebkit.pc.in:
9:19 PM Changeset in webkit [61732] by oliver@apple.com
  • 13 edits
    4 adds in trunk/JavaScriptCore

2010-06-23 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

Custom-written JavaScript parser
​https://bugs.webkit.org/show_bug.cgi?id=34019

Implement a recursive descent parser similar to that used by V8 and
SpiderMonkey. Greater than 2x improvement in SunSpider parsing tests.

The parser consists of a JSParser class that uses a TreeBuilder to actually
build the AST. There are currently two builders -- the ASTBuilder and
SyntaxChecker which separate the job of building an AST for code generation
and simply checking syntactic correctness.

There's still some less than ideal code remaining in the parser to allow
us to retain the existing lexing code with minimal changes. We'll tidy
this up at a later date.

  • GNUmakefile.am:
  • JavaScriptCore.gypi:
  • JavaScriptCore.pro:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • parser/ASTBuilder.h: Added. (JSC::ASTBuilder::BinaryOpInfo::BinaryOpInfo): (JSC::ASTBuilder::AssignmentInfo::AssignmentInfo): (JSC::ASTBuilder::ASTBuilder): (JSC::ASTBuilder::createSourceElements): (JSC::ASTBuilder::varDeclarations): (JSC::ASTBuilder::funcDeclarations): (JSC::ASTBuilder::features): (JSC::ASTBuilder::numConstants): (JSC::ASTBuilder::appendToComma): (JSC::ASTBuilder::createCommaExpr): (JSC::ASTBuilder::createLogicalNot): (JSC::ASTBuilder::createUnaryPlus): (JSC::ASTBuilder::createVoid): (JSC::ASTBuilder::thisExpr): (JSC::ASTBuilder::createResolve): (JSC::ASTBuilder::createObjectLiteral): (JSC::ASTBuilder::createArray): (JSC::ASTBuilder::createNumberExpr): (JSC::ASTBuilder::createString): (JSC::ASTBuilder::createBoolean): (JSC::ASTBuilder::createNull): (JSC::ASTBuilder::createBracketAccess): (JSC::ASTBuilder::createDotAccess): (JSC::ASTBuilder::createRegex): (JSC::ASTBuilder::createNewExpr): (JSC::ASTBuilder::createConditionalExpr): (JSC::ASTBuilder::createAssignResolve): (JSC::ASTBuilder::createFunctionExpr): (JSC::ASTBuilder::createFunctionBody): (JSC::ASTBuilder::createGetterOrSetterProperty): (JSC::ASTBuilder::createArguments): (JSC::ASTBuilder::createArgumentsList): (JSC::ASTBuilder::createProperty): (JSC::ASTBuilder::createPropertyList): (JSC::ASTBuilder::createElementList): (JSC::ASTBuilder::createFormalParameterList): (JSC::ASTBuilder::createClause): (JSC::ASTBuilder::createClauseList): (JSC::ASTBuilder::setUsesArguments): (JSC::ASTBuilder::createFuncDeclStatement): (JSC::ASTBuilder::createBlockStatement): (JSC::ASTBuilder::createExprStatement): (JSC::ASTBuilder::createIfStatement): (JSC::ASTBuilder::createForLoop): (JSC::ASTBuilder::createForInLoop): (JSC::ASTBuilder::createEmptyStatement): (JSC::ASTBuilder::createVarStatement): (JSC::ASTBuilder::createReturnStatement): (JSC::ASTBuilder::createBreakStatement): (JSC::ASTBuilder::createContinueStatement): (JSC::ASTBuilder::createTryStatement): (JSC::ASTBuilder::createSwitchStatement): (JSC::ASTBuilder::createWhileStatement): (JSC::ASTBuilder::createDoWhileStatement): (JSC::ASTBuilder::createLabelStatement): (JSC::ASTBuilder::createWithStatement): (JSC::ASTBuilder::createThrowStatement): (JSC::ASTBuilder::createDebugger): (JSC::ASTBuilder::createConstStatement): (JSC::ASTBuilder::appendConstDecl): (JSC::ASTBuilder::appendStatement): (JSC::ASTBuilder::addVar): (JSC::ASTBuilder::combineCommaNodes): (JSC::ASTBuilder::evalCount): (JSC::ASTBuilder::appendBinaryExpressionInfo): (JSC::ASTBuilder::operatorStackPop): (JSC::ASTBuilder::operatorStackHasHigherPrecedence): (JSC::ASTBuilder::getFromOperandStack): (JSC::ASTBuilder::shrinkOperandStackBy): (JSC::ASTBuilder::appendBinaryOperation): (JSC::ASTBuilder::operatorStackAppend): (JSC::ASTBuilder::popOperandStack): (JSC::ASTBuilder::appendUnaryToken): (JSC::ASTBuilder::unaryTokenStackLastType): (JSC::ASTBuilder::unaryTokenStackLastStart): (JSC::ASTBuilder::unaryTokenStackRemoveLast): (JSC::ASTBuilder::assignmentStackAppend): (JSC::ASTBuilder::createAssignment): (JSC::ASTBuilder::Scope::Scope): (JSC::ASTBuilder::setExceptionLocation): (JSC::ASTBuilder::incConstants): (JSC::ASTBuilder::usesThis): (JSC::ASTBuilder::usesCatch): (JSC::ASTBuilder::usesClosures): (JSC::ASTBuilder::usesArguments): (JSC::ASTBuilder::usesAssignment): (JSC::ASTBuilder::usesWith): (JSC::ASTBuilder::usesEval): (JSC::ASTBuilder::createNumber): (JSC::ASTBuilder::makeTypeOfNode): (JSC::ASTBuilder::makeDeleteNode): (JSC::ASTBuilder::makeNegateNode): (JSC::ASTBuilder::makeBitwiseNotNode): (JSC::ASTBuilder::makeMultNode): (JSC::ASTBuilder::makeDivNode): (JSC::ASTBuilder::makeAddNode): (JSC::ASTBuilder::makeSubNode): (JSC::ASTBuilder::makeLeftShiftNode): (JSC::ASTBuilder::makeRightShiftNode): (JSC::ASTBuilder::makeFunctionCallNode): (JSC::ASTBuilder::makeBinaryNode): (JSC::ASTBuilder::makeAssignNode): (JSC::ASTBuilder::makePrefixNode): (JSC::ASTBuilder::makePostfixNode):
  • parser/JSParser.cpp: Added. (JSC::JSParser::AllowInOverride::AllowInOverride): (JSC::JSParser::AllowInOverride::~AllowInOverride): (JSC::JSParser::token): (JSC::JSParser::next): (JSC::JSParser::consume): (JSC::JSParser::match): (JSC::JSParser::tokenStart): (JSC::JSParser::tokenLine): (JSC::JSParser::tokenEnd): (JSC::JSParser::): (JSC::JSParser::autoSemiColon): (JSC::JSParser::canRecurse): (JSC::JSParser::lastTokenEnd): (JSC::jsParse): (JSC::JSParser::JSParser): (JSC::JSParser::parseProgram): (JSC::JSParser::allowAutomaticSemicolon): (JSC::JSParser::parseSourceElements): (JSC::JSParser::parseVarDeclaration): (JSC::JSParser::parseConstDeclaration): (JSC::JSParser::parseDoWhileStatement): (JSC::JSParser::parseWhileStatement): (JSC::JSParser::parseVarDeclarationList): (JSC::JSParser::parseConstDeclarationList): (JSC::JSParser::parseForStatement): (JSC::JSParser::parseBreakStatement): (JSC::JSParser::parseContinueStatement): (JSC::JSParser::parseReturnStatement): (JSC::JSParser::parseThrowStatement): (JSC::JSParser::parseWithStatement): (JSC::JSParser::parseSwitchStatement): (JSC::JSParser::parseSwitchClauses): (JSC::JSParser::parseSwitchDefaultClause): (JSC::JSParser::parseTryStatement): (JSC::JSParser::parseDebuggerStatement): (JSC::JSParser::parseBlockStatement): (JSC::JSParser::parseStatement): (JSC::JSParser::parseFormalParameters): (JSC::JSParser::parseFunctionBody): (JSC::JSParser::parseFunctionInfo): (JSC::JSParser::parseFunctionDeclaration): (JSC::JSParser::parseExpressionOrLabelStatement): (JSC::JSParser::parseExpressionStatement): (JSC::JSParser::parseIfStatement): (JSC::JSParser::parseExpression): (JSC::JSParser::parseAssignmentExpression): (JSC::JSParser::parseConditionalExpression): (JSC::isUnaryOp): (JSC::JSParser::isBinaryOperator): (JSC::JSParser::parseBinaryExpression): (JSC::JSParser::parseProperty): (JSC::JSParser::parseObjectLiteral): (JSC::JSParser::parseArrayLiteral): (JSC::JSParser::parsePrimaryExpression): (JSC::JSParser::parseArguments): (JSC::JSParser::parseMemberExpression): (JSC::JSParser::parseUnaryExpression):
  • parser/JSParser.h: Added. (JSC::): (JSC::JSTokenInfo::JSTokenInfo):
  • parser/Lexer.cpp: (JSC::Lexer::lex):
  • parser/Lexer.h: (JSC::Lexer::setLastLineNumber): (JSC::Lexer::lastLineNumber):
  • parser/NodeConstructors.h: (JSC::Node::Node):
  • parser/Parser.cpp: (JSC::Parser::parse):
  • parser/SyntaxChecker.h: Added. (JSC::SyntaxChecker::SyntaxChecker): (JSC::SyntaxChecker::createSourceElements): (JSC::SyntaxChecker::makeFunctionCallNode): (JSC::SyntaxChecker::appendToComma): (JSC::SyntaxChecker::createCommaExpr): (JSC::SyntaxChecker::makeAssignNode): (JSC::SyntaxChecker::makePrefixNode): (JSC::SyntaxChecker::makePostfixNode): (JSC::SyntaxChecker::makeTypeOfNode): (JSC::SyntaxChecker::makeDeleteNode): (JSC::SyntaxChecker::makeNegateNode): (JSC::SyntaxChecker::makeBitwiseNotNode): (JSC::SyntaxChecker::createLogicalNot): (JSC::SyntaxChecker::createUnaryPlus): (JSC::SyntaxChecker::createVoid): (JSC::SyntaxChecker::thisExpr): (JSC::SyntaxChecker::createResolve): (JSC::SyntaxChecker::createObjectLiteral): (JSC::SyntaxChecker::createArray): (JSC::SyntaxChecker::createNumberExpr): (JSC::SyntaxChecker::createString): (JSC::SyntaxChecker::createBoolean): (JSC::SyntaxChecker::createNull): (JSC::SyntaxChecker::createBracketAccess): (JSC::SyntaxChecker::createDotAccess): (JSC::SyntaxChecker::createRegex): (JSC::SyntaxChecker::createNewExpr): (JSC::SyntaxChecker::createConditionalExpr): (JSC::SyntaxChecker::createAssignResolve): (JSC::SyntaxChecker::createFunctionExpr): (JSC::SyntaxChecker::createFunctionBody): (JSC::SyntaxChecker::createArguments): (JSC::SyntaxChecker::createArgumentsList): (JSC::SyntaxChecker::createProperty): (JSC::SyntaxChecker::createPropertyList): (JSC::SyntaxChecker::createElementList): (JSC::SyntaxChecker::createFormalParameterList): (JSC::SyntaxChecker::createClause): (JSC::SyntaxChecker::createClauseList): (JSC::SyntaxChecker::setUsesArguments): (JSC::SyntaxChecker::createFuncDeclStatement): (JSC::SyntaxChecker::createBlockStatement): (JSC::SyntaxChecker::createExprStatement): (JSC::SyntaxChecker::createIfStatement): (JSC::SyntaxChecker::createForLoop): (JSC::SyntaxChecker::createForInLoop): (JSC::SyntaxChecker::createEmptyStatement): (JSC::SyntaxChecker::createVarStatement): (JSC::SyntaxChecker::createReturnStatement): (JSC::SyntaxChecker::createBreakStatement): (JSC::SyntaxChecker::createContinueStatement): (JSC::SyntaxChecker::createTryStatement): (JSC::SyntaxChecker::createSwitchStatement): (JSC::SyntaxChecker::createWhileStatement): (JSC::SyntaxChecker::createWithStatement): (JSC::SyntaxChecker::createDoWhileStatement): (JSC::SyntaxChecker::createLabelStatement): (JSC::SyntaxChecker::createThrowStatement): (JSC::SyntaxChecker::createDebugger): (JSC::SyntaxChecker::createConstStatement): (JSC::SyntaxChecker::appendConstDecl): (JSC::SyntaxChecker::createGetterOrSetterProperty): (JSC::SyntaxChecker::appendStatement): (JSC::SyntaxChecker::addVar): (JSC::SyntaxChecker::combineCommaNodes): (JSC::SyntaxChecker::evalCount): (JSC::SyntaxChecker::appendBinaryExpressionInfo): (JSC::SyntaxChecker::operatorStackPop):
  • runtime/JSGlobalData.h:
  • wtf/Platform.h:
  • wtf/ThreadSpecific.h: (WTF::T):
8:25 PM Changeset in webkit [61731] by tony@chromium.org
  • 3 edits in trunk/LayoutTests

2010-06-23 Tony Chang <​tony@chromium.org>

Not reviewed, fixing gtk/qt tests

skip http/tests/multipart/policy-ignore-crash.php on qt and gtk
​https://bugs.webkit.org/show_bug.cgi?id=41128

Their network libraries appear to be more strict about identifying
multipart boundaries.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
8:18 PM Changeset in webkit [61730] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2010-06-23 Mario Sanchez Prada <​msanchez@igalia.com>

Reviewed by Chris Fleizach.

[Gtk] nameFromChildren is obsolete
​https://bugs.webkit.org/show_bug.cgi?id=36128

Added new tests, based on a previous patch by Joanmarie Diggs.

  • platform/gtk/accessibility/name-from-label-expected.txt: Added.
  • platform/gtk/accessibility/name-from-label.html: Added.

2010-06-23 Joanmarie Diggs <​joanmarie.diggs@gmail.com>

Reviewed by Chris Fleizach.

[Gtk] nameFromChildren is obsolete
​https://bugs.webkit.org/show_bug.cgi?id=36128

Look to the AtkText interface implemented by the objects in
question.

Test: platform/gtk/accessibility/name-from-label.html

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_name): (webkit_accessible_table_get_column_description): (webkit_accessible_table_get_row_description):
7:55 PM Changeset in webkit [61729] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2010-06-23 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Port FileSystem
​https://bugs.webkit.org/show_bug.cgi?id=34323

Port FileSystem with IFileMgr interface.

  • platform/FileSystem.h:
  • platform/brew/FileSystemBrew.cpp: Added. (WebCore::getFileSize): (WebCore::getFileModificationTime): (WebCore::fileExists): (WebCore::deleteFile): (WebCore::deleteEmptyDirectory): (WebCore::pathByAppendingComponent): (WebCore::fileSystemRepresentation): (WebCore::canonicalPath): (WebCore::makeAllDirectories): (WebCore::homeDirectoryPath): (WebCore::pathGetFileName): (WebCore::directoryName): (WebCore::openTemporaryFile): (WebCore::closeFile): (WebCore::writeToFile): (WebCore::unloadModule): (WebCore::listDirectory):
7:54 PM Changeset in webkit [61728] by tony@chromium.org
  • 4 edits
    2 adds in trunk

2010-06-23 Tony Chang <​tony@chromium.org>

Reviewed by Darin Fisher.

layout test for a crash in chromium multipart request handling
​https://bugs.webkit.org/show_bug.cgi?id=41050

  • http/tests/multipart/policy-ignore-crash-expected.txt: Copied from LayoutTests/editing/pasteboard/copy-crash-with-extraneous-attribute-expected.txt.
  • http/tests/multipart/policy-ignore-crash.php: Added.
  • platform/mac/Skipped:

2010-06-23 Tony Chang <​tony@chromium.org>

Reviewed by Darin Fisher.

layout test for a crash in chromium multipart request handling
​https://bugs.webkit.org/show_bug.cgi?id=41050

Also roll DEPS to pick up the crash fix.

  • DEPS:
7:21 PM Changeset in webkit [61727] by Laszlo Gombos
  • 2 edits in trunk/WebKit/qt

2010-06-23 Laszlo Gombos <Laszlo Gombos>

Unreviewed, Symbian build fix.

[Qt] Update the def file after r61478.

  • symbian/eabi/QtWebKitu.def:
6:49 PM Changeset in webkit [61726] by commit-queue@webkit.org
  • 3 edits in trunk/JavaScriptCore

2010-06-23 Jedrzej Nowacki <​jedrzej.nowacki@nokia.com>

Reviewed by Simon Hausmann.

Optimization of the QScriptValuePrivate.

Patch change only internals of the QScriptValuePrivate.
Most of the QScriptValuePrivate's attributes were moved
into an union.

[Qt] Optimization of the QScriptVAluePrivate.
​https://bugs.webkit.org/show_bug.cgi?id=40415

  • qt/api/qscriptengine_p.cpp: (QScriptEnginePrivate::globalObject):
  • qt/api/qscriptvalue_p.h: (QScriptValuePrivate::): (QScriptValuePrivate::~QScriptValuePrivate): (QScriptValuePrivate::QScriptValuePrivate): (QScriptValuePrivate::toString): (QScriptValuePrivate::toNumber): (QScriptValuePrivate::toBool): (QScriptValuePrivate::toObject): (QScriptValuePrivate::equals): (QScriptValuePrivate::strictlyEquals): (QScriptValuePrivate::assignEngine): (QScriptValuePrivate::operator JSValueRef): (QScriptValuePrivate::operator JSObjectRef): (QScriptValuePrivate::refinedJSValue):
6:39 PM Changeset in webkit [61725] by andersca@apple.com
  • 8 edits in trunk/WebKit2

2010-06-23 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Have the UI process compute the plug-in data
​https://bugs.webkit.org/show_bug.cgi?id=41118

  • Shared/CoreIPCSupport/WebProcessProxyMessageKinds.h: (WebProcessProxyMessage::): Add GetPlugin message kind.
  • Shared/WebCoreArgumentCoders.h: Add argument coders for PluginInfo and MimeClassInfo.


  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm: (WebKit::safeCreateCFString): (WebKit::PluginInfoStore::pluginPathsInDirectory): (WebKit::PluginInfoStore::getPluginInfo): Use safeCreateCFString.


  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::getPlugins): Ask the plug-in info store for the plug-in list.

(WebKit::WebProcessProxy::didReceiveSyncMessage):
Handle GetPlugins.

  • UIProcess/WebProcessProxy.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::objectContentType): Implement.
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::populatePluginCache): Send a sync GetPlugins message.
6:33 PM Changeset in webkit [61724] by commit-queue@webkit.org
  • 3 edits in trunk/WebCore

2010-06-23 Alexendar Pavlov <​apavlov@chromium.org>

Reviewed by David Hyatt.

Swap checks in Position::isCandidate so that the less expensive
nodeIsUserSelectNode (node && node->renderer() &&
node->renderer()->style()->userSelect() == SELECT_NONE) came first.

(Was Web Inspector: Hangup when expanding elements with enormous
text node content in Elements panel).

​https://bugs.webkit.org/show_bug.cgi?id=35926

  • dom/Position.cpp: (WebCore::Position::isCandidate):
  • dom/PositionIterator.cpp: (WebCore::PositionIterator::isCandidate):
6:02 PM Changeset in webkit [61723] by kevino@webkit.org
  • 3 edits in trunk/WebKitTools

[wx] Build fix, adding new LayoutTestController methods and enabling SVG_FOREIGN_OBJECT.

5:33 PM Changeset in webkit [61722] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/WebCore

2010-06-23 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Add PopupMenu implementation
​https://bugs.webkit.org/show_bug.cgi?id=40226

Delegate PopupMenu handling to ChromeClientBrew.

  • page/brew/ChromeClientBrew.h: Added.
  • platform/PopupMenu.h:
  • platform/brew/PopupMenuBrew.cpp: Added. (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::updateFromElement): (WebCore::PopupMenu::itemWritingDirectionIsNatural):
5:29 PM Changeset in webkit [61721] by aestes@apple.com
  • 2 edits
    1 add in trunk/LayoutTests

<rdar://problem/8107855> Test that removing an object element with an
invalid data URL in a listener to its beforeload event does not crash
WebCore.
​https://bugs.webkit.org/show_bug.cgi?id=41054

Reviewed by Alexey Proskuryakov.

  • fast/dom/beforeload/remove-bad-object-in-beforeload-listener-expected.txt: Added.
  • fast/dom/beforeload/remove-bad-object-in-beforeload-listener.html: Added.
  • fast/dom/beforeload/resources/print.js: Added.

(print):

5:23 PM Changeset in webkit [61720] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Add ArgumentCoder for vectors.

Reviewed by Dan Bernstein.

  • Platform/CoreIPC/ArgumentCoders.h:

(CoreIPC::):

5:18 PM Changeset in webkit [61719] by andersca@apple.com
  • 15 edits
    1 move in trunk/WebKit2

Rename WebCoreTypeArgumentMarshalling.h to WebCoreArgumentCoders.h

Reviewed by Dan Bernstein.

  • Shared/WebCoreArgumentCoders.h: Copied from Shared/WebCoreTypeArgumentMarshalling.h.
  • Shared/WebCoreTypeArgumentMarshalling.h: Removed.
  • Shared/WebEvent.h:
  • Shared/WebNavigationDataStore.h:
  • Shared/WebPreferencesStore.h:
  • Shared/mac/UpdateChunk.cpp:
  • UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
  • UIProcess/WebContext.cpp:
  • UIProcess/WebPageProxy.cpp:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebProcess.cpp:
5:12 PM Changeset in webkit [61718] by andersca@apple.com
  • 4 edits in trunk/WebKit2

2010-06-23 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

MessageIDs should always have the most significant bit zeroed out
​https://bugs.webkit.org/show_bug.cgi?id=41112

The most significant bit is used by the Mac implementation of CoreIPC, and
should always be zero in MessageID objects.

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::waitForMessage):
  • Platform/CoreIPC/MessageID.h: (CoreIPC::MessageID::): (CoreIPC::MessageID::MessageID): (CoreIPC::MessageID::operator==): (CoreIPC::MessageID::fromInt): (CoreIPC::MessageID::isSync): (CoreIPC::MessageID::stripMostSignificantBit):
  • Platform/CoreIPC/mac/ConnectionMac.cpp: (CoreIPC::Connection::sendOutgoingMessage): (CoreIPC::createArgumentDecoder):
4:29 PM Changeset in webkit [61717] by sullivan@apple.com
  • 2 edits in trunk/WebKit2
  • mac/WebKit2.exp:

Added yet another symbol needed by Mac clients.

Rubber-stamped by Anders Carlsson.

4:25 PM Changeset in webkit [61716] by sullivan@apple.com
  • 2 edits in trunk/WebKit2
  • mac/WebKit2.exp:

Added another symbol needed by Mac clients.

Rubber-stamped by Anders Carlsson.

4:22 PM Changeset in webkit [61715] by kbr@google.com
  • 8 edits
    3 adds in trunk

2010-06-23 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Implement format conversions in texImage2D and texSubImage2D taking HTML data
​https://bugs.webkit.org/show_bug.cgi?id=40319

Generalized code supporting premultiplication of alpha and
vertical flip to pack texture data into requested format and type.
Handled incoming image data of various formats, RGBA and BGRA in
particular, both to reduce the number of temporary copies during
texture upload and to support premultiplying alpha for the
texImage2D and texSubImage2D entry points taking ArrayBufferView
in a subsequent bug. Added test case exercising all combinations
of format/type combinations, premultiplication of alpha, and
Image/ImageData upload. (Incorporated pnglib.js under
fast/canvas/webgl/resources/ to be able to generate Image elements
programmatically.) Tested in Safari on Mac OS X and in Chromium on
Mac OS X, Windows and Linux.

Test: fast/canvas/webgl/tex-image-with-format-and-type.html

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::readPixels): (WebCore::WebGLRenderingContext::texImage2DImpl): (WebCore::WebGLRenderingContext::texImage2D): (WebCore::WebGLRenderingContext::texSubImage2DImpl): (WebCore::WebGLRenderingContext::texSubImage2D): (WebCore::WebGLRenderingContext::validateTexFuncFormatAndType): (WebCore::WebGLRenderingContext::validateTexFuncParameters):
  • platform/graphics/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::computeFormatAndTypeParameters): (WebCore::GraphicsContext3D::extractImageData): (WebCore::GraphicsContext3D::flipVertically): (WebCore::doUnpackingAndPacking): (WebCore::doPacking): (WebCore::GraphicsContext3D::packPixels):
  • platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::):
  • platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::GraphicsContext3D::getImageData):
  • platform/graphics/mac/GraphicsContext3DMac.mm: (WebCore::narrowInternalFormat): (WebCore::GraphicsContext3D::texImage2D):
  • platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::getImageData):
  • platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData):

2010-06-23 Kenneth Russell <​kbr@google.com>

Reviewed by Dimitri Glazkov.

Implement format conversions in texImage2D and texSubImage2D taking HTML data
​https://bugs.webkit.org/show_bug.cgi?id=40319

Generalized code supporting premultiplication of alpha and
vertical flip to pack texture data into requested format and type.
Handled incoming image data of various formats, RGBA and BGRA in
particular, both to reduce the number of temporary copies during
texture upload and to support premultiplying alpha for the
texImage2D and texSubImage2D entry points taking ArrayBufferView
in a subsequent bug. Added test case exercising all combinations
of format/type combinations, premultiplication of alpha, and
Image/ImageData upload. (Incorporated pnglib.js under
fast/canvas/webgl/resources/ to be able to generate Image elements
programmatically.) Tested in Safari on Mac OS X and in Chromium on
Mac OS X, Windows and Linux.

Test: fast/canvas/webgl/tex-image-with-format-and-type.html

  • fast/canvas/webgl/resources/pnglib.js: Added. (): (.):
  • fast/canvas/webgl/tex-image-with-format-and-type-expected.txt: Added.
  • fast/canvas/webgl/tex-image-with-format-and-type.html: Added.
4:19 PM Changeset in webkit [61714] by senorblanco@chromium.org
  • 2 edits in trunk/WebCore

2010-06-23 Stephen White <​senorblanco@chromium.org>

Unreviewed; correcting bad patch.

In my haste to land r61710, I mistakenly landed the wrong version, in
which a chunk of code was moved. This patch moves that chunk of code
to where it was in the patch that was reviewed. Mea culpa.

  • rendering/RenderBoxModelObject.cpp: (WebCore::ImageQualityController::shouldPaintAtLowQuality):
4:14 PM Changeset in webkit [61713] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Build fix.

Adding test expectation since a test introduced r61607 has not test results.

  • platform/chromium/test_expectations.txt:
3:27 PM Changeset in webkit [61712] by commit-queue@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-23 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Oliver Hunt.

[GTK] Implement ThreadSpecific with glib
​https://bugs.webkit.org/show_bug.cgi?id=39829

Implement ThreadSpecific with glib's GStaticPrivate.
This patch makes it possible to build GTK port without pthread.

  • wtf/ThreadSpecific.h: (WTF::::ThreadSpecific): (WTF::::~ThreadSpecific): (WTF::::get): (WTF::::set): (WTF::::destroy):
3:18 PM Changeset in webkit [61711] by jschuh@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

Unreviewed, fixing ChangeLog entry for ​http://trac.webkit.org/changeset/61709

2:52 PM Changeset in webkit [61710] by senorblanco@chromium.org
  • 4 edits in trunk

2010-06-23 Stephen White <​senorblanco@chromium.org>

Reviewed by David Hyatt.

This is a tweak to the resize algorithm introduced in r61341, and
is a fix for the regression described in
​https://bugs.webkit.org/show_bug.cgi?id=41036

The goal is to bring back the some of old behaviour, without regressing
too much of the performance gains in r61341.

The old algorithm was:

  • on first resize, draw in high quality and record the paint time
  • if we've already drawn at this size, use the same quality as last time
  • on subsequent resizes, if the resize occurs within X ms of the previous one, draw at low quality and set a timer (one timer per image).
  • when each timer expires, draw that image at high quality

The r61341 algorithm was:

  • on first resize, draw the image in low quality, add it to a list of resized images, and set a timer (one timer for all images)
  • when the timer expires, redraw all resized images in high quality

The new algorithm is:

  • on first resize, if no other animated resizes are outstanding, draw in high quality and set the timer (one timer for all images)
  • if any images have been resized to two different sizes in the last X ms, draw all resized images in low quality and kick the timer forward
  • when the timer expires, if any animated resizes occured, redraw all resized images in high quality, and reset the flag

This should cause GUIMark and the IE9 demos to have good performance
after the first frame, while other pages with only static resizes
should be unaffected.

  • rendering/RenderBoxModelObject.cpp: Change the LastPaintTimeMap to a LastPaintSizeMap: we now record the last size an image was resized to, rather than the time it was painted (the time actually became redundant in r61341 when I added the check for m_timer.isActive(): we only care if anything is resizing while the timer is active). (WebCore::ImageQualityController::ImageQualityController): Add an initializer for the m_animatedResizeIsActive flag. (WebCore::ImageQualityController::objectDestroyed): Reset the m_animatedResizeIsActive flag if this was the last object in the list. (WebCore::ImageQualityController::highQualityRepaintTimerFired): Only repaint all the images if there was an animated resize (otherwise, everything is already high quality). (WebCore::ImageQualityController::shouldPaintAtLowQuality): Implement the above algorithm.

2010-06-23 Stephen White <​senorblanco@chromium.org>

Reviewed by David Hyatt.

Temporarily put the tests broken by the resize change into
test_expectations.txt.
​https://bugs.webkit.org/show_bug.cgi?id=41036

  • platform/chromium/test_expectations.txt:
2:34 PM Changeset in webkit [61709] by jschuh@chromium.org
  • 3 edits
    2 adds in trunk

2010-06-23 Abhishek Arya <​inferno@chromium.org>

Reviewed by Kenneth Rohde Christiansen.

Firing the onchange event on select which changes its size > 1 causes the select
object to change from a menulist to a listbox. However, when propogating the events,
we do a bad cast assuming the object will remain a menulist. Added proper checks to
make sure we check the renderer after the onchange is fired and propogate the event
based on correct object type.
​https://bugs.webkit.org/show_bug.cgi?id=40828

Test: fast/events/select-onchange-crash.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::setSelectedIndex):

2010-06-23 Abhishek Arya <​inferno@chromium.org>

Reviewed by Kenneth Rohde Christiansen.

Tests that we do not crash when onchange handler changes the select from a menu list to a list box.
​https://bugs.webkit.org/show_bug.cgi?id=40828

  • fast/events/select-onchange-crash-expected.txt: Added.
  • fast/events/select-onchange-crash.html: Added.
2:25 PM BuildingQtOnSymbian edited by Laszlo Gombos
CONFIG-=def_files should be used for trunk builds (diff)
1:07 PM Changeset in webkit [61708] by leandro@webkit.org
  • 3 edits
    1 add in trunk

2010-06-23 Leandro Pereira <​leandro@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Add support to CPack (to generate source tarballs)
​https://bugs.webkit.org/show_bug.cgi?id=41009


  • CMakeLists.txt:
  • cmake/OptionsEfl.cmake: Define the default source generator for the EFL port.
  • cmake/WebKitPackaging.cmake: Added. This file filters the source files so that only files relevant to the selected port are included in the source tarball. See comments for details.
1:03 PM Changeset in webkit [61707] by aestes@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/8107855> Prevent a crash in WebCore when removing an
object element with an invalid data URL in in a listener to its
beforeload event.
​https://bugs.webkit.org/show_bug.cgi?id=41054

Reviewed by Alexey Proskuryakov.

Tests: fast/dom/beforeload/remove-bad-object-in-beforeload-listener.html

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::renderFallbackContent): Exit early if the
object element is not in the document.

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::updateWidget): If RenderWidget::destroy()
was called during processing of onbeforeload, do not proceed with loading
the object.

12:39 PM Changeset in webkit [61706] by leandro@webkit.org
  • 8 edits
    2 adds in trunk/WebKit

2010-06-23 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Reviewed by Gustavo Noronha Silva.

Add implementaion of new windows for EFL port. Both cases of a link
with target="_blank" and a javascript that does window.open() are
treated, delegating to browser the role of actually creating the
window (or blocking it).
​https://bugs.webkit.org/show_bug.cgi?id=40930

  • CMakeListsEfl.txt: add new file that wraps the WindowFeatures struct
  • efl/WebCoreSupport/ChromeClientEfl.cpp: (WebCore::ChromeClientEfl::createWindow): implement method for creating new window by delegating to browser its creation. Browser might decide to continue on the same window by returning the same view object.
  • efl/WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::dispatchCreatePage): implement method for creating new window when its creation is done by a javascript script.
  • efl/ewk/EWebKit.h: new header for WindowFeatures.
  • efl/ewk/ewk_private.h:
  • efl/ewk/ewk_view.cpp: (ewk_view_window_create): call the method implemented by browser.
  • efl/ewk/ewk_view.h:
  • efl/ewk/ewk_window_features.cpp: Added. (ewk_window_features_unref): (ewk_window_features_ref): (ewk_window_features_bool_property_get): (ewk_window_features_int_property_get): (ewk_window_features_new_from_core): create and wrapped struct containing the core struct.
  • efl/ewk/ewk_window_features.h: Added.
12:32 PM Changeset in webkit [61705] by andersca@apple.com
  • 3 edits
    1 move in trunk/WebKit2

Rename SimpleArgumentCoder.h to ArgumentCoders.h

Reviewed by Sam Weinig.

  • Platform/CoreIPC/ArgumentCoders.h: Copied from Platform/CoreIPC/SimpleArgumentCoder.h.
  • Platform/CoreIPC/SimpleArgumentCoder.h: Removed.
  • Shared/WebCoreTypeArgumentMarshalling.h:
  • WebKit2.xcodeproj/project.pbxproj:
12:08 PM Changeset in webkit [61704] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=41083
fast/parser/broken-comments-vs-parsing mode no linger tests for what it used to test

  • fast/parser/broken-comments-vs-parsing-mode.html: Moved broken comment to a place where it doesn't affect output.
11:42 AM Changeset in webkit [61703] by kov@webkit.org
  • 2 edits in trunk/WebCore

2010-06-23 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[gtk] web fonts not loaded properly in scribd html5 reader
​https://bugs.webkit.org/show_bug.cgi?id=38758

Drop filling the pattern with default values, because this
restricts the matching more than we want.

  • platform/graphics/cairo/FontCacheCairo.cpp: (WebCore::FontCache::createFontPlatformData):
11:41 AM Changeset in webkit [61702] by andersca@apple.com
  • 3 edits in trunk/WebKit2

2010-06-23 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Add a plug-in info cache to WebPlatformStrategies
​https://bugs.webkit.org/show_bug.cgi?id=41087

This is in preparation for proxying the getPlugins call over to the UI process.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::WebPlatformStrategies): (WebKit::WebPlatformStrategies::populatePluginCache): (WebKit::WebPlatformStrategies::refreshPlugins): (WebKit::WebPlatformStrategies::getPluginInfo):
  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
11:23 AM Changeset in webkit [61701] by kov@webkit.org
  • 2 edits in trunk/WebCore

2010-06-23 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[gtk] web fonts not loaded properly in scribd html5 reader
​https://bugs.webkit.org/show_bug.cgi?id=38758

Also special-case sans' amd mono', which are aliases commonly
used in GTK+ applications.

  • platform/graphics/cairo/FontCacheCairo.cpp: (WebCore::isWellKnownFontName):
11:17 AM Changeset in webkit [61700] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Stop silently ignoring crashes.

Reviewed by John Sullivan.

  • WebProcess/Launching/mac/WebProcessMain.mm:
10:58 AM Changeset in webkit [61699] by jschuh@chromium.org
  • 3 edits
    3 deletes in trunk

2010-06-23 Justin Schuh <​jschuh@chromium.org>

Unreviewed, rolling out r61695.
​http://trac.webkit.org/changeset/61695
​https://bugs.webkit.org/show_bug.cgi?id=40798

61695 broke all the Linux builds.

  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::rowAvailable):

2010-06-23 Justin Schuh <​jschuh@chromium.org>

Unreviewed, rolling out r61695.
​http://trac.webkit.org/changeset/61695
​https://bugs.webkit.org/show_bug.cgi?id=40798

61695 broke all the Linux builds

  • fast/images/png-extra-row-crash-expected.txt: Removed.
  • fast/images/png-extra-row-crash.html: Removed.
  • fast/images/resources/png-extra-row-crash.png: Removed.
10:53 AM Changeset in webkit [61698] by weinig@apple.com
  • 2 edits in trunk/WebKit2

Add missing include to WKRetainPtr.

Reviewed by Anders Carlsson.

  • UIProcess/API/cpp/WKRetainPtr.h:
10:52 AM Changeset in webkit [61697] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

Fix PluginViewNone.cpp compilation for ports that also compile PluginView.cpp
​https://bugs.webkit.org/show_bug.cgi?id=37939

10:51 AM Changeset in webkit [61696] by jamesr@google.com
  • 1 edit
    1 add in trunk/LayoutTests

2010-06-23 James Robinson <​jamesr@chromium.org>

Unreviewed. Add qt baseline due to port specific formatting differences for SVG rects
​https://bugs.webkit.org/show_bug.cgi?id=40366

  • platform/qt/fast/repaint/svg-layout-root-style-attr-update-expected.txt: Added.
10:25 AM Changeset in webkit [61695] by jschuh@chromium.org
  • 3 edits
    3 adds in trunk

2010-06-23 Cris Neckar <​cdn@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Out of bounds write in WebCore::PNGImageDecoder::rowAvailable
​https://bugs.webkit.org/show_bug.cgi?id=40798

Catches error in row callback for libPNG when extra rows are returned.

Test: fast/images/png-extra-row-crash.html

  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::rowAvailable):

2010-06-23 Cris Neckar <​cdn@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Out of bounds write in WebCore::PNGImageDecoder::rowAvailable
​https://bugs.webkit.org/show_bug.cgi?id=40798

Tests a PNG with an extra row.

  • fast/images/png-extra-row-crash-expected.txt: Added.
  • fast/images/png-extra-row-crash.html: Added.
  • fast/images/resources/png-extra-row-crash.png: Added.
10:21 AM Changeset in webkit [61694] by jamesr@google.com
  • 2 edits in trunk/WebKitTools

2010-06-23 James Robinson <​jamesr@chromium.org>

Unreviewed. Add my IRC handle to committers.py so the sheriffbot can yell at me.

  • Scripts/webkitpy/common/config/committers.py:
9:56 AM Changeset in webkit [61693] by jamesr@google.com
  • 3 edits
    4 adds in trunk

2010-06-23 James Robinson <​jamesr@chromium.org>

Reviewed by Dan Bernstein.

Do not set needsLayout when the style attribute changes on an SVG element
​https://bugs.webkit.org/show_bug.cgi?id=40366

SVGSVGElement::svgAttributeChanged was incorrectly calling renderer()->setNeedsLayout(true)
whenever the styleAttr changed on its element. This could happen during layout in some
circumstances due to lazy style attribute synchronization. When it did, it could cause the
layout flags to become inconsistent. See the test case for details.

Changes to an element's style attribute always mark an element as needing layout anyway so
this call was redundant.

Test: fast/repaint/svg-layout-root-style-attr-update.html

  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::isKnownAttribute):

2010-06-23 James Robinson <​jamesr@chromium.org>

Reviewed by Dan Bernstein.

Do not set needsLayout when the style attribute changes on an SVG element
​https://bugs.webkit.org/show_bug.cgi?id=40366

Tests that setting the style attribute on an SVG element does not cause
the render tree's layout flags to go haywire. The details are involved,
please see the bug and test case for details.

  • fast/repaint/svg-layout-root-style-attr-update-expected.checksum: Added.
  • fast/repaint/svg-layout-root-style-attr-update-expected.png: Added.
  • fast/repaint/svg-layout-root-style-attr-update-expected.txt: Added.
  • fast/repaint/svg-layout-root-style-attr-update.html: Added.
9:18 AM Changeset in webkit [61692] by Simon Fraser
  • 3 edits
    5 adds in trunk

2010-06-23 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

r61215 broke Acid3
​https://bugs.webkit.org/show_bug.cgi?id=41034

The code added in r61215, which tests whether the root renderer will fill
the entire viewport, should not run for subframes. So bail from
RenderView::paintBoxDecorations() if document()->ownerElement() is not null.
The old code was trying to do this by checking 'elt', but that ends up as
null after the for loop above.

We can also bail early if the is no FrameView().

Test: fast/frames/paint-iframe-background.html

  • rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations):
9:17 AM Changeset in webkit [61691] by pfeldman@chromium.org
  • 6 edits in trunk/WebCore

2010-06-23 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: do not reset profiles panel on navigation.

​https://bugs.webkit.org/show_bug.cgi?id=41068

  • inspector/InspectorController.cpp: (WebCore::InspectorController::didCommitLoad):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::resetProfilesPanel):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): (WebInspector.ProfilesPanel.prototype.populateInterface): (WebInspector.ProfilesPanel.prototype.profilerWasDisabled): (WebInspector.ProfilesPanel.prototype._reset): (WebInspector.ProfilesPanel.prototype._clearProfiles):
  • inspector/front-end/inspector.js: (WebInspector.resetProfilesPanel):
9:11 AM Changeset in webkit [61690] by tkent@chromium.org
  • 3 edits in trunk/WebKitTools

2010-06-23 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

Correct Chromium test configuration
​https://bugs.webkit.org/show_bug.cgi?id=41057

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
    • Add "--use-drt" option for NRWT. It is required for Chromium and ignored for other platforms.
    • Skip JSC test on Chromium
  • BuildSlaveSupport/test-result-archive: Add Chromium support.
9:06 AM Changeset in webkit [61689] by weinig@apple.com
  • 13 edits in trunk

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=41073
WebKit2: Flesh out more of the InjectedBundle client API

Reviewed by Anders Carlsson.

WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundle.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::willDestroyPage):

  • WebProcess/InjectedBundle/InjectedBundle.h:
  • WebProcess/InjectedBundle/InjectedBundlePageClient.cpp:

(WebKit::InjectedBundlePageClient::didStartProvisionalLoadForFrame):
(WebKit::InjectedBundlePageClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::InjectedBundlePageClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::InjectedBundlePageClient::didCommitLoadForFrame):
(WebKit::InjectedBundlePageClient::didFinishLoadForFrame):
(WebKit::InjectedBundlePageClient::didFailLoadWithErrorForFrame):
(WebKit::InjectedBundlePageClient::didReceiveTitleForFrame):

  • WebProcess/InjectedBundle/InjectedBundlePageClient.h:
  • WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:

(WebKit::InjectedBundle::load): Add some error logging on failure to load the bundle.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidReceiveTitle):
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFinishLoad):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::close):

  • mac/WebKit2.exp:

WebKitTools:

  • MiniBrowser/mac/WebBundle/WebBundleMain.m:

(_didStartProvisionalLoadForFrame):
(_didReceiveServerRedirectForProvisionalLoadForFrame):
(_didFailProvisionalLoadWithErrorForFrame):
(_didCommitLoadForFrame):
(_didFinishLoadForFrame):
(_didFailLoadWithErrorForFrame):
(_didReceiveTitleForFrame):
(_didClearWindowForFrame):
(_didCreatePage):
(_willDestroyPage):
(WKBundleInitialize):

8:34 AM Changeset in webkit [61688] by yurys@chromium.org
  • 3 edits in trunk/WebCore

2010-06-23 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: InspectorController should be added only once as ScriptDebugListener to
ScriptDebugServer.
​https://bugs.webkit.org/show_bug.cgi?id=41070

  • inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::enableDebuggerFromFrontend):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): don't call InspectorBackend.enableDebugger if debugger is always enabled, InspectorController will do this on its side when the front end is connected.
8:01 AM Changeset in webkit [61687] by yurys@chromium.org
  • 2 edits in trunk/WebCore

2010-06-23 Pavel Podivilov <​podivilov@chromium.org>

Reviewed by Yury Semikhatsky.

Clear breakpoints before restoring them, not after.
​https://bugs.webkit.org/show_bug.cgi?id=41071

  • inspector/InspectorController.cpp: (WebCore::InspectorController::enableDebuggerFromFrontend):
7:11 AM Changeset in webkit [61686] by benjamin.poulain@nokia.com
  • 8 edits in trunk/WebCore

Do not render the full frame when there is some elements with fixed positioning
​https://bugs.webkit.org/show_bug.cgi?id=33150

Reviewed by Kenneth Rohde Christiansen.

Do not render the full frame when there is some elements with fixed positioning
​https://bugs.webkit.org/show_bug.cgi?id=33150

The frame view take into acount the list of fixed object when scrolling
the view. If the number of object is lower than a certain threshold, the pixel
are blitted, and the invalidated area updated.

  • page/FrameView.cpp:

(WebCore::FrameView::addFixedObject):
(WebCore::FrameView::removeFixedObject):
(WebCore::FrameView::scrollContentsFastPath):

  • page/FrameView.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::scrollContents):
(WebCore::ScrollView::scrollContentsFastPath):

  • platform/ScrollView.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::repaintRectIncludingDescendants):

  • rendering/RenderLayer.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::styleWillChange):

7:01 AM Changeset in webkit [61685] by leandro@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-23 Leandro Pereira <​leandro@profusion.mobi>

Unreviewed build fix.

  • CMakeLists.txt: Add runtime/RegExpCache.cpp.
6:33 AM Changeset in webkit [61684] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] Doc: Fixed documentation errors.

Patch by David Boddie <​dboddie@trolltech.com> on 2010-06-23
Reviewed by Simon Hausmann.

  • docs/qtwebkit-bridge.qdoc:
6:19 AM Changeset in webkit [61683] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] Provide the Webkit Qml plugin with a UID3 on Symbian

Patch by Alessandro Portale <​alessandro.portale@nokia.com> on 2010-06-23
Reviewed by Simon Hausmann.

...otherwise we cannot Symbian sign it.

  • declarative/declarative.pro:
5:14 AM Changeset in webkit [61682] by mnaganov@chromium.org
  • 2 edits in trunk/WebCore

2010-06-23 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: Fix displaying of several CPU profiles with the same name.

​https://bugs.webkit.org/show_bug.cgi?id=40992

  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfileGroupSidebarTreeElement.prototype.onselect):
3:36 AM Changeset in webkit [61681] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Unreviewed Qt package build fix.

When building without build-webkit, set OUTPUT_DIR if necessary, like
in the other .pro files.

  • declarative/declarative.pro:
3:29 AM Changeset in webkit [61680] by yuzo@google.com
  • 4 edits in trunk/WebKit/chromium

2010-06-23 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Make page format data methods accessible from Chromium
​https://bugs.webkit.org/show_bug.cgi?id=41056

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::isPageBoxVisible): (WebKit::WebFrameImpl::pageAreaRectInPixels): (WebKit::WebFrameImpl::preferredPageSizeInPixels):
  • src/WebFrameImpl.h:
2:37 AM Changeset in webkit [61679] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2010-06-23 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Forgot to update result of fast/xpath/namespace-vs-predicate.html after the SVG renderer creation changes.

  • fast/xpath/namespace-vs-predicate-expected.txt:
2:21 AM Changeset in webkit [61678] by abarth@webkit.org
  • 8 edits in trunk/WebCore

2010-06-23 Adam Barth <​abarth@webkit.org>

Unreviewed. clean-header-guards that were made dirty by recent
renames.

  • html/HTMLDocumentParser.h:
  • html/HTMLPreloadScanner.h:
  • html/HTMLTokenizer.h:
  • html/HTMLTreeBuilder.h:
  • html/LegacyHTMLDocumentParser.h:
  • html/LegacyHTMLTreeBuilder.h:
  • html/LegacyPreloadScanner.h:
2:03 AM Changeset in webkit [61677] by abarth@webkit.org
  • 23 edits
    2 moves in trunk/WebCore

2010-06-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Rename LegacyHTMLTreeConstructor to LegacyHTMLTreeBuilder
​https://bugs.webkit.org/show_bug.cgi?id=41053

There was some debate about whether to call this class (and the
non-legacy version) "tree builder" or "tree constructor". Maciej
pointed out that other implementations (including Mozilla and HTML5Lib)
call it a tree builder. The path of least resistance seems to be call
it that for now.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:
  • dom/DocumentParser.h: (WebCore::DocumentParser::htmlTreeConstructor):
  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::htmlTreeConstructor):
  • html/HTMLDocumentParser.h:
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::removedFromTree):
  • html/HTMLInputElement.cpp:
  • html/HTMLMeterElement.cpp:
  • html/HTMLProgressElement.cpp:
  • html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
  • html/HTMLTreeBuilder.h: (WebCore::HTMLTreeBuilder::legacyTreeConstructor):
  • html/LegacyHTMLDocumentParser.cpp: (WebCore::LegacyHTMLDocumentParser::LegacyHTMLDocumentParser):
  • html/LegacyHTMLDocumentParser.h: (WebCore::LegacyHTMLDocumentParser::htmlTreeConstructor):
  • html/LegacyHTMLTreeBuilder.cpp: Copied from WebCore/html/LegacyHTMLTreeConstructor.cpp. (WebCore::LegacyHTMLTreeBuilder::LegacyHTMLTreeBuilder): (WebCore::LegacyHTMLTreeBuilder::~LegacyHTMLTreeBuilder): (WebCore::LegacyHTMLTreeBuilder::reset): (WebCore::LegacyHTMLTreeBuilder::setCurrent): (WebCore::LegacyHTMLTreeBuilder::limitDepth): (WebCore::LegacyHTMLTreeBuilder::insertNodeAfterLimitDepth): (WebCore::LegacyHTMLTreeBuilder::parseToken): (WebCore::LegacyHTMLTreeBuilder::parseDoctypeToken): (WebCore::LegacyHTMLTreeBuilder::insertNode): (WebCore::LegacyHTMLTreeBuilder::handleError): (WebCore::LegacyHTMLTreeBuilder::textCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::commentCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::headCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::bodyCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::framesetCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::formCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::isindexCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::selectCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::ddCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::dtCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::rpCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::rtCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::nestedCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::nestedPCloserCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::nestedStyleCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::tableCellCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::tableSectionCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::noembedCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::noframesCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::noscriptCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::pCloserCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::pCloserStrictCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::mapCreateErrorCheck): (WebCore::LegacyHTMLTreeBuilder::getNode): (WebCore::LegacyHTMLTreeBuilder::allowNestedRedundantTag): (WebCore::LegacyHTMLTreeBuilder::processCloseTag): (WebCore::LegacyHTMLTreeBuilder::isHeadingTag): (WebCore::LegacyHTMLTreeBuilder::isInline): (WebCore::LegacyHTMLTreeBuilder::isResidualStyleTag): (WebCore::LegacyHTMLTreeBuilder::isAffectedByResidualStyle): (WebCore::LegacyHTMLTreeBuilder::handleResidualStyleCloseTagAcrossBlocks): (WebCore::LegacyHTMLTreeBuilder::reopenResidualStyleTags): (WebCore::LegacyHTMLTreeBuilder::pushBlock): (WebCore::LegacyHTMLTreeBuilder::popBlock): (WebCore::LegacyHTMLTreeBuilder::popOneBlockCommon): (WebCore::LegacyHTMLTreeBuilder::popOneBlock): (WebCore::LegacyHTMLTreeBuilder::moveOneBlockToStack): (WebCore::LegacyHTMLTreeBuilder::checkIfHasPElementInScope): (WebCore::LegacyHTMLTreeBuilder::popInlineBlocks): (WebCore::LegacyHTMLTreeBuilder::freeBlock): (WebCore::LegacyHTMLTreeBuilder::createHead): (WebCore::LegacyHTMLTreeBuilder::handleIsindex): (WebCore::LegacyHTMLTreeBuilder::startBody): (WebCore::LegacyHTMLTreeBuilder::finished): (WebCore::LegacyHTMLTreeBuilder::reportErrorToConsole):
  • html/LegacyHTMLTreeBuilder.h: Copied from WebCore/html/LegacyHTMLTreeConstructor.h.
  • html/LegacyHTMLTreeConstructor.cpp: Removed.
  • html/LegacyHTMLTreeConstructor.h: Removed.
  • html/StepRange.cpp:
  • html/ValidityState.cpp:
  • rendering/RenderSlider.cpp:
1:50 AM Changeset in webkit [61676] by tkent@chromium.org
  • 1 edit
    23 adds in trunk/LayoutTests

2010-06-23 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

Add expectations for r61667 and r61669.

  • platform/chromium-linux/svg/custom/bug45331-expected.checksum: Added.
  • platform/chromium-linux/svg/foreignObject: Added.
  • platform/chromium-linux/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.checksum: Added.
  • platform/chromium-linux/svg/foreignObject/svg-document-as-direct-child-expected.checksum: Added.
  • platform/chromium-linux/svg/foreignObject/svg-document-in-html-document-expected.checksum: Added.
  • platform/chromium-linux/svg/foreignObject/text-tref-02-b-expected.checksum: Added.
  • platform/chromium-linux/svg/foreignObject/text-tref-02-b-expected.png: Added.
  • platform/chromium-win/svg/custom/bug45331-expected.checksum: Added.
  • platform/chromium-win/svg/custom/bug45331-expected.png: Added.
  • platform/chromium-win/svg/custom/bug45331-expected.txt: Added.
  • platform/chromium-win/svg/foreignObject: Added.
  • platform/chromium-win/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.checksum: Added.
  • platform/chromium-win/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.png: Added.
  • platform/chromium-win/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.txt: Added.
  • platform/chromium-win/svg/foreignObject/svg-document-as-direct-child-expected.checksum: Added.
  • platform/chromium-win/svg/foreignObject/svg-document-as-direct-child-expected.png: Added.
  • platform/chromium-win/svg/foreignObject/svg-document-as-direct-child-expected.txt: Added.
  • platform/chromium-win/svg/foreignObject/svg-document-in-html-document-expected.checksum: Added.
  • platform/chromium-win/svg/foreignObject/svg-document-in-html-document-expected.png: Added.
  • platform/chromium-win/svg/foreignObject/svg-document-in-html-document-expected.txt: Added.
  • platform/chromium-win/svg/foreignObject/text-tref-02-b-expected.checksum: Added.
  • platform/chromium-win/svg/foreignObject/text-tref-02-b-expected.png: Added.
  • platform/chromium-win/svg/foreignObject/text-tref-02-b-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
1:44 AM Changeset in webkit [61675] by abarth@webkit.org
  • 13 edits
    4 moves in trunk/WebCore

2010-06-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Rename the preload scanners
​https://bugs.webkit.org/show_bug.cgi?id=41052

Renames PreloadScanner to LegacyPreloadScanner because this code is now
off by default. Also, rename HTML5PreloadScanner to
HTMLPreloadScanner. We're not calling it PreloadScanner because we've
factored out the CSSPreloadScanner and the HTMLPreloadScanner from the
original PreloadScanner.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTML5PreloadScanner.cpp: Removed.
  • html/HTML5PreloadScanner.h: Removed.
  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::pumpTokenizer):
  • html/HTMLDocumentParser.h:
  • html/HTMLPreloadScanner.cpp: Copied from WebCore/html/HTML5PreloadScanner.cpp. (WebCore::HTMLPreloadScanner::HTMLPreloadScanner): (WebCore::HTMLPreloadScanner::appendToEnd): (WebCore::HTMLPreloadScanner::scan): (WebCore::HTMLPreloadScanner::processToken): (WebCore::HTMLPreloadScanner::scanningBody):
  • html/HTMLPreloadScanner.h: Copied from WebCore/html/HTML5PreloadScanner.h.
  • html/LegacyHTMLDocumentParser.cpp: (WebCore::LegacyHTMLDocumentParser::scriptHandler): (WebCore::LegacyHTMLDocumentParser::scriptExecution):
  • html/LegacyHTMLDocumentParser.h:
  • html/LegacyPreloadScanner.cpp: Copied from WebCore/html/PreloadScanner.cpp. (WebCore::LegacyPreloadScanner::LegacyPreloadScanner): (WebCore::LegacyPreloadScanner::~LegacyPreloadScanner): (WebCore::LegacyPreloadScanner::begin): (WebCore::LegacyPreloadScanner::end): (WebCore::LegacyPreloadScanner::reset): (WebCore::LegacyPreloadScanner::scanningBody): (WebCore::LegacyPreloadScanner::write): (WebCore::LegacyPreloadScanner::clearLastCharacters): (WebCore::LegacyPreloadScanner::rememberCharacter): (WebCore::LegacyPreloadScanner::lastCharactersMatch): (WebCore::LegacyPreloadScanner::consumeEntity): (WebCore::LegacyPreloadScanner::tokenize): (WebCore::LegacyPreloadScanner::processAttribute): (WebCore::LegacyPreloadScanner::emitCharacter): (WebCore::LegacyPreloadScanner::tokenizeCSS): (WebCore::LegacyPreloadScanner::emitTag): (WebCore::LegacyPreloadScanner::emitCSSRule):
  • html/LegacyPreloadScanner.h: Copied from WebCore/html/PreloadScanner.h.
  • html/PreloadScanner.cpp: Removed.
  • html/PreloadScanner.h: Removed.
  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::decodeHTMLEntities):
1:33 AM Changeset in webkit [61674] by abarth@webkit.org
  • 13 edits
    4 moves in trunk/WebCore

2010-06-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Yet more HTML5 => HTML renames
​https://bugs.webkit.org/show_bug.cgi?id=41051

This patch renames HTML5DocumentParser to HTMLDocumentParser and
HTML5TreeBuilder to HTMLTreeBuilder. There was some discussion about
whether to use the name HTMLTreeBuilder or HTMLTreeConstructor, but
tree builder seems to be the dominate name in other implementations.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DocumentFragment.cpp: (WebCore::DocumentFragment::parseHTML):
  • html/HTML5DocumentParser.cpp: Removed.
  • html/HTML5DocumentParser.h: Removed.
  • html/HTML5PreloadScanner.cpp: (WebCore::HTML5PreloadScanner::scan): (WebCore::HTML5PreloadScanner::processToken):
  • html/HTML5TreeBuilder.cpp: Removed.
  • html/HTML5TreeBuilder.h: Removed.
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::createParser):
  • html/HTMLDocumentParser.cpp: Copied from WebCore/html/HTML5DocumentParser.cpp. (WebCore::HTMLDocumentParser::HTMLDocumentParser): (WebCore::HTMLDocumentParser::~HTMLDocumentParser): (WebCore::HTMLDocumentParser::begin): (WebCore::HTMLDocumentParser::stopParsing): (WebCore::HTMLDocumentParser::processingData): (WebCore::HTMLDocumentParser::pumpTokenizerIfPossible): (WebCore::HTMLDocumentParser::isScheduledForResume): (WebCore::HTMLDocumentParser::resumeParsingAfterYield): (WebCore::HTMLDocumentParser::runScriptsForPausedTreeConstructor): (WebCore::HTMLDocumentParser::pumpTokenizer): (WebCore::HTMLDocumentParser::willPumpLexer): (WebCore::HTMLDocumentParser::didPumpLexer): (WebCore::HTMLDocumentParser::write): (WebCore::HTMLDocumentParser::end): (WebCore::HTMLDocumentParser::attemptToEnd): (WebCore::HTMLDocumentParser::endIfDelayed): (WebCore::HTMLDocumentParser::finish): (WebCore::HTMLDocumentParser::finishWasCalled): (WebCore::HTMLDocumentParser::executingScript): (WebCore::HTMLDocumentParser::inScriptExecution): (WebCore::HTMLDocumentParser::lineNumber): (WebCore::HTMLDocumentParser::columnNumber): (WebCore::HTMLDocumentParser::htmlTreeConstructor): (WebCore::HTMLDocumentParser::isWaitingForScripts): (WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution): (WebCore::HTMLDocumentParser::watchForLoad): (WebCore::HTMLDocumentParser::stopWatchingForLoad): (WebCore::HTMLDocumentParser::shouldLoadExternalScriptFromSrc): (WebCore::HTMLDocumentParser::notifyFinished): (WebCore::HTMLDocumentParser::executeScriptsWaitingForStylesheets): (WebCore::HTMLDocumentParser::script):
  • html/HTMLDocumentParser.h: Copied from WebCore/html/HTML5DocumentParser.h.
  • html/HTMLParserScheduler.cpp: (WebCore::HTMLParserScheduler::HTMLParserScheduler):
  • html/HTMLParserScheduler.h:
  • html/HTMLTreeBuilder.cpp: Copied from WebCore/html/HTML5TreeBuilder.cpp. (WebCore::HTMLTreeBuilder::HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::~HTMLTreeBuilder): (WebCore::HTMLTreeBuilder::handleScriptStartTag): (WebCore::HTMLTreeBuilder::handleScriptEndTag): (WebCore::HTMLTreeBuilder::takeScriptToProcess): (WebCore::HTMLTreeBuilder::adjustedLexerState): (WebCore::HTMLTreeBuilder::passTokenToLegacyParser): (WebCore::HTMLTreeBuilder::constructTreeFromToken): (WebCore::HTMLTreeBuilder::processToken): (WebCore::HTMLTreeBuilder::finished): (WebCore::HTMLTreeBuilder::isScriptingFlagEnabled):
  • html/HTMLTreeBuilder.h: Copied from WebCore/html/HTML5TreeBuilder.h.
1:18 AM Changeset in webkit [61673] by abarth@webkit.org
  • 18 edits
    4 moves in trunk/WebCore

2010-06-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

More HTML5 => HTML renames
​https://bugs.webkit.org/show_bug.cgi?id=41049

This patch renames HTML5ScriptRunner, HTML5ScriptRunnerHost, and
HTML5Token to remove the "5" from their names. These clases aren't
specific to HTML5 and will be used going forward.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/CSSPreloadScanner.cpp: (WebCore::CSSPreloadScanner::scan):
  • html/CSSPreloadScanner.h:
  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::HTML5DocumentParser): (WebCore::HTML5DocumentParser::notifyFinished):
  • html/HTML5DocumentParser.h:
  • html/HTML5PreloadScanner.cpp: (WebCore::HTMLNames::PreloadTask::PreloadTask): (WebCore::HTMLNames::PreloadTask::processAttributes): (WebCore::HTML5PreloadScanner::processToken):
  • html/HTML5PreloadScanner.h:
  • html/HTML5ScriptRunner.cpp: Removed.
  • html/HTML5ScriptRunner.h: Removed.
  • html/HTML5ScriptRunnerHost.h: Removed.
  • html/HTML5Token.h: Removed.
  • html/HTML5TreeBuilder.cpp: (WebCore::convertToOldStyle): (WebCore::HTML5TreeBuilder::handleScriptEndTag): (WebCore::HTML5TreeBuilder::passTokenToLegacyParser): (WebCore::HTML5TreeBuilder::constructTreeFromToken): (WebCore::HTML5TreeBuilder::processToken):
  • html/HTML5TreeBuilder.h:
  • html/HTMLScriptRunner.cpp: Copied from WebCore/html/HTML5ScriptRunner.cpp. (WebCore::HTMLScriptRunner::HTMLScriptRunner): (WebCore::HTMLScriptRunner::~HTMLScriptRunner): (WebCore::HTMLScriptRunner::sourceFromPendingScript): (WebCore::HTMLScriptRunner::isPendingScriptReady): (WebCore::HTMLScriptRunner::executePendingScript): (WebCore::HTMLScriptRunner::executeScript): (WebCore::HTMLScriptRunner::hasScriptsWaitingForLoad): (WebCore::HTMLScriptRunner::watchForLoad): (WebCore::HTMLScriptRunner::stopWatchingForLoad): (WebCore::HTMLScriptRunner::execute): (WebCore::HTMLScriptRunner::haveParsingBlockingScript): (WebCore::HTMLScriptRunner::executeParsingBlockingScripts): (WebCore::HTMLScriptRunner::executeScriptsWaitingForLoad): (WebCore::HTMLScriptRunner::executeScriptsWaitingForStylesheets): (WebCore::HTMLScriptRunner::requestScript): (WebCore::HTMLScriptRunner::runScript):
  • html/HTMLScriptRunner.h: Copied from WebCore/html/HTML5ScriptRunner.h.
  • html/HTMLScriptRunnerHost.h: Copied from WebCore/html/HTML5ScriptRunnerHost.h. (WebCore::HTMLScriptRunnerHost::~HTMLScriptRunnerHost):
  • html/HTMLToken.h: Copied from WebCore/html/HTML5Token.h. (WebCore::HTMLToken::HTMLToken):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::nextToken): (WebCore::HTMLTokenizer::emitCharacter): (WebCore::HTMLTokenizer::emitCurrentToken): (WebCore::HTMLTokenizer::shouldEmitBufferedCharacterToken):
  • html/HTMLTokenizer.h:
12:49 AM Changeset in webkit [61672] by abarth@webkit.org
  • 9 edits
    2 moves in trunk/WebCore

2010-06-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Rename HTML5EntityParser to HTMLEntityParser
​https://bugs.webkit.org/show_bug.cgi?id=41048

Mostly the result of do-webcore-rename, but I tweaked the header guard
and the name of the free function.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTML5EntityParser.cpp: Removed.
  • html/HTML5EntityParser.h: Removed.
  • html/HTMLEntityParser.cpp: Copied from WebCore/html/HTML5EntityParser.cpp. (WebCore::consumeHTMLEntity):
  • html/HTMLEntityParser.h: Copied from WebCore/html/HTML5EntityParser.h.
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::processEntity): (WebCore::HTMLTokenizer::nextToken):
12:37 AM Changeset in webkit [61671] by morrita@google.com
  • 9 edits
    6 adds in trunk

2010-06-22 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Alexey Proskuryakov.

Add a new class that stores information about WebSocket handshake response.

In the future, instances of the new class will be passed to the Web Inspector
so that it will be able to display information about WebSocket handshake
response.

WebSocket: Add WebSocketHandshakeResponse
​https://bugs.webkit.org/show_bug.cgi?id=38728

Test: websocket/tests/handshake-fail-by-no-cr.html

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • websockets/WebSocketHandshake.cpp: (WebCore::trimConsoleMessage): (WebCore::WebSocketHandshake::readServerHandshake): (WebCore::WebSocketHandshake::serverHandshakeResponse): (WebCore::WebSocketHandshake::readStatusLine): Moved from extractResponseCode. Add more error checks and make error messages more descriptive. (WebCore::WebSocketHandshake::readHTTPHeaders): (WebCore::WebSocketHandshake::processHeaders):
  • websockets/WebSocketHandshake.h:
  • websockets/WebSocketHandshakeResponse.cpp: Added. (WebCore::WebSocketHandshakeResponse::ChallengeResponse::ChallengeResponse): (WebCore::WebSocketHandshakeResponse::ChallengeResponse::set): (WebCore::WebSocketHandshakeResponse::WebSocketHandshakeResponse): (WebCore::WebSocketHandshakeResponse::~WebSocketHandshakeResponse): (WebCore::WebSocketHandshakeResponse::statusCode): (WebCore::WebSocketHandshakeResponse::setStatusCode): (WebCore::WebSocketHandshakeResponse::statusText): (WebCore::WebSocketHandshakeResponse::setStatusText): (WebCore::WebSocketHandshakeResponse::headerFields): (WebCore::WebSocketHandshakeResponse::addHeaderField): (WebCore::WebSocketHandshakeResponse::clearHeaderFields): (WebCore::WebSocketHandshakeResponse::challengeResponse): (WebCore::WebSocketHandshakeResponse::setChallengeResponse):
  • websockets/WebSocketHandshakeResponse.h: Added.
12:30 AM Changeset in webkit [61670] by yuzo@google.com
  • 26 edits
    2 adds in trunk

2010-06-23 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Implement page format data programming interface.
​https://bugs.webkit.org/show_bug.cgi?id=37538

  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • printing/page-format-data-expected.txt: Added.
  • printing/page-format-data.html: Added.

2010-06-23 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Implement page format data programming interface.
The final goal is to implement CSS Paged Media Module Level 3 (​http://dev.w3.org/csswg/css3-page/).
To begin with, this change adds methods to know:

  • if page box is visible,
  • the page area rectangle, and
  • preferred page size.

​https://bugs.webkit.org/show_bug.cgi?id=37538

Test: printing/page-format-data.html

  • WebCore.base.exp:
  • css/CSSParser.cpp: (WebCore::CSSParser::parseSizeParameter):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::applyPageSizeProperty): (WebCore::CSSStyleSelector::pageSizeFromName): (WebCore::CSSStyleSelector::mmLength): (WebCore::CSSStyleSelector::inchLength):
  • css/CSSStyleSelector.h:
  • css/html.css: (@page):
  • dom/Document.cpp: (WebCore::Document::isPageBoxVisible): (WebCore::Document::pageAreaRectInPixels): (WebCore::Document::preferredPageSizeInPixels):
  • dom/Document.h:
  • page/PrintContext.cpp: (WebCore::PrintContext::isPageBoxVisible): (WebCore::PrintContext::pageAreaRectInPixels): (WebCore::PrintContext::preferredPageSizeInPixels):
  • page/PrintContext.h:
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::pageSize): (WebCore::InheritedFlags::setPageSize):
  • rendering/style/StyleRareNonInheritedData.h:

2010-06-23 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Implement page format data programming interface.
Add methods for testing.
​https://bugs.webkit.org/show_bug.cgi?id=37538

  • Misc/WebCoreStatistics.h:
  • Misc/WebCoreStatistics.mm: (-[WebFrame isPageBoxVisible:]): (-[WebFrame pageAreaRectInPixels:]): (-[WebFrame preferredPageSizeInPixels:]):

2010-06-23 Yuzo Fujishima <​yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Implement page format data programming interface.
Add methods for testing.
​https://bugs.webkit.org/show_bug.cgi?id=37538

  • DumpRenderTree/LayoutTestController.cpp: (parsePageNumber): (isPageBoxVisibleCallback): (pageAreaRectInPixelsCallback): (preferredPageSizeInPixelsCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::isPageBoxVisible): (LayoutTestController::pageAreaRectInPixels): (LayoutTestController::preferredPageSizeInPixels):
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::isPageBoxVisible): (LayoutTestController::pageAreaRectInPixels): (LayoutTestController::preferredPageSizeInPixels):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::isPageBoxVisible): (LayoutTestController::pageAreaRectInPixels): (LayoutTestController::preferredPageSizeInPixels):
12:19 AM Changeset in webkit [61669] by Nikolas Zimmermann
  • 1 edit
    4 adds in trunk/LayoutTests

2010-06-23 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Forgot to include four files in the last commit.

  • platform/mac/svg/custom/bug45331-expected.checksum: Added.
  • platform/mac/svg/custom/bug45331-expected.png: Added.
  • platform/mac/svg/custom/bug45331-expected.txt: Added.
  • svg/custom/bug45331.svg: Added.
12:16 AM Changeset in webkit [61668] by abarth@webkit.org
  • 9 edits in trunk/WebCore

2010-06-23 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Rename lexer and m_lexer to tokenizer and m_tokenizer, respectively
​https://bugs.webkit.org/show_bug.cgi?id=41046

This is a follow up to the recent HTML5Lexer => HTMLTokenizer rename.

  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::HTML5DocumentParser): (WebCore::HTML5DocumentParser::begin): (WebCore::HTML5DocumentParser::pumpLexer): (WebCore::HTML5DocumentParser::willPumpLexer): (WebCore::HTML5DocumentParser::didPumpLexer): (WebCore::HTML5DocumentParser::lineNumber): (WebCore::HTML5DocumentParser::columnNumber):
  • html/HTML5DocumentParser.h:
  • html/HTML5PreloadScanner.cpp: (WebCore::HTML5PreloadScanner::scan): (WebCore::HTML5PreloadScanner::processToken):
  • html/HTML5PreloadScanner.h:
  • html/HTML5TreeBuilder.cpp: (WebCore::HTML5TreeBuilder::HTML5TreeBuilder): (WebCore::HTML5TreeBuilder::handleScriptStartTag): (WebCore::HTML5TreeBuilder::passTokenToLegacyParser):
  • html/HTML5TreeBuilder.h:
  • html/HTMLTokenizer.h:
  • html/LegacyHTMLDocumentParser.h:
12:11 AM Changeset in webkit [61667] by Nikolas Zimmermann
  • 6 edits
    22 adds in trunk

2010-06-23 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Eric Seidel.

Reproducible crash in com.apple.WebCore 0x01ed3784 WebCore::RenderLineBoxList::appendLineBox(WebCore::InlineFlowBox*) + 36
​https://bugs.webkit.org/show_bug.cgi?id=40953

REGRESSION (r58209-58231): Memory corruption with invalid SVG
​https://bugs.webkit.org/show_bug.cgi?id=40173

Fix several crashes, all related to <foreignObject> and/or invalid SVG documents.

  • Only allow <svg> nodes, as direct children of a <foreignObject>, not any other "partial" SVG content.
  • Assure to create RenderSVGRoot objects for <svg> nodes in <foreignObject>, treat them as "outermost SVG elements".
  • Never allow any partial SVG content to appear in any document. Only <svg> elements are allowed.

Tests: svg/custom/bug45331.svg

svg/foreignObject/disallowed-svg-nodes-as-direct-children.svg
svg/foreignObject/no-crash-with-svg-content-in-html-document.svg
svg/foreignObject/svg-document-as-direct-child.svg
svg/foreignObject/svg-document-in-html-document.svg
svg/foreignObject/text-tref-02-b.svg

  • dom/Element.cpp: Added childShouldCreateRenderer, with ENABLE(SVG) guards. (WebCore::Element::childShouldCreateRenderer): Only create a renderer for a SVG child, if we're a SVG element, or if the child is a <svg> element.
  • dom/Element.h: Added childShouldCreateRenderer, with ENABLE(SVG) guards.
  • svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::childShouldCreateRenderer): Disallow arbitary SVG content, only <svg> elements are allowed as direct children of a <foreignObject>
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::isOutermostSVG): Be sure to create RenderSVGRoot objects for <svg> elements inside <foreignObject>

2010-06-23 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Eric Seidel.

Reproducible crash in com.apple.WebCore 0x01ed3784 WebCore::RenderLineBoxList::appendLineBox(WebCore::InlineFlowBox*) + 36
​https://bugs.webkit.org/show_bug.cgi?id=40953

REGRESSION (r58209-58231): Memory corruption with invalid SVG
​https://bugs.webkit.org/show_bug.cgi?id=40173

Added several new layout tests covering the crashes with <foreignObject> and/or invalid SVG documents.

  • platform/mac/svg/custom/bug45331-expected.checksum: Added.
  • platform/mac/svg/custom/bug45331-expected.png: Added.
  • platform/mac/svg/custom/bug45331-expected.txt: Added.
  • platform/mac/svg/foreignObject: Added.
  • platform/mac/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.checksum: Added.
  • platform/mac/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.png: Added.
  • platform/mac/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.txt: Added.
  • platform/mac/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.checksum: Added.
  • platform/mac/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.png: Added.
  • platform/mac/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.txt: Added.
  • platform/mac/svg/foreignObject/svg-document-as-direct-child-expected.checksum: Added.
  • platform/mac/svg/foreignObject/svg-document-as-direct-child-expected.png: Added.
  • platform/mac/svg/foreignObject/svg-document-as-direct-child-expected.txt: Added.
  • platform/mac/svg/foreignObject/svg-document-in-html-document-expected.checksum: Added.
  • platform/mac/svg/foreignObject/svg-document-in-html-document-expected.png: Added.
  • platform/mac/svg/foreignObject/svg-document-in-html-document-expected.txt: Added.
  • platform/mac/svg/foreignObject/text-tref-02-b-expected.checksum: Added.
  • platform/mac/svg/foreignObject/text-tref-02-b-expected.png: Added.
  • platform/mac/svg/foreignObject/text-tref-02-b-expected.txt: Added.
  • svg/custom/bug45331.svg: Added.
  • svg/foreignObject: Added.
  • svg/foreignObject/disallowed-svg-nodes-as-direct-children.svg: Added.
  • svg/foreignObject/no-crash-with-svg-content-in-html-document.svg: Added.
  • svg/foreignObject/svg-document-as-direct-child.svg: Added.
  • svg/foreignObject/svg-document-in-html-document.svg: Added.
  • svg/foreignObject/text-tref-02-b.svg: Added.
12:11 AM Changeset in webkit [61666] by hamaji@chromium.org
  • 3 edits in trunk/WebKitTools

2010-06-23 Sam Magnuson <​smagnuson@netflix.com>

Reviewed by Shinichiro Hamaji.

Follow proper convention for if/switch/while as I've discovered
them to be through my review processes.
​https://bugs.webkit.org/show_bug.cgi?id=40723

Modified test so that if( foo ) is not allowed as it appears not
to be the accepted convention.

  • Scripts/webkitpy/style/checkers/cpp.py:
  • Scripts/webkitpy/style/checkers/cpp_unittest.py:
12:02 AM Changeset in webkit [61665] by abarth@webkit.org
  • 14 edits
    2 moves in trunk/WebCore

2010-06-22 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Rename HTML5Lexer to HTMLTokenizer
​https://bugs.webkit.org/show_bug.cgi?id=41045

This might be slightly confusing given that the old class was called
HTMLTokenizer, but it matches the terminology in the HTML5 spec.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::HTML5DocumentParser): (WebCore::HTML5DocumentParser::pumpLexer):
  • html/HTML5DocumentParser.h:
  • html/HTML5Lexer.cpp: Removed.
  • html/HTML5Lexer.h: Removed.
  • html/HTML5PreloadScanner.cpp: (WebCore::HTML5PreloadScanner::processToken):
  • html/HTML5PreloadScanner.h:
  • html/HTML5TreeBuilder.cpp: (WebCore::HTML5TreeBuilder::HTML5TreeBuilder): (WebCore::HTML5TreeBuilder::handleScriptStartTag): (WebCore::HTML5TreeBuilder::adjustedLexerState):
  • html/HTML5TreeBuilder.h:
  • html/HTMLTokenizer.cpp: Copied from WebCore/html/HTML5Lexer.cpp. (WebCore::HTMLNames::isEndTagBufferingState): (WebCore::HTMLTokenizer::HTMLTokenizer): (WebCore::HTMLTokenizer::~HTMLTokenizer): (WebCore::HTMLTokenizer::reset): (WebCore::HTMLTokenizer::processEntity): (WebCore::HTMLTokenizer::nextToken): (WebCore::HTMLTokenizer::temporaryBufferIs): (WebCore::HTMLTokenizer::addToPossibleEndTag): (WebCore::HTMLTokenizer::isAppropriateEndTag): (WebCore::HTMLTokenizer::emitCharacter): (WebCore::HTMLTokenizer::emitCodePoint): (WebCore::HTMLTokenizer::emitParseError): (WebCore::HTMLTokenizer::emitCurrentToken): (WebCore::HTMLTokenizer::shouldEmitBufferedCharacterToken):
  • html/HTMLTokenizer.h: Copied from WebCore/html/HTML5Lexer.h.

Jun 22, 2010:

11:54 PM Changeset in webkit [61664] by Simon Hausmann
  • 2 edits in trunk/WebCore

Unreviewed Qt/Symbian build fix.

Fix "make clean" to not try to execute clean commands for
the extra targets we use to simulate "make install".

  • WebCore.pro: Use no_clean in CONFIG of extra compilers.
11:44 PM Changeset in webkit [61663] by eric@webkit.org
  • 53 edits in trunk

2010-06-22 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Run clean-header-guards to fix some header guards
​https://bugs.webkit.org/show_bug.cgi?id=41044

No functional changes, thus no tests.

This entire change was generated by running
clean-header-guards, and then reverting changes
to files which shouldn't be changed. Those which
are left all should be updated.

Some of these changes are just fixing 755 permissions
to be 644, since it seems various files have the wrong
execute bit which don't need it. clean-header-guards
made those (welcome) permission fixes unintentionally.

  • bindings/v8/custom/V8HTMLAudioElementConstructor.h:
  • bindings/v8/custom/V8HTMLImageElementConstructor.h:
  • bindings/v8/custom/V8HTMLOptionElementConstructor.h:
  • dom/Touch.h:
  • dom/TouchList.h:
  • dom/XMLDocumentParser.h:
  • dom/XMLDocumentParserScope.h:
  • html/HTML5DocumentParser.h:
  • html/LegacyHTMLTreeConstructor.h:
  • loader/CrossOriginPreflightResultCache.h:
  • page/OriginAccessEntry.h:
  • page/win/FrameWin.h:
  • platform/ThreadTimers.h:
  • platform/chromium/KeyboardCodes.h:
  • platform/graphics/chromium/FontPlatformDataChromiumWin.h:
  • platform/graphics/chromium/FontUtilsChromiumWin.h:
  • platform/graphics/filters/FEBlend.h:
  • platform/graphics/filters/FEColorMatrix.h:
  • platform/graphics/filters/FEComponentTransfer.h:
  • platform/graphics/filters/FEComposite.h:
  • platform/graphics/gstreamer/DataSourceGStreamer.h:
  • platform/graphics/gstreamer/VideoSinkGStreamer.h:
    • I checked, this crazy define was not referenced anywhere else. It's safe to change the name. :)
  • platform/graphics/haiku/FontPlatformData.h:
  • platform/graphics/qt/FontCustomPlatformData.h:
  • platform/graphics/skia/SkiaFontWin.h:
  • platform/graphics/win/GraphicsLayerCACF.h:
  • platform/graphics/win/QTMovieWinTimer.h:
  • platform/graphics/win/RefCountedGDIHandle.h:
  • platform/graphics/win/WebLayer.h:
  • platform/graphics/win/WebTiledLayer.h:
  • platform/graphics/wince/FontPlatformData.h:
  • platform/graphics/wx/FontPlatformData.h:
  • platform/network/CredentialStorage.h:
  • platform/network/cf/FormDataStreamCFNet.h:
  • platform/network/curl/FormDataStreamCurl.h:
  • platform/network/qt/DnsPrefetchHelper.h:
  • platform/network/qt/QNetworkReplyHandler.h:
  • platform/win/PlatformScrollBar.h:
  • plugins/PluginDatabase.h:
  • plugins/PluginPackage.h:
  • plugins/PluginStream.h:
  • plugins/qt/PluginContainerQt.h:
  • plugins/symbian/npinterface.h:
  • rendering/RenderSelectionInfo.h:
  • rendering/SVGRenderSupport.h:
  • storage/IDBObjectStoreImpl.h:
  • svg/animation/SMILTimeContainer.h:
  • wml/WMLErrorHandling.h:

2010-06-22 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Run clean-header-guards to fix some header guards
​https://bugs.webkit.org/show_bug.cgi?id=41044

No functional changes, thus no tests.

This entire change was generated by running
clean-header-guards, and then reverting changes
to files which shouldn't be changed. Those which
are left all should be updated.

Some of these changes are just fixing 755 permissions
to be 644, since it seems various files have the wrong
execute bit which don't need it. clean-header-guards
made those (welcome) permission fixes unintentionally.

  • DumpRenderTree/chromium/WebThemeControlDRT.h:
  • DumpRenderTree/chromium/WebThemeEngineDRT.h:
  • QtTestBrowser/fpstimer.h:
11:41 PM Changeset in webkit [61662] by abarth@webkit.org
  • 29 edits
    2 moves in trunk

2010-06-22 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Rename HTMLDocumentParser to LegacyHTMLDocumentParser
​https://bugs.webkit.org/show_bug.cgi?id=41043

  • src/WebEntities.cpp:

2010-06-22 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Rename HTMLDocumentParser to LegacyHTMLDocumentParser
​https://bugs.webkit.org/show_bug.cgi?id=41043

As requested by Darin Adler.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::checkLoaded):
  • dom/Document.cpp: (WebCore::Document::write):
  • dom/DocumentFragment.cpp:
  • dom/DocumentParser.h: (WebCore::DocumentParser::asHTMLDocumentParser):
  • dom/XMLDocumentParserLibxml2.cpp:
  • dom/XMLDocumentParserQt.cpp:
  • html/HTML5Lexer.h: (WebCore::HTML5Lexer::columnNumber):
  • html/HTML5TreeBuilder.cpp:
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::createParser):
  • html/HTMLDocumentParser.cpp: Removed.
  • html/HTMLDocumentParser.h: Removed.
  • html/HTMLFormControlElement.cpp:
  • html/HTMLParserScheduler.cpp: (WebCore::parserChunkSize):
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createParser): (WebCore::HTMLViewSourceDocument::addViewSourceToken):
  • html/HTMLViewSourceDocument.h:
  • html/LegacyHTMLDocumentParser.cpp: Copied from WebCore/html/HTMLDocumentParser.cpp. (WebCore::LegacyHTMLDocumentParser::LegacyHTMLDocumentParser): (WebCore::LegacyHTMLDocumentParser::reset): (WebCore::LegacyHTMLDocumentParser::begin): (WebCore::LegacyHTMLDocumentParser::setForceSynchronous): (WebCore::LegacyHTMLDocumentParser::processListing): (WebCore::LegacyHTMLDocumentParser::parseNonHTMLText): (WebCore::LegacyHTMLDocumentParser::scriptHandler): (WebCore::LegacyHTMLDocumentParser::scriptExecution): (WebCore::LegacyHTMLDocumentParser::parseComment): (WebCore::LegacyHTMLDocumentParser::parseServer): (WebCore::LegacyHTMLDocumentParser::parseProcessingInstruction): (WebCore::LegacyHTMLDocumentParser::parseText): (WebCore::LegacyHTMLDocumentParser::parseEntity): (WebCore::LegacyHTMLDocumentParser::parseDoctype): (WebCore::LegacyHTMLDocumentParser::parseTag): (WebCore::LegacyHTMLDocumentParser::continueProcessing): (WebCore::LegacyHTMLDocumentParser::advance): (WebCore::LegacyHTMLDocumentParser::willWriteHTML): (WebCore::LegacyHTMLDocumentParser::didWriteHTML): (WebCore::LegacyHTMLDocumentParser::write): (WebCore::LegacyHTMLDocumentParser::stopParsing): (WebCore::LegacyHTMLDocumentParser::processingData): (WebCore::LegacyHTMLDocumentParser::timerFired): (WebCore::LegacyHTMLDocumentParser::end): (WebCore::LegacyHTMLDocumentParser::finish): (WebCore::LegacyHTMLDocumentParser::finishWasCalled): (WebCore::LegacyHTMLDocumentParser::processToken): (WebCore::LegacyHTMLDocumentParser::processDoctypeToken): (WebCore::LegacyHTMLDocumentParser::~LegacyHTMLDocumentParser): (WebCore::LegacyHTMLDocumentParser::enlargeBuffer): (WebCore::LegacyHTMLDocumentParser::enlargeScriptBuffer): (WebCore::LegacyHTMLDocumentParser::executeScriptsWaitingForStylesheets): (WebCore::LegacyHTMLDocumentParser::notifyFinished): (WebCore::LegacyHTMLDocumentParser::executeExternalScriptsIfReady): (WebCore::LegacyHTMLDocumentParser::executeExternalScriptsTimerFired): (WebCore::LegacyHTMLDocumentParser::continueExecutingExternalScripts): (WebCore::LegacyHTMLDocumentParser::isWaitingForScripts): (WebCore::LegacyHTMLDocumentParser::setSrc): (WebCore::parseLegacyHTMLDocumentFragment):
  • html/LegacyHTMLDocumentParser.h: Copied from WebCore/html/HTMLDocumentParser.h. (WebCore::LegacyHTMLDocumentParser::asHTMLDocumentParser):
  • html/LegacyHTMLTreeConstructor.cpp: (WebCore::LegacyHTMLTreeConstructor::reportErrorToConsole):
  • html/LegacyHTMLTreeConstructor.h:
  • loader/FTPDirectoryDocument.cpp: (WebCore::FTPDirectoryDocumentParser::FTPDirectoryDocumentParser): (WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate): (WebCore::FTPDirectoryDocumentParser::finish):
  • page/XSSAuditor.h:

2010-06-22 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Rename HTMLDocumentParser to LegacyHTMLDocumentParser
​https://bugs.webkit.org/show_bug.cgi?id=41043

Update the hash.

  • Scripts/do-webcore-rename:
11:35 PM Changeset in webkit [61661] by hamaji@chromium.org
  • 2 edits in trunk/WebCore

2010-06-22 Shinichiro Hamaji <​hamaji@chromium.org>

Unreviewed attempt to fix the windows build.

Split out HTML5DocumentParser yield/resume logic into a separate class
​https://bugs.webkit.org/show_bug.cgi?id=41018

  • WebCore.vcproj/WebCore.vcproj:
11:30 PM Changeset in webkit [61660] by hamaji@chromium.org
  • 3 edits in trunk/WebKitTools

2010-06-22 Sam Magnuson <​smagnuson@netflix.com>

Reviewed by Shinichiro Hamaji.

Follow proper convention for variable declaration spacing.
​https://bugs.webkit.org/show_bug.cgi?id=40724

Modified test so that 'int a;' is not allowed.

  • Scripts/webkitpy/style/checkers/cpp.py:
  • Scripts/webkitpy/style/checkers/cpp_unittest.py:
11:29 PM Changeset in webkit [61659] by pfeldman@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-06-22 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: follow up to r61655 to make Chromium tests happy.

  • src/js/InspectorControllerImpl.js: (devtools.InspectorBackendImpl):
11:18 PM Changeset in webkit [61658] by eric@webkit.org
  • 9 edits
    2 adds in trunk/WebCore

2010-06-22 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Split out HTML5DocumentParser yield/resume logic into a separate class
​https://bugs.webkit.org/show_bug.cgi?id=41018

The HTML5DocumentParser is just the coordinator, and shouldn't have
any real parsing logic of his own. Continuing along that path, I'm
moving the when-to-yield/resume logic out into a separate class.

I could have create a new HTMLParserSchedulerHost virtual interface
to allow the HTMLParserScheduler to talk back to the
HTML5DocumentParser, but instead I just exposed the one method it
needs (resumeParsing()) as a public method. Since no code besides
HTMLDocument (and DocumentFrament) ever should know about the
HTML5DocumentParser DocumentParser subclass, no class should ever
see the resumeParsing() method anyway.

Most of this change is just moving code from HTML5DocumentParser
to the new HTMLParserScheduler.

Some of this change is wrapping previous direct access to
m_continueNextChunkTimer.isActive() with isScheduledForResume().

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::HTML5DocumentParser): (WebCore::HTML5DocumentParser::stopParsing): (WebCore::HTML5DocumentParser::processingData): (WebCore::HTML5DocumentParser::pumpLexerIfPossible): (WebCore::HTML5DocumentParser::isScheduledForResume): (WebCore::HTML5DocumentParser::resumeParsing): (WebCore::HTML5DocumentParser::pumpLexer): (WebCore::HTML5DocumentParser::end): (WebCore::HTML5DocumentParser::attemptToEnd): (WebCore::HTML5DocumentParser::endIfDelayed):
  • html/HTML5DocumentParser.h: (WebCore::HTML5DocumentParser::document):
    • Exposed for HTMLParserScheduler.
  • html/HTMLParserScheduler.cpp: Added. (WebCore::parserTimeLimit): Moved from HTML5DocumentParser. (WebCore::parserChunkSize): ditto. (WebCore::HTMLParserScheduler::HTMLParserScheduler): (WebCore::HTMLParserScheduler::~HTMLParserScheduler): (WebCore::isLayoutTimerActive): (WebCore::HTMLParserScheduler::continueNextChunkTimerFired):
    • Moved from HTML5DocumentParser.
  • html/HTMLParserScheduler.h: Added. (WebCore::HTMLParserScheduler::PumpSession::PumpSession):
    • Moved from HTML5DocumentParser.

(WebCore::HTMLParserScheduler::shouldContinueParsing):
(WebCore::HTMLParserScheduler::isScheduledForResume):

10:59 PM QtWebKitReleases edited by Simon Hausmann
(diff)
10:26 PM Changeset in webkit [61657] by levin@chromium.org
  • 2 edits in trunk/LayoutTests
  • platform/qt/Skipped: Added an xhr test which requires progress events

next to the other xhr test which are disabled due to requiring progress events.

Reviewed by nobody (simple qt test fix).

10:24 PM Changeset in webkit [61656] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

2010-06-22 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium/test_expectations.txt: send-data-blob.html fails.
10:17 PM Changeset in webkit [61655] by pfeldman@chromium.org
  • 15 edits in trunk/WebCore

2010-06-22 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: move nodeByPath from InjectedScript to InspectorBackend.

​https://bugs.webkit.org/show_bug.cgi?id=40988

  • inspector/InjectedScriptHost.cpp:
  • inspector/InjectedScriptHost.h:
  • inspector/InjectedScriptHost.idl:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::pushNodeByPathToFrontend):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::pushNodeByPathToFrontend): (WebCore::InspectorDOMAgent::nodeForPath):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::didPushNodeByPathToFrontend):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/DOMAgent.js:
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.setDocument):
  • inspector/front-end/InjectedScript.js:
  • inspector/front-end/InjectedScriptAccess.js:
9:39 PM Changeset in webkit [61654] by levin@chromium.org
  • 5 edits in trunk

REGRESSION: (r47291): Upload progress events are not fired for simple cross-site XHR.
​https://bugs.webkit.org/show_bug.cgi?id=39029

Reviewed by Alexey Proskuryakov.

WebCore:

Specifically, WebKit should fire upload events if one or more event listeners are
registered on the XMLHttpRequestUpload object when send is called in an async manner.

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::createRequest): Allow upload events to be fired when there are
handlers for them in the cross-origin simple request case.

LayoutTests:

  • http/tests/xmlhttprequest/simple-cross-origin-progress-events-expected.txt: Update results.
  • http/tests/xmlhttprequest/simple-cross-origin-progress-events.html: Add a test which adds an upload progress event handler before XMLHttpRequest.send() is called.
9:16 PM Changeset in webkit [61653] by kinuko@chromium.org
  • 3 edits in trunk/LayoutTests

2010-06-22 Kinuko Yasuda <​kinuko@chromium.org>

Unreviewed.

Update test expectations for qt/gtk.

  • platform/gtk/fast/js/global-constructors-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
9:13 PM Changeset in webkit [61652] by hclam@chromium.org
  • 5 edits
    2 deletes in trunk/LayoutTests

Unreviewed. Build fix.

Rebaseline some test results to make build bots green again.

  • platform/chromium-mac/fast/js/switch-behaviour-expected.txt: Removed.
  • platform/chromium-mac/websocket/tests/bad-sub-protocol-control-chars-expected.txt:
  • platform/chromium-win/fast/js/switch-behaviour-expected.txt: Removed.
  • platform/chromium-win/inspector/timeline-parse-html-expected.txt:
  • platform/chromium-win/websocket/tests/bad-sub-protocol-control-chars-expected.txt:
  • platform/chromium/test_expectations.txt:
9:10 PM Changeset in webkit [61651] by tkent@chromium.org
  • 2 edits in trunk/WebCore

2010-06-22 Kent Tamura <​tkent@chromium.org>

Reviewed by Adam Barth.

Fix uninitialized SubframeLoader::m_containsPlugins
​https://bugs.webkit.org/show_bug.cgi?id=41035

  • loader/SubframeLoader.cpp: (WebCore::SubframeLoader::SubframeLoader): Initialize m_containsPlugins with false.
8:55 PM Changeset in webkit [61650] by kinuko@chromium.org
  • 34 edits
    17 adds in trunk

2010-06-22 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Adam Barth.

Add BlobBuilder.idl to expose BlobBuilder interface
​https://bugs.webkit.org/show_bug.cgi?id=40593

(Resubmitting with the correct file set.)

BlobBuilder is defined in FileAPI's FileWriter spec.
(​http://dev.w3.org/2009/dap/file-system/file-writer.html)

Also removes the ENABLE_FILE_WRITER ifdef guard for BlobBuilder.

Tests: http/tests/local/blob/send-data-blob.html

http/tests/local/blob/send-hybrid-blob.html
http/tests/local/blob/send-sliced-data-blob.html

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/BlobBuilder.cpp: (WebCore::BlobBuilder::append):
  • html/BlobBuilder.h:
  • html/BlobBuilder.idl: Added.
  • page/DOMWindow.idl:

2010-06-22 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Adam Barth.

Add BlobBuilder.idl to expose BlobBuilder interface
​https://bugs.webkit.org/show_bug.cgi?id=40593

(Resubmitting with the correct file set.)

Add new layout tests to test BlobBuilder interface.
Also update test expectations affected by adding the constructors to DOMWindow.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • http/tests/local/blob/resources/hybrid-blob-util.js: Added.
  • http/tests/local/blob/script-tests/TEMPLATE.html: Added.
  • http/tests/local/blob/script-tests/send-data-blob.js: Added.
  • http/tests/local/blob/script-tests/send-hybrid-blob.js: Added.
  • http/tests/local/blob/script-tests/send-sliced-data-blob.js: Added.
  • http/tests/local/blob/send-data-blob-expected.txt: Added.
  • http/tests/local/blob/send-data-blob.html: Added.
  • http/tests/local/blob/send-hybrid-blob-expected.txt: Added.
  • http/tests/local/blob/send-hybrid-blob.html: Added.
  • http/tests/local/blob/send-sliced-data-blob-expected.txt: Added.
  • http/tests/local/blob/send-sliced-data-blob.html: Added.
  • http/tests/local/resources/file-for-drag-to-send2.txt: Added.
  • http/tests/resources/post-and-verify-hybrid.cgi: Added.
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/Skipped: Added send-hybrid-blob.html and send-sliced-data-blob.html because they need eventSender.beginDragWithFiles and Blob.slice.
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/Skipped: Added send-hybrid-blob.html and send-sliced-data-blob.html because they need eventSender.beginDragWithFiles and Blob.slice.
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/Skipped: Added send-hybrid-blob.html and send-sliced-data-blob.html because they need eventSender.beginDragWithFiles and Blob.slice.
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
7:12 PM Changeset in webkit [61649] by tkent@chromium.org
  • 2 edits in trunk/WebCore

2010-06-22 Kent Tamura <​tkent@chromium.org>

Unreviewed, build fix for r61648.

  • platform/graphics/GraphicsContext3D.h:
6:55 PM Changeset in webkit [61648] by tkent@chromium.org
  • 2 edits in trunk/WebCore

2010-06-22 Vangelis Kokkevis <​vangelis@chromium.org>

Reviewed by Kent Tamura.

Define GraphicsContext3D::platformLayer() for all remaining (non PLATFORM(MAC))
ports to get RenderLayerBacking.cpp compiling again.
​https://bugs.webkit.org/show_bug.cgi?id=41026

  • platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::platformLayer):
6:49 PM Changeset in webkit [61647] by commit-queue@webkit.org
  • 1 edit in trunk/ChangeLog

2010-06-22 Eric Seidel <​eric@webkit.org>

Unreviewed. Test commit for ​commit-queue@webkit.org.

6:41 PM Changeset in webkit [61646] by eric@webkit.org
  • 5 edits in trunk/WebCore

2010-06-22 Eric Seidel <​eric@webkit.org>

Unreviewed. Rolling out ​http://trac.webkit.org/changeset/61638
made a few tests crash.

Make PendingScript hold a CachedResourceClient open for its lifetime
​https://bugs.webkit.org/show_bug.cgi?id=40968

  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::watchForLoad): (WebCore::HTML5DocumentParser::notifyFinished):
  • html/HTML5ScriptRunner.cpp: (WebCore::HTML5ScriptRunner::~HTML5ScriptRunner): (WebCore::HTML5ScriptRunner::sourceFromPendingScript): (WebCore::HTML5ScriptRunner::isPendingScriptReady): (WebCore::HTML5ScriptRunner::executePendingScript): (WebCore::HTML5ScriptRunner::hasScriptsWaitingForLoad): (WebCore::HTML5ScriptRunner::watchForLoad): (WebCore::HTML5ScriptRunner::stopWatchingForLoad): (WebCore::HTML5ScriptRunner::executeScriptsWaitingForLoad): (WebCore::HTML5ScriptRunner::executeScriptsWaitingForStylesheets): (WebCore::HTML5ScriptRunner::requestScript):
  • html/HTML5ScriptRunner.h: (WebCore::HTML5ScriptRunner::PendingScript::): (WebCore::HTML5ScriptRunner::PendingScript::PendingScript): (WebCore::HTML5ScriptRunner::PendingScript::watchingForLoad):
  • html/HTML5ScriptRunnerHost.h:
6:27 PM Changeset in webkit [61645] by adele@apple.com
  • 3 edits
    2 adds in trunk

WebCore: Fix for Crash when the renderer for the button in <input type="number"> goes away during event handling
​https://bugs.webkit.org/show_bug.cgi?id=41013

Reviewed by Darin Adler.

Test: fast/forms/input-number-crash.html

  • rendering/TextControlInnerElements.cpp: (WebCore::SpinButtonElement::defaultEventHandler):

Nil check the RenderBox since its possible the renderer has gone away during event handling.

LayoutTests: Test for Crash when the renderer for the button in <input type="number"> goes away during event handling
​https://bugs.webkit.org/show_bug.cgi?id=41013

Reviewed by Darin Adler.

  • fast/forms/input-number-crash-expected.txt: Added.
  • fast/forms/input-number-crash.html: Added.
5:54 PM Changeset in webkit [61644] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-22 Eric Seidel <​eric@webkit.org>

Unreviewed. Add Tony Gentilcore now that he's a committer.

  • Scripts/webkitpy/common/config/committers.py:
5:46 PM Changeset in webkit [61643] by mrowe@apple.com
  • 5 edits in trunk

Versioning.

5:45 PM Changeset in webkit [61642] by mrowe@apple.com
  • 1 copy in tags/Safari-534.1

New tag.

5:25 PM Changeset in webkit [61641] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-22 Eric Seidel <​eric@webkit.org>

No review, skipping test due to revealed bug in ClipboardQt.

editing/execCommand/copy-without-selection.html fails on Qt after r61637
​https://bugs.webkit.org/show_bug.cgi?id=41025

The Qt Clipboard::setData code wrongly reinterpret_casts UChar
data as char* data. This was exposed by the previous commit
which no long strips \0 characters during innerHTML.

Skipping the affected test until a Qt person can fix
platform/qt/ClipboardQt.cpp

  • platform/qt/Skipped:
4:56 PM Changeset in webkit [61640] by abarth@webkit.org
  • 13 edits
    3 adds in trunk

2010-06-22 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Eric Seidel.

Add layout tests which test line numbers for both inline and event handler
scripts in HTML documents.
​https://bugs.webkit.org/show_bug.cgi?id=40649

  • fast/js/resources/script-line-number.js: Added. (getLineFromError): (assertErrorOnLine):
  • fast/js/script-line-number-expected.txt: Added.
  • fast/js/script-line-number.html: Added.

2010-06-22 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Eric Seidel.

Pull script line number from DocumentParser instead of pushing it to ScriptController
​https://bugs.webkit.org/show_bug.cgi?id=40649

This approach is cleaner and improves WebCore/benchmarks/parser/html-parser.html by ~2%.

Tests: fast/js/script-line-number.html

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController): (WebCore::ScriptController::eventHandlerLineNumber):
  • bindings/js/ScriptController.h:
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::eventHandlerLineNumber): (WebCore::ScriptController::eventHandlerColumnNumber):
  • bindings/v8/ScriptController.h:
  • bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener):
  • bindings/v8/V8Proxy.h:
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::startElementNs):
  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::pumpLexer):
  • html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::processToken):
4:55 PM Changeset in webkit [61639] by andersca@apple.com
  • 3 edits
    1 add in trunk/WebKit2

2010-06-22 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Add a SimpleArgumentCoder class template that works on POD types
​https://bugs.webkit.org/show_bug.cgi?id=41023

  • Platform/CoreIPC/SimpleArgumentCoder.h: Added. (CoreIPC::SimpleArgumentCoder::encode): (CoreIPC::SimpleArgumentCoder::decode):
  • Shared/WebCoreTypeArgumentMarshalling.h: (CoreIPC::):
  • WebKit2.xcodeproj/project.pbxproj:
4:46 PM Changeset in webkit [61638] by abarth@webkit.org
  • 5 edits in trunk/WebCore

2010-06-22 Tony Gentilcore <​tonyg@chromium.org>

Reviewed by Eric Seidel.

Make PendingScript hold a CachedResourceClient open for its lifetime
​https://bugs.webkit.org/show_bug.cgi?id=40968

This replaces the mechanism introduced in r61374 with a simpler
approach from preventing unexpected purges; always keep a client open.
This will approach will allow deferred scripts to add a client after
the resource may have already been loaded without having to worry about
the buffer being purged in the meantime.

No new tests because making a CachedResource purge itself is not
testable from a LayoutTest.

  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::watchForLoad): (WebCore::HTML5DocumentParser::notifyFinished):
  • html/HTML5ScriptRunner.cpp: (WebCore::HTML5ScriptRunner::~HTML5ScriptRunner): (WebCore::HTML5ScriptRunner::sourceFromPendingScript): (WebCore::HTML5ScriptRunner::isPendingScriptReady): (WebCore::HTML5ScriptRunner::executePendingScript): (WebCore::HTML5ScriptRunner::watchForLoad): (WebCore::HTML5ScriptRunner::stopWatchingForLoad): (WebCore::HTML5ScriptRunner::executeScriptsWaitingForLoad): (WebCore::HTML5ScriptRunner::executeScriptsWaitingForStylesheets): (WebCore::HTML5ScriptRunner::requestScript):
  • html/HTML5ScriptRunner.h: (WebCore::HTML5ScriptRunner::PendingScript::PendingScript): (WebCore::HTML5ScriptRunner::PendingScript::~PendingScript): (WebCore::HTML5ScriptRunner::PendingScript::setCachedScript): (WebCore::HTML5ScriptRunner::PendingScript::cachedScript): (WebCore::HTML5ScriptRunner::PendingScript::notifyFinished):
  • html/HTML5ScriptRunnerHost.h:
4:43 PM Changeset in webkit [61637] by abarth@webkit.org
  • 34 edits
    1 add in trunk

2010-06-22 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fragment parsing needs to go through the HTML5 Parser code path
​https://bugs.webkit.org/show_bug.cgi?id=40645

  • fast/canvas/canvas-getContext-invalid-expected.txt:
    • \0 is now converted to \uFFFD per HTML5.
  • fast/js/null-char-in-string-expected.txt: ditto.
  • fast/js/switch-behaviour-expected.txt: ditto.
  • fast/parser/comment-in-textarea-expected.txt:
    • <textarea> is parsed in the RCDATA state, which means that comments are ignored, thus the </textarea> in the comment correctly closes the <textarea>. This test is invalid. Our new behavior matches minefield.
  • fast/tokenizer/lessthan-terminates-tags-and-attrs-expected.txt:
    • This test is invalid and probably should just be removed. This same behavior is tested by fast/invalid/016.html.
  • inspector/timeline-parse-html-expected.txt:
    • The "extra" ParseHTML is expected. The HTML5 Parser tells the inspector about every parser pump, even ones which pump no data. The HTML5 parser pumps one last time in finish() to flush any buffered characters. Eventually we'll teach the inspector to filter out (not display) 0-sized pumps.
  • storage/domstorage/complex-values-expected.txt:
    • \0 is now converted to \uFFFD per HTML5
  • svg/dom/fuzz-path-parser-expected.txt: ditto.
  • svg/dom/rgb-color-parser-expected.txt: ditto
  • websocket/tests/bad-sub-protocol-control-chars-expected.txt: ditto.

2010-06-22 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fragment parsing needs to go through the HTML5 Parser code path
​https://bugs.webkit.org/show_bug.cgi?id=40645

Added a new HTML5DocumentParser::parseHTMLDocumentFragment
codepath which optionally calls through to the old fragment
parsing path, now renamed parseLegacyHTMLDocumentFragment.

  • dom/Element.cpp: (WebCore::Element::createContextualFragment):
    • Use document()->createDocumentFragment() instead of DocumentFragment::create() to match other callers (and not depend on DocumentFragment.h).
    • Update call to parseHTMLDocumentFragment to use the new HTML5 parser codepath.
  • dom/MappedAttributeEntry.h:
    • Add a FIXME about this horrible enum placement. Sadly this will cause a world-rebuild for everyone.
  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::HTML5DocumentParser): (WebCore::HTML5DocumentParser::runScriptsForPausedTreeConstructor):
    • The main pumpLexer function has gotten to large. Move the script running logic into this new function.
    • Handle the case where we have no m_scriptRunner (fragment case).

(WebCore::HTML5DocumentParser::pumpLexer):

  • Use new runScriptsForPausedTreeConstructor().

(WebCore::HTML5DocumentParser::executingScript):
(WebCore::HTML5DocumentParser::inScriptExecution):

  • New function to handle the case where m_scriptRunner is null.

(WebCore::HTML5DocumentParser::resumeParsingAfterScriptExecution):

  • Use inScriptExecution() instead of m_scriptRunner->inScriptExecution().

(WebCore::HTML5DocumentParser::executeScript): ditto.
(WebCore::HTML5DocumentParser::notifyFinished): ditto.
(WebCore::HTML5DocumentParser::executeScriptsWaitingForStylesheets): ditto.
(WebCore::shouldUseLegacyParser):

  • Helper function to check the html5ParserEnabled() setting.

(WebCore::HTML5DocumentParser::parseHTMLDocumentFragment):

  • Run HTML5DocumentParser in fragment mode, or optionally run the legacy parser if !html5ParserEnabled().
  • html/HTML5DocumentParser.h:
  • html/HTML5TreeBuilder.cpp: (WebCore::HTML5TreeBuilder::HTML5TreeBuilder): (WebCore::HTML5TreeBuilder::passTokenToLegacyParser):
    • Implement the FragmentScriptingNotAllowed hack for platform/Pasteboard.
  • html/HTML5TreeBuilder.h:
  • html/HTMLDocumentParser.cpp: (WebCore::parseLegacyHTMLDocumentFragment):
    • Renamed from parseHTMLDocumentFragment
  • html/HTMLDocumentParser.h:
  • html/HTMLElement.cpp: (WebCore::HTMLElement::insertAdjacentHTML):
    • Call HTML5DocumentParser::parseHTMLDocumentFragment.
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::documentFragment): ditto.
  • xml/XSLTProcessor.cpp: (WebCore::createFragmentFromSource): ditto.
4:37 PM Changeset in webkit [61636] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-06-22 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Remove Gtk 64-Release bot from core since it's broken
​https://bugs.webkit.org/show_bug.cgi?id=41022

This bot alone has been responsible for more than 72 hours of
commit-queue blockage in the last week. The bot is broken -- keeps
losing its display server or similar. Until the Gtk folks can fix the
bot, we need to remove it from core. The WebKit community can't keep
it green as is.

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot_unittest.py:
4:35 PM Changeset in webkit [61635] by andersca@apple.com
  • 4 edits in trunk/WebKit2

2010-06-22 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Use the ArgumentCoder class template for decoding
​https://bugs.webkit.org/show_bug.cgi?id=41021

  • Platform/CoreIPC/ArgumentCoder.h: (CoreIPC::ArgumentCoder::decode):
  • Platform/CoreIPC/ArgumentDecoder.h: (CoreIPC::ArgumentDecoder::decode):
  • Shared/WebCoreTypeArgumentMarshalling.h: (CoreIPC::):
4:22 PM Changeset in webkit [61634] by andersca@apple.com
  • 4 edits
    1 add in trunk/WebKit2

2010-06-22 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Change the encode functions to be specializations of a class template
​https://bugs.webkit.org/show_bug.cgi?id=41015

  • Platform/CoreIPC/ArgumentCoder.h: Added. (CoreIPC::ArgumentCoder::encode):
  • Platform/CoreIPC/ArgumentEncoder.h: (CoreIPC::ArgumentEncoder::encode):
  • Shared/WebCoreTypeArgumentMarshalling.h: (CoreIPC::):
  • WebKit2.xcodeproj/project.pbxproj:
4:21 PM Changeset in webkit [61633] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Get rid of more USE_LIBDISPATCH code.

Reviewed by Sam Weinig.

  • Plugins/Hosted/NetscapePluginHostProxy.h:
4:07 PM Changeset in webkit [61632] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

2010-06-22 Eric Seidel <​eric@webkit.org>

Reviewed by Geoffrey Garen.

Two fast/dynamic tests needlessly depend on legacy <tag<tag> parsing behavior
​https://bugs.webkit.org/show_bug.cgi?id=40946

These two tests would fail when we turned on
the HTML5 Lexer code path for DocumentFragment parsing.
This old parser quirk is covered by several other tests
including fast/invalid/016.html.

  • fast/dynamic/insertAdjacentHTML.html:
  • fast/dynamic/insertAdjacentText.html:
3:23 PM Changeset in webkit [61631] by cmarrin@apple.com
  • 9 edits in trunk/WebCore

2010-06-22 Chris Marrin <​cmarrin@apple.com>

Reviewed by Simon Fraser.

​https://bugs.webkit.org/show_bug.cgi?id=40643


Final phase of moving ownership of WebGLLayer to GraphicsContext3D.
As it turns out, I still have to have a separate CGLContextObj for
rendering because Core Animation composites in a separate thread,
so we need to disconnect WebGL rendering from CA compositing. But
this change is still worthwhile because it reduces dependencies
and makes it easier to port WebGL to other platforms.


No new tests since this is just restructuring and the current tests
are all still valid and do a sufficient test of WebGL functionality.

  • platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::platformLayer):
  • platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::setContentsToWebGL): (WebCore::GraphicsLayer::setWebGLNeedsDisplay):
  • platform/graphics/mac/GraphicsContext3DMac.mm: Add creation of WebGLLayer (WebCore::GraphicsContext3D::GraphicsContext3D):
  • platform/graphics/mac/GraphicsLayerCA.h: (WebCore::GraphicsLayerCA::):
  • platform/graphics/mac/GraphicsLayerCA.mm: Handle setting of WebGLLayer as content the same as for MediaLayer. Also changed WebGL related names for clarity (WebCore::GraphicsLayerCA::GraphicsLayerCA): (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): (WebCore::GraphicsLayerCA::updateContentsWebGLLayer): (WebCore::GraphicsLayerCA::setContentsToWebGL): (WebCore::GraphicsLayerCA::setWebGLNeedsDisplay):
  • platform/graphics/mac/WebGLLayer.h:
  • platform/graphics/mac/WebGLLayer.mm: Got rid of storage for context and texture, now just store GraphicsContext3D and get them from there when needed (-[WebGLLayer copyCGLPixelFormatForDisplayMask:]): (-[WebGLLayer copyCGLContextForPixelFormat:]): (-[WebGLLayer drawInCGLContext:pixelFormat:forLayerTime:displayTime:]): (-[WebGLLayer copyImageSnapshotWithColorSpace:]):
  • rendering/RenderLayerBacking.cpp: Changed init of WebGL contentsLayer to pass WebGLLayer rather than GraphicsContext3D (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): (WebCore::RenderLayerBacking::rendererContentChanged):
3:13 PM Changeset in webkit [61630] by Darin Adler
  • 2 edits in trunk/WebCore
  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::parseMappedAttribute): Removed incorrect FIXME comments.

Reviewed by Dave Hyatt.

3:10 PM Changeset in webkit [61629] by mitz@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/8119403> REGRESSION (r61548): PLT is almost 1.5% slower, Google page cycler slower
​https://bugs.webkit.org/show_bug.cgi?id=41012

Reviewed by Anders Carlsson.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeHorizontalPositionsForLine): Removed a redundant statement that was
left over in the original patch and resulted in double the calls to RenderText::width() here.
(WebCore::RenderBlock::findNextLineBreak): Changed the order of evaluating conditions for a
potential speedup.

3:05 PM QtWebKitReleases edited by Simon Hausmann
(diff)
2:58 PM QtWebKitReleases edited by Simon Hausmann
(diff)
2:55 PM QtWebKitTiling edited by jesus@webkit.org
(diff)
2:28 PM QtWebKitTiling edited by kenneth@webkit.org
(diff)
2:16 PM QtWebKitTiling edited by kenneth@webkit.org
(diff)
2:16 PM Changeset in webkit [61628] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Get rid of the USE_LIBDISPATCH code.

Reviewed by Sam Weinig.

  • Plugins/Hosted/NetscapePluginHostProxy.mm:

(WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
(WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy):

1:30 PM Changeset in webkit [61627] by Darin Adler
  • 2 edits in trunk/WebCore

Alexey asked me to take out the autorelease pools because he believes
that there is no code that should be running using Objective-C
autorelease. Most likely, the code that is triggering these stderr
messages is incorrect, and that bug should be fixed instead.

Reviewed by Alexey Proskuryakov.

  • workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::run): Roll out use of AutodrainedPool.

1:26 PM Changeset in webkit [61626] by Darin Adler
  • 2 edits in trunk/WebCore

Fix autorelease problem seen when running worker regression tests.
We were seeing logs to stderr saying autorelease was used without
an autorelease pool being set up.

Reviewed by Brady Eidson.

  • workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::run): Use an AutodrainedPool as the file
thread, icon database, and database thread do. No effect on platforms
other than Mac.

12:54 PM Changeset in webkit [61625] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2010-06-22 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Wean NetscapePluginHostManager of any knowledge about WebNetscapePluginPackage
​https://bugs.webkit.org/show_bug.cgi?id=41006

  • Plugins/Hosted/NetscapePluginHostManager.h:
  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::hostForPlugin): (WebKit::NetscapePluginHostManager::spawnPluginHost): (WebKit::NetscapePluginHostManager::instantiatePlugin): (WebKit::NetscapePluginHostManager::createPropertyListFile):
  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView createPlugin]):
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage createPropertyListFile]):
12:39 PM Changeset in webkit [61624] by andersca@apple.com
  • 4 edits in trunk/WebKit2

Implement PluginInfoStore::shouldUsePlugin.

Reviewed by Sam Weinig.

  • UIProcess/Plugins/PluginInfoStore.h:
  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::getPluginInfo):
(WebKit::PluginInfoStore::shouldUsePlugin):

  • WebKit2.xcodeproj/project.pbxproj:
12:16 PM Changeset in webkit [61623] by zherczeg@webkit.org
  • 12 edits
    3 adds in trunk/JavaScriptCore

Adding regular expression caching to JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=38142

Patch by Renata Hodovan <​hodovan@inf.u-szeged.hu> on 2010-06-22
Reviewed by Geoffrey Garen.

The cache is based on Round Robin eviction policy, and
can cache at most 256 character long regular expressions,
and at most 256 of them. These values can be changed at compile time.

(JSC::RegExpNode::emitBytecode):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):

  • runtime/JSGlobalData.h:

(JSC::JSGlobalData::regExpCache):

  • runtime/RegExpCache.cpp: Added.

(JSC::RegExpCache::lookupOrCreate):
(JSC::RegExpCache::create):
(JSC::RegExpCache::RegExpCache):

  • runtime/RegExpCache.h: Added.
  • runtime/RegExpConstructor.cpp:

(JSC::constructRegExp):

  • runtime/RegExpKey.h: Added.

(JSC::RegExpKey::RegExpKey):
(JSC::RegExpKey::getFlagsValue):
(WTF::operator==):
(WTF::):

  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncCompile):

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):

12:01 PM Changeset in webkit [61622] by Chris Fleizach
  • 5 edits
    2 adds in trunk

AX: If an element that is a continuation is removed, its parent tree is not notified appropriately that their children have changed
​https://bugs.webkit.org/show_bug.cgi?id=41000

Reviewed by Darin Adler.

WebCore:

Test: accessibility/removed-continuation-element-causes-crash.html

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::updateChildrenIfNecessary):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::childrenChanged):
(WebCore::AccessibilityRenderObject::addChildren):

  • accessibility/AccessibilityRenderObject.h:

LayoutTests:

  • accessibility/removed-continuation-element-causes-crash-expected.txt: Added.
  • accessibility/removed-continuation-element-causes-crash.html: Added.
11:15 AM Changeset in webkit [61621] by crogers@google.com
  • 6 adds in branches/audio/WebCore/audio

Initial incomplete work for DelayNode and WaveshaperNode

11:15 AM Changeset in webkit [61620] by crogers@google.com
  • 13 edits in branches/audio/WebCore/audio

Add direct audio data access to AudioBuffer

11:02 AM Changeset in webkit [61619] by pkasting@chromium.org
  • 14 edits in trunk/WebCore

Override setFailed() in each image decoder to clean up any temporary
objects.
​https://bugs.webkit.org/show_bug.cgi?id=35411

Reviewed by Adam Barth.

In a few cases, we need to be careful to avoid deleting objects until
after they're no longer needed. These cases usually mean some jumping
through hoops, to the detriment of code simplicity.

No layout tests because this does not change the visible output of
decoding in any way.

  • platform/image-decoders/ImageDecoder.h:

(WebCore::ImageDecoder::setData):

  • platform/image-decoders/bmp/BMPImageDecoder.cpp:

(WebCore::BMPImageDecoder::setFailed):
(WebCore::BMPImageDecoder::decode):

  • platform/image-decoders/bmp/BMPImageDecoder.h:
  • platform/image-decoders/bmp/BMPImageReader.cpp:

(WebCore::BMPImageReader::decodeBMP):
(WebCore::BMPImageReader::readInfoHeaderSize):
(WebCore::BMPImageReader::processInfoHeader):
(WebCore::BMPImageReader::readInfoHeader):
(WebCore::BMPImageReader::processBitmasks):
(WebCore::BMPImageReader::processColorTable):
(WebCore::BMPImageReader::processRLEData):
(WebCore::BMPImageReader::processNonRLEData):

  • platform/image-decoders/bmp/BMPImageReader.h:

(WebCore::BMPImageReader::):

  • platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::setFailed):
(WebCore::GIFImageDecoder::decode):

  • platform/image-decoders/gif/GIFImageDecoder.h:
  • platform/image-decoders/ico/ICOImageDecoder.cpp:

(WebCore::ICOImageDecoder::setFailed):
(WebCore::ICOImageDecoder::decode):

  • platform/image-decoders/ico/ICOImageDecoder.h:
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageReader::decode):
(WebCore::JPEGImageDecoder::setFailed):
(WebCore::JPEGImageDecoder::decode):

  • platform/image-decoders/jpeg/JPEGImageDecoder.h:
  • platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageReader::decode):
(WebCore::PNGImageDecoder::PNGImageDecoder):
(WebCore::PNGImageDecoder::setFailed):
(WebCore::PNGImageDecoder::headerAvailable):
(WebCore::PNGImageDecoder::decode):

  • platform/image-decoders/png/PNGImageDecoder.h:
8:56 AM Changeset in webkit [61618] by Dimitri Glazkov
  • 6 edits in trunk/WebCore

2010-06-04 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Remove side effects of form submission and prepare FormDataBuilder for splitting up.
​https://bugs.webkit.org/show_bug.cgi?id=40184

Refactoring, covered by existing tests.

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::prepareFormSubmission):
    • Changed to use new accessors on FormDataBuilder;
    • Simplified the logic around action URL;
    • Removed form submission side effect of element's enctype property being updated when

submitting a mailto form;

  • Removed unnecessary updating of action URL for mailto forms.

(WebCore::HTMLFormElement::submit): Moved action URL check into prepareFormSubmission.
(WebCore::HTMLFormElement::parseMappedAttribute): Updated to use new methods on FormDataBuilder.

  • html/HTMLFormElement.h: Removed decls for isMailtoForm and dataEncoding methods;

moved m_target and m_url to FormDataBuilder.

  • platform/network/FormData.cpp: (WebCore::FormData::appendDOMFormData): Removed unnecessary instantiation of FormDataBuilder.
  • platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::parseAction): Moved from HTMLFormControl.
  • platform/network/FormDataBuilder.h: (WebCore::FormDataBuilder::action): Ditto. (WebCore::FormDataBuilder::target): Ditto. (WebCore::FormDataBuilder::setTarget): Ditto.
7:58 AM Changeset in webkit [61617] by yurys@chromium.org
  • 3 edits in trunk/LayoutTests

2010-06-22 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: inspector/elements-panel-limited-children.html test fails
​https://bugs.webkit.org/show_bug.cgi?id=40924

  • http/tests/inspector/inspector-test.js: (onload): (frontend_setupTestEnvironment): always start inspector test with Elements panel as current one.
  • inspector/elements-panel-limited-children.html:
7:41 AM QtWebKitTriageRoster edited by Simon Hausmann
(diff)
7:40 AM Changeset in webkit [61616] by mnaganov@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-06-22 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Clean up after removal of static WebDevToolsAgentClient::sendMessageToFrontendOnIOThread.

​https://bugs.webkit.org/show_bug.cgi?id=40914

  • public/WebDevToolsAgentClient.h:
6:54 AM Changeset in webkit [61615] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

[Qt] Fix compilation with QT_NO_COMBOBOX.

Patch by Tasuku Suzuki <​tasuku.suzuki@nokia.com> on 2010-06-22
Reviewed by Simon Hausmann.

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::createSelectPopup):

5:25 AM Changeset in webkit [61614] by loki@webkit.org
  • 4 edits in trunk/JavaScriptCore

Add native call support for ARM and Thumb-2 JIT.
​https://bugs.webkit.org/show_bug.cgi?id=40231

Reviewed by Geoffrey Garen.

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTINativeCall):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTINativeCall):

  • wtf/Platform.h:
5:14 AM QtWebKitDocContrib edited by Henry Haverinen
(diff)
5:11 AM Changeset in webkit [61613] by mnaganov@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-06-21 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Add a sanity test for heap profiler.

​https://bugs.webkit.org/show_bug.cgi?id=40917

  • src/js/Tests.js: (.TestSuite.prototype.testHeapProfiler.findDisplayedNode): (.TestSuite.prototype.testHeapProfiler.findVisibleView): (.TestSuite.prototype.testHeapProfiler):
5:03 AM QtWebKitDocContrib edited by Henry Haverinen
(diff)
4:59 AM QtWebKitDocContrib edited by Henry Haverinen
(diff)
4:44 AM QtWebKitDocContrib edited by Henry Haverinen
(diff)
4:41 AM Changeset in webkit [61612] by tkent@chromium.org
  • 20 edits
    3 adds
    2 deletes in trunk/LayoutTests

2010-06-22 Kent Tamura <​tkent@chromium.org>

Unreviewed, test expectation update.

  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum:
  • platform/chromium-linux/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
  • platform/chromium-linux/fast/parser/broken-comments-vs-parsing-mode-expected.checksum: Added.
  • platform/chromium-linux/fast/parser/broken-comments-vs-parsing-mode-expected.png: Added.
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum:
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum:
  • platform/chromium-mac/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
  • platform/chromium-mac/fast/parser/broken-comments-vs-parsing-mode-expected.checksum: Removed.
  • platform/chromium-mac/fast/parser/broken-comments-vs-parsing-mode-expected.png: Removed.
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.checksum:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum:
  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
  • platform/chromium-win/fast/parser/broken-comments-vs-parsing-mode-expected.checksum:
  • platform/chromium-win/fast/parser/broken-comments-vs-parsing-mode-expected.png:
  • platform/chromium-win/fast/parser/broken-comments-vs-parsing-mode-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
4:40 AM QtWebKitDocContrib edited by Henry Haverinen
(diff)
4:37 AM QtWebKitDocContrib edited by Henry Haverinen
(diff)
4:28 AM QtWebKitDocContrib edited by Henry Haverinen
(diff)
1:59 AM Changeset in webkit [61611] by morrita@google.com
  • 4 edits in trunk/WebCore

2010-06-22 Yuta Kitamura <​yutak@chromium.org>

Reviewed by Alexey Proskuryakov.

Fix WebSocketHandshakeRequest so that it fits the new handshake protocol.

The new WebSocket specification (draft 76 and later) allows a browser to
send header fields in arbitrary order. Thus we can use a HTTPHeaderMap to
store header fields instead of Vector of pairs of a field name and
a field value.

This patch also does refactoring of WebSocketHandshakeRequest class
to make it simpler and easier to use.

Fix WebSocketHandshakeRequest so that it fits the new handshake protocol
​https://bugs.webkit.org/show_bug.cgi?id=39864

No new tests, because there is no functional change.

  • websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::clientHandshakeRequest):
  • websockets/WebSocketHandshakeRequest.cpp: (WebCore::WebSocketHandshakeRequest::Key3::Key3): (WebCore::WebSocketHandshakeRequest::Key3::set): (WebCore::WebSocketHandshakeRequest::WebSocketHandshakeRequest): (WebCore::WebSocketHandshakeRequest::requestMethod): (WebCore::WebSocketHandshakeRequest::url): (WebCore::WebSocketHandshakeRequest::addHeaderField): (WebCore::WebSocketHandshakeRequest::headerFields): (WebCore::WebSocketHandshakeRequest::key3): (WebCore::WebSocketHandshakeRequest::setKey3):
  • websockets/WebSocketHandshakeRequest.h:
1:45 AM QtWebKitDocContrib edited by Henry Haverinen
(diff)
1:28 AM Changeset in webkit [61610] by abarth@webkit.org
  • 3 edits in trunk/LayoutTests

2010-06-22 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Upon closer reading of the spec, we think our behavior is correct.
We'll double-check with the working group.

  • fast/tokenizer/write-on-load-expected.txt:
  • fast/tokenizer/write-on-load.html:
1:22 AM Changeset in webkit [61609] by morrita@google.com
  • 7 edits in trunk

2010-06-20 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

<meter> should be yellow when min < value < low < optimum
​https://bugs.webkit.org/show_bug.cgi?id=40824

Update overlooked broken test results.

  • platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
  • platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum:
  • platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.png:

2010-06-20 MORITA Hajime <​morrita@google.com>

Reviewed by Kent Tamura.

<meter> should be yellow when min < value < low < optimum
​https://bugs.webkit.org/show_bug.cgi?id=40824

Fixed a wrong conditional on HTMLMeterElement::gaugeRegion().

  • html/HTMLMeterElement.cpp: (WebCore::HTMLMeterElement::gaugeRegion):

Tests: fast/dom/HTMLMeterElement/meter-appearances-capacity.html

fast/dom/HTMLMeterElement/meter-optimums.html

1:14 AM Changeset in webkit [61608] by abarth@webkit.org
  • 4 edits
    2 adds in trunk

2010-06-22 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Follow the HTML5 spec more closely w.r.t. when to save the insertion point
​https://bugs.webkit.org/show_bug.cgi?id=40976

This test no longer asserts. The output is incorrect, however. I'll
fix the output in the next patch.

  • fast/tokenizer/write-on-load-expected.txt: Added.
  • fast/tokenizer/write-on-load.html: Added.

2010-06-22 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Follow the HTML5 spec more closely w.r.t. when to save the insertion point
​https://bugs.webkit.org/show_bug.cgi?id=40976

The spec always increments the nesting level and saves the insertion
point at the same time. In this patch, we now do those operations
packaged as a RAII.

As a side effect, the test case below no longer ASSERTs. (The output
is wrong, but we'll get to that next.)

Test: fast/tokenizer/write-on-load.html

  • html/HTML5ScriptRunner.cpp: (WebCore::NestScript::NestScript): (WebCore::NestScript::~NestScript): (WebCore::HTML5ScriptRunner::executePendingScript): (WebCore::HTML5ScriptRunner::executeScript): (WebCore::HTML5ScriptRunner::requestScript): (WebCore::HTML5ScriptRunner::runScript):
  • html/HTMLInputStream.h:
12:56 AM Changeset in webkit [61607] by abarth@webkit.org
  • 5 edits in trunk/WebCore

2010-06-22 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Expose HTMLInputStream to ScriptRunner so that ScriptRunner can save the insertion point itself
​https://bugs.webkit.org/show_bug.cgi?id=40975

This saves us having to call back into the HTML5DocumentParser each
time we need to save the insertion point. This prepares us for another
place we need to save the insertion point.

  • html/HTML5DocumentParser.cpp:
  • html/HTML5DocumentParser.h: (WebCore::HTML5DocumentParser::inputStream):
  • html/HTML5ScriptRunner.cpp: (WebCore::HTML5ScriptRunner::executeScript): (WebCore::HTML5ScriptRunner::requestScript):
  • html/HTML5ScriptRunnerHost.h:
12:42 AM Changeset in webkit [61606] by abarth@webkit.org
  • 6 edits
    1 add in trunk/WebCore

2010-06-22 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Move HTMLInputStream to its own file
​https://bugs.webkit.org/show_bug.cgi?id=40974

No new tests, just code motion.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTML5DocumentParser.h:
12:23 AM QtWebKitDocContrib created by Henry Haverinen
12:23 AM QtWebKit edited by Henry Haverinen
(diff)
12:13 AM Changeset in webkit [61605] by eric@webkit.org
  • 5 edits
    22 adds in trunk/LayoutTests

2010-06-21 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Alexey Proskuryakov.

Tests for:
Space should be allowed between -- and > in comment end
​https://bugs.webkit.org/show_bug.cgi?id=21945

  • fast/css/word-space-extra.html: Tweaked the comment as -- > is now a valid comment end.
  • fast/parser/broken-comment-1-expected.txt: Added.
  • fast/parser/broken-comment-1.html: Added.
  • fast/parser/broken-comment-2-expected.txt: Added.
  • fast/parser/broken-comment-2.html: Added.
  • fast/parser/broken-comment-3-expected.txt: Added.
  • fast/parser/broken-comment-3.html: Added.
  • fast/parser/broken-comment-4-expected.txt: Added.
  • fast/parser/broken-comment-4.html: Added.
  • fast/parser/broken-comment-5-expected.txt: Added.
  • fast/parser/broken-comment-5.html: Added.
  • fast/parser/broken-comment-6-expected.txt: Added.
  • fast/parser/broken-comment-6.html: Added. Those test checks that broken comments in body are correctly parsed.
  • fast/parser/broken-comment-in-head-1-expected.txt: Added.
  • fast/parser/broken-comment-in-head-1.html: Added.
  • fast/parser/broken-comment-in-head-2-expected.txt: Added.
  • fast/parser/broken-comment-in-head-2.html: Added.
  • fast/parser/broken-comment-in-head-3-expected.txt: Added.
  • fast/parser/broken-comment-in-head-3.html: Added.
  • fast/parser/broken-comment-in-head-4-expected.txt: Added.
  • fast/parser/broken-comment-in-head-4.html: Added.
  • fast/parser/broken-comment-in-head-5-expected.txt: Added.
  • fast/parser/broken-comment-in-head-5.html: Added. Those test checks that broken comments in head are correctly parsed.
  • fast/parser/broken-comments-vs-parsing-mode.html: Needed to wrap the broken comment in a title as we match FF here and would not recover from it.
  • fast/parser/comments-expected.txt:
  • fast/parser/comments.html: Added more tests for comment parsing. Made sure that we close empty comments <!--> and <!---> as is specified in HTML5.
12:04 AM Changeset in webkit [61604] by abarth@webkit.org
  • 8 edits in trunk

2010-06-21 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Save the insertion point before beforeload events
​https://bugs.webkit.org/show_bug.cgi?id=40973

Update expected results to show the proper document.write order.

  • fast/tokenizer/write-before-load-expected.txt:

2010-06-21 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Save the insertion point before beforeload events
​https://bugs.webkit.org/show_bug.cgi?id=40973

We need to save the insertion point before dispatching the beforeload
event in case someone decides to document.write during beforeload.
Prior to this patch, such writes would pump the lexer too much and
tokenize the rest of the document before executing the script.

  • html/HTML5DocumentParser.cpp: (WebCore::HTML5DocumentParser::dispatchBeforeLoad):
  • html/HTML5DocumentParser.h:
  • html/HTML5ScriptRunner.cpp: (WebCore::HTML5ScriptRunner::requestScript):
  • html/HTML5ScriptRunnerHost.h:
12:03 AM Changeset in webkit [61603] by dumi@chromium.org
  • 2 edits in trunk/WebKitTools

Fix the Windows build.
​https://bugs.webkit.org/show_bug.cgi?id=40972

Reviewed by Eric Seidel.

  • DumpRenderTree/win/ImageDiff.vcproj:

Jun 21, 2010:

11:25 PM Changeset in webkit [61602] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2010-06-21 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

document.write from BeforeLoad should not assert
​https://bugs.webkit.org/show_bug.cgi?id=40971

Test what happens when we document.write from a beforeload event.
Notice that the order is wrong. I'll fix that in a followup patch.

  • fast/tokenizer/write-before-load-expected.txt: Added.
  • fast/tokenizer/write-before-load.html: Added.

2010-06-21 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

document.write from BeforeLoad should not assert
​https://bugs.webkit.org/show_bug.cgi?id=40971

We're setting the parse blocking script too early. It's not actually
blocking parsing yet.

Test: fast/tokenizer/write-before-load.html

  • html/HTML5ScriptRunner.cpp: (WebCore::HTML5ScriptRunner::requestScript):
9:59 PM Changeset in webkit [61601] by dimich@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, skip new modal tests on Tiger and update expected result for Chromium.

  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/mac-tiger/Skipped:
9:41 PM Changeset in webkit [61600] by dimich@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, fixing qt-specific expected results for r61599

  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
9:24 PM Changeset in webkit [61599] by dimich@chromium.org
  • 54 edits
    6 adds
    7 deletes in trunk

DumpRenderTree should allow tests with modal dialogs
​https://bugs.webkit.org/show_bug.cgi?id=35350

Patch by Prasad Tammana <​prasadt@chromium.org> on 2010-06-21
Reviewed by Darin Adler, Dmitry Titov.

WebKitTools:

  • DumpRenderTree/LayoutTestController.cpp:

(abortModalCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::abortModal):
Add abortModal method to LayoutTestController and make it available from script.

  • DumpRenderTree/mac/UIDelegate.mm: Add support for showModalDialog.

(-[UIDelegate modalWindowWillClose:]): Observer for NSWindowWillCloseNotifications to call
abortModal from when modal window closes.
(-[UIDelegate webViewRunModal:]): Delegate method for showModalDialog to run the modal loop.

LayoutTests:

Added a new test show-modal-dialog.html to harness tests to verify that showModalDialog works.

Added a new test, show-modal-dialog-onblur-onfocus.html, that takes advantage of the showModalDialog
functionality added to UIDelegate.mm. The test is only enabled on mac for now. This test will catch
regressions on the bug fix for ​https://bugs.webkit.org/show_bug.cgi?id=33962.

Support for showModalDialog affected the expected output for many tests that operate under the assumption
that the method is undefined. Modified the tests accordingly, in some cases disabled showModalDialog (not
currently tested anyway. Opened a bug to add showModalDialog specific tests where appropriate - Bug# 39897.

  • fast/dom/Window/window-function-frame-getter-precedence-expected.txt:
  • fast/dom/Window/window-function-frame-getter-precedence.html:
  • fast/dom/Window/window-function-name-getter-precedence-expected.txt:
  • fast/dom/Window/window-function-name-getter-precedence.html:
  • fast/dom/Window/window-lookup-precedence-expected.txt:
  • fast/dom/Window/window-lookup-precedence.html:
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-properties.html:
  • fast/dom/script-tests/prototype-inheritance.js:

Tweak tests so that showModalDialog part gets exercised only if its defined to keep output consistent across platforms.
Where its not possible, skip the test for showModalDialog, which is not currently exercised anyway.

  • fast/events/resources/modal-dialog.html: Added.
  • fast/events/show-modal-dialog-onblur-onfocus-expected.txt: Added.
  • fast/events/show-modal-dialog-onblur-onfocus.html: Added.
  • fast/harness/resources/modal-dialog.html: Added.
  • fast/harness/show-modal-dialog-expected.txt: Added.
  • fast/harness/show-modal-dialog.html: Added.

New tests that take advantage of showModalDialog in DRT.

  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T1-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T10-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T11-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T2-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T3-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T4-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T5-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T6-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T7-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T8-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T9-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T1-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T10-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T11-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T2-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T3-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T4-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T5-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T6-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T7-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T8-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T9-expected.txt:

Update the expected output to reflect the fact that these tests pass now. Skip the tests on gtk, qt and win. They were all expected
to fail anyway. So no coverage lost.

  • http/tests/security/cross-frame-access-call-expected.txt:
  • http/tests/security/cross-frame-access-call.html:
  • http/tests/security/cross-frame-access-get-expected.txt:
  • http/tests/security/cross-frame-access-get.html:
  • http/tests/security/cross-frame-access-put-expected.txt:

Skip showModalDialog to make test pass for all platforms. Added a FIXME with bug # to add a test specifically for showModalDialog.

  • http/tests/security/resources/cross-frame-iframe-for-put-test.html:
  • platform/chromium-mac/fast/dom/Window/window-function-frame-getter-precedence-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/Window/window-function-name-getter-precedence-expected.txt: Removed.
  • platform/chromium-mac/http/tests/security/cross-frame-access-get-expected.txt:
  • platform/chromium-win/fast/dom/Window/window-function-frame-getter-precedence-expected.txt: Removed.
  • platform/chromium-win/fast/dom/Window/window-function-name-getter-precedence-expected.txt: Removed.
  • platform/chromium-win/fast/dom/Window/window-lookup-precedence-expected.txt:
  • platform/chromium-win/http/tests/security/cross-frame-access-get-expected.txt:
  • platform/chromium-win/http/tests/security/cross-frame-access-put-expected.txt:
  • platform/chromium/http/tests/security/cross-frame-access-call-expected.txt:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/qt/fast/dom/Window/window-function-frame-getter-precedence-expected.txt: Removed.
  • platform/qt/fast/dom/Window/window-function-name-getter-precedence-expected.txt: Removed.
  • platform/qt/fast/dom/Window/window-lookup-precedence-expected.txt: Removed.

Updaate expected output to reflect test changes. Removed some platform specific files where the only reason they're different is
because of showModalDialog.

  • platform/qt/http/tests/security/cross-frame-access-call-expected.txt:
  • platform/qt/http/tests/security/cross-frame-access-get-expected.txt:
  • platform/win/Skipped:

Skip failing tests. Note that there is no test functionality lost. These are either new tests or tests that were dysfunctional anyway
in the absence of showModalDialog in DRT.

7:28 PM Changeset in webkit [61598] by morrita@google.com
  • 4 edits
    2 adds in trunk/WebKit/chromium

2010-06-21 MORITA Hajime <​morrita@google.com>

Reviewed by Darin Fisher.

[Chromium] Dragging outside the frame immediately causes page to scroll
​http://webkit.org/b/40461

This is regression that was introduced at ​http://webkit.org/b/39725.

There are 2 problems:

  1. It starts auto-scrolling immediately. We should have some delay.
  2. The scroll continues even after a mouse cursor goes outside a frame. The scroll should be stopped when the curosr has left.

This change introduced DragScrollTimer to handle 1.
At the same time, it fixed DragScrollTimer::scrollDistanceFor() to
handle 2, We now stop scrolling when the cursor gone.

  • WebKit.gyp:
  • src/DragScrollTimer.cpp: Added. (WebKit::distanceToRect): (WebKit::DragScrollTimer::DragScrollTimer): (WebKit::DragScrollTimer::~DragScrollTimer): (WebKit::DragScrollTimer::stop): (WebKit::DragScrollTimer::scroll): (WebKit::DragScrollTimer::update): (WebKit::DragScrollTimer::triggerScroll): (WebKit::DragScrollTimer::scrollDistanceFor):
  • src/DragScrollTimer.h: Added. (WebKit::DragScrollTimer::fired): (WebKit::DragScrollTimer::shouldScroll):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::dragSourceEndedAt): (WebKit::WebViewImpl::dragSourceMovedTo): (WebKit::WebViewImpl::dragTargetDrop): (WebKit::WebViewImpl::dragTargetDragEnterOrOver):
  • src/WebViewImpl.h:
6:36 PM Changeset in webkit [61597] by Chris Fleizach
  • 2 edits in trunk/WebCore

No review. QT build fix again.

AX: VoiceOver does not announce WAI-ARIA state change of aria-expanded
​https://bugs.webkit.org/show_bug.cgi?id=40927

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::postNotification):

6:27 PM Changeset in webkit [61596] by Chris Fleizach
  • 2 edits in trunk/WebCore

No review. QT build fix.

AX: VoiceOver does not announce WAI-ARIA state change of aria-expanded
​https://bugs.webkit.org/show_bug.cgi?id=40927

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::postNotification):

6:07 PM Changeset in webkit [61595] by Chris Fleizach
  • 11 edits
    2 adds in trunk

AX: VoiceOver does not announce WAI-ARIA state change of aria-expanded
​https://bugs.webkit.org/show_bug.cgi?id=40927

Reviewed by Beth Dakin.

WebCore:

Test: platform/mac/accessibility/aria-expanded-notifications.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::handleAriaExpandedChange):

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::handleAriaExpandedChange):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::handleAriaExpandedChanged):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::handleAriaExpandedChanged):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification):

  • dom/Element.cpp:

(WebCore::Element::updateAfterAttributeChanged):

LayoutTests:

  • platform/mac-leopard/Skipped:
  • platform/mac-tiger/Skipped:
  • platform/mac/accessibility/aria-expanded-notifications-expected.txt: Added.
  • platform/mac/accessibility/aria-expanded-notifications.html: Added.
5:33 PM Changeset in webkit [61594] by andersca@apple.com
  • 2 edits in trunk/WebKit2

2010-06-21 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Support reading plug-in info from Carbon resources
​https://bugs.webkit.org/show_bug.cgi?id=40959

  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm: (WebKit::ResourceMap::ResourceMap): (WebKit::ResourceMap::~ResourceMap): (WebKit::ResourceMap::isValid): (WebKit::getStringListResource): (WebKit::getPluginInfoFromCarbonResources): (WebKit::PluginInfoStore::getPluginInfo):
5:23 PM Changeset in webkit [61593] by andersca@apple.com
  • 2 edits in trunk/WebKit2

Build fix.

  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::getPluginInfo):

5:07 PM Changeset in webkit [61592] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Fix an off-by-one bug I introduced.

Reviewed by Sam Weinig.

  • Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage getPluginInfoFromResources]):

5:00 PM Changeset in webkit [61591] by andersca@apple.com
  • 4 edits
    1 add in trunk/WebKit2

2010-06-21 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Have PluginInfoStoreMac actually get plug-in info and populate the plug-in list
​https://bugs.webkit.org/show_bug.cgi?id=40957

  • UIProcess/Plugins/PluginInfoStore.cpp: (WebKit::PluginInfoStore::loadPluginsIfNecessary): (WebKit::PluginInfoStore::loadPluginsInDirectory): (WebKit::PluginInfoStore::loadPlugin): (WebKit::PluginInfoStore::getPlugins):
  • UIProcess/Plugins/PluginInfoStore.h:
  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm: Added. (WebKit::PluginInfoStore::pluginDirectories): (WebKit::PluginInfoStore::pluginPathsInDirectory): (WebKit::getPluginArchitecture): (WebKit::getPluginInfoFromPropertyLists): (WebKit::PluginInfoStore::getPluginInfo): (WebKit::PluginInfoStore::shouldUsePlugin):
  • WebKit2.xcodeproj/project.pbxproj:
4:42 PM Changeset in webkit [61590] by weinig@apple.com
  • 5 edits in trunk/WebKitLibraries

Update WebKitSystemInterface.

Reviewed by Anders Carlsson.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
4:29 PM Changeset in webkit [61589] by Simon Fraser
  • 8 edits
    8 moves in trunk/WebKit2

2010-06-21 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson.

Rename DrawingAreaProxyUpdateChunk to ChunkedUpdateDrawingArea
​https://bugs.webkit.org/show_bug.cgi?id=40948

Rename UIProcess version of DrawingAreaUpdateChunk to ChunkedUpdateDrawingAreaProxy,
and rename the Mac/Win versions of the various DrawingArea files too.

Also rename the DrawingAreaUpdateChunkType enum to ChunkedUpdateDrawingAreaType.

4:17 PM Changeset in webkit [61588] by oliver@apple.com
  • 11 edits in trunk/JavaScriptCore

2010-06-21 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Make JSC more resilient in the face of parse failures
​https://bugs.webkit.org/show_bug.cgi?id=40951

A number of recent bugs have occurred due to issues like miscounting
BOMs, etc which lead to interesting crashes later on. Adding this
logic hardens JSC in the face of these errors, and has no impact on
performance (32bit jit actually gets 0.7% faster but I put that down
to cache effects).

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::reparseForExceptionInfoIfNecessary): (JSC::CodeBlock::lineNumberForBytecodeOffset): (JSC::CodeBlock::expressionRangeForBytecodeOffset): (JSC::CodeBlock::getByIdExceptionInfoForBytecodeOffset):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::bytecodeOffset):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::execute): (JSC::Interpreter::executeCall): (JSC::Interpreter::executeConstruct): (JSC::Interpreter::prepareForRepeatCall): (JSC::Interpreter::privateExecute):
  • jit/JITOpcodes.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • runtime/ArrayPrototype.cpp: (JSC::isNumericCompareFunction):
  • runtime/Executable.cpp: (JSC::FunctionExecutable::compileForCall): (JSC::FunctionExecutable::compileForConstruct): (JSC::FunctionExecutable::generateJITCodeForCall): (JSC::FunctionExecutable::generateJITCodeForConstruct): (JSC::FunctionExecutable::reparseExceptionInfo): (JSC::EvalExecutable::reparseExceptionInfo):
  • runtime/Executable.h: (JSC::FunctionExecutable::bytecodeForCall): (JSC::FunctionExecutable::bytecodeForConstruct):
  • runtime/JSGlobalData.cpp: (JSC::JSGlobalData::numericCompareFunction):
4:00 PM Changeset in webkit [61587] by andersca@apple.com
  • 6 edits
    4 adds in trunk/WebKit2

2010-06-21 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Add PluginInfoStore class
​https://bugs.webkit.org/show_bug.cgi?id=40949

  • Shared/WebPreferencesStore.cpp: (WebKit::WebPreferencesStore::WebPreferencesStore):
  • Shared/WebPreferencesStore.h: (WebKit::WebPreferencesStore::encode): (WebKit::WebPreferencesStore::decode): Add plugInsEnabled to the preferences store.
  • UIProcess/Plugins: Added.
  • UIProcess/Plugins/PluginInfoStore.cpp: Added. (WebKit::PluginInfoStore::shared): (WebKit::PluginInfoStore::PluginInfoStore): (WebKit::PluginInfoStore::refresh): (WebKit::PluginInfoStore::getPlugins):
  • UIProcess/Plugins/PluginInfoStore.h: Added.
  • UIProcess/Plugins/mac: Added.
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::refreshPlugins): (WebKit::WebPlatformStrategies::getPluginInfo):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage):
3:57 PM Changeset in webkit [61586] by kinuko@chromium.org
  • 34 edits in trunk

2010-06-21 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r61585.
​http://trac.webkit.org/changeset/61585
​https://bugs.webkit.org/show_bug.cgi?id=40950

It broke builds (Requested by kinuko on #webkit).

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/BlobBuilder.cpp: (WebCore::BlobBuilder::appendString): (WebCore::BlobBuilder::appendBlob):
  • html/BlobBuilder.h:
  • page/DOMWindow.idl:

2010-06-21 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r61585.
​http://trac.webkit.org/changeset/61585
​https://bugs.webkit.org/show_bug.cgi?id=40950

It broke builds (Requested by kinuko on #webkit).

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/Skipped:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/Skipped:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/Skipped:
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
3:41 PM Changeset in webkit [61585] by kinuko@chromium.org
  • 34 edits in trunk

2010-06-21 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Adam Barth.

Add BlobBuilder.idl to expose BlobBuilder interface
​https://bugs.webkit.org/show_bug.cgi?id=40593

BlobBuilder is defined in FileAPI's FileWriter spec.
(​http://dev.w3.org/2009/dap/file-system/file-writer.html)

Also removes the ENABLE_FILE_WRITER ifdef guard for BlobBuilder.

Tests: http/tests/local/blob/send-data-blob.html

http/tests/local/blob/send-hybrid-blob.html
http/tests/local/blob/send-sliced-data-blob.html

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/BlobBuilder.cpp: (WebCore::BlobBuilder::append):
  • html/BlobBuilder.h:
  • html/BlobBuilder.idl: Added.
  • page/DOMWindow.idl:

2010-06-21 Kinuko Yasuda <​kinuko@chromium.org>

Reviewed by Adam Barth.

Add BlobBuilder.idl to expose BlobBuilder interface
​https://bugs.webkit.org/show_bug.cgi?id=40593

Add new layout tests to test BlobBuilder interface.
Also update test expectations affected by adding the constructors to DOMWindow.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • http/tests/local/blob/resources/hybrid-blob-util.js: Added.
  • http/tests/local/blob/script-tests/TEMPLATE.html: Added.
  • http/tests/local/blob/script-tests/send-data-blob.js: Added.
  • http/tests/local/blob/script-tests/send-hybrid-blob.js: Added.
  • http/tests/local/blob/script-tests/send-sliced-data-blob.js: Added.
  • http/tests/local/blob/send-data-blob-expected.txt: Added.
  • http/tests/local/blob/send-data-blob.html: Added.
  • http/tests/local/blob/send-hybrid-blob-expected.txt: Added.
  • http/tests/local/blob/send-hybrid-blob.html: Added.
  • http/tests/local/blob/send-sliced-data-blob-expected.txt: Added.
  • http/tests/local/blob/send-sliced-data-blob.html: Added.
  • http/tests/local/resources/file-for-drag-to-send2.txt: Added.
  • http/tests/resources/post-and-verify-hybrid.cgi: Added.
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/Skipped: Added send-hybrid-blob.html and send-sliced-data-blob.html because they need eventSender.beginDragWithFiles Blob.slice.
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/Skipped: Added send-hybrid-blob.html and send-sliced-data-blob.html because they need eventSender.beginDragWithFiles Blob.slice.
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/win/Skipped: Added send-hybrid-blob.html and send-sliced-data-blob.html because they need eventSender.beginDragWithFiles Blob.slice.
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt:
  • platform/win/fast/dom/prototype-inheritance-expected.txt:
3:33 PM Changeset in webkit [61584] by Nate Chapin
  • 25 edits
    2 adds in trunk

2010-06-21 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

FrameLoader cleanup: Split high level subframe and plugin
loading functions into a separate class.
​https://bugs.webkit.org/show_bug.cgi?id=40453

Refactor only, no new tests.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.base.exp:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMImplementation.cpp:
  • history/PageCache.cpp:
  • html/HTMLFrameElementBase.cpp:
  • html/HTMLMediaElement.cpp:
  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h: (WebCore::FrameLoader::subframeLoader):
  • loader/PluginDocument.cpp:
  • loader/SubframeLoader.cpp: Added. (WebCore::SubframeLoader::SubframeLoader): (WebCore::toPlugInElement): (WebCore::SubframeLoader::clear): (WebCore::SubframeLoader::requestFrame): (WebCore::SubframeLoader::requestObject): (WebCore::FrameLoader::loadMediaPlayerProxyPlugin): (WebCore::SubframeLoader::createJavaAppletWidget): (WebCore::SubframeLoader::loadSubframe): (WebCore::SubframeLoader::allowPlugins): (WebCore::SubframeLoader::shouldUsePlugin): (WebCore::SubframeLoader::loadPlugin): (WebCore::SubframeLoader::completeURL):
  • loader/SubframeLoader.h: Added. (WebCore::SubframeLoader::containsPlugins):
  • page/Page.cpp:
  • page/XSSAuditor.h:
  • platform/graphics/wince/MediaPlayerProxy.cpp:
  • plugins/MimeType.cpp:
  • rendering/RenderApplet.cpp:
  • rendering/RenderEmbeddedObject.cpp:
3:22 PM Changeset in webkit [61583] by Simon Fraser
  • 9 edits
    2 moves in trunk

2010-06-21 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson.

Rename DrawingAreaProxyUpdateChunk to ChunkedUpdateDrawingArea
​https://bugs.webkit.org/show_bug.cgi?id=40948

Rename DrawingAreaUpdateChunk to ChunkedUpdateDrawingArea.

  • UIProcess/API/mac/WKView.mm: (-[WKView initWithFrame:pageNamespaceRef:]):
  • UIProcess/ChunkedUpdateDrawingArea.cpp: Added. (WebKit::ChunkedUpdateDrawingArea::ChunkedUpdateDrawingArea): (WebKit::ChunkedUpdateDrawingArea::~ChunkedUpdateDrawingArea): (WebKit::ChunkedUpdateDrawingArea::paint): (WebKit::ChunkedUpdateDrawingArea::setSize): (WebKit::ChunkedUpdateDrawingArea::setPageIsVisible): (WebKit::ChunkedUpdateDrawingArea::didSetSize): (WebKit::ChunkedUpdateDrawingArea::update): (WebKit::ChunkedUpdateDrawingArea::didReceiveMessage):
  • UIProcess/ChunkedUpdateDrawingArea.h: Added. (WebKit::ChunkedUpdateDrawingArea::encode):
  • UIProcess/DrawingAreaProxyUpdateChunk.cpp: Removed.
  • UIProcess/DrawingAreaProxyUpdateChunk.h: Removed.
  • UIProcess/mac/DrawingAreaProxyUpdateChunkMac.mm: (WebKit::ChunkedUpdateDrawingArea::page): (WebKit::ChunkedUpdateDrawingArea::ensureBackingStore): (WebKit::ChunkedUpdateDrawingArea::invalidateBackingStore): (WebKit::ChunkedUpdateDrawingArea::platformPaint): (WebKit::ChunkedUpdateDrawingArea::drawUpdateChunkIntoBackingStore):
  • UIProcess/win/DrawingAreaProxyUpdateChunkWin.cpp: (WebKit::ChunkedUpdateDrawingArea::page): (WebKit::ChunkedUpdateDrawingArea::ensureBackingStore): (WebKit::ChunkedUpdateDrawingArea::invalidateBackingStore): (WebKit::ChunkedUpdateDrawingArea::platformPaint): (WebKit::ChunkedUpdateDrawingArea::drawUpdateChunkIntoBackingStore):
  • UIProcess/win/WebView.cpp: (WebKit::WebView::WebView):
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
3:09 PM Changeset in webkit [61582] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Another Tiger build fix.

  • Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage _tryLoad]):

2:40 PM Changeset in webkit [61581] by andersca@apple.com
  • 12 edits in trunk/WebKit/mac

2010-06-21 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

More WebBasePluginPackage cleanup
​https://bugs.webkit.org/show_bug.cgi?id=40944

  • Plugins/Hosted/HostedNetscapePluginStream.mm: (WebKit::HostedNetscapePluginStream::pluginCancelledConnectionError):
  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost):
  • Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::pluginCancelledConnectionError):
  • Plugins/WebBaseNetscapePluginView.mm: (WebHaltablePlugin::pluginName):
  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): (-[WebBasePluginPackage getPluginInfoFromPLists]): (-[WebBasePluginPackage load]): (-[WebBasePluginPackage dealloc]): (-[WebBasePluginPackage finalize]): (-[WebBasePluginPackage pluginInfo]): (-[WebBasePluginPackage supportsExtension:]): (-[WebBasePluginPackage supportsMIMEType:WebCore::]): (-[WebBasePluginPackage MIMETypeForExtension:]): (-[WebBasePluginPackage isJavaPlugIn]): (-[WebBasePluginPackage versionNumber]): (-[WebBasePluginPackage WebCore::]):
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage openResourceFile]): (-[WebNetscapePluginPackage closeResourceFile:]): (-[WebNetscapePluginPackage getPluginInfoFromResources]): (-[WebNetscapePluginPackage _initWithPath:]): (-[WebNetscapePluginPackage _applyDjVuWorkaround]): (-[WebNetscapePluginPackage _tryLoad]): (-[WebNetscapePluginPackage supportsSnapshotting]): (-[WebNetscapePluginPackage _unloadWithShutdown:]):
  • Plugins/WebPluginDatabase.mm: (-[WebPluginDatabase refresh]): (-[WebPluginDatabase _removePlugin:]):
  • Plugins/WebPluginPackage.mm: (-[WebPluginPackage initWithPath:]): (-[WebPluginPackage load]):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin):
  • WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::getPluginInfo):
2:39 PM Changeset in webkit [61580] by robert@webkit.org
  • 4 edits in trunk

2010-06-21 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Unskip plugins/get-url-that-the-resource-load-delegate-will-disallow.html

It's a Mac-specific test so just add the required LayoutTestController
function as a no-op to avoid failing. Similar approach adopted by other
ports.

​https://bugs.webkit.org/show_bug.cgi?id=33344

  • platform/qt/Skipped:

2010-06-21 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Unskip plugins/get-url-that-the-resource-load-delegate-will-disallow.html

It's a Mac-specific test so just add the required LayoutTestController
function as a no-op to avoid failing. Similar approach adopted by other
ports.

​https://bugs.webkit.org/show_bug.cgi?id=33344

  • DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::addDisallowedURL):
2:36 PM Changeset in webkit [61579] by weinig@apple.com
  • 21 edits
    3 adds in trunk

Patch for ​https://bugs.webkit.org/show_bug.cgi?id=40940
Add message passing support to the WebKit2 API.

Reviewed by Anders Carlsson.

WebKit2:

Adds message passing for both InjectedBundle -> WebContext
and WebContext -> InjectedBundle.

  • Shared/CoreIPCSupport/WebProcessMessageKinds.h:

(WebProcessMessage::):

  • Shared/CoreIPCSupport/WebProcessProxyMessageKinds.h: Added.

(WebProcessProxyMessage::):
(CoreIPC::):

  • UIProcess/API/C/WKContext.cpp:

(WKContextSetInjectedBundleClient):
(WKContextPostMessageToInjectedBundle):

  • UIProcess/API/C/WKContext.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::initializeInjectedBundleClient):
(WebKit::WebContext::forwardMessageToWebContext):
(WebKit::WebContext::postMessageToInjectedBundle):

  • UIProcess/WebContext.h:
  • UIProcess/WebContextInjectedBundleClient.cpp: Added.

(WebKit::WebContextInjectedBundleClient::WebContextInjectedBundleClient):
(WebKit::WebContextInjectedBundleClient::initialize):
(WebKit::WebContextInjectedBundleClient::didRecieveMessageFromInjectedBundle):

  • UIProcess/WebContextInjectedBundleClient.h: Added.
  • UIProcess/WebProcessManager.cpp:

(WebKit::WebProcessManager::processDidClose):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveInjectedBundleMessage):
(WebKit::WebProcessProxy::didReceiveMessage):

  • UIProcess/WebProcessProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundlePostMessage):

  • WebProcess/InjectedBundle/API/c/WKBundle.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::postMessage):
(WebKit::InjectedBundle::didCreatePage):
(WebKit::InjectedBundle::didRecieveMessage):

  • WebProcess/InjectedBundle/InjectedBundle.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::loadInjectedBundle):
(WebKit::WebProcess::forwardMessageToInjectedBundle):
(WebKit::WebProcess::didReceiveMessage):

  • WebProcess/WebProcess.h:
  • mac/WebKit2.exp:
  • win/WebKit2.vcproj:

WebKitTools:

  • Add some test messages.
  • MiniBrowser/mac/AppDelegate.m:

(_didRecieveMessageFromInjectedBundle):
(-[BrowserAppDelegate init]):

  • MiniBrowser/mac/WebBundle/WebBundleMain.m:

(_didClearWindow):
(_didCreatePage):
(_didRecieveMessage):
(WKBundleInitialize):

2:07 PM Changeset in webkit [61578] by robert@webkit.org
  • 2 edits in trunk/LayoutTests

2010-06-21 Robert Hogan <​robert@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Missing forward entries when dumping back/forward list

These now pass.
​https://bugs.webkit.org/show_bug.cgi?id=32470

http/tests/navigation/dynamic-iframe-dynamic-form-back-entry.html
http/tests/navigation/parsed-iframe-dynamic-form-back-entry.html

  • platform/qt/Skipped:
2:01 PM Changeset in webkit [61577] by sullivan@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fixed bugzilla URL in previous checkin.

1:59 PM Changeset in webkit [61576] by sullivan@apple.com
  • 2 edits in trunk/JavaScriptCore

RetainPtr can't be used in HashMaps or HashSets
<​https://bugs.webkit.org/post_bug.cgi>

Reviewed by Adam Roben.

Added hashing knowledge similar to that in COMPtr.h.

  • wtf/RetainPtr.h:

(WTF::RetainPtr::RetainPtr):
New function, copied from COMPtr.h but for the type change.
(WTF::RetainPtr::isHashTableDeletedValue):
Ditto.
(WTF::RetainPtr::hashTableDeletedValue):
Ditto.
Added template code for HashTraits and PtrHash copied from COMPtr.h but for the type change.
The only difference is that constructDeletedValue() matches the RefPtr implementation (in HashTraits.h)
rather than the COMPtr implementation.

1:59 PM Changeset in webkit [61575] by robert@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-06-21 Robert Hogan <​robert@webkit.org>

[Qt] Build fix for Qt on Windows MSVC2008

Unreviewed, build fix.

Fix by Jocelyn Turcotte.

  • Api/qwebframe.cpp:
1:50 PM Changeset in webkit [61574] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Another PowerPC build fix.

  • Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage openResourceFile]):
(-[WebNetscapePluginPackage _tryLoad]):

1:48 PM Changeset in webkit [61573] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2010-06-21 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, expectations update.

Mark hyphenation tests as failing on Chromium
Hyphenation landed in ​http://trac.webkit.org/changeset/61548.

  • platform/chromium/test_expectations.txt: Added failing tests.
1:40 PM Changeset in webkit [61572] by Nate Chapin
  • 2 edits in trunk/WebKit/win

2010-06-21 Nate Chapin <Nate Chapin>

Unreviewed, Windows build fix.

Update WebFrame to use FrameLoaderStateMachine in

firstLayoutDone().

  • WebFrame.cpp: (WebFrame::firstLayoutDone):
1:32 PM Changeset in webkit [61571] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Try to fix the PowerPC build.

  • Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage _tryLoad]):

1:26 PM Changeset in webkit [61570] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, fixing a test expectations on Windows.

  • platform/win/fast/dom/prototype-inheritance-expected.txt:
1:20 PM Changeset in webkit [61569] by Nate Chapin
  • 2 edits in trunk/WebCore

2010-06-21 Nate Chapin <Nate Chapin>

Unreviewed, build fix.

Bad merge, left a reference to m_committedFirstRealDocumentLoad in
​http://trac.webkit.org/changeset/61568.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::transitionToCommitted):
1:06 PM Changeset in webkit [61568] by Nate Chapin
  • 19 edits
    2 adds in trunk

2010-06-21 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Remove a couple of FrameLoader's unused boolean members
(m_receivedData, m_cancellingWithLoadInProcess) and merge
several more into a single state machine called FrameLoaderStateMachine
(m_firstLayoutDone, m_creatingInitialEmptyDocument,
m_isDisplayingInitialEmptyDocument, m_committedFirstRealDocumentLoad).

​https://bugs.webkit.org/show_bug.cgi?id=39695

Refactor only, so no new tests.

  • WebCore.base.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/DocumentWriter.cpp: (WebCore::DocumentWriter::createDocument): (WebCore::DocumentWriter::begin):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::init): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::didOpenURL): (WebCore::FrameLoader::didExplicitOpen): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::didBeginDocument): (WebCore::FrameLoader::finishedParsing): (WebCore::FrameLoader::provisionalLoadStarted): (WebCore::FrameLoader::logCanCachePageDecision): (WebCore::FrameLoader::logCanCacheFrameDecision): (WebCore::FrameLoader::frameHasLoaded): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::didFirstLayout): (WebCore::FrameLoader::frameLoadCompleted): (WebCore::FrameLoader::dispatchDidCommitLoad):
  • loader/FrameLoader.h: (WebCore::FrameLoader::stateMachine):
  • loader/FrameLoaderStateMachine.cpp: Added.
  • loader/FrameLoaderStateMachine.h: Added.
  • loader/HistoryController.cpp: (WebCore::HistoryController::restoreScrollPositionAndViewState): (WebCore::HistoryController::saveDocumentState):
  • loader/ProgressTracker.cpp: (WebCore::ProgressTracker::incrementProgress):
  • loader/RedirectScheduler.cpp: (WebCore::RedirectScheduler::scheduleLocationChange): (WebCore::RedirectScheduler::scheduleFormSubmission):
12:58 PM Changeset in webkit [61567] by kevino@webkit.org
  • 3 edits in trunk/WebKit/wx

Build fix after conversion of WebInterfaceSystem to Obj-C++.

12:57 PM Changeset in webkit [61566] by kevino@webkit.org
  • 2 edits in trunk/WebCore

[wx] Build fix. Fix header includes for ENABLE(DATABASE)

12:22 PM Changeset in webkit [61565] by Dimitri Glazkov
  • 2 edits in trunk/WebKit/mac

2010-06-21 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Dan Bernstein.

Chromium/Mac build fix.

  • WebCoreSupport/WebSystemInterface.mm: Change the order of wtf/Platform.h include to let other

headers smell it.

12:11 PM Changeset in webkit [61564] by atwilson@chromium.org
  • 47 edits
    6 deletes in trunk

WebKitTools: Unreviewed.

Rolling back 61551 and 61555 due to test failures.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setEditingBehavior):

  • DumpRenderTree/mac/UIDelegate.mm:

LayoutTests: Unreviewed rollback.

Rolling back 61551 and 61555 due to test failures on Linux/Win.

  • fast/dom/Window/window-function-frame-getter-precedence-expected.txt:
  • fast/dom/Window/window-function-frame-getter-precedence.html:
  • fast/dom/Window/window-function-name-getter-precedence-expected.txt:
  • fast/dom/Window/window-function-name-getter-precedence.html:
  • fast/dom/Window/window-lookup-precedence-expected.txt:
  • fast/dom/Window/window-lookup-precedence.html:
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-properties.html:
  • fast/dom/script-tests/prototype-inheritance.js:
  • fast/events/resources/modal-dialog.html: Removed.
  • fast/events/show-modal-dialog-onblur-onfocus-expected.txt: Removed.
  • fast/events/show-modal-dialog-onblur-onfocus.html: Removed.
  • fast/harness/resources/modal-dialog.html: Removed.
  • fast/harness/show-modal-dialog-expected.txt: Removed.
  • fast/harness/show-modal-dialog.html: Removed.
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T1-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T10-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T11-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T2-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T3-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T4-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T5-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T6-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T7-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T8-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T9-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T1-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T10-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T11-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T2-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T3-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T4-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T5-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T6-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T7-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T8-expected.txt:
  • fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T9-expected.txt:
  • http/tests/security/cross-frame-access-call-expected.txt:
  • http/tests/security/cross-frame-access-call.html:
  • http/tests/security/cross-frame-access-get-expected.txt:
  • http/tests/security/cross-frame-access-get.html:
  • http/tests/security/cross-frame-access-put-expected.txt:
  • http/tests/security/resources/cross-frame-iframe-for-put-test.html:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
11:57 AM Changeset in webkit [61563] by andersca@apple.com
  • 11 edits in trunk

WebKit2: Make WebKit2 build with clang++

Reviewed by Sam Weinig.

  • Platform/CoreIPC/Connection.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView keyUp:]):
(-[WKView keyDown:]):

  • UIProcess/WebHistoryClient.h:
  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebProcess.h:

WebKitTools: Make DumpRenderTree build with clang++

Reviewed by Sam Weinig.

  • DumpRenderTree/mac/DumpRenderTreePasteboard.m:

(-[LocalPasteboard setPropertyList:forType:]):

  • DumpRenderTree/mac/DumpRenderTreeWindow.mm:

(-[DumpRenderTreeWindow keyDown:]):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::elementDoesAutoCompleteForElementWithId):
(LayoutTestController::isCommandEnabled):

11:41 AM Changeset in webkit [61562] by andersca@apple.com
  • 12 edits in trunk/WebKit/mac

Make all of WebKit build with clang++

Reviewed by Dan Bernstein.

  • DefaultDelegates/WebDefaultPolicyDelegate.m:

(-[WebDefaultPolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):

  • Plugins/Hosted/NetscapePluginHostManager.mm:
  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView resolvedURLStringForURL:target:]):

  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView setSuppressLayout:]):

  • WebView/WebHTMLRepresentation.mm:
  • WebView/WebNavigationData.mm:

(-[WebNavigationData initWithURLString:title:originalRequest:response:hasSubstituteData:clientRedirectSource:]):

  • WebView/WebPDFRepresentation.mm:

(-[WebPDFRepresentation setDataSource:]):
(-[WebPDFRepresentation receivedData:withDataSource:]):
(-[WebPDFRepresentation receivedError:withDataSource:]):

  • WebView/WebResource.mm:

(-[WebResource description]):

  • WebView/WebSerializedJSValue.mm:

(-[WebSerializedJSValue initWithValue:context:exception:]):

  • WebView/WebVideoFullscreenController.mm:

(-[WebVideoFullscreenController WebCore::]):
(-[WebVideoFullscreenController setMediaElement:WebCore::]):
(-[WebVideoFullscreenController setDelegate:]):
(-[WebVideoFullscreenController enterFullscreen:]):

  • WebView/WebView.mm:

(-[WebView _openFrameInNewWindowFromMenu:]):
(-[WebView _geolocationDidChangePosition:]):

11:38 AM Changeset in webkit [61561] by mitz@apple.com
  • 2 edits in trunk/WebKitLibraries

Speculative build fix.

  • WebKitSystemInterface.h:
11:29 AM Changeset in webkit [61560] by andersca@apple.com
  • 2 edits in trunk/WebCore

Fix clang++ build.

  • loader/FormSubmission.h:
11:19 AM Changeset in webkit [61559] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2010-06-21 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

Add a missing include in AsyncImageResizer.h

  • html/AsyncImageResizer.h: Added the IntSize include.
11:02 AM Changeset in webkit [61558] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

2010-06-21 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Remove unused dictionary ivars from WebBasePluginPackage
​https://bugs.webkit.org/show_bug.cgi?id=40928

  • Plugins/WebBasePluginPackage.h:
  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage getPluginInfoFromPLists]): (-[WebBasePluginPackage dealloc]):
  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage getPluginInfoFromResources]):
10:51 AM Changeset in webkit [61557] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2010-06-21 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, expectations tweak.

Use C++-style comments rather than Python-style.

  • platform/chromium/test_expectations.txt: Tweaked comment style.
10:46 AM Changeset in webkit [61556] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Build fix

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

10:44 AM Changeset in webkit [61555] by atwilson@chromium.org
  • 6 adds in trunk/LayoutTests/fast

2010-06-21 Drew Wilson <​atwilson@chromium.org>

Unreviewed.

Missing files from r61551.

  • fast/events/resources/modal-dialog.html: Added.
  • fast/events/show-modal-dialog-onblur-onfocus-expected.txt: Added.
  • fast/events/show-modal-dialog-onblur-onfocus.html: Added.
  • fast/harness/resources/modal-dialog.html: Added.
  • fast/harness/show-modal-dialog-expected.txt: Added.
  • fast/harness/show-modal-dialog.html: Added.
10:43 AM Changeset in webkit [61554] by Adam Roben
  • 2 edits in trunk/WebCore

Call NotifyAddrChange again each time we are notified of a change

NotifyAddrChange only notifies you of a single change. If you want to
listen for subsequent changes, you have to call it again.

Fixes <​http://webkit.org/b/33004> NetworkStateNotifier ignores all
state changes after the first.

No test possible, as we don't have a way to modify the system's
network adapters when running tests.

Reviewed by Anders Carlsson.

  • platform/network/win/NetworkStateNotifierWin.cpp:

(WebCore::NetworkStateNotifier::addrChangeCallback): Call
registerForAddressChange as soon as we're notified of an address
change, so we'll also get notified of the *next* address change. I
added the call here instead of in addressChanged (which is called
later on the main thread) to minimize the time between the callback
and registering again (so that we won't miss changes that happen in
rapid succession).

10:43 AM Changeset in webkit [61553] by oliver@apple.com
  • 5 edits in trunk/JavaScriptCore

2010-06-19 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoffrey Garen.

Need to ensure that we grow the RegisterFile when creating a callframe for host code
​https://bugs.webkit.org/show_bug.cgi?id=40858
<rdar://problem/8108986>

In the past the use of the callframe in hostcode was much more
limited. Now that we expect the callframe to always be valid
we need to grow the RegisterFile so that this is actually the
case. In this particular case the problem was failing to grow
the registerfile could lead to a callframe that extended beyond
RegisterFiler::end(), so vm re-entry would clobber the callframe
other scenarios could also lead to badness.

I was unable to construct a simple testcase to trigger badness,
and any such testcase would be so dependent on exact vm stack
layout that it would be unlikely to work as a testcase following
any callframe or register allocation changes anyway.

Thankfully the new assertion I added should help to catch these
failures in future, and triggers on a couple of tests currently.

  • interpreter/CallFrame.cpp: (JSC::CallFrame::registerFile):
  • interpreter/CallFrame.h: (JSC::ExecState::init):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
10:21 AM Changeset in webkit [61552] by mitz@apple.com
  • 2 edits in trunk/WebCore

Release build fix

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::tryHyphenating):

10:17 AM Changeset in webkit [61551] by atwilson@chromium.org
  • 47 edits in trunk

DumpRenderTree should allow tests with modal dialogs
​https://bugs.webkit.org/show_bug.cgi?id=35350

Patch by Prasad Tammana <​prasadt@chromium.org> on 2010-06-21
Reviewed by Darin Adler.

  • DumpRenderTree/LayoutTestController.cpp:

(abortModalCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::abortModal):
Add abortModal method to LayoutTestController and make it available from script.

.:

  • DumpRenderTree/mac/UIDelegate.mm: Add support for showModalDialog.

(-[UIDelegate modalWindowWillClose:]): Observer for NSWindowWillCloseNotifications to call
abortModal from when modal window closes.
(-[UIDelegate webViewRunModal:]): Delegate method for showModalDialog to run the modal loop.

WebKitTools:

  • DumpRenderTree/mac/UIDelegate.mm: Add support for showModalDialog.

(-[UIDelegate modalWindowWillClose:]): Observer for NSWindowWillCloseNotifications to call
abortModal from when modal window closes.
(-[UIDelegate webViewRunModal:]): Delegate method for showModalDialog to run the modal loop.

10:14 AM Changeset in webkit [61550] by leandro@webkit.org
  • 2 edits in trunk

2010-06-21 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Unreviewed debug build fix.

[CMake] Do not force build type to Release
​https://bugs.webkit.org/show_bug.cgi?id=40566

  • CMakeLists.txt:
10:07 AM Changeset in webkit [61549] by mitz@apple.com
  • 2 edits in trunk/WebCore

Windows build fix

  • WebCore.vcproj/WebCore.vcproj: Fixed a typo.
9:54 AM Changeset in webkit [61548] by mitz@apple.com
  • 42 edits
    12 adds in trunk

WebCore: CSS3: Implement the 'hyphens' and 'hyphenate-character' properties
​https://bugs.webkit.org/show_bug.cgi?id=10228

Reviewed by Darin Adler.

Tests: fast/text/hyphenate-character.html

fast/text/hyphens.html

Added -webkit-hyphens and -webkit-hyphenate-character as specified in
<​http://www.w3.org/TR/2010/WD-css3-gcpm-20100608/#hyphenation>.

  • Android.mk: Added Hyphenation.cpp.
  • CMakeLists.txt: Ditto.
  • GNUmakefile.am: Added Hyphenation.{cpp,h}.
  • WebCore.base.exp: Exported wkGetHyphenationLocationBeforeIndex().
  • WebCore.gypi: Added Hyphenation.{cpp,h}.
  • WebCore.pro: Added Hyphenation.{cpp,h}.
  • WebCore.vcproj/WebCore.vcproj: Added Hyphenation.{cpp,h}.
  • WebCore.xcodeproj/project.pbxproj: Added Hyphenation.{cpp,h}.
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added the -webkit-hyphenate-character
and -webkit-hyphens cases.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Validate values for the new properties.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added. Maps from a Hyphens value to an identifier.
(WebCore::CSSPrimitiveValue::operator Hyphens): Added. Maps from an identifier to a Hyphens value.

  • css/CSSPropertyNames.in: Added -webkit-hyphenate-character and -webkit-hyphens.
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty): Apply the new properties to the RenderStyle.

  • css/CSSValueKeywords.in:
  • platform/mac/WebCoreSystemInterface.h: Added wkGetHyphenationLocationBeforeIndex.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.
  • platform/text/CharacterNames.h: Added the hyphen character.
  • platform/text/Hyphenation.cpp: Added.

(WebCore::lastHyphenLocation): Added this default implementation for platforms that do not implement
hyphenation yet. It calls notImplemented() and returns 0.

  • platform/text/Hyphenation.h: Added.
  • platform/text/cf/HyphenationCF.cpp: Added.

(WebCore::lastHyphenLocation): Returns the last hyphenation location occurring in the given string before
the given index. Uses the current search locale (which is based on the top language preference of the user)
for hyphenation.

  • platform/text/mac/HyphenationMac.mm: Added.

(WebCore::lastHyphenLocation): Returns the last hyphenation location occurring in the given string before
the given index. Returns 0 if the current search locale is not "en", because the platform only knows how to
hyphenate English.

  • rendering/BidiRun.h:

(WebCore::BidiRun::BidiRun): Added a boolean member, m_hasHyphen, and initialized it to false in the constructor.

  • rendering/InlineBox.h:

(WebCore::InlineBox::InlineBox): Renamed m_hasEllipsisBox to m_hasEllipsisBoxOrHyphen, because this bit is now
shared by two subclass: RootInlineBox uses it for hasEllipsisBox(), while InlineTextBox uses it for hasHyphen().

  • rendering/InlineTextBox.cpp:

(WebCore::adjustCharactersAndLengthForHyphen): Added this helper function to get the hyphen string from the style
and return a UChar* and length for the concatenation of the given text with the hyphen string.
(WebCore::InlineTextBox::selectionRect): If the selected range touches the end and the box has a hyphen,
compute the width of the text with the hyphen string concatenated to it.
(WebCore::InlineTextBox::paint): If the box has a hyphen, draw the text with the hyphen string concatenated to it.
(WebCore::InlineTextBox::paintSelection): Similarly concatenate the hyphen string.

  • rendering/InlineTextBox.h:

(WebCore::InlineTextBox::hasHyphen): Added this accessor.
(WebCore::InlineTextBox::setHasHyphen): Ditto.

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::constructLine): Copy the m_hasHyphen flag from the run to its text box.
(WebCore::RenderBlock::computeHorizontalPositionsForLine): Add the width of the hyphen string when computing the
width of a box that has a hyphen.
(WebCore::RenderBlock::layoutInlineChildren): If the line was hyphenated, set the m_hasHyphen flag on the
logically last run.
(WebCore::tryHyphenating): Added this helper function which checks if a piece of text that does not fit on the
line could be hyphenated such that the part before the hyphen, including the hyphen, would fit. Given the amount
of space remaining on the line, it finds the longest prefix that can fit in the remaining space (which leaving room for
the hyphen), and then checks for a hyphenation location within that prefix.
(WebCore::RenderBlock::findNextLineBreak): In the 'hyphens: none' case, prevent line breaks at soft hyphens.
In the 'hyphens: auto' case, try hyphenating when a word will not fit in the remaining space on the line.

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::detachEllipsisBox): Changed to use hasEllipsisBox() and setHasEllipsisBox().
(WebCore::RootInlineBox::clearTruncation): Ditto.
(WebCore::RootInlineBox::placeEllipsis): Ditto.
(WebCore::RootInlineBox::paintEllipsisBox): Ditto.
(WebCore::RootInlineBox::nodeAtPoint): Ditto.
(WebCore::RootInlineBox::ellipsisBox): Ditto.

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::hasEllipsisBox): Added this accessor.
(WebCore::RootInlineBox::setHasEllipsisBox): Ditto.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff): Return a layout hint if the hyphens setting or hyphenate-character differs.
(WebCore::RenderStyle::hyphenString): Added. For hyphenate-character: auto, returns the hyphen character.

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::hyphens): Added this accessor.
(WebCore::InheritedFlags::hyphenateCharacter): Ditto.
(WebCore::InheritedFlags::setHyphens): Ditto.
(WebCore::InheritedFlags::setHyphenateCharacter): Ditto.
(WebCore::InheritedFlags::initialHyphens): Added. Returns HyphensManual.
(WebCore::InheritedFlags::initialHyphenateCharacter): Added. Returns the null string, corresponding to
a value of 'auto'.

  • rendering/style/RenderStyleConstants.h:

Added a Hyphens enum.

  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData): Initialize and copy the new members.
(WebCore::StyleRareInheritedData::operator==): Compare the new members.

  • rendering/style/StyleRareInheritedData.h: Added two new members: hyphens and hyphenateCharacter.

WebKit/mac: WebKit part of implementing the 'hyphens' and 'hyphenate-character' properties
​https://bugs.webkit.org/show_bug.cgi?id=10228

Reviewed by Darin Adler.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Initialize wkGetHyphenationLocationBeforeIndex.

WebKitLibraries: WebKitSystemInterface part of CSS3: Implement the 'hyphens' and 'hyphenate-character' properties
​https://bugs.webkit.org/show_bug.cgi?id=10228

Reviewed by Darin Adler.

  • WebKitSystemInterface.h: Added WKGetHyphenationLocationBeforeIndex().
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:

LayoutTests: Added tests for the 'hyphens' and 'hyphenate-character' properties
​https://bugs.webkit.org/show_bug.cgi?id=10228

Reviewed by Darin Adler.

  • fast/text/hyphenate-character.html: Added.
  • fast/text/hyphens.html: Added.
  • platform/gtk/Skipped:
  • platform/mac/fast/text/hyphenate-character-expected.checksum: Added.
  • platform/mac/fast/text/hyphenate-character-expected.png: Added.
  • platform/mac/fast/text/hyphenate-character-expected.txt: Added.
  • platform/mac/fast/text/hyphens-expected.checksum: Added.
  • platform/mac/fast/text/hyphens-expected.png: Added.
  • platform/mac/fast/text/hyphens-expected.txt: Added.
  • platform/qt/Skipped:
  • platform/win/Skipped:
9:39 AM Changeset in webkit [61547] by Dimitri Glazkov
  • 2 edits in trunk/WebKit/chromium

2010-06-21 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] Enable EVENTSOURCE, FILE_WRITER, and IMAGE_RESIZER
​https://bugs.webkit.org/show_bug.cgi?id=40905

EVENTSOURCE: It is already enabled in Chromium browser. This fixes
some tests with Chromium DRT.

FILE_WRITER and IMAGE_RESIZER: Enable experimental features in
order to test them before enabling them in Chromium browser.

  • features.gypi:
9:36 AM Changeset in webkit [61546] by Dimitri Glazkov
  • 7 edits in trunk/WebCore

2010-06-03 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Plumb FormSubmission through to ScheduledFormSubmission.
​https://bugs.webkit.org/show_bug.cgi?id=40137

No behavior change, covered by existing tests.

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::prepareFormSubmission): Moved creation of action URL

instance here from FrameLoader::submit, because it makes more sense here,
also added a FIXME to investigate existing code later.

  • loader/FormSubmission.cpp: (WebCore::FormSubmission::FormSubmission): Changed action to be a KURL, not a String. (WebCore::FormSubmission::create): Ditto. (WebCore::FormSubmission::populateFrameLoadRequest): Added, moving the logic from

FrameLoader::submit closer to the data.

  • loader/FormSubmission.h: (WebCore::FormSubmission::action): Changed type to KURL. (WebCore::FormSubmission::clearTarget): Added. (WebCore::FormSubmission::referrer): Added. (WebCore::FormSubmission::setReferrer): Added. (WebCore::FormSubmission::origin): Added. (WebCore::FormSubmission::setOrigin): Added.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): Cleaned up to make it more about decision-making,

not data manipulation.

  • loader/RedirectScheduler.cpp: (WebCore::ScheduledFormSubmission::ScheduledFormSubmission): Changed to accept FormSubmission as argument. (WebCore::ScheduledFormSubmission::fire): Changed to use FormSubmission. (WebCore::RedirectScheduler::scheduleFormSubmission): Removed assert that no longer makes sense,

changed to use FormSubmission.

  • loader/RedirectScheduler.h: Updated ScheduledFormSubmission decl to hold FormSubmission ref.
9:02 AM Changeset in webkit [61545] by eric@webkit.org
  • 19 edits in trunk

2010-06-21 Satish Sampath <​satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
​https://bugs.webkit.org/show_bug.cgi?id=40878

  • configure.ac:

2010-06-21 Satish Sampath <​satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
​https://bugs.webkit.org/show_bug.cgi?id=40878

  • Configurations/FeatureDefines.xcconfig:

2010-06-21 Satish Sampath <​satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
​https://bugs.webkit.org/show_bug.cgi?id=40878

No new tests are needed, because there is no new functionality.

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • WebCore.pri:

2010-06-21 Satish Sampath <​satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
​https://bugs.webkit.org/show_bug.cgi?id=40878

  • features.gypi:

2010-06-21 Satish Sampath <​satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
​https://bugs.webkit.org/show_bug.cgi?id=40878

  • Configurations/FeatureDefines.xcconfig:

2010-06-21 Satish Sampath <​satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
​https://bugs.webkit.org/show_bug.cgi?id=40878

  • Configurations/FeatureDefines.xcconfig:

2010-06-21 Satish Sampath <​satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
​https://bugs.webkit.org/show_bug.cgi?id=40878

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

2010-06-21 Satish Sampath <​satish@chromium.org>

Reviewed by Steve Block.

Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
​https://bugs.webkit.org/show_bug.cgi?id=40878

  • Scripts/build-webkit:
8:50 AM Changeset in webkit [61544] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-21 Kwang Yul Seo <​skyul@company100.net>

Reviewed by Kent Tamura.

[BREWMP] Use global new/delete operator overloading with USE_SYSTEM_MALLOC=1
​https://bugs.webkit.org/show_bug.cgi?id=40653

Currently, other ports do not use global new/delete operator overloading
when USE_SYSTEM_MALLOC=1. Brew MP uses system malloc, but it needs to enable
"global fastMalloc new" because the default new/delete causes crash on device.
We need to replace them with Brew MP's MALLOC/FREE.

  • wtf/FastMalloc.h:
8:50 AM Changeset in webkit [61543] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/WebKit/qt

[Qt] Fix MSVC build.

Reviewed by nobody, build fix.

The max macro was replacing the max function used in StringImpl.h
when compiling moc_NotificationPresenterClientQt.cpp.

  • WebCoreSupport/NotificationPresenterClientQt.cpp:
7:50 AM Changeset in webkit [61542] by eric@webkit.org
  • 8 edits in trunk/WebCore

2010-06-21 Hans Wennborg <​hans@chromium.org>

Reviewed by Jeremy Orlow.

Delete DOM storage databases when they are empty.
​https://bugs.webkit.org/show_bug.cgi?id=40767

Even if a page clears its local storage, the database file for it stays around,
and there is currently no mechanism that deletes them.

After doing the "final sync" of a storage area, the StorageAreaSyncMaster should
see if the database is empty, and in that case delete it.

Tests:

manual-tests/localstorage-empty-database.html

  • manual-tests/localstorage-empty-database.html: Added link to clear local storage for testing that the file is removed.
  • storage/LocalStorageTask.cpp: (WebCore::LocalStorageTask::LocalStorageTask): Added local storage task type DeleteEmptyDatabase. (WebCore::LocalStorageTask::performTask): Ditto.
  • storage/LocalStorageTask.h: (WebCore::LocalStorageTask::): Ditto. (WebCore::LocalStorageTask::createDeleteEmptyDatabase): Ditto.
  • storage/StorageAreaSync.cpp: (WebCore::StorageAreaSync::scheduleFinalSync): When scheduling final sync, also schedule DeleteEmptyDatabase. (WebCore::StorageAreaSync::sync): Return early if final sync has nothing to sync. (WebCore::StorageAreaSync::deleteEmptyDatabase): Added function to check if a database is empty and in that case delete it.
  • storage/StorageAreaSync.h: Ditto.
  • storage/StorageSyncManager.cpp: (WebCore::StorageSyncManager::scheduleDeleteEmptyDatabase): Added function for scheduling DeleteEmptyDatabase task.
  • storage/StorageSyncManager.h: Ditto.
7:36 AM Changeset in webkit [61541] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-06-21 Kent Tamura <​tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Initialization for http/tests/loading/
​https://bugs.webkit.org/show_bug.cgi?id=40902

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::runFileTest):
7:08 AM Changeset in webkit [61540] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-06-21 Balazs Kelemen <​kb@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] Avoid unnecessary image conversion in RGBA32Buffer::zeroFill()
​https://bugs.webkit.org/show_bug.cgi?id=40910

  • platform/image-decoders/qt/RGBA32BufferQt.cpp: (WebCore::RGBA32Buffer::zeroFill):
6:37 AM Changeset in webkit [61539] by mnaganov@chromium.org
  • 6 edits
    1 add in trunk/WebKit/chromium

2010-06-21 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by NOBODY (OOPS!).

[Chromium] Remove usage of static WebDevToolsAgentClient::sendMessageToFrontendOnIOThread.

Also, move WebDevToolsMessageTransport to its own header file.

​https://bugs.webkit.org/show_bug.cgi?id=40913

  • DEPS:
  • WebKit.gyp:
  • public/WebDevToolsAgent.h:
  • public/WebDevToolsAgentClient.h:
  • public/WebDevToolsMessageTransport.h: Added. (WebKit::WebDevToolsMessageTransport::~WebDevToolsMessageTransport):
  • src/WebDevToolsAgentImpl.cpp: (WebKit::):
5:14 AM Changeset in webkit [61538] by Laszlo Gombos
  • 2 edits in trunk/WebKit/qt

2010-06-21 Laszlo Gombos <Laszlo Gombos>

Unreviewed, Symbian build fix.

[Qt] Update the def file with recent new exports.

  • symbian/eabi/QtWebKitu.def:
4:43 AM Changeset in webkit [61537] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Unreviewed build fix.

[Qt] Fix package builds

Don't use rpath unless we're building inside the trunk.

  • declarative/declarative.pro:
2:40 AM Changeset in webkit [61536] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/JavaScriptCore

[Qt] Work around a build problem with libjscore on Symbian.
​https://bugs.webkit.org/show_bug.cgi?id=40840

Reviewed by Simon Hausmann.

Sbsv2 sometimes have problems with debug/release configuration
determination causing QtWebKit in release to try linking with the debug
JavaScriptCore static library. This patch limit the jscore/jscored
r58306 fix necessary for mac builds only to the mac platform to prevent the
different name problem.

The real fix would be to fix qmake or the toolchain, this patch might
help meanwhile.

2:33 AM Changeset in webkit [61535] by jocelyn.turcotte@nokia.com
  • 2 edits in trunk/WebKitTools

Adding myself to the committers list.

Unreviewed.

  • Scripts/webkitpy/common/config/committers.py:
1:30 AM Changeset in webkit [61534] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-06-21 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Decode images directly to QPixmap
​https://bugs.webkit.org/show_bug.cgi?id=40797

Decode images to QPixmap directly instead of QImage when possible.
RGBA32Buffer transforms the pixmap back to image if
necessary.

This improve the performance with certain graphic system, and
can reduce memory usage.

  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::setData): (WebCore::ImageDecoderQt::internalHandleCurrentImage):
  • platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::getAddr):
  • platform/image-decoders/qt/RGBA32BufferQt.cpp: (WebCore::RGBA32Buffer::clear): (WebCore::RGBA32Buffer::zeroFill): (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::setSize): (WebCore::RGBA32Buffer::asNewNativeImage): (WebCore::RGBA32Buffer::setPixmap):
1:10 AM Changeset in webkit [61533] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-06-21 Patrick Gansterer <​paroga@paroga.com>

Reviewed by Kent Tamura.

Buildfix after r61338.
​https://bugs.webkit.org/show_bug.cgi?id=40888

roundUpAllocationSize is needed in RegisterFile.h.

  • jit/ExecutableAllocator.h:
12:59 AM Changeset in webkit [61532] by dumi@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed, fixing expectations.

  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
12:10 AM Changeset in webkit [61531] by dumi@chromium.org
  • 32 edits
    2 adds in trunk

Adding the SQLException class which will be used to report sync DB errors.
​https://bugs.webkit.org/show_bug.cgi?id=40607

Reviewed by Adam Barth.

WebCore:

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMBinding.cpp:

(WebCore::setDOMException):

  • bindings/js/JSExceptionBase.cpp:

(WebCore::toExceptionBase):

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::setDOMException):

  • bindings/v8/V8Proxy.h:
  • dom/ExceptionCode.cpp:

(WebCore::):
(WebCore::getExceptionCodeDescription):

  • dom/ExceptionCode.h:

(WebCore::):

  • page/DOMWindow.idl:
  • storage/SQLException.h: Added.

(WebCore::SQLException::create):
(WebCore::SQLException::):
(WebCore::SQLException::SQLException):

  • storage/SQLException.idl: Added.

LayoutTests:

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/win/fast/js/global-constructors-expected.txt:
12:06 AM Changeset in webkit [61530] by eric@webkit.org
  • 1 edit
    12 adds in trunk/LayoutTests

2010-06-20 Hayato Ito <​hayato@chromium.org>

Reviewed by Kent Tamura.

Add tests for CSS3 Paged Media to make sure page breaks should happen at right places.
Two tests (allowed-page-break and page-break-margin-collapsed) are expected to fail
due to lack of support.

​https://bugs.webkit.org/show_bug.cgi?id=40770

  • printing/allowed-page-breaks-expected.txt: Added.
  • printing/allowed-page-breaks.html: Added.
  • printing/no-content-empty-pages-expected.txt: Added.
  • printing/no-content-empty-pages.html: Added.
  • printing/page-break-display-none-expected.txt: Added.
  • printing/page-break-display-none.html: Added.
  • printing/page-break-margin-collapsed-expected.txt: Added.
  • printing/page-break-margin-collapsed.html: Added.
  • printing/script-tests/allowed-page-breaks.js: Added. (test):
  • printing/script-tests/no-content-empty-pages.js: Added. (test):
  • printing/script-tests/page-break-display-none.js: Added. (test):
  • printing/script-tests/page-break-margin-collapsed.js: Added. (test):
Note: See TracTimeline for information about the timeline view.