Timeline



Jun 14, 2012:

11:52 PM Changeset in webkit [120411] by keishi@webkit.org
  • 26 edits
    6 copies in trunk

Add color property to input type=range
​https://bugs.webkit.org/show_bug.cgi?id=89067

Reviewed by Kent Tamura.

Source/WebCore:

Adding color property to input type=range in preparation for
supporting tick marks for datalist for input type=range.

  • css/html.css:

(input[type="range"]): Setting color property for input type=range.
This will set the color of tick mark when we implement <datalist>.

  • css/themeChromiumLinux.css:

(input[type=range]):

  • css/themeWin.css:

(input[type="range"]):

LayoutTests:

  • fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt:
  • fast/repaint/slider-thumb-float-expected.txt:
  • platform/chromium-linux/fast/dom/HTMLInputElement/input-slider-update-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/dom/HTMLInputElement/input-slider-update-expected.txt.
  • platform/chromium-linux/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt: Copied from LayoutTests/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt.
  • platform/chromium-linux/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-linux/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-linux/fast/forms/range/slider-thumb-stylability-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/range/slider-thumb-stylability-expected.txt.
  • platform/chromium-linux/fast/repaint/slider-thumb-drag-release-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/repaint/slider-thumb-drag-release-expected.txt.
  • platform/chromium-linux/fast/repaint/slider-thumb-float-expected.txt: Copied from LayoutTests/fast/repaint/slider-thumb-float-expected.txt.
  • platform/chromium-mac/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-mac/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-mac/fast/forms/range/input-appearance-range-expected.txt:
  • platform/chromium-win/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
  • platform/chromium-win/fast/forms/box-shadow-override-expected.txt:
  • platform/chromium-win/fast/forms/input-appearance-height-expected.txt:
  • platform/chromium-win/fast/forms/range/input-appearance-range-expected.txt:
  • platform/chromium-win/fast/forms/range/range-thumb-height-percentage-expected.txt:
  • platform/chromium-win/fast/forms/range/slider-padding-expected.txt:
  • platform/chromium-win/fast/forms/range/slider-thumb-shared-style-expected.txt:
  • platform/chromium-win/fast/forms/range/slider-thumb-stylability-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/range/slider-thumb-stylability-expected.txt.
  • platform/chromium-win/fast/repaint/slider-thumb-drag-release-expected.txt:
  • platform/mac/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
  • platform/mac/fast/forms/range/range-thumb-height-percentage-expected.txt:
  • platform/mac/fast/forms/range/slider-padding-expected.txt:
  • platform/mac/fast/forms/range/slider-thumb-shared-style-expected.txt:
  • platform/mac/fast/forms/range/slider-thumb-stylability-expected.txt:
  • platform/mac/fast/repaint/slider-thumb-drag-release-expected.txt:
11:38 PM Changeset in webkit [120410] by tkent@chromium.org
  • 8 edits in trunk/Source

Support file extensions in HTMLInputElement::accept
​https://bugs.webkit.org/show_bug.cgi?id=88298

Reviewed by Hajime Morita.

Source/WebCore:

The WHATWG specification added file extensions supoprt for
HTMLInputElement::accept recently.

In the WebCore FileChooser interface, we rejected invalid MIME type
strings in HTMLInputElement::acceptMIMETypes(), and platform file
choosers don't expect that it containts file extensions. So, this patch
introduces additional member "acceptFileExtensions" to
FileChooserSettings, and it contains only file extensions specified by
an accept attribute.

  • html/FileInputType.cpp:

Sets HTMLInputElement::acceptFileExtensions() to
FileChooserSettings::acceptFileExtensions.
(WebCore::FileInputType::handleDOMActivateEvent):
(WebCore::FileInputType::receiveDropForDirectoryUpload):

  • html/HTMLInputElement.cpp:

(WebCore::isValidFileExtension): Added.
(WebCore::parseAcceptAttribute):
Common part for acceptMIMETyps() and acceptFileExtensions().
(WebCore::HTMLInputElement::acceptMIMETypes):
Uses parseAcceptAttribute() with isValidMIMEType().
(WebCore::HTMLInputElement::acceptFileExtensions):
Added. Uses parseAcceptAttribute() with isValidFileExtension().

  • html/HTMLInputElement.h:

(HTMLInputElement): Add acceptFileExtensions().

  • platform/FileChooser.h:

(FileChooserSettings): Add acceptFileExtensions and acceptTypes().

  • platform/FileChooser.cpp:

(WebCore::FileChooserSettings::acceptTypes): Added.

Source/WebKit/chromium:

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::runOpenPanel):
Use FileChooserSettings::acceptTypes() to get both of MIME types and file extensions.

11:35 PM Changeset in webkit [120409] by eae@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed rebaseline for mac chromium following r120403.

  • platform/chromium-mac/tables/mozilla/bugs/bug55527-expected.txt: Removed.
11:33 PM Changeset in webkit [120408] by Kaustubh Atrawalkar
  • 4 edits in trunk/Source/WebKit/chromium

Remove support for counterValueForElementById from chromium port
​https://bugs.webkit.org/show_bug.cgi?id=88851

Reviewed by Adam Barth.

Moved the counterValueForElementById from LayoutTestCotroller to Internals so
remove the old platform specific implementations as it exclusively tests WebCore functionality.

  • public/WebFrame.h:

(WebFrame):

  • src/WebFrameImpl.cpp:

(WebKit):

  • src/WebFrameImpl.h:

(WebFrameImpl):

11:23 PM Changeset in webkit [120407] by rniwa@webkit.org
  • 5 edits in trunk/LayoutTests

Use testRunner instead of layoutTestController in battery status and canvas tests
​https://bugs.webkit.org/show_bug.cgi?id=88761

Reviewed by Tony Chang.

  • batterystatus/resources/event-after-navigation-new.html:
  • batterystatus/script-tests/event-after-navigation.js:
  • canvas/philip/tests.js:

(_addTest.endTest):
(_addTest.window.onload):
(_addTest):

  • canvas/philip/tests/2d.text-custom-font-load-crash.html:
11:18 PM Changeset in webkit [120406] by commit-queue@webkit.org
  • 1 edit
    2 deletes in trunk/Source/WebCore

[chromium] Remove unused CanvasLayerChromium.h/cpp from the tree
​https://bugs.webkit.org/show_bug.cgi?id=89152

Patch by James Robinson <​jamesr@chromium.org> on 2012-06-14
Reviewed by Adrienne Walker.

These files have been unused and not in the build system since r119769

  • platform/graphics/chromium/CanvasLayerChromium.cpp: Removed.
  • platform/graphics/chromium/CanvasLayerChromium.h: Removed.
11:17 PM Changeset in webkit [120405] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Cast paddings to int in RenderTableCell
​https://bugs.webkit.org/show_bug.cgi?id=88918

Patch by Emil A Eklund <​eae@chromium.org> on 2012-06-14
Reviewed by Levi Weintraub.

Add test ensuring that table cells does not wrap when using fractional
paddings.

  • fast/sub-pixel/table-cells-with-padding-do-not-wrap-expected.txt: Added.
  • fast/sub-pixel/table-cells-with-padding-do-not-wrap.html: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
  • platform/chromium/TestExpectations:
11:16 PM Changeset in webkit [120404] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Selection - Crash when manipulating selection by dragging handle
​https://bugs.webkit.org/show_bug.cgi?id=89160

RIMBUG:164970
Avoid to set position in shadow tree to the new selection's base. It
crashes when setting a shadow position to a selection' base.

Patch by Sean Wang <​Xuewen.Wang@torchmobile.com.cn> on 2012-06-14
Reviewed by Antonio Gomes.

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):

11:13 PM LayoutUnit edited by eae@chromium.org
(diff)
11:07 PM Changeset in webkit [120403] by eae@chromium.org
  • 12 edits
    2 adds in trunk

Cast paddings to int in RenderTableCell
​https://bugs.webkit.org/show_bug.cgi?id=88918

Reviewed by Levi Weintraub.

Source/WebCore:

Table layout uses integers throughout yet the TableCell paddingLeft/
Right/Top/Bottom methods returns LayoutUnits. This causes inconsistent
rounding as some call sites cast the numbers to ints before doing
computation and others do computation before casting.

By changing the methods to always cast the padding values to int we
ensure consistent padding calculations.

Ideally we'd change the type of the return value for the methods but as
they are overriden that would likely cause more confusion.

Test: fast/sub-pixel/table-cells-with-padding-do-not-wrap.html

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paddingTop):
(WebCore::RenderTableCell::paddingBottom):
(WebCore::RenderTableCell::paddingLeft):
(WebCore::RenderTableCell::paddingRight):
(WebCore::RenderTableCell::paddingBefore):
(WebCore::RenderTableCell::paddingAfter):

LayoutTests:

Add test ensuring that table cells does not wrap when using fractional
paddings.

  • fast/sub-pixel/table-cells-with-padding-do-not-wrap-expected.txt: Added.
  • fast/sub-pixel/table-cells-with-padding-do-not-wrap.html: Added.
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
  • platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
  • platform/chromium/TestExpectations:
10:55 PM Changeset in webkit [120402] by bashi@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Check the result of FontCache::getCachedFontPlatformData()
​https://bugs.webkit.org/show_bug.cgi?id=89141

Reviewed by Kent Tamura.

The value of FontCache::getCachedFontPlatformData() could be invalid,
so we should check the value before use it.

No new tests. No new functionality.

  • platform/graphics/skia/FontCacheSkia.cpp:

(WebCore::FontCache::getFontDataForCharacters):

10:53 PM Changeset in webkit [120401] by commit-queue@webkit.org
  • 6 edits in trunk

Fix framebuffer completeness test
​https://bugs.webkit.org/show_bug.cgi?id=89127

Patch by Gregg Tavares <​gman@google.com> on 2012-06-14
Reviewed by Kenneth Russell.

No new tests just fixing failing tests.

  • html/canvas/WebGLFramebuffer.cpp:

(WebCore::WebGLFramebuffer::initializeAttachments):

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::isTexInternalFormatColorBufferCombinationValid):

  • platform/graphics/GraphicsContext3D.cpp:

(WebCore::GraphicsContext3D::getClearBitsByAttachmentType):
(WebCore):
(WebCore::GraphicsContext3D::getClearBitsByFormat):
(WebCore::GraphicsContext3D::getChannelBitsByFormat):

  • platform/graphics/GraphicsContext3D.h:
10:29 PM Changeset in webkit [120400] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed expectation update.

  • Marked cross-domain-message-event-dispatch.html and track-cue-rendering-snap-to-lines-not-set.html
  • platform/chromium/TestExpectations:
10:24 PM Changeset in webkit [120399] by mary.wu@torchmobile.com.cn
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] empty plugin cause browser hang
​https://bugs.webkit.org/show_bug.cgi?id=89091

Reviewed by Rob Buis.

Add check before clean pluginView in FrameLoaderBlackBerry in case
it didn't have any content.
RIM PR# 165336
Reviewed internally by George Staikos

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::finishedLoading):

9:59 PM Changeset in webkit [120398] by enne@google.com
  • 2 edits in trunk/Source/WebCore

[chromium] Make TiledLayerChromium robust to unexpected null tiles
​https://bugs.webkit.org/show_bug.cgi?id=89143

Reviewed by James Robinson.

Although there shouldn't ever be null tiles in the map, it appears to
be occurring frequently enough to show up in crash reports. In the
short term, be robust to this so the tiler doesn't crash. This should
eventually be reverted.

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::setLayerTreeHost):
(WebCore::TiledLayerChromium::invalidateRect):
(WebCore::TiledLayerChromium::updateTiles):
(WebCore::TiledLayerChromium::resetUpdateState):

9:34 PM Changeset in webkit [120397] by tkent@chromium.org
  • 12 edits
    4 adds in trunk

Validate form state strings in FormController::setStateForNewFormElements()
​https://bugs.webkit.org/show_bug.cgi?id=88768

Reviewed by Hajime Morita.

.:

  • Source/autotools/symbols.filter: Expose some symbols used by Internals.cpp.

Source/WebCore:

Reject invalid form state vectors. This state vectors are generated by
WebKit itself. However it can be invalid because

  • Serialized state vectors can be corrupted
  • A future version of WebKit might change the format

So we had better reject unexpected state vectors as possible.

Test: fast/forms/state-restore-broken-state.html

  • WebCore.exp.in: Expose some symbols used by Internals.cpp.
  • html/FormController.cpp:

(WebCore::isNotFormControlTypeCharacter): A helper for state validation.
(WebCore::FormController::setStateForNewFormElements):
Reject state vectors of which size is not a multiple of 3, or a type name is invalid.

  • testing/Internals.cpp:

(WebCore::Internals::formControlStateOfPreviousHistoryItem):
Returns a form state vector of the previous document.
(WebCore::Internals::setFormControlStateOfPreviousHistoryItem):
Sets a form state vector for the previous document.

  • testing/Internals.h: Declare new functions.
  • testing/Internals.idl: ditto.

Source/WebKit2:

  • win/WebKit2.def: Expose some symbols used by Internals.cpp.
  • win/WebKit2CFLite.def: ditto.

LayoutTests:

  • fast/forms/resources/state-restore-broken-state-1.html: Added.
  • fast/forms/resources/state-restore-broken-state-2.html: Added.
  • fast/forms/state-restore-broken-state-expected.txt: Added.
  • fast/forms/state-restore-broken-state.html: Added.
9:21 PM Changeset in webkit [120396] by commit-queue@webkit.org
  • 10 edits in trunk

Unreviewed, rolling out r120393.
​http://trac.webkit.org/changeset/120393
​https://bugs.webkit.org/show_bug.cgi?id=89163

breaks cr-mac build (Requested by morrita on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-06-14

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:
  • platform/image-decoders/ImageDecoder.h:

(ImageFrame):
(ImageDecoder):

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(turboSwizzled):
(WebCore::JPEGImageReader::JPEGImageReader):
(WebCore::JPEGImageReader::close):
(WebCore::JPEGImageReader::decode):
(JPEGImageReader):
(WebCore::JPEGImageDecoder::outputScanlines):

  • platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageReader::PNGImageReader):
(WebCore::PNGImageReader::close):
(WebCore::PNGImageReader::currentBufferSize):
(PNGImageReader):
(WebCore::PNGImageReader::decodingSizeOnly):
(WebCore::PNGImageReader::interlaceBuffer):
(WebCore::PNGImageReader::hasAlpha):
(WebCore::PNGImageReader::setHasAlpha):
(WebCore::PNGImageDecoder::headerAvailable):
(WebCore::PNGImageDecoder::rowAvailable):

  • platform/image-decoders/skia/ImageDecoderSkia.cpp:

(WebCore):
(WebCore::resolveColorSpace):
(WebCore::createColorSpace):
(WebCore::ImageFrame::setColorProfile):
(WebCore::ImageFrame::setStatus):

Source/WTF:

  • wtf/Platform.h:

LayoutTests:

  • platform/chromium/TestExpectations:
9:17 PM Changeset in webkit [120395] by jchaffraix@webkit.org
  • 4 edits in trunk/Source/WebCore

RenderLayer subtrees without any self-painting layer shouldn't be walked during painting
​https://bugs.webkit.org/show_bug.cgi?id=88888

Reviewed by Simon Fraser.

Performance optimization, covered by existing tests.

The gist of this change is to add a has-self-painting-layer-descendant flag (including an
invalidation logic) that is used to avoid walking subtrees without any self-painting layer.

On ​http://dglazkov.github.com/performance-tests/biggrid.html with a 100,000 rows
by 100 columns table, it brings the paint time during scrolling from ~45ms to ~6ms
on my machine. The test case is a pathologic example here but the optimization should
apply in other cases.

The new update logic piggy-backs on top of the existing updateVisibilityStatus() one that
got repurposed and renamed as part of this change.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::addChild):
(WebCore::RenderLayer::removeChild):
(WebCore::RenderLayer::styleChanged):
These functions were updated to dirty / set the new flag.

(WebCore::RenderLayer::dirtyAncestorChainHasSelfPaintingLayerDescendantStatus):
(WebCore::RenderLayer::setAncestorChainHasSelfPaintingLayerDescendant):
Added those functions to handle setting / invalidating the new flag.

(WebCore::RenderLayer::updateSelfPaintingLayerAfterStyleChange):
Added this function to handle style update.

(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintLayerContentsAndReflection):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::paintList):
Changed this logic to bail out if we have no self-painting descendants. This is what
is giving the performance improvement. Also added some performance ASSERTs to ensure
the methods are not called when they shouldn't.

(WebCore::RenderLayer::updateDescendantDependentFlags):
Renamed from updateVisibilityStatus to account for the new usage.

(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
(WebCore::RenderLayer::collectLayers):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
Updated after updateVisibilityStatus rename.

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::hasSelfPaintingLayerDescendant):
Added the declaration of the new functions as well as the new flag and dirty bit.

8:06 PM Changeset in webkit [120394] by wangxianzhu@chromium.org
  • 5 edits in trunk

[Chromium-Android] Initialize font rendering in DumpRenderTree
​https://bugs.webkit.org/show_bug.cgi?id=89133

Reviewed by Adam Barth.

Source/WebKit/chromium:

  • src/linuxish/WebFontRendering.cpp:

(WebKit::WebFontRendering::setSubpixelPositioning): Now calls WebFontInfo::setSubpixelPositioning to avoid API users from calling both and simplify platform differences at call sites.

Tools:

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::reset):
(LayoutTestController::setTextSubpixelPositioning):

  • DumpRenderTree/chromium/TestShellAndroid.cpp:

(platformInit):

7:53 PM Changeset in webkit [120393] by commit-queue@webkit.org
  • 9 edits in trunk

Source/WebCore: [chromium] Add iccjpeg and qcms to chromium port

​https://bugs.webkit.org/show_bug.cgi?id=81974

Reviewed by Adam Barth.

Covered by existing layout tests which will be rebaselined.

  • WebCore.gyp/WebCore.gyp: Add qcms to the build.
  • platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::qcmsOutputDeviceProfile): Return an sRGB profile. On OSX, return the default RGB profile. Add FIXME to use the user's monitor profile and verify that profile for other platforms.
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (turboSwizzled): For libjpeg-turbo, JCS_EXT_BGRA and JCS_EXT_RGBA are the two known output color spaces for which the decoder uses a data swizzle. (colorSpaceHasAlpha): JPEG's have no alpha in the output color space. For libjpeg-turbo, alpha may be present in the swizzled output color space.

(WebCore::JPEGImageReader::JPEGImageReader):
(WebCore::JPEGImageReader::close):
(WebCore::JPEGImageReader::decode): For QCMSLIB, create the color transform
to use during decoding, and ensure we switch to inputing RGBA data to qcms
even if the desired output data is BGRA: outputScanlines() sends BGRA data
to the frame buffer following color correction if needed.
(JPEGImageReader):
(WebCore::JPEGImageReader::colorTransform): qcms color transform getter.
(WebCore::JPEGImageReader::createColorTransform): Create color transform.
Release the existing transform (if any) and assign to the color transform
created from the color profile data.
(WebCore::JPEGImageDecoder::outputScanlines): Minor style fix. Apply color
transform to each decoded image row.

  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageReader::PNGImageReader): (WebCore::PNGImageReader::close): (WebCore::PNGImageReader::currentBufferSize): Move this adjacent to other setters and getters. (WebCore::PNGImageReader::decodingSizeOnly): Ditto. (WebCore::PNGImageReader::setHasAlpha): Ditto. (WebCore::PNGImageReader::hasAlpha): Ditto. (WebCore::PNGImageReader::interlaceBuffer): Ditto. (WebCore::PNGImageReader::createRowBuffer): Creates a temporary row buffer, used when a color transform is applied to the decoded image pixels. (WebCore::PNGImageReader::rowBuffer): Return the temporary row buffer. (WebCore::PNGImageReader::colorTransform): qcms color transform getter. (WebCore::PNGImageReader::createColorTransform): Create color transform. Release the existing transform (if any) and assign to the color transform created from the color profile data. (WebCore::PNGImageDecoder::headerAvailable): For QCMSLIB, create the color transform to use for decoding. Clear m_colorProfile (not used anymore). (WebCore::PNGImageDecoder::rowAvailable): Create temporary row buffer if a color transform is needed for decoding. Apply color transform to each decoded image row.
  • platform/image-decoders/skia/ImageDecoderSkia.cpp: (WebCore::ImageFrame::setColorProfile): Old method of colorProfiles is no longer used. Add a FIXME to remove the old implementation. (WebCore::ImageFrame::setStatus): Remove old color correction code.

Patch by Tony Payne <​tpayne@chromium.org> on 2012-06-14

Source/WTF: [chromium] Add iccjpeg and qcms to chromium port.
​https://bugs.webkit.org/show_bug.cgi?id=81974

Patch by Tony Payne <​tpayne@chromium.org> on 2012-06-14

  • wtf/Platform.h: Add Chromium USE defines for ICCJPEG and QCMSLIB

to each Chromium platform, excluding Android.

Reviewed by Adam Barth.

7:50 PM Changeset in webkit [120392] by commit-queue@webkit.org
  • 10 edits
    3 deletes in trunk

Unreviewed, rolling out r120384.
​http://trac.webkit.org/changeset/120384
​https://bugs.webkit.org/show_bug.cgi?id=89157

breaks create-blob-url-from-data-url.html (Requested by
morrita on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-06-14

Source/WebCore:

  • fileapi/Blob.cpp:

(WebCore::Blob::Blob):

  • fileapi/BlobURL.cpp:

(WebCore::BlobURL::createBlobURL):

  • fileapi/BlobURL.h:

(BlobURL):

  • fileapi/FileReaderLoader.cpp:

(WebCore::FileReaderLoader::start):

  • fileapi/ThreadableBlobRegistry.cpp:

(WebCore):
(WebCore::ThreadableBlobRegistry::registerBlobURL):
(WebCore::ThreadableBlobRegistry::unregisterBlobURL):

  • fileapi/ThreadableBlobRegistry.h:

(WebCore):
(ThreadableBlobRegistry):

  • html/DOMURL.cpp:

(WebCore::DOMURL::createObjectURL):

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::create):

LayoutTests:

  • fast/files/file-reader-file-url-expected.txt: Removed.
  • fast/files/file-reader-file-url.html: Removed.
  • fast/files/resources/file-reader-file-url-iframe.html: Removed.
7:46 PM Changeset in webkit [120391] by tony@chromium.org
  • 2 edits
    1 add in trunk/Source/WebKit/chromium

[chromium] Port IFrameRedirectTest.Test from test_shell_tests to webkit_unit_tests
​https://bugs.webkit.org/show_bug.cgi?id=89132

Reviewed by Adam Barth.

This test is currently in src/webkit/glue/iframe_redirect_unittest.cc
and uses test_shell's layoutTestController. Moving this will make
it easier to get rid of layoutTestController in test_shell.

  • tests/WebFrameTest.cpp:

(WebKit::TEST_F):
(WebKit):

  • tests/data/iframe_redirect.html: Added.
7:25 PM Changeset in webkit [120390] by yosin@chromium.org
  • 1 edit
    2 adds in trunk/Source/WebCore

[Forms] Copy RenderTextControlSingleLine.{cpp,h} to RenderSearchFiled.{cpp,h}
​https://bugs.webkit.org/show_bug.cgi?id=89155

Reviewed by Kent Tamura.

This patch copies RenderTextControlSingleLine.cpp and .h into RenderSearchField.cpp
and .h with just "cp" code. New files aren't compiled until bug 88980.

No new tests. This patch doesn't change behavior.

  • rendering/RenderSearchField.cpp: Added.

(WebCore::RenderTextControlInnerBlock::positionForPoint):
(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::containerElement):
(WebCore::RenderTextControlSingleLine::innerBlockElement):
(WebCore::RenderTextControlSingleLine::innerSpinButtonElement):
(WebCore::RenderTextControlSingleLine::resultsButtonElement):
(WebCore::RenderTextControlSingleLine::cancelButtonElement):
(WebCore::RenderTextControlSingleLine::textBaseStyle):
(WebCore::RenderTextControlSingleLine::addSearchResult):
(WebCore::RenderTextControlSingleLine::showPopup):
(WebCore::RenderTextControlSingleLine::hidePopup):
(WebCore::RenderTextControlSingleLine::paint):
(WebCore::RenderTextControlSingleLine::layout):
(WebCore::RenderTextControlSingleLine::nodeAtPoint):
(WebCore::RenderTextControlSingleLine::styleDidChange):
(WebCore::RenderTextControlSingleLine::capsLockStateMayHaveChanged):
(WebCore::RenderTextControlSingleLine::hasControlClip):
(WebCore::RenderTextControlSingleLine::controlClipRect):
(WebCore::RenderTextControlSingleLine::getAvgCharWidth):
(WebCore::RenderTextControlSingleLine::preferredContentWidth):
(WebCore::RenderTextControlSingleLine::computeControlHeight):
(WebCore::RenderTextControlSingleLine::updateFromElement):
(WebCore::RenderTextControlSingleLine::createInnerTextStyle):
(WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
(WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility):
(WebCore::RenderTextControlSingleLine::visibilityForCancelButton):
(WebCore::RenderTextControlSingleLine::textShouldBeTruncated):
(WebCore::RenderTextControlSingleLine::autosaveName):
(WebCore::RenderTextControlSingleLine::valueChanged):
(WebCore::RenderTextControlSingleLine::itemText):
(WebCore::RenderTextControlSingleLine::itemLabel):
(WebCore::RenderTextControlSingleLine::itemIcon):
(WebCore::RenderTextControlSingleLine::itemIsEnabled):
(WebCore::RenderTextControlSingleLine::itemStyle):
(WebCore::RenderTextControlSingleLine::menuStyle):
(WebCore::RenderTextControlSingleLine::clientInsetLeft):
(WebCore::RenderTextControlSingleLine::clientInsetRight):
(WebCore::RenderTextControlSingleLine::clientPaddingLeft):
(WebCore::RenderTextControlSingleLine::clientPaddingRight):
(WebCore::RenderTextControlSingleLine::listSize):
(WebCore::RenderTextControlSingleLine::selectedIndex):
(WebCore::RenderTextControlSingleLine::popupDidHide):
(WebCore::RenderTextControlSingleLine::itemIsSeparator):
(WebCore::RenderTextControlSingleLine::itemIsLabel):
(WebCore::RenderTextControlSingleLine::itemIsSelected):
(WebCore::RenderTextControlSingleLine::setTextFromItem):
(WebCore::RenderTextControlSingleLine::fontSelector):
(WebCore::RenderTextControlSingleLine::hostWindow):
(WebCore::RenderTextControlSingleLine::autoscroll):
(WebCore::RenderTextControlSingleLine::scrollWidth):
(WebCore::RenderTextControlSingleLine::scrollHeight):
(WebCore::RenderTextControlSingleLine::scrollLeft):
(WebCore::RenderTextControlSingleLine::scrollTop):
(WebCore::RenderTextControlSingleLine::setScrollLeft):
(WebCore::RenderTextControlSingleLine::setScrollTop):
(WebCore::RenderTextControlSingleLine::scroll):
(WebCore::RenderTextControlSingleLine::logicalScroll):
(WebCore::RenderTextControlSingleLine::createScrollbar):
(WebCore::RenderTextControlSingleLine::inputElement):

  • rendering/RenderSearchField.h: Added.

(RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::popupIsVisible):
(WebCore::RenderTextControlSingleLine::isTextField):
(WebCore::toRenderTextControlSingleLine):
(RenderTextControlInnerBlock):
(WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock):
(WebCore::RenderTextControlInnerBlock::hasLineIfEmpty):

7:11 PM Changeset in webkit [120389] by tkent@chromium.org
  • 4 edits in trunk/Source/WebCore

[JSC/V8] "DOMString[]" for function return values should not be null
​https://bugs.webkit.org/show_bug.cgi?id=89151

Reviewed by Kentaro Hara.

jsArray and v8Array are used for "DOMString[]", not "DOMString[]?". So
we should not return JavaScript null object.

No new tests. We have no plan to use this code in production code for
now. It will be used for window.internals functions.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::jsArray): For null input, returns an empty array, not null.

  • bindings/v8/V8Binding.cpp:

(WebCore::v8Array): Implement DOMStringList -> JavaScript array conversion.
Like jsArray(), we don't return null object.

  • bindings/v8/V8Binding.h:

(WebCore): Declare v8Array().

7:04 PM Changeset in webkit [120388] by commit-queue@webkit.org
  • 5 edits
    1 copy in trunk

Disable click/dbl-click on MediaDocument for Chromium. Fix layout test for all platforms.
​https://bugs.webkit.org/show_bug.cgi?id=89129

Source/WebCore:

As titled, click-to-pause and double-click-to-play behavior are unwanted on Chromium. A
long standing issue (~3 years) has been to disable this feature.

Patch by Dale Curtis <​dalecurtis@chromium.org> on 2012-06-14
Reviewed by Eric Carlson.

Uses existing click/double-click test.

  • html/MediaDocument.cpp:

(WebCore::MediaDocument::defaultEventHandler):

LayoutTests:

Fixes layout test to actually test what it says it tests. Previously it was
testing the opposite behavior and passing because MediaDocument auto-plays.

Additionally failing one half of the test would still allow you to pass the
other half. Both issues have been fixed.

Updates the test expectations for Chromium to reflect a failure.

Patch by Dale Curtis <​dalecurtis@chromium.org> on 2012-06-14
Reviewed by Eric Carlson.

  • media/video-click-dblckick-standalone-expected.txt:
  • media/video-click-dblckick-standalone.html:
  • platform/chromium/media/video-click-dblckick-standalone-expected.txt: Copied from LayoutTests/media/video-click-dblckick-standalone-expected.txt.
6:54 PM ScalesAndZooms edited by jamesr@google.com
(diff)
6:45 PM Changeset in webkit [120387] by jianli@chromium.org
  • 6 edits in trunk/LayoutTests

Unreviewed. Skip the failed test due to r120384 for future investigation.

  • platform/chromium/TestExpectations:
  • platform/efl/Skipped:
  • platform/gtk/TestExpectations:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
6:32 PM Changeset in webkit [120386] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] [DRT] Reset the WebAudio setting on DumpRenderTree
​https://bugs.webkit.org/show_bug.cgi?id=88622

Patch by Dongwoo Im <​dw.im@samsung.com> on 2012-06-14
Reviewed by Philippe Normand.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Reset the setting of the Web Audio feature as default.

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

6:26 PM Changeset in webkit [120385] by wangxianzhu@chromium.org
  • 2 edits in trunk/Tools

[Chromium-Android] Should retry a few times when failed to start DumpRenderTree
​https://bugs.webkit.org/show_bug.cgi?id=89124

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/chromium_android.py:

(ChromiumAndroidDriver._start):
(ChromiumAndroidDriver):
(ChromiumAndroidDriver._start_once):

5:57 PM Changeset in webkit [120384] by jianli@chromium.org
  • 10 edits
    3 adds in trunk

FileReader is dysfunctional in documents with "null" origin string
​https://bugs.webkit.org/show_bug.cgi?id=78648

Reviewed by Adam Barth.

Source/WebCore:

The fix is to keep in-memory map from blob URL to SecurityOrigin for the
unique origin case.

Test: fast/files/file-reader-file-url.html

  • fileapi/Blob.cpp:

(WebCore::Blob::Blob):

  • fileapi/BlobURL.cpp:

(WebCore::BlobURL::getOrigin): Return the origin string embeded in the blob URL.
(WebCore):
(WebCore::BlobURL::createBlobURL): Remove the check for null origin string since it is handled now.

  • fileapi/BlobURL.h:

(BlobURL):

  • fileapi/FileReaderLoader.cpp:

(WebCore::FileReaderLoader::start):

  • fileapi/ThreadableBlobRegistry.cpp:

(WebCore):
(WebCore::originMap): Thread-specific in-memory map from the blob URL to the origin.
(WebCore::ThreadableBlobRegistry::registerBlobURL): Add the map from the blob URL to the origin.
(WebCore::ThreadableBlobRegistry::unregisterBlobURL): Remove the map for the unregistered blob URL.
(WebCore::ThreadableBlobRegistry::cachedOrigin): Retrieve the origin associated with the blob URL.

  • fileapi/ThreadableBlobRegistry.h:

(WebCore):
(ThreadableBlobRegistry):

  • html/DOMURL.cpp:

(WebCore::DOMURL::createObjectURL):

  • page/SecurityOrigin.cpp:

(WebCore::cachedOrigin): Return the cached origin for the blob URL if it exists.
(WebCore):
(WebCore::SecurityOrigin::create): Call cachedOrigin to get the cached origin first.

LayoutTests:

  • fast/files/file-reader-file-url-expected.txt: Added.
  • fast/files/file-reader-file-url.html: Added.
  • fast/files/resources/file-reader-file-url-iframe.html: Added.
5:56 PM Changeset in webkit [120383] by commit-queue@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

Add test cases for header/footer elements' AXRoleDescription
​https://bugs.webkit.org/show_bug.cgi?id=88911

Header and footer elements change their accessibility roles depending
on the elements which contain them. Specifically, they are described
as "banner" or "footer" in the general case, and fall back to
generic "group" role descriptions when contained in either article or
section elements. This patch simply tests that existing behavior on
Mac.

Patch by Mike West <​mkwst@chromium.org> on 2012-06-14
Reviewed by Chris Fleizach.

  • platform/mac/accessibility/footer-expected.txt: Added.
  • platform/mac/accessibility/footer.html: Added.
  • platform/mac/accessibility/header-expected.txt: Added.
  • platform/mac/accessibility/header.html: Added.
5:51 PM Changeset in webkit [120382] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[CMAKE] Move JSDeprecatedPeerConnectionCustom.cpp from CMakeLists.txt to UseJSC.cmake
​https://bugs.webkit.org/show_bug.cgi?id=89015

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-06-14
Reviewed by Antonio Gomes.

Include JSDeprecatedPeerConnectionCustom.cpp in UseJSC.cmake
instead of CMakeLists.txt.

No change in functionality so no new tests.

  • CMakeLists.txt:
  • UseJSC.cmake:
5:43 PM Changeset in webkit [120381] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

[Chromium] Sub-pixel text rendering is incorrectly used for WebView with transparent background.
​https://bugs.webkit.org/show_bug.cgi?id=89033

Patch by David Reveman <​reveman@chromium.org> on 2012-06-14
Reviewed by James Robinson.

Add canvas background argument to PageWidgetDelegate::paint and call
PlatformCanvasSkia::setDrawingToImageBuffer to ensure that sub-pixel
rendering is only used when WebView has opaque background.

  • src/PageWidgetDelegate.cpp:

(WebKit::PageWidgetDelegate::paint):

  • src/PageWidgetDelegate.h:
  • src/WebPagePopupImpl.cpp:

(WebKit::WebPagePopupImpl::paint):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::paint):

5:35 PM Changeset in webkit [120380] by shawnsingh@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] CCLayerTreeHostCommonTest.verifyHitTestingForSingleLayer failing in debug
​https://bugs.webkit.org/show_bug.cgi?id=89065

Reviewed by James Robinson.

A debug assertion was being triggered in the hit-testing unit
tests because I accidentally forgot to set the
DebugScopedSetImplThread for the tests.

This patch also re-enables the disabled broken test.

  • tests/CCLayerTreeHostCommonTest.cpp:
5:12 PM Changeset in webkit [120379] by wangxianzhu@chromium.org
  • 6 edits in trunk/Source

[Chromium] Add setAutoHint() and setUseBitmaps() in WebFontRendering
​https://bugs.webkit.org/show_bug.cgi?id=89014

Reviewed by James Robinson.

Source/WebCore:

No new tests because of no change of functionality.

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:

(WebCore):
(WebCore::FontPlatformData::setAutoHint):
(WebCore::FontPlatformData::setUseBitmaps):
(WebCore::FontPlatformData::setAntiAlias):
(WebCore::FontPlatformData::setupPaint):

  • platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:

(FontPlatformData):

Source/WebKit/chromium:

  • public/linuxish/WebFontRendering.h:

(WebFontRendering):

  • src/linuxish/WebFontRendering.cpp:

(WebKit):
(WebKit::WebFontRendering::setAutoHint):
(WebKit::WebFontRendering::setUseBitmaps):
(WebKit::WebFontRendering::setAntiAlias):

5:06 PM Changeset in webkit [120378] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebCore

Merged r120364 -> <rdar://problem/11629106>

5:03 PM Changeset in webkit [120377] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebKit2

Merged r120329 -> <rdar://problem/11449702>

5:03 PM Changeset in webkit [120376] by timothy_horton@apple.com
  • 7 edits in trunk/Source/WebKit2

DrawingArea: Painting is being resumed while the view is not visible
​https://bugs.webkit.org/show_bug.cgi?id=88940
<rdar://problem/11652545>

Reviewed by Dean Jackson.

Using requestAnimationFrame and the fullscreen API on a DrawingArea-backed window would cause
rAF to permanently suspend animations after entering full-screen mode, because of the following:

  1. JavaScript causes fullscreen transition to start.
  2. Painting (and rAF) are suspended.
  3. The page changes size.
    1. DrawingAreaProxyImpl::sizeDidChange() calls DrawingAreaImpl::updateBackingStoreState, which calls DrawingAreaImpl::resumePainting.
    2. DrawingAreaImpl::resumePainting resumes painting, but does *not* resume rAF, because windowIsVisible is (legitimately) false.
  4. The view becomes visible, windowIsVisible is updated to true.
  5. visibilityDidChange() calls resumePainting again, but this time it early exits because painting is not suspended.

Notice that because of the early exit in 4, rAF is never resumed.

To solve this and prevent any further bugs caused by these unnecessary calls to resume/suspendPainting,
temporarily stop sending SuspendPainting/ResumePainting messages from DrawingAreaProxyImpl::visibilityDidChange
during the window animations that occur while entering and exiting full-screen.

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView setAutomaticallySuspendAndResumePainting:]):
(-[WKView automaticallySuspendAndResumePainting]):

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::visibilityDidChange):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::setShouldSuspendAndResumePainting):
(WebKit::WebPageProxy::shouldSuspendAndResumePainting):

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController enterFullScreen:]):
(-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]):

4:59 PM Changeset in webkit [120375] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Fix Chromium test expectation after r120371.

  • platform/chromium/TestExpectations:
4:54 PM Changeset in webkit [120374] by tonyg@chromium.org
  • 2 edits in trunk/Tools

Update webpagereplay to 1.1.2
​https://bugs.webkit.org/show_bug.cgi?id=89118

This includes the following patch which avoids pkg_resources import errors:
​http://code.google.com/p/web-page-replay/source/detail?r=476

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook._install_webpagereplay):

4:53 PM Changeset in webkit [120373] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

Always convert touch events to mouse events if the
meta-tag TouchEventMode::PureWithMouseConversion is set.
Minor style fix.
​https://bugs.webkit.org/show_bug.cgi?id=89115

Patch by Genevieve Mak <​gmak@rim.com> on 2012-06-14
Reviewed by Antonio Gomes.

Reviewed Internally by Antonio Gomes.

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::touchEventCancel):
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):

4:39 PM Changeset in webkit [120372] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed update of chromium TestExpectations to mark hybi/workers/close.html as failing.

  • platform/chromium/TestExpectations:
4:28 PM Changeset in webkit [120371] by rniwa@webkit.org
  • 13 edits in trunk

Get rid of FAIL test expectation
​https://bugs.webkit.org/show_bug.cgi?id=89137

Reviewed by Dirk Pranke.

Tools:

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ResultSummaryTest.test_summarized_results_wontfix):

  • Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:

(JSONLayoutResultsGenerator):

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(result_was_expected):
(suffixes_for_expectations):
(TestExpectationsModel._add_test):
(TestExpectations):
(TestExpectations.get_rebaselining_failures):
(TestExpectations.remove_configuration_from_test):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(FunctionsTest.test_result_was_expected):
(FunctionsTest.test_suffixes_for_expectations):
(TestExpectationSerializerTests.test_parsed_expectations_string):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(test_test_expectations):

  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py:

(TestExpectationsTestCase.test_valid_expectations):

LayoutTests:

  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
4:18 PM Changeset in webkit [120370] by dpranke@chromium.org
  • 5 edits in trunk/Tools

webkitpy: remove DummyOptions and clean up the code in Port.get_option() and Port.set_option_default()
​https://bugs.webkit.org/show_bug.cgi?id=89135

Reviewed by Ryosuke Niwa.

This patch is just some minor cleanup and simplification. There
should be no functional changes here.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.init):
(Port.get_option):
(Port.set_option_default):

  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:

(ChromiumWinTest.test_setup_environ_for_server_register_cygwin):

  • Scripts/webkitpy/style/checkers/test_expectations.py:

(TestExpectationsChecker._determine_port_from_expectations_path):

  • Scripts/webkitpy/tool/mocktool.py:

(MockOptions.ensure_value):

4:09 PM Changeset in webkit [120369] by ryuan.choi@samsung.com
  • 9 edits in trunk/Source

[EFL] Move cursor related code from WidgetEfl to ewk_view and EflScreenUtilities.
​https://bugs.webkit.org/show_bug.cgi?id=88803

Reviewed by Chang Shu.

Because WebProcess can not control cursor,
setCursor should be passed to ChromeClient like other ports.

Source/WebCore:

  • platform/Widget.h:

(Widget):

  • platform/efl/EflScreenUtilities.cpp:

(WebCore::applyFallbackCursor): Moved from WidgetEfl.cpp.
(WebCore):
(WebCore::isUsingEcoreX): Moved from WidgetEfl.cpp.

  • platform/efl/EflScreenUtilities.h:

(WebCore):

  • platform/efl/WidgetEfl.cpp: Removes cursor related codes.

(WebCore::WidgetPrivate::WidgetPrivate):
(WebCore::Widget::~Widget):
(WebCore::Widget::setCursor): Redirect to HostWindow.
(WebCore::Widget::setEvasObject):

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::setCursor):

  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new): Check whether ecore_x can be used.
(_ewk_view_priv_del):
(_ewk_view_smart_add):
Change order of initialization to use base structure in _ewk_view_priv_new.
(ewk_view_cursor_set): Moved from Widget::applyCursor.

  • ewk/ewk_view_private.h:

(WebCore):

4:00 PM Changeset in webkit [120368] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

[BlackBerry] Implement computeRAMSize for QNX
​https://bugs.webkit.org/show_bug.cgi?id=89110

Patch by Yong Li <​yoli@rim.com> on 2012-06-14
Reviewed by Rob Buis.

  • wtf/RAMSize.cpp:

(WTF::computeRAMSize):

3:38 PM Changeset in webkit [120367] by rniwa@webkit.org
  • 19 edits in trunk

Radio node lists do not get updated when inserted back into a document
​https://bugs.webkit.org/show_bug.cgi?id=88825

Reviewed by Darin Adler.

Source/WebCore:

The bug was caused by RadioNodeList's m_node not being adjusted back to a document after
it was removed from the document and inserted back. While we could be doing this adjustment again
when the HTMLFormElement is inserted back into the document, this whole approach is fragile
because adds a maintenance burden on root elements of RadioNodeList.

Change the approach to the problem instead and detect when m_node is detached from the document.
Now RadioNodeList and LabelsNodeList will always use its root element as m_node and
DynamicSubtreeNodeList's node() will then determine whether it should use its document or not based
on the flag (rootedAtDocument) passed by the constructor of the node list and m_node->inDocument().

Also invalidate node lists rooted at the document level regardless where the DOM mutation took place.

  • dom/ClassNodeList.cpp:

(WebCore::ClassNodeList::~ClassNodeList):

  • dom/Document.cpp:

(WebCore::Document::registerDynamicSubtreeNodeList): Moved from Node.
(WebCore::Document::unregisterDynamicSubtreeNodeList): Ditto.

  • dom/Document.h:

(Document):

  • dom/DynamicNodeList.cpp:

(WebCore::DynamicSubtreeNodeList::DynamicSubtreeNodeList): Takes DynamicNodeListRootType which tell us
whether node() should return m_node's document by default or not.
(WebCore::DynamicSubtreeNodeList::length): Refactor code to avoid node() multiple times.
(WebCore::DynamicSubtreeNodeList::itemForwardsFromCurrent): Ditto.
(WebCore::DynamicSubtreeNodeList::itemBackwardsFromCurrent): Ditto.
(WebCore::DynamicNodeList::itemWithName): Ditto.

  • dom/DynamicNodeList.h:

(WebCore::DynamicNodeList::DynamicNodeList):
(WebCore::DynamicNodeList::node): Returns m_node->document() if m_node is still in the document and
the node list was rooted at document.
(WebCore::DynamicNodeList::Caches::Caches):
(Caches):
(DynamicNodeList):
(DynamicSubtreeNodeList):

  • dom/NameNodeList.cpp:

(WebCore::NameNodeList::~NameNodeList):

  • dom/Node.cpp:

(WebCore):
(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanged): Invalidate m_listsInvalidatedAtDocument
at document instead of trying to invalidate it on every ancestor we traverse.
(WebCore::Node::invalidateNodeListsCacheAfterChildrenChanged): Ditto.
(WebCore::NodeListsNodeData::invalidateCachesForDocument): Extracted from
invalidateCachesThatDependOnAttributes.
(WebCore::NodeListsNodeData::invalidateCachesThatDependOnAttributes):
(WebCore::Node::radioNodeList):

  • dom/Node.h:

(Node):

  • dom/NodeRareData.h:

(NodeListsNodeData):

  • dom/TagNodeList.cpp:

(WebCore::TagNodeList::~TagNodeList):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::removedFrom):

  • html/LabelsNodeList.cpp:

(WebCore::LabelsNodeList::LabelsNodeList):

  • html/RadioNodeList.cpp:

(WebCore::RadioNodeList::RadioNodeList): Takes Element* first since that's the order we use elsewhere.

  • html/RadioNodeList.h:

(WebCore::RadioNodeList::create):
(RadioNodeList):

LayoutTests:

Add a test case to an existing test.

  • fast/forms/radionodelist-whose-form-element-detached-from-domtree-expected.txt:
  • fast/forms/radionodelist-whose-form-element-detached-from-domtree.html:
3:33 PM Changeset in webkit [120366] by tony@chromium.org
  • 3 edits in trunk/Source/WebCore

Fix bit packing of StyleRareInheritedData on Windows
​https://bugs.webkit.org/show_bug.cgi?id=89112

Reviewed by Ryosuke Niwa.

On my machine (64 bit Chromium Linux), StyleRareInheritedData is 168 bytes.

No new tests, added a compile assert to ensure correctness going forward.

  • rendering/style/StyleRareInheritedData.cpp:

(SameSizeAsStyleRareInheritedData):
(WebCore):

  • rendering/style/StyleRareInheritedData.h:

(StyleRareInheritedData):

3:24 PM Changeset in webkit [120365] by Lucas Forschler
  • 49 edits
    8 copies in branches/safari-536-branch

Merged r120357 -> <rdar://problem/11033898>

3:21 PM Changeset in webkit [120364] by kling@webkit.org
  • 2 edits in trunk/Source/WebCore

Crashes below IconDatabase::performPendingRetainAndReleaseOperations().
<​http://webkit.org/b/88846>
<rdar://problem/11629106>

Reviewed by Brady Eidson.

Put isolatedCopy() strings in the retain/release operation queues to make sure it's safe
for secondary threads to ref/deref them in performPendingRetainAndReleaseOperations().
Also added assertions as appropriate.

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::retainIconForPageURL):
(WebCore::IconDatabase::releaseIconForPageURL):
(WebCore::IconDatabase::performPendingRetainAndReleaseOperations):

3:00 PM Changeset in webkit [120363] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

[chromium/linux] Drop deprecated WebFontRenderStyle::useSubpixel
​https://bugs.webkit.org/show_bug.cgi?id=88263

Patch by Daniel Erat <​derat@chromium.org> on 2012-06-14
Reviewed by Adam Barth.

This removes the useSubpixel member, which was replaced by
useSubpixelRendering. Chrome has been updated to set only the
useSubpixelRendering field.

No test updates since the existing behavior shouldn't change.

  • public/linux/WebFontInfo.h:

(WebFontInfo):

  • public/linux/WebFontRenderStyle.h:
  • src/linux/WebFontInfo.cpp:

(WebKit::WebFontInfo::renderStyleForStrike):

  • src/linux/WebFontRenderStyle.cpp:

(WebKit::WebFontRenderStyle::toFontRenderStyle):
(WebKit::WebFontRenderStyle::setDefaults):

2:45 PM Changeset in webkit [120362] by shawnsingh@chromium.org
  • 4 edits in trunk/Source

[chromium] For hit testing in CCLayerTreeHostCommon, need to check that the transform is invertible before inverting it.
​https://bugs.webkit.org/show_bug.cgi?id=89049

Reviewed by Adrienne Walker.

Source/WebCore:

Unit test added to CCLayerTreeHostCommonTest.cpp:

CCLayerTreeHostCommonTest.verifyHitTestingForUninvertibleTransform

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::pointHitsRect):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostCommonTest.cpp:
2:15 PM Changeset in webkit [120361] by mjs@apple.com
  • 3 edits in trunk/Source/WebCore

The whole world rebuilds when you touch any IDL file
​https://bugs.webkit.org/show_bug.cgi?id=89125

Reviewed by Sam Weinig.

No new tests; this only changes the build system and its dependencies.

  • bindings/scripts/preprocess-idls.pl: Optionally generate the

dependencies for supplemental IDLs in Makefile format.

  • DerivedSources.make: Use the new feature of preprocess-idls.pl to generate

the correct IDL dependencies created by Supplemental, then include it. This way,
we avoid the situation where every bindings file implicitly depends on every single
IDL file in the project.

1:41 PM Changeset in webkit [120360] by commit-queue@webkit.org
  • 45 edits
    3 adds in trunk

[chromium] Certain settings in CCSettings could be global
​https://bugs.webkit.org/show_bug.cgi?id=88384

Patch by Ian Vollick <​vollick@chromium.org> on 2012-06-14
Reviewed by James Robinson.

Source/Platform:

  • chromium/public/WebLayerTreeView.h:

(WebCore):
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):

Source/WebCore:

No new tests. No new functionality.

  • WebCore.gypi:
  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(Settings):

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::addAnimation):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateTileSizeAndTilingOption):

  • platform/graphics/chromium/cc/CCDebugRectHistory.cpp:

(WebCore::CCDebugRectHistory::enabled):
(WebCore::CCDebugRectHistory::saveDebugRectsForCurrentFrame):

  • platform/graphics/chromium/cc/CCDebugRectHistory.h:

(WebCore):
(CCDebugRectHistory):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::enabled):
(WebCore::CCHeadsUpDisplay::showPlatformLayerTree):
(WebCore::CCHeadsUpDisplay::showDebugRects):
(WebCore::CCHeadsUpDisplay::draw):
(WebCore::CCHeadsUpDisplay::drawHudContents):
(WebCore::CCHeadsUpDisplay::drawDebugRects):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h:

(WebCore):
(CCHeadsUpDisplay):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::create):
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::animateLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeSettings::CCLayerTreeSettings):
(CCLayerTreeSettings):
(CCLayerTreeHost):
(WebCore::CCLayerTreeHost::settings):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::create):
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::animateLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCRenderer.h:

(CCRendererClient):
(WebCore::CCRenderer::settings):

  • platform/graphics/chromium/cc/CCSettings.cpp: Added.

(WebCore):
(WebCore::CCSettings::perTilePaintingEnabled):
(WebCore::CCSettings::setPerTilePaintingEnabled):
(WebCore::CCSettings::partialSwapEnabled):
(WebCore::CCSettings::setPartialSwapEnabled):
(WebCore::CCSettings::acceleratedAnimationEnabled):
(WebCore::CCSettings::setAcceleratedAnimationEnabled):
(WebCore::CCSettings::reset):

  • platform/graphics/chromium/cc/CCSettings.h: Added.

(WebCore):
(CCSettings):

  • testing/InternalSettings.cpp:
  • testing/InternalSettings.h:

(InternalSettings):

Source/WebKit/chromium:

  • WebKit.gypi:
  • public/WebCompositor.h:

(WebCompositor):

  • public/WebSettings.h:
  • src/WebCompositorImpl.cpp:

(WebKit::WebCompositor::shutdown):
(WebKit):
(WebKit::WebCompositor::setPerTilePaintingEnabled):
(WebKit::WebCompositor::setPartialSwapEnabled):
(WebKit::WebCompositor::setAcceleratedAnimationEnabled):

  • src/WebLayerTreeView.cpp:

(WebKit):
(WebKit::WebLayerTreeView::Settings::operator CCLayerTreeSettings):

  • src/WebSettingsImpl.cpp:
  • src/WebSettingsImpl.h:

(WebSettingsImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:

(WTF):
(CCLayerTreeHostTestShortlived1):
(WTF::CCLayerTreeHostTestShortlived1::CCLayerTreeHostTestShortlived1):
(WTF::CCLayerTreeHostTestShortlived1::beginTest):
(WTF::CCLayerTreeHostTestShortlived1::afterTest):

  • tests/CCTestCommon.h: Added.

(WebKitTests):
(CCScopedSettings):
(WebKitTests::CCScopedSettings::CCScopedSettings):
(WebKitTests::CCScopedSettings::~CCScopedSettings):

  • tests/CCThreadedTest.cpp:

(WebKitTests::MockLayerTreeHostImpl::create):
(WebKitTests::MockLayerTreeHostImpl::MockLayerTreeHostImpl):
(WebKitTests::MockLayerTreeHost::create):
(WebKitTests::MockLayerTreeHost::createLayerTreeHostImpl):
(WebKitTests::MockLayerTreeHost::MockLayerTreeHost):
(WebKitTests::CCThreadedTest::runTest):

  • tests/CCThreadedTest.h:

(CCThreadedTest):
(MockLayerTreeHostImpl):

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKitTests::MockLayerTreeHost::create):
(WebKitTests::MockLayerTreeHost::createLayerTreeHostImpl):
(WebKitTests::MockLayerTreeHost::MockLayerTreeHost):
(WebKitTests::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):

  • tests/LayerChromiumTest.cpp:
  • tests/LayerRendererChromiumTest.cpp:

(LayerRendererChromiumTest):
(TEST_F):
(TEST):

  • tests/TextureLayerChromiumTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:
  • tests/TreeSynchronizerTest.cpp:

(WebKitTests::TEST):

Tools:

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::resetWebSettings):
(TestShell::setPerTilePaintingEnabled):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell):

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::reset):
(WebPreferences::applyTo):

  • DumpRenderTree/chromium/WebPreferences.h:

(WebPreferences):

1:36 PM Changeset in webkit [120359] by alex
  • 12 edits
    1 copy
    2 deletes in trunk/Source

2012-06-14 Alejandro G. Castro <​alex@igalia.com>

[GTK] Add TextureMapper ImageBuffer support as a fallback from the hardware accelerated path
​https://bugs.webkit.org/show_bug.cgi?id=73634

Add the new graphics layer client that uses cairo to render the
composition. The cairo transformations do not support perspective
so in perspective cases we have just a representation not the real
perspective transformation.

This patch adds a new implementation of already tested cases.

Reviewed by Martin Robinson.

  • GNUmakefile.am:
  • WebCoreSupport/AcceleratedCompositingContext.h: (AcceleratedCompositingContext):
  • WebCoreSupport/AcceleratedCompositingContextCairo.cpp: Added.
  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::invalidateWidgetRect): We need to invalidate the widget in this case because we do not directly render to a texture but to the widget surface. (WebKit::ChromeClient::paint): We can not render here, we have to invalidate and wait for the widget rendering.
  • webkit/webkitwebview.cpp: (webkit_web_view_draw): In this case the renderLayersToWindow requires the graphics context used to render in the window. (webkit_web_view_realize): Small cleanup of the priv variable definition.

2012-06-14 Alejandro G. Castro <​alex@igalia.com>

[GTK] Add TextureMapper ImageBuffer support as a fallback from the hardware accelerated path
​https://bugs.webkit.org/show_bug.cgi?id=73634

Remove the TextureMapperCairo classes, now we use
TextureMapperImageBuffer to implement the software fallback. Add
implementation for the 3D transformations in the 2D cairo graphics
context.

Reviewed by Martin Robinson.

This patch adds a new implementation of already tested cases.

  • GNUmakefile.list.am:
  • platform/graphics/cairo/GraphicsContext3DPrivate.cpp: (WebCore): (WebCore::GraphicsContext3DPrivate::paintToTextureMapper): Required for compilation when WebGL is enabled.
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::get3DTransform): (WebCore::GraphicsContext::concat3DTransform): (WebCore::GraphicsContext::set3DTransform):
  • platform/graphics/cairo/TextureMapperCairo.cpp: Removed.
  • platform/graphics/cairo/TextureMapperCairo.h: Removed.
  • platform/graphics/texmap/TextureMapperImageBuffer.cpp: (WebCore::BitmapTextureImageBuffer::updateContents):
1:23 PM Changeset in webkit [120358] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Unreviewed, rolling out r120352.
​http://trac.webkit.org/changeset/120352
​https://bugs.webkit.org/show_bug.cgi?id=89120

It seems something is still wrong with it :/ (Requested by
Ossy on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-06-14

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(Factory.init):
(BuildFactory.init):
(TestFactory.init):
(BuildAndTestFactory.init):
(BuildAndPerfTestFactory.init):
(BuildAndPerfTestWebKit2Factory.init):
(DownloadAndPerfTestFactory.init):
(DownloadAndPerfTestWebKit2Factory.init):

1:22 PM Changeset in webkit [120357] by jpu@apple.com
  • 49 edits
    8 adds in trunk

Mark text with text alternative with blue underline.
​https://bugs.webkit.org/show_bug.cgi?id=83047

Reviewed by Enrica Casucci.

Tests: platform/mac/editing/input/edit-dictated-text-with-alternative.html

platform/mac/editing/input/insert-dictated-text.html

This patch implements visual indication on dictated text with alternatives, and provides UI
to show alternative text on OS X. Majority of the changes is for generalizing existing AlternativeTextController
class to handle dictation alternatives. The two new classes, AlternativeTextUIController and
TextAlternativeWithRange, are used by both WebKit and WK2. So WebCore seems to be the natural place
for them.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/AlternativeTextController.cpp: Expanded exising class interface to support dictation alternatives.

(DictationAlternativeDetails): Marker detail class for dictation alternative mark.
(WebCore::DictationAlternativeDetails::create):
(WebCore::DictationAlternativeDetails::dictationContext):
(WebCore::DictationAlternativeDetails::DictationAlternativeDetails):
(WebCore::markerTypesForAppliedDictationAlternative):
(WebCore::AlternativeTextController::applyAlternativeTextToRange): Generalized existing applyAlternativeTextToRange() to handle dictation alternatives.
(WebCore::AlternativeTextController::timerFired): Expanded existing code to handle dictation alternatives.
(WebCore::AlternativeTextController::handleAlternativeTextUIResult): Expanded existing code to handle dictation alternatives.
(WebCore::AlternativeTextController::respondToChangedSelection): Moved part of the function into respondToMarkerAtEndOfWord() to improve readability.
(WebCore::AlternativeTextController::shouldStartTimerFor):
(WebCore::AlternativeTextController::respondToMarkerAtEndOfWord):
(WebCore::AlternativeTextController::markerDescriptionForAppliedAlternativeText):
(WebCore::AlternativeTextController::removeDictationAlternativesForMarker):
(WebCore::AlternativeTextController::dictationAlternativesForMarker):
(WebCore::AlternativeTextController::applyDictationAlternative):

  • editing/AlternativeTextController.h:
  • editing/Editor.cpp:

(WebCore::Editor::notifyComponentsOnChangedSelection): Renamed existing respondToChangedSelection() function to avoid naming collision.
(WebCore::Editor::appliedEditing):
(WebCore::Editor::unappliedEditing):
(WebCore::Editor::reappliedEditing):
(WebCore::Editor::updateMarkersForWordsAffectedByEditing):
(WebCore::Editor::changeSelectionAfterCommand):
(WebCore::Editor::respondToChangedSelection):
(WebCore::Editor::dictationAlternativesForMarker):
(WebCore::Editor::applyDictationAlternativelternative):

  • editing/Editor.h:
  • editing/FrameSelection.h:
  • editing/mac/AlternativeTextUIController.h: Added. WK1 and WK2 use this class to keep track of text alternatives objects.

(AlternativeTextUIController):
(WebCore::AlternativeTextUIController::AlternativeTextUIController):
(AlernativeTextContextController):
(WebCore::AlternativeTextUIController::AlernativeTextContextController::AlernativeTextContextController):

  • editing/mac/AlternativeTextUIController.mm: Added.

(WebCore::AlternativeTextUIController::AlernativeTextContextController::addAlternatives):
(WebCore::AlternativeTextUIController::AlernativeTextContextController::alternativesForContext):
(WebCore::AlternativeTextUIController::AlernativeTextContextController::removeAlternativesForContext):
(WebCore::AlternativeTextUIController::AlernativeTextContextController::clear):
(WebCore::AlternativeTextUIController::addAlternatives):
(WebCore::AlternativeTextUIController::alternativesForContext):
(WebCore::AlternativeTextUIController::clear):
(WebCore::AlternativeTextUIController::showAlternatives):
(WebCore::AlternativeTextUIController::handleAcceptedAlternative):
(WebCore::AlternativeTextUIController::dismissAlternatives):
(WebCore::AlternativeTextUIController::removeAlternatives):

  • editing/mac/TextAlternativeWithRange.h: Added. A simple struct to make it easier to pass around a pair of text alternatives object and range.
  • editing/mac/TextAlternativeWithRange.mm: Added.

(WebCore::TextAlternativeWithRange::TextAlternativeWithRange):
(WebCore::collectDictationTextAlternatives):

  • page/AlternativeTextClient.h:
  • page/ContextMenuController.cpp: Added code to show alternative dictated text in context menu.

(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::checkOrEnableIfNeeded):

  • platform/ContextMenuItem.h:
  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::dictationAlternatives):

  • rendering/HitTestResult.h:
  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDocumentMarker):

Changes in WebKit include implementation of new functions declared in AlternativeTextClient,
and logic for calling Editor::insertDictatedText() instead of Editor::insertText() when there's
alternatives attached to the input string.

  • WebCoreSupport/CorrectionPanel.mm:

(correctionIndicatorType):
(CorrectionPanel::handleAcceptedReplacement):

  • WebCoreSupport/WebAlternativeTextClient.h:

(WebAlternativeTextClient):

  • WebCoreSupport/WebAlternativeTextClient.mm:

(WebAlternativeTextClient::showCorrectionAlternative):
(WebAlternativeTextClient::dismissAlternative):
(WebAlternativeTextClient::dismissAlternativeSoon):
(WebAlternativeTextClient::recordAutocorrectionResponse):
(WebAlternativeTextClient::removeDictationAlternatives):
(WebAlternativeTextClient::showDictationAlternativeUI):
(WebAlternativeTextClient::dismissDictationAlternativeUI):
(WebAlternativeTextClient::dictationAlternatives):

  • WebView/WebHTMLView.mm:

(-[WebHTMLView validAttributesForMarkedText]):
(-[WebHTMLView insertText:]):

  • WebView/WebView.mm:

(-[WebView handleAcceptedAlternativeText:]):
(-[WebView _getWebCoreDictationAlternatives:fromTextAlternatives:]):
(-[WebView _showDictationAlternativeUI:WebCore::forDictationContext:]):
(-[WebView _dismissDictationAlternativeUI]):
(-[WebView _removeDictationAlternatives:]):
(-[WebView _dictationAlternatives:]):

  • WebView/WebViewData.h:
  • WebView/WebViewData.mm:

(-[WebViewPrivate init]):

  • WebView/WebViewInternal.h:
  • WebView/WebViewPrivate.h:

Changes in WebKit2 include implementation of new functions declared in AlternativeTextClient,
and logic for calling Editor::insertDictatedText() instead of Editor::insertText() when there's
alternatives attached to the input string.

  • Shared/API/c/WKContextMenuItemTypes.h:
  • Shared/API/c/WKSharedAPICast.h:
  • Shared/WebCoreArgumentCoders.cpp:
  • Shared/WebCoreArgumentCoders.h:
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::PageClientImpl):
(WebKit::PageClientImpl::pageClosed):
(WebKit::PageClientImpl::addDictationAlternatives):
(WebKit::PageClientImpl::removeDictationAlternatives):
(WebKit::PageClientImpl::showDictationAlternativeUI):
(WebKit::PageClientImpl::dictationAlternatives):
(WebKit::PageClientImpl::dismissDictationAlternativeUI):

  • UIProcess/API/mac/WKView.mm:

(-[WKView insertText:replacementRange:]):
(-[WKView validAttributesForMarkedText]):
(-[WKView handleAcceptedAlternativeText:]):

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showDictationAlternativeUI):
(WebKit::WebPageProxy::dismissDictationAlternativeUI):
(WebKit::WebPageProxy::removeDictationAlternatives):
(WebKit::WebPageProxy::dictationAlternatives):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/mac/CorrectionPanel.mm:

(correctionIndicatorType):
(WebKit::CorrectionPanel::handleAcceptedReplacement):

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::insertDictatedText):

  • WebProcess/WebCoreSupport/WebAlternativeTextClient.h:

(WebAlternativeTextClient):

  • WebProcess/WebCoreSupport/mac/WebAlternativeTextClient.cpp:

(WebKit::WebAlternativeTextClient::showCorrectionAlternative):
(WebKit::WebAlternativeTextClient::dismissAlternative):
(WebKit::WebAlternativeTextClient::dismissAlternativeSoon):
(WebKit::WebAlternativeTextClient::recordAutocorrectionResponse):
(WebKit::WebAlternativeTextClient::removeDictationAlternatives):
(WebKit::WebAlternativeTextClient::showDictationAlternativeUI):
(WebKit::WebAlternativeTextClient::dismissDictationAlternativeUI):
(WebKit::WebAlternativeTextClient::dictationAlternatives):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::insertDictatedText):

  • platform/mac-lion/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac/editing/input/edit-dictated-text-with-alternative-expected.txt: Added.
  • platform/mac/editing/input/edit-dictated-text-with-alternative.html: Added.
  • platform/mac/editing/input/insert-dictated-text-expected.txt: Added.
  • platform/mac/editing/input/insert-dictated-text.html: Added.
  • DumpRenderTree/mac/TextInputController.m:

(+[TextInputController isSelectorExcludedFromWebScript:]):
(+[TextInputController webScriptNameForSelector:]):
(-[TextInputController dictatedStringWithPrimaryString:alternative:alternativeOffset:alternativeLength:]):

1:18 PM Changeset in webkit [120356] by ggaren@apple.com
  • 4 edits in trunk/Source/WTF

ARMv7 should support spinlocks
​https://bugs.webkit.org/show_bug.cgi?id=88957

Reviewed by Darin Adler.

More info @ ​http://infocenter.arm.com/help/topic/
com.arm.doc.genc007826/Barrier_Litmus_Tests_and_Cookbook_A08.pdf

  • wtf/Atomics.h:

(WTF::memoryBarrierAfterLock):
(WTF::memoryBarrierBeforeUnlock): Added memory barrier primitives since
ARMv7 has a weakly ordered memory model.

  • wtf/Platform.h: Enabled compare-and-swap on Windows so our spinlock

implementation would continue working on Windows.

  • wtf/TCSpinLock.h:

(TCMalloc_SpinLock::Lock):
(TCMalloc_SpinLock::Unlock):
(TCMalloc_SpinLock): Use our compare-and-swap helper function to avoid
rewriting it in assembly here.

Added memory barriers since ARMv7 needs them.

Removed PPC support because our helper function doesn't support PPC.

1:15 PM Changeset in webkit [120355] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Unreviewed, rolling out r120353.
​http://trac.webkit.org/changeset/120353
​https://bugs.webkit.org/show_bug.cgi?id=89119

It seems we still need this workaround (Requested by Ossy on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-06-14

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(loadBuilderConfig):

1:08 PM Changeset in webkit [120354] by eae@chromium.org
  • 3 edits
    2 adds in trunk

Change RenderTableSection::calcRowLogicalHeight to round rather than floor height
​https://bugs.webkit.org/show_bug.cgi?id=88813

Reviewed by Julien Chaffraix.

Source/WebCore:

Change RenderTableSection::calcRowLogicalHeight to round the
logicalHeight instead of flooring it. This matches our rounding logic
elsewhere and results in table rows better matching the expected height.

Test: fast/sub-pixel/table-rows-have-stable-height.html

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):

LayoutTests:

Add new test ensuring that rows are laid out the desired height when
given a height that maps to a device pixel value.

  • fast/sub-pixel/table-rows-have-stable-height-expected.txt: Added.
  • fast/sub-pixel/table-rows-have-stable-height.html: Added.
1:02 PM Changeset in webkit [120353] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

master.cfg cleanup, remove unnecessary workaround
​https://bugs.webkit.org/show_bug.cgi?id=88994

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(loadBuilderConfig):

1:02 PM Changeset in webkit [120352] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

master.cfg cleanup, pass BuildStep instances instead of BuildStep subclasses
​https://bugs.webkit.org/show_bug.cgi?id=89001

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(Factory.init):
(BuildFactory.init):
(TestFactory.init):
(BuildAndTestFactory.init):
(BuildAndPerfTestFactory.init):
(BuildAndPerfTestWebKit2Factory.init):
(DownloadAndPerfTestFactory.init):
(DownloadAndPerfTestWebKit2Factory.init):

1:02 PM Changeset in webkit [120351] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Unhide login form on the build.webkit.org
​https://bugs.webkit.org/show_bug.cgi?id=88981

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
12:52 PM Changeset in webkit [120350] by zandobersek@gmail.com
  • 133 edits
    98 adds in trunk

[Gtk] Add support in DumpRenderTree for tracking repaints
​https://bugs.webkit.org/show_bug.cgi?id=87658

Reviewed by Martin Robinson.

Source/WebKit/gtk:

Add methods to the DumpRenderTreeSupport class for controlling the
status of repaint tracking along with retreiving and resetting the
tracked repaints.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::setTracksRepaints):
(DumpRenderTreeSupportGtk::isTrackingRepaints):
(DumpRenderTreeSupportGtk::trackedRepaintRects):
(DumpRenderTreeSupportGtk::resetTrackedRepaints):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Tools:

Reimplement the displayWebView method in DumpRenderTree - force a
repaint before starting tracking repaints and resetting them.

When gathering pixel output from a web view, if tracking repaints,
paint an overlay over the output with the overlay being clear in the
areas where the repaints occurred.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(displayWebView):
(resetDefaultsToConsistentValues):

  • DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:

(paintOverlay):
(fillRepaintOverlayIntoContext):
(createBitmapContextFromWebView):

LayoutTests:

Update pixel baselines for all the tests in fast/repaint now that the
Gtk's DumpRenderTree properly tracks the repaint rects and displays
an appropriate overlay in the pixel results for such tests.

  • platform/gtk/fast/repaint/4774354-expected.png:
  • platform/gtk/fast/repaint/4776765-expected.png:
  • platform/gtk/fast/repaint/absolute-position-change-containing-block-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/float-new-in-block-expected.png.
  • platform/gtk/fast/repaint/absolute-position-changed-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/layer-visibility-expected.png.
  • platform/gtk/fast/repaint/absolute-position-moved-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-outer-border-expected.png.
  • platform/gtk/fast/repaint/background-clip-text-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/selection-clear-expected.png.
  • platform/gtk/fast/repaint/background-generated-expected.png:
  • platform/gtk/fast/repaint/background-misaligned-expected.png:
  • platform/gtk/fast/repaint/background-scaling-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/clip-with-layout-delta-expected.png.
  • platform/gtk/fast/repaint/backgroundSizeRepaint-expected.png:
  • platform/gtk/fast/repaint/block-layout-inline-children-float-positioned-expected.png: Added.
  • platform/gtk/fast/repaint/block-layout-inline-children-replaced-expected.png: Added.
  • platform/gtk/fast/repaint/block-no-inflow-children-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/slider-thumb-drag-release-expected.png.
  • platform/gtk/fast/repaint/block-selection-gap-in-composited-layer-expected.png:
  • platform/gtk/fast/repaint/block-selection-gap-in-table-cell-expected.png:
  • platform/gtk/fast/repaint/block-selection-gap-stale-cache-2-expected.png:
  • platform/gtk/fast/repaint/block-selection-gap-stale-cache-expected.png:
  • platform/gtk/fast/repaint/body-background-image-expected.png:
  • platform/gtk/fast/repaint/border-fit-lines-expected.png:
  • platform/gtk/fast/repaint/border-radius-repaint-expected.png:
  • platform/gtk/fast/repaint/border-repaint-glitch-expected.png:
  • platform/gtk/fast/repaint/box-shadow-dynamic-expected.png:
  • platform/gtk/fast/repaint/box-shadow-h-expected.png:
  • platform/gtk/fast/repaint/box-shadow-v-expected.png:
  • platform/gtk/fast/repaint/bugzilla-3509-expected.png:
  • platform/gtk/fast/repaint/bugzilla-5699-expected.png:
  • platform/gtk/fast/repaint/bugzilla-6278-expected.png:
  • platform/gtk/fast/repaint/bugzilla-6388-expected.png:
  • platform/gtk/fast/repaint/bugzilla-6473-expected.png:
  • platform/gtk/fast/repaint/bugzilla-7235-expected.png:
  • platform/gtk/fast/repaint/button-spurious-layout-hint-expected.png:
  • platform/gtk/fast/repaint/canvas-putImageData-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/selection-clear-expected.png.
  • platform/gtk/fast/repaint/caret-outside-block-expected.png:
  • platform/gtk/fast/repaint/change-transform-expected.png:
  • platform/gtk/fast/repaint/clip-with-layout-delta-expected.png:
  • platform/gtk/fast/repaint/clipped-relative-expected.png:
  • platform/gtk/fast/repaint/containing-block-position-change-expected.png:
  • platform/gtk/fast/repaint/content-into-overflow-expected.png:
  • platform/gtk/fast/repaint/continuation-after-outline-expected.png:
  • platform/gtk/fast/repaint/control-clip-expected.png:
  • platform/gtk/fast/repaint/create-layer-repaint-expected.png:
  • platform/gtk/fast/repaint/delete-into-nested-block-expected.png:
  • platform/gtk/fast/repaint/dynamic-table-vertical-alignment-change-expected.png:
  • platform/gtk/fast/repaint/erase-overflow-expected.png:
  • platform/gtk/fast/repaint/fixed-after-scroll-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/float-in-new-block-with-layout-delta-expected.png.
  • platform/gtk/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-outer-border-expected.png.
  • platform/gtk/fast/repaint/fixed-child-move-after-scroll-expected.png: Added.
  • platform/gtk/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png: Added.
  • platform/gtk/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png: Added.
  • platform/gtk/fast/repaint/fixed-expected.png:
  • platform/gtk/fast/repaint/fixed-in-page-scale-expected.png: Added.
  • platform/gtk/fast/repaint/fixed-move-after-keyboard-scroll-expected.png: Added.
  • platform/gtk/fast/repaint/fixed-move-after-scroll-expected.png: Added.
  • platform/gtk/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/button-spurious-layout-hint-expected.png.
  • platform/gtk/fast/repaint/fixed-right-bottom-in-page-scale-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/slider-thumb-drag-release-expected.png.
  • platform/gtk/fast/repaint/fixed-right-in-page-scale-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/float-in-new-block-with-layout-delta-expected.png.
  • platform/gtk/fast/repaint/fixed-scale-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-outer-border-expected.png.
  • platform/gtk/fast/repaint/fixed-scroll-simple-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-section-overflow-expected.png.
  • platform/gtk/fast/repaint/fixed-table-cell-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-outer-border-expected.png.
  • platform/gtk/fast/repaint/fixed-table-overflow-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-outer-border-expected.png.
  • platform/gtk/fast/repaint/fixed-table-overflow-zindex-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-outer-border-expected.png.
  • platform/gtk/fast/repaint/fixed-to-relative-position-with-absolute-child-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/float-in-new-block-with-layout-delta-expected.png.
  • platform/gtk/fast/repaint/fixed-tranformed-expected.png: Added.
  • platform/gtk/fast/repaint/flexible-box-overflow-expected.png:
  • platform/gtk/fast/repaint/flexible-box-overflow-horizontal-expected.png:
  • platform/gtk/fast/repaint/float-in-new-block-with-layout-delta-expected.png:
  • platform/gtk/fast/repaint/float-move-during-layout-expected.png:
  • platform/gtk/fast/repaint/float-new-in-block-expected.png:
  • platform/gtk/fast/repaint/float-overflow-expected.png: Added.
  • platform/gtk/fast/repaint/float-overflow-right-expected.png: Added.
  • platform/gtk/fast/repaint/focus-layers-expected.png:
  • platform/gtk/fast/repaint/gradients-em-stops-repaint-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-outer-border-expected.png.
  • platform/gtk/fast/repaint/iframe-scroll-repaint-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/intermediate-layout-position-clip-expected.png.
  • platform/gtk/fast/repaint/inline-block-overflow-expected.png:
  • platform/gtk/fast/repaint/inline-block-resize-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-outer-border-expected.png.
  • platform/gtk/fast/repaint/inline-color-change-expected.png:
  • platform/gtk/fast/repaint/inline-horizontal-bt-overflow-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/layer-hide-when-needs-layout-expected.png.
  • platform/gtk/fast/repaint/inline-outline-repaint-expected.png:
  • platform/gtk/fast/repaint/inline-overflow-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/layer-hide-when-needs-layout-expected.png.
  • platform/gtk/fast/repaint/inline-relative-positioned-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/selection-clear-expected.png.
  • platform/gtk/fast/repaint/inline-vertical-lr-overflow-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/block-selection-gap-in-composited-layer-expected.png.
  • platform/gtk/fast/repaint/inline-vertical-rl-overflow-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/button-spurious-layout-hint-expected.png.
  • platform/gtk/fast/repaint/intermediate-layout-position-clip-expected.png:
  • platform/gtk/fast/repaint/intermediate-layout-position-expected.png:
  • platform/gtk/fast/repaint/invisible-objects-expected.png:
  • platform/gtk/fast/repaint/japanese-rl-selection-clear-expected.png: Added.
  • platform/gtk/fast/repaint/japanese-rl-selection-repaint-expected.png: Added.
  • platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
  • platform/gtk/fast/repaint/layer-child-outline-expected.png:
  • platform/gtk/fast/repaint/layer-full-repaint-expected.png:
  • platform/gtk/fast/repaint/layer-hide-when-needs-layout-expected.png:
  • platform/gtk/fast/repaint/layer-outline-expected.png:
  • platform/gtk/fast/repaint/layer-outline-horizontal-expected.png:
  • platform/gtk/fast/repaint/layer-visibility-expected.png:
  • platform/gtk/fast/repaint/layout-state-only-positioned-expected.png:
  • platform/gtk/fast/repaint/layout-state-relative-expected.png:
  • platform/gtk/fast/repaint/layout-state-scrolloffset-expected.png: Added.
  • platform/gtk/fast/repaint/layout-state-scrolloffset2-expected.png: Added.
  • platform/gtk/fast/repaint/layout-state-scrolloffset3-expected.png: Added.
  • platform/gtk/fast/repaint/line-flow-with-floats-1-expected.png:
  • platform/gtk/fast/repaint/line-flow-with-floats-10-expected.png:
  • platform/gtk/fast/repaint/line-flow-with-floats-2-expected.png:
  • platform/gtk/fast/repaint/line-flow-with-floats-3-expected.png:
  • platform/gtk/fast/repaint/line-flow-with-floats-4-expected.png:
  • platform/gtk/fast/repaint/line-flow-with-floats-5-expected.png:
  • platform/gtk/fast/repaint/line-flow-with-floats-6-expected.png:
  • platform/gtk/fast/repaint/line-flow-with-floats-7-expected.png:
  • platform/gtk/fast/repaint/line-flow-with-floats-8-expected.png:
  • platform/gtk/fast/repaint/line-flow-with-floats-9-expected.png:
  • platform/gtk/fast/repaint/line-flow-with-floats-in-regions-expected.png: Added.
  • platform/gtk/fast/repaint/line-in-scrolled-clipped-block-expected.png:
  • platform/gtk/fast/repaint/line-overflow-expected.png:
  • platform/gtk/fast/repaint/lines-with-layout-delta-expected.png:
  • platform/gtk/fast/repaint/list-marker-2-expected.png:
  • platform/gtk/fast/repaint/list-marker-expected.png:
  • platform/gtk/fast/repaint/make-children-non-inline-expected.png:
  • platform/gtk/fast/repaint/moving-shadow-on-container-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/block-selection-gap-in-composited-layer-expected.png.
  • platform/gtk/fast/repaint/moving-shadow-on-path-expected.png: Added.
  • platform/gtk/fast/repaint/multicol-repaint-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/slider-thumb-drag-release-expected.png.
  • platform/gtk/fast/repaint/nested-iframe-scroll-inner-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/intermediate-layout-position-expected.png.
  • platform/gtk/fast/repaint/nested-iframe-scroll-outer-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/block-selection-gap-in-table-cell-expected.png.
  • platform/gtk/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png:
  • platform/gtk/fast/repaint/opacity-change-on-overflow-float-expected.png:
  • platform/gtk/fast/repaint/outline-child-repaint-expected.png:
  • platform/gtk/fast/repaint/outline-inset-expected.png:
  • platform/gtk/fast/repaint/outline-repaint-glitch-expected.png:
  • platform/gtk/fast/repaint/outline-shrinking-expected.png:
  • platform/gtk/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-outer-border-expected.png.
  • platform/gtk/fast/repaint/overflow-clip-subtree-layout-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/block-selection-gap-in-composited-layer-expected.png.
  • platform/gtk/fast/repaint/overflow-delete-line-expected.png:
  • platform/gtk/fast/repaint/overflow-flipped-writing-mode-block-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/float-in-new-block-with-layout-delta-expected.png.
  • platform/gtk/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/layer-full-repaint-expected.png.
  • platform/gtk/fast/repaint/overflow-flipped-writing-mode-table-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/float-in-new-block-with-layout-delta-expected.png.
  • platform/gtk/fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/float-in-new-block-with-layout-delta-expected.png.
  • platform/gtk/fast/repaint/overflow-hide-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/layer-hide-when-needs-layout-expected.png.
  • platform/gtk/fast/repaint/overflow-into-content-expected.png:
  • platform/gtk/fast/repaint/overflow-outline-repaint-expected.png:
  • platform/gtk/fast/repaint/overflow-scroll-body-appear-expected.png:
  • platform/gtk/fast/repaint/overflow-scroll-delete-expected.png:
  • platform/gtk/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-outer-border-expected.png.
  • platform/gtk/fast/repaint/overflow-show-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-row-expected.png.
  • platform/gtk/fast/repaint/reflection-redraw-expected.png:
  • platform/gtk/fast/repaint/reflection-repaint-test-expected.png:
  • platform/gtk/fast/repaint/region-painting-invalidation-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/float-new-in-block-expected.png.
  • platform/gtk/fast/repaint/region-painting-via-layout-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/selection-clear-expected.png.
  • platform/gtk/fast/repaint/rel-positioned-inline-with-overflow-expected.png:
  • platform/gtk/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
  • platform/gtk/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Added.
  • platform/gtk/fast/repaint/repaint-during-scroll-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/float-new-in-block-expected.png.
  • platform/gtk/fast/repaint/repaint-resized-overflow-expected.png:
  • platform/gtk/fast/repaint/repaint-svg-after-style-change-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-col-background-expected.png.
  • platform/gtk/fast/repaint/scale-page-shrink-expected.png:
  • platform/gtk/fast/repaint/scroll-absolute-layer-with-reflection-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/float-new-in-block-expected.png.
  • platform/gtk/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-outer-border-expected.png.
  • platform/gtk/fast/repaint/scroll-fixed-layer-with-reflection-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/erase-overflow-expected.png.
  • platform/gtk/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/layer-visibility-expected.png.
  • platform/gtk/fast/repaint/scroll-fixed-reflected-layer-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/erase-overflow-expected.png.
  • platform/gtk/fast/repaint/scroll-in-clipped-layer-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-outer-border-expected.png.
  • platform/gtk/fast/repaint/scroll-in-fixed-layer-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-outer-border-expected.png.
  • platform/gtk/fast/repaint/scroll-in-transformed-layer-expected.png: Added.
  • platform/gtk/fast/repaint/scroll-inside-table-cell-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/continuation-after-outline-expected.png.
  • platform/gtk/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/block-selection-gap-in-composited-layer-expected.png.
  • platform/gtk/fast/repaint/scroll-with-transformed-parent-layer-expected.png: Added.
  • platform/gtk/fast/repaint/search-field-cancel-expected.png:
  • platform/gtk/fast/repaint/select-option-background-color-expected.png: Added.
  • platform/gtk/fast/repaint/selected-replaced-expected.png:
  • platform/gtk/fast/repaint/selection-after-delete-expected.png:
  • platform/gtk/fast/repaint/selection-after-remove-expected.png:
  • platform/gtk/fast/repaint/selection-clear-expected.png:
  • platform/gtk/fast/repaint/selection-gap-overflow-scroll-2-expected.png: Added.
  • platform/gtk/fast/repaint/selection-gap-overflow-scroll-expected.png:
  • platform/gtk/fast/repaint/selection-rl-expected.png: Added.
  • platform/gtk/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/gtk/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/gtk/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/gtk/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/gtk/fast/repaint/slider-thumb-drag-release-expected.png:
  • platform/gtk/fast/repaint/slider-thumb-float-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/clip-with-layout-delta-expected.png.
  • platform/gtk/fast/repaint/stacked-diacritics-expected.png: Added.
  • platform/gtk/fast/repaint/static-to-positioned-expected.png:
  • platform/gtk/fast/repaint/subtree-layoutstate-transform-expected.png:
  • platform/gtk/fast/repaint/subtree-root-clip-2-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-col-background-expected.png.
  • platform/gtk/fast/repaint/subtree-root-clip-3-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/float-in-new-block-with-layout-delta-expected.png.
  • platform/gtk/fast/repaint/subtree-root-clip-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-col-background-expected.png.
  • platform/gtk/fast/repaint/subtree-root-skipped-expected.png:
  • platform/gtk/fast/repaint/svg-layout-root-style-attr-update-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/button-spurious-layout-hint-expected.png.
  • platform/gtk/fast/repaint/table-cell-collapsed-border-expected.png:
  • platform/gtk/fast/repaint/table-cell-move-expected.png:
  • platform/gtk/fast/repaint/table-cell-overflow-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/clip-with-layout-delta-expected.png.
  • platform/gtk/fast/repaint/table-col-background-expected.png:
  • platform/gtk/fast/repaint/table-collapsed-border-expected.png:
  • platform/gtk/fast/repaint/table-extra-bottom-grow-expected.png:
  • platform/gtk/fast/repaint/table-hover-on-link-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/intermediate-layout-position-clip-expected.png.
  • platform/gtk/fast/repaint/table-outer-border-expected.png:
  • platform/gtk/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/selection-clear-expected.png.
  • platform/gtk/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/float-in-new-block-with-layout-delta-expected.png.
  • platform/gtk/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/selection-clear-expected.png.
  • platform/gtk/fast/repaint/table-row-expected.png:
  • platform/gtk/fast/repaint/table-section-overflow-expected.png:
  • platform/gtk/fast/repaint/table-section-repaint-expected.png:
  • platform/gtk/fast/repaint/table-two-pass-layout-overpaint-expected.png:
  • platform/gtk/fast/repaint/table-writing-modes-h-expected.png: Added.
  • platform/gtk/fast/repaint/table-writing-modes-v-expected.png: Added.
  • platform/gtk/fast/repaint/text-append-dirty-lines-expected.png:
  • platform/gtk/fast/repaint/text-emphasis-h-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/continuation-after-outline-expected.png.
  • platform/gtk/fast/repaint/text-emphasis-v-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/float-in-new-block-with-layout-delta-expected.png.
  • platform/gtk/fast/repaint/text-in-relative-positioned-inline-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/button-spurious-layout-hint-expected.png.
  • platform/gtk/fast/repaint/text-selection-rect-in-overflow-2-expected.png:
  • platform/gtk/fast/repaint/text-selection-rect-in-overflow-expected.png:
  • platform/gtk/fast/repaint/text-shadow-expected.png:
  • platform/gtk/fast/repaint/text-shadow-horizontal-expected.png:
  • platform/gtk/fast/repaint/textarea-set-disabled-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/float-in-new-block-with-layout-delta-expected.png.
  • platform/gtk/fast/repaint/trailing-floats-root-line-box-overflow-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-row-expected.png.
  • platform/gtk/fast/repaint/transform-absolute-child-expected.png:
  • platform/gtk/fast/repaint/transform-absolute-in-positioned-container-expected.png:
  • platform/gtk/fast/repaint/transform-disable-layoutstate-expected.png:
  • platform/gtk/fast/repaint/transform-layout-repaint-expected.png:
  • platform/gtk/fast/repaint/transform-relative-position-expected.png:
  • platform/gtk/fast/repaint/transform-repaint-descendants-expected.png:
  • platform/gtk/fast/repaint/transform-replaced-shadows-expected.png:
  • platform/gtk/fast/repaint/transform-rotate-and-remove-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/table-col-background-expected.png.
  • platform/gtk/fast/repaint/transform-translate-expected.png:
  • platform/gtk/fast/repaint/view-background-from-body-1-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/block-selection-gap-stale-cache-expected.png.
  • platform/gtk/fast/repaint/view-background-from-body-2-expected.png: Copied from LayoutTests/platform/gtk/fast/repaint/invisible-objects-expected.png.
12:43 PM Changeset in webkit [120349] by dpranke@chromium.org
  • 3 edits in trunk/Tools

new-run-webkit-tests doesn't find similar platform tests for a keyword
​https://bugs.webkit.org/show_bug.cgi?id=37956

Reviewed by Ryosuke Niwa.

This patches adds support for NRWT so that if you type
"new-run-webkit-tests foo" it will run all the tests in foo as
well as platform/foo for all of the platforms that are normally
searched (this only applies to directories, not to individual tests).

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.collect_tests):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.tests):
(Port):
(Port._expanded_paths):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_no_http_tests):
(MainTest):
(MainTest.test_platform_tests_are_found):

12:40 PM Changeset in webkit [120348] by dpranke@chromium.org
  • 5 edits in trunk/Tools

NRWT should honor --skipped=[default|ignore|only], like ORWT does
​https://bugs.webkit.org/show_bug.cgi?id=66308

Reviewed by Ryosuke Niwa.

This patch adds support for ORWT's --skipped=(default|ignore|only)
flag and cleans up the interaction between that and --ignore.

Individual tests (but not directories) explicitly listed on the
command line will always be run regardless of what is passed
for --skipped and --ignore.

This patch also changes the "found" and "running" log messages
since it wasn't clear how the skipped tests were included in those numbers.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.init):
(Manager.collect_tests):
(Manager.prepare_lists_and_print_output):

  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(_set_up_derived_options):
(parse_args):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(MainTest.test_ignore_flag):
(MainTest):
(MainTest.test_skipped_flag):

12:24 PM Changeset in webkit [120347] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

Web Inspector: Remove devtoolsInjectedScript hidden property
​https://bugs.webkit.org/show_bug.cgi?id=89087

We use the devtoolsInjectedScript hidden property to reference a InjectedScript object
for a given ScriptState, but we also have the same reference in the InjectedScriptManager's
hash maps. Just use the hash maps and remove the hidden property from the global object.

Patch by Andrey Adaikin <​aandrey@chromium.org> on 2012-06-14
Reviewed by Pavel Feldman.

  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::visitChildren):

  • bindings/js/JSDOMGlobalObject.h:

(JSDOMGlobalObject):

  • bindings/js/JSInjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::createInjectedScript):

  • bindings/v8/V8HiddenPropertyName.h:

(WebCore):

  • bindings/v8/custom/V8InjectedScriptManager.cpp:
  • inspector/InjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::discardInjectedScripts):
(WebCore::InjectedScriptManager::discardInjectedScriptsFor):
(WebCore::InjectedScriptManager::injectedScriptFor):
(WebCore):
(WebCore::InjectedScriptManager::wrapWebGLRenderingContextForInstrumentation):

  • inspector/InjectedScriptManager.h:

(InjectedScriptManager):

11:54 AM Changeset in webkit [120346] by commit-queue@webkit.org
  • 36 edits
    3 adds
    1 delete in trunk/Source

[chromium] Move opaque rectangle tracking logic out of compositor core
​https://bugs.webkit.org/show_bug.cgi?id=89031

Patch by James Robinson <​jamesr@chromium.org> on 2012-06-14
Reviewed by Adrienne Walker.

Source/WebCore:

This moves the opaque paint tracking logic from the compositor (specifically CanvasLayerTextureUpdater) out to a
dedicated class used by GraphicsLayerChromium for GraphicsContext-painted content. This changes the interface
exposed by the compositor to pass a SkCanvas and let the user fill in an opaque rect if needed. Callers that are
using GraphicsContext to paint can instantiate a PlatformContextSkia / GraphicsContext around this SkCanvas if
they choose to, or use some other strategy, or not fill it in at all. This avoids creating extra wrapper classes
if the eventual caller is going to use the underlying SkCanvas anyway (such as WebContentLayer) and breaks the
dependency from the compositor code on GraphicsContext / PlatformContextSkia.

OpaqueRectTrackingContentLayerDelegate is a helper class that wraps a ContentLayerDelegate implementation with
PlatformContextSkia's opaque region tracking logic.

  • WebCore.gypi:
  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:

(WebCore::BitmapCanvasLayerTextureUpdater::BitmapCanvasLayerTextureUpdater):
(WebCore::BitmapCanvasLayerTextureUpdater::prepareToUpdate):
(WebCore::BitmapCanvasLayerTextureUpdater::updateTextureRect):
(WebCore::BitmapCanvasLayerTextureUpdater::setOpaque):

  • platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:

(WebCore):
(BitmapCanvasLayerTextureUpdater):

  • platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:

(WebCore::CanvasLayerTextureUpdater::paintContents):

  • platform/graphics/chromium/CanvasLayerTextureUpdater.h:

(WebCore):
(CanvasLayerTextureUpdater):

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerPainter::paint):

  • platform/graphics/chromium/ContentLayerChromium.h:

(ContentLayerDelegate):
(WebCore):

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::paint):

  • platform/graphics/chromium/GraphicsLayerChromium.h:

(GraphicsLayerChromium):

  • platform/graphics/chromium/LayerPainterChromium.h:

(LayerPainterChromium):

  • platform/graphics/chromium/LinkHighlight.cpp:

(WebCore::LinkHighlight::paintContents):

  • platform/graphics/chromium/LinkHighlight.h:

(LinkHighlight):

  • platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp: Added.

(WebCore):
(WebCore::OpaqueRectTrackingContentLayerDelegate::OpaqueRectTrackingContentLayerDelegate):
(WebCore::OpaqueRectTrackingContentLayerDelegate::~OpaqueRectTrackingContentLayerDelegate):
(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):

  • platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.h: Added.

(WebCore):
(GraphicsContextPainter):
(WebCore::GraphicsContextPainter::~GraphicsContextPainter):
(OpaqueRectTrackingContentLayerDelegate):
(WebCore::OpaqueRectTrackingContentLayerDelegate::setOpaque):

  • platform/graphics/chromium/PlatformCanvas.cpp:

(WebCore::PlatformCanvas::Painter::Painter):

  • platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp:

(WebCore::SkPictureCanvasLayerTextureUpdater::prepareToUpdate):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore):

Source/WebKit/chromium:

Moves the grayscale/subpixel AA text decision into NonCompositedContentHost and removes one layer of indirection
betwen NCCH and WVI that existed only for historical reasons.

Ports the opaque rect tracking tests that were in LayerTextureUpdaterTest to
OpaquerectTrackingContentLayerDelegateTest to reflect the move in responsibilities.

  • WebKit.gypi:
  • src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setOpaque):
(WebKit::NonCompositedContentHost::paintContents):

  • src/NonCompositedContentHost.h:

(WebCore):
(WebKit):
(WebKit::NonCompositedContentHost::create):
(NonCompositedContentHost):

  • src/WebContentLayerImpl.cpp:

(WebKit::WebContentLayerImpl::paintContents):

  • src/WebContentLayerImpl.h:

(WebContentLayerImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::paintRootLayer):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • src/WebViewImpl.h:

(WebViewImpl):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::TestOpacityChangeLayerDelegate::paintContents):
(WTF::MockContentLayerDelegate::paintContents):

  • tests/LayerChromiumTest.cpp:
  • tests/LayerTextureUpdaterTest.cpp: Removed.
  • tests/OpaqueRectTrackingContentLayerDelegateTest.cpp: Added.

(WebCore):
(PaintCallback):
(TestLayerPainterChromium):
(WebCore::TestLayerPainterChromium::TestLayerPainterChromium):
(WebCore::PaintFillAlpha::operator()):
(WebCore::PaintFillPartialOpaque::PaintFillPartialOpaque):
(PaintFillPartialOpaque):
(WebCore::PaintFillPartialOpaque::operator()):
(OpaqueRectTrackingContentLayerDelegateTest):
(WebCore::OpaqueRectTrackingContentLayerDelegateTest::OpaqueRectTrackingContentLayerDelegateTest):
(WebCore::OpaqueRectTrackingContentLayerDelegateTest::skCanvas):
(WebCore::OpaqueRectTrackingContentLayerDelegateTest::canvasRect):
(WebCore::TEST_F):

11:37 AM Changeset in webkit [120345] by Simon Fraser
  • 10 edits in trunk/LayoutTests

Rebaseline some Mac results after r120246.

  • platform/mac/media/audio-controls-rendering-expected.txt:
  • platform/mac/media/controls-after-reload-expected.txt:
  • platform/mac/media/controls-strict-expected.txt:
  • platform/mac/media/video-colorspace-yuv420-expected.txt:
  • platform/mac/media/video-colorspace-yuv422-expected.txt:
  • platform/mac/media/video-controls-rendering-expected.txt:
  • platform/mac/media/video-display-toggle-expected.txt:
  • platform/mac/media/video-no-audio-expected.txt:
  • platform/mac/media/video-playing-and-pause-expected.txt:
11:33 AM Changeset in webkit [120344] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

[Chromium] webkitImageSmoothingEnabled canvas property does not work on redraw
​https://bugs.webkit.org/show_bug.cgi?id=89018

Patch by Justin Novosad <​junov@chromium.org> on 2012-06-14
Reviewed by Stephen White.

Source/WebCore:

Test: fast/canvas/canvas-imageSmoothingEnabled-repaint.html

When an accelerated canvas layer prepares its texture for the
compositor, it must send a notification to skia to invalidate texture
proprties that are cached by skia, since the compositor may modify them.
The use case this fixes is when a canvas to canvas copy is performed
with webkitImageSmoothingEnabled=false on the destination canvas.
The backing texture of the source canvas will be set to "nearest"
filtering by skia in order to perform the copy. Then, the compositor
sets filtering back to "linear" when the source canvas is drawn.
Skia is designed to only update GL attributes when required, so errors
occur when the skia-side GL state cache is out of sync.

  • platform/graphics/chromium/Canvas2DLayerBridge.cpp:

(WebCore::Canvas2DLayerBridge::prepareTexture):

Source/WebKit/chromium:

Rolling chromium DEPS to 141884

  • DEPS:

LayoutTests:

New layout test that verifies that disabling image smoothing on a 2d
canvas continues to work after multiple paint cycles.

  • fast/canvas/canvas-imageSmoothingEnabled-repaint-expected.txt: Added.
  • fast/canvas/canvas-imageSmoothingEnabled-repaint.html: Added.
  • fast/canvas/script-tests/canvas-imageSmoothingEnabled-repaint.js: Added.

(draw):
(testResult):
(TestControllerPaint):
(BrowserPaint):
(onLoadHandler):

11:23 AM Changeset in webkit [120343] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

[svg] SVGResources applied to Text with Incorrect Transformations in non-CG Implementations
​https://bugs.webkit.org/show_bug.cgi?id=64966

Unreviewed suppression of crashing tests:
svg/batik/text/textDecoration.svg
svg/batik/text/textEffect3.svg

  • platform/chromium/TestExpectations:
11:06 AM Changeset in webkit [120342] by toyoshim@chromium.org
  • 3 edits in trunk/Tools

new-run-webkit-websocketserver must handle TLS related arguments
​https://bugs.webkit.org/show_bug.cgi?id=89079

Reviewed by Dirk Pranke.

PyWebSocket class must accept private_key, certificate, and
ca_certificate arguments and pass them to launching pywebsocket.
Also add ca_certificate handling to new-run-webkit-websocketserver.

  • Scripts/new-run-webkit-websocketserver:

(main):

  • Scripts/webkitpy/layout_tests/servers/websocket_server.py:

(PyWebSocket.init):
(PyWebSocket._prepare_config):

11:02 AM Changeset in webkit [120341] by jhoneycutt@apple.com
  • 4 edits in trunk

2012-06-14 Jon Honeycutt <​jhoneycutt@apple.com>

Fix some failing tests on Windows by resetting the page scale factor
between tests.
​https://bugs.webkit.org/show_bug.cgi?id=89078

Reviewed by Dirk Pranke.

WebCore:

  • testing/Internals.cpp: (WebCore::Internals::reset): Set the scale factor to 1.0.

LayoutTests:
Unskip some now-passing tests.
​https://bugs.webkit.org/show_bug.cgi?id=89078

  • platform/win/Skipped:
10:45 AM Changeset in webkit [120340] by commit-queue@webkit.org
  • 17 edits in trunk/Source

Register fixed position layers with ScrollingCoordinator
​https://bugs.webkit.org/show_bug.cgi?id=78864

Patch by Sami Kyostila <​skyostil@chromium.org> on 2012-06-14
Reviewed by James Robinson.

This patch makes ScrollingCoordinator aware of page elements that are
either fixed positioned directly or through their ancestors and that
also have their own composited backing layers. This allows the
ScrollingCoordinator implementation to potentially enable fast
scrolling even if there are fixed elements on the page, because the
compositor can automatically reposition the fixed element layers after
scrolling.

Since fixed position layers need to be explicitly supported by the
ScrollingCoordinator implementation, we add a new
supportsFixedPositionLayers() query for checking this.

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::useSlowRepaints):
(WebCore::FrameView::addFixedObject):
(WebCore::FrameView::removeFixedObject):

  • page/FrameView.h:

(FrameView):
(WebCore::FrameView::fixedObjects):
(WebCore::FrameView::hasFixedObjects):

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::frameViewFixedObjectsDidChange):
(WebCore::ScrollingCoordinator::hasNonLayerFixedObjects):
(WebCore):
(WebCore::ScrollingCoordinator::updateShouldUpdateScrollLayerPositionOnMainThread):
(WebCore::ScrollingCoordinator::setLayerIsContainerForFixedPosition):
(WebCore::ScrollingCoordinator::setLayerIsFixedToContainerLayer):

  • page/scrolling/ScrollingCoordinator.h:

(ScrollingCoordinator):

  • page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::ScrollingCoordinator::setLayerIsContainerForFixedPosition):
(WebCore):
(WebCore::ScrollingCoordinator::setLayerIsFixedToContainerLayer):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::willBeDestroyed):
(WebCore::RenderBox::styleWillChange):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateBacking):
(WebCore):
(WebCore::RenderLayerCompositor::fixedPositionedByAncestor):
(WebCore::RenderLayerCompositor::ensureRootLayer):

  • rendering/RenderLayerCompositor.h:
10:42 AM Changeset in webkit [120339] by ap@apple.com
  • 4 edits
    4 adds in trunk

[CFNetwork] XMLHttpRequest incorrectly returns cached responses even when there is a Vary header field
​https://bugs.webkit.org/show_bug.cgi?id=88925

Reviewed by David Kilzer.

Test: http/tests/cache/xhr-vary-header.html

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willCacheResponse): Don't cache the response at all if there is a Vary header field. CFNetwork won't look at it if we allowed the response cached.
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::createNSURLConnection): [NSURLResponse copy] is mutable in practice, but we should be nice, and use -mutableCopy. (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]): Same fix as in CFNet code.
10:06 AM Changeset in webkit [120338] by caseq@chromium.org
  • 8 edits
    1 move
    10 deletes in trunk/Source/WebCore

Web Inspector: use CSS gradients instead of images for timeline bars, checkboxes & bullets
​https://bugs.webkit.org/show_bug.cgi?id=89024

Reviewed by Pavel Feldman.

This brings a bunch of UI changes to the way Timeline bars and related controls are rendered:

  • introduce new color palette for categories;
  • replace images used to render timeline bars, list bullets and categories checkboxes with CSS gradients;
  • "flatten" timeline bars
  • make square list bullets, sharpen corners for lower pane bars;
  • make links on the list sidebar grey
  • add more space between categories checkboxes, make labels lighter.
  • WebCore.gypi: Remove old images, add tickMark.png.
  • inspector/front-end/Images/timelineBarBlue.png: Removed.
  • inspector/front-end/Images/timelineBarDarkGreen.png: Removed.
  • inspector/front-end/Images/timelineBarGray.png: Removed.
  • inspector/front-end/Images/timelineBarGreen.png: Removed.
  • inspector/front-end/Images/timelineBarLightPurple.png: Removed.
  • inspector/front-end/Images/timelineBarOrange.png: Removed.
  • inspector/front-end/Images/timelineBarPurple.png: Removed.
  • inspector/front-end/Images/timelineBarRed.png: Removed.
  • inspector/front-end/Images/timelineBarYellow.png: Removed.
  • inspector/front-end/Images/timelineCheckmarks.png: Removed.
  • inspector/front-end/Images/timelineDots.png: Removed.
  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype.wasShown):
(WebInspector.TimelinePanel.prototype._closeRecordDetails): Fixed trailing spaces;
(WebInspector.TimelinePanel.prototype._injectCategoryStyles): Inject generated styles for categories, if necessary.

  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.categories):
(WebInspector.TimelinePresentationModel.createFillStyle):
(WebInspector.TimelinePresentationModel.createStyleRuleForCategory):

  • inspector/front-end/WebKit.qrc: Remove old images, add tickMark.png
  • inspector/front-end/inspector.css:

(.sidebar-tree-section):

  • inspector/front-end/timelinePanel.css:

(#timeline-container .webkit-html-resource-link):
(.timeline-category-statusbar-item):
(.timeline-category-statusbar-item .timeline-category-checkbox):
(.timeline-category-statusbar-item .timeline-category-checkbox:checked::before):
(.timeline-tree-item):
(.timeline-tree-item .timeline-tree-icon):
(.timeline-graph-bar):
(.timeline-graph-bar.with-children):
(.timeline-graph-bar.cpu):
(.timeline-aggregated-category):

  • inspector/front-end/utilities.js:

(Object.values): Return an array of object field's values.

10:00 AM Changeset in webkit [120337] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Change mute button and volume slider behaviour for new Chromium video controls.
​https://bugs.webkit.org/show_bug.cgi?id=88743

Patch by Silvia Pfeiffer <​silviapf@chromium.org> on 2012-06-14
Reviewed by Eric Carlson.

No new tests, final patch will contain the rebaselined tests.

The Chrome video controls are receiving a visual update. This patch makes the mute button and
the volume slider interact with each other. When the user mutes the video through clicking the
mute button, the volume slider animates to 0% volume. Upon unmute, the previous volume level
is restored. Further, when the user drags the volume slider thumb or clicks on the slider and
the video is muted, the video unmutes and sets the volume to the user's chosen level.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlVolumeSliderElement::MediaControlVolumeSliderElement):
Add a member field to the volume slider to allow user interaction to unmute the video.
(WebCore::MediaControlVolumeSliderElement::defaultEventHandler):
Add the logic to unmute the video if the m_clearMutedOnUserInteraction member field is true.
(WebCore::MediaControlVolumeSliderElement::setClearMutedOnUserInteraction):
Add a member function to change the value of the m_clearMutedOnUserInteraction member field.

  • html/shadow/MediaControlElements.h:

(MediaControlVolumeSliderElement):
Add the setClearMutedOnUserInteraction member function and the m_clearMutedOnUserInteraction member field.

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::create):
Activate unmute on user interaction on the Chromium video volume slider.
(WebCore::MediaControlRootElementChromium::changedMute):
Add logic to set volume slider to 0 when muted and reset to volume when unmuted.

  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::paintMediaVolumeSlider):
Add logic to paint the volume slider active area as 0 when muted.

9:58 AM Changeset in webkit [120336] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Breakpoints should not be set when UISourceCode content is diverged from VM version of the script.
​https://bugs.webkit.org/show_bug.cgi?id=89109

Reviewed by Pavel Feldman.

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.Breakpoint.prototype._updateBreakpoint):

  • inspector/front-end/JavaScriptSource.js:

(WebInspector.JavaScriptSource.prototype.isDivergedFromVM):
(WebInspector.JavaScriptSource.prototype.workingCopyCommitted):

9:57 AM Changeset in webkit [120335] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: DebuggerModel should support setting breakpoints without script by sourceURL only.
​https://bugs.webkit.org/show_bug.cgi?id=88988

Reviewed by Pavel Feldman.

This change allows setting all saved breakpoints in debugger model by url before the site
with corresponding scripts was loaded (allows breaking in onload handler on first load).
This change also simplifies implementation of snippets debugging.

  • inspector/front-end/BreakpointManager.js:
  • inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.prototype.setBreakpointByScriptLocation):

9:53 AM Changeset in webkit [120334] by Philippe Normand
  • 2 edits in trunk/LayoutTests

[GTK] Update TestExpectations with tests crashing in 64bits Debug build
​https://bugs.webkit.org/show_bug.cgi?id=89105

Unreviewed gardening.

Mark svg/batik/text/textDecoration.svg and
svg/batik/text/textEffect3.svg as crashing in DEBUG.

Patch by Simon Pena <Simon Pena> on 2012-06-14

  • platform/gtk/TestExpectations:
9:53 AM Changeset in webkit [120333] by Philippe Normand
  • 2 edits in trunk/LayoutTests

[GTK] Update TestExpectations with non-passing tests
​https://bugs.webkit.org/show_bug.cgi?id=89100

Unreviewed gardening.

Mark plugins/plugin-initiate-popup-window.html as flaky and
svg/transforms/transformed-text-fill-pattern.html as failing.

Patch by Simon Pena <Simon Pena> on 2012-06-14

  • platform/gtk/TestExpectations:
9:49 AM Changeset in webkit [120332] by qi.2.zhang@nokia.com
  • 2 edits in trunk/Tools

Unreviewed. Update my email.

  • Scripts/webkitpy/common/config/committers.py:
9:49 AM Changeset in webkit [120331] by pfeldman@chromium.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: refactor settings screen to move user agent and experiments out of general tab.
​https://bugs.webkit.org/show_bug.cgi?id=89101

Reviewed by Vsevolod Vlasov.

See image attached to the bug.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/SettingsScreen.js:

(WebInspector.SettingsScreen.prototype.selectTab):
(WebInspector.SettingsScreen.prototype._tabSelected):
(WebInspector.SettingsScreen.prototype.set wasShown):
(WebInspector.SettingsScreen.prototype.willHide):
(WebInspector.SettingsTab):
(WebInspector.SettingsTab.prototype._appendSection):
(WebInspector.SettingsTab.prototype._createCustomSetting):
(WebInspector.GenericSettingsTab):
(WebInspector.GenericSettingsTab.prototype._showPaintRectsChanged):
(WebInspector.GenericSettingsTab.prototype.get _updateScriptDisabledCheckbox):
(WebInspector.GenericSettingsTab.prototype._javaScriptDisabledChanged):
(WebInspector.UserAgentSettingsTab):
(WebInspector.UserAgentSettingsTab.prototype._createUserAgentSelectRowElement.get const):
(WebInspector.UserAgentSettingsTab.prototype._createUserAgentSelectRowElement.textDoubleClicked):
(WebInspector.UserAgentSettingsTab.prototype._createUserAgentSelectRowElement.textChanged):
(WebInspector.UserAgentSettingsTab.prototype._createUserAgentSelectRowElement.set checkboxClicked):
(WebInspector.UserAgentSettingsTab.prototype._createDeviceMetricsElement):
(WebInspector.ExperimentsSettingsTab):
(WebInspector.ExperimentsSettingsTab.prototype._createExperimentsWarningSubsection):
(WebInspector.ExperimentsSettingsTab.prototype._createExperimentCheckbox.listener):
(WebInspector.ExperimentsSettingsTab.prototype._createExperimentCheckbox):

  • inspector/front-end/ShortcutsScreen.js:
  • inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPane.prototype.get headerContentsElement):

  • inspector/front-end/helpScreen.css:

(.settings-tab.help-container):
(.settings-tab .help-block):
(.help-content fieldset):
(#settings-screen .tabbed-pane-header-tabs):
(#settings-screen .tabbed-pane-header-tab):

9:44 AM Changeset in webkit [120330] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

[Qt] New css3/flexbox/flexitem.html fails
​https://bugs.webkit.org/show_bug.cgi?id=88963

Reviewed by Hajime Morita.

  • css3/flexbox/flexitem.html: The height of the alt text was taller

than the height of the missing image placeholder graphic on Qt. To
get the same results, force the font size to something small.
The test still fails on Qt so leaving it in the Skipped file for now.

8:52 AM Changeset in webkit [120329] by kling@webkit.org
  • 2 edits in trunk/Source/WebKit2

Chinese IM receives incorrect/duplicated key events in text fields in webpages in Safari.
<​http://webkit.org/b/89048>
<rdar://problem/11449702>

Reviewed by Darin Adler.

Send the DidReceiveEvent message with the DispatchMessageEvenWhenWaitingForSyncReply flag
for keyboard events. This ensures that it always arrives before the corresponding synchronous
InterpretQueuedKeyEvent message.

The problem was that we relied on DidReceiveEvent / InterpretQueuedKeyEvent always arriving in
the same order they were sent. This was not always true, since DidReceiveEvent (async) would
get deferred during an unrelated waitForSyncReply() whereas InterpretQueuedKeyEvent (sync)
gets dispatched right away.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::keyEvent):

8:39 AM Changeset in webkit [120328] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/WebCore

Worker tear-down can re-enter JSC during GC finalization pt. 2
​https://bugs.webkit.org/show_bug.cgi?id=88601

Reviewed by David Levin.

No new tests. Current regression tests are sufficient.

  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::WorkerMessagingProxy):
(WebCore::WorkerMessagingProxy::workerObjectDestroyed): We clear the m_workerObject here because
we don't want anybody else trying to send messages to the Worker now that it has been destroyed.
We also queue the asynchronous task for the various other cleanup that still needs to be done.
This allows us to avoid the problem of re-entrant JS code execution during GC.
(WebCore):
(WebCore::WorkerMessagingProxy::workerObjectDestroyedInternal): Here we set m_mayBeDestroyed to true.
This is the point after which deleting the WorkerMessagingProxy in workerContextDestroyedInternal()
is okay. It could happen during this function call if the worker thread has been shutdown already, or
it could be called later after we shut down the worker thread.
(WebCore::WorkerMessagingProxy::workerContextDestroyedInternal): We check m_mayBeDestroyed here
instead of checking m_workerObject. This change effectively orthogonalizes the roles that m_workerObject
was filling. Since we were eagerly clearing m_workerObject, but we wanted to asynchronously call
workerObjectDestroyed(), we needed to make sure we didn't accidentally try to delete the WorkerMessagingProxy
twice (once from destroying the Worker and once from destroying the WorkerContext). This boolean field
should fix that issue--we set it lazily like we wanted to do without being in danger of causing use-after-free
issues with m_workerObject.

  • workers/WorkerMessagingProxy.h: Added the new field and function.

(WorkerMessagingProxy):

8:34 AM Changeset in webkit [120327] by apavlov@chromium.org
  • 4 edits in trunk

Web Inspector: Selector list start position is not extracted for style rules inside @media rules
​https://bugs.webkit.org/show_bug.cgi?id=89094

Reviewed by Pavel Feldman.

Source/WebCore:

Selector list start is now marked inside the "ruleset" rule rather than separately, before its invocation(s).

  • css/CSSGrammar.y:

LayoutTests:

  • inspector/audits/audits-panel-functional.html:
7:57 AM Changeset in webkit [120326] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[chromium] Fix race condition where animations start, finish and are deleted on the composite thread, all before the start even arrives on the main thread.
​https://bugs.webkit.org/show_bug.cgi?id=88439

Patch by Eric Penner <​epenner@google.com> on 2012-06-14
Reviewed by James Robinson.

Scheduling behavior covered by existing tests.

  • platform/graphics/chromium/cc/CCActiveAnimation.cpp:

(WebCore::CCActiveAnimation::isFinishedAt):

  • platform/graphics/chromium/cc/CCActiveAnimation.h:

(WebCore::CCActiveAnimation::isFinished):

  • platform/graphics/chromium/cc/CCLayerAnimationController.cpp:

(WebCore::CCLayerAnimationController::suspendAnimations):
(WebCore::CCLayerAnimationController::pushAnimationUpdatesTo):
(WebCore::CCLayerAnimationController::animate):
(WebCore::CCLayerAnimationController::hasActiveAnimation):
(WebCore):
(WebCore::CCLayerAnimationController::markAnimationsForDeletion):
(WebCore::CCLayerAnimationController::purgeAnimationsMarkedForDeletion):

  • platform/graphics/chromium/cc/CCLayerAnimationController.h:

(CCLayerAnimationController):

7:44 AM Changeset in webkit [120325] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: ConsoleView.evaluateUsingTextPrompt should evaluate without command line API.
​https://bugs.webkit.org/show_bug.cgi?id=89096

Reviewed by Pavel Feldman.

  • inspector/front-end/ConsoleView.js:
7:35 AM Changeset in webkit [120324] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Unreviewed, build fix for Mac 10.5

  • src/WebDevToolsAgentImpl.cpp:

(WebKit::DeviceMetricsSupport::autoZoomPageToFitWidth):

7:15 AM Changeset in webkit [120323] by commit-queue@webkit.org
  • 15 edits in trunk/LayoutTests

[EFL] Tests rebaselining after r120167, r120246
​https://bugs.webkit.org/show_bug.cgi?id=89069

Unreviewed EFL gardening after r120246 and r120167, updating baselines.

Patch by Mikhail Pozdnyakov <​mikhail.pozdnyakov@intel.com> on 2012-06-14

  • platform/efl/fast/layers/video-layer-expected.txt:
  • platform/efl/http/tests/misc/location-replace-crossdomain-expected.txt:
  • platform/efl/media/audio-controls-rendering-expected.txt:
  • platform/efl/media/audio-repaint-expected.txt:
  • platform/efl/media/controls-after-reload-expected.txt:
  • platform/efl/media/controls-strict-expected.txt:
  • platform/efl/media/controls-styling-expected.txt:
  • platform/efl/media/controls-without-preload-expected.txt:
  • platform/efl/media/media-controls-clone-expected.txt:
  • platform/efl/media/media-document-audio-repaint-expected.txt:
  • platform/efl/media/video-controls-rendering-expected.txt:
  • platform/efl/media/video-display-toggle-expected.txt:
  • platform/efl/media/video-empty-source-expected.txt:
  • platform/efl/media/video-zoom-controls-expected.txt:
7:01 AM Changeset in webkit [120322] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebCore

Update the time display of the new Chromium media controls.
​https://bugs.webkit.org/show_bug.cgi?id=88724

Patch by Silvia Pfeiffer <​silviapf@chromium.org> on 2012-06-14
Reviewed by Eric Carlson.

No new tests, final patch will contain the rebaselined tests.

The Chrome video controls are receiving a visual update. This patch changes
the format of the time digits that are displayed. They are different for media
files of different duration. For non-autoplaying videos, the duration is shown
before playback is started.

  • css/mediaControlsChromium.css:

(audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
Format the new duration display the same as the current time display.

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
Add a member field for the duration display.
(WebCore::MediaControlRootElementChromium::create):
Add an element for the duration display and initially hide the current time display.
(WebCore::MediaControlRootElementChromium::setMediaController):
Add the duration display to the controller.
(WebCore::MediaControlRootElementChromium::reset):
Add reset functionality for the duration display.
(WebCore::MediaControlRootElementChromium::playbackStarted):
Show the current time display and hide the duration display upon playback start.
(WebCore::MediaControlRootElementChromium::updateTimeDisplay):
Show the current time display and hide the duration display when current time is non-zero.

  • html/shadow/MediaControlRootElementChromium.h:

(WebCore):
Add the MediaControlTimeRemainingDisplayElement which provides use with the duration display.
(MediaControlRootElementChromium):
Add a duration member field, reusing the existing MediaControlTimeRemainingDisplayElement.

  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::formatChromiumMediaControlsTime):
Formats a given time under the condition of a given duration.
(WebCore::RenderMediaControlsChromium::formatMediaControlsTime):
When formatting a single time, assume it to also provide the duration conditions.
(WebCore::RenderMediaControlsChromium::formatMediaControlsCurrentTime):
Format the current time given the duration.
(WebCore::RenderMediaControlsChromium::formatMediaControlsRemainingTime):
Format the remaining time from the current time given the duration.

  • rendering/RenderMediaControlsChromium.h:

(RenderMediaControlsChromium):
Declare the time formatting member functions.

  • rendering/RenderThemeChromiumMac.h:

(RenderThemeChromiumMac):
Declare the time formatting member functions for Chromium on the Mac.

  • rendering/RenderThemeChromiumMac.mm:

(WebCore::RenderThemeChromiumMac::formatMediaControlsTime):
(WebCore::RenderThemeChromiumMac::formatMediaControlsCurrentTime):
(WebCore::RenderThemeChromiumMac::formatMediaControlsRemainingTime):
Call the time formatting member functions of RenderMediaControlsChromium on the Mac.

  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore::formatMediaControlsTime):
(WebCore::formatMediaControlsCurrentTime):
(WebCore::formatMediaControlsRemainingTime):
Call the time formatting member functions of RenderMediaControlsChromium on Skia.

  • rendering/RenderThemeChromiumSkia.h:

(RenderThemeChromiumSkia):
Declare the time formatting member functions for Chromium Skia.

6:58 AM Changeset in webkit [120321] by apavlov@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, test rebaseline after r120317.

  • inspector/styles/override-screen-size-expected.txt:
6:54 AM Changeset in webkit [120320] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] Mark fast/forms/text-input-event.html as flaky in TestExpectations
​https://bugs.webkit.org/show_bug.cgi?id=89085

Unreviewed gardening. Mark test as flaky.

Patch by Simon Pena <Simon Pena> on 2012-06-14

  • platform/gtk/TestExpectations:
6:52 AM Changeset in webkit [120319] by schenney@chromium.org
  • 20 edits
    1 delete in trunk/LayoutTests

[svg] SVGResources applied to Text with Incorrect Transformations in non-CG Implementations
​https://bugs.webkit.org/show_bug.cgi?id=64966

Unreviewed Chromium test expectations update.

Bug fixed by Dominik Röttsches.

  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • platform/chromium-linux/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/chromium-linux/svg/custom/js-late-gradient-creation-expected.png:
  • platform/chromium-linux/svg/custom/js-late-pattern-creation-expected.png:
  • platform/chromium-linux/svg/custom/text-rotated-gradient-expected.png:
  • platform/chromium-mac-leopard/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/chromium-mac-leopard/svg/custom/js-late-gradient-creation-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/js-late-gradient-creation-expected.png: Removed.
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • platform/chromium-mac/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/chromium-mac/svg/custom/js-late-gradient-creation-expected.png:
  • platform/chromium-mac/svg/custom/js-late-pattern-creation-expected.png:
  • platform/chromium-mac/svg/custom/text-rotated-gradient-expected.png:
  • platform/chromium-win-vista/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • platform/chromium-win/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/chromium-win/svg/custom/js-late-gradient-creation-expected.png:
  • platform/chromium-win/svg/custom/js-late-pattern-creation-expected.png:
  • platform/chromium-win/svg/custom/text-rotated-gradient-expected.png:
  • platform/chromium/TestExpectations:
6:26 AM Changeset in webkit [120318] by commit-queue@webkit.org
  • 13 edits in trunk/Source

Web Inspector: Refactor message loop instrumentation.
​https://bugs.webkit.org/show_bug.cgi?id=88978

Patch by Eugene Klyuchnikov <​eustas.bug@gmail.com> on 2012-06-14
Reviewed by Pavel Feldman.

1) Remove "messageLoop" term
2) Reuse WebThread::TaskObserver interface
3) Move implementation (from embedder) to platform code.

Source/Platform:

  • chromium/public/WebThread.h:

(TaskObserver): add "willProcessTask" method.

Source/WebCore:

  • inspector/InspectorClient.h:

(WebCore::InspectorClient::startMainThreadMonitoring): Renamed method.
(WebCore::InspectorClient::stopMainThreadMonitoring): Ditto.

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::start):
(WebCore::InspectorTimelineAgent::stop):

Source/WebKit/chromium:

  • public/WebDevToolsAgent.h:

(WebDevToolsAgent):

  • public/WebDevToolsAgentClient.h:

(WebDevToolsAgentClient):
(WebKit::WebDevToolsAgentClient::startMainThreadMonitoring): Renamed medthod.
(WebKit::WebDevToolsAgentClient::stopMainThreadMonitoring): Ditto.

  • src/InspectorClientImpl.cpp:

(WebKit::InspectorClientImpl::startMainThreadMonitoring): Ditto.
(WebKit::InspectorClientImpl::stopMainThreadMonitoring): Ditto.

  • src/InspectorClientImpl.h:

(InspectorClientImpl):

  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::startMainThreadMonitoring): Use platform threading.
(WebKit::WebDevToolsAgentImpl::stopMainThreadMonitoring): Ditto.
(WebKit::WebDevToolsAgentImpl::willProcessTask): Renamed medthod.
(WebKit::WebDevToolsAgentImpl::didProcessTask): Ditto.

  • src/WebDevToolsAgentImpl.h:

(WebDevToolsAgentImpl):

  • src/WebKit.cpp:
6:05 AM Changeset in webkit [120317] by apavlov@chromium.org
  • 5 edits in trunk

Web Inspector: [Device Metrics] "Fit window" results in duplicate rescaling in WebDevToolsAgentImpl::autoZoomPageToFitWidth()
​https://bugs.webkit.org/show_bug.cgi?id=89092

Reviewed by Pavel Feldman.

Source/WebKit/chromium:

Do not apply the sizeRatio after it has been applied in scaledEmulatedFrameSize().

  • src/WebDevToolsAgentImpl.cpp:

(WebKit::DeviceMetricsSupport::autoZoomPageToFitWidth):
(WebKit::DeviceMetricsSupport::ensureOriginalZoomFactor):

LayoutTests:

  • platform/chromium/inspector/styles/device-metrics-fit-window-expected.txt:
  • platform/chromium/inspector/styles/device-metrics-fit-window.html:
5:51 AM Changeset in webkit [120316] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening after r120314.

  • platform/qt/Skipped: skip svg/transforms/transformed-text-fill-gradient.html
5:40 AM Changeset in webkit [120315] by toyoshim@chromium.org
  • 9 edits in trunk/Tools

Update pywebsocket to 0.7.6 from 0.7.4
​https://bugs.webkit.org/show_bug.cgi?id=88975

Reviewed by Kent Tamura.

This new version of pywebsocket introduce following features.

  • Allow handlers to send a close frame with empty body in response of

a client initiated closing handshake

  • Implement perframe compression extension
  • Support client certificate authentication
  • Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING:
  • Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py:

(_create_control_frame):
(Stream._receive_frame):
(Stream.send_message):
(Stream.receive_message):
(Stream._send_closing_handshake):
(Stream.close_connection):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py:

(ExtensionParsingException):
(ExtensionParsingException.init):
(_parse_extension_param):
(_parse_extension):
(parse_extensions):
(format_extension):
(format_extensions):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py:

(_parse_compression_method):
(_create_accepted_method_desc):
(PerFrameCompressionExtensionProcessor):
(PerFrameCompressionExtensionProcessor.init):
(PerFrameCompressionExtensionProcessor._lookup_compression_processor):
(PerFrameCompressionExtensionProcessor._get_compression_processor_response):
(PerFrameCompressionExtensionProcessor.get_extension_response):
(PerFrameCompressionExtensionProcessor.setup_stream_options):
(PerFrameCompressionExtensionProcessor.get_compression_processor):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py:

(parse_token_list):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py:

(Handshaker._parse_extensions):
(Handshaker._send_handshake):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py:

(WebSocketServer._create_sockets):
(_get_logger_from_class):
(_configure_logging):
(_build_option_parser):
(_main.if):

  • Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py:

(RepeatedXorMasker.mask):

5:18 AM Changeset in webkit [120314] by commit-queue@webkit.org
  • 10 edits
    4 adds in trunk

[svg] SVGResources applied to Text with Incorrect Transformations in non-CG Implementations
​https://bugs.webkit.org/show_bug.cgi?id=64966

Patch by Dominik Röttsches <​dominik.rottsches@intel.com> on 2012-06-14
Reviewed by Nikolas Zimmermann.

Source/WebCore:

SVGInlineTextBox::paintTextWithShadows for non-CG implementations resets the scale aspect
of the currently applied CTM. This leads to patterns and gradients being incorrectly downscaled.
This way of resetting the CTM and drawing fonts "natively" scaled was introduced
in r77485 to fix a number of issues with SVG font scaling.
Unfortunately, this breaks scaling of patterns and gradients. To fix it,
we need to push the transformation back into the pattern/gradient space transformation.

Tests: svg/transforms/transformed-text-fill-gradient.html

svg/transforms/transformed-text-fill-pattern.html

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::computeNewScaledFontForStyle): Moving the scaling factor calculation out into SVGRenderingContext.

  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::shouldTransformOnTextPainting): Reusing the scaling factor calculation from SVGRenderingContext.
(WebCore):

  • rendering/svg/RenderSVGResourceContainer.h:

(RenderSVGResourceContainer):

  • rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::RenderSVGResourceGradient::applyResource): If needed, push down transformation into gradient space.

  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::applyResource): If needed, push transformation into pattern space.

  • rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::calculateScreenFontSizeScalingFactor): Common scaling factor calculation for RenderSVGInlineText and RenderSVGResourceContainer.

  • rendering/svg/SVGRenderingContext.h:

(SVGRenderingContext):

LayoutTests:

For Pattern: RefTest that compare a scaled rectangle with a scaled block of Ahem characters.
The pattern or gradient should scale in the same way for the text and the rectangle.
This approach needs a clipping path hack to work around micro gaps between Ahem characters
due to rounding.
For Gradient: Scaling text at two different scale factors and adjusting font size to yield the same effective text size.
Gradient fill should be identical in both cases.

  • platform/chromium/TestExpectations: Added 3 tests that need rebaselining for text gradient fills.
  • svg/transforms/transformed-text-fill-gradient-expected.html: Added.
  • svg/transforms/transformed-text-fill-gradient.html: Added.
  • svg/transforms/transformed-text-fill-pattern-expected.html: Added.
  • svg/transforms/transformed-text-fill-pattern.html: Added.
4:53 AM Changeset in webkit [120313] by yosin@chromium.org
  • 24 edits in trunk/Source/WebCore

[Form] Replace InputNumber type to Decimal type and drop InputNumber
​https://bugs.webkit.org/show_bug.cgi?id=88746

Reviewed by Kent Tamura.

This patch removes InputNumber introduced by r119540 by replacing
InputNumber type to Decimal type and changing convertDoubleToDecimal
and convertDecimalToDouble to Decimal::fromDouble and
Decimal::toDouble, respectively.

No new tests. This patch doesn't change behavior.

  • html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::setValueAsDecimal):
(WebCore::BaseDateAndTimeInputType::defaultValueForStepUp):
(WebCore::BaseDateAndTimeInputType::parseToNumber):
(WebCore::BaseDateAndTimeInputType::serialize):
(WebCore::BaseDateAndTimeInputType::serializeWithComponents):
(WebCore::BaseDateAndTimeInputType::serializeWithMilliseconds):

  • html/BaseDateAndTimeInputType.h:

(BaseDateAndTimeInputType):

  • html/DateInputType.cpp:

(WebCore::DateInputType::createStepRange):

  • html/DateTimeInputType.cpp:

(WebCore::DateTimeInputType::defaultValueForStepUp):
(WebCore::DateTimeInputType::createStepRange):

  • html/DateTimeInputType.h:

(DateTimeInputType):

  • html/DateTimeLocalInputType.cpp:

(WebCore::DateTimeLocalInputType::createStepRange):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::getAllowedValueStep):

  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/InputType.cpp:

(WebCore::InputType::setValueAsDouble):
(WebCore::InputType::setValueAsDecimal):
(WebCore::InputType::rangeUnderflow):
(WebCore::InputType::rangeOverflow):
(WebCore::InputType::defaultValueForStepUp):
(WebCore::InputType::minimum):
(WebCore::InputType::maximum):
(WebCore::InputType::isInRange):
(WebCore::InputType::isOutOfRange):
(WebCore::InputType::stepMismatch):
(WebCore::InputType::validationMessage):
(WebCore::InputType::parseToNumber):
(WebCore::InputType::parseToNumberOrNaN):
(WebCore::InputType::serialize):
(WebCore::InputType::applyStep):
(WebCore::InputType::getAllowedValueStep):
(WebCore::InputType::stepUpFromRenderer):

  • html/InputType.h:

(InputType):

  • html/MonthInputType.cpp:

(WebCore::MonthInputType::defaultValueForStepUp):
(WebCore::MonthInputType::createStepRange):
(WebCore::MonthInputType::parseToNumber):

  • html/MonthInputType.h:

(MonthInputType):

  • html/NumberInputType.cpp:

(WebCore::NumberInputType::setValueAsDecimal):
(WebCore::NumberInputType::createStepRange):
(WebCore::NumberInputType::parseToNumber):
(WebCore::NumberInputType::serialize):

  • html/NumberInputType.h:

(NumberInputType):

  • html/RangeInputType.cpp:

(WebCore::ensureMaximum):
(WebCore::RangeInputType::setValueAsDecimal):
(WebCore::RangeInputType::createStepRange):
(WebCore::RangeInputType::handleKeydownEvent):
(WebCore::RangeInputType::parseToNumber):
(WebCore::RangeInputType::serialize):
(WebCore::RangeInputType::sanitizeValue):

  • html/RangeInputType.h:

(RangeInputType):

  • html/StepRange.cpp:

(WebCore::StepRange::StepRange):
(WebCore::StepRange::acceptableError):
(WebCore::StepRange::alignValueForStep):
(WebCore::StepRange::clampValue):
(WebCore::StepRange::parseStep):
(WebCore::StepRange::roundByStep):
(WebCore::StepRange::stepMismatch):

  • html/StepRange.h:

(WebCore::StepRange::StepDescription::defaultValue):
(StepRange):
(WebCore::StepRange::maximum):
(WebCore::StepRange::minimum):
(WebCore::StepRange::step):
(WebCore::StepRange::stepBase):
(WebCore::StepRange::defaultValue):
(WebCore::StepRange::proportionFromValue):
(WebCore::StepRange::valueFromProportion):

  • html/TimeInputType.cpp:

(WebCore::TimeInputType::defaultValueForStepUp):
(WebCore::TimeInputType::createStepRange):

  • html/TimeInputType.h:

(TimeInputType):

  • html/WeekInputType.cpp:

(WebCore::WeekInputType::createStepRange):

  • html/shadow/CalendarPickerElement.cpp:

(WebCore::CalendarPickerElement::writeDocument):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::sliderPosition):
(WebCore::RenderSliderThumb::layout):
(WebCore::SliderThumbElement::setPositionFromPoint):

3:57 AM Changeset in webkit [120312] by yosin@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium][Forms] We should remove ENABLE_INPUT_TYPE_TIME=0 and so on to allows us to override them by ~/.gyp/include.gypi
​https://bugs.webkit.org/show_bug.cgi?id=89062

Reviewed by Kent Tamura.

This patch removes ENABLE_INPUT_TYPE_*=0 from default entry of feature_defines to
allows us overriding by ~/.gyp/include.gypi

  • features.gypi: Remove ENABLE_INPUT_TYPE_DATETIME=0, ENABLE_INPUT_TYPE_DATETIMELOCAL=0,

and so on.

3:34 AM Changeset in webkit [120311] by commit-queue@webkit.org
  • 6 edits in trunk

Web Inspector: Implement ExtensionPanel.show() method
​https://bugs.webkit.org/show_bug.cgi?id=88473

Source/WebCore:

Implemented ExtensionPanel.show() API method to allow extension
developers to show their panel when needed.

Patch by Jan Keromnes <​janx@linux.com> on 2012-06-14
Reviewed by Pavel Feldman.

Tests for this method are in:
LayoutTests/inspector/extensions/extensions-panel.html

  • inspector/front-end/ExtensionAPI.js:

(defineCommonExtensionSymbols):
(injectedExtensionAPI.ExtensionPanelImpl.prototype.createStatusBarButton):
(injectedExtensionAPI.ExtensionPanelImpl.prototype.show):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype._onShowPanel):

LayoutTests:

Add output for ExtensionPanel callbacks, and use ExtensionPanel.show()
to show the panel. Fix expected.

Patch by Jan Keromnes <​janx@linux.com> on 2012-06-14
Reviewed by Pavel Feldman.

  • inspector/extensions/extensions-panel-expected.txt:
  • inspector/extensions/extensions-panel.html:
3:31 AM Changeset in webkit [120310] by zoltan@webkit.org
  • 2 edits in trunk/Tools

[Qt] Remove USE(QT_IMAGE_DECODER) macro, since we don't use it anymore

Reviewed by Noam Rosenthal.

  • qmake/mkspecs/features/features.prf:
3:27 AM Changeset in webkit [120309] by tkent@chromium.org
  • 3 edits in trunk/Source/WebCore

Fix a typo in r120304.
​https://bugs.webkit.org/show_bug.cgi?id=89070

  • bindings/scripts/CodeGeneratorV8.pm:

(NativeToJSValue):

  • bindings/scripts/test/V8/V8TestObj.cpp:
3:20 AM Changeset in webkit [120308] by commit-queue@webkit.org
  • 8 edits in trunk

Add dpcm to css3-images image-resolution
​https://bugs.webkit.org/show_bug.cgi?id=85442

Patch by David Barr <​davidbarr@chromium.org> on 2012-06-14
Reviewed by Tony Chang.

Source/WebCore:

The css3-images module is at candidate recommendation.
​http://www.w3.org/TR/2012/CR-css3-images-20120417/#the-image-resolution

No new tests; extended fast/css/image-resolution/image-resolution.html

  • css/CSSGrammar.y: Add DPCM token and unary term.
  • css/CSSParser.cpp: Extend range of units accepted for resolution and tokenize "dpcm".

(WebCore::CSSParser::validUnit): Accept CSSPrimitiveValue::CSS_DPCM.
(WebCore::CSSParser::createPrimitiveNumericValue): Accept CSSPrimitiveValue::CSS_DPCM.
(WebCore::unitFromString): Map "dpcm" to CSSPrimitiveValue::CSS_DPCM.
(WebCore::CSSParser::parseValidPrimitive): Accept CSSPrimitiveValue::CSS_DPCM.
(WebCore::CSSParser::detectNumberToken): Map "dpcm" to CSSPrimitiveValue::CSS_DPCM.

  • css/CSSPrimitiveValue.cpp: Add CSSPrimitiveValue::CSS_DPCM as a numeric unit.

(WebCore::isValidCSSUnitTypeForDoubleConversion): Accept CSSPrimitiveValue::CSS_DPCM.
(WebCore::unitCategory): Map CSSPrimitiveValue::CSS_DPCM to CSSPrimitiveValue::UResolution.
(WebCore::conversionToCanonicalUnitsScaleFactor): Scale CSSPrimitiveValue::CSS_DPCM to CSSPrimitiveValue::CSS_DPPX.
(WebCore::CSSPrimitiveValue::customCssText): Format CSSPrimitiveValue::CSS_DPCM as "<num>dpcm".
(WebCore::CSSPrimitiveValue::cloneForCSSOM): Accept CSSPrimitiveValue::CSS_DPCM as numeric unit.

  • css/CSSPrimitiveValue.h: Add CSSPrimitiveValue::CSS_DPCM.

LayoutTests:

  • fast/css/image-resolution/image-resolution-expected.txt:
  • fast/css/image-resolution/image-resolution.html:
3:16 AM Changeset in webkit [120307] by vsevik@chromium.org
  • 1 edit in branches/chromium/1132/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js

Merge 120214 - Web Inspector: Errors when pending console messages are attached to JavaScriptSourceFrame.
​https://bugs.webkit.org/show_bug.cgi?id=88712

Reviewed by Pavel Feldman.

  • inspector/front-end/PresentationConsoleMessageHelper.js:

(WebInspector.PresentationConsoleMessageHelper):
(WebInspector.PresentationConsoleMessageHelper.prototype._addPendingConsoleMessage):
(WebInspector.PresentationConsoleMessageHelper.prototype._parsedScriptSource):

TBR=​vsevik@chromium.org
BUG=132449

---All lines above this line become the description.
---Repository Root: /home/vsevik/webkit_merges/drover_120214_1132/1132
---Paths in this changelist (120214):

---Paths modified but not in any changelist:

! Source/WebCore/inspector/front-end/PresentationConsoleMessageHelper.js
Review URL: ​https://chromiumcodereview.appspot.com/10548044

3:13 AM Changeset in webkit [120306] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: REGRESSION HeapProfiler can't remove heap snapshot from the list if Dominators view has been opened.
​https://bugs.webkit.org/show_bug.cgi?id=89080

There was no dispose method on artificial ShowMoreDataGrid node.

Reviewed by Pavel Feldman.

  • inspector/front-end/ShowMoreDataGridNode.js:

(WebInspector.ShowMoreDataGridNode.prototype.nodeHeight):
(WebInspector.ShowMoreDataGridNode.prototype.dispose):

3:10 AM Changeset in webkit [120305] by Carlos Garcia Campos
  • 8 edits
    2 adds in trunk/Source/WebKit2

[GTK] Add input methods submenu item to the default context menu for editable content
​https://bugs.webkit.org/show_bug.cgi?id=80600

Reviewed by Martin Robinson.

  • GNUmakefile.am: Add new files to compilation.
  • UIProcess/API/gtk/WebKitContextMenuClient.cpp: Added.

(getContextMenuFromProposedMenu): Call webkitWebViewContextMenu().
(attachContextMenuClientToView): Add implementation for
getContextMenuFromProposedMenu callback.

  • UIProcess/API/gtk/WebKitContextMenuClient.h: Added.
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewConstructed): Attach context menu client to view.
(webkitWebViewCreateAndAppendDefaultMenuItems): Helper function to
add default context menu items to the new context menu items vector.
(webkitWebViewShouldShowInputMethodsMenu): Helper function to
check whether to show the input methods submenu according to the
gtk-show-input-method-menu GTK+ setting.
(webkitWebViewCreateAndAppendInputMethodsMenuItem): Helper
function to add input methods submenu to the new context menu
items vector.
(webkitWebViewContextMenu): Create a new context menu items vector
containing default items and input methods submenu in case of
editable content. The active content menu is populated using that
new vector.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseSetActiveContextMenu): Set the active context menu.
(webkitWebViewBaseGetActiveContextMenu): Get the active context menu.

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
  • UIProcess/API/gtk/WebKitWebViewPrivate.h:
  • UIProcess/gtk/WebContextMenuProxyGtk.cpp:

(WebKit::WebContextMenuProxyGtk::append): Helper method to add a
new item to the context menu.
(WebKit::WebContextMenuProxyGtk::populate): Add items to the
context menu.
(WebKit::WebContextMenuProxyGtk::showContextMenu): Populate the
menu with the given items and popup the menu if it's not empty.
(WebKit::WebContextMenuProxyGtk::hideContextMenu): Get the GtkMenu
from the WebCore ContextMenu to popdown it.
(WebKit::WebContextMenuProxyGtk::WebContextMenuProxyGtk): Call
webkitWebViewBaseSetActiveContextMenu() to set the menu as the current
active one for the view.
(WebKit::WebContextMenuProxyGtk::~WebContextMenuProxyGtk): Call
webkitWebViewBaseSetActiveContextMenu() with NULL to reset the
current active context of the view. GtkMenu is destroyed by
WebCore ContextMenu in its destructor.

  • UIProcess/gtk/WebContextMenuProxyGtk.h:
2:59 AM Changeset in webkit [120304] by tkent@chromium.org
  • 9 edits in trunk/Source/WebCore

[JSC/V8] Improve DOMString[] support
​https://bugs.webkit.org/show_bug.cgi?id=89070

Reviewed by Kentaro Hara.

Tests: new test case in TestObj.idl

  • bindings/js/JSDOMBinding.cpp:

(WebCore::jsArray): Implement jsArray() for DOMStringList.

  • bindings/js/JSDOMBinding.h: Declare jsArray() for DOMStringList.
  • bindings/scripts/CodeGeneratorJS.pm:

(NativeToJSValue): Avoid to include JSDOMString.h and DOMString.h.

  • bindings/scripts/CodeGeneratorV8.pm:

(GetNativeType): Move a check for DOMString[] because it's a RefPtr type
and we'd like to avoid to generate RefPtr<DOMString[]>
(%non_wrapper_types): DOMString[] is not a wrapper type. This is needed
to avoid to generate unnecessary custom function template.
(NativeToJSValue): Avoid to include V8DOMString.h and DOMString.h.

  • bindings/scripts/test/TestObj.idl: Add non-overload function using DOMString[].
  • bindings/scripts/test/JS/JSTestObj.cpp: Update expectation.
  • bindings/scripts/test/JS/JSTestObj.h: ditto.
  • bindings/scripts/test/V8/V8TestObj.cpp: ditto.
2:56 AM Changeset in webkit [120303] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

LocaleToScriptMappingDefault.cpp should also do what scriptCodeForFontSelection does in LocaleToScriptMappingICU.cpp
​https://bugs.webkit.org/show_bug.cgi?id=88845

Patch by Matt Falkenhagen <​falken@chromium.org> on 2012-06-14
Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/text/international/jpan-script-equivalence.html

  • platform/text/LocaleToScriptMappingDefault.cpp:

(WebCore::scriptNameToCode):

LayoutTests:

  • fast/text/international/jpan-script-equivalence-expected.html: Added.
  • fast/text/international/jpan-script-equivalence.html: Added.
2:52 AM Changeset in webkit [120302] by pfeldman@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: render dock-to-right icon in status bar.
​https://bugs.webkit.org/show_bug.cgi?id=89040

Reviewed by Vsevolod Vlasov.

Today we render dock to bottom icon for both actions (dock to bottom and dock to right).

  • inspector/front-end/Images/statusbarButtonGlyphs.png:
  • inspector/front-end/inspector.css:

(button.dock-status-bar-item.status-bar-item.toggled-undock .glyph):
(button.dock-status-bar-item.status-bar-item.toggled-bottom .glyph):
(button.dock-status-bar-item.status-bar-item.toggled-right .glyph):

  • inspector/front-end/inspector.js:

(WebInspector._createGlobalStatusBarItems):
(WebInspector._installDockToRight.listener):
(windowLoaded):
(WebInspector.setDockingUnavailable):

2:43 AM Changeset in webkit [120301] by commit-queue@webkit.org
  • 19 edits
    4 adds in trunk

[WK2] Add implementation for registerIntentService in WebFrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=88399

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-14
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add implementation for registerIntentService() in
WebFrameLoaderClient.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Shared/API/c/WKBase.h:
  • Shared/APIClientTraits.h:
  • Shared/APIObject.h:
  • Shared/IntentServiceInfo.cpp: Added.

(WebKit):
(WebKit::IntentServiceInfo::encode):
(WebKit::IntentServiceInfo::decode):

  • Shared/IntentServiceInfo.h: Added.

(CoreIPC):
(WebKit):
(IntentServiceInfo):

  • Target.pri:
  • UIProcess/API/C/WKAPICast.h:

(WebKit):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/gtk/WebKitLoaderClient.cpp:

(attachLoaderClientToView):

  • UIProcess/WebIntentServiceInfo.cpp: Added.

(WebKit):
(WebKit::WebIntentServiceInfo::WebIntentServiceInfo):

  • UIProcess/WebIntentServiceInfo.h: Added.

(WebKit):
(WebIntentServiceInfo):
(WebKit::WebIntentServiceInfo::create):
(WebKit::WebIntentServiceInfo::~WebIntentServiceInfo):
(WebKit::WebIntentServiceInfo::action):
(WebKit::WebIntentServiceInfo::payloadType):
(WebKit::WebIntentServiceInfo::href):
(WebKit::WebIntentServiceInfo::title):
(WebKit::WebIntentServiceInfo::disposition):
(WebKit::WebIntentServiceInfo::type):

  • UIProcess/WebLoaderClient.cpp:

(WebKit):
(WebKit::WebLoaderClient::registerIntentServiceForFrame):

  • UIProcess/WebLoaderClient.h:

(WebKit):
(WebLoaderClient):

  • UIProcess/WebPageProxy.cpp:

(WebKit):
(WebKit::WebPageProxy::registerIntentServiceForFrame):

  • UIProcess/WebPageProxy.h:

(WebKit):
(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit):
(WebKit::WebFrameLoaderClient::registerIntentService):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

(WebFrameLoaderClient):

Tools:

Update initialization of WKPageLoaderClient.

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

2:32 AM Changeset in webkit [120300] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk

[Blackberry] add a new Api named setAllowNotification
​https://bugs.webkit.org/show_bug.cgi?id=88950

Patch by Chris Guan <​chris.guan@torchmobile.com.cn> on 2012-06-14
Reviewed by Antonio Gomes.

.:

Add a new API named setAllowNotification in webpage class to
let client set those allowed domains into notifications.

Test case:

  • ManualTests/blackberry/notification.html: Added.

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::setAllowNotification):
(WebKit):

  • Api/WebPage.h:
2:31 AM Changeset in webkit [120299] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: clear execution live before the text edit.
​https://bugs.webkit.org/show_bug.cgi?id=89016

Reviewed by Vsevolod Vlasov.

Otherwise we can't remove them after committing the edit.

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.clearExecutionLine):

2:25 AM Changeset in webkit [120298] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Remove the const keyword from MediaPlayerPrivate::enterFullscreen()
​https://bugs.webkit.org/show_bug.cgi?id=89044

Patch by Min Qin <​qinmin@google.com> on 2012-06-14
Reviewed by Adam Barth.

Source/WebCore:

enterFullscreen() and exitFullscreen() could both modify the player state.
This change reverts the change we made in r120213.

Just function declaration change, no test needed.

  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::enterFullscreen):

Source/WebKit/chromium:

enterFullscreen() should be treated similarly as exitFullscreen() as it could alter the player state.
This reverts the change from r120213.

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::enterFullscreen):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

1:40 AM Changeset in webkit [120297] by Carlos Garcia Campos
  • 9 edits in trunk/Source/WebKit2

[WK2] Add WKHitTestResultIsContentEditable()
​https://bugs.webkit.org/show_bug.cgi?id=80597

Reviewed by Martin Robinson.

  • Shared/WebHitTestResult.cpp:

(WebKit::WebHitTestResult::Data::encode): Encode isContentEditable.
(WebKit::WebHitTestResult::Data::decode): Decode isContentEditable.

  • Shared/WebHitTestResult.h:

(Data): Add isContentEditable.
(WebKit::WebHitTestResult::Data::Data): Initialize
isContentEditable.
(WebKit::WebHitTestResult::isContentEditable): Returns whether
hit test result target is editable content.

  • UIProcess/API/C/WKHitTestResult.cpp:

(WKHitTestResultIsContentEditable): C API to get whether hit test
result target is editable content.

  • UIProcess/API/C/WKHitTestResult.h:
  • UIProcess/API/gtk/WebKitHitTestResult.cpp:

(webkitHitTestResultCreate): Add
WEBKIT_HIT_TEST_RESULT_CONTEXT_EDITABLE flags to the context if
hit test result target is editable content.
(webkit_hit_test_result_context_is_editable): Returns TRUE if
WEBKIT_HIT_TEST_RESULT_CONTEXT_EDITABLE flags is present in
context.

  • UIProcess/API/gtk/WebKitHitTestResult.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewMouseTarget): Add tests for
WEBKIT_HIT_TEST_RESULT_CONTEXT_EDITABLE.

1:31 AM Changeset in webkit [120296] by commit-queue@webkit.org
  • 7 edits in trunk

el.getAttribute('type') returns 'null' when setting el.type to null
​https://bugs.webkit.org/show_bug.cgi?id=89030

Patch by Edaena Salinas Jasso <​edaena@apple.com> on 2012-06-14
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: fast/dom/HTMLButtonElement/change-type.html

  • html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::setType): Changed parameter to be AtomicString to
address an unrelated review comment from bug 14439 for slightly better performance.

  • html/HTMLButtonElement.h:

(HTMLButtonElement): Changed parameter to be AtomicString to address an unrelated
review comment from bug 14439 for slightly better performance.

  • html/HTMLButtonElement.idl: Specified TreatNullAs NullString for the type attribute.

LayoutTests:

  • fast/dom/HTMLButtonElement/change-type-expected.txt: Updated the expected output

so that it matches the null return type of getAttribute('type').

  • fast/dom/HTMLButtonElement/change-type.html: Change test of getAttribute('type')

to be null instead of 'null'. Addressed and unrelated review comment from bug 14439
about how 'undefined' is specified in the shouldBe function.

1:06 AM Changeset in webkit [120295] by commit-queue@webkit.org
  • 20 edits in trunk

IndexedDB: Creating a transaction from within a transaction callback should fail
​https://bugs.webkit.org/show_bug.cgi?id=80547

Patch by Alec Flett <​alecflett@chromium.org> on 2012-06-14
Reviewed by Tony Chang.

Source/WebCore:

Prevent creation of a transaction, via IDBDatabase.transaction()
or IDBDatabase.setVersion(), from inside a setVersion()
transaction, as per spec. Update many tests to deal with this.

Test restructuring uncovered some inconsistencies in transaction
mode handling. So also do some minor cleanup in the way the
transaction mode is passed between the frontend and backend
transaction objects, and add additional asserts.

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::update):

  • Modules/indexeddb/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::update):

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::setVersion):
(WebCore::IDBDatabase::transaction):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::putInternal):

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::onSuccess):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::create):
(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::stringToMode):
(WebCore::IDBTransaction::modeToString):

  • Modules/indexeddb/IDBTransaction.h:

(IDBTransaction):

LayoutTests:

  • storage/indexeddb/cursor-update-expected.txt:
  • storage/indexeddb/database-basics-expected.txt:
  • storage/indexeddb/mozilla/cursor-update-updates-indexes-expected.txt:
  • storage/indexeddb/mozilla/resources/cursor-update-updates-indexes.js:

(setupObjectStoreAndCreateIndexAndAdd.transaction.oncomplete):
(setupObjectStoreAndCreateIndexAndAdd):

  • storage/indexeddb/mozilla/resources/object-store-remove-values.js:

(createObjectStore):
(finalCheck):

  • storage/indexeddb/mozilla/resources/remove-objectstore.js:

(createAndPopulateObjectStore):
(postSetVersion2.request.onsuccess):
(postSetVersion2):
(deleteSecondObjectStore):

  • storage/indexeddb/resources/cursor-update.js:

(openBasicCursor):
(keyCursor):
(testReadOnly):
(attemptUpdate):

  • storage/indexeddb/resources/database-basics.js:

(openSuccess.request.onsuccess):
(openSuccess):
(setVersionSuccess.request.onsuccess):
(setVersionSuccess):
(createObjectStore):

  • storage/indexeddb/resources/version-change-exclusive.js:

(test):

  • storage/indexeddb/version-change-exclusive-expected.txt:
1:00 AM Changeset in webkit [120294] by commit-queue@webkit.org
  • 7 edits in trunk

[EFL] [DRT] Implement setDomainRelaxationForbiddenForURLScheme in EFL DRT
​https://bugs.webkit.org/show_bug.cgi?id=84577

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-06-14
Reviewed by Ryosuke Niwa.

Source/WebKit/efl:

Add missing implementation setDomainRelaxationForbiddenForURLScheme to
EFL's DumpRenderTreeSupport to allow disabling domain relaxation.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::setDomainRelaxationForbiddenForURLScheme):

  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Add missing implementation setDomainRelaxationForbiddenForURLScheme to EFL's
LayoutTestController.

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setDomainRelaxationForbiddenForURLScheme):

LayoutTests:

Unskip http/tests/security/setDomainRelaxationForbiddenForURLScheme.html

  • platform/efl/Skipped:
12:52 AM Changeset in webkit [120293] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Updating baseline after r120257.

Patch by Ádám Kallai <​kadam@inf.u-szeged.hu> on 2012-06-14

  • fast/table/max-width-integer-overflow-expected.txt:
12:36 AM Changeset in webkit [120292] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Rename WebFrameClient::userAgent() to better reflect what it does
​https://bugs.webkit.org/show_bug.cgi?id=89028

Patch by Dan Alcantara <​dfalcantara@chromium.org> on 2012-06-14
Reviewed by Adam Barth.

Renames WebFrameClient::userAgent() to userAgentOverride() and makes it return
the user agent override string directly.

  • public/WebFrameClient.h:

(WebFrameClient):
(WebKit::WebFrameClient::userAgentOverride):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::userAgent):

  • tests/FrameLoaderClientImplTest.cpp:
12:22 AM Changeset in webkit [120291] by commit-queue@webkit.org
  • 8 edits in trunk

[WebSocket] WebSocket object in Worker Context should fire error event when it fails connection.
​https://bugs.webkit.org/show_bug.cgi?id=88744

Patch by Li Yin <​li.yin@intel.com> on 2012-06-14
Reviewed by Kent Tamura.

Source/WebCore:

Spec:http://dev.w3.org/html5/websockets/#feedback-from-the-protocol
The behavior of firing error event in Document has been implemented in Committed r117944.
WebSocket in WorkerContext is also required to fire error event.

Test: http/tests/websocket/tests/hybi/workers/close.html

  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageError):
(WebCore):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageErrorCallback):

  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:

(ThreadableWebSocketChannelClientWrapper):

  • Modules/websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::workerContextDidReceiveMessageError):
(WebCore):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveMessageError):

  • Modules/websockets/WorkerThreadableWebSocketChannel.h:

(Peer):

LayoutTests:

  • http/tests/websocket/tests/hybi/workers/close-expected.txt:
  • http/tests/websocket/tests/hybi/workers/resources/close.js:

(testPassed):
(runCodeTest.else.ws.onerror):
(runCodeTest):
(runReasonTest.else.ws.onerror):
(runReasonTest):

12:04 AM Changeset in webkit [120290] by g.czajkowski@samsung.com
  • 2 edits in trunk/Source/WebKit2

[WK2] Fix client interface size for WKPageLoaderClient.
​https://bugs.webkit.org/show_bug.cgi?id=88764

Reviewed by Anders Carlsson.

Fixes offset of WKPageLoaderClient for version 0 by adding didDetectXSSForFrame.
The offset should be off the first new callback that was added in the new version.

  • Shared/APIClientTraits.cpp:

(WebKit):

Jun 13, 2012:

11:56 PM Changeset in webkit [120289] by kinuko@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix attempt for r120285

  • Modules/filesystem/DOMFileSystemBase.cpp:

(WebCore):

11:54 PM Changeset in webkit [120288] by morrita@google.com
  • 13 edits in trunk/Source/WebCore

Unreviewed expectation update.

  • bindings/scripts/test/V8/V8Float64Array.cpp:
  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:
  • bindings/scripts/test/V8/V8TestEventTarget.cpp:
  • bindings/scripts/test/V8/V8TestException.cpp:
  • bindings/scripts/test/V8/V8TestInterface.cpp:
  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
  • bindings/scripts/test/V8/V8TestNode.cpp:
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::installPerContextProperties):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
11:47 PM Changeset in webkit [120287] by zandobersek@gmail.com
  • 15 edits
    1 add in trunk/LayoutTests

Unreviewed GTK gardening after r120246 and r120257, updating baselines.

  • platform/gtk/fast/hidpi/video-controls-in-hidpi-expected.txt:
  • platform/gtk/fast/layers/video-layer-expected.txt:
  • platform/gtk/fast/table/max-width-integer-overflow-expected.txt: Added.
  • platform/gtk/media/audio-controls-rendering-expected.txt:
  • platform/gtk/media/audio-repaint-expected.txt:
  • platform/gtk/media/controls-strict-expected.txt:
  • platform/gtk/media/controls-styling-expected.txt:
  • platform/gtk/media/controls-without-preload-expected.txt:
  • platform/gtk/media/media-controls-clone-expected.txt:
  • platform/gtk/media/media-document-audio-repaint-expected.txt:
  • platform/gtk/media/video-controls-rendering-expected.txt:
  • platform/gtk/media/video-empty-source-expected.txt:
  • platform/gtk/media/video-no-audio-expected.txt:
  • platform/gtk/media/video-volume-slider-expected.txt:
  • platform/gtk/media/video-zoom-controls-expected.txt:
11:43 PM Changeset in webkit [120286] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed: Update expectations
​https://bugs.webkit.org/show_bug.cgi?id=88949

http/tests/media/media-source/video-media-source-add-and-remove-ids.html
is passing on canary bots but producing text diffs on the WebKit
waterfall. As noted in the bug, I believe the text diffs are
timing-related.

  • platform/chromium/TestExpectations:
11:41 PM Changeset in webkit [120285] by kinuko@chromium.org
  • 9 edits
    1 delete in trunk/Source

Move isolated file system code out of chromium-specific directory
​https://bugs.webkit.org/show_bug.cgi?id=88997

Reviewed by Adam Barth.

The code does not need to be chromium-specific. Any platforms that
have file system implementation and manage mappings from file system
id to a set of files should share the code.

No new tests as this has no functional/behavioral changes.

  • Modules/filesystem/DOMFileSystem.cpp:

(WebCore::DOMFileSystem::createIsolatedFileSystem):
(WebCore):

  • Modules/filesystem/DOMFileSystem.h:

(DOMFileSystem):

  • Modules/filesystem/DOMFileSystemBase.h:

(DOMFileSystemBase):

  • Modules/filesystem/FileSystemType.h:
  • Modules/filesystem/chromium/DOMFileSystemChromium.cpp:
  • Modules/filesystem/chromium/DOMFileSystemChromium.h: Removed.
  • Modules/filesystem/chromium/DraggedIsolatedFileSystem.cpp:

(WebCore::DraggedIsolatedFileSystem::getDOMFileSystem):

  • WebCore.gypi:
11:31 PM Changeset in webkit [120284] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Add WebDocument.images
​https://bugs.webkit.org/show_bug.cgi?id=88837

Patch by Jesse Greenwald <​jgreenwald@google.com> on 2012-06-13
Reviewed by Adam Barth.

This method is needed on Android to support the existing
WebView.documentHasImages Java API.

  • public/WebDocument.h:

(WebDocument):

  • src/WebDocument.cpp:

(WebKit::WebDocument::images):
(WebKit):

11:30 PM Changeset in webkit [120283] by dominicc@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed: Disable verifyHitTestingForSingleLayer.
​https://bugs.webkit.org/show_bug.cgi?id=89065

It is failing on canary debug bots.

  • tests/CCLayerTreeHostCommonTest.cpp:
11:17 PM Changeset in webkit [120282] by kinuko@chromium.org
  • 13 edits in trunk/Source/WebCore

File::lastModifiedDate should use NaN or separate boolean flag for null Date value
​https://bugs.webkit.org/show_bug.cgi?id=87826

Reviewed by Kent Tamura.

Test: http/tests/local/fileapi/file-last-modified-after-delete.html

  • fileapi/File.cpp:

(WebCore::File::File):
(WebCore::File::captureSnapshot):
(WebCore::File::lastModifiedDate):
(WebCore::File::lastModifiedDateForBinding): Removed.

  • fileapi/File.h:

(File):

  • fileapi/File.idl:
  • platform/FileMetadata.h:

(WebCore::FileMetadata::FileMetadata):

  • platform/FileSystem.h:
  • platform/FileStream.cpp:

(WebCore::FileStream::getSize):

  • platform/chromium/support/WebHTTPBody.cpp:

(WebKit::WebHTTPBody::elementAt):

  • platform/network/BlobData.h:

(WebCore::BlobDataItem::doNotCheckFileChange): Removed.

  • platform/network/BlobData.cpp:
  • platform/network/cf/FormDataStreamCFNet.cpp:

(WebCore::advanceCurrentStream):

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::blobIsOutOfDate):

10:59 PM Changeset in webkit [120281] by efidler@rim.com
  • 2 edits in trunk/Source/WebCore

Fix CMake build with SMOOTH_SCROLLING enabled
​https://bugs.webkit.org/show_bug.cgi?id=89032

Reviewed by Antonio Gomes.

SMOOTH_SCROLLING pulls in ScrollAnimatorNone.cpp, which has
dependencies on platform/ActivePlatformGestureAnimation.cpp and
platform/TouchpadFlingPlatformGestureCurve.cpp

  • CMakeLists.txt:
10:22 PM Changeset in webkit [120280] by commit-queue@webkit.org
  • 5 edits in trunk

Source/WebCore: Touched CSSPropertyNames.in to trigger a proper rebuild

[CSS Regions] Adding feature defines for CSS Regions & exclusions for Windows
​https://bugs.webkit.org/show_bug.cgi?id=88645

Patch by Mihai Balan <​mibalan@adobe.com> on 2012-06-13
Reviewed by Sam Weinig.

Previous work on #87442 added feature defines to allow proper disabling of CSS Regions and
exclusions (previously even with the feature disabled, parsing still worked). However, the
feature defines were enabled on Mac only - they were broken on Windows. This
patch adds the feature defines to (re)enable regions and exclusions on Windows.

  • css/CSSPropertyNames.in: Touched to trigger a proper rebuild. Incremental builds were broken on Windows.

WebKitLibraries: Fix for #88645 - enabling regions on Windows

[CSS Regions] Adding feature defines for CSS Regions & exclusions for Windows
​https://bugs.webkit.org/show_bug.cgi?id=88645

Patch by Mihai Balan <​mibalan@adobe.com> on 2012-06-13
Reviewed by Sam Weinig.

Previous work on #87442 added feature defines to allow proper disabling of CSS Regions and
exclusions (previously even with the feature disabled, parsing still worked). However, the
feature defines were enabled on Mac only - they were broken on Windows. This
patch adds the feature defines to (re)enable regions and exclusions on Windows.

  • win/tools/vsprops/FeatureDefines.vsprops: Added default value for ENABLE_CSS_EXCLUSIONS and ENABLE_CSS_REGIONS
  • win/tools/vsprops/FeatureDefinesCairo.vsprops: ditto
10:10 PM Changeset in webkit [120279] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebCore

make sure headers are included only once per file
​https://bugs.webkit.org/show_bug.cgi?id=88931

Patch by Arnaud Renevier <​arno@renevier.net> on 2012-06-13
Reviewed by Darin Adler.

  • Modules/indexeddb/IDBDatabase.cpp:
  • WebCorePrefix.h:
  • bindings/js/JSHTMLAllCollectionCustom.cpp:
  • bindings/v8/V8Utilities.cpp:
  • bindings/v8/custom/V8LocationCustom.cpp:
  • bridge/NP_jsobject.cpp:
  • editing/Editor.cpp:
  • html/HTMLMediaElement.cpp:
  • platform/graphics/cairo/PlatformContextCairo.cpp:
  • rendering/InlineFlowBox.cpp:
9:37 PM Changeset in webkit [120278] by commit-queue@webkit.org
  • 19 edits
    4 copies in trunk

[WK2] Add implementation for dispatchIntent in WebFrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=88340

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-13
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add implementation for dispatchIntent() in WebFrameLoaderClient.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Shared/API/c/WKBase.h:
  • Shared/APIClientTraits.h:
  • Shared/APIObject.h:
  • Shared/IntentData.cpp: Added.

(WebKit):
(WebKit::IntentData::encode):
(WebKit::IntentData::decode):

  • Shared/IntentData.h: Added.

(CoreIPC):
(WebKit):
(IntentData):

  • Target.pri:
  • UIProcess/API/C/WKAPICast.h:

(WebKit):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/gtk/WebKitLoaderClient.cpp:

(attachLoaderClientToView):

  • UIProcess/WebIntentData.cpp: Added.

(WebKit):
(WebKit::WebIntentData::WebIntentData):
(WebKit::WebIntentData::data):

  • UIProcess/WebIntentData.h: Added.

(WebKit):
(WebIntentData):
(WebKit::WebIntentData::create):
(WebKit::WebIntentData::~WebIntentData):
(WebKit::WebIntentData::action):
(WebKit::WebIntentData::payloadType):
(WebKit::WebIntentData::extras):
(WebKit::WebIntentData::suggestions):
(WebKit::WebIntentData::type):

  • UIProcess/WebLoaderClient.cpp:

(WebKit):
(WebKit::WebLoaderClient::didReceiveIntentForFrame):

  • UIProcess/WebLoaderClient.h:

(WebKit):
(WebLoaderClient):

  • UIProcess/WebPageProxy.cpp:

(WebKit):
(WebKit::WebPageProxy::didReceiveIntentForFrame):

  • UIProcess/WebPageProxy.h:

(WebKit):
(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchIntent):

Tools:

Update initialization of WKPageLoaderClient.

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

9:19 PM Changeset in webkit [120277] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Rename _swapView:with: to _replaceView:with:
​https://bugs.webkit.org/show_bug.cgi?id=89037

Reviewed by Darin Adler.

_swapView:with: is a misnomer - after calling it, the first view is no longer
contained within the view hierarchy. "Replace" is a more accurate term.

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController enterFullScreen:]):
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):
(-[WKFullScreenWindowController _replaceView:with:]):

9:18 PM Changeset in webkit [120276] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

Unreviewed typo fix.

  • platform/RefCountedSupplement.h:
9:12 PM Changeset in webkit [120275] by commit-queue@webkit.org
  • 42 edits
    3 deletes in trunk

Unreviewed, rolling out r120268.
​http://trac.webkit.org/changeset/120268
​https://bugs.webkit.org/show_bug.cgi?id=89060

WebCompositor::setPerTilePaintingEnabled hits an assertion in
DEBUG (Requested by dominicc|work on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-06-13

Source/Platform:

  • chromium/public/WebLayerTreeView.h:

(WebCore):
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):

Source/WebCore:

  • WebCore.gypi:
  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(WebCore::Settings::setPerTileDrawingEnabled):
(WebCore::Settings::perTileDrawingEnabled):
(Settings):
(WebCore::Settings::setPartialSwapEnabled):
(WebCore::Settings::partialSwapEnabled):
(WebCore::Settings::setThreadedAnimationEnabled):
(WebCore::Settings::threadedAnimationEnabled):

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::addAnimation):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateTileSizeAndTilingOption):

  • platform/graphics/chromium/cc/CCDebugRectHistory.cpp:

(WebCore::CCDebugRectHistory::enabled):
(WebCore::CCDebugRectHistory::saveDebugRectsForCurrentFrame):

  • platform/graphics/chromium/cc/CCDebugRectHistory.h:

(WebCore):
(CCDebugRectHistory):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::enabled):
(WebCore::CCHeadsUpDisplay::showPlatformLayerTree):
(WebCore::CCHeadsUpDisplay::showDebugRects):
(WebCore::CCHeadsUpDisplay::draw):
(WebCore::CCHeadsUpDisplay::drawHudContents):
(WebCore::CCHeadsUpDisplay::drawDebugRects):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h:

(WebCore):
(CCHeadsUpDisplay):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::create):
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::animateLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCSettings::CCSettings):
(CCSettings):
(CCLayerTreeHost):
(WebCore::CCLayerTreeHost::settings):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::create):
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::animateLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCRenderer.h:

(CCRendererClient):
(WebCore::CCRenderer::settings):

  • platform/graphics/chromium/cc/CCSettings.cpp: Removed.
  • platform/graphics/chromium/cc/CCSettings.h: Removed.
  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::setPerTileDrawingEnabled):
(WebCore):

  • testing/InternalSettings.h:

(InternalSettings):

Source/WebKit/chromium:

  • WebKit.gypi:
  • public/WebCompositor.h:

(WebCompositor):

  • public/WebSettings.h:
  • src/WebCompositorImpl.cpp:

(WebKit::WebCompositor::shutdown):

  • src/WebLayerTreeView.cpp:

(WebKit::WebLayerTreeView::Settings::operator CCSettings):

  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setPerTilePaintingEnabled):
(WebKit):
(WebKit::WebSettingsImpl::setPartialSwapEnabled):
(WebKit::WebSettingsImpl::setThreadedAnimationEnabled):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:
  • tests/CCTestCommon.h: Removed.
  • tests/CCThreadedTest.cpp:

(WebKitTests::MockLayerTreeHostImpl::create):
(WebKitTests::MockLayerTreeHostImpl::MockLayerTreeHostImpl):
(WebKitTests::MockLayerTreeHost::create):
(WebKitTests::MockLayerTreeHost::createLayerTreeHostImpl):
(WebKitTests::MockLayerTreeHost::MockLayerTreeHost):
(WebKitTests::CCThreadedTest::runTest):

  • tests/CCThreadedTest.h:

(CCThreadedTest):
(MockLayerTreeHostImpl):

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKitTests::MockLayerTreeHost::create):
(WebKitTests::MockLayerTreeHost::createLayerTreeHostImpl):
(WebKitTests::MockLayerTreeHost::MockLayerTreeHost):
(WebKitTests::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):

  • tests/LayerChromiumTest.cpp:
  • tests/LayerRendererChromiumTest.cpp:

(LayerRendererChromiumTest):
(TEST_F):
(TEST):

  • tests/TextureLayerChromiumTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:
  • tests/TreeSynchronizerTest.cpp:

(WebKitTests::TEST):

Tools:

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::applyTo):

9:08 PM Changeset in webkit [120274] by hbono@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Add WebFrame::replaceMisspelledRange
​https://bugs.webkit.org/show_bug.cgi?id=88618

Reviewed by Kent Tamura.

This change adds WebFrame::replaceMisspelledRange, which replaces the range of a
misspelled marker with text so Chromium can use it for replacing misspelled
words with suggetions.

  • public/WebFrame.h:

(WebFrame):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::replaceMisspelledRange):
(WebKit):

  • src/WebFrameImpl.h:

(WebFrameImpl):

8:57 PM Changeset in webkit [120273] by kinuko@chromium.org
  • 2 edits
    4 adds in trunk/LayoutTests

[Chromium] Unreviewed: Add rebaseline and update expectations.
​https://bugs.webkit.org/show_bug.cgi?id=87356

Patch by Eric Uhrhane <​ericu@chromium.org>

  • platform/chromium/fast/files/read-blob-async-expected.txt: Added.
  • platform/chromium/fast/files/workers/worker-read-blob-async-expected.txt: Added.
  • platform/chromium/fast/files/workers/worker-read-blob-sync-expected.txt: Added.
8:47 PM Changeset in webkit [120272] by timothy_horton@apple.com
  • 2 edits in trunk/Tools

REGRESSION (r120252): run-webkit-tests on Mac fails
​https://bugs.webkit.org/show_bug.cgi?id=89057

Reviewed by Dan Bernstein.

get_option will happily return None (the default only kicks in if
the option is actually *not set*). We should instead check get_option's
return value and default to "x86_64" architecture ourselves.

  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.init):

8:40 PM Changeset in webkit [120271] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed: Rebaseline for Mac

Rebaselining after r119893. There was a rebasline in r120221 but
it failed on Chromium WebKit waterfall and canaries after that, so
trying again.

  • platform/chromium-mac/fast/borders/border-antialiasing-expected.png:
8:28 PM Changeset in webkit [120270] by wangxianzhu@chromium.org
  • 3 edits
    1 copy
    1 move
    2 adds in trunk/Source/WebKit/chromium

[Chromium] Let Android and Linux share WebFontRendering decl/impl.
​https://bugs.webkit.org/show_bug.cgi?id=88802

Reviewed by Adam Barth.

  • WebKit.gyp:
  • public/linux/WebFontRendering.h: Temporarily forwards to the new file under linuxish.
  • public/linuxish: Added.
  • public/linuxish/WebFontRendering.h: Copied from chromium/public/linux/WebFontRendering.h.
  • src/linux/WebFontRendering.cpp: Removed.
  • src/linuxish: Added.
  • src/linuxish/WebFontRendering.cpp: Copied from chromium/src/linux/WebFontRendering.cpp.
8:22 PM Changeset in webkit [120269] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed: Update expectations
​https://bugs.webkit.org/show_bug.cgi?id=88949

http/tests/media/media-source/video-media-source-add-and-remove-ids.html
is flakily hitting an ASSERT on Chromium canaries.

  • platform/chromium/TestExpectations:
8:15 PM Changeset in webkit [120268] by commit-queue@webkit.org
  • 42 edits
    3 adds in trunk

[chromium] Certain settings in CCSettings could be global
​https://bugs.webkit.org/show_bug.cgi?id=88384

Patch by Ian Vollick <​vollick@chromium.org> on 2012-06-13
Reviewed by James Robinson.

Source/Platform:

  • chromium/public/WebLayerTreeView.h:

(WebCore):
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):

Source/WebCore:

No new tests. No new functionality.

  • WebCore.gypi:
  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:

(Settings):

  • platform/graphics/chromium/ContentLayerChromium.cpp:

(WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded):

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::addAnimation):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::initialize):

  • platform/graphics/chromium/TiledLayerChromium.cpp:

(WebCore::TiledLayerChromium::updateTileSizeAndTilingOption):

  • platform/graphics/chromium/cc/CCDebugRectHistory.cpp:

(WebCore::CCDebugRectHistory::enabled):
(WebCore::CCDebugRectHistory::saveDebugRectsForCurrentFrame):

  • platform/graphics/chromium/cc/CCDebugRectHistory.h:

(WebCore):
(CCDebugRectHistory):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:

(WebCore::CCHeadsUpDisplay::enabled):
(WebCore::CCHeadsUpDisplay::showPlatformLayerTree):
(WebCore::CCHeadsUpDisplay::showDebugRects):
(WebCore::CCHeadsUpDisplay::draw):
(WebCore::CCHeadsUpDisplay::drawHudContents):
(WebCore::CCHeadsUpDisplay::drawDebugRects):

  • platform/graphics/chromium/cc/CCHeadsUpDisplay.h:

(WebCore):
(CCHeadsUpDisplay):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::create):
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::animateLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(WebCore::CCLayerTreeSettings::CCLayerTreeSettings):
(CCLayerTreeSettings):
(CCLayerTreeHost):
(WebCore::CCLayerTreeHost::settings):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::create):
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::animateLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

  • platform/graphics/chromium/cc/CCRenderer.h:

(CCRendererClient):
(WebCore::CCRenderer::settings):

  • platform/graphics/chromium/cc/CCSettings.cpp: Added.

(WebCore):
(WebCore::CCSettings::perTilePaintingEnabled):
(WebCore::CCSettings::setPerTilePaintingEnabled):
(WebCore::CCSettings::partialSwapEnabled):
(WebCore::CCSettings::setPartialSwapEnabled):
(WebCore::CCSettings::acceleratedAnimationEnabled):
(WebCore::CCSettings::setAcceleratedAnimationEnabled):
(WebCore::CCSettings::reset):

  • platform/graphics/chromium/cc/CCSettings.h: Added.

(WebCore):
(CCSettings):

  • testing/InternalSettings.cpp:
  • testing/InternalSettings.h:

(InternalSettings):

Source/WebKit/chromium:

  • WebKit.gypi:
  • public/WebCompositor.h:

(WebCompositor):

  • public/WebSettings.h:
  • src/WebCompositorImpl.cpp:

(WebKit::WebCompositor::shutdown):
(WebKit):
(WebKit::WebCompositor::setPerTilePaintingEnabled):
(WebKit::WebCompositor::setPartialSwapEnabled):
(WebKit::WebCompositor::setAcceleratedAnimationEnabled):

  • src/WebLayerTreeView.cpp:

(WebKit):
(WebKit::WebLayerTreeView::Settings::operator CCLayerTreeSettings):

  • src/WebSettingsImpl.cpp:
  • src/WebSettingsImpl.h:

(WebSettingsImpl):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCLayerTreeHostTest.cpp:

(WTF):
(CCLayerTreeHostTestShortlived1):
(WTF::CCLayerTreeHostTestShortlived1::CCLayerTreeHostTestShortlived1):
(WTF::CCLayerTreeHostTestShortlived1::beginTest):
(WTF::CCLayerTreeHostTestShortlived1::afterTest):

  • tests/CCTestCommon.h: Added.

(WebKitTests):
(CCScopedSettings):
(WebKitTests::CCScopedSettings::CCScopedSettings):
(WebKitTests::CCScopedSettings::~CCScopedSettings):

  • tests/CCThreadedTest.cpp:

(WebKitTests::MockLayerTreeHostImpl::create):
(WebKitTests::MockLayerTreeHostImpl::MockLayerTreeHostImpl):
(WebKitTests::MockLayerTreeHost::create):
(WebKitTests::MockLayerTreeHost::createLayerTreeHostImpl):
(WebKitTests::MockLayerTreeHost::MockLayerTreeHost):
(WebKitTests::CCThreadedTest::runTest):

  • tests/CCThreadedTest.h:

(CCThreadedTest):
(MockLayerTreeHostImpl):

  • tests/GraphicsLayerChromiumTest.cpp:

(WebKitTests::MockLayerTreeHost::create):
(WebKitTests::MockLayerTreeHost::createLayerTreeHostImpl):
(WebKitTests::MockLayerTreeHost::MockLayerTreeHost):
(WebKitTests::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):

  • tests/LayerChromiumTest.cpp:
  • tests/LayerRendererChromiumTest.cpp:

(LayerRendererChromiumTest):
(TEST_F):
(TEST):

  • tests/TextureLayerChromiumTest.cpp:
  • tests/TiledLayerChromiumTest.cpp:
  • tests/TreeSynchronizerTest.cpp:

(WebKitTests::TEST):

Tools:

  • DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::applyTo):

7:36 PM Changeset in webkit [120267] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[BlackBerry] Apply New Style and JS for Select Popup
​https://bugs.webkit.org/show_bug.cgi?id=89020

Patch by Crystal Zhang <​haizhang@rim.com> on 2012-06-13
Reviewed by Rob Buis.

PR 162854

Source/WebCore:

Use new python script for data generating, as the old one is too simple and problematic.

  • PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

Use new styled CSS files for select popup, also remove most JS functions
to a separate JS file, only pass the parameters to JS, and use new python
script for data generating, as the old one is too simple and problematic.

  • WebCoreSupport/SelectPopupClient.cpp:

(WebCore::SelectPopupClient::generateHTML):

7:27 PM Changeset in webkit [120266] by danakj@chromium.org
  • 6 edits in trunk/Source

[chromium] Assert if iterating an invalid RenderSurfaceLayerList, where a layer in the list has no RenderSurface
​https://bugs.webkit.org/show_bug.cgi?id=89004

Reviewed by Adrienne Walker.

Source/WebCore:

A RenderSurfaceLayerList expects that all layers in the list own a
RenderSurface. If an invalid RSLL is iterated over, the
CCLayerIterator class will now ASSERT in debug mode, as well as
considering the list empty in release mode.

We will be adding code to CCLayerTreeHostImpl to save a RSLL across
frames, so adding a clearRenderSurfaces() method with a FIXME comment
to make it clear that we should clear the RSLL when we remove
RenderSurfaces from the layers in the saved RSLL.

  • platform/graphics/chromium/cc/CCLayerIterator.h:

(WebCore::CCLayerIterator::CCLayerIterator):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
(WebCore::clearRenderSurfacesOnCCLayerImplRecursive):
(WebCore::CCLayerTreeHostImpl::clearRenderSurfaces):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

Source/WebKit/chromium:

  • tests/CCLayerIteratorTest.cpp:
7:03 PM Changeset in webkit [120265] by yael.aharon@nokia.com
  • 4 edits in trunk/Source/WebCore

Remove redundant code from RenderView and RenderBlock
​https://bugs.webkit.org/show_bug.cgi?id=89019

Reviewed by Abhishek Arya.

As pointed out in ​https://bugs.webkit.org/show_bug.cgi?id=83981#c7 , RenderView::insertFixedPositionedObject()
is redundant and should be removed.
No new tests.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::insertPositionedObject):
(WebCore::RenderBlock::removePositionedObject):

  • rendering/RenderView.cpp:

(WebCore):

  • rendering/RenderView.h:

(RenderView):

5:40 PM Changeset in webkit [120264] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Address some feedbacks in layout test
​https://bugs.webkit.org/show_bug.cgi?id=88909

Patch by Min Qin <​qinmin@google.com> on 2012-06-13
Reviewed by Eric Carlson.

Fixed some comments in ​https://bugs.webkit.org/show_bug.cgi?id=88897.
Reduced the timeout to 100 ms and fixed the function definition.

  • media/no-autoplay-with-user-gesture-requirement.html:
5:38 PM Changeset in webkit [120263] by danakj@chromium.org
  • 9 edits
    2 adds in trunk/Source/WebCore

[chromium] Create a CCStreamVideoDrawQuad used for StreamTexture video output
​https://bugs.webkit.org/show_bug.cgi?id=88826

Reviewed by Adrienne Walker.

Remove the matrix from the CCVideoDrawQuad, and create a new quad
specifically for StreamTexture video decoder output. This quad
contains only the fields needed for display - textureId and the
matrix to be applied to texture coords.

Removes the (0, 0, 1, 1) "transform" from the shader used for these
quads, as it was a no-op.

No new tests, no change in behaviour.

  • WebCore.gypi:
  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawQuad):
(WebCore::LayerRendererChromium::drawStreamVideoQuad):
(WebCore::LayerRendererChromium::drawVideoQuad):

  • platform/graphics/chromium/LayerRendererChromium.h:

(WebCore):
(LayerRendererChromium):

  • platform/graphics/chromium/ShaderChromium.cpp:

(WebCore::VertexShaderVideoTransform::VertexShaderVideoTransform):
(WebCore::VertexShaderVideoTransform::init):
(WebCore::VertexShaderVideoTransform::getShaderString):

  • platform/graphics/chromium/ShaderChromium.h:

(VertexShaderVideoTransform):

  • platform/graphics/chromium/cc/CCDrawQuad.cpp:

(WebCore::CCDrawQuad::toStreamVideoDrawQuad):
(WebCore):

  • platform/graphics/chromium/cc/CCDrawQuad.h:

(WebCore):
(CCDrawQuad):

  • platform/graphics/chromium/cc/CCStreamVideoDrawQuad.cpp: Added.

(WebCore):
(WebCore::CCStreamVideoDrawQuad::create):
(WebCore::CCStreamVideoDrawQuad::CCStreamVideoDrawQuad):

  • platform/graphics/chromium/cc/CCStreamVideoDrawQuad.h: Added.

(WebCore):
(CCStreamVideoDrawQuad):
(WebCore::CCStreamVideoDrawQuad::textureId):
(WebCore::CCStreamVideoDrawQuad::matrix):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::appendQuads):

5:13 PM Changeset in webkit [120262] by Martin Robinson
  • 14 edits
    1 copy
    2 adds in trunk/Source

[GTK] Add an accelerated compositing implementation for WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=86037

Reviewed by Alejandro G. Castro.

Source/WebCore:

No new tests. These changes are covered by the compositing tests, which
we will gradually try to turn on for the bots.

Add a new GLContext method for getting to current default framebuffer size, which
is quite useful for preventing composited content quivering while resizing.

  • platform/graphics/cairo/GLContext.h:
  • platform/graphics/glx/GLContextGLX.cpp:

(WebCore::GLContextGLX::defaultFrameBufferSize): Added this implementation for X11
which asks the X server for the window size.

  • platform/graphics/glx/GLContextGLX.h:

Source/WebKit2:

Add an implementation of LayerTreeHost for GTK+ that uses TextureMapperGL.
Later this implementation will fall back to using the ImageBuffer TextureMapper.

  • GNUmakefile.am: Add new files to the compilation.
  • Shared/LayerTreeContext.h:

(LayerTreeContext): The GTK+ version of the LayerTreeContext just holds window handle.

  • Shared/gtk/LayerTreeContextGtk.cpp: Copied from Source/WebKit2/WebProcess/WebPage/LayerTreeHost.cpp.
  • WebProcess/WebPage/gtk/LayerTreeHostGtk.h: Added.
  • WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp: Added.

Add this LayerTreeHost implementation that just creates a GL context from the widget X11 window ID.
Later implementations might find a more cross-platform solution.

  • WebProcess/WebPage/gtk/WebPageGtk.cpp:

(WebKit::WebPage::platformInitialize): Initialize the native window handle to be zero.
(WebKit::WebPage::widgetMapped): When mapping the widget, try to get the native window
handle and send it to the WebProcess.

5:04 PM Changeset in webkit [120261] by shawnsingh@chromium.org
  • 7 edits in trunk/Source

[chromium] Implement hit-testing for impl-side input handling in accelerated compositor
​https://bugs.webkit.org/show_bug.cgi?id=88972

Reviewed by Adrienne Walker.

Source/WebCore:

The original hit testing code by Sami Kyostila.

This patch implements a simple impl-side hit-testing helper
function. At this time, the main motivation for this is so that
composited scrollable layers can be scrolled by the impl thread --
and a prerequisite for that is the ability to hit-test on the impl
thread, to determine where the scrolling action should be applied.

To implement the actual hit test, it's possible to compute the hit
test in two equivalent ways: (a) inverse-project the point into
local space, or (b) forward-transform the rect to screen space
It's not obvious which one would perform better, or which one
would be more robust to w < 0 homogeneous clipping issues. For
this patch, we simply opt for the inverse-projection approach.

10 unit tests added to CCLayerTreeHostCommonTest.cpp:

CCLayerTreeHostCommonTest.verifyHitTestingForEmptyLayerList
CCLayerTreeHostCommonTest.verifyHitTestingForSingleLayer
CCLayerTreeHostCommonTest.verifyHitTestingForSinglePositionedLayer
CCLayerTreeHostCommonTest.verifyHitTestingForSingleRotatedLayer
CCLayerTreeHostCommonTest.verifyHitTestingForSinglePerspectiveLayer
CCLayerTreeHostCommonTest.verifyHitTestingForSingleLayerWithScaledContents
CCLayerTreeHostCommonTest.verifyHitTestingForSimpleClippedLayer
CCLayerTreeHostCommonTest.verifyHitTestingForMultiClippedRotatedLayer
CCLayerTreeHostCommonTest.verifyHitTestingForMultipleLayers
CCLayerTreeHostCommonTest.verifyHitTestingForMultipleLayerLists

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::pointHitsRect):
(WebCore):
(WebCore::pointIsClippedBySurfaceOrClipRect):
(WebCore::CCLayerTreeHostCommon::findLayerThatIsHitByPoint):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:

(CCLayerTreeHostCommon):

  • platform/graphics/chromium/cc/CCMathUtil.cpp:

(WebCore::projectHomogeneousPoint):
(WebCore::mapHomogeneousPoint):
(WebCore::CCMathUtil::mapClippedRect):
(WebCore::CCMathUtil::projectClippedRect):
(WebCore::CCMathUtil::mapClippedQuad):
(WebCore::CCMathUtil::mapQuad):
(WebCore::CCMathUtil::projectPoint):
(WebCore):

  • platform/graphics/chromium/cc/CCMathUtil.h:

(WebCore):
(CCMathUtil):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostCommonTest.cpp:
4:50 PM WebKitGTK/WebKit2Roadmap edited by Martin Robinson
(diff)
4:47 PM WebKitGTK/WebKit2Roadmap edited by Martin Robinson
(diff)
4:40 PM Changeset in webkit [120260] by charles.wei@torchmobile.com.cn
  • 13 edits
    1 add in trunk/Source/WebCore

Need customized toDOMStringList for IndexedDB JSC binding.
​https://bugs.webkit.org/show_bug.cgi?id=87965

Reviewed by Kentaro Hara.

IndexedDB database interface uses DOMStringList as the input parameter.
The generated toDOMStringList() can't convert an JSArray of Strings to
native DOMStringList. We need a custom function to do this.

Because this patch adds one new file (JSDOMStringList.cpp), all build systems
are updated accordingly to pick up this file.

Tests: Corresponding bindings/scripts/test/JS files have been updated accordingly.

  • GNUmakefile.list.am:
  • Target.pri:
  • UseJSC.cmake:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSDOMStringListCustom.cpp: Added.

(WebCore):
(WebCore::toDOMStringList):

  • bindings/scripts/CodeGeneratorJS.pm:

(IndexGetterReturnsStrings):
(GenerateHeader):
(GetNativeType):
(GetNativeTypeForCallbacks):
(JSValueToNative):

  • bindings/scripts/test/JS/JSTestCallback.cpp:

(WebCore::JSTestCallback::callbackWithStringList):

  • bindings/scripts/test/JS/JSTestCallback.h:

(JSTestCallback):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionOverloadedMethod6):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod7):

  • dom/DOMStringList.idl:
4:33 PM Changeset in webkit [120259] by Lucas Forschler
  • 4 edits in branches/safari-536-branch/Source

Versioning.

4:30 PM Changeset in webkit [120258] by Lucas Forschler
  • 1 copy in tags/Safari-536.18

New Tag.

4:30 PM Changeset in webkit [120257] by jpfau@apple.com
  • 6 edits
    6 adds in trunk

Padding and borders can cause integer overflow in block layouts
​https://bugs.webkit.org/show_bug.cgi?id=88820
<rdar://problem/11328762>

Reviewed by Tony Chang.

Source/WebCore:

Tests: fast/block/block-size-integer-overflow.html

fast/flexbox/box-size-integer-overflow.html
fast/table/table-size-integer-overflow.html

  • rendering/AutoTableLayout.cpp: Decreased max int.

(WebCore::AutoTableLayout::computePreferredLogicalWidths):

  • rendering/FixedTableLayout.cpp: Use shared constant.

(WebCore::FixedTableLayout::computePreferredLogicalWidths):

  • rendering/RenderBlock.cpp: Removed unused constant.
  • rendering/TableLayout.h: Add shared constant.

(TableLayout):

LayoutTests:

  • fast/block/block-size-integer-overflow-expected.txt: Added.
  • fast/block/block-size-integer-overflow.html: Added.
  • fast/flexbox/box-size-integer-overflow-expected.txt: Added.
  • fast/flexbox/box-size-integer-overflow.html: Added.
  • fast/table/table-size-integer-overflow-expected.txt: Added.
  • fast/table/table-size-integer-overflow.html: Added.
4:25 PM Changeset in webkit [120256] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WTF

make sure headers are included only once per file
​https://bugs.webkit.org/show_bug.cgi?id=88929

Patch by Arnaud Renevier <​arno@renevier.net> on 2012-06-13
Reviewed by Kentaro Hara.

  • wtf/FastMalloc.cpp:
  • wtf/MathExtras.h:
  • wtf/OSAllocator.h:
4:07 PM Changeset in webkit [120255] by commit-queue@webkit.org
  • 6 edits in trunk

Refactor WebGLFramebuffer to handle texture attachments
​https://bugs.webkit.org/show_bug.cgi?id=88697

Patch by Gregg Tavares <​gman@google.com> on 2012-06-13
Reviewed by Adrienne Walker.

In order to add support for depth textures WebGLFramebuffer
needed to be refactored to handle textures as attachments.

No new tests as no new functionality.

  • html/canvas/WebGLFramebuffer.cpp:

(WebCore::WebGLFramebuffer::WebGLAttachment::WebGLAttachment):
(WebCore):
(WebCore::WebGLFramebuffer::WebGLAttachment::~WebGLAttachment):
(WebCore::WebGLFramebuffer::WebGLFramebuffer):
(WebCore::WebGLFramebuffer::setAttachmentForBoundFramebuffer):
(WebCore::WebGLFramebuffer::attach):
(WebCore::WebGLFramebuffer::getAttachmentObject):
(WebCore::WebGLFramebuffer::getAttachment):
(WebCore::WebGLFramebuffer::removeAttachmentFromBoundFramebuffer):
(WebCore::WebGLFramebuffer::getColorBufferWidth):
(WebCore::WebGLFramebuffer::getColorBufferHeight):
(WebCore::WebGLFramebuffer::getColorBufferFormat):
(WebCore::WebGLFramebuffer::checkStatus):
(WebCore::WebGLFramebuffer::onAccess):
(WebCore::WebGLFramebuffer::hasStencilBuffer):
(WebCore::WebGLFramebuffer::deleteObjectImpl):
(WebCore::WebGLFramebuffer::initializeAttachments):

  • html/canvas/WebGLFramebuffer.h:

(WebGLAttachment):
(WebGLFramebuffer):

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::framebufferRenderbuffer):
(WebCore::WebGLRenderingContext::reattachDepthStencilAttachments):
(WebCore::WebGLRenderingContext::framebufferTexture2D):
(WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter):

  • html/canvas/WebGLRenderingContext.h:

(WebGLRenderingContext):

3:58 PM Changeset in webkit [120254] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Crash when WebViewImpl::setIsTransparent is called before the WebLayerTreeView has been initialized.
​https://bugs.webkit.org/show_bug.cgi?id=89013

Patch by David Reveman <​reveman@chromium.org> on 2012-06-13
Reviewed by James Robinson.

Add !m_layerTreeView.isNull() check to WebViewImpl::setIsTransparent.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsTransparent):

3:55 PM Changeset in webkit [120253] by dpranke@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed, expectations changes.

  • platform/chromium-win/http/tests/misc/location-replace-crossdomain-expected.txt:
  • platform/chromium/fast/events/constructors/speech-recognition-error-constructor-expected.txt: Added.
3:37 PM Changeset in webkit [120252] by dpranke@chromium.org
  • 7 edits in trunk/Tools

new-run-webkit-tests does not support --32-bit like ORWT did
​https://bugs.webkit.org/show_bug.cgi?id=71634

Reviewed by Ojan Vafai.

This patch adds support for 32-bit apple mac builds, adding the
--32-bit flag for compatibility with ORWT and fixing the port
architecture() definition to actually return the correct values.

  • Scripts/webkitpy/layout_tests/port/apple.py:

(ApplePort._generate_all_test_configurations):

  • Scripts/webkitpy/layout_tests/port/factory.py:

(port_options):

  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort):
(MacPort.init):
(MacPort._build_driver_flags):
(MacPort.setup_environ_for_server):

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:

(test_sample_process_throws_exception):
(test_32bit):
(test_32bit.run_script):
(test_64bit):
(test_64bit.run_script):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._build_driver):
(WebKitPort._build_driver_flags):

  • Scripts/webkitpy/layout_tests/port/win.py:

(WinPort):

2:59 PM Changeset in webkit [120251] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove return statement in void method
​https://bugs.webkit.org/show_bug.cgi?id=88998

Patch by Konrad Piascik <​kpiascik@rim.com> on 2012-06-13
Reviewed by Andreas Kling

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::collectStyleForAttribute):

2:44 PM Changeset in webkit [120250] by benjamin@webkit.org
  • 13 edits
    1 add in trunk/Source

Implement the simple constructors WTFURL's KURL
​https://bugs.webkit.org/show_bug.cgi?id=85724

Reviewed by Adam Barth.

Source/WebCore:

This patch implement the correct initialization of KURL from an absolute URL.
The URL correctness is also relaxed in order to have KURLWTFURL works similarily to KURL.

  • platform/KURLWTFURL.cpp:

(WebCore::KURL::KURL):
(WebCore::KURL::isValid):
(WebCore::KURL::string):
(WebCore::KURL::protocol):
(WebCore::KURL::host):
(WebCore::KURL::port): Fix a bug where invalidPortNumber was returned if no port was defined.
(WebCore::KURL::hasFragmentIdentifier):
(WebCore::KURL::fragmentIdentifier):
(WebCore::KURL::protocolIs):
(WebCore::KURL::removeFragmentIdentifier):
(WebCore):
(WebCore::KURL::print):

  • platform/cf/KURLCFNet.cpp:

(WebCore::KURL::KURL):
(WebCore::KURL::createCFURL):
(WebCore):

  • platform/mac/KURLMac.mm:

(WebCore::KURL::KURL):
(WebCore::KURL::createCFURL):
(WebCore):
Use the code of KURL to make the conversion from WTFURL to NSURL.

Source/WTF:

This patch extends WTFURL with:
-support basic debugging using print() methods
-parsing in the incomming string character set (8bits or 16bits)
-add a function for parsing of relative URL (but no implementation yet)

  • WTF.xcodeproj/project.pbxproj:
  • wtf/text/WTFString.h:

(String):

  • wtf/url/api/ParsedURL.cpp:

(WTF::ParsedURL::ParsedURL):
(WTF):
(WTF::ParsedURL::hasFragment): Add this method to query the framgent availability without
allocating a new String.
(WTF::ParsedURL::withoutFragment): This method is added to implement KURL::removeFragmentIdentifier() and
the parsing of empty relative URL (where we return the base without fragment).
(WTF::ParsedURL::print):

  • wtf/url/api/ParsedURL.h:

(ParsedURL):
(WTF::ParsedURL::spec):

  • wtf/url/api/URLString.h:

(URLString):

  • wtf/url/src/URLParser.h:

(WTF):
(URLParser):
(WTF::URLParser::parseURLWithBase):

  • wtf/url/src/URLSegments.cpp:

(WTF::URLSegments::length):
(WTF::URLSegments::charactersBefore):

  • wtf/url/src/URLSegments.h:

(URLSegments):
Change the boolean argument includeDelimiter in favor of an enum to improve readability.

2:35 PM Changeset in webkit [120249] by rniwa@webkit.org
  • 8 edits in trunk/Tools

Remove webkitpy code to support legacy test_expectations.txt files
​https://bugs.webkit.org/show_bug.cgi?id=89038

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.path_to_test_expectations_file):
(Port.expectations_dict):

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_uses_test_expectations_file):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(WebKitPortTest.test_path_to_test_expectations_file):
(test_test_expectations):

  • Scripts/webkitpy/style/checker.py:

(CheckerDispatcher.should_skip_without_warning):
(CheckerDispatcher._create_checker):

  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py:

(TestExpectationsTestCase._expect_port_for_expectations_path):

  • Scripts/webkitpy/tool/steps/commit.py:

(Commit._check_test_expectations):

  • Scripts/webkitpy/tool/steps/commit_unittest.py:

(CommitTest.test_check_test_expectations):

2:09 PM Changeset in webkit [120248] by scheib@chromium.org
  • 7 edits in trunk

Remove duplicate webkitpointerlockchange events when unlocking.
​https://bugs.webkit.org/show_bug.cgi?id=88917

Reviewed by Dimitri Glazkov.

Source/WebCore:

Subsequent patches adding the new API for entering and exiting
pointer lock would be burdened by handling multiple change events
when the lock target is changed. This change introduces
temporary code to suppress duplicate change events.

Existing tests simplified by removing the duplicate change events.

  • page/PointerLockController.cpp:

(WebCore::PointerLockController::requestPointerLock):
(WebCore::PointerLockController::didLosePointerLock):

  • page/PointerLockController.h:

(PointerLockController):

LayoutTests:

Part of a series of refactoring changes to update pointer lock API to
the fullscreen locking style. ​https://bugs.webkit.org/show_bug.cgi?id=84402

Tests simplified by removing the duplicate change events.

  • pointer-lock/lock-already-locked-expected.txt:
  • pointer-lock/pointerlockchange-pointerlockerror-events-expected.txt:
  • pointer-lock/pointerlockchange-pointerlockerror-events.html:
2:07 PM Changeset in webkit [120247] by dpranke@chromium.org
  • 6 edits in trunk/Tools

nrwt: remove port.test_expectations() and port.test_expectations_overrides()
​https://bugs.webkit.org/show_bug.cgi?id=88948

Reviewed by Ojan Vafai.

In the final patch of this run, we remove the
test_expectations() and test_expectation_overrides() methods
from the Port class - callers must now use just
expectations_dict().

Note that support for the cascade in new-run-webkit-tests is
complete but only Chromium uses it; webkit-patch
rebaseline-expectations still does not support updating entries
in any file other than the first expectations file, however.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.path_to_test_expectations_file):
(Port.uses_test_expectations_file):
(Port.expectations_files):

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_additional_expectations):

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumPortTest.test_expectations_files):

  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:

(TestGoogleChromePort.test_get_google_chrome_port):

  • Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

(test_test_expectations):
(test_legacy_test_expectations):

2:01 PM Changeset in webkit [120246] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Update range sliders rendering for volume and playback position of new Chrome video controls.
​https://bugs.webkit.org/show_bug.cgi?id=88623

Patch by Silvia Pfeiffer <​silviapf@chromium.org> on 2012-06-13
Reviewed by Eric Carlson.

No new tests, final patch will contain the rebaselined tests.

The Chrome video controls are receiving a visual update. This patch contains updates to the
rendering of the range sliders for the playback position and the volume. This includes the
creation of a shadowPseudoId to be able to style the range sliders via CSS, the rendering
of the slider background and the highlighted ranges.

  • css/mediaControlsChromium.css:

(input[type="range"]::-webkit-media-slider-container):
Adjust the styling of the slider container backgrounds.
(input[type="range"]::-webkit-media-slider-thumb):
Adjust the styling of the slider thumbs.

  • html/shadow/SliderThumbElement.cpp:

(WebCore::sliderThumbShadowPseudoId):
Add an accessor function for the slider thumb shadowPseudoId.
(WebCore::mediaSliderThumbShadowPseudoId):
Add an accessor function for the media slider thumb shadowPseudoId.
(WebCore::SliderThumbElement::shadowPseudoId):
Add a different CSS pseudo-class name to the media slider thumbs.
(WebCore::TrackLimiterElement::shadowPseudoId):
Add a different CSS pseudo-class name to the media slider thumbs.
(WebCore::SliderContainerElement::shadowPseudoId):
Add a different CSS pseudo-class name to the media slider background container.

  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::paintRoundedSliderBackground):
Add function to draw rounded background of sliders in a dark color.
(WebCore::paintSliderRangeHighlight):
Add function to draw a highlighted grey region on the sliders, which is rounded only at
its ends.
(WebCore::paintMediaSlider):
Update the background and buffered range renderings on the playback position slider by making
use of the new helper functions.
(WebCore::paintMediaVolumeSlider):
Update the background and buffered range renderings on the volume slider by making
use of the new helper functions.

1:56 PM Changeset in webkit [120245] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Source/WebCore

[BlackBerry] Update Select Popup's styling
​https://bugs.webkit.org/show_bug.cgi?id=89005

Patch by Christopher Hutten-Czapski <​chutten@rim.com> on 2012-06-13
Reviewed by Rob Buis.

Add in some nicely-styled CSS and JS for the BlackBerry port's <select>

  • Resources/blackberry/popupControlBlackBerry.css:

(body):
(.popup-area):
(.popup-area>:first-child):
(.popup-buttons):
(.popup-button-divider):
(.popup-button):
(.popup-button:active):
(.popup-button:first-child:active):
(.popup-button:last-child:active):
(.popup-button:only-child:active):

  • Resources/blackberry/selectControlBlackBerry.css: Added.

(.select-area):
(.select-area:last-child):
(.option):
(.optgroup:last-child):
(.selected):
(.optgroup):
(.optgroup .option):

  • Resources/blackberry/selectControlBlackBerry.js: Added.
1:53 PM Changeset in webkit [120244] by fpizlo@apple.com
  • 66 edits
    6 adds in trunk

DFG should be able to set watchpoints on global variables
​https://bugs.webkit.org/show_bug.cgi?id=88692

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

Rolling back in after fixing Windows build issues, and implementing
branchTest8 for the Qt port's strange assemblers.

This implements global variable constant folding by allowing the optimizing
compiler to set a "watchpoint" on globals that it wishes to constant fold.
If the watchpoint fires, then an OSR exit is forced by overwriting the
machine code that the optimizing compiler generated with a jump.

As such, this patch is adding quite a bit of stuff:

  • Jump replacement on those hardware targets supported by the optimizing JIT. It is now possible to patch in a jump instruction over any recorded watchpoint label. The jump must be "local" in the sense that it must be within the range of the largest jump distance supported by a one instruction jump.


  • WatchpointSets and Watchpoints. A Watchpoint is a doubly-linked list node that records the location where a jump must be inserted and the destination to which it should jump. Watchpoints can be added to a WatchpointSet. The WatchpointSet can be fired all at once, which plants all jumps. WatchpointSet also remembers if it had ever been invalidated, which allows for monotonicity: we typically don't want to optimize using watchpoints on something for which watchpoints had previously fired. The act of notifying a WatchpointSet has a trivial fast path in case no Watchpoints are registered (one-byte load+branch).


  • SpeculativeJIT::speculationWatchpoint(). It's like speculationCheck(), except that you don't have to emit branches. But, you need to know what WatchpointSet to add the resulting Watchpoint to. Not everything that you could write a speculationCheck() for will have a WatchpointSet that would get notified if the condition you were speculating against became invalid.


  • SymbolTableEntry now has the ability to refer to a WatchpointSet. It can do so without incurring any space overhead for those entries that don't have WatchpointSets.


  • The bytecode generator infers all global function variables to be watchable, and makes all stores perform the WatchpointSet's write check, and marks all loads as being potentially watchable (i.e. you can compile them to a watchpoint and a constant).


Put together, this allows for fully sleazy inlining of calls to globally
declared functions. The inline prologue will no longer contain the load of
the function, or any checks of the function you're calling. I.e. it's
pretty much like the kind of inlining you would see in Java or C++.
Furthermore, the watchpointing functionality is built to be fairly general,
and should allow setting watchpoints on all sorts of interesting things
in the future.

The sleazy inlining means that we will now sometimes inline in code paths
that have never executed. Previously, to inline we would have either had
to have executed the call (to read the call's inline cache) or have
executed the method check (to read the method check's inline cache). Now,
we might inline when the callee is a watched global variable. This
revealed some humorous bugs. First, constant folding disagreed with CFA
over what kinds of operations can clobber (example: code path A is dead
but stores a String into variable X, all other code paths store 0 into
X, and then you do CompareEq(X, 0) - CFA will say that this is a non-
clobbering constant, but constant folding thought it was clobbering
because it saw the String prediction). Second, inlining would crash if
the inline callee had not been compiled. This patch fixes both bugs,
since otherwise run-javascriptcore-tests would report regressions.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • assembler/ARMv7Assembler.h:

(ARMv7Assembler):
(JSC::ARMv7Assembler::ARMv7Assembler):
(JSC::ARMv7Assembler::labelForWatchpoint):
(JSC::ARMv7Assembler::label):
(JSC::ARMv7Assembler::replaceWithJump):
(JSC::ARMv7Assembler::maxJumpReplacementSize):

  • assembler/AbstractMacroAssembler.h:

(JSC):
(AbstractMacroAssembler):
(Label):
(JSC::AbstractMacroAssembler::watchpointLabel):
(JSC::AbstractMacroAssembler::readPointer):

  • assembler/AssemblerBuffer.h:
  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::branchTest8):
(MacroAssemblerARM):
(JSC::MacroAssemblerARM::replaceWithJump):
(JSC::MacroAssemblerARM::maxJumpReplacementSize):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::load8Signed):
(JSC::MacroAssemblerARMv7::load16Signed):
(MacroAssemblerARMv7):
(JSC::MacroAssemblerARMv7::replaceWithJump):
(JSC::MacroAssemblerARMv7::maxJumpReplacementSize):
(JSC::MacroAssemblerARMv7::branchTest8):
(JSC::MacroAssemblerARMv7::jump):
(JSC::MacroAssemblerARMv7::makeBranch):

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::branchTest8):
(MacroAssemblerMIPS):
(JSC::MacroAssemblerMIPS::replaceWithJump):
(JSC::MacroAssemblerMIPS::maxJumpReplacementSize):

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::branchTest8):
(MacroAssemblerSH4):
(JSC::MacroAssemblerSH4::replaceWithJump):
(JSC::MacroAssemblerSH4::maxJumpReplacementSize):

  • assembler/MacroAssemblerX86.h:

(MacroAssemblerX86):
(JSC::MacroAssemblerX86::branchTest8):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::replaceWithJump):
(MacroAssemblerX86Common):
(JSC::MacroAssemblerX86Common::maxJumpReplacementSize):

  • assembler/MacroAssemblerX86_64.h:

(MacroAssemblerX86_64):
(JSC::MacroAssemblerX86_64::branchTest8):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::X86Assembler):
(X86Assembler):
(JSC::X86Assembler::cmpb_im):
(JSC::X86Assembler::testb_im):
(JSC::X86Assembler::labelForWatchpoint):
(JSC::X86Assembler::label):
(JSC::X86Assembler::replaceWithJump):
(JSC::X86Assembler::maxJumpReplacementSize):
(JSC::X86Assembler::X86InstructionFormatter::memoryModRM):

  • bytecode/CodeBlock.cpp:

(JSC):
(JSC::CodeBlock::printGetByIdCacheStatus):
(JSC::CodeBlock::dump):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::appendOSRExit):
(JSC::CodeBlock::appendSpeculationRecovery):
(CodeBlock):
(JSC::CodeBlock::appendWatchpoint):
(JSC::CodeBlock::numberOfWatchpoints):
(JSC::CodeBlock::watchpoint):
(DFGData):

  • bytecode/DFGExitProfile.h:

(JSC::DFG::exitKindToString):
(JSC::DFG::exitKindIsCountable):

  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeForChain):

  • bytecode/Instruction.h:

(Instruction):
(JSC::Instruction::Instruction):

  • bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

  • bytecode/Watchpoint.cpp: Added.

(JSC):
(JSC::Watchpoint::~Watchpoint):
(JSC::Watchpoint::correctLabels):
(JSC::Watchpoint::fire):
(JSC::WatchpointSet::WatchpointSet):
(JSC::WatchpointSet::~WatchpointSet):
(JSC::WatchpointSet::add):
(JSC::WatchpointSet::notifyWriteSlow):
(JSC::WatchpointSet::fireAllWatchpoints):

  • bytecode/Watchpoint.h: Added.

(JSC):
(Watchpoint):
(JSC::Watchpoint::Watchpoint):
(JSC::Watchpoint::setDestination):
(WatchpointSet):
(JSC::WatchpointSet::isStillValid):
(JSC::WatchpointSet::hasBeenInvalidated):
(JSC::WatchpointSet::startWatching):
(JSC::WatchpointSet::notifyWrite):
(JSC::WatchpointSet::addressOfIsWatched):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::ResolveResult::checkValidity):
(JSC::BytecodeGenerator::addGlobalVar):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::resolve):
(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveWithBase):
(JSC::BytecodeGenerator::emitResolveWithThis):
(JSC::BytecodeGenerator::emitGetStaticVar):
(JSC::BytecodeGenerator::emitPutStaticVar):

  • bytecompiler/BytecodeGenerator.h:

(BytecodeGenerator):

  • bytecompiler/NodesCodegen.cpp:

(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::PostfixResolveNode::emitBytecode):
(JSC::PrefixResolveNode::emitBytecode):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::AssignResolveNode::emitBytecode):
(JSC::ConstDeclNode::emitCodeSingle):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::clobberStructures):

  • dfg/DFGAbstractState.h:

(AbstractState):
(JSC::DFG::AbstractState::didClobber):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCCallHelpers.h:

(CCallHelpers):
(JSC::DFG::CCallHelpers::setupArguments):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::globalVarWatchpointElimination):
(CSEPhase):
(JSC::DFG::CSEPhase::globalVarStoreElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::run):

  • dfg/DFGCorrectableJumpPoint.h:

(JSC::DFG::CorrectableJumpPoint::isSet):
(CorrectableJumpPoint):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::link):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasIdentifierNumberForCheck):
(Node):
(JSC::DFG::Node::identifierNumberForCheck):
(JSC::DFG::Node::hasRegisterPointer):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::OSRExit):

  • dfg/DFGOSRExit.h:

(OSRExit):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):
(JSC::DFG::SpeculativeJIT::appendCall):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::speculationWatchpoint):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_put_global_var_check):
(JSC):
(JSC::JIT::emitSlow_op_put_global_var_check):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_put_global_var_check):
(JSC):
(JSC::JIT::emitSlow_op_put_global_var_check):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):
(JSC):

  • jit/JITStubs.h:
  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(LLInt):

  • llint/LLIntSlowPaths.h:

(LLInt):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/JSObject.cpp:

(JSC::JSObject::removeDirect):

  • runtime/JSObject.h:

(JSObject):

  • runtime/JSSymbolTableObject.h:

(JSC::symbolTableGet):
(JSC::symbolTablePut):
(JSC::symbolTablePutWithAttributes):

  • runtime/SymbolTable.cpp: Added.

(JSC):
(JSC::SymbolTableEntry::copySlow):
(JSC::SymbolTableEntry::freeFatEntrySlow):
(JSC::SymbolTableEntry::couldBeWatched):
(JSC::SymbolTableEntry::attemptToWatch):
(JSC::SymbolTableEntry::addressOfIsWatched):
(JSC::SymbolTableEntry::addWatchpoint):
(JSC::SymbolTableEntry::notifyWriteSlow):
(JSC::SymbolTableEntry::inflateSlow):

  • runtime/SymbolTable.h:

(JSC):
(SymbolTableEntry):
(Fast):
(JSC::SymbolTableEntry::Fast::Fast):
(JSC::SymbolTableEntry::Fast::isNull):
(JSC::SymbolTableEntry::Fast::getIndex):
(JSC::SymbolTableEntry::Fast::isReadOnly):
(JSC::SymbolTableEntry::Fast::getAttributes):
(JSC::SymbolTableEntry::Fast::isFat):
(JSC::SymbolTableEntry::SymbolTableEntry):
(JSC::SymbolTableEntry::~SymbolTableEntry):
(JSC::SymbolTableEntry::operator=):
(JSC::SymbolTableEntry::isNull):
(JSC::SymbolTableEntry::getIndex):
(JSC::SymbolTableEntry::getFast):
(JSC::SymbolTableEntry::getAttributes):
(JSC::SymbolTableEntry::isReadOnly):
(JSC::SymbolTableEntry::watchpointSet):
(JSC::SymbolTableEntry::notifyWrite):
(FatEntry):
(JSC::SymbolTableEntry::FatEntry::FatEntry):
(JSC::SymbolTableEntry::isFat):
(JSC::SymbolTableEntry::fatEntry):
(JSC::SymbolTableEntry::inflate):
(JSC::SymbolTableEntry::bits):
(JSC::SymbolTableEntry::freeFatEntry):
(JSC::SymbolTableEntry::pack):
(JSC::SymbolTableEntry::isValidIndex):

Source/WTF:

Reviewed by Geoffrey Garen.

Added ability to set the inline capacity of segmented vectors.

Also added the ability ot ASSERT_NOT_REACHED() without having to
propagate NO_RETURN macros, which would be a show-stopper for code
that is conditionally unreachable.

  • wtf/Assertions.h:

(UNREACHABLE_FOR_PLATFORM):

  • wtf/SegmentedVector.h:

(WTF):
(SegmentedVectorIterator):
(WTF::SegmentedVectorIterator::operator=):
(WTF::SegmentedVectorIterator::SegmentedVectorIterator):
(SegmentedVector):

LayoutTests:

Rubber stamped by Geoffrey Garen.

Added a test for watchpoints. Also updated the jsc-test-list to include the latest
tests.

  • fast/js/dfg-call-function-hit-watchpoint-expected.txt: Added.
  • fast/js/dfg-call-function-hit-watchpoint.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-call-function-hit-watchpoint.js: Added.

(foo):
(bar):
(.foo):

1:43 PM Changeset in webkit [120243] by dpranke@chromium.org
  • 3 edits in trunk/Tools

nrwt: implement the actual cascade of TestExpectations
​https://bugs.webkit.org/show_bug.cgi?id=88947

Reviewed by Ojan Vafai.

This change implements the actual cascade by removing the
concept of 'overrides' from the TestExpectations object and
parsing each file separately.

There is an actual semantic change in this patch, in that
setting an expectation on a directory in one file will override
the expectations on any individual tests set in prior files. The
test_overridesdirectory() unit test verifies this.

Otherwise, this patch mostly consists of deleting code :).

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationsModel.init):
(TestExpectationsModel.add_expectation_line):
(TestExpectationsModel._add_test):
(TestExpectationsModel._already_seen_better_match):
(TestExpectations.init):
(TestExpectations._add_expectations):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(test_overridesdirectory):

1:37 PM Changeset in webkit [120242] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening after r120228, fix an incorrect test expectation.

  • platform/gtk/TestExpectations:
1:29 PM Changeset in webkit [120241] by commit-queue@webkit.org
  • 8 edits
    4 adds in trunk

[V8] IndexedDB: Cursor value modifications should be preserved until cursor iterates
​https://bugs.webkit.org/show_bug.cgi?id=83526

Patch by Alec Flett <​alecflett@chromium.org> on 2012-06-13
Reviewed by Kentaro Hara.

Source/WebCore:

Cache the 'value' attribute of IDBCursorWithValue with policy
determined by IDBCursor.cpp, to follow spec behavior of keeping a
consistent script object until the cursor advances. See
​http://www.w3.org/TR/IndexedDB/#widl-IDBCursorWithValueSync-value
for details.

Test: storage/indexeddb/cursor-value.html

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::IDBCursor):
(WebCore::IDBCursor::value):
(WebCore::IDBCursor::setValueReady):

  • Modules/indexeddb/IDBCursor.h:

(IDBCursor):
(WebCore::IDBCursor::valueIsDirty):

  • Modules/indexeddb/IDBCursorWithValue.idl:
  • WebCore.gypi:
  • bindings/v8/IDBCustomBindings.cpp: Added.

(WebCore):
(WebCore::V8IDBCursorWithValue::valueAccessorGetter):

LayoutTests:

  • storage/indexeddb/cursor-value-expected.txt: Added.
  • storage/indexeddb/cursor-value.html: Added.
  • storage/indexeddb/resources/cursor-value.js: Added.

(openDatabase.request.onsuccess.request.onsuccess):
(openDatabase.request.onsuccess):
(openDatabase):
(testCursor.request.onsuccess):
(testCursor):
(ensureModificationsNotPersisted.request.onsuccess):
(ensureModificationsNotPersisted):

1:14 PM Changeset in webkit [120240] by dpranke@chromium.org
  • 6 edits in trunk/Tools

webkitpy: update callers to use port.expectation_dict() instead of test_expectations() and test_expectations_overrides()
​https://bugs.webkit.org/show_bug.cgi?id=88946

Reviewed by Ojan Vafai.

In preparation for fully supporting cascading expectations files
and removing the 'overrides' concept.

There should be no functional changes in this patch.

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ManagerTest.test_update_summary_with_result):
(ResultSummaryTest.get_result_summary):

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations.init):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(parse_exp):
(SkippedTests.check):
(RemoveConfigurationsTest.test_remove):
(test_remove_line):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(LintTest.test_all_configurations.FakePort.init):
(LintTest.test_all_configurations.FakePort.expectations_dict):
(LintTest.test_lint_test_fileserrors):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(test_overrides_are_included_correctly):

1:04 PM Changeset in webkit [120239] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Code cleanup from bug 88881 to share the SliderVerticalPart code.
​https://bugs.webkit.org/show_bug.cgi?id=88930

Patch by Silvia Pfeiffer <​silviapf@chromium.org> on 2012-06-13
Reviewed by Eric Carlson.

No new tests - this is just code cleanup.

  • html/shadow/SliderThumbElement.cpp:

(WebCore::hasVerticalAppearance):
Avoid having two ifdef-ed returns in the code depending on ENABLE(VIDEO).

12:46 PM Changeset in webkit [120238] by dpranke@chromium.org
  • 2 edits in trunk/Tools

webkitpy: rework the TestExpectations style checker in preparation for the cascade
​https://bugs.webkit.org/show_bug.cgi?id=88945

Reviewed by Ojan Vafai.

This patch changes the style checker to call the
TestExpectations parser directly and be oblivious as to what the
port's actual expectations are.

  • Scripts/webkitpy/style/checkers/test_expectations.py:

(TestExpectationsChecker.init):
(TestExpectationsChecker.check_test_expectations):

12:45 PM Changeset in webkit [120237] by Csaba Osztrogonác
  • 2 edits
    1 move
    1 add
    1 delete in trunk/LayoutTests

REGRESSION(r120108): It made http/tests/loading/gmail-assert-on-load.html fail
​https://bugs.webkit.org/show_bug.cgi?id=88923

Patch by Shrey Banga <​banga@chromium.org> on 2012-06-13
Reviewed by Csaba Osztrogonác.

  • http/tests/loading/gmail-assert-on-load-expected.txt: Removed.
  • http/tests/misc/gmail-assert-on-load-expected.txt: Added.
  • http/tests/misc/gmail-assert-on-load.html: Renamed from LayoutTests/http/tests/loading/gmail-assert-on-load.html.

All tests in http/tests/loading dump frame load events, which are not
consistent or relevant for this test. So it had to be moved out of
http/tests/loading.

  • platform/qt/Skipped: This test can be unskipped now
12:40 PM Changeset in webkit [120236] by dpranke@chromium.org
  • 11 edits in trunk/Tools

nrwt: restructure the port classes to handle multiple expectations files
​https://bugs.webkit.org/show_bug.cgi?id=88944

Reviewed by Ojan Vafai.

This patch restructures the Port classes so that each port
returns a list of TestExpectations files to be used (in a new, public,
expectations_files() method), and the base implementation rolls them
up into the ordered expectations_dict(), which becomes a public
method.

port.path_to_test_expectations_file(), port.test_expectations(),
and port.test_expectations_overrides() are then reimplemented as
wrappers around port.expectations_dict().
port.test_expectations() and port.test_expectations_overrides()
will eventually be removed when the cascade is fully completed,
and port.path_to_test_expectations_file() will be removed when
the rebaselining tool supports the cascade
(expectations_files() may also become private at that point).

There should be no functional changes in this patch, but a bunch
of custom logic gets deleted!

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.expectations_dict):
(Port):
(Port.expectations_files):
(Port.test_expectations):
(Port.test_expectations_overrides):

  • Scripts/webkitpy/layout_tests/port/base_unittest.py:

(PortTest.test_additional_expectations):
(PortTest.test_uses_test_expectations_file):

  • Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort.all_baseline_variants):
(ChromiumPort.expectations_files):

  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

(ChromiumPortTest.test_overrides_and_builder_names):

  • Scripts/webkitpy/layout_tests/port/google_chrome.py:

(_expectations_files):
(GoogleChromeLinux32Port.expectations_files):
(GoogleChromeLinux64Port.expectations_files):
(GoogleChromeMacPort.expectations_files):
(GoogleChromeWinPort.expectations_files):

  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:

(TestGoogleChromePort._verify_expectations_overrides):

  • Scripts/webkitpy/layout_tests/port/port_testcase.py:

(PortTestCase.test_expectations_ordering):

  • Scripts/webkitpy/layout_tests/port/webkit.py:

(WebKitPort._skipped_file_search_paths):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaseline.test_rebaseline_updates_expectations_file_noop):
(test_rebaseline_updates_expectations_file):
(test_rebaseline_does_not_include_overrides):
(test_rebaseline_expectations):
(test_overrides_are_included_correctly):

12:28 PM Changeset in webkit [120235] by bfulgham@webkit.org
  • 3 edits in trunk/Tools

[WinCairo] Update URL of WinCairoRequirements.zip download.
​https://bugs.webkit.org/show_bug.cgi?id=89009

Reviewed by Martin Robinson.

  • Tools/Scripts/update-webkit-dependency: Put fallback code

to download a "last update" time from servers that don't properly
report Last-Modified in their HTTP header.

  • Tools/Scripts/update-webkit-wincairo-libs: Change download link

for the WinCairo build requirements bundle.

12:21 PM Changeset in webkit [120234] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium mac] Don't include things in subframeworks of
ApplicationServices.framework.

A CoreText #include (with quotes instead of brackets, even) sprung up
in r120506, bug 69826.

​https://bugs.webkit.org/show_bug.cgi?id=88569

Patch by Mark Mentovai <​mark@chromium.org> on 2012-06-13
Reviewed by Stephen White.

No new tests.

  • platform/graphics/harfbuzz/ng/HarfBuzzFaceCoreText.cpp:
12:09 PM Changeset in webkit [120233] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] ASSERT(m_rawAttributes.initialScale > 0) in QtViewportHandler::initialRect()
​https://bugs.webkit.org/show_bug.cgi?id=89026

Reviewed by Csaba Osztrogonác.

Only act on viewport attribute changes if the layout size is valid.

  • UIProcess/qt/QtViewportHandler.cpp:

(WebKit::QtViewportHandler::setInitialScaleIfNeeded):
(WebKit::QtViewportHandler::viewportAttributesChanged):

12:08 PM Changeset in webkit [120232] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

REGRESSION (r120204-r120206): 37 fast/profiler tests failing on GTK Linux 64-bit Release
​https://bugs.webkit.org/show_bug.cgi?id=89006

Patch by Vineet Chaudhary <Vineet> on 2012-06-13
Reviewed by Enrica Casucci.

  • fast/profiler/nested-start-and-stop-profiler-expected.txt:
  • fast/profiler/resources/profiler-test-JS-resources.js:

(printProfileNodeWithoutTime): change childern to children()

12:00 PM Changeset in webkit [120231] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WinCairo] Build fix after Windows export definition file change.

  • win/WebKit2CFLite.def: Add missing symbol exports.
11:50 AM Changeset in webkit [120230] by dpranke@chromium.org
  • 5 edits in trunk/Tools

nrwt: preliminary cleanup before supporting cascading expectations files
​https://bugs.webkit.org/show_bug.cgi?id=88942

Reviewed by Ojan Vafai.

This change just prepares the TestExpectations parser to get filenames
along with the expectations, and improves the warning messages so that
they contain the filenames along with the line numbers.

There should be no functional changes in this patch.

  • Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:

(TestExpectationEditorTests.make_parsed_expectation_lines):

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationParser.parse):
(TestExpectationParser.expectation_for_skipped_test):
(TestExpectationParser._tokenize):
(TestExpectationParser._tokenize_list):
(TestExpectationLine):
(TestExpectationsModel.init):
(TestExpectationsModel._already_seen_better_match):
(TestExpectations.init):
(TestExpectations._shorten_filename):
(TestExpectations._report_warnings):
(TestExpectations._add_skipped_tests):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(TestExpectationParserTests._tokenize):
(TestExpectationParserTests.test_tokenize_blank):
(TestExpectationParserTests.test_tokenize_missing_colon):
(TestExpectationParserTests.test_tokenize_extra_colon):
(TestExpectationParserTests.test_tokenize_empty_comment):
(TestExpectationParserTests.test_tokenize_comment):
(TestExpectationParserTests.test_tokenize_missing_equal):
(TestExpectationParserTests.test_tokenize_extra_equal):
(TestExpectationParserTests.test_tokenize_valid):
(TestExpectationParserTests.test_tokenize_valid_with_comment):
(TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
(TestExpectationParserTests.test_parse_empty_string):
(TestExpectationSerializerTests._tokenize):
(TestExpectationSerializerTests.assert_round_trip):
(TestExpectationSerializerTests.assert_list_round_trip):

  • Scripts/webkitpy/tool/servers/gardeningserver.py:

(GardeningExpectationsUpdater.update_expectations):

11:45 AM Changeset in webkit [120229] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Removing an extra HandleScope in V8Proxy::evaluateInIsolatedWorld
​https://bugs.webkit.org/show_bug.cgi?id=88451

Patch by Eriq Augustine <​eaugusti@chromium.org> on 2012-06-13
Reviewed by Adam Barth.

Any values retuned by the evaluation will get destroyed with the extra
HandleScope.

I was unable to cause a test failure, however this feature is tested by:
platform/chromium/http/tests/misc/execute-and-return-value.html

  • bindings/v8/V8Proxy.cpp:

(WebCore::V8Proxy::evaluateInIsolatedWorld):

11:21 AM Changeset in webkit [120228] by zandobersek@gmail.com
  • 8 edits in trunk

[Gtk] Enable link prefetch support in the developer builds
​https://bugs.webkit.org/show_bug.cgi?id=89011

Reviewed by Martin Robinson.

.:

Rather export an automake conditional than define a preprocessor
macro for enabling link prefetch support.

  • configure.ac:

Source/WebCore:

Handle the ENABLE_LINK_PREFETCH conditional in standard way.

No new tests - covered by existing link prefetch tests.

  • GNUmakefile.am:

Tools:

Enable the link prefetch support for Gtk by default in developer
builds.

  • Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Remove expectations for link prefetch tests that now pass and
recategorise a few failures that now fail due to missing
dumpResourceResponseMIMETypes implementation in DumpRenderTree.

  • platform/gtk/TestExpectations:
11:11 AM Changeset in webkit [120227] by abarth@webkit.org
  • 2 edits in branches/chromium/1132/Source/WebKit/chromium

Merge 120219 - [Chromium] WebFrameImpl::find doesn't work for searching from a selection.
​https://bugs.webkit.org/show_bug.cgi?id=88885

Patch by Martin Kosiba <​mkosiba@google.com> on 2012-06-13
Reviewed by Adam Barth.

Remember the active match not just until the seatchText changes but for the entire find session.

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::find):
(WebKit::WebFrameImpl::setFindEndstateFocusAndSelection):

TBR=​commit-queue@webkit.org
Review URL: ​https://chromiumcodereview.appspot.com/10541145

11:04 AM Changeset in webkit [120226] by wangxianzhu@chromium.org
  • 3 edits
    1 add
    2 deletes in trunk/Source/WebKit/chromium

Unreviewed, rolling out r120220.
​http://trac.webkit.org/changeset/120220
​https://bugs.webkit.org/show_bug.cgi?id=89021

The patch broke build Chromium Win Release (Requested by
wangxianzhu on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-06-13

  • WebKit.gyp:
  • public/linux/WebFontRendering.h:

(WebKit):
(WebFontRendering):

  • public/linuxish/WebFontRendering.h: Removed.
  • src/linux/WebFontRendering.cpp: Renamed from Source/WebKit/chromium/src/linuxish/WebFontRendering.cpp.

(WebKit):
(WebKit::WebFontRendering::setHinting):
(WebKit::WebFontRendering::setAntiAlias):
(WebKit::WebFontRendering::setSubpixelGlyphs):
(WebKit::WebFontRendering::setSubpixelRendering):
(WebKit::WebFontRendering::setSubpixelPositioning):
(WebKit::WebFontRendering::setLCDOrder):
(WebKit::WebFontRendering::setLCDOrientation):

10:56 AM Changeset in webkit [120225] by jchaffraix@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed flakiness removal.

  • platform/chromium/TestExpectations:

The test was improved as bug 52064 (which was fixed some time ago). The test isn't showing
up as flaky anymore so removing it.

10:36 AM Changeset in webkit [120224] by commit-queue@webkit.org
  • 16 edits in trunk/Source

Rename currentDeviceMotion to lastMotion in DeviceMotionClient
​https://bugs.webkit.org/show_bug.cgi?id=88854

Patch by Amy Ousterhout <​aousterh@chromium.org> on 2012-06-13
Reviewed by Adam Barth.

Rename the function currentDeviceMotion to lastMotion in DeviceMotionClient.
This makes it consistent with the similar function lastOrientation in DeviceOrientationClient.

Source/WebCore:

Just a rename, so does not require any new tests.

  • dom/DeviceMotionClient.h:

(DeviceMotionClient):

  • dom/DeviceMotionController.cpp:

(WebCore::DeviceMotionController::timerFired):
(WebCore::DeviceMotionController::addListener):

  • loader/EmptyClients.h:

(WebCore::EmptyDeviceMotionClient::lastMotion):

  • platform/qt/DeviceMotionClientQt.cpp:

(WebCore::DeviceMotionClientQt::lastMotion):

  • platform/qt/DeviceMotionClientQt.h:

(DeviceMotionClientQt):

  • platform/qt/DeviceMotionProviderQt.h:

(WebCore::DeviceMotionProviderQt::lastMotion):

Source/WebKit/blackberry:

  • WebCoreSupport/DeviceMotionClientBlackBerry.cpp:

(DeviceMotionClientBlackBerry::lastMotion):
(DeviceMotionClientBlackBerry::onMotion):

  • WebCoreSupport/DeviceMotionClientBlackBerry.h:

(DeviceMotionClientBlackBerry):

Source/WebKit/efl:

  • WebCoreSupport/DeviceMotionClientEfl.cpp:

(WebCore::DeviceMotionClientEfl::lastMotion):

  • WebCoreSupport/DeviceMotionClientEfl.h:

(DeviceMotionClientEfl):

Source/WebKit/gtk:

  • WebCoreSupport/DeviceMotionClientGtk.cpp:

(WebKit::DeviceMotionClientGtk::lastMotion):

  • WebCoreSupport/DeviceMotionClientGtk.h:

(DeviceMotionClientGtk):

10:32 AM Changeset in webkit [120223] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Breakpoint's _uiLocationRemoved() method is never called.
​https://bugs.webkit.org/show_bug.cgi?id=89003

Reviewed by Pavel Feldman.

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype.breakpointLocationsForUISourceCode):
(WebInspector.BreakpointManager.Breakpoint):
(WebInspector.BreakpointManager.Breakpoint.prototype._locationUpdated):
(WebInspector.BreakpointManager.Breakpoint.prototype._resetLocations):
(WebInspector.BreakpointManager.Breakpoint.prototype._fakeBreakpointAtPrimaryLocation):

  • inspector/front-end/FileSystemModel.js: Drive by compilation fix.

(WebInspector.FileSystemModel):

10:30 AM Changeset in webkit [120222] by dgrogan@chromium.org
  • 5 edits
    3 adds in trunk

IndexedDB: Add tests, an assert, and some comments around open/close/setVersion call sequencing
​https://bugs.webkit.org/show_bug.cgi?id=88829

Reviewed by Tony Chang.

Source/WebCore:

Test: storage/indexeddb/three-setversion-calls.html

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::processPendingCalls):

LayoutTests:

  • storage/indexeddb/factory-deletedatabase-interactions-expected.txt:
  • storage/indexeddb/resources/factory-deletedatabase-interactions.js:

(Connection.this.open.req.onsuccess.that.handle.onversionchange):
(Connection.this.open.req.onsuccess):
(Connection.this.open):
(test3):
(test4.runSteps.):
(test4):
(test4.):

  • storage/indexeddb/resources/three-setversion-calls.js: Added.

(test):
(openDBConnection):
(successHandler.return.trans.oncomplete):
(openSuccess1.deleteRequest.onsuccess):
(openSuccess1):

  • storage/indexeddb/three-setversion-calls-expected.txt: Added.
  • storage/indexeddb/three-setversion-calls.html: Added.
10:24 AM Changeset in webkit [120221] by leviw@chromium.org
  • 16 edits
    14 adds
    8 deletes in trunk/LayoutTests

Unreviewed Chromium test expectation update after r119893.

  • fast/multicol/nested-columns-expected.txt: Added.
  • fast/multicol/vertical-lr/nested-columns-expected.txt: Added.
  • platform/chromium-linux-x86/fast/borders: Removed.
  • platform/chromium-linux-x86/fast/multicol/vertical-rl: Added.
  • platform/chromium-linux-x86/fast/multicol/vertical-rl/nested-columns-expected.png: Added.
  • platform/chromium-linux/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-linux/fast/multicol/nested-columns-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-lr/nested-columns-expected.png:
  • platform/chromium-linux/fast/multicol/vertical-rl/nested-columns-expected.png:
  • platform/chromium-linux/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png: Added.
  • platform/chromium-linux/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.txt: Added.
  • platform/chromium-mac-leopard/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-mac-leopard/fast/multicol/nested-columns-expected.png:
  • platform/chromium-mac-leopard/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.txt: Removed.
  • platform/chromium-mac/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-mac/fast/multicol/nested-columns-expected.png:
  • platform/chromium-mac/fast/multicol/vertical-lr/nested-columns-expected.png:
  • platform/chromium-mac/fast/multicol/vertical-rl/nested-columns-expected.png:
  • platform/chromium-mac/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png: Added.
  • platform/chromium-mac/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.txt: Added.
  • platform/chromium-win-vista/fast/borders: Removed.
  • platform/chromium-win-vista/fast/multicol: Added.
  • platform/chromium-win-vista/fast/multicol/vertical-rl: Added.
  • platform/chromium-win-vista/fast/multicol/vertical-rl/nested-columns-expected.png: Added.
  • platform/chromium-win-xp/fast/borders: Removed.
  • platform/chromium-win/fast/borders/border-antialiasing-expected.png:
  • platform/chromium-win/fast/multicol/nested-columns-expected.png:
  • platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.png:
  • platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.png:
  • platform/chromium-win/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.png: Added.
  • platform/chromium-win/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.txt: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/fast/multicol/nested-columns-expected.txt: Removed.
  • platform/efl/fast/multicol/vertical-lr/nested-columns-expected.txt: Removed.
  • platform/gtk/fast/multicol/nested-columns-expected.txt: Removed.
  • platform/gtk/fast/multicol/vertical-lr/nested-columns-expected.txt: Removed.
10:09 AM Changeset in webkit [120220] by wangxianzhu@chromium.org
  • 3 edits
    1 copy
    1 move
    2 adds in trunk/Source/WebKit/chromium

[Chromium] Let Android and Linux share WebFontRendering decl/impl.
​https://bugs.webkit.org/show_bug.cgi?id=88802

Reviewed by Adam Barth.

  • WebKit.gyp:
  • public/linux/WebFontRendering.h: Temporarily forwards to the new file under linuxish.
  • public/linuxish: Added.
  • public/linuxish/WebFontRendering.h: Copied from chromium/public/linux/WebFontRendering.h.
  • src/linux/WebFontRendering.cpp: Removed.
  • src/linuxish: Added.
  • src/linuxish/WebFontRendering.cpp: Copied from chromium/src/linux/WebFontRendering.cpp.
9:41 AM Changeset in webkit [120219] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] WebFrameImpl::find doesn't work for searching from a selection.
​https://bugs.webkit.org/show_bug.cgi?id=88885

Patch by Martin Kosiba <​mkosiba@google.com> on 2012-06-13
Reviewed by Adam Barth.

Remember the active match not just until the seatchText changes but for the entire find session.

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::find):
(WebKit::WebFrameImpl::setFindEndstateFocusAndSelection):

9:38 AM Changeset in webkit [120218] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Fixed visible content rect lost during page-load
​https://bugs.webkit.org/show_bug.cgi?id=88991

Patch by Allan Sandfeld Jensen <​allan.jensen@nokia.com> on 2012-06-13
Reviewed by Kenneth Rohde Christiansen.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):

9:26 AM Changeset in webkit [120217] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Update buildbot master in autoinstaller to match build.webkit.org
​https://bugs.webkit.org/show_bug.cgi?id=88992

Reviewed by Adam Barth.

  • Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook._install_buildbot):

9:16 AM Changeset in webkit [120216] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Skip the isolated world tests for Gtk - the infrastructure is missing
and they take too long to fail by timing out, lengthening the bot cycles.

Rubber-stamped by Philippe Normand.

  • platform/gtk/TestExpectations:
9:13 AM Changeset in webkit [120215] by commit-queue@webkit.org
  • 19 edits
    4 deletes in trunk

Unreviewed, rolling out r120209.
​http://trac.webkit.org/changeset/120209
​https://bugs.webkit.org/show_bug.cgi?id=89007

Broke the WebKit2 mac build. (Requested by andersca on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-06-13

Source/WebKit2:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Shared/API/c/WKBase.h:
  • Shared/APIClientTraits.h:
  • Shared/APIObject.h:
  • Shared/IntentData.cpp: Removed.
  • Shared/IntentData.h: Removed.
  • Target.pri:
  • UIProcess/API/C/WKAPICast.h:

(WebKit):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/gtk/WebKitLoaderClient.cpp:

(attachLoaderClientToView):

  • UIProcess/WebIntentData.cpp: Removed.
  • UIProcess/WebIntentData.h: Removed.
  • UIProcess/WebLoaderClient.cpp:
  • UIProcess/WebLoaderClient.h:

(WebKit):
(WebLoaderClient):

  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:

(WebKit):
(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchIntent):

Tools:

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

8:35 AM Changeset in webkit [120214] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Errors when pending console messages are attached to JavaScriptSourceFrame.
​https://bugs.webkit.org/show_bug.cgi?id=88712

Reviewed by Pavel Feldman.

  • inspector/front-end/PresentationConsoleMessageHelper.js:

(WebInspector.PresentationConsoleMessageHelper):
(WebInspector.PresentationConsoleMessageHelper.prototype._addPendingConsoleMessage):
(WebInspector.PresentationConsoleMessageHelper.prototype._parsedScriptSource):

8:29 AM Changeset in webkit [120213] by peter@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Fix Clang build with USE(NATIVE_FULLSCREEN_VIDEO)=1
​https://bugs.webkit.org/show_bug.cgi?id=88987

Reviewed by Simon Hausmann.

The enterFullscreen method is declared as const by MediaPlayerPrivateInterface,
so this one should be declared as such as well.

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::enterFullscreen):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

8:15 AM Changeset in webkit [120212] by zoltan@webkit.org
  • 2 edits in trunk/Tools

check-webkit-style needs to respect Qt API coding style
​https://bugs.webkit.org/show_bug.cgi?id=88995

Reviewed by Csaba Osztrogonác.

Add -whitespace/declaration exception to Qt API files.

  • Scripts/webkitpy/style/checker.py:
8:14 AM Changeset in webkit [120211] by alexis.menard@openbossa.org
  • 9 edits in trunk/Source/WebKit2

Web Inspector: add a way to get the remote inspector url for a given page.
​https://bugs.webkit.org/show_bug.cgi?id=88902

Reviewed by Jocelyn Turcotte.

Expose the remote inspector url for a given page in the API. If you want
to create a web view and load directly the inspector for the page you want to inspect,
it helps to get the url as it is impossible to figure it out from the API layer.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewExperimental::remoteInspectorUrl):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/InspectorServer/WebInspectorServer.cpp:

(WebKit):
(WebKit::WebInspectorServer::inspectorUrlForPageID):

  • UIProcess/InspectorServer/WebInspectorServer.h:

(WebInspectorServer):

  • UIProcess/InspectorServer/WebSocketServer.cpp:

(WebKit::WebSocketServer::WebSocketServer):
(WebKit::WebSocketServer::listen):
(WebKit::WebSocketServer::close):

  • UIProcess/InspectorServer/WebSocketServer.h:

(WebKit::WebSocketServer::bindAddress):
(WebKit::WebSocketServer::port):
(WebKit::WebSocketServer::serverState):
(WebSocketServer):

  • UIProcess/InspectorServer/qt/WebInspectorServerQt.cpp:

(WebKit::remoteInspectorPagePath):
(WebKit):
(WebKit::WebInspectorServer::inspectorUrlForPageID):
(WebKit::WebInspectorServer::buildPageList):

  • UIProcess/WebInspectorProxy.h:

(WebKit::WebInspectorProxy::remoteInspectionPageID):

8:07 AM Changeset in webkit [120210] by zandobersek@gmail.com
  • 9 edits in trunk/LayoutTests

Unreviewed GTK gardening after r120100, r120167, r120173 and r120181.

  • fast/events/constructors/speech-recognition-error-constructor-expected.txt:
  • platform/gtk/editing/pasteboard/4641033-expected.txt:
  • platform/gtk/editing/selection/mixed-editability-1-expected.txt:
  • platform/gtk/editing/selection/paragraph-granularity-expected.txt:
  • platform/gtk/editing/selection/triple-click-in-pre-expected.txt:
  • platform/gtk/editing/selection/word-granularity-expected.txt:
  • platform/gtk/fast/multicol/span/clone-flexbox-expected.txt:
  • platform/gtk/http/tests/misc/location-replace-crossdomain-expected.txt:
8:05 AM Changeset in webkit [120209] by commit-queue@webkit.org
  • 19 edits
    4 copies in trunk

[WK2] Add implementation for dispatchIntent in WebFrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=88340

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-13
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add implementation for dispatchIntent() in WebFrameLoaderClient.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Shared/API/c/WKBase.h:
  • Shared/APIClientTraits.h:
  • Shared/APIObject.h:
  • Shared/IntentData.cpp: Added.

(WebKit):
(WebKit::IntentData::encode):
(WebKit::IntentData::decode):

  • Shared/IntentData.h: Added.

(CoreIPC):
(WebKit):
(IntentData):

  • Target.pri:
  • UIProcess/API/C/WKAPICast.h:

(WebKit):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/gtk/WebKitLoaderClient.cpp:

(attachLoaderClientToView):

  • UIProcess/WebIntentData.cpp: Added.

(WebKit):
(WebKit::WebIntentData::WebIntentData):
(WebKit::WebIntentData::data):

  • UIProcess/WebIntentData.h: Added.

(WebKit):
(WebIntentData):
(WebKit::WebIntentData::create):
(WebKit::WebIntentData::~WebIntentData):
(WebKit::WebIntentData::action):
(WebKit::WebIntentData::payloadType):
(WebKit::WebIntentData::extras):
(WebKit::WebIntentData::suggestions):
(WebKit::WebIntentData::type):

  • UIProcess/WebLoaderClient.cpp:

(WebKit):
(WebKit::WebLoaderClient::didReceiveIntentForFrame):

  • UIProcess/WebLoaderClient.h:

(WebKit):
(WebLoaderClient):

  • UIProcess/WebPageProxy.cpp:

(WebKit):
(WebKit::WebPageProxy::didReceiveIntentForFrame):

  • UIProcess/WebPageProxy.h:

(WebKit):
(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchIntent):

Tools:

Update initialization of WKPageLoaderClient.

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

8:03 AM Changeset in webkit [120208] by apavlov@chromium.org
  • 4 edits
    3 adds in trunk

Web Inspector: Support user attributes in DOMNode
​https://bugs.webkit.org/show_bug.cgi?id=88706

Reviewed by Pavel Feldman.

Source/WebCore:

This change allows clients to store arbitrary properties on DOMNodes and know if there are descendants
(and how many of them) having a certain property set.

Test: inspector/elements/user-attributes.html

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode.prototype._removeChild):
(WebInspector.DOMNode.prototype._updateChildUserPropertyCountsOnRemoval):
(WebInspector.DOMNode.prototype._updateDescendantUserPropertyCount):
(WebInspector.DOMNode.prototype.setUserProperty):
(WebInspector.DOMNode.prototype.removeUserProperty):
(WebInspector.DOMNode.prototype.getUserProperty):
(WebInspector.DOMNode.prototype.descendantUserPropertyCount):

LayoutTests:

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.dumpElementsTree.dumpMap):
(initialize_ElementTest.InspectorTest.dumpElementsTree.userPropertyDataDump):
(initialize_ElementTest.InspectorTest.dumpElementsTree.print):
(initialize_ElementTest.InspectorTest.dumpElementsTree):

  • inspector/elements/resources/user-properties.js: Added.

(test.step0):
(test.step1):
(test.step2):
(test):

  • inspector/elements/user-properties-expected.txt: Added.
  • inspector/elements/user-properties.html: Added.
8:01 AM Changeset in webkit [120207] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[Qt] Handle multiple held buttons in touch mocking.
​https://bugs.webkit.org/show_bug.cgi?id=88865

Patch by Allan Sandfeld Jensen <​allan.jensen@nokia.com> on 2012-06-13
Reviewed by Kenneth Rohde Christiansen.

Add handling for multiple held mouse-buttons in the appropiate places.
To do this last-pos and start-pos are now also read from the last recorded
touch-point instead from object-global variables.

  • MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::notify):
(MiniBrowserApplication::updateTouchPoint):

  • MiniBrowser/qt/MiniBrowserApplication.h:

(MiniBrowserApplication):

7:40 AM Changeset in webkit [120206] by commit-queue@webkit.org
  • 19 edits in trunk

REGRESSION:Bindings sequence<T> in Console.idl, Internals.idl and ScriptProfileNode.idl should be T[]
​https://bugs.webkit.org/show_bug.cgi?id=84863

Patch by Vineet Chaudhary <​vineet.chaudhary@motorola.com> on 2012-06-13
Reviewed by Kentaro Hara.

With reference to ​http://www.w3.org/TR/WebIDL/#idl-sequence
"Sequences must not be used as the type of an attribute, constant or exception field."
So we should use T[] instead of sequence<T>.

Source/WebCore:

Tests: bindings/scripts/test/TestObj.idl

fast/harness/user-preferred-language.html
inspector/profiler/cpu-profiler-profiling-without-inspector.html
media/track/track-language-preference.html

  • bindings/scripts/CodeGenerator.pm:

(GetSequenceType): Getter for getting sequence type.
(GetArrayType): Getter for getting array type.
(AssertNotSequenceType): Check sequences must not be used as the type of an attribute,
constant or exception field.

  • bindings/scripts/CodeGeneratorCPP.pm:

(SkipFunction): Exclude bindings code for type sequence.
(SkipAttribute): Check for sequences must not be used as the type of an attribute,
constant or exception field.
(AddIncludesForType): Exclude header inclusion code for type array/sequence.

  • bindings/scripts/CodeGeneratorGObject.pm:

(SkipAttribute): Check for sequences must not be used as the type of an attribute,
constant or exception field.
(SkipFunction): Exclude bindings code for type sequence.

  • bindings/scripts/CodeGeneratorJS.pm:

(AddIncludesForType): Exclude header inclusion code for type array/sequence.
(GenerateImplementation): Check for sequences must not be used as the type of an attribute,
constant or exception field.
(GetNativeType):
(JSValueToNative):
(NativeToJSValue):

  • bindings/scripts/CodeGeneratorObjC.pm:

(SkipFunction): Exclude bindings code for type sequence.
(SkipAttribute): Exclude bindings code for type array.
(AddForwardDeclarationsForType):
(AddIncludesForType):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GetNativeType):
(JSValueToNative):
(CreateCustomSignature):
(NativeToJSValue):

  • bindings/scripts/test/JS/JSTestObj.cpp: Updated code from run-bindings-tests.

(WebCore):
(WebCore::jsTestObjPrototypeFunctionMethodWithSequenceArg):

  • bindings/scripts/test/JS/JSTestObj.h: Updated code from run-bindings-tests.

(WebCore):

  • bindings/scripts/test/TestObj.idl: Tests.
  • bindings/scripts/test/V8/V8TestObj.cpp: Updated code from run-bindings-tests.

(TestObjV8Internal):
(WebCore::TestObjV8Internal::methodWithSequenceArgCallback):
(WebCore):

  • inspector/ScriptProfileNode.idl: Using sequence<T> for children().
  • page/Console.idl: Using Array[T] for profiles attribute.
  • testing/Internals.idl: Using sequence<T> for userPreferredLanguages().

LayoutTests:

  • fast/harness/user-preferred-language.html: Using getter and setter

for userPreferredLanguages.

  • inspector/profiler/cpu-profiler-profiling-without-inspector.html:

Use ScriptProfileNode.children as function.

  • media/track/track-language-preference-expected.txt:
  • media/track/track-language-preference.html: Using setter for

userPreferredLanguages.

7:39 AM Changeset in webkit [120205] by kbalazs@webkit.org
  • 4 edits
    2 adds in trunk/Source/WebKit2

[Qt][WK2] Scanning plugins blocks the UI for a long time
​https://bugs.webkit.org/show_bug.cgi?id=88535

Reviewed by Simon Hausmann.

Implement a persistent cache for the meta data of plugins.
This way the UI process will not block for too long when
it's time to scan the plugins (except the first time).
The cache is a json file stored in a standard hidden cache
directory.

  • Shared/qt/QtDefaultDataLocation.cpp: Added.

(WebKit):
(WebKit::defaultDataLocation):

  • Shared/qt/QtDefaultDataLocation.h: Added.

(WebKit):
Added a common helper for the path we use to
put stuff into.

  • Target.pri:
  • UIProcess/Plugins/qt/PluginProcessProxyQt.cpp:

(WebKit::cacheFile):
(WebKit):
(WebKit::readMetaDataFromCacheFile):
(WebKit::writeToCacheFile):
(WebKit::appendToCacheFile):
(WebKit::tryReadPluginMetaDataFromCacheFile):
(WebKit::PluginProcessProxy::scanPlugin):

  • UIProcess/qt/WebContextQt.cpp:
7:37 AM Changeset in webkit [120204] by kkristof@inf.u-szeged.hu
  • 7 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

Rebaseline updated tests to green Qt bots.

Patch by Zoltan Arvai <​zarvai@inf.u-szeged.hu> on 2012-06-13

  • platform/qt/editing/pasteboard/4641033-expected.txt:
  • platform/qt/editing/selection/mixed-editability-1-expected.txt:
  • platform/qt/editing/selection/paragraph-granularity-expected.txt:
  • platform/qt/editing/selection/triple-click-in-pre-expected.txt:
  • platform/qt/editing/selection/word-granularity-expected.txt:
  • platform/qt/http/tests/misc/location-replace-crossdomain-expected.txt:
7:27 AM Changeset in webkit [120203] by Simon Hausmann
  • 2 edits in trunk/Tools

[Qt] Make it possible to disable -Werror in production builds

Reviewed by Tor Arne Vestbø.

Don't do -Werror if build-webkit is called with --qmakearg=CONFIG+=production_build,
something qt5.git's qtwebkit.pri will soon do.

  • qmake/mkspecs/features/unix/default_post.prf:
7:22 AM Changeset in webkit [120202] by kenneth@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Do not set contents pos to the current position
​https://bugs.webkit.org/show_bug.cgi?id=88990

Reviewed by Laszlo Gombos.

This is basically an optimization but it also solves flickering
in some cases.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebView::setContentPos):

7:08 AM Changeset in webkit [120201] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/LayoutTests

[EFL][DRT] Gardening for a greener bot
​https://bugs.webkit.org/show_bug.cgi?id=88971

Unreviewed, EFL gardening.

Patch by Dominik Röttsches <​dominik.rottsches@intel.com> on 2012-06-13

  • platform/efl/TestExpectations:
  • platform/efl/fast/multicol/span/clone-flexbox-expected.txt: rebaselined after r120100.
  • platform/efl/http/tests/loading/gmail-assert-on-load-expected.txt: Added, we print more verbosely.
6:54 AM Changeset in webkit [120200] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[GTK][EFL] Skip http/tests/misc/redirect-to-about-blank.html
​https://bugs.webkit.org/show_bug.cgi?id=88962

Unreviewed gardening. Skip http/tests/misc/redirect-to-about-blank.html
for both EFL and GTK ports. The test is failing after r120145.

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-13

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
6:51 AM Changeset in webkit [120199] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Store and compare md5sum of jhbuild files to trigger cleaning Dependencies
​https://bugs.webkit.org/show_bug.cgi?id=85790

Patch by Dominik Röttsches <​dominik.rottsches@intel.com> on 2012-06-13
Reviewed by Gustavo Noronha Silva.

Add md5 checks for jhbuild configuration for EFL, reusing the gtk jhbuild related
code in webkitdirs.pm.

  • Scripts/webkitdirs.pm:

(jhbuildConfigurationChanged):
(saveJhbuildMd5):
(cleanJhbuild):
(buildAutotoolsProject):
(generateBuildSystemFromCMakeProject):

6:51 AM Changeset in webkit [120198] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening, clean up the crashing tests, either removing
their expectations completely or expanding them to avoid false 'newly-passing'
reports. Also split some expectations as some tests are failing differently in
debug and release builds.

  • platform/gtk/TestExpectations:
6:46 AM Changeset in webkit [120197] by haraken@chromium.org
  • 2 edits
    2 copies in branches/chromium/1132

Merge 117928 - REGRESSION r110315: Event handler throws TypeError for an input element with name="arguments"
​https://bugs.webkit.org/show_bug.cgi?id=86991

Reviewed by Ojan Vafai.

Source/WebCore:

Original Chromium bug: ​http://code.google.com/p/chromium/issues/detail?id=128723

Consider the following html:

<html><body><form>
<input type="hidden" name="arguments"></input>
<div onclick="onclicked()" id="divInsideForm">Click here</div>
</form></body>
<script>
function onclicked() {

alert("onclicked");

}
</script>
</html>

If we click "Click here", JavaScript throws "Uncaught TypeError: undefined has no properties".

This is a regression caused by r110315. V8LazyEventListener should not use
'arguments' to retrieve the execution contexts, since 'arguments' can be
shadowed by JavaScript.

This patch changes V8LazyEventListener so that it retrieves contexts
by this[2], this[1] and this[0].

Test: fast/forms/form-input-named-arguments.html

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

LayoutTests:

The added test checks whether an event handler is successfully invoked
for an input element with name="arguments".

  • fast/forms/form-input-named-arguments-expected.txt: Added.
  • fast/forms/form-input-named-arguments.html: Added.

TBR=​haraken@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/10532125

6:37 AM Changeset in webkit [120196] by Simon Hausmann
  • 11 edits in trunk/Source

[Qt] Remove dependency to QtScript for the Qt 5 build
​https://bugs.webkit.org/show_bug.cgi?id=88993

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Replace the use of QScriptEngine::ValueOwnership with an enum local
to the class where it is used (QtInstance).

  • Target.pri:
  • bindings/js/ScriptControllerQt.cpp:

(WebCore::ScriptController::createScriptInstanceForWidget):

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtInstance::QtInstance):
(JSC::Bindings::QtInstance::~QtInstance):
(JSC::Bindings::QtInstance::getQtInstance):

  • bridge/qt/qt_instance.h:

(QtInstance):
(JSC::Bindings::QtInstance::create):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertQVariantToValue):

  • bridge/qt/qt_runtime_qt4.cpp:

(JSC::Bindings::convertQVariantToValue):

Source/WebKit/qt:

When building against Qt 5, replace the use of QScriptEngine::ValueOwnership with
a (compatible) QWebFrame::ValueOwnership enum.

  • Api/qwebframe.cpp:

(qtSenderCallback):
(QWebFrame::addToJavaScriptWindowObject):

  • Api/qwebframe.h:
  • tests/qobjectbridge/tst_qobjectbridge.cpp:

(tst_QObjectBridge::arrayObjectEnumerable):
(tst_QObjectBridge::ownership):
(tst_QObjectBridge::qObjectWrapperWithSameIdentity):

6:11 AM Changeset in webkit [120195] by caio.oliveira@openbossa.org
  • 4 edits in trunk/Source/WebCore

[Qt] Save a JSGlobalContextRef instead of a JSContextRef in QtConnectionObject
​https://bugs.webkit.org/show_bug.cgi?id=88905

Make QtConnectionObject use JSContextGetGlobalContext and store the
JSGlobalContextRef. Previous code was working but saving JSContextRef was wrong in terms of
API.

There's an assumption that JSGlobalContextRef will outlive the connection objects, and
because of it no JSGlobalContextRetain/Release calls were added.

Reviewed by Noam Rosenthal.

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeConnectionMethod::call):
(JSC::Bindings::QtConnectionObject::QtConnectionObject):

  • bridge/qt/qt_runtime.h:

(QtConnectionObject):

  • bridge/qt/qt_runtime_qt4.cpp:

(JSC::Bindings::QtRuntimeConnectionMethod::call):
(JSC::Bindings::QtConnectionObject::QtConnectionObject):

6:04 AM Changeset in webkit [120194] by commit-queue@webkit.org
  • 8 edits in trunk

Add dpi to css3-images image-resolution
​https://bugs.webkit.org/show_bug.cgi?id=85439

Patch by David Barr <​davidbarr@chromium.org> on 2012-06-13
Reviewed by Tony Chang.

Source/WebCore:

No new tests; extended fast/css/image-resolution/image-resolution.html

  • css/CSSGrammar.y:
  • css/CSSParser.cpp:

(WebCore::CSSParser::validUnit):
(WebCore::CSSParser::createPrimitiveNumericValue):
(WebCore::unitFromString):
(WebCore::CSSParser::parseValidPrimitive):
(WebCore::CSSParser::detectNumberToken):

  • css/CSSPrimitiveValue.cpp:

(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::unitCategory):
(WebCore::conversionToCanonicalUnitsScaleFactor):
(WebCore::CSSPrimitiveValue::customCssText):
(WebCore::CSSPrimitiveValue::cloneForCSSOM):

  • css/CSSPrimitiveValue.h:

LayoutTests:

  • fast/css/image-resolution/image-resolution-expected.txt:
  • fast/css/image-resolution/image-resolution.html:
5:52 AM Changeset in webkit [120193] by qi.2.zhang@nokia.com
  • 7 edits
    3 adds in trunk

[Qt] Add configure test for zlib and set WTF_USE_ZLIB if found
​https://bugs.webkit.org/show_bug.cgi?id=88763

Tools:

Add configure test for zlib and set WTF_USE_ZLIB if found to enable websocket
extension.

Reviewed by Simon Hausmann.

  • qmake/config.tests/libzlib: Added.
  • qmake/config.tests/libzlib/libzlib.cpp: Added.

(main):

  • qmake/config.tests/libzlib/libzlib.pro: Added.
  • qmake/mkspecs/features/features.prf:
  • qmake/sync.profile:

LayoutTests:

Move failed websocket extension test case to qt-4.8 after enable it in qt5

Reviewed by Simon Hausmann.

  • platform/qt-4.8/Skipped:
  • platform/qt/Skipped:
5:48 AM Changeset in webkit [120192] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] http/tests/xmlhttprequest/origin-exact-matching.html can be unskipped
​https://bugs.webkit.org/show_bug.cgi?id=88960

Unreviewed EFL gardening.
http/tests/xmlhttprequest/origin-exact-matching.html can be
unskipped after r120107.

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-13

  • platform/efl/TestExpectations:
5:41 AM Changeset in webkit [120191] by commit-queue@webkit.org
  • 6 edits in trunk

FileAPI: type should be converted to be lower case in Blob constructor.
​https://bugs.webkit.org/show_bug.cgi?id=88696

Patch by Li Yin <​li.yin@intel.com> on 2012-06-13
Reviewed by Kentaro Hara.

Source/WebCore:

Spec: ​http://dev.w3.org/2006/webapi/FileAPI/#dfn-BlobPropertyBag
Spec: ​http://dev.w3.org/2006/webapi/FileAPI/#attributes-blob
The ASCII-encoded string in lower case representing the media type of the Blob.

Test: fast/files/blob-constructor.html

  • bindings/js/JSBlobCustom.cpp:

(WebCore::JSBlobConstructor::constructJSBlob):

  • bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCallback):

LayoutTests:

Spec: ​http://dev.w3.org/2006/webapi/FileAPI/#dfn-BlobPropertyBag
Add sub-test to track changing upper case into lower case of type in Blob constructor.

  • fast/files/blob-constructor-expected.txt:
  • fast/files/script-tests/blob-constructor.js:
5:34 AM Changeset in webkit [120190] by rniwa@webkit.org
  • 27 edits in trunk/LayoutTests

Fonts, fullscreen, gamepad, and html5lib tests should use testRunner instead of layoutTestController
​https://bugs.webkit.org/show_bug.cgi?id=88959

Reviewed by Darin Adler.

  • fonts/valid-standard-font.html:
  • fullscreen/anonymous-block-merge-crash.html:
  • fullscreen/full-screen-element-stack.html:
  • fullscreen/full-screen-frameset.html:
  • fullscreen/full-screen-iframe-zIndex.html:
  • fullscreen/full-screen-keyboard-disabled.html:
  • fullscreen/full-screen-keyboard-enabled.html:
  • fullscreen/full-screen-remove-ancestor-during-transition.html:
  • fullscreen/full-screen-remove-sibling.html:
  • fullscreen/full-screen-render-inline.html:
  • fullscreen/full-screen-request-rejected.html:
  • fullscreen/full-screen-request-removed.html:
  • fullscreen/full-screen-restrictions.html:
  • fullscreen/full-screen-stacking-context.html:
  • fullscreen/full-screen-test.js:

(runWithKeyDown):
(endTest):

  • fullscreen/full-screen-zIndex-after.html:
  • fullscreen/full-screen-zIndex.html:
  • fullscreen/non-ancestor-iframe.html:
  • fullscreen/parent-flow-inline-with-block-child.html:
  • fullscreen/video-controls-override.html:
  • html5lib/resources/runner.js:

(run):

  • html5lib/webkit-resumer.html:
  • platform/gtk/fonts/custom-font-missing-glyphs.html:
  • platform/gtk/fonts/font-face-with-complex-text.html:
  • platform/gtk/fonts/font-family-fallback.html:
  • platform/gtk/fonts/synthetic-oblique-positioning.html:
5:31 AM Changeset in webkit [120189] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip new failing tests.

  • platform/qt/Skipped:
5:28 AM Changeset in webkit [120188] by commit-queue@webkit.org
  • 12 edits
    6 adds in trunk

[BlackBerry] Enable MEDIA_STREAM by default
​https://bugs.webkit.org/show_bug.cgi?id=88849

Patch by Robin Cao <​robin.cao@torchmobile.com.cn> on 2012-06-13
Reviewed by Antonio Gomes.

.:

  • Source/cmake/OptionsBlackBerry.cmake:
  • Source/cmakeconfig.h.cmake:

Source/WebCore:

Covered by existing test cases.

  • CMakeLists.txt:
  • PlatformBlackBerry.cmake:
  • platform/mediastream/blackberry/DeprecatedPeerConnectionHandler.cpp: Added.

(WebCore):
(WebCore::DeprecatedPeerConnectionHandler::create):
(WebCore::DeprecatedPeerConnectionHandler::DeprecatedPeerConnectionHandler):
(WebCore::DeprecatedPeerConnectionHandler::~DeprecatedPeerConnectionHandler):
(WebCore::DeprecatedPeerConnectionHandler::produceInitialOffer):
(WebCore::DeprecatedPeerConnectionHandler::handleInitialOffer):
(WebCore::DeprecatedPeerConnectionHandler::processSDP):
(WebCore::DeprecatedPeerConnectionHandler::processPendingStreams):
(WebCore::DeprecatedPeerConnectionHandler::sendDataStreamMessage):
(WebCore::DeprecatedPeerConnectionHandler::stop):

  • platform/mediastream/blackberry/MediaStreamCenterBlackBerry.cpp: Added.

(WebCore):
(WebCore::MediaStreamCenter::instance):
(WebCore::MediaStreamCenterBlackBerry::MediaStreamCenterBlackBerry):
(WebCore::MediaStreamCenterBlackBerry::~MediaStreamCenterBlackBerry):
(WebCore::MediaStreamCenterBlackBerry::queryMediaStreamSources):
(WebCore::MediaStreamCenterBlackBerry::didSetMediaStreamTrackEnabled):
(WebCore::MediaStreamCenterBlackBerry::didStopLocalMediaStream):
(WebCore::MediaStreamCenterBlackBerry::didCreateMediaStream):
(WebCore::MediaStreamCenterBlackBerry::constructSDP):

  • platform/mediastream/blackberry/MediaStreamCenterBlackBerry.h: Added.

(WebCore):
(MediaStreamCenterBlackBerry):

Source/WebKit:

  • PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

  • WebCoreSupport/UserMediaClientImpl.cpp: Added.

(WebCore):
(WebCore::UserMediaClientImpl::UserMediaClientImpl):
(WebCore::UserMediaClientImpl::~UserMediaClientImpl):
(WebCore::UserMediaClientImpl::pageDestroyed):
(WebCore::UserMediaClientImpl::requestUserMedia):
(WebCore::UserMediaClientImpl::cancelUserMediaRequest):

  • WebCoreSupport/UserMediaClientImpl.h: Added.

(WebKit):
(WebCore):
(UserMediaClientImpl):

Tools:

  • Scripts/webkitperl/FeatureList.pm:
5:23 AM WebInspector edited by ojwbetts@gmail.com
remove spam (diff)
5:04 AM Changeset in webkit [120187] by sergio@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Removed some tests passing in all the GTK
bots from the test expectations file.

  • platform/gtk/TestExpectations:
4:51 AM Changeset in webkit [120186] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: working copy should be committed even if domain binding returns error.
​https://bugs.webkit.org/show_bug.cgi?id=88884

Reviewed by Vsevolod Vlasov.

Committing working copy is about saving file. It should always succeed.

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.commitWorkingCopy):

4:45 AM Changeset in webkit [120185] by pfeldman@chromium.org
  • 1 edit in trunk/Source/WebCore/ChangeLog

Web Inspector: show revisions of all modified files in local modifications view
​https://bugs.webkit.org/show_bug.cgi?id=88864

Reviewed by Vsevolod Vlasov.

This change allows all local modifications to be seen in a single view. View is now
singleton, listening to all revisions being added. Revert captions were reworked
(see the screenshot).

  • English.lproj/localizedStrings.js:
  • inspector/front-end/Resource.js:
  • inspector/front-end/RevisionHistoryView.js:

(WebInspector.RevisionHistoryView.populateRevisions):
(WebInspector.RevisionHistoryView):
(WebInspector.RevisionHistoryView.showHistory):
(WebInspector.RevisionHistoryView.reset):
(WebInspector.RevisionHistoryView.prototype._createResourceItem.clearHistory):
(WebInspector.RevisionHistoryView.prototype._createResourceItem):
(WebInspector.RevisionHistoryView.prototype._revisionAdded.get if):
(WebInspector.RevisionHistoryView.prototype._revisionAdded):
(WebInspector.RevisionHistoryView.prototype._revealResource.get if):
(WebInspector.RevisionHistoryView.prototype._revealResource):
(WebInspector.RevisionHistoryView.prototype._reset):
(WebInspector.RevisionHistoryTreeElement):
(WebInspector.RevisionHistoryTreeElement.prototype.onattach):
(WebInspector.RevisionHistoryTreeElement.prototype.oncollapse):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._reset):
(WebInspector.ScriptsPanel.prototype._editorSelected):

  • inspector/front-end/revisionHistory.css:

(.revision-history-link-row):
(.revision-history-drawer li.revision-history-revision):

4:38 AM Changeset in webkit [120184] by pfeldman@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Make "Go to source and line" possible with "go to file" dialog
​https://bugs.webkit.org/show_bug.cgi?id=88740

Reviewed by Vsevolod Vlasov.

Selection dialog now allows search query rewrite and uses line number
suffix to go to a particular line.

  • inspector/front-end/FilteredItemSelectionDialog.js:

(WebInspector.FilteredItemSelectionDialog.prototype.onEnter):
(WebInspector.FilteredItemSelectionDialog.prototype._createSearchRegExp):
(WebInspector.SelectionDialogContentProvider.prototype.selectItem):
(WebInspector.SelectionDialogContentProvider.prototype.rewriteQuery):
(WebInspector.JavaScriptOutlineDialog.prototype.selectItem):
(WebInspector.JavaScriptOutlineDialog.prototype.rewriteQuery):
(WebInspector.OpenResourceDialog.prototype.selectItem):
(WebInspector.OpenResourceDialog.prototype.rewriteQuery):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.showUISourceCode):

  • inspector/front-end/StylesPanel.js:

(WebInspector.StyleSheetOutlineDialog.prototype.selectItem):
(WebInspector.StyleSheetOutlineDialog.prototype.rewriteQuery):

4:31 AM Changeset in webkit [120183] by vestbo@webkit.org
  • 3 edits in trunk/Tools

Prevent stderr output from messing up detection of build path

​https://bugs.webkit.org/show_bug.cgi?id=88075

Warnings such as 'perl: warning: Setting locale failed' will otherwise
end up as the build path when calling out to webkit-build-directory.

Reviewed by Ojan Vafai.

  • Scripts/webkitpy/layout_tests/port/config.py:

(Config.build_directory):

4:27 AM Changeset in webkit [120182] by pfeldman@chromium.org
  • 5 edits in trunk

Web Inspector: Make "Go to source and line" possible with "go to file" dialog
​https://bugs.webkit.org/show_bug.cgi?id=88740

Reviewed by Vsevolod Vlasov.

Selection dialog now allows search query rewrite and uses line number
suffix to go to a particular line.

  • inspector/front-end/FilteredItemSelectionDialog.js:

(WebInspector.FilteredItemSelectionDialog.prototype.onEnter):
(WebInspector.FilteredItemSelectionDialog.prototype._createSearchRegExp):
(WebInspector.SelectionDialogContentProvider.prototype.selectItem):
(WebInspector.SelectionDialogContentProvider.prototype.rewriteQuery):
(WebInspector.JavaScriptOutlineDialog.prototype.selectItem):
(WebInspector.JavaScriptOutlineDialog.prototype.rewriteQuery):
(WebInspector.OpenResourceDialog.prototype.selectItem):
(WebInspector.OpenResourceDialog.prototype.rewriteQuery):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.showUISourceCode):

  • inspector/front-end/StylesPanel.js:

(WebInspector.StyleSheetOutlineDialog.prototype.selectItem):
(WebInspector.StyleSheetOutlineDialog.prototype.rewriteQuery):

3:48 AM Changeset in webkit [120181] by hans@chromium.org
  • 5 edits
    2 adds in trunk

Speech JavaScript API: Add test for constructing SpeechRecognitionError events
​https://bugs.webkit.org/show_bug.cgi?id=88868

Reviewed by Adam Barth.

Source/WebCore:

This adds a test for constructing SpeechRecognitionError events, and
code to make it work.

Test: fast/events/constructors/speech-recognition-error-constructor.html

  • Modules/speech/SpeechRecognitionError.cpp:

(WebCore::SpeechRecognitionError::create):
(WebCore):
(WebCore::SpeechRecognitionError::SpeechRecognitionError):
(WebCore::SpeechRecognitionErrorInit::SpeechRecognitionErrorInit):

  • Modules/speech/SpeechRecognitionError.h:

(SpeechRecognitionErrorInit):
(WebCore):
(SpeechRecognitionError):
(WebCore::SpeechRecognitionError::code):

  • Modules/speech/SpeechRecognitionError.idl:

LayoutTests:

Add a layout test for constructing SpeechRecognitionError events.

  • fast/events/constructors/speech-recognition-error-constructor-expected.txt: Added.
  • fast/events/constructors/speech-recognition-error-constructor.html: Added.
3:38 AM Changeset in webkit [120180] by rniwa@webkit.org
  • 24 edits in trunk/LayoutTests

Chromium rebaseline after r120173.

  • platform/chromium-linux/editing/pasteboard/4641033-expected.txt:
  • platform/chromium-linux/editing/selection/paragraph-granularity-expected.png:
  • platform/chromium-linux/editing/selection/triple-click-in-pre-expected.png:
  • platform/chromium-linux/editing/selection/word-granularity-expected.png:
  • platform/chromium-mac-leopard/editing/selection/paragraph-granularity-expected.png:
  • platform/chromium-mac-leopard/editing/selection/triple-click-in-pre-expected.png:
  • platform/chromium-mac-leopard/editing/selection/word-granularity-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/paragraph-granularity-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/triple-click-in-pre-expected.png:
  • platform/chromium-mac-snowleopard/editing/selection/word-granularity-expected.png:
  • platform/chromium-mac/editing/selection/paragraph-granularity-expected.png:
  • platform/chromium-mac/editing/selection/triple-click-in-pre-expected.png:
  • platform/chromium-mac/editing/selection/word-granularity-expected.png:
  • platform/chromium-win/editing/inserting/editable-html-element-expected.txt:
  • platform/chromium-win/editing/pasteboard/4641033-expected.png:
  • platform/chromium-win/editing/pasteboard/4641033-expected.txt:
  • platform/chromium-win/editing/selection/mixed-editability-1-expected.txt:
  • platform/chromium-win/editing/selection/paragraph-granularity-expected.png:
  • platform/chromium-win/editing/selection/paragraph-granularity-expected.txt:
  • platform/chromium-win/editing/selection/triple-click-in-pre-expected.png:
  • platform/chromium-win/editing/selection/triple-click-in-pre-expected.txt:
  • platform/chromium-win/editing/selection/word-granularity-expected.png:
  • platform/chromium-win/editing/selection/word-granularity-expected.txt:
3:28 AM Changeset in webkit [120179] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Fix a wrong rebaseline in r120178.

  • editing/pasteboard/file-input-files-access-expected.txt:
3:21 AM Changeset in webkit [120178] by rniwa@webkit.org
  • 14 edits in trunk

Tools: Update the builder name for Apple Lion builders.

  • Scripts/webkitpy/layout_tests/port/builders.py:

LayoutTests: Mac rebaseline after r120167 and r120173.

Also revert an inadvertent change to file.invalidext.

  • editing/pasteboard/file-input-files-access-expected.txt:
  • editing/pasteboard/paste-sanitize-crash-2-expected.txt:
  • editing/pasteboard/resources/file.invalidext:
  • editing/selection/blockquote-crash-expected.txt:
  • editing/style/4230923-expected.txt:
  • platform/mac/editing/pasteboard/4641033-expected.txt:
  • platform/mac/editing/selection/mixed-editability-1-expected.txt:
  • platform/mac/editing/selection/paragraph-granularity-expected.txt:
  • platform/mac/editing/selection/triple-click-in-pre-expected.txt:
  • platform/mac/editing/selection/word-granularity-expected.txt:
  • platform/mac/http/tests/misc/location-replace-crossdomain-expected.txt:
2:52 AM Changeset in webkit [120177] by commit-queue@webkit.org
  • 10 edits
    4 adds in trunk

Implement InspectorFileSystemAgent::readDirectory for FileSystem support.
​https://bugs.webkit.org/show_bug.cgi?id=87724

Patch by Taiju Tsuiki <​tzik@chromium.org> on 2012-06-13
Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: http/tests/inspector/filesystem/read-directory.html

  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorFileSystemAgent.cpp:

(InspectorFileSystemAgent::FrontendProvider):
(WebCore):
(WebCore::InspectorFileSystemAgent::create):
(WebCore::InspectorFileSystemAgent::readDirectory):
(WebCore::InspectorFileSystemAgent::InspectorFileSystemAgent):

  • inspector/InspectorFileSystemAgent.h:

(WebCore):
(InspectorFileSystemAgent):

LayoutTests:

  • http/tests/inspector/filesystem/filesystem-test.js: Added.
  • http/tests/inspector/filesystem/read-directory-expected.txt: Added.
  • http/tests/inspector/filesystem/read-directory.html: Added.
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
2:49 AM Changeset in webkit [120176] by rniwa@webkit.org
  • 1 edit
    2 copies in trunk/LayoutTests

Revert the removal of 2 editing tests in r120173.

  • editing/pasteboard/copy-paste-float.html: Copied from LayoutTests/editing/pasteboard/copy-paste-float.html.
  • platform/mac/editing/selection/word-thai.html: Copied from LayoutTests/platform/mac/editing/selection/word-thai.html.
2:38 AM Changeset in webkit [120175] by zandobersek@gmail.com
  • 63 edits
    6 deletes in trunk

Unreviewed, rolling out r120172.
​http://trac.webkit.org/changeset/120172
​https://bugs.webkit.org/show_bug.cgi?id=88976

The patch causes compilation failures on Gtk, Qt and Apple Win
bots (Requested by zdobersek on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-06-13

Source/JavaScriptCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::nop):
(JSC::ARMv7Assembler::label):
(JSC::ARMv7Assembler::readPointer):
(ARMv7Assembler):

  • assembler/AbstractMacroAssembler.h:

(JSC):
(AbstractMacroAssembler):
(Label):

  • assembler/AssemblerBuffer.h:
  • assembler/MacroAssemblerARM.h:
  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::nop):
(JSC::MacroAssemblerARMv7::jump):
(JSC::MacroAssemblerARMv7::makeBranch):

  • assembler/MacroAssemblerMIPS.h:
  • assembler/MacroAssemblerSH4.h:
  • assembler/MacroAssemblerX86.h:

(MacroAssemblerX86):
(JSC::MacroAssemblerX86::moveWithPatch):

  • assembler/MacroAssemblerX86Common.h:
  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::branchTest8):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::cmpb_im):
(JSC::X86Assembler::codeSize):
(JSC::X86Assembler::label):
(JSC::X86Assembler::X86InstructionFormatter::memoryModRM):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::appendOSRExit):
(JSC::CodeBlock::appendSpeculationRecovery):
(DFGData):

  • bytecode/DFGExitProfile.h:

(JSC::DFG::exitKindToString):
(JSC::DFG::exitKindIsCountable):

  • bytecode/Instruction.h:
  • bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

  • bytecode/Watchpoint.cpp: Removed.
  • bytecode/Watchpoint.h: Removed.
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::ResolveResult::checkValidity):
(JSC::BytecodeGenerator::addGlobalVar):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::resolve):
(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveWithBase):
(JSC::BytecodeGenerator::emitResolveWithThis):
(JSC::BytecodeGenerator::emitGetStaticVar):
(JSC::BytecodeGenerator::emitPutStaticVar):

  • bytecompiler/BytecodeGenerator.h:

(BytecodeGenerator):

  • bytecompiler/NodesCodegen.cpp:

(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::PostfixResolveNode::emitBytecode):
(JSC::PrefixResolveNode::emitBytecode):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::AssignResolveNode::emitBytecode):
(JSC::ConstDeclNode::emitCodeSingle):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::clobberStructures):

  • dfg/DFGAbstractState.h:

(AbstractState):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCCallHelpers.h:

(JSC::DFG::CCallHelpers::setupArguments):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::globalVarStoreElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::run):

  • dfg/DFGCorrectableJumpPoint.h:
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::link):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasRegisterPointer):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::OSRExit):

  • dfg/DFGOSRExit.h:

(OSRExit):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):
(JSC::DFG::SpeculativeJIT::appendCallSetResult):
(JSC::DFG::SpeculativeJIT::speculationCheck):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp:
  • jit/JITPropertyAccess32_64.cpp:
  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
  • llint/LLIntSlowPaths.cpp:
  • llint/LLIntSlowPaths.h:

(LLInt):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/JSObject.cpp:

(JSC::JSObject::removeDirect):

  • runtime/JSObject.h:

(JSObject):

  • runtime/JSSymbolTableObject.h:

(JSC::symbolTableGet):
(JSC::symbolTablePut):
(JSC::symbolTablePutWithAttributes):

  • runtime/SymbolTable.cpp: Removed.
  • runtime/SymbolTable.h:

(JSC):
(JSC::SymbolTableEntry::isNull):
(JSC::SymbolTableEntry::getIndex):
(SymbolTableEntry):
(JSC::SymbolTableEntry::getAttributes):
(JSC::SymbolTableEntry::isReadOnly):
(JSC::SymbolTableEntry::pack):
(JSC::SymbolTableEntry::isValidIndex):

Source/WTF:

  • wtf/SegmentedVector.h:

(WTF):
(SegmentedVectorIterator):
(WTF::SegmentedVectorIterator::operator=):
(WTF::SegmentedVectorIterator::SegmentedVectorIterator):
(SegmentedVector):

LayoutTests:

  • fast/js/dfg-call-function-hit-watchpoint-expected.txt: Removed.
  • fast/js/dfg-call-function-hit-watchpoint.html: Removed.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-call-function-hit-watchpoint.js: Removed.
2:19 AM Changeset in webkit [120174] by rniwa@webkit.org
  • 655 edits in trunk/LayoutTests

Commit the rest of changes for r120167.

  • http/tests/history/resources/back-during-onload-hung-page.php:
  • http/tests/misc/embed-image-load-outlives-gc-without-crashing.html:
  • http/tests/misc/image-input-type-outlives-gc-without-crashing.html:
  • http/tests/misc/image-load-outlives-gc-without-crashing.html:
  • http/tests/misc/object-image-load-outlives-gc-without-crashing.html:
  • http/tests/security/:
1:51 AM Changeset in webkit [120173] by rniwa@webkit.org
  • 871 edits
    2 deletes in trunk/LayoutTests

Editing tests should use testRunner instead of layoutTestController
​https://bugs.webkit.org/show_bug.cgi?id=88955

Reviewed by Darin Adler.

  • editing/:
  • platform/blackberry/editing/text-iterator/findString-markers.html:
  • platform/chromium-linux/editing/selection/linux_selection_color.html:
  • platform/chromium-win/editing/selection/paragraph-granularity-expected.txt:
  • platform/chromium-win/editing/selection/triple-click-in-pre-expected.txt:
  • platform/chromium-win/editing/selection/word-granularity-expected.txt:
  • platform/chromium/editing/spelling/delete-misspelled-word.html:
  • platform/chromium/editing/spelling/move-cursor-to-misspelled-word.html:
  • platform/gtk/editing/pasteboard/middle-button-paste.html:
  • platform/gtk/editing/pasteboard/script-tests/middle-click-onpaste.js:
  • platform/gtk/editing/selection/caret-mode-document-begin-end.html:
  • platform/gtk/editing/selection/paragraph-granularity-expected.txt:
  • platform/gtk/editing/selection/triple-click-in-pre-expected.txt:
  • platform/gtk/editing/selection/word-granularity-expected.txt:
  • platform/mac/editing/:
  • platform/qt/editing/selection/paragraph-granularity-expected.txt:
  • platform/qt/editing/selection/triple-click-in-pre-expected.txt:
  • platform/qt/editing/selection/word-granularity-expected.txt:
  • platform/win/editing/deleting/delete-start-block-expected.txt:
  • platform/win/editing/pasteboard/pasting-crlf-isnt-translated-to-crcrlf-win.html:
  • platform/win/editing/selection/shift-page-up-down.html:
1:20 AM Changeset in webkit [120172] by fpizlo@apple.com
  • 63 edits
    6 adds in trunk

DFG should be able to set watchpoints on global variables
​https://bugs.webkit.org/show_bug.cgi?id=88692

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

This implements global variable constant folding by allowing the optimizing
compiler to set a "watchpoint" on globals that it wishes to constant fold.
If the watchpoint fires, then an OSR exit is forced by overwriting the
machine code that the optimizing compiler generated with a jump.

As such, this patch is adding quite a bit of stuff:

  • Jump replacement on those hardware targets supported by the optimizing JIT. It is now possible to patch in a jump instruction over any recorded watchpoint label. The jump must be "local" in the sense that it must be within the range of the largest jump distance supported by a one instruction jump.


  • WatchpointSets and Watchpoints. A Watchpoint is a doubly-linked list node that records the location where a jump must be inserted and the destination to which it should jump. Watchpoints can be added to a WatchpointSet. The WatchpointSet can be fired all at once, which plants all jumps. WatchpointSet also remembers if it had ever been invalidated, which allows for monotonicity: we typically don't want to optimize using watchpoints on something for which watchpoints had previously fired. The act of notifying a WatchpointSet has a trivial fast path in case no Watchpoints are registered (one-byte load+branch).


  • SpeculativeJIT::speculationWatchpoint(). It's like speculationCheck(), except that you don't have to emit branches. But, you need to know what WatchpointSet to add the resulting Watchpoint to. Not everything that you could write a speculationCheck() for will have a WatchpointSet that would get notified if the condition you were speculating against became invalid.


  • SymbolTableEntry now has the ability to refer to a WatchpointSet. It can do so without incurring any space overhead for those entries that don't have WatchpointSets.


  • The bytecode generator infers all global function variables to be watchable, and makes all stores perform the WatchpointSet's write check, and marks all loads as being potentially watchable (i.e. you can compile them to a watchpoint and a constant).


Put together, this allows for fully sleazy inlining of calls to globally
declared functions. The inline prologue will no longer contain the load of
the function, or any checks of the function you're calling. I.e. it's
pretty much like the kind of inlining you would see in Java or C++.
Furthermore, the watchpointing functionality is built to be fairly general,
and should allow setting watchpoints on all sorts of interesting things
in the future.

The sleazy inlining means that we will now sometimes inline in code paths
that have never executed. Previously, to inline we would have either had
to have executed the call (to read the call's inline cache) or have
executed the method check (to read the method check's inline cache). Now,
we might inline when the callee is a watched global variable. This
revealed some humorous bugs. First, constant folding disagreed with CFA
over what kinds of operations can clobber (example: code path A is dead
but stores a String into variable X, all other code paths store 0 into
X, and then you do CompareEq(X, 0) - CFA will say that this is a non-
clobbering constant, but constant folding thought it was clobbering
because it saw the String prediction). Second, inlining would crash if
the inline callee had not been compiled. This patch fixes both bugs,
since otherwise run-javascriptcore-tests would report regressions.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • assembler/ARMv7Assembler.h:

(ARMv7Assembler):
(JSC::ARMv7Assembler::ARMv7Assembler):
(JSC::ARMv7Assembler::labelForWatchpoint):
(JSC::ARMv7Assembler::label):
(JSC::ARMv7Assembler::replaceWithJump):
(JSC::ARMv7Assembler::maxJumpReplacementSize):

  • assembler/AbstractMacroAssembler.h:

(JSC):
(AbstractMacroAssembler):
(Label):
(JSC::AbstractMacroAssembler::watchpointLabel):

  • assembler/AssemblerBuffer.h:
  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::replaceWithJump):
(MacroAssemblerARM):
(JSC::MacroAssemblerARM::maxJumpReplacementSize):

  • assembler/MacroAssemblerARMv7.h:

(MacroAssemblerARMv7):
(JSC::MacroAssemblerARMv7::replaceWithJump):
(JSC::MacroAssemblerARMv7::maxJumpReplacementSize):
(JSC::MacroAssemblerARMv7::branchTest8):
(JSC::MacroAssemblerARMv7::jump):
(JSC::MacroAssemblerARMv7::makeBranch):

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::replaceWithJump):
(MacroAssemblerMIPS):
(JSC::MacroAssemblerMIPS::maxJumpReplacementSize):

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::replaceWithJump):
(MacroAssemblerSH4):
(JSC::MacroAssemblerSH4::maxJumpReplacementSize):

  • assembler/MacroAssemblerX86.h:

(MacroAssemblerX86):
(JSC::MacroAssemblerX86::branchTest8):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::replaceWithJump):
(MacroAssemblerX86Common):
(JSC::MacroAssemblerX86Common::maxJumpReplacementSize):

  • assembler/MacroAssemblerX86_64.h:

(MacroAssemblerX86_64):
(JSC::MacroAssemblerX86_64::branchTest8):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::X86Assembler):
(X86Assembler):
(JSC::X86Assembler::cmpb_im):
(JSC::X86Assembler::testb_im):
(JSC::X86Assembler::labelForWatchpoint):
(JSC::X86Assembler::label):
(JSC::X86Assembler::replaceWithJump):
(JSC::X86Assembler::maxJumpReplacementSize):
(JSC::X86Assembler::X86InstructionFormatter::memoryModRM):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::appendOSRExit):
(JSC::CodeBlock::appendSpeculationRecovery):
(CodeBlock):
(JSC::CodeBlock::appendWatchpoint):
(JSC::CodeBlock::numberOfWatchpoints):
(JSC::CodeBlock::watchpoint):
(DFGData):

  • bytecode/DFGExitProfile.h:

(JSC::DFG::exitKindToString):
(JSC::DFG::exitKindIsCountable):

  • bytecode/Instruction.h:

(Instruction):
(JSC::Instruction::Instruction):

  • bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

  • bytecode/Watchpoint.cpp: Added.

(JSC):
(JSC::Watchpoint::~Watchpoint):
(JSC::Watchpoint::correctLabels):
(JSC::Watchpoint::fire):
(JSC::WatchpointSet::WatchpointSet):
(JSC::WatchpointSet::~WatchpointSet):
(JSC::WatchpointSet::add):
(JSC::WatchpointSet::notifyWriteSlow):
(JSC::WatchpointSet::fireAllWatchpoints):

  • bytecode/Watchpoint.h: Added.

(JSC):
(Watchpoint):
(JSC::Watchpoint::Watchpoint):
(JSC::Watchpoint::setDestination):
(WatchpointSet):
(JSC::WatchpointSet::isStillValid):
(JSC::WatchpointSet::hasBeenInvalidated):
(JSC::WatchpointSet::startWatching):
(JSC::WatchpointSet::notifyWrite):
(JSC::WatchpointSet::addressOfIsWatched):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::ResolveResult::checkValidity):
(JSC::BytecodeGenerator::addGlobalVar):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::resolve):
(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveWithBase):
(JSC::BytecodeGenerator::emitResolveWithThis):
(JSC::BytecodeGenerator::emitGetStaticVar):
(JSC::BytecodeGenerator::emitPutStaticVar):

  • bytecompiler/BytecodeGenerator.h:

(BytecodeGenerator):

  • bytecompiler/NodesCodegen.cpp:

(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::PostfixResolveNode::emitBytecode):
(JSC::PrefixResolveNode::emitBytecode):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::AssignResolveNode::emitBytecode):
(JSC::ConstDeclNode::emitCodeSingle):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::clobberStructures):

  • dfg/DFGAbstractState.h:

(AbstractState):
(JSC::DFG::AbstractState::didClobber):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCCallHelpers.h:

(CCallHelpers):
(JSC::DFG::CCallHelpers::setupArguments):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::globalVarWatchpointElimination):
(CSEPhase):
(JSC::DFG::CSEPhase::globalVarStoreElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::run):

  • dfg/DFGCorrectableJumpPoint.h:

(JSC::DFG::CorrectableJumpPoint::isSet):
(CorrectableJumpPoint):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::link):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasIdentifierNumberForCheck):
(Node):
(JSC::DFG::Node::identifierNumberForCheck):
(JSC::DFG::Node::hasRegisterPointer):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::OSRExit):

  • dfg/DFGOSRExit.h:

(OSRExit):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):
(JSC::DFG::SpeculativeJIT::appendCall):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::speculationWatchpoint):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_put_global_var_check):
(JSC):
(JSC::JIT::emitSlow_op_put_global_var_check):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_put_global_var_check):
(JSC):
(JSC::JIT::emitSlow_op_put_global_var_check):

  • jit/JITStubs.cpp:

(JSC::JITThunks::JITThunks):
(JSC::DEFINE_STUB_FUNCTION):
(JSC):

  • jit/JITStubs.h:
  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(LLInt):

  • llint/LLIntSlowPaths.h:

(LLInt):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/JSObject.cpp:

(JSC::JSObject::removeDirect):

  • runtime/JSObject.h:

(JSObject):

  • runtime/JSSymbolTableObject.h:

(JSC::symbolTableGet):
(JSC::symbolTablePut):
(JSC::symbolTablePutWithAttributes):

  • runtime/SymbolTable.cpp: Added.

(JSC):
(JSC::SymbolTableEntry::copySlow):
(JSC::SymbolTableEntry::freeFatEntrySlow):
(JSC::SymbolTableEntry::couldBeWatched):
(JSC::SymbolTableEntry::attemptToWatch):
(JSC::SymbolTableEntry::addressOfIsWatched):
(JSC::SymbolTableEntry::addWatchpoint):
(JSC::SymbolTableEntry::notifyWriteSlow):
(JSC::SymbolTableEntry::inflateSlow):

  • runtime/SymbolTable.h:

(JSC):
(SymbolTableEntry):
(Fast):
(JSC::SymbolTableEntry::Fast::Fast):
(JSC::SymbolTableEntry::Fast::isNull):
(JSC::SymbolTableEntry::Fast::getIndex):
(JSC::SymbolTableEntry::Fast::isReadOnly):
(JSC::SymbolTableEntry::Fast::getAttributes):
(JSC::SymbolTableEntry::Fast::isFat):
(JSC::SymbolTableEntry::SymbolTableEntry):
(JSC::SymbolTableEntry::~SymbolTableEntry):
(JSC::SymbolTableEntry::operator=):
(JSC::SymbolTableEntry::isNull):
(JSC::SymbolTableEntry::getIndex):
(JSC::SymbolTableEntry::getFast):
(JSC::SymbolTableEntry::getAttributes):
(JSC::SymbolTableEntry::isReadOnly):
(JSC::SymbolTableEntry::watchpointSet):
(JSC::SymbolTableEntry::notifyWrite):
(FatEntry):
(JSC::SymbolTableEntry::FatEntry::FatEntry):
(JSC::SymbolTableEntry::isFat):
(JSC::SymbolTableEntry::fatEntry):
(JSC::SymbolTableEntry::inflate):
(JSC::SymbolTableEntry::bits):
(JSC::SymbolTableEntry::freeFatEntry):
(JSC::SymbolTableEntry::pack):
(JSC::SymbolTableEntry::isValidIndex):

Source/WTF:

Reviewed by Geoffrey Garen.

Added ability to set the inline capacity of segmented vectors.

  • wtf/SegmentedVector.h:

(WTF):
(SegmentedVectorIterator):
(WTF::SegmentedVectorIterator::operator=):
(WTF::SegmentedVectorIterator::SegmentedVectorIterator):
(SegmentedVector):

LayoutTests:

Rubber stamped by Geoffrey Garen.

Added a test for watchpoints. Also updated the jsc-test-list to include the latest
tests.

  • fast/js/dfg-call-function-hit-watchpoint-expected.txt: Added.
  • fast/js/dfg-call-function-hit-watchpoint.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-call-function-hit-watchpoint.js: Added.

(foo):
(bar):
(.foo):

1:19 AM Changeset in webkit [120171] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

Change the styling of the Chromium video controls.
​https://bugs.webkit.org/show_bug.cgi?id=88297

Patch by Silvia Pfeiffer <​silviapf@chromium.org> on 2012-06-13
Reviewed by Eric Carlson.

No new tests, final patch will contain the rebaselined tests.

The Chrome video controls are receiving a visual update. This patch includes CSS changes,
the removal of the now no longer needed controls background div, and the introduction of
new images for the buttons.

  • css/mediaControlsChromium.css:

(audio):
Adjust height of audio controls.
(::-webkit-media-controls):
Use flexbox on media controls shadow DOM.
(audio::-webkit-media-controls-enclosure, video::-webkit-media-controls-enclosure):
Adjust height, max-width, text-indent and box-sizing, and reset padding to 0.
(video::-webkit-media-controls-enclosure):
Use 5px padding only for video controls and adjust height accordingly.
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
Use flexbox on panel, adjust bottom alignment, height, background color and border radius.
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
Display buttons inline with fixed width and height, vertically centered, no padding and
6px space to next controls element (this will be 15px incl the space in the image).
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
Display buttons inline with fixed width and height, vertically centered, no padding and
9px space to next controls element (this will be 15px incl the space in the image).
(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
Display text as block, without broder, adjusted height, font-family, font-size and 9px space
to next controls element (this will be 15px incl the space in the image).
(audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
Adjust height, padding, background-color, min-wdith and 15px space to next controls element.
(audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
Adjust height, max- and min-width, background-color and 15px space to next controls element.

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
Remove timeline container, which is not necessary any longer because of the use of flexbox.
(WebCore::MediaControlRootElementChromium::create):
Remove timeline container, which is not necessary any longer because of the use of flexbox.
(WebCore::MediaControlRootElementChromium::setMediaController):
Remove timeline container, which is not necessary any longer because of the use of flexbox.
(WebCore::MediaControlRootElementChromium::reset):
Show the timeline instead of the timeline container when resetting.
(WebCore::MediaControlRootElementChromium::reportedError):
Hide the timeline instead of the timeline container when running into an error.

  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::paintMediaMuteButton):
Introduce new image resources for the mute button and adjust it based on volume levels.
(WebCore::paintMediaPlayButton):
Introduce new image resources for the play button.
(WebCore::getMediaSliderThumb):
Introduce new image resources for the position slider thumb.
(WebCore::paintMediaVolumeSliderThumb):
Introduce new image resources for the volume slider thumb.
Remove timeline container rendering.
(WebCore::RenderMediaControlsChromium::paintMediaControlsPart):
Add timeline container painting to the "not reached" elements.
(WebCore):
Provide size settings for the position and volume sliders.
(WebCore::RenderMediaControlsChromium::adjustMediaSliderThumbSize):
Calculate correct width and height settings for the new image resources of the position and volume
slider thumbs.

  • rendering/RenderThemeChromiumMac.h:

(RenderThemeChromiumMac):
Remove timeline container rendering (i.e. the media controls background).

  • rendering/RenderThemeChromiumMac.mm:

Remove timeline container rendering (i.e. the media controls background).

  • rendering/RenderThemeChromiumSkia.cpp:

Remove timeline container rendering (i.e. the media controls background).

  • rendering/RenderThemeChromiumSkia.h:

(RenderThemeChromiumSkia):
Remove timeline container rendering (i.e. the media controls background).

1:18 AM Changeset in webkit [120170] by kkristof@inf.u-szeged.hu
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

Skip svg/as-image/svg-nested.html which is timeout only on Qt-4.8.

  • platform/qt-4.8/Skipped: skip svg/as-image/svg-nested.html
  • platform/qt/TestExpectations: removed the slow marker from this test
1:17 AM Changeset in webkit [120169] by kinuko@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, fixing English nits suggested by review for r120165.

  • fileapi/Blob.cpp:

(WebCore::Blob::webkitSlice):

  • fileapi/Blob.h:

(Blob):

1:05 AM Changeset in webkit [120168] by morrita@google.com
  • 32 edits
    1 copy
    2 moves
    4 adds in trunk

REGRESSION(r118098): <content> element does not render distributed children when cloned from another document
​https://bugs.webkit.org/show_bug.cgi?id=88148

Source/WebCore:

Reviewed by Dimitri Glazkov.

The shadow DOM availability was decided through FrameLoaderClient.
But there are documents which don't have any associated frames, in
which any shadow DOM related elements cannot be constructed. That
resulsted the regression.

This change introduces a Page-based client called
ContextFeaturesClient which takes the role from FrameLoaderClient
to decide the feature availability, and ContextFeatures which is a
proxy of ContextFeaturesClient. ContextEnabledFeatures is is
replaced with ContextFeatures.

Each ContextFeatures object is owned by a Page, and is attached to
each Document in the page even if the page itself has no referenct
to Frames or Pages. With ContextFeatures, each Document can decide
the feature availability even if it cannot reach Page or Frame.

On RefCountedSupplement: Document instance can live longer than a
Page where it is shwon. This means that ContextFeatures instance
needs to survive after owner Page destruction because it's
referenced from possibly surviving Documents. RefCountedSupplement
is introduced to cover this scenario: It allows supplement classes
to live after Page's destruction.

RefCountedSupplement::hostDestroyed() is notified when the hosting
page is gone. ContextFeatures clears its reference to the client
using this notification.

Test: fast/dom/shadow/elements-in-frameless-document.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementation):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::determineScope):

  • dom/ContextFeatures.cpp: Added.

(WebCore):
(WebCore::ContextFeaturesClient::empty):
(WebCore::ContextFeatures::supplementName):
(WebCore::ContextFeatures::defaultSwitch):
(WebCore::ContextFeatures::shadowDOMEnabled):
(WebCore::ContextFeatures::styleScopedEnabled):
(WebCore::ContextFeatures::pagePopupEnabled):
(WebCore::provideContextFeaturesTo):
(WebCore::provideContextFeaturesToDocumentFrom):

  • dom/ContextFeatures.h: Added.

(WebCore):
(ContextFeatures):
(WebCore::ContextFeatures::ContextFeatures):
(WebCore::ContextFeatures::hostDestroyed):
(ContextFeaturesClient):
(WebCore::ContextFeaturesClient::~ContextFeaturesClient):
(WebCore::ContextFeaturesClient::isEnabled):
(WebCore::ContextFeatures::create):
(WebCore::ContextFeatures::isEnabled):

  • dom/DOMAllInOne.cpp:
  • dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocument):
(WebCore::DOMImplementation::createHTMLDocument):

  • dom/Document.h:

(WebCore::Document::contextFeatures):

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::setContextFeatures):

  • dom/Position.cpp:

(WebCore::Position::Position):
(WebCore::Position::findParent):

  • dom/TreeScope.cpp:

(WebCore::TreeScope::getSelection):

  • dom/make_names.pl:

(printConstructorInterior):
(printFactoryCppFile):
(printWrapperFunctions):
(printWrapperFactoryCppFile):

  • editing/markup.cpp:

(WebCore::createFragmentFromMarkupWithContext):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::registerWithScopingNode):
(WebCore::HTMLStyleElement::unregisterWithScopingNode):

  • html/shadow/HTMLContentElement.cpp:

(WebCore::contentTagName):

  • inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::patchDocument):

  • loader/FrameLoaderClient.h:
  • platform/RefCountedSupplement.h: Copied from Source/WebCore/platform/Supplementable.h.

(WebCore):
(RefCountedSupplement):
(WebCore::RefCountedSupplement::hostDestroyed):
(Wrapper):
(WebCore::RefCountedSupplement::Wrapper::Wrapper):
(WebCore::RefCountedSupplement::Wrapper::~Wrapper):
(WebCore::RefCountedSupplement::Wrapper::wrapped):
(WebCore::RefCountedSupplement::provideTo):
(WebCore::RefCountedSupplement::from):

  • platform/Supplementable.h:

(WebCore::Supplement::isRefCountedWrapper):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::responseXML):

Source/WebKit/chromium:

Reviewed by Dimitri Glazkov.

  • Added ContextFeaturesClientImpl which implements WebCore::ContextFeaturesClient.
  • Replaced PagePopupFrameLoaderClient with PagePopupFeaturesClient.
  • WebKit.gyp:
  • public/WebPermissionClient.h:

(WebKit):
(WebKit::WebPermissionClient::allowWebComponents):

  • src/ContextFeaturesClientImpl.cpp: Renamed from Source/WebCore/bindings/generic/ContextEnabledFeatures.cpp.

(WebKit):
(WebKit::ContextFeaturesClientImpl::isEnabled):

  • src/ContextFeaturesClientImpl.h: Renamed from Source/WebCore/bindings/generic/ContextEnabledFeatures.h.

(WebKit):
(ContextFeaturesClientImpl):
(WebKit::ContextFeaturesClientImpl::ContextFeaturesClientImpl):
(WebKit::ContextFeaturesClientImpl::setPermissionClient):

  • src/FrameLoaderClientImpl.cpp:
  • src/FrameLoaderClientImpl.h:

(FrameLoaderClientImpl):

  • src/WebPagePopupImpl.cpp:

(PagePopupFeaturesClient):
(WebKit::PagePopupFeaturesClient::isEnabled):
(WebKit):
(WebKit::WebPagePopupImpl::initPage):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setPermissionClient):
(WebKit::WebViewImpl::WebViewImpl):

  • src/WebViewImpl.h:

(WebKit):

LayoutTests:

Reviewed by Dimitri Glazkov.

  • fast/dom/shadow/elements-in-frameless-document-expected.txt: Added.
  • fast/dom/shadow/elements-in-frameless-document.html: Added.
12:49 AM Changeset in webkit [120167] by rniwa@webkit.org
  • 755 edits in trunk/LayoutTests

HTTP tests should use testRunner instead of layoutTestController
​https://bugs.webkit.org/show_bug.cgi?id=88969

Reviewed by Darin Adler.

  • http/tests/appcache/:
  • http/tests/cache/cancel-during-failure-crash.html:
  • http/tests/cache/cancel-during-revalidation-succeeded.html:
  • http/tests/cache/history-only-cached-subresource-loads-max-age-https.html:
  • http/tests/cache/history-only-cached-subresource-loads.html:
  • http/tests/cache/loaded-from-cache-after-reload-within-iframe.html:
  • http/tests/cache/loaded-from-cache-after-reload.html:
  • http/tests/cache/post-redirect-get.php:
  • http/tests/cache/post-with-cached-subresources.php:
  • http/tests/cache/resources/stopped-revalidation-result.html:
  • http/tests/cache/resources/subresource-test.js:

(nextTest):

  • http/tests/cache/stopped-revalidation.html:
  • http/tests/cache/subresource-failover-to-network.html:
  • http/tests/cache/subresource-fragment-identifier.html:
  • http/tests/cache/subresource-multiple-instances.html:
  • http/tests/cache/xhr-body.html:
  • http/tests/cache/zero-length-xhr.html:
  • http/tests/canvas/philip/tests.js:

(_addTest.endTest):
(_addTest.window.onload):
(_addTest):

  • http/tests/canvas/webgl/origin-clean-conformance.html:
  • http/tests/cookies/resources/cookies-test-pre.js:
  • http/tests/cookies/resources/resetCookies.js:

(resetCookies):

  • http/tests/cookies/resources/setArraycookies-result.php:
  • http/tests/cookies/resources/setUtf8Cookies-result.php:
  • http/tests/cookies/resources/third-party-cookie-relaxing-iframe.html:
  • http/tests/cookies/third-party-cookie-relaxing.html:
  • http/tests/css/cross-fade-reload.html:
  • http/tests/css/css-imports-redirect-cycle.html:
  • http/tests/css/font-face-src-loading.html:
  • http/tests/css/resources/link-css-disabled-value-with-slow-loading-sheet-in-error.js:
  • http/tests/css/resources/link-css-disabled-value-with-slow-loading-sheet.js:
  • http/tests/css/resources/request-logging.js:

(startTest):
(endTest):

  • http/tests/download/basic-ascii.html:
  • http/tests/download/default-encoding.html:
  • http/tests/download/inherited-encoding-form-submission-result.html:
  • http/tests/download/inherited-encoding.html:
  • http/tests/download/literal-utf-8.html:
  • http/tests/eventsource/eventsource-bad-mime-type.html:
  • http/tests/eventsource/eventsource-content-type-charset.html:
  • http/tests/eventsource/eventsource-eof.html:
  • http/tests/eventsource/eventsource-parse-event-stream.html:
  • http/tests/eventsource/eventsource-reconnect-during-navigate-crash.html:
  • http/tests/eventsource/eventsource-reconnect.html:
  • http/tests/eventsource/eventsource-status-code-states.html:
  • http/tests/eventsource/existent-eventsource-status-error-iframe-crash.html:
  • http/tests/eventsource/non-existent-eventsource-status-error-iframe-crash.html:
  • http/tests/eventsource/resources/wait-then-notify-done.php:
  • http/tests/eventsource/workers/eventsource-simple.html:
  • http/tests/fileapi/create-blob-url-from-data-url.html:
  • http/tests/filesystem/no-cache-filesystem-url.html:
  • http/tests/globalhistory/history-delegate-basic-302-redirect.html:
  • http/tests/globalhistory/history-delegate-basic-refresh-redirect.html:
  • http/tests/globalhistory/history-delegate-basic-title.html:
  • http/tests/globalhistory/history-delegate-basic-visited-links.html:
  • http/tests/history/:
  • http/tests/incremental/frame-focus-before-load.html:
  • http/tests/incremental/partial-jpeg.html:
  • http/tests/incremental/pause-in-script-element.pl:
  • http/tests/incremental/slow-utf8-css.html:
  • http/tests/incremental/slow-utf8-html.pl:
  • http/tests/incremental/split-hex-entities.pl:
  • http/tests/inspector-enabled/console-clear-arguments-on-frame-navigation.html:
  • http/tests/inspector-enabled/console-clear-arguments-on-frame-remove.html:
  • http/tests/inspector-enabled/console-log-before-frame-navigation.html:
  • http/tests/inspector-enabled/contentSecurityPolicy-blocks-setInterval.html:
  • http/tests/inspector-enabled/contentSecurityPolicy-blocks-setTimeout.html:
  • http/tests/inspector-enabled/database-open.html:
  • http/tests/inspector-enabled/dedicated-workers-list.html:
  • http/tests/inspector-enabled/document-write.html:
  • http/tests/inspector-enabled/dom-storage-open.html:
  • http/tests/inspector-enabled/injected-script-discard.html:
  • http/tests/inspector-enabled/resources/console-clear-arguments-iframe.html:
  • http/tests/inspector/console-resource-errors.html:
  • http/tests/inspector/console-websocket-error.html:
  • http/tests/inspector/indexeddb/resources/without-indexed-db.html:
  • http/tests/inspector/inspector-test.js:
  • http/tests/inspector/network/ping.html:
  • http/tests/inspector/resource-tree/resources/script-initial.js:

(foo):

  • http/tests/inspector/resource-tree/resources/script-navigated.js:

(foo):

  • http/tests/inspector/web-socket-frame-error.html:
  • http/tests/inspector/web-socket-frame.html:
  • http/tests/loading/:
  • http/tests/local/absolute-url-strip-whitespace.html:
  • http/tests/local/blob/script-tests/send-hybrid-blob.js:

(runTests):

  • http/tests/local/drag-over-remote-content.html:
  • http/tests/local/fail.css:

(#pass):

  • http/tests/local/formdata/send-form-data-constructed-from-form.html:
  • http/tests/local/link-stylesheet-load-order-preload.html:
  • http/tests/local/link-stylesheet-load-order.html:
  • http/tests/local/link-stylesheet-preferred.html:
  • http/tests/local/style-access-before-stylesheet-loaded.html:
  • http/tests/local/stylesheet-and-script-load-order-http.html:
  • http/tests/local/stylesheet-and-script-load-order-media-print.html:
  • http/tests/local/stylesheet-and-script-load-order.html:
  • http/tests/media/reload-after-dialog.html:
  • http/tests/media/resources/test.txt:
  • http/tests/media/video-buffered-range-contains-currentTime.html:
  • http/tests/media/video-cancel-load.html:
  • http/tests/media/video-cookie.html:
  • http/tests/media/video-error-abort.html:
  • http/tests/messaging/cross-domain-message-event-dispatch.html:
  • http/tests/messaging/cross-domain-message-send.html:
  • http/tests/mime/quoted-charset.php:
  • http/tests/mime/resources/uppercase-mime-type.php:
  • http/tests/mime/standard-mode-does-not-load-stylesheet-with-text-plain-and-css-extension.html:
  • http/tests/mime/standard-mode-does-not-load-stylesheet-with-text-plain.html:
  • http/tests/mime/standard-mode-loads-stylesheet-with-charset-and-css-extension.html:
  • http/tests/mime/standard-mode-loads-stylesheet-with-charset.html:
  • http/tests/mime/standard-mode-loads-stylesheet-with-empty-content-type.html:
  • http/tests/mime/standard-mode-loads-stylesheet-with-text-css-and-invalid-type.html:
  • http/tests/mime/uppercase-mime-type.html:
  • http/tests/misc/:
  • http/tests/websocket/tests/:
  • http/tests/workers/resources/worker-redirect.js:

(runNextTest):

  • http/tests/workers/resources/worker-util.js:

(waitUntilThreadCountMatches.return):
(waitUntilThreadCountMatches):
(done):

  • http/tests/workers/shared-worker-importScripts.html:
  • http/tests/workers/shared-worker-invalid-url.html:
  • http/tests/workers/terminate-during-sync-operation.html:
  • http/tests/workers/text-encoding.html:
  • http/tests/workers/worker-document-domain-security.html:
  • http/tests/workers/worker-importScripts.html:
  • http/tests/workers/worker-importScriptsOnError.html:
  • http/tests/workers/worker-invalid-url.html:
  • http/tests/workers/worker-workerScriptNotThere.html:
  • http/tests/xmlhttprequest/:
  • http/tests/xmlviewer/dumpAsText/frames.html:
  • http/tests/xmlviewer/dumpAsText/xhtml-tag.xml:
  • http/tests/xmlviewer/extensions-api.html:
  • platform/chromium-win/http/tests/websocket/tests/hixie76/bad-sub-protocol-control-chars-expected.txt:
  • platform/chromium/http/tests/misc/execute-and-return-value.html:
  • platform/chromium/http/tests/misc/selectionAsMarkup.html:
  • platform/chromium/http/tests/permissionclient/image-permissions.html:
  • platform/chromium/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
  • platform/chromium/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
  • platform/chromium/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt:
  • platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt:
  • platform/chromium/http/tests/security/mixedContent/insecure-iframe-in-main-frame-allowed.html:
  • platform/chromium/http/tests/security/mixedContent/insecure-iframe-in-main-frame-blocked.html:
  • platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-allowed.html:
  • platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-blocked.html:
  • platform/chromium/http/tests/security/mixedContent/insecure-script-in-main-frame-allowed.html:
  • platform/chromium/http/tests/security/mixedContent/insecure-script-in-main-frame-blocked.html:
  • platform/chromium/http/tests/security/window-named-proto-expected.txt:
  • platform/qt/http/tests/cookies/strict-third-party-cookie-blocking.html:
  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
  • platform/qt/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
12:32 AM Changeset in webkit [120166] by Simon Hausmann
  • 2 edits
    1 move in trunk/Tools

[Qt][Win]QtTestBrowser somehow picks up DumpRenderTree's main.cpp, causing a failure to link
​https://bugs.webkit.org/show_bug.cgi?id=88874

Patch by Joel Dillon <​joel.dillon@codethink.co.uk> on 2012-06-13
Reviewed by Simon Hausmann.

Rename main.cpp in QtTestBrowser because on Windows
it conflicts with main.cpp from DumpRenderTree.

  • QtTestBrowser/QtTestBrowser.pro:
  • QtTestBrowser/qttestbrowser.cpp: Renamed from Tools/QtTestBrowser/main.cpp.

(launcherMain):
(LauncherApplication):
(LauncherApplication::urls):
(LauncherApplication::isRobotized):
(LauncherApplication::robotTimeout):
(LauncherApplication::robotExtraTime):
(LauncherApplication::applyDefaultSettings):
(LauncherApplication::LauncherApplication):
(requiresGraphicsView):
(LauncherApplication::handleUserOptions):
(main):

Jun 12, 2012:

11:50 PM Changeset in webkit [120165] by kinuko@chromium.org
  • 17 edits in trunk

Unprefix Blob.webkitSlice
​https://bugs.webkit.org/show_bug.cgi?id=78111

Reviewed by Adam Barth.

Source/WebCore:

Add unprefixed Blob.slice and start showing a deprecation message when webkitSlice is called.

No new tests: existing tests that call webkitSlice() are converted to slice(). They should keep running.

  • bindings/gobject/WebKitDOMCustom.cpp:

(webkit_dom_blob_slice): Removed.
(webkit_dom_blob_webkit_slice): Added.

  • fileapi/Blob.cpp:

(WebCore::Blob::slice):
(WebCore):
(WebCore::Blob::webkitSlice):
(WebCore::Blob::sliceInternal): Added.

  • fileapi/Blob.h:

(WebCore):
(Blob):

  • fileapi/Blob.idl:

LayoutTests:

Converted existing tests that are calling Blob.webkitSlice() to call slice().

  • fast/files/blob-slice-overflow.html:
  • fast/files/blob-slice-test.html:
  • fast/files/resources/read-blob-test-cases.js:

(testReadingSlicedFileBlob):
(testReadingSlicedTextBlob):
(testReadingSlicedArrayBufferBlob):
(testReadingSlicedHybridBlob):
(testReadingTripleSlicedHybridBlob):

  • fast/filesystem/resources/file-writer-utils.js:

(verifyByteRangeIsZeroesHelper):

  • http/tests/local/blob/script-tests/send-hybrid-blob.js:

(runHybridBlobTest):

  • http/tests/local/blob/script-tests/send-sliced-data-blob.js:

(runSliceTest):

  • http/tests/local/fileapi/script-tests/send-sliced-dragged-file.js:

(onStableFileDrop):
(onUnstableFileDrop):

  • http/tests/local/formdata/resources/send-form-data-common.js:

(testSendingFormData):

  • inspector/profiler/heap-snapshot-loader.html:
11:33 PM Changeset in webkit [120164] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r120036.
​http://trac.webkit.org/changeset/120036
​https://bugs.webkit.org/show_bug.cgi?id=88965

"assert failed in debug build" (Requested by maryw on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-06-12

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::handleNotifyDataReceived):

11:01 PM Changeset in webkit [120163] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed morning gardening, skip new failing tests.

  • platform/qt/Skipped:
10:39 PM Changeset in webkit [120162] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit/qt

[Qt][Mac] Unreviewed buildfix after r120076.

  • WebCoreSupport/QTKitFullScreenVideoHandler.h:
10:19 PM Changeset in webkit [120161] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Roll chromium rev in DEPS
​https://bugs.webkit.org/show_bug.cgi?id=88934

Patch by Ian Vollick <​vollick@chromium.org> on 2012-06-12
Reviewed by James Robinson.

Rolling to 141410

  • DEPS:
10:00 PM Changeset in webkit [120160] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

webcore should depend on webcore_arm_neon for only arm target_arch
​https://bugs.webkit.org/show_bug.cgi?id=88839

Patch by Wei James <​james.wei@intel.com> on 2012-06-12
Reviewed by Adam Barth.

  • WebCore.gyp/WebCore.gyp:
9:56 PM Changeset in webkit [120159] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix for ARMv7 debug builds.

  • jit/JITStubs.cpp:

(JSC::JITThunks::JITThunks):

9:50 PM Changeset in webkit [120158] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Can't set el.type on a <button> element
​https://bugs.webkit.org/show_bug.cgi?id=14439

Patch by Edaena Salinas Jasso <​edaena@apple.com> on 2012-06-12
Reviewed by Darin Adler.

Source/WebCore:

Test: fast/dom/HTMLButtonElement/change-type.html

  • bindings/objc/PublicDOMInterfaces.h:
  • html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::setType): Added implementation of setType method.
(WebCore):

  • html/HTMLButtonElement.h:

(HTMLButtonElement): Added setType method.

  • html/HTMLButtonElement.idl: Removed readonly restriction to the type variable.

LayoutTests:

  • fast/dom/HTMLButtonElement/change-type-expected.txt: Added.
  • fast/dom/HTMLButtonElement/change-type.html: Added.
9:47 PM Changeset in webkit [120157] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed: Update expectations for http/tests/media/media-source/webm/video-media-source-seek.html

This test has racy events (seeked and webkitsourceended) so is
flaky on Linux Dbg. Updated bug 85952 that is tracking flakiness
in these tests.

  • platform/chromium/TestExpectations:
9:32 PM Changeset in webkit [120156] by bashi@chromium.org
  • 8 edits
    5 adds in trunk

[Chromium] Implement font shaping with font-feature-settings on Mac
​https://bugs.webkit.org/show_bug.cgi?id=69826

Reviewed by Tony Chang.

Source/WebCore:

Add HarfBuzz-ng text shaper.
Chromium mac port uses it as secondary text shaper to support OpenType features.
HarfBuzz-ng is only used when -webkit-font-feature-settings is specified and
corresponding font is not an AAT font.

No new tests. css3/font-feature-settings-rendering.html should pass on Chromium mac port.

  • WebCore.gyp/WebCore.gyp: Added harfbuzz-ng dependencies.
  • WebCore.gypi: Added harfbuzz-ng files.
  • platform/graphics/FontPlatformData.h:

(FontPlatformData): Added m_harfbuzzFace.

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::platformDataInit): Copy m_harfbuzzFace.
(WebCore::FontPlatformData::platformDataAssign): Ditto.
(WebCore):
(WebCore::isAATFont):
(WebCore::FontPlatformData::harfbuzzFace):

  • platform/graphics/harfbuzz/ng/HarfBuzzFace.cpp: Added.

(WebCore):
(WebCore::harfbuzzFaceCache):
(WebCore::HarfBuzzFace::HarfBuzzFace):
(WebCore::HarfBuzzFace::~HarfBuzzFace):

  • platform/graphics/harfbuzz/ng/HarfBuzzFace.h: Added.

(WebCore):
(HarfBuzzFace):
(WebCore::HarfBuzzFace::create):

  • platform/graphics/harfbuzz/ng/HarfBuzzFaceCoreText.cpp: Added.

(WebCore):
(WebCore::floatToHarfBuzzPosition):
(WebCore::getGlyph):
(WebCore::getGlyphHorizontalAdvance):
(WebCore::getGlyphHorizontalOrigin):
(WebCore::getGlyphExtents):
(WebCore::harfbuzzCoreTextGetFontFuncs):
(WebCore::releaseTableData):
(WebCore::harfbuzzCoreTextGetTable):
(WebCore::HarfBuzzFace::createFace):
(WebCore::HarfBuzzFace::createFont):
(WebCore::HarfBuzzShaper::createGlyphBufferAdvance):

  • platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp: Added.

(WebCore):
(WebCore::harfbuzzPositionToFloat):
(WebCore::HarfBuzzShaper::HarfBuzzRun::HarfBuzzRun):
(WebCore::HarfBuzzShaper::HarfBuzzRun::setGlyphAndPositions):
(WebCore::HarfBuzzShaper::HarfBuzzRun::characterIndexForXPosition):
(WebCore::HarfBuzzShaper::HarfBuzzRun::xPositionForOffset):
(WebCore::HarfBuzzShaper::HarfBuzzShaper):
(WebCore::HarfBuzzShaper::~HarfBuzzShaper):
(WebCore::HarfBuzzShaper::setFontFeatures):
(WebCore::HarfBuzzShaper::shape):
(WebCore::HarfBuzzShaper::setupHarfBuzzRun):
(WebCore::HarfBuzzShaper::shapeHarfBuzzRun):
(WebCore::HarfBuzzShaper::setGlyphPositionsForHarfBuzzRun):
(WebCore::HarfBuzzShaper::offsetForPosition):
(WebCore::HarfBuzzShaper::selectionRect):

  • platform/graphics/harfbuzz/ng/HarfBuzzShaper.h: Added.

(WebCore):
(HarfBuzzShaper):
(WebCore::HarfBuzzShaper::totalWidth):
(HarfBuzzRun):
(WebCore::HarfBuzzShaper::HarfBuzzRun::create):
(WebCore::HarfBuzzShaper::HarfBuzzRun::setWidth):
(WebCore::HarfBuzzShaper::HarfBuzzRun::numCharacters):
(WebCore::HarfBuzzShaper::HarfBuzzRun::numGlyphs):
(WebCore::HarfBuzzShaper::HarfBuzzRun::width):
(WebCore::HarfBuzzShaper::HarfBuzzRun::rtl):

  • platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore):
(WebCore::preferHarfBuzz): Added.
(WebCore::Font::selectionRectForComplexText): Use HarfBuzzShaper if font-feature-settings exists.
(WebCore::Font::drawComplexText): Ditto.
(WebCore::Font::floatWidthForComplexText): Ditto.
(WebCore::Font::offsetForPositionForComplexText): Ditto.

LayoutTests:

  • platform/chromium/TestExpectations: Updated expectation of css3/font-feature-settings-rendering.html. The result need to be rebaselined.
8:39 PM Changeset in webkit [120155] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed: Update expectations

fast/forms/datetimelocal/input-valueasdate-datetimelocal.html is
passing, so I expanded fast/forms/datetimelocal to TEXT failures
for all other tests. See bug 29359.

Likewise for
fast/forms/color/input-value-sanitization-color.html. See bug
88951.

fast/js/integer-division-neg2tothe32-by-neg1.html is passing on
Chromium WebKit waterfall, so updating CRASH to PASS CRASH. See
bug 81732.

  • platform/chromium/TestExpectations:
8:31 PM Changeset in webkit [120154] by macpherson@chromium.org
  • 27 edits
    2 adds in trunk/Source/WebCore

WIP: Implement CSS Variables Standard.
​https://bugs.webkit.org/show_bug.cgi?id=85580

Reviewed by Ojan Vafai.

Implement CSS Variables Module Level 1. (See ​http://www.w3.org/TR/css-variables/)

A HashMap of properties is referenced by RenderStyle, and used to store variables as strings.
That HashMap is copy-on-write, and unless new variables are defined is simply a pointer to the
parent's definitions. At usage time the variable's value is parsed according to the CSS property
where it is used.
Variables can:

Define lists of values (ie. entire shorthand values).
Define individual values.
Refer to other variables. (Cycle detection is implemented).

Please see the supplied test cases for example usage.

Missing features:

CSS variables cannot yet be used inside some functions such as -webkit-calc.

Covered by existing test suite under fast/css/variables.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSGrammar.y:
  • css/CSSParser.cpp:

(WebCore):
(WebCore::filterProperties):
(WebCore::CSSParser::createStylePropertySet):
(WebCore::CSSParser::validUnit):
(WebCore::CSSParser::createPrimitiveNumericValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::storeVariableDeclaration):
(WebCore::CSSParser::detectDashToken):
(WebCore::CSSParser::lex):

  • css/CSSParser.h:

(CSSParser):

  • css/CSSParserValues.cpp:

(WebCore::CSSParserValue::createCSSValue):

  • css/CSSPrimitiveValue.cpp:

(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::getStringValue):
(WebCore::CSSPrimitiveValue::customSerializeResolvingVariables):
(WebCore):

  • css/CSSPrimitiveValue.h:

(CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::isVariableName):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSValue.cpp:

(WebCore::CSSValue::serializeResolvingVariables):
(WebCore):
(WebCore::CSSValue::destroy):

  • css/CSSValue.h:

(CSSValue):
(WebCore::CSSValue::isVariableValue):

  • css/CSSValueList.cpp:

(WebCore):
(WebCore::CSSValueList::customSerializeResolvingVariables):

  • css/CSSValueList.h:

(CSSValueList):

  • css/CSSVariableValue.h: Added.

(WebCore):
(CSSVariableValue):
(WebCore::CSSVariableValue::create):
(WebCore::CSSVariableValue::name):
(WebCore::CSSVariableValue::value):
(WebCore::CSSVariableValue::CSSVariableValue):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • css/StyleResolver.h:
  • css/WebKitCSSTransformValue.cpp:

(WebCore):
(WebCore::WebKitCSSTransformValue::customSerializeResolvingVariables):

  • css/WebKitCSSTransformValue.h:

(WebKitCSSTransformValue):

  • css/makeprop.pl:
  • rendering/style/RenderStyle.h:
  • rendering/style/StyleVariableData.h: Added.

(WebCore):
(StyleVariableData):
(WebCore::StyleVariableData::create):
(WebCore::StyleVariableData::copy):
(WebCore::StyleVariableData::operator==):
(WebCore::StyleVariableData::operator!=):
(WebCore::StyleVariableData::setVariable):
(WebCore::StyleVariableData::StyleVariableData):

8:23 PM Changeset in webkit [120153] by ggaren@apple.com
  • 2 edits in trunk/Source/WTF

Try to fix the build.

Maybe don't export inlined functions.

  • wtf/ThreadingPrimitives.h:

(WTF::MutexTryLocker::MutexTryLocker):
(WTF::MutexTryLocker::~MutexTryLocker):
(WTF::MutexTryLocker::locked):

8:05 PM Changeset in webkit [120152] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed: Update expectations for video-media-source-add-and-remove-ids.html
​https://bugs.webkit.org/show_bug.cgi?id=88949

  • platform/chromium/TestExpectations:
7:50 PM Changeset in webkit [120151] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix for case-sensitive file systems: use the right case.

  • heap/ListableHandler.h:
7:37 PM Changeset in webkit [120150] by Lucas Forschler
  • 2 edits in trunk/Tools

Wrap bot types inside ().
​https://bugs.webkit.org/show_bug.cgi?id=88893

Reviewed by Stephanie Lewis.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
7:06 PM Changeset in webkit [120149] by ggaren@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

GC should be 1.7X faster
​https://bugs.webkit.org/show_bug.cgi?id=88840

Reviewed by Oliver Hunt.

I profiled, and removed anything that showed up as a concurrency
bottleneck. Then, I added 3 threads to our max thread count, since we
can scale up to more threads now.

  • heap/BlockAllocator.cpp:

(JSC::BlockAllocator::BlockAllocator):
(JSC::BlockAllocator::~BlockAllocator):
(JSC::BlockAllocator::releaseFreeBlocks):
(JSC::BlockAllocator::waitForRelativeTimeWhileHoldingLock):
(JSC::BlockAllocator::waitForRelativeTime):
(JSC::BlockAllocator::blockFreeingThreadMain):

  • heap/BlockAllocator.h:

(BlockAllocator):
(JSC::BlockAllocator::allocate):
(JSC::BlockAllocator::deallocate): Use a spin lock for the common case
where we're just popping a linked list. (A pthread mutex would sleep our
thread even if the lock were only contended for a microsecond.)

Scope the lock to avoid holding it while allocating VM, since that's a
slow activity and it doesn't modify any of our data structures.

We still use a pthread mutex to handle our condition variable since we
have to, and it's not a hot path.

  • heap/CopiedSpace.cpp:

(JSC::CopiedSpace::CopiedSpace):
(JSC::CopiedSpace::doneFillingBlock):

  • heap/CopiedSpace.h:

(JSC::CopiedSpace::CopiedSpace): Use a spin lock for the to space lock,
since it just guards linked list and hash table manipulation.

  • heap/MarkStack.cpp:

(JSC::MarkStackSegmentAllocator::MarkStackSegmentAllocator):
(JSC::MarkStackSegmentAllocator::allocate):
(JSC::MarkStackSegmentAllocator::release):
(JSC::MarkStackSegmentAllocator::shrinkReserve): Use a spin lock, since
we're just managing a linked list.

(JSC::MarkStackArray::donateSomeCellsTo): Changed donation to be proportional
to our current stack size. This fixes cases where we used to donate too
much. Interestingly, donating too much was starving the donor (when it
ran out of work later) *and* the recipient (since it had to wait on a
long donation operation to complete before it could acquire the lock).

In the worst case, we're still guaranteed to donate N cells in roughly log N time.

This change also fixes cases where we used to donate too little, since
we would always keep a fixed minimum number of cells. In the worst case,
with N marking threads, would could have N large object graph roots in
our stack for the duration of GC, and scale to only 1 thread.

It's an interesting observation that a single object in the mark stack
might represent an arbitrarily large object graph -- and only the act
of marking can find out.

(JSC::MarkStackArray::stealSomeCellsFrom): Steal in proportion to idle
threads. Once again, this fixes cases where constants could cause us
to steal too much or too little.

(JSC::SlotVisitor::donateKnownParallel): Always wake up other threads
if they're idle. We can afford to do this because we're conservative
about when we donate.

(JSC::SlotVisitor::drainFromShared):

  • heap/MarkStack.h:

(MarkStackSegmentAllocator):
(MarkStackArray):
(JSC):

  • heap/SlotVisitor.h: Merged the "should I donate?" decision into a

single function, for simplicity.

  • runtime/Options.cpp:

(minimumNumberOfScansBetweenRebalance): Reduced the delay before donation
a lot. We can afford to do this because, in the common case, donation is
a single branch that decides not to donate.

(cpusToUse): Use more CPUs now, since we scale better now.

  • runtime/Options.h:

(Options): Removed now-unused variables.

6:29 PM Changeset in webkit [120148] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(120121): inspector tests crash in DFG
​https://bugs.webkit.org/show_bug.cgi?id=88941

Reviewed by Geoffrey Garen.

The CFG simplifier has two different ways of fixing up GetLocal, Phantom, and Flush. If we've
already fixed up the node one way, we shouldn't try the other way. The reason why we shouldn't
is that the second way depends on the node referring to other nodes in the to-be-jettisoned
block. After fixup they potentially will refer to nodes in the block being merged to.

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::fixPossibleGetLocal):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):

6:28 PM Changeset in webkit [120147] by morrita@google.com
  • 13 edits
    2 adds in trunk

Shadow Pseudo ID should be able to nest to point nested shadow DOM.
​https://bugs.webkit.org/show_bug.cgi?id=62218

Reviewed by Dimitri Glazkov.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • updateSpecifiersWithElementName() didn't take nesting into account. tag history can contain selector entries which isn't marked as ShadowDescendant yet. such entry can be found by investigating isUnknownPseudoElement().
  • SelectorChecker::checkSelector() was too strict. Unknown pseudo elements are essentially a kind of class or id in implementation perspective. For such, rejecting by missing elementStyle doesn't make sense: It isn't a pseudo but a real element for WebCore after all.
  • Added Internals::setShadowPseudoId() to create a test harness whose DOM tree contains pseudo shadow ids.

Before this change, following selecdtor chain is created for "p::-shadow-child::-nested-shadow-child":

[both tag name and -shadow-id are set] <-(ShadowDescendant)- [-nested-shadow-id]

What we want, which is created by this change is:

[tag] <-(ShadowDescendant)- [-shadow-id is set] <-(ShadowdescenDant)- [-nested-shadow-id]

Test: fast/dom/shadow/shadow-nested-pseudo-id.html

  • WebCore.exp.in:
  • css/CSSParser.cpp:

(WebCore::CSSParser::updateSpecifiersWithElementName):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOneSelector):

  • testing/Internals.cpp:

(WebCore::Internals::setShadowPseudoId):
(WebCore):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

  • fast/dom/shadow/shadow-nested-pseudo-id-expected.txt: Added.
  • fast/dom/shadow/shadow-nested-pseudo-id.html: Added.
5:42 PM BuildingOnWindows edited by alex.christensen@flexsim.com
There is no directory called OpenSource. LayoutTests is just in the … (diff)
5:39 PM Changeset in webkit [120146] by ojan@chromium.org
  • 4 edits in trunk/LayoutTests

Chromium rebaselines after r120135. The new results are clearly more correct.

  • platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-expected.png:
  • platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
  • platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
5:33 PM Changeset in webkit [120145] by commit-queue@webkit.org
  • 8 edits in trunk

[soup] Prevent setting or editing httpOnly cookies from JavaScript
​https://bugs.webkit.org/show_bug.cgi?id=88760

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-12
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Prevent setting or overwriting httpOnly cookies from JavaScript.
Fix setCookies() so that it parses all the cookies and not just
the first one.

Test: http/tests/cookies/js-get-and-set-http-only-cookie.html

  • platform/network/soup/CookieJarSoup.cpp:

(WebCore::httpOnlyCookieExists):
(WebCore):
(WebCore::setCookies):

Tools:

Update libsoup to v2.39.2, glib to v2.33.2 and glib-networking
to v2.33.2 for both GTK and EFL ports.

  • efl/jhbuild.modules:
  • gtk/jhbuild.modules:

LayoutTests:

Unskip http/tests/cookies/js-get-and-set-http-only-cookie.html for
both GTK and EFL ports now that that we don't allow overwriting
httpOnly cookies from JavaScript anymore.

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
5:28 PM Changeset in webkit [120144] by commit-queue@webkit.org
  • 19 edits
    3 adds in trunk

[EFL] Enable SHADOW_DOM flag
​https://bugs.webkit.org/show_bug.cgi?id=87732

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-12
Reviewed by Kentaro Hara.

.:

Enable SHADOW_DOM flag by default at compile time for EFL port.

  • Source/autotools/symbols.filter: Fix GTK build by adding new symbol.
  • Source/cmake/OptionsEfl.cmake:
  • Source/cmakeconfig.h.cmake:

Source/WebCore:

Test: fast/dom/shadow/shadow-root-innerHTML.html

  • dom/ShadowRoot.idl: Add JSGenerateToJSObject extended attribute so

that the ShadowRoot properties are accessible on JS side.

  • testing/Internals.idl: Fix SHADOW_DOM ifdef check.

Source/WebKit:

Add WebCore/bindings/generic to include directories so
that we can include RuntimeEnabledFeatures.h.

  • CMakeLists.txt:

Source/WebKit/efl:

Add Ewk setting to toggle Shadow DOM support at runtime.

  • ewk/ewk_settings.cpp:

(ewk_settings_shadow_dom_enable_get):
(ewk_settings_shadow_dom_enable_set):

  • ewk/ewk_settings.h:

Tools:

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues): Enable
SHADOW_DOM by default in DRT.

  • DumpRenderTree/efl/DumpRenderTreeView.cpp:

(onFocusCanCycle): Enable focus cycling in EFL DRT to behave like
Chromium and Mac ports.
(drtViewAdd):

  • Scripts/webkitperl/FeatureList.pm: Enable SHADOW_DOM flag by default

at compile time for EFL port.

LayoutTests:

Unskip most of the test cases associated to Shadow DOM now that the
feature is enabled by default for EFL's DRT.

  • platform/efl/Skipped:
  • platform/efl/TestExpectations:
  • platform/efl/fast/dom/shadow/form-in-shadow-expected.txt: Added.
  • platform/efl/fast/dom/shadow/tab-order-iframe-and-shadow-expected.txt: Added.
5:23 PM Changeset in webkit [120143] by leo.yang@torchmobile.com.cn
  • 4 edits in trunk/Source

Dynamic hash table in DOMObjectHashTableMap is wrong in multiple threads
​https://bugs.webkit.org/show_bug.cgi?id=87334

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Add a copy member function to JSC::HasTable. This function will copy all data
members except for *table* which contains thread specific data that prevents
up copying it. When you want to copy a JSC::HashTable that was constructed
on another thread you should call JSC::HashTable::copy().

  • runtime/Lookup.h:

(JSC::HashTable::copy):
(HashTable):

Source/WebCore:

Adapt to JSC::HashTable::copy to avoid copy dynamic table member of a HashTable.
The dynamic table may be allocated on other thread and contains thread specific
identifiers. For example, a hash table of JSEntryArray was first initialized on a
worker thread, and then the user reloaded the page, another worker thread is
created due to reload, the dynamic allocated table in *staticTable* is specific
to the first worker thread which has died. If the user reload the page again,
the dynamic table will be freed and memory corruption will occur.

No functionalities changed, no new tests.

  • bindings/js/DOMObjectHashTableMap.h:

(WebCore::DOMObjectHashTableMap::get):

5:10 PM Changeset in webkit [120142] by commit-queue@webkit.org
  • 8 edits in trunk/Source

[chromium] Port Canvas2DLayerBridge over to WebExternalTextureLayer
​https://bugs.webkit.org/show_bug.cgi?id=88597

Patch by James Robinson <​jamesr@chromium.org> on 2012-06-12
Reviewed by Adrienne Walker.

Source/Platform:

This adds two new APIs to WebExternalTextureLayer that are used by the accelerated 2d canvas path:

  • willModifyTexture() is called to indicate that a system outside the compositor's control is about to modify

the texture backing the WebExternalTextureLayer. This indicates to the compositor that it needs to avoid
producing more frames using this texture until it can do a full commit - either by double buffering or
appropriate flow control.

  • setRateLimitContext() is called to enable rate limiting for this texture. The rate limiting logic blocks if

too many invalidate() or invalidateRect() calls are made on the texture outside of the context of a
WebLayerTreeViewClient::updateAnimations() call to prevent a non-vsynced producer from getting too far ahead of
the compositor.

  • chromium/public/WebExternalTextureLayer.h:

(WebKit::WebExternalTextureLayer::WebExternalTextureLayer):
(WebExternalTextureLayer):

Source/WebCore:

This converts Canvas2DLayerBridge to using public WebLayer API types instead of LayerChromium types.

  • platform/graphics/chromium/Canvas2DLayerBridge.cpp:

(WebCore::AcceleratedDeviceContext::AcceleratedDeviceContext):
(WebCore::AcceleratedDeviceContext::prepareForDraw):
(AcceleratedDeviceContext):
(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::skCanvas):
(WebCore::Canvas2DLayerBridge::prepareTexture):
(WebCore::Canvas2DLayerBridge::context):
(WebCore::Canvas2DLayerBridge::layer):
(WebCore::Canvas2DLayerBridge::contextAcquired):

  • platform/graphics/chromium/Canvas2DLayerBridge.h:

(WebCore):
(Canvas2DLayerBridge):

Source/WebKit/chromium:

Implementations for new WebExternalTextureLayer APIs, updates test.

  • src/WebExternalTextureLayer.cpp:

(WebKit::WebExternalTextureLayer::willModifyTexture):
(WebKit):
(WebKit::WebExternalTextureLayer::setRateLimitContext):

  • tests/Canvas2DLayerBridgeTest.cpp:

(Canvas2DLayerBridgeTest::fullLifecycleTest):

5:04 PM Changeset in webkit [120141] by Lucas Forschler
  • 4 edits in branches/safari-536-branch

Merged r119280 -> <rdar://problem/11620927>

5:01 PM Changeset in webkit [120140] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Add some expecations to green the chromium tree while the bugs are resolved.

  • platform/chromium/TestExpectations:
4:56 PM Changeset in webkit [120139] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebKit2

Merged r119758 -> <rdar://problem/11430118>

4:40 PM Changeset in webkit [120138] by beidson@apple.com
  • 1 edit
    13 moves in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=88928
[WK2] New http/tests/loading/* tests fail

There's some latent timing issue with WK2 tests that prevents us from getting the last load delegate callback
before finishing the test.

Fortunately for the sake of these tests the load delegate dumps are entirely irrelevant.
Moving them from http/tests/loading to http/tests/misc and getting new, cleaner results fixes this.

Rubberstamped by Darin Adler.

  • http/tests/misc/embed-image-load-outlives-gc-without-crashing-expected.txt: Renamed from LayoutTests/http/tests/loading/embed-image-load-outlives-gc-without-crashing-expected.txt.
  • http/tests/misc/embed-image-load-outlives-gc-without-crashing.html: Renamed from LayoutTests/http/tests/loading/embed-image-load-outlives-gc-without-crashing.html.
  • http/tests/misc/image-input-type-outlives-gc-without-crashing-expected.txt: Renamed from LayoutTests/http/tests/loading/image-input-type-outlives-gc-without-crashing-expected.txt.
  • http/tests/misc/image-input-type-outlives-gc-without-crashing.html: Renamed from LayoutTests/http/tests/loading/image-input-type-outlives-gc-without-crashing.html.
  • http/tests/misc/image-load-outlives-gc-without-crashing-expected.txt: Renamed from LayoutTests/http/tests/loading/image-load-outlives-gc-without-crashing-expected.txt.
  • http/tests/misc/image-load-outlives-gc-without-crashing.html: Renamed from LayoutTests/http/tests/loading/image-load-outlives-gc-without-crashing.html.
  • http/tests/misc/object-image-load-outlives-gc-without-crashing-expected.txt: Renamed from LayoutTests/http/tests/loading/object-image-load-outlives-gc-without-crashing-expected.txt.
  • http/tests/misc/object-image-load-outlives-gc-without-crashing.html: Renamed from LayoutTests/http/tests/loading/object-image-load-outlives-gc-without-crashing.html.
  • http/tests/misc/resources/slowimage.php: Renamed from LayoutTests/http/tests/loading/resources/slowimage.php.
  • http/tests/misc/svg-image-load-outlives-gc-without-crashing-expected.txt: Renamed from LayoutTests/http/tests/loading/svg-image-load-outlives-gc-without-crashing-expected.txt.
  • http/tests/misc/svg-image-load-outlives-gc-without-crashing.html: Renamed from LayoutTests/http/tests/loading/svg-image-load-outlives-gc-without-crashing.html.
  • http/tests/misc/video-poster-image-load-outlives-gc-without-crashing-expected.txt: Renamed from LayoutTests/http/tests/loading/video-poster-image-load-outlives-gc-without-crashing-expected.txt.
  • http/tests/misc/video-poster-image-load-outlives-gc-without-crashing.html: Renamed from LayoutTests/http/tests/loading/video-poster-image-load-outlives-gc-without-crashing.html.
4:16 PM Changeset in webkit [120137] by fpizlo@apple.com
  • 4 edits
    3 adds in trunk

DFG should not ASSERT if you have a double use of a variable that is not revealed to be a double
until after CFG simplification
​https://bugs.webkit.org/show_bug.cgi?id=88927
<rdar://problem/11513971>

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

Speculation fixup needs to run if simplification did things, because simplification can change
predictions - particularly if you had a control flow path that stored weird things into a
variable, but that path got axed by the simplifier.

Running fixup in the fixpoint requires making it idempotent, which it previously wasn't. Only
one place needed to be changed, namely the un-MustGenerate-ion of ValueToInt32.

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

LayoutTests:

Reviewed by Geoffrey Garen.

  • fast/js/dfg-double-use-of-post-simplification-double-prediction-expected.txt: Added.
  • fast/js/dfg-double-use-of-post-simplification-double-prediction.html: Added.
  • fast/js/script-tests/dfg-double-use-of-post-simplification-double-prediction.js: Added.

(foo):

4:07 PM Changeset in webkit [120136] by alexis.menard@openbossa.org
  • 3 edits in trunk/Source/WebCore

Fix packing in StyleBoxData for Windows.
​https://bugs.webkit.org/show_bug.cgi?id=88858

Reviewed by Tony Chang.

MSVC doesn't pack bitfields if the types are mixed.
We can safely change the bool type to an unsigned so
the packing will happen. I have added a compile assert
for future regressions.

No new tests : we should not see any regressions.

  • rendering/style/StyleBoxData.h:
  • rendering/style/StyleBoxData.cpp:

(StyleBoxData):

4:04 PM Changeset in webkit [120135] by enne@google.com
  • 11 edits in trunk/Source

[chromium] Paint scrollbars on WebKit thread and composite those textures
​https://bugs.webkit.org/show_bug.cgi?id=88145

Reviewed by James Robinson.

Source/WebCore:

Scrollbars were previously painted and uploaded on the compositor
thread. This isn't possible to do for many scrollbar themes. This
patch changes ScrollbarLayerChromium to paint the scrollbar into two
parts: the thumb, and everything else. These are uploaded into
textures and synced over to the CCScrollbarImpl where they are
composited and drawn.

Mac and overlay scrollbars are still not enabled to have compositor
thread-updated scrollbars.

As a bonus, fix LayerRendererChromium::drawTextureQuad to draw quads
that do not fill the entire layer bounds.

Tested by existing layout and unit tests by removing the condition
that these scrollbar layers are only created when the threaded proxy
exists.

  • page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::scrollbarLayerDidChange):

  • platform/ScrollbarThemeComposite.cpp:

(WebCore::ScrollbarThemeComposite::thumbRect):
(WebCore):

  • platform/ScrollbarThemeComposite.h:

(ScrollbarThemeComposite):

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawTextureQuad):

  • platform/graphics/chromium/ScrollbarLayerChromium.cpp:

(WebCore::ScrollbarLayerChromium::ScrollbarLayerChromium):
(WebCore::ScrollbarLayerChromium::theme):
(WebCore):
(WebCore::ScrollbarLayerChromium::pushPropertiesTo):
(ScrollbarBackgroundPainter):
(WebCore::ScrollbarBackgroundPainter::create):
(WebCore::ScrollbarBackgroundPainter::paint):
(WebCore::ScrollbarBackgroundPainter::ScrollbarBackgroundPainter):
(ScrollbarThumbPainter):
(WebCore::ScrollbarThumbPainter::create):
(WebCore::ScrollbarThumbPainter::paint):
(WebCore::ScrollbarThumbPainter::ScrollbarThumbPainter):
(WebCore::ScrollbarLayerChromium::setLayerTreeHost):
(WebCore::ScrollbarLayerChromium::createTextureUpdaterIfNeeded):
(WebCore::ScrollbarLayerChromium::updatePart):
(WebCore::ScrollbarLayerChromium::update):

  • platform/graphics/chromium/ScrollbarLayerChromium.h:

(WebCore):
(ScrollbarLayerChromium):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:

(WebCore::CCScrollbarLayerImpl::CCScrollbarLayerImpl):
(WebCore::CCScrollbarLayerImpl::appendQuads):

  • platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:

(WebCore::CCScrollbarLayerImpl::setBackgroundTextureId):
(WebCore::CCScrollbarLayerImpl::setThumbTextureId):
(CCScrollbarLayerImpl):

Source/WebKit/chromium:

Remove scrollbarLayerLostContext test that no longer makes sense. The
compositor won't draw at all after a lost context if it has no
contents.

  • tests/CCLayerTreeHostImplTest.cpp:
3:52 PM Changeset in webkit [120134] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Crash when rendering web page that's being destroyed
​https://bugs.webkit.org/show_bug.cgi?id=88915

Patch by Arvid Nilsson <​anilsson@rim.com> on 2012-06-12
Reviewed by Rob Buis.

PR #164943

This was a null pointer dereference that happened when the compositor
was asked to render after being disconnected from its web page.

  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::render):

3:47 PM Changeset in webkit [120133] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

WinLauncher should show loading errors
​https://bugs.webkit.org/show_bug.cgi?id=80760

Patch by Ashod Nakashian <​ashodnakashian@yahoo.com> on 2012-06-12
Reviewed by Brent Fulgham.

  • WinLauncher/WinLauncher.cpp: Added load-fail handler to show messagebox with error.

(WinLauncherWebHost::didFailProvisionalLoadWithError):

  • WinLauncher/WinLauncher.h:

(WinLauncherWebHost::didFailProvisionalLoadWithError):
(WinLauncherWebHost):

3:39 PM Changeset in webkit [120132] by tony@chromium.org
  • 4 edits
    2 adds in trunk

Replaced items in a flexbox should be coerced to display:block
​https://bugs.webkit.org/show_bug.cgi?id=87068

Reviewed by Ojan Vafai.

Source/WebCore:

The flexbox spec lists HTML tags that should automatically be converted
to display:block when a flex child. It also says that atomic inline-level
children should become block (e.g., inline-table should be treated as table).
​http://dev.w3.org/csswg/css3-flexbox/#flex-items

Test: css3/flexbox/flexitem.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

LayoutTests:

  • css3/flexbox/flexitem-expected.txt: Added.
  • css3/flexbox/flexitem.html: Added.
  • css3/flexbox/resources/flexbox.js:

(checkExpectedValues):

3:36 PM Changeset in webkit [120131] by jsbell@chromium.org
  • 20 edits
    7 adds in trunk

IndexedDB: ObjectStore/Index shouldn't hold reference to backing store
​https://bugs.webkit.org/show_bug.cgi?id=83074

Reviewed by Tony Chang.

Source/WebCore:

We should be able to collect and close the leveldb backing store as soon as the database
connection is closed, but the IDBObjectStoreBackendImpl and IDBIndexBackendImpl were
holding RefPtrs, and those objects are kept alive by script references.

Replaced RefPtrs to the IDBBackingStore with pointers to the IDBDatabase. On the back end,
IDBDatabaseBackendImpl maintains a RefPtr to the IDBObjectStoreBackendImpl object, so
a raw pointer back is safe. On the front end, the IDBObjectStore maintains a RefPtr to
the IDBDatabase so script can navigate upwards. Ditto on both ends for the ObjectStore/Index
relationship. The frontend objects maintain RefPtrs to the backend objects, so the backend
objects and their owners are maintained as long as there's a script reference. To ensure
that all LevelDB objects are destructed in the right order, transactions indirectly track all
open cursors and ensure they are closed when the transaction finishes, and database closing
is explicitly prevented from occurring until transactions are complete.

Also made IDBDatabaseBackendImpl handle a null IDBFactoryBackendImpl pointer, for testing.

Tests: storage/indexeddb/database-close.html

storage/indexeddb/persistence.html
[Chromium] webkit_unit_tests --gtest_filter=IDBDatabaseBackendTest.BackingStoreRetention

  • Modules/indexeddb/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::close): Release LevelDB resources when closed to allow backing store to close.

  • Modules/indexeddb/IDBCursorBackendImpl.h:

(WebCore):

  • Modules/indexeddb/IDBDatabase.cpp: Ensure connection close deferred until all transactions are finished.

(WebCore::IDBDatabase::transactionCreated): Accounting.
(WebCore::IDBDatabase::transactionFinished): Accounting.
(WebCore::IDBDatabase::close):
(WebCore):
(WebCore::IDBDatabase::closeConnection):

  • Modules/indexeddb/IDBDatabase.h:

(IDBDatabase):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp: Track outstanding transactions for forced-close scenarios.

(WebCore::IDBDatabaseBackendImpl::~IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::createObjectStore): Don't pass in backing store reference.
(WebCore::IDBDatabaseBackendImpl::setVersion): Use transaction() for consistent accounting.
(WebCore::IDBDatabaseBackendImpl::transactionFinished): Accounting.
(WebCore::IDBDatabaseBackendImpl::transaction): Accounting.
(WebCore::IDBDatabaseBackendImpl::close): Unregister from factory when last connection is closed.
(WebCore::IDBDatabaseBackendImpl::loadObjectStores): Don't pass in backing store reference.
(WebCore::IDBDatabaseBackendImpl::removeObjectStoreFromMap):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(WebCore):
(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::deleteDatabase): Don't hang on to deleted databases eternally.

  • Modules/indexeddb/IDBFactoryBackendImpl.h: Backend map controls IDBDatabaseBackend lifetimes.

(IDBFactoryBackendImpl):

  • Modules/indexeddb/IDBIndexBackendImpl.cpp: Don't hold backing store references.

(WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl):

  • Modules/indexeddb/IDBIndexBackendImpl.h:

(WebCore::IDBIndexBackendImpl::create):
(IDBIndexBackendImpl):
(WebCore::IDBIndexBackendImpl::backingStore):
(WebCore::IDBIndexBackendImpl::databaseId):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp: Don't hold backing store references.

(WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::loadIndexes):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(WebCore::IDBObjectStoreBackendImpl::create):
(IDBObjectStoreBackendImpl):
(WebCore::IDBObjectStoreBackendImpl::backingStore):
(WebCore::IDBObjectStoreBackendImpl::databaseId):

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::onSuccess):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::IDBTransaction): For IDBDatabase accounting, allow ref during ctor.
(WebCore::IDBTransaction::onAbort): Accounting.
(WebCore::IDBTransaction::onComplete): Accounting.

  • Modules/indexeddb/IDBTransaction.h:

(WebCore::IDBTransaction::isVersionChange): Convenience function.
(IDBTransaction):

  • Modules/indexeddb/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::abort): Cleanup ordering to allow backing store to close.
(WebCore::IDBTransactionBackendImpl::commit): Cleanup ordering to allow backing store to close.

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/IDBDatabaseBackendTest.cpp: Added.

(WebCore):
(WebCore::TEST):

LayoutTests:

The storage/indexeddb/persistence.html test verifies ​http://webkit.org/b/88788 which
was revealed by this patch set. The storage/indexeddb/database-close.html test verifies
the precise database connection closing semantics defined in the IDB spec.

  • storage/indexeddb/database-close-expected.txt: Added.
  • storage/indexeddb/database-close.html: Added.
  • storage/indexeddb/persistence-expected.txt: Added.
  • storage/indexeddb/persistence.html: Added.
  • storage/indexeddb/resources/database-close.js: Added.

(test):
(openConnection.request.onsuccess.request.onsuccess):
(openConnection.request.onsuccess):
(openConnection):
(openVersionChangeConnection.request2.onsuccess):
(openVersionChangeConnection):
(testClose.transactionCompleted):
(testClose.request.onsuccess):
(testClose):

  • storage/indexeddb/resources/persistence.js: Added.

(test):
(openAndChangeVersion.request.onsuccess.request.onsuccess.trans.oncomplete):
(openAndChangeVersion.request.onsuccess.request.onsuccess):
(openAndChangeVersion.request.onsuccess):

3:19 PM Changeset in webkit [120130] by ryuan.choi@samsung.com
  • 2 edits
    3 adds in trunk/Tools

[EFL][WK2] Add MiniBrowserEfl.
​https://bugs.webkit.org/show_bug.cgi?id=61850

Reviewed by Chang Shu.

Implement MiniBrowser for EFL.

  • CMakeLists.txt:
  • MiniBrowser/efl/CMakeLists.txt: Added.
  • MiniBrowser/efl/main.c: Added.

(_MiniBrowser):
(main_signal_exit):
(on_ecore_evas_resize):
(browserCreate):
(main):

3:12 PM Changeset in webkit [120129] by enne@google.com
  • 3 edits in trunk/Source/WebCore

[chromium] Don't set visible layer rect in CCLayerTreeHost paint iteration
​https://bugs.webkit.org/show_bug.cgi?id=88895

Reviewed by James Robinson.

We should only set visible layer rects during the recursion in
CClayerTreeHostCommon and not while we're painting. This is one last
straggling piece of code that never got moved.

Tested by existing mask-related layout tests.

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::paintMasksForRenderSurface):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateVisibleAndScissorRectsInternal):

3:02 PM Changeset in webkit [120128] by danakj@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Set contentBounds() on impl layers in CCLayerTreeHostCommonTests
​https://bugs.webkit.org/show_bug.cgi?id=88903

Reviewed by Adrienne Walker.

Without setting the contentBounds() on impl layers, the visibleLayerRect
will be wrong. This is not the case for main-thread layers, which most
of the tests in this file use. But this is a potential serious confusion
for future test implementors so I'd like to make it explicit now.

  • tests/CCLayerTreeHostCommonTest.cpp:
2:57 PM Changeset in webkit [120127] by danakj@chromium.org
  • 4 edits in trunk/Source

[chromium] Return empty visibleLayerRect for layers with empty content bounds
​https://bugs.webkit.org/show_bug.cgi?id=88901

Reviewed by Adrienne Walker.

Source/WebCore:

This change should only affect tests. Currently if you set up a
CCLayerImpl with some bounds, but don't set the contentBounds, then
they are empty by default. In this case the visibleLayerRect gets
set inappropriately to the layer's target surface contentRect which
in a completely different coordinate space.

Fixed up tests that were passing bogusly and failed after this change.

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::calculateVisibleLayerRect):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:
2:55 PM Changeset in webkit [120126] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviwed nightly gardening.

  • platform/qt/Skipped:
2:46 PM Changeset in webkit [120125] by enne@google.com
  • 4 edits in trunk/Source/WebCore

[chromium] ScrollingCoordinator::setScrollLayer should update scroll layer ids
​https://bugs.webkit.org/show_bug.cgi?id=88882

Reviewed by James Robinson.

Tested manually, as scrollbar layers are currently only created when
threaded compositing is enabled and none of those layout tests trigger
this bug.

  • page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::ScrollingCoordinatorPrivate::setScrollLayer):
(ScrollingCoordinatorPrivate):
(WebCore::ScrollingCoordinatorPrivate::setHorizontalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::setVerticalScrollbarLayer):
(WebCore::createScrollbarLayer):
(WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):

  • platform/graphics/chromium/ScrollbarLayerChromium.h:

(WebCore::ScrollbarLayerChromium::setScrollLayerId):
(ScrollbarLayerChromium):

  • platform/graphics/chromium/TreeSynchronizer.cpp:

(WebCore::TreeSynchronizer::updateScrollbarLayerPointersRecursive):

2:44 PM Changeset in webkit [120124] by zhajiang@rim.com
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Scale was incorrect when reloading a simple web page after initial load
​https://bugs.webkit.org/show_bug.cgi?id=88889

Reviewed by Adam Treat.
Patch by Jacky Jiang <​zhajiang@rim.com>

PR: 164442
When we were reloading a web page with the load type FrameLoadTypeSame
after the initial load, the first layout timer was fired after the load
Finished state, in which case the web page would have no chance to zoom
to the initial scale during the layout as it was only for load
Committed state. This patch takes care of it.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::layoutFinished):
(BlackBerry::WebKit::WebPagePrivate::shouldZoomToInitialScaleOnLoad):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad):

  • Api/WebPage_p.h:

(WebPagePrivate):

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDidFirstVisuallyNonEmptyLayout):

2:40 PM Changeset in webkit [120123] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Unreviwed nightly gardening.

  • platform/qt/Skipped: Remove rolled out tests.
  • platform/qt/fast/multicol/span/clone-flexbox-expected.txt: Updated after r120100.
2:39 PM Changeset in webkit [120122] by commit-queue@webkit.org
  • 6 edits in trunk/Source

Source/WebCore: [chromium mac] Don't include things in subframeworks of
ApplicationServices.framework.

Subframeworks move around from SDK to SDK and OS release to OS
release, but just using the top-level umbrella framework guarantees
forward compatibility. When building for Chromium Mac, just #include
<ApplicationServices/ApplicationServices.h> instead of reaching in to
subframeworks.

​https://bugs.webkit.org/show_bug.cgi?id=88569

Patch by Mark Mentovai <​mark@chromium.org> on 2012-06-12
Reviewed by Stephen White.

No new tests.

  • platform/graphics/GlyphBuffer.h:
  • platform/graphics/mac/ComplexTextControllerCoreText.mm:
  • platform/graphics/skia/GraphicsContextSkia.cpp:

Source/WebKit/chromium: [chromium mac] Don't #include things in subframeworks of
ApplicationServices.framework.

#including the umbrella <ApplicatonServices/ApplicationServices.h>
exposed an ambiguous name, FontMetrics, that needs to be fully
qualified as WebCore::FontMetrics.

​https://bugs.webkit.org/show_bug.cgi?id=88569

Patch by Mark Mentovai <​mark@chromium.org> on 2012-06-12
Reviewed by Stephen White.

  • src/WebFontImpl.cpp:

(WebKit::WebFontImpl::estimateTextBounds):

2:18 PM WebKit Team edited by Helder Correia
(diff)
2:15 PM Changeset in webkit [120121] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

REGRESSION (r119779): Javascript TypeError: 'undefined' is not an object
​https://bugs.webkit.org/show_bug.cgi?id=88783
<rdar://problem/11640299>

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

If you don't keep alive the base of an object access over the various checks
you do for the prototype chain, you're going to have a bad time.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleGetById):

LayoutTests:

Reviewed by Geoffrey Garen.

  • fast/js/dfg-proto-access-inline-osr-exit-expected.txt: Added.
  • fast/js/dfg-proto-access-inline-osr-exit.html: Added.
  • fast/js/script-tests/dfg-proto-access-inline-osr-exit.js: Added.

(foo):
(Thingy):

2:09 PM Changeset in webkit [120120] by helder@sencha.com
  • 2 edits in trunk/Tools

Unreviewed. Update my email address in committers.py.

  • Scripts/webkitpy/common/config/committers.py:
2:08 PM Changeset in webkit [120119] by igor.o@sisa.samsung.com
  • 10 edits
    8 adds in trunk

Apply animations and transitions for first-letter element
​https://bugs.webkit.org/show_bug.cgi?id=85253

Source/WebCore:

Add animations and transitions support for the first-letter
pseudo element.
Instead of calling RenderOject::node() in the animations code,
now we need to call RenderObject::styledGeneratingNode() because
pseudo elements does not have a Node associated with the
RenderObject.

Initial patch by Simon Fraser

Reviewed by Simon Fraser.

Tests: animations/first-letter-animation.html

animations/first-letter-play-state.html
transitions/first-letter-color-transition.html
transitions/first-letter-transition.html

  • page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::updateStateMachine):

  • page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::updateAnimations):
(WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
(WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
(WebCore::AnimationController::cancelAnimations):
(WebCore::AnimationController::updateAnimations):

  • page/animation/ImplicitAnimation.cpp:

(WebCore::ImplicitAnimation::pauseAnimation):
(WebCore::ImplicitAnimation::sendTransitionEvent):

  • page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::KeyframeAnimation):
(WebCore::KeyframeAnimation::pauseAnimation):
(WebCore::KeyframeAnimation::endAnimation):
(WebCore::KeyframeAnimation::sendAnimationEvent):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetterStyle):
(WebCore::RenderBlock::createFirstLetterRenderer):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::clippedOverflowRectForRepaint):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::setAnimatableStyle):
(WebCore::RenderObject::styledGeneratingNode):
(WebCore):

  • rendering/RenderObject.h:

(RenderObject):

LayoutTests:

Reviewed by Simon Fraser.

  • animations/first-letter-animation-expected.txt: Added.
  • animations/first-letter-animation.html: Added.
  • animations/first-letter-play-state-expected.txt: Added.
  • animations/first-letter-play-state.html: Added.
  • transitions/first-letter-color-transition-expected.txt: Added.
  • transitions/first-letter-color-transition.html: Added.
  • transitions/first-letter-transition-expected.txt: Added.
  • transitions/first-letter-transition.html: Added.
2:04 PM Changeset in webkit [120118] by tkent@chromium.org
  • 5 edits in trunk

Checking a radio button doesn't uncheck other buttons in the same group in some cases.
​https://bugs.webkit.org/show_bug.cgi?id=88835

Reviewed by Ryosuke Niwa.

Source/WebCore:

This change fixes a bug that checking a radio button in a radio button
group in a form detached from a document tree doesn't uncheck another
checked radio button in the radio button group.

A radio button participates in a radio button group in the following
conditions:

  • If it is owned by a form element regardless of the form is in a

document tree or not, or

  • If it is not owned by any form elements and it is in a document tree.

A radio button group for the radio button is owned by the document.

For HTMLInputElement::removedFrom():
The old code always unregistered the radio button if it was removed from
the document tree. It was incorrect because we don't need to unregister
it if it has an owner form and the owner form is not changed by
removedFrom().
If the owner form is cleared by removedFrom(), willChangeForm()
unregisters the radio button. So what we should do in removedFrom() is
to unregister the radio button only if the radio button group is owned
by the document.

For HTMLInputElement::insertedInto():
The old code always registered the radio button if it is inserted into
the document tree. It was incorrect because we don't need to register it
if it has an owner form and the owner form is not changed by
insertedInto().
If the owner form is changed by insertedInto(), didChangeForm()
registers the radio button. So We should register the radio button only
if its radio button group will be owned by the document.

Test: Add test cases to fast/forms/radio/radio-group.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::insertedInto):
Register this to CheckedRadioButtons only if new group owner is Document.
(WebCore::HTMLInputElement::removedFrom):
Unregister this from CheckedRadioButtons only if old group owner was Document.

LayoutTests:

  • fast/forms/radio/radio-group-expected.txt:
  • fast/forms/radio/radio-group.html: Add test cases.
1:54 PM Changeset in webkit [120117] by jamesr@google.com
  • 4 edits in trunk/Source

[chromium] REGRESSION(119769): Canvas2DLayerBridge may go away before its TextureLayerChromium
​https://bugs.webkit.org/show_bug.cgi?id=88910

Reviewed by Adrienne Walker.

Source/WebCore:

Unregister the bridge as its TextureLayerChromium client when going away.

Covered by new unit test in Canvas2DLayerBridgeTest.cpp.

  • platform/graphics/chromium/Canvas2DLayerBridge.cpp:

(WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):

Source/WebKit/chromium:

New unit test to verify that we can still update a TextureLayerChromium after the bridge owning it has gone
away.

  • tests/Canvas2DLayerBridgeTest.cpp:
1:54 PM Changeset in webkit [120116] by cevans@google.com
  • 1 edit in branches/chromium/1132/Source/WebCore/editing/CompositeEditCommand.cpp

Merge 119872
BUG=130927
Review URL: ​https://chromiumcodereview.appspot.com/10544115

1:50 PM Changeset in webkit [120115] by cevans@google.com
  • 5 edits in branches/chromium/1132/Source/WebCore/editing

Merge 119870
BUG=130722
Review URL: ​https://chromiumcodereview.appspot.com/10536125

1:45 PM Changeset in webkit [120114] by commit-queue@webkit.org
  • 18 edits in trunk

IndexedDB: Error codes, phase two
​https://bugs.webkit.org/show_bug.cgi?id=88690

Patch by Alec Flett <​alecflett@chromium.org> on 2012-06-12
Reviewed by Tony Chang.

Source/WebCore:

Update the next phase of IndexedDB error codes to match the spec.
This update is mostly focused on DATA_ERR vs CONSTRAINT_ERR.

Also moves some of the error checking for the transaction mode
into the frontend and replaces the backend checks with asserts, so that
we can consolidate error checking in one place.

This also removes a few FIXME's that are no longer true (about
I/O errors - the spec was updated and our implementation was
already correct)

No new tests, existing tests cover changed behavior.

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::deleteFunction):

  • Modules/indexeddb/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::deleteFunction):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::setVersionInternal):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(WebCore::IDBObjectStore::deleteFunction):
(WebCore::IDBObjectStore::clear):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::deleteFunction):
(WebCore::IDBObjectStoreBackendImpl::clear):

  • Modules/indexeddb/IDBTransaction.h:

(WebCore::IDBTransaction::enumMode):

  • Modules/indexeddb/IDBTransactionBackendImpl.h:

LayoutTests:

  • storage/indexeddb/cursor-advance-expected.txt:
  • storage/indexeddb/index-unique-expected.txt:
  • storage/indexeddb/mozilla/index-prev-no-duplicate-expected.txt:
  • storage/indexeddb/mozilla/index-prev-no-duplicate.html:
  • storage/indexeddb/objectstore-basics-expected.txt:
  • storage/indexeddb/objectstore-basics-workers-expected.txt:
  • storage/indexeddb/resources/cursor-advance.js:

(openSuccess):
(createObjectStore.trans.oncomplete):
(createObjectStore):
(populateObjectStore):

  • storage/indexeddb/resources/index-unique.js:

(addMoreDataFailed):

  • storage/indexeddb/resources/objectstore-basics.js:

(addAgainFailure):

1:38 PM Changeset in webkit [120113] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Resolve CMake warnings on overlapping search paths for EFL jhbuild-enabled build
​https://bugs.webkit.org/show_bug.cgi?id=84707

Fixing CMAKE prefix path for 64bit systems to avoid CMAKE warnings on those.
use_lib64 variable is preconfigured to True by jhbuild.

Patch by Dominik Röttsches <​dominik.rottsches@intel.com> on 2012-06-12
Reviewed by Dirk Pranke.

  • efl/jhbuildrc:
1:37 PM Changeset in webkit [120112] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk

Disable autoplay when user gesture is required for media playback
​https://bugs.webkit.org/show_bug.cgi?id=88897

Patch by Min Qin <​qinmin@google.com> on 2012-06-12
Reviewed by Adam Barth.

When user gesture is required for media playback, we should block autoplay.
Otherwise, people will use autoplay instead of video.play() to bypass the gesture requirement.
Test: media/no-autoplay-with-user-gesture-requirement.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setReadyState):

1:37 PM Changeset in webkit [120111] by rniwa@webkit.org
  • 150 edits in trunk/LayoutTests

Use testRunner in accessibility tests instead of layoutTestController
​https://bugs.webkit.org/show_bug.cgi?id=88755

Reviewed by Tony Chang.

Replaced all instances of layoutTestController in accessibility tests by testRunner.

  • accessibility/:
  • platform/chromium/accessibility/:
  • platform/gtk/accessibility/:
  • platform/mac/accessibility/:
  • platform/win/accessibility/:
1:27 PM Changeset in webkit [120110] by danakj@chromium.org
  • 2 edits in trunk/Tools

Add ​zlieber@chromium.org to contributors list
​https://bugs.webkit.org/show_bug.cgi?id=88904

Unreviewed.

  • Scripts/webkitpy/common/config/committers.py:
1:21 PM Changeset in webkit [120109] by Lucas Forschler
  • 2 edits in trunk/Tools

Rename Apple bots to a standard convention.
​https://bugs.webkit.org/show_bug.cgi?id=88893

Note: This has the side effect of grouping all of the Apple bots together in the waterfall.

Reviewed by Simon Fraser.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
1:20 PM Changeset in webkit [120108] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

HTML parser should yield more to improve perceived page load time
​https://bugs.webkit.org/show_bug.cgi?id=86165

Source/WebCore:

Patch by Shrey Banga <​banga@chromium.org> on 2012-06-12
Reviewed by Tony Gentilcore.

Test: fast/events/event-yield-timing.html

We want the parser to yield at least every 500ms to keep the page somewhat responsive and allow painting.
Since it would be too expensive to check the time after each token, the previous heuristic was to check every 4,096 tokens.
That works fine for most tokens, but a script may spend an arbitrary amount of time executing.

This patch fixes the issue by causing the parser to check the elapsed time immediately after executing a script.

  • html/parser/HTMLParserScheduler.cpp:

(WebCore::HTMLParserScheduler::checkForYieldBeforeScript):

  • html/parser/HTMLParserScheduler.h:

(WebCore::PumpSession::PumpSession):
(PumpSession):
(WebCore::HTMLParserScheduler::checkForYieldBeforeToken):

LayoutTests:

Added test for parser yield times after seeing a script

Patch by Shrey Banga <​banga@chromium.org> on 2012-06-12
Reviewed by Tony Gentilcore.

  • fast/parser/parser-yield-timing-expected.txt: Added.
  • fast/parser/parser-yield-timing.html: Added.
  • http/tests/loading/gmail-assert-on-load-expected.txt: The test was added

for an assert that failed on debug builds when an iframe removed itself
from its parent window after blocking for 1 second. In previous builds,
the destroyIt() function was called without yielding to the event loop,
which lead to didFailLoadWithError being called. The fix for bug 86165
ensures that we yield after executing the script, which leads to
didHandleOnloadEventsForFrame being called instead. This is the cause
of the change in output of the test. The test still successfully removes
the iframe and since no asserts fail in the debug build, we should consider
it as passing.

1:09 PM Changeset in webkit [120107] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

LayoutTests/http/tests/xmlhttprequest/origin-exact-matching.html is giving trouble due to too many redirects
​https://bugs.webkit.org/show_bug.cgi?id=88896

Patch by Pablo Flouret <​pablof@motorola.com> on 2012-06-12
Reviewed by Darin Adler.

The test was giving out "too many redirect" errors on GTK and EFL due to
using redirect-cors.php without an actual url to redirect.

Redirects are not actually tested in that test, a script that set the
Access-Control-Allow-Origin header to an arbitrary origin was needed and
redirect-cors.php was the only existing one that had the capability. The
infinite redirect thing was an unintended consequence.
Use resources/access-control-allow-lists.php to set the header instead.

  • http/tests/xmlhttprequest/origin-exact-matching-expected.txt:
  • http/tests/xmlhttprequest/resources/origin-exact-matching-iframe.html:
1:01 PM Changeset in webkit [120106] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Update more expectations to match the state of the bots.

  • platform/chromium/TestExpectations:
12:55 PM Changeset in webkit [120105] by enne@google.com
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Fix incorrect LayerChromium scroll position for RTL overflow pages
​https://bugs.webkit.org/show_bug.cgi?id=88887

Reviewed by James Robinson.

The scroll position on layers needs to take into account the scroll
origin, since RTL pages start scrolled all the way to the right.
Otherwise, when scrolling left the scroll position incorrectly will go
negative, causing havok in scrollbar theme code that just assumes that
it's always scrolled all the way to the left.

Also, now that the scroll origin is passed into NCCH, handle
scrollOrigin.y() for layer adjusting. This is always zero in practice,
but it seemed awkward to just drop it and that assumption could always
change in the future.

  • src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::setViewport):
(WebKit::NonCompositedContentHost::paintContents):

  • src/NonCompositedContentHost.h:

(NonCompositedContentHost):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::updateLayerTreeViewport):

12:47 PM Changeset in webkit [120104] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening after r120099, fix two incorrect text expectations.

  • platform/gtk/TestExpectations:
12:17 PM Changeset in webkit [120103] by commit-queue@webkit.org
  • 3 edits in trunk/Source

[chromium] Don't crash in CCLayerIterator if the root layer doesn't have a render surface
​https://bugs.webkit.org/show_bug.cgi?id=88886

Patch by Sami Kyostila <​skyostil@chromium.org> on 2012-06-12
Reviewed by James Robinson.

If we are iterating over a render render surface layer list where the
root layer does not have a render surface, fail gracefully instead of
crashing.

Tests: CCLayerIteratorTest.{emptyTree,rootLayerWithoutRenderSurface}

  • platform/graphics/chromium/cc/CCLayerIterator.h:

(WebCore::CCLayerIterator::CCLayerIterator):

12:17 PM Changeset in webkit [120102] by cevans@google.com
  • 3 edits
    3 copies in branches/chromium/1132

Merge 119158
BUG=129191
Review URL: ​https://chromiumcodereview.appspot.com/10542126

12:07 PM Changeset in webkit [120101] by cevans@google.com
  • 1 edit
    4 copies in branches/chromium/1132

Merge 119914
BUG=121128
Review URL: ​https://chromiumcodereview.appspot.com/10533113

12:06 PM Changeset in webkit [120100] by ojan@chromium.org
  • 35 edits in trunk

Change default for flex-grow back to 0
​https://bugs.webkit.org/show_bug.cgi?id=88443

Reviewed by Tony Chang.

Source/WebCore:

  • rendering/style/RenderStyle.h:

LayoutTests:

  • css3/flexbox/flex-algorithm.html:
  • css3/flexbox/flex-order.html:
  • css3/flexbox/flex-property-parsing-expected.txt:
  • css3/flexbox/flex-property-parsing.html:
12:01 PM Changeset in webkit [120099] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

[Gtk] TestExpectations should remove use of FAIL expectations
​https://bugs.webkit.org/show_bug.cgi?id=88894

Reviewed by Martin Robinson.

Remove FAIL expectation from Gtk's TestExpectations file, replacing it
with TEXT or IMAGE in case of reftests. That should suffice for now as the
buildbots don't run pixel tests at the moment.

  • platform/gtk/TestExpectations:
11:52 AM Changeset in webkit [120098] by cevans@google.com
  • 1 edit in branches/chromium/1132/Source/WebCore/dom/Document.cpp

Merge 119439
BUG=131087
Review URL: ​https://chromiumcodereview.appspot.com/10537130

11:52 AM Changeset in webkit [120097] by annacc@chromium.org
  • 3 edits in trunk/LayoutTests

Separate RemoveID test cases.
​https://bugs.webkit.org/show_bug.cgi?id=88798

Reviewed by Eric Carlson.

  • http/tests/media/media-source/video-media-source-add-and-remove-ids-expected.txt:
  • http/tests/media/media-source/video-media-source-add-and-remove-ids.html:
11:24 AM Changeset in webkit [120096] by beidson@apple.com
  • 4 edits
    13 adds in trunk

<rdar://problem/11593686> and ​https://bugs.webkit.org/show_bug.cgi?id=88683
Garbage collection of an <img> element can cause reentrant event dispatch.

Reviewed by Darin Adler.

Source/WebCore:

The most straightforward solution is for ImageLoader to keep its Element alive
with ref/deref any time the Image is actually loading.

ImageLoader should always do this for all Elements, and if those Elements want/need
different behavior for when they are detached then they need to manually stop their
loads.

Tests: http/tests/loading/embed-image-load-outlives-gc-without-crashing.html

http/tests/loading/image-input-type-outlives-gc-without-crashing.html
http/tests/loading/image-load-outlives-gc-without-crashing.html
http/tests/loading/object-image-load-outlives-gc-without-crashing.html
http/tests/loading/svg-image-load-outlives-gc-without-crashing.html
http/tests/loading/video-poster-image-load-outlives-gc-without-crashing.html

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::ImageLoader):
(WebCore::ImageLoader::~ImageLoader):
(WebCore::ImageLoader::setImage):
(WebCore::ImageLoader::updateFromElement):
(WebCore::ImageLoader::notifyFinished):
(WebCore::ImageLoader::updatedHasPendingLoadEvent):
(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):
(WebCore::ImageLoader::dispatchPendingLoadEvent):

  • loader/ImageLoader.h:

(ImageLoader):

LayoutTests:

New tests for all users of ImageLoader:

  • http/tests/loading/embed-image-load-outlives-gc-without-crashing-expected.txt: Added.
  • http/tests/loading/embed-image-load-outlives-gc-without-crashing.html: Added.
  • http/tests/loading/image-input-type-outlives-gc-without-crashing-expected.txt: Added.
  • http/tests/loading/image-input-type-outlives-gc-without-crashing.html: Added.
  • http/tests/loading/image-load-outlives-gc-without-crashing-expected.txt: Added.
  • http/tests/loading/image-load-outlives-gc-without-crashing.html: Added.
  • http/tests/loading/object-image-load-outlives-gc-without-crashing-expected.txt: Added.
  • http/tests/loading/object-image-load-outlives-gc-without-crashing.html: Added.
  • http/tests/loading/resources/slowimage.php: Added.
  • http/tests/loading/svg-image-load-outlives-gc-without-crashing-expected.txt: Added.
  • http/tests/loading/svg-image-load-outlives-gc-without-crashing.html: Added.
  • http/tests/loading/video-poster-image-load-outlives-gc-without-crashing-expected.txt: Added.
  • http/tests/loading/video-poster-image-load-outlives-gc-without-crashing.html: Added.

Shared sub resource for all of those tests:

  • http/tests/loading/resources/slowimage.php: Added.
11:21 AM Changeset in webkit [120095] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

Update some tests to better match actual results on the bots.

  • platform/chromium/TestExpectations:
11:07 AM Changeset in webkit [120094] by shawnsingh@chromium.org
  • 6 edits in trunk/Source

[chromium] Make damage tracking more robust to early exits
​https://bugs.webkit.org/show_bug.cgi?id=84803

Reviewed by James Robinson.

Source/WebCore:

All CCDamageTrackerTest unit tests updated;
One new unit test added:

CCDamageTrackerTest.verifyDamageAccumulatesUntilReset

Damage tracking inherently needs to be aware of all changes that
occur for every frame. Before this patch, anyone modifying details
of CCLayerTreeHostImpl and the drawing phases of the compositor
needed to be careful to avoid early exiting once draw is
initiated, otherwise running the risk of damage tracking's state
getting out-of-sync from actual changes. This patch makes the
damage tracker API more asynchronous-like, so that damage will
continue to accumulate until it is explicitly notified that
damaged areas have been drawn. This will allow more freedom in
designing and restructuing drawing code in the compositor, without
worrying as much about damage tracking getting out-of-sync.

  • platform/graphics/chromium/cc/CCDamageTracker.h:

(WebCore::CCDamageTracker::didDrawDamagedArea):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:

(WebCore::CCLayerTreeHostImpl::drawLayers):

  • platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:

(CCLayerTreeHostImpl):

Source/WebKit/chromium:

  • tests/CCDamageTrackerTest.cpp:

(WebKitTests::clearDamageForAllSurfaces):
(WebKitTests::TEST_F):

11:02 AM Changeset in webkit [120093] by commit-queue@webkit.org
  • 9 edits
    1 copy
    2 moves
    4 adds
    17 deletes in trunk

Make document.documentURI readonly from JavaScript
​https://bugs.webkit.org/show_bug.cgi?id=65187

Patch by Mike West <​mkwst@chromium.org> on 2012-06-12
Reviewed by Alexey Proskuryakov.

Source/WebCore:

The DOM4 working draft marks the documentURI attribute as read only
(​http://www.w3.org/TR/dom/#document). Firefox has shipped with this
behavior since ​https://hg.mozilla.org/mozilla-central/rev/3bc751906409
landed in October 2011, IE9 doesn't support the property, and
Opera throws a NO_MODIFICATION_ALLOWED_ERR. This patch changes WebKit
to silently fail (matching Firefox's behavior) by setting the property
to readonly in the IDL.

Document::setDocumentURI and the m_documentURI property are retained
for compatibility with ObjC clients, and the readonly attribute is
ifdeffed out for ObjC.

This patch adds a single test to verify the behavior, and removes a
variety of tests that depended on the writable behavior. In particular,
potential security issues involving the document.baseURL property are
avoided completely as long as this property can't be changed.

Test: fast/dom/documenturi-readonly.html

  • dom/Document.cpp:

(WebCore::Document::setDocumentURI):

Adds a comment explaining that the fallback is necessary only to
support ObjC, not for JS calls.

  • dom/Document.cpp:

(WebCore::Document::updateBaseURL):

Ditto.

(Document):

  • dom/Document.idl:

Add readonly to the attribute and drop null value when not in
LANGUAGE_OBJECTIVE_C.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/SetDocumentURI.html: Added.
  • TestWebKitAPI/Tests/mac/SetDocumentURI.mm: Added.

(-[SetDocumentURITest webView:didFinishLoadForFrame:]):
(TestWebKitAPI):
(TestWebKitAPI::TEST):

LayoutTests:

  • dom/xhtml/level3/core/documentsetdocumenturi01-expected.txt: Removed.
  • dom/xhtml/level3/core/documentsetdocumenturi01.xhtml-disabled: Renamed from LayoutTests/dom/xhtml/level3/core/documentsetdocumenturi01.xhtml.
  • dom/xhtml/level3/core/documentsetdocumenturi02-expected.txt: Removed.
  • dom/xhtml/level3/core/documentsetdocumenturi02.xhtml-disabled: Renamed from LayoutTests/dom/xhtml/level3/core/documentsetdocumenturi02.xhtml.

Disabling these two tests, because they write out documentURI which is a file: URL dependent on a local path.

  • dom/xhtml/level3/core/documentsetdocumenturi03-expected.txt:
  • dom/xhtml/level3/core/nodegetbaseuri02-expected.txt:

Updating these two tests to match the new, read-only behavior.

  • fast/dom/documenturi-affects-relative-paths-expected.txt: Removed.
  • fast/dom/documenturi-affects-relative-paths.html: Removed.
  • fast/dom/documenturi-assigned-junk-implies-baseuri-null-expected.txt: Removed.
  • fast/dom/documenturi-assigned-junk-implies-baseuri-null.html: Removed.
  • fast/dom/documenturi-assigned-junk-implies-relative-urls-do-not-resolve-expected.txt: Removed.
  • fast/dom/documenturi-assigned-junk-implies-relative-urls-do-not-resolve.html: Removed.
  • fast/dom/documenturi-can-hold-arbitrary-string-expected.txt: Removed.
  • fast/dom/documenturi-can-hold-arbitrary-string.html: Removed.

Removing now-irrelevant tests.

  • fast/dom/documenturi-readonly-expected.txt: Added.
  • fast/dom/documenturi-readonly.html: Added.

Adding a test to verify that document.documentURI is read-only.

  • http/tests/security/xss-DENIED-document-baseURI-javascript-expected.txt: Removed.
  • http/tests/security/xss-DENIED-document-baseURI-javascript-with-spaces-expected.txt: Removed.
  • http/tests/security/xss-DENIED-document-baseURI-javascript-with-spaces.html: Removed.
  • http/tests/security/xss-DENIED-document-baseURI-javascript.html: Removed.
  • platform/chromium/dom/xhtml/level3/core/nodegetbaseuri02-expected.txt: Added

Platform-specific result for Chromium, which doesn't set the line property on exceptions.

  • storage/domstorage/events/documentURI-expected.txt: Removed.
  • storage/domstorage/events/documentURI.html: Removed.
  • storage/domstorage/events/script-tests/documentURI.js: Removed.

Removing now-irrelevant tests.

10:52 AM Changeset in webkit [120092] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Support !ENABLE(VIDEO) builds with horizontally layed out video controls.
​https://bugs.webkit.org/show_bug.cgi?id=88881

Patch by Silvia Pfeiffer <​silviapf@chromium.org> on 2012-06-12
Reviewed by Csaba Osztrogonác.

No new tests as this is a regression from WK87835.

  • html/shadow/SliderThumbElement.cpp:

(WebCore::hasVerticalAppearance):
Ifdef out video related functionality, since usesVerticalVolumeSlider
does not exist in that case.

10:28 AM Changeset in webkit [120091] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Fix crash in InputHandler
​https://bugs.webkit.org/show_bug.cgi?id=88808

Patch by Crystal Zhang <​haizhang@rim.com> on 2012-06-12
Reviewed by Antonio Gomes.

m_page is destroyed before InputHandler, so should move the call to destroy popup to chromeDestroyed().

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::chromeDestroyed():

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::~InputHandler):

10:11 AM Changeset in webkit [120090] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-536-branch

Merged r119739 -> <rdar://problem/11616643>

10:08 AM Changeset in webkit [120089] by Lucas Forschler
  • 3 edits
    3 copies in branches/safari-536-branch

Merged r119644 -> <rdar://problem/11575112>

10:05 AM Changeset in webkit [120088] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebKit/mac

Merged r119543 -> <rdar://problem/11602601>

10:04 AM Changeset in webkit [120087] by Lucas Forschler
  • 2 edits in branches/safari-536-branch/Source/WebKit/mac

Merged r119542 -> <rdar://problem/11602601>

9:57 AM Changeset in webkit [120086] by pfeldman@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: allow clearing revision history.
​https://bugs.webkit.org/show_bug.cgi?id=88847

Reviewed by Vsevolod Vlasov.

This change also renames "Revision history" to "Local modifications".
I intend to list modifications to all files in that view in the subsequent change.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/Resource.js:

(WebInspector.Resource._clearResourceHistory):

  • inspector/front-end/RevisionHistoryView.js:

(WebInspector.RevisionHistoryView.else.clearHistory):
(WebInspector.RevisionHistoryView):
(WebInspector.RevisionHistoryView.prototype._revisionAdded):
(WebInspector.RevisionHistoryTreeElement):
(WebInspector.RevisionHistoryTreeElement.prototype._createLine):
(WebInspector.RevisionHistoryTreeElement.prototype.allowRevert):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.appendApplicableItems):

9:44 AM Changeset in webkit [120085] by pfeldman@chromium.org
  • 8 edits
    1 add in trunk/Source/WebCore

Web Inspector: use jsdifflib for revision diff calculation.
​https://bugs.webkit.org/show_bug.cgi?id=88791

Reviewed by Vsevolod Vlasov.

Present diff calculation is incomplete, it does not properly handle the following case:

[a, b, c, d, e, f, g, h] => [c, d, e, f, g, h, a, b]

We should not be implementing diff by ourselves. I imported jsdifflib from
​https://github.com/cemerick/jsdifflib. It has BSD license that is compatible with WebKit.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/RevisionHistoryView.js:

(WebInspector.RevisionHistoryTreeElement.prototype.onexpand.step2):
(WebInspector.RevisionHistoryTreeElement.prototype.onexpand):
(WebInspector.RevisionHistoryTreeElement.prototype._createLine.appendLineNumber):
(WebInspector.RevisionHistoryTreeElement.prototype._createLine):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/externs.js:

(difflib.stringAsLines):
(difflib.SequenceMatcher):
(difflib.SequenceMatcher.prototype.get_opcodes):

  • inspector/front-end/inspector.html:
  • inspector/front-end/jsdifflib.js: Added.

(difflib.defaultJunkFunction):
(difflib.stripLinebreaks):
(difflib.stringAsLines):
(difflib.reduce):
(difflib.ntuplecomp):
(difflib.calculate_ratio):
(difflib.dictget):
(difflib.SequenceMatcher.this.set_seqs):
(difflib.SequenceMatcher.this.set_seq1):
(difflib.SequenceMatcher.this.set_seq2):
(difflib.SequenceMatcher.this.chain_b):
(difflib.SequenceMatcher.this.find_longest_match):
(difflib.SequenceMatcher.this.get_matching_blocks):
(difflib.SequenceMatcher.this.get_opcodes):
(difflib.SequenceMatcher.this.get_grouped_opcodes):
(difflib.SequenceMatcher.this.quick_ratio):
(difflib.SequenceMatcher.this.real_quick_ratio):

  • inspector/front-end/revisionHistory.css:

(.revision-history-line-separator .webkit-line-number):

9:32 AM Changeset in webkit [120084] by commit-queue@webkit.org
  • 7 edits in trunk

[EFL] enable LEGACY_WEBKIT_BLOB_BUILDER flag
​https://bugs.webkit.org/show_bug.cgi?id=88715

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-12
Reviewed by Noam Rosenthal.

.:

Enable LEGACY_WEBKIT_BLOB_BUILDER flag by default on EFL port.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmakeconfig.h.cmake:

Tools:

Enable LEGACY_WEBKIT_BLOB_BUILDER flag by default on EFL port.

  • Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Unskip fast/files/blob-builder-crash.html now that
LEGACY_WEBKIT_BLOB_BUILDER flag is enabled by default
on EFL port.

  • platform/efl/Skipped:
9:28 AM Changeset in webkit [120083] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt] Fix -Werror for the buildbots
​https://bugs.webkit.org/show_bug.cgi?id=88223

Rubber-stamped by Tor Arne Vestbø.

Revert a part of r119269 to enable Werror again for non qt-developer-builds. (for bots for example)

  • qmake/mkspecs/features/unix/default_post.prf:
9:15 AM Changeset in webkit [120082] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

[GStreamer] http/tests/media/video-buffered-range-contains-currentTime.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=87575

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-12
Reviewed by Philippe Normand.

Source/WebCore:

When EOS is reached in forward playback, the position does not necessarily
match the duration. This confuses HTMLMediaElement and causes the "ended"
event not to be fired. To avoid this, we synchronize position and duration
values in this case.

Test: http/tests/media/video-buffered-range-contains-currentTime.html

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

LayoutTests:

Unskip http/tests/media/video-buffered-range-contains-currentTime.html for both
GTK and EFL ports now that MediaPlayerPrivateGStreamer correctly reports EOS and
now that the "ended" event is properly fired.

  • platform/efl/TestExpectations:
  • platform/efl/http/tests/media/video-buffered-range-contains-currentTime-expected.png: Added.
  • platform/gtk/TestExpectations:
  • platform/gtk/http/tests/media/video-buffered-range-contains-currentTime-expected.png: Added.
8:34 AM Changeset in webkit [120081] by kinuko@chromium.org
  • 8 edits in trunk/Source/WebCore

Refactor InputType::receiveDroppedFiles to take DragData
​https://bugs.webkit.org/show_bug.cgi?id=88860

Reviewed by Kent Tamura.

So that we can centralize the file paths related code into FileInputType
and makes it easier to extract more data from DragData for
<input type=file> (like bug 88293 for directory drag-and-drop).

No new tests as this has no behavioral changes.

  • html/FileInputType.cpp:

(WebCore::FileInputType::receiveDroppedFiles):

  • html/FileInputType.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::receiveDroppedFiles):

  • html/HTMLInputElement.h:
  • html/InputType.cpp:

(WebCore::InputType::receiveDroppedFiles):

  • html/InputType.h:
  • page/DragController.cpp:

(WebCore::DragController::concludeEditDrag):

8:29 AM Changeset in webkit [120080] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Generate -webkit-box-decoration-break property only when the feature is enabled
​https://bugs.webkit.org/show_bug.cgi?id=88861

Patch by Thiago Marcos P. Santos <​thiago.santos@intel.com> on 2012-06-12
Reviewed by Alexis Menard.

Otherwise it will hit an assertion if the property is present on the
style but the feature disabled. Also fixes a compilation warning when
the feature is disabled.

  • css/CSSPropertyNames.in:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

8:11 AM Changeset in webkit [120079] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
​https://bugs.webkit.org/show_bug.cgi?id=85591

Reviewed by Martin Robinson.

Remove FAIL text expectations for sputnik tests that have been
consistently passing on all the Gtk builders.

  • platform/gtk/TestExpectations:
8:10 AM Changeset in webkit [120078] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Tweaked the Mac export file a bit more, adding more-correct iOS cases.

Reviewed by David Kilzer.

  • WebCore.exp.in: Rearrangement.
8:06 AM Changeset in webkit [120077] by kenneth@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix.

  • UIProcess/qt/QtViewportHandler.cpp:

(WebKit::QtViewportHandler::initialRect):

8:04 AM Changeset in webkit [120076] by jocelyn.turcotte@nokia.com
  • 7 edits in trunk/Source

Using extrernal ICU library on case unsensitive drives will not work
​https://bugs.webkit.org/show_bug.cgi?id=70913

Reviewed by Csaba Osztrogonác.

Source/WebCore:

  • platform/graphics/surfaces/GraphicsSurface.h:

Source/WebKit2:

  • WebProcess/WebPage/UpdateAtlas.cpp:

Source/WTF:

Properly set the include path for the WTF module and for modules using it.
The path should include Source/WTF/wtf only when building WTF itself. Other
modules are expected to include the headers as #include <wtf/Header.h>, so
only add Source/WTF to their include path.

"unicode/utf8.h" should now then always reference to ICU in the include path
and "wtf/unicode/UTF8.h" reference to the WTF version.
This will work as long as WTF object files don't depend on ICU themselves.

Removed gobject, qt and unicode from the include path as those directories
don't exist anymore.

  • WTF.pri:
  • WTF.pro:
7:55 AM Changeset in webkit [120075] by kenneth@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt] Do not move/scale content while the user is interacting with it
​https://bugs.webkit.org/show_bug.cgi?id=88872

Reviewed by Simon Hausmann.

Don't try moving content into valid bounds when the content
size changes and the user is interacting with the content.

Only apply the viewport initial scale after user interaction
has ended.

  • UIProcess/qt/QtViewportHandler.cpp:

(WebKit::ViewportUpdateDeferrer::~ViewportUpdateDeferrer):
(WebKit::QtViewportHandler::setInitialScaleIfNeeded):
(WebKit::QtViewportHandler::viewportAttributesChanged):
(WebKit::QtViewportHandler::pageContentsSizeChanged):
(WebKit::QtViewportHandler::initialRect):
(WebKit):

  • UIProcess/qt/QtViewportHandler.h:

(QtViewportHandler):

7:51 AM Changeset in webkit [120074] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Use a safer way to shrink JS memory usage
​https://bugs.webkit.org/show_bug.cgi?id=88811

Patch by Yong Li <​yoli@rim.com> on 2012-06-12
Reviewed by Antonio Gomes.

We should just make a GC request and JSC will check if it is safe to do anything.

  • Api/BlackBerryGlobal.cpp:

(BlackBerry::WebKit::clearMemoryCaches):

7:39 AM Changeset in webkit [120073] by danakj@chromium.org
  • 4 edits in trunk/Source/WebCore

[chromium] Use TextureDrawQuad for video layer output when it produces a single GL texture
​https://bugs.webkit.org/show_bug.cgi?id=88814

Reviewed by Adrienne Walker.

When a CCVideLayerImpl produces quads for a frame that is contained
in a single GL texture, then use the TextureDrawQuad instead of the
VideoDrawQuad. Moves the computation for the RGBA(software) and
NativeTexture (hardware) cases from LayerRendererChromium into
CCVideoLayerImpl, so it can embed these values in the TextureDrawQuad.

No new tests, behaviour should be the same.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawStreamTexture):
(WebCore::LayerRendererChromium::drawVideoQuad):

  • platform/graphics/chromium/LayerRendererChromium.h:

(LayerRendererChromium):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::appendQuads):

7:31 AM Changeset in webkit [120072] by commit-queue@webkit.org
  • 11 edits in trunk

Change the volume slider to horizontal rendering for Chrome video controls.
​https://bugs.webkit.org/show_bug.cgi?id=87835

Patch by Silvia Pfeiffer <​silviapf@chromium.org> on 2012-06-12
Reviewed by Eric Carlson.

Source/WebCore:

No new tests - final patch in the Chrome controls update series will contain rebaselined tests.

The Chrome video controls are receiving a visual update. The volume slider is moved into
the controls with horizontal rendering, the volume slider container is removed. The visual
update itself is in a separate patch.

  • css/mediaControlsChromium.css:

(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
Removed relative positioning to render all controls elements equally in DOM order.
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
Removed absolute positioning to render all controls elements equally in DOM order.
(audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
Removed absolute positioning to render all controls elements equally in DOM order.
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
Removed volume slider container - it's not necessary any more.
(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
Remove flexbox and introduce inline display to always display this field.
(audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
Removed absolute positioning to render all controls elements equally in DOM order.

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
Removed volume slider container - it's not necessary any more.
(WebCore::MediaControlRootElementChromium::create):
Appended the volume slider and the mute button directly to the panel, removed volume slider container.
(WebCore::MediaControlRootElementChromium::setMediaController):
Removed volume slider container.
(WebCore::MediaControlRootElementChromium::reportedError):
Removed volume slider container.
(WebCore::MediaControlRootElementChromium::showVolumeSlider):
Removed volume slider container.

  • html/shadow/MediaControlRootElementChromium.h:

(WebCore):
(MediaControlRootElementChromium):
Removed volume slider container.

  • html/shadow/SliderThumbElement.cpp:

(WebCore::hasVerticalAppearance):
Allow use of horizontal media volume slider.
(WebCore::RenderSliderThumb::layout):
Reuse hasVerticalAppearance function.

  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::RenderMediaControlsChromium::paintMediaVolumeSlider):
Change line drawing from vertical to horizontal.

  • rendering/RenderTheme.h:

(WebCore::RenderTheme::usesVerticalVolumeSlider):
Add usesVerticalVolumeSlider function to allow horizontal volume sliders.

  • rendering/RenderThemeChromiumMac.h:

(WebCore::RenderThemeChromiumMac::usesVerticalVolumeSlider):
Add usesVerticalVolumeSlider function to allow horizontal volume sliders.
Add usesVerticalVolumeSlider function to allow horizontal volume sliders.

  • rendering/RenderThemeChromiumSkia.h:

(WebCore::RenderThemeChromiumSkia::usesVerticalVolumeSlider):
Add usesVerticalVolumeSlider function to allow horizontal volume sliders.

LayoutTests:

The Chrome video controls are receiving a visual update. The volume slider is included into
the controls with horizontal rendering, the volume slider container is removed. The visual
update itself is in a separate patch.

  • platform/chromium/TestExpectations:

Temporarily skip tests related to volume controls rendering for Chromium.

7:21 AM Changeset in webkit [120071] by commit-queue@webkit.org
  • 5 edits in trunk

[CSSRegions]NamedFlow::overset should return true when there's no region chain attached
​https://bugs.webkit.org/show_bug.cgi?id=88515

The CSS Regions specifies that the "overset" attribute needs to return true if the content overflows, there's no region attached to the flow
or if the NamedFlow is in the NULL state:
​http://www.w3.org/TR/css3-regions/#dom-named-flow-overset

Source/WebCore:

This patch updates WebKit's behavior in the last two situations to match the one in the spec.

Patch by Andrei Bucur <​abucur@adobe.com> on 2012-06-12
Reviewed by Andreas Kling.

Test: fast/regions/webkit-named-flow-overset.html was updated

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::computeOverflowStateForRegions): If the last valid region is null, the flow has not region chain attached or it's in the NULL state.

LayoutTests:

The overset test was updated to cover the attribute value in case of a flow in the NULL state.

Patch by Andrei Bucur <​abucur@adobe.com> on 2012-06-12
Reviewed by Andreas Kling.

  • fast/regions/webkit-named-flow-overset-expected.txt:
  • fast/regions/webkit-named-flow-overset.html:
6:58 AM Changeset in webkit [120070] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Provide context menu for deleting recorded profile on Profiles Panel
​https://bugs.webkit.org/show_bug.cgi?id=88286

Added the context menu to delete the selected profile.

Patch by Rahul Tiwari <​rahultiwari.cse.iitr@gmail.com> on 2012-06-12
Reviewed by Pavel Feldman.

No new tests required as UI related change

  • English.lproj/localizedStrings.js: Removed property svn:mime-type.
  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfileSidebarTreeElement.prototype.handleContextMenuEvent):

6:52 AM Changeset in webkit [120069] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2012-06-12 Pavel Feldman <​pfeldman@chromium.org>

Not reviewed: removed svn:mime-type property from English.lproj/localizedStrings.js

  • English.lproj/localizedStrings.js
6:45 AM Changeset in webkit [120068] by mitz@apple.com
  • 3 edits in trunk/Source/WebCore

Tried to fix the notification-enabled build after r120044.

  • notifications/NotificationController.cpp:

(WebCore::NotificationController::NotificationController):
(WebCore::NotificationController::create):
(WebCore::provideNotification):

  • notifications/NotificationController.h:

(NotificationController):

6:40 AM Changeset in webkit [120067] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Skip test failing randomly in GTK bots after r120040.

  • platform/gtk/TestExpectations:
6:33 AM Changeset in webkit [120066] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt][Texmap] Falling leaves demo missing clipping.
​https://bugs.webkit.org/show_bug.cgi?id=88704

The bug originated from begining native painting mode of QPainter after enabling
scissor test, because begining native painting mode disables scissor test.

Covered by existing compositing tests.

Patch by Huang Dongsung <​luxtella@company100.net> on 2012-06-12
Reviewed by Noam Rosenthal.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::beginPainting):

6:30 AM Changeset in webkit [120065] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebCore

[Qt][Win] Buildfix related to fromWinHBITMAP
​https://bugs.webkit.org/show_bug.cgi?id=88863

Reviewed by Jocelyn Turcotte.

  • platform/graphics/qt/GraphicsContextQt.cpp: Add qt_pixmapFromWinHBITMAP and HBitmapFormat enum.

(WebCore):
(WebCore::GraphicsContext::releaseWindowsContext):

  • platform/graphics/qt/ImageQt.cpp:

(WebCore): Move qt_pixmapFromWinHBITMAP to outside of WebCore namespace. (Fix after r119924.)

6:19 AM Changeset in webkit [120064] by commit-queue@webkit.org
  • 3 edits in trunk

[CMake] Enabled CSS_BOX_DECORATION_BREAK by default
​https://bugs.webkit.org/show_bug.cgi?id=88850

Patch by Thiago Marcos P. Santos <​thiago.santos@intel.com> on 2012-06-12
Reviewed by Alexis Menard.

Enabled it by default on CMake ports like in other ports.
This patch is a follow up to r120029.

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:
5:51 AM Changeset in webkit [120063] by kbalazs@webkit.org
  • 2 edits in trunk/Tools

[REGRESSION][WTR] Build fail with werror after r120054
​https://bugs.webkit.org/show_bug.cgi?id=88862

Reviewed by Csaba Osztrogonác.

Some static helpers become unused after counterValueForElementById
has moved to Internals. Let's remove them.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR):

5:28 AM Changeset in webkit [120062] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

[Shadow DOM] <style> inside Shadow subtree should be scoped inside the subtree.
​https://bugs.webkit.org/show_bug.cgi?id=87805

Source/WebCore:

Modified HTMLStyleElement to be treated as a scoped style independent
of its "scoped" attribute's value if HTMLStyleElement is in shadow
subtree. HTMLStyleElement has the following four cases talking about
"scoped" attribute and whether is in shadow subtree or not:
1, HTMLStyleElement is "scoped" and is in document tree,
2, HTMLStyleElement is "scoped" and is in shadow subtree,
3, HTMLStyleElement is not "scoped" and is in document tree, and
4, HTMLStyleElement is not "scoped" and is in shadow subtree.
The case 1 and 2 are not changed. This patch affected the case 4.
At the case 4, the HTMLStyleElement's scoping node is the shadow root.
This change is the first step for fixing style scope bug,
i.e. HTMLStyleElements in shadow subtree are applied to any element
in document tree.

Patch by Takashi Sakamoto <​tasak@google.com> on 2012-06-12
Reviewed by Dimitri Glazkov.

Test: fast/css/style-scoped/style-scoped-change-scoped-in-shadow.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::determineScope):
Modified to return a shadow root if a targeted stylesheet owner node is
not scoped but in some shadow DOM subtree.

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::HTMLStyleElement):
(WebCore::HTMLStyleElement::parseAttribute):
Modified to use the below scopedAttributeChanged when a changed
attribute's name is "scoped".
(WebCore::HTMLStyleElement::scopedAttributeChanged):
Newly added. According to new scoped value and isInShadowTree,
add or remove style rules to/from scopedAuthorRules via
registerWithScopingNode or unregisterWithScopingNode.
(WebCore::HTMLStyleElement::registerWithScopingNode):
Added one boolean argument to determine whether HTMLStyleElement is
scoped or not. The reason why not using scoped() is the comment:
"We cannot rely on the scoped element already being present when this
method is invoked. Therefore we cannot rely on scoped()"
(WebCore::HTMLStyleElement::unregisterWithScopingNode):
Changed the code for updating m_isRegisteredWithScopingNode. Now
set m_scopedStyleRegistrationState to be NotRegistered.
(WebCore::HTMLStyleElement::insertedInto):
Modified to invoke registerWithScopingNode when an element is not
scoped but in some shadow subtree.
(WebCore::HTMLStyleElement::removedFrom):
Modified to invoke unregisterWithScopingNode when an element is not
scoped but in some shadow subtree.

  • html/HTMLStyleElement.h:

(HTMLStyleElement):
Modified the type of m_isRegisteredWithScopingNode from bool to
enum and renamed to m_scopedStyleRegistrationState. Now the member
variable keeps what HTMLStyleElement's scoping node is, i.e.
none (this means, not in shadow subtree and not scoped), shadow root or
parent node.
Added one new method scopedAttributeChanged's declaration and
modified the declaration of registerWithScopingNode.

LayoutTests:

Patch by Takashi Sakamoto <​tasak@google.com> on 2012-06-12
Reviewed by Dimitri Glazkov.

  • fast/css/style-scoped/registering-shadowroot-expected.txt:
  • fast/css/style-scoped/registering-shadowroot.html:
  • fast/css/style-scoped/style-scoped-change-scoped-in-shadow-expected.txt: Added.
  • fast/css/style-scoped/style-scoped-change-scoped-in-shadow.html: Added.
5:06 AM Changeset in webkit [120061] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Removing unused parameter Page
​https://bugs.webkit.org/show_bug.cgi?id=88848

Patch by Amy Ousterhout <​aousterh@chromium.org> on 2012-06-12
Reviewed by Kentaro Hara.

Removed the unused parameter Page* supplied to the create function
and constructor in DeviceOrientationController.

The parameter Page* was previously stored in an instance variable
m_page, but this was removed (see ​https://bugs.webkit.org/show_bug.cgi?id=88812).

No new tests because the removed parameter was unused and untested.

  • dom/DeviceOrientationController.cpp:

(WebCore::DeviceOrientationController::DeviceOrientationController):
(WebCore::DeviceOrientationController::create):
(WebCore::provideDeviceOrientationTo):

  • dom/DeviceOrientationController.h:

(DeviceOrientationController):

4:53 AM Changeset in webkit [120060] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt] Slave losts cause build break on bots
​https://bugs.webkit.org/show_bug.cgi?id=38980

Minor fix after r59261.

Reviewed by Tor Arne Vestbø.

  • Scripts/build-webkit:

(unlinkZeroFiles): Don't remove 0 byte sized directories, because they are always 0 byte sized on Windows.

4:48 AM Changeset in webkit [120059] by mario@webkit.org
  • 7 edits in trunk/LayoutTests

Unreviewed. Add reference to bug 88859 for test skipped in r120055.

  • platform/efl/Skipped:
  • platform/gtk/TestExpectations:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
4:30 AM Changeset in webkit [120058] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed: Add expectations for speech-recognition-event-constructor

This looks like it was failing as it was added in r120053. Filed
bug 88856.

  • platform/chromium/TestExpectations:
4:18 AM Changeset in webkit [120057] by commit-queue@webkit.org
  • 32 edits
    2 moves
    5 deletes in trunk

Unreviewed, rolling out r120051.
​http://trac.webkit.org/changeset/120051
​https://bugs.webkit.org/show_bug.cgi?id=88852

some tests are crashing (Requested by morrita on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-06-12

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/generic/ContextEnabledFeatures.cpp: Renamed from Source/WebKit/chromium/src/ContextFeaturesClientImpl.cpp.

(WebCore):
(WebCore::ContextEnabledFeatures::shadowDOMEnabled):
(WebCore::ContextEnabledFeatures::styleScopedEnabled):
(WebCore::ContextEnabledFeatures::pagePopupEnabled):

  • bindings/generic/ContextEnabledFeatures.h: Renamed from Source/WebKit/chromium/src/ContextFeaturesClientImpl.h.

(WebCore):
(ContextEnabledFeatures):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementation):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::determineScope):

  • dom/ContextFeatures.cpp: Removed.
  • dom/ContextFeatures.h: Removed.
  • dom/DOMAllInOne.cpp:
  • dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocument):
(WebCore::DOMImplementation::createHTMLDocument):

  • dom/Document.cpp:

(WebCore::Document::Document):

  • dom/Document.h:

(WebCore):
(Document):

  • dom/Position.cpp:

(WebCore::Position::Position):
(WebCore::Position::findParent):

  • dom/TreeScope.cpp:

(WebCore::TreeScope::getSelection):

  • dom/make_names.pl:

(printConstructorInterior):
(printFactoryCppFile):
(printWrapperFunctions):
(printWrapperFactoryCppFile):

  • editing/markup.cpp:

(WebCore::createFragmentFromMarkupWithContext):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::registerWithScopingNode):
(WebCore::HTMLStyleElement::unregisterWithScopingNode):

  • html/shadow/HTMLContentElement.cpp:

(WebCore::contentTagName):

  • inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::patchDocument):

  • loader/FrameLoaderClient.h:

(WebCore::FrameLoaderClient::allowShadowDOM):
(WebCore::FrameLoaderClient::allowStyleScoped):
(FrameLoaderClient):
(WebCore::FrameLoaderClient::allowPagePopup):

  • platform/RefCountedSupplement.h: Removed.
  • platform/Supplementable.h:
  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::responseXML):

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/WebPermissionClient.h:

(WebKit::WebPermissionClient::allowWebComponents):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::allowShadowDOM):
(WebKit):
(WebKit::FrameLoaderClientImpl::allowStyleScoped):

  • src/FrameLoaderClientImpl.h:

(FrameLoaderClientImpl):

  • src/WebPagePopupImpl.cpp:

(WebKit::WebPagePopupImpl::initPage):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setPermissionClient):
(WebKit::WebViewImpl::WebViewImpl):

  • src/WebViewImpl.h:

(WebKit):

LayoutTests:

  • fast/dom/shadow/elements-in-frameless-document-expected.txt: Removed.
  • fast/dom/shadow/elements-in-frameless-document.html: Removed.
4:09 AM Changeset in webkit [120056] by Csaba Osztrogonác
  • 7 edits
    2 deletes in trunk/LayoutTests

[Qt] Diverging test results on 32/64 bit architectures
​https://bugs.webkit.org/show_bug.cgi?id=82601

Unreviewed gardening, update expected files.

  • platform/qt/Skipped: Unskip svg/transforms/transform-origin-css-property.xhtml, because it passes now.
  • platform/qt/fast/repaint/moving-shadow-on-container-expected.png:
  • platform/qt/fast/repaint/moving-shadow-on-path-expected.png:
  • platform/qt/svg/W3C-SVG-1.1/paths-data-03-f-expected.png:
  • platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.png:
  • platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/qt/svg/transforms/transform-origin-css-property-expected.png: Removed, because it is a reftest.
  • platform/qt/svg/transforms/transform-origin-css-property-expected.txt: Removed, because it is a reftest.
4:05 AM Changeset in webkit [120055] by kinuko@chromium.org
  • 7 edits in trunk/LayoutTests

Unreviewed; skipping the new XHR blob test on the platforms where XHR_RESPONSE_BLOB is not enabled.
http/tests/xmlhttprequest/response-blob-size.html

  • platform/efl/Skipped:
  • platform/gtk/TestExpectations:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wincairo/Skipped:
3:47 AM Changeset in webkit [120054] by Kaustubh Atrawalkar
  • 64 edits in trunk

[DRT] LTC:: counterValueForElementById() could be moved to Internals.
​https://bugs.webkit.org/show_bug.cgi?id=84406

Reviewed by Hajime Morita.

.:

Exporting Internals::counterValueForElement symbols for the Gtk build.

  • Source/autotools/symbols.filter:

Source/WebCore:

Move the counterValueForElementById from LayoutTestCotroller to Internals and
remove the old platform specific implementations as it exclusively tests WebCore functionality.

Covered by existing test cases.

  • testing/Internals.cpp:

(WebCore::Internals::counterValue):
(WebCore):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit/efl:

Move the counterValueForElementById from LayoutTestCotroller to Internals and
remove the old platform specific implementations as it exclusively tests WebCore functionality.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

Source/WebKit/gtk:

Move the counterValueForElementById from LayoutTestCotroller to Internals and
remove the old platform specific implementations as it exclusively tests WebCore functionality.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Source/WebKit/qt:

Move the counterValueForElementById from LayoutTestCotroller to Internals and
remove the old platform specific implementations as it exclusively tests WebCore functionality.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit/win:

Move the counterValueForElementById from LayoutTestCotroller to Internals and
remove the old platform specific implementations as it exclusively tests WebCore functionality.

  • Interfaces/IWebFramePrivate.idl:
  • WebFrame.cpp:
  • WebFrame.h:

Source/WebKit2:

Exporting Internals::counterValueForElement symbols for the win build.

  • win/WebKit2.def:

Tools:

Move the counterValueForElementById from LayoutTestCotroller to Internals and
remove the old platform specific implementations as it exclusively tests WebCore functionality.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::setPOSIXLocale):

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  • DumpRenderTree/qt/LayoutTestControllerQt.h:

(LayoutTestController):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

(LayoutTestController):

LayoutTests:

Move the counterValueForElementById from LayoutTestCotroller to Internals and
remove the old platform specific implementations as it exclusively tests WebCore functionality.

  • fast/css/counters/2displays-expected.txt:
  • fast/css/counters/2displays.html:
  • fast/css/counters/adding-nodes.html:
  • fast/css/counters/after-continuation-expected.txt:
  • fast/css/counters/after-continuation.html:
  • fast/css/counters/content-021-expected.txt:
  • fast/css/counters/content-021.html:
  • fast/css/counters/counter-before-content-not-incremented.html:
  • fast/css/counters/counter-increment-000-expected.txt:
  • fast/css/counters/counter-increment-000.html:
  • fast/css/counters/counter-increment-001-expected.txt:
  • fast/css/counters/counter-increment-001.html:
  • fast/css/counters/counter-increment-002.html:
  • fast/css/counters/counter-increment-inherit-expected.txt:
  • fast/css/counters/counter-increment-inherit.htm:
  • fast/css/counters/counter-increment-overflow.html:
  • fast/css/counters/counter-increment-tests-expected.txt:
  • fast/css/counters/counter-increment-tests.htm:
  • fast/css/counters/counter-reset-000.html:
  • fast/css/counters/counter-reset-001.html:
  • fast/css/counters/counter-reset-002.html:
  • fast/css/counters/counterValueForElementById-expected.txt:
  • fast/css/counters/counterValueForElementById.html:
  • fast/css/counters/deep-before-expected.txt:
  • fast/css/counters/deep-before.html:
  • fast/css/counters/invalidate-cached-counter-node.html:
  • fast/css/counters/nesting.html:
3:38 AM Changeset in webkit [120053] by hans@chromium.org
  • 15 edits
    2 adds in trunk

Speech JavaScript API: Make SpeechRecognitionError an Event
​https://bugs.webkit.org/show_bug.cgi?id=88784

Reviewed by Adam Barth.

Source/WebCore:

Make SpeechRecognitionError an Event. The spec was updated to make it
an event in its own right, rather than an attribute of
SpeechRecognitionEvent.

Test: fast/speech/scripted/speechrecognition-errors.html

  • Modules/speech/SpeechRecognition.cpp:

(WebCore::SpeechRecognition::didReceiveError):

  • Modules/speech/SpeechRecognitionError.cpp:

(WebCore::SpeechRecognitionError::SpeechRecognitionError):
(WebCore::SpeechRecognitionError::interfaceName):
(WebCore):

  • Modules/speech/SpeechRecognitionError.h:

(WebCore::SpeechRecognitionError::create):
(SpeechRecognitionError):

  • Modules/speech/SpeechRecognitionError.idl:
  • Modules/speech/SpeechRecognitionEvent.cpp:

(WebCore::SpeechRecognitionEvent::SpeechRecognitionEvent):

  • Modules/speech/SpeechRecognitionEvent.h:

(SpeechRecognitionEventInit):
(SpeechRecognitionEvent):

  • Modules/speech/SpeechRecognitionEvent.idl:
  • dom/EventNames.in:

Tools:

Make it possible to have MockWebSpeechRecognizer fire error events.

  • DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::LayoutTestController):
(LayoutTestController::setMockSpeechRecognitionError):

  • DumpRenderTree/chromium/LayoutTestController.h:

(LayoutTestController):

  • DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:

(WebKit):
(ErrorTask):
(WebKit::ErrorTask::ErrorTask):
(MockWebSpeechRecognizer::addMockResult):
(MockWebSpeechRecognizer::setError):

  • DumpRenderTree/chromium/MockWebSpeechRecognizer.h:

(MockWebSpeechRecognizer):

LayoutTests:

Add a layout test that fires a SpeechRecognitionError.

  • fast/speech/scripted/speechrecognition-errors-expected.txt: Added.
  • fast/speech/scripted/speechrecognition-errors.html: Added.
3:13 AM Changeset in webkit [120052] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Skip test failing on GTK bots after r119947.

  • platform/gtk/TestExpectations: Skip test.
2:49 AM Changeset in webkit [120051] by morrita@google.com
  • 32 edits
    1 copy
    2 moves
    4 adds in trunk

REGRESSION(r118098): <content> element does not render distributed children when cloned from another document
​https://bugs.webkit.org/show_bug.cgi?id=88148

Source/WebCore:

Reviewed by Dimitri Glazkov.

The shadow DOM availability was decided through FrameLoaderClient.
But there are documents which don't have any associated frames, in
which any shadow DOM related elements cannot be constructed. That
resulsted the regression.

This change introduces a Page-based client called
ContextFeaturesClient which takes the role from FrameLoaderClient
to decide the feature availability, and ContextFeatures which is a
proxy of ContextFeaturesClient. ContextEnabledFeatures is is
replaced with ContextFeatures.

Each ContextFeatures object is owned by a Page, and is attached to
each Document in the page even if the page itself has no referenct
to Frames or Pages. With ContextFeatures, each Document can decide
the feature availability even if it cannot reach Page or Frame.

On RefCountedSupplement: Document instance can live longer than a
Page where it is shwon. This means that ContextFeatures instance
needs to survive after owner Page destruction because it's
referenced from possibly surviving Documents. RefCountedSupplement
is introduced to cover this scenario: It allows supplement classes
to live after Page's destruction.

RefCountedSupplement::hostDestroyed() is notified when the hosting
page is gone. ContextFeatures clears its reference to the client
using this notification.

Test: fast/dom/shadow/elements-in-frameless-document.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementation):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::determineScope):

  • dom/ContextFeatures.cpp: Added.

(WebCore):
(WebCore::ContextFeaturesClient::empty):
(WebCore::ContextFeatures::supplementName):
(WebCore::ContextFeatures::defaultSwitch):
(WebCore::ContextFeatures::shadowDOMEnabled):
(WebCore::ContextFeatures::styleScopedEnabled):
(WebCore::ContextFeatures::pagePopupEnabled):
(WebCore::provideContextFeaturesTo):
(WebCore::provideContextFeaturesToDocumentFrom):

  • dom/ContextFeatures.h: Added.

(WebCore):
(ContextFeatures):
(WebCore::ContextFeatures::ContextFeatures):
(WebCore::ContextFeatures::hostDestroyed):
(ContextFeaturesClient):
(WebCore::ContextFeaturesClient::~ContextFeaturesClient):
(WebCore::ContextFeaturesClient::isEnabled):
(WebCore::ContextFeatures::create):
(WebCore::ContextFeatures::isEnabled):

  • dom/DOMAllInOne.cpp:
  • dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocument):
(WebCore::DOMImplementation::createHTMLDocument):

  • dom/Document.h:

(WebCore::Document::contextFeatures):

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::setContextFeatures):

  • dom/Position.cpp:

(WebCore::Position::Position):
(WebCore::Position::findParent):

  • dom/TreeScope.cpp:

(WebCore::TreeScope::getSelection):

  • dom/make_names.pl:

(printConstructorInterior):
(printFactoryCppFile):
(printWrapperFunctions):
(printWrapperFactoryCppFile):

  • editing/markup.cpp:

(WebCore::createFragmentFromMarkupWithContext):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::registerWithScopingNode):
(WebCore::HTMLStyleElement::unregisterWithScopingNode):

  • html/shadow/HTMLContentElement.cpp:

(WebCore::contentTagName):

  • inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::patchDocument):

  • loader/FrameLoaderClient.h:
  • platform/RefCountedSupplement.h: Copied from Source/WebCore/platform/Supplementable.h.

(WebCore):
(RefCountedSupplement):
(WebCore::RefCountedSupplement::hostDestroyed):
(Wrapper):
(WebCore::RefCountedSupplement::Wrapper::Wrapper):
(WebCore::RefCountedSupplement::Wrapper::~Wrapper):
(WebCore::RefCountedSupplement::Wrapper::wrapped):
(WebCore::RefCountedSupplement::provideTo):
(WebCore::RefCountedSupplement::from):

  • platform/Supplementable.h:

(WebCore::Supplement::isRefCountedWrapper):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::responseXML):

Source/WebKit/chromium:

Reviewed by Dimitri Glazkov.

  • Added ContextFeaturesClientImpl which implements WebCore::ContextFeaturesClient.
  • Replaced PagePopupFrameLoaderClient with PagePopupFeaturesClient.
  • WebKit.gyp:
  • public/WebPermissionClient.h:

(WebKit):
(WebKit::WebPermissionClient::allowWebComponents):

  • src/ContextFeaturesClientImpl.cpp: Renamed from Source/WebCore/bindings/generic/ContextEnabledFeatures.cpp.

(WebKit):
(WebKit::ContextFeaturesClientImpl::isEnabled):

  • src/ContextFeaturesClientImpl.h: Renamed from Source/WebCore/bindings/generic/ContextEnabledFeatures.h.

(WebKit):
(ContextFeaturesClientImpl):
(WebKit::ContextFeaturesClientImpl::ContextFeaturesClientImpl):
(WebKit::ContextFeaturesClientImpl::setPermissionClient):

  • src/FrameLoaderClientImpl.cpp:
  • src/FrameLoaderClientImpl.h:

(FrameLoaderClientImpl):

  • src/WebPagePopupImpl.cpp:

(PagePopupFeaturesClient):
(WebKit::PagePopupFeaturesClient::isEnabled):
(WebKit):
(WebKit::WebPagePopupImpl::initPage):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setPermissionClient):
(WebKit::WebViewImpl::WebViewImpl):

  • src/WebViewImpl.h:

(WebKit):

LayoutTests:

Reviewed by Dimitri Glazkov.

  • fast/dom/shadow/elements-in-frameless-document-expected.txt: Added.
  • fast/dom/shadow/elements-in-frameless-document.html: Added.
2:21 AM Changeset in webkit [120050] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed: Rebaseline gradient-after-transparent-border

Font antialiasing differences are causing this to fail after
rebaseline in r120043.

  • platform/chromium-linux/fast/gradients/gradient-after-transparent-border-expected.png:
2:10 AM Changeset in webkit [120049] by tkent@chromium.org
  • 16 edits
    2 adds in trunk

Remove unnecessary functions: setName() and formControlName()
​https://bugs.webkit.org/show_bug.cgi?id=88392

Reviewed by Kentaro Hara.

Source/WebCore:

'name' IDL attributes of form-related elements should be [Reflected],
and we don't need to have setName(). We used formControlName() for
name() implementation, and formControlName() is not needed because it
just converts a null attribute to an empty string. Our binding code does it.

We don't remove FormAssociatedElement::name() because many C++ code use it.

FormAssociatedElement::name() is virtual, and HTMLInputElement overrides
it so that it returns a cache of the name attribtue value because
CheckedRadioButtons class needs to know an old name attribute value when
the name attribtue is changed.

References:
​http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#dom-object-name
​http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#dom-form-name
​http://www.whatwg.org/specs/web-apps/current-work/multipage/association-of-controls-and-forms.html#dom-fe-name

Test: fast/forms/name-attribute.html

  • dom/Element.h: Remove formControlName().
  • html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::name):
Copied from formControlName() implementation of HTMLFormControlElement.

  • html/FormAssociatedElement.h:

(FormAssociatedElement): Make name() virtual, remove formControlName().

  • html/FormController.cpp:

(WebCore::FormController::formElementsState):
Use name() instead of formControlName().

  • html/HTMLFormControlElement.cpp:

Remove formControlName() and setName().

  • html/HTMLFormControlElement.h: ditto.
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::name): Renamed from formControlName().

  • html/HTMLInputElement.h:

(HTMLInputElement): Renamed formControlName() to name(), and make it public.

  • html/HTMLKeygenElement.idl: Make 'name' [Reflected].
  • html/HTMLObjectElement.cpp: Remove formControlName().
  • html/HTMLObjectElement.h: ditto.
  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::appendFormData):
Use name() instead of formControlName().

  • html/HTMLSelectElement.idl: Make 'name' [Reflected].
  • html/HTMLTextAreaElement.idl: Make 'name' [Reflected].

LayoutTests:

  • fast/forms/name-attribute-expected.txt: Added.
  • fast/forms/name-attribute.html: Added.
1:58 AM Changeset in webkit [120048] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Skip test crashing on GTK debug bots.

  • platform/gtk/TestExpectations: Skip test.
1:32 AM FeatureFlags edited by tkent@chromium.org
Add CSS_BOX_DECORATION_BREAK (diff)
1:21 AM Changeset in webkit [120047] by annacc@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] video-media-source-add-and-remove-ids.html needs to be skipped
until a chromium patch lands that will cause different expectations.

Unreviewed.

  • platform/chromium/TestExpectations:
12:46 AM Changeset in webkit [120046] by dominicc@chromium.org
  • 3 edits
    1 delete in trunk/LayoutTests

[Chromium] Unreviewed: Rebaseline gradients tests

Rebaseline two gradients tests after r120033 that I missed in
rebaselines in r120043.

  • platform/chromium-linux-x86/fast/gradients/css3-radial-gradients2-expected.png: Removed.
  • platform/chromium-linux/fast/gradients/css3-radial-gradients2-expected.png:
  • platform/chromium-linux/fast/gradients/gradient-after-transparent-border-expected.png:
12:08 AM Changeset in webkit [120045] by commit-queue@webkit.org
  • 5 edits in trunk

Property names of the built-in object cannot be retrieved
after trying to delete one of its properties
​https://bugs.webkit.org/show_bug.cgi?id=86461

Patch by Hojong Han <​hojong.han@samsung.com> on 2012-06-12
Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

  • runtime/JSObject.cpp:

(JSC::getClassPropertyNames):
(JSC::JSObject::getOwnPropertyNames):

LayoutTests:

  • fast/js/delete-syntax-expected.txt:
  • fast/js/script-tests/delete-syntax.js:

Jun 11, 2012:

11:24 PM Changeset in webkit [120044] by thakis@chromium.org
  • 69 edits in trunk/Source

Remove unused member variables found by clang's -Wunused-private-field
​https://bugs.webkit.org/show_bug.cgi?id=88812

Reviewed by Anders Carlsson.

Source/WebCore:

Change a few |class|s that were used only to pin down the size of
existing classes to |struct|, so that clang doesn't warn about these
memvars.

No intended behavior change.

  • Modules/geolocation/GeolocationController.cpp:

(WebCore::GeolocationController::GeolocationController):

  • Modules/geolocation/GeolocationController.h:

(GeolocationController):

  • Modules/webaudio/AudioContext.h:

(AudioContext):

  • Modules/webaudio/AudioParamTimeline.h:

(AudioParamTimeline):

  • accessibility/AccessibilityScrollbar.h:

(AccessibilityScrollbar):

  • bindings/v8/ScriptScope.cpp:

(WebCore::ScriptScope::ScriptScope):

  • bindings/v8/ScriptScope.h:

(ScriptScope):

  • css/CSSValue.cpp:
  • css/StylePropertySet.cpp:
  • dom/DeviceOrientationController.cpp:

(WebCore::DeviceOrientationController::DeviceOrientationController):

  • dom/DeviceOrientationController.h:

(DeviceOrientationController):

  • editing/ReplaceSelectionCommand.cpp:

(ReplacementFragment):
(WebCore::ReplacementFragment::ReplacementFragment):

  • editing/TextIterator.cpp:

(WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):

  • editing/TextIterator.h:

(SimplifiedBackwardsTextIterator):
(BackwardsCharacterIterator):

  • html/HTMLFormCollection.cpp:

(WebCore::HTMLFormCollection::HTMLFormCollection):

  • html/HTMLFormCollection.h:

(HTMLFormCollection):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):

  • html/shadow/MediaControlElements.h:

(MediaControlFullscreenButtonElement):

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):

  • html/shadow/MediaControlRootElementChromium.h:

(MediaControlRootElementChromium):

  • html/track/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::LoadableTextTrack):

  • html/track/LoadableTextTrack.h:

(LoadableTextTrack):

  • inspector/CodeGeneratorInspector.py:

(Generator.go):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::InspectorCSSAgent):

  • inspector/InspectorCSSAgent.h:

(InspectorCSSAgent):

  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):

  • inspector/InspectorDOMDebuggerAgent.h:

(InspectorDOMDebuggerAgent):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::InspectorMemoryAgent):

  • inspector/InspectorMemoryAgent.h:

(InspectorMemoryAgent):

  • notifications/NotificationController.cpp:

(WebCore::NotificationController::NotificationController):

  • notifications/NotificationController.h:

(NotificationController):

  • page/animation/CompositeAnimation.h:

(WebCore::CompositeAnimation::CompositeAnimation):
(CompositeAnimation):

  • platform/Length.cpp:
  • platform/audio/ReverbConvolver.cpp:

(WebCore::ReverbConvolver::ReverbConvolver):

  • platform/audio/ReverbConvolver.h:

(ReverbConvolver):

  • platform/audio/ReverbConvolverStage.cpp:

(WebCore::ReverbConvolverStage::ReverbConvolverStage):

  • platform/audio/ReverbConvolverStage.h:

(ReverbConvolverStage):

  • platform/graphics/TextRun.cpp:

(ExpectedTextRunSize):

  • platform/graphics/chromium/cc/CCThreadProxy.h:

(CCThreadProxy):

  • platform/graphics/filters/FECustomFilter.cpp:

(WebCore::FECustomFilter::FECustomFilter):

  • platform/graphics/filters/FECustomFilter.h:

(FECustomFilter):

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(JPEGImageReader):

  • platform/leveldb/LevelDBTransaction.cpp:

(WebCore::LevelDBTransaction::TreeIterator::next):

  • platform/text/TextCodecICU.cpp:

(WebCore::TextCodecICU::TextCodecICU):

  • platform/text/TextCodecICU.h:

(TextCodecICU):

  • rendering/InlineBox.cpp:
  • rendering/InlineFlowBox.cpp:
  • rendering/RenderText.cpp:
  • rendering/style/KeyframeList.h:

(WebCore::KeyframeList::KeyframeList):
(KeyframeList):

  • rendering/svg/RenderSVGTextPath.cpp:

(WebCore::RenderSVGTextPath::RenderSVGTextPath):

  • rendering/svg/RenderSVGTextPath.h:
  • rendering/svg/SVGInlineTextBox.cpp:
  • svg/SVGPathByteStreamSource.cpp:
  • svg/SVGPathByteStreamSource.h:
  • svg/SVGPathTraversalStateBuilder.cpp:

(WebCore::SVGPathTraversalStateBuilder::SVGPathTraversalStateBuilder):

  • svg/SVGPathTraversalStateBuilder.h:

(SVGPathTraversalStateBuilder):

  • xml/XSLStyleSheet.h:

Source/WebKit/chromium:

  • src/AudioDestinationChromium.cpp:

(WebCore::AudioDestinationChromium::AudioDestinationChromium):

  • src/AudioDestinationChromium.h:

(AudioDestinationChromium):

  • src/InspectorFrontendClientImpl.cpp:

(WebKit::InspectorFrontendClientImpl::InspectorFrontendClientImpl):

  • src/InspectorFrontendClientImpl.h:

(InspectorFrontendClientImpl):

  • src/WebFrameImpl.cpp:

(ChromePluginPrintContext):

  • src/WebInputEvent.cpp:
  • src/WorkerAsyncFileSystemChromium.cpp:

(WebCore::WorkerAsyncFileSystemChromium::createWorkerFileSystemCallbacksBridge):

  • src/WorkerAsyncFileWriterChromium.cpp:

(WebCore::WorkerAsyncFileWriterChromium::WorkerAsyncFileWriterChromium):

  • src/WorkerAsyncFileWriterChromium.h:

(WorkerAsyncFileWriterChromium):

  • tests/CCLayerTreeHostTest.cpp:

(WTF::CCLayerTreeHostTestSetVisible::CCLayerTreeHostTestSetVisible):
(CCLayerTreeHostTestSetVisible):

11:22 PM Changeset in webkit [120043] by dominicc@chromium.org
  • 30 edits
    1 copy
    2 adds
    5 deletes in trunk/LayoutTests

[Chromium] Unreviewed: Rebaseline gradients tests

r120033 added IMAGE failures for bunch of gradient tests that will
need rebaselining as a result of that change. This is that
rebaseline.

(File list elided because it is too long.)

11:17 PM Changeset in webkit [120042] by kinuko@chromium.org
  • 3 edits
    2 adds in trunk

XHR returns size==0 Blob
​https://bugs.webkit.org/show_bug.cgi?id=88750

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Response Blob's .size field must have the correct response size.

Test: http/tests/xmlhttprequest/response-blob-size.html

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::responseBlob):

LayoutTests:

  • http/tests/xmlhttprequest/response-blob-size-expected.txt: Added.
  • http/tests/xmlhttprequest/response-blob-size.html: Added.
11:03 PM Changeset in webkit [120041] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit2

[CMAKE][WK2] Make WebProcess target name more clear.
​https://bugs.webkit.org/show_bug.cgi?id=88767

Reviewed by Ryosuke Niwa.

  • CMakeLists.txt: Change WebProcess_NAME to WebProcess_EXECUTABLE_NAME.
10:40 PM Changeset in webkit [120040] by commit-queue@webkit.org
  • 10 edits in trunk

Introduce an Enclosure Element for Chromium video controls.
​https://bugs.webkit.org/show_bug.cgi?id=87683

Patch by Silvia Pfeiffer <​silviapf@chromium.org> on 2012-06-11
Reviewed by Eric Carlson.

Source/WebCore:

Updated tests.

The Chrome video controls are receiving a visual update. A new enclosure div is required
to provide for a offset space from the video's boundaries. The visual update itself is in
a separate patch.

  • css/mediaControlsChromium.css:

(video::-webkit-media-controls-enclosure):
Introduce CSS for enclosure div so it doesn't show yet.

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlChromiumEnclosureElement::MediaControlChromiumEnclosureElement):
Definition of the new enclosure element.
(WebCore::MediaControlChromiumEnclosureElement::create):
Definition of a create operator for the new enclosure element.
(WebCore::MediaControlChromiumEnclosureElement::shadowPseudoId):
Definition of the shadowPseudoId of -webkit-media-controls-enclosure for the enclosure div.
(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
Initialize member element for enclosure div.
(WebCore::MediaControlRootElementChromium::create):
Instantiate enclosure div and add into DOM between controls and panel elements.
(WebCore::MediaControlRootElementChromium::setMediaController):
Set media controller for enclosure div.
(WebCore::MediaControlRootElementChromium::createTextTrackDisplay):
Insert text track display container to enclosure rather than panel.

  • html/shadow/MediaControlRootElementChromium.h:

(WebCore):
(MediaControlChromiumEnclosureElement):
(WebCore::MediaControlChromiumEnclosureElement::setMediaController):
(WebCore::MediaControlChromiumEnclosureElement::mediaController):
(WebCore::MediaControlChromiumEnclosureElement::isMediaControlElement):
Add declaration of the new enclosure element and its member functions.
(MediaControlRootElementChromium):
Add member variable to controls root element to hold the enclosure element.

LayoutTests:

Change fullscreen/video-controls-override.html, media/media-controls-invalid-url.html and
media/track/track-cue-rendering-snap-to-lines-not-set.html to deal with the new enclosure
div in Chromium controls and use the mediaControlsElement() helper function to find elements
inside the controls.
Fail video controls tests in test expectations.

  • fullscreen/video-controls-override-expected.txt: Updated.
  • fullscreen/video-controls-override.html: Use mediaControlsElement helper function.
  • media/media-controls-invalid-url.html: Use mediaControlsElement helper function.
  • media/track/track-cue-rendering-snap-to-lines-not-set.html: Height is provided by enclosure element.
  • platform/chromium/TestExpectations: Fail video controls tests.
10:32 PM Changeset in webkit [120039] by ojan@chromium.org
  • 3 edits in trunk/Tools

Don't show the ASAN builders in garden-o-matic since they don't get block WebKit rolls.
​https://bugs.webkit.org/show_bug.cgi?id=88836

Reviewed by Dirk Pranke.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
9:23 PM Changeset in webkit [120038] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed: Expectations for track-cues-cuechange.html
​https://bugs.webkit.org/show_bug.cgi?id=88833

media/track/track-cues-cuechange.html is timing out flakily like
some other media tests noted in bug 88833.

  • platform/chromium/TestExpectations:
9:10 PM Changeset in webkit [120037] by commit-queue@webkit.org
  • 5 edits in trunk

WebKit doesn't allow replacing the document element with a DocumentFragment containing one element
​https://bugs.webkit.org/show_bug.cgi?id=88681

Patch by Elliott Sprehn <Elliott Sprehn> on 2012-06-11
Reviewed by Ojan Vafai.

Source/WebCore:

Fix bug where replacing an immediate child of a Document with a DocumentFragment
would throw a HIERARCHY_REQUEST_ERR instead of replacing the node as required by DOM4.
​http://www.w3.org/TR/domcore/#mutation-algorithms

  • dom/Document.cpp:

(WebCore::Document::canReplaceChild):

When the newChild was a DocumentFragment we incorrectly
iterated over the document's children twice instead of the
fragment when counting the total number of elements and
doctypes to enfoce that there's only one of each.

LayoutTests:

Re-enables a bunch of disabled tests that are long since fixed and rewrites
the tests to use a more modern js-test-pre.js style.
​https://bugs.webkit.org/show_bug.cgi?id=12751

  • fast/dom/Document/replace-child-expected.txt:
  • fast/dom/Document/replace-child.html:
8:46 PM Changeset in webkit [120036] by mary.wu@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Add handling of notifyDataReceived in NetworkJob even there's no data inside
​https://bugs.webkit.org/show_bug.cgi?id=88773

Reviewed by Rob Buis.

Handling notifyDataReceived event even if there is no data inside.
This event was critical because it gives downloadFilterStream a chance
to follow up NetworkStream close event, and it also make pluginView in
FrameLoaderBlackBerry return normal logic.

RIM PR# 164563

Reviewed internally by Leo Yang.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::handleNotifyDataReceived):

8:44 PM Changeset in webkit [120035] by mary.wu@torchmobile.com.cn
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Wrong mimetype for empty file link
​https://bugs.webkit.org/show_bug.cgi?id=88642

Reviewed by Rob Buis.

RIM PR# 164164

For empty file link, we shouldn't give "application/octet-stream"
which will lead to download.

Reviewed internally by Charles Wei.

  • platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::sendResponseIfNeeded):

8:21 PM Changeset in webkit [120034] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed: Update test expectations with bugs for media test timeouts

  • platform/chromium/TestExpectations:
8:04 PM Changeset in webkit [120033] by commit-queue@webkit.org
  • 4 edits in trunk

GeneratorGeneratedImage should cache images for the non-tiled case
​https://bugs.webkit.org/show_bug.cgi?id=87094

Patch by Jin Yang <​jin.a.yang@intel.com> on 2012-06-11
Reviewed by Simon Fraser.

Source/WebCore:

We cache the generated image if generator is not changed. By compared
with generating image on the fly, it will lose a little pixel precision
and several layout tests should be rebaselined. With this patch, the IE test
drive benchmark "Bayou" can gain about 50%.

No new tests. Performance optimization.

  • platform/graphics/GeneratorGeneratedImage.cpp:

(WebCore::GeneratorGeneratedImage::draw):

LayoutTests:

Update expectations: added failures for baselines to come.

  • platform/chromium/TestExpectations:
8:04 PM Changeset in webkit [120032] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Remove CMakeCache.txt before building
​https://bugs.webkit.org/show_bug.cgi?id=88717

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-11
Reviewed by Antonio Gomes.

Remove CMake cache file before every build to avoid using outdated
build flags when new features get enabled. This will avoid unexpected
failures on the bots due to outdated build flags.

  • Scripts/webkitdirs.pm:

(generateBuildSystemFromCMakeProject):

8:02 PM Changeset in webkit [120031] by scheib@chromium.org
  • 15 edits in trunk

Add new Pointer Lock spec attribute webkitPointerLockElement.
​https://bugs.webkit.org/show_bug.cgi?id=88799

Source/WebCore:

Reviewed by Dimitri Glazkov.

Part of a series of refactoring changes to update pointer lock API to
the fullscreen locking style. ​https://bugs.webkit.org/show_bug.cgi?id=84402

New attribute webkitPointerLockElement added. Follow up patches
will remove the previous isLocked attribute. Tests updated to use
the new attribute.

  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::webkitPointerLockElementEnabled):

  • dom/Document.cpp:

(WebCore):
(WebCore::Document::webkitPointerLockElement):

  • dom/Document.h:

(Document):

  • dom/Document.idl:
  • page/PointerLockController.h:

(WebCore::PointerLockController::element):

Tools:

Reviewed by Dimitri Glazkov.

Part of a series of refactoring changes to update pointer lock API to
the fullscreen locking style. ​https://bugs.webkit.org/show_bug.cgi?id=84402

New attribute webkitPointerLockElement added. Follow up patches
will remove the previous isLocked attribute. Tests updated to use
the new attribute.

WebViewHost logic required modification to correctly repond to
a lock, unlock, pointerLockElement call series. Specifically,
unlocking must be queued after a lock command is issued always
as the lock state may not be set yet with a lock request in flight.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::requestPointerUnlock): Always post didLosePointerLock task.
(WebViewHost::didLosePointerLock): Signal didLosePointerLock only if pointer was locked.

LayoutTests:

Part of a series of refactoring changes to update pointer lock API to
the fullscreen locking style. ​https://bugs.webkit.org/show_bug.cgi?id=84402

New attribute webkitPointerLockElement added. Follow up patches
will remove the previous isLocked attribute. Tests updated to use
the new attribute.

Reviewed by Dimitri Glazkov.

  • pointer-lock/lock-already-locked-expected.txt:
  • pointer-lock/lock-already-locked.html:
  • pointer-lock/pointer-lock-api-expected.txt:
  • pointer-lock/pointer-lock-api.html:
  • pointer-lock/pointerlocklost-event-expected.txt:
  • pointer-lock/pointerlocklost-event.html:
7:51 PM Changeset in webkit [120030] by scheib@chromium.org
  • 7 edits in trunk/Source

Consolidate Pointer Lock runtime enabled flags to just one.
​https://bugs.webkit.org/show_bug.cgi?id=88810

Reviewed by Dimitri Glazkov.

Source/WebCore:

No new tests.

  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::pointerLockEnabled):
(WebCore::RuntimeEnabledFeatures::setPointerLockEnabled):

  • dom/MouseEvent.idl:
  • page/Navigator.idl:

Source/WebKit/chromium:

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enablePointerLock):
(WebKit::WebRuntimeFeatures::isPointerLockEnabled):

7:21 PM Changeset in webkit [120029] by alexis.menard@openbossa.org
  • 26 edits in trunk

[CSS3 Backgrounds and Borders] Protect box-decoration-break behind a feature flag.
​https://bugs.webkit.org/show_bug.cgi?id=88804

Reviewed by Tony Chang.

Protect box-decoration-break behind a feature flag enabled by default.

.:

  • configure.ac:

Source/WebCore:

No new tests : no behavior change here.

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSValueKeywords.in:
  • css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder):

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleBoxData.cpp:

(WebCore::StyleBoxData::StyleBoxData):
(WebCore::StyleBoxData::operator==):

  • rendering/style/StyleBoxData.h:

(StyleBoxData):

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
7:05 PM Changeset in webkit [120028] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed: http/tests/xmlhttprequest/origin-exact-matching.html is timing out on XP about half the time

  • platform/chromium/TestExpectations:
6:48 PM Changeset in webkit [120027] by jchaffraix@webkit.org
  • 4 edits in trunk/LayoutTests

Unreviewed expected result update after r120017.

  • platform/gtk/fast/block/basic/fieldset-stretch-to-legend-expected.txt:

Rebaselined gtk.

  • platform/efl/Skipped:
  • platform/qt/Skipped:

Skipped the test with some explanation on those platforms as I couldn't get
the new baseline.

6:42 PM Changeset in webkit [120026] by mitz@apple.com
  • 3 edits in trunk/LayoutTests

Updated expected results for this test after r120017.

  • platform/mac/fast/block/basic/fieldset-stretch-to-legend-expected.png:
  • platform/mac/fast/block/basic/fieldset-stretch-to-legend-expected.txt:
6:12 PM Changeset in webkit [120025] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Added http/tests/security/mixedContent/blob-url-in-iframe.html back to the Mac skip list, as
it is still failing intermittently. <​http://webkit.org/b/88736> will track this.

  • platform/mac/Skipped:
6:09 PM FeatureFlags edited by tkent@chromium.org
Add CSS_IMAGE_RESOLUTION (diff)
5:58 PM Changeset in webkit [120024] by gyuyoung.kim@samsung.com
  • 7 edits in trunk

[CMAKE][EFL] Remove duplicated executable output path
​https://bugs.webkit.org/show_bug.cgi?id=88765

Reviewed by Daniel Bates.

CMake files for EFL port have redefined executable output path. However, EFL port doesn't
need to define again because it is already defined in top-level CMake file.

Source/JavaScriptCore:

  • shell/CMakeLists.txt:

Source/WebKit2:

  • CMakeLists.txt:

Tools:

  • DumpRenderTree/efl/CMakeLists.txt:
  • EWebLauncher/CMakeLists.txt:
5:39 PM Changeset in webkit [120023] by jamesr@google.com
  • 11 edits
    1 copy in trunk/Source

[chromium] Port DrawingBufferChromium from TextureLayerChromium over to WebExternalTextureLayer
​https://bugs.webkit.org/show_bug.cgi?id=86273

Reviewed by Adrienne Walker.

Source/Platform:

  • Platform.gypi:
  • chromium/public/WebExternalTextureLayer.h:

(WebKit):
(WebExternalTextureLayer):

  • chromium/public/WebExternalTextureLayerClient.h: Copied from Source/WebKit/chromium/src/WebExternalTextureLayer.cpp.

(WebKit):
(WebTextureUpdater):
(WebKit::WebTextureUpdater::~WebTextureUpdater):
(WebExternalTextureLayerClient):
(WebKit::WebExternalTextureLayerClient::~WebExternalTextureLayerClient):

Source/WebCore:

This converts more WebCore code over to using public APIs instead of internal compositor layer types.

Refactor only, no change in behavior thus no new tests.

  • platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBufferPrivate::DrawingBufferPrivate):
(WebCore::DrawingBufferPrivate::~DrawingBufferPrivate):
(WebCore::DrawingBufferPrivate::layer):
(DrawingBufferPrivate):

  • platform/graphics/chromium/TextureLayerChromium.cpp:

(WebCore::TextureLayerChromium::~TextureLayerChromium):
(WebCore::TextureLayerChromium::setRateLimitContext):
(WebCore::TextureLayerChromium::setNeedsDisplayRect):
(WebCore::TextureLayerChromium::update):

  • platform/graphics/chromium/TextureLayerChromium.h:

(WebKit):
(TextureLayerChromiumClient):

Source/WebKit/chromium:

  • src/WebExternalTextureLayer.cpp:

(WebTextureUpdaterImpl):
(WebKit::WebTextureUpdaterImpl::WebTextureUpdaterImpl):
(WebKit):
(WebExternalTextureLayerImpl):
(WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl):
(WebKit::WebExternalTextureLayer::create):
(WebKit::WebExternalTextureLayer::clearClient):
(WebKit::WebExternalTextureLayer::setOpaque):
(WebKit::WebExternalTextureLayer::setPremultipliedAlpha):

5:32 PM Changeset in webkit [120022] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Autofill feature implementation for BlackBerry porting
​https://bugs.webkit.org/show_bug.cgi?id=85577

Patch by Jonathan Dong <Jonathan Dong> on 2012-06-11
Reviewed by Rob Buis.

Remove the autofill saving procedure out of dispatchWillSubmitForm, this procedure
is same as the procedure in dispatchWillSendSubmitEvent.
Some sites will redirect to other url in its login process, which will cause the
user get notified to save credentials for this provisional redirecting url if we
put this saving procedure in dispatchWillSubmitForm. So we should remove it to make
sure we only save the autofill data before the submit event is fired.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchWillSubmitForm):

5:29 PM Changeset in webkit [120021] by andersca@apple.com
  • 26 edits
    1 copy
    1 add in trunk

Pass the right color space over to the web process so we can set it on our CA context
​https://bugs.webkit.org/show_bug.cgi?id=88819
<rdar://problem/11629050>

Reviewed by John Sullivan.

Source/WebKit2:

  • Platform/mac/LayerHostingContext.h:

(LayerHostingContext):

  • Platform/mac/LayerHostingContext.mm:

(WebKit::LayerHostingContext::createForPort):
(WebKit::LayerHostingContext::createForWindowServer):
Use a single constructor and explicitly set up the parameters of the constructed object.

(WebKit::LayerHostingContext::setColorSpace):
(WebKit::LayerHostingContext::colorSpace):
Add getter and setter.

  • Scripts/webkit2/messages.py:

(struct_or_class):
WebKit::ColorSpaceData is a struct.

  • Shared/WebPageCreationParameters.cpp:

Encode and decode the color space parameter.

  • Shared/WebPageCreationParameters.h:

Add the color space.

  • Shared/mac/ColorSpaceData.h: Added.
  • Shared/mac/ColorSpaceData.mm: Added.

Add a new class that represents a color space that can be sent over the wire.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::colorSpace):
Call through to the WKView.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _windowDidChangeBackingProperties:]):
Fix whitespace.

(-[WKView viewDidChangeBackingProperties]):
Check if our new color space is different from the current one and null the current one out if that is the case,
it will be reinitialized by the next call to -[WKView _colorSpace].

(-[WKView _colorSpace:]):
Compute the color space. If we're not in a window we'll get the main screen's color space.

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::colorSpaceDidChange):
Add empty stub.

  • UIProcess/PageClient.h:

Add colorSpace getter.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::creationParameters):
Initialize the color space.

  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::colorSpaceDidChange):
Send the new color space over to the web process.

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::colorSpace):
Call through to the page client.

  • WebKit2.xcodeproj/project.pbxproj:

Add ColorSpaceData.h and ColorSpaceData.mm.

  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/DrawingArea.messages.in:

Add SetColorSpace message.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
Set the color space from the creation parameters.

(WebKit::TiledCoreAnimationDrawingArea::setColorSpace):
Set the color space on the layer hosting context.

(WebKit::TiledCoreAnimationDrawingArea::updateLayerHostingContext):
Make sure we apply the color space from the previous layer hosting context if one exists.

WebKitLibraries:

Add WKCAContextSetColorSpace and WKCAContextGetColorSpace.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
5:02 PM Changeset in webkit [120020] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Seek calls are being unnecessarily delayed
​https://bugs.webkit.org/show_bug.cgi?id=88732

Patch by Max Feil <​mfeil@rim.com> on 2012-06-11
Reviewed by Antonio Gomes.

There is a problem with the way the m_userDrivenSeekTimer is
implemented. When MediaPlayerPrivate::seek() is called, there
is always a 100ms delay even if the timer is not running. The
timer is supposed to space out (i.e. throttle) repeated seeks
that come in too soon after a previous seek, but currently it
is slowing down even single seeks and seeks that come in with
adequate delay after a previous seek. I fixed this in my patch
by improving the way the timer fired function is called.

A note on the new m_lastSeekTimePending flag: This flag is
needed so that userDrivenSeekTimerFired() knows whether or not
to perform the seek. The only case where this flag will not be
set is if no MediaPlayerPrivate::seek() call came in while the
timer was active, in which case it's important to do nothing.
I could encode this flag's information into the m_lastSeekTime
float, for example by initializing it and resetting it to NAN
and using isnan(). But I feel that using a separate bool is a
more portable approach.

No new tests. I would like to propose not including a layout test
with this fix. Doing timing tests for 100ms delays is tricky
from Javascript, and I don't think the benefit of such a test
outweighs the extra time it would take to develop one. The test
would also be a problem to maintain as it may give different
results over different runs and across different target hardware.

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::seek):
(WebCore::MediaPlayerPrivate::userDrivenSeekTimerFired):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(MediaPlayerPrivate):

4:48 PM Changeset in webkit [120019] by ojan@chromium.org
  • 4 edits in trunk/Tools

Don't consider show warnings in the garden-o-matic UI for non-layout test failures
​https://bugs.webkit.org/show_bug.cgi?id=88816

Reviewed by Dirk Pranke.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:

Expose a way to clear AsynchronousCaches.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:

Clear the buildInfo cache at the beginning of each test in order to avoid having one test affect another.

4:18 PM Changeset in webkit [120018] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

[BlackBerry] Unexpected repeats of short media
​https://bugs.webkit.org/show_bug.cgi?id=88733

Patch by Max Feil <​mfeil@rim.com> on 2012-06-11
Reviewed by Antonio Gomes.

Source/WebCore:

The m_userDrivenSeekTimer is causing unwanted repeats of short
media such as sound effects because it is causing the current
time to not reflect that the media has finished playing.
This problem only affects media whose duration is close to
or less than the SeekSubmissionDelay, which is currently
set to 100ms. My fix is to ignore the userDrivenSeekTimer in
MediaPlayerPrivate::currentTime() if the duration of the media
is within twice the SeekSubmissionDelay. Seek drag smoothness
is a non-issue for such short media.

Test: platform/blackberry/media/short-media-repeats-correctly.html

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore):
(WebCore::MediaPlayerPrivate::currentTime):
(WebCore::MediaPlayerPrivate::seek):
(WebCore::MediaPlayerPrivate::userDrivenSeekTimerFired):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(MediaPlayerPrivate):

LayoutTests:

Test for problem where short media repeats unintentionally.

  • media/content/short.wav: Added.
  • platform/blackberry/media/short-media-repeats-correctly-expected.txt: Added.
  • platform/blackberry/media/short-media-repeats-correctly.html: Added.
4:14 PM Changeset in webkit [120017] by jchaffraix@webkit.org
  • 3 edits
    8 adds in trunk

Account for margin after when laying out <legend> element
​https://bugs.webkit.org/show_bug.cgi?id=35981

Reviewed by Abhishek Arya.

Source/WebCore:

Tests: fast/forms/legend-after-margin-horizontal-writing-mode.html

fast/forms/legend-after-margin-vertical-writing-mode.html
fast/forms/legend-after-margin-with-before-border-horizontal-mode.html
fast/forms/legend-small-after-margin-before-border-horizontal-mode.html

The existing code would ignore margin after when layouting out the <legend>. This
change only adds the code to handle the margin after, the margin before is still
ignored as it's not obvious how it should be working.

  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::layoutSpecialExcludedChild):
Split the code in 2 code paths to reflect how we position and size. Those are covered by the
tests above.

LayoutTests:

  • fast/forms/legend-after-margin-horizontal-writing-mode-expected.html: Added.
  • fast/forms/legend-after-margin-horizontal-writing-mode.html: Added.
  • fast/forms/legend-after-margin-vertical-writing-mode-expected.html: Added.
  • fast/forms/legend-after-margin-vertical-writing-mode.html: Added.
  • fast/forms/legend-after-margin-with-before-border-horizontal-mode-expected.html: Added.
  • fast/forms/legend-after-margin-with-before-border-horizontal-mode.html: Added.
  • fast/forms/legend-small-after-margin-before-border-horizontal-mode-expected.html: Added.
  • fast/forms/legend-small-after-margin-before-border-horizontal-mode.html: Added.
4:12 PM Changeset in webkit [120016] by jamesr@google.com
  • 6 edits in trunk/Source/WebCore

[chromium] Use WebGraphicsContext3D in rate limiting logic inside compositor
​https://bugs.webkit.org/show_bug.cgi?id=86259

Reviewed by Adrienne Walker.

This refactors the compositor's rate limiting implementation to use the Platform API's WebGraphicsContext3D
directly instead of WebCore::GraphicsContext3D to cut down on the number of spurious WebCore dependencies in the
compositor. The one change in contract is that the caller to CCLayerTreeHost::startRateLimit() now has to call
CCLayerTreeHost::stopRateLimit() before allowing the referenced context to go away since CCLayerTreeHost no
longer retains a reference, but this was always happening already.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp:

(WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium):
(WebCore::Canvas2DLayerChromium::setNeedsDisplayRect):

  • platform/graphics/chromium/RateLimiter.cpp:

(WebCore::RateLimiter::create):
(WebCore::RateLimiter::RateLimiter):
(WebCore::RateLimiter::start):
(WebCore::RateLimiter::rateLimitContext):

  • platform/graphics/chromium/RateLimiter.h:

(WebKit):
(RateLimiter):

  • platform/graphics/chromium/TextureLayerChromium.cpp:

(WebCore::TextureLayerChromium::~TextureLayerChromium):
(WebCore::TextureLayerChromium::setRateLimitContext):
(WebCore::TextureLayerChromium::setNeedsDisplayRect):

  • platform/graphics/chromium/cc/CCLayerTreeHost.cpp:

(WebCore::CCLayerTreeHost::startRateLimiter):
(WebCore::CCLayerTreeHost::stopRateLimiter):
(WebCore::CCLayerTreeHost::rateLimit):
(WebCore):

  • platform/graphics/chromium/cc/CCLayerTreeHost.h:

(CCLayerTreeHost):

3:58 PM Changeset in webkit [120015] by danakj@chromium.org
  • 13 edits
    1 delete in trunk/Source

[chromium] Separate CCVideoDrawQuad and from the layer tree and video provider by removing ManagedTexture and WebVideoFrame pointers from the quad
​https://bugs.webkit.org/show_bug.cgi?id=88363

Reviewed by Adrienne Walker.

Source/Platform:

  • Platform.gypi:
  • chromium/public/WebVideoFrame.h:
  • chromium/src/WebVideoFrame.cpp: Removed.

Source/WebCore:

CCVideoDrawQuad should not contain any pointers to data in the layer
tree so we are able to serialize it across process boundaries. This
patch removes the ManagedTexture pointers from the quad class,
replacing them with texture ids. It removes the WebVideoFrame* from
the quad, replacing it with the frame provider's texture id included
in the WebVideoFrame structure. And it uses a WebTransformationMatrix
instead of a pointer to an array of floats.

Texture allocation is done in CCVideoLayerImpl via the
contentsTextureAllocator, so that the memory usage can be tracked.

We move the copyPlaneToTextures() method back from LayerRendererChromium
to CCVideoLayerImpl, as this method uses the texture data pointer in the
WebVideoFrame, and we do not want to give this pointer to the quad
class. Instead, this method makes use of the LayerTextureSubImage class
to copy the pixel data into the texture.

LayerTextureSubImage is updated to allow non-4byte texture formats.

  • platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::drawYUV):
(WebCore::LayerRendererChromium::drawRGBA):
(WebCore::LayerRendererChromium::drawNativeTexture2D):
(WebCore::LayerRendererChromium::drawStreamTexture):
(WebCore::LayerRendererChromium::drawVideoQuad):

  • platform/graphics/chromium/LayerTextureSubImage.cpp:

(WebCore::LayerTextureSubImage::uploadWithTexSubImage):
(WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):

  • platform/graphics/chromium/TextureCopier.cpp:
  • platform/graphics/chromium/cc/CCVideoDrawQuad.cpp:

(WebCore::CCVideoDrawQuad::create):
(WebCore::CCVideoDrawQuad::CCVideoDrawQuad):

  • platform/graphics/chromium/cc/CCVideoDrawQuad.h:

(CCVideoDrawQuad):
(WebCore::CCVideoDrawQuad::planes):
(WebCore::CCVideoDrawQuad::frameProviderTextureId):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:

(WebCore::CCVideoLayerImpl::~CCVideoLayerImpl):
(WebCore::CCVideoLayerImpl::willDraw):
(WebCore::CCVideoLayerImpl::willDrawInternal):
(WebCore::CCVideoLayerImpl::appendQuads):
(WebCore::CCVideoLayerImpl::didDraw):
(WebCore::CCVideoLayerImpl::FramePlane::allocateData):
(WebCore):
(WebCore::CCVideoLayerImpl::FramePlane::freeData):
(WebCore::CCVideoLayerImpl::allocatePlaneData):
(WebCore::CCVideoLayerImpl::copyPlaneData):
(WebCore::CCVideoLayerImpl::freePlaneData):
(WebCore::CCVideoLayerImpl::freeUnusedPlaneData):
(WebCore::CCVideoLayerImpl::didLoseContext):

  • platform/graphics/chromium/cc/CCVideoLayerImpl.h:

(FramePlane):
(WebCore::CCVideoLayerImpl::FramePlane::FramePlane):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:
  • tests/CCTiledLayerTestCommon.h:

(WebKitTests::FakeTextureCopier::copyToTexture):

  • tests/Canvas2DLayerChromiumTest.cpp:
3:41 PM Changeset in webkit [120014] by jsbell@chromium.org
  • 4 edits in trunk/Source

IndexedDB: Object stores are not successfully deleted
​https://bugs.webkit.org/show_bug.cgi?id=88788

Reviewed by Tony Chang.

Source/WebCore:

Discovered while working on ​http://webkit.org/b/83074 - object stores are not
being deleted from the backing store. Deletion would succeed in the in-memory
data structures, but after closing/re-opening the backing store the object store
(but not its indexes/data) would reappear. Due to 83074, this isn't detectable
by DRT without a full restart.

Test: [chromium] webkit_unit_tests --gtest_filter='IDBLevelDBCodingTest.ComparisonTest'

  • Modules/indexeddb/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::compare):

Source/WebKit/chromium:

  • tests/IDBLevelDBCodingTest.cpp:

(IDBLevelDBCoding::TEST):

3:29 PM Changeset in webkit [120013] by ericu@chromium.org
  • 5 edits in trunk

Crash in fast/files/read tests during Garbage Collection
​https://bugs.webkit.org/show_bug.cgi?id=87165

Reviewed by Michael Saboff

Source/WebCore:

Fix previous fix for hasPendingActivity, and fix a bug in a complex
abort case as well--abort during the final progress event of a write
would hang the writer.

  • Modules/filesystem/FileWriter.cpp:

(WebCore::FileWriter::stop):
(WebCore::FileWriter::write):
(WebCore::FileWriter::truncate):
(WebCore::FileWriter::didWrite):
(WebCore::FileWriter::didTruncate):
(WebCore::FileWriter::didFail):
(WebCore::FileWriter::completeAbort):
(WebCore::FileWriter::doOperation):
(WebCore::FileWriter::signalCompletion):

LayoutTests:

Simplify file-writer-abort-continue.js a bit, and add a new test case
for a write that gets aborted in the final progress event, which
previously would have hung the FileWriter.

  • fast/filesystem/file-writer-abort-continue-expected.txt:
  • fast/filesystem/resources/file-writer-abort-continue.js:
3:16 PM Changeset in webkit [120012] by commit-queue@webkit.org
  • 5 edits in trunk

.: Replace obsolete mkdir_p variable with MKDIR_P
​https://bugs.webkit.org/show_bug.cgi?id=88790

Patch by Arnaud Renevier <​arno@renevier.net> on 2012-06-11
Reviewed by Martin Robinson.

  • GNUmakefile.am:
  • configure.ac:

Source/WebKit/gtk/po: Replace obsolete mkdir_p variables with MKDIR_P
​https://bugs.webkit.org/show_bug.cgi?id=88790

Patch by Arnaud Renevier <​arno@renevier.net> on 2012-06-11
Reviewed by Martin Robinson.

  • GNUmakefile.am:
3:05 PM Changeset in webkit [120011] by commit-queue@webkit.org
  • 13 edits in trunk/LayoutTests

WebAudio tests need to set WebKitWebAudioEnabled.
​https://bugs.webkit.org/show_bug.cgi?id=88624

Patch by Dongwoo Im <​dw.im@samsung.com> on 2012-06-11
Reviewed by Chris Rogers.

  • webaudio/audiochannelmerger-basic.html: Set WebKitWebAudioEnabled by including 'audio-testing.js'.
  • webaudio/audionode-connect-order.html: ditto.
  • webaudio/biquadfilternode-basic.html: ditto.
  • webaudio/delaynode-maxdelay.html: ditto.
  • webaudio/delaynode-scheduling.html: ditto.
  • webaudio/delaynode.html: ditto.
  • webaudio/javascriptaudionode-downmix8-2channel-input.html: ditto.
  • webaudio/javascriptaudionode-upmix2-8channel-input.html: ditto.
  • webaudio/mediaelementaudiosourcenode-gc.html: ditto.
  • webaudio/mediaelementaudiosourcenode.html: ditto.
  • webaudio/realtimeanalyser-fft-sizing.html: ditto.
  • webaudio/stereo2mono-down-mixing.html: ditto.
3:04 PM Changeset in webkit [120010] by tonikitoo@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] [BlackBerry] browser video player fullscreen mode (portrait) does not play well with rotation
​https://bugs.webkit.org/show_bug.cgi?id=88809

Reviewed by Rob Buis.
Patch by Antonio Gomes <​agomes@rim.com>

Adjust the media container dimensions, whenever the FrameView::frameRect
(aka viewport rect) changes

Reviewed internally by Jacky Jiang.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::updateViewportSize):

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::fullScreenRendererChanged):

3:03 PM Changeset in webkit [120009] by tonikitoo@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

browser video player fullscreen mode (portrait) does not play well with viewport metatag - Controls are off screen so cannot exit fullscreen ​https://bugs.webkit.org/show_bug.cgi?id=88719 PR #164026

Reviewed by Rob Buis.
Patch by Antonio Gomes <​agomes@rim.com>

Instead of using WebPage's viewport size, which suffers from
dealing with transformed coordinates, viewport metatag changes,
etc, lets use WebCore::FrameView's visibleContentRect::Size::Width,
which abstract all these variations.

It fixes an overscale issue we were having when video player entered
fullscreen, and webpage had viewport metatag set.

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::fullScreenRendererChanged):

2:37 PM Changeset in webkit [120008] by shawnsingh@chromium.org
  • 8 edits in trunk/Source

[chromium] Implement position:fixed in compositor thread
​https://bugs.webkit.org/show_bug.cgi?id=70103

Reviewed by Adrienne Walker.

Source/WebCore:

Significant contributions to this patch by Alpha Lam and Sami Kyostila.

This patch is the compositor-side change that adds support for
fixed-position layers to be composited layers. Before this patch,
fixed-position elements were positioned only by WebCore (i.e. main
thread when painting), and the compositor did not have enough
knowledge on its own to position it properly. This patch adds the
necessary math and plumbs the necessary layer information so that
the impl thread can properly position fixed-position elements on
its own. This support is necessary for correctness of composited
fixed-position elements, which can greatly help to avoid
repainting container layers when scrolling with a fixed-position
layer.

There also needs to be WebCore-side support for this, which is
addressed in ​https://bugs.webkit.org/show_bug.cgi?id=78864

Unit tests added to CCLayerTreeHostCommonTest:

CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithDirectContainer
CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithTransformedDirectContainer
CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithDistantContainer
CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithDistantContainerAndTransforms
CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithMultipleScrollDeltas
CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithIntermediateSurfaceAndTransforms
CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithMultipleIntermediateSurfaces
CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithContainerLayerThatHasSurface
CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerThatIsAlsoFixedPositionContainer
CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerThatHasNoContainer

  • platform/graphics/chromium/LayerChromium.cpp:

(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::pushPropertiesTo):

  • platform/graphics/chromium/LayerChromium.h:

(WebCore::LayerChromium::setIsContainerForFixedPositionLayers):
(WebCore::LayerChromium::isContainerForFixedPositionLayers):
(LayerChromium):
(WebCore::LayerChromium::setFixedToContainerLayerVisibleRect):
(WebCore::LayerChromium::fixedToContainerLayerVisibleRect):

  • platform/graphics/chromium/cc/CCLayerImpl.cpp:

(WebCore::CCLayerImpl::CCLayerImpl):

  • platform/graphics/chromium/cc/CCLayerImpl.h:

(WebCore::CCLayerImpl::setIsContainerForFixedPositionLayers):
(WebCore::CCLayerImpl::isContainerForFixedPositionLayers):
(CCLayerImpl):
(WebCore::CCLayerImpl::setFixedToContainerLayerVisibleRect):
(WebCore::CCLayerImpl::fixedToContainerLayerVisibleRect):

  • platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:

(WebCore::computeScrollCompensationForThisLayer):
(WebCore):
(WebCore::computeScrollCompensationMatrixForChildren):
(WebCore::calculateDrawTransformsInternal):
(WebCore::CCLayerTreeHostCommon::calculateDrawTransforms):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostCommonTest.cpp:
2:17 PM Changeset in webkit [120007] by dpranke@chromium.org
  • 2 edits in trunk/Tools

nrwt exits early too frequently
​https://bugs.webkit.org/show_bug.cgi?id=73843

Reviewed by Ryosuke Niwa.

Change the defaults for new-run-webkit-tests for both
--exit-after-n-failures and --exit-after-n-crashes-or-timeouts
to zero (i.e., we will never exit early by default).

If people want their buildbots to exit early it is their
responsibility to update their buildbot configs appropriately.

Note that we have tests that ensure that these flags work for
non-zero numbers, but we don't have tests that either test the
default or ensure that zero means "run all of the tests". I
think that's okay but can add tests if others disagree.

Also note that it looks like no changes on the build.webkit.org
master.cfg are necessary; all of the bots seem to be using the
RunWebKitTests wrapper which is already setting the flags. There
is a NewRunWebKitTests wrapper, but that looks to be unused; I
will delete that in a separate patch.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

2:01 PM Changeset in webkit [120006] by jschuh@chromium.org
  • 1 edit
    2 copies in branches/chromium/1132

Merge 119733

BUG=127185
TBR=​raymes@webkit.org
Review URL: ​https://chromiumcodereview.appspot.com/10540108

1:52 PM Changeset in webkit [120005] by weinig@apple.com
  • 22 edits in trunk/Source

Remove support for disconnected/excluded from search frames, they are not used by Safari anymore
​https://bugs.webkit.org/show_bug.cgi?id=88723

Reviewed by Dan Bernstein.

Source/WebCore:

  • WebCore.exp.in:

Update export.

  • editing/Editor.cpp:

(WebCore::Editor::rangeOfString):
(WebCore::Editor::countMatchesForText):

  • editing/Editor.h:

(Editor):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::findFrameForNavigation):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::parent):
(WebCore::DOMWindow::top):

  • page/EventHandler.cpp:

(WebCore::EventHandler::hitTestResultAtPoint):

  • page/Frame.cpp:

(WebCore::Frame::Frame):

  • page/Frame.h:

(Frame):

  • page/FrameTree.cpp:

(WebCore::FrameTree::parent):
(WebCore::FrameTree::top):

  • page/FrameTree.h:

(FrameTree):

  • page/Location.cpp:

(WebCore::Location::ancestorOrigins):

  • xml/XMLTreeViewer.cpp:

(WebCore::XMLTreeViewer::hasNoStyleInformation):
Update for the removal of disconnected frames and text search exclusions concepts.

Source/WebKit/blackberry:

  • WebKitSupport/InPageSearchManager.cpp:

(BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):

Source/WebKit/chromium:

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::scopeStringMatches):

Source/WebKit/mac:

  • WebView/WebFrame.mm:
  • WebView/WebFramePrivate.h:

Remove -[WebFrame _setIsDisconnected:] and -[WebFrame _setExcludeFromTextSearch:]

Source/WebKit/win:

  • WebFrame.cpp:

(WebFrame::setIsDisconnected):
(WebFrame::setExcludeFromTextSearch):
Stop doing anything in these functions.

1:30 PM Changeset in webkit [120004] by ojan@chromium.org
  • 515 edits
    32 deletes in trunk/LayoutTests

Last large slew of Chromium windows png rebaselines. See ​http://crbug.com/131829 for more information.
List of rebaselined files excluded because it's too long.

1:22 PM Changeset in webkit [120003] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] WebInputEvent::isGestureEventType should return true for GestureTwoFingerTap
​https://bugs.webkit.org/show_bug.cgi?id=88789

Patch by Varun Jain <​varunjain@chromium.org> on 2012-06-11
Reviewed by Adam Barth.

  • public/WebInputEvent.h:

(WebKit::WebInputEvent::isGestureEventType):

1:16 PM Changeset in webkit [120002] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Crash when a plug-in tries to use the NPRuntime API with JavaScript disabled
​https://bugs.webkit.org/show_bug.cgi?id=88797
<rdar://problem/11574844>

Reviewed by Brady Eidson.

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::initialize):
Handle the windowNPObjectID being 0.

(WebKit::PluginControllerProxy::windowScriptNPObject):
Handle m_windownPObject being null.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::windowScriptNPObject):
Return null if JavaScript is disabled.

(WebKit::PluginView::pluginElementNPObject):
Ditto.

1:16 PM Changeset in webkit [120001] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[EFL] [DRT] Reset CacheModel before running each test
​https://bugs.webkit.org/show_bug.cgi?id=87534

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-06-11
Reviewed by Gustavo Noronha Silva.

Reset cache model to default before running each test to fix some
flaky tests on EFL build bots. Also fix case value in setCacheModel.

  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::setCacheModel):

1:15 PM Changeset in webkit [120000] by wangxianzhu@chromium.org
  • 15 edits
    2 adds in trunk

SVGImageCache leaks image data
​https://bugs.webkit.org/show_bug.cgi?id=87792

Source/WebCore:

There are two functions to remove a client from a CachedImage:

  • CachedResource::removeClient()
  • CachedImage::removeClientForRenderer().

It's easy to make error to call the former which will leak the cached
image buffers in SVGImageCache.

This change combined the two by adding the virtual
CachedResource::didRemoveClient(). CachedImage will do SVGImageCache
cleanup in the function.

Reviewed by Nikolas Zimmermann.

Test: svg/as-image/svg-image-leak-cached-data.html

  • loader/cache/CachedFont.h:

(WebCore::CachedFontClient::resourceClientType): Added 'const'.

  • loader/cache/CachedImage.cpp:

(WebCore):
(WebCore::CachedImage::didRemoveClient): Removes the client from SVGImageCache.
(WebCore::CachedImage::lookupOrCreateImageForRenderer):

  • loader/cache/CachedImage.h:

(CachedImage):
(WebCore::CachedImageClient::resourceClientType): Added 'const'.

  • loader/cache/CachedRawResource.h:

(WebCore::CachedRawResourceClient::resourceClientType): Added 'const'.

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::removeClient): Added invocation of didRemoveClient().

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::didRemoveClient): Added for subclasses to do additional works.

  • loader/cache/CachedResourceClient.h:

(WebCore::CachedResourceClient::resourceClientType): Added 'const'.

  • loader/cache/CachedSVGDocument.h:

(WebCore::CachedSVGDocumentClient::resourceClientType): Added 'const'.

  • loader/cache/CachedStyleSheetClient.h:

(WebCore::CachedStyleSheetClient::resourceClientType): Added 'const'.

  • rendering/style/StyleCachedImage.cpp:

(WebCore::StyleCachedImage::removeClient):

  • rendering/style/StyleCachedImageSet.cpp:

(WebCore::StyleCachedImageSet::removeClient):

  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::~SVGImageCache): Added checking for leaks.
(WebCore::SVGImageCache::removeClientFromCache):
(WebCore::SVGImageCache::setRequestedSizeAndScales):
(WebCore::SVGImageCache::requestedSizeAndScales):
(WebCore::SVGImageCache::lookupOrCreateBitmapImageForClient):

  • svg/graphics/SVGImageCache.h:

(WebCore):
(SVGImageCache):

LayoutTests:

Reviewed by Nikolas Zimmermann.

New test case.

  • svg/as-image/svg-image-leak-cached-data-expected.txt: Added.
  • svg/as-image/svg-image-leak-cached-data.html: Added.
12:50 PM Changeset in webkit [119999] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Memory leaks in DRT EventSender.cpp
​https://bugs.webkit.org/show_bug.cgi?id=88774

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-06-11
Reviewed by Martin Robinson.

Fix a few possible memory leaks in EventSender code.

  • DumpRenderTree/gtk/EventSender.cpp:

(contextClickCallback): Free the event returned by gdk_event_new().
(mouseDownCallback): Ditto.
(mouseUpCallback): Ditto.

12:45 PM Changeset in webkit [119998] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] REGRESSION (r119788): tests rely on pathToLocalResource are failing after r119788
​https://bugs.webkit.org/show_bug.cgi?id=88661

Patch by Sudarsana Nagineni <​sudarsana.nagineni@linux.intel.com> on 2012-06-11
Reviewed by Dirk Pranke.

Tools:

Pass string length explicitly when creating String object from
non-null-terminated UChar* returned by characters().

  • DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::pathToLocalResource):

LayoutTests:

Unskip test cases which rely on pathToLocalResource().

  • platform/efl/TestExpectations:
11:54 AM Changeset in webkit [119997] by pilgrim@chromium.org
  • 5 edits in trunk/Source

[Chromium] Call shared timer functions directly
​https://bugs.webkit.org/show_bug.cgi?id=88781

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

  • platform/chromium/SharedTimerChromium.cpp:

(WebCore::setSharedTimerFiredFunction):
(WebCore::setSharedTimerFireInterval):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore):

11:48 AM Changeset in webkit [119996] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Relative pos. input fields in columns vanish when you start typing in them
​https://bugs.webkit.org/show_bug.cgi?id=76834

Patch by Pravin D <​pravind.2k4@gmail.com> on 2012-06-11
Reviewed by Julien Chaffraix.

Source/WebCore:

Test: fast/multicol/multicol-with-child-renderLayer-for-input.html

  • page/FrameView.cpp:

(WebCore::updateLayerPositionFlags):
Helper function to prepare the UpdateLayerPositionsFlags based on the input parameters.
If didFullRepaint flag is set, then CheckForRepaints flag is removed from the default flags.
Also during a relayout of a subtree, if the RenderLayer of the subtree root is paginated then updatePagination flag is
included in the flags.

(WebCore):
(WebCore::FrameView::layout):
Now uses the helper function updateLayerPositionFlags() to get the final set of UpdateLayerPositionsFlags.

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::isPaginated):
(RenderLayer):
isPaginated function is made public so that FrameView class can use it prepare UpdateLayerPositionsFlags.

LayoutTests:

  • fast/multicol/multicol-with-child-renderLayer-for-input-expected.html: Added.
  • fast/multicol/multicol-with-child-renderLayer-for-input.html: Added.
11:37 AM Changeset in webkit [119995] by fischman@chromium.org
  • 15 edits
    3 copies in branches/chromium/1132

Merge 119742 - Plumb CORS attribute information from HTMLMediaElement to media players so it can be used
​https://bugs.webkit.org/show_bug.cgi?id=88349

Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/video-cross-origin-readback.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerCORSMode):
(WebCore):

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

  • html/canvas/CanvasRenderingContext.cpp:

(WebCore::CanvasRenderingContext::wouldTaintOrigin):

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::didPassCORSAccessCheck):
(WebCore):

  • platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerCORSMode):
(MediaPlayer):

  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::didPassCORSAccessCheck):
(MediaPlayerPrivateInterface):

Source/WebKit/chromium:

  • public/WebMediaPlayer.h:

(WebMediaPlayer):

  • src/AssertMatchingEnums.cpp:
  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::loadInternal):
(WebKit::WebMediaPlayerClientImpl::didPassCORSAccessCheck):
(WebKit):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

LayoutTests:

  • http/tests/security/resources/video-cross-origin-allow.php: Added.
  • http/tests/security/video-cross-origin-readback-expected.txt: Added.
  • http/tests/security/video-cross-origin-readback.html: Added.
  • platform/efl/Skipped:
  • platform/gtk/TestExpectations:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
  • platform/wk2/Skipped:

TBR=​fischman@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/10536097

11:36 AM Changeset in webkit [119994] by pilgrim@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Remove some dead code in PasteboardChromium
​https://bugs.webkit.org/show_bug.cgi?id=88782

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.
Leftover detritus from bug 88038.

  • platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::documentFragment):

11:35 AM Changeset in webkit [119993] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Removing long WebDeviceOrientation constructor
​https://bugs.webkit.org/show_bug.cgi?id=88779

Patch by Amy Ousterhout <​aousterh@chromium.org> on 2012-06-11
Reviewed by Adam Barth.

Removing the WebDeviceOrientation constructor with nine parameters.
Chromium has been changed to use the default constructor and setter
functions instead (see ​https://chromiumcodereview.appspot.com/10542025/).

  • public/WebDeviceOrientation.h:
11:29 AM Changeset in webkit [119992] by rniwa@webkit.org
  • 273 edits in trunk/LayoutTests

Use testRunner instead of layoutTestController in compositing tests
​https://bugs.webkit.org/show_bug.cgi?id=88766

Reviewed by Tony Chang.

  • compositing/:
  • compositing/animation/:
  • compositing/backface-visibility/:
  • compositing/backing/:
  • compositing/culling/:
  • compositing/geometry/:
  • compositing/iframes/:
  • compositing/iframes/resources/:
  • compositing/images/:
  • compositing/layer-creation/:
  • compositing/masks/:
  • compositing/overflow/:
  • compositing/plugins/:
  • compositing/reflections/:
  • compositing/repaint/:
  • compositing/resources/:
  • compositing/rtl/:
  • compositing/scaling/:
  • compositing/tiling/:
  • compositing/transitions/:
  • compositing/video/:
  • compositing/visibility/:
  • compositing/webgl/:
  • platform/chromium/compositing/:
  • platform/chromium/compositing/force-compositing-mode/:
  • platform/chromium/compositing/rubberbanding/:
  • platform/mac/compositing/canvas/:
11:26 AM Changeset in webkit [119991] by ojan@chromium.org
  • 539 edits
    9 adds
    24 deletes in trunk/LayoutTests

Large slew of Chromium windows png rebaselines. See ​http://crbug.com/131829 for more information.

List of rebaselined files excluded because it's too long.

11:23 AM Changeset in webkit [119990] by rniwa@webkit.org
  • 153 edits in trunk/LayoutTests

Use testRunner instead of layoutTestController in css 1, css 2.1, and css3 tests
​https://bugs.webkit.org/show_bug.cgi?id=88769

Reviewed by Tony Chang.

  • css1/units/zero-duration-without-units.html:
  • css3/calc/:
  • css3/filters/:
  • css3/filters/custom/:
  • css3/filters/resources/:
  • css3/filters/script-tests/:
  • css3/flexbox/:
  • css3/font-feature-settings-rendering.html:
  • css3/images/cross-fade-invalidation.html:
  • css3/images/optimize-contrast-canvas.html:
  • css3/images/optimize-contrast-image.html:
  • css3/khtml-background-size-0x0-bmp.html:
  • css3/parsing-css3-nthchild.html:
  • css3/style-zoomed-image.html:
  • css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-getStyle.html:
  • css3/zoom-coords.xhtml:
  • platform/win/css2.1/resources/run-webkit-tests-epilogue.html:
  • platform/win/css2.1/resources/run-webkit-tests-prologue.html:
11:21 AM Changeset in webkit [119989] by fischman@chromium.org
  • 1 edit in branches/chromium/1132/Source/WebKit/chromium/public/WebMediaPlayer.h

Merge 119569 - [chromium] Add a WebKit::WebMediaPlayer::CORSMode enum in preparation for 88349
​https://bugs.webkit.org/show_bug.cgi?id=88388

Reviewed by Darin Fisher.

  • public/WebMediaPlayer.h:

TBR=​fischman@chromium.org
Review URL: ​https://chromiumcodereview.appspot.com/10533083

11:14 AM Changeset in webkit [119988] by commit-queue@webkit.org
  • 11 edits in trunk

[chromium] Provide access to the WebPlugin created by the helper plugin widget
​https://bugs.webkit.org/show_bug.cgi?id=88028

Patch by David Dorwin <​ddorwin@chromium.org> on 2012-06-11
Reviewed by Adam Barth.

Source/WebKit/chromium:

A WebPlugin is created when the document created by createHelperPlugin() is laid out.
Expose it so the embedder can interact with the plugin instance.

  • public/WebHelperPlugin.h:

(WebKit):
(WebHelperPlugin):

  • public/WebMediaPlayerClient.h:

(WebKit):

  • public/WebPlugin.h:

(WebKit::WebPlugin::isPlaceholder):
(WebPlugin):

  • src/WebHelperPluginImpl.cpp:

(WebKit::WebHelperPluginImpl::WebHelperPluginImpl):
(WebKit):
(WebKit::WebHelperPluginImpl::getPlugin):
(WebKit::WebHelperPluginImpl::initPage):
(WebKit::WebHelperPluginImpl::close):

  • src/WebHelperPluginImpl.h:

(WebKit):
(WebHelperPluginImpl):

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::createHelperPlugin):

  • src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

  • src/WebPagePopupImpl.cpp:

Tools:

Added isPlaceholder() to WebPlugin.

  • DumpRenderTree/chromium/TestWebPlugin.h:

(TestWebPlugin::isPlaceholder):

11:13 AM Changeset in webkit [119987] by peter@chromium.org
  • 5 edits in trunk/Source/WebCore

[Chromium] Theme updates for Android in menu list rendering and selection backgrounds
​https://bugs.webkit.org/show_bug.cgi?id=88775

Reviewed by Adam Barth.

For Chrome on Android, use the width of the scrollbar down arrow instead
of the scrollbar's width for determining the arrow padding to apply for
menu list rendering, as WebKit isn't drawing a scrollbar (thus width=0).

Furthermore, change the default active selection background color to be
equal to the tap highlighting color.

These changes should be covered by existing layout tests.

  • rendering/RenderThemeChromiumAndroid.cpp:

(WebCore::RenderThemeChromiumAndroid::menuListArrowPadding):
(WebCore): Retrieve the scrollbar down arrow's size via PlatformSupport.

  • rendering/RenderThemeChromiumAndroid.h: Override the menuListArrowPadding

and platformActiveSelectionBackgroundColor methods, and add a static
static RGBA32 color for the default active selection bg color.

  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::menuListArrowPadding): Default to

the scrollbar thickness, not changing behavior for non-Android.

(WebCore::RenderThemeChromiumSkia::menuListInternalPadding): Instead

of polling the scrollbar thickness, call menuListArrowPadding().

  • rendering/RenderThemeChromiumSkia.h:

(RenderThemeChromiumSkia): Add the menuListArrowPadding() as a protected method.

10:39 AM Changeset in webkit [119986] by tony@chromium.org
  • 3 edits in trunk/Tools

rebaseline from garden-o-matic leaves N processes each time it is run
​https://bugs.webkit.org/show_bug.cgi?id=88586

Reviewed by Dirk Pranke.

This appears to only be a problem on python 2.7. Maybe a bug causing
pools to not be garbage collected?

  • Scripts/webkitpy/common/system/executive.py:

(Executive.run_in_parallel): close() and join() the process pool.

  • Scripts/webkitpy/common/system/executive_unittest.py:

(ExecutiveTest.test_run_in_parallel):

10:22 AM Changeset in webkit [119985] by rniwa@webkit.org
  • 53 edits in trunk/LayoutTests

Use testRunner instead of layoutTestController in animations tests
​https://bugs.webkit.org/show_bug.cgi?id=88757

Reviewed by Tony Chang.

  • animations/3d/change-transform-in-end-event.html:
  • animations/3d/replace-filling-transform.html:
  • animations/3d/state-at-end-event-transform.html:
  • animations/3d/transform-origin-vs-functions.html:
  • animations/animation-add-events-in-handler.html:
  • animations/animation-border-overflow.html:
  • animations/animation-controller-drt-api.html:
  • animations/animation-direction-reverse-fill-mode-hardware.html:
  • animations/animation-direction-reverse-fill-mode.html:
  • animations/animation-drt-api-multiple-keyframes.html:
  • animations/animation-drt-api.html:
  • animations/animation-end-event-destroy-renderer.html:
  • animations/animation-end-event-short-iterations.html:
  • animations/animation-hit-test-transform.html:
  • animations/animation-hit-test.html:
  • animations/animation-iteration-event-destroy-renderer.html:
  • animations/animation-matrix-negative-scale-unmatrix.html:
  • animations/animation-on-inline-crash.html:
  • animations/animation-shorthand-overriding.html:
  • animations/animation-shorthand-removed.html:
  • animations/animation-shorthand.html:
  • animations/animation-start-event-destroy-renderer.html:
  • animations/animation-welcome-safari.html:
  • animations/body-removal-crash.html:
  • animations/change-keyframes-name.html:
  • animations/change-transform-style-during-animation.html:
  • animations/combo-transform-translate+scale.html:
  • animations/empty-keyframes.html:
  • animations/fill-mode-forwards.html:
  • animations/fill-mode-iteration-count-non-integer.html:
  • animations/fill-mode-missing-from-to-keyframes.html:
  • animations/fill-mode-multiple-keyframes.html:
  • animations/fill-mode-removed.html:
  • animations/fill-mode-reverse.html:
  • animations/fill-mode-transform.html:
  • animations/fill-mode.html:
  • animations/fill-unset-properties.html:
  • animations/font-size-using-ems.html-disabled:
  • animations/import-crash.html:
  • animations/keyframe-timing-functions-transform.html:
  • animations/keyframe-timing-functions2.html:
  • animations/keyframes-iteration-count-non-integer.html:
  • animations/longhand-timing-function.html:
  • animations/missing-from-to-transforms.html:
  • animations/missing-from-to.html:
  • animations/pause-crash.html:
  • animations/resources/animation-test-helpers.js:

(checkExpectedValue):
(endTest):

  • animations/state-at-end-event.html:
  • animations/suspend-resume-animation-events.html:
  • animations/suspend-transform-animation.html:
  • animations/transition-and-animation-3.html:
  • animations/unanimated-style.html:
10:19 AM Changeset in webkit [119984] by commit-queue@webkit.org
  • 22 edits
    3 adds in trunk

Add css3-images image-resolution (dppx only)
​https://bugs.webkit.org/show_bug.cgi?id=85332

Patch by David Barr <​davidbarr@chromium.org> on 2012-06-11
Reviewed by Tony Chang.

The css3-images module is at candidate recommendation.
​http://www.w3.org/TR/2012/CR-css3-images-20120417/#image-resolution

Source/WebCore:

Test: fast/css/image-resolution.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSGrammar.y:
  • css/CSSParser.cpp:

(WebCore::CSSParser::validUnit):
(WebCore::CSSParser::createPrimitiveNumericValue):
(WebCore::unitFromString):
(WebCore::CSSParser::parseValidPrimitive):
(WebCore::CSSParser::parseValue):
(WebCore):
(WebCore::CSSParser::parseImageResolution):
(WebCore::CSSParser::detectNumberToken):

  • css/CSSParser.h:
  • css/CSSPrimitiveValue.cpp:

(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::unitCategory):
(WebCore::CSSPrimitiveValue::canonicalUnitTypeForCategory):
(WebCore::CSSPrimitiveValue::customCssText):
(WebCore::CSSPrimitiveValue::cloneForCSSOM):

  • css/CSSPrimitiveValue.h:
  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/StyleBuilder.cpp:

(WebCore):
(ApplyPropertyImageResolution):
(WebCore::ApplyPropertyImageResolution::applyInheritValue):
(WebCore::ApplyPropertyImageResolution::applyInitialValue):
(WebCore::ApplyPropertyImageResolution::applyValue):
(WebCore::ApplyPropertyImageResolution::createHandler):
(WebCore::StyleBuilder::StyleBuilder):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::styleDidChange):
(WebCore::RenderImage::imageDimensionsChanged):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:

(StyleRareInheritedData):

LayoutTests:

  • fast/css/image-resolution/image-resolution-expected.txt: Added.
  • fast/css/image-resolution/image-resolution.html: Added.
  • platform/chromium/TestExpectations: Skip tests until image-resolution implementation lands.
  • platform/efl/TestExpectations: Skip tests until image-resolution implementation lands.
  • platform/gtk/TestExpectations: Skip tests until image-resolution implementation lands.
  • platform/mac/TestExpectations: Skip tests until image-resolution implementation lands.
  • platform/qt/TestExpectations: Skip tests until image-resolution implementation lands.
9:57 AM Changeset in webkit [119983] by tonikitoo@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

Make media (<video> and <audio>) slide draggable again ​https://bugs.webkit.org/show_bug.cgi?id=88742 PR #158199

Reviewed by George Staikos.
Patch by Antonio Gomes <​agomes@rim.com>

First check if the element is a range type then gets its
shadow DOM ancestor.

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::shouldConvertTouchToMouse):

9:49 AM Changeset in webkit [119982] by danakj@chromium.org
  • 4 edits in trunk/Source

[chromium] Free texture from CCIOSurfaceLayerImpl when it is destroyed
​https://bugs.webkit.org/show_bug.cgi?id=88371

Reviewed by James Robinson.

Source/WebCore:

Unit test: CCLayerTreeHostImplTest.layersFreeTextures

  • platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:

(WebCore::CCIOSurfaceLayerImpl::~CCIOSurfaceLayerImpl):
(WebCore::CCIOSurfaceLayerImpl::willDraw):

Source/WebKit/chromium:

  • tests/CCLayerTreeHostImplTest.cpp:
8:31 AM Changeset in webkit [119981] by Carlos Garcia Campos
  • 9 edits in trunk

Unreviewed. Fix make distcheck issues.

.:

  • GNUmakefile.am: Initialize jscore nosource variables.

Source/JavaScriptCore:

  • GNUmakefile.list.am: Remove non existent header file.

Source/WebCore:

  • GNUmakefile.am: Add idl files in editing dir to EXTRA_DIST.
  • GNUmakefile.list.am: Add missing header file.

Source/WTF:

  • GNUmakefile.list.am: Add missing header file.
7:59 AM Changeset in webkit [119980] by dominicc@chromium.org
  • 21 edits
    5 adds
    1 delete in trunk/LayoutTests

[Chromium] Unreviewed: Rebaseline more SVG tests on Windows.

  • platform/chromium-linux-x86/svg/batik/filters/filterRegions-expected.png: Removed.
  • platform/chromium-win-vista/svg/batik/paints/gradientLimit-expected.png: Added.
  • platform/chromium-win-xp/svg/batik/paints/patternPreserveAspectRatioA-expected.png: Added.
  • platform/chromium-win-xp/svg/batik/text/smallFonts-expected.png: Added.
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/interact-order-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/interact-order-02-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/linking-a-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/linking-a-02-b-expected.png:
  • platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-2-expected.png:
  • platform/chromium-win/svg/as-image/same-image-two-instances-expected.png:
  • platform/chromium-win/svg/as-image/svg-as-relative-image-expected.png:
  • platform/chromium-win/svg/as-image/svg-image-change-content-size-expected.png:
  • platform/chromium-win/svg/batik/filters/feTile-expected.png:
  • platform/chromium-win/svg/batik/filters/filterRegions-expected.png:
7:37 AM Changeset in webkit [119979] by dominicc@chromium.org
  • 7 edits
    1 delete in trunk/LayoutTests

[Chromium] Unreviewed: Rebaselines for svg/as-background-image tests on Windows.

  • platform/chromium-linux/svg/as-background-image/svg-as-background-2-expected.png: Removed.
  • platform/chromium-win/svg/as-background-image/svg-as-background-2-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-as-background-4-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-as-background-5-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-as-background-with-relative-size-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-background-partial-redraw-expected.png:
  • platform/chromium-win/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png:
7:33 AM Changeset in webkit [119978] by mitz@apple.com
  • 5 edits
    2 deletes in trunk

Reverted r119940 because it caused multiple media tests to fail on Lion.

Source/WebCore:

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore):
(WebCore::HTMLMediaElement::userCancelledLoad):

  • html/HTMLMediaElement.h:

(HTMLMediaElement):

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes):

LayoutTests:

  • http/tests/media/video-src-invalid-error-expected.txt: Removed.
  • http/tests/media/video-src-invalid-error.html: Removed.
7:05 AM Changeset in webkit [119977] by zoltan@webkit.org
  • 6 edits
    3 adds in trunk

Source/WebCore: [Qt] Add config tests for WEBP imagedecoder library, modify HAVE(decoderlibrary) to USE(...)$
​https://bugs.webkit.org/show_bug.cgi?id=87841

Reviewed by Simon Hausmann.

No new tests were needed.

  • Target.pri:
  • WebCore.pri:
  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageDecoder::create):

Tools: [Qt] Add config tests for WEBP imagedecoder library, modify HAVE(decoderlibrary) to USE(...)
​https://bugs.webkit.org/show_bug.cgi?id=87841

Reviewed by Simon Hausmann.

  • qmake/config.tests/libwebp/libwebp.cpp: Added.

(main):

  • qmake/config.tests/libwebp/libwebp.pro: Added.
  • qmake/sync.profile:
7:02 AM Changeset in webkit [119976] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Gardening after r119962. Four inspector/debugger tests still fail after they have been re-enabled.
​https://bugs.webkit.org/show_bug.cgi?id=43332

Patch by János Badics <János Badics> on 2012-06-11
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
6:53 AM Changeset in webkit [119975] by kenneth@webkit.org
  • 8 edits in trunk/Source

Add QML api for setting device width and height
​https://bugs.webkit.org/show_bug.cgi?id=88777

Reviewed by Simon Hausmann.

Source/WebCore:

Change the default values for deviceWidth/Height to be 0 (unset). The
original values were introduced by Qt and 0 makes it possible to
detect if a value has never been set and therefore fall back.

Only Qt depended on the former values.

  • page/Settings.cpp:

(WebCore::Settings::Settings):

Source/WebKit2:

Add the new API and set the default values to 0 (unset). The
current values were introduced by Qt and only Qt depends on them.

  • Shared/WebPreferencesStore.h:

(WebKit):

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewExperimental::deviceWidth):
(QQuickWebViewExperimental::setDeviceWidth):
(QQuickWebViewExperimental::deviceHeight):
(QQuickWebViewExperimental::setDeviceHeight):

  • UIProcess/API/qt/qquickwebview_p.h:
  • UIProcess/qt/QtViewportHandler.cpp:

(WebKit::QtViewportHandler::viewportItemSizeChanged):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::sendViewportAttributesChanged):

6:20 AM Changeset in webkit [119974] by tkent@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Should call frameDetached() in WebPagePopupImpl::close()
​https://bugs.webkit.org/show_bug.cgi?id=88754

Reviewed by Adam Barth.

  • src/WebPagePopupImpl.cpp:

(WebKit::WebPagePopupImpl::close): Calls FrameLoader::frameDetached().

5:49 AM Changeset in webkit [119973] by dominicc@chromium.org
  • 19 edits in trunk/LayoutTests

[Chromium] Unreviewed: Rebaselines and updated expectations for media tests

Pixel differences are due to antialiasing and different rounded
corners on the media progress bar. The difference is not
noticeable.

  • platform/chromium-win/media/audio-controls-rendering-expected.png:
  • platform/chromium-win/media/audio-repaint-expected.png:
  • platform/chromium-win/media/controls-after-reload-expected.png:
  • platform/chromium-win/media/controls-layout-direction-expected.png:
  • platform/chromium-win/media/controls-strict-expected.png:
  • platform/chromium-win/media/controls-styling-expected.png:
  • platform/chromium-win/media/controls-without-preload-expected.png:
  • platform/chromium-win/media/media-controls-clone-expected.png:
  • platform/chromium-win/media/media-document-audio-repaint-expected.png:
  • platform/chromium-win/media/video-controls-rendering-expected.png:
  • platform/chromium-win/media/video-display-toggle-expected.png:
  • platform/chromium-win/media/video-layer-crash-expected.png:
  • platform/chromium-win/media/video-no-audio-expected.png:
  • platform/chromium-win/media/video-playing-and-pause-expected.png:
  • platform/chromium-win/media/video-transformed-expected.png:
  • platform/chromium-win/media/video-volume-slider-expected.png:
  • platform/chromium-win/media/video-zoom-controls-expected.png:
  • platform/chromium/TestExpectations:
5:19 AM Changeset in webkit [119972] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed: Mark track-cue-rendering-inner-timestamps.html failing on Vista

  • platform/chromium/TestExpectations:
4:27 AM Changeset in webkit [119971] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Skipping http/tests/security/mixedContent/filesystem-url-in-iframe.html
​https://bugs.webkit.org/show_bug.cgi?id=88770

ENABLE(FILE_SYSTEM) is disabled; this test should be skipped until
that feature is enabled. Moving it up into the proper section of the
Skipped file to make sure it's enabled if and when the feature makes
it into the port.

Patch by Mike West <​mkwst@chromium.org> on 2012-06-11
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
3:29 AM Changeset in webkit [119970] by Csaba Osztrogonác
  • 6 edits in trunk/Source/WebKit/qt

[Qt][Win] Add missing includes to fix the build
​https://bugs.webkit.org/show_bug.cgi?id=88538

Reviewed by Simon Hausmann.

  • Api/qwebframe.cpp:
  • WebCoreSupport/ChromeClientQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/GeolocationClientQt.cpp:
  • WebCoreSupport/IconDatabaseClientQt.cpp:
3:24 AM Changeset in webkit [119969] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

[Qt][Win] Fix UString related build problem in Source/WebCore/bridge/qt/qt_instance.cpp
​https://bugs.webkit.org/show_bug.cgi?id=88310

Reviewed by Simon Hausmann.

  • bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtInstance::getPropertyNames):

2:49 AM Changeset in webkit [119968] by Simon Hausmann
  • 2 edits in trunk/Source/WebCore

[Qt][WK2] Compute and set cache capacities using the current CacheModel
​https://bugs.webkit.org/show_bug.cgi?id=73918

Unreviewed build fix.

No new tests added as this is a build fix.

Patch by Michael Brüning <​michael.bruning@nokia.com> on 2012-06-11

  • platform/qt/FileSystemQt.cpp:
2:38 AM Changeset in webkit [119967] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Rect-based hittesting doesn't work in tables.
​https://bugs.webkit.org/show_bug.cgi?id=86605

Patch by Allan Sandfeld Jensen <​allan.jensen@nokia.com> on 2012-06-11
Reviewed by Julien Chaffraix.

Source/WebCore:

The existing code only performed a single binary lookup for the central
hit-test point. This meant area-based hit-testing did not work across
table-cell borders. All cells spanned by a hit-test area must be hit
tested.

This patch introduces three auxilary functions to help calculate rows
and columns spanned by an rect. These are intended to also be used by
repaint logic in a later patch.

For point-based hit-testing we maintain unchanged behavior and still
only hit test a single column in a single row.

Test: fast/dom/nodesFromRect-table.html

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::logicalRectForWritingModeAndDirection):
(WebCore::RenderTableSection::spannedRows):
(WebCore::RenderTableSection::spannedColumns):
(WebCore::RenderTableSection::nodeAtPoint):

  • rendering/RenderTableSection.h:

(RenderTableSection):

LayoutTests:

Test nodesFromRect on tables.

  • fast/dom/nodesFromRect-table-expected.txt: Added.
  • fast/dom/nodesFromRect-table.html: Added.
2:26 AM Changeset in webkit [119966] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Adding a flag to show fullscreen media controls in chromium
​https://bugs.webkit.org/show_bug.cgi?id=88266

Patch by Min Qin <​qinmin@google.com> on 2012-06-11
Reviewed by Adam Barth.

Source/WebCore:

The default chromium shadow DOM for media element does not contain fullscreen button.
This change adds a flag to display the fullscreen button.
It will be used by the android port.

No new tests needed. We will use the same layout tests as desktop chromium.
However, new test result expections will be added later.

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
(WebCore::MediaControlRootElementChromium::create):
(WebCore::MediaControlRootElementChromium::setMediaController):
(WebCore::MediaControlRootElementChromium::reset):
(WebCore::MediaControlRootElementChromium::reportedError):

  • html/shadow/MediaControlRootElementChromium.h:

(MediaControlRootElementChromium):

Source/WebKit/chromium:

Adding a flag to the gyp file so that we can enable fullscreen media control

  • features.gypi:
2:17 AM Changeset in webkit [119965] by commit-queue@webkit.org
  • 8 edits in trunk/Source

[Qt][WK2] Compute and set cache capacities using the current CacheModel
​https://bugs.webkit.org/show_bug.cgi?id=73918

Patch by Michael Brüning <​michael.bruning@nokia.com> on 2012-06-11
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

No new tests needed / applicable (using operating system functionality).

Added method to read free file system space for a path to support cache model
implementation in Qt WK 2.

  • platform/FileSystem.h:

(WebCore):

  • platform/qt/FileSystemQt.cpp:

(WebCore::getVolumeFreeSizeForPath): Added for Qt ports.
(WebCore):

Source/WebKit2:

Added implementation of cache model for Qt WK 2 port including supporting
functionality such as WebProcess creation parameters and default values
for disk cache directories.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

(WebProcessCreationParameters):

  • UIProcess/qt/WebContextQt.cpp:

(WebKit::defaultDiskCacheDirectory):
(WebKit):
(WebKit::WebContext::platformInitializeWebProcess):

  • WebProcess/qt/WebProcessQt.cpp:

(WebKit::physicalMemorySizeInBytes):
(WebKit::WebProcess::platformSetCacheModel):
(WebKit::WebProcess::platformInitializeWebProcess):

2:00 AM Changeset in webkit [119964] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Gardening, skip new failing tests.

Patch by Szilard Ledan <Szilárd LEDÁN> on 2012-06-11
Reviewed by Csaba Osztrogonác.

  • platform/qt/Skipped:
1:26 AM Changeset in webkit [119963] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] skip http/tests/cookies/js-get-and-set-http-only-cookie.html test case
​https://bugs.webkit.org/show_bug.cgi?id=88751

Unreviewed EFL gardening. Skip newly introduced test case that is failing
on most ports.

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-11

  • platform/efl/TestExpectations:
1:24 AM Changeset in webkit [119962] by commit-queue@webkit.org
  • 4 edits in trunk

[JSC] Web Inspector: implement breaking from native callback
​https://bugs.webkit.org/show_bug.cgi?id=43332

Patch by Peter Wang <​peter.wang@torchmobile.com.cn> on 2012-06-11
Reviewed by Pavel Feldman.

These test cases were enabled:
LayoutTests/inspector/debugger/dom-breakpoints.html
LayoutTests/inspector/debugger/event-listener-breakpoints.html
LayoutTests/inspector/debugger/step-through-event-listeners.html
LayoutTests/inspector/debugger/xhr-breakpoints.html

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::breakProgram):

  • bindings/js/ScriptDebugServer.h:

(WebCore::supportsNativeBreakpoints):

1:23 AM Changeset in webkit [119961] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed: Remove expectations for passing tests

The flakiness dashboard indicates that
platform/chromium/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.cylinder.html
and
platform/chromium/virtual/gpu/fast/canvas/canvas-currentColor.html
are passing on all platforms now.

  • platform/chromium/TestExpectations:
1:17 AM Changeset in webkit [119960] by morrita@google.com
  • 2 edits in trunk/Source/WebCore

Spellchecker crash in async scenario.
​https://bugs.webkit.org/show_bug.cgi?id=88617

Reviewed by Tony Chang.

SpellCheckRequest::invokeRequest() can be reached after the frame is detached.
SpellCheckRequest should ignore such a request since TextCheckerClient is not available
for detached Frames.

No new tests. It's hard to reproduce this.

  • editing/SpellChecker.cpp:

(WebCore::SpellChecker::invokeRequest):

1:11 AM Changeset in webkit [119959] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unskip http/tests/security/mixedContent/blob-url-in-iframe.html
​https://bugs.webkit.org/show_bug.cgi?id=88752

Unreviewed EFL gardening. Unskip http/tests/security/mixedContent/blob-url-in-iframe.html
now that it no longer depends on the legacy blob builder (r119944).

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-11

  • platform/efl/TestExpectations:
12:41 AM Changeset in webkit [119958] by ryuan.choi@samsung.com
  • 4 edits in trunk/Source/WebCore

[EFL] Extract CursorMap from WidgetEfl.cpp.
​https://bugs.webkit.org/show_bug.cgi?id=88633

Reviewed by Ryosuke Niwa.

In order to share CursorMap in WebKit/efl and UIProcess of WebKit2/Efl,
extract it and expose getEcoreCursor.

No new tests, refactoring only.

  • platform/efl/EflScreenUtilities.cpp:

(WebCore):
(CursorMap):
(WebCore::CursorMap::cursor):
(WebCore::CursorMap::CursorMap):
(WebCore::getEcoreCursor):

  • platform/efl/EflScreenUtilities.h:

(WebCore):

  • platform/efl/WidgetEfl.cpp:

(WebCore::Widget::applyFallbackCursor):

12:14 AM QtWebKitForQt5 edited by Simon Hausmann
(diff)

Jun 10, 2012:

11:58 PM Changeset in webkit [119957] by commit-queue@webkit.org
  • 18 edits in trunk/Source

Unreviewed, rolling out r119955.
​http://trac.webkit.org/changeset/119955
​https://bugs.webkit.org/show_bug.cgi?id=88758

Breaks Chromium compile - Chromium depends on removed API
(Requested by dominicc on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2012-06-10

Source/WebCore:

  • WebCore.exp.in:
  • editing/Editor.cpp:

(WebCore::Editor::insideVisibleArea):
(WebCore):
(WebCore::Editor::firstVisibleRange):
(WebCore::Editor::lastVisibleRange):
(WebCore::Editor::nextVisibleRange):
(WebCore::Editor::rangeOfString):
(WebCore::Editor::countMatchesForText):

  • editing/Editor.h:

(Editor):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::findFrameForNavigation):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::parent):
(WebCore::DOMWindow::top):

  • page/EventHandler.cpp:

(WebCore::EventHandler::hitTestResultAtPoint):

  • page/Frame.cpp:

(WebCore::Frame::Frame):

  • page/Frame.h:

(Frame):
(WebCore::Frame::isDisconnected):
(WebCore):
(WebCore::Frame::setIsDisconnected):
(WebCore::Frame::excludeFromTextSearch):
(WebCore::Frame::setExcludeFromTextSearch):

  • page/FrameTree.cpp:

(WebCore::FrameTree::parent):
(WebCore::FrameTree::top):

  • page/FrameTree.h:

(FrameTree):

  • page/Location.cpp:

(WebCore::Location::ancestorOrigins):

  • xml/XMLTreeViewer.cpp:

(WebCore::XMLTreeViewer::hasNoStyleInformation):

Source/WebKit/mac:

  • WebView/WebFrame.mm:

(-[WebFrame _setIsDisconnected:]):
(-[WebFrame _setExcludeFromTextSearch:]):

  • WebView/WebFramePrivate.h:

Source/WebKit/win:

  • WebFrame.cpp:

(WebFrame::setIsDisconnected):
(WebFrame::setExcludeFromTextSearch):

11:23 PM Changeset in webkit [119956] by kinuko@chromium.org
  • 7 edits in trunk

Using BlobBuilder should show a deprecation warning message (if it is enabled)
​https://bugs.webkit.org/show_bug.cgi?id=88644

Reviewed by Jian Li.

Source/WebCore:

Mac has already disabled BlobBuilder, but Chromium still has it.
We should start showing a warning to let people migrate to using Blob constructor.

Tests: fast/files/blob-builder-crash.html

  • fileapi/WebKitBlobBuilder.cpp:

(WebCore):
(WebCore::WebKitBlobBuilder::create):

  • fileapi/WebKitBlobBuilder.h:

(WebCore):
(WebKitBlobBuilder):

  • fileapi/WebKitBlobBuilder.idl:

LayoutTests:

  • fast/files/blob-builder-crash-expected.txt:
11:11 PM Changeset in webkit [119955] by weinig@apple.com
  • 18 edits in trunk/Source

Remove support for disconnected/excluded from search frames, they are not used by Safari anymore
​https://bugs.webkit.org/show_bug.cgi?id=88723

Reviewed by Dan Bernstein.

Source/WebCore:

  • WebCore.exp.in:

Update export.

  • editing/Editor.cpp:

(WebCore::Editor::rangeOfString):
(WebCore::Editor::countMatchesForText):

  • editing/Editor.h:

(Editor):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::findFrameForNavigation):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::parent):
(WebCore::DOMWindow::top):

  • page/EventHandler.cpp:

(WebCore::EventHandler::hitTestResultAtPoint):

  • page/Frame.cpp:

(WebCore::Frame::Frame):

  • page/Frame.h:

(Frame):

  • page/FrameTree.cpp:

(WebCore::FrameTree::parent):
(WebCore::FrameTree::top):

  • page/FrameTree.h:

(FrameTree):

  • page/Location.cpp:

(WebCore::Location::ancestorOrigins):

  • xml/XMLTreeViewer.cpp:

(WebCore::XMLTreeViewer::hasNoStyleInformation):
Update for the removal of disconnected frames and text search exclusions concepts.

Source/WebKit/mac:

  • WebView/WebFrame.mm:
  • WebView/WebFramePrivate.h:

Remove -[WebFrame _setIsDisconnected:] and -[WebFrame _setExcludeFromTextSearch:]

Source/WebKit/win:

  • WebFrame.cpp:

(WebFrame::setIsDisconnected):
(WebFrame::setExcludeFromTextSearch):
Stop doing anything in these functions.

11:03 PM Changeset in webkit [119954] by kinuko@chromium.org
  • 17 edits
    3 copies
    9 moves
    1 add in trunk/Source/WebCore

Move Quota related code out of DOMWindow and into the quota/ folder
​https://bugs.webkit.org/show_bug.cgi?id=88512

Patch by Kinuko Yasuda <​kinuko@google.com> on 2012-06-07
Reviewed by Adam Barth.

No new tests: no visible changes.

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • Modules/quota/DOMWindowQuota.cpp: Added.
  • Modules/quota/DOMWindowQuota.h: Added.
  • Modules/quota/DOMWindowQuota.idl: Added.
  • Modules/quota/StorageInfo.cpp: Renamed from Source/WebCore/storage/StorageInfo.cpp.
  • Modules/quota/StorageInfo.h: Renamed from Source/WebCore/storage/StorageInfo.h.
  • Modules/quota/StorageInfo.idl: Renamed from Source/WebCore/storage/StorageInfo.idl.
  • Modules/quota/StorageInfoErrorCallback.h: Renamed from Source/WebCore/storage/StorageInfoErrorCallback.h.
  • Modules/quota/StorageInfoErrorCallback.idl: Renamed from Source/WebCore/storage/StorageInfoErrorCallback.idl.
  • Modules/quota/StorageInfoQuotaCallback.h: Renamed from Source/WebCore/storage/StorageInfoQuotaCallback.h.
  • Modules/quota/StorageInfoQuotaCallback.idl: Renamed from Source/WebCore/storage/StorageInfoQuotaCallback.idl.
  • Modules/quota/StorageInfoUsageCallback.h: Renamed from Source/WebCore/storage/StorageInfoUsageCallback.h.
  • Modules/quota/StorageInfoUsageCallback.idl: Renamed from Source/WebCore/storage/StorageInfoUsageCallback.idl.
  • Target.pri:
  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.vcproj/copyForwardingHeaders.cmd:
  • WebCore.xcodeproj/project.pbxproj:
  • page/DOMWindow.cpp:
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
10:47 PM Changeset in webkit [119953] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed: Add expectations for svg-as-background-6.html

Like other SVG tests noted in bug 83303, this test fails on
Windows because it uses a sans-serif font where a serif font is
expected.

  • platform/chromium/TestExpectations:
10:35 PM Changeset in webkit [119952] by dominicc@chromium.org
  • 3 edits in trunk/LayoutTests

[Chromium] Unreviewed: Rebaseline fixed-position-transform-composited-page-scale on Linux, Win

These differ in antialiasing only, where there are already
platform differences antialiasing.

  • platform/chromium-linux/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
  • platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
9:45 PM Changeset in webkit [119951] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed: Update
css3/font-feature-settings-rendering.html again -- actually it may
pass if a particular DLL is installed. So expect PASS or
IMAGE+TEXT failure from this test.

  • platform/chromium/TestExpectations:
9:38 PM Changeset in webkit [119950] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed: Update
css3/font-feature-settings-rendering.html expectations to fail on
XP.

  • platform/chromium/TestExpectations:
8:58 PM Changeset in webkit [119949] by hayato@chromium.org
  • 6 edits
    2 adds in trunk

An inheritance of '-webkit-user-modify' does not stop at shadow boundary.
​https://bugs.webkit.org/show_bug.cgi?id=88514

Reviewed by Ryosuke Niwa.

Source/WebCore:

In StyleResolver::styleForElement(), we reset '-webkit-user-modify'
CSS property after inheriting a parent style, but that is not
enough. We also have to reset '-webkit-user-modify' when we use a
cached result in applying matched properties.

Test: fast/dom/shadow/user-modify-inheritance.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::styleForElement):

  • css/StyleResolver.h:

(StyleResolver):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::inheritFrom):

  • rendering/style/RenderStyle.h:

LayoutTests:

  • fast/dom/shadow/user-modify-inheritance-expected.txt: Added.
  • fast/dom/shadow/user-modify-inheritance.html: Added.
7:30 PM Changeset in webkit [119948] by yosin@chromium.org
  • 19 edits
    2 adds in trunk

[Forms] Introduce Decimal behind the InputNumber type
​https://bugs.webkit.org/show_bug.cgi?id=88383

Reviewed by Kent Tamura.

Source/WebCore:

This patch introduces decimal arithmetic for steppable input types,
e.g. date, datetime, number, range, and so on, to avoid rounding error
caused by base 2 floating point representation, e.g. C/C++ double type.

Most of decimal arithmetic calculations are implemented in StepRange
class, replacing "double" with "Decimal", InputType::applyStep, and
InputType::stepFromRenderer.

Changes introduced by this patch are still intermediate state.
Following patch will replace InputNumber type to Decimal type for
completion of introducing decimal arithmetic.

Test: fast/forms/range/range-value-rounding.html

  • html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::serialize): Changed for Decimal type.
(WebCore::BaseDateAndTimeInputType::serializeWithComponents): ditto.

  • html/DateInputType.cpp:

(WebCore::DateInputType::createStepRange): Replaced NumberWithDecimalPlaces to InputNumber.

  • html/DateTimeInputType.cpp:

(WebCore::DateTimeInputType::createStepRange): Replaced NumberWithDecimalPlaces to InputNumber.

  • html/DateTimeLocalInputType.cpp:

(WebCore::DateTimeLocalInputType::createStepRange): Replaced NumberWithDecimalPlaces to InputNumber.

  • html/InputType.cpp:

(WebCore::InputType::rangeUnderflow): Changed for Decimal type.
(WebCore::InputType::rangeOverflow): Changed for Decimal type.
(WebCore::InputType::minimum): Changed for Decimal type.
(WebCore::InputType::maximum): ditto.
(WebCore::InputType::isInRange): ditto.
(WebCore::InputType::isOutOfRange): ditto.
(WebCore::InputType::stepMismatch): ditto.
(WebCore::InputType::validationMessage): ditto.
(WebCore::InputType::parseToNumberOrNaN): ditto.
(WebCore::InputType::applyStep): ditto.
(WebCore::InputType::stepUpFromRenderer): ditto.

  • html/InputType.h:

(InputType): Removed parseToNumberWIthDecimaplPlaces.

  • html/MonthInputType.cpp:

(WebCore::MonthInputType::createStepRange): Changed for Decimal type.

  • html/NumberInputType.cpp:

(WebCore::RealNumberRenderSize): Added for calculateRenderSize.
(WebCore::calculateRenderSize): Added. This function replacess lengthBeforeDecimalPoint.
(WebCore::NumberInputType::createStepRange): Changed for Decimal type.
(WebCore::NumberInputType::sizeShouldIncludeDecoration): Changed to use calculateRenderSize.
(WebCore::NumberInputType::parseToNumber): Changed for Decimal type.
(WebCore::NumberInputType::serialize): ditto.

  • html/NumberInputType.h:

(NumberInputType): Removed parseToNumberWIthDecimaplPlaces.

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::createStepRange): Changed for Decimal type.
(WebCore::RangeInputType::handleKeydownEvent): ditto.
(WebCore::RangeInputType::parseToNumber): ditto.
(WebCore::RangeInputType::serialize): ditto.

  • html/StepRange.cpp:

(WebCore::StepRange::StepRange): Removed decimal places and changed for Decimal type.
(WebCore::StepRange::acceptableError): Changed for Decimal type.
(WebCore::StepRange::alignValueForStep): ditto.
(WebCore::StepRange::clampValue): Changed for Decimal type and std::min/max.
(WebCore::StepRange::parseStep): Changed for Decimal type and removed NumberWithDecimalPlaces.
(WebCore::StepRange::stepMismatch): Changed for Decimal type.
(WebCore::convertDoubleToInputNumber): Changed to real implementation.
(WebCore::convertInputNumberToDouble): Changed to real implementation.

  • html/StepRange.h:

(InputNumber): Replacement of NumberWithDecimalPlaces.
(WebCore::StepRange::InputNumber::InputNumber):

  • html/TimeInputType.cpp:

(WebCore::TimeInputType::createStepRange): Changed for Decimal type.

  • html/WeekInputType.cpp:

(WebCore::WeekInputType::createStepRange): Changed for Decimal type.

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::serializeForNumberType): Added Decimal version.
(WebCore::parseToDecimalForNumberType): Added.

  • html/parser/HTMLParserIdioms.h: Updated comments for parseToDoubleForNumberType.
  • html/shadow/SliderThumbElement.cpp:

(WebCore::sliderPosition): Changed for Decimal type.

LayoutTests:

  • fast/forms/range/range-value-rounding-expected.txt: Added.
  • fast/forms/range/range-value-rounding.html: Added.
7:16 PM Changeset in webkit [119947] by commit-queue@webkit.org
  • 7 edits
    3 adds in trunk

[BlackBerry] Possible to clobber httponly cookie.
​https://bugs.webkit.org/show_bug.cgi?id=86067

Patch by Jason Liu <​jason.liu@torchmobile.com.cn> on 2012-06-10
Reviewed by Rob Buis.

Source/WebCore:

If a cookie is set by javaScript and there is already a same httpOnly cookie in cookieManager,
we should reject it. If it has a httpOnly property, we reject it, too.

Test: http/tests/cookies/js-get-and-set-http-only-cookie.html

  • platform/blackberry/CookieJarBlackBerry.cpp:

(WebCore::setCookies):

  • platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::setCookies):
(WebCore::CookieManager::checkAndTreatCookie):
(WebCore::CookieManager::addCookieToMap):
(WebCore::CookieManager::setPrivateMode):

  • platform/blackberry/CookieManager.h:
  • platform/blackberry/CookieMap.cpp:

(WebCore::CookieMap::addOrReplaceCookie):
(WebCore::CookieMap::removeCookie):

  • platform/blackberry/CookieMap.h:

(CookieMap):

LayoutTests:

  • http/tests/cookies/js-get-and-set-http-only-cookie-expected.txt: Added.
  • http/tests/cookies/js-get-and-set-http-only-cookie.html: Added.
  • platform/chromium/http/tests/cookies/js-get-and-set-http-only-cookie-expected.txt: Added.
2:36 PM Changeset in webkit [119946] by rniwa@webkit.org
  • 6 edits
    2 adds in trunk

Expose layoutTestController as testRunner
​https://bugs.webkit.org/show_bug.cgi?id=88210

Reviewed by Darin Adler.

Tools:

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::makeWindowObject):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::bindJSObjectsToWindow):

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::initJSObjects):

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::makeWindowObject):

LayoutTests:

Add a test for testRunner object.

  • fast/harness/testrunner-object-expected.txt: Added.
  • fast/harness/testrunner-object.html: Added.
1:18 PM Changeset in webkit [119945] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Access control allow lists starting with a comma are parsed incorrectly (CORS)
​https://bugs.webkit.org/show_bug.cgi?id=88461

Patch by Pablo Flouret <​pablof@motorola.com> on 2012-06-10
Reviewed by Adam Barth.

Source/WebCore:

The parsing algorithm would stop parsing at the first comma (being an
empty entry, of sorts) and bail out, effectively ignoring the whole
header.

Test: http/tests/xmlhttprequest/access-control-allow-lists-starting-with-comma.html

  • loader/CrossOriginPreflightResultCache.cpp:

(WebCore::parseAccessControlAllowList):

LayoutTests:

  • http/tests/xmlhttprequest/access-control-allow-lists-starting-with-comma-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-allow-lists-starting-with-comma.html: Added.
  • http/tests/xmlhttprequest/resources/access-control-allow-lists.php: Added.
12:48 PM Changeset in webkit [119944] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

Removing mixed content tests' dependency on WebKitBlobBuilder:
​https://bugs.webkit.org/show_bug.cgi?id=88736

http/tests/security/mixedContent/blob-url-in-iframe.html and
http/tests/security/mixedContent/filesystem-url-in-iframe.html both
relied on WebKitBlobBuilder, which is disabled on some builds. `new
Blob()` is the new hotness that these tests should be using instead. This
patch migrates both tests to the new API.

It also reenables blob-url-in-iframe.html on mac (filesystem-url-in-iframe.html
remains disabled, as the filesystem APIs are disabled entirely).

Patch by Mike West <​mkwst@chromium.org> on 2012-06-10
Reviewed by Adam Barth.

  • http/tests/security/mixedContent/blob-url-in-iframe.html:
  • http/tests/security/mixedContent/filesystem-url-in-iframe.html:
  • platform/mac/Skipped:
12:19 PM Changeset in webkit [119943] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Some additional tweaks to keep TreeShared code simple/clean
​https://bugs.webkit.org/show_bug.cgi?id=88738

Reviewed by Adam Barth.

  • platform/TreeShared.h: Make constructor and destructor both protected.

It's slightly dangerous to have a public non-virtual destructor, and there
is no reason it needs to be public.
(WebCore::TreeShared::~TreeShared): Make debug-only destructor non-virtual;
we were getting no value from it being virtual. Now that it's non-virtual,
there is no need to use an #if on it since it's an empty inline destructor
in non-debug builds.

11:44 AM Changeset in webkit [119942] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[EFL][GTK] media/track/track-cue-rendering-inner-timestamps.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=88725

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-10
Reviewed by Eric Carlson.

  • media/track/track-cue-rendering-inner-timestamps.html: Round the timestamp values

so that the test passes for EFL and GTK ports.

  • platform/efl/TestExpectations: Unskip test.
  • platform/gtk/TestExpectations: Unskip test.
11:41 AM Changeset in webkit [119941] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Skip fast/dom/frame-loading-via-document-write.html
​https://bugs.webkit.org/show_bug.cgi?id=88737

Unreviewed EFL gardening. Skipping test that is flaky after r119788.

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-10

  • platform/efl/TestExpectations:
11:18 AM Changeset in webkit [119940] by jer.noble@apple.com
  • 5 edits
    2 adds in trunk

REGRESSION: Setting invalid media "src" does not cause "error" event
​https://bugs.webkit.org/show_bug.cgi?id=88423

Reviewed by Eric Carlson.

Source/WebCore:

Test: http/tests/media/video-src-invalid-error.html

Two problems here. When the loadTimer is scheduled, the m_pendingLoadFlags
variable is set to specify what type of load is scheduled. It is cleared
when the loadTimer fires. But, when prepareForLoad() stops the loadTimer,
it does not clear the m_pendingLoadFlags variable, so the next time
scheduleLoad() is called (when the src is changed to an invalid URL)
prepareForLoad() is not called again.

Second problem: Due to a bug in QTKit (<rdar://problem/11606415>), the
QTMovieLoadStateChangedNotification is never fired for an invalid http
URL if QTMovieOpenAsyncRequiredAttribute:YES is not passed when creating
the QTMovie.

Add a new utility method which both stops the m_loadTimer and clears the
m_pendingLoadFlags, and use it in all the places where m_loadTimer was
stopped explicitly:

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore::HTMLMediaElement::stopLoadTimer): Added
(WebCore::HTMLMediaElement::userCancelledLoad):

  • html/HTMLMediaElement.h:

And pass QTMovieOpenAsyncRequiredAttribute:YES when creating the QTMovie:

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes):

LayoutTests:

  • http/tests/media/video-src-invalid-error-expected.txt: Added.
  • http/tests/media/video-src-invalid-error.html: Added.
11:14 AM Changeset in webkit [119939] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

Add logging functions to MediaPlayerPrivateQTKit.
​https://bugs.webkit.org/show_bug.cgi?id=88425

Reviewed by Eric Carlson.

No new tests; adds logging functions to aide debugging.

MediaPlayerPrivateQTKit should emit the same kind of logging messages as
other MediaPlayerPrivate engines to aide in debugging.

Distinguish between loadedRangesChanged() and loadStateChanged() for logging
purposes:

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::loadedRangesChanged):
(-[WebCoreMovieObserver loadedRangesChanged:]):

Add LOG messages for each of the following functions:

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::~MediaPlayerPrivateQTKit):
(WebCore::MediaPlayerPrivateQTKit::createQTMovie):
(WebCore::MediaPlayerPrivateQTKit::createQTMovieView):
(WebCore::MediaPlayerPrivateQTKit::detachQTMovieView):
(WebCore::MediaPlayerPrivateQTKit::createQTVideoRenderer):
(WebCore::MediaPlayerPrivateQTKit::destroyQTVideoRenderer):
(WebCore::MediaPlayerPrivateQTKit::createQTMovieLayer):
(WebCore::MediaPlayerPrivateQTKit::destroyQTMovieLayer):
(WebCore::MediaPlayerPrivateQTKit::setUpVideoRendering):
(WebCore::MediaPlayerPrivateQTKit::tearDownVideoRendering):
(WebCore::MediaPlayerPrivateQTKit::load):
(WebCore::MediaPlayerPrivateQTKit::prepareToPlay):
(WebCore::MediaPlayerPrivateQTKit::play):
(WebCore::MediaPlayerPrivateQTKit::pause):
(WebCore::MediaPlayerPrivateQTKit::seek):
(WebCore::MediaPlayerPrivateQTKit::cancelSeek):
(WebCore::MediaPlayerPrivateQTKit::setVolume):
(WebCore::MediaPlayerPrivateQTKit::setRate):
(WebCore::MediaPlayerPrivateQTKit::setPreservesPitch):
(WebCore::MediaPlayerPrivateQTKit::cancelLoad):
(WebCore::MediaPlayerPrivateQTKit::prepareForRendering):
(WebCore::MediaPlayerPrivateQTKit::updateStates):
(WebCore::MediaPlayerPrivateQTKit::loadStateChanged):
(WebCore::MediaPlayerPrivateQTKit::rateChanged):
(WebCore::MediaPlayerPrivateQTKit::sizeChanged):
(WebCore::MediaPlayerPrivateQTKit::timeChanged):
(WebCore::MediaPlayerPrivateQTKit::didEnd):
(WebCore::MediaPlayerPrivateQTKit::clearMediaCache):
(WebCore::MediaPlayerPrivateQTKit::clearMediaCacheForSite):
(WebCore::MediaPlayerPrivateQTKit::disableUnsupportedTracks):

11:09 AM Changeset in webkit [119938] by jer.noble@apple.com
  • 8 edits in trunk/Source/WebCore

WebCore should use a single definition of an invalid media time.
​https://bugs.webkit.org/show_bug.cgi?id=88572

Reviewed by Eric Carlson.

No new tests; no change in functionality, so covered by existing tests.

Add a new, universal definition for an invalid media time:

  • platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayer::invalidTime):

Use this new definition instead of the hodge podge of (identical) local
definitions for an invalid media time:

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::invalidateCachedTime):
(WebCore::HTMLMediaElement::currentTime):
(WebCore::HTMLMediaElement::initialTime):
(WebCore::HTMLMediaElement::playbackProgressTimerFired):
(WebCore::HTMLMediaElement::prepareMediaFragmentURI):
(WebCore::HTMLMediaElement::applyMediaFragmentURI):

  • html/MediaFragmentURIParser.cpp:

(WebCore::MediaFragmentURIParser::invalidTimeValue):
(WebCore::MediaFragmentURIParser::MediaFragmentURIParser):
(WebCore::MediaFragmentURIParser::startTime):
(WebCore::MediaFragmentURIParser::endTime):
(WebCore::MediaFragmentURIParser::parseTimeFragment):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
(WebCore::MediaPlayerPrivateAVFoundation::duration):
(WebCore::MediaPlayerPrivateAVFoundation::seeking):
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):
(WebCore::MediaPlayerPrivateAVFoundation::invalidateCachedDuration):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

(MediaPlayerPrivateAVFoundation):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration):

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::duration):
(WebCore::MediaPlayerPrivateQTKit::updateStates):
(WebCore::MediaPlayerPrivateQTKit::timeChanged):

10:15 AM Changeset in webkit [119937] by Darin Adler
  • 16 edits in trunk

Remove unneeded callRemovedLastRef function from TreeShared refactoring
​https://bugs.webkit.org/show_bug.cgi?id=88653

Reviewed by Sam Weinig.

.:

  • Source/autotools/symbols.filter: Filter removedLastRef instead of

callRemovedLastRef.

Source/WebCore:

  • WebCore.exp.in: Updated to remove callRemovedLastRef and add removedLastRef.
  • dom/ContainerNode.cpp: Removed callRemovedLastRef, which is no longer

needed and also had a bad cast in it.

  • dom/Document.h: Made removedLastRef private and non-virtual and made Node

a friend so it can call the private function.

  • dom/Node.cpp:

(WebCore::Node::removedLastRef): Moved here. This should not be an inline
function. Added comments explaining why it should not be inlined. Also added
explicit code to call to Document::removedLastRef, and added a comment why
that's the right thing to do here.

  • dom/Node.h: Inherit from TreeShared<Node, ContainerNode>. Made the

removedLastRef function non-virtual and removed it from the header file.
Updated TreeShared using statements. Made the TreeShared template class a
friend so it can call the private removedLastRef.

  • html/HTMLFormControlElement.h: Updated TreeShared using statements to specify

Node instead, which accomplishes the same thing.

  • html/HTMLObjectElement.h: Ditto.
  • platform/TreeShared.h: Made TreeShared take two template arguments for the

node type and the parent node type. Removed the callRemovedLastRef functions and
the extra forward declarations it required. Removed the private unused
removedLastRef function; not sure why it was left in here at all.
(WebCore::TreeShared::deref): Call removedLastRef instead of callRemovedLastRef.
(WebCore::TreeShared::setParent): Use ParentNodeType.
(WebCore::TreeShared::parent): Ditto.
(WebCore::adopted): Updated to have both template arguments.

  • svg/SVGElementInstance.cpp:

(WebCore::SVGElementInstance::removedLastRef): Replaced callRemovedLastRef with
this. Moved the body out of the header and added a comment explaining why the
function should not be inlined.

  • svg/SVGElementInstance.h: Made removedLastRef non-virtual, non-inline, and

private. Made TreeShared a friend so it can call the private removedLastRef.
Updated TreeShared using statements.

Source/WebKit2:

  • win/WebKit2.def: Export removedLastRef instead of callRemovedLastRef.
  • win/WebKit2CFLite.def: Ditto.
9:54 AM Changeset in webkit [119936] by zandobersek@gmail.com
  • 4 edits
    1 add in trunk/LayoutTests

Unreviewed GTK gardening. Updating a few animations tests baselines,
adding test expectations for one FileSystem test.

  • platform/gtk/TestExpectations:
  • platform/gtk/animations/3d/change-transform-in-end-event-expected.txt:
  • platform/gtk/animations/3d/matrix-transform-type-animation-expected.txt: Added.
  • platform/gtk/animations/3d/state-at-end-event-transform-expected.txt:
9:33 AM Changeset in webkit [119935] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Temporarily added http/tests/security/mixedContent/blob-url-in-iframe.html to the Mac skip
list. <​http://webkit.org/b/88736> tracks moving this test off of the legacy
WebKitBlobBuilder API.

  • platform/mac/Skipped:
9:14 AM Changeset in webkit [119934] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Added http/tests/security/mixedContent/filesystem-url-in-iframe.html to the Mac skip list,
because FILE_SYSTEM is not enabled.

Part of: http/tests/security/mixedContent/blob-url-in-iframe.html and http/tests/security/mixedContent/filesystem-url-in-iframe.html are failing
<​http://webkit.org/b/88736>

  • platform/mac/Skipped:
9:14 AM Changeset in webkit [119933] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] 2 fast/multicol/span tests are flaky
​https://bugs.webkit.org/show_bug.cgi?id=88734

Unreviewed EFL gardening. Move to TestExpectations 2 tests that
are flaky on the bot.

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-10

  • platform/efl/TestExpectations:
8:37 AM Changeset in webkit [119932] by Darin Adler
  • 2 edits in trunk/Source/WebCore
  • WebCore.exp.in: Re-sorted and alphabetized the file.
8:32 AM Changeset in webkit [119931] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL][GTK] Skip http/tests/xmlhttprequest/origin-exact-matching.html added in r119911
​https://bugs.webkit.org/show_bug.cgi?id=88728

Unreviewed gardening. Skip new test added in r119911 which fails for both
GTK and EFL ports.

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-10

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
8:29 AM Changeset in webkit [119930] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Several test cases can be unskipped
​https://bugs.webkit.org/show_bug.cgi?id=88731

Unreviewed EFL gardening. Unskip a few tests that are passing after
r118618 was rolled out.

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-10

  • platform/efl/TestExpectations:
7:53 AM Changeset in webkit [119929] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] skip userscripts/window-onerror-for-isolated-world-*.html tests
​https://bugs.webkit.org/show_bug.cgi?id=88730

Unreviewed EFL gardening. Skip a few tests causing flakiness.

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-10

  • platform/efl/Skipped:
  • platform/efl/TestExpectations:
7:21 AM Changeset in webkit [119928] by ryuan.choi@samsung.com
  • 5 edits
    2 copies
    2 adds in trunk/Source/WebKit2

[EFL][WK2] Add and refactor ewk API in order to support MiniBrowser without WK API.
​https://bugs.webkit.org/show_bug.cgi?id=84124

Reviewed by Chang Shu.

Modify ewk_view and add ewk_context to provide a platform-depedent WebKit2
API.
This patch provides the minimum to support MiniBrowser.

  • PlatformEfl.cmake: add ewk_context.cpp.
  • UIProcess/API/efl/EWebKit2.h: Added.
  • UIProcess/API/efl/ewk_context.cpp: Added.

(_Ewk_Context):
(createDefaultWebContext):
(ewk_context_WKContext_get):
(ewk_context_default_get):

  • UIProcess/API/efl/ewk_context.h: Added.
  • UIProcess/API/efl/ewk_context_private.h: Added.
  • UIProcess/API/efl/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_del):
(ewk_view_base_add):
(ewk_view_add_with_context):
(ewk_view_add):
(ewk_view_uri_set):
(ewk_view_uri_get):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/ewk_view_private.h:
6:44 AM Changeset in webkit [119927] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt][Win] Fix building Source/WebCore/plugins/win/PluginViewWin.cpp
​https://bugs.webkit.org/show_bug.cgi?id=88308

Reviewed by Simon Hausmann.

No new tests, just a build fix.

Use ownerWindow() from page client. It has been
introduced for x11 plugins to solve exactly the
same problem.

  • plugins/win/PluginViewWin.cpp:

(windowHandleForPageClient):

5:49 AM Changeset in webkit [119926] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Build fix for !ENABLE(JIT) after r119844 and r119925.

  • runtime/Executable.h:

(ExecutableBase):
(JSC::ExecutableBase::clearCodeVirtual):

5:25 AM Changeset in webkit [119925] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Build fix for !ENABLE(JIT) after r119844.

  • runtime/Executable.h:

(ExecutableBase):
(JSC):

5:09 AM Changeset in webkit [119924] by kbalazs@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt][Win] Fix building ImageQt.cpp
​https://bugs.webkit.org/show_bug.cgi?id=88306

Reviewed by Simon Hausmann.

No new tests, this is just a build fix.

  • platform/graphics/qt/ImageQt.cpp:

(WebCore):
(WebCore::BitmapImage::create):
Adapt to the "API" changes in Qt.

4:43 AM Changeset in webkit [119923] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL][GTK] Skip media/track/track-cue-rendering-inner-timestamps.html added in r119907
​https://bugs.webkit.org/show_bug.cgi?id=88726

Unreviewed gardening. Skip test added in r119907 for GTK and EFL ports.

Patch by Christophe Dumez <Christophe Dumez> on 2012-06-10

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
Note: See TracTimeline for information about the timeline view.