Timeline



Nov 13, 2002:

11:24 PM Changeset in webkit [2668] by trey
  • 5 edits in trunk/WebKit

Fixed client redirects, some more. The upshot is that they do not
generate two items in the back-forward list. iBench still works.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge reportClientRedirectTo:delay:fireDate:]): Call straight to the frame for all impl. (-[WebBridge reportClientRedirectCancelled]): Call straight to the frame for all impl. (-[WebBridge loadURL:reload:triggeringEvent:isFormSubmission:]): clientRedirect param removed when sending _loadURL: to frame.
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]): clientRedirect param removed. Check our own ivar to know if we are in client redirect case. (-[WebFrame _loadURL:intoChild:]): clientRedirect param removed when sending _loadURL: . (-[WebFrame _clientRedirectedTo:delay:fireDate:]): Note that we are doing a redirect if time=0 and we're not completed. Also includes previous impl moved from Bridge. (-[WebFrame _clientRedirectCancelled]): Previous impl moved from Bridge.
10:16 PM Changeset in webkit [2667] by darin
  • 5 edits in trunk/WebCore
  • khtml/rendering/render_text.h: Add an optional arena parameter to deleteSlaves.
  • khtml/rendering/render_text.cpp: (RenderText::detach): Pass the render arena in to deleteSlaves. (RenderText::deleteSlaves): Use the passed-in arena.
10:09 PM Changeset in webkit [2666] by darin
  • 11 edits in trunk/WebCore

WebFoundation:

  • Misc.subproj/WebAssertions.m: (vprintf_stderr_objc): Don't use displayableString. Makes us able to build on Panther.
  • WebFoundation.pbproj/project.pbxproj: Project Builder wanted to touch this.

WebCore:

  • khtml/rendering/render_box.cpp: (RenderBox::setStyle): Call renderArena() from RenderObject rather than going at the document directly. Safer because it works even when we don't have a node yet.
  • khtml/rendering/render_flow.cpp: (RenderFlow::addChild): Ditto.
  • khtml/rendering/render_layer.cpp: (RenderLayer::paint): Ditto. (RenderLayer::nodeAtPoint): Ditto. (RenderLayer::constructZTree): Ditto.
  • khtml/rendering/render_list.cpp: (RenderListItem::setStyle): Ditto.
  • khtml/rendering/render_text.cpp: (RenderText::deleteSlaves): Ditto. (RenderText::position): Ditto. This is the one that actually crashed.
  • khtml/misc/makeattrs: Fixed handling of failure case.
  • khtml/misc/maketags: Ditto.
  • WebCore.pbproj/project.pbxproj: Project Builder wanted to touch this.
9:11 PM Changeset in webkit [2665] by darin
  • 9 edits in trunk/WebCore

A few arena-related fixes.

  • khtml/rendering/bidi.h: Don't define the operator new without the arena parameter. That way, we get a link failure if we use it by accident, rather than an assert at runtime. It would be even better to get a compile-time error, but I don't know how to make that happen.
  • khtml/rendering/render_layer.h: Ditto.
  • khtml/rendering/render_object.h: Ditto.
  • khtml/rendering/render_text.h: Ditto.
  • khtml/rendering/render_container.cpp: (RenderContainer::addChild): Create the RenderTable with the appropriate arena. (RenderContainer::insertPseudoChild): Create the RenderFlow objects with the appropriate arena.
  • khtml/rendering/render_text.cpp: (RenderText::deleteSlaves): Don't try to get the arena when there are no slaves. This can happen after the element is nil, and in that case we will do a nil-dereference.
8:53 PM Changeset in webkit [2664] by darin
  • 5 edits in trunk/WebCore

WebCore:

  • kwq/KWQLineEdit.mm: (QLineEdit::sizeForCharacterWidth): Use the "0" instead of the "x" as the canonical character for width. This is slightly wider and is better for credit card numbers, for example.
  • WebCore.pbproj/project.pbxproj: Tweak.

WebBrowser:

  • English.lproj/StringsNotToBeLocalized.txt: Let the script sort this file.
8:44 PM Changeset in webkit [2663] by darin
  • 4 edits in trunk/JavaScriptCore
  • fixed 3099930 -- dates/times without time zones are parsed as UTC by kjs, local time by other browsers
  • kjs/date_object.cpp: (DateProtoFuncImp::call): Handle the NaN case better, like Mozilla and OmniWeb. (DateObjectFuncImp::call): Return NaN rather than Undefined() for bad dates. (KJS::parseDate): Return NaN rather than Undefined() or 0 for bad dates. (KJS::KRFCDate_parseDate): Return -1 rather than 0 for bad dates. Assume local time if no time zone is passed. Don't return 1 if we parse 0.
7:20 PM Changeset in webkit [2662] by mjs
  • 7 edits in trunk/WebKit

WebKit:

Pass mime type instead of full response to content policy delegate
method, in preparation for merging it with the file URL policy.

  • WebView.subproj/WebControllerPolicyDelegate.h:
  • WebView.subproj/WebDefaultPolicyDelegate.m:
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveResponse:]):

WebBrowser:

Pass mime type instead of full response to content policy delegate
method, in preparation for merging it with the file URL policy.

  • BrowserWebController.m: (-[BrowserWebController contentPolicyForMIMEType:andRequest:inFrame:]):
3:46 PM Changeset in webkit [2661] by vicki
  • 1 edit in trunk/WebCore/khtml/misc/arena.h

tiny change made by rjw to fix build breakage

3:32 PM Changeset in webkit [2660] by darin
  • 18 edits in trunk

WebCore:

  • fixed 3083982 -- Logging into AOL gives null view

Turns out AOL was using a refresh header, which we were not supporting.

  • khtml/khtml_part.h: Declare receivedFirstData, a private member function.
  • khtml/khtml_part.cpp: (KHTMLPart::receivedFirstData): Separate out the part of slotData we want to share, which really seems kinda separate anyway. (KHTMLPart::slotData): More of the same.
  • kwq/KWQKHTMLPart.h: Declare addMetaData.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::slotData): Call receivedFirstData instead of doing the same thing ourselves. (KWQKHTMLPart::addMetaData): Added. Puts metadata into the job.
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Fix bug where this was calling openURL: but meant to call loadURL:.
  • kwq/WebCoreBridge.h: Add headers to openURL method. Remove setContentType.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge openURL:withHeaders:]): Handle Content-Type and Refresh. This method is big enough that I should probably move the guts to KWQKHTMLPart.
  • other things
  • kwq/KWQListImpl.mm: (KWQListImpl::~KWQListImpl): I overlooked something while doing my "bug fix" in here a while back. Change an assignment statement to an assert.

WebKit:

  • fixed 3083982 -- Logging into AOL gives null view

Turns out AOL was using a refresh header, which we were not supporting.

  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady]): Call openURL: and pass headers in.
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:isFormSubmission:]): Pass nil for headers in this case, since we know it's just an anchor change.
  • other things
  • WebCoreSupport.subproj/WebBridge.h: Remove dataSourceChanged and dataSource methods. We try to keep the bridge methods down to actual bridging.
  • WebCoreSupport.subproj/WebBridge.m: Remove dataSourceChanged altogether, and move dataSource up in the file.
  • WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation setDataSource:]): Keep the data source around, so we don't need to ask the bridge for it. (-[WebHTMLRepresentation documentSource]): Use it here.
3:01 PM Changeset in webkit [2659] by hyatt
  • 4 edits in trunk/WebCore

Fix for floats. Force relayout if collapsing margins
have to adjust the position of an object.

  • khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren):
2:13 PM Changeset in webkit [2658] by trey
  • 4 edits in trunk/WebKit

Fixed 3100084 - REGRESSION: web page is not first responder after visiting web page

  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady]): Make the rep before _transitionToCommitted. This is the way it used to be. (-[WebDataSource _makeRepresentation]): Don't make the docView here.
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]): Make the docView here, after we save the scroll state but before notifying the delegate.
2:07 PM Changeset in webkit [2657] by hyatt
  • 11 edits in trunk/WebCore

Rewrite cellpadding to not use the style system at all and
to make table cells just get the padding from the table
itself (overriding style).

  • khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::HTMLTableElementImpl): (HTMLTableElementImpl::attach): (HTMLTableElementImpl::parseAttribute): (HTMLTableCellElementImpl::init):
  • khtml/html/html_tableimpl.h:
  • khtml/rendering/bidi.cpp: (RenderFlow::layoutInlineChildren):
  • khtml/rendering/render_box.cpp: (RenderBox::contentWidth): (RenderBox::contentHeight):
  • khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren): (RenderFlow::leftOffset): (RenderFlow::rightOffset): (RenderFlow::calcMinMaxWidth):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_table.cpp: (RenderTable::RenderTable): (RenderTableCell::paddingTop): (RenderTableCell::paddingBottom): (RenderTableCell::paddingLeft): (RenderTableCell::paddingRight):
  • khtml/rendering/render_table.h:
1:40 PM Changeset in webkit [2656] by kocienda
  • 4 edits in trunk/WebCore

Bump WebCore cache to 4 MB (was 1 MB).

  • khtml/misc/loader.cpp
1:15 PM Changeset in webkit [2655] by darin
  • 5 edits in trunk/JavaScriptCore
  • fixed 3073230 -- JavaScript time calls do I/O by lstat()ing /etc/localtime
  • kjs/date_object.cpp: (formatDate): Added. (formatTime): Added. (formatLocaleDate): Added. (formatLocaleTime): Added. (DateProtoFuncImp::call): Changed to use the above functions instead of using strftime.
10:30 AM Changeset in webkit [2654] by darin
  • 3 edits in trunk/WebKit
  • fixed 3100013 -- REGRESSION: Can't get results from i-Bench anymore
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _isLoadComplete]): Don't set the state to WebFrameStateComplete if it has already been set to WebFrameStateProvisional. If it has, that means we already began a new load; that one is not yet complete.
9:17 AM Changeset in webkit [2653] by sullivan
  • 4 edits in trunk/WebKit

2002-11-13 John Sullivan <​sullivan@apple.com>

  • fixed 3099922 -- REGRESSION: Back button always pops up menu
  • Misc.subproj/WebNSViewExtras.h:
  • Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragShouldBeginFromMouseDown:withExpiration:xHysteresis:yHysteresis:]: Fixed a copy/paste error I made yesterday -- this method was never noticing the mouse-up events because it was checking the event type against the wrong number. Also changed the hysteresis values from unsigneds to floats (unsigned was just wrong).
2:56 AM Changeset in webkit [2652] by mjs
  • 15 edits in trunk

WebCore:

  • fixed 3050447 - Policy handlers have no way of telling client that the proposed navigation is a form post
  • khtml/khtml_part.cpp: (KHTMLPart::submitForm): Call kwq->submitForm
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURL): Adjusted for bridge API change. (KWQKHTMLPart::openURLRequest): Removed POST handling. (KWQKHTMLPart::submitForm): Added this back, because we need to know what URL navigations are caused by form submission, even if they are not POSTs. (KWQKHTMLPart::urlSelected): Adjusted for bridge API change.
  • kwq/WebCoreBridge.h: Add triggeringEvent: parameter to postURL: and isFormSubmission: parameter to loadURL:.

WebKit:

  • fixed 3050447 - Policy handlers have no way of telling client that the proposed navigation is a form post

Now we pass form submissions through all the normal policy steps.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadURL:reload:triggeringEvent:isFormSubmission:]): (-[WebBridge postWithURL:data:contentType:triggeringEvent:]): (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]):
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _setTriggeringAction:]): (-[WebDataSource _triggeringAction]): (-[WebDataSource _lastCheckedRequest]): (-[WebDataSource _setLastCheckedRequest:]):
  • WebView.subproj/WebFrame.m: (-[WebFrame setProvisionalDataSource:]):
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _shouldShowRequest:]): (-[WebFrame _loadRequest:triggeringAction:]): (-[WebFrame _actionInformationForNavigationType:event:]): (-[WebFrame _continueAfterNavigationPolicyForRequest:dataSource:]): (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:isFormSubmission:]): (-[WebFrame _loadURL:intoChild:]): (-[WebFrame _postWithURL:data:contentType:triggeringEvent:]):

Nov 12, 2002:

8:52 PM Changeset in webkit [2651] by mjs
  • 8 edits in trunk/WebKit

WebKit:

Combine click policy and URL policy into navigation policy.

  • WebView.subproj/WebControllerPolicyDelegate.h:
  • WebView.subproj/WebDefaultPolicyDelegate.h:
  • WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate navigationPolicyForAction:andRequest:inFrame:]):
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _shouldShowRequest:]): (-[WebFrame _actionInformationForNavigationType:event:]): (-[WebFrame _continueAfterFileURLPolicyForRequest:]): (-[WebFrame _continueAfterNavigationPolicyForRequest:event:]): (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:]):

WebBrowser:

Combined click policy and URL policy into navigation policy.

  • BrowserDocument.m: (-[BrowserDocument goToRequest:]):
  • BrowserWebController.m: (-[BrowserWebController navigationPolicyForAction:andRequest:inFrame:]):
7:24 PM Changeset in webkit [2650] by hyatt
  • 5 edits in trunk/WebCore

Fix for 3032869, the background image for the body was being
propagated up to the root properly but was not being tiled over
the whole canvas.

  • khtml/rendering/render_box.cpp: (RenderBox::printBackground):
  • khtml/rendering/render_html.cpp: (RenderHtml::printBoxDecorations):
6:20 PM Changeset in webkit [2649] by trey
  • 3 edits in trunk/WebKit

fixed 3096030 - Crash in -[WebBackForwardList goToEntry:] when playing with SnapBack and dictionary.com

  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _isLoadComplete]): Set state=completed only after we tell the bridge to end the load. This allows client redirects to be processed before we think we're complete. (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:]): Only process client redirects as such if we are not already complete. This makes JS driven navigations after load-time work like the user would expect, as normal navigations.
6:15 PM Changeset in webkit [2648] by hyatt
  • 4 edits in trunk/WebCore

Fix the top of moveabletype.org. The maxwidth/minwidth
calculation for blocks with inline content did not properly
deal with margins and padding on inline elements like <a>.

  • khtml/rendering/render_flow.cpp: (RenderFlow::calcInlineMinMaxWidth):
5:59 PM Changeset in webkit [2647] by hyatt
  • 6 edits in trunk/WebCore

Fix for 2953367, padding is incorrectly inherited into table cells
and also incorrectly overrides cellpadding on the table itself.
Fixes dailyf1.com.

  • khtml/css/html4.css:
  • khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::parseAttribute): (HTMLTableCellElementImpl::init):
  • khtml/html/html_tableimpl.h:
5:56 PM Changeset in webkit [2646] by mjs
  • 10 edits in trunk/WebKit
  • fixed 3099487 - REGRESSION: dragging an image always puts it in the download directory
  • WebView.subproj/WebControllerPrivate.h:
  • WebView.subproj/WebControllerPrivate.m: (-[WebController _downloadURL:]): Call _downloadURL:toPath: with nil path. (-[WebController _downloadURL:toPath:]): New method that predetermines the path to download to (needed for DnD).
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Use _downloadURL:toPath:
  • WebView.subproj/WebImageView.m: (-[WebImageView namesOfPromisedFilesDroppedAtDestination:]): Use _downloadURL:toPath:
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveResponse:]): Don't ask delegate for download path if we already have one.
5:49 PM Changeset in webkit [2645] by rjw
  • 3 edits in trunk/WebKit

Fixed likely cause of 3099047 (and others). Width buffer could underrun in
some situations.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:letterSpacing:wordSpacing:]):
5:33 PM Changeset in webkit [2644] by hyatt
  • 4 edits in trunk/WebCore

For now make text/xml files use HTML parsing/documents.
This avoids the infinite loop we get into when loading
text/xml. If/when we finally support XML, we can undo
this change.

  • khtml/khtml_part.cpp: (KHTMLPart::begin):
5:28 PM Changeset in webkit [2643] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3086321, stylesheets not loading if titles are
specified. Note that 4 of the pages on the PLT were
affected by this, so I fully expect a slight performance
degradation (the boost from the regression was artificial).

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyleSelector):
5:27 PM Changeset in webkit [2642] by sullivan
  • 4 edits in trunk/WebKit

WebKit:

  • Misc.subproj/WebNSViewExtras.h:
  • Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragShouldBeginFromMouseDown:withExpiration:xHysteresis:yHysteresis:]): new method (-[NSView _web_dragShouldBeginFromMouseDown:withExpiration:]): now calls the new method, passing the default hysteresis values

WebBrowser:

  • fixed 3096528 -- don't let initially-horizontal drags of toolbar bookmarks escape from toolbar

Unfortunately I left behind a drawing glitch, recorded as
bug 3099488. Ideas to fix this are hereby solicited.

  • FavoritesBar.m: (-[FavoritesBar slideButtonsIntoPlace]): renamed from repositionButtons for clarity (-[FavoritesBar maxButtonX]): new method, extracted from _layOutButtons (-[FavoritesBar _layOutButtons]): now calls maxButtonX (-[FavoritesBar setDropIndex:]): updated for name change (-[FavoritesBar specialBookmarkSourcesCount]): new method, extracted from duplicated code (-[FavoritesBar lastNonFavoriteIndex]): new method, extracted from dropIndexFromDraggingInfo: (-[FavoritesBar dropIndexFromLocalPoint:]): new method, extracted from dropIndexFromDraggingInfo: (-[FavoritesBar dropIndexFromDraggingInfo:]): now calls dropIndexFromLocalPoint: (-[FavoritesBar addDroppedBookmarks:atIndex:]): new method, extracted from performDragOperation: (-[FavoritesBar performDragOperation:]): now calls addDroppedBookmarks:atIndex: (-[FavoritesBar _lastDraggedEventFollowing:]), (-[FavoritesBar _lastDraggedOrUpEventFollowing:]): new methods, cribbed from AppKit (-[FavoritesBar constrainProposedButtonFrame:]): new method (-[FavoritesBar reorderFavoriteButton:fromMouseDownEvent:]): new method, drags (but not using CoreDragging stuff) button horizontally within bar only
  • FavoritesBarView.h: added definition of FavoritesBarReorderingDelegate informal protocol
  • FavoritesBarView.m: (-[FavoritesBarView reorderFavoriteButton:fromMouseDownEvent:]): pass call through to delegate (FavoritesBar)
  • FavoriteButton.m: (-[FavoriteButton currentEventOffsetFromEvent:]): new method, extracted from performDragFromEvent: (-[FavoriteButton performDragFromEvent:]): now calls extracted method (-[FavoriteButton canDrag]): renamed from canDragButton; now checks whether superview is a FavoritesBarView (-[FavoriteButton mouseDown:]): checks whether initial dragging movement was primarily vertical or horizontal; if horizontal, calls new reordering code; if vertical, uses larger hysteresis to minimize accidental poofing
5:18 PM Changeset in webkit [2641] by rjw
  • 4 edits in trunk/WebCore

Oops, removed debugging.

  • khtml/rendering/font.cpp: (Font::drawText):
5:07 PM Changeset in webkit [2640] by rjw
  • 14 edits in trunk

Implemented letter-spacing and word-spacing CSS properties.

  • khtml/rendering/font.cpp: (Font::drawText): (Font::floatWidth): (Font::floatCharacterWidths):
  • kwq/KWQFontMetrics.h:
  • kwq/KWQFontMetrics.mm: (QFontMetrics::width): (QFontMetrics::floatWidth): (QFontMetrics::floatCharacterWidths):
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (QPainter::drawText):
  • kwq/WebCoreTextRenderer.h:

Implemented letter-spacing and word-spacing CSS properties.

  • Misc.subproj/WebStringTruncator.m: (+[WebStringTruncator rightTruncateString:toWidth:withFont:]): (+[WebStringTruncator centerTruncateString:toWidth:withFont:]):
  • WebCoreSupport.subproj/WebTextRenderer.h:
  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer widthForCharacters:length:]): (-[WebTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:rightToLeft:letterSpacing:wordSpacing:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:characterPosition:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:letterSpacing:wordSpacing:]): (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:letterSpacing:wordSpacing:]):

Changed to reflect method name change.

  • EtchedStringView.m: (-[EtchedStringView drawRect:]):
5:03 PM Changeset in webkit [2639] by hyatt
  • 8 edits in trunk/WebCore

Revert floats so that they don't use layers any more.
Floats have to be able to paint in between the background
and foreground of inlines, so they can't have layers.

  • khtml/rendering/render_box.cpp: (RenderBox::setStyle):
  • khtml/rendering/render_flow.cpp: (RenderFlow::printObject): (RenderFlow::paintFloats): (RenderFlow::addOverHangingFloats): (RenderFlow::nodeAtPoint):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_layer.cpp: (RenderLayer::constructZTree):
  • khtml/rendering/render_list.cpp: (RenderListItem::printObject):
4:54 PM Changeset in webkit [2638] by mjs
  • 17 edits
    2 deletes in trunk/WebKit

WebKit:

Removed policy classes and instead use the policy enums directly,
since we no longer hold the path in the enum.

  • Downloads.subproj/WebDownloadHandler.m:
  • WebKit.exp:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebControllerPolicyDelegate.h:
  • WebView.subproj/WebControllerPolicyDelegate.m:
  • WebView.subproj/WebControllerPolicyDelegatePrivate.h: Removed.
  • WebView.subproj/WebControllerPrivate.m:
  • WebView.subproj/WebDefaultPolicyDelegate.h:
  • WebView.subproj/WebDefaultPolicyDelegate.m: (+[WebDefaultPolicyDelegate defaultURLPolicyForRequest:]): (-[WebDefaultPolicyDelegate URLPolicyForRequest:inFrame:]): (-[WebDefaultPolicyDelegate fileURLPolicyForMIMEType:andRequest:inFrame:]): (-[WebDefaultPolicyDelegate unableToImplementPolicy:error:forURL:inFrame:]): (-[WebDefaultPolicyDelegate clickPolicyForAction:andRequest:inFrame:]):
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame handleUnimplementablePolicy:errorCode:forURL:]): (-[WebFrame _shouldShowRequest:]): (-[WebFrame _continueAfterClickPolicyForEvent:request:]):
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveResponse:]):

WebBrowser:

Adjusted for WebKit API changes.

  • BrowserDocument.m: (-[BrowserDocument goToRequest:]):
  • BrowserWebController.m: (-[BrowserWebController URLPolicyForRequest:inFrame:]): (-[BrowserWebController unableToImplementPolicy:error:forURL:inFrame:]): (-[BrowserWebController fileURLPolicyForMIMEType:andRequest:inFrame:]): (-[BrowserWebController contentPolicyForResponse:andRequest:inFrame:]): (-[BrowserWebController clickPolicyForAction:andRequest:inFrame:]):
3:24 PM Changeset in webkit [2637] by darin
  • 4 edits in trunk/WebCore
  • kwq/KWQCursor.mm: (QCursor::QCursor): Use nil instead of [NSCursor arrowCursor]. This will probably fix the performance regression.
2:10 PM Changeset in webkit [2636] by darin
  • 5 edits in trunk/WebCore
  • fixed 3080250 -- Hands-free crash at wired.com in KHTMLPart::slotChildStarted
  • kwq/KWQListImpl.mm: (KWQListImpl::~KWQListImpl): Set the node of each iterator to NULL too, not just the list. This is the bug fix for the bug above. (KWQListIteratorImpl::toFirst): Check for list of NULL. (KWQListIteratorImpl::toLast): ditto.
  • kwq/KWQSlot.mm: Tweaks.
1:44 PM Changeset in webkit [2635] by hyatt
  • 44 edits
    4 adds in trunk/WebCore

This patch lands a rewrite of whitespace-handling in the
layout engine and adds support for the CSS2 white-space
property.

It also includes a rewrite of inlines' min/max width
calculations (for both flow inlines and raw text).

A problem with <form> margins has been fixed (this is a
regression I caused with my collapsing margin checkin).

  • WebCore.pbproj/project.pbxproj:
  • khtml/css/html4.css:
  • khtml/html/dtd.cpp: (DOM::checkChild):
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::attach): (HTMLFrameElementImpl::attach): (HTMLFrameSetElementImpl::attach): (HTMLHtmlElementImpl::attach): (HTMLIFrameElementImpl::attach):
  • khtml/html/html_formimpl.cpp: (HTMLFormElementImpl::HTMLFormElementImpl): (HTMLInputElementImpl::attach): (HTMLSelectElementImpl::attach): (HTMLTextAreaElementImpl::attach):
  • khtml/html/html_formimpl.h:
  • khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::attach):
  • khtml/html/html_inlineimpl.cpp: (HTMLBRElementImpl::attach):
  • khtml/html/html_objectimpl.cpp: (HTMLAppletElementImpl::attach): (HTMLEmbedElementImpl::attach): (HTMLObjectElementImpl::attach):
  • khtml/html/htmlparser.cpp: (KHTMLParser::reset): (KHTMLParser::parseToken): (KHTMLParser::insertNode): (KHTMLParser::popBlock): (KHTMLParser::popOneBlock):
  • khtml/html/htmlparser.h:
  • khtml/html/htmltokenizer.cpp: (HTMLTokenizer::addPending): (HTMLTokenizer::write):
  • khtml/misc/arena.cpp: Added. (CeilingLog2): (InitArenaPool): (ArenaAllocate): (ArenaGrow): (FreeArenaList): (ArenaRelease): (FreeArenaPool): (FinishArenaPool): (ArenaFinish):
  • khtml/misc/arena.h: Added.
  • khtml/rendering/bidi.cpp: (BidiIterator::detach): (throw): (BidiIterator::operator delete): (appendRunsForObject): (appendRun): (RenderFlow::bidiReorderLine): (deleteMidpoints): (RenderFlow::layoutInlineChildren): (RenderFlow::findNextLineBreak):
  • khtml/rendering/bidi.h:
  • khtml/rendering/render_arena.cpp: Added. (RenderArena::RenderArena): (RenderArena::~RenderArena): (RenderArena::allocate): (RenderArena::free):
  • khtml/rendering/render_arena.h: Added.
  • khtml/rendering/render_box.cpp: (RenderBox::setStyle): (RenderBox::~RenderBox): (RenderBox::detach):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_br.cpp: (RenderBR::RenderBR):
  • khtml/rendering/render_container.cpp: (RenderContainer::~RenderContainer): (RenderContainer::detach):
  • khtml/rendering/render_container.h:
  • khtml/rendering/render_flow.cpp: (RenderFlow::setStyle): (RenderFlow::layout): (RenderFlow::calcInlineMinMaxWidth): (RenderFlow::calcBlockMinMaxWidth): (RenderFlow::calcMinMaxWidth): (RenderFlow::addChild): (RenderFlow::makeChildrenNonInline):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_html.cpp: (RenderHtml::RenderHtml):
  • khtml/rendering/render_layer.cpp: (RenderLayer::~RenderLayer): (throw): (RenderLayer::operator delete): (RenderLayer::detach): (RenderLayer::paint): (RenderLayer::nodeAtPoint): (RenderLayer::constructZTree): (RenderLayer::RenderLayerElement::operator delete): (RenderLayer::RenderLayerElement::detach): (RenderLayer::RenderZTreeNode::operator delete): (RenderLayer::RenderZTreeNode::detach):
  • khtml/rendering/render_layer.h:
  • khtml/rendering/render_list.cpp: (RenderListItem::setStyle):
  • khtml/rendering/render_object.cpp: (throw): (RenderObject::operator delete): (RenderObject::createObject): (RenderObject::renderArena): (RenderObject::detach):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_replaced.cpp: (RenderWidget::detach):
  • khtml/rendering/render_replaced.h:
  • khtml/rendering/render_root.cpp: (RenderRoot::RenderRoot):
  • khtml/rendering/render_table.cpp: (RenderTable::addChild): (RenderTable::calcWidth): (RenderTable::setCellWidths): (RenderTableSection::addChild): (RenderTableRow::addChild):
  • khtml/rendering/render_text.cpp: (TextSlave::detach): (throw): (TextSlave::operator delete): (TextSlaveArray::TextSlaveArray): (RenderText::RenderText): (RenderText::~RenderText): (RenderText::detach): (RenderText::deleteSlaves): (RenderText::trimmedMinMaxWidth): (RenderText::calcMinMaxWidth): (RenderText::position):
  • khtml/rendering/render_text.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::~DocumentImpl): (DocumentImpl::attach): (DocumentImpl::detach):
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::detach): (NodeImpl::isReadOnly): (NodeImpl::previousRenderer):
  • khtml/xml/dom_nodeimpl.h:
  • khtml/xml/dom_stringimpl.cpp:
  • khtml/xml/dom_stringimpl.h:
  • khtml/xml/dom_textimpl.cpp: (CharacterDataImpl::containsOnlyWhitespace): (TextImpl::attach):
  • khtml/xml/dom_textimpl.h:
1:43 PM Changeset in webkit [2634] by mjs
  • 3 edits in trunk/WebKit

Keep the triggering event around on the data source, so it can be
used with redirects.

  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _loadRequest:triggeringEvent:]): (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:]): (-[WebFrame _postWithURL:data:contentType:]):
1:36 PM Changeset in webkit [2633] by darin
  • 4 edits in trunk/WebCore
  • fixed 3094819 -- Crash in -[KWQObjectTimerTarget timerFired]
  • kwq/KWQObject.mm: (QObject::~QObject): Call the _destroyed signal. (QObject::killTimers): Simplify the code a bit using makeObjectsPerformSelector:.
10:43 AM Changeset in webkit [2632] by darin
  • 6 edits in trunk/WebCore
  • khtml/misc/loader.cpp: (CachedCSSStyleSheet::checkNotify): Copy the clients list before iterating over it, since clients can move around in the list or be removed. (CachedScript::checkNotify): Ditto. (CachedImage::do_notify): Ditto. (CachedImage::movieStatus): Ditto.
  • fixed double calls to openURL I noticed
  • khtml/khtml_part.cpp: (KHTMLPart::processObjectRequest): Don't call openURL here at all. That happens indirectly as a result of the load we kick off.
  • kwq/KWQKHTMLPart.mm: Tweaks.
9:22 AM Changeset in webkit [2631] by darin
  • 7 edits in trunk

WebCore:

  • fixed 3083043 -- Alex doesn't decode % sequences in javascript: URLs

Some places here did KURL::decode_string, but others didn't.

  • khtml/khtml_part.cpp: (KHTMLPart::slotShowDocument): Added call to KURL::decode_string. (KHTMLPart::overURL): Ditto. (KHTMLPart::urlSelected): Ditto. (KHTMLPart::requestFrame): Ditto. (KHTMLPart::slotChildURLRequest): Ditto.

WebKit:

  • improved the code that manages observing the window and superview
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView addSuperviewObservers]): Added. (-[WebHTMLView removeSuperviewObservers]): Added. (-[WebHTMLView addWindowObservers]): Added. (-[WebHTMLView removeWindowObservers]): Added. (-[WebHTMLView viewWillMoveToSuperview:]): Call removeSuperviewObservers. (-[WebHTMLView viewDidMoveToSuperview]): Call addSuperviewObservers. (-[WebHTMLView viewWillMoveToWindow:]): Call removeWindowObservers and removeSuperviewObservers. (-[WebHTMLView viewDidMoveToWindow]): Call addWindowObservers and addSuperviewObservers.

WebBrowser:

  • fixed 3083043 -- Alex doesn't decode % sequences in javascript: URLs
  • BrowserWebBookmarkExtras.m: (-[WebBookmark _goToWithWindowPolicy:]): Call CFURLCreateStringByReplacingPercentEscapes on the URL fragment before passing it to stringByEvaluatingJavaScriptFromString:.
  • BrowserWindowController.m: (-[BrowserWindowController goToToolbarLocation:]): Ditto.
  • fixed world leaks seen when playing with the snippet window
  • Debug/SnippetController.m: (-[SnippetController dealloc]): Release the location change delegate to avoid a leak. Also release the data source now that we retain it. (-[SnippetController windowWillClose:]): Release everything here. If we don't we get a world leak. Also remove the WebView from the superview. If we don't, it leaks. At some point we should look into this because it may indicate a WebKit problem, so I marked it with a FIXME. (-[SnippetController load]): Retain the data source. (-[SnippetController loadComplete]): Release the old text storage.
  • Debug/SnippetController.h: Tweaks.

Nov 11, 2002:

11:17 PM Changeset in webkit [2630] by mjs
  • 19 edits in trunk/WebKit

WebKit:

Remove contentPolicy parameter from _downloadURL, and remove
remaining traces of path from policy object.

  • WebView.subproj/WebControllerPolicyDelegate.h:
  • WebView.subproj/WebControllerPolicyDelegate.m: (-[WebPolicyPrivate dealloc]): (+[WebURLPolicy webPolicyWithURLAction:]): (+[WebFileURLPolicy webPolicyWithFileAction:]): (+[WebContentPolicy webPolicyWithContentAction:]): (+[WebClickPolicy webPolicyWithClickAction:]):
  • WebView.subproj/WebControllerPolicyDelegatePrivate.h:
  • WebView.subproj/WebControllerPrivate.h:
  • WebView.subproj/WebControllerPrivate.m: (-[WebController _downloadURL:]):
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate downloadURL:]):
  • WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate clickPolicyForAction:andRequest:inFrame:]):
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueAfterClickPolicyForEvent:request:]):
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
  • WebView.subproj/WebImageView.m: (-[WebImageView namesOfPromisedFilesDroppedAtDestination:]):
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveResponse:]):

WebBrowser:

Don't pass path when making policy objects.

  • BrowserWebController.m: (-[BrowserWebController contentPolicyForResponse:andRequest:inFrame:]): (-[BrowserWebController clickPolicyForAction:andRequest:inFrame:]):
10:33 PM Changeset in webkit [2629] by darin
  • 8 edits in trunk

WebFoundation:

  • English.lproj/StringsNotToBeLocalized.txt: Update.

WebCore:

  • kwq/KWQWidget.mm: (QWidget::setCursor): Remove printf I left in by accident.

WebKit:

  • Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): Use fileSystemRepresentationWithPath, not cString, to turn a path into something to pass to FSPathMakeRef.
  • English.lproj/StringsNotToBeLocalized.txt: Update.

WebBrowser:

  • BrowserNSStringExtras.m: (-[NSString compareVersionString:]): Use lossyCString so we don't get an exception if a string is bad.
  • English.lproj/StringsNotToBeLocalized.txt: Update.
6:06 PM Changeset in webkit [2628] by darin
  • 11 edits in trunk

WebCore:

  • tighten up cursor handling a bit more
  • kwq/KWQWidget.mm: (QWidget::setCursor): Use setDocumentCursor: instead of our own protocol. (QWidget::cursor): Use documentCursor instead of storing our own cursor.
  • kwq/WebCoreFrameView.h: Remove setCursor: method.

WebKit:

  • tighten up cursor handling a bit more
  • WebView.subproj/WebDynamicScrollBarsView.m:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView addMouseMovedObserver]): Call _frameOrBoundsChanged so we emit a mouse moved event right away. (-[WebHTMLView viewWillMoveToSuperview:]): Remove the colon since I removed the parameter from _frameOrBoundsChanged.
  • WebView.subproj/WebHTMLViewPrivate.h: Declare _frameOrBoundsChanged.
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _frameOrBoundsChanged]): Remove parameter.
5:47 PM Changeset in webkit [2627] by darin
  • 7 edits in trunk/WebCore
  • fixed 3084704 -- crash in HTMLTokenizer on page with JavaScript HTMLDocument::Close inside a <script>

I think it's going to work this time. The key was to hook up the
KHTML submitFormAgain machinery.

  • khtml/khtml_part.cpp: (KHTMLPart::submitForm): Take out the APPLE_CHANGES ifdef that was disabling the submitFormAgain logic.
  • kwq/KWQKHTMLPart.h: Remove submitForm(), because openURLRequest() handles it fine.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURLRequest): Move the logic for handling POST here from submitForm() and remove submitForm().
  • kwq/KWQSlot.mm: (KWQSlot::KWQSlot): Add support for the submitFormAgain slot. (KWQSlot::call): Ditto.
11:27 AM Changeset in webkit [2626] by trey
  • 3 edits in trunk/WebKit

Fixed 3015884 - Reloading a page should remember the scroll position

  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]): Save scroll position on reload (-[WebFrame _isLoadComplete]): Restore position on reload
11:04 AM Changeset in webkit [2625] by darin
  • 8 edits
    2 adds in trunk/WebCore
  • fixed 3092421 -- javascript: URL that opens window crashes Alex if typed into empty window
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): Set _ownsView to false. (KWQKHTMLPart::~KWQKHTMLPart): Delete the view if we own it. Also release _currentEvent to fix a leak. (KWQKHTMLPart::setView): Delete the old view if we own it. Also, set the _ownsView flag. (KWQKHTMLPart::createDummyDocument): Create a dummy view too.
  • kwq/KWQDummyView.h: Added.
  • kwq/KWQDummyView.m: Added.
  • WebCore.pbproj/project.pbxproj: Added KWQDummyView.
  • kwq/WebCoreBridge.h: Remove bridgeOwnsKHTMLView and currentEvent.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge createKHTMLViewWithNSView:marginWidth:marginHeight:]): Pass true to setView instead of setting bridgeOwnsKHTMLView. (-[WebCoreBridge removeFromFrame]): Just call setView on the part. It knows how to handle ownership now. (-[WebCoreBridge installInFrame:]): Call setOwnsView instead of setting bridgeOwnsKHTMLView.
10:33 AM Changeset in webkit [2624] by trey
  • 21 edits in trunk

First checkin of making frames work with the back forward list, restoring scroll position and form state. Fixing:

3014555 Lose frameset context going back/forward
3078151 History inconsistency after loading frame content
3089551 REGRESSION: www.bmwusa.com frames don't load in alex-30
3095878 refresh doesn't preserve frame state

WebCore:

  • khtml/khtml_part.cpp: (KHTMLPart::requestFrameName): Call through bridge to get generated frame name.
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::generateFrameName): New call that just forwards through the bridge.
  • kwq/WebCoreBridge.h:

WebKit:

  • History.subproj/WebBackForwardList.m: (-[WebBackForwardList addEntry:]): Yank code to avoid adding a duplicate entry, to catch the refresh case. That's dealt with in WebFramePrivate now. (-[WebBackForwardList description]): Enhanced to print more info.
  • History.subproj/WebHistoryItem.h: History items now hold an array of subitems to mirror the frame tree. One item in the tree is designated the target of the navigation.
  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem dealloc]): Release new ivars. (-[WebHistoryItem isTargetItem]): (-[WebHistoryItem setIsTargetItem:]): New setter and setter. (-[WebHistoryItem _recurseToFindTargetItem]): (-[WebHistoryItem targetItem]): Search the tree to find the target item. (-[WebHistoryItem children]): (-[WebHistoryItem addChildItem:]): (-[WebHistoryItem childItemWithName:]): Maintain and search new child item list. (-[WebHistoryItem description]): Enhanced to print out the tree of items. (-[WebHistoryItem dictionaryRepresentation]): (-[WebHistoryItem initFromDictionaryRepresentation:]): Save and load the new state.
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge generateFrameName]): New call from KWQ, just forwards to Frame. (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): Call new frame method dedicated to this case. (-[WebBridge saveDocumentState:]): (-[WebBridge documentState]): Call frame methods to get the right item to save/restore to/from.
  • WebView.subproj/WebController.m: (-[WebController _goToItem:withLoadType:]): Stop any current loading before going to a new item. (-[WebController goBack]): (-[WebController goForward]): (-[WebController goBackOrForwardToItem:]): Name change of private method (for consistency)
  • WebView.subproj/WebDataSourcePrivate.h: ProvisionalItem and PreviousItem are moved back up to WebFrame, where we know more about the state transitions that happen during loading.
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): Don't release removed ivars. (-[WebDataSource _commitIfReady]): Make the view representations -after- the transition to committed. This allows us to save away the scroll location successfully, since making the view was resetting it.
  • WebView.subproj/WebFrame.h:
  • WebView.subproj/WebFrame.m: (-[WebFrame setProvisionalDataSource:]): Saving the scroll location has moved elsewhere to handle frames. (-[WebFrame stopLoading]): Skip all the work if we're already state=complete.
  • WebView.subproj/WebFramePrivate.h: The frame now holds a ref to the current, previous and provisional back-forward items.
  • WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate dealloc]): Release new state. (-[WebFramePrivate setProvisionalItem:]): (-[WebFramePrivate setPreviousItem:]): (-[WebFramePrivate setCurrentItem:]): New setters (1 line getters were missed by script) (-[WebFrame _addBackForwardItemClippedAtTarget:]): Adds a BF item to the top of the BF list. (-[WebFrame _createItem]): Create a single BF item. (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]): Create a tree of BF items, which mirror the frame tree. (-[WebFrame _immediateChildFrameNamed:]): New frame search utility (doesn't recurse) (-[WebFrame _detachFromParent]): Save the scroll position when detaching a frame. (-[WebFrame _transitionToCommitted]): Maintain new item ivars. Save scroll position when appropriate. Hook up items for child frames to their parent, as they are created. (-[WebFrame _setState:]): Clear previousItem whenever we reach committed. (-[WebFrame _isLoadComplete]): Clear previousItem if we are committed. (-[WebFrame _childFramesMatchItem:]): Does the frame's frame tree match the one held by the item? (-[WebFrame _loadItem:fromItem:withLoadType:]): Only do simple anchor navigation if the frame has no children (fixes oddball corner case with a frame reloading itself). Set provisional item. (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]): Heart of returning to an item that had frames. We either find that the existing content is good, or initiate a load. (-[WebFrame _goToItem:withLoadType:]): Adjust the BF list cursor, and recurse to do the work. (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:]): Only do anchor-style nav if the destination URL has a fragment. Save scroll position. (-[WebFrame _loadURL:intoChild:]): If returning to an item with frames, possibly replace the new content with the stuff that was there at the time, substituting the URL. (-[WebFrame _saveScrollPositionToItem:]): Don't croak on nil item or view. (-[WebFrame _restoreScrollPosition]): Do croak (ASSERT) on nil item. (-[WebFrame _scrollToTop]): Nit cleanup. (-[WebFrame _addFramePathToString:]): Add a component for our frame to the frame name we're generating. (-[WebFrame _generateFrameName]): Generate a frame name that is repeatable. (-[WebFrame _itemForSavingDocState]): Returns correct item to use for formstate save. (-[WebFrame _itemForRestoringDocState]): Returns correct item to use for formstate restore

WebBrowser:

  • BrowserDocument.m: (-[BrowserDocument _addItem:toMenu:]): For a back-forward item that's a tree because its for a frameset, use the right item of the tree to generate the menu contents.
7:01 AM Changeset in webkit [2623] by mjs
  • 12 edits in trunk/WebKit

WebKit:

Store path and the fact that we're downloading in the data source,
instead of storing the content policy.

  • Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler cleanUpAfterFailure]): (-[WebDownloadHandler createFileIfNecessary]): (-[WebDownloadHandler finishedLoading]):
  • WebView.subproj/WebControllerPrivate.m: (-[WebController _downloadURL:withContentPolicy:]):
  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSource.m: (+[WebDataSource registerRepresentationClass:forMIMEType:]): (-[WebDataSource isDownloading]): (-[WebDataSource downloadPath]):
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _commitIfReady]): (-[WebDataSource _setIsDownloading:]): (-[WebDataSource _setDownloadPath:]):
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedError:]): (-[WebMainResourceClient handle:didReceiveResponse:]): (-[WebMainResourceClient handleDidFinishLoading:]):

WebBrowser:

Adjusted for WebKit API changes.

  • DownloadProgressEntry.m: (+[DownloadProgressEntry entryWithDataSource:]): (-[DownloadProgressEntry path]):
4:49 AM Changeset in webkit [2622] by mjs
  • 8 edits in trunk/WebKit

WebKit:

Don't ask for the content policy any more if the previous policies
said to save - in effect this means to ask only if the previous
policies said to use the content policy. Also, remove now-useless
previous content policy parameter from content policy delegate.

  • WebView.subproj/WebControllerPolicyDelegate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setContentPolicy:]): Retain new policy before releasing the old one.
  • WebView.subproj/WebDefaultPolicyDelegate.m:
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveResponse:]): Don't ask for content policy if the delegate already decided to save.

WebBrowser:

Adjusted for WebKit API change.

  • BrowserWebController.m: (-[BrowserWebController contentPolicyForResponse:andRequest:inFrame:]):
1:29 AM Changeset in webkit [2621] by mjs
  • 7 edits in trunk/WebKit

WebKit:

Added new policy delegate callback to get the filename - this
won't be up to the content policy any more.

  • WebView.subproj/WebControllerPolicyDelegate.h:
  • WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate saveFilenameForResponse:andRequest:]):
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveResponse:]):

WebBrowser:

Added new policy delegate callback to get the filename - this
won't be up to the content policy any more.

  • BrowserWebController.m: (-[BrowserWebController contentPolicyForResponse:andRequest:inFrame:withContentPolicy:]): (-[BrowserWebController saveFilenameForResponse:andRequest:]):
12:46 AM Changeset in webkit [2620] by darin
  • 4 edits in trunk/WebCore
  • fixed 3097253 -- text tagged <small> inside <h1> is too small
  • khtml/css/html4.css: Change BIG to use "font-size: larger" rather than "font-size: large" and SMALL to use "font-size: smaller" rather than "font-size: small".
12:31 AM Changeset in webkit [2619] by darin
  • 15 edits in trunk

WebCore:

  • kwq/WebCoreBridge.h: Remove unused modifierTrackingEnabled method.

WebKit:

  • made some improvements to cursor setting for greater speed and correctness
  • WebView.subproj/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView setCursor:]): Just use setDocumentCursor: instead of our own logic. This allows us to remove code and may fix some bugs or anomalies as well. (-[WebDynamicScrollBarsView dealloc]): Release the cursor. I think we were leaking before.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView viewWillMoveToSuperview:]): Use _frameOrBoundsChanged: method now, which has been moved into the private file. (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Don't bother finding topmost WebHTMLView to call _updateMouseoverWithEvent: on; now it works fine no matter which level it's called at.
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _frameOrBoundsChanged:]): Moved the code here that was formerly in the _setNeedsLayoutIfSizeChanged method, also added code that does _updateMouseoverWithEvent: so that we get properly updated cursor when we scroll. (-[WebHTMLView _updateMouseoverWithEvent:]): Remove unneeded assert. This method works equally well no matter which WebHTMLView calls it; everything is done at the window and controller level.
  • WebView.subproj/WebControllerPrivate.h: Added lastElementWasNotNil field and _mouseDidMoveOverElement:modifierFlags: method.
  • WebView.subproj/WebControllerPrivate.m: (-[WebController _mouseDidMoveOverElement:modifierFlags:]): Call through to the delegate, but don't do multiple calls if they are all nil.
  • WebCoreSupport.subproj/WebBridge.m: Remove unused modifierTrackingEnabled method.
  • WebView.subproj/WebHTMLViewPrivate.h: Remove unused _setModifierTrackingEnabled and _modifierTrackingEnabled methods.

WebBrowser:

  • AppController.m: (-[AppController awakeFromNib]): Remove unneeded call to set unused modifierTrackingEnabled flag. The code that used to care about this flag is now in WebBrowser and there's no need to inform WebCore and WebKit about whether we are passing in flags-changed events.

Nov 10, 2002:

10:36 PM Changeset in webkit [2618] by darin
  • 3 edits in trunk/WebKit

WebFoundation:

  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

WebKit:

  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

WebBrowser:

  • BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]): Add call to _setAutoreleaseDuringLiveResize: so we can live with a smaller footprint when running under SUJagGreen or newer.
  • Preferences.subproj/DefaultBrowserController.m: (keyValuesMatch): Fix comparison of nils. (-[DefaultBrowserController handleApplicationPopUp:withSheetDidEndSelector:]): Fix typo in localization comment.
  • English.lproj/Localizable.strings: Update.
  • English.lproj/StringsNotToBeLocalized.txt: Update.
  • TextFieldWithControls.m: (-[TextFieldWithControls selectText:]): Add a comment explaining Chris's bug fix.
2:33 PM Changeset in webkit [2617] by cblu
  • 5 edits in trunk/WebKit

WebFoundation:

Made WebCacheObject and WebResourceResponse methods that refer to specific dates set and return NSDates rather than NSTimeIntervals. Our public methods now only use NSTimeIntervals when referring to differences in time. Made the methods that use NSTimeIntervals when referring to specific dates private.

  • CacheLoader.subproj/WebCacheObject.h:
  • CacheLoader.subproj/WebCacheObject.m: (-[WebCacheObject createdDate]): (-[WebCacheObject setCreatedDate:]): (-[WebCacheObject expiresDate]): (-[WebCacheObject setExpiresDate:]): (-[WebCacheObject lastModifiedDate]): (-[WebCacheObject setLastModifiedDate:]): (-[WebCacheObject maxAgeValue]): (-[WebCacheObject isExpired]): (-[WebCacheObject age]): (-[WebCacheObject freshnessLifetime]): (-[WebCacheObject dealloc]): (-[WebCacheObject _createdTime]): (-[WebCacheObject _setCreatedTime:]): (-[WebCacheObject _expiresTime]): (-[WebCacheObject _setExpiresTime:]): (-[WebCacheObject _lastModifiedTime]): (-[WebCacheObject _setLastModifiedTime:]):
  • CacheLoader.subproj/WebCacheObjectPrivate.h: Added.
  • CacheLoader.subproj/WebResourceResponse.h:
  • CacheLoader.subproj/WebResourceResponse.m: (-[WebResourceResponse createdDate]): (-[WebResourceResponse lastModifiedDate]): (-[WebResourceResponse _createdTime]): (-[WebResourceResponse _lastModifiedTime]): (-[WebResourceResponse _takePersistentValuesFrom:]):
  • CacheLoader.subproj/WebResourceResponsePrivate.h:
  • ProtocolHandlers.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler addIfModifiedSinceHeader:]): (-[WebCFNetworkHTTPProtocolHandler continueHeaderReadAfter3xxResponseAndCall:]):
  • ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler willCacheObject:]):
  • ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebSimpleHTTPProtocolHandler _createHTTPRequest]): (-[WebSimpleHTTPProtocolHandler _examineHeaders]):
  • WebFoundation.pbproj/project.pbxproj:

WebKit:

Fixed: 3021681 - downloaded files' creation and modification dates are not set

  • Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler createFileIfNecessary]): call [response creationDate] and [response lastModifiedDate] when setting file attributes.
  • Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream setResponse:]): call [response lastModifiedDate] when giving content to plug-ins.

WebBrowser:

Possible fix for: 3096071 - Button under "Proxy settings" in preferences window needs implementation

With the new Network Pref root, the proxy button seems to work %50 of the time. 3096071 may be fixed if the current problem is just a bug in the network pref.

  • Preferences.subproj/GeneralPreferences.m: (-[GeneralPreferences _launchNetworkPrefs]): code from Robert Ulrich (-[GeneralPreferences openProxyPreferences:]): call _launchNetworkPrefs
9:07 AM Changeset in webkit [2616] by darin
  • 3 edits in trunk/WebKit
  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

Nov 9, 2002:

3:45 PM Changeset in webkit [2615] by darin
  • 11 edits in trunk/WebKit
  • fixed 3095156 -- reproducible leak of WebDataSource due to bad URL in stylesheet
  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): Check for errors by looking at the return value from loadWithRequest: rather than making a separate call to canInitWithRequest.
  • WebView.subproj/WebBaseResourceHandleDelegate.h: Add boolean success/failure result loadWithRequest:.
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate loadWithRequest:]): Return NO if we fail to make a handle.
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading]): Check result of loadWithRequest: and complain if it's NO.
  • WebView.subproj/WebMainResourceClient.m: Tweak whitespace.
12:59 PM Changeset in webkit [2614] by cblu
  • 6 edits in trunk/WebKit

WebKit:

Fixed: 2991610 - Alexander should support services, including Speech

  • WebView.subproj/WebHTMLView.m: (+[WebHTMLView initialize]): register for service types (-[WebHTMLView dealloc]): moved to top of file (-[WebHTMLView copy:]): call _writeSelectionToPasteboard (-[WebHTMLView writeSelectionToPasteboard:types:]): call _writeSelectionToPasteboard (-[WebHTMLView validRequestorForSendType:returnType:]): return self for our pboard types
  • WebView.subproj/WebHTMLViewPrivate.h:
  • WebView.subproj/WebHTMLViewPrivate.m: (+[WebHTMLView _pasteboardTypes]): new, returns the array of supported pboard types (-[WebHTMLView _writeSelectionToPasteboard:]): new, adds data to pboard
  • WebView.subproj/WebImageView.m: (-[WebImageView initialize]): register for service types (-[WebImageView validateUserInterfaceItem:]): respond to copy (-[WebImageView validRequestorForSendType:returnType:]): return self for images (-[WebImageView writeImageToPasteboard:]): writes image data to pboard (-[WebImageView copy:]): calls writeImageToPasteboard (-[WebImageView writeSelectionToPasteboard:types:]): calls writeImageToPasteboard

WebBrowser:

Open the URL in a new window as we do for other externally opened URLs.

  • ServicesProvider.m: (-[ServicesProvider openURL:userData:error:]):
Note: See TracTimeline for information about the timeline view.