Context Navigation

khtml/khtml_part.cpp: (firstRunAt): (lastRunAt): (startAndEndLineNodesIncludingNode):
khtml/rendering/bidi.cpp: (RenderBlock::layoutInlineChildren):
khtml/rendering/render_text.cpp: (TextRun::detach): (throw): (TextRun::operator delete): (TextRun::paintSelection): (TextRun::paintDecoration): (TextRun::paintBoxDecorations): (TextRun::checkSelectionPoint): (TextRunArray::TextRunArray): (TextRunArray::compareItems): (TextRunArray::findFirstMatching): (RenderText::detach): (RenderText::deleteRuns): (RenderText::findTextRun): (RenderText::nodeAtPoint): (RenderText::checkSelectionPoint): (RenderText::cursorPos): (RenderText::posOfChar): (RenderText::paintObject): (RenderText::position): (RenderText::width):
khtml/rendering/render_text.h:
kwq/KWQRenderTreeDebug.cpp: (writeTextRun): (write):

3:19 PM Changeset in webkit [3549] by hyatt

3 edits in trunk/WebCore

Fix for assertion on nasdaq.com. Patch containingBlock
to return 0 when it can't find a containingBlock at all (e.g.,
when the object is orphaned).

Patch setOverhangingContents to deal with a null containingBlock
caused by it being called from RenderImage::setStyle().

The bug # is 3162989.

Reviewed by NOBODY (OOPS!).

khtml/rendering/render_object.cpp: (RenderObject::containingBlock): (RenderObject::setOverhangingContents):

2:48 PM Changeset in webkit [3548] by hyatt

15 edits in trunk/WebCore

Enable support for the "run-in" and "compact" display types.

Also implementing support for :before and :after (they were not even
remotely working before these fixes).

Made sure :first-letter drills into inline children to find the
first letter in a block, e.g., so :before content can be used in
conjunction with :first-letter.

Fixed a regression in addOverhangingFloats that broke meyerweb.com's
front page.

Patched findNextLineBreak to correctly handle words that cross
inline boundaries and white-space mixtures. We now pass Hixie's
insanely evil mixed white-space test (we are the only browser
to do so).

Reviewed by kocienda

ChangeLog:
khtml/css/cssstyleselector.cpp:
khtml/rendering/bidi.cpp: (RenderBlock::findNextLineBreak):
khtml/rendering/render_block.cpp: (RenderBlock::setStyle): (RenderBlock::addChildToFlow): (getInlineRun): (RenderBlock::layoutBlockChildren): (RenderBlock::paintObject): (RenderBlock::clearFloats):
khtml/rendering/render_box.cpp: (RenderBox::calcWidthUsing):
khtml/rendering/render_box.h:
khtml/rendering/render_container.cpp: (RenderContainer::insertPseudoChild):
khtml/rendering/render_container.h:
khtml/rendering/render_flow.cpp: (RenderFlow::addChild):
khtml/rendering/render_image.cpp: (RenderImage::setStyle):
khtml/rendering/render_inline.cpp: (RenderInline::setStyle): (RenderInline::addChildToFlow):
khtml/rendering/render_object.cpp: (RenderObject::createObject):
khtml/rendering/render_object.h:
khtml/rendering/render_style.cpp: (RenderStyle::addPseudoStyle):

12:09 PM Changeset in webkit [3547] by rjw

2 edits in trunk/WebKit

Fixed headerdoc type.

Reviewed by me.

WebView.subproj/WebDocument.h:

11:57 AM Changeset in webkit [3546] by rjw

18 edits in trunk/WebKit

WebKit:

Support for new canProvideDocumentSource and documentSource API.
Updated all the representations. Added support to show for RTF source.
Moved WebKitInitializeUnicode to to early class. This was necessary
because WebCore may use the unicode property functions before WebTextRenderer
gets initialized.
Ensured guarantee that identifierForInitialRequest:fromDataSource: is called with
the first initial request.

Reviewed by maciej.

Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation canProvideDocumentSource]): (-[WebNetscapePluginRepresentation documentSource]):
WebCoreSupport.subproj/WebTextRenderer.m:
WebView.subproj/WebBaseResourceHandleDelegate.h:
WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate setIdentifier:]):
WebView.subproj/WebDataSource.h:
WebView.subproj/WebDataSource.m: (-[WebDataSource initWithRequest:]): (-[WebDataSource controller]): (-[WebDataSource initialRequest]):
WebView.subproj/WebDataSourcePrivate.h:
WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _startLoading:]): (-[WebDataSource _originalRequest]):
WebView.subproj/WebDocument.h:
WebView.subproj/WebHTMLRepresentation.h:
WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): (-[WebHTMLRepresentation canProvideDocumentSource]):
WebView.subproj/WebHTMLView.m: (+[WebHTMLView initialize]):
WebView.subproj/WebImageRepresentation.m: (-[WebImageRepresentation canProvideDocumentSource]): (-[WebImageRepresentation documentSource]):
WebView.subproj/WebTextRepresentation.h:
WebView.subproj/WebTextRepresentation.m: (-[WebTextRepresentation dealloc]): (-[WebTextRepresentation setDataSource:]): (-[WebTextRepresentation finishedLoadingWithDataSource:]): (-[WebTextRepresentation canProvideDocumentSource]): (-[WebTextRepresentation documentSource]):

WebBrowser:

Make us of new canProvideDocumentSource API, replacing somewhat
klunky usage of isDocumentHTML.

Reviewed by maciej.

BrowserDocument.m: (-[BrowserDocument validateUserInterfaceItem:]): (-[BrowserDocument source]):
ContextMenuHandler.m: (-[ContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]):
HTMLSourceDocument.m: (-[HTMLSourceDocument makeWindowControllers]): (-[HTMLSourceDocument setDataSource:]):

11:28 AM Changeset in webkit [3545] by cblu

3 edits in trunk/WebKit

Fixed: 3163073 - SECURITY: Need to check if filename in encoded download is safe

Reviewed by kocienda, darin, mjs.

Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler createFileIfNecessary]): call _web_filenameByFixingIllegalCharacters on the encoded filename

10:41 AM Changeset in webkit [3544]

16 copies
1 delete in tags/Safari-57

This commit was manufactured by cvs2svn to create tag 'Safari-57'.

10:41 AM Changeset in webkit [3543] by sheridan

8 edits in branches/Safari-0-8-2-branch

Safari-57 versionstamp

9:38 AM Changeset in webkit [3542] by darin

3 edits in branches/Safari-0-8-2-branch/WebCore

Rolled over changes from the main trunk.

2003-01-30 Trey Matteson <trey@apple.com>

3161486 - REGRESSION: double click on a widget causes crash

Slight enhancement to the earlier fix of this bug. When handling a doubleclick we
don't want to try to pass the current event down the Cocoa widgets, because Cocoa
has no double-click event, and we just end up resending one we already sent.

The upshot is that we do not pass an extra mouseup event to the widgets at the
end of a double click sequence.

Reviewed by Darin.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWidgetMouseDownEventToWidget): Do not pass event down to the widget for doubleclick events.

9:02 AM Changeset in webkit [3541] by darin

9 edits in trunk/WebCore

Reviewed by Maciej.

fixed 3146862 -- meta http-equiv refresh with a space before the delay does not work

khtml/xml/dom_docimpl.cpp: (DocumentImpl::processHttpEquiv): Fix code that was trying to use positions within the whitespace-stripped string, but extracting substrings from the non-stripped original.

tweaks to render tree dumping format

khtml/rendering/render_block.h: Make renderName not be inline, since an inline virtual function doesn't really do any good.
khtml/rendering/render_block.cpp: (RenderBlock::renderName): Use the string RenderBlock instead of the string Block for consistency with all the other renderName results.

khtml/rendering/render_inline.h: Make renderName not be inline, since an inline virtual function doesn't really do any good.
khtml/rendering/render_inline.cpp: (RenderInline::renderName): Use the string RenderInline instead of the string Inline for consistency with all the other renderName results.

khtml/rendering/render_text.h: Make textSlaves() a const member function.
kwq/KWQRenderTreeDebug.cpp: (operator<<): Format rectangles as "x at (1,2) size 3x4" rather than "(1,2,3,4)". (quoteAndEscapeNonPrintables): Added. Makes it easy to turn an arbitrary Unicode string into something that's all ASCII. (writeTextSlave): Change this so it also writes out the text. (write): Call the new writeTextSlave, and also use "layer" instead of "RenderLayer".

Feb 1, 2003:

5:29 PM Changeset in webkit [3540] by darin

3 edits in trunk/WebCore

fix mistake that broke build

khtml/rendering/render_block.h: Add include of <qsortedlist.h>.

5:02 PM Changeset in webkit [3539] by mjs

3 edits in trunk/WebKit

Reviewed by Darin and Ken.

fixed 3162581 - 56 debug: Assertion failure displaying pop-up menu while downloading

WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveResponse:]): No need to assert that the controller is not deferred if this is a handle being used for a download. (-[WebMainResourceClient handle:didReceiveData:]): Likewise. (-[WebMainResourceClient handleDidFinishLoading:]): Likewise. (-[WebMainResourceClient handle:didFailLoadingWithError:]): Likewise.

4:51 PM Changeset in webkit [3538] by darin

12 edits in trunk/WebCore

Reviewed by Dave.

reduced the amount of RenderFlow in the world by about 1/2

khtml/rendering/bidi.h: Take RenderBlock * instead of RenderFlow *.
khtml/rendering/bidi.cpp: (BidiIterator::BidiIterator): Take RenderBlock * instead of RenderFlow *. (RenderBlock::layoutInlineChildren): Fix debug message to say RenderBlock instead of RenderFlow. (RenderBlock::findNextLineBreak): Fix debug message to say RenderBlock instead of RenderFlow.

khtml/rendering/render_block.cpp: (RenderBlock::addChildToFlow): Make RenderBlock * instead of RenderFlow *. (RenderBlock::layout): Fix debug message to say RenderBlock instead of RenderFlow. (RenderBlock::layoutBlockChildren): Fix debug message to say RenderBlock instead of RenderFlow. (RenderBlock::clearFloats): Fix debug message to say RenderBlock instead of RenderFlow.

khtml/rendering/render_flow.h: Return a RenderFlow * instead of a RenderObject * from createFlow.
khtml/rendering/render_flow.cpp: (RenderFlow::createFlow): Use an if statement instead of ? : to get rid of typecasting.

khtml/rendering/render_html.cpp: (RenderHtml::containingBlockWidth): Fix parent call to call RenderBlock. Calling RenderFlow was a mistake, but one that didn't matter since the actual method isn't implemented until up in RenderBox anyway.

khtml/rendering/render_inline.h: Change some parameters to RenderBlock *.
khtml/rendering/render_inline.cpp: (cloneInline): Make this return a RenderInline * instead of a RenderFlow *. (RenderInline::splitInlines): Change some parameters to RenderBlock * and locals to RenderInline *. (RenderInline::splitFlow): Change some parameters and locals to RenderBlock *.

khtml/rendering/render_layer.h: Remove forward declaration of class RenderFlow.
khtml/rendering/render_object.h: Remove forward declaration and friend declaration of class RenderFlow.

1:39 PM Changeset in webkit [3537] by trey

12 edits
2 adds in trunk

WebCore:

New plumbing for autofill/autocomplete. WebBrowser receives controlText delegate
messages from our form widgets. Should result in no behavior change.

New SPI is exposed over the bridge and KWQTextField passes the text delegate msgs to it.

Reviewed by Richard

kwq/KWQTextField.mm: Pass text delegate msgs through new SPI. (-[KWQTextField controlTextDidBeginEditing:]): (-[KWQTextField controlTextDidEndEditing:]): (-[KWQTextField controlTextDidChange:]): (-[KWQTextField control:textShouldBeginEditing:]): (-[KWQTextField control:textShouldEndEditing:]): (-[KWQTextField control:didFailToFormatString:errorDescription:]): (-[KWQTextField control:didFailToValidatePartialString:errorDescription:]): (-[KWQTextField control:isValidObject:]): (-[KWQTextField control:textView:doCommandBySelector:]):
kwq/WebCoreBridge.h: New SPI for passing text delegate msgs.

WebKit:

New plumbing for autofill/autocomplete. WebBrowser receives controlText delegate
messages from our form widgets. Should result in no behavior change.

New private API is exposed for the app to set a WebFormDelegate.

Reviewed by Richard

WebCoreSupport.subproj/WebBridge.m: Pass msgs from WC on to the controller's FormDelegate. (formDelegate): Little utility function. (-[WebBridge controlTextDidBeginEditing:]): (-[WebBridge controlTextDidEndEditing:]): (-[WebBridge controlTextDidChange:]): (-[WebBridge control:textShouldBeginEditing:]): (-[WebBridge control:textShouldEndEditing:]): (-[WebBridge control:didFailToFormatString:errorDescription:]): (-[WebBridge control:didFailToValidatePartialString:errorDescription:]): (-[WebBridge control:isValidObject:]): (-[WebBridge control:textView:doCommandBySelector:]):
WebKit.exp: New class exported.
WebKit.pbproj/project.pbxproj: New WebFormDelegate files.
WebView.subproj/WebControllerPrivate.h: API to set/get FormDelegate.
WebView.subproj/WebControllerPrivate.m: (-[WebController _setFormDelegate:]): simple setter (-[WebController _formDelegate]): simple getter
WebView.subproj/WebFormDelegate.h: Added.
WebView.subproj/WebFormDelegate.m: Added. NOP impls for all these delegate methods. (-[WebFormDelegate controlTextDidBeginEditing:inFrame:]): (-[WebFormDelegate controlTextDidEndEditing:inFrame:]): (-[WebFormDelegate controlTextDidChange:inFrame:]): (-[WebFormDelegate control:textShouldBeginEditing:inFrame:]): (-[WebFormDelegate control:textShouldEndEditing:inFrame:]): (-[WebFormDelegate control:didFailToFormatString:errorDescription:inFrame:]): (-[WebFormDelegate control:didFailToValidatePartialString:errorDescription:inFrame:]): (-[WebFormDelegate control:isValidObject:inFrame:]): (-[WebFormDelegate control:textView:doCommandBySelector:inFrame:]):

WebBrowser:

New plumbing for autofill/autocomplete. WebBrowser receives controlText delegate
messages from our form widgets. Should result in no behavior change.

This is mostly using new API, with a couple autocomplete fixes for newly exposed issues.

Reviewed by Richard

BrowserWindowController.h: New formDelegate ivar.
BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]): Create FormDelegate, an internal helper object to field WebFormDelegate messages. (-[BrowserWindowController dealloc]): Release FormDelegate. (-[BrowserWindowController controlTextDidEndEditing:]): Pass msg on to completion controller. (-[FormDelegate initWithController:]): Create CompletionController to do autocomplete (commented out for now). (-[FormDelegate controlTextDidBeginEditing:inFrame:]): Pass msg on to completion controller. (-[FormDelegate controlTextDidEndEditing:inFrame:]): Pass msg on to completion controller. (-[FormDelegate controlTextDidChange:inFrame:]): Pass msg on to completion controller. (-[FormDelegate control:textView:doCommandBySelector:inFrame:]): Pass msg on to completion controller.
CompletionController.h: Added controlTextDidBeginEditing: Should have been receiving this all along.
CompletionController.m: (-[CompletionController _buildUI]): Set TableView font to match the textfield. (-[CompletionController _positionWindow]): Position window relative to TextField, not enclosing ScrollView (bogus code that's a NOP for the locationField). (-[CompletionController controlTextDidEndEditing:]): Hide the completion window when we leave the field.

Jan 31, 2003:

6:30 PM Changeset in webkit [3536] by hyatt

3 edits in trunk/WebCore

Fix regression that broke John's site. RenderInline needs
to implement childrenInline() so that it can return true.
I pulled this method out of RenderFlow and into RenderBlock,
which caused RenderInline to use RenderObject's method (and
that one returns false).

Reviewed by rjw

khtml/rendering/render_inline.h:

5:44 PM Changeset in webkit [3535] by hyatt

3 edits in trunk/WebCore

Fix for crash on espn.com. Revert my change to make
containingBlock() return 0 for the root. Put it back to the
old behavior, where the root returns itself when you ask for
the root's containing block.

Reviewed by rjw

khtml/rendering/render_object.cpp: (RenderObject::containingBlock): (RenderObject::setOverhangingContents):

5:13 PM Changeset in webkit [3534] by hyatt

3 edits in trunk/WebCore

Two whitespace handling fixes that improve <pre> handling,
especially of inline pres.

Reviewed by rjw.

khtml/rendering/bidi.cpp: (RenderBlock::findNextLineBreak):

4:31 PM Changeset in webkit [3533]

15 copies
1 delete in tags/Safari-56

This commit was manufactured by cvs2svn to create tag 'Safari-56'.

4:31 PM Changeset in webkit [3532] by sheridan

8 edits in branches/Safari-0-8-2-branch

Safari-56 version stamp

3:14 PM Changeset in webkit [3531] by darin

3 edits in branches/Safari-0-8-2-branch/WebCore

Rolled over changes from the main trunk.

2003-01-31 Darin Adler <Darin Adler>

Reviewed by Richard.

khtml/misc/decoder.cpp: (Decoder::decode): Turn off Japanese auto-detect. It was causing us to use Japanese encoding on pages that were UTF-8.

3:13 PM Changeset in webkit [3530] by darin

3 edits in trunk/WebCore

Reviewed by Richard.

khtml/misc/decoder.cpp: (Decoder::decode): Turn off Japanese auto-detect. It was causing us to use Japanese encoding on pages that were UTF-8.

2:06 PM Changeset in webkit [3529] by darin

4 edits
1 delete in branches/Safari-0-8-2-branch/WebCore

Rolled over changes from the main trunk.

2003-01-31 Darin Adler <Darin Adler>

Resources/Info.plist: Removed unused file.

2003-01-31 Darin Adler <Darin Adler>

Reviewed by me, Dave wrote the code.

fixed 3162013 -- Safari collapses margins through bottom borders (affects top of zeldman.com)

khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren): Don't collapse if we have any bottom border or padding.

2003-01-31 Darin Adler <Darin Adler>

Reviewed by Dave.

fixed 3160442 -- no top image map at ebay, caused by referrer returning null instead of empty string

khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::tryGet): Return an empty string, not null, when there is no referrer.

1:47 PM Changeset in webkit [3528] by darin

2 edits
1 delete in trunk/WebCore

Resources/Info.plist: Removed unused file.

1:44 PM Changeset in webkit [3527] by hyatt

26 edits
4 adds in trunk/WebCore

Split RenderFlow into subclasses: RenderInline and RenderBlock.
This change should make inlines a lot smaller (since nearly all
of the member variables in RenderFlow moved into RenderBlock).

It also simplifies methods like containingBlock(), which can
now return a RenderBlock.

Reviewed by darin

WebCore.pbproj/project.pbxproj:
khtml/css/cssstyleselector.cpp:
khtml/rendering/bidi.cpp: (RenderBlock::bidiReorderLine): (RenderBlock::layoutInlineChildren): (RenderBlock::findNextLineBreak):
khtml/rendering/render_block.cpp: Added. (:RenderFlow): (RenderBlock::~RenderBlock): (RenderBlock::setStyle): (RenderBlock::addChildToFlow): (getInlineRun): (RenderBlock::makeChildrenNonInline): (RenderBlock::removeChild): (RenderBlock::layout): (RenderBlock::layoutBlockChildren): (RenderBlock::layoutSpecialObjects): (RenderBlock::paint): (RenderBlock::paintObject): (RenderBlock::paintFloats): (RenderBlock::insertSpecialObject): (RenderBlock::removeSpecialObject): (RenderBlock::positionNewFloats): (RenderBlock::newLine): (RenderBlock::leftOffset): (RenderBlock::leftRelOffset): (RenderBlock::rightOffset): (RenderBlock::rightRelOffset): (RenderBlock::lineWidth): (RenderBlock::nearestFloatBottom): (RenderBlock::floatBottom): (RenderBlock::lowestPosition): (RenderBlock::rightmostPosition): (RenderBlock::leftBottom): (RenderBlock::rightBottom): (RenderBlock::clearFloats): (RenderBlock::addOverHangingFloats): (RenderBlock::checkClear): (RenderBlock::nodeAtPoint): (RenderBlock::calcMinMaxWidth): (next): (RenderBlock::calcInlineMinMaxWidth): (RenderBlock::calcBlockMinMaxWidth): (RenderBlock::close): (RenderBlock::printTree): (RenderBlock::dump):
khtml/rendering/render_block.h: Added.
khtml/rendering/render_body.cpp: (RenderBody::RenderBody): (RenderBody::setStyle): (RenderBody::layout): (RenderBody::availableHeight):
khtml/rendering/render_body.h:
khtml/rendering/render_box.cpp: (RenderBox::containingBlockWidth): (RenderBox::calcWidth): (RenderBox::calcHeight):
khtml/rendering/render_container.cpp: (RenderContainer::insertPseudoChild): (RenderContainer::removeLeftoverAnonymousBoxes):
khtml/rendering/render_flow.cpp: (RenderFlow::createFlow): (RenderFlow::addChildWithContinuation):
khtml/rendering/render_flow.h:
khtml/rendering/render_form.h:
khtml/rendering/render_html.cpp: (RenderHtml::RenderHtml): (RenderHtml::setStyle): (RenderHtml::layout):
khtml/rendering/render_html.h:
khtml/rendering/render_image.h:
khtml/rendering/render_inline.cpp: Added. (:RenderFlow): (RenderInline::~RenderInline): (RenderInline::setStyle): (RenderInline::addChildToFlow): (cloneInline): (RenderInline::splitInlines): (RenderInline::splitFlow): (RenderInline::paint): (RenderInline::paintObject): (RenderInline::calcMinMaxWidth): (RenderInline::offsetWidth): (RenderInline::offsetHeight): (RenderInline::offsetLeft): (RenderInline::offsetTop):
khtml/rendering/render_inline.h: Added.
khtml/rendering/render_list.cpp: (RenderListItem::RenderListItem): (RenderListItem::setStyle): (getParentOfFirstLineBox): (RenderListItem::calcMinMaxWidth): (RenderListItem::layout): (RenderListItem::paint): (RenderListItem::paintObject):
khtml/rendering/render_list.h:
khtml/rendering/render_object.cpp: (RenderObject::createObject): (RenderObject::containingBlock): (RenderObject::setOverhangingContents): (RenderObject::removeFromSpecialObjects):
khtml/rendering/render_object.h:
khtml/rendering/render_replaced.h:
khtml/rendering/render_root.cpp: (RenderRoot::RenderRoot): (RenderRoot::calcMinMaxWidth): (RenderRoot::layout): (RenderRoot::paintObject):
khtml/rendering/render_root.h:
khtml/rendering/render_table.cpp: (RenderTable::RenderTable): (RenderTable::setStyle): (RenderTable::lineHeight): (RenderTable::baselinePosition): (RenderTable::addChild): (RenderTable::calcWidth): (RenderTable::recalcSections): (RenderTable::dump): (RenderTableCell::RenderTableCell): (RenderTableCell::detach): (RenderTableCell::calcMinMaxWidth): (RenderTableCell::close): (RenderTableCell::repaintRectangle): (RenderTableCell::absolutePosition): (RenderTableCell::setStyle): (RenderTableCell::dump):
khtml/rendering/render_table.h:
khtml/rendering/render_text.h:
khtml/xml/dom_textimpl.cpp: (TextImpl::rendererIsNeeded):

1:13 PM Changeset in webkit [3526] by darin

3 edits in trunk/WebCore

Reviewed by me, Dave wrote the code.

fixed 3162013 -- Safari collapses margins through bottom borders (affects top of zeldman.com)

khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren): Don't collapse if we have any bottom border or padding.

1:09 PM Changeset in webkit [3525] by darin

3 edits in trunk/WebCore

Reviewed by Dave.

fixed 3160442 -- no top image map at ebay, caused by referrer returning null instead of empty string

khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::tryGet): Return an empty string, not null, when there is no referrer.

12:55 PM Changeset in webkit [3524] by cblu

7 edits in trunk

WebCore:

kwq/WebCoreBridge.mm: fixed key value

WebKit:

English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
WebView.subproj/WebController.m: fixed key value

WebBrowser:

English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

9:38 AM Changeset in webkit [3523] by cblu

14 edits in trunk

WebCore:

Fixed : 3155148 - image shown when dragging gets size from image file, not size as used on page

Reviewed by darin.

kwq/WebCoreBridge.h: added WebCoreElementImageRectKey
kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): get the rect of the image

WebKit:

Fixed : 3155148 - image shown when dragging gets size from image file, not size as used on page

Reviewed by darin.

Misc.subproj/WebNSViewExtras.h:
Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragPromisedImage:rect:URL:fileType:title:event:]): take a rect so we know the original size and origin
WebKit.exp: added WebElementImageRectKey
WebView.subproj/WebController.h: WebElementImageRectKey
WebView.subproj/WebController.m: WebElementImageRectKey
WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _handleMouseDragged:]): call _web_dragPromisedImage with WebElementImageRect
WebView.subproj/WebImageView.m: (-[WebImageView menuForEvent:]): provide the WebElementImageRect since we do this for other image elements (-[WebImageView mouseDragged:]): call _web_dragPromisedImage with [self bounds]

8:54 AM Changeset in webkit [3522] by trey

4 edits in trunk/WebCore

3161088 - disabled select elements are not disabled when scrolling list used

We use a tableview delegate method to prevent the user from changing the
selection when disabled. Too bad tableviews don't know how to disable themselves.
We also condition the cell used for drawing to match our enabled state.

Reviewed by Maciej.

kwq/KWQListBox.h: Keep track of whether we are enabled.
kwq/KWQListBox.mm: (QListBox::QListBox): Init new flag. (QListBox::setEnabled): Set new flag. (QListBox::isEnabled): Getter for new flag. (-[KWQListBoxTableViewDelegate selectionShouldChangeInTableView:]): Disallow selection changes if disabled. (-[KWQListBoxTableViewDelegate tableView:willDisplayCell:forTableColumn:row:]): Enable cell based on our enabled state to get visual feedback of being disabled.

Jan 30, 2003:

8:59 PM Changeset in webkit [3521] by trey

3 edits in trunk/WebCore

3161486 - REGRESSION: double click on a widget causes crash

Slight enhancement to the earlier fix of this bug. When handling a doubleclick we
don't want to try to pass the current event down the Cocoa widgets, because Cocoa
has no double-click event, and we just end up resending one we already sent.

The upshot is that we do not pass an extra mouseup event to the widgets at the
end of a double click sequence.

Reviewed by Darin.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWidgetMouseDownEventToWidget): Do not pass event down to the widget for doubleclick events.

8:09 PM Changeset in webkit [3520]

6 copies in tags/Safari-55

This commit was manufactured by cvs2svn to create tag 'Safari-55'.

8:09 PM Changeset in webkit [3519]

6 copies in branches/Safari-0-8-2-branch

This commit was manufactured by cvs2svn to create branch
'Safari-0-8-2-branch'.

8:09 PM Changeset in webkit [3518]

6 copies in tags/SAFARI_0_8_2_BRANCH_ANCHOR

This commit was manufactured by cvs2svn to create tag
'SAFARI_0_8_2_BRANCH_ANCHOR'.

8:09 PM Changeset in webkit [3517] by darin

6 edits in trunk/WebCore

Reviewed by Ken, Maciej, and Trey.

fixed 3161486 -- REGRESSION: double click on a widget causes crash

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWidgetMouseDownEventToWidget): Only pass the mouseUp event if it's not the same as the current event. Through a strange set of circumstances, sometimes the "mouse down" event is a mouse up event (due to KHTML vs. AppKit differences for double-click handling).

fixed build with newer compiler

khtml/html/Makefile.am: Use ANSI-C style, not C++ style, gperf.
khtml/html/doctypes.cpp: Regenerated.
khtml/html/html_documentimpl.cpp: Do inline workaround to make newer compiler happy. (HTMLDocumentImpl::determineParseMode): Change to use ANSI-C style.

4:42 PM Changeset in webkit [3516] by sheridan

4 edits in trunk

tree is open, 56u is build version, now on the path to beta 2 officially

4:34 PM Changeset in webkit [3515] by sheridan

8 edits in trunk

Safari-55 version stamp

4:13 PM Changeset in webkit [3514] by cblu

3 edits in trunk/WebKit

Backed out my fix for 3161102. Richard and I found problems the fix. 3161102 turns out to not be an issue.

Reviewed by rjw.

History.subproj/WebHistoryItem.m: (+[WebHistoryItem _releaseAllPendingPageCaches]):
WebView.subproj/WebHTMLView.m: (-[WebHTMLView windowWillClose:]):

2:17 PM Changeset in webkit [3513] by rjw

3 edits in trunk/WebCore

Fix for 3156831 (and dupe 3160816). Don't access userInfo on an invalid NSTimer.

Reviewed by trey.

kwq/KWQObject.mm: (QObject::pauseTimer): (QObject::resumeTimers):

2:11 PM Changeset in webkit [3512] by cblu

3 edits in trunk/WebKit

Fixed: 3161102 - Avoid retain cycles by destroying plug-ins in the page cache before dealloc

Reviewed by rjw.

History.subproj/WebHistoryItem.m: (+[WebHistoryItem _releaseAllPendingPageCaches]): iterate over all of the plug-ins and call destroy
WebView.subproj/WebHTMLView.m: (-[WebHTMLView windowWillClose:]): clear page cache

1:41 PM Changeset in webkit [3511] by trey

3 edits in trunk/WebCore

3160565 - REGRESSION: Can't log in to etrade

Fix regression caused by fixed to 3058229. We auto-select an item of a select element
if it is size=1 or size is unset (m_size==0 in the code).

This gives us conformance with WinIE. The test at dbaron.org fails us for the
case of a disabled list with no size and no initial selection.

Reviewed by Darin.

khtml/html/html_formimpl.cpp: (HTMLSelectElementImpl::recalcListItems): Auto-select an item if size==1 or is unset.

1:22 PM Changeset in webkit [3510] by hyatt

3 edits in trunk/WebCore

Make quirk bits part of the bitfield to shrink RenderFlows.

Reviewed by trey

khtml/rendering/render_flow.h:

12:24 PM Changeset in webkit [3509] by hyatt

5 edits in trunk/WebCore

Fix for 3155954. Make sure no layers get made for :before,
:after or :first-letter. The only debatable case is whether
overflow can apply to generated content. Included a FIXME
to think about that case.

Reviewed by darin

khtml/rendering/render_container.cpp: (RenderContainer::insertPseudoChild):
khtml/rendering/render_flow.cpp: (RenderFlow::addChildToFlow):
khtml/rendering/render_text.cpp: (RenderText::nodeAtPoint):

12:03 PM Changeset in webkit [3508] by cblu

3 edits in trunk/WebKit

Fixed: 3160464 - Slideback sometimes happens twice

Because we start drags in mouseDragged (which AppKit says we shouldn't), we get mouseDragged events after a drag (image, link, text etc) has ended. We also get mouseDragged events after we've sent the fake mouseUp to WebCore. That is probably bad for unknown reasons.

Reviewed by darin.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDown:]): set ignoringMouseDraggedEvents to NO (-[WebHTMLView mouseDragged:]): check ignoringMouseDraggedEvents (-[WebHTMLView draggedImage:endedAt:operation:]): set ignoringMouseDraggedEvents to NO
WebView.subproj/WebHTMLViewPrivate.h: added ignoringMouseDraggedEvents

11:25 AM Changeset in webkit [3507] by darin

3 edits in trunk/WebCore

khtml/html/html_documentimpl.cpp: Updated license.

9:12 AM Changeset in webkit [3506] by darin

2 edits in trunk/WebKit

Reviewed by John.

fixed 3160710 -- REGRESSION: bizrate.com front page ad in wrong position

The new code to compute port coordinates was screwing up somehow.
I had to roll it out and we'll have to try again to fix the problem Ed was fixing.

Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]): Roll back changes between 1.45 and 1.47.

8:08 AM Changeset in webkit [3505] by darin

3 edits in trunk/WebCore

Reviewed by Maciej.

fixed 3158958 -- nil-dereference in KJS::DOMNode::getValueProperty at www.babyage.com

khtml/ecma/kjs_dom.cpp: (DOMNode::getValueProperty): Move the code that gets the render object down after the point where the render tree is updated, so we don't end up using a stale pointer.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed