Timeline



Sep 28, 2004:

6:54 PM Changeset in webkit [7719] by rjw
  • 1 edit in branches/Safari-1-2-branch/WebKit/ChangeLog

Changed incorrect reference to 3791526 to 3710123.

6:49 PM Changeset in webkit [7718] by rjw
  • 2 edits in branches/Safari-1-2-branch/WebKit

Fix for follow on problem to fix for 3791526, in particular:

<rdar://problem/3803113> WebFrame object leaked

We should always call end to guarantee that terminal load delegate
callbacks get sent to WebKit clients. In this case the a cancel message
wasn't sent and Safari's activity monitor was holding onto a reference.

Reviewed by Maciej.

  • WebView.subproj/WebDataSource.m: (-[WebDataSource _finishedLoading]):
6:19 PM Changeset in webkit [7717] by cblu
  • 2 edits in trunk/WebCore

Fixed: WebArchives begin with "<#document/>"

Reviewed by hyatt.

  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::startMarkup): don't return markup if this is a document node, forgot this when factoring this method out from toHTML
6:02 PM Changeset in webkit [7716] by cblu
  • 5 edits in trunk/WebCore

Removed range parameter from recursive_toHTML and friends since that code path is no longer used.

Reviewed by mjs.

  • khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::toHTML):
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::recursive_toString): (NodeImpl::recursive_toHTML):
  • khtml/xml/dom_nodeimpl.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge markupStringFromNode:nodes:]):
5:34 PM Changeset in webkit [7715] by cblu
  • 3 edits in trunk/WebKit

Added timing code so that Doug can time RTF conversion.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView writeSelectionWithPasteboardTypes:toPasteboard:]): (-[WebHTMLView _attributeStringFromDOMRange:]):
5:17 PM Changeset in webkit [7714] by darin
  • 8 edits in trunk/WebCore

Reviewed by Ken.

  • improve spell checking so it doesn't unmark and remark as you move the cursor with the arrow
  • khtml/editing/htmlediting.h: Remove obsolete markMisspellingsInSelection private function.
  • khtml/editing/htmlediting.cpp: (khtml::EditCommand::EditCommand): Blow away the selection when starting an edit command. (khtml::EditCommand::apply): Remove code to mark misspellings because that's now done as part of blowing away the selection. (khtml::EditCommand::unapply): Blow away the selection instead of marking mispellings. (khtml::EditCommand::reapply): Ditto. (khtml::ReplaceSelectionCommand::doApply): Removed incorrect code that does spell checking on inserted text; this doesn't match NSText behavior. (khtml::TypingCommand::markMisspellingsAfterTyping): Use markMisspellingsInAdjacentWords function for greater clarity on what this actually does.
  • khtml/khtml_part.h: Replaced setSelection's "unmarkOldSelection" boolean parameter with a "keepTypingStyle" boolean parameter. Removed notifySelectionChanged.
  • khtml/khtml_part.cpp: (KHTMLPart::setSelection): Replaced the "unmarkOldSelection" boolean with a new "keepTypingStyle" boolean. This is a step on the way to simplifying how this works. Moved the code from the notifySelectionChanged function here, since there was no clear line between the two functions. (KHTMLPart::clearSelection): Call setSelection rather that having special case code here for the case of an empty selection. (KHTMLPart::appliedEditing): Remove the explicit "false" for "unmarkOldSelection". (KHTMLPart::unappliedEditing): Ditto. (KHTMLPart::reappliedEditing): Ditto.
  • kwq/KWQKHTMLPart.h: Replaced markMisspellingsInSelection and updateSpellChecking with markMisspellings and markMisspellingsInAdjacentWords. Added parameters to respondToChangedSelection.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::markMisspellingsInAdjacentWords): Added. (KWQKHTMLPart::markMisspellings): New name for markMisspellingsInSelection. Simplified logic a bit and made it the caller's responsibility to expand the selection passed in to word boundaries. (KWQKHTMLPart::respondToChangedSelection): Added parameter that identifies the old selection, and changed logic so it won't mark mispellings in a word if the selection still starts in that word.
  • implemented empty-cells property in computed style
  • khtml/css/css_computedstyle.cpp: (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue): Added code for CSS_PROP_EMPTY_CELLS. I think the HTML converter in AppKit uses this.
3:55 PM Changeset in webkit [7713] by cblu
  • 4 edits in trunk/WebCore

Fixed n-squared issues with appending to KWQValueListImpl. This fixes the hang in 3794799.

Fixed by Darin, reviewed by me.

  • khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::toHTML): tweaks
  • kwq/KWQValueListImpl.mm: (KWQValueListImpl::KWQValueListPrivate::KWQValueListPrivate): (KWQValueListImpl::KWQValueListPrivate::copyList): (KWQValueListImpl::clear): (KWQValueListImpl::appendNode): (KWQValueListImpl::prependNode): (KWQValueListImpl::removeEqualNodes): (KWQValueListImpl::containsEqualNodes): (KWQValueListImpl::removeIterator): (KWQValueListImpl::lastNode):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge nodesFromList:]): use iterator, not at()
1:57 PM Changeset in webkit [7712] by rjw
  • 18 edits in trunk

WebCore:

More dashboard region changes for John.

<rdar://problem/3817421> add getter for dashboard regions (debugging)

<rdar://problem/3817417> NSScrollView need autoregions for dashboard

<rdar://problem/3817388> should have short form form control regions

<rdar://problem/3817477> visibility does not work with dashboard control regions

Reviewed by Hyatt.

  • WebCore-combined.exp:
  • WebCore.exp:
  • khtml/css/cssparser.cpp: (skipCommaInDashboardRegion): (CSSParser::parseDashboardRegions):
  • khtml/khtmlview.cpp: (KHTMLView::updateDashboardRegions):
  • khtml/rendering/render_object.cpp: (RenderObject::setStyle): (RenderObject::addDashboardRegions):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::setDashboardRegions):
  • khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::setDashboardRegionsDirty): (DOM::DocumentImpl::dashboardRegionsDirty):
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::paint): (KWQKHTMLPart::dashboardRegionsDictionary): (KWQKHTMLPart::dashboardRegionsChanged):
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge dashboardRegions]):
  • kwq/WebDashboardRegion.h:
  • kwq/WebDashboardRegion.m: (-[WebDashboardRegion description]):

WebKit:

More dashboard region changes for John.

<rdar://problem/3817421> add getter for dashboard regions (debugging)

<rdar://problem/3817417> NSScrollView need autoregions for dashboard
Also KWQScrollBars

Reviewed by Hyatt.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge dashboardRegionsChanged:]):
  • WebView.subproj/WebView.m: (-[WebView _setInitiatedDrag:]): (-[WebView _addScrollerDashboardRegions:from:]): (-[WebView _addScrollerDashboardRegions:]): (-[WebView _dashboardRegions]):
  • WebView.subproj/WebViewPrivate.h:
1:07 PM Changeset in webkit [7711] by sullivan
  • 2 edits in trunk/LayoutTests/fast/tokenizer

Updated the output of the script type test for more clarity; updated the expected results too.

11:55 AM Changeset in webkit [7710] by sullivan
  • 3 edits in trunk

Reviewed by Chris.

  • fixed <rdar://problem/3818558> REGRESSION: "Installed Plug-ins" is blank because of <script type="application/x-javascript">
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseTag): add "application/x-javascript" to the list of legal scripting types. Mozilla accepts this, but WinIE doesn't.
  • layout-tests/fast/tokenizer/004.html: updated layout test to test some application/xxxx types
11:33 AM Changeset in webkit [7709] by hyatt
  • 2 adds in trunk/LayoutTests/fast/lists

New list results.

11:32 AM Changeset in webkit [7708] by hyatt
  • 9 edits in trunk/WebCore

Reworked lists to work well with RTL text. Specifically the following bugs have been fixed:

(1) All bullets use the same offset constant now (a padding of 7 pixels). Before, images used 5 and others used 7.
(2) Line height now works properly, so that list items with no content aren't squished (and missing the line descent).
(3) Punctuation now works correctly with inside and outside style ordered lists in RTL.
(4) RTL lists now properly apply padding and margin to the right side rather than the left. This was done by adding
-khtml-margin-start and -khtml-padding-start properties that are just mapped to left/right based off the direction.

Reviewed by darin

  • khtml/css/cssparser.cpp: (CSSParser::parseValue):
  • khtml/css/cssproperties.c: (hash_prop): (findProp):
  • khtml/css/cssproperties.h:
  • khtml/css/cssproperties.in:
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyDeclarations): (khtml::CSSStyleSelector::applyProperty):
  • khtml/css/html4.css:
  • khtml/rendering/bidi.cpp: (khtml::BidiIterator::direction):
  • khtml/rendering/render_list.cpp: (RenderListItem::getAbsoluteRepaintRect): (RenderListMarker::paint): (RenderListMarker::calcMinMaxWidth): (RenderListMarker::lineHeight): (RenderListMarker::baselinePosition):
11:29 AM Changeset in webkit [7707] by hyatt
  • 3 edits in trunk/LayoutTests/fast/lists

List layout test changes.

11:24 AM Changeset in webkit [7706] by kocienda
  • 6 edits in trunk/WebCore

Reviewed by Darin

Mark the VisiblePosition taking (Position &, EAffinity=DOWNSTREAM) explicit. Recently, when I added
the EAffinity argument, I left this constructor implicit. Darin pointed out to me that this is
undesirable since implicit use of the the constructor involved making the affinity choice, something
which should be done explicitly.

  • khtml/editing/selection.cpp: (khtml::Selection::modifyExtendingRightForward): Make explicit use of constructor mentioned above. (khtml::Selection::modifyMovingRightForward): Ditto. (khtml::Selection::modifyExtendingLeftBackward): Ditto. (khtml::Selection::modifyMovingLeftBackward): Ditto. (khtml::Selection::modify): Ditto. (khtml::Selection::validate): Ditto.
  • khtml/editing/visible_position.h: Make constructor taking (Position &, EAffinity) explicit.
  • khtml/editing/visible_units.cpp: Ditto. (khtml::previousWordBoundary): Make explicit use of constructor mentioned above. (khtml::nextWordBoundary): Ditto. (khtml::previousLinePosition): Ditto. (khtml::nextLinePosition): Ditto.
  • kwq/KWQKHTMLPart.mm: Ditto. (KWQKHTMLPart::findString): Ditto. (KWQKHTMLPart::advanceToNextMisspelling): Ditto. (KWQKHTMLPart::markMisspellingsInSelection): Ditto. (KWQKHTMLPart::updateSpellChecking): Ditto.
9:43 AM Changeset in webkit [7705] by darin
  • 2 edits in trunk/WebCore

Reviewed by John.

  • fixed a storage leak discovered by code inspection
  • khtml/html/htmlparser.cpp: (KHTMLParser::~KHTMLParser): Call setCurrent(0) to deref the parser's current node in the rare case where it still has one.

Sep 27, 2004:

6:08 PM Changeset in webkit [7704] by sullivan
  • 4 edits in trunk/WebKit
  • fixed <rdar://problem/3814705> 8A266: Safari authentication dialog "remember password" text should match Mail
  • Panels.subproj/English.lproj/WebAuthenticationPanel.nib: changed "Remember this password" to "Remember this password in my keychain"; this will need to go through CCC for this week's build.
6:01 PM Changeset in webkit [7703] by hyatt
  • 2 adds in trunk/LayoutTests/fast/invalid

* empty log message *

5:58 PM Changeset in webkit [7702] by hyatt
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Don't allow nested headers when only inlines are in between them. Fixes a hang related to pathological nesting
on magicmethodsonline.com.

Reviewed by darin

  • khtml/html/htmlparser.cpp: (KHTMLParser::parseToken): (KHTMLParser::processCloseTag): (KHTMLParser::isHeaderTag): (KHTMLParser::popNestedHeaderTag):
  • khtml/html/htmlparser.h:
5:57 PM Changeset in webkit [7701] by hyatt
  • 2 edits in trunk/WebCore/khtml/html

ChangeLog

4:17 PM Changeset in webkit [7700] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3594754> change null event interval from 20 ms to 10 ms to match speed on Windows

Reviewed by NOBODY (OOPS!).

  • Plugins.subproj/WebBaseNetscapePluginView.m:
3:56 PM Changeset in webkit [7699] by cblu
  • 1 edit in trunk/WebKit/ChangeLog

WebKit:

Fixed previous reviewer line.

  • ChangeLog:

WebBrowser:

Fixed typo.

  • ChangeLog:
3:22 PM Changeset in webkit [7698] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3502138> text files don't remember scroll position when going back or reloading

Reviewed by .

  • WebView.subproj/WebTextView.m: (-[WebTextView layout]): implemented, call sizeToFit, without this scrollPoint: won't work
2:30 PM Changeset in webkit [7697] by sullivan
  • 6 edits in trunk/WebKit

WebKit:

Reviewed by Ken.

  • WebKit part of fix for <rdar://problem/3734466> ER: Support standard editing keystrokes like Cmd-B while editing rich text
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _toggleBold]): new method, toggles font-weight from "bold" to "normal" (-[WebHTMLView _toggleItalic]): new method, toggles font-style from "italic" to "normal" (-[WebHTMLView _handleStyleKeyEquivalent:]): new method, if the new preference is set and we're in an editable state, check for standard key equivalents for toggling styles (just command-B and command-I for now). (-[WebHTMLView performKeyEquivalent:]): Moved in file, now calls _handleStyleKeyEquivalent:
  • WebView.subproj/WebPreferenceKeysPrivate.h: new preference key WebKitRespectStandardStyleKeyEquivalentsPreferenceKey
  • WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]): initial value of WebKitRespectStandardStyleKeyEquivalentsPreferenceKey is NO (maybe we'll change our minds about this, but this is more guaranteed to be backward-compatible) (-[WebPreferences respectStandardStyleKeyEquivalents]): read WebKitRespectStandardStyleKeyEquivalentsPreferenceKey (-[WebPreferences setRespectStandardStyleKeyEquivalents:]): write WebKitRespectStandardStyleKeyEquivalentsPreferenceKey
  • WebView.subproj/WebPreferencesPrivate.h: declare getter and setter
  • English.lproj/StringsNotToBeLocalized.txt: updated for these and other recent changes

WebBrowser:

Reviewed by Ken.

  • WebBrowser part of fix for <rdar://problem/3734466> ER: Support standard editing keystrokes like Cmd-B while editing rich text
  • AppController.m: (-[AppController applicationDidFinishLaunching:]): turn on the new WebKit preference that makes command-B and command-I toggle styles in editable text.
11:41 AM Changeset in webkit [7696] by cblu
  • 2 edits in trunk/WebKit

WebKit:

Fixed: <rdar://problem/3806649> assertion failure after control-click of webcam

Reviewed by john.

  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate contextMenuItemsForElement:]): don't provide "Copy Image" if the image is not fully loaded

WebBrowser:

Fixed: Fixed: <rdar://problem/3806649> assertion failure after control-click of webcam

Reviewed by john.

  • ContextMenuHandler.m: (-[BrowserWebView webView:contextMenuItemsForElement:defaultMenuItems:]): don't provide "Save Image", "Copy Image" and "Add Image to iPhoto Library" if the image is not fully loaded. Provide "Download Image" instead.
11:39 AM Changeset in webkit [7695] by hyatt
  • 1 edit in trunk/LayoutTests/fast/frames/contentWindow_Frame-expected.txt

land fixed frame result.

11:35 AM Changeset in webkit [7694] by hyatt
  • 1 edit in trunk/LayoutTests/fast/overflow/003-expected.txt

Land fixed overflow result.

11:00 AM Changeset in webkit [7693] by kdecker
  • 2 edits in trunk/WebCore

Reviewed by John.

  • khtml/css/css_base.cpp: (CSSSelector::selectorText): changed another ATTR_CLASS case to properly return class selector names.
10:52 AM Changeset in webkit [7692] by hyatt
  • 8 edits in trunk/WebCore

Fix style sharing so that it doesn't share when it shouldn't. Partially fixes 3671516, table cells don't update
their color on macosx.apple.com.

Fix 3521639, iframe mispositioned on bidi page. Make sure that when the width of a line exceeds the available line
width that the spillage out of the block is determined by the direction of the block and not by the text-align value.

Partial fix for 3762962, make sure the image cells with specified widths but percentage heights don't just get a minwidth
of 0.

Fix for 3533878, framesets that use percentages that add up to a value > 100% should normalize those percentages.

Reviewed by john

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::locateCousinList): (khtml::CSSStyleSelector::elementsCanShareStyle): (khtml::CSSStyleSelector::locateSharedStyle):
  • khtml/css/cssstyleselector.h:
  • khtml/html/html_elementimpl.h: (DOM::HTMLNamedAttrMapImpl::hasMappedAttributes): (DOM::HTMLElementImpl::inlineStyleDecl):
  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::computeHorizontalPositionsForLine):
  • khtml/rendering/render_frames.cpp: (RenderFrameSet::layout):
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::calcMinMaxWidth):
  • khtml/xml/dom_elementimpl.h: (DOM::ElementImpl::inlineStyleDecl): (DOM::ElementImpl::hasMappedAttributes):
10:49 AM Changeset in webkit [7691] by kocienda
  • 18 edits
    3 adds in trunk

Reviewed by John

Removed closestRenderedPosition function from Position class and gave this work
to VisiblePosition instead. However, in order to make the transfer possible,
VisiblePosition needed upstream and downstream affinities added to its
constructors. Also moved the EAffinity enum into its own file. Also moved it
to the khtml namespace.

Updated several functions which used closestRenderedPosition to use VisiblePosition
instead.

Also deleted Position::equivalentShallowPosition. This was unused.

  • ForwardingHeaders/editing/text_affinity.h: Added.
  • ForwardingHeaders/editing/visible_position.h: Added.
  • WebCore.pbproj/project.pbxproj: Added new files.
  • khtml/editing/selection.cpp: (khtml::Selection::validate): Use VisiblePosition instead of closestRenderedPosition.
  • khtml/editing/selection.h:
  • khtml/editing/text_affinity.h: Added.
  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::VisiblePosition): (khtml::VisiblePosition::initUpstream): New helper for finding upstream visible position. (khtml::VisiblePosition::initDownstream): Was old init function that unconditionally did downstream checks for visible position. Renamed to describe this more clearly.
  • khtml/editing/visible_position.h:
  • khtml/editing/visible_units.cpp: (khtml::previousWordBoundary): Use VisiblePosition instead of closestRenderedPosition. (khtml::nextWordBoundary): Use VisiblePosition instead of closestRenderedPosition.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::updateSelection): Use VisiblePosition instead of closestRenderedPosition.
  • khtml/xml/dom_position.cpp: (DOM::Position::closestRenderedPosition): Removed.
  • khtml/xml/dom_position.h: Removed two functions mentioned above.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::fontForSelection) Use VisiblePosition instead of closestRenderedPosition.:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge setSelectedDOMRange:affinity:]): Use VisiblePosition instead of closestRenderedPosition.
  • layout-tests/editing/deleting/delete-block-merge-contents-012-expected.txt: Updated expected results.
  • layout-tests/editing/deleting/delete-block-merge-contents-017-expected.txt: Ditto.
  • layout-tests/editing/deleting/delete-contiguous-ws-001-expected.txt: Ditto.
  • layout-tests/editing/selection/move-by-character-004-expected.txt: Ditto.
9:36 AM Changeset in webkit [7690] by cblu
  • 2 edits in trunk/WebKit

Fixed: <rdar://problem/3814810> REGRESSION (125-164): Exception adding nil to dictionary in dragging code

Reviewed by john.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _setMouseDownEvent:]): new (-[WebHTMLView acceptsFirstMouse:]): call _setMouseDownEvent (-[WebHTMLView shouldDelayWindowOrderingForEvent:]): ditto (-[WebHTMLView mouseDown:]): ditto (-[WebHTMLView _delegateDragSourceActionMask]): removed temp fix, assert that the mouse event is not nil
8:30 AM Changeset in webkit [7689] by darin
  • 2 edits in trunk/WebKit
  • WebKit.pbproj/project.pbxproj: Added WebDashboardRegion.h as a private header.
7:44 AM Changeset in webkit [7688] by kocienda
  • 13 edits
    3 deletes in trunk/WebCore

Reviewed by Darin and Maciej

Removed EditCommand smart pointer wrappers from htmlediting.cpp/.h, save for the one
at the root of the hierarchy, and this one has been renamed EditCommandPtr. Renamed
each of the XXXCommandImpl classes, removing the Impl suffix from each, and rolled
these into the htmlediting.cpp/.h files. The htmlediting_impl.cpp/.h files have
been emptied and are being removed.

For the remainder of files, perform the mechanical changes necessary to make everything
compile and run as before.

  • WebCore.pbproj/project.pbxproj
  • khtml/editing/htmlediting.cpp
  • khtml/editing/htmlediting.h
  • khtml/editing/htmlediting_impl.cpp: Removed.
  • khtml/editing/htmlediting_impl.h: Removed.
  • khtml/editing/jsediting.cpp
  • khtml/khtml_part.cpp (KHTMLPart::openURL) (KHTMLPart::lastEditCommand) (KHTMLPart::appliedEditing) (KHTMLPart::unappliedEditing) (KHTMLPart::reappliedEditing) (KHTMLPart::applyStyle):
  • khtml/khtml_part.h
  • khtml/khtmlpart_p.h
  • kwq/KWQEditCommand.h
  • kwq/KWQEditCommand.mm (-[KWQEditCommand initWithEditCommandImpl:]) (+[KWQEditCommand commandWithEditCommandImpl:]) (-[KWQEditCommand impl])
  • kwq/KWQKHTMLPart.h
  • kwq/KWQKHTMLPart.mm (KWQKHTMLPart::registerCommandForUndo) (KWQKHTMLPart::registerCommandForRedo)
  • kwq/WebCoreBridge.mm (-[WebCoreBridge undoEditing:]) (-[WebCoreBridge redoEditing:]) (-[WebCoreBridge replaceSelectionWithFragment:selectReplacement:smartReplace:]) (-[WebCoreBridge moveSelectionToDragCaret:smartMove:]) (-[WebCoreBridge deleteSelectionWithSmartDelete:])

Sep 26, 2004:

9:59 PM Changeset in webkit [7687] by darin
  • 5 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed <rdar://problem/3816170> image.width/height not available from Image objects (works in Firefox)
  • khtml/ecma/kjs_html.h: Added width and height.
  • khtml/ecma/kjs_html.cpp: (Image::getValueProperty): Added width and height.
  • khtml/ecma/kjs_html.lut.h: Regenerated.
  • unrelated change; changed ordering of use count manipulation just in case we decide some day to do something when the use count hits 0
  • khtml/rendering/render_image.cpp: (RenderImage::setPixmap): Increment use count on new object before decrementing use count on old object.
7:07 PM Changeset in webkit [7686] by darin
  • 10 adds in trunk/LayoutTests/fast

New layout tests for the bugs I just fixed.

6:54 PM Changeset in webkit [7685] by darin
  • 2 edits in trunk/JavaScriptCore
  • kjs/string_object.cpp: (StringProtoFuncImp::call): Remove strange use of high() and low() to get Unicode value of character, and just use unicode().
6:52 PM Changeset in webkit [7684] by darin
  • 2 edits in trunk/JavaScriptCore
  • refine charAt/charCodeAt fix slightly
  • kjs/string_object.cpp: (StringProtoFuncImp::call): Treat undefined the same was as an omitted parameter, as we do everywhere else, and as other browsers do here.
6:02 PM Changeset in webkit [7683] by darin
  • 8 edits in trunk/WebCore

Reviewed by Kevin.

  • fixed <rdar://problem/3812771> document.implementation.hasFeature returns false for a lot of features we implement
  • khtml/xml/dom_docimpl.cpp: (DOMImplementationImpl::hasFeature): Added all the DOM features that we implemented as part of the HTML editing work.
  • khtml/dom/dom_node.cpp: (Node::isSupported): Changed this to call DOMImplementationImpl::hasFeature to share code. Later this might need to be different per-node, but at the moment that does not seem to be so.
  • khtml/ecma/kjs_dom.cpp: (DOMNodeProtoFunc::tryCall): Pass a null string if the parameter is omitted, undefined, or null. This is better than having a special case for the string "null" in the DOM implementation. (DOMDOMImplementationProtoFunc::tryCall): Ditto.
  • fixed <rdar://problem/3814605> REGRESSION: fast/table/039 layout test is failing due to extra trailing whitespace in innerText
  • khtml/editing/visible_text.cpp: (khtml::TextIterator::advance): Check for the case where we are at the end of iteration, and don't call exitNode in that case. This prevents us from getting some unwanted trailing \n characters.
  • fixed <rdar://problem/3813253> method cloneNode() does not clone dynamically-set style attributes correctly
  • khtml/html/html_elementimpl.h: Added cloneNode override.
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::cloneNode): Added. Copies m_inlineStyleDecl. (HTMLElementImpl::parseHTMLAttribute): Changed to use getInlineStyleDecl(). (HTMLElementImpl::innerText): Changed to do the same thing with fewer lines of code. (HTMLElementImpl::outerText): Tweaked comment.
  • other cleanup
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::cloneNode): Removed an uneeded type cast. (XMLElementImpl::cloneNode): Ditto.
6:01 PM Changeset in webkit [7682] by darin
  • 4 edits in trunk/JavaScriptCore

Reviewed by Kevin.

  • fixed <rdar://problem/3816097> REGRESSION: mailblocks, and presumably many other pages, failing because variable not found
  • kjs/internal.cpp: (InterpreterImp::evaluate): Process variable declarations before executing the program. We were doing this properly for functions, but not entire programs.
  • fixed <rdar://problem/3814706> REGRESSION: text fields in mailblocks wizards do not accept keystrokes due to use of charCodeAt()
  • kjs/string_object.cpp: (StringProtoFuncImp::call): Changed the implementation of charAt and charCodeAt to treat a missing parameter as an index of 0, rather than an invalid index.
  • tests/mozilla/expected.html: Update for two tests that now pass with these changes.

Sep 24, 2004:

5:44 PM Changeset in webkit [7681] by kdecker
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

<rdar://problem/3799334> DIG: Safari does not properly return style names [DigCSS.htm]

  • khtml/css/css_base.cpp: (CSSSelector::selectorText): Properly returns Class Selector names. Before we would get *[CLASS"foo"] instead of .foo
4:27 PM Changeset in webkit [7680] by kocienda
  • 2 edits
    2 adds in trunk

Reviewed by John

Fix for this bug:

<rdar://problem/3814660> REGRESSION (8A200-8A259): Select All has no effect on livepage.apple.com

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::updateSelection): Move the selection start and end to rendered positions before passing off to the RenderCanvas for drawing.
  • layout-tests/editing/selection/select-all-004-expected.txt: Added.
  • layout-tests/editing/selection/select-all-004.html: Added.
4:23 PM Changeset in webkit [7679] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • fixed <rdar://problem/3528339> Turn on full keyboard access shows invisible <input> elements
  • khtml/html/html_formimpl.cpp: (DOM::HTMLGenericFormElementImpl::isFocusable): reject elements that have zero width or height, even if they aren't hidden
4:09 PM Changeset in webkit [7678] by mjs
  • 2 edits in trunk/WebCore
  • fixed deployment build

Reviewed by Ken.

  • khtml/dom/dom_string.cpp: put implementation of ascii() in #ifdef !NDEBUG to match prototype.
3:38 PM Changeset in webkit [7677] by hyatt
  • 1 edit in trunk/LayoutTests/fast/table/037.xml

Fix layout test 37.

3:14 PM Changeset in webkit [7676] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3800316, test 37 for tables is failing on the layout tests. Make sure we don't incorrectly match
non-HTML elements with HTML tag selectors in CSS.

Reviewed by rjw

  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::checkOneSelector):
3:09 PM Changeset in webkit [7675] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3601920, CSS "tabs" not switching properly on zen garden design. Improve the repainting to account
for layer changes of z-index that necessitate an invalidation.

Reviewed by kocienda

  • khtml/rendering/render_object.cpp: (RenderObject::setStyle):
  • khtml/rendering/render_style.cpp: (RenderStyle::diff):
  • khtml/rendering/render_style.h: (khtml::RenderStyle::):
2:44 PM Changeset in webkit [7674] by cblu
  • 7 edits in trunk

WebCore:

Made markup copying 5 times faster. Unfortunately, this still doesn't fix:
<rdar://problem/3794799> Tiger8A252: copying a bunch o' text is so slow it seems like a hang

Reviewed by rjw.

  • khtml/dom/dom_string.h:
  • khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::toHTML): serialize the range by iterating through the range
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::startMarkup): new, factored out from recursive_toString (NodeImpl::endMarkup): ditto (NodeImpl::recursive_toString): call factored out methods
  • khtml/xml/dom_nodeimpl.h:

WebKit:

Reviewed by rjw.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _selectedArchive]): added timing code for copying markup
2:42 PM Changeset in webkit [7673] by vicki
  • 3 edits in trunk

versioning for TOT, Safari 2.0 (v166u)

2:31 PM Changeset in webkit [7672]
  • 3 copies in tags/Safari-165

This commit was manufactured by cvs2svn to create tag 'Safari-165'.

2:31 PM Changeset in webkit [7671] by vicki
  • 6 edits in trunk

Safari-165 stamp for everything except WebBrowser. In these projects, CFBundleShortVersionString matches CFBundleVersion (165 for both).

1:34 PM Changeset in webkit [7670] by cblu
  • 2 edits in trunk/WebKit

Temp fix for: <rdar://problem/3814810> REGRESSION (125-164): Exception adding nil to dictionary in dragging code

Reviewed by john.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _delegateDragSourceActionMask]): return none if the mouse down event is nil
11:12 AM Changeset in webkit [7669] by kocienda
  • 3 edits in trunk

Reviewed by me

Hyatt made an improvement in the render tree which caused the results
to get a little thinner.

  • layout-tests/editing/deleting/delete-block-merge-contents-001-expected.txt.
  • layout-tests/editing/deleting/delete-block-merge-contents-008-expected.txt.
10:51 AM Changeset in webkit [7668] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3812939> REGRESSION: move-between-blocks-no-001 editing layout test fails in DeleteSelectionCommandImpl

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::removeChild): Hyatt said this regression was caused by a bad merge. Found by code inspection.
10:49 AM Changeset in webkit [7667] by kocienda
  • 3 edits in trunk/WebKit

Reviewed by John

Fix for this bug:

<rdar://problem/3813917> REGRESSION (125-163): The font panel will change the font of any web page

We were doing a laughably bad job at preventing edits in documents that were not editable.
This change fixes the specific case of the bug mentioned above, and makes an attempt to
fix similar bugs by checking for whether the view is in editing mode before making edits.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _canEdit]): Renamed from _canType. Used in many more places in the code now. (-[WebHTMLView _isMoveDrag]): Change around code to make the meaning more clear. This one was actually performing a correct check before. (-[WebHTMLView keyDown:]): Renamed _canType to _canEdit. (-[WebHTMLView paste:]): Don't beep if can't paste. This matches AppKit. Any paste-related beeps will come from failure to handle key equivalent. Menu validation will kick in to dim menu. (-[WebHTMLView _applyStyleToSelection:]): Bail if !_canEdit. (-[WebHTMLView pasteAsPlainText:]): Ditto. (-[WebHTMLView _alignSelectionUsingCSSValue:]): Ditto. (-[WebHTMLView insertNewline:]): Ditto. (-[WebHTMLView insertParagraphSeparator:]): Ditto. (-[WebHTMLView _changeWordCaseWithSelector:]): Ditto. (-[WebHTMLView _deleteWithDirection:granularity:killRing:]): Ditto. (-[WebHTMLView complete:]): Ditto. (-[WebHTMLView _changeSpellingToWord:]): Ditto. Some code rearranging to eliminate bridge local variable. (-[WebHTMLView ignoreSpelling:]): Ditto. (-[WebHTMLView yank:]): Bail if !_canEdit. (-[WebHTMLView yankAndSelect:]): Ditto. (-[WebHTMLView deleteToMark:]): Ditto. (-[WebHTMLView swapWithMark:]): Ditto. (-[WebHTMLView transpose:]): Ditto. (-[WebHTMLView _updateFontPanel]): Ditto. Some code rearranging to eliminate bridge local variable. (-[WebHTMLView setMarkedText:selectedRange:]): Bail if !_canEdit. (-[WebHTMLView _insertText:selectInsertedText:]): Ditto. Some code rearranging to eliminate bridge local variable.
  • WebView.subproj/WebHTMLViewPrivate.h: Renamed _canType to _canEdit.
9:37 AM Changeset in webkit [7666] by kocienda
  • 2 edits in trunk/WebKit

Reviewed by me

  • WebCoreSupport.subproj/WebDashboardRegion.h: Check in file copied from WebCore.
8:35 AM Changeset in webkit [7665] by sullivan
  • 2 adds in trunk/LayoutTests/fast/tokenizer

Layout tests for acceptable and unacceptable values of "language" and "type" attributes for <script> tags.

Note: See TracTimeline for information about the timeline view.