Context Navigation

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:isTypingAction:]): (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): (-[WebHTMLView _deleteWithDirection:granularity:killRing:isTypingAction:]): (-[WebHTMLView selectToMark:]): (-[WebHTMLView swapWithMark:]): (-[WebHTMLView transpose:]): (-[WebHTMLView _selectMarkedText]): (-[WebHTMLView _selectRangeInMarkedText:]): Adopt new default affinity of NSSelectionAffinityDownstream as of <rdar://problem/3937447>.

4:35 PM Changeset in webkit [8572] by kocienda

2 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3992092> 8A374: Mail crash while pasting - RemoveNodeCommand

khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply): Code tried to remove a node that was no longer in the document. We try to do a good job of detecting all these cases, and generally do. This one was missed. Fixed.

3:50 PM Changeset in webkit [8571] by darin

2 edits in trunk/WebKit

Reviewed by Harrison.

fixed <rdar://problem/4002084> Setting ResourceLoadDelegate to nil can cause a crash

WebView.subproj/WebView.m: (-[WebView _cacheResourceLoadDelegateImplementations]): Set booleans to either YES or NO, rather than setting them only in the YES case.

3:48 PM Changeset in webkit [8570] by darin

2 edits in trunk/WebKit

Reviewed by Harrison.

fixed <rdar://problem/3991225> Format->Style->Underline menu item does not get checked when selected text is underlined

WebView.subproj/WebHTMLView.m: (-[WebHTMLView validateUserInterfaceItem:]): Added tons of additional cases in here for all the "action" style methods in this class that don't always want to be valid. For the ones where state makes sense, added the state-checking code too for the menu item case. (-[WebHTMLView ignoreSpelling:]): Removed unnecessary "editable text only" check since this command would work fine on a non-editable selection. (-[WebHTMLView swapWithMark:]): Ditto. (-[WebHTMLView changeBaseWritingDirection:]): Added. Like toggle, but based on the sender's tag.

3:47 PM Changeset in webkit [8569] by darin

3 edits in trunk/WebCore

Reviewed by Harrison.

added support needed to fix <rdar://problem/3991225> Format->Style->Underline menu item does not get checked when selected text is underlined

kwq/WebCoreBridge.h: Added selectionHasStyle: method.
kwq/WebCoreBridge.mm: (-[WebCoreBridge selectionHasStyle:]): Added. Calls selectionHasStyle on the part.

2:51 PM Changeset in webkit [8568] by darin

5 edits in trunk/WebCore

Reviewed by Harrison.

fixed <rdar://problem/3990484> cursor changes to I-beam when moving over text in widgets, even when selection off via CSS

khtml/khtmlview.cpp: (KHTMLView::viewportMouseMoveEvent): Changed code to check canSelect when deciding whether to show an I-beam cursor.

khtml/rendering/render_object.h: Added canSelect.
khtml/rendering/render_object.cpp: (selectStartNode): Added. Helper function with the guts of shouldSelect. (RenderObject::canSelect): Added. Like shouldSelect, but does not call the "start selecting" event handler. (RenderObject::shouldSelect): Refactored to use selectStartNode.

khtml/css/cssvalues.c: Regnerated with newer gperf.

2:30 PM Changeset in webkit [8567] by hyatt

3 edits in trunk/WebCore

Fix for 3867759, .mac regression where scrollers don't show up. Make sure you can set the .width and
.height properties on the Image object.

Reviewed by John Sullivan

khtml/ecma/kjs_html.cpp: (ImageConstructorImp::construct): (Image::getValueProperty): (Image::putValue): (Image::Image):
khtml/ecma/kjs_html.h:

2:25 PM Changeset in webkit [8566] by kocienda

10 edits
4 adds in trunk

Reviewed by Chris

Fix for this bug:

<rdar://problem/3965158> Drag-n-drop within a rich text message sometimes changes the color of the dragged text

This change fixes the bug....and much more. Now, for the first time, the paste code can do "smart merging"
or "smooshing" of styles during its operation. Since this new code is actively, rather than passively
working with styles, it fixes the bug, and lays the groundwork for similar work we need to do to
preserve quote levels in Mail.

khtml/css/css_valueimpl.cpp: (DOM::CSSMutableStyleDeclarationImpl::clear): New method. (DOM::CSSMutableStyleDeclarationImpl::removeBlockProperties): Ditto. (DOM::CSSMutableStyleDeclarationImpl::removePropertiesInSet): Ditto. (DOM::operator==): Add operator for CSSProperty.
khtml/css/css_valueimpl.h: Declare new functions.
khtml/editing/htmlediting.cpp: (khtml::isEmptyStyleSpan): Improved the test in this function, rolling together the old implementation with some code that did this work inline elsewhere. Sum of the parts is better than either test was by itself. (khtml::isStyleSpan): Check for ID_SPAN. (khtml::ApplyStyleCommand::removeCSSStyle): Call isEmptyStyleSpan. This was the place with an inline implementation before. (khtml::ReplacementFragment::ReplacementFragment): Now takes a DocumentImpl argument. No longer does a "default style" check, but rather calls functions which do a similar check to that, and much more. (khtml::ReplacementFragment::~ReplacementFragment): Deref document, and computed styles. (khtml::ReplacementFragment::styleForNode): New helper. Looks up and returns computed style for a node. (khtml::ReplacementFragment::removeNodePreservingChildren): New helper. (khtml::ReplacementFragment::computeStylesForNodes): New function which computes the "desired" style for every node in the fragment. This information is used later after paste is done as a reference for testing what styles need to be added, and which can be removed as redundant, from all the nodes inserted by the replacement code. (khtml::ReplacementFragment::removeStyleNodes): Clears out all style nodes from the fragment. They are no longer needed after the call to computeStylesForNodes(), (khtml::ReplaceSelectionCommand::ReplaceSelectionCommand): Add a document to the call to initialize the command's ReplacementFragment. (khtml::ReplaceSelectionCommand::doApply): Call applyStyleToInsertedNodes() after inserting nodes to make styles come out right. (khtml::ReplaceSelectionCommand::applyStyleToInsertedNodes): This is the "style smooshing" function. It computes the styles that need to be added to each node inserted, comparing the style it gets from just being inserted into its correct destination with the computed "desired style" done in the ReplacementFragment constructor. It then adds in all the necessary styles, and will also remove redundant styles.
khtml/editing/htmlediting.h: Update declarations and member variables as needed.
khtml/editing/markup.cpp: (khtml::startMarkup): Add additional style annotations to the markup we generate, so that paste code can preserve it. (khtml::markup): Ditto. (khtml::createMarkup): Ditto.

These test results are subtly better with this change. They no longer have an unneeded empty span.
Visually the same as before.

layout-tests/editing/style/remove-underline-across-paragraph-expected.txt
layout-tests/editing/style/remove-underline-across-paragraph-in-bold-expected.txt
layout-tests/editing/style/remove-underline-expected.txt
layout-tests/editing/style/remove-underline-from-stylesheet-expected.txt

New tests:

layout-tests/editing/style/smoosh-styles-001-expected.txt
layout-tests/editing/style/smoosh-styles-002-expected.txt
layout-tests/editing/style/smoosh-styles-001.html
layout-tests/editing/style/smoosh-styles-002.html

1:29 PM Changeset in webkit [8565] by darin

2 edits in trunk/WebCore

Reviewed by Adele.

fixed <rdar://problem/3974988> WebHTMLView drops scroll wheel events when deltas are 0

kwq/WebCoreScrollView.m: (-[WebCoreScrollView autoforwardsScrollWheelEvents]): Added, for Tiger only. For Tiger, removed the override of scrollWheel:, which doesn't work quite right because of how the delta attributes return all 0 for newfangled scrolling events from the new trackpads.

11:46 AM Changeset in webkit [8564] by darin

1 edit
1 delete in trunk/JavaScriptCore

"Reviewed" by Richard (he told me the file was obsolete).

got rid of an obsolete file

bindings/npsap.h: Removed.

11:45 AM Changeset in webkit [8563] by darin

2 edits
1 delete in trunk/WebKit

"Reviewed" by Richard (he told me the file was obsolete).

got rid of an obsolete file

Plugins.subproj/npsap.h: Removed.
copy-webcore-files-to-webkit: Removed npsap.h.

11:12 AM Changeset in webkit [8562] by harrison

3 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3991532> REGRESSION (Mail): Triple-click on trailing blank line should select previous line but doesn't

khtml/css/cssvalues.c: (hash_val): (findValue):
khtml/editing/selection.cpp: (khtml::Selection::validate): Do moral equiavalent of LeftWordIfOnBoundary for PARAGRAPH.

11:03 AM Changeset in webkit [8561] by harrison

3 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3991848> Double-click on first character selects wrong item

khtml/editing/selection.cpp: (khtml::Selection::validate): Honor the fact that clicking on a character positions the cursor on the left side of the character.

2:21 AM Changeset in webkit [8560] by hyatt

2 edits in trunk/WebCore

Fix for 3980778, repro crash in RootInlineBox::paint. Make sure that when merging blocks we dirty them for layout
up front. That way as we do the merge, we dont attempt to examine the lines in dirtyLinesForChangedChild.

Reviewed by mjs

khtml/rendering/render_block.cpp: (khtml::RenderBlock::removeChild):

1:55 AM Changeset in webkit [8559] by hyatt

2 edits in trunk/WebCore

Fix for 3987010, fix a bug that caused the self-collapsing-block-cleared-float bit to never get set correctly.

Reviewed by mjs

khtml/rendering/render_block.h: (khtml::RenderBlock::MarginInfo::setSelfCollapsingBlockClearedFloat):

1:34 AM Changeset in webkit [8558] by hyatt

2 edits in trunk/WebCore

Fix for 3992440, text not wrapping correctly on half moon bay web site. Refine an incorrect optimization I
added to be less restrictive.

Reviewed by mjs

khtml/rendering/render_block.cpp: (khtml::RenderBlock::layoutBlockChildren):

12:40 AM Changeset in webkit [8557] by mjs

5 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3977973> pages on ebay leak referenced JavaScript objects -- over time browsing becomes super-slow

I fixed this by removing all event listeners for a document, it's
children, and any disconnected nodes that used to be in the
document at document detach time. Mozilla temporarily disables
event listeners on such nodes, but re-enables them if you
re-parant a node into a new document. However, in WebCore, you
can't re-parent a node into another document, so there is no
observable change in behavior.

We have to do this to break the possible reference cycles between
event listeners and the dom nodes they are attached to (e.g. via
scope chain, as in this case).

khtml/xml/dom_docimpl.cpp: (DocumentImpl::detach): (DocumentImpl::removeAllEventListenersFromAllNodesx): (DocumentImpl::registerDisconnectedNodeWithEventListeners): (DocumentImpl::unregisterDisconnectedNodeWithEventListeners): (DocumentImpl::removeAllDisconnectedNodeEventListeners):
khtml/xml/dom_docimpl.h:
khtml/xml/dom_nodeimpl.cpp: (NodeImpl::~NodeImpl): (NodeImpl::addEventListener): (NodeImpl::removeEventListener): (NodeImpl::removeAllEventListeners): (NodeImpl::removeHTMLEventListener): (NodeImpl::insertedIntoDocument): (NodeImpl::removedFromDocument):
khtml/xml/dom_nodeimpl.h:

Feb 9, 2005:

4:39 PM Changeset in webkit [8556] by cblu

2 edits in trunk/WebCore

Fixed: <rdar://problem/3999213> Sometimes 2 Windows Media Player plugin instances are loaded

Reviewed by hyatt.

khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::attach): Set needWidgetUpdate to false before calling updateWidget because updateWidget may cause this method or another method (which also calls updateWidget) to be called. (HTMLObjectElementImpl::recalcStyle): ditto

4:33 PM Changeset in webkit [8555] by rjw

2 edits in trunk/WebKit

Fixed <rdar://problem/4000073> non-screen font error on www.worldofwarcraft.com

Reviewed by John Sullivan.

WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _smallCapsFont]):

4:30 PM Changeset in webkit [8554] by harrison

23 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3937447> Mail-689: Arrow key navigation in new message body stops working when a line ends with a bold word

Added affinity to VisiblePosition. Changed Selection code to use affinity more.

(Partial) <rdar://problem/3982096> editing/pasteboard/paste-text-007 is failing

Changed ReplaceSelectionCommand to also pay attention to the top children of the incoming fragment, not just the very last node inserted, when deciding whether to insert a paragraph for the Apple interchange newline.

khtml/ecma/kjs_window.cpp: (SelectionFunc::tryCall):
khtml/editing/htmlediting.cpp: (khtml::EditCommandPtr::setStartingSelection): (khtml::EditCommandPtr::setEndingSelection): (khtml::EditCommand::setStartingSelection): (khtml::EditCommand::setEndingSelection): (khtml::CompositeEditCommand::deleteInsignificantTextDownstream): (khtml::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): (khtml::ApplyStyleCommand::splitTextAtStartIfNeeded): (khtml::ApplyStyleCommand::splitTextAtEndIfNeeded): (khtml::ApplyStyleCommand::splitTextElementAtStartIfNeeded): (khtml::ApplyStyleCommand::splitTextElementAtEndIfNeeded): (khtml::ApplyStyleCommand::mergeStartWithPreviousIfIdentical): (khtml::ApplyStyleCommand::mergeEndWithNextIfIdentical): (khtml::ApplyStyleCommand::joinChildTextNodes): (khtml::DeleteSelectionCommand::initializePositionData): (khtml::DeleteSelectionCommand::handleGeneralDelete): (khtml::DeleteSelectionCommand::calculateTypingStyleAfterDelete): (khtml::DeleteSelectionCommand::doApply): (khtml::InsertLineBreakCommand::doApply): (khtml::InsertParagraphSeparatorCommand::doApply): (khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply): (khtml::InsertTextCommand::input): (khtml::MoveSelectionCommand::doApply): (khtml::ReplaceSelectionCommand::ReplaceSelectionCommand): (khtml::ReplaceSelectionCommand::~ReplaceSelectionCommand): (khtml::ReplaceSelectionCommand::doApply): (khtml::ReplaceSelectionCommand::completeHTMLReplacement): (khtml::ReplaceSelectionCommand::updateNodesInserted): (khtml::TypingCommand::deleteKeyPressed): (khtml::TypingCommand::forwardDeleteKeyPressed): (khtml::TypingCommand::markMisspellingsAfterTyping):
khtml/editing/htmlediting.h:
khtml/editing/selection.cpp: (khtml::Selection::Selection): (khtml::Selection::init): (khtml::Selection::moveTo): (khtml::Selection::modifyExtendingRightForward): (khtml::Selection::modifyMovingRightForward): (khtml::Selection::modifyExtendingLeftBackward): (khtml::Selection::modifyMovingLeftBackward): (khtml::Selection::modify): (khtml::Selection::xPosForVerticalArrowNavigation): (khtml::Selection::clear): (khtml::Selection::setBase): (khtml::Selection::setExtent): (khtml::Selection::setBaseAndExtent): (khtml::Selection::layout): (khtml::Selection::validate):
khtml/editing/selection.h: (khtml::Selection::startAffinity): (khtml::Selection::endAffinity): (khtml::Selection::baseAffinity): (khtml::Selection::extentAffinity): (khtml::operator==):
khtml/editing/text_affinity.h: (khtml::):
khtml/editing/visible_position.cpp: (khtml::VisiblePosition::VisiblePosition): (khtml::VisiblePosition::init): (khtml::VisiblePosition::initUpstream): (khtml::VisiblePosition::initDownstream): (khtml::VisiblePosition::next): (khtml::VisiblePosition::previous): (khtml::startVisiblePosition): (khtml::endVisiblePosition):
khtml/editing/visible_position.h: (khtml::VisiblePosition::): (khtml::VisiblePosition::VisiblePosition): (khtml::VisiblePosition::affinity): (khtml::VisiblePosition::setAffinity): (khtml::operator==):
khtml/editing/visible_units.cpp: (khtml::previousBoundary): (khtml::nextBoundary): (khtml::startOfLine): (khtml::endOfLine): (khtml::previousLinePosition): (khtml::nextLinePosition): (khtml::startOfParagraph): (khtml::endOfParagraph): (khtml::previousParagraphPosition): (khtml::nextParagraphPosition): (khtml::startOfBlock): (khtml::endOfBlock): (khtml::startOfDocument): (khtml::endOfDocument):
khtml/editing/visible_units.h:
khtml/khtml_part.cpp: (KHTMLPart::findTextNext): (KHTMLPart::selectClosestWordFromMouseEvent): (KHTMLPart::handleMousePressEventTripleClick): (KHTMLPart::handleMousePressEventSingleClick): (KHTMLPart::handleMouseMoveEventSelection): (KHTMLPart::khtmlMouseReleaseEvent): (KHTMLPart::selectAll): (KHTMLPart::computeAndSetTypingStyle): (KHTMLPart::selectionComputedStyle):
khtml/rendering/render_br.cpp: (RenderBR::positionForCoordinates):
khtml/xml/dom_docimpl.cpp: (DocumentImpl::updateSelection):
khtml/xml/dom_nodeimpl.cpp: (NodeBaseImpl::setFocus):
khtml/xml/dom_position.cpp: (DOM::Position::previousCharacterPosition): (DOM::Position::nextCharacterPosition):
khtml/xml/dom_position.h:
kwq/KWQAccObject.mm: (-[KWQAccObject value]): (-[KWQAccObject visiblePositionForStartOfTextMarkerRange:]): (-[KWQAccObject visiblePositionForEndOfTextMarkerRange:]): (-[KWQAccObject accessibilityAttributeValue:]): (-[KWQAccObject doAXLineForTextMarker:]): (-[KWQAccObject doAXTextMarkerRangeForLine:]): (-[KWQAccObject doAXTextMarkerForPosition:]): (-[KWQAccObject doAXLeftLineTextMarkerRangeForTextMarker:]): (-[KWQAccObject doAXRightLineTextMarkerRangeForTextMarker:]): (-[KWQAccObject doAXNextWordEndTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousWordStartTextMarkerForTextMarker:]): (-[KWQAccObject doAXNextLineEndTextMarkerForTextMarker:]): (-[KWQAccObject doAXPreviousLineStartTextMarkerForTextMarker:]): (-[KWQAccObject doSetAXSelectedTextMarkerRange:]):
kwq/KWQAccObjectCache.mm: (KWQAccObjectCache::textMarkerForVisiblePosition): (KWQAccObjectCache::visiblePositionForTextMarker):
kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::findString): (KWQKHTMLPart::advanceToNextMisspelling): (KWQKHTMLPart::styleForSelectionStart): (KWQKHTMLPart::baseWritingDirectionForSelectionStart): (KWQKHTMLPart::setSelectionFromNone): (KWQKHTMLPart::respondToChangedSelection):
kwq/WebCoreBridge.mm: (-[WebCoreBridge setSelectedDOMRange:affinity:]): (-[WebCoreBridge selectionAffinity]): (-[WebCoreBridge setMarkDOMRange:]): (-[WebCoreBridge _visiblePositionForPoint:]): (-[WebCoreBridge moveDragCaretToPoint:]): (-[WebCoreBridge editableDOMRangeForPoint:]): (-[WebCoreBridge ensureSelectionVisible]): (-[WebCoreBridge rangeOfCharactersAroundCaret]):

1:52 PM Changeset in webkit [8553] by cblu

3 edits in trunk/WebCore

Fixed: <rdar://problem/3985211> Seed: Mail: Drag-and-drop destination indicator / insertion point disappears

Reviewed by kocienda.

khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintCaret): new (khtml::RenderBlock::paintObject): call paintCaret for the cursor caret and the drag caret
khtml/rendering/render_block.h:

1:30 PM Changeset in webkit [8552]

10 copies
4 deletes in tags/JavaScriptCore-125~6~1

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-125~6~1'.

1:30 PM Changeset in webkit [8551] by rjw

1 edit in branches/Safari-1-2-branch/JavaScriptCore/JavaScriptCore.pbproj/project.pbxproj

Added "-lobjc" for buildit.

10:42 AM Changeset in webkit [8550] by adele

2 edits in branches/Safari-1-2-branch/JavaScriptCore

Versioning for the Panther Security Update 2005-002

Feb 8, 2005:

6:11 PM Changeset in webkit [8549] by rjw

1 edit in branches/Safari-1-2-branch/JavaScriptCore/JavaScriptCore.pbproj/project.pbxproj

More changes for Java update.

6:05 PM Changeset in webkit [8548] by rjw

2 edits in branches/Safari-1-2-branch/JavaScriptCore/bindings

More stuff for Java update.

5:45 PM Changeset in webkit [8547] by rjw

23 edits
2 deletes in branches/Safari-1-2-branch/JavaScriptCore

ck-ported Java LiveConnect implementation from Tiger/SUPanWheat.

Reviewed by Darin.

JavaScriptCore.pbproj/project.pbxproj:
Makefile.am:
bindings/jni/jni_class.cpp: (JavaClass::methodsNamed): (JavaClass::fieldNamed):
bindings/jni/jni_class.h:
bindings/jni/jni_instance.cpp: (JavaInstance::JavaInstance): (JavaInstance::invokeMethod): (JavaInstance::invokeDefaultMethod):
bindings/jni/jni_instance.h:
bindings/jni/jni_jsobject.cpp: Added. (isJavaScriptThread): (JSObject::invoke): (JSObject::JSObject): (JSObject::call): (JSObject::eval): (JSObject::getMember): (JSObject::setMember): (JSObject::removeMember): (JSObject::getSlot): (JSObject::setSlot): (JSObject::toString): (JSObject::finalize): (JSObject::createNative): (JSObject::convertValueToJObject): (JSObject::convertJObjectToValue): (JSObject::listFromJArray):
bindings/jni/jni_jsobject.h: Added. (KJS::Bindings::):
bindings/jni/jni_objc.mm: Added. (convertNSStringToString): (KJS::Bindings::dispatchJNICall): (KJS::Bindings::getLastPolledView): (pollForAppletInView): (initializeWorkaround):
bindings/jni/jni_runtime.cpp: (JavaField::JavaField): (JavaArray::convertJObjectToArray): (JavaField::dispatchValueFromInstance): (JavaField::valueFromInstance): (JavaField::dispatchSetValueToInstance): (JavaField::setValueToInstance): (JavaMethod::JavaMethod): (JavaArray::JavaArray): (JavaArray::valueAt):
bindings/jni/jni_runtime.h: (KJS::Bindings::JavaString::JavaString): (KJS::Bindings::JavaString::_commonInit): (KJS::Bindings::JavaString::UTF8String): (KJS::Bindings::JavaString::uchars): (KJS::Bindings::JavaString::length): (KJS::Bindings::JavaString::ustring): (KJS::Bindings::JavaMethod::returnType): (KJS::Bindings::JavaMethod::isStatic): (KJS::Bindings::JavaArray::operator=): (KJS::Bindings::JavaArray::executionContext):
bindings/jni/jni_utility.cpp: (callJNIStaticMethod): (KJS::Bindings::getMethodID): (KJS::Bindings::callJNIStaticBooleanMethod): (KJS::Bindings::getJNIField): (KJS::Bindings::convertValueToJValue):
bindings/jni/jni_utility.h:
bindings/jni_jsobject.cpp: Removed.
bindings/jni_jsobject.h: Removed.
bindings/runtime.cpp: (MethodList::MethodList): (MethodList::operator=): (Instance::setDidExecuteFunction): (Instance::didExecuteFunction): (Instance::getValueOfField): (Instance::setValueOfField): (Instance::createBindingForLanguageInstance): (Instance::createRuntimeObject): (Instance::Instance): (Instance::operator=):
bindings/runtime.h: (KJS::Bindings::Class::fallbackObject): (KJS::Bindings::Instance::): (KJS::Bindings::Instance::Instance): (KJS::Bindings::Instance::getValueOfUndefinedField): (KJS::Bindings::Instance::supportsSetValueOfUndefinedField): (KJS::Bindings::Instance::setValueOfUndefinedField): (KJS::Bindings::Instance::valueOf): (KJS::Bindings::Instance::setExecutionContext): (KJS::Bindings::Instance::executionContext):
bindings/runtime_array.cpp: (RuntimeArrayImp::RuntimeArrayImp): (RuntimeArrayImp::get):
bindings/runtime_array.h:
bindings/runtime_method.cpp: (RuntimeMethodImp::RuntimeMethodImp): (RuntimeMethodImp::get): (RuntimeMethodImp::call):
bindings/runtime_method.h:
bindings/runtime_object.cpp: (RuntimeObjectImp::~RuntimeObjectImp): (RuntimeObjectImp::RuntimeObjectImp): (RuntimeObjectImp::get): (RuntimeObjectImp::put): (RuntimeObjectImp::canPut): (RuntimeObjectImp::hasProperty): (RuntimeObjectImp::defaultValue): (RuntimeObjectImp::implementsCall): (RuntimeObjectImp::call):
bindings/runtime_object.h:
kjs/ustring.cpp: (KJS::CString::operator=):

5:45 PM Changeset in webkit [8546]

5 copies in branches/Safari-1-2-branch/JavaScriptCore/bindings

This commit was manufactured by cvs2svn to create branch
'Safari-1-2-branch'.

3:41 PM Changeset in webkit [8545] by vicki

3 edits in trunk

Versioning for TOT, Safari 2.0 (185+). The tree is open.

3:31 PM Changeset in webkit [8544]

1 copy in tags/Safari-185

This commit was manufactured by cvs2svn to create tag 'Safari-185'.

3:31 PM Changeset in webkit [8543] by vicki

6 edits in trunk

Safari-185 stamp (can't use 184 b/c of the "4", of course)

9:33 AM Changeset in webkit [8542] by kocienda

2 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3996344> Entire document content is deleted when only the first paragraph was supposed to be

Problem stems from my attempt to fix this bug: <rdar://problem/3986155> Insertion point goes
to beginning of doc after deleting.

I added an "optimization" that proved to do more harm than good. So, basically, the fix is to remove code.

khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::handleGeneralDelete)

8:53 AM Changeset in webkit [8541] by darin

1 edit in trunk/WebCore/ChangeLog-2005-08-23

Reviewed by Kevin.

fixed <rdar://problem/3890352> REGRESSION (125-170, Panther-only): pasted textarea contents disappear (exception in NSText)

kwq/KWQTextArea.mm: (-[KWQTextArea tile]): Don't resize the text view immediately here. Use performWithDelay to defer it to avoid the re-entrancy that bothers the Panther version of NSTextView. On Tiger, leave the code alone.

8:52 AM Changeset in webkit [8540] by darin

2 edits in trunk/WebCore

Reviewed by NOBODY (OOPS!).

fixed <rdar://problem/3890352> REGRESSION (125-170, Panther-only): pasted textarea contents disappear (exception in NSText)

kwq/KWQTextArea.mm: (-[KWQTextArea tile]): Don't resize the text view immediately here. Use performWithDelay to defer it to avoid the re-entrancy that bothers the Panther version of NSTextView. On Tiger, leave the code alone.

Feb 7, 2005:

5:33 PM Changeset in webkit [8539] by adele

2 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/3993628> REGRESSION (180-181): Logitelnet bank's website doesn't work

This fixes an oversight in the fix for <rdar://problem/3964286>.
We're now making sure there is a document before calling checkCompleted in slotLoaderRequestDone.

That function is called even when other parts finish loads of their subresources, so we could end

up calling checkCompleted before we had a document. We also looked over all the other calls to
checkCompleted to convince ourselves no other call sites had a similar issue.

khtml/khtml_part.cpp: (KHTMLPart::slotLoaderRequestDone): Check if doc is nil before calling checkCompleted.

2:42 PM Changeset in webkit [8538] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3993354> Safari claims to put RTFD on the pasteboard, but doesn't, in some cases

Reviewed by john.

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _stripAttachmentCharactersFromAttributedString:]): moved (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]): take cachedAttributedString parameter in case the attributed string was gotten already (-[WebHTMLView _writeSelectionToPasteboard:]): omit RTFD from the types list when there are no attachments

1:09 PM Changeset in webkit [8537] by harrison

2 edits in trunk/WebKit

Reviewed by Ken.

<rdar://problem/3990693> REGRESSION (8A373): ctrl-k now deletes just one character instead of line

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _deleteWithDirection:granularity:killRing:isTypingAction:]): Set the selection so that deleteKeyPressedWithSmartDelete knows what to delete.

8:32 AM Changeset in webkit [8536] by kocienda

11 edits in trunk

Reviewed by Darin

Fix for this bug:

<rdar://problem/3953302> Replacing quoted text ends up with blue-colored text that is not quoted

khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::doApply): Removed special case delete code for select all. It was causing as many bugs as it fixed. What's more, the design concept is a bit shaky. By removing this special case, the bug goes away.
khtml/editing/htmlediting.h: Remove declaration.

Test results using selectAll() updated to reflect changed behavior.

layout-tests/editing/deleting/delete-3775172-fix-expected.txt:
layout-tests/editing/deleting/delete-select-all-001-expected.txt:
layout-tests/editing/deleting/delete-select-all-003-expected.txt:
layout-tests/editing/inserting/insert-3654864-fix-expected.txt:
layout-tests/editing/inserting/insert-3775316-fix-expected.txt:
layout-tests/editing/inserting/insert-3851164-fix-expected.txt:
layout-tests/editing/inserting/insert-3907422-fix-expected.txt:
layout-tests/editing/pasteboard/paste-text-015-expected.txt:

8:26 AM Changeset in webkit [8535] by darin

4 edits in trunk/WebCore

Reviewed by Ken.

fixed <rdar://problem/3994164> setting a new style attribute with setAttribute("style") doesn't blow away the old style

khtml/css/css_valueimpl.h: Renamed parseProperty to parseDeclaration, since it's used to parse an entire style declaration, not a single property.
khtml/css/css_valueimpl.cpp: (DOM::CSSMutableStyleDeclarationImpl::parseDeclaration): Renamed, and added code to clear m_values.
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseHTMLAttribute): Call function by its new name, and remove some unnecessary comments.

Feb 6, 2005:

10:44 PM Changeset in webkit [8534] by darin

2 edits in trunk/WebCore

Reviewed by Maciej.

fixed <rdar://problem/3993722> need oncut and onpaste handlers implemented for <textarea> (needed for widgets)

kwq/KWQTextArea.mm: (-[KWQTextAreaTextView dispatchHTMLEvent:]): Added. (-[KWQTextAreaTextView cut:]): Dispatch "before cut" and "cut" events. (-[KWQTextAreaTextView copy:]): Dispatch "before copy" and "copy" events. (-[KWQTextAreaTextView paste:]): Dispatch "before paste" and "paste" events. (-[KWQTextAreaTextView pasteAsPlainText:]): Ditto. (-[KWQTextAreaTextView pasteAsRichText:]): Ditto.

10:37 PM Changeset in webkit [8533] by darin

3 edits in trunk/WebCore

Reviewed by Maciej.

fixed <rdar://problem/3943038> <input type=search> that is focused in onload handler doesn't have a visible editor

khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): Always update layout before giving focus to a widget. This prevents the bad case where we give a widget focus before it has been positioned or sized, causing us to exercise edge cases AppKit doesn't handle well.

kwq/KWQTextField.mm: (-[KWQTextFieldController initWithTextField:QLineEdit:]): Remove workaround code I added to fix bug 3943049. Updating the layout fixes the same problem in a cleaner, safer way, and solves another problem, with the way the clip view is set up.

10:31 PM Changeset in webkit [8532] by darin

3 edits in trunk/WebCore

Reviewed by Maciej.

fixed <rdar://problem/3425232> textarea won't trigger onchange action when clicking to new field

khtml/rendering/render_form.h: Added new m_dirty data member.
khtml/rendering/render_form.cpp: (RenderTextArea::RenderTextArea): Initialize m_dirty to false. (RenderTextArea::detach): Call value() on the DOM element to cause it to fetch the value from this object. (RenderTextArea::handleFocusOut): Ditto. Also send the onchange event based only on the m_dirty flag. (RenderTextArea::updateFromElement): Clear the m_dirty flag if the edited value is blown away by a value that comes from the DOM element. Remove code to clear the element's m_dirtyvalue flag; that's an unnecessary optimization, and ideally we'll stop having code in the render object that knows about that flag later. (RenderTextArea::slotTextChanged): Set the m_dirty flag.

10:26 PM Changeset in webkit [8531] by darin

2 edits in trunk/WebCore

Reviewed by Maciej.

re-fixed <rdar://problem/3760910> please add support for custom tag names in HTML

khtml/xml/dom_docimpl.cpp: (DocumentImpl::tagId): Use ID_LAST_TAG + 1 for the ID of the first assigned tag ID. Before we'd use ID_LAST_TAG, which resulted in the same number being used for ID_COMMENT and the first custom tag. (DocumentImpl::tagName): Use ID_LAST_TAG + 1, as above. (DocumentImpl::namespaceURI): Change a < ID_LAST_TAG to <= ID_LAST_TAG in the same spirit as above.

10:18 PM Changeset in webkit [8530] by darin

2 edits in trunk/WebCore

Reviewed by Maciej.

fixed <rdar://problem/3986639> Crash occurs after choosing Undo Typing from the Edit menu

kwq/KWQTextArea.mm: (-[KWQTextArea viewWillMoveToWindow:]): Remove actions from undo manager when the view is removed from the window. Unfortunately, to do this the code has to know that the target of NSTextView actions will be the text storage object, but given the NSText architecture, that's pretty clear.

10:13 PM Changeset in webkit [8529] by darin

3 edits in trunk/WebKit

Reviewed by Maciej.

fixed <rdar://problem/3963166> PDFView SPI print method is being deprecated, moving to PDFDocument; please update WebKit

WebView.subproj/WebPDFView.m: (-[WebPDFView printOperationWithPrintInfo:]): Target the document instead of the view.

English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes and also moved one translation to be a file-specific item rather than a file-independent one.

12:19 PM Changeset in webkit [8528] by cblu

6 edits in trunk

WebCore:

Fixed: <rdar://problem/3991974> REGRESSION: www.jabra.com world location screen does not work

Reviewed by hyatt.

kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::KJavaAppletWidget): fallback to the document's base URL if there is no baseURL attribute
kwq/WebCoreBridge.h:
kwq/WebCoreBridge.mm: (-[WebCoreBridge baseURL]): new

WebKit:

Fixed: <rdar://problem/3991974> REGRESSION: www.jabra.com world location screen does not work

Reviewed by hyatt.

WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:]): use the baseURL from the bridge rather than from the response

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed