Timeline



May 15, 2006:

10:33 PM Changeset in webkit [14407] by eseidel
  • 54 edits
    42 copies
    4 moves in trunk/WebCore

2006-05-15 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

Split css_valueimpl.* and css_ruleimpl.* into separate files (one per class).
http://bugzilla.opendarwin.org/show_bug.cgi?id=8934

  • WebCore+SVG/RGBColor.cpp: (WebCore::RGBColor::RGBColor):
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_css.cpp: (KJS::DOMCSSRule::classInfo):
  • bindings/js/kjs_css.h:
  • bindings/js/kjs_dom.cpp:
  • bindings/js/kjs_html.cpp:
  • bindings/js/kjs_window.cpp:
  • bindings/objc/DOMCSS.mm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • css/CSSBorderImageValue.cpp: Added. (WebCore::CSSBorderImageValue::CSSBorderImageValue):
  • css/CSSBorderImageValue.h: Added.
  • css/CSSCharsetRule.h: Added. (WebCore::CSSCharsetRule::CSSCharsetRule):
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForShadow): (WebCore::):
  • css/CSSComputedStyleDeclaration.h:
  • css/CSSFontFaceRule.cpp: Added. (WebCore::CSSFontFaceRule::CSSFontFaceRule):
  • css/CSSFontFaceRule.h: Added. (WebCore::CSSFontFaceRule::isFontFaceRule):
  • css/CSSGrammar.y:
  • css/CSSImageValue.cpp: Added. (WebCore::CSSImageValue::CSSImageValue):
  • css/CSSImageValue.h: Added.
  • css/CSSImportRule.cpp: Added.
  • css/CSSImportRule.h: Added.
  • css/CSSInheritedValue.cpp: Added.
  • css/CSSInheritedValue.h: Added.
  • css/CSSInitialValue.cpp: Added.
  • css/CSSInitialValue.h: Added.
  • css/CSSMediaRule.cpp: Added. (WebCore::CSSMediaRule::CSSMediaRule): (WebCore::CSSMediaRule::~CSSMediaRule): (WebCore::CSSMediaRule::append): (WebCore::CSSMediaRule::deleteRule): (WebCore::CSSMediaRule::cssText):
  • css/CSSMediaRule.h: Added. (WebCore::CSSMediaRule::media): (WebCore::CSSMediaRule::cssRules):
  • css/CSSMutableStyleDeclaration.cpp: Added. (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration): (WebCore::CSSMutableStyleDeclaration::setChanged):
  • css/CSSMutableStyleDeclaration.h: Added.
  • css/CSSPageRule.cpp: Added. (WebCore::CSSPageRule::CSSPageRule):
  • css/CSSPageRule.h: Added. (WebCore::CSSPageRule::isPageRule):
  • css/CSSPrimitiveValue.cpp: Added.
  • css/CSSPrimitiveValue.h: Added.
  • css/CSSProperty.cpp: Added. (WebCore::CSSProperty::cssText):
  • css/CSSProperty.h: Added. (WebCore::CSSProperty::CSSProperty):
  • css/CSSQuirkPrimitiveValue.h: Added.
  • css/CSSRule.cpp: Added.
  • css/CSSRule.h: Added. (WebCore::CSSRule::CSSRule):
  • css/CSSRuleList.cpp: Added. (WebCore::CSSRuleList::CSSRuleList): (WebCore::CSSRuleList::~CSSRuleList): (WebCore::CSSRuleList::deleteRule): (WebCore::CSSRuleList::append): (WebCore::CSSRuleList::insertRule):
  • css/CSSRuleList.h: Added. (WebCore::CSSRuleList::item):
  • css/CSSStyleDeclaration.cpp: Added. (WebCore::CSSStyleDeclaration::CSSStyleDeclaration): (WebCore::CSSStyleDeclaration::diff):
  • css/CSSStyleDeclaration.h: Added.
  • css/CSSStyleRule.cpp: Added. (WebCore::CSSStyleRule::CSSStyleRule): (WebCore::CSSStyleRule::selectorText):
  • css/CSSStyleRule.h: Added.
  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::ownerRule):
  • css/CSSUnknownRule.h: Added. (WebCore::CSSUnknownRule::CSSUnknownRule):
  • css/CSSValue.h: Added.
  • css/CSSValueList.cpp: Added.
  • css/CSSValueList.h: Added.
  • css/Counter.h: Added.
  • css/DashboardRegion.h: Added.
  • css/FontFamilyValue.cpp: Added.
  • css/FontFamilyValue.h: Added. (WebCore::FontFamilyValue::genericFamilyType):
  • css/FontValue.cpp: Added. (WebCore::FontValue::cssText):
  • css/FontValue.h: Added.
  • css/MediaList.cpp:
  • css/Pair.h: Added. (WebCore::Pair::~Pair):
  • css/RectImpl.h: Added. (WebCore::RectImpl::~RectImpl):
  • css/ShadowValue.cpp: Added. (WebCore::ShadowValue::ShadowValue):
  • css/ShadowValue.h: Added.
  • css/css_base.cpp:
  • css/css_ruleimpl.cpp: Removed.
  • css/css_ruleimpl.h: Removed.
  • css/css_valueimpl.cpp: Removed.
  • css/css_valueimpl.h: Removed.
  • css/cssparser.cpp: (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseFontFamily):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::locateCousinList): (WebCore::CSSStyleSelector::checkSelector): (WebCore::CSSRuleSet::addRulesFromSheet): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::mapBackgroundImage):
  • css/cssstyleselector.h:
  • dom/CSSMappedAttributeDeclaration.h: (WebCore::CSSMappedAttributeDeclaration::CSSMappedAttributeDeclaration):
  • dom/Document.cpp:
  • editing/ApplyStyleCommand.cpp:
  • editing/CompositeEditCommand.h:
  • editing/EditCommand.cpp:
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):
  • editing/InsertLineBreakCommand.h:
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input):
  • editing/RemoveCSSPropertyCommand.cpp: (WebCore::RemoveCSSPropertyCommand::RemoveCSSPropertyCommand): (WebCore::RemoveCSSPropertyCommand::~RemoveCSSPropertyCommand):
  • editing/RemoveCSSPropertyCommand.h: (WebCore::RemoveCSSPropertyCommand::styleDeclaration):
  • html/HTMLBodyElement.cpp:
  • html/HTMLElement.cpp:
  • html/HTMLScriptElement.h:
  • html/HTMLTokenizer.h:
  • kcanvas/KCanvasFilters.h: (WebCore::KCanvasFEColorMatrix::values): (WebCore::KCanvasFEColorMatrix::setValues): (WebCore::KCanvasFEConvolveMatrix::kernel): (WebCore::KCanvasFEConvolveMatrix::setKernel):
  • kcanvas/KCanvasPath.h:
  • kcanvas/KCanvasTreeDebug.h: (WebCore::operator<<):
  • kcanvas/RenderPath.h:
  • ksvg2/css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue): (WebCore::CSSParser::parseSVGStrokeDasharray): (WebCore::CSSParser::parseSVGPaint): (WebCore::CSSParser::parseSVGColor):
  • ksvg2/css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
  • ksvg2/css/SVGRenderStyleDefs.h:
  • ksvg2/ecma/Ecma.cpp:
  • ksvg2/misc/KCanvasRenderingStyle.cpp:
  • ksvg2/misc/KCanvasRenderingStyle.h:
  • ksvg2/svg/SVGAnimationElement.cpp:
  • ksvg2/svg/SVGColor.cpp:
  • ksvg2/svg/SVGColor.h:
  • ksvg2/svg/SVGCursorElement.h:
  • ksvg2/svg/SVGFEColorMatrixElement.cpp: (SVGFEColorMatrixElement::filterEffect):
  • page/DOMWindow.cpp:
  • page/Frame.cpp:
  • page/FramePrivate.h:
  • platform/DeprecatedValueList.h:
  • rendering/RenderTextField.cpp:
9:38 PM Changeset in webkit [14406] by ap
  • 5 edits in trunk

JavaScriptCore:

  • make-generated-sources.sh: Changed to be executable and removed text in the file generated by "svn diff".

WebKitTools:

  • Scripts/install-unix-extras: Changed to be executable and removed text in the file generated by "svn diff".
  • Scripts/regenerate-makefiles: Ditto.
9:30 PM Changeset in webkit [14405] by darin
  • 2 edits in trunk/WebCore
  • WebCore.xcodeproj/project.pbxproj: Removed duplicate files that were screwing up Xcode.
8:11 PM Changeset in webkit [14404] by eseidel
  • 1 edit in trunk/WebCore/bindings/js/kjs_css.h

Fix typo causing build failure.

7:54 PM Changeset in webkit [14403] by ggaren
  • 4 edits
    6 adds in trunk

JavaScriptCore:

Reviewed by Maciej.

  • Fixed <rdar://problem/4534904> please do not treat "debugger" as a reserved word while parsing JavaScript (and other ECMA reserved words)

AKA

http://bugzilla.opendarwin.org/show_bug.cgi?id=6179
We treat "char" as a reserved word in JavaScript and firefox/IE do
not

(1) I unreserved most of the spec's "future reserved words" because
they're not reserved in IE or FF. (Most, but not all, because IE
somewhat randomly *does* reserve a few of them.)
(2) I made 'debugger' a legitimate statement that acts like an empty
statement because FF and IE support it.


  • kjs/grammar.y:
  • kjs/keywords.table:

LayoutTests:

  • fast/js/debugger-expected.txt: Added.
  • fast/js/debugger.html: Added.
  • fast/js/reserved-words-expected.txt: Added.
  • fast/js/reserved-words.html: Added.
  • fast/js/resources/debugger.js: Added.
  • fast/js/resources/reserved-words.js: Added.
7:21 PM Changeset in webkit [14402] by eseidel
  • 1 edit in trunk/WebCore/bindings/js/kjs_css.h

A few more style cleanup changes I missed in my last commit.

7:08 PM Changeset in webkit [14401] by eseidel
  • 33 edits
    6 copies
    2 moves in trunk/WebCore

2006-05-15 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Split css_stylesheetimpl.* into separate files (one per class).
http://bugzilla.opendarwin.org/show_bug.cgi?id=8933

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSStyleSheet.cpp: Added. (WebCore::CSSStyleSheet::CSSStyleSheet): (WebCore::CSSStyleSheet::addRule): (WebCore::CSSStyleSheet::deleteRule): (WebCore::CSSStyleSheet::parseString): (WebCore::CSSStyleSheet::docLoader):
  • css/CSSStyleSheet.h: Added.
  • css/MediaList.cpp: Added. (WebCore::MediaList::MediaList): (WebCore::MediaList::contains): (WebCore::MediaList::parentStyleSheet): (WebCore::MediaList::parentRule): (WebCore::MediaList::deleteMedium): (WebCore::MediaList::setMediaText):
  • css/MediaList.h: Added.
  • css/StyleSheet.cpp: Added. (WebCore::StyleSheet::StyleSheet): (WebCore::StyleSheet::parentStyleSheet): (WebCore::StyleSheet::setMedia):
  • css/StyleSheet.h: Added. (WebCore::StyleSheet::ownerNode):
  • css/StyleSheetList.cpp: Added. (WebCore::StyleSheetList::~StyleSheetList): (WebCore::StyleSheetList::add): (WebCore::StyleSheetList::remove): (WebCore::StyleSheetList::item):
  • css/StyleSheetList.h: Added.
  • css/css_stylesheetimpl.cpp: Removed.
  • css/css_stylesheetimpl.h: Removed.
7:00 PM Changeset in webkit [14400] by darin
  • 3 edits in trunk/WebCore
  • make-generated-sources.sh: Changed to be executable and removed text in the file generated by "svn diff".
  • move-js-headers.sh: Ditto.
6:04 PM Changeset in webkit [14399] by bdakin
  • 121 edits in trunk/LayoutTests

Reviewed by Darin.

These tests have new expected results after the fix for
http://bugzilla.opendarwin.org/show_bug.cgi?id=6838 Incomplete
repaint of collapsed table borders

5:43 PM Changeset in webkit [14398] by thatcher
  • 3 edits in trunk/WebCore/platform/mac

64-bit build fixes.

5:04 PM Changeset in webkit [14397] by tomernic
  • 5 edits in trunk

JavaScriptCore:

Reviewed by John Sullivan.

Part of <rdar://problem/4466508> Add 64-bit support to the Netscape Plugin API

Added to the Netscape Plugin API the concept of "plugin drawing models". The drawing model
determines the kind of graphics context created by the browser for the plugin, as well as
the Mac types of various Netscape Plugin API data structures.

There is a drawing model to represent the old QuickDraw-based API. It is used by default
if QuickDraw is available on the system, unless the plugin specifies another drawing model.

The big change is the addition of the CoreGraphics drawing model. A plugin may request this
drawing model to obtain access to a CGContextRef for drawing, instead of a QuickDraw CGrafPtr.

  • bindings/npapi.h: Define NP_NO_QUICKDRAW when compiling 64-bit; there is no 64-bit QuickDraw. Added NPNVpluginDrawingModel, NPNVsupportsQuickDrawBool, and NPNVsupportsCoreGraphicsBool variables. Added NPDrawingModel enumeration. Currently the only drawing models are QuickDraw and CoreGraphics. NPRegion's type now depends on the drawing model specified by the plugin. NP_Port is now only defined when QuickDraw is available. Added NP_CGContext, which is the type of the NPWindow's "window" member in CoreGraphics mode.

WebKit:

Reviewed by John Sullivan.

Part of <rdar://problem/4466508> Add 64-bit support to the Netscape Plugin API

Added to the Netscape Plugin API the concept of "plugin drawing models". The drawing model
determines the kind of graphics context created by the browser for the plugin, as well as
the Mac types of various Netscape Plugin API data structures.

There is a drawing model to represent the old QuickDraw-based API. It is used by default
if QuickDraw is available on the system, unless the plugin specifies another drawing model.

The big change is the addition of the CoreGraphics drawing model. A plugin may request this
drawing model to obtain access to a CGContextRef for drawing, instead of a QuickDraw CGrafPtr.

  • Plugins/WebBaseNetscapePluginView.h: Added PluginPort union, which wraps a NP_Port and a NP_CGContext. This is to make access to the nPort and lastSetPort ivars more convenient now that the port type differs based on the drawing model. Changed types of nPort and lastSetPort to PluginPort so they can be used with any drawing model. Added drawingModel ivar.
  • Plugins/WebBaseNetscapePluginView.m: Renamed PortState to PortState_QD. PortState is now an opaque pointer. PortState_QD cannot be used if QuickDraw is unavailable. (-[WebBaseNetscapePluginView fixWindowPort]): Cannot be used if QuickDraw is unavailable. (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Only fix window port if drawing model is QuickDraw. Re-ordered some code so I could group QuickDraw-specific stuff into switch and if blocks (that's why the diff here is so terrible). Now returns a malloc()'ed PortState that the caller is responsible for freeing. Renamed to better reflect this behavior. Support for the CoreGraphics drawing model -- fill PortState_CG struct, save CGContext state. (-[WebBaseNetscapePluginView restorePortState:]): Switch based on drawing model. Support for the CoreGraphics drawing model -- restore CGContext state saved earlier. (-[WebBaseNetscapePluginView sendEvent:]): Formatting. Don't set save/set port state or set the window in CoreGraphics mode unless the event being sent is an updateEvt. We can't provide the plugin with a CGContext outside of our view display cycle. Don't restore PortState if it's NULL (didn't used to be a pointer). Free when we're done with it. (-[WebBaseNetscapePluginView isNewWindowEqualToOldWindow]): Formatting. Switch how we compare ports based on the drawing model. (-[WebBaseNetscapePluginView updateAndSetWindow]): Fixed for CoreGraphics by triggering a redisplay instead of sending an update event to the plugin outside of the view display cycle. Don't restore PortState if it's NULL (didn't used to be a pointer). Free when we're done with it. (-[WebBaseNetscapePluginView setWindowIfNecessary]): Assert that the window is only set when updating in CoreGraphics mode. Log differently depending on the drawing model. (-[WebBaseNetscapePluginView start]): Fall back on QuickDraw if the plugin does not specify a drawing model. (-[WebBaseNetscapePluginView tellQuickTimeToChill]): Cannot be used if QuickDraw is unavailable. (-[WebBaseNetscapePluginView viewWillMoveToWindow:]): Only call -tellQuickTimeToChill in QuickDraw mode. (-[WebBaseNetscapePluginView viewHasMoved:]): ditto (-[WebBaseNetscapePluginView invalidateRegion:]): NPRegion is a CGPathRef in CoreGraphics mode. (-[WebBaseNetscapePluginView getVariable:value:]): Added support for retriveing the NPNVpluginDrawingModel, NPNVsupportsQuickDrawBool, and NPNVsupportsCoreGraphicsBool browser variables. (-[WebBaseNetscapePluginView setVariable:value:]): Added support for setting the NPNVpluginDrawingModel variable.
5:04 PM Changeset in webkit [14396] by eseidel
  • 2 edits in trunk/WebCore

2006-05-15 Eric Seidel <eseidel@apple.com>

  • WebCore.xcodeproj/project.pbxproj: build fix.
4:53 PM Changeset in webkit [14395] by eseidel
  • 11 edits
    6 copies
    2 moves in trunk/WebCore

2006-05-15 Eric Seidel <eseidel@apple.com>

Reviewed by ggaren.

Split dom_xmlimpl.* into separate files (one per class).

  • WebCore.xcodeproj/project.pbxproj:
  • dom/Entity.cpp: Added. (WebCore::Entity::Entity):
  • dom/Entity.h: Added.
  • dom/EntityReference.cpp: Added. (WebCore::EntityReference::EntityReference):
  • dom/EntityReference.h: Added.
  • dom/Notation.cpp: Added. (WebCore::Notation::Notation):
  • dom/Notation.h: Added.
  • dom/ProcessingInstruction.cpp: Added. (WebCore::ProcessingInstruction::ProcessingInstruction):
  • dom/ProcessingInstruction.h: Added.
  • dom/dom_xmlimpl.cpp: Removed.
  • dom/dom_xmlimpl.h: Removed.
4:30 PM Changeset in webkit [14394] by thatcher
  • 1 edit in trunk/WebCore/kwq/KWQListBox.mm

build fix

4:23 PM Changeset in webkit [14393] by eseidel
  • 24 edits
    6 copies
    2 moves in trunk/WebCore

2006-05-15 Eric Seidel <eseidel@apple.com>

Reviewed by Tim Hatcher.

Split html_imageimpl.* into separate files (one per class).
http://bugzilla.opendarwin.org/show_bug.cgi?id=8929

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCanvasRenderingContext2DBase.cpp:
  • bindings/js/kjs_events.cpp:
  • bindings/js/kjs_html.cpp:
  • bindings/objc/DOMHTML.mm:
  • bridge/mac/WebCoreFrameBridge.mm:
  • dom/Document.cpp:
  • editing/JSEditor.cpp:
  • html/CanvasRenderingContext2D.cpp:
  • html/HTMLAnchorElement.cpp:
  • html/HTMLAreaElement.cpp: Added. (WebCore::HTMLAreaElement::HTMLAreaElement): (WebCore::HTMLAreaElement::mapMouseEvent): (WebCore::HTMLAreaElement::getRect): (WebCore::HTMLAreaElement::getRegion):
  • html/HTMLAreaElement.h: Added.
  • html/HTMLCanvasElement.h:
  • html/HTMLDocument.cpp:
  • html/HTMLElementFactory.cpp:
  • html/HTMLFormCollection.cpp:
  • html/HTMLFormElement.cpp:
  • html/HTMLImageElement.cpp: Added. (WebCore::HTMLImageElement::HTMLImageElement):
  • html/HTMLImageElement.h: Added.
  • html/HTMLImageLoader.cpp: Added. (WebCore::HTMLImageLoader::HTMLImageLoader):
  • html/HTMLImageLoader.h: Added.
  • html/HTMLInputElement.cpp:
  • html/HTMLMapElement.cpp: Added. (WebCore::HTMLMapElement::mapMouseEvent): (WebCore::HTMLMapElement::parseMappedAttribute):
  • html/HTMLMapElement.h: Added.
  • html/HTMLObjectElement.cpp:
  • html/HTMLParser.cpp:
  • html/html_imageimpl.cpp: Removed.
  • html/html_imageimpl.h: Removed.
  • ksvg2/misc/SVGImageLoader.h:
  • kwq/WebCoreAXObject.mm: (-[WebCoreAXObject addChildrenToArray:]):
  • page/Frame.cpp:
  • rendering/RenderImage.cpp: (WebCore::RenderImage::RenderImage): (WebCore::RenderImage::nodeAtPoint):
3:22 PM Changeset in webkit [14392] by tomernic
  • 3 edits in branches/Safari-2-0-branch/WebKit

Merged fix and follow-up fix from TOT to Safari-2-0-branch

2006-05-15 Tim Omernick <timo@apple.com>

Reviewed by Darin.

Safari's Page Load Test (PLT) saturates the runloop with so many sources that timers are not allowed to fire
as frequently as they should. This is a general problem with the PLT -- because of this, it does not measure
work done in timer callbacks during/after the page load process.

Unfortunately, this aspect of the PLT interferes with our window display throttle hack. Because we throttle
display using timers, and the PLT starves timers, most of the pages loaded by the PLT do not actually display.
This makes the PLT run "too fast", yielding ridiculously fast numbers compared to when throttling is disabled.

I've added a new method that the PLT can call after each page load to force any starved display throttle timers
to fire. By doing this, Safari's PLT will be guaranteed to display each page at least once.

  • Misc/WebNSWindowExtras.h:
  • Misc/WebNSWindowExtras.m: Added a special internal runloop mode for the throttle timers. (+[NSWindow _webkit_displayThrottledWindows]): Run the runloop in our special internal mode until there are no more sources to handle. (requestWindowDisplay): Schedule the timer in the new mode as well as the standard modes.

2006-05-15 Tim Omernick <timo@apple.com>

Reviewed by Kevin Decker.

Follow-up to my previous PLT fix. I found upon further testing (by dramatically decreasing the
allowed display rate) that +_webkit_displayThrottledWindows did not always force a display when
necessary. The reason is that I was not giving a proper timeout to CFRunLoopRunInMode(). I was
passing 0, which was causing only "expired" timers to fire. This method is actually supposed to
block until all currently scheduled display timers fire.

I tested this change and found that it did not affect my PLT times when the display rate was
capped to 60 fps. It also behaves as expected when the display rate is set much lower (say, 1
display per second); my previous fix did not work well at such display rates.

  • Misc/WebNSWindowExtras.m: (+[NSWindow _webkit_displayThrottledWindows]): Run the runloop for an amount of time equal to the minimum allowed interval between displays. This ensures that we'll block until all currently scheduled display timers fire (but we won't block for future display timers).
3:18 PM Changeset in webkit [14391] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Kevin Decker.

Follow-up to my previous PLT fix. I found upon further testing (by dramatically decreasing the
allowed display rate) that +_webkit_displayThrottledWindows did not always force a display when
necessary. The reason is that I was not giving a proper timeout to CFRunLoopRunInMode(). I was
passing 0, which was causing only "expired" timers to fire. This method is actually supposed to
block until all currently scheduled display timers fire.

I tested this change and found that it did not affect my PLT times when the display rate was
capped to 60 fps. It also behaves as expected when the display rate is set much lower (say, 1
display per second); my previous fix did not work well at such display rates.

  • Misc/WebNSWindowExtras.m: (+[NSWindow _webkit_displayThrottledWindows]): Run the runloop for an amount of time equal to the minimum allowed interval between displays. This ensures that we'll block until all currently scheduled display timers fire (but we won't block for future display timers).
2:57 PM Changeset in webkit [14390] by eseidel
  • 9 edits
    12 copies
    2 moves in trunk/WebCore

2006-05-15 Eric Seidel <eseidel@apple.com>

Reviewed by beth.

Split html_blockimpl.* into separate files (one per class).
http://bugzilla.opendarwin.org/show_bug.cgi?id=8927

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_html.cpp:
  • bindings/objc/DOMHTML.mm:
  • html/HTMLBlockquoteElement.cpp: Added. (WebCore::HTMLBlockquoteElement::HTMLBlockquoteElement):
  • html/HTMLBlockquoteElement.h: Added.
  • html/HTMLDivElement.cpp: Added.
  • html/HTMLDivElement.h: Added.
  • html/HTMLElementFactory.cpp:
  • html/HTMLHRElement.cpp: Added.
  • html/HTMLHRElement.h: Added.
  • html/HTMLHeadingElement.cpp: Added.
  • html/HTMLHeadingElement.h: Added.
  • html/HTMLMarqueeElement.cpp: Added. (WebCore::HTMLMarqueeElement::HTMLMarqueeElement): (WebCore::HTMLMarqueeElement::parseMappedAttribute):
  • html/HTMLMarqueeElement.h: Added.
  • html/HTMLParagraphElement.cpp: Added.
  • html/HTMLParagraphElement.h: Added.
  • html/HTMLParser.cpp:
  • html/HTMLPreElement.cpp: Added. (WebCore::HTMLPreElement::HTMLPreElement): (WebCore::HTMLPreElement::setWrap):
  • html/HTMLPreElement.h: Added.
  • html/HTMLTextFieldInnerElement.h:
  • html/html_blockimpl.cpp: Removed.
  • html/html_blockimpl.h: Removed.
  • rendering/RenderLayer.cpp:
2:16 PM Changeset in webkit [14389] by eseidel
  • 16 edits
    14 copies
    4 moves in trunk/WebCore

2006-05-15 Eric Seidel <eseidel@apple.com>

Reviewed by ggaren.

Split render_list.* and html_listimpl.* into separate files (one per class).

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_html.cpp:
  • bindings/objc/DOMHTML.mm:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::attributedString):
  • html/HTMLDListElement.cpp: Added. (WebCore::HTMLDListElement::HTMLDListElement):
  • html/HTMLDListElement.h: Added.
  • html/HTMLDirectoryElement.cpp: Added. (WebCore::HTMLDirectoryElement::HTMLDirectoryElement):
  • html/HTMLDirectoryElement.h: Added.
  • html/HTMLElementFactory.cpp:
  • html/HTMLKeygenElement.cpp:
  • html/HTMLLIElement.cpp: Added. (WebCore::HTMLLIElement::HTMLLIElement): (WebCore::HTMLLIElement::parseMappedAttribute): (WebCore::HTMLLIElement::attach): (WebCore::HTMLLIElement::setType):
  • html/HTMLLIElement.h: Added.
  • html/HTMLMenuElement.cpp: Added. (WebCore::HTMLMenuElement::HTMLMenuElement):
  • html/HTMLMenuElement.h: Added.
  • html/HTMLOListElement.cpp: Added. (WebCore::HTMLOListElement::HTMLOListElement): (WebCore::HTMLOListElement::parseMappedAttribute): (WebCore::HTMLOListElement::setType):
  • html/HTMLOListElement.h: Added. (WebCore::HTMLOListElement::start):
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::HTMLOptionElement): (WebCore::HTMLOptionElement::checkDTD): (WebCore::HTMLOptionElement::text): (WebCore::HTMLOptionElement::setText): (WebCore::HTMLOptionElement::getSelect): (WebCore::HTMLOptionElement::setLabel):
  • html/HTMLOptionElement.h:
  • html/HTMLParser.cpp:
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::HTMLSelectElement):
  • html/HTMLUListElement.cpp: Added. (WebCore::HTMLUListElement::HTMLUListElement):
  • html/HTMLUListElement.h: Added.
  • html/html_listimpl.cpp: Removed.
  • html/html_listimpl.h: Removed.
  • kwq/WebCoreAXObject.mm:
  • rendering/InlineFlowBox.cpp:
  • rendering/ListMarkerBox.cpp: Added. (WebCore::ListMarkerBox::ListMarkerBox): (WebCore::ListMarkerBox::isText):
  • rendering/ListMarkerBox.h: Added.
  • rendering/RenderContainer.cpp: (WebCore::updateListMarkerNumbers): (WebCore::RenderContainer::addChild): (WebCore::RenderContainer::removeChild): (WebCore::RenderContainer::layout): (WebCore::RenderContainer::removeLeftoverAnonymousBoxes): (WebCore::RenderContainer::positionForCoordinates): (WebCore::RenderContainer::lineBoxRects):
  • rendering/RenderListItem.cpp: Added. (WebCore::RenderListItem::RenderListItem): (WebCore::RenderListItem::setStyle): (WebCore::RenderListItem::calcValue): (WebCore::RenderListItem::markerStringValue):
  • rendering/RenderListItem.h: Added. (WebCore::RenderListItem::renderName): (WebCore::RenderListItem::setValue): (WebCore::RenderListItem::setNotInList): (WebCore::RenderListItem::notInList):
  • rendering/RenderListMarker.cpp: Added. (WebCore::RenderListMarker::RenderListMarker): (WebCore::RenderListMarker::setStyle): (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::layout): (WebCore::RenderListMarker::calcMinMaxWidth):
  • rendering/RenderListMarker.h: Added. (WebCore::RenderListMarker::renderName):
  • rendering/RenderObject.cpp:
  • rendering/render_list.cpp: Removed.
  • rendering/render_list.h: Removed.
2:12 PM Changeset in webkit [14388] by hyatt
  • 1 edit in trunk/LayoutTests/editing/input/attributed-substring-from-range-lines-expected.txt

Land updated results.

1:49 PM Changeset in webkit [14387] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Omernick.


  • followup to previous fix; I hadn't tested quitting adequately
  • WebView/WebHTMLView.m: (-[WebHTMLView dealloc]): call removeAllToolTips before clearing _private so that removeTrackingRect: override can work properly. Normally removeAllToolTips would be called by super, but that's too late. (-[WebHTMLView finalize]): ditto
1:25 PM Changeset in webkit [14386] by thatcher
  • 1 copy in tags/WebKit-418.4/WebKit

Tag for WebKit 418.4 (part 2 of 2.)

1:25 PM Changeset in webkit [14385] by thatcher
  • 1 add in tags/WebKit-418.4

Tag for WebKit 418.4 (part 1 of 2.)

1:25 PM Changeset in webkit [14384] by thatcher
  • 1 delete in tags/WebCore-418.4/WebCore/WebCore

Removing a bad tag.

1:23 PM Changeset in webkit [14383] by sullivan
  • 4 edits in trunk/WebKit

Reviewed by Darin.


  • fixed <rdar://problem/4503016> TOT assertion failure in -[WebHTMLView(WebPrivate) removeTrackingRect:]


We have some tricky code to deal with tracking rects, which succumbed to a fix in AppKit. Updated our
tricky code to work with the AppKit fix.

  • WebView/WebHTMLViewInternal.h: new instance variable lastToolTipTag


  • WebView/WebHTMLView.m: (-[WebHTMLView removeTrackingRect:]): handle removing lastToolTipTag by calling super (-[WebHTMLView _setToolTip:]): save tool tip tag in lastToolTipTag; this apparently used to always return 0, so we formerly had no way to distinguish it from the no-tool-tips-yet case.
  • WebKit.xcodeproj/project.pbxproj: Xcode removed some old cruft
12:15 PM Changeset in webkit [14382] by eseidel
  • 17 edits
    18 copies
    2 moves in trunk/WebCore

2006-05-15 Sam Weinig <sam.weinig@gmail.com>

Reviewed by eseidel.

Split render_form.* into separate files (one per class).
http://bugzilla.opendarwin.org/show_bug.cgi?id=8889

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::HTMLButtonElement):
  • html/HTMLFieldSetElement.cpp:
  • html/HTMLFormElement.cpp:
  • html/HTMLInputElement.cpp:
  • html/HTMLLabelElement.cpp:
  • html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::createRenderer):
  • html/HTMLOptionElement.cpp:
  • html/HTMLSelectElement.cpp:
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::selectionStart): (WebCore::HTMLTextAreaElement::selectionEnd): (WebCore::HTMLTextAreaElement::setSelectionStart): (WebCore::HTMLTextAreaElement::setSelectionEnd): (WebCore::HTMLTextAreaElement::setSelectionRange): (WebCore::HTMLTextAreaElement::parseMappedAttribute): (WebCore::HTMLTextAreaElement::createRenderer): (WebCore::HTMLTextAreaElement::setValue): (WebCore::HTMLTextAreaElement::setDefaultValue): (WebCore::HTMLTextAreaElement::setAccessKey):
  • kwq/KWQComboBox.mm:
  • kwq/KWQFileButton.mm:
  • kwq/KWQListBox.mm:
  • kwq/KWQSlider.mm:
  • platform/mac/WebCoreTextField.mm:
  • rendering/RenderFieldset.cpp: Added. (WebCore::RenderFieldset::RenderFieldset): (WebCore::RenderFieldset::findLegend): (WebCore::RenderFieldset::paintBorderMinusLegend): (WebCore::RenderFieldset::setStyle):
  • rendering/RenderFieldset.h: Added. (WebCore::RenderFieldset::renderName):
  • rendering/RenderFileButton.cpp: Added. (WebCore::RenderFileButton::RenderFileButton): (WebCore::RenderFileButton::calcMinMaxWidth): (WebCore::RenderFileButton::updateFromElement): (WebCore::RenderFileButton::click):
  • rendering/RenderFileButton.h: Added. (WebCore::RenderFileButton::renderName): (WebCore::RenderFileButton::calcReplacedHeight): (WebCore::RenderFileButton::isEditable):
  • rendering/RenderFormElement.cpp: Added. (WebCore::RenderFormElement::RenderFormElement): (WebCore::RenderFormElement::baselinePosition): (WebCore::RenderFormElement::layout):
  • rendering/RenderFormElement.h: Added. (WebCore::RenderFormElement::renderName): (WebCore::RenderFormElement::isFormElement): (WebCore::RenderFormElement::borderTop): (WebCore::RenderFormElement::borderBottom): (WebCore::RenderFormElement::borderLeft): (WebCore::RenderFormElement::borderRight): (WebCore::RenderFormElement::paddingTop): (WebCore::RenderFormElement::paddingBottom): (WebCore::RenderFormElement::paddingLeft): (WebCore::RenderFormElement::paddingRight): (WebCore::RenderFormElement::canHaveIntrinsicMargins): (WebCore::RenderFormElement::intrinsicMargin): (WebCore::RenderFormElement::isEditable):
  • rendering/RenderImageButton.cpp: Added. (WebCore::RenderImageButton::RenderImageButton):
  • rendering/RenderImageButton.h: Added. (WebCore::RenderImageButton::renderName): (WebCore::RenderImageButton::isImageButton):
  • rendering/RenderLabel.cpp: Added. (WebCore::RenderLabel::RenderLabel):
  • rendering/RenderLabel.h: Added. (WebCore::RenderLabel::renderName):
  • rendering/RenderLegend.cpp: Added. (WebCore::RenderLegend::RenderLegend):
  • rendering/RenderLegend.h: Added. (WebCore::RenderLegend::renderName):
  • rendering/RenderLineEdit.cpp: Added. (WebCore::RenderLineEdit::RenderLineEdit):
  • rendering/RenderLineEdit.h: Added. (WebCore::RenderLineEdit::renderName): (WebCore::RenderLineEdit::calcReplacedHeight): (WebCore::RenderLineEdit::canHaveIntrinsicMargins): (WebCore::RenderLineEdit::isTextField): (WebCore::RenderLineEdit::isEditable):
  • rendering/RenderSelect.cpp: Added. (WebCore::RenderSelect::RenderSelect): (WebCore::RenderSelect::setWidgetWritingDirection): (WebCore::RenderSelect::setStyle): (WebCore::RenderSelect::updateFromElement): (WebCore::RenderSelect::baselinePosition): (WebCore::RenderSelect::calcMinMaxWidth): (WebCore::RenderSelect::layout): (WebCore::RenderSelect::valueChanged): (WebCore::RenderSelect::selectionChanged): (WebCore::RenderSelect::updateSelection):
  • rendering/RenderSelect.h: Added. (WebCore::RenderSelect::renderName): (WebCore::RenderSelect::calcReplacedHeight): (WebCore::RenderSelect::canHaveIntrinsicMargins): (WebCore::RenderSelect::selectionChanged): (WebCore::RenderSelect::setSelectionChanged):
  • rendering/RenderSlider.cpp: Added. (WebCore::RenderSlider::calcMinMaxWidth): (WebCore::RenderSlider::updateFromElement):
  • rendering/RenderSlider.h: Added. (WebCore::RenderSlider::renderName): (WebCore::RenderSlider::canHaveIntrinsicMargins):
  • rendering/RenderTextArea.cpp: Added. (WebCore::RenderTextArea::RenderTextArea): (WebCore::RenderTextArea::calcMinMaxWidth): (WebCore::RenderTextArea::setStyle): (WebCore::RenderTextArea::updateFromElement): (WebCore::RenderTextArea::selectionStart): (WebCore::RenderTextArea::selectionEnd): (WebCore::RenderTextArea::setSelectionStart): (WebCore::RenderTextArea::setSelectionEnd): (WebCore::RenderTextArea::select): (WebCore::RenderTextArea::setSelectionRange):
  • rendering/RenderTextArea.h: Added. (WebCore::RenderTextArea::renderName): (WebCore::RenderTextArea::isTextArea): (WebCore::RenderTextArea::isEdited): (WebCore::RenderTextArea::canHaveIntrinsicMargins): (WebCore::RenderTextArea::isEditable):
  • rendering/render_form.cpp: Removed.
  • rendering/render_form.h: Removed.
12:10 PM Changeset in webkit [14381] by thatcher
  • 1 copy in tags/WebCore-418.4/WebCore/WebCore

Tag for WebCore 418.4 (part 2 of 2.)

12:08 PM Changeset in webkit [14380] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Versioning

12:05 PM Changeset in webkit [14379] by tomernic
  • 3 edits in trunk/WebKit

Reviewed by Darin.

Safari's Page Load Test (PLT) saturates the runloop with so many sources that timers are not allowed to fire
as frequently as they should. This is a general problem with the PLT -- because of this, it does not measure
work done in timer callbacks during/after the page load process.

Unfortunately, this aspect of the PLT interferes with our window display throttle hack. Because we throttle
display using timers, and the PLT starves timers, most of the pages loaded by the PLT do not actually display.
This makes the PLT run "too fast", yielding ridiculously fast numbers compared to when throttling is disabled.

I've added a new method that the PLT can call after each page load to force any starved display throttle timers
to fire. By doing this, Safari's PLT will be guaranteed to display each page at least once.

  • Misc/WebNSWindowExtras.h:
  • Misc/WebNSWindowExtras.m: Added a special internal runloop mode for the throttle timers. (+[NSWindow _webkit_displayThrottledWindows]): Run the runloop in our special internal mode until there are no more sources to handle. (requestWindowDisplay): Schedule the timer in the new mode as well as the standard modes.
11:17 AM Changeset in webkit [14378] by andersca
  • 10 edits in trunk/WebCore

2006-05-15 Anders Carlsson <acarlsson@apple.com>

Reviewed by Eric.

Remove the XPath log calls. They were causing leaks and were never
really useful.


  • bridge/mac/WebCorePageBridge.mm: (initializeLoggingChannelsIfNecessary):
  • platform/Logging.cpp:
  • platform/Logging.h:
  • xpath/XPathResult.cpp: (WebCore::XPathResult::convertTo):
  • xpath/impl/XPathFunctions.cpp: (round): (WebCore::XPath::FunCount::doEvaluate): (WebCore::XPath::FunSum::doEvaluate): (WebCore::XPath::FunctionLibrary::createFunction):
  • xpath/impl/XPathPath.cpp: (WebCore::XPath::Filter::doEvaluate): (WebCore::XPath::LocationPath::doEvaluate):
  • xpath/impl/XPathPredicate.cpp: (WebCore::XPath::Negative::doEvaluate): (WebCore::XPath::NumericOp::doEvaluate): (WebCore::XPath::Union::doEvaluate):
  • xpath/impl/XPathStep.cpp: (WebCore::XPath::Step::evaluate): (WebCore::XPath::Step::nodesInAxis): (WebCore::XPath::Step::nodeTestMatches):
  • xpath/impl/XPathValue.cpp: (WebCore::XPath::Value::toNodeVector):
10:14 AM Changeset in webkit [14377] by eseidel
  • 2 edits in trunk/WebCore

2006-05-15 Eric Seidel <eseidel@apple.com>

Fix linux build.

  • html/HTMLBodyElement.cpp: Fix case of #include "cssstyleselector.h"
1:47 AM Changeset in webkit [14376] by andersca
  • 6 edits in trunk

WebCore:

2006-05-15 Anders Carlsson <acarlsson@apple.com>

Reviewed by Maciej.

http://bugzilla.opendarwin.org/show_bug.cgi?id=8913
REGRESSION: Can view source for text files


  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canProvideDocumentSource]): (-[WebCoreFrameBridge canSaveAsWebArchive]):

WebKit:

2006-05-15 Anders Carlsson <acarlsson@apple.com>

Reviewed by Maciej.

http://bugzilla.opendarwin.org/show_bug.cgi?id=8913
REGRESSION: Can view source for text files

  • WebView/WebDocumentPrivate.h: Add canSaveAsWebArchive.


  • WebView/WebHTMLRepresentation.m: (-[WebHTMLRepresentation canProvideDocumentSource]): Call the bridge.


(-[WebHTMLRepresentation canSaveAsWebArchive]):
New function. This will be used in Safari ToT to determine if a page can be saved as an archive.

1:03 AM Changeset in webkit [14375] by hyatt
  • 10 edits in trunk/WebCore

Remove the .forPrinter boolean from FontPlatformData. After the initial
acquisition of an NSFont, the font is then adjusted to printer or screen
when put into a FontPlatformData. Then it can simply be used in the hash
lookup to get a FontData.

Reviewed by mjs

  • platform/Font.cpp: (WebCore::WidthIterator::advance):
  • platform/FontData.h:
  • platform/FontDescription.h: (WebCore::FontDescription::bold):
  • platform/FontPlatformData.h: (WebCore::FontPlatformData::syntheticOblique):
  • platform/mac/FontCacheMac.mm: (WebCore::FontCache::getFontDataForCharacters):
  • platform/mac/FontData.mm: (WebCore::FontData::smallCapsFontData): (WebCore::getSmallCapsFontData): (WebCore::setUpFont):
  • platform/mac/FontMac.mm: (WebCore::ATSULayoutParameters::initialize):
  • platform/mac/WebTextRendererFactory.h:
  • platform/mac/WebTextRendererFactory.mm: (-[WebTextRendererFactory rendererWithFont:]): (-[WebTextRendererFactory fontWithDescription:WebCore::familyIndex:]):

May 14, 2006:

11:59 PM Changeset in webkit [14374] by andersca
  • 2 edits in trunk/WebCore

2006-05-15 Anders Carlsson <acarlsson@apple.com>

Reviewed by Maciej.

9:57 PM Changeset in webkit [14373] by hyatt
  • 246 edits in trunk/LayoutTests/svg/W3C-SVG-1.1

Update svg layout tests.

9:42 PM Changeset in webkit [14372] by darin
  • 8 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.


  • fast/repaint/table-collapsed-border-expected.checksum: Added.
  • fast/repaint/table-collapsed-border-expected.png: Added.
  • fast/repaint/table-collapsed-border-expected.txt: Added.
  • fast/repaint/table-collapsed-border.html: Added.

WebCore:

Reviewed by Hyatt.


This patch updates the implementation of collapsing borders to match
the current spec.

Test: fast/repaint/table-collapsed-border.html

  • rendering/RenderTable.cpp: (WebCore::RenderTable::RenderTable): (WebCore::RenderTable::layout): Calculate horizontal overflows. (WebCore::RenderTable::calcMinMaxWidth): Added call to recalcHorizontalBorders. (WebCore::RenderTable::colElement): Made const. (WebCore::RenderTable::calcBorderLeft): Calculates the left border. In the collapsing borders model, this is the left border of the leftmost cell of the first row. (WebCore::RenderTable::calcBorderRight): Ditto for the right border. (WebCore::RenderTable::recalcHorizontalBorders): Added. (WebCore::RenderTable::borderTop): Changed to return outerBorderTop in the collapsing case. (WebCore::RenderTable::borderBottom): Changed to return outerBorderBottom in the collapsing case. (WebCore::RenderTable::outerBorderTop): Added. Returns the table half of the top border, which is half the widest top border on the first row. (WebCore::RenderTable::outerBorderBottom): Added. Returns the table half of the bottom border, which is half the widest bottom border on the last row. (WebCore::RenderTable::outerBorderLeft): Added. Returns the table half of the left border, which is half the widest left border on the leftmost column. (WebCore::RenderTable::outerBorderRight): Added. Returns the table half of the right border, which is half the widest right border on the rightmost column. (WebCore::RenderTable::cellAbove): Return 0 if the cell is in the first row of the header. (WebCore::RenderTable::cellBelow): Return 0 if the cell is in the last row of the footer.
  • rendering/RenderTable.h: (WebCore::RenderTable::borderLeft): (WebCore::RenderTable::borderRight): (WebCore::RenderTable::overflowHeight):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::borderLeft): Removed unnecessary use of floats. (WebCore::RenderTableCell::borderTop): Ditto. (WebCore::RenderTableCell::paint): Account for the table half of the vertical borders. (WebCore::RenderTableCell::paintCollapsedBorder): Removed unnecessary use of floats.
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::RenderTableSection): (WebCore::RenderTableSection::layoutRows): Added call to recalcOuterBorder. (WebCore::RenderTableSection::calcOuterBorderTop): Added. Calculates the outer half of the section's top border, which is half the widest top border on the first row. (WebCore::RenderTableSection::calcOuterBorderBottom): Ditto for the bottom border. (WebCore::RenderTableSection::calcOuterBorderLeft): Ditto for the left border. (WebCore::RenderTableSection::calcOuterBorderRight): Ditto for the right border. (WebCore::RenderTableSection::recalcOuterBorder): Added. (WebCore::RenderTableSection::paint): Account for the table half of the borders.
  • rendering/RenderTableSection.h: (WebCore::RenderTableSection::outerBorderTop): (WebCore::RenderTableSection::outerBorderBottom): (WebCore::RenderTableSection::outerBorderLeft): (WebCore::RenderTableSection::outerBorderRight):
  • rendering/render_style.cpp: (WebCore::RenderStyle::diff): Changed to return Layout if a border style changed from 'hidden' to 'none' or vice versa in the collapsing borders model, since 'hidden' suppresses other borders.
9:37 PM Changeset in webkit [14371] by darin
  • 5 edits
    1 add in trunk

WebCore:

Reviewed by Darin.

  • manual-tests/dom-manipulation-on-resize.html: Added.

WebKit:

Reviewed by Darin.

Manual test: manual-tests/dom-manipulation-on-resize.html

  • WebView/WebHTMLView.m: (-[NSArray layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Relayout if necessary after sending the resize event.
9:33 PM Changeset in webkit [14370] by darin
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=5882:
disabled type="file" element doesn't appear disabled

  • fast/forms/file-input-disabled.html: Added.
  • fast/forms/file-input-disabled-expected.txt: Added.
  • fast/forms/file-input-disabled-expected.png: Added.
  • fast/forms/file-input-disabled-expected.checksum: Added.

WebCore:

Reviewed by Darin.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=5882:
disabled type="file" element doesn't appear disabled

Be sure to call setDisabled on the file button when in
RenderFileButton::updateFromElement.

  • kwq/KWQFileButton.h:
  • kwq/KWQFileButton.mm: (-[WebFileChooserButton setEnabled:]): (KWQFileButton::setDisabled):
  • rendering/render_form.cpp: (WebCore::RenderFileButton::updateFromElement):
3:12 PM Changeset in webkit [14369] by sfalken
  • 2 edits in trunk/WebCore

2006-05-14 Steve Falkenburg <sfalken@apple.com>

Fix Windows build.

  • platform/win/FontWin.cpp: (WebCore::FontFallbackList::fontDataAt): (WebCore::hackishExtentForString): (WebCore::Font::floatWidth): (WebCore::Font::drawText): (WebCore::Font::selectionRectForText): (WebCore::Font::offsetForPosition):
2:26 PM Changeset in webkit [14368] by hyatt
  • 1 edit in trunk/WebCore/platform/win/FontWin.cpp

Fix Win32 build bustage.

2:25 PM Changeset in webkit [14367] by hyatt
  • 1 edit in trunk/WebCore/platform/win/FontWin.cpp

Fix Win32 build bustage.

1:38 PM Changeset in webkit [14366] by hyatt
  • 100 edits
    8 adds in trunk

Bug 8895. Rework font substitution and fallback. Lift the concept of
substitution and fallback out of FontData and up into the FontFallbackList.
See the bug for details of issues fixed in the fallback code.

Reviewed by darin

  • WebCore.xcodeproj/project.pbxproj:
  • platform/Font.cpp: (WebCore::m_finalRoundingWidth): (WebCore::WidthIterator::advance): (WebCore::Font::primaryFont): (WebCore::Font::fontDataAt): (WebCore::Font::fontDataForCharacters): (WebCore::Font::ascent): (WebCore::Font::descent): (WebCore::Font::lineSpacing): (WebCore::Font::xHeight): (WebCore::Font::isFixedPitch):
  • platform/Font.h: (WebCore::Font::getNSFont):
  • platform/FontCache.h: Added.
  • platform/FontData.h: (WebCore::FontData::pitch): (WebCore::FontData::getNSFont): (WebCore::):
  • platform/FontFallbackList.cpp: Added. (WebCore::m_pitch): (WebCore::FontFallbackList::~FontFallbackList): (WebCore::FontFallbackList::invalidate): (WebCore::FontFallbackList::determinePitch): (WebCore::FontFallbackList::fontDataAt): (WebCore::FontFallbackList::fontDataForCharacters):
  • platform/FontFallbackList.h: (WebCore::FontFallbackList::isFixedPitch): (WebCore::FontFallbackList::primaryFont):
  • platform/FontFamily.h:
  • platform/mac/FontCacheMac.mm: Added. (WebCore::FontCache::getFontData): (WebCore::FontCache::getFontDataForCharacters):
  • platform/mac/FontData.mm: (WebCore::FontData::containsCharacters):
  • platform/mac/FontMac.mm: (WebCore::ATSULayoutParameters::initialize):
  • platform/mac/WebTextRendererFactory.h:
  • platform/mac/WebTextRendererFactory.mm: (-[WebTextRendererFactory fallbackFontWithTraits:size:]): (-[WebTextRendererFactory fontWithDescription:WebCore::familyIndex:]):
  • platform/win/FontWin.cpp: (WebCore::FontFallbackList::determinePitch): (WebCore::FontFallbackList::primaryFont): (WebCore::FontFallbackList::fontDataAt): (WebCore::FontFallbackList::fontDataForCharacters):
9:39 AM Changeset in webkit [14365] by ap
  • 3 edits
    4 adds in trunk

2006-05-14 Sam Weinig <sam.weinig@gmail.com>

Reviewed by Hyatt, landed by ap.

Fix for <http://bugzilla.opendarwin.org/show_bug.cgi?id=8387>
"border-left/padding-Left do not show up on multiline rtl inline boxes"

Test: fast/inline/inline-borders-with-bidi-override.html: added

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
12:12 AM Changeset in webkit [14364] by sfalken
  • 2 edits in trunk/WebCore

2006-05-14 Steve Falkenburg <sfalken@apple.com>

Fix the Windows build the rest of the way

  • WebCore.vcproj/WebCore/WebCore.vcproj:

May 13, 2006:

9:52 PM Changeset in webkit [14363] by sfalken
  • 2 edits in trunk/WebKitWin

2006-05-14 Steve Falkenburg <sfalken@apple.com>

Update to new file paths

  • WebFramePrivate.cpp:
9:42 PM Changeset in webkit [14362] by sfalken
  • 2 edits in trunk/WebCore

2006-05-14 Steve Falkenburg <sfalken@apple.com>

Get FontWin.cpp compiling.
WebCore and JSCore now build, but Spinneret still gets link errors.

  • platform/win/FontWin.cpp: (WebCore::Font::offsetForPosition):
8:58 PM Changeset in webkit [14361] by sfalken
  • 4 edits in trunk/WebCore

2006-05-14 Steve Falkenburg <sfalken@apple.com>

Reviewed by maciej.

Fix Windows build except for fontwin.cpp.

  • WebCore/platform/win/FontWin.cpp:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/FrameWin.cpp:
9:58 AM Changeset in webkit [14360] by ap
  • 3 edits in trunk/LayoutTests/fast/block/positioning/auto

Commit the remaining updated results for bug 7604.

9:47 AM Changeset in webkit [14359] by ap
  • 3 edits
    22 adds in trunk

2006-05-13 Kevin M. Ollivier <kevino@theolliviers.com>

Reviewed by Darin, landed by ap.

JavaScriptCore:

  • make-generated-sources.sh: Added script to configure environment to run DerivedSources.make


  • JavaScriptCoreSources.bkl: Added JavaScriptCore sources list for Bakefile.


  • jscore.bkl: Bakefile used to generate JavaScriptCore project files (currently only used by wx and gdk ports)

WebCore:

  • make-generated-sources.sh: Added script to configure environment to run DerivedSources.make


  • move-js-headers.sh: Added script to copy JavaScriptCore includes into one dir so that Framework-style includes will work on all OSes. (written by Mike Emmel)


  • platform/wx: New dir, home for the wxWidgets port
  • platform/wx/wx-encodings.txt: Added temp. stub for wx encodings file.


  • Projects: New dir, for various project files for ports.


  • Projects/gdk: New dir, GDK port files.
  • Projects/webcore-gdk.bkl: Bakefile to generate GDK port project files


  • Projects/wx: New dir, wxWidgets port files.
  • Projects/webcore-wx.bkl: Bakefile to generate wxWidgets port project files

WebKitTools:

  • Scripts/install-unix-extras: Added.
  • Scripts/regenerate-makefiles: Added.
9:28 AM Changeset in webkit [14358] by ap
  • 3 edits
    4 adds in trunk

2006-05-13 Mitz Pettel <opendarwin.org@mitzpettel.com>

Reviewed by Darin, landed by ap.

Test: fast/text/midword-break-hang.html

  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): If this is a mid-word break, ignore breakOnlyAfterWhiteSpace.
9:19 AM Changeset in webkit [14357] by ap
  • 2 edits in trunk/WebCore

Ok, now RenderBox.cpp actually compiles for me.

8:57 AM Changeset in webkit [14356] by ap
  • 2 edits in trunk/WebCore

Same fix for calcAbsoluteVerticalValues().

8:50 AM Changeset in webkit [14355] by ap
  • 2 edits in trunk/WebCore

Try to fix release build.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcAbsoluteHorizontalValues): Initialize leftValue. This value will never be used, because 'left' and 'right' cannot both be 'auto'.
8:28 AM Changeset in webkit [14354] by ap
  • 1 edit
    1 delete in trunk/WebCore/rendering

Re-applied the fix for bug 8835 (REGRESSION: Line moves but selection
highlight stays behind) to a correct file; removed the stale one.

  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::adjustPosition): Adjust m_selectionTop and m_selectionBottom.
  • rendering/render_line.cpp: Removed.
8:12 AM Changeset in webkit [14353] by ap
  • 1 edit in trunk/WebCore/ChangeLog

Corrected a path in ChangeLog.

8:11 AM Changeset in webkit [14352] by ap
  • 6 edits
    4 adds in trunk

2006-05-13 Rob Buis <buis@kde.org>

Reviewed by Darin, landed by ap.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8132
CSS parser sometimes accepts real number as integer

Add a boolean variable per css value to catch whether values
are specified as floats or integers.

Test: fast/css/rgb-float.html

  • css/CSSGrammar.y:
  • css/cssparser.cpp: (WebCore::CSSParser::validUnit): (WebCore::CSSParser::lex):
  • css/cssparser.h:
  • css/tokenizer.flex:
7:58 AM Changeset in webkit [14351] by ap
  • 7 edits
    8 adds in trunk

2006-05-13 Sam Weinig <sam.weinig@gmail.com>

Reviewed by Hyatt, landed by ap.

WebCore:

Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=7604
calcAbsoluteHorizontalValues() is being getting passed arguments
in the wrong order in calcAbsoluteHorizontal()

Cleans up the RenderBox code for absolutely positioned elements
and adds new functions for replaced absolutely positioned
elements. Now uses Length so that magic number -666666 for
auto lengths is no longer used.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteHorizontalValues): (WebCore::RenderBox::calcAbsoluteVertical): (WebCore::RenderBox::calcAbsoluteVerticalValues): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): Handle replaced case separately. (WebCore::RenderBox::calcAbsoluteVerticalReplaced): ditto.
  • rendering/RenderBox.h:

LayoutTests:

  • fast/block/positioning/absolute-length-of-neg-666666.html: Added.
  • fast/block/positioning/absolute-positioned-overconstrained.html: Added.
  • fast/block/positioning/auto/006.html: Updated to reflect that the containing block's direction, not the parent's is used.
  • fast/css/absolute-poition-in-rtl-parent.html: Updated and cleaned up.

May 12, 2006:

11:41 PM Changeset in webkit [14350] by hyatt
  • 7 edits in trunk/WebCore

Bug 8880, remove the remaining drawing/hit testing code from
FontData.

Reviewed by tim h

  • platform/Font.cpp: (WebCore::m_finalRoundingWidth): (WebCore::WidthIterator::advanceOneCharacter): (WebCore::Font::selectionRectForText): (WebCore::Font::selectionRectForSimpleText): (WebCore::Font::offsetForPosition): (WebCore::Font::offsetForPositionForSimpleText):
  • platform/Font.h: (WebCore::TextRun::makeComplete):
  • platform/FontData.h:
  • platform/GlyphBuffer.h: (WebCore::GlyphBuffer::clear):
  • platform/mac/FontData.mm:
  • platform/mac/FontMac.mm: (WebCore::Font::selectionRectForComplexText): (WebCore::Font::offsetForPositionForComplexText):
8:26 PM Changeset in webkit [14349] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Reviewed by Maciej.

8:26 PM Changeset in webkit [14348] by darin
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Add missing include.


  • dom/Node.h: Add missing include for DeprecatedString.
8:24 PM Changeset in webkit [14347] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/dynamic/selection-highlight-adjust-expected.checksum: Added.
  • fast/dynamic/selection-highlight-adjust-expected.png: Added.
  • fast/dynamic/selection-highlight-adjust-expected.txt: Added.
  • fast/dynamic/selection-highlight-adjust.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/dynamic/selection-highlight-adjust.html

  • rendering/render_line.cpp: (WebCore::RootInlineBox::adjustPosition): Adjust m_selectionTop and m_selectionBottom.
7:44 PM Changeset in webkit [14346] by thatcher
  • 5 edits
    1 add in trunk/WebCore

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=7156
Bug 7156: TinyMCE: Links are actually activated in editable area, not editable.


Links in editable areas will not activate or perform a navigation
change (on par with WinIE and Firefox.) To visit the link
you can shift-click. Manual test added.

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle):
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): (WebCore::HTMLAnchorElement::setActive):
  • html/HTMLAnchorElement.h:
  • manual-tests/contenteditable-link.html: Added.
  • page/FrameView.cpp: (WebCore::selectCursor):
6:36 PM Changeset in webkit [14345] by eseidel
  • 10 edits
    8 copies
    2 moves in trunk/WebCore

2006-05-12 Eric Seidel <eseidel@apple.com>

Reviewed by timo.

Split out html_inlineimpl.* into separate files (one per class).

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_html.cpp:
  • bindings/objc/DOMHTML.mm:
  • editing/CreateLinkCommand.cpp:
  • editing/UnlinkCommand.cpp:
  • html/HTMLAnchorElement.cpp: Added. (WebCore::HTMLAnchorElement::HTMLAnchorElement):
  • html/HTMLAnchorElement.h: Added.
  • html/HTMLBRElement.cpp: Added.
  • html/HTMLBRElement.h: Added.
  • html/HTMLElementFactory.cpp:
  • html/HTMLFontElement.cpp: Added. (WebCore::HTMLFontElement::HTMLFontElement): (WebCore::HTMLFontElement::setColor): (WebCore::HTMLFontElement::setFace): (WebCore::HTMLFontElement::setSize):
  • html/HTMLFontElement.h: Added.
  • html/HTMLModElement.cpp: Added. (WebCore::HTMLModElement::setCite): (WebCore::HTMLModElement::setDateTime):
  • html/HTMLModElement.h: Added.
  • html/HTMLQuoteElement.cpp: Added.
  • html/HTMLQuoteElement.h: Added.
  • html/html_imageimpl.h:
  • html/html_inlineimpl.cpp: Removed.
  • html/html_inlineimpl.h: Removed.
  • page/FrameView.cpp:
5:57 PM Changeset in webkit [14344] by eseidel
  • 3 edits in trunk/WebCore

2006-05-12 Eric Seidel <eseidel@apple.com>

Reviewed by beth.

Fix build error.

  • rendering/InlineFlowBox.cpp:
  • rendering/RootInlineBox.cpp:
5:54 PM Changeset in webkit [14343] by eseidel
  • 7 edits
    8 copies
    1 move in trunk/WebCore

2006-05-12 Eric Seidel <eseidel@apple.com>

Reviewed by beth.

Split out render_line.* into separate files (one per class).

  • WebCore.xcodeproj/project.pbxproj:
  • dom/ContainerNode.cpp:
  • rendering/EllipsisBox.cpp: Added.
  • rendering/EllipsisBox.h: Added. (WebCore::EllipsisBox::EllipsisBox):
  • rendering/InlineBox.cpp: Added.
  • rendering/InlineBox.h: Added. (WebCore::InlineBox::InlineBox): (WebCore::InlineBox::~InlineBox): (WebCore::InlineBox::bottomOverflow): (WebCore::InlineBox::rightOverflow):
  • rendering/InlineFlowBox.cpp: Added. (WebCore::InlineFlowBox::placeBoxesHorizontally):
  • rendering/InlineFlowBox.h: Added.
  • rendering/InlineRunBox.h: Added. (WebCore::InlineRunBox::InlineRunBox): (WebCore::InlineRunBox::paintBackgroundAndBorder): (WebCore::InlineRunBox::paintDecorations):
  • rendering/InlineTextBox.h:
  • rendering/RenderBlock.h:
  • rendering/RenderFlow.h:
  • rendering/RenderReplaced.cpp:
  • rendering/RootInlineBox.cpp: Added.
  • rendering/RootInlineBox.h: Added. (WebCore::RootInlineBox::RootInlineBox):
  • rendering/render_line.h: Removed.
4:50 PM Changeset in webkit [14342] by eseidel
  • 1 edit
    1 delete in trunk/WebCore

spelling fix

4:44 PM Changeset in webkit [14341] by eseidel
  • 3 edits
    4 copies
    2 moves in trunk/WebCore

2006-05-12 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

Split out table_layout.* into separate files (one per class).
Search replace instnace variables "foo" with "m_foo" to comply with modern style.

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/AutoTableLayout.cpp: Added. (WebCore::AutoTableLayout::AutoTableLayout): (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::fullRecalc): (WebCore::AutoTableLayout::calcMinMaxWidth): (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::insertSpanCell): (WebCore::AutoTableLayout::layout): (WebCore::AutoTableLayout::calcPercentages):
  • rendering/AutoTableLayout.h: Added. (WebCore::AutoTableLayout::totalPercent): (WebCore::AutoTableLayout::Layout::Layout):
  • rendering/FixedTableLayout.cpp: Added. (WebCore::FixedTableLayout::FixedTableLayout): (WebCore::FixedTableLayout::calcWidthArray): (WebCore::FixedTableLayout::calcMinMaxWidth): (WebCore::FixedTableLayout::layout):
  • rendering/FixedTableLayout.h: Added.
  • rendering/RenderTable.cpp:
  • rendering/TableLayout.h: Added. (WebCore::TableLayout::TableLayout):
  • rendering/table_layout.cpp: Removed.
  • rendering/table_layout.h: Removed.
4:39 PM Changeset in webkit [14340] by thatcher
  • 1 copy in tags/WebCore-418.5/WebCore

Tag for WebCore 418.5 (part 2 of 2.)

4:39 PM Changeset in webkit [14339] by thatcher
  • 1 add in tags/WebCore-418.5

Tag for WebCore 418.5 (part 1 of 2.)

4:39 PM Changeset in webkit [14338] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

4:28 PM Changeset in webkit [14337] by hyatt
  • 15 edits in trunk/WebCore

Bug 8877. Change form controls and the bridge entry points from the
Safari UI to use Font instead of FontData.

Reviewed by mjs

  • bridge/mac/WebCoreStringTruncator.mm: (stringWidth): (truncateString): (+[WebCoreStringTruncator widthOfString:font:]): (+[WebCoreStringTruncator clear]):
  • kwq/KWQComboBox.mm: (QComboBox::sizeHint):
  • kwq/KWQLineEdit.mm: (QLineEdit::sizeForCharacterWidth):
  • kwq/KWQListBox.mm: (itemTextRenderer): (groupLabelTextRenderer): (QListBox::sizeForNumberOfLines): (QListBox::clearCachedTextRenderers): (-[KWQTableView drawRow:clipRect:]):
  • platform/Font.cpp: (WebCore::Font::drawSimpleText): (WebCore::Font::drawText):
  • platform/Font.h: (WebCore::TextStyle::disableRoundingHacks): (WebCore::TextStyle::setRTL):
  • platform/FontData.h:
  • platform/FontFallbackList.h:
  • platform/FontPlatformData.h: (WebCore::FontPlatformData::syntheticOblique):
  • platform/Pen.h:
  • platform/mac/FontData.mm: (WebCore::FontData::smallCapsFontData): (WebCore::findSubstituteRenderer):
  • platform/mac/FontMac.mm: (WebCore::FontFallbackList::setPlatformFont): (WebCore::m_wordSpacing): (WebCore::Font::drawComplexText):
  • platform/mac/WebCoreTextRenderer.mm: (WebCoreDrawTextAtPoint): (WebCoreTextFloatWidth):
  • platform/win/FontWin.cpp: (WebCore::Font::drawText):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::positionForOffset):
4:14 PM Changeset in webkit [14336] by eseidel
  • 14 edits
    2 moves in trunk/WebCore

2006-05-12 Eric Seidel <eseidel@apple.com>

Reviewed by kevin.

Move render_button to RenderButton.
Various small style cleanup.

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLButtonElement.cpp:
  • html/HTMLElement.cpp:
  • html/HTMLGenericFormElement.cpp:
  • html/HTMLInputElement.cpp:
  • platform/mac/WebCoreTextArea.mm:
  • rendering/RenderApplet.h:
  • rendering/RenderBox.cpp:
  • rendering/RenderButton.cpp: Added. (WebCore::RenderButton::RenderButton): (WebCore::RenderButton::addChild): (WebCore::RenderButton::removeChild):
  • rendering/RenderButton.h: Added.
  • rendering/RenderEmptyApplet.h:
  • rendering/RenderHTMLCanvas.h:
  • rendering/RenderTreeAsText.cpp:
  • rendering/render_button.cpp: Removed.
  • rendering/render_button.h: Removed.
  • rendering/table_layout.cpp: (WebCore::FixedTableLayout::FixedTableLayout): (WebCore::FixedTableLayout::calcWidthArray): (WebCore::FixedTableLayout::calcMinMaxWidth): (WebCore::FixedTableLayout::layout): (WebCore::AutoTableLayout::AutoTableLayout): (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::fullRecalc): (WebCore::AutoTableLayout::calcMinMaxWidth): (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::insertSpanCell): (WebCore::AutoTableLayout::layout):
  • rendering/table_layout.h: (WebCore::TableLayout::TableLayout): (WebCore::AutoTableLayout::totalPercent): (WebCore::AutoTableLayout::Layout::Layout):
4:08 PM Changeset in webkit [14335] by bdakin
  • 4 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0 branch. Fixes <rdar://problem/
4536941> Branch regression: : Random crash occurs when navigating
site at http://abcnews.go.com/ (KHTMLParser::popOneBlock(bool) +
56)

2006-01-26 Maciej Stachowiak <mjs@apple.com>

Reviewed by Eric.

  • various leaks on "fast" LayoutTests


http://bugzilla.opendarwin.org/show_bug.cgi?id=6819
http://bugzilla.opendarwin.org/show_bug.cgi?id=6823
http://bugzilla.opendarwin.org/show_bug.cgi?id=6824


It turns out these all had the same cause.


  • page/Frame.cpp: (Frame::clear): If we have a document, make sure to cancel parsing, in case it has a tokenizer and parser that are keeping it alive. Use cancelParsing to avoid possibly accidentally firing the onload handler.
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::cancelParsing): Factored out of implicitOpen. (WebCore::DocumentImpl::implicitOpen): Call cancelParsing now.
  • khtml/xml/DocumentImpl.h:
3:56 PM Changeset in webkit [14334] by eseidel
  • 17 edits
    18 copies
    6 moves in trunk/WebCore

2006-05-12 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Split render_frames.* render_replaced.* and html_baseimpl.* into separate files (one class per file).
http://bugzilla.opendarwin.org/show_bug.cgi?id=8878

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_html.cpp: (KJS::JSHTMLDocumentProtoFunc::callAsFunction): (KJS::JSHTMLDocument::namedItemGetter): (KJS::JSHTMLDocument::getValueProperty): (KJS::JSHTMLDocument::getOwnPropertySlot): (KJS::JSHTMLDocument::putValueProperty): (KJS::JSHTMLElement::formIndexGetter): (KJS::JSHTMLElement::formNameGetter): (KJS::JSHTMLElement::selectIndexGetter): (KJS::JSHTMLElement::framesetNameGetter): (KJS::JSHTMLElement::runtimeObjectGetter): (KJS::JSHTMLElement::runtimeObjectPropertyGetter): (KJS::JSHTMLElement::getOwnPropertySlot): (KJS::JSHTMLElement::implementsCall): (KJS::JSHTMLElement::callAsFunction): (KJS::JSHTMLElement::getValueProperty): (KJS::JSHTMLElement::toString): (KJS::getForm): (KJS::JSHTMLElement::pushEventHandlerScope): (KJS::HTMLElementFunction::callAsFunction): (KJS::JSHTMLElement::put): (KJS::JSHTMLElement::selectSetter): (KJS::JSHTMLElement::putValueProperty): (KJS::toHTMLElement): (KJS::toHTMLTableCaptionElement): (KJS::toHTMLTableSectionElement): (KJS::JSHTMLCollection::lengthGetter): (KJS::JSHTMLCollection::indexGetter): (KJS::JSHTMLCollection::nameGetter): (KJS::JSHTMLCollection::getOwnPropertySlot): (KJS::HTMLCollectionProtoFunc::callAsFunction): (KJS::JSHTMLSelectCollection::selectedIndexGetter): (KJS::JSHTMLSelectCollection::put): (KJS::OptionConstructorImp::construct): (KJS::getSelectHTMLCollection):
  • bindings/objc/DOMHTML.mm:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::createFrame):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge copyRenderNode:copier:]):
  • dom/Document.cpp: (WebCore::widgetForNode):
  • html/HTMLBodyElement.cpp: Added. (WebCore::HTMLBodyElement::HTMLBodyElement): (WebCore::HTMLBodyElement::parseMappedAttribute):
  • html/HTMLBodyElement.h: Added.
  • html/HTMLDocument.cpp:
  • html/HTMLElementFactory.cpp:
  • html/HTMLEmbedElement.cpp:
  • html/HTMLFrameElement.cpp: Added. (WebCore::HTMLFrameElement::isURLAllowed): (WebCore::HTMLFrameElement::parseMappedAttribute): (WebCore::HTMLFrameElement::setLocation):
  • html/HTMLFrameElement.h: Added.
  • html/HTMLFrameSetElement.cpp: Added. (WebCore::HTMLFrameSetElement::HTMLFrameSetElement): (WebCore::HTMLFrameSetElement::parseMappedAttribute): (WebCore::HTMLFrameSetElement::attach): (WebCore::HTMLFrameSetElement::defaultEventHandler): (WebCore::HTMLFrameSetElement::recalcStyle):
  • html/HTMLFrameSetElement.h: Added.
  • html/HTMLHeadElement.cpp: Added. (WebCore::HTMLHeadElement::HTMLHeadElement):
  • html/HTMLHeadElement.h: Added.
  • html/HTMLHtmlElement.cpp: Added. (WebCore::HTMLHtmlElement::HTMLHtmlElement):
  • html/HTMLHtmlElement.h: Added.
  • html/HTMLIFrameElement.cpp: Added. (WebCore::HTMLIFrameElement::HTMLIFrameElement):
  • html/HTMLIFrameElement.h: Added.
  • html/HTMLObjectElement.cpp:
  • html/HTMLParser.cpp:
  • html/html_baseimpl.cpp: Removed.
  • html/html_baseimpl.h: Removed.
  • kwq/WebCoreAXObject.mm:
  • page/Frame.cpp: (WebCore::isFrameElement): (WebCore::Frame::applyEditingStyleToBodyElement): (WebCore::Frame::removeEditingStyleFromBodyElement): (WebCore::Frame::applyEditingStyleToElement): (WebCore::Frame::removeEditingStyleFromElement): (WebCore::Frame::selectionRect): (WebCore::Frame::isFrameSet): (WebCore::scanForForm): (WebCore::Frame::currentForm): (WebCore::Frame::nodeInfoAtPoint): (WebCore::Frame::adjustPageHeight): (WebCore::Frame::frameForWidget): (WebCore::Frame::forceLayoutWithPageWidthRange): (WebCore::Frame::passWidgetMouseDownEventToWidget):
  • page/FrameView.cpp:
  • rendering/RenderFrame.cpp: Added. (WebCore::RenderFrame::viewCleared):
  • rendering/RenderFrame.h: Added.
  • rendering/RenderFrameSet.cpp: Added. (WebCore::RenderFrameSet::RenderFrameSet): (WebCore::RenderFrameSet::~RenderFrameSet): (WebCore::RenderFrameSet::layout): (WebCore::RenderFrameSet::positionFrames): (WebCore::RenderFrameSet::userResize): (WebCore::RenderFrameSet::canResize): (WebCore::RenderFrameSet::dump):
  • rendering/RenderFrameSet.h: Added.
  • rendering/RenderImage.h:
  • rendering/RenderPart.cpp: Added. (WebCore::RenderPart::RenderPart):
  • rendering/RenderPart.h: Added.
  • rendering/RenderPartObject.cpp: Added. (WebCore::isURLAllowed): (WebCore::RenderPartObject::updateWidget): (WebCore::RenderPartObject::viewCleared):
  • rendering/RenderPartObject.h: Added.
  • rendering/RenderReplaced.cpp: Added. (WebCore::RenderReplaced::selectionColor):
  • rendering/RenderReplaced.h: Added.
  • rendering/RenderWidget.cpp: Added. (WebCore::RenderWidget::deleteWidget):
  • rendering/RenderWidget.h: Added.
  • rendering/render_form.h:
  • rendering/render_frames.cpp: Removed.
  • rendering/render_frames.h: Removed.
  • rendering/render_replaced.cpp: Removed.
  • rendering/render_replaced.h: Removed.
3:21 PM Changeset in webkit [14333] by mjs
  • 19 edits
    1 add in trunk/WebKit

Reviewed by Brady.


http://bugzilla.opendarwin.org/show_bug.cgi?id=8876

  • move most private WebDataSource methods to uninstalled header


I put the declarations for the ones only used in WebKit in WebDataSourceInternal.h
and removed two entirey unused ones.

  • Plugins/WebNetscapePluginRepresentation.m:
  • Plugins/WebNetscapePluginStream.m:
  • Plugins/WebPluginController.m:
  • Plugins/WebPluginDocumentView.m:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge dataSource]):
  • WebCoreSupport/WebSubresourceLoader.m:
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDataSource.m: (-[WebDataSource _updateIconDatabaseWithURL:]): (-[WebDataSource _loadIcon]): (-[WebDataSource _clearErrors]): (-[WebDataSource _commitLoadWithData:]): (-[WebDataSource _doesProgressiveLoadWithMIMEType:]): (-[WebDataSource _addResponse:]):
  • WebView/WebDataSourceInternal.h: Added.
  • WebView/WebDataSourcePrivate.h:
  • WebView/WebFrame.m:
  • WebView/WebHTMLRepresentation.m:
  • WebView/WebHTMLView.m:
  • WebView/WebImageView.m:
  • WebView/WebLoader.m:
  • WebView/WebMainResourceLoader.m:
  • WebView/WebPDFView.m:
  • WebView/WebRenderNode.m:
  • WebView/WebView.m:
1:44 PM Changeset in webkit [14332] by eseidel
  • 15 edits
    10 copies
    2 moves in trunk/WebCore

2006-05-12 Eric Seidel <eseidel@apple.com>

Reviewed by beth.

Split html_headimpl.* into separate files (one per class)
http://bugzilla.opendarwin.org/show_bug.cgi?id=8875

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_css.cpp:
  • bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::headGetter): (KJS::JSHTMLElement::linkGetter):
  • bindings/objc/DOMCSS.mm: (+[DOMCounter _counterWith:]): (-[DOMCounter finalize]): (-[DOMCounter _DOMStyleSheet]): (-[DOMStyleSheet _initWithStyleSheet:]): (-[DOMStyleSheetList dealloc]): (-[DOMStyleSheetList finalize]): (-[DOMStyleSheetList _styleSheetList]): (-[DOMStyleSheetList _initWithStyleSheetList:]): (-[DOMCSSStyleSheet _CSSStyleSheet]): (-[DOMMediaList dealloc]): (-[DOMMediaList finalize]): (-[DOMMediaList _mediaList]): (-[DOMMediaList _initWithMediaList:]): (-[DOMCSSRuleList dealloc]): (-[DOMCSSRuleList finalize]): (-[DOMCSSRuleList _ruleList]): (-[DOMCSSRuleList _initWithRuleList:]): (-[DOMCSSRule dealloc]): (-[DOMCSSRule finalize]): (-[DOMCSSRule _rule]): (-[DOMCSSRule _initWithRule:]): (-[DOMCSSStyleRule _styleRule]): (-[DOMCSSMediaRule _mediaRule]): (-[DOMCSSFontFaceRule _fontFaceRule]): (-[DOMCSSPageRule _pageRule]): (-[DOMCSSImportRule _importRule]): (-[DOMCSSCharsetRule _importRule]): (-[DOMCSSStyleDeclaration dealloc]): (-[DOMCSSStyleDeclaration finalize]): (-[DOMCSSStyleDeclaration _initWithStyleDeclaration:]): (-[DOMCSSStyleDeclaration _styleDeclaration]): (-[DOMCSSValue dealloc]): (-[DOMCSSValue finalize]): (-[DOMCSSValue _value]): (-[DOMCSSValue _initWithValue:]): (-[DOMCSSPrimitiveValue _primitiveValue]): (-[DOMCSSValueList _valueList]): (getWrapperForRGB): (setWrapperForRGB): (removeWrapperForRGB): (-[DOMRGBColor _initWithRGB:]): (-[DOMRect dealloc]): (-[DOMRect finalize]): (-[DOMRect _rect]): (-[DOMRect _initWithRect:]): (-[DOMCounter dealloc]): (-[DOMCounter _counter]): (-[DOMCounter _initWithCounter:]): (-[DOMObject sheet]):
  • bindings/objc/DOMHTML.mm: (-[DOMHTMLCollection dealloc]): (-[DOMHTMLCollection finalize]): (-[DOMHTMLCollection _collection]): (-[DOMHTMLCollection _initWithCollection:]): (-[DOMHTMLOptionsCollection dealloc]): (-[DOMHTMLOptionsCollection finalize]): (-[DOMHTMLOptionsCollection _initWithOptionsCollection:]): (-[DOMHTMLOptionsCollection _optionsCollection]): (+[DOMHTMLElement _elementWith:]): (-[DOMHTMLElement _HTMLElement]): (-[DOMHTMLDocument _HTMLDocument]): (-[DOMHTMLHtmlElement _HTMLHtmlElement]): (-[DOMHTMLHeadElement _headElement]): (-[DOMHTMLLinkElement _linkElement]): (-[DOMHTMLTitleElement _titleElement]): (-[DOMHTMLMetaElement _metaElement]): (-[DOMHTMLBaseElement _baseElement]): (-[DOMHTMLStyleElement _styleElement]): (-[DOMHTMLBodyElement _bodyElement]): (-[DOMHTMLFormElement _formElement]): (+[DOMHTMLFormElement _formElementWith:]): (-[DOMHTMLIsIndexElement _isIndexElement]): (-[DOMHTMLSelectElement _selectElement]): (-[DOMHTMLOptGroupElement _optGroupElement]): (-[DOMHTMLOptionElement _optionElement]): (-[DOMHTMLInputElement _inputElement]): (-[DOMHTMLTextAreaElement _textAreaElement]): (-[DOMHTMLButtonElement _buttonElement]): (-[DOMHTMLLabelElement _labelElement]): (-[DOMHTMLLabelElement form]): (-[DOMHTMLFieldSetElement _fieldSetElement]): (-[DOMHTMLLegendElement _legendElement]): (-[DOMHTMLUListElement _uListElement]): (-[DOMHTMLOListElement _oListElement]): (-[DOMHTMLDListElement _dListElement]): (-[DOMHTMLDirectoryElement _directoryListElement]): (-[DOMHTMLMenuElement _menuListElement]): (-[DOMHTMLLIElement _liElement]): (-[DOMHTMLQuoteElement _quoteElement]): (-[DOMHTMLDivElement _divElement]): (-[DOMHTMLParagraphElement _paragraphElement]): (-[DOMHTMLHeadingElement _headingElement]): (-[DOMHTMLPreElement _preElement]): (-[DOMHTMLBRElement _BRElement]): (-[DOMHTMLBaseFontElement _baseFontElement]): (-[DOMHTMLFontElement _fontElement]): (-[DOMHTMLHRElement _HRElement]): (-[DOMHTMLModElement _modElement]): (-[DOMHTMLAnchorElement _anchorElement]): (-[DOMHTMLImageElement _imageElement]): (-[DOMHTMLObjectElement _objectElement]): (-[DOMHTMLParamElement _paramElement]): (-[DOMHTMLMapElement _mapElement]): (-[DOMHTMLAreaElement _areaElement]): (-[DOMHTMLScriptElement _scriptElement]): (+[DOMHTMLTableCaptionElement _tableCaptionElementWith:]): (-[DOMHTMLTableCaptionElement _tableCaptionElement]): (+[DOMHTMLTableSectionElement _tableSectionElementWith:]): (-[DOMHTMLTableSectionElement _tableSectionElement]): (-[DOMHTMLTableElement createTHead]): (-[DOMHTMLTableElement createTFoot]): (-[DOMHTMLTableElement createCaption]): (-[DOMHTMLTableElement insertRow:]): (+[DOMHTMLTableElement _tableElementWith:]): (-[DOMHTMLTableElement _tableElement]): (-[DOMHTMLTableColElement _tableColElement]): (-[DOMHTMLTableRowElement _tableRowElement]): (-[DOMHTMLTableRowElement insertCell:]): (+[DOMHTMLTableCellElement _tableCellElementWith:]): (-[DOMHTMLTableCellElement _tableCellElement]): (-[DOMHTMLFrameSetElement _frameSetElement]): (-[DOMHTMLFrameElement _frameElement]): (-[DOMHTMLIFrameElement _IFrameElement]): (-[DOMHTMLEmbedElement _embedElement]): (viewForElement):
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::searchForLabelsAboveCell): (WebCore::FrameMac::searchForLabelsBeforeElement): (WebCore::FrameMac::createFrame): (WebCore::FrameMac::passMouseDownEventToWidget): (WebCore::FrameMac::passSubframeEventToSubframe): (WebCore::FrameMac::passWheelEventToChildWidget): (WebCore::FrameMac::fileWrapperForElement): (WebCore::listParent): (WebCore::FrameMac::attributedString): (WebCore::FrameMac::shouldBeginEditing): (WebCore::FrameMac::shouldEndEditing): (WebCore::FrameMac::setMarkedTextRange):
  • dom/Document.cpp:
  • dom/xml_tokenizer.cpp:
  • html/HTMLBaseElement.cpp: Added. (WebCore::HTMLBaseElement::removedFromDocument): (WebCore::HTMLBaseElement::process):
  • html/HTMLBaseElement.h: Added.
  • html/HTMLDocument.cpp:
  • html/HTMLElementFactory.cpp:
  • html/HTMLLinkElement.cpp: Added. (WebCore::HTMLLinkElement::HTMLLinkElement): (WebCore::HTMLLinkElement::process):
  • html/HTMLLinkElement.h: Added.
  • html/HTMLMetaElement.cpp: Added. (WebCore::HTMLMetaElement::HTMLMetaElement): (WebCore::HTMLMetaElement::parseMappedAttribute): (WebCore::HTMLMetaElement::process): (WebCore::HTMLMetaElement::setContent): (WebCore::HTMLMetaElement::setHttpEquiv): (WebCore::HTMLMetaElement::setName):
  • html/HTMLMetaElement.h: Added.
  • html/HTMLParser.cpp:
  • html/HTMLScriptElement.cpp: Added. (WebCore::HTMLScriptElement::HTMLScriptElement): (WebCore::HTMLScriptElement::parseMappedAttribute): (WebCore::HTMLScriptElement::evaluateScript):
  • html/HTMLScriptElement.h: Added.
  • html/HTMLStyleElement.cpp: Added. (WebCore::HTMLStyleElement::HTMLStyleElement):
  • html/HTMLStyleElement.h: Added.
  • html/HTMLTitleElement.cpp: Added. (WebCore::HTMLTitleElement::HTMLTitleElement): (WebCore::HTMLTitleElement::text): (WebCore::HTMLTitleElement::setText):
  • html/HTMLTitleElement.h: Added.
  • html/html_headimpl.cpp: Removed.
  • html/html_headimpl.h: Removed.
  • loader/CachedCSSStyleSheet.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::updateFromElement):
  • rendering/RenderTableCol.cpp: (WebCore::RenderTableCol::updateFromElement):
12:44 PM Changeset in webkit [14331] by eseidel
  • 2 edits
    12 copies
    2 moves in trunk/WebCore

2006-05-12 Eric Seidel <eseidel@apple.com>

Reviewed by beth.

Split out html_tableimpl.* into multiple files (one per class)
http://bugzilla.opendarwin.org/show_bug.cgi?id=8873

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLTableCaptionElement.cpp: Added. (WebCore::HTMLTableCaptionElement::HTMLTableCaptionElement):
  • html/HTMLTableCaptionElement.h: Added.
  • html/HTMLTableCellElement.cpp: Added. (WebCore::HTMLTableCellElement::HTMLTableCellElement):
  • html/HTMLTableCellElement.h: Added.
  • html/HTMLTableColElement.cpp: Added. (WebCore::HTMLTableColElement::HTMLTableColElement): (WebCore::HTMLTableColElement::endTagRequirement): (WebCore::HTMLTableColElement::tagPriority): (WebCore::HTMLTableColElement::checkDTD):
  • html/HTMLTableColElement.h: Added.
  • html/HTMLTableElement.cpp: Added. (WebCore::HTMLTableElement::HTMLTableElement): (WebCore::HTMLTableElement::setCaption): (WebCore::HTMLTableElement::setTHead): (WebCore::HTMLTableElement::setTFoot): (WebCore::HTMLTableElement::setTBody): (WebCore::HTMLTableElement::createTHead): (WebCore::HTMLTableElement::deleteTHead): (WebCore::HTMLTableElement::createTFoot): (WebCore::HTMLTableElement::deleteTFoot): (WebCore::HTMLTableElement::createCaption): (WebCore::HTMLTableElement::deleteCaption): (WebCore::HTMLTableElement::insertRow): (WebCore::HTMLTableElement::deleteRow): (WebCore::HTMLTableElement::addChild): (WebCore::HTMLTableElement::parseMappedAttribute): (WebCore::HTMLTableElement::attach):
  • html/HTMLTableElement.h: Added.
  • html/HTMLTablePartElement.cpp: Added. (WebCore::HTMLTablePartElement::parseMappedAttribute):
  • html/HTMLTablePartElement.h: Added.
  • html/HTMLTableRowElement.cpp: Added. (WebCore::HTMLTableRowElement::HTMLTableRowElement): (WebCore::HTMLTableRowElement::rowIndex):
  • html/HTMLTableRowElement.h: Added.
  • html/HTMLTableSectionElement.cpp: Added. (WebCore::HTMLTableSectionElement::insertRow):
  • html/HTMLTableSectionElement.h: Added.
  • html/html_tableimpl.cpp: Removed.
  • html/html_tableimpl.h: Removed.
11:51 AM Changeset in webkit [14330] by thatcher
  • 1 copy in tags/WebCore-418.4/WebCore

Tag for WebCore 418.4 (part 2 of 2.)

11:51 AM Changeset in webkit [14329] by thatcher
  • 1 add in tags/WebCore-418.4

Tag for WebCore 418.4 (part 1 of 2.)

11:51 AM Changeset in webkit [14328] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

11:14 AM Changeset in webkit [14327] by eseidel
  • 11 edits
    8 copies
    2 moves in trunk/WebCore

2006-05-10 Eric Seidel <eseidel@apple.com>

Reviewed by mjs & adele.

Split html_objectimpl.* into multiple files (one per class)
http://bugzilla.opendarwin.org/show_bug.cgi?id=8836

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_dom.cpp: (KJS::DOMNamedNodeMap::lengthGetter): (KJS::DOMNamedNodeMap::indexGetter): (KJS::DOMNamedNodeMap::nameGetter): (KJS::DOMNamedNodeMapProtoFunc::callAsFunction): (KJS::getRuntimeObject):
  • bindings/js/kjs_html.cpp:
  • html/HTMLAppletElement.cpp: Added.
  • html/HTMLAppletElement.h: Added.
  • html/HTMLElementFactory.cpp:
  • html/HTMLEmbedElement.cpp: Added. (WebCore::HTMLEmbedElement::HTMLEmbedElement): (WebCore::HTMLEmbedElement::getInstance): (WebCore::HTMLEmbedElement::parseMappedAttribute):
  • html/HTMLEmbedElement.h: Added.
  • html/HTMLNameCollection.cpp: (WebCore::HTMLNameCollection::traverseNextItem):
  • html/HTMLObjectElement.cpp: Added. (WebCore::HTMLObjectElement::getInstance): (WebCore::HTMLObjectElement::form): (WebCore::HTMLObjectElement::parseMappedAttribute): (WebCore::HTMLObjectElement::updateDocNamedItem):
  • html/HTMLObjectElement.h: Added.
  • html/HTMLParamElement.cpp: Added.
  • html/HTMLParamElement.h: Added.
  • html/HTMLParser.cpp:
  • html/HTMLPlugInElement.cpp: Added.
  • html/HTMLPlugInElement.h: Added.
  • html/html_objectimpl.cpp: Removed.
  • html/html_objectimpl.h: Removed.
  • page/Frame.cpp: (WebCore::Frame::handleFallbackContent):
  • rendering/RenderApplet.cpp:
  • rendering/render_frames.cpp: (WebCore::RenderPartObject::updateWidget):
10:53 AM Changeset in webkit [14326] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2006-05-12 Tim Omernick <timo@apple.com>

Reviewed by John Sullivan.

<rdar://problem/4542808> REGRESSION: benchjs test 1 has slowed by over 150% (8740)
<http://bugzilla.opendarwin.org/show_bug.cgi?id=8740>

Improvement to my NSWindow display throttle hack. Remember the last flush time instead of the last display time.
Our goal is to never draw less than 1/60th of a second after the window is flushed in order to avoid blocking on
a CG coalesced update. Using the last display time is close, but this is much more accurate. I have verified that
this further improves our score on BenchJS Test 1 (by 9.8% with the status bar shown compared to the previous build),
as well as on our internal PLT scores by a smaller percentage.

  • Misc/WebNSWindowExtras.m: Renamed lastDisplayTime to lastFlushTime. (+[NSWindow _webkit_enableWindowDisplayThrottle]): Replace -[NSWindow flushWindow] with our own implementation. (+[NSWindow _webkit_disableWindowDisplayThrottle]): Restore -[NSWindow flushWindow]. (replacementFlushWindow): Use the last flush time instead of the last display time. (getWindowDisplayInfo): Renamed lastDisplayTime to lastFlushTime. (requestWindowDisplay): Moved some code to replacementFlushWindow().
10:40 AM Changeset in webkit [14325] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.

<rdar://problem/4542808> REGRESSION: benchjs test 1 has slowed by over 150% (8740)
<http://bugzilla.opendarwin.org/show_bug.cgi?id=8740>

Improvement to my NSWindow display throttle hack. Remember the last flush time instead of the last display time.
Our goal is to never draw less than 1/60th of a second after the window is flushed in order to avoid blocking on
a CG coalesced update. Using the last display time is close, but this is much more accurate. I have verified that
this further improves our score on BenchJS Test 1 (by 9.8% with the status bar shown compared to the previous build),
as well as on our internal PLT scores by a smaller percentage.

  • Misc/WebNSWindowExtras.m: Renamed lastDisplayTime to lastFlushTime. (+[NSWindow _webkit_enableWindowDisplayThrottle]): Replace -[NSWindow flushWindow] with our own implementation. (+[NSWindow _webkit_disableWindowDisplayThrottle]): Restore -[NSWindow flushWindow]. (replacementFlushWindow): Use the last flush time instead of the last display time. (getWindowDisplayInfo): Renamed lastDisplayTime to lastFlushTime. (requestWindowDisplay): Moved some code to replacementFlushWindow().
9:49 AM Changeset in webkit [14324] by darin
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Adele.

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::sendContextMenuEvent): Added a null check.
  • manual-tests/context-click-generated-content.html: Added.
9:45 AM Changeset in webkit [14323] by darin
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Adele.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::caretRect): Move caret to the right side of the rect when the offset is non-zero, rather than expanding it.
  • manual-tests/caret-image.html: Added.
5:35 AM Changeset in webkit [14322] by andersca
  • 3 edits
    4 adds in trunk

WebCore:

2006-05-12 Mitz Pettel <opendarwin.org@mitzpettel.com>

Reviewed and landed by Anders.


Test: fast/text/international/rtl-caret.html

  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::positionForOffset): Added missing m_toAdd argument.

LayoutTests:

2006-05-12 Mitz Pettel <opendarwin.org@mitzpettel.com>

Reviewed and landed by Anders.


  • fast/text/international/rtl-caret-expected.checksum: Added.
  • fast/text/international/rtl-caret-expected.png: Added.
  • fast/text/international/rtl-caret-expected.txt: Added.
  • fast/text/international/rtl-caret.html: Added.
2:22 AM Changeset in webkit [14321] by hyatt
  • 10 edits in trunk/WebCore

Bug 8864. Lift WebCoreTextStyle up into the API (as TextStyle).

Reviewed by mjs

  • platform/Font.cpp: (WebCore::m_finalRoundingWidth): (WebCore::WidthIterator::advance): (WebCore::Font::width): (WebCore::Font::drawSimpleText): (WebCore::Font::drawText): (WebCore::Font::floatWidth): (WebCore::Font::floatWidthForSimpleText):
  • platform/Font.h: (WebCore::TextStyle::m_attemptFontSubstitution): (WebCore::TextStyle::tabWidth): (WebCore::TextStyle::xPos): (WebCore::TextStyle::padding): (WebCore::TextStyle::rtl): (WebCore::TextStyle::ltr): (WebCore::TextStyle::directionalOverride): (WebCore::TextStyle::applyRunRounding): (WebCore::TextStyle::applyWordRounding): (WebCore::TextStyle::attemptFontSubstitution): (WebCore::Font::operator==):
  • platform/GraphicsContext.cpp: (WebCore::GraphicsContext::drawText): (WebCore::GraphicsContext::drawHighlightForText):
  • platform/GraphicsContext.h:
  • platform/mac/FontMac.mm: (WebCore::overrideLayoutOperation): (WebCore::ATSULayoutParameters::initialize): (WebCore::Font::selectionRectForText): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPosition):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset):
  • rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache): (WebCore::RenderText::calcMinMaxWidth): (WebCore::RenderText::width):
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::calcMinMaxWidth):
  • rendering/render_line.cpp: (WebCore::EllipsisBox::paint):

May 11, 2006:

9:51 PM Changeset in webkit [14320] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

Test: fast/loader/url-strip-cr-lf-tab.html

  • platform/KURL.cpp: (appendEscapingBadChars): Strip CR, LF and TAB, as Firefox and IE do.
9:43 PM Changeset in webkit [14319] by thatcher
  • 4 edits in trunk/WebKit

Reviewed by Darin.

Bug 8856: Web Inspector should show the Xpath for the selected node
http://bugzilla.opendarwin.org/show_bug.cgi?id=8856


Adds an Xpath area to the Node panel.

5:23 PM Changeset in webkit [14318] by hyatt
  • 10 edits in trunk/WebCore

Remove the misspelling drawing code from Font and FontData. Implement it
natively in GraphicContext instead.

Reviewed by maciej

  • platform/FontData.h:
  • platform/GraphicsContext.cpp:
  • platform/GraphicsContext.h:
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawLineForMisspelling):
  • platform/mac/FontData.mm:
  • platform/mac/FontMac.mm:
  • platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForMisspelling):
  • platform/win/FontWin.cpp:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSpellingMarker):
5:04 PM Changeset in webkit [14317] by hyatt
  • 12 edits in trunk/WebCore

Remove drawLineForText from the Font API. Implement it natively in
the two GraphicsContexts (CG and Cairo) instead.

Reviewed by maciej

  • platform/Font.h:
  • platform/FontData.h:
  • platform/GraphicsContext.cpp:
  • platform/GraphicsContext.h:
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawLineForText):
  • platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawLineForText):
  • platform/mac/FontData.mm:
  • platform/mac/FontMac.mm:
  • platform/win/FontWin.cpp: (WebCore::Font::drawLineForText):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintDecoration): (WebCore::InlineTextBox::paintMarkedTextUnderline):
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::paintDecorations):
4:57 PM Changeset in webkit [14316] by bdakin
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/4539954> 10.4.7 regression:DHTML menu
closes prematurely when hovering over it at http://
www.shopping.hp.com/

This fix already exists on TOT, though I am not sure when it was
checked in, nor am I aure what in particular caused this regression
on the branch. Whatever the cause of the badness, though, we need
to take borderTopExtra() and borderBottomExtra() into consideration
when hitTesting the background of a RenderBlock.

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::nodeAtPoint):
4:55 PM Changeset in webkit [14315] by sfalken
  • 2 edits in trunk/WebCore

2006-05-11 Steve Falkenburg <sfalken@apple.com>

Reviewed by eric.

Fix last fix.

  • dom/QualifiedName.h: (WebCore::QualifiedName::QualifiedName):
4:31 PM Changeset in webkit [14314] by sfalken
  • 2 edits in trunk/WebCore

2006-05-11 Steve Falkenburg <sfalken@apple.com>

Reviewed by eric.

Fix crash on static constructors builds at exit due to qualified name default constructor not
initializing m_impl.

  • dom/QualifiedName.cpp: (WebCore::QualifiedName::deref):
4:24 PM Changeset in webkit [14313] by hyatt
  • 4 edits in trunk/WebCore

Reviewed by hyatt

Already covered by several tests in fast/text

  • platform/Font.h: (WebCore::TextRun::TextRun): Added length parameter.
  • rendering/InlineTextBox.cpp: Pass the length to the TextRun constructor. (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset):
  • rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache): Pass length and from instead of from and to to the TextRun constructor. (WebCore::RenderText::width): Ditto.
3:45 PM Changeset in webkit [14312] by harrison
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Justin.


<rdar://problem/4543847> 10.4.7 regression: Mail: selecting the bottom of a message and deleting it leaves a stray newline


Merged most of the DeleteSelectionCommand parts of r14143.

  • khtml/editing/htmlediting.cpp: (DeleteSelectionCommand::initializePositionData): Removed erroneous check that disabled merging based on paragraph boundaries.


(DeleteSelectionCommand::mergeParagraphs):
Return early if upstreamStart and downstreamEnd are flipped, or startblock == endblock.

3:31 PM Changeset in webkit [14311] by hyatt
  • 2 edits in trunk/WebCore

Fix a regression from the TextRun landing. Delete the characters in
the adjustedRun, not the ones in the original run!

Reviewed by beth

  • platform/mac/FontMac.mm: (WebCore::Font::drawComplexText):
3:21 PM Changeset in webkit [14310] by justing
  • 18 edits in trunk

LayoutTests:

Reviewed by thatcher, levi


Inserting an <hr> into <div>foobar</div> now produces
<div>foo</div><hr><div>bar</div>, instead of <div>foo<hr>bar</div>,
which means that removing an inserted <hr> programmatically from
javascript produces a different visual result than before (the
new result is arguably more correct):

  • editing/execCommand/insertHorizontalRule.html:
  • editing/execCommand/insertHorizontalRule-expected.checksum:
  • editing/execCommand/insertHorizontalRule-expected.png:
  • editing/execCommand/insertHorizontalRule-expected.txt:


Equivalent render trees or changes in the editing delegate
notifications that reflect the fact that we are doing an end
merge more often:

  • editing/pasteboard/paste-text-001-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
  • editing/pasteboard/smart-paste-003-expected.txt:
  • editing/pasteboard/smart-paste-004-expected.txt:
  • editing/pasteboard/smart-paste-005-expected.txt:
  • editing/pasteboard/smart-paste-006-expected.txt:
  • editing/pasteboard/smart-paste-007-expected.txt:
  • editing/style/smoosh-styles-001-expected.txt:
  • editing/style/smoosh-styles-002-expected.txt:

WebCore:

Reviewed by thatcher, levi

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Removed a use fragment.hasMoreThanOneBlock to decide if the paragraph containing the position pasted into must be split to avoid block nesting. We now split unnecessarily some times, but the end merge cleans up for us.
3:20 PM Changeset in webkit [14309] by hyatt
  • 3 edits in trunk/LayoutTests/tables/mozilla_expected_failures/bugs

More 8060 layout test fun.

3:18 PM Changeset in webkit [14308] by hyatt
  • 3 edits in trunk/LayoutTests/tables/mozilla/bugs

More 8060 layout test fun.

3:03 PM Changeset in webkit [14307] by hyatt
  • 3 edits in trunk/LayoutTests/fast/text/international

Fix bidi line break layout test to account for bug 8060.

3:02 PM Changeset in webkit [14306] by hyatt
  • 3 edits in trunk/LayoutTests/fast/block/margin-collapse

Fix margin-collapsing layout test to account for bug 8060.

3:01 PM Changeset in webkit [14305] by hyatt
  • 3 edits in trunk/LayoutTests/fast/block/float

Fix float layout test to account for bug 8060.

2:56 PM Changeset in webkit [14304] by hyatt
  • 11 edits in trunk/WebCore

This patch makes drawHighlightForText a completely cross-platform method
implemented by the GraphicsContext. The platform-specific implementations
of the method in the Font class have been eliminated.

Reviewed by andersca

  • platform/Font.h:
  • platform/FontData.h: Remove the drawHighlight methods. Change the selectionRect method in Font to return a FloatRect so that the GraphicsContext can do an accurate fill.
  • platform/GraphicsContext.cpp: (WebCore::GraphicsContext::drawHighlightForText): Implement the drawHighlightFunction in terms of the cross-platform Font selectionRect functions and a new float-based fillRect graphics context function.
  • platform/GraphicsContext.h:
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::fillRect):
  • platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRect): Add the new float-based fillRect function for Cairo and CG.
  • platform/mac/FontData.mm: (WebCore::CG_draw): (WebCore::ATSU_draw): Removed the CG and ATSU drawHighlight methods. Remove the drawing of the background from the deprecated draw methods (they'll be removed soon).
  • platform/mac/FontMac.mm: (WebCore::Font::selectionRectForText):
  • platform/win/FontWin.cpp: (WebCore::Font::selectionRectForText): Change selectionRectForText to return a FloatRect instead of an IntRect, so that the GraphicsContext can do a precise fill.
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::positionForOffset): Modify the callers who expect an int-based selection rect so that they call enclosingIntRect.
12:05 PM Changeset in webkit [14303] by thatcher
  • 4 edits in trunk/WebKit

Reviewed by Anders.

Fixes <rdar://problem/4411845> lots of SPOD trying to scroll through
Markup & Content inspecting body at apple.com (6614)
http://bugzilla.opendarwin.org/show_bug.cgi?id=6614

Removed the Markup & Content pane when viewing a element.
This pane was not that useful and made the inspector really slow
when the markup was large. Only show this pane for text nodes.

11:34 AM Changeset in webkit [14302] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Timothy.

Patch for <http://bugzilla.opendarwin.org/show_bug.cgi?id=8810>
Bug 8810: Scrollbars in WebInspector rendered incorrectly

  • WebInspector/webInspector/inspector.css: Make scroll bars absolutely positioned.
10:47 AM Changeset in webkit [14301] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

  • fast/forms/double-focus-expected.txt: Added.
  • fast/forms/double-focus.html: Added.

WebCore:

Reviewed by Adele.

Test: fast/forms/double-focus.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::focus): Changed to only call setFocusNode, select, and revealSelection if the element is not already focused. Also changed to use return a bit more rather than else.
10:44 AM Changeset in webkit [14300] by thatcher
  • 1 edit in branches/Safari-2-0-branch/WebKit/Misc.subproj/WebNSWindowExtras.m

Build fix.

10:23 AM Changeset in webkit [14299] by darin
  • 3 edits in trunk/WebCore

Reviewed by Tim Hatcher (earlier version).

  • bindings/scripts/IDLParser.pm: Invoke the preprocessor via the "gcc" driver script, passing "-E" so we only preprocess, "-P" so we don't get "#line" directives, and "-x c++" so we handle both C and C++ comments. Removed the code to eliminate comments since the preprocessor handles that.
  • css/make-css-file-arrays.pl: This already invoked the preprocessor, but updated it to do the same way as above.
4:38 AM Changeset in webkit [14298] by andersca
  • 14 edits
    3 adds in trunk

WebCore:

2006-05-11 Anders Carlsson <acarlsson@apple.com>

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=7838
Add support for mozilla-style node constructors as properties of the window object


  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj: Add new generated files.


  • bindings/js/JSCanvasRenderingContext2DBase.cpp: (WebCore::JSCanvasRenderingContext2DBaseProtoFunc::callAsFunction):
  • bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createJSWrapper): Specify the KJS namespace for JSHTMLElmement.


  • bindings/js/kjs_dom.cpp: (KJS::toJS): Create a WebCore::JSHTMLDocument for document nodes. Also, create JSDocumentFragments for document fragments (instead of plain node objects).


  • bindings/js/kjs_html.cpp: (KJS::JSHTMLDocumentProtoFunc::callAsFunction): (KJS::JSHTMLDocument::JSHTMLDocument): (KJS::JSHTMLDocument::getOwnPropertySlot): Add a prototype for JSHTMLDocument and move all functions there.


(KJS::JSHTMLElement::JSHTMLElement):
(KJS::JSHTMLElement::getOwnPropertySlot):
Update since JSHTMLElement now inherits from WebCore::JSHTMLElement.


(KJS::JSHTMLElement::getValueProperty):
(KJS::JSHTMLElement::putValueProperty):
Remove title setter and getter. Those are autogenerated now.


  • bindings/js/kjs_html.h: (KJS::JSHTMLElement::): Inherit from WebCore::JSHTMLElement. Clarify the inheritance chain.


  • bindings/scripts/CodeGeneratorJS.pm: Always generate a prototype object, regardless of whether the object has any functions or constants.


Use the type of generator attributes to determine what constructor to use. This is useful for
the XMLDocument property in DOMWindow.idl, since that's just an alias for the Document constructor.


  • dom/DocumentFragment.idl: Added.
  • html/HTMLDocument.idl: Added.
  • html/HTMLElement.idl: Added.


  • page/DOMWindow.idl: Add constructors for DocumentFragment, HTMLElement, HTMLDocument and XMLDocument. XMLDocument is just an alias for the Document constructor.


LayoutTests:

2006-05-11 Anders Carlsson <acarlsson@apple.com>

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=7838
Add support for mozilla-style node constructors as properties of the window object

  • fast/dom/prototype-chain-expected.txt: Update prototype chains.
  • fast/dom/global-constructors-expected.txt:
  • fast/dom/global-constructors.html: Test new constructor objects.
3:19 AM Changeset in webkit [14297] by hyatt
  • 16 edits in trunk/WebCore

Bug 8845. Define a TextRun (similar to the old WebCoreTextRun) and
make it the new API for Font and GraphicsContext when drawing/measuring
text.

Reviewed by andersca

  • platform/Font.cpp: (WebCore::m_finalRoundingWidth): (WebCore::WidthIterator::advance): (WebCore::WidthIterator::normalizeVoicingMarks): (WebCore::Font::width): (WebCore::Font::canUseGlyphCache): (WebCore::Font::drawSimpleText): (WebCore::Font::drawText): (WebCore::Font::floatWidth): (WebCore::Font::floatWidthForSimpleText):
  • platform/Font.h: (WebCore::TextRun::m_to): (WebCore::TextRun::operator[]): (WebCore::TextRun::data): (WebCore::TextRun::adjustFrom): (WebCore::TextRun::adjustTo): (WebCore::TextRun::characters): (WebCore::TextRun::length): (WebCore::TextRun::from): (WebCore::TextRun::to):
  • platform/GraphicsContext.cpp: (WebCore::GraphicsContext::drawText): (WebCore::GraphicsContext::drawHighlightForText):
  • platform/GraphicsContext.h:
  • platform/mac/FontMac.mm: (WebCore::addDirectionalOverride): (WebCore::overrideLayoutOperation): (WebCore::ATSULayoutParameters::initialize): (WebCore::Font::selectionRectForText): (WebCore::Font::drawComplexText): (WebCore::Font::drawHighlightForText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::checkSelectionPoint):
  • platform/win/FontWin.cpp: (WebCore::hackishExtentForString): (WebCore::Font::floatWidth): (WebCore::Font::drawText): (WebCore::Font::drawHighlightForText): (WebCore::Font::selectionRectForText): (WebCore::Font::checkSelectionPoint):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset):
  • rendering/RenderBlock.cpp: (WebCore::stripTrailingSpace):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::paint):
  • rendering/RenderText.cpp: (WebCore::RenderText::cacheWidths): (WebCore::RenderText::widthFromCache): (WebCore::RenderText::trimmedMinMaxWidth): (WebCore::RenderText::calcMinMaxWidth): (WebCore::RenderText::width):
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::calcMinMaxWidth):
  • rendering/bidi.cpp: (WebCore::RenderBlock::tabWidth): (WebCore::RenderBlock::checkLinesForTextOverflow):
  • rendering/render_line.cpp: (WebCore::EllipsisBox::paint):
  • rendering/render_list.cpp: (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::calcMinMaxWidth): (WebCore::RenderListMarker::getRelativeMarkerRect):
Note: See TracTimeline for information about the timeline view.