Timeline


and

07/29/06:

21:31 Changeset [15699] by eseidel

2006-07-30 Eric Seidel <eric@eseidel.com>

Reviewed by gramps!

Remove some unused SVG code.

  • ksvg2/ecma/Ecma.cpp: Removed.
  • ksvg2/ecma/Ecma.h: Removed.
  • ksvg2/ecma/GlobalObject.cpp: remove a couple dead functions.
  • ksvg2/ecma/GlobalObject.h: add a comment about this dead code.
  • ksvg2/ecma/SVGLookup.h: Removed.
17:04 Changeset [15698] by darin

JavaScriptCore:

  • Removed tabs from these source files that still had them. We don't use them; that way source files look fine in editors that have tabs set to 8 spaces or to 4 spaces.
  • Removed allow-tabs Subversion property from the files too.
  • bindings/NP_jsobject.cpp:
  • bindings/c/c_utility.cpp:
  • bindings/jni/jni_runtime.cpp:
  • bindings/jni/jni_utility.cpp:
  • bindings/objc/objc_utility.mm:
  • bindings/runtime.cpp:
  • bindings/runtime_method.cpp:
  • bindings/testbindings.cpp:
  • bindings/testbindings.mm:
  • kjs/date_object.cpp:
  • kjs/function.cpp:
  • kjs/list.cpp:
  • kjs/nodes.cpp:
  • kjs/nodes.h:
  • kjs/string_object.cpp:
  • kjs/ustring.cpp:

WebCore:

  • Removed tabs from these source files that still had them. We don't use them; that way source files look fine in editors that have tabs set to 8 spaces or to 4 spaces.
  • Removed allow-tabs Subversion property from the files too.
  • bindings/objc/WebScriptObject.h:
  • bindings/objc/WebScriptObject.mm:
  • platform/FontData.cpp:

WebKit:

  • Removed tabs from these source files that still had them. We don't use them; that way source files look fine in editors that have tabs set to 8 spaces or to 4 spaces.
  • Removed allow-tabs Subversion property from the files too.
  • DefaultDelegates/WebDefaultPolicyDelegate.m:
  • History/WebHistory.m:
  • Misc/WebDownload.m:
  • Misc/WebIconDatabase.m:
  • Misc/WebKitErrors.m:
  • Misc/WebKitLogging.m:
  • Misc/WebNSDataExtras.m:
  • Misc/WebNSFileManagerExtras.m:
  • Panels/WebPanelAuthenticationHandler.m:
  • Plugins/WebBaseNetscapePluginView.m:
  • Plugins/npfunctions.h:
  • WebCoreSupport/WebSubresourceLoader.m:
  • WebView/WebMainResourceLoader.m:
  • WebView/WebView.h:
  • WebView/WebView.m:
16:41 Changeset [15697] by darin
  • tests/mozilla/expected.html: Update test results now that regress-185165.js is succeeding. I suspect Anders fix for bug 4620655 is the reason.
16:15 Changeset [15696] by weinig

JavaScriptCore:

Reviewed by Darin.

Changes include:

  • Removing trailing semicolon from namespace braces.
  • Removing trailing comma from last enum declaration.
  • Updating to match style guidelines.
  • Adding missing newline to the end of the file.
  • Turning on gcc warning for missing newline at the end of a source file (GCC_WARN_ABOUT_MISSING_NEWLINE in Xcode, -Wnewline in gcc).
  • Alphabetical sorting of Xcode source list files.
  • Replace use of non-portable variable-size array with Vector.
  • Use C-style comments instead of C++ comments in files that might be included by either C or C++ files.
  • API/JSCallbackConstructor.cpp: (KJS::JSCallbackConstructor::construct):
  • API/JSCallbackFunction.cpp: (KJS::JSCallbackFunction::callAsFunction):
  • API/JSCallbackObject.cpp: (KJS::JSCallbackObject::construct): (KJS::JSCallbackObject::callAsFunction):
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCorePrefix.h:
  • bindings/jni/jni_class.cpp: (JavaClass::fieldNamed):
  • bindings/jni/jni_class.h:
  • bindings/jni/jni_instance.cpp: (JavaInstance::JavaInstance): (JavaInstance::valueOf):
  • bindings/jni/jni_objc.mm: (KJS::Bindings::dispatchJNICall):
  • bindings/jni/jni_runtime.cpp: (JavaParameter::JavaParameter): (JavaArray::JavaArray):
  • bindings/jni/jni_runtime.h:
  • bindings/jni/jni_utility.h:
  • bindings/objc/objc_instance.h:
  • bindings/runtime_array.h:
  • kjs/collector.h:
  • kjs/config.h:
  • kjs/ustring.cpp:
  • wtf/Platform.h:

JavaScriptGlue:

Reviewed by Darin.

Changes include:

  • Turning on gcc warning for missing newline at the end of a source file (GCC_WARN_ABOUT_MISSING_NEWLINE in Xcode, -Wnewline in gcc).
  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Reviewed by Darin.

Changes include:

  • Removing trailing semicolon from namespace braces.
  • Removing trailing comma from last enum declaration.
  • Updating to match style guidelines.
  • Adding missing newline to the end of the file.
  • Turning on gcc warning for missing newline at the end of a source file (GCC_WARN_ABOUT_MISSING_NEWLINE in Xcode, -Wnewline in gcc).
  • Alphabetical sorting of Xcode source list files.
  • Use abs() function from <math.h> instead of ABS() macro.
  • Use C-style comments instead of C++ comments in files that might be included by either C or C++ files.
  • Use -numeric_limits<double>::infinity() instead of -HUGE_VAL.
  • WebCore+SVG/DOMList.h:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCorePrefix.h:
  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  • bindings/js/JSXSLTProcessor.h:
  • bindings/js/kjs_domnode.h: (KJS::DOMNode::):
  • bindings/objc/DOMCSS.h: (-[DOMCSSValue enum]):
  • bindings/objc/DOMCore.h: (-[DOMImplementation createDocument:::]):
  • bindings/objc/DOMEvents.h: (-[DOMOverflowEvent enum]):
  • bindings/objc/DOMRange.h:
  • bindings/objc/DOMTraversal.h:
  • bindings/objc/DOMXPath.h: (-[DOMXPathNSResolver lookupNamespaceURI:]):
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreKeyboardAccess.h:
  • css/makeprop:
  • css/makevalues:
  • dom/ChildNodeList.h:
  • dom/DocPtr.h:
  • dom/Document.h: (WebCore::Document::):
  • dom/DocumentMarker.h: (WebCore::DocumentMarker::): (WebCore::DocumentMarker::operator==): (WebCore::DocumentMarker::operator!=):
  • dom/EventTargetNode.h:
  • dom/KeyboardEvent.h: (WebCore::KeyboardEvent::):
  • dom/NameNodeList.h: (WebCore::NameNodeList::rootNodeChildrenChanged):
  • dom/QualifiedName.cpp:
  • editing/TypingCommand.h: (WebCore::TypingCommand::):
  • editing/UnlinkCommand.h: (WebCore::UnlinkCommand::editingAction):
  • html/FormDataList.h: (WebCore::FormDataListItem::FormDataListItem): (WebCore::FormDataList::appendData):
  • html/HTMLBlockquoteElement.h:
  • html/HTMLDivElement.h:
  • html/HTMLFormElement.h:
  • html/HTMLHRElement.h:
  • html/HTMLHeadingElement.h:
  • html/HTMLMarqueeElement.h:
  • html/HTMLParagraphElement.h:
  • html/HTMLPlugInElement.h:
  • html/HTMLPreElement.h:
  • html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::State::):
  • icon/IconDatabase.cpp:
  • icon/SQLStatement.cpp:
  • kcanvas/KCanvasFilters.h: (WebCore::): (WebCore::KCanvasPoint3F::KCanvasPoint3F): (WebCore::KCanvasFilter::KCanvasFilter): (WebCore::KCanvasFilter::~KCanvasFilter): (WebCore::KCanvasFilterEffect::~KCanvasFilterEffect): (WebCore::KCComponentTransferFunction::KCComponentTransferFunction): (WebCore::KCanvasFEConvolveMatrix::KCanvasFEConvolveMatrix): (WebCore::KCLightSource::KCLightSource): (WebCore::KCDistantLightSource::KCDistantLightSource): (WebCore::KCPointLightSource::KCPointLightSource): (WebCore::KCSpotLightSource::KCSpotLightSource): (WebCore::KCanvasFEDiffuseLighting::KCanvasFEDiffuseLighting): (WebCore::KCanvasFEDisplacementMap::KCanvasFEDisplacementMap): (WebCore::KCanvasFEImage::KCanvasFEImage): (WebCore::KCanvasFESpecularLighting::KCanvasFESpecularLighting):
  • kcanvas/RenderSVGImage.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.h:
  • ksvg2/css/SVGRenderStyle.h: (WebCore::SVGRenderStyle::InheritedFlags::): (WebCore::SVGRenderStyle::NonInheritedFlags::):
  • ksvg2/css/SVGRenderStyleDefs.h: (WebCore::):
  • ksvg2/events/SVGZoomEvent.h:
  • ksvg2/ksvg.h: (WebCore::):
  • ksvg2/misc/KCanvasRenderingStyle.h:
  • ksvg2/misc/SVGImageLoader.h:
  • ksvg2/scripts/make_names.pl:
  • ksvg2/svg/SVGAElement.h:
  • ksvg2/svg/SVGAngle.h:
  • ksvg2/svg/SVGAnimateColorElement.h:
  • ksvg2/svg/SVGAnimateElement.h:
  • ksvg2/svg/SVGAnimateTransformElement.h:
  • ksvg2/svg/SVGAnimatedAngle.h:
  • ksvg2/svg/SVGAnimatedBoolean.h:
  • ksvg2/svg/SVGAnimatedColor.h:
  • ksvg2/svg/SVGAnimatedEnumeration.h:
  • ksvg2/svg/SVGAnimatedInteger.h:
  • ksvg2/svg/SVGAnimatedLength.h:
  • ksvg2/svg/SVGAnimatedLengthList.h:
  • ksvg2/svg/SVGAnimatedNumber.h:
  • ksvg2/svg/SVGAnimatedNumberList.h:
  • ksvg2/svg/SVGAnimatedPathData.h:
  • ksvg2/svg/SVGAnimatedPoints.h:
  • ksvg2/svg/SVGAnimatedPreserveAspectRatio.h:
  • ksvg2/svg/SVGAnimatedRect.h:
  • ksvg2/svg/SVGAnimatedString.h:
  • ksvg2/svg/SVGAnimatedTemplate.h:
  • ksvg2/svg/SVGAnimatedTransformList.h:
  • ksvg2/svg/SVGAnimationElement.cpp: (SVGAnimationElement::calculateCurrentValueItem): (SVGAnimationElement::calculateRelativeTimePercentage):
  • ksvg2/svg/SVGAnimationElement.h: (WebCore::):
  • ksvg2/svg/SVGCircleElement.h:
  • ksvg2/svg/SVGClipPathElement.h:
  • ksvg2/svg/SVGColor.h:
  • ksvg2/svg/SVGComponentTransferFunctionElement.h:
  • ksvg2/svg/SVGCursorElement.h:
  • ksvg2/svg/SVGDOMImplementation.h:
  • ksvg2/svg/SVGDefsElement.h:
  • ksvg2/svg/SVGDescElement.h:
  • ksvg2/svg/SVGDocument.h:
  • ksvg2/svg/SVGElement.h: (WebCore::SVGElement::rendererIsNeeded): (WebCore::svg_dynamic_cast):
  • ksvg2/svg/SVGElementInstance.h:
  • ksvg2/svg/SVGElementInstanceList.h:
  • ksvg2/svg/SVGEllipseElement.h:
  • ksvg2/svg/SVGExternalResourcesRequired.h:
  • ksvg2/svg/SVGFEBlendElement.h:
  • ksvg2/svg/SVGFEColorMatrixElement.h:
  • ksvg2/svg/SVGFEComponentTransferElement.h:
  • ksvg2/svg/SVGFECompositeElement.h:
  • ksvg2/svg/SVGFEDiffuseLightingElement.h:
  • ksvg2/svg/SVGFEDisplacementMapElement.h:
  • ksvg2/svg/SVGFEDistantLightElement.h:
  • ksvg2/svg/SVGFEFloodElement.h:
  • ksvg2/svg/SVGFEFuncAElement.h:
  • ksvg2/svg/SVGFEFuncBElement.h:
  • ksvg2/svg/SVGFEFuncGElement.h:
  • ksvg2/svg/SVGFEFuncRElement.h:
  • ksvg2/svg/SVGFEGaussianBlurElement.h:
  • ksvg2/svg/SVGFEImageElement.h:
  • ksvg2/svg/SVGFELightElement.h:
  • ksvg2/svg/SVGFEMergeElement.h:
  • ksvg2/svg/SVGFEMergeNodeElement.h:
  • ksvg2/svg/SVGFEOffsetElement.h:
  • ksvg2/svg/SVGFEPointLightElement.h:
  • ksvg2/svg/SVGFESpecularLightingElement.h:
  • ksvg2/svg/SVGFESpotLightElement.h:
  • ksvg2/svg/SVGFETileElement.h:
  • ksvg2/svg/SVGFETurbulenceElement.h:
  • ksvg2/svg/SVGFilterElement.h:
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
  • ksvg2/svg/SVGFitToViewBox.h:
  • ksvg2/svg/SVGForeignObjectElement.cpp:
  • ksvg2/svg/SVGForeignObjectElement.h:
  • ksvg2/svg/SVGGElement.h:
  • ksvg2/svg/SVGGradientElement.h:
  • ksvg2/svg/SVGHelper.h: (WebCore::):
  • ksvg2/svg/SVGImageElement.h:
  • ksvg2/svg/SVGLangSpace.h:
  • ksvg2/svg/SVGLength.h:
  • ksvg2/svg/SVGLengthList.h:
  • ksvg2/svg/SVGLineElement.h:
  • ksvg2/svg/SVGLinearGradientElement.h:
  • ksvg2/svg/SVGList.h:
  • ksvg2/svg/SVGLocatable.h:
  • ksvg2/svg/SVGMarkerElement.h:
  • ksvg2/svg/SVGMaskElement.h:
  • ksvg2/svg/SVGMatrix.h:
  • ksvg2/svg/SVGNumber.h:
  • ksvg2/svg/SVGNumberList.h:
  • ksvg2/svg/SVGPaint.h:
  • ksvg2/svg/SVGPathElement.h:
  • ksvg2/svg/SVGPathSeg.h:
  • ksvg2/svg/SVGPathSegArc.h:
  • ksvg2/svg/SVGPathSegClosePath.h:
  • ksvg2/svg/SVGPathSegCurvetoCubic.h:
  • ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
  • ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
  • ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
  • ksvg2/svg/SVGPathSegLineto.h:
  • ksvg2/svg/SVGPathSegLinetoHorizontal.h:
  • ksvg2/svg/SVGPathSegLinetoVertical.h:
  • ksvg2/svg/SVGPathSegList.h:
  • ksvg2/svg/SVGPathSegMoveto.h:
  • ksvg2/svg/SVGPatternElement.h:
  • ksvg2/svg/SVGPoint.h:
  • ksvg2/svg/SVGPointList.h:
  • ksvg2/svg/SVGPolyElement.h:
  • ksvg2/svg/SVGPolygonElement.h:
  • ksvg2/svg/SVGPolylineElement.h:
  • ksvg2/svg/SVGPreserveAspectRatio.h:
  • ksvg2/svg/SVGRadialGradientElement.h:
  • ksvg2/svg/SVGRect.h:
  • ksvg2/svg/SVGRectElement.h:
  • ksvg2/svg/SVGSVGElement.h:
  • ksvg2/svg/SVGScriptElement.h:
  • ksvg2/svg/SVGSetElement.h:
  • ksvg2/svg/SVGStopElement.h:
  • ksvg2/svg/SVGStringList.h:
  • ksvg2/svg/SVGStylable.h:
  • ksvg2/svg/SVGStyleElement.h:
  • ksvg2/svg/SVGStyledElement.h: (WebCore::SVGStyledElement::rendererIsNeeded): (WebCore::SVGStyledElement::canvasResource):
  • ksvg2/svg/SVGStyledLocatableElement.h:
  • ksvg2/svg/SVGStyledTransformableElement.h:
  • ksvg2/svg/SVGSwitchElement.h:
  • ksvg2/svg/SVGSymbolElement.h:
  • ksvg2/svg/SVGTRefElement.h:
  • ksvg2/svg/SVGTSpanElement.h:
  • ksvg2/svg/SVGTests.h:
  • ksvg2/svg/SVGTextContentElement.h:
  • ksvg2/svg/SVGTextElement.h:
  • ksvg2/svg/SVGTextPositioningElement.h:
  • ksvg2/svg/SVGTitleElement.h:
  • ksvg2/svg/SVGTransform.h:
  • ksvg2/svg/SVGTransformList.h:
  • ksvg2/svg/SVGTransformable.h:
  • ksvg2/svg/SVGURIReference.h:
  • ksvg2/svg/SVGUseElement.h:
  • ksvg2/svg/SVGViewElement.h:
  • ksvg2/svg/SVGZoomAndPan.h:
  • ksvg2/svg/svgpathparser.h:
  • page/Frame.h: (WebCore::):
  • platform/AffineTransform.h:
  • platform/FontCache.cpp: (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
  • platform/FontData.cpp: (WebCore::FontData::FontData):
  • platform/FontData.h:
  • platform/TextBox.h: (WebCore::TextBox::):
  • platform/Timer.cpp: (WebCore::TimerBase::heapPop):
  • platform/mac/FontCacheMac.mm:
  • platform/mac/GlyphMapMac.cpp:
  • platform/mac/WebFontCache.mm: (betterChoice):
  • rendering/DeprecatedRenderSelect.cpp: (WebCore::DeprecatedRenderSelect::setWidgetWritingDirection):
  • rendering/EllipsisBox.h:
  • rendering/RenderBR.h: (WebCore::RenderBR::renderName): (WebCore::RenderBR::width):
  • rendering/RenderBlock.h: (WebCore::):
  • rendering/RenderFlexibleBox.h:
  • rendering/RenderFlow.h: (WebCore::RenderFlow::RenderFlow):
  • rendering/RenderFrame.cpp:
  • rendering/bidi.h:
  • rendering/break_lines.cpp:

WebKit:

Reviewed by Darin.

Changes include:

  • Adding missing newline to the end of the file.
  • Turning on gcc warning for missing newline at the end of a source file (GCC_WARN_ABOUT_MISSING_NEWLINE in Xcode, -Wnewline in gcc).
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebResourcePrivate.h:
16:09 Changeset [15695] by darin

Clear stray executable bits.

15:50 Changeset [15694] by darin

Clear some stray executable bits.

14:05 Changeset [15693] by rwlbuis

Remove the output produced by an alert, so
hopefully buildbot will not complain anymore :)

13:25 Changeset [15692] by rwlbuis

Reviewed by Geoff.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10151
ghostmap XHTML + SVG fails due to javascript undefined exception

Make sure document.URL works when called from a non-HTML document.

08:44 Changeset [15691] by darin

JavaScriptCore:

Reviewed by Darin.

  • fixes for Linux build
  • JavaScriptCoreSources.bkl: Added new files to build, kjs/PropertyNameArray.cpp and kjs/testkjs.cpp, and removed old files.

WebCore:

Reviewed and tweaked by Darin.

  • fixes for Linux build (still might not compile, since Darin tweaked but was unable to test).
  • WebCoreSources.bkl: Added some new sources, removed some obsolete ones.
  • Projects/gdk/webcore-gdk.bkl: Added RenderPopupMenuGdk.cpp
  • html/HTMLPlugInElement.h: Removed incorrect syntax with class name before ::.
  • platform/gdk/FrameGdk.h:
  • platform/gdk/FrameGdk.cpp: Updated parameters of constructor. Moved a couple stubs out of this file.
  • platform/gdk/RenderPopupMenuGdk.h: Added.
  • platform/gdk/RenderPopupMenuGdk.cpp: Added. Just a file full of empty stubs.
  • platform/gdk/RenderThemeGdk.h:
  • platform/gdk/RenderThemeGdk.cpp: (WebCore::RenderThemeGdk::createPopupMenu): Added.
  • platform/gdk/TemporaryLinkStubs.cpp: Add some new stubs.

WebKitTools:

Reviewed by Darin.

  • fixes for Linux build
  • GdkLauncher/mk: Added call to bakefile_gen before calling make.
  • GdkLauncher/gdklauncher.bkl: Tweak comment.
08:43 Changeset [15690] by darin
  • changed this test to a plain-text one and added text explaining what it tests
  • fast/forms/input-named-action-overrides-action-attribute.html: Added explanation text, got rid of some incorrect HTML syntax, added a call to dumpAsText(), and used a paragraph element instead of a span element for the result.
  • fast/forms/input-named-action-overrides-action-attribute-expected.txt: Updated.
08:21 Changeset [15689] by darin

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10022
Bug 10022: REGRESSION: Crash in WebCore::XMLTokenizer::characters

  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::resumeParsing): If the write() call resulted in new callbacks being added, don't call through to end() just yet.
08:19 Changeset [15688] by darin

WebCore:

Reviewed by John Sullivan.

  • manual-tests/subview-click-assertion.html: Added.

WebKit:

Reviewed by John Sullivan.

  • WebView/WebHTMLView.m: (-[WebHTMLView _setMouseDownEvent:]): Moved into the WebHTMLViewFileInternal category and changed to accept nil. (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): Copy the hit HTMLView's mouse down event to the top HTMLView. (-[WebHTMLView acceptsFirstMouse:]): Added a call to _setMouseDownEvent:nil before returning. (-[WebHTMLView shouldDelayWindowOrderingForEvent:]): Added a call to _setMouseDownEvent:nil before returning. (-[WebHTMLView mouseUp:]): Added a call to _setMouseDownEvent:nil to clear the event set in mouseDown: (and used during dragging). (-[WebHTMLView _delegateDragSourceActionMask]): Copy the hit HTMLView's mouse down event to the top HTMLView.
08:06 Changeset [15687] by darin

LayoutTests:

Reviewed by Darin.

Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8587 / <rdar://problem/4631844>
REGRESSION: {display:list-item} items outside an ol or ul element don't number correctly

  • fast/lists/ordered-list-with-no-ol-tag-expected.checksum: Added.
  • fast/lists/ordered-list-with-no-ol-tag-expected.png: Added.
  • fast/lists/ordered-list-with-no-ol-tag-expected.txt: Added.
  • fast/lists/ordered-list-with-no-ol-tag.html: Added.

WebCore:

Reviewed by Darin.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8587 / <rdar://problem/4631844>
REGRESSION: {display:list-item} items outside an ol or ul element don't number correctly

  • rendering/RenderListItem.cpp: (WebCore::enclosingList): If no real list element is found, use parent instead. (WebCore::previousListItem): Check list elements to see if they are list items -- the old code assumed that a list would never be a list item but this is entirely possible with CSS and especially with the new rule that means any DOM element could act as a list.
07:56 Changeset [15686] by ap

Reviewed by Darin.

Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10147
REGRESSION: custom attribute values set via javascript are not persistent

Test: fast/dom/Element/setAttribute-case-insensitivity.html

  • dom/Element.cpp: (WebCore::Element::setAttribute): Use the lowercased localName for retrieving the old value, too.
07:53 Changeset [15685] by darin
  • rolled out the test for bug 9753, since we rolled out the fix we'll bring back the test when we bring back the fix
  • svg/custom/width-full-percentage-expected.checksum: Removed.
  • svg/custom/width-full-percentage-expected.png: Removed.
  • svg/custom/width-full-percentage-expected.txt: Removed.
  • svg/custom/width-full-percentage.svg: Removed.

07/28/06:

17:25 Changeset [15684] by thatcher

Suggested by Darin.

Moving the implementation of isContentEditable to the
the WebPrivate category.

  • bindings/objc/DOM.mm: (-[DOMNode isContentEditable]):
17:24 Changeset [15683] by justing

LayoutTests:

Reviewed by levi


<rdar://problem/4515463>
REGRESSION: Blot and Mail both do a very poor job of pasting the main www.apple.com page


Removed incorrect nesting:

  • editing/pasteboard/paste-table-001-expected.checksum:
  • editing/pasteboard/paste-table-001-expected.png:
  • editing/pasteboard/paste-table-001-expected.txt:
  • editing/pasteboard/paste-table-003-expected.txt:

WebCore:

Reviewed by levi


First part of:
<rdar://problem/4515463>
REGRESSION: Blot and Mail both do a very poor job of pasting the main www.apple.com page


Migrate to isBlock and enclosingBlock.
Changed RendereringInfo::isBlock and ReplacementFragment::isBlock
to wasBlock so that they don't conflict with isBlock and because
it's more descriptive.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::mergeStartNode): (WebCore::ReplacementFragment::wasBlock): (WebCore::ReplacementFragment::saveRenderingInfo): (WebCore::ReplacementFragment::renderedBlocks): (WebCore::RenderingInfo::RenderingInfo): (WebCore::ReplaceSelectionCommand::shouldMergeStart): (WebCore::ReplaceSelectionCommand::doApply):
  • editing/ReplaceSelectionCommand.h: (WebCore::RenderingInfo::wasBlock):
17:05 Changeset [15682] by thatcher

New tag.

17:02 Changeset [15681] by thatcher

Versioning

16:58 Changeset [15680] by wsanchez

revert 15679

16:58 Changeset [15679] by wsanchez

test

16:51 Changeset [15678] by thatcher

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-28 Timothy Hatcher <timothy@apple.com>

Reviewed by John.

The context menu code should be checking isContentEditable
on DOMNode not just DOMElement. This is needed because DOMText
will be the node class of any text that is clicked.

  • DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]):
16:50 Changeset [15677] by thatcher

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-28 Timothy Hatcher <timothy@apple.com>

Reviewed by John.

Adding isContentEditable to DOMNode's private category.

  • bindings/objc/DOMPrivate.h:
16:29 Changeset [15676] by bdakin

Rubber stamped by Maciej.

Fix for <rdar://problem/4541255> Safari hangs at http://
www.kutilek.de/safari-test/ somewhere from
WebCore::RenderBlock::layoutInlineChildren(bool)

This is the same fix that Maciej and I did a week ago for 4529398.
Rolling it onto the branch because it fixes this crash too!

  • WebCore.xcodeproj/project.pbxproj: Project file wars.
  • khtml/rendering/render_list.cpp: (ListMarkerBox::detach): Remove from parent when detaching. (ListMarkerBox::operator delete):
  • khtml/rendering/render_list.h:
15:33 Changeset [15675] by spadma

2006-07-28 ligman <joseph.ligman@nokia.com>

Reviewed by Sachin.

  • BrowserView/inc/SmartLinkMap.h:
  • BrowserView/src/SmartLinkMap.cpp:
15:10 Changeset [15674] by spadma

2006-07-28 ligman <joseph.ligman@nokia.com>

Reviewed by Sachin.

  • BrowserView/inc/SmartLinkMap.h:
  • BrowserView/src/SmartLinkMap.cpp: (CSmartLinkMap::InsertLink): (CSmartLinkMap::IndexingCallbackL): (CSmartLinkMap::~CSmartLinkMap): (CSmartLinkMap::StartIndexingSmartLinks): (CSmartLinkMap::StopIndexingSmartLinks): (CSmartLinkMap::ReIndexSmartLinks):
  • BrowserView/src/WebKitView.cpp: (CWebKitView::FindNextSmartLink):


Fix scrolling of smart links in manual find. Remove the duplicate smart links from the map

15:01 Changeset [15673] by justing

LayoutTests:

Reviewed by levi


<rdar://problem/4242293>
Poor paste fidelity of http://www.google.com/

Removed one of the two extraneous newlines that are introduced on paste:

  • editing/pasteboard/paste-table-003-expected.checksum:
  • editing/pasteboard/paste-table-003-expected.png:
  • editing/pasteboard/paste-table-003-expected.txt:


Fewer pastes remove nodes containing the selection b/c of
the changes to interchange newlines:

  • editing/pasteboard/paste-line-endings-007-expected.txt:
  • editing/pasteboard/paste-line-endings-008-expected.txt:
  • editing/pasteboard/paste-line-endings-009-expected.txt:


Added:

  • editing/pasteboard/4242293-1-expected.checksum: Added.
  • editing/pasteboard/4242293-1-expected.png: Added.
  • editing/pasteboard/4242293-1-expected.txt: Added.
  • editing/pasteboard/4242293-1.html: Added.
  • editing/pasteboard/4242293-expected.checksum: Added.
  • editing/pasteboard/4242293-expected.png: Added.
  • editing/pasteboard/4242293-expected.txt: Added.
  • editing/pasteboard/4242293.html: Added.

WebCore:

Reviewed by levi


More changes for:
<rdar://problem/4242293>
Poor paste fidelity of http://www.google.com/

  • editing/markup.cpp: (WebCore::needInterchangeNewlineAfter): Added. (WebCore::createMarkup): Only add an interchangeNewline if we're annotating for interchange. Can't test this until we expose createMarkup in non-annotate mode (I'd expose Range::toHTML). Remove the FIXME about prepending the interchangeNewline before creating the rest of the markup. Its correct to surround the interchangeNewline in ancestors of the adjusted startNode. Fixed the check to see if an interchangeNewline is needed (!inSameBlock). This would add an interchangeNewline for a selection that started before a table. Removed the workaround for the bug where markup for a table was not included when selecting the contents of a table, since this change fixes the general problem of markup for ancestors of the startNode being left out. Don't leave out ancestors of the startNode as we leave their subtrees. Execute the code to include them even if we closed ancestors in the ancestorsToClose list.
13:06 Changeset [15672] by spadma

2006-07-28 sareen <shyam.sareen@nokia.com>

Reviewed by Sachin

  • group/EABI/browserengineU.def: Bugzilla ID 10109: BC break in Browser Control API due to the def file

incompatibility with the old version.

12:59 Changeset [15671] by thatcher

Reviewed by John.

<rdar://problem/4657473> REGRESSION: Spell check not available from contextual menu in Mail

The context menu code should be checking isContentEditable
on DOMNode not just DOMElement. This is needed because DOMText
will be the node class of any text that is clicked.

  • DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]):
12:58 Changeset [15670] by thatcher

WebCore:

Reviewed by John.

Adding isContentEditable to DOMNode's private category.

  • bindings/objc/DOMPrivate.h:

WebKit:

Reviewed by John.

The context menu code should be checking isContentEditable
on DOMNode not just DOMElement. This is needed because DOMText
will be the node class of any text that is clicked.

  • DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]):
12:19 Changeset [15669] by ap

Rolling out http://bugzilla.opendarwin.org/show_bug.cgi?id=6010 because of failing layout tests.

12:01 Changeset [15668] by adele

Rolling out http://bugzilla.opendarwin.org/show_bug.cgi?id=9753 because of failing layout tests.
SVG with width and height 100% leaves room for scrollbar on the right.

  • kcanvas/RenderPath.cpp:
  • kcanvas/RenderPath.h:
  • kcanvas/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout):
  • ksvg2/svg/SVGCircleElement.cpp:
  • ksvg2/svg/SVGCircleElement.h:
  • ksvg2/svg/SVGEllipseElement.cpp:
  • ksvg2/svg/SVGEllipseElement.h:
  • ksvg2/svg/SVGLineElement.cpp:
  • ksvg2/svg/SVGLineElement.h:
  • ksvg2/svg/SVGRectElement.cpp:
  • ksvg2/svg/SVGRectElement.h:
  • ksvg2/svg/SVGStyledElement.h:
11:07 Changeset [15667] by eseidel

2006-07-27 Eric Seidel <eric@eseidel.com>

Reviewed by darin.


Add better SVGLoad event support.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6010
There will still need to be additional support added for <link> and <script> elements.
Not all of the error -> loaded -> error transition cases work yet.

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchGenericEvent):
  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::dispatchLoadEvent):
  • html/HTMLImageLoader.h: (WebCore::HTMLImageLoader::haveFiredLoadEvent): (WebCore::HTMLImageLoader::setHaveFiredLoadEvent):
  • ksvg2/misc/SVGImageLoader.cpp: (WebCore::SVGImageLoader::SVGImageLoader): (WebCore::SVGImageLoader::dispatchLoadEvent):
  • ksvg2/misc/SVGImageLoader.h:
  • ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::parseMappedAttribute):
  • ksvg2/svg/SVGAnimatedBoolean.h:
  • ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::SVGElement): (WebCore::SVGElement::parseMappedAttribute): (WebCore::SVGElement::haveLoadedRequiredResources): (WebCore::SVGElement::sendSVGLoadEventIfPossible): (WebCore::SVGElement::closeRenderer):
  • ksvg2/svg/SVGElement.h: (WebCore::SVGElement::rendererIsNeeded): (WebCore::svg_dynamic_cast):
  • ksvg2/svg/SVGExternalResourcesRequired.h:
  • ksvg2/svg/SVGImageElement.cpp: (SVGImageElement::SVGImageElement): (SVGImageElement::haveLoadedRequiredResources):
  • ksvg2/svg/SVGImageElement.h:
  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::parseMappedAttribute):
  • ksvg2/svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::SVGScriptElement): (WebCore::SVGScriptElement::parseMappedAttribute): (WebCore::SVGScriptElement::executeScript):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener): use new Event() instead of createEvent

07/27/06:

22:13 Changeset [15666] by adele

Reviewed by Anders.

No test possible (no functionality change)

  • rendering/RenderBox.cpp: (WebCore::RenderBox::position):
  • rendering/RenderBox.h:
  • rendering/RenderObject.h: (WebCore::RenderObject::position):
  • rendering/RenderTableRow.h: (WebCore::RenderTableRow::position):
  • rendering/RenderTableSection.h: (WebCore::RenderTableSection::position):
  • rendering/RenderText.cpp: (WebCore::RenderText::position):
  • rendering/RenderText.h:
  • rendering/bidi.cpp: (WebCore::RenderBlock::constructLine): (WebCore::RenderBlock::computeVerticalPositionsForLine):
21:53 Changeset [15665] by adele

LayoutTests:

Reviewed by Maciej.

Test case for
<http://bugzilla.opendarwin.org/show_bug.cgi?id=9753>
SVG with width and height 100% leaves room for scrollbar on the right.

  • svg/custom/width-full-percentage-expected.txt: Added.
  • svg/custom/width-full-percentage-expected.checksum: Added.
  • svg/custom/width-full-percentage-expected.png: Added.
  • svg/custom/width-full-percentage.svg: Added.

WebCore:

Reviewed by Maciej.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9753
SVG with width and height 100% leaves room for scrollbar on the right.

Relayout children of svg containers, except svg shapes that do not depend on percentages.

  • kcanvas/RenderPath.cpp: (WebCore::RenderPath::hasPercentageValues):
  • kcanvas/RenderPath.h:
  • kcanvas/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout):
  • ksvg2/svg/SVGCircleElement.cpp: (SVGCircleElement::hasPercentageValues):
  • ksvg2/svg/SVGCircleElement.h:
  • ksvg2/svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::hasPercentageValues):
  • ksvg2/svg/SVGEllipseElement.h:
  • ksvg2/svg/SVGLineElement.cpp: (SVGLineElement::hasPercentageValues):
  • ksvg2/svg/SVGLineElement.h:
  • ksvg2/svg/SVGRectElement.cpp: (WebCore::SVGRectElement::hasPercentageValues):
  • ksvg2/svg/SVGRectElement.h:
  • ksvg2/svg/SVGStyledElement.h: (WebCore::SVGStyledElement::hasPercentageValues):
18:07 Changeset [15664] by thatcher

Versioning

18:03 Changeset [15663] by thatcher

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-26 Justin Garcia <justin.garcia@apple.com>

Reviewed by darin


<rdar://problem/4652788>
REGRESSION: Can't change size or style of any text in message body

  • dom/Node.cpp: (WebCore::Node::isContentRichlyEditable): Mimic Node::isContentEditable.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::isContentRichlyEditable): First check the frame for editability, then userModify, like what HTMLElement::isContentEditable() does.
  • html/HTMLElement.h:
18:02 Changeset [15662] by thatcher

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-26 Justin Garcia <justin.garcia@apple.com>

Reviewed by darin


<rdar://problem/4652788>
REGRESSION: Can't change size or style of any text in message body

  • dom/Node.cpp: (WebCore::Node::isContentRichlyEditable): Mimic Node::isContentEditable.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::isContentRichlyEditable): First check the frame for editability, then userModify, like what HTMLElement::isContentEditable() does.
  • html/HTMLElement.h:
17:47 Changeset [15661] by thatcher

New tag.

17:45 Changeset [15660] by thatcher

Versioning

17:40 Changeset [15659] by thatcher

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-26 Alice Liu <alice.liu@apple.com>

Reviewed by John Sullivan (and Kevin and Timo).

landing this patch for John et al.
Fixed <rdar://problem/4651380> REGRESSION (9A232->9A234): existing web clips don't render if you restart Dashboard

  • page/FrameView.cpp: (WebCore::FrameView::layout): moved the call to didFirstLayout to above the check for needsLayout because we need to call didFirstLayout for every webview, not just ones we think need layout.
17:38 Changeset [15658] by thatcher

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-25 Geoffrey Garen <ggaren@apple.com>

Reviewed by Maciej, inspired by John.


  • Fixed <rdar://problem/4651931> 1% REGRESSION on iBench HTML due to repeated requests for non-existent favicon


An optimization to avoid serializing favicon data for missing icons had stomped an
optimization to avoid GETing a missing favicon more than once. The solution
is a happy marriage of optimizations, ensuring that we *retain* the missing
favicon's "i am missing" data without posting a notification or saving it to disk.

  • Misc/WebIconDatabase.m: (-[WebIconDatabase _setIconURL:forURL:]):
17:36 Changeset [15657] by thatcher

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-25 Justin Garcia <justin.garcia@apple.com>

Reviewed by darin


<rdar://problem/4468458> Incoming HTML message is editable <body contenteditable="true">

  • dom/Document.cpp: (WebCore::Document::inDesignMode): Removed some spaces.
  • page/Frame.cpp: (WebCore::Frame::applyEditingStyleToElement): Just add CSS properties needed for editing. (WebCore::Frame::removeEditingStyleFromElement): Made this a no-op, we'll remove it eventually.
16:50 Changeset [15656] by justing

LayoutTests:

Reviewed by levi


<rdar://problem/4242293>
Poor paste fidelity of http://www.google.com/

  • editing/pasteboard/styled-element-markup-expected.checksum: Added.
  • editing/pasteboard/styled-element-markup-expected.png: Added.
  • editing/pasteboard/styled-element-markup-expected.txt: Added.
  • editing/pasteboard/styled-element-markup.html: Added.

WebCore:

Reviewed by levi


<rdar://problem/4242293>
Poor paste fidelity of http://www.google.com/

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle): Fixed crasher with nil-check.
  • editing/markup.cpp: (WebCore::startMarkup): Style information wasn't added to an element if it had attributes but no style attribute.
14:56 Changeset [15655] by spadma

2006-07-27 zhalu <Zhaosong.lu@nokia.com>

Reviewed by Sachin

  • BrowserCore/Formcontrols/src/FControlSelectSkin.cpp: (CFormSelectSkin::CalculateVisualClipTextL): Work around if Font returns zero for MaxNormalCharWidth


http://bugzilla.opendarwin.org/show_bug.cgi?id=10133

14:06 Changeset [15654] by lypanov

2006-07-27 Alexander Kellett <lypanov@kde.org>

Reviewed by Darin.

  • bindings/scripts/CodeGeneratorJS.pm: add new attribute - HasOverridingNameGetter
  • html/HTMLFormElement.idl:

2006-07-27 Alexander Kellett <lypanov@kde.org>

Reviewed by Darin.

Test for: http://bugzilla.opendarwin.org/show_bug.cgi?id=9867
REGRESSION: code that modifies form element in Firefox modifies form attribute in WebKit

  • fast/forms/input-named-action-overrides-action-attribute-expected.txt: Added.
  • fast/forms/input-named-action-overrides-action-attribute.html: Added.
13:18 Changeset [15653] by rwlbuis

Reviewed by Anders.

http://bugzilla.opendarwin.org/show_bug.cgi?id=8992
Some HTML DOM attributes have incorrect types

Adjust idl and dom source code for HTMLImageElement and
HTMLBaseFontElement to choose correct type for
HTMLImageElement::border and HTMLBaseFontElement::size
attributes.

13:01 Changeset [15652] by justing

LayoutTests:

Reviewed by levi


<rdar://problem/4628409>
Safari crashes in CompositeEditCommand::removeBlockPlaceholder entering text in a web page form

  • fast/forms/4628409-expected.txt: Added.
  • fast/forms/4628409.html: Added.

WebCore:

Reviewed by levi


<rdar://problem/4628409>
Safari crashes in CompositeEditCommand::removeBlockPlaceholder entering text in a web page form

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::removeBlockPlaceholder): A script on the page shrinks the textarea down to zero rows just before insertion. That gives the shadow div a zero height, removing [div, 0] as a candidate for a VisiblePosition. Then InsertTextCommand::input() tries to create a VisiblePosition from [div, 0] and fails. A nil check is a quick fix. Another might be to make positions where there is a caret selection candidates. Another might be to make any [div, 0] where div is a shadow div inside a form element a candidate.
11:58 Changeset [15651] by ap

Fix by Graham Dennis, reviewed by Darin.


Test: fast/encoding/denormalised-voiced-japanese-chars.html

  • platform/Font.cpp: (WebCore::WidthIterator::advance): pass currentCharacter to normalizeVoicingMarks (WebCore::WidthIterator::normalizeVoicingMarks): turn the currentCharacter variable into an argument as WidthIterator::advance doesn't update m_currentCharacter while looping
11:11 Changeset [15650] by thatcher

Versioning

11:09 Changeset [15649] by thatcher

Versioning

02:22 Changeset [15648] by eseidel

2006-07-27 Eric Seidel <eric@eseidel.com>

Reviewed by ap.

Complex entities seem to fail on TOT
http://bugzilla.opendarwin.org/show_bug.cgi?id=6390
Use an alternative work-around to an XML Entity parsing bug.

  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::write): (WebCore::hackAroundLibXMLEntityBug): added. (WebCore::startElementNsHandler): (WebCore::endElementNsHandler): (WebCore::charactersHandler): (WebCore::processingInstructionHandler): (WebCore::cdataBlockHandler): (WebCore::commentHandler): (WebCore::getEntityHandler):
00:46 Changeset [15647] by rwlbuis

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9938
Fix viewBox issues in Hixie's test

Do a more accurate and quicker job of parsing the viewBox
attribute. Handle properly on negative width/height and
invalid syntax in general.

  • ksvg2/svg/SVGFitToViewBox.cpp: (SVGFitToViewBox::parseViewBox):

07/26/06:

22:26 Changeset [15646] by eseidel

2006-07-27 Eric Seidel <eric@eseidel.com>

Reviewed by ap.

Enables getSVGDocument() support for HTMLObjectElement and HTMLEmbedElement
This patch does not try to autogenerate anything, but enables the SVG functionality.
Also fix HTMLObjectElement vspace and hspace to be numbers instead of strings to match IE & Firefox.

  • bindings/js/kjs_dom.cpp: (KJS::toJS):
  • bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::objectGetter): (KJS::HTMLElementFunction::callAsFunction): (KJS::JSHTMLElement::objectSetter):
  • bindings/js/kjs_html.h: (KJS::JSHTMLElement::):
  • dom/Document.h: (WebCore::Document::isSVGDocument):
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::contentDocument): (WebCore::HTMLEmbedElement::getSVGDocument):
  • html/HTMLEmbedElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::HTMLObjectElement): (WebCore::HTMLObjectElement::getInstance): (WebCore::HTMLObjectElement::parseMappedAttribute): (WebCore::HTMLObjectElement::contentDocument): (WebCore::HTMLObjectElement::rendererIsNeeded): (WebCore::HTMLObjectElement::createRenderer): (WebCore::HTMLObjectElement::setCode): (WebCore::HTMLObjectElement::setArchive): (WebCore::HTMLObjectElement::setBorder): (WebCore::HTMLObjectElement::setCodeBase): (WebCore::HTMLObjectElement::setCodeType): (WebCore::HTMLObjectElement::setData): (WebCore::HTMLObjectElement::hspace): (WebCore::HTMLObjectElement::setHspace): (WebCore::HTMLObjectElement::setStandby): (WebCore::HTMLObjectElement::setType): (WebCore::HTMLObjectElement::setUseMap): (WebCore::HTMLObjectElement::vspace): (WebCore::HTMLObjectElement::setVspace): (WebCore::HTMLObjectElement::getSVGDocument):
  • html/HTMLObjectElement.h:
  • ksvg2/svg/SVGDocument.h: (WebCore::SVGDocument::isSVGDocument):
  • rendering/RenderWidget.h: (WebCore::RenderWidget::frameView):
21:31 Changeset [15645] by ap

Reviewed by Darin.

Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9901
XSLTProcessor cannot parse text nodes for INPUT ELEMENTS in an XSLT stylesheet

Test: fast/js/xhtml-serialize.html

  • editing/markup.cpp: (WebCore::endMarkup): If the element has child nodes, write a closing tag even if it is not permitted in HTML, to make it valid XML.
18:43 Changeset [15644] by aliceli1

Reviewed by John Sullivan (and Kevin and Timo).

landing this patch for John et al.
Fixed <rdar://problem/4651380> REGRESSION (9A232->9A234): existing web clips don't render if you restart Dashboard

  • page/FrameView.cpp: (WebCore::FrameView::layout): moved the call to didFirstLayout to above the check for needsLayout because we need to call didFirstLayout for every webview, not just ones we think need layout.
17:42 Changeset [15643] by justing

LayoutTests:

Reviewed by darin


<rdar://problem/4652788>
REGRESSION: Can't change size or style of any text in message body

  • editing/style/designmode-expected.checksum: Added.
  • editing/style/designmode-expected.png: Added.
  • editing/style/designmode-expected.txt: Added.
  • editing/style/designmode.html: Added.

WebCore:

Reviewed by darin


<rdar://problem/4652788>
REGRESSION: Can't change size or style of any text in message body

  • dom/Node.cpp: (WebCore::Node::isContentRichlyEditable): Mimic Node::isContentEditable.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::isContentRichlyEditable): First check the frame for editability, then userModify, like what HTMLElement::isContentEditable() does.
  • html/HTMLElement.h:
17:26 Changeset [15642] by thatcher

New tag.

17:07 Changeset [15641] by thatcher

Versioning

16:22 Changeset [15640] by thatcher

WebCore:

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-25 David Harrison <harrison@apple.com>

Reviewed by timo and Darin.

<rdar://problem/4618584> "Paste and Match Style" is not working in Mail (add SPI)


  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): Add matchStyle parameter for use by WebKit.

WebKit:

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-25 David Harrison <harrison@apple.com>

Reviewed by timo and Darin.

<rdar://problem/4618584> "Paste and Match Style" is not working in Mail (add SPI)


  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebView.m: (-[WebView replaceSelectionWithNode:]): (-[WebView _replaceSelectionWithNode:matchStyle:]):
  • WebView/WebViewPrivate.h: (-[WebView _replaceSelectionWithNode:matchStyle::]): New SPI that is same as replaceSelectionWithNode: with added parameter whether to match existing style.
12:33 Changeset [15639] by ap

Fix by Mitz Pettel, reviewed by ap.

  • fix debug-only information() string for table cells
  • rendering/RenderObject.cpp: (WebCore::RenderObject::information):
11:31 Changeset [15638] by brmorris

2006-06-26 David Carson <david.carson@nokia.com>

Reviewed by Sachin & Zalan.


Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9073
Soft hyphens not breaking words


  • WebCore/WebCore/khtml/rendering/break_lines.cpp (isBreakable): Added check for soft hyphen character when determining where to break a word. Based on similar change made by Hyatt in Windows port of WebKit. Added copyright notice to the file, copied from same file in current Mac WebKit tree.


Testcases

  • LayoutTests/fast/js/global/encode-URI-test-mobile-expected.txt:
  • LayoutTests/fast/text/basic/014-mobile-expected.txt: Updated these results as the test now passes, and the results are different.
  • LayoutTests/fas/text/basic/013-mobile-expected.txt Added missing results file.
09:31 Changeset [15637] by brmorris

2006-07-26 David Carson <david.carson@nokia.com>


Implement location.assign.
Reviewed by Zalan.


Test cases added:

  • layout-tests/fast/js/location-assign.html: Added.
  • layout-tests/fast/js/location-assign-expected.txt: Added.
  • layout-tests/fast/js/resources/new-location.html: Added.
  • khtml/ecma/kjs_window.cpp: (Window::get): (Window::isSafeScript): (WindowFunc::tryCall): (ScheduledAction::execute): (Location::get): (LocationFunc::tryCall):
  • khtml/ecma/kjs_window.h: (KJS::Window::): (KJS::Location::):
  • khtml/ecma/kjs_window.lut.h: (KJS::): Implement location.assign.

07/25/06:

20:04 Changeset [15636] by ggaren

Reviewed by Maciej, inspired by John.


  • Fixed <rdar://problem/4651931> 1% REGRESSION on iBench HTML due to repeated requests for non-existent favicon


An optimization to avoid serializing favicon data for missing icons had stomped an
optimization to avoid GETing a missing favicon more than once. The solution
is a happy marriage of optimizations, ensuring that we *retain* the missing
favicon's "i am missing" data without posting a notification or saving it to disk.

  • Misc/WebIconDatabase.m: (-[WebIconDatabase _setIconURL:forURL:]):
19:23 Changeset [15635] by thatcher

New tag.

19:18 Changeset [15634] by thatcher

Versioning

17:30 Changeset [15633] by harrison

WebCore:

Reviewed by timo and Darin.

<rdar://problem/4618584> "Paste and Match Style" is not working in Mail (add SPI)


  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): Add matchStyle parameter for use by WebKit.

WebKit:

Reviewed by timo and Darin.

<rdar://problem/4618584> "Paste and Match Style" is not working in Mail (add SPI)


  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebView.m: (-[WebView replaceSelectionWithNode:]): (-[WebView _replaceSelectionWithNode:matchStyle:]):
  • WebView/WebViewPrivate.h: (-[WebView _replaceSelectionWithNode:matchStyle::]): New SPI that is same as replaceSelectionWithNode: with added parameter whether to match existing style.
17:27 Changeset [15632] by thatcher

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-24 Adele Peterson <adele@apple.com>

Reviewed by Justin.

  • Fix for <rdar://problem/4632132> Changing style of content with mixed editability fails

Test: * editing/style/apple-style-editable-mix.html

  • dom/Node.cpp: (WebCore::Node::isContentRichlyEditable): Doesn't need to check the editable root. It now just checks the user modify property of its own renderer, since that is inherited.
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle): If the end position is in a table, Adjust the end node to the last descendant of the table, so we don't skip over any runs.
17:23 Changeset [15631] by thatcher

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-24 Maciej Stachowiak <mjs@apple.com>

Reviewed by Geoff.


  • WebView/WebLoader.h:
  • WebView/WebMainResourceLoader.m: (-[WebMainResourceLoader receivedError:]): Copy in some code from the base class to do it in the proper order, surrounding the call to [ds _receivedMainResourceError:error complete:YES].
17:17 Changeset [15630] by thatcher

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-24 Timothy Hatcher <timothy@apple.com>

Reviewed by John and Darin.

<rdar://problem/4634290> Cannot selectively install a custom
scroller that differs from the default Aqua frame size.

Adds two new private methods to WebFrameView that allows
an application to set a custom scroll view class. This is needed
if the application wants to install a custom scroller that is wider
than the typical scroller, because NSScrollView does the content
rect calculations in a class method (ignoring custom scrollers.)
The _setScrollViewClass method requires the class to be a subclass
of WebDynamicScrollBarView, or nil can be passed to reset to the default class.
A new scroll view of the specified class will then replace the previous
one without the need to reload content of the frame.

  • WebView/WebFrameView.m: (-[WebFrameView _customScrollViewClass]): (-[WebFrameView _setCustomScrollViewClass:]):
  • WebView/WebFrameViewPrivate.h:
17:09 Changeset [15629] by thatcher

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-24 David Hyatt <hyatt@apple.com>

Two bug fixes.

(1) Make sure to mark positioned objects that depend on line position to
mark themselves as needing layout when their line box placeholder gets
repositioned.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::position):


(2) Improve highlighting to factor the inflation into overflow so that
invalidation and repainting will work properly.

  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::addHighlightOverflow):
  • rendering/RootInlineBox.h:
  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
17:06 Changeset [15628] by thatcher

Merging CCC approved change from TOT to Safari-521 branch.

2006-07-24 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adele.

<rdar://problem/4641824> REGRESSION: Wikipedia widget fails to complete a search after pressing return key


  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Don't eat enter events for search fields that have no enclosing form; they need to be passed to AppKit so that onsearch can be invoked.


  • manual-tests/onsearch-enter.html: Added.
16:13 Changeset [15627] by justing

LayoutTests:

Reviewed by adele


<rdar://problem/4649560>
REGRESSION: Can't Select All when the body is contentEditable="true"

  • editing/selection/select-all-005-expected.checksum: Added.
  • editing/selection/select-all-005-expected.png: Added.
  • editing/selection/select-all-005-expected.txt: Added.
  • editing/selection/select-all-005.html: Added.
  • editing/selection/select-all-006-expected.checksum: Added.
  • editing/selection/select-all-006-expected.png: Added.
  • editing/selection/select-all-006-expected.txt: Added.
  • editing/selection/select-all-006.html: Added.

WebCore:

Reviewed by adele


<rdar://problem/4649560>
REGRESSION: Can't Select All when the body is contentEditable="true"

  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::canonicalPosition): Allow descent from a non-editable html element into an editable body as a convenience.
15:06 Changeset [15626] by brmorris

2006-07-25 brmorris <bradley.morrison@nokia.com>

Quickfix for RD_32_BROWSER build


Reviewed by Sachin.

  • BrowserView/inc/WebKitToolBarInterface.h: Removed errant "\no newline at end of file" :-)
14:24 Changeset [15625] by brmorris

2006-07-25 brmorris <bradley.morrison@nokia.com>

Reviewed by Sachin.

  • build.bat: restores variant.cfg to default at END
  • variant_default.cfg: Added.
14:06 Changeset [15624] by justing

Reviewed by darin


<rdar://problem/4468458> Incoming HTML message is editable <body contenteditable="true">

  • dom/Document.cpp: (WebCore::Document::inDesignMode): Removed some spaces.
  • page/Frame.cpp: (WebCore::Frame::applyEditingStyleToElement): Just add CSS properties needed for editing. (WebCore::Frame::removeEditingStyleFromElement): Made this a no-op, we'll remove it eventually.
13:56 Changeset [15623] by spadma

2006-07-25 yadavall <sriram.yadavalli@nokia.com>

Reviewed by Sachin


WARNING: NO TEST CASES ADDED OR CHANGED


Implement webkit changes for toolbar.


http://bugzilla.opendarwin.org/show_bug.cgi?id=10101


  • BrowserControl/inc/BrCtl.h:
  • BrowserControl/inc/BrCtlDefs.h: (TBrCtlDefs::):
  • BrowserControl/inc/BrCtlInterface.h:
  • BrowserControl/src/BrCtl.cpp: (CBrCtl::~CBrCtl): (CBrCtl::HandleCommandL): (CBrCtl::AddCommandObserverL): (CBrCtl::RemoveCommandObserver): (CBrCtl::SendCommandsToClient):
  • BrowserView/inc/WebKitToolBarInterface.h: Added.
  • BrowserView/inc/WebKitView.h:
  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleOfferKeyEventL): (CKeyEventHandler::HandleActivateKeysL):
  • BrowserView/src/WebKitCursor.cpp: (CWebKitCursor::CursorUpdate):
  • BrowserView/src/WebKitToolBarInterface.cpp: Added. (CWebKitToolBarInterface::NewL): (CWebKitToolBarInterface::CWebKitToolBarInterface): (CWebKitToolBarInterface::ConstructL): (CWebKitToolBarInterface::~CWebKitToolBarInterface): (CWebKitToolBarInterface::CursorPosition): (CWebKitToolBarInterface::SetAndUpdateCursorPosition): (CWebKitToolBarInterface::SendCommandsToClient): (CWebKitToolBarInterface::ResolveUrlL): (CWebKitToolBarInterface::OpenPageViewL): (CWebKitToolBarInterface::HandleHistoryCommandL):
  • BrowserView/src/WebKitView.cpp: (CWebKitView::~CWebKitView): (CWebKitView::Draw): (CWebKitView::DrawToolTip): (CWebKitView::LaunchToolBarL): (CWebKitView::CloseToolBarL):
  • group/BWINSCW/WebKit_30U.def:
  • group/BrowserView.mmp:
  • group/EABI/browserengineU.def:
  • group/webkit.mmp:
  • rom/webkit.iby:
  • rom/webkitResources.iby:
13:32 Changeset [15622] by brmorris

2006-07-25 brmorris <bradley.morrison@nokia.com>

Reviewed by zbujtas@gmail.com.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9941


  • build.bat: Correct build drive print statement.

Allow BUILD_DRIVE env var support.

10:26 Changeset [15621] by brmorris

2006-07-25 brmorris <bradley.morrison@nokia.com>

Reviewed by Zalan.


http://bugzilla.opendarwin.org/show_bug.cgi?id=10104

  • runATF.bat: Restore emulator startup on SIGINT
10:23 Changeset [15620] by spadma

2006-07-25 vbradley <vincent.bradley@nokia.com>

Reviewed by Sachin & Sriram.

Changes to CreateStream to allow Plugins to make additional content requests.


http://bugzilla.opendarwin.org/show_bug.cgi?id=10091

  • Plugin/src/PluginWin.cpp: (CPluginWin::ConstructL): (CPluginWin::~CPluginWin): (CPluginWin::SizeChanged): (CPluginWin::OfferKeyEventL): (CPluginWin::DestroyStream): (CPluginWin::CreateStreamL): (CPluginWin::WriteStreamL): (CPluginWin::WriteStreamToPluginL): (CPluginWin::DestroyStreamL): (CPluginWin::LoadRequestL): (CPluginWin::SetPluginFocusL): (CPluginWin::PluginConstructedL): (CPluginData::CPluginData): (CPluginData::NewL): (CPluginData::SetUrlL):
08:35 Changeset [15619] by ddkilzer

WebCore:

Reviewed by Darin.

No test added because there is no change in functionality.

  • bindings/js/kjs_binding.cpp: Removed valueToBooleanTreatUndefinedAsTrue() method.
  • bindings/js/kjs_binding.h: Ditto.
  • bindings/scripts/CodeGeneratorJS.pm: Removed support for ConvertUndefinedToTrue parameter attribute.
  • dom/Element.h: Set default value to true for scrollIntoView() and scrollIntoViewIfNeeded() arguments.
  • dom/Element.idl: Replaced ConvertUndefinedToTrue attribute with Optional attribute. Fixed name of scrollIntoViewIfNeeded() argument to match implementation.
  • page/DOMWindow.idl: Replaced ConvertUndefinedToTrue attribute with Optional attribute.
Note: See TracTimeline for information about the timeline view.