Timeline
Aug 3, 2006:
- 10:41 PM Changeset in webkit [15795] by
-
- 2 edits in trunk/WebCore
Minor tweak to earlier patch. Use containsFloats instad.
- 10:35 PM Changeset in webkit [15794] by
-
- 3 edits2 moves3 adds6 deletes in trunk/WebKit
Reviewed by Darin.
- moved all loader code that is slated to be moved down to WebCore to a new Loader directory
(next step is to remove dependencies on the rest of WebKit from this directory)
- Loader/WebNetscapePlugInStreamLoader.h: Added.
- Loader/WebNetscapePlugInStreamLoader.m: Added. Cut out of WebNetscapePluginStream.m (-[WebNetscapePlugInStreamLoader initWithStream:view:]): (-[WebNetscapePlugInStreamLoader isDone]): (-[WebNetscapePlugInStreamLoader releaseResources]): (-[WebNetscapePlugInStreamLoader didReceiveResponse:]): (-[WebNetscapePlugInStreamLoader didReceiveData:lengthReceived:]): (-[WebNetscapePlugInStreamLoader didFinishLoading]): (-[WebNetscapePlugInStreamLoader didFailWithError:]): (-[WebNetscapePlugInStreamLoader cancelWithError:]):
- Plugins/WebNetscapePluginStream.m:
- WebKit.xcodeproj/project.pbxproj:
- WebCoreSupport/WebSubresourceLoader.h: Moved to Loader/
- WebCoreSupport/WebSubresourceLoader.m: Moved to Loader/
- WebView/WebFrameLoader.h: Moved to Loader/
- WebView/WebFrameLoader.m: Moved to Loader/
- WebView/WebLoader.h: Moved to Loader/
- WebView/WebLoader.m: Moved to Loader/
- WebView/WebMainResourceLoader.h: Moved to Loader/
- WebView/WebMainResourceLoader.m: Moved to Loader/
- 7:08 PM Changeset in webkit [15793] by
-
- 2 edits in trunk/WebKit
Reviewed by Kevin Decker.
<rdar://problem/4667460> Windowless OpenGL plug-ins render incorrectly on PowerPC
- Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView _aglOffscreenImageForDrawingInRect:]): Fixed color component swapping so that it works on both x86 and PPC. See comments.
- 6:38 PM Changeset in webkit [15792] by
-
- 4 adds in trunk/LayoutTests/fast/block/float
- 6:35 PM Changeset in webkit [15791] by
-
- 2 edits in trunk/WebCore
Fix for bug 10229, don't bother trying to clear when no floats are
present. I suspect there's still a bug in the math that follows, but
this fix is safer in that it just does the obvious thing (and doesn't
compute any clearance if no floats are even around).
Reviewed by maciej
- ChangeLog:
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::getClearDelta):
- 5:42 PM Changeset in webkit [15790] by
-
- 4 edits4 adds in trunk
LayoutTests:
Reviewed by harrison
- editing/style/non-inheritable-styles-expected.checksum: Added.
- editing/style/non-inheritable-styles-expected.png: Added.
- editing/style/non-inheritable-styles-expected.txt: Added.
- editing/style/non-inheritable-styles.html: Added.
WebCore:
Reviewed by harrison
<rdar://problem/4641033/4515463/4052426/4046570/4053718/4053724/4060115/4062858>
Copy/Paste fidelity was bad.
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle):
- editing/markup.cpp: (WebCore::startMarkup): We were not adding non-inheritable styles to the markup for an element unless they were in the elements inline style declaration.
- 5:37 PM Changeset in webkit [15789] by
-
- 1 edit in trunk/WebKit/ChangeLog
Cleaned up the ChangeLog from last checkin
- 5:00 PM Changeset in webkit [15788] by
-
- 2 edits in trunk/WebKit
Reviewed by Tim Hatcher's rubber stamp
Fixed Intel build break caused by weinig's -W change in r15781
- WebView/WebView.m: wrapped cpu-dependent defs with defined() macro
- 3:58 PM Changeset in webkit [15787] by
-
- 2 edits in trunk/WebKit
Reviewed by John.
- fixed problem that could cause assertion failures in Safari
- Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]): Don't allow a plugin to start new loads once its document is no longer the one actively loading.
- 3:48 PM Changeset in webkit [15786] by
-
- 3 edits in S60/trunk/WebKit
Rolling out r15783 which introduced a new, unwanted dependency. This patch needs to be re-thought.
- 3:35 PM Changeset in webkit [15785] by
-
- 2 edits in S60/trunk/JavaScriptCore
2006-08-03 bujtas <zbujtas@gmail.com>
Reviewed by Yongjun.
fix hashtable crash in case of oom
- kjs/identifier.cpp: (KJS::Identifier::rehash):
- 3:33 PM Changeset in webkit [15784] by
-
- 14 edits in trunk/WebKit
Reviewed by John.
- remove use of WebDataSource from WebLoader and subclasses, just have them talk to the WebFrameLoader instead.
For now this is done by forarding all the calls.
- Misc/WebIconLoader.m: (-[WebIconLoader didFinishLoading]):
- Plugins/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]): (-[WebNetscapePluginStream start]): (-[WebNetscapePlugInStreamLoader didFinishLoading]): (-[WebNetscapePlugInStreamLoader didFailWithError:]): (-[WebNetscapePlugInStreamLoader cancelWithError:]):
- WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
- WebCoreSupport/WebSubresourceLoader.h:
- WebCoreSupport/WebSubresourceLoader.m: (-[WebSubresourceLoader initWithLoader:frameLoader:]): (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]): (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:referrer:forFrameLoader:]): (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:postData:referrer:forFrameLoader:]): (-[WebSubresourceLoader receivedError:]): (-[WebSubresourceLoader signalFinish]): (-[WebSubresourceLoader didFailWithError:]): (-[WebSubresourceLoader cancel]):
- WebKit.xcodeproj/project.pbxproj:
- WebView/WebDataSource.m: (-[WebDataSource _updateLoading]): (-[WebDataSource textEncodingName]): (-[WebDataSource _mainReceivedBytesSoFar:complete:]):
- WebView/WebFrameLoader.h:
- WebView/WebFrameLoader.m: (-[WebFrameLoader loadIconWithRequest:]): (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]): (-[WebFrameLoader clearIconLoader]): (-[WebFrameLoader commitProvisionalLoad]): (-[WebFrameLoader activeDataSource]): (-[WebFrameLoader _archivedSubresourceForURL:]): (-[WebFrameLoader _defersCallbacks]): (-[WebFrameLoader _identifierForInitialRequest:]): (-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]): (-[WebFrameLoader _didReceiveAuthenticationChallenge:forResource:]): (-[WebFrameLoader _didCancelAuthenticationChallenge:forResource:]): (-[WebFrameLoader _didReceiveResponse:forResource:]): (-[WebFrameLoader _didReceiveData:contentLength:forResource:]): (-[WebFrameLoader _didFinishLoadingForResource:]): (-[WebFrameLoader _didFailLoadingWithError:forResource:]): (-[WebFrameLoader _privateBrowsingEnabled]): (-[WebFrameLoader _addPlugInStreamLoader:]): (-[WebFrameLoader _removePlugInStreamLoader:]): (-[WebFrameLoader _finishedLoadingResource]): (-[WebFrameLoader _receivedError:]): (-[WebFrameLoader _addSubresourceLoader:]): (-[WebFrameLoader _removeSubresourceLoader:]): (-[WebFrameLoader _originalRequest]): (-[WebFrameLoader webFrame]): (-[WebFrameLoader _receivedMainResourceError:complete:]): (-[WebFrameLoader initialRequest]): (-[WebFrameLoader _receivedData:]): (-[WebFrameLoader _setRequest:]): (-[WebFrameLoader _downloadWithLoadingConnection:request:response:proxy:]): (-[WebFrameLoader _handleFallbackContent]): (-[WebFrameLoader _isStopping]): (-[WebFrameLoader _decidePolicyForMIMEType:decisionListener:]): (-[WebFrameLoader _setupForReplaceByMIMEType:]): (-[WebFrameLoader _setResponse:]): (-[WebFrameLoader _mainReceivedError:complete:]): (-[WebFrameLoader _finishedLoading]): (-[WebFrameLoader _mainReceivedBytesSoFar:complete:]): (-[WebFrameLoader _iconLoaderReceivedPageIcon:]): (-[WebFrameLoader _URL]):
- WebView/WebLoader.h:
- WebView/WebLoader.m: (-[NSURLProtocol releaseResources]): (-[NSURLProtocol loadWithRequest:]): (-[NSURLProtocol setFrameLoader:]): (-[NSURLProtocol frameLoader]): (-[NSURLProtocol willSendRequest:redirectResponse:]): (-[NSURLProtocol didReceiveAuthenticationChallenge:]): (-[NSURLProtocol didCancelAuthenticationChallenge:]): (-[NSURLProtocol didReceiveResponse:]): (-[NSURLProtocol didReceiveData:lengthReceived:]): (-[NSURLProtocol signalFinish]): (-[NSURLProtocol didFailWithError:]): (-[NSURLProtocol willCacheResponse:]): (-[NSURLProtocol cancelWithError:]):
- WebView/WebMainResourceLoader.h:
- WebView/WebMainResourceLoader.m: (-[WebMainResourceLoader initWithFrameLoader:]): (-[WebMainResourceLoader receivedError:]): (-[WebMainResourceLoader cancelWithError:]): (-[WebMainResourceLoader _isPostOrRedirectAfterPost:redirectResponse:]): (-[WebMainResourceLoader addData:]): (-[WebMainResourceLoader willSendRequest:redirectResponse:]): (-[WebMainResourceLoader continueAfterContentPolicy:response:]): (-[WebMainResourceLoader continueAfterContentPolicy:]): (-[WebMainResourceLoader checkContentPolicyForResponse:]): (-[WebMainResourceLoader didReceiveResponse:]): (-[WebMainResourceLoader didReceiveData:lengthReceived:]): (-[WebMainResourceLoader didFinishLoading]): (-[WebMainResourceLoader didFailWithError:]): (-[WebMainResourceLoader loadWithRequestNow:]):
- 3:12 PM Changeset in webkit [15783] by
-
- 3 edits in S60/trunk/WebKit
2006-08-03 spaltis
Reviewed Yongjun.
Unfinished download should be visible in the download list,
before connection is established.
- ResourceLoader/inc/HttpDownloadObserver.h:
- ResourceLoader/src/HttpDownloadObserver.cpp: (CHttpDownloadObserver::~CHttpDownloadObserver): (CHttpDownloadObserver::ConstructL): (CHttpDownloadObserver::DlMgrInitCB): (CHttpDownloadObserver::InitDownloadMgrL): (CHttpDownloadObserver::HandleDMgrEventL): (CHttpDownloadObserver::HandleDMgrCompletedEventL):
- 3:03 PM Changeset in webkit [15782] by
-
- 3 edits in S60/trunk/WebKit
2006-08-03 ligman <joseph.ligman@nokia.com>
Reviewed by Yongjun.
The browser engine opens same database 9 times in CFaviconHandler during startup
CFaviconHandler has only one instance. Open the database in ConstructL
and close it when the object is deleted.
- BrowserCore/Misc/inc/Favicon.h:
- BrowserCore/Misc/src/Favicon.cpp: (CFaviconHandler::NewL): (CFaviconHandler::CFaviconHandler): (CFaviconHandler::ConstructL): (CFaviconHandler::~CFaviconHandler): (CFaviconHandler::SetFaviconL): (CFaviconHandler::InsertFaviconL): (CFaviconHandler::GetFaviconL): (CFaviconHandler::OpenDatabaseL): (CFaviconHandler::DeleteFaviconL): (CFaviconHandler::UpdateTimeL): (CFaviconHandler::CreateDatabaseL): (CFaviconHandler::ExtractDomainL):
- 2:55 PM Changeset in webkit [15781] by
-
- 94 edits in trunk
Reviewed by Darin.
- patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10176 Make WebCore compile with -Wundef
- Adds -Wundef flag to Xcode project
- Converts #ifs to #ifdef and #ifndefs where needed.
- Added #define YYMAXDEPTH 10000 in kjs/grammar.y to fix a warning from within Bison.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bindings/jni/jni_jsobject.cpp: (JavaJSObject::getSlot): (JavaJSObject::setSlot):
- bindings/npapi.h:
- bindings/objc/objc_class.mm: (KJS::Bindings::ObjcClass::methodsNamed): (KJS::Bindings::ObjcClass::fieldNamed):
- bindings/objc/objc_instance.mm: (ObjcInstance::invokeMethod):
- bindings/objc/objc_runtime.mm: (ObjcMethod::getMethodSignature): (ObjcField::name): (ObjcField::type):
- kjs/grammar.y:
- kjs/identifier.h:
JavaScriptGlue:
Reviewed by Darin.
- patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10176 Make WebCore compile with -Wundef
- Adds -Wundef flag to Xcode project
- JavaScriptGlue.xcodeproj/project.pbxproj:
WebCore:
Reviewed by Darin.
- patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10176 Make WebCore compile with -Wundef
- Adds -Wundef flag to Xcode project
- Converts #ifs to #ifdef and #ifndefs where needed.
- Replaces #ifdef WIN32 with #if PLATFORM(WIN_OS) or PLATFORM(WIN) (and in one instance in config.h with #if !COMPILER(MSVC))
- Added #define YYMAXDEPTH 10000 in XPathGrammar.y and CSSGrammar.y to fix a warning from within Bison.
- Cleaned up style a little in surrounding code.
- WebCore.xcodeproj/project.pbxproj:
- bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject doAXTextMarkerRangeForUnorderedTextMarkers:]):
- config.h:
- css/CSSGrammar.y:
- css/MediaFeatureNames.cpp:
- css/MediaFeatureNames.h:
- css/cssparser.cpp:
- dom/ContainerNode.cpp: (WebCore::ContainerNode::setActive):
- dom/Element.cpp: (WebCore::Element::attach):
- dom/Element.h:
- dom/EventNames.cpp:
- dom/EventNames.h:
- dom/NamedAttrMap.h:
- dom/Position.cpp:
- dom/QualifiedName.cpp:
- dom/QualifiedName.h:
- dom/Range.h:
- dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::error):
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): (WebCore::HTMLTokenizer::scriptExecution): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::continueProcessing): (WebCore::HTMLTokenizer::write): (WebCore::HTMLTokenizer::timerFired): (WebCore::HTMLTokenizer::notifyFinished):
- kcanvas/device/quartz/KCanvasFilterQuartz.h:
- kcanvas/device/quartz/KRenderingDeviceQuartz.h:
- ksvg2/css/SVGRenderStyle.h:
- ksvg2/css/SVGRenderStyleDefs.h:
- ksvg2/scripts/make_names.pl:
- loader/CachedResource.h:
- loader/LoaderFunctions.h:
- loader/loader.h:
- page/Frame.cpp:
- page/FrameTree.cpp:
- page/FrameView.cpp: (WebCore::FrameView::clear): (WebCore::FrameView::layout): (WebCore::FrameView::layoutTimerFired): (WebCore::FrameView::scheduleRelayout): (WebCore::FrameView::unscheduleRelayout):
- platform/AtomicString.cpp:
- platform/AtomicString.h:
- platform/Cursor.h:
- platform/DeprecatedArray.h:
- platform/DeprecatedString.cpp: (WebCore::allocateHandle): (WebCore::initializeHandleNodeBlock): (WebCore::freeHandle):
- platform/FloatPoint.h:
- platform/FloatRect.h:
- platform/FloatSize.h:
- platform/GraphicsContext.h:
- platform/Image.h:
- platform/IntPoint.h:
- platform/IntRect.h: (WebCore::IntRect::inflateX): (WebCore::IntRect::inflateY):
- platform/IntSize.h:
- platform/PlatformKeyboardEvent.h:
- platform/PlatformMouseEvent.h:
- platform/PlatformString.h:
- platform/ResourceLoader.h:
- platform/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
- platform/ScrollView.h:
- platform/StaticConstructors.h:
- platform/StreamingTextDecoderICU.cpp: (WebCore::StreamingTextDecoderICU::convert):
- platform/StringImpl.h:
- platform/Widget.h:
- platform/mac/BlockExceptions.mm:
- platform/mac/ColorMac.mm: (+[WebCoreControlTintObserver WebCore]):
- platform/mac/FloatPointMac.mm:
- platform/mac/FloatRectMac.mm:
- platform/mac/FloatSizeMac.mm:
- platform/mac/FontMac.mm:
- platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawFocusRing):
- platform/mac/IntPointMac.mm:
- platform/mac/IntRectMac.mm:
- platform/mac/IntSizeMac.mm:
- platform/mac/WebCoreSystemInterface.h:
- rendering/RenderBlock.h:
- rendering/RenderTableCell.h:
- rendering/bidi.cpp: (WebCore::appendRun): (WebCore::RenderBlock::layoutInlineChildren):
- xml/XSLTProcessor.cpp: (WebCore::parseErrorFunc):
- xpath/impl/XPathGrammar.y:
WebKit:
Reviewed by Darin.
- patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10176 Make WebCore compile with -Wundef
- Adds -Wundef flag to Xcode project
- Converts #ifs to #ifdef and #ifndefs where needed.
- Carbon/CarbonUtils.m:
- Carbon/CarbonWindowAdapter.m:
- Carbon/HIViewAdapter.m: (+[NSView bindHIViewToNSView:nsView:]):
- Carbon/HIWebView.m: (HIWebViewEventHandler):
- Misc/WebFileDatabase.m: (UniqueFilePathForKey):
- Misc/WebNSWindowExtras.m: (swizzleInstanceMethod):
- Misc/WebTypesInternal.h:
- Plugins/WebNetscapeDeprecatedFunctions.c:
- Plugins/WebNetscapeDeprecatedFunctions.h:
- Plugins/WebNetscapePluginPackage.h:
- Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage unloadWithoutShutdown]): (-[WebNetscapePluginPackage load]):
- WebKit.xcodeproj/project.pbxproj:
- 1:25 PM Changeset in webkit [15780] by
-
- 3 edits in trunk/LayoutTests
Reviewed by darin
- fast/forms/plaintext-mode-1-expected.txt:
- fast/forms/plaintext-mode-1.html:
- 1:13 PM Changeset in webkit [15779] by
-
- 4 edits in S60/trunk/WebKit
2006-08-03 rathnasa <sornalatha.rathnasamy@nokia.com>
Reviewed by Zalan.
Fix pending resource loading.
- BrowserView/inc/WebKitLoader.h:
- BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::CreateAsyncCancelHandleL):
- BrowserView/src/webkitbridge.cpp: (CWebKitBridge::StartLoadingResource):
- 12:51 PM Changeset in webkit [15778] by
-
- 4 edits in S60/trunk/WebKit
2006-08-02 ligman <joseph.ligman@nokia.com>
Reviewed by Yongjun.
The SetClientResolvesUrl setting was not set when pages were loaded.
If the ResolveLinkL callback failed to handle the link the transaction was canceled
before it was added to the queue and a crash would occur. I delay the cancel by
putting it into a callback.
- BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
- ResourceLoader/inc/BufferTransaction.h:
- ResourceLoader/src/BufferTransaction.cpp: (CBufferTransaction::CancelTransactionCB): (CBufferTransaction::~CBufferTransaction): (CBufferTransaction::DoSubmitL): (CBufferTransaction::HandleClientDataChunkL):
- 12:33 PM Changeset in webkit [15777] by
-
- 2 edits in trunk/JavaScriptCore
2006-08-03 Anders Carlsson <acarlsson@apple.com>
Reviewed by John Sullivan.
- wtf/HashSet.h: (WTF::::operator): Return *this in operator=
- 12:29 PM Changeset in webkit [15776] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej and Beth.
Fix use-after-dispose heap corruption bug.
- rendering/ListMarkerBox.cpp: (WebCore::ListMarkerBox::destroy): Only call removeChild if we're not destroying the document
- 12:19 PM Changeset in webkit [15775] by
-
- 2 edits in S60/trunk/WebKit
2006-08-03 vbradley <vincent.bradley@nokia.com>
Reviewed by Yongjun & Sriram
Changes the cursor to correct image when loading a new page and was
was displaying the waiting cursor.
- BrowserView/src/WebKitCursor.cpp: (CWebKitCursor::CursorUpdate): (CWebKitCursor::SetWaitCursor):
- 12:18 PM Changeset in webkit [15774] by
-
- 6 edits in trunk
Reviewed by Anders.
- Fixed Windows build
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- wtf/MathExtras.h: Implement inline versions of these functions (nextafter): (nextafterf):
WebCore:
Reviewed by Anders.
- Fixed Windows build.
- platform/Color.cpp: (WebCore::makeRGBAFromHSLA): Whitespace change
- platform/win/TemporaryLinkStubs.cpp: Add new method stubs (PlatformScrollBar::PlatformScrollBar): (PlatformScrollBar::~PlatformScrollBar): (PlatformScrollBar::width): (PlatformScrollBar::height): (PlatformScrollBar::setEnabled): (PlatformScrollBar::paint): (PlatformScrollBar::setScrollBarValue): (PlatformScrollBar::setKnobProportion): (PlatformScrollBar::setRect): (ScrollBar::ScrollBar): (ScrollBar::scroll): (ScrollBar::setValue):
- 11:48 AM Changeset in webkit [15773] by
-
- 2 edits in S60/trunk/WebKit
2006-08-03 ligman <joseph.ligman@nokia.com>
Reviewed by Yongjun.
FocusElementType is incosistent in tabbed view.
Resolved by setting the current focus element type prior to
calling TabbedNavigation in CKeyEventHandler::NavigateWithCursor which
will reset the focus element type.
- BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::NavigateWithCursor):
- 11:04 AM Changeset in webkit [15772] by
-
- 4 edits4 adds in trunk
LayoutTests:
Reviewed by mjs
<http://bugzilla.opendarwin.org/show_bug.cgi?id=10225>
GMail Editor: Change Hilite Color doesn't work
- editing/execCommand/hilitecolor-expected.checksum: Added.
- editing/execCommand/hilitecolor-expected.png: Added.
- editing/execCommand/hilitecolor-expected.txt: Added.
- editing/execCommand/hilitecolor.html: Added.
WebCore:
Reviewed by mjs
<http://bugzilla.opendarwin.org/show_bug.cgi?id=10225>
GMail Editor: Change Hilite Color doesn't work
- editing/JSEditor.cpp: Added support for execCommand("HiliteColor", ...). It's what GMail uses to implement text hiliting. It's just a synonym for BackColor.
- editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved): Moved a comment a more appropriate place.
- 9:21 AM Changeset in webkit [15771] by
-
- 1 edit50 adds in S60/trunk/LayoutTests
2006-07-31 brmorris <bradley.morrison@nokia.com>
Reviewed by dacarson.
Adding new LayoutTest baselines.
- 9:18 AM Changeset in webkit [15770] by
-
- 2 edits in S60/trunk
2006-07-31 brmorris <bradley.morrison@nokia.com>
Reviewed by dacarson.
- runATF.bat: Generate and copy 'expected' if missing.
- 8:36 AM Changeset in webkit [15769] by
-
- 4 edits in trunk/WebKitTools
2006-08-03 Mark Rowe <opendarwin.org@bdash.net.nz>
Reviewed by Darin.
Bug 10224: [Drosera] Drosera icon should be set on DroseraLauncher so it appears in nightly builds
http://bugzilla.opendarwin.org/show_bug.cgi?id=10224
- Drosera/Drosera.xcodeproj/project.pbxproj:
- Drosera/LauncherInfo.plist:
2006-08-03 Mitz Pettel <opendarwin.org@mitzpettel.com>
- fix ASSERTION FAILURE: draggingDocumentView == nil in -[WebViewPrivate dealloc] when a test performs an unsuccessful drag and drop operation.
- DumpRenderTree/EventSendingController.m: (-[EventSendingController mouseUp]): Added a call to -draggingExited: if the drag operation for the mouse release is NSDragOperationNone.
- 8:34 AM Changeset in webkit [15768] by
-
- 4 edits4 adds in trunk
LayoutTests:
Reviewed by Adele and Darin.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10177 REGRESSION: Successfully dragging text into a disabled field
- fast/forms/textfield-drag-into-disabled-expected.checksum: Added.
- fast/forms/textfield-drag-into-disabled-expected.png: Added.
- fast/forms/textfield-drag-into-disabled-expected.txt: Added.
- fast/forms/textfield-drag-into-disabled.html: Added.
- fast/forms/input-disabled-color-expected.txt: Updated.
WebCore:
Reviewed by Adele and Darin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10177 REGRESSION: Successfully dragging text into a disabled field
Test: fast/forms/textfield-drag-into-disabled.html
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createDivStyle): Changed to set -webkit-user-modify to read-only on the inner div if the control is disabled. (WebCore::RenderTextControl::updateFromElement): Ditto.
- 8:24 AM Changeset in webkit [15767] by
-
- 3 edits2 adds in trunk
LayoutTests:
Reviewed by Darin.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10198 REGRESSION: WebKit r15750 crashes while loading anthem.com
- fast/overflow/generated-content-crash-expected.txt: Added.
- fast/overflow/generated-content-crash.html: Added.
WebCore:
Reviewed by Darin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10198 REGRESSION: WebKit r15750 crashes while loading anthem.com
Test: fast/overflow/generated-content-crash.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateScrollInfoAfterLayout): Added a null check for the renderer's element. Generated content does not have an element and therefore does not need to maintain overflow status.
- 8:22 AM Changeset in webkit [15766] by
-
- 3 edits2 adds in trunk
LayoutTests:
Reviewed by Anders.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10202 REGRESSION: Repro crash when loading an empty image document
- fast/tokenizer/image-empty-crash-expected.txt: Added.
- fast/tokenizer/image-empty-crash.html: Added.
WebCore:
Reviewed by Anders.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10202 REGRESSION: Repro crash when loading an empty image document
Test: fast/tokenizer/image-empty-crash.html
- loader/ImageDocument.cpp: (WebCore::ImageTokenizer::stopParsing): Added null check for m_imageElement. (WebCore::ImageTokenizer::finish): Ditto.
- 8:21 AM Changeset in webkit [15765] by
-
- 6 edits in trunk/WebCore
Reviewed by Anders.
- clean up "flip"-related code a tiny bit
- platform/Screen.h: Removed redundant parameter names.
- platform/mac/ScreenMac.mm: (WebCore::flipScreenRect): Changed to call flipScreenPoint so we only have one copy of the flipping code. (WebCore::flipScreenPoint): Fixed indentation.
- bridge/mac/WebCoreFrameBridge.mm: (globalPoint): Removed type casts and simplified a bit.
- platform/mac/PlatformMouseEventMac.mm: (WebCore::globalPositionForEvent):
- platform/mac/WheelEventMac.mm: (WebCore::globalPositionForEvent): Removed unneeded local variable.
- 8:17 AM Changeset in webkit [15764] by
-
- 2 edits in trunk/WebKit
Reviewed by Eric Seidel.
- fix storage leak
- WebView/WebFrame.m: (-[WebFramePrivate dealloc]): Release the frame loader.
Aug 2, 2006:
- 11:08 PM Changeset in webkit [15763] by
-
- 2 edits in trunk/WebKit
Rubber stamped by Maciej.
Adding back resultsWithXpathQuery, removed by Darin's earlier change.
This function is called from ObjC, but not used from JavaScript.
- WebInspector/webInspector/inspector.js:
- 4:18 PM Changeset in webkit [15762] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Darin.
Bug 9632: [Drosera] syntax highlighting is slow (reproducible 40 second hang)
http://bugzilla.opendarwin.org/show_bug.cgi?id=9632
Do not change the file source when normalizing the line endings.
We use this file source to compare against new versions of the source
as it comes in, so we can skip re-syntax highlighting if they are the same.
The problem is apparent on yahoo.com since they have mixed line endings and
once we normalize them the source will always be different. This was
compounded by the fact that yahoo has around 40 inline scripts. Each
inline script causes us to check if the main document has more loaded,
that is when we compare the source strings. Since they are always different
we would syntax highlight yahoo.com 40 times! We do check source length before
doing a more expensive string comparison, but the lengths were the same.
- Drosera/debugger.js:
- 4:15 PM Changeset in webkit [15761] by
-
- 3 edits in trunk/WebKit
Reviewed by Darin.
Bug 10200: [Drosera] Deadlock between Drosera and Safari while loading page
http://bugzilla.opendarwin.org/show_bug.cgi?id=10200
Prevent reentrancy in our debugger callbacks. This was causing a deadlock in Drosera because
suspendProcessIfPaused was being called during a DO call into Safari.
Preventing reentrancy also prevents scripts that Drosera injects and evaluates from showing
up in rare cases (such as a iframe loading about:blank). I thought this would prevent cases
where you call a function from the console and expect it to break on a breakpoint in them, but
this appears to never have worked even without this change. When that is figured out we can
reconsider a better solution to reentrancy. I have filed that as bug 10214.
I also removed the NSRunLoop runMode:beforeDate: calls since DO handles this for us since
we don't use "onway void" as the return type for the callbacks. Note: using onway void for
the listener callbacks causes bad synchronization issues and obscure crashes.
- DefaultDelegates/WebScriptDebugServer.m: (-[WebScriptDebugServer webView:didLoadMainResourceForDataSource:]): (-[WebScriptDebugServer webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]): (-[WebScriptDebugServer webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]): (-[WebScriptDebugServer webView:didEnterCallFrame:sourceId:line:forWebFrame:]): (-[WebScriptDebugServer webView:willExecuteStatement:sourceId:line:forWebFrame:]): (-[WebScriptDebugServer webView:willLeaveCallFrame:sourceId:line:forWebFrame:]): (-[WebScriptDebugServer webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
- DefaultDelegates/WebScriptDebugServerPrivate.h:
- 3:59 PM Changeset in webkit [15760] by
-
- 4 edits in trunk/WebCore
Abstract RenderLayer scrollbar creation and destruction so that there
is a clean spot in which to drop in engine scrollbar stuff.
Reviewed by timo
- platform/ScrollBar.h: (WebCore::ScrollBar::hasPlatformScrollBars):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): (WebCore::RenderLayer::destroyScrollbar): (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar):
- rendering/RenderLayer.h:
- 3:58 PM Changeset in webkit [15759] by
-
- 2 edits1 add in trunk/WebKitSite
Reviewed by TimO.
Tweaked the build instructions a bit.
- building/build.html:
- building/debug.png: Added.
- 3:47 PM RecentChanges created by
- 3:47 PM SandBox created by
- 3:47 PM TitleIndex created by
- 3:47 PM CamelCase created by
- 3:47 PM TracAccessibility created by
- 3:47 PM TracAdmin created by
- 3:47 PM TracBackup created by
- 3:47 PM TracBrowser created by
- 3:47 PM TracCgi created by
- 3:47 PM TracInstall created by
- 3:47 PM TracInterfaceCustomization created by
- 3:47 PM TracLinks created by
- 3:47 PM TracChangeset created by
- 3:47 PM TracEnvironment created by
- 3:47 PM TracFastCgi created by
- 3:47 PM TracGuide created by
- 3:47 PM TracRss created by
- 3:47 PM TracImport created by
- 3:47 PM TracIni created by
- 3:47 PM TracLogging created by
- 3:47 PM TracModPython created by
- 3:47 PM TracNotification created by
- 3:47 PM TracPermissions created by
- 3:47 PM TracPlugins created by
- 3:47 PM TracQuery created by
- 3:47 PM TracReports created by
- 3:47 PM TracRoadmap created by
- 3:47 PM TracSearch created by
- 3:47 PM TracStandalone created by
- 3:47 PM TracSupport created by
- 3:47 PM TracSyntaxColoring created by
- 3:47 PM TracTickets created by
- 3:47 PM WikiHtml created by
- 3:47 PM TracTicketsCustomFields created by
- 3:47 PM TracTimeline created by
- 3:47 PM TracUnicode created by
- 3:47 PM TracUpgrade created by
- 3:47 PM TracWiki created by
- 3:47 PM WikiDeletePage created by
- 3:47 PM WikiFormatting created by
- 3:47 PM WikiMacros created by
- 3:47 PM WikiPageNames created by
- 3:47 PM WikiProcessors created by
- 3:47 PM WikiRestructuredText created by
- 3:47 PM WikiRestructuredTextLinks created by
- 3:47 PM WikiStart created by
- 3:47 PM InterWiki edited by
- (diff)
- 3:47 PM TracFineGrainedPermissions created by
- 3:47 PM TracFastCgi edited by
- (diff)
- 3:47 PM TracEnvironment edited by
- (diff)
- 3:47 PM TracChangeset edited by
- (diff)
- 3:47 PM TracCgi edited by
- (diff)
- 3:47 PM InterTrac edited by
- (diff)
- 3:47 PM TracRevisionLog edited by
- (diff)
- 3:47 PM TracUpgrade edited by
- (diff)
- 3:47 PM TracUnicode edited by
- (diff)
- 3:47 PM TracTimeline edited by
- (diff)
- 3:47 PM TracTicketsCustomFields edited by
- (diff)
- 3:47 PM TracTickets edited by
- (diff)
- 3:47 PM WikiProcessors edited by
- (diff)
- 3:47 PM WikiMacros edited by
- (diff)
- 3:47 PM WikiFormatting edited by
- (diff)
- 3:47 PM WikiRestructuredTextLinks edited by
- (diff)
- 3:47 PM WikiRestructuredText edited by
- (diff)
- 3:47 PM WikiPageNames edited by
- (diff)
- 3:47 PM WikiHtml edited by
- (diff)
- 3:47 PM WikiDeletePage edited by
- (diff)
- 3:47 PM TracWorkflow created by
- 3:47 PM TracWiki edited by
- (diff)
- 3:47 PM TracSyntaxColoring edited by
- (diff)
- 3:47 PM TracSupport edited by
- (diff)
- 3:47 PM TracStandalone edited by
- (diff)
- 3:47 PM TracSearch edited by
- (diff)
- 3:47 PM TracRss edited by
- (diff)
- 3:47 PM TracRoadmap edited by
- (diff)
- 3:47 PM TracReports edited by
- (diff)
- 3:47 PM TracQuery edited by
- (diff)
- 3:47 PM TracPlugins edited by
- (diff)
- 3:47 PM TracPermissions edited by
- (diff)
- 3:47 PM TracNotification edited by
- (diff)
- 3:47 PM TracNavigation created by
- 3:47 PM TracModPython edited by
- (diff)
- 3:47 PM TracLogging edited by
- (diff)
- 3:47 PM TracLinks edited by
- (diff)
- 3:47 PM TracInterfaceCustomization edited by
- (diff)
- 3:47 PM TracInstall edited by
- (diff)
- 3:47 PM TracIni edited by
- (diff)
- 3:47 PM TracImport edited by
- (diff)
- 3:47 PM TracGuide edited by
- (diff)
- 3:47 PM TracBrowser edited by
- (diff)
- 3:47 PM TracBackup edited by
- (diff)
- 3:47 PM TracAdmin edited by
- (diff)
- 3:47 PM TracAccessibility edited by
- (diff)
- 3:47 PM TitleIndex edited by
- (diff)
- 3:47 PM RecentChanges edited by
- (diff)
- 3:47 PM PageTemplates created by
- 3:47 PM CamelCase edited by
- (diff)
- 1:32 PM Changeset in webkit [15758] by
-
- 3 edits4 adds4 deletes in trunk
Fix by Mitz Pettel, reviewed by Darin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3438 incorrect display of transparent 1x1 PNGs
Test: fast/replaced/image-solid-color-with-alpha.html
- platform/mac/ImageMac.mm: (WebCore::Image::checkForSolidColor): Changed to divide each color component by the alpha component. You need to do that since the bitmap context has premultiplied alpha but m_solidColor should be non-premultiplied.
- 1:26 PM Changeset in webkit [15757] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Darin.
- Fixed build
- kjs/date_object.cpp: (KJS::formatTime):
- 12:06 PM Changeset in webkit [15756] by
-
- 3 edits in trunk/WebKit
Reviewed by John.
- fix assertion failure on layout tests by stopping plugins from loading at a clearly defined time
- add more assertions for safety
- WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): Removed obsolete comment. (-[WebDataSource _updateLoading]): Add assertion ensuring this method is only called at a time when this data source is the one that might be loading for a frame. (-[WebDataSource _stopLoading]): Stop loading plugins as a FIXME suggests we should.
- WebView/WebFrameLoader.m: (-[WebFrameLoader isLoadingPlugIns]): New helper method. (-[WebFrameLoader isLoading]): Consider plugin loads too - otherwise we won't stop them at stopLoading time.
- 11:35 AM Changeset in webkit [15755] by
-
- 2 edits in trunk/WebKitSite
- building/checkout.html: Fix a typo: "OpenSource" instead of "Open Source".
- 11:14 AM Changeset in webkit [15754] by
-
- 4 edits in trunk
WebCore:
Reviewed by Brady.
- Remove redundant #include
- loader/loader.cpp:
WebKit:
Reviewed by Brady.
- Rename TransferJob to ResourceLoader (this file was forgotten in an earlier change by Maciej)
- COM/WebView.cpp:
- 11:13 AM Changeset in webkit [15753] by
-
- 3 edits1 add in trunk/WebKitTools
Reviewed by Timothy.
Bug 9931: [Drosera] Needs a cool icon
http://bugzilla.opendarwin.org/show_bug.cgi?id=9931
- Drosera/Drosera.icns: Added.
- Drosera/Drosera.xcodeproj/project.pbxproj:
- Drosera/Info.plist:
- 11:07 AM Changeset in webkit [15752] by
-
- 2 edits in S60/trunk/WebKit
2006-08-02 ligman <joseph.ligman@nokia.com>
Reviewed by Yongjun, landed by Bradley.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10194
Assigned a default element type to keep the focus from being undefined.
TWebCoreFocusedElementType elType = EWebCoreElementNone;
- BrowserView/src/WebKitControl.cpp: (CWebKitControl::FinalProgressComplete):
- 1:11 AM Changeset in webkit [15751] by
-
- 8 edits in trunk/WebKit
Reviewed by Adele.
- Change things around so WebFrameLoader tracks the main and provisional data source, as well as the frame load state, pulling much code out of WebFrame along the way.
The most significant aspects of this change are:
- management of WebDataSources and WebFrameState was moved into WebFrameLoader
- there is now just one WebFrameLoader shared between the primary and provisional data source
- WebKit.xcodeproj/project.pbxproj:
- WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _updateLoading]): (-[WebDataSource _loadIcon]): (-[WebDataSource _setPrimaryLoadComplete:]): (-[WebDataSource _stopLoading]): (-[WebDataSource _startLoading]): (-[WebDataSource _addSubresourceLoader:]): (-[WebDataSource _removeSubresourceLoader:]): (-[WebDataSource _addPlugInStreamLoader:]): (-[WebDataSource _removePlugInStreamLoader:]): (-[WebDataSource _defersCallbacksChanged]): (-[WebDataSource _stopLoadingWithError:]): (-[WebDataSource _revertToProvisionalState]): (-[WebDataSource _setupForReplaceByMIMEType:]): (-[WebDataSource initWithRequest:]): (-[WebDataSource data]): (-[WebDataSource isLoading]):
- WebView/WebFrame.m: (-[WebFramePrivate init]): (-[WebFramePrivate dealloc]): (-[WebFrame _closeOldDataSources]): (-[WebFrame _detachFromParent]): (-[WebFrame _makeDocumentView]): (-[WebFrame _receivedMainResourceError:]): (-[WebFrame _transitionToCommitted:]): (+[WebFrame _timeOfLastCompletedLoad]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _continueAfterWillSubmitForm:]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrame _initWithWebFrameView:webView:bridge:]): (-[WebFrame _frameLoader]): (-[WebFrame _provisionalLoadStarted]): (-[WebFrame _prepareForDataSourceReplacement]): (-[WebFrame _frameLoadCompleted]): (-[WebFrame provisionalDataSource]): (-[WebFrame dataSource]): (-[WebFrame stopLoading]):
- WebView/WebFrameInternal.h:
- WebView/WebFrameLoader.h:
- WebView/WebFrameLoader.m: (-[WebFrameLoader initWithWebFrame:]): (-[WebFrameLoader dealloc]): (-[WebFrameLoader dataSource]): (-[WebFrameLoader _setDataSource:]): (-[WebFrameLoader clearDataSource]): (-[WebFrameLoader provisionalDataSource]): (-[WebFrameLoader _setProvisionalDataSource:]): (-[WebFrameLoader _clearProvisionalDataSource]): (-[WebFrameLoader state]): (+[WebFrameLoader timeOfLastCompletedLoad]): (-[WebFrameLoader _setState:]): (-[WebFrameLoader clearProvisionalLoad]): (-[WebFrameLoader markLoadComplete]): (-[WebFrameLoader commitProvisionalLoad]): (-[WebFrameLoader stopLoading]): (-[WebFrameLoader startLoading]): (-[WebFrameLoader startProvisionalLoad:]): (-[WebFrameLoader setupForReplace]):
- WebView/WebFramePrivate.h:
Aug 1, 2006:
- 4:06 PM Changeset in webkit [15750] by
-
- 4 edits in trunk/WebKit
Reviewed by John Sullivan.
<rdar://problem/4480737> Flash crashes after it replaces itself via a document.write()
I kind of hate to do this, but this is the best way to work around buggy plug-ins like Flash that assume that
NPP_Destroy() cannot be called while the browser is calling one of its other plug-in functions. The classic
situation is a plug-in that replaces itself via an NPN_Invoke() that executes a document.write().
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendEvent:]): Call -willCallPlugInFunction and -didCallPlugInFunction around calls to the NPP_* functions. (-[WebBaseNetscapePluginView setWindowIfNecessary]): ditto (-[WebBaseNetscapePluginView start]): It should not be possible to start a plug-in instance while we are calling into it (one of those chicken/egg problems). Added a sanity-checking assertion. (-[WebBaseNetscapePluginView stop]): If we're already calling a plug-in function, do not call NPP_Destroy(). The plug-in function we are calling may assume that its instance->pdata, or other memory freed by NPP_Destroy(), is valid and unchanged until said plugin-function returns. (-[WebBaseNetscapePluginView pluginScriptableObject]): Call -willCallPlugInFunction and -didCallPlugInFunction around calls to the NPP_* functions. (-[WebBaseNetscapePluginView willCallPlugInFunction]): Increment plug-in function call depth. (-[WebBaseNetscapePluginView didCallPlugInFunction]): Decrement plug-in function call depth. Stop if we're supposed to stop. (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): Call -willCallPlugInFunction and -didCallPlugInFunction around calls to the NPP_* functions. (-[WebBaseNetscapePluginView webFrame:didFinishLoadWithReason:]): ditto (-[WebBaseNetscapePluginView _printedPluginBitmap]): ditto
- Plugins/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:]): Call -willCallPlugInFunction and -didCallPlugInFunction around calls to the NPP_* functions. (-[WebBaseNetscapePluginStream _destroyStream]): ditto (-[WebBaseNetscapePluginStream _deliverData]): ditto
- 4:04 PM Changeset in webkit [15749] by
-
- 1 copy in S60/tags/s60-RnD-06wk31_rc1
Tagging S60 RnD w31 '06 release candidate 1
- 3:58 PM Changeset in webkit [15748] by
-
- 3 edits in S60/trunk/WebKit
2006-08-01 hongzhao <hong.a.zhao@nokia.com>
Reviewed by Yongjun.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10184
Sound continues after page closes in Bookmark view.
- Plugin/inc/PluginAdapterInterface.h: (MPluginNotifier::): Added EPluginInvisible
- Plugin/src/PluginWin.cpp: (CPluginWin::MakeVisible): Sends message to Plugin notifier
- 3:53 PM Changeset in webkit [15747] by
-
- 2 edits in trunk/WebKit
- fix build after last change
- WebView/WebFrame.m: (-[WebFrame _checkLoadCompleteForThisFrame]):
- 3:43 PM Changeset in webkit [15746] by
-
- 6 edits in S60/trunk/WebKit
2006-07-31 vbradley <vincent.bradley@nokia.com>
Reviewed by Yongun & Sachin
Add changes to allow the user to send plugin content to viewer.
- BrowserControl/src/BrCtl.cpp:
- BrowserView/inc/PluginControl.h:
- BrowserView/src/PluginControl.cpp:
- Plugin/inc/PluginWin.h:
- Plugin/src/PluginWin.cpp:
- 3:08 PM Changeset in webkit [15745] by
-
- 5 edits in S60/trunk
2006-08-01 raalexan <rasvan.alexandrescu@nokia.com>
Reviewed by Sachin/Youngjun.
Horizontal scroll not working with WML pages.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10092
- BrowserControl/src/BrCtlScrollingProvider.cpp: (CBrCtlScrollingProvider::ResizeBrCtlView): Set the view rectangle in WML view.
- 3:05 PM Changeset in webkit [15744] by
-
- 2 edits in trunk/WebKit
Reviewed by Beth.
- revert part of my last fix that broke the Safari bookmarks view
- WebView/WebFrame.m: (-[WebFrame _checkLoadCompleteForThisFrame]): still send layout message for non-HTML views
- 1:20 PM Changeset in webkit [15743] by
-
- 2 edits in trunk/WebKit
Reviewed by Anders.
Fixed an assertion failure I ran into while debugging <rdar://problem/4652683>.
- Plugins/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView redeliverStream]): Don't clear the "instance" ivar here. This code was refactored here from the old WebNetscapePluginRepresentation, which also had an "instance" ivar. It is never appropriate to clear a plug-in view's instance. That is done when the plug-in is destroyed.
- 1:17 PM Changeset in webkit [15742] by
-
- 2 edits in S60/trunk/WebKit
2006-07-28 zhalu <zhaosong.lu@nokia.com>
Reviewed by Youngjun.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10149
- BrowserView/src/WebKitView.cpp: (CWebKitView::ProgressAndImageDecodeComplete): Now calls ScheduleRepaint()
- 1:06 PM Changeset in webkit [15741] by
-
- 2 edits in S60/trunk/WebKit
2006-08-01 naguo <George.Guo@nokia.com>
Reviewed by Yongjun.
- ResourceLoader/src/HttpDownloadObserver.cpp: (CHttpDownloadObserver::FindDownloadL): Make sure the download is not completed before start it
- 12:09 PM Changeset in webkit [15740] by
-
- 2 edits in S60/trunk/WebCore
2006-08-01 rathnasa <sornalatha.rathnasamy@nokia.com>
Reviewed by Zalan
Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10185
www.euromaster.fi crash due to memory corruption.
- kwq/KWQKURL.cpp: (KURL::KURL): free buffer (KURL::parse): free path_buffer not buffer
- 11:41 AM Changeset in webkit [15739] by
-
- 2 edits3 adds in trunk/WebKitSite
Reviewed by Beth.
- Added instructions for debugging in Xcode
- building/build-window.png: Added.
- building/build.html:
- building/custom-executable.png: Added.
- building/info-tab.png: Added.
- 11:38 AM Changeset in webkit [15738] by
-
- 2 edits in trunk/WebKit
Reviewed by Geoff.
- some refactoring in preparation for moving more stuff to WebFrameLoader.
- WebView/WebFrame.m: (-[WebFrame _clearDataSource]): (-[WebFrame _detachFromParent]): (-[WebFrame _commitProvisionalLoad]): (-[WebFrame _transitionToCommitted:]): (-[WebFrame _clearProvisionalLoad]): (-[WebFrame _markLoadComplete]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _startProvisionalLoad:]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrame stopLoading]):
- 11:03 AM Changeset in webkit [15737] by
-
- 5 edits in S60/trunk/WebKit
2006-08-01 ligman <joseph.ligman@nokia.com>
Reviewed by Yongjun.
Implemented MCoeForegroundObserver at CPluginWin to process
background/foreground events independently of changes in focus.
- Plugin/inc/PluginLoader.h:
- Plugin/inc/PluginSkin.h:
- Plugin/inc/PluginWin.h:
- Plugin/src/PluginWin.cpp: (CPluginWin::ConstructL): (CPluginWin::~CPluginWin): (CPluginWin::SizeChanged): (CPluginWin::ProcessEventL): (CPluginWin::HandleControlEventL): (CPluginWin::ViewFocusChanged): (CPluginWin::SetPluginFocusL): (CPluginWin::HandleGainingForeground): (CPluginWin::HandleLosingForeground):
- 10:57 AM Changeset in webkit [15736] by
-
- 4 edits in S60/trunk
2006-08-01 zhalu <zhaosong.lu@nokia.com>
Reviewed by Yongjun.
- BrowserCore/Formcontrols/src/FControlButtonSkin.cpp: (CFormButtonSkin::Draw): Now sets alpha
- 9:40 AM Changeset in webkit [15735] by
-
- 4 edits in trunk
LayoutTests:
- updated a test affected by changes to the DumpRenderTree tool to return a current mouse position
- fast/inline/dirtyLinesForInline-expected.txt: Updated.
WebKitTools:
- fix a bug in my recent change where the mouse position at the end of the last test would affect the results of the next test
- DumpRenderTree/DumpRenderTree.m: (dumpRenderTree): Set lastMousePosition to 0.
Jul 31, 2006:
- 11:15 PM Changeset in webkit [15734] by
-
- 12 edits in trunk
LayoutTests:
Reviewed by Darin.
- tests changed by http://bugzilla.opendarwin.org/show_bug.cgi?id=9955 Colors scaled from [0, 1] range to [0, 255] incorrectly
- fast/css/hsl-color-expected.checksum:
- fast/css/hsl-color-expected.png:
- fast/css/hsl-color-expected.txt:
- fast/forms/input-disabled-color-expected.checksum:
- fast/forms/input-disabled-color-expected.png:
- fast/forms/input-disabled-color-expected.txt:
WebCore:
Reviewed by Darin.
- patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=9955 Colors scaled from [0, 1] range to [0, 255] incorrectly
Fixes scaling issue and fixes Color to follow style guidelines.
- css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
- platform/Color.cpp: (WebCore::calcHue): (WebCore::makeRGBAFromHSLA): (WebCore::Color::Color): (WebCore::Color::name): (WebCore::Color::setNamedColor): (WebCore::Color::light): (WebCore::Color::dark): (WebCore::blend):
- platform/Color.h: (WebCore::Color::Color): (WebCore::Color::isValid): (WebCore::Color::red): (WebCore::Color::green): (WebCore::Color::blue): (WebCore::Color::alpha): (WebCore::Color::rgb): (WebCore::Color::setRGB): (WebCore::operator==): (WebCore::operator!=):
- rendering/RenderObject.cpp: (WebCore::RenderObject::drawBorder):
- 11:13 PM Changeset in webkit [15733] by
-
- 3 edits4 adds in trunk
LayoutTests:
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10158 REGRESSION: Selection highlight is dark and opaque when solid-color images are used
Reviewed by Darin.
- fast/backgrounds/solid-color-context-restore-expected.checksum: Added.
- fast/backgrounds/solid-color-context-restore-expected.png: Added.
- fast/backgrounds/solid-color-context-restore-expected.txt: Added.
- fast/backgrounds/solid-color-context-restore.html: Added.
WebCore:
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10158 REGRESSION: Selection highlight is dark and opaque when solid-color images are used
Reviewed by Darin.
Pixel test: fast/backgrounds/solid-color-context-restore.html
- platform/mac/ImageMac.mm: (WebCore::Image::draw): Added calls to preserve the graphics context around the painting of a solid color image. (WebCore::Image::drawTiled): Ditto.
- 11:10 PM Changeset in webkit [15732] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Maciej.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10182
Bug 10182: [Drosera] Evaluating expressions in Console is slow when current frame has many variables
- Drosera/console.js: String.indexOf returns -1 when the string is not found. Correct the logic to not reload local variable list unless an '=' character is in the expression.
- 11:00 PM Changeset in webkit [15731] by
-
- 5 edits in trunk
LayoutTests:
Reviewed by Maciej.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10171 REGRESSION: failing layout test: fast/events/objc-event-api.html
- fast/events/objc-event-api-expected.txt: Updated test results for changes in the DumpRenderTree tool.
WebKitTools:
Reviewed by Maciej.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10171 REGRESSION: failing layout test: fast/events/objc-event-api.html
- DumpRenderTree/DumpRenderTree.m: (main): Add pose so we can implement +[NSEvent mouseLocation]. Put the window at a predictable location in flipped coordinates, since those are the coordinates that we use. (+[DumpRenderTreeEvent mouseLocation]): Implement this, since it's used for mouse event handling inside WebHTMLView.
- DumpRenderTree/EventSendingController.m: (+[EventSendingController initialize]): Removed unused webkitDomEventProperties array. (-[EventSendingController init]): Removed, since the whole thing was a no-op. (-[EventSendingController mouseMoveToX:Y:]): Convert the x,y pair to window coordinates. The old code probably worked OK, but this is needed to be correct. (-[EventSendingController handleEvent:]): Put clientX/Y before screenX/Y and removed the flipping code from screenY. We didn't really need to flip screenY -- what was actually happening was that the position that DumpRenderTree chose was in non-flipped coordinates, and with that fixed we can just dump the screenY as-is.
- 10:15 PM Changeset in webkit [15730] by
-
- 25 edits10 moves in trunk
WebCore:
Rubber-stamped by Tim Hatcher.
- renamed TransferJob to ResourceLoader
- Projects/gdk/webcore-gdk.bkl:
- WebCore.vcproj/WebCore/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bridge/mac/FrameMac.mm:
- bridge/mac/WebCoreResourceLoaderImp.h:
- bridge/mac/WebCoreResourceLoaderImp.mm: (-[WebCoreResourceLoaderImp redirectedToURL:]): (-[WebCoreResourceLoaderImp addData:]): (-[WebCoreResourceLoaderImp finishJobAndHandle:]):
- bridge/win/FrameWin.cpp:
- dom/XMLTokenizer.cpp: (WebCore::openFunc):
- loader/Cache.cpp:
- loader/LoaderFunctions.h:
- loader/loader.cpp: (WebCore::Loader::servePendingRequests): (WebCore::Loader::receivedAllData): (WebCore::Loader::receivedResponse): (WebCore::Loader::receivedData): (WebCore::Loader::cancelRequests): (WebCore::Loader::jobForRequest):
- loader/loader.h:
- loader/mac/LoaderFunctionsMac.mm: (WebCore::ServeSynchronousRequest):
- platform/ResourceLoader.cpp: Added. (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::isErrorPage): (WebCore::ResourceLoader::error): (WebCore::ResourceLoader::setError): (WebCore::ResourceLoader::queryMetaData): (WebCore::ResourceLoader::addMetaData): (WebCore::ResourceLoader::kill): (WebCore::ResourceLoader::url): (WebCore::ResourceLoader::postData): (WebCore::ResourceLoader::method): (WebCore::ResourceLoader::client):
- platform/ResourceLoader.h: Added. (WebCore::ResourceLoader::getInternal):
- platform/ResourceLoaderClient.h: Added. (WebCore::ResourceLoaderClient::~ResourceLoaderClient): (WebCore::ResourceLoaderClient::receivedRedirect): (WebCore::ResourceLoaderClient::receivedResponse): (WebCore::ResourceLoaderClient::receivedData): (WebCore::ResourceLoaderClient::receivedAllData):
- platform/ResourceLoaderInternal.h: Added. (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
- platform/TransferJob.cpp: Removed.
- platform/TransferJob.h: Removed.
- platform/TransferJobClient.h: Removed.
- platform/TransferJobInternal.h: Removed.
- platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::openURL): (WebCore::FrameGdk::urlSelected): (WebCore::FrameGdk::receivedData): (WebCore::FrameGdk::receivedAllData):
- platform/gdk/FrameGdk.h:
- platform/gdk/ResourceLoaderCurl.cpp: Added. (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal): (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::cancel):
- platform/gdk/ResourceLoaderManager.cpp: Added. (WebCore::ResourceLoaderManager::ResourceLoaderManager): (WebCore::ResourceLoaderManager::get): (WebCore::ResourceLoaderManager::useSimpleTransfer): (WebCore::writeCallback): (WebCore::ResourceLoaderManager::downloadTimerCallback): (WebCore::ResourceLoaderManager::remove): (WebCore::ResourceLoaderManager::add): (WebCore::ResourceLoaderManager::cancel):
- platform/gdk/ResourceLoaderManager.h: Added.
- platform/gdk/TemporaryLinkStubs.cpp: (WebCore::ServeSynchronousRequest): (WebCore::ResourceLoader::assembleResponseHeaders): (WebCore::ResourceLoader::retrieveCharset):
- platform/gdk/TransferJobCurl.cpp: Removed.
- platform/gdk/TransferJobManager.cpp: Removed.
- platform/gdk/TransferJobManager.h: Removed.
- platform/mac/ResourceLoaderMac.mm: Added. (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal): (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::assembleResponseHeaders): (WebCore::ResourceLoader::retrieveCharset): (WebCore::ResourceLoader::setLoader): (WebCore::ResourceLoader::receivedResponse): (WebCore::ResourceLoader::cancel):
- platform/mac/TransferJobMac.mm: Removed.
- platform/win/ResourceLoaderWin.cpp: Added. (WebCore::addToOutstandingJobs): (WebCore::lookupResourceLoader): (WebCore::ResourceLoaderWndProc): (WebCore::initializeOffScreenResourceLoaderWindow): (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal): (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::fileLoadTimer): (WebCore::ResourceLoader::cancel):
- platform/win/ResourceLoaderWin.h: Added.
- platform/win/TemporaryLinkStubs.cpp: (WebCore::ServeSynchronousRequest): (WebCore::ResourceLoader::assembleResponseHeaders): (WebCore::ResourceLoader::retrieveCharset):
- platform/win/TransferJobWin.cpp: Removed.
- platform/win/TransferJobWin.h: Removed.
- xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc):
- xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::receivedAllData): (WebCore::XMLHttpRequest::receivedRedirect): (WebCore::XMLHttpRequest::receivedData):
- xml/xmlhttprequest.h:
WebKit:
Reviewed by Tim Hatcher.
- renamed TransferJob to ResourceLoader in WebCore
- COM/WebFrame.cpp: (WebFrame::loadDataSource): (WebFrame::receivedRedirect): (WebFrame::receivedResponse): (WebFrame::receivedData): (WebFrame::receivedAllData): (WebFrame::setStatusText):
- COM/WebFrame.h:
- 9:54 PM Changeset in webkit [15729] by
-
- 4 edits in trunk/WebKit
Reviewed by Maciej.
- omit the margin and padding boxes for display types where they are ignored
- use CSS instead of properties for table spacing and padding as suggested by Tim H.
- WebInspector/webInspector/inspector.css: Added rules for spacing and padding. Added rules that hide the margin and padding boxes (borders and all but the center cell) when the hide attribute is present.
- WebInspector/webInspector/inspector.html: Added classes for the rules above. Removed cellpadding and cellspacing attributes.
- WebInspector/webInspector/inspector.js: Added code to hide/show the margin and padding boxes based on the display type.
- 9:14 PM Changeset in webkit [15728] by
-
- 3 edits in trunk/WebCore
Reviewed by Hyatt.
- removed obsolete cell margin hack
- rendering/RenderBox.cpp: (WebCore::RenderBox::calcVerticalMargins): Set top and bottom margins to 0 for table cells instead of -16384. No effect on layout (including layout tests).
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added a few comments about differences between this class and the what the CSS specification says about computed style.
- 9:00 PM Changeset in webkit [15727] by
-
- 3 edits8 adds in trunk
LayoutTests:
Reviewed by Maciej.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9738
Bug 9738: Unqualified :hover selector ignored in strict parsing mode
- fast/selectors/unqualified-hover-quirks-expected.checksum: Added.
- fast/selectors/unqualified-hover-quirks-expected.png: Added.
- fast/selectors/unqualified-hover-quirks-expected.txt: Added.
- fast/selectors/unqualified-hover-quirks.html: Added.
- fast/selectors/unqualified-hover-strict-expected.checksum: Added.
- fast/selectors/unqualified-hover-strict-expected.png: Added.
- fast/selectors/unqualified-hover-strict-expected.txt: Added.
- fast/selectors/unqualified-hover-strict.html: Added.
WebCore:
Reviewed by Maciej.
http://bugzilla.opendarwin.org/show_bug.cgi?id=9738
Bug 9738: Unqualified :hover selector ignored in strict parsing mode
- css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkSelector): Restrict the :hover and :active exclusion based on onlyHoverActive to quirks mode.
- 8:54 PM Changeset in webkit [15726] by
-
- 2 edits in trunk/WebKit
Reviewed by Darin.
Fixes <http://bugzilla.opendarwin.org/show_bug.cgi?id=10159>
"REGRESSION: delegate returning no menu elements crashes webkit"
No automated test, because there's no way to programmatically open a context menu,
no manual test because there's no way to customize the context menu delegate.
- WebView/WebView.m: (-[WebView _menuForElement:defaultItems:]): Make sure the context menu returned some menu items before accessing the first one.
- 8:51 PM Changeset in webkit [15725] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10178
Bug 10178: [Drosera] Selecting a frame in the stack list should take you to that location in the source
- Drosera/debugger.js: Keep a stack that contains the source file and line number references for outer frames. Use this stack to determine which file and line to highlight when a stack frame is selected.
- 8:48 PM Changeset in webkit [15724] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10175
Bug 10175: [Drosera] Anonymous functions show up as "(global scope)" in stack list
- Drosera/DebuggerDocument.m: (-[WebScriptObject currentFunctionStack]): If the frame has a caller it isn't the global scope.
- 7:27 PM Changeset in webkit [15723] by
-
- 1 add in trunk/WebCore/platform/ScrollBar.cpp
Add ScrollBar.cpp to fix the build.
- 7:25 PM Changeset in webkit [15722] by
-
- 7 edits in trunk/WebCore
Fix for bug 10179, digg.com scrolls slowly. Improve fixed positioning
and fixed backgrounds so that a count of them is kept on the FrameView.
This allows us to switch slow scrolling on and off as these objects come
and go.
- css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): (WebCore::CSSStyleSelector::applyProperty):
- page/FrameView.cpp: (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::layout): (WebCore::FrameView::useSlowRepaints): (WebCore::FrameView::setUseSlowRepaints): (WebCore::FrameView::addSlowRepaintObject): (WebCore::FrameView::removeSlowRepaintObject):
- page/FrameView.h:
- rendering/RenderBox.cpp: (WebCore::RenderBox::paintBackgroundExtended):
- rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle):
- rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations):
- 6:50 PM Changeset in webkit [15721] by
-
- 11 edits2 adds1 delete in trunk/WebCore
Begin disentangling of scrollbar logic in preparation for engine-implemented
scrollbars. Split ScrollBar into two classes, an abstract base (still named
ScrollBar) and a new PlatformScrollBar subclass. This subclass is used only
by platforms that want to continue to use a platform scrollbar (rather than
the engine one).
Reviewed by darin
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLCanvasElement.h:
- page/Frame.cpp:
- platform/PlatformScrollBar.h: Added. (WebCore::PlatformScrollBar::isWidget):
- platform/ScrollBar.h: (WebCore::ScrollBarClient::~ScrollBarClient): (WebCore::ScrollBar::~ScrollBar): (WebCore::ScrollBar::orientation): (WebCore::ScrollBar::value): (WebCore::ScrollBar::client):
- platform/mac/PlatformScrollBarMac.mm: Added. (-[WebCoreScrollBar initWithPlatformScrollBar:]): (-[WebCoreScrollBar detachPlatformScrollBar]): (-[WebCoreScrollBar scroll:]): (-[WebCoreScrollBar widget]): (-[WebCoreScrollBar mouseDown:]): (WebCore::PlatformScrollBar::PlatformScrollBar): (WebCore::PlatformScrollBar::~PlatformScrollBar): (WebCore::PlatformScrollBar::setScrollBarValue): (WebCore::PlatformScrollBar::setKnobProportion): (WebCore::PlatformScrollBar::scrollbarHit): (WebCore::PlatformScrollBar::width): (WebCore::PlatformScrollBar::height): (WebCore::PlatformScrollBar::setRect): (WebCore::PlatformScrollBar::setEnabled): (WebCore::PlatformScrollBar::paint):
- platform/mac/ScrollBarMac.mm: Removed.
- platform/mac/WebCoreTextArea.mm:
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::isPointInScrollbar):
- rendering/RenderFormElement.cpp:
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::horizontalScrollbarWidget): (WebCore::RenderLayer::verticalScrollbarWidget): (WebCore::RenderLayer::valueChanged): (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar): (WebCore::RenderLayer::positionScrollbars):
- rendering/RenderLayer.h:
- rendering/RenderWidget.h:
- 5:05 PM Changeset in webkit [15720] by
-
- 4 edits2 adds in trunk
LayoutTests:
Reviewed by John and Anders.
- Test for <rdar://problem/4380576> onChange does not get called when field changed by return key
- fast/forms/onchange-enter-submit-expected.txt: Added.
- fast/forms/onchange-enter-submit.html: Added.
WebCore:
Reviewed by John and Anders.
- Fix for <rdar://problem/4380576> onChange does not get called when field changed by return key
Test: fast/forms/onchange-enter-submit.html
Blur (which will fire onChange appropriately) before submitting a form when pressing Enter.
This matches the sequence of events fired in WinIE.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::defaultEventHandler):
- 4:55 PM Changeset in webkit [15719] by
-
- 2 edits in trunk/WebKit
Reviewed by John.
<rdar://problem/4658194> REGRESSION: "Search in Google"
and "Search in Spotlight" fail to work on text selected in a frame
Use selectedFrame to get the frame with the text selection.
- WebView/WebView.m: (-[WebView _searchWithGoogleFromMenu:]): (-[WebView _searchWithSpotlightFromMenu:]):
- 3:27 PM Changeset in webkit [15718] by
-
- 2 edits in trunk/WebCore
Reviewed by Kevin.
Moved string debug function outside of the WebCore namespace so that it's
easier to call in the debugger. I will never doubt Darin again (x100).
- platform/String.cpp: (string):
- 2:06 PM Changeset in webkit [15717] by
-
- 1 edit in trunk/WebCore/rendering/RenderLayer.cpp
Get rid of the -50000 nonsense on scrollbars when they're first added to overflow blocks.
- 1:59 PM Changeset in webkit [15716] by
-
- 2 edits in trunk/WebCore
Partial fix for 5453. Improve overflow so that when it changes
dynamically from scroll/auto to hidden that we properly hide the
scrollbars. Also refine the dirty dashboard region updating so that
it only happens if the scrollbars genuinely come and go.
Also eliminate the extra repaint of the entire block. This should not be
necessary, since the scrollbars repaint themselves already and children
will repaint already if they move.
Reviewed by darin
Adding test case from bug into fast/overflow/dynamic-hidden.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar): (WebCore::RenderLayer::updateScrollInfoAfterLayout):
- 1:58 PM Changeset in webkit [15715] by
-
- 4 adds in trunk/LayoutTests/fast/overflow
Add layout test for bug 5453.
- 12:49 PM Changeset in webkit [15714] by
-
- 5 edits4 adds in trunk
LayoutTests:
Reviewed by justin
<http://bugzilla.opendarwin.org/show_bug.cgi?id=9507>
Empty style spans created in applyInlineStyle
<rdar://problem/4515463>
REGRESSION: Blot and Mail both do a very poor job of pasting the main www.apple.com page
- editing/pasteboard/paste-4039777-fix-expected.txt:
- editing/pasteboard/testcase-9507-expected.checksum: Added.
- editing/pasteboard/testcase-9507-expected.png: Added.
- editing/pasteboard/testcase-9507-expected.txt: Added.
- editing/pasteboard/testcase-9507.html: Added.
- editing/unsupported-content/table-delete-001-expected.txt:
- editing/selection/selectNode-expected.png:
- editing/selection/selectNode-expected.checksum:
- editing/selection/selectNode-expected.txt:
WebCore:
Reviewed by justin
<http://bugzilla.opendarwin.org/show_bug.cgi?id=9507>
Empty style spans created in applyInlineStyle
Improves paste fidelity because some of these empty font/style spans had a non-zero
size and were messing up the layout of pasted content:
<rdar://problem/4515463>
REGRESSION: Blot and Mail both do a very poor job of pasting the main www.apple.com page
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle): Use the adjusted start node instead of start.node(). Don't do any application if the endpoints are swapped. Adjust endNode if the start node is a descendant of it, so that the pre-order traversal will terminate properly.
- 12:14 PM Changeset in webkit [15713] by
-
- 4 edits in trunk/WebKit
Reviewed by Tim Hatcher.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=10168 add a first cut at a Metrics pane to the inspector
- WebInspector/webInspector/inspector.css: Add styles for the new metrics pane.
- WebInspector/webInspector/inspector.html: Add the new metrics pane, starting with the table to show the box model.
- WebInspector/webInspector/inspector.js: Add the new metrics pane. Add back some "title" attributes so we have more tooltips. Removed the optional parameter to getComputedStyle.
- 11:44 AM Changeset in webkit [15712] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
- platform/String.cpp: (WebCore::string): Added a debugging function to create a String from a const char*.
- 11:21 AM Changeset in webkit [15711] by
-
- 1 edit in trunk/WebKit/ChangeLog
Update ChangeLog with bug link.
- 9:13 AM Changeset in webkit [15710] by
-
- 2 edits in trunk/WebKit
2006-07-31 Anders Carlsson <acarlsson@apple.com>
Reviewed by John.
- Plugins/WebPluginDatabase.m: (-[WebPluginDatabase refresh]): Create a mutable set instead of a mutable array.
- 8:43 AM Changeset in webkit [15709] by
-
- 2 edits in trunk/WebCore
2006-07-31 Anders Carlsson <acarlsson@apple.com>
- css/CSSPrimitiveValue.cpp: Fix windows build.
- 1:44 AM Changeset in webkit [15708] by
-
- 2 edits1 copy1 move1 delete in trunk/WebCore
Reinstating my last change. Everything builds now.
- 1:41 AM Changeset in webkit [15707] by
-
- 4 edits in trunk
LayoutTests:
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10167
Bug 10167: REGRESSION(r15688): ASSERTION FAILED: _private->mouseDownEvent != nil in layout tests
- fast/events/objc-event-api-expected.txt: Update test results.
WebKitTools:
Reviewed by Darin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10167
Bug 10167: REGRESSION(r15688): ASSERTION FAILED: _private->mouseDownEvent != nil in layout tests
- DumpRenderTree/EventSendingController.m: Don't set the mouse down flag in keyDown handler.
- 1:31 AM Changeset in webkit [15706] by
-
- 2 edits2 copies2 deletes in trunk/WebCore
Backing out my last change because it causes a build failure in some
configurations. This seems to be the cleanest way to get svn to cooperate.
- 12:26 AM Changeset in webkit [15705] by
-
- 3 edits2 deletes in trunk/LayoutTests
- editing/pasteboard/paste-table-002-expected.txt: Corrected one result affected by my recent change to getComputedStyle.
- editing/pasteboard/paste-table-002.html: Converted to a text test, since it dumps the serialized form of hte result.
- editing/pasteboard/paste-table-002-expected.checksum: Removed.
- editing/pasteboard/paste-table-002-expected.png: Removed.
- 12:17 AM Changeset in webkit [15704] by
-
- 2 edits1 copy1 move1 delete in trunk/WebCore
Reviewed by Maciej.
Moved files around to make WebCore's structure clearer
and easier to explain.
DerivedSources/JS* -> bindings/js/DerivedSources/ (so JS* files
show up when you search inside bindings/js/, but are marked, at
the same time, as files that you should not edit manually)
WebCore+SVG/DOMList.h -> ksvg2/svg/ (only files inside ksvg2/svg/
use DOMList.h)
icon -> loader/icon
I tested that everything still builds.
- 12:07 AM Changeset in webkit [15703] by
-
- 2 edits in trunk/WebKit
Reviewed by Tim Hatcher.
- WebInspector/webInspector/inspector.js: Fix bug where a null property value leads to an empty style pane.
Jul 30, 2006:
- 11:52 PM Changeset in webkit [15702] by
-
- 10 edits2 adds in trunk
LayoutTests:
- test that displays all computed style -- demonstrates bug fixes I just made to the computed style class and also acts as a regression test for the existence of all of them and the basic format for a default object
- fast/css/computed-style-expected.txt: Added.
- fast/css/computed-style.html: Added.
WebCore:
Reviewed by Tim Hatcher.
- some improvements for the benefit of the style pane of the inspector
- css/CSSComputedStyleDeclaration.cpp: Removed background-position and border-spacing from the list of properties that show up in computed style, because of background-position-x, background-position-y, -webkit-border-horizontal-spacing and -webkit-border-vertical-spacing. (WebCore::valueForLength): Added handling for undefinedLength, intrinsic, and min-intrinsic. (WebCore::primitiveValueFromLength): Removed code that would add a space to the string for no good reason. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added a special case for a line clamp of -1, which should come back as "none" rather than an actual "-1". (WebCore::CSSComputedStyleDeclaration::length): Return 0 if the declaration has no corresponding node or no renderer. (WebCore::CSSComputedStyleDeclaration::item): Check against length() so that the two stay consistent rather than using a constant.
- css/CSSPrimitiveValue.cpp: (WebCore::isCSSTokenizerIdentifier): Added. (WebCore::isCSSTokenizerURL): Added. (WebCore::quoteString): Added. (WebCore::quoteStringIfNeeded): Changed to quote strings in many more cases -- any cases where they would not parse in the CSS parser otherwise. The main case this affects is font names with spaces in them. (WebCore::quoteURLIfNeeded): Added. (WebCore::CSSPrimitiveValue::cssText): Use quoteURLIfNeeded in the case where we're making the text form of a URI.
- css/tokenizer.flex: Whitespace tweaks to line things up better.
WebKit:
Reviewed by Tim Hatcher.
- some improvements for the inspector
- WebInspector/WebInspector.m: (+sharedWebInspector:): Fixed bug that could cause the inspector to be garbage collected if used in an application with GC enabled. (-dealloc): Removed a call to a non-existent close method. (-window): Added a custom WebPreferences object and called setPrivateBrowsingEnabled:YES so the inspector won't appear in the history menu. Also call setProhibitsMainFrameScrolling:YES to try to get rid of trouble where the inspector scrolls when dragging.
- WebInspector/webInspector/inspector.css: Added style for the new color swatch, and JavaScript properties. More of the style should be shared between the panes, but this should be OK for now.
- WebInspector/webInspector/inspector.html: Added a first cut at a JavaScript properties pane. Needs work, but better than nothing.
- WebInspector/webInspector/inspector.js: Lots of improvements:
- Omit "typical" property values from computed style display, making it much shorter.
- Use the words "black", "white", and "transparent" when appropriate for color values.
- Refactored the loaded() function to get rid of repetitive scrollbar setup.
- Added a new scrollarea for the JavaScript properties pane.
- Simplified refreshScrollbars() -- we now refresh all scrollbars every time, which does no harm.
- Removed unused resultsWithXpathQuery().
- Use [] instead of "new Array()" and {} instead of "new Object()".
- Removed unused xpathForNode().
- Changed style pane to display the style for a text node's parent instead of saying it can't display the style for text.
- Fixed regression I caused a while back by checking the length of a computed style and not trying to display anything if its length is 0. Before this change and the corresponding change in WebCore, we'd see a complete list of all styles with the empty string as the value for each one.
- Changed the name of the computedStyle flag on the style rules array to isComputedStyle to make it easier to understand it's a boolean.
- Fixed an error in the code that does !important scanning where it was trying to do a special case for computed style, but was checking the computed style flag on the wrong object.
- Added populateStyleListItem() function to factor out things in common between the items in the top level list and the expanded tree for shorthand properties.
- Added code to make a color swatch next to the textual representation for any property that contains a color.
- Implemented a first cut at a simple JavaScript properties pane.
- 11:15 PM Changeset in webkit [15701] by
-
- 3 edits in trunk/WebKitTools
Reviewed by Maciej.
Bug 9686: [Drosera] Need the ability to break into Drosera on Javascript exceptions
http://bugzilla.opendarwin.org/show_bug.cgi?id=9686
- Drosera/DebuggerDocument.m: (-[WebScriptObject switchToServerNamed:]): Remove as listener before resuming to ensure that the server does not try and notify us of events related to the resumption. (-[WebScriptObject webView:exceptionWasRaised:sourceId:line:forWebFrame:]): Delegate call through to JavaScript.
- Drosera/debugger.js: Pause debugger when exception is raised.
- 4:02 PM Changeset in webkit [15700] by
-
- 3 edits in trunk/WebKitSite
Reviewed by Beth.
- Tweaked the checkout and build instructions to make them simpler and clearer.
- building/build.html:
- building/checkout.html:
