Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Oct 14, 2006:

5:31 PM Changeset in webkit [17061] by oliver

• 10 edits in trunk/WebCore

2006-10-15 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Oliver.

Implement some functions in FrameQt / ScrollViewQt.

Added comments what needs to be done in quite some places,
marked some functions as no-ops.

• CMakeLists.txt:
• platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt): (WebCore::FrameQt::runJavaScriptConfirm): (WebCore::FrameQt::locationbarVisible): (WebCore::FrameQt::createFrame): (WebCore::FrameQt::passSubframeEventToSubframe): (WebCore::FrameQt::menubarVisible): (WebCore::FrameQt::personalbarVisible): (WebCore::FrameQt::statusbarVisible): (WebCore::FrameQt::toolbarVisible): (WebCore::FrameQt::markedTextRange): (WebCore::FrameQt::lastEventIsMouseUp): (WebCore::FrameQt::openURLRequest): (WebCore::FrameQt::scheduleClose): (WebCore::FrameQt::unfocusWindow): (WebCore::FrameQt::focusWindow): (WebCore::FrameQt::overrideMediaType): (WebCore::FrameQt::runJavaScriptPrompt): (WebCore::FrameQt::bindingRootObject): (WebCore::FrameQt::addPluginRootObject): (WebCore::FrameQt::registerCommandForUndo): (WebCore::FrameQt::registerCommandForRedo): (WebCore::FrameQt::clearUndoRedoOperations): (WebCore::FrameQt::respondToChangedSelection): (WebCore::FrameQt::respondToChangedContents): (WebCore::FrameQt::shouldChangeSelection): (WebCore::FrameQt::canGoBackOrForward): (WebCore::FrameQt::canPaste): (WebCore::FrameQt::canRedo): (WebCore::FrameQt::canUndo):
• platform/qt/FrameQt.h:
• platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::runJavaScriptAlert): (WebCore::FrameQtClientDefault::runJavaScriptConfirm): (WebCore::FrameQtClientDefault::runJavaScriptPrompt): (WebCore::FrameQtClientDefault::menubarVisible): (WebCore::FrameQtClientDefault::toolbarVisible): (WebCore::FrameQtClientDefault::statusbarVisible): (WebCore::FrameQtClientDefault::personalbarVisible): (WebCore::FrameQtClientDefault::locationbarVisible):
• platform/qt/FrameQtClient.h:
• platform/qt/ImageSourceQt.cpp:
• platform/qt/RenderThemeQt.cpp:
• platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::scrollPointRecursively):
• platform/qt/TemporaryLinkStubs.cpp: (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData):

5:04 PM Changeset in webkit [17060] by oliver

• 2 edits in trunk/WebKitTools

2006-10-15 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Oliver.

Add another hanging test, to the "to be skipped" list.

• DumpRenderTree/DumpRenderTree.qtproj/tests-skipped.txt:

10:38 AM Changeset in webkit [17059] by harrison

• 2 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/4775213> REGRESSION: Can't from tab from last link on the page to URL address field
<rdar://problem/4783926> REGRESSION: Typing tab key enters no text

The problem is that EventTargetNode::defaultEventHandler() calls event->setDefaultHandled() regardless
of whether frame->view()->advanceFocus() actually changed the focus.

Trivial fix is to preventDefault() only if advanceFocus() returns true.

• No test is possible because DumpRenderTree sets the WebView preference to tab to links, and that preference cannot be changed dynamically after the webview is initialized. Also, the "tab from last link" is not testable because DumpRenderTree uses the WebView for the whole window, so tabs can't shift focus out of the WebView regardless.

• dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler):

10:21 AM Changeset in webkit [17058] by weinig

• 3 edits in trunk/WebKitTools

Reviewed by Anders.

Some fixes to get the Qt BuildSlave to run the LayoutTests.

• Scripts/build-dumprendertree: No need to call cmake again.
• Scripts/run-webkit-tests: Expose LD_LIBRARY_PATH.

5:53 AM Changeset in webkit [17057] by weinig

• 10 edits in trunk/WebCore

Reviewed by Mitz.

Fix Qt/Linux build & some little fixes:

• Adapt to Maciej's FrameLoadRequest changes.
• Fix response handling - don't try to compare with '0' - for us it's a non-ptr QString object.
• Actually call setAllData from loader/loader.cpp (David Carson forgot that in his last commit)
• Fix CacheObjectExpiresTime/ResponseIsMultipart signature.

• loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify):
• loader/CachedResource.h: (WebCore::CachedResource::CachedResource):
• loader/loader.cpp: (WebCore::Loader::receivedAllData): (WebCore::Loader::receivedResponse):
• platform/qt/BrowserExtensionQt.cpp: (WebCore::BrowserExtensionQt::createNewWindow):
• platform/qt/BrowserExtensionQt.h:
• platform/qt/FrameQt.cpp: (WebCore::FrameQt::submitForm): (WebCore::FrameQt::urlSelected): (WebCore::FrameQt::openURLRequest):
• platform/qt/FrameQt.h:
• platform/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::setURLForRect):
• platform/qt/TemporaryLinkStubs.cpp: (WebCore::CacheObjectExpiresTime): (WebCore::ResponseIsMultipart): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData):

2:42 AM Changeset in webkit [17056] by bdash

• 10 edits in trunk/WebCore

2006-10-14 David Carson <​dacarson@gmail.com>

Reviewed by Maciej.

Fix: ​http://bugs.webkit.org/show_bug.cgi?id=11257
Removed Mac platform dependance, changed WebCore functions to
use PlatformResponse/PlatformData rather than NSURLResponse/
NSData.

• loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify):
• loader/CachedImage.cpp: (WebCore::CachedImage::createImage):
• loader/CachedResource.cpp: (WebCore::CachedResource::~CachedResource):
• loader/CachedResource.h: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::response): (WebCore::CachedResource::allData):
• loader/LoaderFunctions.h:
• loader/loader.cpp: (WebCore::Loader::receivedResponse):
• loader/mac/LoaderFunctionsMac.mm: (WebCore::ResponseMIMEType): (WebCore::ResponseIsMultipart): (WebCore::CacheObjectExpiresTime): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData):
• platform/qt/TemporaryLinkStubs.cpp: (WebCore::CacheObjectExpiresTime): (WebCore::ResponseIsMultipart): (WebCore::ResponseMIMEType): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData):
• platform/win/TemporaryLinkStubs.cpp: (WebCore::CacheObjectExpiresTime): (WebCore::ResponseIsMultipart): (WebCore::ResponseMIMEType): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData):

2:39 AM Changeset in webkit [17055] by bdash

• 7 edits in trunk

2006-10-14 Krzysztof Kowalczyk <​kkowalczyk@gmail.com>

Reviewed by Maciej.

Define KXMLCORE_USE_CURL for platforms that wish to use CURL as
networking, and set it for GDK build

• wtf/Platform.h:

2006-10-14 Krzysztof Kowalczyk <​kkowalczyk@gmail.com>

Reviewed by Maciej.

Fix GDK build by defining FrameGdkClient() constructor as non-virtual.
Pure virtual classes require non-pure destructor, who knew.

Make CURL networking dependent on USE(CURL) instead of PLATFORM(GDK),
so that other platforms can also use CURL, if they wish.

Silence compiler warning about unused variable in SharedTimerLinux.cpp

• platform/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
• platform/gdk/FrameGdk.h: (WebCore::FrameGdkClient::~FrameGdkClient):
• platform/gdk/ResourceLoaderManager.cpp: (WebCore::ResourceLoaderManager::downloadTimerCallback):
• platform/gdk/SharedTimerLinux.cpp: (WebCore::stopSharedTimer):

Oct 13, 2006:

7:44 PM Changeset in webkit [17054] by bdakin

• 3 edits in trunk/WebCore

Reviewed by Geoff.

Build fix from my last check-in. Make hasOutlineAnnotation() non-
inline so that we don't have to include Document.h in
RenderObject.h
Doing so causes a build failure in WebKit, and it probably isn't a
good idea anyway.

• rendering/RenderObject.cpp: (WebCore::RenderObject::hasOutlineAnnotation):
• rendering/RenderObject.h: (WebCore::RenderObject::hasOutline):

6:37 PM Changeset in webkit [17053] by ggaren

• 3 edits
  2 adds in trunk/WebKitSite

Reviewed by Beth.

Split build, run, and debug steps into separate pages. Darin recommended
this a while back.

• building/build.html:
• building/checkout.html:
• building/debug.html: Added.
• building/run.html: Added.
• nav.inc:

6:12 PM Changeset in webkit [17052] by bdakin

• 12 edits in trunk/WebCore

Patch written mostly by Ken Kraisler, but also by me.

Reviewed by Hyatt.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=10216 and <rdar://
problem/3391162> PDF created by printing should have live
hyperlinks

• platform/GraphicsContext.cpp: (WebCore::GraphicsContext::focusRingBoundingRect):
• platform/GraphicsContext.h:
• platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::setURLForRect):
• platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setURLForRect): Implement method to add URL link to PDF document.
• rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint): Ask hasOutline() instead of querying the outline width
• rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject): Same as above.
• rendering/RenderFlow.cpp: (WebCore::RenderFlow::paintLines): Call the new paintOutline() (WebCore::RenderFlow::paintOutline): Take care of focus ring and pdf url rects, and outline painting.
• rendering/RenderFlow.h:
• rendering/RenderObject.cpp: (WebCore::RenderObject::addPDFURLRect): Declaration to apply a PDF link to a rectanglular region. (WebCore::RenderObject::paintOutline): Take care of pdf rects as well as focus ring painting.
• rendering/RenderObject.h: (WebCore::RenderObject::hasOutlineAnnotation): Returns true is the element is a link and we are printing. (WebCore::RenderObject::hasOutline): Returns true is the style has an outline and hasOutlineAnnotation() is true.
• rendering/RenderStyle.h: (WebCore::RenderStyle::hasOutline): Returns true if outlineWidth is greater than 0 and outlineStyle is greater than BHIDDEN.

4:58 PM Changeset in webkit [17051] by justing

• 3 edits
  2 adds in trunk

LayoutTests:

Reviewed by ggaren and harrison

<rdar://problem/4744008>
9A270: Mail crashes when I try to paste large items from Safari

• editing/pasteboard/4744008-expected.txt: Added.
• editing/pasteboard/4744008.html: Added.

WebCore:

Reviewed by ggaren and harrison

<rdar://problem/4744008>
9A270: Mail crashes when I try to paste large items from Safari

• editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Even though we put nodes in the hash map in pre-order, they don't necessary come out of the iterator that way. If a node is a redundant style span and one of its pruned ancestors comes off the hash map after it, and that ancestor is a redundant style span or font tag, we will try to remove it even though it has already been removed and we'll crash. The test case added with the fix depends on our hash map implementation because it requires that a particular redundant style span come out of the iterator before its parent. So, it may eventually not provide coverage for the fix.

4:56 PM Changeset in webkit [22364] by mjs

• 5 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

• split FrameLoadRequest off from ResourceRequest - it's a ResourceRequest plus frame name plus lockHistory bool

• WebCore.vcproj/WebCore.vcproj:
• bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): (WebCore::FrameWin::submitForm):
• bridge/win/FrameWin.h:
• platform/win/TemporaryLinkStubs.cpp: (BrowserExtensionWin::createNewWindow): (IconLoader::notifyIconChanged):

4:54 PM Changeset in webkit [17050] by mjs

• 12 edits
  1 add in trunk/WebCore

Reviewed by Darin.

• split FrameLoadRequest off from ResourceRequest - it's a ResourceRequest plus frame name plus lockHistory bool

• WebCore.xcodeproj/project.pbxproj:
• bindings/js/kjs_window.cpp: (KJS::createNewWindow): (KJS::WindowFunc::callAsFunction):
• bridge/BrowserExtension.h:
• bridge/mac/BrowserExtensionMac.h:
• bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
• bridge/mac/FrameMac.h:
• bridge/mac/FrameMac.mm: (WebCore::FrameMac::submitForm): (WebCore::FrameMac::openURLRequest): (WebCore::FrameMac::urlSelected):
• bridge/win/BrowserExtensionWin.h:
• page/Frame.cpp: (WebCore::Frame::changeLocation): (WebCore::Frame::urlSelected): (WebCore::Frame::requestFrame): (WebCore::Frame::submitForm):
• page/Frame.h:
• page/FrameLoadRequest.h: Added. (WebCore::FrameLoadRequest::FrameLoadRequest): (WebCore::FrameLoadRequest::lockHistory): (WebCore::FrameLoadRequest::setLockHistory):
• page/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest):

4:50 PM Changeset in webkit [17049] by sullivan

• 2 edits in trunk/WebCore

Reviewed by Maciej

• loader/mac/WebFrameLoader.mm: (-[WebFrameLoader loadDocumentLoader:]): Replace ASSERT(!policyDocumentLoader) with code that handles this case. This can happen when loading a page during a decidePolicyForNavigationAction callback.

4:45 PM Changeset in webkit [17048] by mjs

• 1 edit
  1 copy in trunk/WebKit

Not reviewed, build fix.

• icu/unicode/putil.h: Added - needed for build if you don't have apple internal headers.

4:16 PM Changeset in webkit [17047] by mjs

• 1 edit
  1 copy in trunk/WebKit

Not reviewed, build fix.

• icu/unicode/ustring.h: Added - needed for build if you don't have apple internal headers.

3:14 PM Changeset in webkit [22363] by hyatt

• 5 edits in branches/WindowsMerge/WebCore

Make form controls work in transparency layers.

3:12 PM Changeset in webkit [22362] by hyatt

• 2 edits in branches/WindowsMerge/WebKitWin

Make sure the backing store flushes properly when the theme changes.

3:09 PM Changeset in webkit [17046] by hyatt

• 4 edits in trunk/WebCore

Transparency layer work.

2:45 PM Changeset in webkit [17045] by spadma

• 2 edits in S60/trunk/WebKit

2006-10-13 zhalu <​zhaosong.lu@nokia.com>

Reviewed by Sachin.
DESC: Don't need to set the focus. The listbox itself will set the focus when receiving key event.
Otherwise, it will cause problem in input. Here is a little explaination: When the form data saving is enabled,
the CControlSelectWidget::FilterContentL is called whenever a 'letter' is committed.
The function calls the the listbox's setFocus(). This setFocus triggers a CommitInlineEditL action in
CAknFepManager. If users press the key in a normal speed, there is no problem because there is nothing
for committing. But if users press two keys(not two letters on the same key) very quickly, the second key
will be commited by the SetFocus() of the first key and the cursor in the editbox will move to the third
key position. The result is that it seems not letting you insert some key in the second position.

​http://bugs.webkit.org/show_bug.cgi?id=11192

• BrowserCore/Formcontrols/src/FControlSelectWidget.cpp: (CControlSelectWidget::FilterContentL):

2:42 PM Changeset in webkit [17044] by mjs

• 3 edits in trunk/WebKit

Reviewed by Anders.

• add a bunch of casts to get this compiling with older Xcode versions

(I used static_cast so it will be easier to find and remove these once we have completely moved
on to a new enough compiler version.)

• Plugins/WebBaseNetscapePluginView.m: (+[WebBaseNetscapePluginView getCarbonEvent:]): (-[WebBaseNetscapePluginView getCarbonEvent:withEvent:]): (-[WebBaseNetscapePluginView fixWindowPort]): (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebBaseNetscapePluginView _createWindowlessAGLContext]): (-[WebBaseNetscapePluginView _reshapeAGLWindow]): (-[WebBaseNetscapePluginView _aglOffscreenImageForDrawingInRect:]):
• WebKit.xcodeproj/project.pbxproj:

2:35 PM Changeset in webkit [17043] by brmorris

• 2 edits
  1 move in S60/trunk/S60WebUi

2006-10-13 brmorris <​thisisbradley@gmail.com>

Reviewed by Zalan.
DESC: Updates to reindeer sisx installation.
​http://bugs.webkit.org/show_bug.cgi?id=9435

• WebUi/install/Reindeer.pkg: Added.
• WebUi/install/WebUi.pkg: Removed.
• WebUi/install/buildsis.bat:

2:18 PM Changeset in webkit [17042] by spadma

• 7 edits in S60/trunk/WebKit

2006-10-13 sareen <​shyam.sareen@nokia.com>

Reviewed by (​Sachin.padma@nokia.com).
DESC: New Enum need to add for finding the whether the plugin

is interactive or not.

​http://bugs.webkit.org/show_bug.cgi?id=11281.

• Plugin/inc/PluginAdapterInterface.h: (MPluginAdapter::SetOptionMenuHandler):
• Plugin/inc/PluginSkin.h:
• Plugin/inc/PluginWin.h:
• Plugin/inc/npapi.h:
• Plugin/src/PluginSkin.cpp:
• Plugin/src/PluginWin.cpp: (CPluginWin::ConstructL): (CPluginWin::IsContentInteractive):

2:04 PM Changeset in webkit [17041] by rwlbuis

• 11 edits in trunk/WebCore

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style

Cleanup coding style in svg paint server classes.

1:22 PM Changeset in webkit [17040] by ggaren

• 10 edits
  4 adds in trunk

LayoutTests:

Tests for accessing renderer-dependent properties from a javascript: URL.

• fast/frames/frame-js-url-clientWidth-expected.txt: Added.
• fast/frames/frame-js-url-clientWidth.html: Added.
• fast/frames/iframe-js-url-clientWidth-expected.txt: Added.
• fast/frames/iframe-js-url-clientWidth.html: Added.

WebCore:

Reviewed by Darin, John.

• Merged more frame and iframe code
• Fixed a bug where iframes returned incorrect values for renderer-dependent properties during javascript: loads because they didn't have renderers at load time

PLT insists this is a small performance win. Don't believe its lies.

• bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::frameGetter): Renamed frameWidth and frameHeight to width and height, for consistency with the rest of the DOM.
• dom/ContainerNode.cpp: (WebCore::ContainerNode::queuePostAttachCallback): Added a post-attach callback queue that gets drained after the render tree is fully constructed. Currently, this is only used for frame loading. (WebCore::ContainerNode::attach):
• dom/ContainerNode.h:
• html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::insertedIntoDocument): Removed frame loading from attach() because loading iframes during attach() causes a crash. Moved frame loading logic into insertedIntoDocument(). That's a more logical place for it because document insertion is what triggers frame loading. Made frame loading a post-attach callback, instead of an immediate action, to fix the incorrect values bug. (WebCore::HTMLFrameElement::attach): Added setWidget call that used to be in HTMLIFrameElement::attach. IFRAME requires this call. FRAME will soon require this call, once I remove the call from WebKit. (WebCore::HTMLFrameElement::setLocation): (WebCore::HTMLFrameElement::width): (WebCore::HTMLFrameElement::height):
• html/HTMLFrameElement.h: Made openURL non-virtual to avoid the unnecessary killing of puppies.
• html/HTMLIFrameElement.cpp: Merged code into HTMLFrameElement (WebCore::HTMLIFrameElement::rendererIsNeeded): (WebCore::HTMLIFrameElement::createRenderer): (WebCore::HTMLIFrameElement::insertedIntoDocument): (WebCore::HTMLIFrameElement::removedFromDocument): (WebCore::HTMLIFrameElement::attach):
• page/FrameView.h: Removed unused method.

12:21 PM Changeset in webkit [17039] by rwlbuis

• 2 edits in trunk/WebKitTools

Reviewed by Eric.

Force --no-http on Qt/Linux.

12:10 PM Changeset in webkit [17038] by rwlbuis

• 1 add
  2 deletes in trunk/WebCore/platform/qt

Add PopupMenuQt.cpp, remove RenderPopupMenuQt.*, as per WildFox' request.

11:56 AM Changeset in webkit [17037] by kmccullo

• 4 edits in trunk/JavaScriptCore

Reviewed by Kevin McCullough.

Fixes ​http://bugs.webkit.org/show_bug.cgi?id=11283
Fixes Qt/Linux and Windows build

• kjs/DateMath.cpp:
• kjs/DateMath.h:
• kjs/date_object.cpp: (KJS::DateProtoFunc::callAsFunction):

11:17 AM Changeset in webkit [17036] by harrison

• 12 edits
  4 adds in trunk

LayoutTests:

Reviewed by Justin.

<rdar://problem/4746860> Mail crash in WebCore::CSSMutableStyleDeclaration::merge(WebCore::CSSMutableStyleDeclaration*, bool)

• editing/style/style-boundary-005.html: Added. Matches steps from bug.
• editing/execCommand/hilitecolor-expected.txt: Updated (no empty Apple style spans).
• editing/style/remove-underline-across-paragraph-in-bold-expected.txt: Updated (no empty Apple style spans).
• editing/style/remove-underline-in-bold-expected.txt: Updated (no empty Apple style spans).
• editing/style/typing-style-003-expected.txt: Updated (no empty Apple style spans).

WebCore:

Reviewed by Justin.

<rdar://problem/4746860> Mail crash in WebCore::CSSMutableStyleDeclaration::merge(WebCore::CSSMutableStyleDeclaration*, bool)

Tests added or changed:

• editing/style/style-boundary-005.html: Added. Matches steps from bug.
• editing/execCommand/hilitecolor-expected.txt: Updated (no empty Apple style spans).
• editing/style/remove-underline-across-paragraph-in-bold-expected.txt: Updated (no empty Apple style spans).
• editing/style/remove-underline-in-bold-expected.txt: Updated (no empty Apple style spans).
• editing/style/typing-style-003-expected.txt: Updated (no empty Apple style spans).

• dom/Text.cpp: (WebCore::Text::splitText): Comment changes.

• editing/ApplyStyleCommand.cpp: (WebCore::isUnstyledStyleSpan): Renamed from isEmptyStyleSpan.

(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
Rename emptySpans local to unstyledSpans.

(WebCore::dummySpanAncestorForNode):
New. To locate Apple style span created when splitting a text node.

(WebCore::ApplyStyleCommand::cleanupUnstyledAppleStyleSpans):
Renamed from cleanUpEmptyStyleSpans. Algorithm changed to scan children
of dummy span's parents, rather than traversing up from start and
end locations. Old algorithm would miss empty spans in the bug case.

(WebCore::ApplyStyleCommand::applyInlineStyle):
Use dummySpanAncestorForNode() and cleanupUnstyledAppleStyleSpans().

(WebCore::ApplyStyleCommand::removeCSSStyle):
Renamed isEmptyStyleSpan() to isUnstyledStyleSpan().

(WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
Comment changes.

• editing/ApplyStyleCommand.h: Renamed cleanUpEmptyStyleSpans() to cleanupUnstyledAppleStyleSpans().

• editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Allow for Apple style span to be unstyled, because old email may have this in the DOM. Use !node->hasChildNodes() instead of !node->firstChild().

• editing/SplitTextNodeCommand.cpp: (WebCore::SplitTextNodeCommand::doApply): Comment changes.

• rendering/RenderTreeAsText.cpp: (WebCore::isEmptyOrUnstyledAppleStyleSpan): (WebCore::operator<<): Flag empty or unstyled AppleStyleSpa nbecause we never want to leave them in the DOM

11:14 AM Changeset in webkit [17035] by rwlbuis

• 1 add in trunk/WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/tests-skipped.txt

Adding a file that should have gone in in r17021, as requested by WildFox.

11:08 AM Changeset in webkit [17034] by adele

• 6 edits in trunk/WebCore

Reviewed by Eric.

Fix Qt/Linux build after Adele's popup menu changes.

• CMakeLists.txt:
• platform/qt/FileChooserQt.cpp: (WebCore::FileChooser::disconnectUploadControl):
• platform/qt/PopupMenuQt.cpp: Added. (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::clear): (WebCore::PopupMenu::populate): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::addSeparator): (WebCore::PopupMenu::addGroupLabel): (WebCore::PopupMenu::addOption):
• platform/qt/RenderPopupMenuQt.cpp: Removed.
• platform/qt/RenderPopupMenuQt.h: Removed.
• platform/qt/RenderThemeQt.cpp:

10:57 AM Changeset in webkit [17033] by kmccullo

• 3 edits in trunk/WebKitTools

Reviewed by Adam.

Gets JavaScripCore tests running on windows.

• Scripts/run-javascriptcore-tests:
• Scripts/webkitdirs.pm:

10:48 AM Changeset in webkit [17032] by kmccullo

• 3 edits in trunk/WebCore

Reviewed by Darin.

fixed build failure

• WebCore.xcodeproj/project.pbxproj:
• loader/mac/WebFrameLoader.mm:

10:31 AM Changeset in webkit [17031] by kmccullo

• 5 edits in trunk/JavaScriptCore

Reviewed by Adam, Geoff, Darin.

Fixed displaying the UTC offset and time zone string, as well as renamed the GregorianDateTime structure and clean up.

• ChangeLog:
• kjs/DateMath.cpp: (KJS::getUTCOffset): (KJS::getDSTOffsetSimple): (KJS::gregorianDateTimeToMS): (KJS::msToGregorianDateTime):
• kjs/DateMath.h: (KJS::GregorianDateTime::GregorianDateTime): (KJS::GregorianDateTime::~GregorianDateTime): (KJS::GregorianDateTime::toTM):
• kjs/date_object.cpp: (KJS::gmtoffset): (KJS::formatDate): (KJS::formatDateUTCVariant): (KJS::formatTime): (KJS::fillStructuresUsingTimeArgs): (KJS::fillStructuresUsingDateArgs): (KJS::DateInstance::getTime): (KJS::DateInstance::getUTCTime): (KJS::DateProtoFunc::callAsFunction): (KJS::DateObjectImp::construct): (KJS::DateObjectImp::callAsFunction): (KJS::DateObjectFuncImp::callAsFunction): (KJS::parseDate):
• kjs/date_object.h:

10:22 AM Changeset in webkit [17030] by kmccullo

• 2 edits in trunk/WebKit

Changed by Darin, reviewed by me.

• Plugins/WebNetscapePluginStream.m: Fixed case of import so we can compile on case-sensitive file system.

10:07 AM Changeset in webkit [17029] by darin

• 14 edits
  1 copy
  1 add in trunk

WebCore:

Reviewed by Adele.

• converted WebFormState from Objective-C to C++

• WebCore.exp: Added a new symbol, changed one symbol from C to C++.

• WebCore.xcodeproj/project.pbxproj: Made lots of headers "private" instead of "project". Added UChar.h and FrameLoaderTypes.h.

• loader/FrameLoaderTypes.h: Added. Has enums from WebFrameLoader.h.

• loader/mac/WebFormState.h: Converted class to C++.
• loader/mac/WebFormState.mm: Ditto.

• loader/mac/WebFrameLoader.h:
• loader/mac/WebFrameLoader.mm: (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrameLoader invalidatePendingPolicyDecisionCallingDefaultAction:]): (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]): (-[WebFrameLoader continueAfterNewWindowPolicy:]): (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]): (-[WebFrameLoader continueAfterNavigationPolicy:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]): (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): Changed Objective-C WebFormState uses to C++ WebCore::FormState.

WebKit:

Reviewed by Adele.

• converted WebFormState from Objective-C to C++

• ForwardingHeaders: Added an entire copy of WebCore's forwarding headers here. We should eventually come up with a more-elegant solution.

• WebKit.xcodeproj/project.pbxproj: Added ForwardingHeaders to the include paths. Converted many files from Objective-C to Objective-C++. In a later check-in, I'll rename them to .mm instead of .m. Removed C-only warning options for now. In a later check-in I will add these back in a way that omits them for C++.

• Plugins/WebPluginContainerCheck.m: Updated for header changes.

• WebView/WebFrameInternal.h: Updated for header changes. Removed WebFrameLoaderClient category so this file can still be used by Objective-C code (not just Objective-C++).

• WebView/WebFrame.m: Put WebFrameLoaderClient category in here. (-[WebFrame _loadItem:withLoadType:]): Changed to use 0 instead of nil for FormState and fixed enum code for C++ compatibility. (-[WebFrame _initWithWebFrameView:webView:bridge:]): Added call to setFrameLoaderClient: here. (-[WebFrame _updateHistoryForCommit]): Fixed enum code for C++ compatibility. (-[WebFrame _updateHistoryForReload]): Ditto.

• WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): Removed call to setFrameLoaderClient:. (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): Ditto. (-[WebFrameBridge _retrieveKeyboardUIModeFromPreferences:]): Fixed enum code for C++ compatibility. (-[WebFrameBridge runModal]): Changed code to not use "namespace" as a local variable name.

• WebView/WebPDFView.m: Added extern "C" so this can compile as Objective-C++.

7:36 AM Changeset in webkit [17028] by adele

• 5 edits in trunk/WebCore

Reviewed by Maciej.

• Fix for <rdar://problem/4768591> REGRESSION: List box selection color should just be a darker version of regular selection color

• rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground):
• rendering/RenderTheme.cpp: (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor): (WebCore::RenderTheme::activeListBoxSelectionForegroundColor): (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor): (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
• rendering/RenderThemeMac.h:
• rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::activeListBoxSelectionBackgroundColor):

5:56 AM Changeset in webkit [17027] by rwlbuis

• 23 edits in trunk/WebCore

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style

Cleanup coding style in svg structure classes.

Oct 12, 2006:

11:33 PM Changeset in webkit [17026] by adele

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by Anders.

• Test for ​http://bugs.webkit.org/show_bug.cgi?id=11172 REGRESSION (NativeListBox): OPTION text paints over the edge of the select element at ​http://jobs.apple.com/

• fast/forms/listbox-width-change-expected.txt: Added.
• fast/forms/listbox-width-change-expected.png: Added.
• fast/forms/listbox-width-change-expected.checksum: Added.
• fast/forms/listbox-width-change.html: Added.

WebCore:

Reviewed by Anders.

• Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11172 REGRESSION (NativeListBox): OPTION text paints over the edge of the select element at ​http://jobs.apple.com/

Test: fast/forms/listbox-width-change.html

• rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement): When the options change, call setNeedsLayoutAndMinMaxRecalc.

10:52 PM Changeset in webkit [22361] by hyatt

• 10 edits
  2 deletes in branches/WindowsMerge/WebCore

Vote Cairo off the island.

10:49 PM Changeset in webkit [22360] by hyatt

• 1 edit in branches/WindowsMerge/WebKitWin/WebFrame.cpp

Remove Cairo files from WebFrame.cpp now that the Cairo paint method is gone.

10:22 PM Changeset in webkit [17025] by mjs

• 10 edits
  2 adds in trunk

WebCore:

Reviewed by Oliver.

• moved a bunch of WebFrameBridge code down to WebCoreFrameBridge, now that it no longer has any WebKit dependencies

• WebCore.xcodeproj/project.pbxproj:
• bridge/mac/WebCoreFrameBridge.h:
• bridge/mac/WebCoreFrameBridge.mm: (stringByCollapsingNonPrintingCharacters): (-[WebCoreFrameBridge setTitle:]): (-[WebCoreFrameBridge didFirstLayout]): (-[WebCoreFrameBridge notifyIconChanged:]): (-[WebCoreFrameBridge originalRequestURL]): (-[WebCoreFrameBridge isLoadTypeReload]): (-[WebCoreFrameBridge frameDetached]): (-[WebCoreFrameBridge tokenizerProcessedData]): (-[WebCoreFrameBridge receivedData:textEncodingName:]): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]): (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebCoreFrameBridge reportClientRedirectCancelled:]): (-[WebCoreFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): (-[WebCoreFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebCoreFrameBridge incomingReferrer]): (-[WebCoreFrameBridge isReloading]): (-[WebCoreFrameBridge handledOnloadEvents]): (-[WebCoreFrameBridge mainResourceURLResponse]): (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):
• loader/mac/LoaderNSURLExtras.h:
• loader/mac/LoaderNSURLRequestExtras.h: Added.
• loader/mac/LoaderNSURLRequestExtras.m: Added. (isConditionalRequest): (setHTTPReferrer):
• loader/mac/WebFrameLoader.mm:
• loader/mac/WebSubresourceLoader.mm:

WebKit:

Reviewed by Oliver.

• liberate more WebKit code down to WebCore

• WebCoreSupport/WebFrameBridge.h:
• WebCoreSupport/WebFrameBridge.m:

8:53 PM Changeset in webkit [22359] by hyatt

• 2 edits in branches/WindowsMerge/WebKitWin

Add code that will delete the backing store if our window gets hidden. (We are dependent on the app to make sure we get the message.)

7:29 PM Changeset in webkit [22358] by adele

• 2 edits in branches/WindowsMerge/WebCore

RS by Geoff.

Renamed uploadControlDetaching to disconnectUploadControl.

• platform/win/FileChooserWin.cpp: (WebCore::FileChooser::disconnectUploadControl):

7:28 PM Changeset in webkit [17024] by adele

• 7 edits in trunk/WebCore

RS by Geoff.

Renamed menuListIsDetaching to disconnectMenuList,
uploadControlDetaching to disconnectUploadControl, and fileChooserDetachingSoon to disconnectFileChooser.
These names match similar methods in WebCore a little better.

• platform/FileChooser.h:
• platform/PopupMenu.h: (WebCore::PopupMenu::disconnectMenuList):
• platform/mac/FileChooserMac.mm: (-[OpenPanelController disconnectFileChooser]): (WebCore::FileChooser::disconnectUploadControl):
• platform/win/TemporaryLinkStubs.cpp: (FileChooser::disconnectUploadControl):
• rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
• rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList):

7:13 PM Changeset in webkit [17023] by adele

• 9 edits in trunk

WebCore:

Reviewed by Maciej.

WebCore part of fix for <rdar://problem/4450613> need a means to attach user data to any menu that is popuped up in HTML

Added private delegate method for clients that want access to a PopupMenu's NSMenu.

• bridge/mac/FrameMac.h:
• bridge/mac/FrameMac.mm: (WebCore::FrameMac::willPopupMenu):
• bridge/mac/WebCoreFrameBridge.h:

• platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Calls willPopupMenu with the NSMenu about to be popped up.

WebKit:

Reviewed by Maciej.

WebKit part of fix for <rdar://problem/4450613> need a means to attach user data to any menu that is popuped up in HTML

Added private delegate method for clients that want access to a PopupMenu's NSMenu.

• DefaultDelegates/WebDefaultUIDelegate.m: (-[NSApplication webView:willPopupMenu:]):
• WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge willPopupMenu:]):
• WebView/WebUIDelegatePrivate.h:

6:39 PM Changeset in webkit [17022] by adele

• 4 edits in trunk/WebCore

Reviewed by Alice.

• Fix for <rdar://problem/4707372> After timers fix, crash in -[NSMenu performActionForItemAtIndex:] after moving/detroying active popup menu

• platform/PopupMenu.h: (WebCore::PopupMenu::menuListIsDetaching): Added. Zeros out the pointer to the menu list.
• rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList): Calls menuListIsDetaching.
• platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Added a RefPtr to protect the PopupMenu while the NSMenu is up, in case the RenderMenuList goes away. Also, checks the pointer to the menu list immediately afterwards.

6:33 PM Changeset in webkit [17021] by bdash

• 3 edits in trunk/WebKitTools

2006-10-12 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Maciej.

Exclude some tests which crash or hang from Qt/Linux DRT.
These are known to fail, and will be fixed at some point :-)

• DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::open): (WebCore::DumpRenderTree::readStdin): (WebCore::DumpRenderTree::readSkipFile): (WebCore::DumpRenderTree::checkLoaded):
• DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
• DumpRenderTree/DumpRenderTree.qtproj/tests-skipped.txt: Added.

6:31 PM Changeset in webkit [17020] by bdash

• 3 edits in trunk/WebCore

2006-10-12 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Maciej.

Trying to fix "DRT hangs on certain testcases" like fast/dom/Document/document-reopen.html
document.open(); document.write(..); and NO document.close(). On the Qt platform this
leaves a HTMLDocument which is still in parsing mode (parsing() always returns true).
DRT waits forever, but m_frame->isComplete() is never true due the parsing mode problem.

Hmpf, this took me nine hours to debug today.
Result: Couldn't find the real fix, going for a workaround for now.

540 minutes, 1 line of code changed after all -> 0,0019 lines per minute.

• platform/qt/FrameQt.cpp: (WebCore::FrameQt::handledOnloadEvents): Call endIfNotLoading() manually.
• platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::receivedData): Use write() again instead of addData().

6:27 PM Changeset in webkit [22357] by adele

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Alice.

Fixed a small oversight from the last checkin. The populate method was calling itself,
instead of the newly renamed addItems method.

• platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::populate):

4:04 PM Changeset in webkit [22356] by aroben

• 3 edits
  1 move
  1 delete in branches/WindowsMerge/WebCore

Reviewed by Adele.

Move popup menu code out of rendering/ and into platform/.
RenderPopupMenu becomes PopupMenu, the
RenderPopupMenuMac/RenderPopupMenuWin subclasses and all the associated
virtual methods go away, RenderTheme gets to stop worrying about popup
menus, PopupMenu becomes ref-counted, and everyone becomes happy.

• WebCore.vcproj/WebCore.vcproj: Move files within project.
• platform/win/PopupMenuWin.cpp: Moved from rendering/RenderPopupMenuWin.cpp. Rename RenderPopupMenuWin to PopupMenu. (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::clear): (WebCore::PopupMenu::populate): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::setPositionAndSize): (WebCore::PopupMenu::addOption): (WebCore::PopupMenu::focusedIndex): New method to get the index of the element that is currently highlighted. This won't always be the same as the selectedIndex because of mouse hot-tracking. (WebCore::PopupMenu::down): (WebCore::PopupMenu::up): (WebCore::registerPopup): (WebCore::PopupWndProc): Use focusedIndex() instead of sending messages to the popup window.
• platform/win/TemporaryLinkStubs.cpp: Rename RenderPopupMenuWin to PopupMenu. (PopupMenu::addSeparator): (PopupMenu::addGroupLabel):
• rendering/RenderPopupMenuWin.cpp: Removed.
• rendering/RenderPopupMenuWin.h: Removed.
• rendering/RenderThemeWin.cpp: Get rid of createPopupMenu() method.
• rendering/RenderThemeWin.h: Ditto.

4:02 PM Changeset in webkit [17019] by aroben

• 13 edits
  3 moves
  2 deletes in trunk/WebCore

Reviewed by Adele.

Move popup menu code out of rendering/ and into platform/.
RenderPopupMenu becomes PopupMenu, the
RenderPopupMenuMac/RenderPopupMenuWin subclasses and all the associated
virtual methods go away, RenderTheme gets to stop worrying about popup
menus, PopupMenu becomes ref-counted, and everyone becomes happy.

• WebCore.vcproj/WebCore/WebCore.vcproj: Move files within project.
• WebCore.xcodeproj/project.pbxproj: Ditto.
• html/HTMLSelectElement.cpp: Remove unnecessary #include.
• platform/PopupMenu.cpp: Moved from rendering/RenderPopupMenu.cpp. Also renamed showPopup()/hidePopup() to show()/hide() to disambiguate from RenderMenuList::showPopup/hidePopup. (WebCore::PopupMenu::create): New static creation method to hand back a PassRefPtr<PopupMenu>. (WebCore::PopupMenu::addItems): This platform-independent method should be called by PopupMenu::populate when the platform-specific implementation is ready to receive the menu items. Fixed an ASSERT while I was at it.
• platform/PopupMenu.h: Moved from rendering/RenderPopupMenu.h. No more need for virtual methods. (WebCore::PopupMenu::wasClicked): (WebCore::PopupMenu::setWasClicked): (WebCore::PopupMenu::popupHandle):
• platform/mac/PopupMenuMac.mm: Moved from rendering/RenderPopupMenuMac.mm. Much renaming ensues. (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::clear): (WebCore::PopupMenu::populate): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::addSeparator): (WebCore::PopupMenu::addGroupLabel): Since we don't have our own RenderStyle anymore, just pick up the style from our RenderMenuList. (WebCore::PopupMenu::addOption): Ditto.
• platform/win/TemporaryLinkStubs.cpp: Rename-fest. (PopupMenu::PopupMenu): (PopupMenu::~PopupMenu): (PopupMenu::clear): (PopupMenu::populate): (PopupMenu::show): (PopupMenu::hide): (PopupMenu::addSeparator): (PopupMenu::addGroupLabel): (PopupMenu::addOption):
• rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList): (WebCore::RenderMenuList::showPopup): Use nice new simple PopupMenu::create to make the popup. (WebCore::RenderMenuList::hidePopup):
• rendering/RenderMenuList.h: Hold a RefPtr<PopupMenu> instead of a RenderPopupMenu*. (WebCore::RenderMenuList::popup):
• rendering/RenderPopupMenu.cpp: Removed.
• rendering/RenderPopupMenu.h: Removed.
• rendering/RenderPopupMenuMac.h: Removed.
• rendering/RenderPopupMenuMac.mm: Removed.
• rendering/RenderPopupMenuWin.h: Removed.
• rendering/RenderTheme.cpp: Get rid of createPopupMenu() method.
• rendering/RenderTheme.h: Ditto.
• rendering/RenderThemeMac.h: Ditto.
• rendering/RenderThemeMac.mm: Ditto.
• rendering/RenderThemeWin.cpp: Ditto.
• rendering/RenderThemeWin.h: Ditto.

2:44 PM Changeset in webkit [17018] by adele

• 2 edits in trunk/WebCore

Reviewed by Dave Harrison.

• Fixed <rdar://problem/4650813> REGRESSION: typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)

• rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): Make subtree layouts work for textareas as well as text fields.

1:42 PM Changeset in webkit [17017] by ggaren

• 7 edits in trunk/JavaScriptCore

Reviewed by Maciej.

Removed JSObjectMakeWithPrototype, clarified some comments. We really
don't want people to manage their own prototypes, so we don't want an
extra function in the API devoted to just that. People can still manage
their own prototypes if they really want by using JSObjectSetPrototype.

• API/JSClassRef.cpp: (OpaqueJSClass::createNoAutomaticPrototype): (OpaqueJSClass::create):
• API/JSClassRef.h:
• API/JSObjectRef.cpp: (JSClassCreate): (JSObjectMake):
• API/JSObjectRef.h:
• API/testapi.c: (main):
• JavaScriptCore.exp:

1:29 PM Changeset in webkit [17016] by rwlbuis

• 9 edits in trunk/WebCore

Reviewed by MacDome.

Finally found a way to remove our begin() trickery in FrameQt.
The (probably misnamed) Frame::setEncoding() function automatically
calls Frame::receivedFirstData() which calls being on the working
url, which has been passed to didOpenUrl(). Took me some hours
to figure out that the missing charset logic, forced us to do hacks.

1:19 PM Changeset in webkit [17015] by kmccullo

• 3 edits in trunk/JavaScriptCore

Reviewed by Adam.

Build breakage fix

• kjs/DateMath.cpp: (KJS::msToTM):
• kjs/date_object.cpp: (KJS::gmtoffset):

12:49 PM Changeset in webkit [17014] by brmorris

• 2 edits in S60/trunk

2006-10-12 brmorris <​thisisbradley@gmail.com>

Reviewed by Bradley.
DESC: Replace winscw MemMan.dll with MemMan_sdk.dll if ! -e MemMan.dll

12:22 PM Changeset in webkit [17013] by aroben

• 2 edits in trunk/WebCore

Reviewed by Hyatt.

Bandaid-ing a null-dereference crash until a real fix is made.

• page/FrameView.cpp: (WebCore::FrameView::windowClipRect):

11:46 AM Changeset in webkit [17012] by brmorris

• 4 edits in S60/trunk

2006-10-12 brmorris <​thisisbradley@gmail.com>

Reviewed by Zalan.
DESC: Generate/check only the correct WebKit icons depending on build flavour
​http://bugs.webkit.org/show_bug.cgi?id=11266

• group/icons.mk: Work off BROWSER_SDK evar to check/create correct icons.

11:34 AM Changeset in webkit [17011] by aroben

• 2 edits in trunk/WebKit

2006-10-12 MorganL <​morganl.webkit@yahoo.com>

Reviewed/landed by Adam.

Fixes ​http://bugs.webkit.org/show_bug.cgi?id=11264
Windows build busted

• COM/WebFrame.cpp: (WebFrame::receivedResponse):

10:58 AM Changeset in webkit [17010] by kmccullo

• 5 edits in trunk/JavaScriptCore

Reviewed by Geoff.

Added our own tm struct to have a consistent set of fields, which lets us display the DST offset and timezone strings correctly. Also there is some code cleanup.

• kjs/DateMath.cpp: (KJS::timeToMS): (KJS::getUTCOffset): (KJS::getDSTOffsetSimple): (KJS::dateToMS): (KJS::msToTM): (KJS::tmToKJStm): (KJS::KJStmToTm):
• kjs/DateMath.h:
• kjs/date_object.cpp: (KJS::gmtoffset): (KJS::formatTime): (KJS::DateProtoFunc::callAsFunction): (KJS::DateObjectImp::construct): (KJS::DateObjectImp::callAsFunction): (KJS::DateObjectFuncImp::callAsFunction): (KJS::parseDate):
• kjs/date_object.h:

10:10 AM Changeset in webkit [22355] by aroben

• 2 edits in branches/WindowsMerge/WebKitWin

Build fix (broken by OpenSource r17006)

• WebFrame.cpp: (WebFrame::receivedResponse):

10:04 AM Changeset in webkit [17009] by brmorris

• 9 edits
  3 adds in S60/trunk

2006-10-12 brmorris <​thisisbradley@gmail.com>

Reviewed by Zalan.
DESC: Fixes for GCCE compilation.
​http://bugs.webkit.org/show_bug.cgi?id=9435

8:07 AM Changeset in webkit [17008] by rwlbuis

• 11 edits in trunk/WebCore

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style

Cleanup coding style in svg text classes.

5:44 AM Changeset in webkit [17007] by rwlbuis

• 7 edits in trunk

WebCore:

Reviewed by Maciej.

Specialization of alert() for DumpRenderTree - just log the output, don't show any message box.

WebKitTools:

Reviewed by Maciej.

Specialization of alert() for DumpRenderTree - just log the output, don't show any message box.

4:50 AM Changeset in webkit [17006] by mjs

• 9 edits in trunk/WebCore

Reviewed by Eric.

• move m_responseMIMEType out of ResourceRequest, where it doesn't belong

• page/FramePrivate.h: Add m_responseMIMEType
• page/ResourceRequest.h: Remove m_responseMIMEType
• page/Frame.cpp: (WebCore::Frame::setResponseMIMEType): added (WebCore::Frame::responseMIMEType): added (WebCore::Frame::begin): get MIME type from the right place (WebCore::Frame::write): ditto
• page/Frame.h:
• bindings/js/kjs_window.cpp: (KJS::createNewWindow): updated to use new Frame methods (KJS::WindowFunc::callAsFunction): ditto
• bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): ditto (-[WebCoreFrameBridge canProvideDocumentSource]): ditto
• loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure): ditto

3:36 AM Changeset in webkit [17005] by mjs

• 2 edits in trunk/WebCore

Reviewed by Eric.

<rdar://problem/4774321> REGRESSION: "Can't find the server" error page contains unstyled text and missing image

We really need some way to test loadHTMLString since it keeps breaking!

• loader/mac/WebFrameLoader.mm: (-[WebFrameLoader commitProvisionalLoad:]): Set stuff up on the proper data source.

3:22 AM Changeset in webkit [17004] by rwlbuis

• 3 edits in trunk/WebCore

Reviewed by Eric.

Fix Qt/Linux build.

2:36 AM Changeset in webkit [17003] by bdash

• 6 edits in trunk

2006-10-12 Krzysztof Kowalczyk <​kkowalczyk@gmail.com>

Reviewed by Maciej.

Update Gdk\Linux build for recent changes, based on Qt code

• platform/gdk/FrameGdk.cpp: (WebCore::FrameGdkClientDefault::FrameGdkClientDefault): (WebCore::FrameGdkClientDefault::~FrameGdkClientDefault): (WebCore::FrameGdkClientDefault::setFrame): (WebCore::FrameGdkClientDefault::openURL): (WebCore::FrameGdkClientDefault::submitForm): (WebCore::FrameGdkClientDefault::receivedResponse): (WebCore::FrameGdkClientDefault::receivedData): (WebCore::FrameGdkClientDefault::receivedAllData): (WebCore::FrameGdk::FrameGdk): (WebCore::FrameGdk::openURL): (WebCore::FrameGdk::submitForm): (WebCore::FrameGdk::urlSelected):
• platform/gdk/FrameGdk.h:
• platform/gdk/TemporaryLinkStubs.cpp: (FrameGdk::createJavaAppletWidget): (FileChooser::create):

2006-10-12 Krzysztof Kowalczyk <​kkowalczyk@gmail.com>

Reviewed by Maciej.

Also regenerate GdkLauncher makefiles, since not doing that might
lead to mismatch between WebCore and GdkLauncher compiler settings.

• Scripts/regenerate-makefiles:

2:03 AM Changeset in webkit [22354] by hyatt

• 12 edits in branches/WindowsMerge

Implement full-blown double buffering.

2:01 AM Changeset in webkit [17002] by hyatt

• 13 edits in trunk/WebCore

Add more clipping retrieval functionality for widgets.

Oct 11, 2006:

6:44 PM Changeset in webkit [17001] by zbujtas

• 3 edits in S60/trunk/WebKit

2006-10-11 brmorris <​thisisbradley@gmail.com>

Reviewed by zalan
DESC: send reindeer UA String
​http://bugs.webkit.org/show_bug.cgi?id=9189

• BrowserView/inc/WebKitLoader.h: Update static ua string to 3.1
• ResourceLoader/src/HttpTransaction.cpp: (CHttpTransaction::AddRequestHeadersL): Return static ua string if BROWSER_SDK

5:54 PM Changeset in webkit [17000] by darin

• 11 edits in trunk/WebKit

Reviewed by Adele.

• preparations for making more code C++

• WebKitPrefix.h: Fixed ifdef so that C++ files get all the precompiled stuff that non-C++ files get.

• Misc/WebKitLogging.h:
• Misc/WebKitSystemBits.h:
• Misc/WebLocalizableStrings.h:
• WebCoreSupport/WebSystemInterface.h: Added extern "C".

• Misc/WebNSViewExtras.h:
• WebView/WebDataSource.m: (addTypesFromClass):
• WebView/WebFrameView.m: (addTypesFromClass): Eliminated use of the identifier "class".

• WebView/WebView.m: (-[WebView _goToItem:withLoadType:]): Added a type cast.

• Plugins/WebBaseNetscapePluginView.m: Added lots of type casts.

5:40 PM Changeset in webkit [16999] by darin

• 14 edits in trunk/WebCore

Reviewed by John.

• some changes to prepare for converting more code to C++

• bridge/mac/WebCoreFrameBridge.h: Added import of <Cocoa/Cocoa.h> so this header is self-sufficient.

• bridge/mac/WebCoreViewFactory.h: Added forward declaration of the NSMenu class. Needed since the class is used in this header (for some work I have not landed yet).

• loader/mac/LoaderNSURLExtras.h:
• loader/mac/WebFormDataStream.h: Added extern "C" so this code can be used from C++.

• loader/mac/LoaderNSURLExtras.m:
• loader/mac/WebDataProtocol.mm:
• loader/mac/WebDocumentLoader.mm:
• loader/mac/WebFormDataStream.m:
• loader/mac/WebLoader.mm:
• loader/mac/WebMainResourceLoader.mm:
• loader/mac/WebNetscapePlugInStreamLoader.mm:
• loader/mac/WebPolicyDecider.mm:
• loader/mac/WebSubresourceLoader.mm: Added missing includes of config.h.

4:18 PM Changeset in webkit [16998] by darin

• 2 edits in trunk/WebKitLibraries

Reviewed by John Sullivan.

• WebKitSystemInterface.h: Updated to a C++-compatible version.

4:15 PM Changeset in webkit [16997] by sullivan

• 4 edits in trunk/WebCore

Darin wrote this code; we tested it; I give it the thumbs up.

• fixed regression from svn revision 16982 that was generating the wrong Obj-C classes

The hash table to look up an element class given a QualifiedName was
not working at all.

• dom/QualifiedName.h: (WebCore::QualifiedName::impl): Added. This new accessor method for impl is needed if we want to use a QualifiedName as a hash table key without doing the kind of specialization we do for String. Maybe later we can do the String thing.

• bindings/objc/DOM.mm: (WebCore::addElementClass): Use QualifiedName.impl instead of the QualifiedName pointer itself. The QualifiedName pointer is *not* unique so almost nothing would be found in this hash table! (WebCore::elementClass): ditto

2:09 PM Changeset in webkit [16996] by aroben

• 3 edits in trunk/WebCore

Rubberstamped by Anders.

Clean up FileChooser::create and Icon::newIconForFile.

• WebCore.xcodeproj/project.pbxproj:
• platform/mac/FileChooserMac.mm: (WebCore::FileChooser::create):
• platform/mac/IconMac.mm: (WebCore::Icon::newIconForFile):

1:39 PM Changeset in webkit [16995] by kmccullo

• 1 edit
  3 adds in trunk/LayoutTests

Reviewed by Darin.

These test DST behavior on the cusp of a change (i.e. spring forward, fall back)

• fast/js/date-DST-time-cusps-expected.txt: Added.
• fast/js/date-DST-time-cusps.html: Added.
• fast/js/resources/date-DST-time-cusps.js: Added.

11:45 AM Changeset in webkit [16994] by oliver

• 3 edits in trunk/LayoutTests

2006-10-11 Oliver Hunt <​oliver@apple.com>

Reviewed by Brady.

Fix svg text related layout tests

• svg/custom/getsvgdocument-expected.txt:
• svg/hixie/viewbox/003-expected.txt:

11:27 AM Changeset in webkit [16993] by oliver

• 3 edits
  4 adds in trunk

2006-10-11 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11251
Corrects canvas tag to not throw JS exception when drawing
zero sized rects, arcs, etc

• html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::arcTo): (WebCore::CanvasRenderingContext2D::arc): (WebCore::CanvasRenderingContext2D::rect): (WebCore::CanvasRenderingContext2D::clearRect): (WebCore::CanvasRenderingContext2D::fillRect): (WebCore::CanvasRenderingContext2D::strokeRect):

Reviewed by Geoff.

Test case for ​http://bugs.webkit.org/show_bug.cgi?id=11251

• fast/canvas/zero-size-fill-rect-expected.checksum: Added.
• fast/canvas/zero-size-fill-rect-expected.png: Added.
• fast/canvas/zero-size-fill-rect-expected.txt: Added.
• fast/canvas/zero-size-fill-rect.html: Added.

11:26 AM Changeset in webkit [16992] by brmorris

• 1 edit
  7 adds in S60/trunk/S60Internals

Reviewed by Bradley Morrison.
DESC: some support files for GCCE and RVCT compilations
​http://bugs.webkit.org/show_bug.cgi?id=9435

• target/GCCE/SDKGCCEPatch.zip: Added.
• target/RVCT/S60LibsRVCT.zip: Added.
• target/RVCT/S60RVCTPatch.zip: Added.
• target/RVCT/rvct2_2.h: Added. (std::):

11:19 AM Changeset in webkit [16991] by rwlbuis

• 3 edits
  2 adds in trunk

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=11221
REGRESSION: iExploder crash due to style="cursor: url()"

Take better care of empty cursor lists.

Test: fast/css/invalid-cursor-property-crash.html

10:56 AM Changeset in webkit [16990] by aroben

• 2 edits in trunk/WebCore

Fixing Windows for real this time.

• platform/win/TemporaryLinkStubs.cpp: (FileChooser::create):

10:30 AM Changeset in webkit [16989] by aroben

• 2 edits in trunk/WebCore

Fix Windows build.

• platform/win/TemporaryLinkStubs.cpp: (FileChooser::create):

10:14 AM Changeset in webkit [22353] by aroben

• 2 edits in branches/WindowsMerge/WebCore

Rubberstamped by Brady.

Clean up logic in Icon::newIconForFile.

• platform/win/IconWin.cpp: (WebCore::Icon::newIconForFile): Error case should return early.

10:08 AM Changeset in webkit [22352] by aroben

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Steve.

Fixes <rdar://problem/4777719>
Icons don't paint with CG

• platform/win/IconWin.cpp: (WebCore::Icon::paint): Remove Cairo-specific code now that we have GraphicsContextWin.

9:54 AM Changeset in webkit [22351] by aroben

• 3 edits in branches/WindowsMerge/WebCore

Rubberstamped by Anders.

Clean up FileChooser::create, Icon::create.

• platform/win/FileChooserWin.cpp: (WebCore::FileChooser::create): Just return a FileChooser* and let the implicit cast happen.
• platform/win/IconWin.cpp: (WebCore::Icon::newIconForFile): Ditto for Icon*.

8:04 AM Changeset in webkit [16988] by antti

• 6 edits
  4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=4377

• fast/layers/layer-visibility-expected.checksum: Added.
• fast/layers/layer-visibility-expected.png: Added.
• fast/layers/layer-visibility-expected.txt: Added.
• fast/layers/layer-visibility.html: Added.

WebCore:

Reviewed by Hyatt.

​http://bugs.webkit.org/show_bug.cgi?id=4377

Respect css visibility semantics for layers too

• rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode): (WebCore::RenderContainer::appendChildNode): (WebCore::RenderContainer::insertChildNode):
• rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::setHasVisibleContent): (WebCore::RenderLayer::dirtyVisibleContentStatus): (WebCore::RenderLayer::childVisibilityChanged): (WebCore::RenderLayer::dirtyVisibleDescendantStatus): (WebCore::RenderLayer::updateVisibilityStatus): (WebCore::RenderLayer::addChild): (WebCore::RenderLayer::removeChild): (WebCore::RenderLayer::updateZOrderLists): (WebCore::RenderLayer::collectLayers):
• rendering/RenderLayer.h: (WebCore::RenderLayer::hasVisibleContent):
• rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle):

12:15 AM Changeset in webkit [16987] by mjs

• 3 edits
  1 add in trunk/WebCore

Reviewed by Oliver.

• added RetainPtr, smart pointer for refcounted ObjC objects and CFTypes

• WebCore.xcodeproj/project.pbxproj:
• platform/cf/RetainPtr.h: Added. (WTF::): (WTF::RetainPtr::RetainPtr): (WTF::RetainPtr::~RetainPtr): (WTF::RetainPtr::get): (WTF::RetainPtr::operator*): (WTF::RetainPtr::operator->): (WTF::RetainPtr::operator!): (WTF::RetainPtr::operator UnspecifiedBoolType): (WTF::::operator): (WTF::::swap): (WTF::swap): (WTF::operator==): (WTF::operator!=): (WTF::static_pointer_cast): (WTF::const_pointer_cast): (WTF::getPtr):

• use it in WidgetMac so it gets tested in at least one place

• platform/mac/WidgetMac.mm: (WebCore::Widget::Widget): (WebCore::Widget::~Widget): (WebCore::Widget::setEnabled): (WebCore::Widget::isEnabled): (WebCore::Widget::setCursor): (WebCore::Widget::getView): (WebCore::Widget::setView): (WebCore::Widget::getOuterView):

Oct 10, 2006:

11:35 PM Changeset in webkit [16986] by beidson

• 8 edits in trunk

WebCore:

Reviewed by Maciej.

Moved WebFrameLoader from WebFrameBridge into WebCoreFrameBridge

• bridge/mac/WebCoreFrameBridge.h:
• bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge initMainFrameWithPage:]): (-[WebCoreFrameBridge initSubframeWithOwnerElement:]): (-[WebCoreFrameBridge dealloc]): (-[WebCoreFrameBridge close]): (-[WebCoreFrameBridge setFrameLoaderClient:]): (-[WebCoreFrameBridge frameLoader]):
• loader/mac/WebFrameLoader.h:
• loader/mac/WebFrameLoader.mm: (-[WebFrameLoader initWithFrameBridge:]): (-[WebFrameLoader setFrameLoaderClient:]):

WebKit:

Reviewed by Maciej.

Moved WebFrameLoader into WebCoreFrameBridge

• WebCoreSupport/WebFrameBridge.h:
• WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): (-[WebFrameBridge dealloc]): (-[WebFrameBridge setTitle:]): (-[WebFrameBridge receivedData:textEncodingName:]): (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]): (-[WebFrameBridge objectLoadedFromCacheWithURL:response:data:]): (-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebFrameBridge reportClientRedirectCancelled:]): (-[WebFrameBridge close]): (-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): (-[WebFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrameBridge tokenizerProcessedData]): (-[WebFrameBridge frameDetached]): (-[WebFrameBridge didFirstLayout]): (-[WebFrameBridge notifyIconChanged:]): (-[WebFrameBridge originalRequestURL]): (-[WebFrameBridge isLoadTypeReload]):

9:39 PM Changeset in webkit [16985] by thatcher

• 2 edits in trunk/WebKitTools

Reviewed by Tim H.

Bug 11246: Minor Drosera code cleanup
​http://bugs.webkit.org/show_bug.cgi?id=11246

• Drosera/debugger.js: Change [has, add, remove]StyleClass to be a function on Element rather than taking an Element as an argument.

9:35 PM Changeset in webkit [16984] by thatcher

• 7 edits
  5 adds in trunk/WebKitTools

Reviewed by Tim H.

Bug 9778: ​http://bugs.webkit.org/show_bug.cgi?id=9778

• ChangeLog:
• Drosera/Drosera.xcodeproj/project.pbxproj: Added files
• Drosera/English.lproj/Debugger.nib/info.nib: Resized the main window and WebView
• Drosera/English.lproj/Debugger.nib/keyedobjects.nib: Resized the main window and WebView
• Drosera/Images/SourceArrowOpen.png: Added.
• Drosera/Images/fileIcon.jpg: Added.
• Drosera/Images/siteCollapsed.tif: Added.
• Drosera/Images/siteExpanded.tif: Added.
• Drosera/Images/siteIcon.tif: Added.
• Drosera/debugger.css: Added File Browser styles
• Drosera/debugger.html: Added File Browser UI
• Drosera/debugger.js: Added File Browser functionality

9:35 PM Changeset in webkit [22350] by aroben

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Fixes <rdar://problem/4731316>
Crash when <input type="file"> element removed while file chooser is open

• platform/win/FileChooserWin.cpp: Make FileChooser ref-counted. (WebCore::FileChooser::create): (WebCore::FileChooser::openFileChooser): Add a protector RefPtr around the call to GetOpenFileName so we don't get deleted while the file chooser window is open.

9:33 PM Changeset in webkit [16983] by aroben

• 5 edits in trunk/WebCore

Reviewed by Oliver.

Make FileChooser ref-counted.

• platform/FileChooser.h:
• platform/mac/FileChooserMac.mm: (WebCore::FileChooser::create):
• rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::RenderFileUploadControl): (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
• rendering/RenderFileUploadControl.h:

8:46 PM Changeset in webkit [16982] by weinig

• 22 edits
  1 delete in trunk/WebCore

Reviewed by Tim H.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=11248
Even More auto-generated Objective-C DOM bindings changes

• Auto-generate DOMSVGPathElement.

• Auto-generate the internal interfaces even for classes that have custom internal implementations. Change IDL property from ObjCNoInternal to ObjCCustomInternalImpl to indicate the change.

• Add SVG classes to DOMNode and DOMEvent internal interfaces.

• Add isSVGZoomEvent() method to Event class to match other Event subclasses and make DOM binding possible.

• Assorted cleanups.

• DerivedSources.make:
• WebCore.xcodeproj/project.pbxproj:
• bindings/objc/DOM.mm: (WebCore::addElementClass): (WebCore::createElementClassMap): (WebCore::elementClass): (-[DOMNode description]): (+[DOMNode _nodeWith:WebCore::]): (-[DOMNode addEventListener:listener:useCapture:]): (-[DOMNode removeEventListener:listener:useCapture:]): (-[DOMElement _NPObject]): (WebCore::ObjCEventListener::handleEvent):
• bindings/objc/DOMEvents.mm: (+[DOMEvent _eventWith:WebCore::]):
• bindings/objc/DOMInternal.h:
• bindings/objc/DOMRGBColor.mm: (-[DOMRGBColor WebCore::]):
• bindings/objc/DOMSVGPathSegInternal.h: Removed.
• bindings/scripts/CodeGeneratorObjC.pm:
• css/CSSRule.idl:
• css/CSSValue.idl:
• css/StyleSheet.idl:
• dom/Event.cpp: (WebCore::Event::isSVGZoomEvent):
• dom/Event.h:
• dom/Event.idl:
• dom/Node.idl:
• ksvg2/events/SVGZoomEvent.cpp: (WebCore::SVGZoomEvent::isSVGZoomEvent):
• ksvg2/events/SVGZoomEvent.h:
• ksvg2/svg/SVGAnimatedAngle.idl:
• ksvg2/svg/SVGCircleElement.idl:
• ksvg2/svg/SVGClipPathElement.idl:
• ksvg2/svg/SVGPathElement.idl:
• ksvg2/svg/SVGPathSeg.idl:

8:41 PM Changeset in webkit [22349] by aroben

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Anders.

Fixes <rdar://problem/4772428>
<select> popup menus positioned incorrectly within frames

• rendering/RenderPopupMenuWin.cpp: (WebCore::RenderPopupMenuWin::setPositionAndSize): Use contentsToWindow() instead of scrollOffset() to correct menu location.

7:29 PM Changeset in webkit [22348] by sfalken

• 2 edits in branches/WindowsMerge/WebKitWin

2006-10-10 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.

<rdar://4775676>
Crash in CoreFoundation parsing a "corrupt" plist

Prevent crash when we encounter a corrupt history plist by using
structured exception handling to catch the crash and return
an empty history list.

• WebHistory.cpp: (WebHistory::loadHistoryGutsFromURL):

7:22 PM Changeset in webkit [16981] by oliver

• 2 edits in trunk/WebCore

2006-10-10 Oliver Hunt <​oliver@apple.com>

rubber stamped by Anders.

More buildbot bustage

• kcanvas/SVGInlineFlowBox.cpp: (WebCore::placeBoxesVerticallyWithAbsBaseline):

7:12 PM Changeset in webkit [16980] by oliver

• 4 edits in trunk/WebCore

2006-10-10 Oliver Hunt <​oliver@apple.com>

Reviewed by Anders

Unbreak build bots

• dom/Text.cpp:
• kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::layout):
• kcanvas/SVGInlineFlowBox.cpp: (WebCore::placePositionedBoxesHorizontally): (WebCore::placeBoxesVerticallyWithAbsBaseline):

6:28 PM Changeset in webkit [16979] by oliver

• 9 edits
  10 adds in trunk/WebCore

2006-10-10 Oliver Hunt <set EMAIL_ADDRESS environment variable>

Reviewed by hyatt.

Fixes bugs #6423, #6559, #10380 and #10839

• WebCore.xcodeproj/project.pbxproj:
• css/svg.css:
• dom/Text.cpp: (WebCore::Text::createRenderer):
• kcanvas/RenderSVGInline.cpp: Added. (WebCore::RenderSVGInline::RenderSVGInline): (WebCore::RenderSVGInline::createInlineBox):
• kcanvas/RenderSVGInline.h: Added. (WebCore::RenderSVGInline::renderName): (WebCore::RenderSVGInline::requiresLayer):
• kcanvas/RenderSVGInlineText.cpp: Added. (WebCore::RenderSVGInlineText::RenderSVGInlineText): (WebCore::RenderSVGInlineText::absoluteRects): (WebCore::RenderSVGInlineText::selectionRect):
• kcanvas/RenderSVGInlineText.h: Added. (WebCore::RenderSVGInlineText::renderName): (WebCore::RenderSVGInlineText::requiresLayer):
• kcanvas/RenderSVGTSpan.cpp: Added. (WebCore::RenderSVGTSpan::RenderSVGTSpan): (WebCore::RenderSVGTSpan::absoluteRects):
• kcanvas/RenderSVGTSpan.h: Added. (WebCore::RenderSVGTSpan::renderName):
• kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::RenderSVGText): (WebCore::RenderSVGText::computeAbsoluteRepaintRect): (WebCore::RenderSVGText::layout): (WebCore::RenderSVGText::createInlineBox): (WebCore::RenderSVGText::nodeAtPoint): (WebCore::RenderSVGText::absoluteRects): (WebCore::RenderSVGText::paint): (WebCore::RenderSVGText::relativeBBox):
• kcanvas/RenderSVGText.h: (WebCore::RenderSVGText::renderName):
• kcanvas/SVGInlineFlowBox.cpp: Added. (WebCore::SVGInlineFlowBox::paint): (WebCore::SVGInlineFlowBox::placeBoxesHorizontally): (WebCore::SVGInlineFlowBox::verticallyAlignBoxes): (WebCore::paintSVGInlineFlow): (WebCore::translateBox): (WebCore::placePositionedBoxesHorizontally): (WebCore::placeSVGFlowHorizontally): (WebCore::placeBoxesVerticallyWithAbsBaseline): (WebCore::placeSVGFlowVertically):
• kcanvas/SVGInlineFlowBox.h: Added. (WebCore::SVGInlineFlowBox::SVGInlineFlowBox):
• kcanvas/SVGRootInlineBox.cpp: Added. (WebCore::SVGRootInlineBox::paint): (WebCore::SVGRootInlineBox::placeBoxesHorizontally): (WebCore::SVGRootInlineBox::verticallyAlignBoxes):
• kcanvas/SVGRootInlineBox.h: Added. (WebCore::SVGRootInlineBox::SVGRootInlineBox):
• ksvg2/svg/SVGTRefElement.cpp: (SVGTRefElement::createRenderer):
• ksvg2/svg/SVGTSpanElement.cpp: (SVGTSpanElement::createRenderer):
• rendering/InlineFlowBox.h:

6:26 PM Changeset in webkit [16978] by oliver

• 271 edits in trunk/LayoutTests

2006-10-10 Oliver Hunt <​ohunt@apple.com>

Rubber stamped by Anders.

Updated to deal with new svg text renderers, and
updated result.

custom/text-clip testcase was incorrect, and has been fixed

• svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-08-t-expected.checksum:
• svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
• svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-12-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-22-b-expected.checksum:
• svg/W3C-SVG-1.1/animate-elem-22-b-expected.png:
• svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-27-t-expected.checksum:
• svg/W3C-SVG-1.1/animate-elem-27-t-expected.png:
• svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt:
• svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
• svg/W3C-SVG-1.1/color-prof-01-f-expected.txt:
• svg/W3C-SVG-1.1/color-prop-01-b-expected.txt:
• svg/W3C-SVG-1.1/color-prop-02-f-expected.txt:
• svg/W3C-SVG-1.1/color-prop-03-t-expected.txt:
• svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
• svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt:
• svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt:
• svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt:
• svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt:
• svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt:
• svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
• svg/W3C-SVG-1.1/coords-units-02-b-expected.txt:
• svg/W3C-SVG-1.1/coords-units-03-b-expected.txt:
• svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
• svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
• svg/W3C-SVG-1.1/extend-namespace-01-f-expected.checksum:
• svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png:
• svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt:
• svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
• svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
• svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
• svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
• svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
• svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
• svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
• svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
• svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
• svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum:
• svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
• svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
• svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
• svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum:
• svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
• svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
• svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
• svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
• svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
• svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
• svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
• svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
• svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
• svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
• svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
• svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
• svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
• svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
• svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
• svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
• svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
• svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
• svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
• svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
• svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
• svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
• svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
• svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
• svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
• svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
• svg/W3C-SVG-1.1/filters-tile-01-b-expected.checksum:
• svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
• svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
• svg/W3C-SVG-1.1/filters-turb-01-f-expected.checksum:
• svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
• svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
• svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
• svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
• svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
• svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
• svg/W3C-SVG-1.1/interact-cursor-01-f-expected.checksum:
• svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png:
• svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
• svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt:
• svg/W3C-SVG-1.1/interact-events-01-b-expected.txt:
• svg/W3C-SVG-1.1/interact-order-01-b-expected.txt:
• svg/W3C-SVG-1.1/interact-order-02-b-expected.txt:
• svg/W3C-SVG-1.1/interact-order-03-b-expected.txt:
• svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt:
• svg/W3C-SVG-1.1/linking-a-01-b-expected.txt:
• svg/W3C-SVG-1.1/linking-a-02-b-expected.txt:
• svg/W3C-SVG-1.1/linking-a-03-b-expected.txt:
• svg/W3C-SVG-1.1/linking-a-04-t-expected.txt:
• svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
• svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
• svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt:
• svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
• svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt:
• svg/W3C-SVG-1.1/masking-path-01-b-expected.txt:
• svg/W3C-SVG-1.1/masking-path-02-b-expected.txt:
• svg/W3C-SVG-1.1/masking-path-03-b-expected.txt:
• svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
• svg/W3C-SVG-1.1/masking-path-05-f-expected.txt:
• svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
• svg/W3C-SVG-1.1/painting-fill-01-t-expected.txt:
• svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt:
• svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt:
• svg/W3C-SVG-1.1/painting-fill-04-t-expected.txt:
• svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
• svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
• svg/W3C-SVG-1.1/painting-render-01-b-expected.checksum:
• svg/W3C-SVG-1.1/painting-render-01-b-expected.png:
• svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
• svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt:
• svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt:
• svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt:
• svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt:
• svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
• svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
• svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
• svg/W3C-SVG-1.1/paths-data-04-t-expected.txt:
• svg/W3C-SVG-1.1/paths-data-05-t-expected.txt:
• svg/W3C-SVG-1.1/paths-data-06-t-expected.txt:
• svg/W3C-SVG-1.1/paths-data-07-t-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
• svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
• svg/W3C-SVG-1.1/render-elems-01-t-expected.txt:
• svg/W3C-SVG-1.1/render-elems-02-t-expected.txt:
• svg/W3C-SVG-1.1/render-elems-03-t-expected.txt:
• svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
• svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
• svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
• svg/W3C-SVG-1.1/render-groups-01-b-expected.checksum:
• svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
• svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
• svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
• svg/W3C-SVG-1.1/script-handle-01-b-expected.txt:
• svg/W3C-SVG-1.1/script-handle-02-b-expected.txt:
• svg/W3C-SVG-1.1/script-handle-03-b-expected.txt:
• svg/W3C-SVG-1.1/script-handle-04-b-expected.txt:
• svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt:
• svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt:
• svg/W3C-SVG-1.1/shapes-line-01-t-expected.txt:
• svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt:
• svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt:
• svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt:
• svg/W3C-SVG-1.1/struct-cond-01-t-expected.txt:
• svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt:
• svg/W3C-SVG-1.1/struct-defs-01-t-expected.txt:
• svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt:
• svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt:
• svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt:
• svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt:
• svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt:
• svg/W3C-SVG-1.1/struct-dom-06-b-expected.txt:
• svg/W3C-SVG-1.1/struct-group-01-t-expected.txt:
• svg/W3C-SVG-1.1/struct-group-02-b-expected.txt:
• svg/W3C-SVG-1.1/struct-image-01-t-expected.txt:
• svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
• svg/W3C-SVG-1.1/struct-image-03-t-expected.txt:
• svg/W3C-SVG-1.1/struct-image-04-t-expected.txt:
• svg/W3C-SVG-1.1/struct-image-05-b-expected.txt:
• svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
• svg/W3C-SVG-1.1/styling-css-01-b-expected.txt:
• svg/W3C-SVG-1.1/styling-css-02-b-expected.txt:
• svg/W3C-SVG-1.1/styling-css-03-b-expected.txt:
• svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
• svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt:
• svg/W3C-SVG-1.1/text-align-01-b-expected.checksum:
• svg/W3C-SVG-1.1/text-align-01-b-expected.png:
• svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
• svg/W3C-SVG-1.1/text-align-02-b-expected.checksum:
• svg/W3C-SVG-1.1/text-align-02-b-expected.png:
• svg/W3C-SVG-1.1/text-align-02-b-expected.txt:
• svg/W3C-SVG-1.1/text-align-03-b-expected.checksum:
• svg/W3C-SVG-1.1/text-align-03-b-expected.png:
• svg/W3C-SVG-1.1/text-align-03-b-expected.txt:
• svg/W3C-SVG-1.1/text-align-04-b-expected.checksum:
• svg/W3C-SVG-1.1/text-align-04-b-expected.png:
• svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
• svg/W3C-SVG-1.1/text-align-05-b-expected.checksum:
• svg/W3C-SVG-1.1/text-align-05-b-expected.png:
• svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
• svg/W3C-SVG-1.1/text-align-06-b-expected.checksum:
• svg/W3C-SVG-1.1/text-align-06-b-expected.png:
• svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
• svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
• svg/W3C-SVG-1.1/text-deco-01-b-expected.checksum:
• svg/W3C-SVG-1.1/text-deco-01-b-expected.png:
• svg/W3C-SVG-1.1/text-deco-01-b-expected.txt:
• svg/W3C-SVG-1.1/text-fonts-01-t-expected.checksum:
• svg/W3C-SVG-1.1/text-fonts-01-t-expected.png:
• svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
• svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt:
• svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
• svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt:
• svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
• svg/W3C-SVG-1.1/text-text-03-b-expected.txt:
• svg/W3C-SVG-1.1/text-tref-01-b-expected.txt:
• svg/W3C-SVG-1.1/text-tselect-01-b-expected.checksum:
• svg/W3C-SVG-1.1/text-tselect-01-b-expected.png:
• svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt:
• svg/W3C-SVG-1.1/text-tspan-01-b-expected.checksum:
• svg/W3C-SVG-1.1/text-tspan-01-b-expected.png:
• svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
• svg/W3C-SVG-1.1/text-ws-01-t-expected.txt:
• svg/W3C-SVG-1.1/text-ws-02-t-expected.txt:
• svg/custom/baseval-animval-equality-expected.checksum:
• svg/custom/baseval-animval-equality-expected.png:
• svg/custom/coords-relative-units-transforms-expected.checksum:
• svg/custom/coords-relative-units-transforms-expected.png:
• svg/custom/coords-relative-units-transforms-expected.txt:
• svg/custom/createelement-expected.txt:
• svg/custom/feComponentTransfer-Discrete-expected.txt:
• svg/custom/feComponentTransfer-Gamma-expected.txt:
• svg/custom/feComponentTransfer-Linear-expected.txt:
• svg/custom/feComponentTransfer-Table-expected.txt:
• svg/custom/foreign-object-skew-expected.txt:
• svg/custom/gradient-stroke-width-expected.txt:
• svg/custom/image-with-transform-clip-filter-expected.txt:
• svg/custom/invalid-css-expected.txt:
• svg/custom/invalid-fill-expected.txt:
• svg/custom/invalid-viewbox1-expected.txt:
• svg/custom/invalid-viewbox2-expected.txt:
• svg/custom/junk-data-expected.txt:
• svg/custom/marker-overflow-clip-expected.txt:
• svg/custom/missing-xlink-expected.txt:
• svg/custom/non-opaque-filters-expected.txt:
• svg/custom/pointer-events-path-expected.txt:
• svg/custom/svg-overflow-types-expected.txt:

text-clip was an incorrect test, rather than an incorrect result

• svg/custom/text-clip-expected.txt:
• svg/custom/text-clip.svg:
• svg/custom/text-filter-expected.txt:
• svg/custom/text-gradient-no-content-expected.txt:
• svg/custom/text-hit-test-expected.txt:
• svg/custom/text-image-opacity-expected.txt:
• svg/custom/tref-update-expected.txt:

3:04 PM Changeset in webkit [22347] by aroben

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adele.

Fixes <rdar://problem/4763246>
Using arrow keys in <select> popup fires onChange event

Also updates text shown in <select> element on page when using arrow
keys to change selection within the popup menu, and makes onChange fire
in the same cases as Firefox/IE.

• rendering/RenderPopupMenuWin.cpp: (WebCore::RenderPopupMenuWin::down): Update text of the <select> control. Change call to valueChanged() so that onChange doesn't fire. (WebCore::RenderPopupMenuWin::up): Ditto. (WebCore::PopupWndProc): Don't fire onChange anytime selection changes. Fire onChange when pressing Enter

2:57 PM Changeset in webkit [16977] by aroben

• 5 edits in trunk/WebCore

Reviewed by Adele.

Improve popup menu behavior.

• html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::HTMLSelectElement): Cache m_lastOnChangeIndex so we know when to fire onChange. (WebCore::HTMLSelectElement::setSelectedIndex): Added parameter to specify whether we should fire onChange. (WebCore::HTMLSelectElement::dispatchBlurEvent): Fire onChange on blur. (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Fire onChange when using the Enter key to change the selection.
• html/HTMLSelectElement.h:
• rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement): Extract setText logic into its own method. (WebCore::RenderMenuList::setTextFromOption): New method. (WebCore::RenderMenuList::valueChanged): Let setSelectedIndex call onChange instead of calling it directly here.
• rendering/RenderMenuList.h:

2:28 PM Changeset in webkit [16976] by zbujtas

• 2 edits in S60/trunk/WebCore

2006-10-10 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan Bujtas
DESC: On ActivateEvent, clear the "don't submit form twice" data member.
​http://bugs.webkit.org/show_bug.cgi?id=11242

WARNING: NO TEST CASES ADDED OR CHANGED

• kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::activateNodeAtPoint):

2:18 PM Changeset in webkit [16975] by adele

• 15 edits in trunk

WebCore:

Reviewed by Beth.

• Fix for <rdar://problem/4707489> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active <input type=text> and <rdar://problem/4707519> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active textarea

Moved autoscroll code to the Frame class

• bridge/mac/FrameMac.h: Moved _mouseDownMayStartDrag and _mouseDownMayStartAutoscroll flags to the frame.
• bridge/mac/FrameMac.mm: Use new getters and setters for drag and autoscroll flags. Moved autoscroll code to Frame::handleMouseMoveEvent. (WebCore::FrameMac::FrameMac): (WebCore::FrameMac::handleMousePressEvent): (WebCore::FrameMac::eventMayStartDrag): (WebCore::FrameMac::handleMouseMoveEvent): (WebCore::FrameMac::mouseDown):

• bridge/mac/WebCoreFrameBridge.h: Removed handleAutoscrollForMouseDragged, which called over the bridge for AppKit to do autoscroll for us. Now we scroll our views in WebCore.

• page/Frame.cpp: (WebCore::Frame::handleMousePressEvent): Initialize the mouseDownMayStartAutoscroll flag. (WebCore::Frame::handleMouseMoveEvent): Now kicks off autoscroll if appropriate. Moved from FrameMac. (WebCore::Frame::updateSelectionForMouseDragOverPosition): Factored code out from handleMouseMoveEvent so we can update the selection from autoscroll too. (WebCore::Frame::mouseDownMayStartAutoscroll): Added. (WebCore::Frame::setMouseDownMayStartAutoscroll): Added. (WebCore::Frame::mouseDownMayStartDrag): Added. (WebCore::Frame::setMouseDownMayStartDrag): Added. (WebCore::Frame::autoscrollRenderer): Added (WebCore::Frame::setAutoscrollRenderer): Added. (WebCore::Frame::handleAutoscroll): Updated to use autoscrollRenderer getter and setter. (WebCore::Frame::autoscrollTimerFired): ditto. (WebCore::Frame::stopAutoscrollTimer): ditto.
• page/Frame.h: Made autoscrollRenderer and stopAutoscrollTimer public, so the renderer being autoscrolled can kill the timer when it dies.

• page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Added mouseDownMayStartDrag and mouseDownMayStartAutoscroll flags. Moved from FrameMac.

• page/FrameView.cpp: Store the current mouse position in window coordinates. The callers can convert to their own coordinate space. (WebCore::FrameView::handleMousePressEvent): (WebCore::FrameView::handleMouseDoubleClickEvent): (WebCore::FrameView::handleMouseMoveEvent): (WebCore::FrameView::handleMouseReleaseEvent):

• rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): Rewrote this to scroll recursively, and to scroll based on the mouse position (not the selection). We also need to update the selection here, since autoscroll can occur without a mouseMove event, and the selection needs to get reset as we scroll.

• rendering/RenderListBox.cpp: (WebCore::RenderListBox::autoscroll): Convert the mouse coordinates to the right space.

• rendering/RenderObject.cpp: (WebCore::RenderObject::shouldAutoscroll): Also return true if the renderer is a root (so we know to autoscroll views too) (WebCore::RenderObject::destroy): If this renderer is being autoscrolled, stop the frame's autoscroll timer.

WebKit:

Reviewed by Beth.

Removed handleAutoscrollForMouseDragged. Except for autoscroll caused by drag and drop, all other
autoscrolling should be done in WebCore instead of in AppKit.

• WebCoreSupport/WebFrameBridge.m:
• WebView/WebHTMLView.m:
• WebView/WebHTMLViewPrivate.h:

2:02 PM Changeset in webkit [16974] by zbujtas

• 2 edits in S60/trunk/WebCore

2006-10-10 bujtas <​zbujtas@gmail.com>

Reviewed by NOBODY.
DESC: changing capital includes to non-capital
​http://bugs.webkit.org/show_bug.cgi?id=11247

WARNING: NO TEST CASES ADDED OR CHANGED

• khtml/xml/xml_tokenizer.cpp: (khtml::XMLNamespace::m_ref): (khtml::): (khtml::XMLTokenizer::XMLTokenizer): (khtml::XMLTokenizer::startElement): (khtml::XMLTokenizer::endElement): (khtml::XMLTokenizer::characters): (khtml::XMLTokenizer::exitText): (khtml::XMLTokenizer::processingInstruction): (khtml::XMLTokenizer::comment): (khtml::XMLTokenizer::insertErrorMessageBlock): (khtml::XMLTokenizer::executeScripts): (khtml::XMLTokenizer::setTransformSource): (khtml::attributesStartElementHandler): (khtml::XMLAttributes::operator=): (khtml::XMLAttributes::split):

2:00 PM Changeset in webkit [16973] by darin

• 2 edits
  9 moves in trunk/WebCore

Rubber stamped by Maciej.

• convert many of the loader source files to Objective-C++ to prepare to convert some of them to C++

• WebCore.xcodeproj/project.pbxproj:
• loader/mac/WebDataProtocol.m: Removed.
• loader/mac/WebDocumentLoader.m: Removed.
• loader/mac/WebFormState.m: Removed.
• loader/mac/WebFrameLoader.m: Removed.
• loader/mac/WebLoader.m: Removed.
• loader/mac/WebMainResourceLoader.m: Removed.
• loader/mac/WebNetscapePlugInStreamLoader.m: Removed.
• loader/mac/WebPolicyDecider.m: Removed.
• loader/mac/WebSubresourceLoader.m: Removed.
• loader/mac/WebDataProtocol.mm: Added.
• loader/mac/WebDocumentLoader.mm: Added.
• loader/mac/WebFormState.mm: Added.
• loader/mac/WebFrameLoader.mm: Added.
• loader/mac/WebLoader.mm: Added.
• loader/mac/WebMainResourceLoader.mm: Added.
• loader/mac/WebNetscapePlugInStreamLoader.mm: Added.
• loader/mac/WebPolicyDecider.mm: Added.
• loader/mac/WebSubresourceLoader.mm: Added.

2:00 PM Changeset in webkit [16972] by darin

• 1 edit
  1 add in trunk/WebKitTools

• Scripts/do-file-rename: Added.

1:10 PM Changeset in webkit [16971] by mjs

• 2 edits in trunk/WebCore

Reviewed by Mitz.

• fixed REGRESSION (r16960): crash on navigating to site ​http://www.zoominfo.com/Search/CompanyDetail.aspx?CompanyID=62948057&cs=QGDwILZIE

• loader/mac/WebFrameLoader.m: (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): Add back a mistakenly removed retain.

12:17 PM Changeset in webkit [22346] by darin

• 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Beth.

• fix problem where you can't type in subframes

• WebView.cpp: (WebViewWndProc): Use WebView's focusedTargetFrame() function instead of sending everything to the main frame.

10:01 AM Changeset in webkit [16970] by darin

• 2 edits in trunk/WebKit

• corrected an archive regression caused by loader refactoring (pointed out by Graham Dennis)

• WebView/WebFrame.m: (-[WebFrame _deliverArchivedResourcesAfterDelay]): Fix selector name.

9:19 AM Changeset in webkit [16969] by brmorris

• 33 edits
  18 adds in S60/trunk

2006-10-04 sareen <​shyam.sareen@nokia.com>

Reviewed by Zalan, yongjun.
DESC: Change the dll names BROWSER_SDK and add stub for HistoryProvider
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11148
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11149
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11150

4:03 AM Changeset in webkit [16968] by mjs

• 2 edits in trunk/WebCore

Not reviewed, build fix.

• fixed release build

• WebCore.xcodeproj/project.pbxproj:

3:48 AM Changeset in webkit [16967] by mjs

• 20 edits
  24 moves in trunk

WebCore:

Rubber stamped by Eric.

• moved a big honkin' pile of code over from WebKit; made minimal needed changes to compile

• WebCore.exp:
• WebCore.xcodeproj/project.pbxproj:
• loader/mac/LoaderNSURLExtras.m: Added.
• loader/mac/WebDataProtocol.m: Added.
• loader/mac/WebDocumentLoader.m: Added.
• loader/mac/WebFormDataStream.m: Added.
• loader/mac/WebFrameLoader.m: Added.
• loader/mac/WebLoader.m: Added. (-[NSURLProtocol didReceiveResponse:]): (-[NSURLProtocol didReceiveData:lengthReceived:allAtOnce:]):
• loader/mac/WebMainResourceLoader.m: Added. (-[WebMainResourceLoader didReceiveResponse:]):
• loader/mac/WebPolicyDecider.m: Added.
• loader/mac/WebSubresourceLoader.h: Added.
• loader/mac/WebSubresourceLoader.m: Added.

WebKit:

Rubber stamped by Eric.

• moved a whole bunch of stuff over to WebCore - updated includes appropriately

• Loader/LoaderNSURLExtras.h: Removed.
• Loader/LoaderNSURLExtras.m: Removed.
• Loader/WebDataProtocol.h: Removed.
• Loader/WebDataProtocol.m: Removed.
• Loader/WebDocumentLoader.h: Removed.
• Loader/WebDocumentLoader.m: Removed.
• Loader/WebFormDataStream.h: Removed.
• Loader/WebFormDataStream.m: Removed.
• Loader/WebFormState.h: Removed.
• Loader/WebFormState.m: Removed.
• Loader/WebFrameLoader.h: Removed.
• Loader/WebFrameLoader.m: Removed.
• Loader/WebFrameLoaderClient.h: Removed.
• Loader/WebLoader.h: Removed.
• Loader/WebLoader.m: Removed.
• Loader/WebMainResourceLoader.h: Removed.
• Loader/WebMainResourceLoader.m: Removed.
• Loader/WebNetscapePlugInStreamLoader.h: Removed.
• Loader/WebNetscapePlugInStreamLoader.m: Removed.
• Loader/WebPlugInStreamLoaderDelegate.h: Removed.
• Loader/WebPolicyDecider.h: Removed.
• Loader/WebPolicyDecider.m: Removed.
• Loader/WebSubresourceLoader.h: Removed.
• Loader/WebSubresourceLoader.m: Removed.
• Misc/WebNSURLExtras.m:
• Plugins/WebBaseNetscapePluginStream.h:
• Plugins/WebBaseNetscapePluginView.m:
• Plugins/WebNetscapePluginStream.m:
• Plugins/WebPluginContainerCheck.m:
• Plugins/WebPluginController.m:
• WebCoreSupport/WebFrameBridge.m:
• WebKit.xcodeproj/project.pbxproj:
• WebView/WebDataSource.m:
• WebView/WebDocumentLoaderMac.h:
• WebView/WebFrame.m:
• WebView/WebFrameInternal.h:
• WebView/WebHTMLView.m:
• WebView/WebPolicyDeciderMac.h:
• WebView/WebPolicyDelegate.m:
• WebView/WebView.m:

3:38 AM Changeset in webkit [16966] by bdash

• 2 edits in trunk/WebKit

2006-10-10 Mark Rowe <​bdash@webkit.org>

Reviewed by Maciej.

Fix crash on launch in nightly builds after r16965.

Safari will sometimes call through to -[NSURL _webkit_canonicalize] before creating a WebView. If this happens,
InitWebCoreSystemInterface has not yet been called so the call to wkNSURLProtocolClassForReqest is via a garbage
pointer.

• Misc/WebNSURLExtras.m: (-[NSURL _webkit_canonicalize]): Ensure InitWebCoreSystemInterface is called prior to canonicalURL.

2:49 AM Changeset in webkit [16965] by mjs

• 4 edits in trunk/WebCore

Reviewed by Oliver (sort of?)

• WebCore part of moving down NSURL extras

• WebCore.exp:
• platform/mac/WebCoreSystemInterface.h:
• platform/mac/WebCoreSystemInterface.mm:

2:44 AM Changeset in webkit [16964] by mjs

• 5 edits
  2 adds in trunk/WebKit

Reviewed by Oliver.

• split out some NSURL extras to be moved to WebCore

• Loader/LoaderNSURLExtras.h: Added.
• Loader/LoaderNSURLExtras.m: Added. (urlByRemovingComponent): (urlByRemovingFragment): (urlOriginalDataAsString): (urlOriginalData): (urlWithData): (WebCFAutorelease): (urlWithDataRelativeToURL): (urlByRemovingResourceSpecifier): (urlIsFileURL): (stringIsFileURL): (urlIsEmpty): (canonicalURL):
• Loader/WebFrameLoader.m: (-[WebFrameLoader shouldReloadForCurrent:andDestination:]): (setHTTPReferrer): (-[WebFrameLoader commitProvisionalLoad:]): (-[WebFrameLoader _notifyIconChanged:]): (-[WebFrameLoader didChangeTitleForDocument:]): (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]): (-[WebFrameLoader safeLoadURL:]):
• Misc/WebNSURLExtras.m: (+[NSURL _web_URLWithData:]): (+[NSURL _web_URLWithData:relativeToURL:]): (-[NSURL _web_originalData]): (-[NSURL _web_originalDataAsString]): (-[NSURL _web_isEmpty]): (-[NSURL _webkit_canonicalize]): (-[NSURL _webkit_URLByRemovingComponent:]): (-[NSURL _webkit_URLByRemovingFragment]): (-[NSURL _webkit_URLByRemovingResourceSpecifier]): (-[NSURL _webkit_isFileURL]): (-[NSString _webkit_isFileURL]):
• WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
• WebKit.xcodeproj/project.pbxproj:

1:42 AM Changeset in webkit [16963] by rwlbuis

• 12 edits in trunk/WebCore

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style

Cleanup coding style in svg animation classes.

1:06 AM Changeset in webkit [16962] by mjs

• 3 edits in trunk/WebCore

Reviewed by Oliver.

• added isMainFrame and frameLoader to WebCoreFrameBridge for ease of future code motion

• bridge/mac/WebCoreFrameBridge.h:
• bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge isMainFrame]):