Timeline
Nov 21, 2006:
- 9:14 PM Changeset in webkit [22572] by
-
- 10 edits in branches/WindowsMerge
WebCoreWin:
Reviewed by Adam.
Various fixes that make file upload possible.
- bridge/win/FrameWin.h:
- loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::submitForm): Change submitForm to take a FrameLoadRequest.
- platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::advanceCurrentStream): Pass kCFURLWindowsPathStyle to CFURLCreateWithFileSystemPath.
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): Call the client method.
WebKitWin:
Reviewed by Adam.
Various fixes for getting file upload working.
- WebFrame.cpp: (WebFrame::loadDataSource): Set the header fields on the new request.
(WebFrame::submitForm):
- WebFrame.h: Update submitForm, it now takes a FrameLoadRequest.
- WebMutableURLRequest.cpp: (WebMutableURLRequest::addHTTPHeaderFields): (WebMutableURLRequest::httpHeaderFields):
- WebMutableURLRequest.h: New functions for getting and setting HTTP headers.
- 8:43 PM Changeset in webkit [22571] by
-
- 1 edit in branches/WindowsMerge/WebCore/WebCore.vcproj/WebCore.vcproj
Forgot to add this file.
- 8:25 PM Changeset in webkit [22570] by
-
- 1 edit8 adds in branches/WindowsMerge/WebCore
Rubber-stamped by Maciej.
Fork the CF loader.
- WebCore.vcproj/WebCore.vcproj:
- platform/network/cf/FormDataStreamCFNet.cpp: Added. (WebCore::getStreamFormDatas): (WebCore::pairRetain): (WebCore::pairRelease): (WebCore::pairEqual): (WebCore::pairHash): (WebCore::closeCurrentStream): (WebCore::scheduleWithPair): (WebCore::advanceCurrentStream): (WebCore::openNextStream): (WebCore::formCreate): (WebCore::formFinalize): (WebCore::formOpen): (WebCore::formRead): (WebCore::formCanRead): (WebCore::formClose): (WebCore::formSchedule): (WebCore::formUnschedule): (WebCore::formEventCallback): (WebCore::setHTTPBody): (WebCore::httpBodyFromStream):
- platform/network/cf/FormDataStreamCFNet.h: Added.
- platform/network/cf/ResourceHandleCFNet.cpp: Added. (WebCore::willSendRequest): (WebCore::didReceiveResponse): (WebCore::didReceiveData): (WebCore::didFinishLoading): (WebCore::didFail): (WebCore::willCacheResponse): (WebCore::didReceiveChallenge): (WebCore::addHeadersFromHashMap): (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::arrayFromFormData): (WebCore::emptyPerform): (WebCore::runLoaderThread): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel):
- platform/network/cf/ResourceRequestCFNet.cpp: Added. (WebCore::getResourceRequest): (WebCore::addHeadersFromHashMap): (WebCore::cfURLRequest):
- platform/network/cf/ResourceRequestCFNet.h: Added.
- platform/network/cf/ResourceResponseCFNet.cpp: Added. (WebCore::getResourceResponse):
- platform/network/cf/ResourceResponseCFNet.h: Added.
- 4:58 PM Changeset in webkit [22569] by
-
- 2 edits in branches/WindowsMerge/WebCore
Reviewed by Lou, Dave Hyatt.
<rdar://problem/4761639>
Group label in list box doesn't appear as bold
<rdar://problem/4805795>
<optgroup> labels should be bold in popup menus
- platform/win/FontPlatformDataWin.cpp: (WebCore::enumStylesCallback): (WebCore::FontPlatformData::FontPlatformData): Enumerate the existing font styles and decide what to synthesize depending on what styles are available.
- 4:09 PM Changeset in webkit [22568] by
-
- 2 edits in branches/WindowsMerge/WebCore
Fix build.
- WebCore.vcproj/WebCore.vcproj:
- 4:03 PM Changeset in webkit [17874] by
-
- 24 edits in trunk/WebCore
Reviewed by Mitz.
General SVG cleanup. Change some enums to match the style guidelines, use PLATFORM(CG) instead of PLATFORM(MAC).
Remove config.h inluce from AffineTransform.h
- kcanvas/device/quartz/KRenderingDeviceQuartz.cpp: (WebCore::KRenderingDeviceQuartz::createPaintServer): (WebCore::KRenderingDeviceQuartz::createResource):
- ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::sharedSolidPaintServer):
- ksvg2/svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::canvasResource):
- ksvg2/svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::buildGradient):
- ksvg2/svg/SVGLinearGradientElement.h: (WebCore::SVGLinearGradientElement::gradientType):
- ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::fillAttributesFromReferencePattern): (WebCore::SVGPatternElement::canvasResource):
- ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
- ksvg2/svg/SVGRadialGradientElement.h: (WebCore::SVGRadialGradientElement::gradientType):
- platform/graphics/AffineTransform.h:
- platform/graphics/svg/SVGPaintServer.h: (WebCore::):
- platform/graphics/svg/SVGPaintServerGradient.cpp: (WebCore::SVGPaintServerGradient::SVGPaintServerGradient): (WebCore::SVGPaintServerGradient::~SVGPaintServerGradient):
- platform/graphics/svg/SVGPaintServerGradient.h:
- platform/graphics/svg/SVGPaintServerLinearGradient.h: (WebCore::SVGPaintServerLinearGradient::type):
- platform/graphics/svg/SVGPaintServerPattern.h: (WebCore::SVGPaintServerPattern::type):
- platform/graphics/svg/SVGPaintServerRadialGradient.h: (WebCore::SVGPaintServerRadialGradient::type):
- platform/graphics/svg/SVGPaintServerSolid.h: (WebCore::SVGPaintServerSolid::type):
- platform/graphics/svg/SVGResource.h: (WebCore::):
- platform/graphics/svg/cg/SVGPaintServerCg.cpp: (WebCore::SVGPaintServer::renderPath):
- platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp: (WebCore::SVGPaintServerGradient::updateQuartzGradientCache): (WebCore::SVGPaintServerGradient::teardown): (WebCore::SVGPaintServerGradient::renderPath): (WebCore::SVGPaintServerGradient::setup):
- platform/graphics/svg/cg/SVGPaintServerPatternCg.cpp: (WebCore::SVGPaintServerPattern::setup):
- platform/graphics/svg/cg/SVGPaintServerSolidCg.cpp: (WebCore::SVGPaintServerSolid::setup):
- rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
- rendering/SVGInlineFlowBox.cpp: (WebCore::paintSVGInlineFlow):
- 3:15 PM Changeset in webkit [17873] by
-
- 2 edits in S60/branches/3.1m/WebKit
2006-11-21 spadma <Sachin.Padma@nokia.com>
Reviewed by Yongjun.
DESC: [S60] "Opening a secure connection. Content cannot be seen by anyone else." -note shown 4 times when entering page.
http://bugs.webkit.org/show_bug.cgi?id=11670
- ResourceLoader/src/HttpLoader.cpp: (CHttpLoader::CheckSecurityStatus):
- 3:11 PM Changeset in webkit [17872] by
-
- 2 edits in S60/trunk/WebKit
2006-11-21 spadma <Sachin.Padma@nokia.com>
Reviewed by Yongjun.
DESC: [S60] "Opening a secure connection. Content cannot be seen by anyone else." -note shown 4 times when entering page.
http://bugs.webkit.org/show_bug.cgi?id=11670
- ResourceLoader/src/HttpLoader.cpp: (CHttpLoader::CheckSecurityStatus):
- 10:14 AM Changeset in webkit [17871] by
-
- 7 edits in trunk
WebKit:
Reviewed by Maciej.
- make the close method do a more-complete job to prevent world leaks seen when running some of the layout tests
- WebView/WebHTMLViewInternal.h: Added declaration of -[WebHTMLViewPrivate clear].
- WebView/WebHTMLView.m: (-[WebHTMLViewPrivate clear]): Added method to drop references to other objects. We want to do this at "close" time, rather than waiting for deallocation time. This is especially important for the data source, which indirectly keeps a number of objects alive. (-[WebHTMLView close]): Added an explicit call to clear out the data source on the plug-in controller. Without this, we'd see the plug-in controller making calls to a deallocated data source during the layout tests. Added a call to the new clear method on the private object so that we release the objects at close time instead of waiting for deallocation time.
- WebKit.xcodeproj/project.pbxproj: Let Xcode have its way with the project file, because I can't fight the power.
WebKitTools:
Reviewed by Maciej.
- a couple changes to reduce the chance of false positives on the leakbot
- DumpRenderTree/DumpRenderTree.m: (dumpRenderTree): Move the main function into a separate function so we can run a final garbage collect afterward without any stray values on the stack. Replaced the old way of closing down a WebView (setting the delegates to nil) with the new way (calling the close method), which does a more complete job of shutting everything down without waiting for the WebView object to be deallocated. (main): Put auto-release pool here and added an explicit call to garbage collect. With a separate function, we greatly reduce the chance that a stray address on the stack will keep an object alive.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Let Xcode do its thing, because I don't have what it takes to fight the power.
- 4:22 AM Changeset in webkit [17870] by
-
- 26 edits22 adds19 deletes in trunk/WebCore
Reviewed by Oliver.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11658
Move KRenderingPaintServer* classes to the location
of all other resources (platform/graphics/svg).
- 4:08 AM Changeset in webkit [17869] by
-
- 3 edits4 adds in trunk
2006-11-21 Alex Taylor <darwin@techvisual.co.nz>
Reviewed by Mitz.
Pixel tests for border radius rendering bug
- fast/borders/borderRadiusArcs01-expected.checksum: Added.
- fast/borders/borderRadiusArcs01-expected.png: Added.
- fast/borders/borderRadiusArcs01-expected.txt: Added.
- fast/borders/borderRadiusArcs01.html: Added.
2006-11-21 Alex Taylor <darwin@techvisual.co.nz>
Reviewed by Mitz.
Adds calculations for bottom right radius's position
which was being drawn incorrectly.
- rendering/RenderObject.cpp: (WebCore::RenderObject::paintBorder):
- 3:58 AM Changeset in webkit [17868] by
-
- 11 edits in trunk/WebKitSite
2006-11-21 Matt Lilek <pewtermoose@gmail.com>
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=11652
Bug 11652: Mailing list address and URL are incorrect
This also removes a lot of bit rot from the KWQ-era.
- coding/contributing.html:
- contact.html:
- projects/css/index.html:
- projects/editing/index.html:
- projects/forms/index.html:
- projects/html/index.html:
- projects/portability/index.html:
- projects/xslt/index.html:
- quality/lifecycle.html:
- quality/testwriting.html:
- 1:28 AM Changeset in webkit [17867] by
-
- 3 edits in trunk/WebCore
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=11519
REGRESSION: Disabled file upload control doesn't have disabled appearance, failing fast/forms/file-input-disabled.html
Transport disabled state from DOM element to the shadow
DOM/render object.
Nov 20, 2006:
- 11:23 PM Changeset in webkit [17866] by
-
- 1 edit in trunk/WebCore/loader/TextResourceDecoder.cpp
Build fix: silence warning about use before initialization.
- 3:27 PM Changeset in webkit [17865] by
-
- 6 edits in trunk/WebCore
Reviewed by Maciej.
- loader/TextResourceDecoder.cpp: (WebCore::findXMLEncoding): Use CString instead of DeprecatedCString.
- platform/CString.cpp: (WebCore::CString::find):
- platform/CString.h: (WebCore::CString::data): Add find method, make data method inline.
- platform/TextStream.cpp:
- platform/TextStream.h: Remove DeprecatedCString functions.
- 2:35 PM Changeset in webkit [17864] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej.
Use CString instead of DeprecatedCString.
- html/FormDataList.cpp: (WebCore::FormDataList::appendString): (WebCore::fixLineBreaks): (WebCore::FormDataList::appendFile):
- 2:35 PM Changeset in webkit [17863] by
-
- 2 edits in S60/trunk/WebKit
2006-11-20 spadma <Sachin.Padma@nokia.com>
Reviewed by Yongjun.
DESC: [S60] Dependencies to SystemSW Internal headers; Browser HttpCacheStreamHandler.cpp
http://bugs.webkit.org/show_bug.cgi?id=11657
- ResourceLoader/CacheSrc/HttpCacheStreamHandler.cpp:
- 12:24 PM Changeset in webkit [17862] by
-
- 10 edits in trunk
2006-11-20 W. Andy Carrel <wac@google.com>
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=11501
REGRESSION: \u no longer escapes metacharacters in RegExps
http://bugs.webkit.org/show_bug.cgi?id=11502
Serializing RegExps doesn't preserve Unicode escapes
- kjs/lexer.cpp: (Lexer::Lexer): (Lexer::setCode): (Lexer::shift): (Lexer::scanRegExp): Push \u parsing back down into the RegExp object rather than in the parser. This backs out r17354 in favor of a new fix that better matches the behavior of other browsers.
- kjs/lexer.h:
- kjs/regexp.cpp: (KJS::RegExp::RegExp): (KJS::sanitizePattern): (KJS::isHexDigit): (KJS::convertHex): (KJS::convertUnicode):
- kjs/regexp.h: Translate \u escaped unicode characters for the benefit of pcre.
- kjs/ustring.cpp: (KJS::UString::append): Fix failure to increment length on the first UChar appended to a UString that was copy-on-write.
- tests/mozilla/ecma_2/RegExp/properties-001.js: Adjust tests back to the uniform standards.
LayoutTests:
- fast/js/kde/RegExp-expected.txt:
- fast/js/regexp-unicode-handling-expected.txt: Adjust these test results to passing as a result of other included changes in this revision.
- 11:58 AM Changeset in webkit [17861] by
-
- 8 edits in trunk
2006-11-20 Samuel Weinig <sam@webkit.org>
Reviewed by Alexey.
Fix for http://bugs.webkit.org/show_bug.cgi?id=11656
Fix Windows build
- WebCore.vcproj/WebCore/WebCore.vcproj:
- bridge/win/ContextMenuClientWin.h:
- bridge/win/EditorClientWin.h:
- bridge/win/FrameWin.h:
- platform/win/TemporaryLinkStubs.cpp: (WebCore::ContextMenu::show): (WebCore::ContextMenuClientWin::copyLinkToClipboard): (WebCore::ContextMenuClientWin::downloadURL): (WebCore::ContextMenuClientWin::copyImageToClipboard): (WebCore::ContextMenuClientWin::lookUpInDictionary): (WebCore::EditorClientWin::shouldInsertText): (WebCore::FrameLoader::reload): (WebCore::FrameWin::ignoreSpelling): (WebCore::FrameWin::learnSpelling):
2006-11-20 Samuel Weinig <sam@webkit.org>
Reviewed by Alexey.
Fix for http://bugs.webkit.org/show_bug.cgi?id=11656
Fix Windows build
- WebKit.vcproj/WebKit.vcproj: don't include directories that no longer exist.
- 11:56 AM Changeset in webkit [17860] by
-
- 9 edits in trunk
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=10736
XMLHttpRequest.responseXML should be null on error
WebCore:
- dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::wellFormed):
- dom/XMLTokenizer.h: (WebCore::Tokenizer::wellFormed):
- dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::implicitClose):
- dom/Document.h: (WebCore::Document::wellFormed): Tell whether XMLTokenizer saw an error. Always true (success) for HTML.
- xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::getResponseXML): Set the document to null if it's not well-formed.
LayoutTests:
- http/tests/xmlhttprequest/zero-length-response-expected.txt:
- http/tests/xmlhttprequest/zero-length-response-sync-expected.txt: Updated the results for the new behavior.
- 10:59 AM Changeset in webkit [17859] by
-
- 16 edits5 adds in trunk
Reviewed by Sam Weinig.
http://bugs.webkit.org/show_bug.cgi?id=11633
Implement XMLDocument properties xmlEncoding, xmlVersion, xmlStandalone
WebCore:
- dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::setXMLVersion): (WebCore::Document::setXMLStandalone):
- dom/Document.h: (WebCore::Document::xmlEncoding): (WebCore::Document::xmlVersion): (WebCore::Document::xmlStandalone): (WebCore::Document::setXMLEncoding):
- dom/Document.idl:
- dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::startDocument): (WebCore::startDocumentHandler): (WebCore::XMLTokenizer::initializeParserContext): Added support for these properties, getting them from an libxml2 context.
- html/HTMLDocument.cpp: (WebCore::HTMLDocument::HTMLDocument): HTMLDocument is the only kind of document that doesn't have xmlVersion default to "1.0".
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/CodeGeneratorObjC.pm: Added WK_ucfirst to properly uppercase xmlVersion and xmlStandalone.
LayoutTests:
- dom/xhtml/level3/core/documentgetxmlencoding01-expected.txt:
- dom/xhtml/level3/core/documentgetxmlencoding03-expected.txt
- dom/xhtml/level3/core/documentgetxmlstandalone04-expected.txt:
- dom/xhtml/level3/core/documentgetxmlversion01-expected.txt:
- dom/xhtml/level3/core/documentgetxmlversion02-expected.txt:
- dom/xhtml/level3/core/documentgetxmlversion03-expected.txt: These now pass.
- dom/xhtml/level3/core/documentgetxmlencoding03.xhtml: Re-added a correct test.
- fast/dom/Window/window-properties-expected.txt: Added these new properties.
- http/tests/xmlhttprequest/xml-encoding-expected.txt: Added.
- http/tests/xmlhttprequest/xml-encoding.html: Added.
- http/tests/xmlhttprequest/resources/xml-encoding.xml: Added.
- http/tests/xmlhttprequest/resources/post-echo-as-utf-8.cgi: Added. Test how xmlEncoding interacts with XMLHttpRequest.
- 8:12 AM Changeset in webkit [17858] by
-
- 9 edits in trunk/WebCore
Reviewed by Rob.
Fix Qt/Linux build.
- 7:42 AM Writing Layout Tests for DumpRenderTree edited by
- (diff)
- 5:14 AM Changeset in webkit [17857] by
-
- 1 add in trunk/WebCore/platform/graphics/svg/qt/SVGResourceFilterQt.cpp
Qt build fix after r17853: add missing SVGResourceFilterQt.cpp.
- 4:59 AM Changeset in webkit [17856] by
-
- 7 edits in trunk
2006-11-20 Samuel Weinig <sam@webkit.org>
Reviewed by Maciej.
Fix for http://bugs.webkit.org/show_bug.cgi?id=11647
Fix Win32 build
- kjs/config.h: define NOMINMAX instead of min/max as themselves.
- wtf/Vector.h: put back hack to ensure that min/max are not defined as macros.
2006-11-20 Samuel Weinig <sam@webkit.org>
Reviewed by Maciej.
Fix for http://bugs.webkit.org/show_bug.cgi?id=11647
Fix Win32 build
- config.h: add #define NOMINMAX for windows build
- platform/win/FontCacheWin.cpp: (WebCore::FontCache::createFontPlatformData):
- platform/win/TemporaryLinkStubs.cpp: add definitions for new cursors. (WebCore::aliasCursor): (WebCore::noDropCursor): (WebCore::progressCursor):
- 2:13 AM Changeset in webkit [22567] by
-
- 2 edits in branches/WindowsMerge/WebCore
Add the same include paths to the debug build.
- WebCore.vcproj/WebCore.vcproj:
- 1:42 AM Changeset in webkit [22566] by
-
- 2 edits1 move in branches/WindowsMerge/WebCore
Fix build.
- WebCore.vcproj/WebCore.vcproj:
- kcanvas/device/quartz/KCanvasFilterQuartz.cpp: Removed.
- platform/graphics/svg/cg/SVGResourceFilterCg.cpp: Added. (WebCore::SVGResourceFilter::SVGResourceFilter): (WebCore::SVGResourceFilter::~SVGResourceFilter): (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter):
- 1:39 AM Changeset in webkit [22565] by
-
- 3 edits in branches/WindowsMerge/WebKitWin
Fix build.
- WebEditorClient.cpp: (WebEditorClient::shouldInsertNode): (WebEditorClient::shouldInsertText):
- WebEditorClient.h:
Nov 19, 2006:
- 10:51 PM TitleIndex edited by
- removing spam (diff)
- 10:51 PM Writing Layout Tests for DumpRenderTree edited by
- removing spam (diff)
- 10:48 PM TracInstall edited by
- removing spam (diff)
- 10:48 PM TracGuide edited by
- removing spam (diff)
- 5:27 PM Changeset in webkit [22564] by
-
- 9 edits in branches/WindowsMerge
WebCore:
Reviewed by Adam.
Boomer part of context menu actions.
- bridge/win/FrameWin.h: New spelling functions on Frame.
- platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::show): (WebCore::ContextMenu::hide):
- platform/win/TemporaryLinkStubs.cpp: New stubs. (FrameWin::ignoreSpelling): (FrameWin::learnSpelling): (FrameLoader::reload):
WebKit:
Reviewed by Adam.
- WebContextMenuClient.cpp: Stubs for the currently client- dependent menu actions. (WebContextMenuClient::copyLinkToClipboard): (WebContextMenuClient::downloadURL): (WebContextMenuClient::copyImageToClipboard): (WebContextMenuClient::lookUpInDictionary):
- WebContextMenuClient.h:
- WebEditorClient.cpp: (WebEditorClient::shouldInsertText): Remove comment markers since this is implemented now on the Mac.
- WebEditorClient.h:
- 5:21 PM Changeset in webkit [17855] by
-
- 24 edits1 add in trunk
WebCore:
Reviewed by Adam.
Implementation of actions for the new context menus.
- WebCore.exp:
- WebCore.xcodeproj/project.pbxproj:
- bridge/EditorClient.h: Declaration of shouldInsertText.
- bridge/mac/FrameMac.h: Two new spelling functions.
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::ignoreSpelling): (WebCore::FrameMac::learnSpelling):
- editing/Editor.cpp: (WebCore::Editor::shouldInsertText): Call into the client.
- editing/Editor.h:
- editing/EditorInsertAction.h: Added. (WebCore::): The WebCore equivalent of WebViewInsertAction. This is defined in its own header so that we can use it from Editor.h and EditorClient.h without having one of the above include the other.
- page/ContextMenuClient.h: A few currently WebKit-implemented function needed for menu actions.
- page/ContextMenuController.cpp: (WebCore::makeGoogleSearchURL): (WebCore::ContextMenuController::contextMenuActionSelected): The actions!
- page/ContextMenuController.h:
- page/Frame.h: New pure-virtual spelling functions.
- platform/ContextMenu.cpp: (WebCore::ContextMenu::controller): Get the controller from the menu.
- platform/ContextMenu.h:
- platform/mac/ContextMenuMac.mm: (-[MenuTarget forwardContextMenuAction:initWithContextMenuController:WebCore::]): Use the controller instead of the menu (-[MenuTarget WebCore::]): (-[MenuTarget setMenuController:WebCore::]): (-[MenuTarget forwardContextMenuAction:]): (getNSMenuItem): (ContextMenu::show): (ContextMenu::hide):
WebKit:
Reviewed by Adam.
WebKit side of new context menu actions.
- WebCoreSupport/WebContextMenuClient.h: These are for the currently-WebKit-dependent menu actions.
- WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::copyLinkToClipboard): (WebContextMenuClient::downloadURL): (WebContextMenuClient::copyImageToClipboard): (WebContextMenuClient::searchWithSpotlight): (WebContextMenuClient::lookUpInDictionary):
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebEditorClient.mm: (core): These are to convert between WebViewInsertAction and EditorInsertAction. (kit): (WebEditorClient::shouldInsertText): Added implementation for shouldInsertText.
- WebKit.xcodeproj/project.pbxproj:
- WebView/WebHTMLView.m: (-[WebHTMLView _lookUpInDictionaryFromMenu:]): Moved _lookUpInDictionary to be within the implementation of WebHTMLView internal.
- WebView/WebHTMLViewInternal.h: Add _lookUpInDictionaryFromMenu
- WebView/WebViewInternal.h: Add _searchWithSpotlightFromMenu
- 2:22 PM Changeset in webkit [17854] by
-
- 1 edit3 deletes in trunk/LayoutTests
Removed parts of an incorrectly committed test, to be re-added later.
- dom/xhtml/level3/core/documentgetxmlencoding03-expected.png: Removed.
- dom/xhtml/level3/core/documentgetxmlencoding03-expected.checksum: Removed.
- dom/xhtml/level3/core/documentgetxmlencoding03.xhtml: Removed.
- 1:25 PM TracGuide edited by
- (diff)
- 1:25 PM TracInstall edited by
- (diff)
- 1:24 PM Writing Layout Tests for DumpRenderTree edited by
- (diff)
- 1:23 PM TitleIndex edited by
- (diff)
- 12:13 PM Writing Layout Tests for DumpRenderTree edited by
- Added GCController (diff)
- 10:39 AM Changeset in webkit [17853] by
-
- 13 edits in trunk
top level:
Reviewed by Zack.
- CMakeLists.txt: Fix Qt-only build without KDE cmake files
Reviewed by Zack.
http://bugs.webkit.org/show_bug.cgi?id=11649
Fix CMake Qt-only build without KDE CMake files
- CMakeLists.txt:
- pcre/CMakeLists.txt:
WebCore:
Reviewed by Zack.
http://bugs.webkit.org/show_bug.cgi?id=11649
Fix CMake files for Qt-only build without KDE cmake files.
Fix Qt/KDE build for the SVG support.
Fix Qt-only build in the resource handler.
- CMakeLists.txt:
- platform/graphics/svg/qt/SVGResourceFilterQt.cpp: Added. (WebCore::SVGResourceFilter::SVGResourceFilter): (WebCore::SVGResourceFilter::~SVGResourceFilter): (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter):
- platform/network/qt/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::cancel): (WebCore::ResourceHandleManager::slotData): (WebCore::ResourceHandleManager::slotMimetype): (WebCore::ResourceHandleManager::slotResult): (WebCore::ResourceHandleManager::deliverJobData):
- platform/network/qt/ResourceHandleManager.h:
- platform/network/qt/ResourceHandleQt.cpp:
- platform/qt/CursorQt.cpp: (WebCore::noDropCursor): (WebCore::progressCursor): (WebCore::aliasCursor):
WebKitQt:
Reviewed by Zack.
http://bugs.webkit.org/show_bug.cgi?id=11649
Fix Qt-only build
- QtLauncher/CMakeLists.txt:
- 1:12 AM Changeset in webkit [17852] by
-
- 2 edits4 adds1 delete in trunk
2006-11-19 Mitz Pettel <mitz@webkit.org>
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=11626 Automate test for rdar://problem/4056100
WebCore:
- manual-tests/delete-into-nested-block.html: Removed.
LayoutTests:
- fast/repaint/delete-into-nested-block-expected.checksum: Added.
- fast/repaint/delete-into-nested-block-expected.png: Added.
- fast/repaint/delete-into-nested-block-expected.txt: Added.
- fast/repaint/delete-into-nested-block.html: Added.
Nov 18, 2006:
- 11:20 PM Changeset in webkit [22563] by
-
- 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION
Bump version for submit
- 11:18 PM Changeset in webkit [17851] by
-
- 1 copy in tags/Safari-521.31b
New tag.
- 6:44 PM Changeset in webkit [17850] by
-
- 59 edits41 copies61 adds6 deletes in trunk/WebCore
Reviewed by Oliver.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11596
Split up KCanvasFilters & KCanvasFilterQuartz into several
new classes (SVGFEBlend, SVGFEComposite...) and move them
into platform/graphics/svg. This is still a temporary location,
as discussed with Darin; the whole platform/graphics/svg directory
will probably be moved into ksvg2/ in near future.
This commit removes the duplicated enumerations in the svg filter
classes and within kcanvas. ksvg2/ and platform/graphics/svg share
their enums now.
- 4:47 PM Changeset in webkit [17849] by
-
- 1 edit2 adds in trunk/LayoutTests
Reviewed by Darin.
Add tests for crash when garbage collecting node iterators and tree walkers
without a node filter.
- fast/dom/node-filter-gc-expected.txt: Added.
- fast/dom/node-filter-gc.html: Added.
- 3:45 PM Changeset in webkit [22562] by
-
- 2 edits in branches/WindowsMerge/WebCore
Build fix from OpenSource r17841.
- platform/win/CursorWin.cpp: New method stubs. (WebCore::aliasCursor): (WebCore::progressCursor): (WebCore::noDropCursor):
- 2:59 PM Changeset in webkit [17848] by
-
- 3 edits4 adds in trunk
LayoutTests:
Reviewed by Maciej.
Testcase for:
http://bugs.webkit.org/show_bug.cgi?id=11321
Element with :target pseudo-class still matched after fragment identifier change
- fast/css/target-fragment-match-expected.checksum: Added.
- fast/css/target-fragment-match-expected.png: Added.
- fast/css/target-fragment-match-expected.txt: Added.
- fast/css/target-fragment-match.html: Added.
WebCore:
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=11321
Element with :target pseudo-class still matched after fragment identifier change
Make sure the page does a style recalculation and possible rendering
when navigating back from a page with an anchor to a page without
an anchor.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::gotoAnchor):
- 12:58 PM Changeset in webkit [17847] by
-
- 10 edits2 adds in trunk
2006-11-18 Don Gibson <dgibson77@gmail.com>
Reviewed by Sam Weinig.
http://bugs.webkit.org/show_bug.cgi?id=11634:
Fix segfault on startup for Windows build. Also fix segfault when
typing in a URL.
Clean up some of the style of the patch that landed in r17816.
WebCore:
- WebCore.vcproj/WebCore/WebCore.vcproj:
- bridge/win/ChromeClientWin.h: (WebCore::ChromeClientWin::~ChromeClientWin): (WebCore::ChromeClientWin::ref): (WebCore::ChromeClientWin::deref):
- bridge/win/ContextMenuClientWin.h: (WebCore::ContextMenuClientWin::~ContextMenuClientWin): (WebCore::ContextMenuClientWin::ref): (WebCore::ContextMenuClientWin::deref):
- bridge/win/EditorClientWin.h: (WebCore::EditorClientWin::~EditorClientWin): (WebCore::EditorClientWin::ref): (WebCore::EditorClientWin::deref):
- bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
- bridge/win/FrameWin.h: (WebCore::Win):
- loader/win/FrameLoaderClientWin.h: Added. (WebCore::FrameLoaderClientWin::~FrameLoaderClientWin): (WebCore::FrameLoaderClientWin::ref): (WebCore::FrameLoaderClientWin::deref):
- platform/win/TemporaryLinkStubs.cpp: (WebCore::ChromeClientWin::createWindow): (WebCore::ChromeClientWin::createModalDialog): (WebCore::EditorClientWin::selectWordBeforeMenuEvent): (WebCore::EditorClientWin::isEditable): (WebCore::EditorClientWin::shouldBeginEditing): (WebCore::EditorClientWin::shouldEndEditing): (WebCore::EditorClientWin::shouldApplyStyle): (WebCore::EditorClientWin::didBeginEditing): (WebCore::EditorClientWin::respondToChangedContents): (WebCore::EditorClientWin::didEndEditing): (WebCore::EditorClientWin::registerCommandForUndo): (WebCore::EditorClientWin::registerCommandForRedo): (WebCore::EditorClientWin::clearUndoRedoOperations): (WebCore::EditorClientWin::canUndo): (WebCore::EditorClientWin::canRedo): (WebCore::EditorClientWin::undo): (WebCore::EditorClientWin::redo): (WebCore::FrameLoader::createFrame): (WebCore::FrameLoader::createPlugin): (WebCore::FrameLoaderClientWin::hasWebView): (WebCore::FrameLoaderClientWin::hasFrameView): (WebCore::FrameLoaderClientWin::hasBackForwardList): (WebCore::FrameLoaderClientWin::resetBackForwardList): (WebCore::FrameLoaderClientWin::provisionalItemIsTarget): (WebCore::FrameLoaderClientWin::loadProvisionalItemFromPageCache): (WebCore::FrameLoaderClientWin::invalidateCurrentItemPageCache): (WebCore::FrameLoaderClientWin::privateBrowsingEnabled): (WebCore::FrameLoaderClientWin::makeDocumentView): (WebCore::FrameLoaderClientWin::makeRepresentation): (WebCore::FrameLoaderClientWin::forceLayout): (WebCore::FrameLoaderClientWin::forceLayoutForNonHTML): (WebCore::FrameLoaderClientWin::updateHistoryForCommit): (WebCore::FrameLoaderClientWin::updateHistoryForBackForwardNavigation): (WebCore::FrameLoaderClientWin::updateHistoryForReload): (WebCore::FrameLoaderClientWin::updateHistoryForStandardLoad): (WebCore::FrameLoaderClientWin::updateHistoryForInternalLoad): (WebCore::FrameLoaderClientWin::updateHistoryAfterClientRedirect): (WebCore::FrameLoaderClientWin::setCopiesOnScroll): (WebCore::FrameLoaderClientWin::tokenForLoadErrorReset): (WebCore::FrameLoaderClientWin::resetAfterLoadError): (WebCore::FrameLoaderClientWin::doNotResetAfterLoadError): (WebCore::FrameLoaderClientWin::willCloseDocument): (WebCore::FrameLoaderClientWin::detachedFromParent1): (WebCore::FrameLoaderClientWin::detachedFromParent2): (WebCore::FrameLoaderClientWin::detachedFromParent3): (WebCore::FrameLoaderClientWin::detachedFromParent4): (WebCore::FrameLoaderClientWin::loadedFromPageCache): (WebCore::FrameLoaderClientWin::dispatchDidHandleOnloadEvents): (WebCore::FrameLoaderClientWin::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebCore::FrameLoaderClientWin::dispatchDidCancelClientRedirect): (WebCore::FrameLoaderClientWin::dispatchWillPerformClientRedirect): (WebCore::FrameLoaderClientWin::dispatchDidChangeLocationWithinPage): (WebCore::FrameLoaderClientWin::dispatchWillClose): (WebCore::FrameLoaderClientWin::dispatchDidReceiveIcon): (WebCore::FrameLoaderClientWin::dispatchDidStartProvisionalLoad): (WebCore::FrameLoaderClientWin::dispatchDidReceiveTitle): (WebCore::FrameLoaderClientWin::dispatchDidCommitLoad): (WebCore::FrameLoaderClientWin::dispatchDidFinishLoad): (WebCore::FrameLoaderClientWin::dispatchDidFirstLayout): (WebCore::FrameLoaderClientWin::dispatchShow): (WebCore::FrameLoaderClientWin::cancelPolicyCheck): (WebCore::FrameLoaderClientWin::dispatchWillSubmitForm): (WebCore::FrameLoaderClientWin::dispatchDidLoadMainResource): (WebCore::FrameLoaderClientWin::clearLoadingFromPageCache): (WebCore::FrameLoaderClientWin::isLoadingFromPageCache): (WebCore::FrameLoaderClientWin::revertToProvisionalState): (WebCore::FrameLoaderClientWin::clearUnarchivingState): (WebCore::FrameLoaderClientWin::progressStarted): (WebCore::FrameLoaderClientWin::progressCompleted): (WebCore::FrameLoaderClientWin::setMainFrameDocumentReady): (WebCore::FrameLoaderClientWin::willChangeTitle): (WebCore::FrameLoaderClientWin::didChangeTitle): (WebCore::FrameLoaderClientWin::finishedLoading): (WebCore::FrameLoaderClientWin::finalSetupForReplace): (WebCore::FrameLoaderClientWin::setDefersLoading): (WebCore::FrameLoaderClientWin::isArchiveLoadPending): (WebCore::FrameLoaderClientWin::cancelPendingArchiveLoad): (WebCore::FrameLoaderClientWin::clearArchivedResources): (WebCore::FrameLoaderClientWin::canShowMIMEType): (WebCore::FrameLoaderClientWin::representationExistsForURLScheme): (WebCore::FrameLoaderClientWin::generatedMIMETypeForURLScheme): (WebCore::FrameLoaderClientWin::frameLoadCompleted): (WebCore::FrameLoaderClientWin::restoreScrollPositionAndViewState): (WebCore::FrameLoaderClientWin::provisionalLoadStarted): (WebCore::FrameLoaderClientWin::shouldTreatURLAsSameAsCurrent): (WebCore::FrameLoaderClientWin::addHistoryItemForFragmentScroll): (WebCore::FrameLoaderClientWin::didFinishLoad): (WebCore::FrameLoaderClientWin::prepareForDataSourceReplacement): (WebCore::FrameLoaderClientWin::setTitle): (WebCore::FrameLoaderClientWin::userAgent):
WebKit:
- COM/WebFrame.cpp: (WebFrame::initWithName):
- 12:19 PM Changeset in webkit [17846] by
-
- 2 edits in S60/branches/3.1m/WebCore
2006-11-16 rathnasa <sornalatha.rathnasamy@nokia.com>
Reviewed by Zalan Bujtas <zbujtas@gmail.com>.
Merged from 3.2 r17845
DESC: Image map using ID attribute cannot be activated
http://bugs.webkit.org/show_bug.cgi?id=11618
WARNING: NO TEST CASES ADDED OR CHANGED
- khtml/html/html_imageimpl.cpp: (HTMLMapElementImpl::parseHTMLAttribute):
- 12:17 PM Changeset in webkit [17845] by
-
- 2 edits in S60/trunk/WebCore
2006-11-16 rathnasa <sornalatha.rathnasamy@nokia.com>
Reviewed by Zalan Bujtas <zbujtas@gmail.com>.
DESC: Image map using ID attribute cannot be activated
http://bugs.webkit.org/show_bug.cgi?id=11618
WARNING: NO TEST CASES ADDED OR CHANGED
- khtml/html/html_imageimpl.cpp: (HTMLMapElementImpl::parseHTMLAttribute):
- 11:29 AM Changeset in webkit [17844] by
-
- 2 edits in S60/trunk/WebCore
2006-11-16 yadavall <sriram.yadavalli@nokia.com>
Reviewed by Zalan Bujtas (zbujtas@gmail.com).
DESC: Fix for tabbed navigation
http://bugs.webkit.org/show_bug.cgi?id=11619
WARNING: NO TEST CASES ADDED OR CHANGED
- kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::getNewTabbedCursorPosition):
- 11:25 AM Changeset in webkit [17843] by
-
- 2 edits in S60/trunk/WebCore
2006-11-16 shkeller <shaun.keller@nokia.com>
Reviewed by zalan.
DESC: render object of image type was wrongly typecast and move brace so changelog script works
http://bugs.webkit.org/show_bug.cgi?id=11608
WARNING: NO TEST CASES ADDED OR CHANGED
- khtml/html/html_objectimpl.cpp: (HTMLEmbedElementImpl::isFocusable): (HTMLObjectElementImpl::getObjectInstance): (HTMLObjectElementImpl::isFocusable):
- 5:52 AM Changeset in webkit [17842] by
-
- 5 edits in trunk
Reviewed by Rob (yay!).
http://bugs.webkit.org/show_bug.cgi?id=11640
XMLHttpRequest produces undefined:undefined HTTP authentication
WebCore:
- bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Treat undefined credentials as missing ones.
LayoutTests:
- http/tests/xmlhttprequest/basic-auth-expected.txt:
- http/tests/xmlhttprequest/basic-auth.html: Added tests for undefined.
- 3:24 AM Nightly Builds edited by
- Changed to talk about Safari extensions in general rather than about a … (diff)
- 3:01 AM Known incompatibilities between open-source WebKit and Safari edited by
- Deleted obsolete information. The context menu items are present and … (diff)
- 2:00 AM Changeset in webkit [17841] by
-
- 9 edits3 adds in trunk/WebCore
2006-11-17 Lars Naesbye Christensen <larsnaesbye@stud.ku.dk>
Reviewed by Tim H.
http://bugs.webkit.org/show_bug.cgi?id=11638
[CSS 2.1+3] add support for alias, progress, no-drop and not-allowed cursor styles
- Resources/aliasCursor.png: Added.
- Resources/noDropCursor.png: Added.
- Resources/progressCursor.png: Added.
- WebCore.xcodeproj/project.pbxproj:
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSValueKeywords.in:
- manual-tests/cursor.html:
- page/EventHandler.cpp: (WebCore::selectCursor):
- platform/Cursor.h:
- platform/mac/CursorMac.mm: (WebCore::handCursor): (WebCore::aliasCursor): (WebCore::progressCursor): (WebCore::noDropCursor):
- rendering/RenderStyle.h: (WebCore::):
- 1:30 AM Changeset in webkit [17840] by
-
- 2 edits in trunk/WebKitSite
2006-11-18 Mitz Pettel <mitz@webkit.org>
Reviewed by Maciej.
Gender-neutrality fix.
- coding/contributing.html:
- 1:29 AM Changeset in webkit [17839] by
-
- 2 edits in trunk/WebCore
2006-11-18 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam.
Properly adjust CFAbsoluteTime to time_t to fix date calculations.
Compare lastModified w/ MAX_TIME_T when setting last modified date
instead of comparing expiration against MAX_TIME_T.
- platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::getResourceResponse): Add kCFAbsoluteTimeIntervalSince1970 in assignment
Nov 17, 2006:
- 9:57 PM Changeset in webkit [17838] by
-
- 10 edits in trunk/WebCore
Reviewed by Geoff.
More conversions from DeprecatedValueList to Vector and HashSet.
- css/CSSValueList.cpp: (WebCore::CSSValueList::~CSSValueList): (WebCore::CSSValueList::append): (WebCore::CSSValueList::cssText):
- css/CSSValueList.h: (WebCore::CSSValueList::length): (WebCore::CSSValueList::item):
- dom/Document.cpp: (WebCore::Document::attachNodeIterator): (WebCore::Document::notifyBeforeNodeRemoval):
- dom/Document.h:
- ksvg2/svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::notifyAttributeChange):
- ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::notifyClientsToRepaint):
- platform/graphics/svg/SVGResource.cpp: (WebCore::SVGResource::invalidate): (WebCore::SVGResource::addClient):
- platform/graphics/svg/SVGResource.h:
- rendering/RenderBlock.h:
- 7:29 PM Changeset in webkit [22561] by
-
- 19 edits in branches/WindowsMerge
WebCoreWin:
Reviewed by Adam.
Add #defines in config.h to prevent the min and max macros from being used.
- bridge/win/FrameWin.cpp:
- config.h:
- platform/win/FontCacheWin.cpp: (WebCore::FontCache::createFontPlatformData):
- platform/win/PopupMenuWin.cpp:
- plugins/win/PluginStreamWin.cpp:
- plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::handlePost):
WebKitWin:
Reviewed by Adam.
Make sure that all .cpp files and none of the headers include config.h.
- MemoryStream.cpp:
- WebBackForwardList.cpp:
- WebBackForwardList.h:
- WebElementPropertyBag.cpp:
- WebHTMLRepresentation.cpp:
- WebKitClassFactory.cpp:
- WebKitDLL.cpp:
- WebMutableURLRequest.cpp:
- WebMutableURLRequest.h:
- WebURLResponse.cpp:
- WebURLResponse.h:
- 7:15 PM Changeset in webkit [17837] by
-
- 4 edits in trunk/JavaScriptCore
2006-11-17 Anders Carlsson <acarlsson@apple.com>
Reviewed by Adam.
Make sure that we always use std::min and std::max instead of macros.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- kjs/config.h:
- wtf/Vector.h:
- 7:09 PM Changeset in webkit [22560] by
-
- 2 edits in branches/WindowsMerge/WebCore
Reviewed by Adam.
- Fixes Targetted Form Submission to now work. Radar: 4762693
- ChangeLog:
- loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::submitForm):
- 6:24 PM Changeset in webkit [17836] by
-
- 1 edit in trunk/WebCore/editing/EditCommand.cpp
Fixing the assertion failure, forgot to remove an enable() call.
- 5:24 PM Changeset in webkit [17835] by
-
- 1 edit8 copies in tags/Safari-521.31
New tag.
- 5:21 PM Changeset in webkit [17834] by
-
- 6 edits in /
Versioning
- 5:06 PM Changeset in webkit [17833] by
-
- 3 edits in trunk/WebCore
Reviewed by Harrison.
<rdar://problem/4796730> table deletion elements are serialized out if they are visible when innerHTML or a Web Archive is made
Disable the delete button controller when cloning nodes, Mail does this before saving a draft.
- dom/ContainerNode.cpp: (WebCore::ContainerNode::cloneChildNodes):
- editing/markup.cpp: (WebCore::createFragmentFromNodes):
- 5:04 PM Changeset in webkit [17832] by
-
- 9 edits12 adds in trunk
LayoutTests:
Reviewed by harrison
<rdar://problem/4237467> REGRESSION: Pasting word from quoted text quotes the destination
<rdar://problem/4017358> quoted text is wrong color, when pasted as quotation
Fixed:
- editing/pasteboard/merge-end-blockquote-expected.checksum:
- editing/pasteboard/merge-end-blockquote-expected.png:
- editing/pasteboard/merge-end-blockquote-expected.txt:
- editing/pasteboard/merge-end-blockquote.html:
Added:
- editing/pasteboard/paste-blockquote-1-expected.checksum: Added.
- editing/pasteboard/paste-blockquote-1-expected.png: Added.
- editing/pasteboard/paste-blockquote-1-expected.txt: Added.
- editing/pasteboard/paste-blockquote-1.html: Added.
- editing/pasteboard/paste-blockquote-2-expected.checksum: Added.
- editing/pasteboard/paste-blockquote-2-expected.png: Added.
- editing/pasteboard/paste-blockquote-2-expected.txt: Added.
- editing/pasteboard/paste-blockquote-2.html: Added.
- editing/pasteboard/paste-blockquote-3-expected.checksum: Added.
- editing/pasteboard/paste-blockquote-3-expected.png: Added.
- editing/pasteboard/paste-blockquote-3-expected.txt: Added.
- editing/pasteboard/paste-blockquote-3.html: Added.
WebCore:
Reviewed by harrison
<rdar://problem/4237467> REGRESSION: Pasting word from quoted text quotes the destination
<rdar://problem/4017358> quoted text is wrong color, when pasted as quotation
- editing/ReplaceSelectionCommand.cpp: (WebCore::isMailPasteAsQuotationNode): Added. Checks for the node that Mail wraps around an incoming fragment when it wants it to be pasted with quoting (no merging should be done). (WebCore::ReplaceSelectionCommand::removeNodePreservingChildren): Added this virtual method in order to adjust the nodes that ReplaceSelectionCommand tracks. (WebCore::ReplaceSelectionCommand::shouldMerge): Don't merge from content inside a Mail Paste as Quotation node. Allow merging from Mail blockquotes. (WebCore::ReplaceSelectionCommand::removeRedundantStyles): When pasting into a Mail blockquote, we ignore the parts of the source document's default style that are overriden by styles from the Mail blockquote. This is necessary in order for text that's black (because black is the source document's default font color) to appear blue/green/whatever when it's pasted into a Mail blockquote. (WebCore::ReplaceSelectionCommand::handlePasteAsQuotationNode): Turn an inserted Mail Paste as Quotation node into a normal Mail blockquote. This will prevent a copied blockquote that was inserted into the document using Paste as Quotation from triggering Paste as Quotation behavior when it's pasted. (WebCore::ReplaceSelectionCommand::doApply): Call the new/altered methods.
- editing/ReplaceSelectionCommand.h:
- editing/markup.cpp: (WebCore::styleFromMatchedRulesForElement): Put this code into a subroutine. (WebCore::removeEnclosingMailBlockquoteStyle): Added. (WebCore::startMarkup): When wrapping text nodes in style spans, leave out styles that Mail blockquotes contribute, so that Mail blockquote styles can be differentiated from styles that the user has applied. When creating markup for elements, do the same thing. (WebCore::createMarkup): Call the new subroutine.
- 4:22 PM Changeset in webkit [17831] by
-
- 1 edit in trunk/WebKit/WebKit.xcodeproj/project.pbxproj
Forgoet the project change.
- 4:21 PM Changeset in webkit [17830] by
-
- 2 edits in trunk/WebKit
Reviewed by Geoff.
<rdar://problem/4841044> Temporarily default Mail.app editable link clicking behavior, until they do it themselves
- WebKit.xcodeproj/project.pbxproj:
- WebView/WebView.mm: (+[WebView initialize]): (-[WebView setPreferences:]):
- 4:04 PM Changeset in webkit [22559] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
Reviewed by Adele.
- fix leak of Document ref count seen in updateCounterpartURLForRSS
- WebScriptObject.h: Changed destructor to be virtual. Without this, when the COM object was released we wouldn't release the underlying WebCore::Node.
- 12:14 PM Changeset in webkit [17829] by
-
- 2 edits in trunk/WebCore
Reviewed by Mitz.
http://bugs.webkit.org/show_bug.cgi?id=11635
Bug 11635: Fix potential issue with non-xslt build
Fix the issue and do style guideline corrections.
- 11:47 AM Changeset in webkit [17828] by
-
- 3 edits in trunk/WebCore
Reviewed by Harrison.
<rdar://problem/4843131> text entry is slow inside element that has the deletion rectangle around it
Only disable/enable the delete button inside applyCommand() to prevent slowing down typing.
This reintroduces <rdar://problem/4796657> table deletion outline does not always follow the table size as editing occurs inside
- editing/EditCommand.cpp: (WebCore::EditCommand::apply): (WebCore::EditCommand::unapply): (WebCore::EditCommand::reapply): (WebCore::applyCommand):
- editing/EditCommand.h:
- 11:42 AM Changeset in webkit [22558] by
-
- 4 edits in branches/WindowsMerge/WebKitWin
WebKitWin:
Reviewed by Adele.
- fix leak of WebView when you close a tab or window
- Interfaces/IWebView.idl: Added a close function, like the close method we added to WebView on the Macintosh side.
- WebView.h: Added close function.
- WebView.cpp: (WebView::close): First cut at implementation of close.
- 11:23 AM Changeset in webkit [17827] by
-
- 13 edits5 adds in trunk
Reviewed by Mitz. Landed by Niko.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11617
Adapt to latest API changes, fixing Qt/Linux build.
- 11:21 AM Changeset in webkit [17826] by
-
- 2 edits in trunk/WebCore
Reviewed by Adele.
<rdar://problem/4799899> Frame::revealSelection() only scrolls the startContainer's layer
Replace an assert with a fixme that refers to this bug.
- page/Frame.cpp: (WebCore::Frame::revealSelection):