Timeline



Nov 24, 2006:

2:39 PM Changeset in webkit [17879] by rwlbuis
  • 6 edits
    4 adds in trunk

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=11666
.getScreenCTM() returns wrong values

Take into account the local transform matrix too and
so fix getScreenCTM/getCTM for <text>.

Nov 22, 2006:

11:16 PM WikiStart edited by mitz@webkit.org
+Writing Layout Tests for DumpRenderTree (diff)
2:02 PM Changeset in webkit [17878] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2006-11-21 sareen <shyam.sareen@nokia.com>

Reviewed by sachin.padma@nokia.com
Desc: [S60]Cache not cleared when it gets filled. Cache Handler is not assigned in case of
expired entries.
http://bugzilla.opendarwin.org/show_bug.cgi?id=11663

  • ResourceLoader/CacheSrc/HttpCacheManager.cpp: (CHttpCacheManager::RequestL):
1:59 PM Changeset in webkit [17877] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-21 sareen <shyam.sareen@nokia.com>

Reviewed by sachin.padma@nokia.com
Desc: [S60]Cache not cleared when it gets filled. Cache Handler is not assigned in case of
expired entries.
http://bugzilla.opendarwin.org/show_bug.cgi?id=11663

  • ResourceLoader/CacheSrc/HttpCacheManager.cpp: (CHttpCacheManager::RequestL):
1:24 PM Changeset in webkit [17876] by rwlbuis
  • 3 edits
    4 adds in trunk

Reviewed by Eric.

http://bugs.webkit.org/show_bug.cgi?id=11661
SVG: stroke not sensitive to mouse events (hit testing fails)

Use mapAbsolutePointToLocal when hit-testing strokes.

7:49 AM Changeset in webkit [17875] by zbujtas
  • 2 edits in S60/branches/3.1m/WebCore

2006-11-21 w3liu <wei.liu@nokia.com>

Reviewed by <yongjun.zhang@nokia.com>
DESC:
http://bugs.webkit.org/show_bug.cgi?id=11665
Text decoder regression in 3.1 and 3.0 browser

WARNING: NO TEST CASES ADDED OR CHANGED

  • ChangeLog:
  • kwq/KWQTextCodec.h:

Nov 21, 2006:

9:14 PM Changeset in webkit [22572] by andersca
  • 10 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

Various fixes that make file upload possible.


  • bridge/win/FrameWin.h:
  • loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::submitForm): Change submitForm to take a FrameLoadRequest.


  • platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::advanceCurrentStream): Pass kCFURLWindowsPathStyle to CFURLCreateWithFileSystemPath.


  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): Call the client method.

WebKitWin:

Reviewed by Adam.

Various fixes for getting file upload working.


  • WebFrame.cpp: (WebFrame::loadDataSource): Set the header fields on the new request.


(WebFrame::submitForm):

  • WebFrame.h: Update submitForm, it now takes a FrameLoadRequest.


  • WebMutableURLRequest.cpp: (WebMutableURLRequest::addHTTPHeaderFields): (WebMutableURLRequest::httpHeaderFields):
  • WebMutableURLRequest.h: New functions for getting and setting HTTP headers.
8:43 PM Changeset in webkit [22571] by andersca
  • 1 edit in branches/WindowsMerge/WebCore/WebCore.vcproj/WebCore.vcproj

Forgot to add this file.

8:25 PM Changeset in webkit [22570] by andersca
  • 1 edit
    8 adds in branches/WindowsMerge/WebCore

Rubber-stamped by Maciej.

Fork the CF loader.


  • WebCore.vcproj/WebCore.vcproj:
  • platform/network/cf/FormDataStreamCFNet.cpp: Added. (WebCore::getStreamFormDatas): (WebCore::pairRetain): (WebCore::pairRelease): (WebCore::pairEqual): (WebCore::pairHash): (WebCore::closeCurrentStream): (WebCore::scheduleWithPair): (WebCore::advanceCurrentStream): (WebCore::openNextStream): (WebCore::formCreate): (WebCore::formFinalize): (WebCore::formOpen): (WebCore::formRead): (WebCore::formCanRead): (WebCore::formClose): (WebCore::formSchedule): (WebCore::formUnschedule): (WebCore::formEventCallback): (WebCore::setHTTPBody): (WebCore::httpBodyFromStream):
  • platform/network/cf/FormDataStreamCFNet.h: Added.
  • platform/network/cf/ResourceHandleCFNet.cpp: Added. (WebCore::willSendRequest): (WebCore::didReceiveResponse): (WebCore::didReceiveData): (WebCore::didFinishLoading): (WebCore::didFail): (WebCore::willCacheResponse): (WebCore::didReceiveChallenge): (WebCore::addHeadersFromHashMap): (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::arrayFromFormData): (WebCore::emptyPerform): (WebCore::runLoaderThread): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel):
  • platform/network/cf/ResourceRequestCFNet.cpp: Added. (WebCore::getResourceRequest): (WebCore::addHeadersFromHashMap): (WebCore::cfURLRequest):
  • platform/network/cf/ResourceRequestCFNet.h: Added.
  • platform/network/cf/ResourceResponseCFNet.cpp: Added. (WebCore::getResourceResponse):
  • platform/network/cf/ResourceResponseCFNet.h: Added.
4:58 PM Changeset in webkit [22569] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Lou, Dave Hyatt.

<rdar://problem/4761639>
Group label in list box doesn't appear as bold


<rdar://problem/4805795>
<optgroup> labels should be bold in popup menus


  • platform/win/FontPlatformDataWin.cpp: (WebCore::enumStylesCallback): (WebCore::FontPlatformData::FontPlatformData): Enumerate the existing font styles and decide what to synthesize depending on what styles are available.
4:09 PM Changeset in webkit [22568] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Fix build.


  • WebCore.vcproj/WebCore.vcproj:
4:03 PM Changeset in webkit [17874] by andersca
  • 24 edits in trunk/WebCore

Reviewed by Mitz.

General SVG cleanup. Change some enums to match the style guidelines, use PLATFORM(CG) instead of PLATFORM(MAC).
Remove config.h inluce from AffineTransform.h


  • kcanvas/device/quartz/KRenderingDeviceQuartz.cpp: (WebCore::KRenderingDeviceQuartz::createPaintServer): (WebCore::KRenderingDeviceQuartz::createResource):
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::sharedSolidPaintServer):
  • ksvg2/svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::canvasResource):
  • ksvg2/svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::buildGradient):
  • ksvg2/svg/SVGLinearGradientElement.h: (WebCore::SVGLinearGradientElement::gradientType):
  • ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::fillAttributesFromReferencePattern): (WebCore::SVGPatternElement::canvasResource):
  • ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
  • ksvg2/svg/SVGRadialGradientElement.h: (WebCore::SVGRadialGradientElement::gradientType):
  • platform/graphics/AffineTransform.h:
  • platform/graphics/svg/SVGPaintServer.h: (WebCore::):
  • platform/graphics/svg/SVGPaintServerGradient.cpp: (WebCore::SVGPaintServerGradient::SVGPaintServerGradient): (WebCore::SVGPaintServerGradient::~SVGPaintServerGradient):
  • platform/graphics/svg/SVGPaintServerGradient.h:
  • platform/graphics/svg/SVGPaintServerLinearGradient.h: (WebCore::SVGPaintServerLinearGradient::type):
  • platform/graphics/svg/SVGPaintServerPattern.h: (WebCore::SVGPaintServerPattern::type):
  • platform/graphics/svg/SVGPaintServerRadialGradient.h: (WebCore::SVGPaintServerRadialGradient::type):
  • platform/graphics/svg/SVGPaintServerSolid.h: (WebCore::SVGPaintServerSolid::type):
  • platform/graphics/svg/SVGResource.h: (WebCore::):
  • platform/graphics/svg/cg/SVGPaintServerCg.cpp: (WebCore::SVGPaintServer::renderPath):
  • platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp: (WebCore::SVGPaintServerGradient::updateQuartzGradientCache): (WebCore::SVGPaintServerGradient::teardown): (WebCore::SVGPaintServerGradient::renderPath): (WebCore::SVGPaintServerGradient::setup):
  • platform/graphics/svg/cg/SVGPaintServerPatternCg.cpp: (WebCore::SVGPaintServerPattern::setup):
  • platform/graphics/svg/cg/SVGPaintServerSolidCg.cpp: (WebCore::SVGPaintServerSolid::setup):
  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
  • rendering/SVGInlineFlowBox.cpp: (WebCore::paintSVGInlineFlow):
3:15 PM Changeset in webkit [17873] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2006-11-21 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: [S60] "Opening a secure connection. Content cannot be seen by anyone else." -note shown 4 times when entering page.
http://bugs.webkit.org/show_bug.cgi?id=11670

  • ResourceLoader/src/HttpLoader.cpp: (CHttpLoader::CheckSecurityStatus):
3:11 PM Changeset in webkit [17872] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-21 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: [S60] "Opening a secure connection. Content cannot be seen by anyone else." -note shown 4 times when entering page.
http://bugs.webkit.org/show_bug.cgi?id=11670

  • ResourceLoader/src/HttpLoader.cpp: (CHttpLoader::CheckSecurityStatus):
10:14 AM Changeset in webkit [17871] by darin
  • 7 edits in trunk

WebKit:

Reviewed by Maciej.

  • make the close method do a more-complete job to prevent world leaks seen when running some of the layout tests
  • WebView/WebHTMLViewInternal.h: Added declaration of -[WebHTMLViewPrivate clear].
  • WebView/WebHTMLView.m: (-[WebHTMLViewPrivate clear]): Added method to drop references to other objects. We want to do this at "close" time, rather than waiting for deallocation time. This is especially important for the data source, which indirectly keeps a number of objects alive. (-[WebHTMLView close]): Added an explicit call to clear out the data source on the plug-in controller. Without this, we'd see the plug-in controller making calls to a deallocated data source during the layout tests. Added a call to the new clear method on the private object so that we release the objects at close time instead of waiting for deallocation time.
  • WebKit.xcodeproj/project.pbxproj: Let Xcode have its way with the project file, because I can't fight the power.

WebKitTools:

Reviewed by Maciej.

  • a couple changes to reduce the chance of false positives on the leakbot
  • DumpRenderTree/DumpRenderTree.m: (dumpRenderTree): Move the main function into a separate function so we can run a final garbage collect afterward without any stray values on the stack. Replaced the old way of closing down a WebView (setting the delegates to nil) with the new way (calling the close method), which does a more complete job of shutting everything down without waiting for the WebView object to be deallocated. (main): Put auto-release pool here and added an explicit call to garbage collect. With a separate function, we greatly reduce the chance that a stray address on the stack will keep an object alive.
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Let Xcode do its thing, because I don't have what it takes to fight the power.
4:22 AM Changeset in webkit [17870] by zimmermann
  • 26 edits
    22 adds
    19 deletes in trunk/WebCore

Reviewed by Oliver.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11658

Move KRenderingPaintServer* classes to the location
of all other resources (platform/graphics/svg).

4:08 AM Changeset in webkit [17869] by bdash
  • 3 edits
    4 adds in trunk

2006-11-21 Alex Taylor <darwin@techvisual.co.nz>

Reviewed by Mitz.

Pixel tests for border radius rendering bug

  • fast/borders/borderRadiusArcs01-expected.checksum: Added.
  • fast/borders/borderRadiusArcs01-expected.png: Added.
  • fast/borders/borderRadiusArcs01-expected.txt: Added.
  • fast/borders/borderRadiusArcs01.html: Added.

2006-11-21 Alex Taylor <darwin@techvisual.co.nz>

Reviewed by Mitz.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11587

Adds calculations for bottom right radius's position
which was being drawn incorrectly.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::paintBorder):
3:58 AM Changeset in webkit [17868] by bdash
  • 11 edits in trunk/WebKitSite

2006-11-21 Matt Lilek <pewtermoose@gmail.com>

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=11652
Bug 11652: Mailing list address and URL are incorrect

This also removes a lot of bit rot from the KWQ-era.

  • coding/contributing.html:
  • contact.html:
  • projects/css/index.html:
  • projects/editing/index.html:
  • projects/forms/index.html:
  • projects/html/index.html:
  • projects/portability/index.html:
  • projects/xslt/index.html:
  • quality/lifecycle.html:
  • quality/testwriting.html:
1:28 AM Changeset in webkit [17867] by rwlbuis
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=11519
REGRESSION: Disabled file upload control doesn't have disabled appearance, failing fast/forms/file-input-disabled.html

Transport disabled state from DOM element to the shadow
DOM/render object.

Nov 20, 2006:

11:23 PM Changeset in webkit [17866] by bdash
  • 1 edit in trunk/WebCore/loader/TextResourceDecoder.cpp

Build fix: silence warning about use before initialization.

3:27 PM Changeset in webkit [17865] by andersca
  • 6 edits in trunk/WebCore

Reviewed by Maciej.

  • loader/TextResourceDecoder.cpp: (WebCore::findXMLEncoding): Use CString instead of DeprecatedCString.


  • platform/CString.cpp: (WebCore::CString::find):
  • platform/CString.h: (WebCore::CString::data): Add find method, make data method inline.


  • platform/TextStream.cpp:
  • platform/TextStream.h: Remove DeprecatedCString functions.
2:35 PM Changeset in webkit [17864] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Use CString instead of DeprecatedCString.


  • html/FormDataList.cpp: (WebCore::FormDataList::appendString): (WebCore::fixLineBreaks): (WebCore::FormDataList::appendFile):
2:35 PM Changeset in webkit [17863] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-20 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: [S60] Dependencies to SystemSW Internal headers; Browser HttpCacheStreamHandler.cpp
http://bugs.webkit.org/show_bug.cgi?id=11657

  • ResourceLoader/CacheSrc/HttpCacheStreamHandler.cpp:
12:24 PM Changeset in webkit [17862] by ap
  • 10 edits in trunk

2006-11-20 W. Andy Carrel <wac@google.com>

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=11501
REGRESSION: \u no longer escapes metacharacters in RegExps
http://bugs.webkit.org/show_bug.cgi?id=11502
Serializing RegExps doesn't preserve Unicode escapes

JavaScriptCore:

  • kjs/lexer.cpp: (Lexer::Lexer): (Lexer::setCode): (Lexer::shift): (Lexer::scanRegExp): Push \u parsing back down into the RegExp object rather than in the parser. This backs out r17354 in favor of a new fix that better matches the behavior of other browsers.
  • kjs/lexer.h:
  • kjs/regexp.cpp: (KJS::RegExp::RegExp): (KJS::sanitizePattern): (KJS::isHexDigit): (KJS::convertHex): (KJS::convertUnicode):
  • kjs/regexp.h: Translate \u escaped unicode characters for the benefit of pcre.
  • kjs/ustring.cpp: (KJS::UString::append): Fix failure to increment length on the first UChar appended to a UString that was copy-on-write.
  • tests/mozilla/ecma_2/RegExp/properties-001.js: Adjust tests back to the uniform standards.

LayoutTests:

  • fast/js/kde/RegExp-expected.txt:
  • fast/js/regexp-unicode-handling-expected.txt: Adjust these test results to passing as a result of other included changes in this revision.
11:58 AM Changeset in webkit [17861] by bdash
  • 8 edits in trunk

2006-11-20 Samuel Weinig <sam@webkit.org>

Reviewed by Alexey.

Fix for http://bugs.webkit.org/show_bug.cgi?id=11656
Fix Windows build

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/ContextMenuClientWin.h:
  • bridge/win/EditorClientWin.h:
  • bridge/win/FrameWin.h:
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::ContextMenu::show): (WebCore::ContextMenuClientWin::copyLinkToClipboard): (WebCore::ContextMenuClientWin::downloadURL): (WebCore::ContextMenuClientWin::copyImageToClipboard): (WebCore::ContextMenuClientWin::lookUpInDictionary): (WebCore::EditorClientWin::shouldInsertText): (WebCore::FrameLoader::reload): (WebCore::FrameWin::ignoreSpelling): (WebCore::FrameWin::learnSpelling):

2006-11-20 Samuel Weinig <sam@webkit.org>

Reviewed by Alexey.

Fix for http://bugs.webkit.org/show_bug.cgi?id=11656
Fix Windows build

  • WebKit.vcproj/WebKit.vcproj: don't include directories that no longer exist.
11:56 AM Changeset in webkit [17860] by ap
  • 9 edits in trunk

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=10736
XMLHttpRequest.responseXML should be null on error

WebCore:

  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::wellFormed):
  • dom/XMLTokenizer.h: (WebCore::Tokenizer::wellFormed):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::implicitClose):
  • dom/Document.h: (WebCore::Document::wellFormed): Tell whether XMLTokenizer saw an error. Always true (success) for HTML.
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::getResponseXML): Set the document to null if it's not well-formed.

LayoutTests:

  • http/tests/xmlhttprequest/zero-length-response-expected.txt:
  • http/tests/xmlhttprequest/zero-length-response-sync-expected.txt: Updated the results for the new behavior.
10:59 AM Changeset in webkit [17859] by ap
  • 16 edits
    5 adds in trunk

Reviewed by Sam Weinig.

http://bugs.webkit.org/show_bug.cgi?id=11633
Implement XMLDocument properties xmlEncoding, xmlVersion, xmlStandalone

WebCore:

  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::setXMLVersion): (WebCore::Document::setXMLStandalone):
  • dom/Document.h: (WebCore::Document::xmlEncoding): (WebCore::Document::xmlVersion): (WebCore::Document::xmlStandalone): (WebCore::Document::setXMLEncoding):
  • dom/Document.idl:
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::startDocument): (WebCore::startDocumentHandler): (WebCore::XMLTokenizer::initializeParserContext): Added support for these properties, getting them from an libxml2 context.
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::HTMLDocument): HTMLDocument is the only kind of document that doesn't have xmlVersion default to "1.0".
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm: Added WK_ucfirst to properly uppercase xmlVersion and xmlStandalone.

LayoutTests:

  • dom/xhtml/level3/core/documentgetxmlencoding01-expected.txt:
  • dom/xhtml/level3/core/documentgetxmlencoding03-expected.txt
  • dom/xhtml/level3/core/documentgetxmlstandalone04-expected.txt:
  • dom/xhtml/level3/core/documentgetxmlversion01-expected.txt:
  • dom/xhtml/level3/core/documentgetxmlversion02-expected.txt:
  • dom/xhtml/level3/core/documentgetxmlversion03-expected.txt: These now pass.
  • dom/xhtml/level3/core/documentgetxmlencoding03.xhtml: Re-added a correct test.
  • fast/dom/Window/window-properties-expected.txt: Added these new properties.
  • http/tests/xmlhttprequest/xml-encoding-expected.txt: Added.
  • http/tests/xmlhttprequest/xml-encoding.html: Added.
  • http/tests/xmlhttprequest/resources/xml-encoding.xml: Added.
  • http/tests/xmlhttprequest/resources/post-echo-as-utf-8.cgi: Added. Test how xmlEncoding interacts with XMLHttpRequest.
8:12 AM Changeset in webkit [17858] by zimmermann
  • 9 edits in trunk/WebCore

Reviewed by Rob.
Fix Qt/Linux build.

7:42 AM Writing Layout Tests for DumpRenderTree edited by mitz@webkit.org
(diff)
5:14 AM Changeset in webkit [17857] by bdash
  • 1 add in trunk/WebCore/platform/graphics/svg/qt/SVGResourceFilterQt.cpp

Qt build fix after r17853: add missing SVGResourceFilterQt.cpp.

4:59 AM Changeset in webkit [17856] by bdash
  • 7 edits in trunk

2006-11-20 Samuel Weinig <sam@webkit.org>

Reviewed by Maciej.

Fix for http://bugs.webkit.org/show_bug.cgi?id=11647
Fix Win32 build

  • kjs/config.h: define NOMINMAX instead of min/max as themselves.
  • wtf/Vector.h: put back hack to ensure that min/max are not defined as macros.

2006-11-20 Samuel Weinig <sam@webkit.org>

Reviewed by Maciej.

Fix for http://bugs.webkit.org/show_bug.cgi?id=11647
Fix Win32 build

  • config.h: add #define NOMINMAX for windows build
  • platform/win/FontCacheWin.cpp: (WebCore::FontCache::createFontPlatformData):
  • platform/win/TemporaryLinkStubs.cpp: add definitions for new cursors. (WebCore::aliasCursor): (WebCore::noDropCursor): (WebCore::progressCursor):
2:13 AM Changeset in webkit [22567] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Add the same include paths to the debug build.


  • WebCore.vcproj/WebCore.vcproj:
1:42 AM Changeset in webkit [22566] by andersca
  • 2 edits
    1 move in branches/WindowsMerge/WebCore

Fix build.


  • WebCore.vcproj/WebCore.vcproj:
  • kcanvas/device/quartz/KCanvasFilterQuartz.cpp: Removed.
  • platform/graphics/svg/cg/SVGResourceFilterCg.cpp: Added. (WebCore::SVGResourceFilter::SVGResourceFilter): (WebCore::SVGResourceFilter::~SVGResourceFilter): (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter):
1:39 AM Changeset in webkit [22565] by andersca
  • 3 edits in branches/WindowsMerge/WebKitWin

Fix build.


  • WebEditorClient.cpp: (WebEditorClient::shouldInsertNode): (WebEditorClient::shouldInsertText):
  • WebEditorClient.h:
Note: See TracTimeline for information about the timeline view.