Timeline



Nov 28, 2006:

11:43 PM Changeset in webkit [22589] by adachan
  • 14 edits
    3 adds in branches/WindowsMerge/WebKitWin

2006-11-28 Ada Chan <​adachan@apple.com>

Reviewed by Adam.


WebKitWin:

<rdar://4850020> Clear cache in WebKit

  • Added the IWebCache interface, which contains API to clear and disable the cache
  • Added implementation of WebCache which implements IWebCache.
  • the page cache related calls added in WebHistoryItem are just stubs right now because we haven't implemented page cache yet.
11:25 PM Changeset in webkit [17920] by aliceli1
  • 6 edits in trunk

WebCore:

Reviewed by Maciej.

A fix for a couple failing layout tests involving copy/cut in iframes.

  • bridge/EditorClient.h: Add frame parameter to dataForArchivedSelectionInFrame instead of just getting the webview's selectedFrame.
  • platform/mac/PasteboardMac.mm: (Pasteboard::writeSelection): Pass in the frame

WebKit:

Reviewed by Maciej.

A fix for a couple failing layout tests involving copy/cut in iframes.

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::dataForArchivedSelection): Use the frame parameter instead of using the webview's selectedFrame.
10:42 PM Changeset in webkit [17919] by bdakin
  • 2 edits in trunk/WebKit

Reviewed by Geoffff.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11691 REGRESSION
(r17399, r17511): WebElementDictionary no longer returns nil
NSStrings

String's NSString* operator converts null Strings to empty
NSStrings for compatibility with AppKit. We need to work around
that here.

  • Misc/WebElementDictionary.m: (NSStringOrNil): (-[WebElementDictionary _altDisplayString]): (-[WebElementDictionary _spellingToolTip]): (-[WebElementDictionary _title]): (-[WebElementDictionary _titleDisplayString]): (-[WebElementDictionary _textContent]):
10:18 PM Changeset in webkit [22588] by ggaren
  • 5 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Beth Dakin.

Fixed <rdar://problem/4844855> Should clarify when to create clients in
the WebCore client API


All clients must now be supplied as constructor arguments. This clarifies
when you need to create clients, and also guarantees that objects can't
(for the most part) be in a clientless state.

Layout tests pass. No leaks reported.


  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
  • bridge/win/FrameWin.h:

WebKitWin:

Reviewed by Beth Dakin.

Fixed <rdar://problem/4844855> Should clarify when to create clients in
the WebCore client API


All clients must now be supplied as constructor arguments. This clarifies
when you need to create clients, and also guarantees that objects can't
(for the most part) be in a clientless state.

Layout tests pass. No leaks reported.


  • WebFrame.cpp: (WebFrame::initWithWebFrameView):
10:11 PM Changeset in webkit [17918] by ggaren
  • 17 edits in trunk

WebCore:

Reviewed by Beth Dakin.

Fixed <rdar://problem/4844855> Should clarify when to create clients in
the WebCore client API


All clients must now be supplied as constructor arguments. This clarifies
when you need to create clients, and also guarantees that objects can't
(for the most part) be in a clientless state.

Layout tests pass. No leaks reported.


  • bridge/mac/WebCoreFrameBridge.mm: I had to move some initialization up into WebKit to resolve circular dependencies at init time.

WebKit:

Reviewed by Beth Dakin.

Fixed <rdar://problem/4844855> Should clarify when to create clients in
the WebCore client API


All clients must now be supplied as constructor arguments. This clarifies
when you need to create clients, and also guarantees that objects can't
(for the most part) be in a clientless state.

Layout tests pass. No leaks reported.


  • WebCoreSupport/WebFrameBridge.mm: Shuffled around initialization and changed some arguments to resolve ciruclar dependencies at init time. (-[WebFrame _initWithWebFrameView:webView:bridge:]): We no longer call setClient here, because the client is set up at construction time.
8:25 PM Changeset in webkit [22587] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Ada.

Add platform-specific constructor/destructor to ContextMenu so we can
properly dispose of the HMENU.

  • platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::~ContextMenu): (WebCore::ContextMenu::itemCount): (WebCore::ContextMenu::insertItem): (WebCore::ContextMenu::at): (WebCore::ContextMenu::setPlatformDescription): (WebCore::ContextMenu::show):
8:19 PM Changeset in webkit [17917] by aroben
  • 3 edits in trunk/WebCore

Reviewed by Ada.

Add platform-specific constructor/destructor to ContextMenu so we can
properly retain/release the platform menu description.

  • platform/ContextMenu.h: (WebCore::ContextMenu::platformDescription):
  • platform/mac/ContextMenuMac.mm: (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::~ContextMenu): (WebCore::getNSMenuItem): (WebCore::ContextMenu::appendItem): (WebCore::ContextMenu::itemCount): (WebCore::ContextMenu::insertItem): (WebCore::ContextMenu::setPlatformDescription):
7:27 PM Changeset in webkit [22586] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-11-28 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Geoff.


Make COM registration fall back to per-user for Vista LUA compatibility.

  • WebKitDLL.cpp:
7:24 PM Changeset in webkit [22585] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

7:15 PM Changeset in webkit [17916] by brmorris
  • 2 edits in S60/trunk/S60Tools

2006-11-28 brmorris <​bradley.morrison@nokia.com>

Reviewed by Sasha.

  • S60WebKitPlatformBuild.pl: Utility fixes.
6:30 PM Changeset in webkit [17915] by zbujtas
  • 3 edits in S60/branches/3.1m/WebCore

2006-11-27 shkeller <​shaun.keller@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: Fix geometry calculations for tabbed navigation.
​http://bugs.webkit.org/show_bug.cgi?id=11678
Merged from 3.2 17914
WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::getNewTabbedCursorPosition): (KWQKHTMLPart::tabbedNavigation):
  • kwq/KWQKHTMLPart.h:
6:15 PM Changeset in webkit [22584] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2006-11-28 Steve Falkenburg <​sfalken@apple.com>

B&I build fix

  • WebCore.vcproj/WebCore.vcproj:
6:09 PM Changeset in webkit [17914] by zbujtas
  • 3 edits in S60/trunk/WebCore

2006-11-22 shkeller <​shaun.keller@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: Fix geometry calculations for tabbed navigation.
​http://bugs.webkit.org/show_bug.cgi?id=11678

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::getNewTabbedCursorPosition): (KWQKHTMLPart::tabbedNavigation):
  • kwq/KWQKHTMLPart.h:
5:51 PM Changeset in webkit [17913] by aroben
  • 2 edits in trunk/WebCore

Build fix.

  • platform/network/mac/ResourceRequestMac.mm:
5:24 PM Changeset in webkit [17912] by harrison
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Adele.

<rdar://problem/4852804> selection color does not get drawn over the missing image rectangle

  • editing/selection/select-missing-image-expected.checksum: Added.
  • editing/selection/select-missing-image-expected.png: Added.
  • editing/selection/select-missing-image-expected.txt: Added.
  • editing/selection/select-missing-image.html: Added.

WebCore:

Reviewed by Adele.

<rdar://problem/4852804> selection color does not get drawn over the missing image rectangle

Test:

  • editing/selection/select-missing-image.html: Added.
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint): Draw the selection tint even if the image itself is not available.
5:23 PM Changeset in webkit [22583] by andersca
  • 5 edits in branches/WindowsMerge/WebCore

Fix the build by doing the same changes that were done in the open source WebCore repo.


  • WebCore.vcproj/WebCore.vcproj:
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): (WebCore::didReceiveResponse): (WebCore::ResourceHandle::start):
  • platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::cfURLRequest): (WebCore::addHeadersFromHashMap): (WebCore::ResourceRequest::doUpdatePlatformRequest): (WebCore::ResourceRequest::doUpdateResourceRequest):
  • platform/network/cf/ResourceRequestCFNet.h:
5:15 PM Changeset in webkit [17911] by andersca
  • 11 edits
    1 add
    1 delete in trunk

WebCore:

Reviewed by Maciej.

Have ResourceRequest hold on to the platform object so we don't
have to convert back and forth when nothing in the object changes.

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::continueAfterNavigationPolicy):
  • page/Chrome.cpp: (WebCore::Chrome::pageRect):
  • platform/network/ResourceRequest.cpp: Added. (WebCore::ResourceRequest::isEmpty): (WebCore::ResourceRequest::url): (WebCore::ResourceRequest::setURL): (WebCore::ResourceRequest::cachePolicy): (WebCore::ResourceRequest::setCachePolicy): (WebCore::ResourceRequest::timeoutInterval): (WebCore::ResourceRequest::setTimeoutInterval): (WebCore::ResourceRequest::mainDocumentURL): (WebCore::ResourceRequest::setMainDocumentURL): (WebCore::ResourceRequest::httpMethod): (WebCore::ResourceRequest::setHTTPMethod): (WebCore::ResourceRequest::httpHeaderFields): (WebCore::ResourceRequest::httpHeaderField): (WebCore::ResourceRequest::setHTTPHeaderField): (WebCore::ResourceRequest::httpBody): (WebCore::ResourceRequest::setHTTPBody): (WebCore::ResourceRequest::allowHTTPCookies): (WebCore::ResourceRequest::setAllowHTTPCookies): (WebCore::ResourceRequest::updatePlatformRequest): (WebCore::ResourceRequest::updateResourceRequest): (WebCore::ResourceRequest::addHTTPHeaderField): (WebCore::ResourceRequest::addHTTPHeaderFields):
  • platform/network/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::willSendRequest):
  • platform/network/mac/ResourceRequestMac.h: Removed.
  • platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::nsURLRequest): (WebCore::ResourceRequest::doUpdateResourceRequest): (WebCore::ResourceRequest::doUpdatePlatformRequest):

WebKit:

Reviewed by Maciej.

Update for changes to ResourceRequest.


  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::createWindow): (WebChromeClient::createModalDialog):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::canHandleRequest):
4:49 PM Changeset in webkit [22582] by aroben
  • 15 edits
    1 add in branches/WindowsMerge

WebCoreWin:

Reviewed by Ada and Beth.

Fix: <rdar://problem/4601523> Contextual Menus (in web content)

  • WebCore.vcproj/WebCore.vcproj: Defined WEBCORE_CONTEXT_MENUS to turn on the context menus. Added new ContextMenuItem files.
  • platform/win/ContextMenuItemWin.cpp: Added. (WebCore::ContextMenuItem::ContextMenuItem):
  • platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::itemCount): Updated to match ContextMenu.h and ContextMenuItem changes. (WebCore::ContextMenu::insertItem): Ditto. (WebCore::ContextMenu::appendItem): Ditto. (WebCore::ContextMenu::at): New method, similar to Vector<T>::at. (WebCore::ContextMenu::setPlatformDescription): Use MIM_APPLYTOSUBMENUS to make sure all submenus get the MNS_NOTIFYBYPOS style. (WebCore::ContextMenu::show): Implemented.

Updates to match OpenSource changes.

  • loader/win/FrameLoaderWin.cpp: Added missing #include.
  • page/win/EventHandlerWin.cpp: Return bools to signify whether the event was handled. (WebCore::EventHandler::passMousePressEventToSubframe): (WebCore::EventHandler::passMouseMoveEventToSubframe): (WebCore::EventHandler::passMouseReleaseEventToSubframe): (WebCore::EventHandler::passWheelEventToSubframe): (WebCore::EventHandler::passMousePressEventToScrollbar):
  • platform/win/PlatformScrollBar.h: Ditto.
  • platform/win/PlatformScrollBarWin.cpp: Ditto. (WebCore::PlatformScrollbar::handleMouseMoveEvent): (WebCore::PlatformScrollbar::handleMouseOutEvent): (WebCore::PlatformScrollbar::handleMousePressEvent): (WebCore::PlatformScrollbar::handleMouseReleaseEvent):

Small fix inspired by WebView.cpp changes.

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::calculatePositionAndSize): Use ::ClientToScreen to do coordinate conversion instead of doing it ourselves.

WebKitWin:

Reviewed by Ada and Beth.

Fix: <rdar://problem/4601523> Contextual Menus (in web content)

  • Interfaces/IWebUIDelegate.idl: Added a new delegate method to be called when the user clicks on one of the application's context menu items.

Client updates from WebCore.

  • WebContextMenuClient.cpp: (WebContextMenuClient::addCustomContextMenuItems): Updated for method name changes. (WebContextMenuClient::contextMenuItemSelected): New client method that calls the UI delegate.
  • WebContextMenuClient.h: Updated to match ContextMenuClient.h

Windows context menu event handling.

  • WebView.cpp: (WebView::handleContextMenuEvent): New method to send a context menu event down into WebCore. (WebView::performContextMenuAction): New method to tell the ContextMenuController that the user clicked on a context menu item. (WebView::handleMouseEvent): Return a bool to signify whether the event was handled. (WebView::mouseWheel): Ditto. (WebViewWndProc): Handle WM_CONTEXTMENU and WM_MENUCOMMAND messages, and pass unhandled events to DefWindowProc.
  • WebView.h: New declarations.

Small (but necessary) fixes.

  • WebElementPropertyBag.cpp: (isEqual): Fixed to deal with LPCWSTRs, which is what was being passed in anyway. (WebElementPropertyBag::Read): Use FAILED() to check the return value of QueryInterface.
  • WebElementPropertyBag.h: Added missing #include.
4:42 PM Changeset in webkit [17910] by aroben
  • 23 edits
    1 copy
    1 add in trunk

WebCore:

Reviewed by Beth.

More WebCore context menu work (still not turned on, however).

Split ContextMenuItem into its own files and make it a class.

  • WebCore.exp: Updated symbols.
  • WebCore.xcodeproj/project.pbxproj: Added new ContextMenuItem files.
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): Code cleanup.
  • platform/ContextMenu.h: Split ContextMenuItem into a separate file, removed redundant "Menu" part of platformMenuDescription(), setPlatformMenuDescription(). (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::hitTestResult): (WebCore::ContextMenu::platformDescription):
  • platform/ContextMenuItem.h: Added. Made ContextMenuItem a full-fledged class. (WebCore::): (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::menu): (WebCore::ContextMenuItem::platformDescription): (WebCore::ContextMenuItem::type): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::title):
  • platform/mac/ContextMenuItemMac.mm: Added. (WebCore::ContextMenuItem::ContextMenuItem):
  • platform/mac/ContextMenuMac.mm: Updated for ContextMenuItem changes. (-[MenuTarget forwardContextMenuAction:]): (getNSMenuItem): Handle separator items. (ContextMenu::appendItem): (ContextMenu::itemCount): (ContextMenu::insertItem): (ContextMenu::setPlatformDescription):
  • page/ContextMenuController.h: Updated declaration, added getter. (WebCore::ContextMenuController::contextMenu):

Added some more context menu plumbing.

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): Added code to call the ContextMenuController when a context menu event is received.
  • page/ContextMenuClient.h: New client method declaration.
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::handleContextMenuEvent): Set the event defaultHandled after handling it. (WebCore::ContextMenuController::contextMenuItemSelected): Take a ContextMenuItem instead of a separate action and title.

Changed event-handling methods to return bools to signify whether the
event was handled or not. This is needed so we can know whether to hand
the event off to the OS. Also restructured some code to use early
returns instead of nesting ifs.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEventDoubleClick): (WebCore::EventHandler::handleMousePressEventTripleClick): (WebCore::EventHandler::handleMousePressEventSingleClick): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::handleMouseReleaseEvent): (WebCore::EventHandler::handleMouseDoubleClickEvent): (WebCore::EventHandler::handleWheelEvent): (WebCore::EventHandler::canMouseDownStartSelect):
  • page/EventHandler.h:
  • page/FrameView.cpp: (WebCore::FrameView::handleMouseMoveEvent): (WebCore::FrameView::handleMouseReleaseEvent):
  • page/FrameView.h:
  • platform/ScrollBar.h: More bool return values. (WebCore::Scrollbar::handleMouseMoveEvent): (WebCore::Scrollbar::handleMouseOutEvent):
  • platform/Widget.h: Ditto. (WebCore::Widget::handleMouseMoveEvent): (WebCore::Widget::handleMouseReleaseEvent):

Reverted the changes made in r17805 so that we can have fewer header
#includes.

  • page/Page.cpp: (WebCore::Page::Page):
  • page/Page.h: Ditto. (WebCore::Page::dragCaretController): (WebCore::Page::chrome): (WebCore::Page::contextMenuController):

WebKit:

Reviewed by Beth.

More WebCore context menu work.

  • DefaultDelegates/WebDefaultUIDelegate.m: New stub delegate method implementation. (-[NSApplication webView:contextMenuItemSelected:forElement:]):
  • WebCoreSupport/WebContextMenuClient.h: Updated to match ContextMenuClient.h changes.
  • WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::addCustomContextMenuItems): Updated for method name changes. (WebContextMenuClient::contextMenuItemSelected): Added new client method.
  • WebView/WebUIDelegatePrivate.h: New private delegate method declaration.
4:12 PM Changeset in webkit [22581] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.


<rdar://problem/4850883>
Crash loading pdf page (W4 form)


  • platform/win/TemporaryLinkStubs.cpp: (FrameLoader::redirectDataToPlugin):
  • loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::redirectDataToPlugin): Move the function to FrameLoaderWin.cpp and get rid of STOP_NOIMPL() for now, we do things differently on Windows so this function doesn't need do do anything. I've filed 4852889 about redoing this once the loader has been ported.
2:14 PM Changeset in webkit [22580] by aliceli1
  • 6 edits
    4 adds in branches/WindowsMerge

WebCoreWin:

Reviewed by Ada, Adam, and Lou.

  • WebCore.vcproj/WebCore.vcproj: Added the files listed below


  • platform/win/ClipboardWin.h: Added.
  • platform/win/ClipboardWin.cpp: Added. Added the minimum stubs for the ClipboardWin class (WebCore::ClipboardWin::isForDragging): (WebCore::ClipboardWin::dropEffect): (WebCore::ClipboardWin::setDropEffect): (WebCore::ClipboardWin::effectAllowed): (WebCore::ClipboardWin::setEffectAllowed): (WebCore::ClipboardWin::clearData): (WebCore::ClipboardWin::clearAllData): (WebCore::ClipboardWin::getData): (WebCore::ClipboardWin::setData): (WebCore::ClipboardWin::types): (WebCore::ClipboardWin::dragLocation): (WebCore::ClipboardWin::dragImage): (WebCore::ClipboardWin::setDragImage): (WebCore::ClipboardWin::dragImageElement): (WebCore::ClipboardWin::setDragImageElement): (WebCore::ClipboardWin::setAccessPolicy): (WebCore::ClipboardWin::~ClipboardWin):
  • platform/win/EditorWin.cpp: Added. Added this to make dispatchCPPEvent happy. (WebCore::Editor::newGeneralClipboard):
  • platform/win/PasteboardWin.cpp: Added. The pasteboard class follows a singleton pattern Implemented the following to support CF_HTML, CF_UNICODE, and CF_TEXT (WebCore::Pasteboard::generalPasteboard): (WebCore::Pasteboard::Pasteboard): (WebCore::Pasteboard::~Pasteboard): (WebCore::Pasteboard::registerSelectionPasteboardTypes): (WebCore::Pasteboard::clearTypes): (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::createHandleFromString): (WebCore::Pasteboard::createHandleFromCString): (WebCore::Pasteboard::createCF_HTMLFromRange): (WebCore::Pasteboard::replaceNBSP): (WebCore::Pasteboard::canSmartReplace): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment): (WebCore::PasteboardOwnerWndProc):

WebKitWin:

Reviewed by Ada, Adam, and Lou.

  • WebEditorClient.h:
  • WebEditorClient.cpp: These 3 functions are, for now, hard-coded to return true, letting paste work. Commented out previous unused code because the app would crash if the editingDelegate was called (WebEditorClient::shouldDeleteRange): (WebEditorClient::shouldInsertNode): (WebEditorClient::shouldInsertText): stub impl for: (WebEditorClient::smartInsertDeleteEnabled):
  • WebView.cpp: moved where cut/copy/paste was handled from (WebView::execCommand): (WebViewWndProc):


call the editor's version of these 4:
(WebView::copy):
(WebView::cut):
(WebView::paste):
(WebView::delete_):

2:06 PM Changeset in webkit [22579] by ggaren
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Anders Carlsson.

Fixed <rdar://problem/4844863> REGRESSION: screen flashes when scrolling/
resizing page with plug-in (@ cnn.com, for example).

LockWindowUpdate was to blame. It turns out that using LockWindowUpdate
was wrong to begin with. It's really only intended for use in drag-n-drop
operations, which explains why only one window can be locked at a time.
(See ​http://blogs.msdn.com/oldnewthing/archive/2004/06/10/152612.aspx.)


The new solution I've implemented for avoiding plug-in fragments while scrolling
is simply to clip the plug-in to the zero rect before moving it, and
then to un-clip it when done.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::updateHwnd):
2:05 PM Changeset in webkit [17909] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-28 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: [S60] browser fails to run the script when the page saved
​http://bugs.webkit.org/show_bug.cgi?id=11706

  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::LoadSavedPageL):
2:02 PM Changeset in webkit [17908] by aliceli1
  • 17 edits
    1 move
    5 adds in trunk

WebCore:

Reviewed by Justin and Adam.

All layout tests pass as they do without this patch

  • WebCore.exp: Exposed functions in Editor and removed functions in FrameMac due to changes in WebHTMLView.m
  • WebCore.xcodeproj/project.pbxproj: Added Pasteboard.h, PasteboardMac.mm, WebNSAttributedStringExtras.h&mm, EditorMac.mm
  • bridge/EditorClient.h: Added smartInsertDeleteEnabled and shouldInsertNode and some mac-specific functions
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: Removed dispatchCPPEvent and [can|try]DHTML[cut|copy|paste] since the Editor's are called now
  • dom/CharacterData.h: (WebCore::CharacterData::isCharacterDataNode):
  • dom/Node.h: (WebCore::Node::isCharacterDataNode): Added a type-identifying function to Node and the proper subclass
  • dom/Clipboard.h: Exposed setAccessPolicy as public


  • editing/Editor.h:
  • editing/Editor.cpp: Implemented the following (WebCore::Editor::canDHTMLCut): (WebCore::Editor::canDHTMLCopy): (WebCore::Editor::canDHTMLPaste): (WebCore::Editor::canSmartCopyOrDelete): (WebCore::Editor::deleteSelection): (WebCore::Editor::pasteAsPlainTextWithPasteboard): (WebCore::Editor::pasteWithPasteboard): (WebCore::Editor::canSmartReplaceWithPasteboard): (WebCore::Editor::shouldInsertFragment): (WebCore::Editor::replaceSelectionWithFragment): (WebCore::Editor::replaceSelectionWithText): (WebCore::Editor::selectedRange): (WebCore::Editor::shouldDeleteRange): (WebCore::Editor::tryDHTMLCopy): (WebCore::Editor::tryDHTMLCut): (WebCore::Editor::tryDHTMLPaste): (WebCore::Editor::writeSelectionToPasteboard): (WebCore::Editor::dispatchCPPEvent): (WebCore::Editor::cut): (WebCore::Editor::copy): (WebCore::Editor::paste):


  • platform/mac/ClipboardAccessPolicy.h: Removed. Not removed, but moved to dom/ClipboardAccessPolicy.h


  • platform/mac/EditorMac.mm: Added. (WebCore::Editor::newGeneralClipboard):
  • platform/Pasteboard.h: Added.
  • platform/mac/PasteboardMac.mm: Added. The pasteboard class follows a singleton pattern (Pasteboard::generalPasteboard): (Pasteboard::~Pasteboard): (Pasteboard::Pasteboard): (Pasteboard::clearTypes): (Pasteboard::writeSelection): (Pasteboard::selectionPasteboardTypes): (Pasteboard::canSmartReplace): (Pasteboard::plainText): (Pasteboard::documentFragment):


  • platform/mac/WebNSAttributedStringExtras.h: Added.
  • platform/mac/WebNSAttributedStringExtras.mm: Added. Added select portions of this file from WebKit because the pasteboard needed the following function: (-[NSAttributedString _web_attributedStringByStrippingAttachmentCharacters]):

WebKit:

Reviewed by Justin and Adam.

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: added the following (WebEditorClient::smartInsertDeleteEnabled): (WebEditorClient::dataForArchivedSelectionInFrame): (WebEditorClient::_web_userVisibleString): (WebEditorClient::shouldInsertNode):


  • WebKitPrefix.h: Added flags to control whether WebCore cut/copy/paste is enabled. Turned on Cut and Copy, left Paste and Delete off


  • WebView/WebHTMLViewPrivate.h:
  • WebView/WebHTMLView.m: removed _can[Cut|Copy|Paste|Delete] (-[NSArray validateUserInterfaceItem:]): call the editor for canDHTML[C|C|P|D] and _can[C|C|P|D] instead (-[NSArray delete:]): added code to call the editor's delete instead (not turned on) (-[WebHTMLView copy:]): added code to call the editor's copy (turned on) (-[WebHTMLView cut:]): added code to call the editor's cut (turned on) (-[WebHTMLView paste:]): added code to call the editor's paste (not turned on)
1:25 PM Changeset in webkit [17907] by justing
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/4397952>
Cannot select buttons at the end of a document, preventing copy/paste

  • editing/selection/4397952-expected.checksum: Added.
  • editing/selection/4397952-expected.png: Added.
  • editing/selection/4397952-expected.txt: Added.
  • editing/selection/4397952.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/4397952>
Cannot select buttons at the end of a document, preventing copy/paste


There were no VisiblePositions before/after buttons because editingIgnoresContent
returned false for buttons.

  • dom/Position.cpp: (WebCore::Position::upstream): Fixed a comment. (WebCore::Position::downstream): Ditto.
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd): Ditto.
  • editing/htmlediting.cpp: (WebCore::editingIgnoresContent): It's unnecessary to prefer renderer checks over tag name checks because it seems that a node of a tag name that we do not ignore content for can't have a renderer of a type that we do. (WebCore::canHaveChildrenForEditing): Added selects, buttons, applets, and embeds.
  • editing/visible_units.cpp: (WebCore::previousLinePosition): Migrate to enclosingBlock. Fixes a bug where the caret would get stuck moving up/down a line from a caret just before an input element. (WebCore::nextLinePosition): Ditto.
11:00 AM Changeset in webkit [22578] by ggaren
  • 14 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

Fixed <rdar://problem/4844848> REGRESSION: extra cross-library ref/deref
calls cause .5% PLT regression.


Changed ref/deref calls to a single 'xxxDestroyed' call. Moved EditorClient
from the Frame to the Page, since it's only responsible for
Webview-level delegate calls.


I don't really love this design, but it fixes the regression and allows
a single WebKit object to implement multiple client interfaces.


Layout tests pass.

WebKitWin:

Reviewed by Adam.

Fixed <rdar://problem/4844848> REGRESSION: extra cross-library ref/deref
calls cause .5% PLT regression.


Changed ref/deref calls to a single 'xxxDestroyed' call. Moved EditorClient
from the Frame to the Page, since it's only responsible for
Webview-level delegate calls.


I don't really love this design, but it fixes the regression and allows
a single WebKit object to implement multiple client interfaces.


Layout tests pass.

10:54 AM Changeset in webkit [17906] by ggaren
  • 36 edits
    1 delete in trunk

WebCore:

Reviewed by Adam.

Fixed <rdar://problem/4844848> REGRESSION: extra cross-library ref/deref
calls cause .5% PLT regression.


Changed ref/deref calls to a single 'xxxDestroyed' call. Moved EditorClient
from the Frame to the Page, since it's only responsible for
Webview-level delegate calls.


I don't really love this design, but it fixes the regression and allows
a single WebKit object to implement multiple client interfaces.


Layout tests pass.

WebKit:

Reviewed by Adam.

Fixed <rdar://problem/4844848> REGRESSION: extra cross-library ref/deref
calls cause .5% PLT regression.


Changed ref/deref calls to a single 'xxxDestroyed' call. Moved EditorClient
from the Frame to the Page, since it's only responsible for
Webview-level delegate calls.


I don't really love this design, but it fixes the regression and allows
a single WebKit object to implement multiple client interfaces.


Layout tests pass.

9:21 AM Changeset in webkit [17905] by spadma
  • 33 edits in S60/trunk

2006-11-17 vbradley <​vincent.bradley@nokia.com>

Reviewed by Sachin.
DESC: Removed the obsolete flags RD_32_BROWSER and RD_BROWSER_VIDEO_PLUGIN
​http://bugs.webkit.org/show_bug.cgi?id=11604

  • BrowserControl/inc/BrCtlDefs.h: (TBrCtlDefs::):
  • BrowserControl/src/BrCtl.cpp: (CBrCtl::HandleCommandL): (CBrCtl::CountComponentControls): (CBrCtl::ComponentControl):
  • BrowserCore/Formcontrols/inc/FControlInputWidget.h:
  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::ActivateL):
  • BrowserCore/Formcontrols/src/FControlInputWidget.cpp: (CControlInputWidget::ConstructTextEditorL): (CControlInputWidget::OfferKeyEventL): (CControlInputWidget::SetWebKitCursorPosition):
  • BrowserCore/Misc/src/CannedImages.cpp: (CCannedImages::GetImage):
  • BrowserView/inc/BrowserSettingsContainer.h:
  • BrowserView/inc/SmartLinkHandler.h:
  • BrowserView/inc/WebKitControl.h:
  • BrowserView/inc/WebKitCursor.h:
  • BrowserView/inc/WebKitFrame.h:
  • BrowserView/inc/WebKitView.h:
  • BrowserView/src/BrowserSettingsContainer.cpp: (CBrowserSettingsContainer::InsertDefaultSettingsL):
  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleArrowKeysL): (CKeyEventHandler::HandleActivateKeysL):
  • BrowserView/src/SmartLinkHandler.cpp: (CSmartLinkHandler::~CSmartLinkHandler): (CSmartLinkHandler::PrepareAiwHandlerL): (CSmartLinkHandler::HandleMakeCall):
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::~CWebKitControl): (CWebKitControl::SetBrowserSettingL): (CWebKitControl::GetBrowserSettingL): (CWebKitControl::PageInfoLC): (CWebKitControl::ProgressCompleted):
  • BrowserView/src/WebKitCursor.cpp: (CWebKitCursor::ConstructL): (CWebKitCursor::CursorUpdate): (CWebKitCursor::MoveCursorAdjusted): (CWebKitCursor::GetSmartLinkEntry): (CWebKitCursor::CalcSearchRect):
  • BrowserView/src/WebKitFrame.cpp: (CWebKitFrame::ConstructL): (CWebKitFrame::~CWebKitFrame):
  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
  • BrowserView/src/WebKitView.cpp: (CWebKitView::CWebKitView): (CWebKitView::ZoomLevelChanged): (CWebKitView::FindNextSmartLink):
  • Plugin/inc/PluginSkin.h: (CPluginSkin::CanInteract):
  • Plugin/inc/PluginWin.h:
  • Plugin/src/PluginWin.cpp:
  • ResourceLoader/src/HttpDownloadObserver.cpp: (CHttpDownloadObserver::InitDownloadMgrL): (CHttpDownloadObserver::HandleDMgrCompletedEventL):
  • data/Webkit.loc:
  • data/Webkit.rss:
  • data/Webkit_sdk.loc:
  • data/Webkit_sdk.rss:
  • group/BrowserView.mmp:
  • group/webkit.mmp:

Nov 27, 2006:

11:06 PM Changeset in webkit [17904] by andersca
  • 2 edits in trunk/WebCore

2006-11-27 Anders Carlsson <​acarlsson@apple.com>

Try fixing the build.


  • platform/graphics/IntRect.cpp: (WebCore::IntRect::IntRect):
10:34 PM Changeset in webkit [22577] by bdakin
  • 6 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

Stub out functions in order to remove FIXMEs from ContextMenu.cpp

  • bridge/win/FrameWin.h: Spell checker functions pushed down from WebKit.
  • platform/win/TemporaryLinkStubs.cpp: Stubs for spelling functions. (WebCore::FrameWin::isSelectionMisspelled): (WebCore::FrameWin::guessesForMisspelledSelection):

WebKitWin:

Reviewed by Adam.

Stub for canHandleRequest() to remove FIXME from ContextMenu.cpp

  • WebFrame.cpp: (WebFrame::canHandleRequest):
  • WebFrame.h:
10:26 PM Changeset in webkit [17903] by bdakin
  • 13 edits in trunk

WebCore:

Reviewed by Adam.

Getting rid of some of the critical FIXMEs in ContextMenu.cpp.

  • bridge/mac/FrameMac.h: Two new spell checker functions from WebKit. (We will be able to delete the WebKit versions once we switch over to WebCore context menus.)
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::isSelectionMisspelled): (WebCore::core): Convert from NSArray of Strings to a Vector of Strings. (WebCore::FrameMac::guessesForMisspelledSelection):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::canHandleRequest):
  • loader/FrameLoader.h: Make canHandleRequest available through the FrameLoader.
  • loader/FrameLoaderClient.h: canHandleRequest takes a ResourceRequest instead of an NSURLRequest.
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::continueAfterNavigationPolicy): Same
  • page/Frame.h: New spell checker functions moved to Frame. These should be moved some place better some day, but FrameMac currently seems to be the place to be for spell checker stuff.
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): Use new FrameLoader and spell checking functionality to get rid of two if (true) statements. Also add spelling guesses to the editing context menus.

WebKit:

Reviewed by Adam.

WebKit half of getting rid of the FixMes in ContextMenu.cpp

  • WebCoreSupport/WebFrameLoaderClient.h: canHandleRequest takes a ResourceRequest now.
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::canHandleRequest): Same.
  • WebView/WebHTMLView.m: (-[WebHTMLView _isSelectionMisspelled]): Call into WebCore.
9:33 PM Changeset in webkit [17902] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Hyatt.

​http://bugs.webkit.org/show_bug.cgi?id=11694
XSLT output method does not default to HTML when the target document is HTML

Test: fast/xsl/default-html.html

  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::transformToString): Make mimeType an input/output parameter, serving as a hint when the stylesheet doesn't specify the output method. (WebCore::XSLTProcessor::transformToFragment): Set mimeType to text/html if the target document is HTML.
8:36 PM Changeset in webkit [22576] by oliver
  • 2 edits in branches/WindowsMerge/WebCore

2006-11-27 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Fixes a crash in SVG caused by an attempt to
perform css overflow clipping by preventing
the css overflow clip from being set in SVG.


<rdar:/problems/4839568>


8:33 PM Changeset in webkit [17901] by oliver
  • 6 edits
    2 adds in trunk/WebCore

2006-11-27 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Fixes a crash in SVG caused by an attempt to
perform css overflow clipping by preventing
the css overflow clip from being set in SVG.


<rdar:/problems/4839568>


7:08 PM Changeset in webkit [22575] by andersca
  • 3 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Adam.

<rdar://problem/4814582>
JavaScript window.resizeTo doesn't work


  • Interfaces/IWebUIDelegate.idl: Fix declarations.


  • WebChromeClient.cpp: (WebChromeClient::setWindowRect): (WebChromeClient::windowRect): Call the COM methods.
7:01 PM Changeset in webkit [17900] by andersca
  • 3 edits in trunk/WebCore

Reviewed by Adam.

Add an explicit IntRect constructor that takes a FloatRect.


  • platform/graphics/IntRect.cpp: (WebCore::IntRect::IntRect):
  • platform/graphics/IntRect.h:
6:18 PM Changeset in webkit [17899] by adachan
  • 8 edits
    2 moves in trunk

WebCore:

Reviewed by Adam.

Moved WebCoreCache up to WebKit.

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreCache.h: Removed.
  • bridge/mac/WebCoreCache.mm: Removed.

WebKit:

Reviewed by Adam.

Part of the change to move WebCoreCache into WebKit:
Added WebCache which handles emptying and enable/disabling the cache.
emptyCache and setCacheDisabled have been removed from WebCoreStatistics.

  • Misc/WebCache.h: Added.
  • Misc/WebCache.mm: Added.
  • Misc/WebCoreStatistics.h:
  • Misc/WebCoreStatistics.m: (+[WebCoreStatistics statistics]):
  • WebKit.exp:
  • WebKit.xcodeproj/project.pbxproj:
5:13 PM Changeset in webkit [17898] by thatcher
  • 1 edit in tags/WebCore-521.31.1/WebCore/Info.plist

Versioning.

5:12 PM Changeset in webkit [17897] by thatcher
  • 1 edit in tags/WebCore-521.31.1/WebCore/platform/graphics/cg/PDFDocumentImage.cpp

Merging the build fix from r17888.

5:10 PM Changeset in webkit [17896] by thatcher
  • 1 copy in tags/WebCore-521.31.1/WebCore

New tag (part 2.)

5:09 PM Changeset in webkit [17895] by thatcher
  • 1 add in tags/WebCore-521.31.1

New tag.

5:06 PM Changeset in webkit [17894] by kmccullo
  • 5 edits
    1 move in trunk/LayoutTests

Reviewed by Adam.

  • fast/forms/resources/success.html: Removed.
  • fast/forms/targeted-frame-submission-expected.checksum:
  • fast/forms/targeted-frame-submission-expected.png:
  • fast/forms/targeted-frame-submission-expected.txt:
  • fast/forms/targeted-frame-submission.html:
4:50 PM Changeset in webkit [17893] by thatcher
  • 1 edit in tags/Safari-421.31/JavaScriptGlue/Info.plist

Versioning.

4:49 PM Changeset in webkit [17892] by thatcher
  • 1 edit in tags/Safari-421.31/JavaScriptCore/Info.plist

Versioning.

4:49 PM Changeset in webkit [17891] by thatcher
  • 1 edit in tags/Safari-421.31/WebKit/Info.plist

Versioning.

4:49 PM Changeset in webkit [17890] by thatcher
  • 1 edit in tags/Safari-421.31/WebCore/Info.plist

Versioning.

4:38 PM Changeset in webkit [17889] by thatcher
  • 1 copy in tags/Safari-421.31

New tag.

4:29 PM Changeset in webkit [17888] by thatcher
  • 1 edit in trunk/WebCore/platform/graphics/cg/PDFDocumentImage.cpp

Build fix. Use the CGPDFPage APIs to get the media rect, crop rect and rotation.

3:10 PM Changeset in webkit [22574] by andersca
  • 9 edits in branches/WindowsMerge

WebCoreWin:

Remove addMessageToConsole from FrameWin.

  • bridge/win/FrameWin.h:
  • platform/win/TemporaryLinkStubs.cpp:

WebKitWin:

Reviewed by Adam.

Add "addMessageToConsole" method to the private ui delegate, and have the client call it.


  • Interfaces/IWebUIDelegatePrivate.idl:
  • WebFrame.cpp: (WebFrame::addMessageToConsole):
  • WebFrame.h:
3:01 PM Changeset in webkit [17887] by kmccullo
  • 1 edit
    5 adds in trunk/LayoutTests

Reviewed by Adam and Anders.

Testcase for:
Targeted frame submission.

  • fast/forms/resources/success.html: Added.
  • fast/forms/targeted-frame-submission-expected.checksum: Added.
  • fast/forms/targeted-frame-submission-expected.png: Added.
  • fast/forms/targeted-frame-submission-expected.txt: Added.
  • fast/forms/targeted-frame-submission.html: Added.
2:59 PM Changeset in webkit [17886] by andersca
  • 15 edits in trunk

WebCore:

Reviewed by Adam.

Move addMessageToConsole to Chrome.


  • bindings/js/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::evaluate):
  • bindings/js/kjs_window.cpp: (KJS::Window::isSafeScript): (KJS::ScheduledAction::execute):
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm:
  • bridge/mac/WebCoreFrameBridge.h:
  • page/Chrome.cpp: (WebCore::Chrome::addMessageToConsole):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/Frame.h:

WebKit:

Reviewed by Adam.

Move addMessageToConsole to Chrome.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::addMessageToConsole):
  • WebCoreSupport/WebFrameBridge.mm:
1:55 PM Changeset in webkit [22573] by beidson
  • 4 edits in branches/WindowsMerge/WebKitWin

Reviewed by Ada


Added removeAllIcons() for cache clearing

  • Interfaces/IWebIconDatabase.idl:
  • WebIconDatabase.cpp: (WebIconDatabase::removeAllIcons): Added
  • WebIconDatabase.h:
1:30 PM Changeset in webkit [17885] by adele
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

  • editing/SelectionController.cpp: (WebCore::SelectionController::paintCaret): Use the foreground color of the rootEditableElement to determine the caret color. This will work well for text controls in web pages (since the root is always the actual form control) as well as in editable WebViews, like in Mail, which will just pick up the color from the body element.
12:53 PM Changeset in webkit [17884] by beidson
  • 3 edits in trunk/WebKit

Reviewed by Anders

Moved unused Private SPI to Internal and pruned other unused code

  • Misc/WebIconDatabase.m:
  • Misc/WebIconDatabasePrivate.h:
8:04 AM Changeset in webkit [17883] by brmorris
  • 3 edits in S60/trunk/S60Tools

2006-11-27 brmorris <​thisisbradley@gmail.com>

Reviewed by me.
DESC: Minor updates to svn2ccm utils

  • S60WebKitPlatformBuild.pl: Detailed notification
  • svn2ccm.pl: Whitespace only desc to 'undefined synopsis'

Nov 26, 2006:

12:57 PM Changeset in webkit [17882] by zbujtas
  • 3 edits in S60/branches/3.1m/WebCore

2006-11-22 w3liu <​wei.liu@nokia.com>

Reviewed by ​zbujtas@gmail.com.
DESC:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11665
Text decoder regression in S60 browser.

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQTextCodec.cpp: (KWQTextDecoder::KWQTextDecoder): (QTextCodec::fromUnicode): (QTextCodec::toUnicode): (KWQTextDecoder::fromUnicode): (KWQTextDecoder::checkRealloc):
  • kwq/KWQTextCodec.h:
12:53 PM Changeset in webkit [17881] by zbujtas
  • 3 edits in S60/trunk/WebCore

2006-11-22 w3liu <​wei.liu@nokia.com>

Reviewed by ​zbujtas@gmail.com.
DESC:
​http://bugs.webkit.org/show_bug.cgi?id=11665
Text decoder regression in S60 browser

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQTextCodec.cpp: (KWQTextDecoder::KWQTextDecoder): (QTextCodec::fromUnicode): (QTextCodec::toUnicode): (KWQTextDecoder::fromUnicode): (KWQTextDecoder::checkRealloc):
  • kwq/KWQTextCodec.h:
5:09 AM Changeset in webkit [17880] by rwlbuis
  • 7 edits in trunk/WebCore

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=11693
Fix the Qt build, adapt to various enum/class renamings.

Nov 24, 2006:

2:39 PM Changeset in webkit [17879] by rwlbuis
  • 6 edits
    4 adds in trunk

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=11666
.getScreenCTM() returns wrong values

Take into account the local transform matrix too and
so fix getScreenCTM/getCTM for <text>.

Note: See TracTimeline for information about the timeline view.