Timeline


and

12/09/06:

23:13 Changeset [18131] by zack

Remove unused/pointless code from FrameQtClient.

23:11 Changeset [18130] by aroben

Build fix.

  • xml/XPathParser.cpp: (WebCore::XPath::charCat): Use C++ unsigned instead of uint.
22:54 Changeset [18129] by staikos

Reviewed by Zack.

Make it not crash, and make it set the title on Qt platform.

22:36 Changeset [18128] by zack

Include DumpRenderTree in the Qt build and adjust it to the
recet platform/qt changes (by lars)

22:32 Changeset [22643] by aroben

WebCoreWin:

Reviewed by Hyatt.

Use num-cpus to determine the number of jobs make should run
concurrently.

  • WebCore.vcproj/build-generated-files.sh:
21:54 Changeset [18127] by staikos

Correct the path to the libraries for QMake.

21:44 Changeset [18126] by zack

Cleanup the FrameQtClient mess a little bit.

21:33 Changeset [18125] by zack

Accomodate the file changes in the project files (aka build)

21:12 Changeset [18124] by zack

Implement a decent network loader using QHttp (from Lars)

20:58 Changeset [18123] by staikos

Fix qmake build re: bison issues - unify with Linux build

20:36 Changeset [18122] by staikos

Repair QMake build on OS X.

20:25 Changeset [18121] by zack

Small fixes for qmake shadow builds

19:57 Changeset [18120] by staikos

Remove reference to Unity. Reviewed by Zack.

19:27 Changeset [18119] by zack

Simon says : work with qmake shadow builds. Patch adds support
for it to the build scripts.

19:07 Changeset [22642] by aroben

Reviewed by Hyatt.

Fix: <rdar://problem/4860184> Can't select context menu items with the
right mouse button

  • platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::show):
18:52 Changeset [18118] by zack

Crazy notion: make the font setting on widgets work.

18:36 Changeset [18117] by zack

Stop complaining about the nil renderer (granted the whole
scrollcanvas implementation makes the baby jesus cry)

18:32 Changeset [18116] by zack

Fix some rounding issues

18:01 Changeset [18115] by zack

Fix build for Qt 4.1 and less (for Qtopia mainly). By George.

16:58 Changeset [18114] by zack

CMake is too slow to make it the default build for us. This
patch adds QMake build which works, way, way better. Mostly
done by Simon Hausmann.

16:44 Changeset [18113] by zack

This is part of r 18111 commit - Use the Qt image
loading framework.

16:41 Changeset [18112] by zack

Compile after latest WebKit changes and don't depend on
deprecated methods in Qt.

16:37 Changeset [18111] by zack

Use the Qt image loading framework instead of the Mozilla
loaders

16:21 Changeset [18110] by zack

Remove an explicit ICU dependency (by lars)

16:19 Changeset [18109] by zack

Fixing the kde build after the icu Qt changes.

16:01 Changeset [22641] by aroben

WebCoreWin:

Reviewed by Darin.

Build fixes after OpenSource r18098 and r18106.

  • WebCore.vcproj/WebCore.vcproj:
    • Changed include paths to reflect the now-flattened JSCore headers.
    • Added missing files to project.
    • Changed post-build step to also copy ForwardingHeaders.
    • Removed unnecessary definition of WTF_PLATFORM_CF from project file (it's already defined in config.h).
  • platform/win/TextBoundariesWin.cpp: Fixed up includes and renamed function calls. (WebCore::findNextWordFromIndex): (WebCore::findWordBoundary):

WebKitWin:

Reviewed by Darin.

Build fix.

  • WebKit.vcproj/WebKit.vcproj: Added WebCore/ForwardingHeaders to the include path.
  • WebView.cpp: Updated to reflect the newly-flattend JSCore headers.
15:53 Changeset [18108] by aroben

JavaScriptCore:

Reviewed by Darin.

Some updates in reaction to r18098.

  • wtf/unicode/icu/UnicodeIcu.h: Use !! to convert UBool to bool in all cases. (WTF::Unicode::toLower): (WTF::Unicode::toUpper): (WTF::Unicode::isDigit): (WTF::Unicode::isSpace): (WTF::Unicode::isPunct): (WTF::Unicode::isLower): (WTF::Unicode::isUpper):
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:

WebCore:

Reviewed by Darin.

Changed all ForwardingHeaders to use #include instead of #import.

  • ForwardingHeaders/kjs/JSLock.h:
  • ForwardingHeaders/kjs/SavedBuiltins.h:
  • ForwardingHeaders/kjs/collector.h:
  • ForwardingHeaders/kjs/dtoa.h:
  • ForwardingHeaders/kjs/internal.h:
  • ForwardingHeaders/kjs/interpreter.h:
  • ForwardingHeaders/kjs/lookup.h:
  • ForwardingHeaders/kjs/object.h:
  • ForwardingHeaders/kjs/property_map.h:
  • ForwardingHeaders/kjs/protect.h:
  • ForwardingHeaders/wtf/AlwaysInline.h:
  • ForwardingHeaders/wtf/Assertions.h:
  • ForwardingHeaders/wtf/FastMalloc.h:
  • ForwardingHeaders/wtf/GetPtr.h:
  • ForwardingHeaders/wtf/HashCountedSet.h:
  • ForwardingHeaders/wtf/HashMap.h:
  • ForwardingHeaders/wtf/HashSet.h:
  • ForwardingHeaders/wtf/HashTraits.h:
  • ForwardingHeaders/wtf/MathExtras.h:
  • ForwardingHeaders/wtf/Noncopyable.h:
  • ForwardingHeaders/wtf/OwnArrayPtr.h:
  • ForwardingHeaders/wtf/OwnPtr.h:
  • ForwardingHeaders/wtf/PassRefPtr.h:
  • ForwardingHeaders/wtf/Platform.h:
  • ForwardingHeaders/wtf/RefPtr.h:
  • ForwardingHeaders/wtf/Vector.h:
14:40 Changeset [18107] by staikos

Patch by Lars Knoll, comment out ICU dependency on Qt platform (unused code).

Reviewed by Darin.

09:22 Changeset [18106] by rwlbuis

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11625
Investigate possibility to share code between HTMLStyleElement and SVGStyleElement

Add a class shared by both HTMLStyleElement and SVGStyleElement that
encapsulates the common logic.

09:09 SVG TODO List - Short notes edited by zimmermann@kde.org
(diff)
09:07 SVG TODO List - Short notes created by zimmermann@kde.org
08:15 WikiStart edited by pewtermoose@gmail.com
(diff)
08:09 WikiStart edited by pewtermoose@gmail.com
(diff)
05:30 WikiStart edited by zimmermann@kde.org
(diff)
00:52 Changeset [18105] by hyatt

Fix WebKit forwarding headers for mac.

00:35 Changeset [18104] by hyatt

Update forwarding headers in WebCore to reflect wtf/unicode/icu dir structure.

00:34 Changeset [18103] by hyatt

Fix mac bustage (more still).

00:33 Changeset [18102] by hyatt

Fix mac bustage (maybe).

00:32 Changeset [18101] by hyatt

Fix mac bustage (maybe).

00:29 Changeset [18100] by hyatt

Fix mac bustage (maybe).

12/08/06:

23:54 Changeset [18099] by hyatt

Fix mac bustage.

21:54 Changeset [18098] by hyatt

JavaScriptCore:

Land the new ICU abstraction layer. Patch by Lars.

Reviewed by me

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/Platform.h:
  • wtf/unicode/UnicodeCategory.h: Removed.
  • wtf/unicode/UnicodeDecomposition.h: Removed.
  • wtf/unicode/UnicodeDirection.h: Removed.
  • wtf/unicode/icu/UnicodeIcu.h: (WTF::Unicode::): (WTF::Unicode::foldCase): (WTF::Unicode::toLower): (WTF::Unicode::toUpper): (WTF::Unicode::toTitleCase): (WTF::Unicode::isDigit): (WTF::Unicode::isSpace): (WTF::Unicode::isPunct): (WTF::Unicode::mirroredChar): (WTF::Unicode::category): (WTF::Unicode::direction): (WTF::Unicode::isLower): (WTF::Unicode::isUpper): (WTF::Unicode::digitValue): (WTF::Unicode::combiningClass): (WTF::Unicode::decompositionType): (WTF::Unicode::strcasecmp): (WTF::Unicode::memset):
  • wtf/unicode/qt4/UnicodeQt4.cpp: Removed.
  • wtf/unicode/qt4/UnicodeQt4.h: (WTF::Unicode::): (WTF::Unicode::toLower): (WTF::Unicode::toUpper): (WTF::Unicode::toTitleCase): (WTF::Unicode::foldCase): (WTF::Unicode::isPrintableChar): (WTF::Unicode::isLower): (WTF::Unicode::isUpper): (WTF::Unicode::digitValue): (WTF::Unicode::combiningClass): (WTF::Unicode::decompositionType): (WTF::Unicode::strcasecmp): (WTF::Unicode::memset): (WTF::Unicode::direction): (WTF::Unicode::category):

WebCore:

Land the new ICU abstraction layer (WTF::Unicode). Patch
by Lars with a couple of fixes thrown in by me.

Reviewed by hyatt

  • ForwardingHeaders/wtf/icu/UnicodeIcu.h: Added.
  • ForwardingHeaders/wtf/unicode/Unicode.h: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • css/cssparser.cpp: (WebCore::ParseString::lower):
  • dom/Document.cpp: (WebCore::isValidNameStart): (WebCore::isValidNamePart):
  • editing/TextIterator.cpp: (WebCore::CircularSearchBuffer::append):
  • html/HTMLFontElement.cpp: (WebCore::parseFontSizeNumber):
  • html/HTMLInputElement.cpp: (WebCore::numGraphemeClusters): (WebCore::numCharactersInGraphemeClusters):
  • html/HTMLSelectElement.cpp: (WebCore::stripLeadingWhiteSpace):
  • page/Frame.h:
  • platform/DeprecatedString.h: (WebCore::DeprecatedChar::isSpace): (WebCore::DeprecatedChar::lower): (WebCore::DeprecatedChar::upper):
  • platform/Font.cpp: (WebCore::WidthIterator::advance): (WebCore::WidthIterator::normalizeVoicingMarks):
  • platform/FontCache.h:
  • platform/FontData.h:
  • platform/GlyphMap.cpp:
  • platform/GlyphMap.h:
  • platform/GlyphWidthMap.h:
  • platform/KURL.cpp: (WebCore::encodeHostname):
  • platform/StringHash.h: (WTF::):
  • platform/StringImpl.cpp: (WebCore::isSpace): (WebCore::parseLength): (WebCore::StringImpl::isLower): (WebCore::StringImpl::lower): (WebCore::StringImpl::upper): (WebCore::StringImpl::secure): (WebCore::StringImpl::foldCase): (WebCore::StringImpl::capitalize): (WebCore::StringImpl::toInt): (WebCore::equalIgnoringCase): (WebCore::StringImpl::find):
  • platform/StringImpl.h:
  • platform/TextBoundaries.h:
  • platform/TextBreakIterator.h: Added. (WebCore::):
  • platform/TextBreakIteratorICU.cpp: Added. (WebCore::wordBreakIterator): (WebCore::characterBreakIterator): (WebCore::textBreakFirst): (WebCore::textBreakNext): (WebCore::textBreakPreceding): (WebCore::textBreakFollowing): (WebCore::textBreakCurrent):
  • platform/TextCodec.h:
  • platform/TextCodecLatin1.cpp:
  • platform/TextEncoding.cpp: (WebCore::TextEncoding::encode):
  • platform/TextEncoding.h:
  • platform/TextEncodingRegistry.cpp: (WebCore::buildTextEncodingNameMap): (WebCore::buildTextCodecMap):
  • platform/TextEncodingRegistry.h:
  • platform/UChar.h: Removed.
  • platform/graphics/GraphicsContext.h:
  • platform/qt/GlyphMapQt.cpp:
  • platform/qt/TextBreakIteratorQt.cpp: Added. (WebCore::TextBreakIterator::following): (WebCore::TextBreakIterator::preceding): (WebCore::WordBreakIteratorQt::first): (WebCore::WordBreakIteratorQt::next): (WebCore::WordBreakIteratorQt::previous): (WebCore::CharBreakIteratorQt::first): (WebCore::CharBreakIteratorQt::next): (WebCore::CharBreakIteratorQt::previous): (WebCore::wordBreakIterator): (WebCore::characterBreakIterator): (WebCore::textBreakFirst): (WebCore::textBreakNext): (WebCore::textBreakPreceding): (WebCore::textBreakFollowing): (WebCore::textBreakCurrent):
  • platform/qt/TextCodecQt.cpp: Added. (WebCore::getAtomicName): (WebCore::TextCodecQt::registerEncodingNames): (WebCore::newTextCodecQt): (WebCore::TextCodecQt::registerCodecs): (WebCore::TextCodecQt::TextCodecQt): (WebCore::TextCodecQt::~TextCodecQt): (WebCore::TextCodecQt::decode): (WebCore::TextCodecQt::encode):
  • platform/qt/TextCodecQt.h: Added.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter):
  • rendering/RenderText.cpp: (WebCore::RenderText::previousOffset): (WebCore::RenderText::nextOffset): (WebCore::RenderText::widthFromCache):
  • rendering/RenderText.h:
  • rendering/bidi.cpp: (WebCore::BidiState::BidiState): (WebCore::BidiContext::BidiContext): (WebCore::bidiNext): (WebCore::bidiFirst): (WebCore::BidiIterator::direction): (WebCore::appendRun): (WebCore::embed): (WebCore::RenderBlock::computeHorizontalPositionsForLine): (WebCore::RenderBlock::bidiReorderLine): (WebCore::RenderBlock::layoutInlineChildren):
  • rendering/bidi.h: (WebCore::BidiStatus::BidiStatus): (WebCore::BidiContext::dir): (WebCore::BidiContext::basicDir): (WebCore::BidiRun::BidiRun):
  • rendering/break_lines.h:

WebKit:

Land new ICU abstraction layer. Patch by Lars.

Reviewed by me

  • ForwardingHeaders/wtf/icu/UnicodeIcu.h: Added.
  • ForwardingHeaders/wtf/unicode/Unicode.h: Added.
  • WebKit.xcodeproj/project.pbxproj:
20:10 Changeset [18097] by aroben

Rolling out r17865 because it caused a performance regression.

  • loader/TextResourceDecoder.cpp: (WebCore::findXMLEncoding):
  • platform/CString.cpp: (WebCore::CString::data):
  • platform/CString.h:
  • platform/TextStream.cpp: (WebCore::TextStream::operator<<):
  • platform/TextStream.h:
18:44 Changeset [22640] by kmccullo

WebKitWin:

Reviewed by Adam.

  • createWebViewWithRequest now increases the ref count for the new window it returns. This is standard practice for COM, and fixes a crash.
  • WebFrame.cpp: (WebFrame::openURL):
17:27 Changeset [18096] by zack

Reviewed by Maciej.

Patch fixes compile of all Qt/KDE code after
the recent API changes.

17:25 Changeset [18095] by bdash

Remove stray conflict marker

17:13 Changeset [18094] by thatcher

New tag.

17:07 Changeset [18093] by thatcher

Versioning

16:38 Changeset [18092] by thatcher

Rolling out a change that broke Mail stationary.
<rdar://problem/4699166> REGRESSION: Background images in Mail stationery do not load

  • WebView/WebUnarchivingState.m: (-[WebUnarchivingState archivedResourceForURL:]):
16:31 Changeset [18091] by staikos

Reviewed by Maciej.

Build Qt webkit on non-linux, and prefer it if $QTDIR is set

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:
16:11 Changeset [22639] by aroben

Rubberstamped by Anders.

  • platform/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::FontPlatformData): Fix use of min().
15:40 Changeset [18090] by rwlbuis

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=10188
Form elements added via appendChild() are not accessible via form.element

Make sure looking up form elements works when the form is not appended
to the document.

14:44 Changeset [18089] by rwlbuis

Reviewed by Adele.

http://bugs.webkit.org/show_bug.cgi?id=11765
REGRESSION: Clicking on a select with size other than 1 and no children results in a crash

Make sure returned value is -1 for selects without children.

14:37 Changeset [22638] by aroben

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
14:34 Changeset [18088] by aroben

Fixed typo.

14:34 Changeset [18087] by aroben

JavaScriptCore:

Reviewed by Anders.

This is a mo' better fix for ensuring we don't use macro definitiones
of min/max.

  • kjs/config.h:
  • wtf/Vector.h:

WebCore:

Reviewed by Anders.

This is a mo' better fix for ensuring we don't use macro definitiones
of min/max.

  • config.h:
13:21 Changeset [18086] by ap

2006-12-08 Don Gibson <dgibson77@gmail.com>

Reviewed and landed by Alexey.

http://bugs.webkit.org/show_bug.cgi?id=11759:
Windows build bustage

WebCore:

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/ContextMenuClientWin.h:
  • bridge/win/FrameWin.h:
  • loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::submitForm):
  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onRequestComplete): (WebCore::ResourceHandle::fileLoadTimer): (WebCore::ResourceHandle::cancel):
  • platform/win/MouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::fileButtonChooseFileLabel): (WebCore::inputElementAltText): (WebCore::copyCursor): (WebCore::resetButtonDefaultLabel): (WebCore::ContextMenuClientWin::contextMenuItemSelected): (WebCore::ContextMenuClientWin::copyLinkToClipboard): (WebCore::ContextMenuClientWin::downloadURL): (WebCore::ContextMenuClientWin::copyImageToClipboard): (WebCore::Editor::ignoreSpelling): (WebCore::Editor::learnSpelling): (WebCore::Editor::isSelectionUngrammatical): (WebCore::Editor::isSelectionMisspelled): (WebCore::Editor::guessesForMisspelledSelection): (WebCore::Editor::guessesForUngrammaticalSelection): (WebCore::Editor::markMisspellingsInAdjacentWords): (WebCore::FrameLoader::load): (WebCore::FrameWin::scheduleClose): (WebCore::FrameWin::respondToChangedSelection):

WebKit:

  • COM/WebFrame.cpp: (WebFrame::loadDataSource):
  • COM/WebFrame.h:
13:12 Changeset [18085] by weinig

LayoutTests:

Reviewed by Geoff.

Testcases for http://bugs.webkit.org/show_bug.cgi?id=11777
Crash when using XMLSerializer.serializeToString() on
documentless, DocumentType nodes.

  • fast/dom/XMLSerializer-doctype-expected.txt: Added.
  • fast/dom/XMLSerializer-doctype.html: Added.
  • fast/dom/XMLSerializer-doctype2-expected.txt: Added.
  • fast/dom/XMLSerializer-doctype2.html: Added.

WebCore:

Reviewed by Geoff.

Fix for http://bugs.webkit.org/show_bug.cgi?id=11777
Crash when using XMLSerializer.serializeToString() on
documentless, DocumentType nodes.

Test: fast/dom/XMLSerializer-doctype.html
Test: fast/dom/XMLSerializer-doctype2.html

  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): set the document of the DocumentType node to the new document.
  • xml/XMLSerializer.cpp: Cleanup. (WebCore::XMLSerializer::serializeToString): now throws an exception for documentless nodes.
  • xml/XMLSerializer.h: cleanup
  • xml/XMLSerializer.idl: add exception
11:29 Changeset [18084] by justing

LayoutTests:

Reviewed by john

<rdar://problem/4836287>
Cannot expand selection out of editable element when containing element is non-editable.

  • editing/selection/mixed-editability-6-expected.checksum: Added.
  • editing/selection/mixed-editability-6-expected.png: Added.
  • editing/selection/mixed-editability-6-expected.txt: Added.
  • editing/selection/mixed-editability-6.html: Added.
  • editing/selection/mixed-editability-7-expected.checksum: Added.
  • editing/selection/mixed-editability-7-expected.png: Added.
  • editing/selection/mixed-editability-7-expected.txt: Added.
  • editing/selection/mixed-editability-7.html: Added.

WebCore:

Reviewed by john

<rdar://problem/4836287>
Cannot expand selection out of editable element when containing element is non-editable.

  • editing/Selection.cpp: (WebCore::Selection::adjustForEditableContent): Restrict the selection endpoints to the same *highest* editable root. This bug only happened when creating selections based in an editable region and extending into a higher editable root, so this change doesn't expose any new kinds of deletions, but we should start thinking about how those deletions should behave.
  • editing/SelectionController.cpp: (WebCore::SelectionController::selectAll): Ditto.
10:53 Changeset [18083] by harrison

Reviewed by Brady.

<rdar://problem/4863611> Xyle Scope crashes at launch due to WebCore-521.29.3

  • WebView/WebPreferences.m: (-[WebPreferences editableLinkBehavior]): Add nil check.
10:46 Changeset [22637] by bdakin

Reviewed by Maciej.

Add a new member variable to ContectMenuItem to hold on to the sub-
menu. The new member variable is an OwnPtr<ContextMenu>. Not doing
this breaks sub-menus on Boomer since the menu items are no longer
static.

  • platform/win/ContextMenuItemWin.cpp: (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::platformSubMenu): (WebCore::ContextMenuItem::setSubMenu):
10:42 Changeset [18082] by bdakin

Typo! Thanks Mitz!

10:37 Changeset [18081] by bdakin

Reviewed by Maciej.

Add a new member variable to ContectMenuItem to hold on to the sub-
menu. The new member variable is an OwnPtr<ContextMenu>

  • platform/ContextMenu.cpp: Because of the OwnPtr in ContextMenuItem, we have to separate the declaration of ContextMenuItems away from the calls to appendItem(). Not doing so causes a build failure because OwnPtr inherits from Noncopyable. (WebCore::createFontSubMenu): Same. (WebCore::createSpellingAndGrammarSubMenu): Same. (WebCore::createSpellingSubMenu): Same. (WebCore::createSpeechSubMenu): Same. (WebCore::createWritingDirectionSubMenu): Same. (WebCore::ContextMenu::populate): Same.
  • platform/ContextMenuItem.h: New member variable m_subMenu.
  • platform/mac/ContextMenuItemMac.mm: Take care of setting m_subMenu in addition to setting the submenu of the NSMenuItem when we have a sub-menu. (WebCore::menuToArray): (WebCore::ContextMenuItem::ContextMenuItem): Same. (WebCore::ContextMenuItem::platformSubMenu): Same. (WebCore::ContextMenuItem::setSubMenu): Same.
10:35 Changeset [18080] by ap

2006-12-08 MorganL <morganl.webkit@yahoo.com>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11778
CString::data() should be documented as returning a null terminated char array

  • platform/CString.h: Add some basic documentation to CString.h
10:31 Changeset [18079] by ap

Reviewed by Geoff.

http://bugs.webkit.org/show_bug.cgi?id=11718
REGRESSION: When I mouse up after dragging a selection outside of a iframe, the iframe
continues to scroll automatically.

Test: manual-tests/autoscroll.html

  • manual-tests/autoscroll.html: Added.
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): Assign to m_mousePressNode earlier, so that it is available in the superframe as well. Reset m_mouseDownWasInSubframe to false when starting to handle a mousedown - previously, its value was only defined if the event was passed down to a widget or a subframe.

(WebCore::EventHandler::stopAutoscrollTimer):
If the mouse down event was in a subframe, stop the subframe's timer.

10:25 Changeset [18078] by ap

Reviewed by Geoff.

http://bugs.webkit.org/show_bug.cgi?id=6275
XMLHttpRequest.getResponseHeader should return a null string for non-existent headers

WebCore:

  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Convert null getResponseHeader strings to JS null, rather than undefined.

LayoutTests:

  • http/tests/xmlhttprequest/methods-async-expected.txt:
  • http/tests/xmlhttprequest/methods-expected.txt:
  • http/tests/xmlhttprequest/methods-lower-case-expected.txt: Updated the results.
  • http/tests/xmlhttprequest/web-apps/008-expected.txt:
  • http/tests/xmlhttprequest/web-apps/008-test.asis:
  • http/tests/xmlhttprequest/web-apps/008.html: Changed to test both missing and empty headers, also test case insensitivity of header names. Please note that neither Firefox nor IE passes this test now - the former returns null in both cases, and the latter returns empty strings.
10:19 Changeset [18077] by ap

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=9854
HTTP Refresh header with quotes is parsed incorrectly

Test: http/tests/misc/redirect-with-quotes.php

  • WebCore.xcodeproj/project.pbxproj: Added HTTPParsers.{h,cpp}. I intend to move Content-Type parsing here, as well.
  • dom/Document.cpp: (WebCore::Document::processHttpEquiv):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::receivedFirstData): Use the new implementation in HTTPHeaders.
  • platform/network/HTTPParsers.cpp: Added. (WebCore::skipWhiteSpace): (WebCore::parseHTTPRefresh):
  • platform/network/HTTPParsers.h: Added. Merged and rewrote existing implementations for better Firefox compatibility.
10:03 Changeset [18076] by ap

Reviewed by Tim H.

http://bugs.webkit.org/show_bug.cgi?id=11772
REGRESSION: XMLSerializer.serializeToString incorrect value for CDATA nodes

Test: fast/dom/serialize-cdata.html

  • editing/markup.cpp: (WebCore::startMarkup): Dump CDATA sections, too.
03:02 Changeset [18075] by rwlbuis

Reviewed by hyatt.

Deleted misplaced comment.

00:02 Changeset [18074] by rwlbuis

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=6074
WebKit+SVG and FireFox disagree on invalid "transform" handling

Test for parsing failure on transform attribute and clear the transform
list upon failure to match FF behaviour.

12/07/06:

23:05 Changeset [18073] by ggaren

LayoutTests:

Reviewed by Beth Dakin.


Tests for the change and blur events in input elements.

  • fast/events/onchange-passwordfield-expected.txt: Added.
  • fast/events/onchange-passwordfield.html: Added.
  • fast/events/onchange-searchfield-expected.txt: Added.
  • fast/events/onchange-searchfield.html: Added.
  • fast/events/onchange-textfield-expected.txt: Added.
  • fast/events/onchange-textfield.html: Added.

WebCore:

Reviewed by Beth Dakin.

Fixed <rdar://problem/4870551> 9A320: <input type="text"> no longer
dispatches onchange event in response to enter key


To match our old behavior and FF, we need to dispatch onchange in response to the
ENTER key. The strategy here is just to dispatch a blur event, since that's how
the search field always worked, and the DOM spec says onchange only fires
as a precursor to blur.

  • ChangeLog:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
19:53 Changeset [18072] by aroben

Reviewed by Oliver.

Some small context menu-related fixes.

  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::defaultEventHandler): Don't try to resize on a contextmenuEvent.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Only pass the event off to HTMLGenericFormElement if we haven't handled it.
19:22 Changeset [18071] by bdash

2006-12-07 Kevin Fyure <digdog@macports.org>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11545
Disable the testcases do not follow the ECMA-262v3 specification.


  • tests/mozilla/expected.html: Update Results.
  • tests/mozilla/js1_2/String/concat.js: 4 tests disabled. The result of concat Array object is not followinig ECMA 15.5.4.6
  • tests/mozilla/js1_2/function/Number.js: 1 test disabled. The result of Array object to Number object conversion is not following ECMA 9.3. And the test was duplicated in ecma/TypeConversion/9.3-1.js
  • tests/mozilla/js1_2/function/String.js: 2 tests disabled. The result of Object/Array object to String object conversion is not following ECMA 15.5.1.1 and ECMA 9.8
17:51 Changeset [18070] by zbujtas

2006-12-03 shkeller <shaun.keller@nokia.com>

Reviewed by Zalan Bujtas (zbujtas@gmail.com).
DESC: synthesize missing html node when comments start doc
http://bugs.webkit.org/show_bug.cgi?id=11747

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):
16:54 Changeset [18069] by andersca

LayoutTests:

Reviewed by Darin.

<rdar://problem/4838778>
DashboardClient crashing in WebCore::SubresourceLoader::didFail.


  • http/tests/xmlhttprequest/abort-crash-expected.txt: Added.
  • http/tests/xmlhttprequest/abort-crash.html: Added.
  • http/tests/xmlhttprequest/hello-world.cgi: Added.

WebCore:

Reviewed by Darin.

<rdar://problem/4838778>
Title: DashboardClient crashing in WebCore::SubresourceLoader::didFail


  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::stopLoading):
  • loader/SubresourceLoader.h: Add stopLoading method which currently just clears the client. This isn't the ideal fix, since it doesn't actually stop the load.


  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::willSendRequest): (WebCore::SubresourceLoader::didReceiveResponse): (WebCore::SubresourceLoader::didReceiveData): (WebCore::SubresourceLoader::didFinishLoading): (WebCore::SubresourceLoader::didFail): (WebCore::SubresourceLoader::didCancel): Add null-checks.


  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::abort): Call stopLoading.
16:28 Changeset [22636] by kmccullo

Reviewed by.

Fixed previous comment

  • ChangeLog:
16:26 Changeset [22635] by kmccullo

Reviewed by NOBODY (OOPS!).

  • keyDown events must be followed by keyPressed events and before keyUp events.
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::keyEvent):
16:23 Changeset [18068] by kmccullo

Reviewed by Geof.

  • added the ability to set the auto repeating variable to force a keyPressed event from a keyDown event.
  • platform/PlatformKeyboardEvent.h: (WebCore::PlatformKeyboardEvent::setIsAutoRepeat):
16:14 Changeset [18067] by bdash

2006-12-07 Kirby White <KWhiteRight@gmail.com>

Reviewed by Adele.

http://bugs.webkit.org/show_bug.cgi?id=11771
Bug 11771: Add a test for resetting a textarea form control

  • fast/dom/HTMLTextAreaElement/reset-textarea-expected.checksum: Added.
  • fast/dom/HTMLTextAreaElement/reset-textarea-expected.png: Added.
  • fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt: Added.
  • fast/dom/HTMLTextAreaElement/reset-textarea.html: Added.
16:10 Changeset [18066] by bdash

2006-12-07 Don Gibson <dgibson77@gmail.com>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11749
Don't call updateThumbProportion() unnecessarily.

  • platform/ScrollBar.cpp: (WebCore::Scrollbar::setProportion):
15:50 Changeset [22634] by sfalken

Bump version for submit

15:44 Changeset [18065] by sfalken

New tag.

15:37 Changeset [18064] by bdash

Versioning.

15:35 Changeset [18063] by bdash

Merge fix from r18048

15:22 Changeset [18062] by bdash

New tag

15:21 Changeset [18061] by brmorris

2006-12-07 Bradley Morrison <bradley.morrison@nokia.com>

Reviewed by Babu.


Updated expected layout test results to include color attribute.



14:10 Changeset [22633] by aroben

WebKitWin:

Reviewed by Anders.

Two small fixes for bugs discovered while implementing the Snippet
Editor.

  • WebView.cpp: (registerWebViewWindowClass): Set the WebView's default cursor to be IDC_ARROW. (WebView::uiDelegate): Return E_FAIL if there's no UI delegate.
13:57 Changeset [22632] by sfalken

2006-12-06 Steve Falkenburg <sfalken@apple.com>

Reviewed by Lou.


Add LPCTSTR_UI_STRING and LPCTSTR_UI_STRING_KEY.
Added caching to prevent re-converting strings unnecessarily.

  • WebKit.vcproj/WebKit.def: Export LPCTSTR localization function
  • WebKit.vcproj/WebKit_debug.def: Export LPCTSTR localization function
  • WebLocalizableStrings.cpp: (createWebKitBundle): Added using namespace so we don't need to qualify String (WebLocalizedLPCTSTR): Added
  • WebLocalizableStrings.h: Added LPCTSTR localization support
13:49 Changeset [18060] by sfalken

2006-12-06 Steve Falkenburg <sfalken@apple.com>

Support C strings for localization

  • Scripts/extract-localizable-strings:
12:47 Changeset [18059] by bdakin

Reviewed by Brady.

Build fix for WebCore ContextMenus. It got broken by r18046.

  • WebView/WebHTMLView.m: (-[NSArray menuForEvent:]):
11:57 Changeset [22631] by bdakin

WebCoreWin:

Reviewed by Brady.

New link stub for load() function used by
ContextMenuItemTagOpenLink action.

  • platform/win/TemporaryLinkStubs.cpp: (FrameLoader::load):

WebKitWin:

Reviewed by Brady.

Make some parameters const and const references.

  • WebContextMenuClient.cpp: (WebContextMenuClient::contextMenuItemSelected): (WebContextMenuClient::copyLinkToClipboard): (WebContextMenuClient::downloadURL): (WebContextMenuClient::copyImageToClipboard):
  • WebContextMenuClient.h:

M OpenSourceWin/WebKitWin/WebContextMenuClient.cpp
M OpenSourceWin/WebKitWin/ChangeLog
M OpenSourceWin/WebKitWin/WebContextMenuClient.h
M OpenSourceWin/WebCoreWin/platform/win/TemporaryLinkStubs.cpp
M OpenSourceWin/WebCoreWin/ChangeLog

11:49 Changeset [18058] by yongjzha

2006-12-05 yadavall <sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (sachin.padma@nokia.com).
DESC: Toolbar tooltip not OK for RTL tooltip like Hebrew
http://bugs.webkit.org/show_bug.cgi?id=11761

  • BrowserView/src/WebKitView.cpp: (CWebKitView::DrawToolTip):
11:49 Changeset [18057] by bdakin

WebCore:

Reviewed by Brady.

Fixes "Open in new Window" item in WebCore ContextMenus. It wasn't
doing anything before, and now it works! Also some formatting
changes, etc.

  • page/ContextMenuClient.h: Several of the parameters to several of the functions here should be const or const references. And now they are!
  • page/ContextMenuController.cpp: (WebCore::openNewWindow): Moved the open new window functionality into a helper function since it is used by several menu item tags. Now after calling chrome()->createWindow() we call chrome()->show() on the new window, and so it appears! (WebCore::ContextMenuController::contextMenuItemSelected): Call new openNewWindow function to do the right thing. Shift some formatting, use local variable for HitTestResult. Implement action for ContextMenuItemTagOpenLink.

WebKit:

Reviewed by Brady.

Make some parameters const and const references.

  • WebCoreSupport/WebContextMenuClient.h:
  • WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::contextMenuItemSelected): (WebContextMenuClient::copyLinkToClipboard): (WebContextMenuClient::downloadURL): (WebContextMenuClient::copyImageToClipboard):
11:41 Changeset [18056] by yongjzha

2006-12-07 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan Bujtas (zbujtas@gmail.com).
DESC: TSW ID:EYWG-6W7AGP-LSK and RSK are all displayed as YES after accessing the given link
http://bugs.webkit.org/show_bug.cgi?id=11776

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall):
11:39 Changeset [22630] by adachan

2006-12-07 Ada Chan <adachan@apple.com>

Reviewed by Steve and Anders.

<rdar://4866288> Crash on boomer quit

  • don't close the themes on termination, since uxtheme should do that anyway.
01:49 Changeset [18055] by ddkilzer

Fixed typos/misspellings.

12/06/06:

18:47 Changeset [18054] by kmccullo

Reviewed by.

  • Removed a confilct marker
  • ChangeLog:
18:47 Changeset [22629] by adachan

2006-12-06 Ada Chan <adachan@apple.com>

Reviewed by Maciej.

Fixed a couple of things while investigating <rdar://4866288> (note this doesn't fix the crash yet):

  • we forgot to initialize m_sliderTheme
  • we did the wrong null check when getting the slider theme.
18:46 Changeset [18053] by justing

LayoutTests:

Reviewed by darin


<rdar://problem/4818134>
Crash in WebCore::selectRange when invoking WebView:insertNewLine in any empty content editable DIV.

  • editing/selection/select-line-expected.txt: Added.
  • editing/selection/select-line.html: Added.

WebCore:

Reviewed by darin


<rdar://problem/4818134>
Crash in WebCore::selectRange when invoking WebView:insertNewLine in any empty content editable DIV.

  • WebCore.vcproj/WebCore/WebCore.vcproj: Removed RebalanceWhitespaceCommand.*.
  • editing/visible_units.cpp: (WebCore::startOfLine): There are VisiblePositions at offset 0 in blocks without RootInlineBoxes, like empty editable blocks and bordered blocks. (WebCore::endOfLine): Ditto.
18:40 Changeset [18052] by kmccullo

Reviewed by.

  • Removed a confilct marker
  • ChangeLog:
18:24 Changeset [18051] by kmccullo

Reviewed by john


<rdar://problem/4854869>
Inserting a new line in a contenteditable=true SPAN whose parent is a DIV asserts

  • editing/htmlediting.cpp: (WebCore::enclosingBlock): Use enclosingNodeWithType to prevent escape from editable content.
  • editing/markup.cpp: (WebCore::createMarkup): A null commonAncestorBlock will happen if commonAncestor is inside an inline editable root that doesn't contain any blocks. Removed an early return for this case: the code below the early return can and must handle it.
17:01 Changeset [18050] by justing

LayoutTests:

Reviewed by john


<rdar://problem/4854869>
Inserting a new line in a contenteditable=true SPAN whose parent is a DIV asserts

  • editing/deleting/delete-mixed-editable-content-001-expected.txt:
  • editing/inserting/editable-inline-element-expected.checksum: Added.
  • editing/inserting/editable-inline-element-expected.txt: Added.
  • editing/inserting/editable-inline-element-expected.png: Added.
  • editing/inserting/editable-inline-element.html: Added.

WebCore:

Reviewed by john


<rdar://problem/4854869>
Inserting a new line in a contenteditable=true SPAN whose parent is a DIV asserts

  • editing/htmlediting.cpp: (WebCore::enclosingBlock): Use enclosingNodeWithType to prevent escape from editable content.
  • editing/markup.cpp: (WebCore::createMarkup): A null commonAncestorBlock will happen if commonAncestor is inside an inline editable root that doesn't contain any blocks. Removed an early return for this case: the code below the early return can and must handle it.
16:41 Changeset [18049] by beidson

Reviewed by John Sullivan

Fixes http://bugs.webkit.org/show_bug.cgi?id=11675 and <rdar://4857669>
Now we need to explicitly set the data source when loading from a page cache

  • History/WebHistoryItem.mm: (-[WebHistoryItem _scheduleRelease]): Enhanced a logging message (+[WebHistoryItem _releasePageCache:]): Ditto (+[WebHistoryItem _releaseAllPendingPageCaches]): Ditto
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::setDocumentViewFromPageCache): Reset the View's DataSource from the cache, effectively reopening it
  • WebView/WebHTMLView.m: (-[NSArray setDataSource:]): Properly Handle resetting the DataSource and "reopening" the view
16:22 Changeset [18048] by thatcher

Reviewed by Mark Rowe.

<rdar://problem/4843505> Fix cross-library ivar use for 64-bit Objective-C

Adds a new WebCore.LP64.exp file that gets appended to the normal export file.
This new file will have 64-bit only symbols we need to export.

  • WebCore.LP64.exp: Added.
  • WebCore.xcodeproj/project.pbxproj:
16:15 Changeset [22628] by andersca

WebCoreWin:

Fix the build.


  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didReceiveData): (WebCore::didFail): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel):

WebKitWin:

Fix the build.

  • WebFrame.cpp: (WebFrame::loadDataSource): (WebFrame::didReceiveData): (WebFrame::didFail):
  • WebFrame.h:
16:08 Changeset [18047] by andersca

Reviewed by Maciej.


Change SubresourceLoader to use a ResourceHandle, and change ResourceHandle to use a NSURLConnection.


  • loader/ResourceLoader.h:
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): (WebCore::SubresourceLoader::didReceiveData): (WebCore::SubresourceLoader::didFinishLoading): (WebCore::SubresourceLoader::didFail):
  • loader/SubresourceLoader.h: (WebCore::SubresourceLoader::didReceiveAuthenticationChallenge): (WebCore::SubresourceLoader::didCancelAuthenticationChallenge): (WebCore::SubresourceLoader::willStopBufferingData): (WebCore::SubresourceLoader::willCacheResponse): (WebCore::SubresourceLoader::receivedCredential): (WebCore::SubresourceLoader::receivedRequestToContinueWithoutCredential): (WebCore::SubresourceLoader::receivedCancellation):
  • loader/SubresourceLoaderClient.h: (WebCore::SubresourceLoaderClient::didFail):
  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::didFail):
  • loader/icon/IconLoader.h:
  • loader/loader.cpp: (WebCore::Loader::didFail):
  • loader/loader.h:
  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::addData): (WebCore::ResourceLoader::resourceData):
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::setDefersLoading): (WebCore::SubresourceLoader::resourceData): (WebCore::SubresourceLoader::load): (WebCore::SubresourceLoader::create): (WebCore::SubresourceLoader::willSendRequest): (WebCore::SubresourceLoader::didReceiveResponse): (WebCore::SubresourceLoader::didReceiveData): (WebCore::SubresourceLoader::didFinishLoading): (WebCore::SubresourceLoader::didFail): (WebCore::SubresourceLoader::didCancel):
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::ResourceHandle): (WebCore::ResourceHandle::create):
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::didReceiveData): (WebCore::ResourceHandleClient::didFail): (WebCore::ResourceHandleClient::didReceiveAuthenticationChallenge): (WebCore::ResourceHandleClient::didCancelAuthenticationChallenge): (WebCore::ResourceHandleClient::willStopBufferingData): (WebCore::ResourceHandleClient::willCacheResponse): (WebCore::ResourceHandleClient::receivedCredential): (WebCore::ResourceHandleClient::receivedRequestToContinueWithoutCredential): (WebCore::ResourceHandleClient::receivedCancellation):
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel): (WebCore::ResourceHandle::setDefersLoading): (WebCore::ResourceHandle::delegate): (WebCore::ResourceHandle::releaseDelegate): (WebCore::ResourceHandle::supportsBufferedData): (WebCore::ResourceHandle::bufferedData): (-[WebCoreResourceHandleAsDelegate initWithHandle:]): (-[WebCoreResourceHandleAsDelegate detachHandle]): (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]): (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]): (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]): (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]): (-[WebCoreResourceHandleAsDelegate useCredential:forAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate continueWithoutCredentialForAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate cancelAuthenticationChallenge:]):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::didFail):
  • xml/xmlhttprequest.h:
14:41 Changeset [22627] by andersca

Reviewed by Adam.

Modify PluginStreamWin to use a SubresourceLoader instead of a ResourceHandle.

  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::PluginStreamWin): (WebCore::PluginStreamWin::~PluginStreamWin): (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::stop): (WebCore::PluginStreamWin::deliverData): (WebCore::PluginStreamWin::didReceiveResponse): (WebCore::PluginStreamWin::didReceiveData): (WebCore::PluginStreamWin::didFail): (WebCore::PluginStreamWin::didFinishLoading):
  • plugins/win/PluginStreamWin.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest): (WebCore::PluginViewWin::load):
14:33 Changeset [22626] by andersca

Build fixes.


  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::scheduleClose):
13:55 Changeset [18046] by beidson

Reviewed by Adam and Oliver

While working on http://bugs.webkit.org/show_bug.cgi?id=11675 I
decided to fix much of the null-deref problems that creeped in via
the loader refactoring. This isn't changing behavior, just reintroducing
the free nil checking we used to have with pure ObjC

  • WebView/WebHTMLView.m: (-[NSArray menuForEvent:]): Explicitly check for null frames (-[NSArray mouseDown:]): Ditto (-[NSArray mouseDragged:]): Ditto (-[NSArray mouseUp:]): Ditto (-[NSArray performKeyEquivalent:]): Ditto (-[WebHTMLView elementAtPoint:allowShadowContent:]): Ditto
13:54 Changeset [18045] by bdakin

Reviewed by Adam.

There are two bugs with WebCore ContextMenus due to the static
ContextMenuItems. One bug is that we often crashed in
NSAutoreleasePool upon quitting the browser. The other bug is that
we were adding static NSMenuItems to multiple NSMenus, which is
disallowed. To fix these bugs, the MenuItems are no longer static.
This is in line with the current design in WebKit anyway. I made
some re-arrangements in the code because I also removed the macro
that was used to create the menu items since it was a bit
confusing.

  • platform/ContextMenu.cpp: (WebCore::createFontSubMenu): (WebCore::createSpellingAndGrammarSubMenu): (WebCore::createSpellingSubMenu): (WebCore::createSpeechSubMenu): (WebCore::createWritingDirectionSubMenu): (WebCore::ContextMenu::populate):
  • platform/ContextMenuItem.h:
  • platform/mac/ContextMenuItemMac.mm: (WebCore::ContextMenuItem::ContextMenuItem): Use the NSMenuItem global separator item if we have SeparatorType.
  • platform/mac/ContextMenuMac.mm: (WebCore::setMenuItemTarget): Change name of getNSMenuItem since that is no longer accurate. (WebCore::ContextMenu::appendItem): Above name change. (WebCore::ContextMenu::insertItem): Same.
13:46 Changeset [18044] by kmccullo

Reviewed by Geof.

  • Returned the semantic meaning of the mask to be the actual repeat count, and changed auto_repeat to correctly differnetiate between keypressed and keydown.
  • platform/win/KeyEventWin.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
13:01 Changeset [18043] by justing

LayoutTests:

Reviewed by harrison


<rdar://problem/4753545>
REGRESSION: Edited whitespace sequences are all nbsps (10636)

  • editing/inserting/edited-whitespace-1-expected.checksum: Added.
  • editing/inserting/edited-whitespace-1-expected.png: Added.
  • editing/inserting/edited-whitespace-1-expected.txt: Added.
  • editing/inserting/edited-whitespace-1.html: Added.

WebCore:

Reviewed by harrison


<rdar://problem/4753545>
REGRESSION: Edited whitespace sequences are all nbsps (10636)

  • WebCore.xcodeproj/project.pbxproj: Removed RebalanceWhitespaceCommand.* from the project.
  • editing/CompositeEditCommand.cpp: (WebCore::isWhitespace): Moved from htmlediting. (WebCore::CompositeEditCommand::rebalanceWhitespaceAt): Moved the work that was once done in its own command here. (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit): Prevents whitespace around a position from collapsing when it's pushed apart during Paste. This function can eventually be deployed to eliminate the need for leading/trailing whitespace handling in InsertParagraphSeparator, InsertLineBreak, Delete, and BreakBlockquote. (WebCore::CompositeEditCommand::rebalanceWhitespace): Cleaned up.
  • editing/CompositeEditCommand.h:
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::doApply): Do rebalanceWhitespaceAt *before* saving the typing style, because whitespace rebalancing is no longer it's own command that claims to preserve the typing style.
  • editing/RebalanceWhitespaceCommand.cpp: Removed.
  • editing/RebalanceWhitespaceCommand.h: Removed.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Moved the code to prepare whitespace arond a position for being pushed aparat to its own method.
  • editing/htmlediting.cpp: (WebCore::stringWithRebalancedWhitespace): Added. Returns a rebalanced string. Takes in whether or not the beginning of that string will be at the start of a paragraph, because a space at such a position must have be nbsp, even if that doesn't follow the nbsp/space pattern used. Similar stuff for the end of a paragraph.
  • editing/htmlediting.h:
  • editing/markup.cpp: (WebCore::fillContainerFromString): Call stringWithRelabacedWhitespace. Pass it the startOfParagraph/endOfParagraph bools.
12:39 Changeset [18042] by rwlbuis

Reviewed by Brady.

http://bugs.webkit.org/show_bug.cgi?id=10254
A few grammar and spelling corrections on the WebKit website

Grammar and spelling corrections by Jonathan Johnsson.

12:01 Changeset [22625] by sfalken
10:57 Changeset [22624] by sullivan

Try to keep the windows build happy with Frame -> Editor changes...

  • bridge/win/FrameWin.h: removed declarations of spelling and grammar functions
  • platform/win/TemporaryLinkStubs.cpp:
changed spelling and grammar functions from FrameWin
to Editor:: (WebCore::Editor::isSelectionMisspelled): (WebCore::Editor::isSelectionUngrammatical): (WebCore::Editor::guessesForMisspelledSelection): (WebCore::Editor::guessesForUngrammaticalSelection): (WebCore::Editor::markMisspellingsInAdjacentWords): (WebCore::Editor::advanceToNextMisspelling):
10:50 Changeset [18041] by sullivan

WebCore:

Reviewed by Beth

Moved spelling and grammar code from Frame to Editor

  • WebCore.exp: updated for these changes
  • page/Frame.h: removed declarations of spelling and grammar functions
  • bridge/mac/FrameMac.h: removed declarations of spelling and grammar functions
  • bridge/mac/FrameMac.mm: moved implementation of spelling and grammar functions from here (WebCore::FrameMac::respondToChangedSelection): updated for moved functions
  • editing/Editor.h: moved declarations of spelling and grammar functions to here
  • editing/mac/EditorMac.mm: moved implementation of spelling and grammar functions to here; changed only to make it compile (e.g. removing "editor()->" and adding "frame()->" where appropraite. (WebCore::findFirstMisspellingInRange): (WebCore::paragraphAlignedRangeForRange): (WebCore::findFirstGrammarDetailInRange): (WebCore::findFirstBadGrammarInRange): (WebCore::Editor::advanceToNextMisspelling): (WebCore::Editor::isSelectionMisspelled): (WebCore::isRangeUngrammatical): (WebCore::Editor::isSelectionUngrammatical): (WebCore::Editor::guessesForUngrammaticalSelection): (WebCore::core): (WebCore::Editor::guessesForMisspelledSelection): (WebCore::Editor::markMisspellingsInAdjacentWords): (WebCore::markAllMisspellingsInRange): (WebCore::markAllBadGrammarInRange): (WebCore::Editor::markMisspellings):
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): updated for moved functions
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::markMisspellingsAfterTyping): updated for moved functions

WebKit:

Reviewed by Beth

Updated to match Frame -> Editor changes in WebCore

  • DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]): guessesForUngrammaticalSelection() is now in Editor
  • WebView/WebHTMLView.m: (-[WebHTMLView _isSelectionUngrammatical]): isSelectionUngrammatical() is now in Editor (-[WebHTMLView _isSelectionMisspelled]): isSelectionMisspelled() is now in Editor

(-[WebHTMLView checkSpelling:]):
advanceToNextMisspelling() is now in Editor
(-[WebHTMLView showGuessPanel:]):
ditto

12/05/06:

19:49 Changeset [22623] by sfalken

Bump version for submit

19:42 Changeset [18040] by sfalken

New tag.

18:16 Changeset [22622] by andersca

Reviewed by Maciej.

Don't delete the internal pointer anymore since it's an OwnPtr now.


  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::~ResourceHandle):
18:09 Changeset [18039] by andersca

Reviewed by Maciej.

General cleanup, get rid of PlatformResponse (we have ResourceResponse now)
and remove a couple of functions that were unused.

  • loader/CachedResource.h:
  • loader/LoaderFunctions.h:
  • loader/mac/LoaderFunctionsMac.mm:
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h:
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::~ResourceHandle):
18:01 Changeset [18038] by kmccullo

Reviewed by John.

  • keydown is now a keydown event instead of a keypress event. Fixes some form submission odditties.
  • platform/win/KeyEventWin.cpp:
17:20 Changeset [18037] by zbujtas

2006-12-05 yadavall <sriram.yadavalli@nokia.com>

Reviewed by Zalan Bujtas (zbujtas@gmail.com).
DESC: Fix for tabbed navigation
http://bugs.webkit.org/show_bug.cgi?id=11757

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::getNewTabbedCursorPosition):
17:11 Changeset [22621] by sfalken

2006-12-05 Steve Falkenburg <sfalken@apple.com>

Fix the build

  • platform/win/TemporaryLinkStubs.cpp:
16:18 Changeset [18036] by sullivan

Tiger build fix

  • editing/mac/EditorMac.mm: declare -[NSSpellChecker learnWord:], on Tiger only (it's API on Leopard)
16:08 Changeset [22620] by sfalken

2006-12-05 Steve Falkenburg <sfalken@apple.com>

B&I build fix.
...and add ImageAnimationObserver.h into its new location.

  • WebCore.vcproj/WebCore.vcproj:
16:03 Changeset [22619] by sfalken

2006-12-05 Steve Falkenburg <sfalken@apple.com>

B&I build fix.
Remove ImageAnimationObserver.h from vcproj.

  • WebCore.vcproj/WebCore.vcproj:
15:56 Changeset [22618] by sullivan

Reviewed by Geoff Garen

Changes to keep up with Frame -> Editor changes in WebCore

  • bridge/win/FrameWin.h: remove ignoreSpelling() and learnSpelling()
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::Editor::ignoreSpelling): moved from FrameWin to Editor (WebCore::Editor::learnSpelling): ditto
15:48 Changeset [18035] by sullivan

Reviewed by Geoff Garen

  • page/Frame.h: remove declarations of ignoreSpelling() and learnSpelling()
  • bridge/mac/FrameMac.h: remove declarations of ignoreSpelling() and learnSpelling()
  • bridge/mac/FrameMac.mm: moved implementations of ignoreSpelling() and learnSpelling() from here
  • editing/Editor.h: added declarations of ignoreSpelling() and learnSpelling()
  • editing/mac/EditorMac.mm: (WebCore::Editor::ignoreSpelling): moved here from FrameMac.mm (WebCore::Editor::learnSpelling): ditto
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): updated callers to use frame()->editor() rather than frame()
15:18 Changeset [22617] by sfalken

2006-12-04 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin.


We're using the WebKit extract-localizable-strings script to generate these files,
and will use a cross-platform merged string file when we ship.

2006-12-04 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin.

We're using the WebKit extract-localizable-strings script to generate these files,
and will use a cross-platform merged string file when we ship.

15:15 Changeset [18034] by sfalken

2006-12-04 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin.


Make extract-localizable-strings compatible with cpp file extensions.

  • Scripts/extract-localizable-strings:
14:34 Changeset [18033] by sullivan

WebCore:

Reviewed by Adam

New context-menu mechanism fix for:
<rdar://problem/4864351> Should leave out "No Guesses Found" from context menu for bad grammar

  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): Leave out "No Guesses Found" and separator for grammar-checking case.

WebKit:

Reviewed by Adam


Old context-menu mechanism fix for:
<rdar://problem/4864351> Should leave out "No Guesses Found" from context menu for bad grammar

  • DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]): Leave out "No Guesses Found" and separator for grammar-checking case.
13:50 Changeset [22616] by aliceli1

Build fix.


  • platform/win/CursorWin.cpp: (WebCore::copyCursor):
13:47 Changeset [18032] by rwlbuis

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=11686
WebKit draws Carto.net tabgroup example completely incorrectly (ff does fine)

Make sure the SVG render objects are laid out before measuring their
dimensions using relativeBBox.

13:24 Changeset [18031] by sullivan

Reviewed by Darin

Grammar/Spelling code re-homing, baby step one: put isGrammarCheckingEnabled in Editor
since that's where isContinousSpellCheckingEnabled lives.

  • editing/Editor.h:
  • editing/Editor.cpp: (WebCore::Editor::isGrammarCheckingEnabled): new method, calls through to client a la isContinuousSpellCheckingEnabled
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): call editor() rather than editor()->client() (WebCore::FrameMac::markMisspellings): ditto
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): ditto
13:22 Changeset [22615] by aliceli1

Build fix.


  • bridge/win/FrameWin.h: added missing declarations for the functions in John's checkin, below.
13:08 Changeset [18030] by darin

Reviewed by Geoff.

  • a little cleanup
  • html/HTMLInputElement.h: Removed unneeded includes of RenderObject.h and RenderStyle.h.
  • html/HTMLSelectElement.h: Removed unneeded include of RenderStyle.h.
  • ksvg2/svg/SVGStyledElement.h: Removed unneeded include of RenderStyle.h.
  • ksvg2/svg/SVGSVGElement.h: Remove unneeded parameter to createSVGPoint.
  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::createSVGPoint): Ditto.
  • ksvg2/scripts/generateJSBindings.pl: Removed unused script.
11:58 Changeset [18029] by yongjzha

2006-11-28 yadavall <sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (sachin.padma@nokia.com).
DESC: Layout messed up when changing zoomlevel while typing text in input box
http://bugs.webkit.org/show_bug.cgi?id=11708

  • BrowserView/src/WebKitView.cpp: (CWebKitView::ZoomL): (CWebKitView::SetCurrentZoomLevelIndex): (CWebKitView::ZoomLevelChanged):
11:50 Changeset [18028] by spadma

2006-12-05 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Not able to select placeholder for audio download
http://bugs.webkit.org/show_bug.cgi?id=11755

  • Plugin/src/PluginSkin.cpp: (CPluginSkin::IsFocusable):
11:49 Changeset [18027] by darin
  • doc: Removed empty directory. It's not clear this is a good place for documentation, so lets add it back later if we actually start using it.
11:17 Changeset [18026] by yongjzha

2006-12-04 hongzhao <set EMAIL_ADDRESS environment variable>

Reviewed by Yongjun <yongjun.zhang@nokia.com>
DESC: [S60] Browser scrollbar is blinking, then disappears in RTL pages for 3.1 version.
http://bugzilla.opendarwin.org/show_bug.cgi?id=11733

  • BrowserCore/ScrollBars/src/ScrollBarFrame.cpp: (CScrollBarFrame::SetScrollBar):
11:08 Changeset [18025] by yongjzha

2006-12-04 hongzhao <set EMAIL_ADDRESS environment variable>

Reviewed by Yongjun <yongjun.zhang@nokia.com>
DESC: Don't move to the scroll bar rect to right if the page is RTL
http://bugs.webkit.org/show_bug.cgi?id=11733

  • WebKit/BrowserCore/ScrollBars/src/ScrollBarFrame.cpp: (CScrollBarFrame::SetScrollBar):
11:03 Changeset [18024] by andersca

Reviewed by Brady, Darin.

  • loader/loader.cpp: (WebCore::Loader::receivedAllData): Remove ref() call that was left around by mistake.
11:01 Changeset [18023] by sullivan

build fix

  • WebView/WebViewPrivate.h:
  • WebView/WebView.mm: (-[WebView isGrammarCheckingEnabled]): define isGrammarCheckingEnabled whether on Tiger or not (just return NO on Tiger)
10:43 Changeset [22614] by sullivan
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::FrameWin::isSelectionUngrammatical): (WebCore::FrameWin::guessesForUngrammaticalSelection): added stubs to correspond to new Frame functions
10:40 Changeset [18022] by weinig

Reviewed by Tim H.

Fix for http://bugs.webkit.org/show_bug.cgi?id=11758
Don't compile custom SVG and XSLT bindings in non-svg build

  • bindings/js/JSSVGNumber.cpp:
  • bindings/js/JSSVGNumber.h:
  • bindings/js/JSSVGPoint.cpp:
  • bindings/js/JSSVGPoint.h:
  • bindings/js/JSSVGRect.cpp:
  • bindings/js/JSSVGRect.h:
  • bindings/js/JSXSLTProcessor.cpp:
  • bindings/js/JSXSLTProcessor.h:
10:36 Changeset [18021] by sullivan

WebCore:

Reviewed by Darin

WebCore part of fix for:
<rdar://problem/4817188> Context menu for bad grammar should include suggestions and "Ignore Grammar"

The context menu mechanism is currently in flux; the old mechanism is still in place, but an
up-and-coming new mechanism is waiting in the wings. I updated both of them, but couldn't
test the new mechanism because it doesn't work well enough yet. Also, some of this code
should move from Frame to Editor, but that will wait for another checkin.

  • page/Frame.h: added pure virtual function declarations for isSelectionUngrammatical() and guessesForUngrammaticalSelection()
  • bridge/mac/FrameMac.h: added virtual functions declarations for isSelectionUngrammatical() and guessesForUngrammaticalSelection()
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::isSelectionMisspelled): now updates spelling panel (whether or not it's showing), since this is now needed to make -[NSSSpellChecker ignoreWord:inSpellDocumentWithTag:] work correctly (WebCore::isRangeUngrammatical): new function, helper used by both isSelectionUngrammatical() and guessesForUngrammaticalSelection() (WebCore::FrameMac::isSelectionUngrammatical): new function, calls isRangeUngrammatical (WebCore::FrameMac::guessesForUngrammaticalSelection): ditto
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): now considers bad grammar as well as misspellings


  • platform/ContextMenuItem.h: added ContextMenuItemTagIgnoreGrammar

WebKit:

Reviewed by Darin

WebKit part of fix for:
<rdar://problem/4817188> Context menu for bad grammar should include suggestions and "Ignore Grammar"

The context menu mechanism is currently in flux; the old mechanism is still in place, but an
up-and-coming new mechanism is waiting in the wings. I updated both of them, but couldn't
test the new mechanism because it doesn't work well enough yet. Most of this WebKit code
can be deleted when the new mechanism is in place.

  • WebView/WebUIDelegatePrivate.h: added WebMenuItemTagIgnoreGrammar
  • DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]): added case for WebMenuItemTagIgnoreGrammar (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]): now considers adding grammar-related items as well as spelling-related items


  • WebView/WebHTMLViewPrivate.h: declared _isSelectionUngrammatical
  • WebView/WebHTMLView.m: (-[WebHTMLView _isSelectionUngrammatical]): new method, calls through to WebCore (-[WebHTMLView _ignoreGrammarFromMenu:]): new method, calls _ignoreSpellingFromMenu: since NSSpellChecker has one method for both
  • English.lproj/Localizable.strings: updated for "Ignore Grammar" menu item title
04:31 Changeset [18020] by ap

2006-12-05 Kirby White <KWhiteRight@gmail.com>

Reviewed, tweaked and landed by Alexey.

<http://bugs.webkit.org/show_bug.cgi?id=11639> Form buttons don't look different when clicked

  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::determineState): Moved test for active state before test for hover state, since active should override hover when both are true.
  • platform/gdk/RenderThemeGdk.cpp: (WebCore::RenderThemeGdk::determineState): Same fix.
02:23 Changeset [18019] by ap

2006-12-05 Kirby White <KWhiteRight@gmail.com>

Reviewed and landed by Alexey.

http://bugs.webkit.org/show_bug.cgi?id=11681
Don't select the first option when resetting a listbox-style form
control (i.e., a multi-select control or one with size > 1) that
has no default selection.

Test: fast/dom/HTMLSelectElement/listbox-select-reset.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::reset):
00:51 Changeset [18018] by ap

Reviewed by Rob.

Make this test pass on PowerPC, too (the calculation was giving 4.7e-16 instead of zero,
now rounding it to 15 digits).

  • svg/custom/getTransformToElement.svg:
00:26 Changeset [18017] by ap

2006-12-05 Lars Naesbye Christensen <larsnaesbye@stud.ku.dk>

Reviewed and landed by Alexey.

http://bugs.webkit.org/show_bug.cgi?id=11752
[CSS 3] missing support for cursor selector 'copy'

  • Resources/copyCursor.png: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSValueKeywords.in:
  • manual-tests/cursor.html:
  • page/EventHandler.cpp: (WebCore::selectCursor):
  • platform/Cursor.h:
  • platform/mac/CursorMac.mm: (WebCore::copyCursor):
  • rendering/RenderStyle.h: (WebCore::):
Note: See TracTimeline for information about the timeline view.