Timeline



Dec 22, 2006:

10:01 PM Changeset in webkit [18400] by bdash
  • 2 edits in trunk/WebKitTools

2006-12-22 Mark Rowe <bdash@webkit.org>

Reviewed by Brady.

Fix for <rdar://problem/4265976>
prepare-ChangeLog sometimes lists the wrong Objective-C class name for a changed method

  • Scripts/prepare-ChangeLog: Treat @end as the end of both the interface and the method declaration.
6:29 PM Changeset in webkit [22714] by aliceli1
  • 7 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Geoff.

Fixed <rdar://4766681> and <rdar://4766685> concerning editable link behavior

  • Interfaces/IWebPreferences.idl:
  • WebHistoryItem.cpp: (WebHistoryItem::dictionaryRepresentation):
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::initialize): (WebPreferences::editableLinkBehavior): (WebPreferences::setEditableLinkBehavior):
  • WebPreferences.h:
  • WebView.cpp: (WebView::updateWebCoreSettingsFromPreferences):
4:19 PM Changeset in webkit [18399] by ggaren
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed by Brady Eidson.


Test for <rdar://problem/4871518> Leopard9A321: Crash visiting www.audible.com
(WebCore::FrameLoader::loadSubframe)


Tests an onload handler for a synchronously loaded iframe removing the iframe
from the document.

  • fast/frames/onload-remove-iframe-crash-expected.txt: Added.
  • fast/frames/onload-remove-iframe-crash.html: Added.

WebCore:

Reviewed by Brady Eidson.


Fixed <rdar://problem/4871518> Leopard9A321: Crash visiting www.audible.com
(WebCore::FrameLoader::loadSubframe)

  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::createFrame): Updated to reflect the fact that createChildFrameNamed: now returns a WebCore::Frame* instead of a WebCoreFrameBridge *.
  • page/mac/WebCoreFrameBridge.h:

WebKit:

Reviewed by Brady Eidson.


Fixed <rdar://problem/4871518> Leopard9A321: Crash visiting www.audible.com
(WebCore::FrameLoader::loadSubframe)

  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge createChildFrameNamed:withURL:referrer:ownerElement:allowsScrolling:marginWidth:marginHeight:]):
  • The fix:

Changed to re-fetch the child frame we're trying to load before returning it,
since its onload handler may have removed it from the document. This
allows us to treat a removed frame like a frame that never loaded.


  • Plus some cleanup:
    • Changed to return a WebCore::Frame* instead of a WebFrameBridge *, to simplify some code.
    • Grouped ObjC objects by usage, and moved calls to -release so that they immediately follow the calls that retain.
4:03 PM Changeset in webkit [22713] by adachan
  • 2 edits in branches/WindowsMerge/WebCore

2006-12-22 Ada Chan <adachan@apple.com>

Reviewed by Anders.

Build fix.

3:28 PM Changeset in webkit [18398] by hyatt
  • 3 edits in trunk/WebCore

Make sure to actually set the stroke thickness for text decorations.
Covered by bugzilla bug 11921.

Reviewed by mitz

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintDecorations):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintDecoration):
2:06 PM Changeset in webkit [18397] by thatcher
  • 2 edits in tags/WebCore-521.32.1/WebCore

Versioning

2:04 PM Changeset in webkit [18396] by thatcher
  • 5 edits in tags/WebCore-521.32.1/WebCore

Merging fix r18328 and r18386.

1:52 PM Changeset in webkit [18395] by thatcher
  • 1 copy in tags/WebCore-521.32.1/WebCore

New tag (part 2.)

1:52 PM Changeset in webkit [18394] by thatcher
  • 1 add in tags/WebCore-521.32.1

New tag. (part 1).

12:49 PM Changeset in webkit [22712] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.


  • WebCore.vcproj/WebCore.vcproj:
11:35 AM Changeset in webkit [18393] by zimmermann
  • 33 edits
    5 adds
    1 delete in trunk

Reviewed by Rob.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11934

Adding/removing SVGPathSeg* items to a SVGPathElement (through SVGPathSegList
interface) has live update problems, as the notifyAttributeChange() function
isn't called anywhere. The context param is currently stored per SVGPathSeg,
which is not needed - as it can be done using SVGPathSegList completely. It
wastes memory, that is fixed. In order to get rid of the context param in
SVGPathSeg, we need a way to map SVGPathSeg* objects to SVGStyledElement*
objects ("context element"). That is done using a new HashMap in the
SVGDocumentExtensions class.

11:26 AM Changeset in webkit [18392] by ap
  • 2 edits in trunk/WebCore

2006-12-22 Mitz Pettel <mitz@webkit.org>

Reviewed by Beth.

This fixes a bunch of existing pixel tests.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::drawBorder):
10:57 AM Changeset in webkit [22711] by sullivan
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Kevin Decker

Renamed stub method name to match change in WebCore

  • platform/win/TemporaryLinkStubs.cpp: (WebCore::Editor::markMisspellingsAfterTypingToPosition): renamed from markMisspellingsInAdjacentWords
10:49 AM Changeset in webkit [18391] by sullivan
  • 4 edits in trunk/WebCore

Reviewed by Kevin Decker

  • renamed markMisspellingsInAdjacentWords to markMisspellingsAfterTypingToPosition in anticipation of fixing it to work more correctly with grammar checking, where only checking adjacent words isn't good enough.
  • editing/Editor.h: renamed markMisspellingsInAdjacentWords to markMisspellingsAfterTypingToPosition
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::markMisspellingsAfterTyping): updated for name change
  • editing/mac/EditorMac.mm: (WebCore::Editor::markMisspellingsAfterTypingToPosition): renamed from markMisspellingsInAdjacentWords and added FIXME comment
9:43 AM Changeset in webkit [18390] by eseidel
  • 3 edits
    16 adds in trunk

2006-12-22 Eric Seidel <eric@webkit.org>

Reviewed by aroben.

http://bugs.webkit.org/show_bug.cgi?id=11912
Overriding visibility does not behave as expected.

  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint): allow children to draw when container is visibility='hidden'
8:51 AM Changeset in webkit [18389] by yongjzha
  • 3 edits in S60/trunk/WebKit

2006-12-22 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by Steve Winship and Yongjun Zhang.
DESC: TSW ID# SRAY-6WQKA6: Formdataautofill: If the form field contains single or double quotes the SQL query to insert, delete data does not work.
http://bugs.webkit.org/show_bug.cgi?id=11927

  • BrowserView/inc/FormDataAutoFillStore.h:
  • BrowserView/src/FormDataAutoFillStore.cpp: (CFormDataAutoFillStore::NewL): (CFormDataAutoFillStore::ConstructL): (CFormDataAutoFillStore::GetDataL): (CFormDataAutoFillStore::DeleteDataL): (CFormDataAutoFillStore::InsertDataL): (CFormDataAutoFillStore::SaveData): (CFormDataAutoFillStore::OpenTableForUse): (CFormDataAutoFillStore::CloseTableAfterUse): (CFormDataAutoFillStore::CreateFormDataTableL): (CFormDataAutoFillStore::WriteLongTextL): (CFormDataAutoFillStore::ReadLongTextL):
6:11 AM Changeset in webkit [18388] by sullivan
  • 5 edits in trunk/WebKit

Reviewed by Geoff Garen

  • improved concept and implementation of my previous checkin after discussing with Darin
  • WebView/WebViewPrivate.h:
  • WebView/WebView.mm: (-[WebView setHoverFeedbackSuspended:]): renamed from setIgnoresMouseMovedEvents, and now tells the main WebHTMLView (if any) that this state has changed. Telling just the main WebHTMLView is a bit of an implementation hack. Hopefully someday we can rework the document architecture and make this kind of thing less hacky (but this is following existing customs, so I don't feel too bad) (-[WebView isHoverFeedbackSuspended]): renamed from ignoresMouseMovedEvents
  • WebView/WebHTMLViewInternal.h: declare _hoverFeedbackSuspendedChanged
  • WebView/WebHTMLView.m: (-[WebHTMLView _updateMouseoverWithEvent:]): test the webView's state of the hit-tested WebHTMLView rather than self (-[WebHTMLView _hoverFeedbackSuspendedChanged]): generate a fake mouse-moved event, which simulates the mouse moving away from the current element or back over it
1:30 AM Changeset in webkit [18387] by zimmermann
  • 4 edits
    5 adds in trunk

Reviewed by Rob.

Fix SVGPathSeg JS object creation. SVGPathSegList has to return
the actual SVGPathSegLineToAbs/MoveToRel... object instead of a pure
SVGPathSeg JS object.

Dec 21, 2006:

10:06 PM Changeset in webkit [22710] by wallis
  • 1 edit in branches/WindowsMerge/WebKitWin/WebView.cpp

Print by spooling PDF

9:53 PM Changeset in webkit [18386] by bdakin
  • 10 edits
    2 adds in trunk

WebCore:

Reviewed by Geoff.

Fix for <rdar://problem/4897162> REGRESSION: Attempting to create a
new message in .Mac web mail causes Safari to crash
( KJS::DOMCSSStyleDeclaration::put() + 368 )

This was a regression from my clone-node change. This fix is very
simple.

  • dom/StyledElement.cpp: (WebCore::StyledElement::copyNonAttributeProperties): Must set the data that getInlineStyleDecl() points to instead of setting m_inlineStyleDecl directly. I also changed some variable names.
  • dom/StyledElement.h: Don't need parameter name here.

Layout Tests:

Reviewed by Beth. (Geoff wrote the new test.)

New test for <rdar://problem/4897162>. This also reverts the layout
test changes that were caused by the first rev of the clone-node
style change.

  • editing/style/remove-underline-across-paragraph-expected.checksum:
  • editing/style/remove-underline-across-paragraph-expected.png:
  • editing/style/remove-underline-across-paragraph-expected.txt:
  • editing/style/remove-underline-expected.checksum:
  • editing/style/remove-underline-expected.png:
  • editing/style/remove-underline-expected.txt:
  • fast/dom/clone-node-style-expected.txt: Added.
  • fast/dom/clone-node-style.html: Added.
9:46 PM Changeset in webkit [22709] by wallis
  • 1 edit in branches/WindowsMerge/WebKitWin/WebView.h

Print by spooling PDF

9:46 PM Changeset in webkit [22708] by wallis
  • 1 edit in branches/WindowsMerge/WebKitWin/Interfaces/IWebViewPrivate.idl

Print by spooling PDF

6:20 PM Changeset in webkit [18385] by bdash
  • 2 edits in trunk/WebKitTools

2006-12-21 Mark Rowe <bdash@webkit.org>

Reviewed by Tim Hatcher.

http://bugs.webkit.org/show_bug.cgi?id=11922
Bug 11922: REGRESSION(r17128): Drosera no longer shows local variables in stack frame

  • Drosera/DebuggerDocument.m: (-[WebScriptObject webScriptAttributeKeysForScriptObject:]): Use an anonymous function with function.call to ensure that the properties are being retrieved from the correct scope object.
5:53 PM Changeset in webkit [18384] by adele
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Geoff.

Test for <rdar://problem/4895716> REGRESSION: Pressing return key in search field doesn't begin search

  • fast/events/onsearch-enter-expected.txt: Added.
  • fast/events/onsearch-enter.html: Added.

WebCore:

Reviewed by Geoff.

  • Fix for <rdar://problem/4895716> REGRESSION: Pressing return key in search field doesn't begin search

Test: fast/events/onsearch-enter.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Calls onSearch when handling "Enter". Also removed special case for AppKit search fields, so now the enter event is considered handled here. (WebCore::HTMLInputElement::onSearch): Added. Dispatches search event.
  • html/HTMLInputElement.h: Added onSearch.
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::onSearch): Calls onSearch on the node.
5:26 PM Changeset in webkit [18383] by darin
  • 2 edits in trunk/WebKit

Reviewed by Oliver.

  • WebInspector/webInspector/inspector.js: Added default values for the new CSS properties so they don't appear in the inspector when their values are uninteresting.
4:03 PM Changeset in webkit [22707] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

3:56 PM Changeset in webkit [18382] by sfalken
  • 1 copy in tags/Safari-521.32.7b

New tag.

3:02 PM Changeset in webkit [18381] by sullivan
  • 4 edits in trunk/WebKit

Reviewed by Geoff Garen

  • added WebKit support for making a web page temporarily ignore mouse movements
  • WebView/WebViewPrivate.h: declare ignoresMouseMovedEvents and setIgnoresMouseMovedEvents:
  • WebView/WebView.mm: added ignoresMouseMovedEvents boolean field to _private data structure (-[WebView setIgnoresMouseMovedEvents:]): set new boolean field (-[WebView ignoresMouseMovedEvents]): return new boolean field
  • WebView/WebHTMLView.m: (-[WebHTMLView _updateMouseoverWithEvent:]): bail out right away if [[self _webView] ignoresMouseMovedEvents]
2:39 PM Changeset in webkit [18380] by ggaren
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Brady Eidson.


<rdar://problem/4897205> ASSERTION FAILURE in ContainerNode::queuePostAttachCallback
when creating an iframe from an iframe onload handler

Test for adding an iframe to the document from another iframe's onload handler.

  • fast/loader/iframe-recursive-synchronous-load-expected.txt: Added.
  • fast/loader/iframe-recursive-synchronous-load.html: Added.

WebCore:

Reviewed by Brady Eidson.


Fixed <rdar://problem/4897205> ASSERTION FAILURE in ContainerNode::queuePostAttachCallback
when creating an iframe from an iframe onload handler

I added that assertion to try to "keep things simple," but I've found a
testcase that demonstrates why things need to be complicated.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::queuePostAttachCallback):
2:37 PM Changeset in webkit [18379] by yongjzha
  • 2 edits in S60/branches/3.1m/WebKit

2006-12-21 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by <yongjun.zhang@nokia.com>.
DESC: TSW# SPIO-6W7GCZ: News Ticker dialog: With a not white background, blinking moving between messages.
http://bugs.webkit.org/show_bug.cgi?id=11881

  • BrowserView/src/LoadListeners.cpp: (CPageLoadListener::HeadersL):
2:25 PM Changeset in webkit [18378] by yongjzha
  • 2 edits in S60/trunk/WebKit

2006-12-21 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by <yongjun.zhang@nokia.com>.
DESC: TSW# SPIO-6W7GCZ: News Ticker dialog: With a not white background, blinking moving between messages.
http://bugs.webkit.org/show_bug.cgi?id=11881

  • BrowserView/src/LoadListeners.cpp: (CPageLoadListener::HeadersL):
12:16 PM Changeset in webkit [18377] by ap
  • 5 edits in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11919
Allow setting CSS values to null.

WebCore:

  • bindings/js/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::put): (KJS::DOMCSSStyleDeclarationProtoFunc::callAsFunction): Convert null values to null strings.

LayoutTests:

  • fast/dom/css-set-property-exception-expected.txt:
  • fast/dom/css-set-property-exception.html:
11:45 AM Changeset in webkit [18376] by rwlbuis
  • 3 edits
    2 adds in trunk

Reviewed by Anders.

http://bugs.webkit.org/show_bug.cgi?id=11898
CSSMediaRule functions insertRule and deleteRule assert when called from js in debug builds

Test explicitly for the two media rule functions so it ends up calling callAsFunction.

5:46 AM Changeset in webkit [18375] by lars
  • 15 edits
    19 adds in trunk

Add support for the layoutTestController JavaScript object
to be able to get textOnly dumps.
Added a Qt specific hack to always get the same fonts (the ones
added in this submit) and the same dpi when running the layout tests.
Modified the run-webkit-tests script to also do a comparison to the
Mac generated outputs (by stripping out positioning information).

12:08 AM Changeset in webkit [18374] by bdash
  • 4 edits in trunk

2006-12-21 Mark Rowe <bdash@webkit.org>

Reviewed by Geoff.

http://bugs.webkit.org/show_bug.cgi?id=11888
Bug 11888: REGRESSION (r18320): Web Inspector panes broken

  • WebInspector/webInspector/inspector.js: Use removeProperty to reset a style property to its initial value. Bail out early from updateNodePane if Inspector has not yet been set.

2006-12-21 Mark Rowe <bdash@webkit.org>

Reviewed by Geoff.

http://bugs.webkit.org/show_bug.cgi?id=11888
Bug 11888: REGRESSION (r18320): Web Inspector panes broken

  • Drosera/debugger.js: Use removeProperty to reset a style property to its initial value.

Dec 20, 2006:

11:53 PM Changeset in webkit [18373] by hyatt
  • 1 edit in trunk/LayoutTests/fast/css/computed-style-expected.txt

Land updated results for computed style test.

11:41 PM Changeset in webkit [18372] by hyatt
  • 3 edits in trunk/WebCore

Make sure the execrable match-nearest-mail-blockquote-color CSS property is actually initialized (amazingly
it started off with the value "match", since it wasn't even initialized). Now that it is actually being
initialized and properly copied and assigned to, tests have failed. It seems that we were getting the
behavior of "match" by default, when the initial value was supposed to be "normal."

Because this property really should not exist at all, it's unclear to me what the right solution is here.


  • rendering/RenderStyle.cpp: (WebCore::StyleCSS3NonInheritedData::StyleCSS3NonInheritedData): (WebCore::StyleCSS3NonInheritedData::operator==):
  • rendering/RenderStyle.h:
9:43 PM Changeset in webkit [18371] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Adam's rubberstamp

Accidentally left a logging channel on in my checkin

  • platform/Logging.cpp: (WebCore::):
8:13 PM Changeset in webkit [22706] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Mark Rowe.

Fix: <rdar://4895655> Status bar doesn't display correct text when
WebView is scrolled.

  • WebView.cpp: (WebView::handleMouseEvent): Convert the event coordinates to document coordinates before calling elementAtPoint.
5:42 PM Changeset in webkit [18370] by zimmermann
  • 2 edits in trunk/WebCore

Reviewed by Oliver.

Fix removeItem recursively calling itself (!). It was meant to call m_vector.remove(index)
not removeItem(index, ec). This bug is in SVN for quite some time now :-)

5:29 PM Changeset in webkit [18369] by harrison
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan.

<rdar://problem/4893376> REGRESSION: Crash occurs at WebCoreFrameBridge fontForSelection: when drag selecting from a line break


No layout test added because crash only happens in path where editing window is key,
which is never the case for the automated tests.

  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge fontForSelection:]): Add nil check of fontForSelection() result.
4:53 PM Changeset in webkit [18368] by zimmermann
  • 6 edits
    4 adds in trunk/LayoutTests

Reviewed by Adam.

Adding new test js-update-style.svg, testing
dynamic style updates via JS (here: stroke-width change)

Setting eol-style native property for all the js-update*.svg
files, as requested by Adam.

4:50 PM Changeset in webkit [22705] by aroben
  • 3 edits in branches/WindowsMerge/WebCore
4:26 PM Changeset in webkit [18367] by zimmermann
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Beth.

Adding new test js-update-pattern.svg, testing
dynamic pattern updates via JS.

4:13 PM Changeset in webkit [18366] by zimmermann
  • 6 edits in trunk

Reviewed by Maciej.

Fix dynamic gradient changes, via JS. It actually worked before, but it
wasn't repainted. Behave just like the pattern notifyAttributeChange() code now.

3:57 PM Changeset in webkit [18365] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

Fixed <rdar://problem/4809825>. We need to check isSafeScript when converting
a Location to string.


It's really a bug, and poor design, for objects to override toString.
Subclasses that want custom toString implementations should add a toString
function to their prototypes instead of overriding the JavaScript ToString
operation. Following this design pattern would have avoided this bug in the
first place.


  • bindings/js/kjs_window.cpp: (KJS::Location::toString):
3:09 PM Changeset in webkit [18364] by zimmermann
  • 1 edit
    24 adds in trunk/LayoutTests

Reviewed by Sam.
Add a new set of SVG JavaScript testcases, mostly using SVG DOM.

2:54 PM Changeset in webkit [18363] by yongjzha
  • 3 edits in S60/trunk/WebKit

2006-12-20 raalexan <rasvan.alexandrescu@nokia.com>

Reviewed by Sachin and Yongjun.
DESC: Links on sonera.fi when loaded opens toolbar.
http://bugs.webkit.org/show_bug.cgi?id=11843

  • BrowserView/inc/KeyEventHandler.h:
  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleOfferKeyEventL): (CKeyEventHandler::HandleActivateKeysL):
2:43 PM Changeset in webkit [18362] by yongjzha
  • 3 edits in S60/branches/3.1m/WebKit

2006-12-20 raalexan <rasvan.alexandrescu@nokia.com>

Reviewed by Yongjun & Sachin.
DESC: Links on www.sonera.fi don't work and open floating Toolbar
http://bugs.webkit.org/show_bug.cgi?id=11843

  • BrowserView/inc/KeyEventHandler.h:
  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleOfferKeyEventL): (CKeyEventHandler::HandleActivateKeysL):
2:34 PM Changeset in webkit [22704] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

Remove line width setting in font rendering now that GraphicsContext sets
it for us.

  • platform/win/FontWin.cpp: (WebCore::Font::drawGlyphs):
2:30 PM Changeset in webkit [18361] by hyatt
  • 1 edit in trunk/LayoutTests/fast/css/computed-style-expected.txt

Update computed style layout test results.

2:25 PM Changeset in webkit [18360] by hyatt
  • 7 edits in trunk/WebCore

Fix SVG stroking. Make strokeThickness() get pushed into CG immediately
when set in the GraphicsContext. Remove setLineWidth since it is
redundant with setStrokeThickness now.

Reviewed by mitz

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setLineWidth):
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setPlatformStrokeThickness): (WebCore::GraphicsContext::setPlatformStrokeStyle):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::setPlatformStrokeThickness):
  • platform/graphics/qt/GraphicsContextQt.cpp:
  • platform/mac/FontMac.mm: (WebCore::Font::drawComplexText): (WebCore::Font::drawGlyphs):
1:55 PM Changeset in webkit [18359] by hyatt
  • 4 edits in trunk/WebCore

Fix for bug 11893, white text on form controls. Just make sure that
all form control drawing in RenderTheme is bracketed by save/restore
calls.

Reviewed by adele

  • platform/mac/LocalCurrentGraphicsContext.h:
  • platform/mac/LocalCurrentGraphicsContext.mm: (WebCore::LocalCurrentGraphicsContext::LocalCurrentGraphicsContext): (WebCore::LocalCurrentGraphicsContext::~LocalCurrentGraphicsContext):
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintTextField): (WebCore::RenderThemeMac::paintTextArea):
1:54 PM Changeset in webkit [18358] by bdash
  • 2 edits in trunk/WebCore

2006-12-20 Mark Rowe <bdash@webkit.org>

Reviewed by Anders.

Fix leak of CGContextRef from GraphicsContext::createImageBuffer.

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::createImageBuffer): Release newly-created CGContextRef after passing it to GraphicsContext.
1:28 PM Changeset in webkit [18357] by bdakin
  • 4 edits in trunk/LayoutTests

Rubber-stamped by Darin.

This test also needs updated results after my clone node check-in.
Somehow, the fix to clone node eliminated the dummy spans in both
of these tests. This is an improvement.

  • editing/style/remove-underline-expected.checksum:
  • editing/style/remove-underline-expected.png:
  • editing/style/remove-underline-expected.txt:
12:25 PM Changeset in webkit [18356] by andersca
  • 2 edits in trunk/JavaScriptCore
  • kjs/string_object.cpp: (localeCompare): Another speculative Win32 fix.
12:20 PM Changeset in webkit [18355] by andersca
  • 2 edits in trunk/JavaScriptCore
  • kjs/string_object.cpp: (localeCompare): Speculative Win32 fix.
12:11 PM Changeset in webkit [18354] by andersca
  • 3 edits in trunk/JavaScriptCore

Reviewed by Darin.

<rdar://problem/4235733>
<http://bugs.webkit.org/?show_bug.cgi?id=10193>
support String.localeCompare.


Implement localeCompare.


  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/string_object.cpp: (localeCompare): (StringProtoFunc::callAsFunction):
  • kjs/string_object.h: (KJS::StringProtoFunc::):
11:20 AM Changeset in webkit [18353] by thatcher
  • 2 edits in trunk/JavaScriptCore

Reviewed by Mark Rowe.

  • JavaScriptCore.xcodeproj/project.pbxproj: use GCC 4.0 for all the other test targets
10:54 AM Changeset in webkit [18352] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe.

<rdar://problem/4871993> WebCore-421.31 build fails with "Public API change" error when gcc 3.3 is the default compiler

  • bindings/scripts/CodeGeneratorObjC.pm: ignore blank lines in the public API check
10:50 AM Changeset in webkit [18351] by bdakin
  • 4 edits in trunk/LayoutTests

Rubber stamped by Darin.

Updated results for this test after my clone node check-in
yesterday.

  • editing/style/remove-underline-across-paragraph-expected.checksum:
  • editing/style/remove-underline-across-paragraph-expected.png:
  • editing/style/remove-underline-across-paragraph-expected.txt:
10:41 AM Changeset in webkit [18350] by harrison
  • 2 edits in trunk/LayoutTests

Updated for Justin's checkin that added properties.

  • fast/dom/Window/window-properties-expected.txt:
10:36 AM Changeset in webkit [18349] by thatcher
  • 2 edits in trunk/JavaScriptCore

Reviewed by Mark Rowe.

<rdar://problem/4871613> JavaScriptCore-421.31's dftables target needs to override default compiler and use gcc-4.0

10:31 AM Changeset in webkit [18348] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2006-12-20 sareen <set EMAIL_ADDRESS environment variable>

Reviewed Sachin Padma.
DESC:BrowserNG: Opening and closing cover while in text input fields causes

input text to be displaced.

http://bugs.webkit.org/show_bug.cgi?id=11886

  • BrowserView/src/WebKitView.cpp: (CWebKitView::SizeChanged):
10:25 AM Changeset in webkit [18347] by spadma
  • 2 edits in S60/trunk/WebKit

2006-12-20 sareen <set EMAIL_ADDRESS environment variable>

Reviewed Sachin Padma.
DESC:BrowserNG: Opening and closing cover while in text input fields causes

input text to be displaced.

http://bugs.webkit.org/show_bug.cgi?id=11886

  • BrowserView/src/WebKitView.cpp: (CWebKitView::SizeChanged):
8:14 AM Changeset in webkit [18346] by yongjzha
  • 2 edits in S60/branches/3.1m/WebKit

2006-12-19 vbradley <vincent.bradley@nokia.com>

Reviewed by yongjun.zhang@nokia.com
DESC: TSW ID: IRON-6WAAWZ. crash on aol.co.uk
http://bugs.webkit.org/show_bug.cgi?id=11875

  • BrowserCore/Renderers/src/ImageRenderer.cpp: (CImageRenderer::TileInRect):
7:40 AM Changeset in webkit [18345] by harrison
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by John Sullivan.

Test for <rdar://problem/4570218> REGRESSION (?-10.4.7): cntl-K only works the first time

  • editing/deleting/delete-to-end-of-paragraph-expected.checksum: Added.
  • editing/deleting/delete-to-end-of-paragraph-expected.png: Added.
  • editing/deleting/delete-to-end-of-paragraph-expected.txt: Added.
  • editing/deleting/delete-to-end-of-paragraph.html: Added.

WebCore:

Reviewed by John Sullivan.

<rdar://problem/4570218> REGRESSION (?-10.4.7): cntl-K only works the first time

Test:

  • editing/deleting/delete-to-end-of-paragraph.html


  • editing/TypingCommand.cpp: (WebCore::TypingCommand::forwardDeleteKeyPressed): If the selection was a caret at the end of the paragraph, extend selection so it wraps to the start of next paragraph (if any),
6:16 AM Changeset in webkit [18344] by zimmermann
  • 2 edits in trunk/WebCore

Build fix, reviewed by Mitz.
Fix mac build, by using proper float -> int conversion.

3:32 AM Changeset in webkit [18343] by hyatt
  • 1 edit in trunk/WebCore/rendering/InlineTextBox.cpp

Fix warning on buildbot on mac.

3:16 AM Changeset in webkit [18342] by hyatt
  • 3 edits
    4 adds in trunk

Make sure text decoration colors prefer stroke over fill (and honor both of the new CSS properties added
for these values over color).

Reviewed by mitz

Added fast/text/stroking-decorations.html

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintDecorations):
  • rendering/RenderObject.cpp: (WebCore::decorationColor): (WebCore::RenderObject::getTextDecorationColors):
3:05 AM Changeset in webkit [18341] by ddkilzer
  • 9 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for http://bugs.webkit.org/show_bug.cgi?id=11746
REGRESSION(r14931): Outlook Web Access incorrectly positions the insertion point when replying to e-mail

  • editing/selection/move-begin-end-expected.txt: Updated editing delegate results.
  • fast/forms/onselect-textarea-expected.txt: Updated selection start/end positions.
  • fast/forms/textarea-initial-caret-position-expected.txt: Added.
  • fast/forms/textarea-initial-caret-position.html: Added.
  • fast/forms/textarea-no-scroll-on-blur.html: Updated to position caret at end of text to match previous initial focus behavior for this test.
  • fast/forms/textarea-scrollbar.html: Ditto.
  • fast/forms/textarea-scrolled-endline-caret.html: Ditto.
  • fast/forms/textarea-scrolled-type.html: Ditto.

WebCore:

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11746
REGRESSION(r14931): Outlook Web Access incorrectly positions the insertion point when replying to e-mail

Set caret at beginning of text on initial focus.

Test: fast/forms/textarea-initial-caret-position.html

  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::updateFocusAppearance):
2:40 AM Changeset in webkit [22703] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

Add support for stroking and filling of text to CSS. Boomer side. Same code as in FontMac.

  • platform/win/FontWin.cpp: (WebCore::Font::drawGlyphs):
2:31 AM Changeset in webkit [18340] by hyatt
  • 13 edits
    4 adds in trunk

Fix for bug 11889, support stroking and filling of HTML text from CSS. This patch adds four new CSS properties:
text-fill-color, text-stroke-color, text-stroke-width and text-stroke (a shorthand for the other two). Text
is filled and not stroked by default and does so using the text-fill-color. If this property is not set, then
color is used.

Stroking is accomplished by setting a stroke width. Stroke color, if omitted, will be picked up from the color
property. You can set either color to be transparent or partially transparent. A fully transparent fill color is
the way to achieve an "outline" effect where only stroking happens.

Stroking and filling are both customizable inside the ::selection pseudo-element, and so when selecting you can
vary colors and widths.

text-shadow applies to both the stroke and the fill.

text-decorations do not yet respect the stroke/fill colors. This will follow in a later patch.

Reviewed by mitz

Added fast/text/stroking.html as a layout test. Enhanced RenderTreeAsText.cpp to dump fill and stroke information.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSPropertyNames.in:
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • platform/mac/FontMac.mm: (WebCore::Font::drawComplexText): (WebCore::Font::drawGlyphs):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally):
  • rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::InlineFlowBox): (WebCore::InlineFlowBox::maxHorizontalVisualOverflow):
  • rendering/InlineTextBox.cpp: (WebCore::updateGraphicsContext): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintTextMatchMarker):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::selectionForegroundColor):
  • rendering/RenderStyle.cpp: (WebCore::StyleCSS3InheritedData::StyleCSS3InheritedData): (WebCore::StyleCSS3InheritedData::operator==): (WebCore::RenderStyle::diff):
  • rendering/RenderStyle.h: (WebCore::RenderStyle::textStrokeColor): (WebCore::RenderStyle::textStrokeWidth): (WebCore::RenderStyle::textFillColor): (WebCore::RenderStyle::setTextStrokeColor): (WebCore::RenderStyle::setTextStrokeWidth): (WebCore::RenderStyle::setTextFillColor): (WebCore::RenderStyle::initialTextStrokeWidth):
  • rendering/RenderTreeAsText.cpp: (WebCore::operator<<):
2:05 AM Changeset in webkit [18339] by lars
  • 4 edits
    9 adds in trunk/JavaScriptCore

Added support to bind QObject's to JavaScript.

Dec 19, 2006:

11:18 PM Changeset in webkit [18338] by adele
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Anders.

Test for <rdar://problem/3824247> Select All works even if -khtml-user-select:none; style is set

  • editing/selection/select-all-user-select-none-expected.txt: Added.
  • editing/selection/select-all-user-select-none.html: Added.

WebCore:

Reviewed by Anders.

  • Fix for <rdar://problem/3824247> Select All works even if -khtml-user-select:none; style is set

Also made user-select:none work on new list boxes, and cleaned up the list box defaultEventHandler.

Test: editing/selection/select-all-user-select-none.html

  • editing/SelectionController.cpp: (WebCore::SelectionController::selectAll): Make sure canSelect is true on the root renderer.
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::canSelectAll): Check canSelect here. (WebCore::HTMLSelectElement::selectAll): Added nil check for renderer. (WebCore::HTMLSelectElement::defaultEventHandler): Return early if the event has been handled. (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Check canSelect here.
  • html/HTMLSelectElement.h:
10:52 PM Changeset in webkit [18337] by andersca
  • 6 edits in trunk/JavaScriptCore

Reviewed by Geoff.

Add -p option to testkjs which pretty prints the files instead of executing them.

  • JavaScriptCore.exp:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/Parser.cpp: (KJS::Parser::prettyPrint):
  • kjs/Parser.h:
  • kjs/testkjs.cpp: (doIt):
10:22 PM Changeset in webkit [18336] by andersca
  • 2 edits in trunk

Fix bug numbers (Thanks Mitz!)

10:00 PM Changeset in webkit [18335] by andersca
  • 3 edits
    3 adds in trunk

LayoutTests:

Reviewed by Adele.

<rdar://problem/4726407>
[9A255] Crash in WebCore::EventTargetNode::dispatchEvent

  • fast/dom/resources/script-element-gc.js: Added.
  • fast/dom/script-element-gc-expected.txt: Added.
  • fast/dom/script-element-gc.html: Added.

WebCore:

Reviewed by Adele.

<rdar://problem/4726407>
[9A255] Crash in WebCore::EventTargetNode::dispatchEvent


  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::notifyFinished): Ref the script element while running the script since it can be freed when executing the script.
6:53 PM Changeset in webkit [22702] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

6:46 PM Changeset in webkit [18334] by sfalken
  • 1 copy in tags/Safari-521.32.5b

New tag.

5:49 PM Changeset in webkit [18333] by darin
  • 5 edits in trunk/WebCore

Reviewed by Geoff.

  • <rdar://problem/4885227> frame resizing is now live and no longer does direct drawing
  • html/HTMLFrameSetElement.h: Made frameBorder() and noResize() const. Added rowLengths() and colLengths() getters so that we don't have to have RenderFrameSet as a friend. Stopped using bit fields.
  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::defaultEventHandler): Removed now-uneeded check for contextmenu events. Look at return value from userResize to decide whether to mark the event as "default handled". In the case where the event is handled, don't call through to the base class.
  • rendering/RenderFrameSet.h: No longer mark HTMLFrameSetElement as a friend. Made positionFrames and canResize private, and changed canResize to take an IntPoint. Added isResizingRow, isResizingColumn, canResizeRow, and canResizeColumn functions to be used soon for cursor feedback. Removed override of non-virtual element() function and replaced it with a private frameSet() inline function. Grouped all the data members for each axis into a GridAxis class, and made one called m_cols and one called m_rows. Used vectors for the resizable bits of this instead of new/delete arrays. Added a constant named "noSplit" so we don't have to use -1 everywhere explicitly for this purpose. Renamed setResizing to setIsResizing and made it private. Eliminated resizing() function. Added new private helper functions, layOutAxis, findNonResizableSplits, splitPosition, hitTestSplit, startResizing, and continueResizing. Renamed m_resizing to m_isResizing, and m_clientResizing to m_isChildResizing.
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::RenderFrameSet): Removed now-unneeded initialization that is handled by the GridAxis and Vector constructors. (WebCore::RenderFrameSet::~RenderFrameSet): Ditto (for destructors). (WebCore::RenderFrameSet::GridAxis::GridAxis): Added. (WebCore::RenderFrameSet::frameSet): Added. Inline function so we don't have to cast the result of node() or element() everywhere. (WebCore::RenderFrameSet::nodeAtPoint): Updated for name changes. (WebCore::RenderFrameSet::GridAxis::resize): Added. Helper function to be used in the layout function. (WebCore::RenderFrameSet::layOutAxis): Added. Factored out the part of the layout function that used to be inside a for loop for the two axes. The algorithm is otherwise unchanged. (WebCore::RenderFrameSet::findNonResizableSplits): Added. Factored out the code that set up the "split variable" arrays from the layout function. (WebCore::RenderFrameSet::layout): Moved the bulk of this function into the new helpers. This allowed me to remove the use of goto. (WebCore::RenderFrameSet::positionFrames): Updated for change to data structures. Also added some more local variables for clarity. (WebCore::RenderFrameSet::startResizing): Added. Code factored out of the userResize function that handles mousedown events that might begin a resize. (WebCore::RenderFrameSet::continueResizing): Added. Code factored out of the userResize function that handles mouse events that continue a resize already in progress, including mouseup events that end the resizing. Uses the new splitPosition function so it can be used over and over again while resizing. (WebCore::RenderFrameSet::userResize): Restructured to use the new helper functions. Removed the direct drawing of a gray bar during mouse movement; instead we do the resizing live. (WebCore::RenderFrameSet::setIsResizing): Updated for name changes. (WebCore::RenderFrameSet::isResizingRow): Added. (WebCore::RenderFrameSet::isResizingColumn): Added. (WebCore::RenderFrameSet::canResize): Changed to use hitTestSplit for clarity. (WebCore::RenderFrameSet::canResizeRow): Added. (WebCore::RenderFrameSet::canResizeColumn): Added. (WebCore::RenderFrameSet::splitPosition): Added. (WebCore::RenderFrameSet::hitTestSplit): Added. Contains the guts of the code that was used both in canResize and userResize before -- now it's shared. (WebCore::RenderFrameSet::dump): Updated for name changes.
5:37 PM Changeset in webkit [22701] by aliceli1
  • 2 edits in branches/WindowsMerge/WebKitWin

In r11349 I accidentally checked in my local change to the user agent.
Here I am changing it back to what it used to be.

  • WebView.cpp: (WebView::userAgentForKURL):
5:16 PM Changeset in webkit [18332] by justing
  • 6 edits
    6 adds in trunk

LayoutTests:

Reviewed by harrison


Added Selection::removeAllRanges() and ::addRange()


  • editing/selection/addRange-expected.checksum: Added.
  • editing/selection/addRange-expected.png: Added.
  • editing/selection/addRange-expected.txt: Added.
  • editing/selection/addRange.html: Added.
  • editing/selection/removeAllRanges-expected.txt: Added.
  • editing/selection/removeAllRanges.html: Added.

WebCore:

Reviewed by harrison


Added Selection::removeAllRanges() and ::addRange()

  • bindings/js/kjs_window.cpp: (KJS::SelectionFunc::callAsFunction): Added the bindings for the two new functions.
  • bindings/js/kjs_window.h: (KJS::Selection::):
  • editing/SelectionController.cpp: (WebCore::SelectionController::removeAllRanges): Equivalent to clear(). (WebCore::SelectionController::addRange): Until we support discontiguous selections, the new selected range is the union of the old selected range and the passed range if the two intersect, and the old range if they don't.
  • editing/SelectionController.h:
5:07 PM Changeset in webkit [18331] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Darin

  • fix for unrepro infinite recursion bug: <rdar://problem/4448181> CrashTracer: 154 crashes in Safari at com.apple.AppKit: -[NSView isDescendantOf:] + 24; infinite recursion in makeFirstResponder logic
  • WebView/WebView.mm: added becomingFirstResponder BOOL to private struct (-[WebView becomeFirstResponder]): use _private->becomingFirstResponder to guard against infinite recursion; complain on debug builds if we run into this problem
5:06 PM Changeset in webkit [22700] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

4:59 PM Changeset in webkit [18330] by sfalken
  • 1 copy in tags/Safari-521.32.4b

New tag.

4:46 PM Changeset in webkit [22699] by aliceli1
  • 2 edits
    2 adds in branches/WindowsMerge/WebKitWin

Reviewed by Brady.

<rdar://problem/4796729> add "deleteButton" image resource

  • WebKit.vcproj/WebKit.rc:
  • WebKit.vcproj/deleteButton.png: Added.
  • WebKit.vcproj/deleteButtonPressed.png: Added.
4:41 PM Changeset in webkit [18329] by oliver
  • 4 edits in trunk/LayoutTests

m2006-12-19 Oliver Hunt <oliver@apple.com>

rs=ggaren.
Fix expected output of layout test to not rely on ms fonts

  • svg/custom/js-font-test-expected.checksum:
  • svg/custom/js-font-test-expected.png:
  • svg/custom/js-font-test-expected.txt:
4:32 PM Changeset in webkit [18328] by bdakin
  • 6 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/4860924> outerHTML gives an out-of-date
result when applied to a clone

We were only copying the m_inlineStyleDecl over to clones, but we
need to copy m_isStyleAttributeValid and
m_synchronizingStyleAttribute as well to know when we have to
update style, etc.

  • dom/StyledElement.cpp: (WebCore::StyledElement::copyNonAttributeProperties): Copy over all three member variables.
  • dom/StyledElement.h:
  • html/HTMLElement.cpp: (WebCore::HTMLElement::cloneNode): No longer need to copy the inline style decl explicitly because copyNonAttributeProperties() will take care of it.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::copyNonAttributeProperties): Call into parent class implementation. This is important now that there is more than one implementation of this function.
4:20 PM Changeset in webkit [22698] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2006-12-19 Steve Falkenburg <sfalken@apple.com>

Remove non-existent header from vcproj

  • WebCore.vcproj/WebCore.vcproj:
3:44 PM Changeset in webkit [22697] by andersca
  • 3 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Adam, Darin.

<rdar://problem/4769830>
logging to JS console.


Add isError argument to addMessageToConsole.


  • Interfaces/IWebUIDelegatePrivate.idl:
  • WebChromeClient.cpp: (WebChromeClient::addMessageToConsole):
3:39 PM Changeset in webkit [18327] by ggaren
  • 4 edits in trunk/WebCore

Reviewed by Darin Adler.

Fixed http://bugs.webkit.org/show_bug.cgi?id=11880
REGRESSION (r18304): Assertion failure in -[WebHTMLView _canProcessDragWithDraggingInfo:]
when dragging over the window's a scroll bar (innerFrame)


RenderLayer needs to check 'active,' when deciding what to do if hit testing
hasn't hit anything, because we want the default hit testing mechanism to return the
document when we hit a scrollbar.


This problem shows that the idea of 'capturing' was a little too ambitious
in hit testing, at least given the current state of things. So, I've replaced
'capturing' with 'mouseUp,' the condition that provided the immediate need
for the capturing flag in the first place.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent):
  • rendering/HitTestRequest.h: Removed 'capturing' (WebCore::HitTestRequest::HitTestRequest):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestLayer):
3:23 PM Changeset in webkit [22696] by beidson
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Ada

-Changed CFNetwork debugging output to use a logging channel
-Added the url to each logging message - the debugging output was quite crippled without this

3:08 PM Changeset in webkit [18326] by beidson
  • 6 edits in trunk

JavaScriptCore:

Rubberstamped by Lou


Removed unneccessary "else"

  • wtf/Assertions.cpp:

WebCore:

Reviewed by Ada

Added a logging channel for network activity for loader work

  • platform/Logging.cpp: (WebCore::):
  • platform/Logging.h:
  • platform/mac/LoggingMac.mm: (WebCore::InitializeLoggingChannelsIfNecessary):
2:06 PM Changeset in webkit [18325] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by hyatt


<rdar://problem/4888891>
Docs & Spreadsheets: Comment fails to insert if text is selected in the document


  • fast/dom/Range/surroundContents-1-expected.checksum: Added.
  • fast/dom/Range/surroundContents-1-expected.png: Added.
  • fast/dom/Range/surroundContents-1-expected.txt: Added.
  • fast/dom/Range/surroundContents-1.html: Added.

WebCore:

Reviewed by hyatt


<rdar://problem/4888891>
Docs & Spreadsheets: Comment fails to insert if text is selected in the document


  • dom/Range.cpp: (WebCore::Range::surroundContents): If startContainer is a text node, it will be split when the range is extracted, and it will be its parent that will have to accept newParent. Also cleaned up some code with isDescendantOf.
2:00 PM Changeset in webkit [22695] by sfalken
  • 4 edits in branches/WindowsMerge/WebKitWin

2006-12-19 Steve Falkenburg <sfalken@apple.com>

Reviewed by Lou, Adele.


Added CLSID for WebPreferences

  • Interfaces/WebKit.idl:
  • WebKitClassFactory.cpp: (WebKitClassFactory::CreateInstance):
  • WebKitDLL.cpp: (DllGetClassObject):
1:43 PM Changeset in webkit [18324] by thatcher
  • 8 edits in trunk

JavaScriptCore:

Reviewed by Darin.

<rdar://problem/4891774> Local WebCore/WebBrowser builds fail in 9A328 due to warning about ObjC-2.0 language features

JavaScriptGlue:

Reviewed by Darin.

<rdar://problem/4891774> Local WebCore/WebBrowser builds fail in 9A328 due to warning about ObjC-2.0 language features

  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Reviewed by Darin.

<rdar://problem/4891774> Local WebCore/WebBrowser builds fail in 9A328 due to warning about ObjC-2.0 language features

  • WebCore.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Darin.

<rdar://problem/4891774> Local WebCore/WebBrowser builds fail in 9A328 due to warning about ObjC-2.0 language features

  • WebKit.xcodeproj/project.pbxproj:
1:38 PM Changeset in webkit [18323] by zimmermann
  • 3 edits
    4 adds in trunk

Reviewed by Oliver.
Fix SVGList index validation (off-by-one error).

Adding new testcase js-font-test.svg, which uses SVGLengthList interface.
(This is a very old ksvg1 testcase, adopted for SVG1.1)

12:40 PM Changeset in webkit [22694] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Geoff.

<rdar://problem/4876963>
Crash launching Boomer after all options deselected in pref->security


  • loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::partClearedInBegin): Add check for JavaScript.
12:17 PM Changeset in webkit [18322] by zimmermann
  • 7 edits in trunk

Reviewed by Oliver.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11879
Fix pattern on stroke/fill of text.

11:59 AM Changeset in webkit [22693] by andersca
  • 4 edits in branches/WindowsMerge/WebCore

Reviewed by Kevin Decker.

Add (currently disabled) plugin quirks. This is necessary in order to get the Flash plugin
to request windowless plugins (which it only will do if it think it's running on a Mozilla browser).


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::userAgent): (WebCore::PluginViewWin::determineQuirks): (WebCore::PluginViewWin::PluginViewWin):
  • plugins/win/PluginViewWin.h: (WebCore::):
  • plugins/win/npapi.cpp: (NPN_UserAgent):
11:58 AM Changeset in webkit [18321] by aliceli1
  • 2 edits in trunk/WebCore

Build fix

  • platform/graphics/ImageBuffer.cpp:
11:46 AM Changeset in webkit [22692] by beidson
  • 2 edits in branches/WindowsMerge/WebCore

Change by Lou, reviewed by Brady

Scrolling caused Desktop flickering as well as other strange
flickering in the case of a missing plug-in

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::updateHwnd):
10:56 AM Changeset in webkit [18320] by ap
  • 7 edits in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=7296
JavaScript error not thrown when trying to set a CSS property to an invalid value

WebCore:

  • bindings/js/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::put): When not in Dashboard compatibility mode, raise exception for invalid values. Also removed an unnecessary call to removeProperty(), which prevented the property value from being preserved in error case.
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::setProperty): Moved the handling of empty property values here. Also removed an unnecessary call to removeProperty().

LayoutTests:

  • fast/block/positioning/relayout-on-position-change.html: This test was setting position property to an invalid value, expecting that it will be removed. Changed it to set the property to an empty value (now the test passes in Firefox, too).
  • fast/dom/css-set-property-exception-expected.txt:
  • fast/dom/css-set-property-exception.html: Updated the results, added a new case and made the output more verbose.
10:49 AM Changeset in webkit [22691] by andersca
  • 2 edits in branches/WindowsMerge/WebCore
  • WebCore.vcproj/WebCore.vcproj: Update for SVG changes.
10:45 AM Changeset in webkit [18319] by andersca
  • 3 edits in trunk/WebCore

Reviewed by Adam.

  • dom/Document.h:
  • page/EventHandler.h: Use correct forward declarations for HitTestRequest.
10:41 AM Changeset in webkit [18318] by spadma
  • 8 edits
    2 adds in S60/trunk/WebKit

2006-12-14 yaharon <yael.aharon@nokia.com>

Reviewed by Sachin and Zalan.
DESC: Bug 11834: TLUU-6VJQX3 : Cache cannot support more than one application simultaneously
http://bugs.webkit.org/show_bug.cgi?id=11834

  • ChangeLog:
  • ResourceLoader/CacheInc/HttpCacheEntry.h:
  • ResourceLoader/CacheInc/HttpCacheHandler.h:
  • ResourceLoader/CacheInc/HttpCacheLookupTable.h:
  • ResourceLoader/CacheInc/HttpCacheObserver.h: Added. (NONSHARABLE_CLASS):
  • ResourceLoader/CacheSrc/HttpCacheEntry.cpp: (CHttpCacheEntry::Accessed):
  • ResourceLoader/CacheSrc/HttpCacheHandler.cpp: (CHttpCacheHandler::ConstructL): (CHttpCacheHandler::~CHttpCacheHandler): (CHttpCacheHandler::OpenLookupTableL): (CHttpCacheHandler::SaveLookupTableL): (CHttpCacheHandler::UpdateLookupTable): (CHttpCacheHandler::UpdateLookupTableL):
  • ResourceLoader/CacheSrc/HttpCacheLookupTable.cpp:
  • ResourceLoader/CacheSrc/HttpCacheObserver.cpp: Added. (CHttpCacheObserver::CHttpCacheObserver): (CHttpCacheObserver::ConstructL): (CHttpCacheObserver::NewL): (CHttpCacheObserver::~CHttpCacheObserver): (CHttpCacheObserver::RunL): (CHttpCacheObserver::RunError): (CHttpCacheObserver::DoCancel): (CHttpCacheObserver::StartObserver):
  • group/BrowserCache.mmp:
10:36 AM Changeset in webkit [18317] by spadma
  • 8 edits
    2 adds in S60/branches/3.1m/WebKit

2006-12-14 yaharon <yael.aharon@nokia.com>

Reviewed by Sachin and Zalan.
DESC: Bug 11834: TLUU-6VJQX3 : Cache cannot support more than one application simultaneously
http://bugs.webkit.org/show_bug.cgi?id=11834

  • ChangeLog:
  • ResourceLoader/CacheInc/HttpCacheEntry.h:
  • ResourceLoader/CacheInc/HttpCacheHandler.h:
  • ResourceLoader/CacheInc/HttpCacheLookupTable.h:
  • ResourceLoader/CacheInc/HttpCacheObserver.h: Added. (NONSHARABLE_CLASS):
  • ResourceLoader/CacheSrc/HttpCacheEntry.cpp: (CHttpCacheEntry::~CHttpCacheEntry): (CHttpCacheEntry::SetSize): (CHttpCacheEntry::Internalize): (CHttpCacheEntry::Externalize): (CHttpCacheEntry::Accessed):
  • ResourceLoader/CacheSrc/HttpCacheHandler.cpp: (CHttpCacheHandler::ConstructL): (CHttpCacheHandler::~CHttpCacheHandler): (CHttpCacheHandler::OpenLookupTableL): (CHttpCacheHandler::SaveLookupTableL): (CHttpCacheHandler::DoBackgroundSave): (CHttpCacheHandler::UpdateLookupTable): (CHttpCacheHandler::UpdateLookupTableL):
  • ResourceLoader/CacheSrc/HttpCacheLookupTable.cpp:
  • ResourceLoader/CacheSrc/HttpCacheObserver.cpp: Added. (CHttpCacheObserver::CHttpCacheObserver): (CHttpCacheObserver::ConstructL): (CHttpCacheObserver::NewL): (CHttpCacheObserver::~CHttpCacheObserver): (CHttpCacheObserver::RunL): (CHttpCacheObserver::RunError): (CHttpCacheObserver::DoCancel): (CHttpCacheObserver::StartObserver):
  • group/BrowserCache.mmp:
7:09 AM Changeset in webkit [18316] by zimmermann
  • 3 edits in trunk/WebCore

Build fix, not reviewed.

Fix Qt/Linux build. Missing GraphicsContext.h include.
Fix Mac build, by adding lroundf() (I swear this compiled w/o that, locally :-)

6:51 AM Changeset in webkit [18315] by zimmermann
  • 27 edits
    4 adds
    3 deletes in trunk

Reviewed by Sam. Previous attempts reviewed by Oliver & Eric.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11867

Bring back masking, by adding off-screen rendering functionality in GraphicsContext.
Add new "static GraphicsContext* createImageContext(const IntSize& size, bool grayScale)"
function, and implement it with CGBitmapContext in the GraphicsContextCG (stubs for Qt.)

Mask image sizes are dynamically calculated using the passed bounding box in applyMask,
as it was orignally planned. Gradient stroke mask image sizes aren't hardcoded to 2048x2048
anymore, but are as well dynamically calculated using getAbsoluteRepaintRect().

Add new ImageBuffer class encapsulating the size of the image, a platform-specific
handle (ie. CGImageRef for CG platform) plus the GraphicsContext pointer, obtained
via GraphicsContext::createImageBuffer. Offer a generic logic for rendering subtrees
of the rendering tree into a ImageBuffer (see renderSubtreeToImage function)
ImageBufferCG is completly implemented, ImageBufferQt is stubbed.

Also add correct default values for x/y/width/height of <mask>.
Fixes masking related LayoutTests, and speeds up gradient-on-stroke a lot.

3:22 AM Changeset in webkit [18314] by hyatt
  • 1 edit in trunk/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp

Fix spelling error in Cairo graphics context.

3:07 AM Changeset in webkit [18313] by hyatt
  • 1 edit in trunk/WebCore/platform/graphics/cg/GraphicsContextCG.cpp

Remove save()/restore()... forgot they are more expensive.

3:04 AM Changeset in webkit [18312] by hyatt
  • 3 edits in trunk/WebCore

Make sure to initialize the CG fill and stroke colors to our initial fill/stroke colors when first
constructing a GraphicsContextCG. Because Safari actually draws text in the bookmarks bar using GraphicsContext
and sets a fill color, this could only really be seen in another WebKit app.

Patched GraphicsContextQt as well, since it has the same pattern.

Reviewed by bdash

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::setCGFillColor): (WebCore::setCGStrokeColor): (WebCore::GraphicsContext::GraphicsContext):
2:47 AM Changeset in webkit [18311] by hyatt
  • 1 edit in trunk/WebCore/platform/graphics/cg/GraphicsContextCG.cpp

Remove an unnecessary cgsetfill in drawEllipse.

2:26 AM Changeset in webkit [18310] by hyatt
  • 1 edit in trunk/WebCore/platform/graphics/cg/GraphicsContextCG.cpp

Fix buildbot bustage with conversion of stroke thickness.

2:20 AM Changeset in webkit [18309] by hyatt
  • 1 edit in trunk/WebCore/rendering/RenderImage.cpp

Fix drawing of image alt text..

2:08 AM Changeset in webkit [18308] by hyatt
  • 1 edit in trunk/WebCore/rendering/RenderImage.cpp

Fix stroking of error image borders.

1:53 AM Changeset in webkit [18307] by lars
  • 6 edits in trunk

Fix the Qt build and make sure it doesn't crash.

12:54 AM Changeset in webkit [18306] by hyatt
  • 6 edits in trunk/WebCore

Convert stroke thickness to a float. This allows the thickness argument to strokeArc to be eliminated.


Reviewed by olliej

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setStrokeThickness): (WebCore::GraphicsContext::strokeThickness): (WebCore::GraphicsContext::setPlatformStrokeThickness):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::strokeArc):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::setPlatformStrokeThickness):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::drawBorderArc):
12:39 AM Changeset in webkit [18305] by hyatt
  • 6 edits in trunk/WebCore

Rename drawArc to strokeArc and remove its strange behavior of trying to "fill" by stroking using the passed in
thickness. Now the method is purely about stroking an arc and always uses the passed in thickness. Fix the
border-radius code that calls the method so that it makes more sense now. If stroke thickness is converted
to a float, then even the extra argument can go away, and this method can be a clean stroke of an arc.

Make sure to get square list markers right by setting both stroke and fill color properly.

Reviewed by mitz, olliej

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::strokeArc):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::strokeArc):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::drawBorderArc):
12:04 AM Changeset in webkit [18304] by ggaren
  • 10 edits
    4 adds in trunk

LayoutTests:

Reviewed by Beth Dakin.


Test cases for capturing of mouse up events.

  • fast/events/mouseup-outside-button-expected.txt: Added.
  • fast/events/mouseup-outside-button.html: Added.
  • fast/events/mouseup-outside-document-expected.txt: Added.
  • fast/events/mouseup-outside-document.html: Added.

WebCore:

Reviewed by Beth Dakin.

Fixed <rdar://problem/4549745> REGRESSION: scrolling on Google maps
continues after the mouse is released outside the window (8137)


The RenderLayer hit testing code assumed that, when the mouse was outside
the WebView, we only needed to capture mouse events while the mouse was
down (in other words, mouse move events). We actually need to capture mouse
up events, as well.

  • dom/Document.cpp: (WebCore::Document::prepareMouseEvent): To match EventHandler::prepareMouseEvent, I changed this function to take a HitTestRequest instead of the broken-out values of one. For clarity, I moved an assert to top of function. (WebCore::Document::addMarker): Removed stray character.
  • dom/Document.h:
  • page/EventHandler.cpp: Changed prepareMouseEvent to take a HitTestRequest, instead of the broken-out values of one. This simplified the code, and made the task of adding an extra, optional parameter to hit testing much easier. (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseDoubleClickEvent): (WebCore::EventHandler::handleMouseMoveEvent): Set the 'capturing' flag if the move occurs while the mouse is down. This replaces RenderLayer's heavy-handed assumption that we should always capture if the mouse is down. (WebCore::EventHandler::handleMouseReleaseEvent): Set the 'capturing' flag, since we assume every mouse up follows a mouse down inside the WebView. (We'd like to ASSERT as much, but DRT's event sending mechanism is crazy, and violates this axiom.) (WebCore::EventHandler::updateDragAndDrop): (WebCore::EventHandler::prepareMouseEvent): (WebCore::EventHandler::handleWheelEvent): (WebCore::EventHandler::sendContextMenuEvent): (WebCore::EventHandler::hoverTimerFired):
  • page/EventHandler.h:
  • rendering/HitTestRequest.h: (WebCore::HitTestRequest::HitTestRequest): Added 'capturing' data member, which specifies whether the hit test should capture mouse events that occur outside the WebView.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestLayer): Moved misleading comment to where it actually applies. Changed 'active' test to new 'capturing' test, so the hit test requester can decide whether we need to capture mouse events that don't intersect any layer.

WebKitTools:

Reviewed by Beth Dakin.

Updated EventSender to be able to send mouse up events outside the WebView.
This is a minor tweak to a hackish implementation. The real solution
should be to use NSApplication's event sending model instead of rolling
our own, but I don't have time for that right now.


  • DumpRenderTree/EventSendingController.m: (-[EventSendingController mouseUp]):

Dec 18, 2006:

11:45 PM Changeset in webkit [18303] by hyatt
  • 2 edits in trunk/WebCore

Make sure a stroke style is set for list bullets.

Reviewed by mitz

  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
10:28 PM Changeset in webkit [22690] by adachan
  • 10 edits in branches/WindowsMerge

2006-12-18 Ada Chan <adachan@apple.com>

Reviewed by Adam.


Fixed <rdar://4850800> Pop-up window opens with same size as parent window, and app crashes when closing pop-up

  • Corrected the height set on the max/min/restore/close buttons on the top-right of the safari win to take into account its top margin.
  • Implemented the calls we need to close window via script.
  • Added runBeforeUnloadConfirmPanelWithMessage to IWebUIDelegate.
  • implemented canRunBeforeUnloadConfirmPanel, runBeforeUnloadConfirmPanel, and closeWindowSoon in WebChromeClient
  • implemented WebView::closeWindow().

Removed scheduleClose() from FrameWin. The implementation has
been moved to Frame.cpp.

10:15 PM Changeset in webkit [18302] by adachan
  • 22 edits in trunk

2006-12-18 Ada Chan <adachan@apple.com>

Reviewed by Adam.


Moved canRunBeforeUnloadConfirmPanel, runBeforeUnloadConfirmPanel, and closeWindowSoon
from WebCoreFrameBridge to Chrome.
Moved implementation of Frame::scheduleClose to Frame.cpp.

9:53 PM Changeset in webkit [22689] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/platform/win/PopupMenuWin.cpp

Fix Boomer build bustage from Pen conversion.

9:48 PM Changeset in webkit [22688] by beidson
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Alice


Fixes <rdar://4821724> - Wrong site icon displays for sites who don't actually have an icon


We judged whether or not a site has an icon based on whether or not the IconDatabase returned
a valid Image.
In the case of sites without an icon, we actually get returned a valid Image with dimensions 0x0.
WebKit on OS X correctly handles this case via NSImage goodness - now we manually handle it on Windows

  • WebIconDatabase.cpp: (WebIconDatabase::iconForURL): Check the width() as an additional case to fallback to the default icon
9:30 PM Changeset in webkit [18301] by aliceli1
  • 3 edits
    3 adds in trunk

LayoutTests:

Reviewed by Adam.

Test case for <rdar://problem/4766174> REGRESSION(r16081): Aspect eWFM: Unable to log in

  • http/tests/misc/location-test-xsl-style-sheet-expected.txt: Added.
  • http/tests/misc/location-test-xsl-style-sheet.xml: Added.
  • http/tests/misc/resources/location-test-xsl-style-sheet.xsl: Added.

WebCore:

Reviewed by Adam.

Fixed <rdar://problem/4766174> REGRESSION(r16081): Aspect eWFM: Unable to log in

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didExplicitOpen):
9:23 PM Changeset in webkit [18300] by hyatt
  • 1 edit in trunk/WebCore/platform/graphics/qt/GraphicsContextQt.cpp

Fix Qt build bustage by removing uses of Pen and replacing with new stroke APIS.

9:22 PM Changeset in webkit [22687] by sfalken
  • 5 edits in branches/WindowsMerge/WebKitWin

2006-12-18 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam.


Added loadType to IWebFramePrivate.

  • Interfaces/IWebFramePrivate.idl: Added loadType
  • WebFrame.cpp: Fixed line endings (WebFrame::loadType): Added
  • WebFrame.h: Fixed line endings
  • WebKit.vcproj/WebKit.vcproj: Moved WebLocalizableStrings.h to proper folder
9:18 PM Changeset in webkit [18299] by hyatt
  • 1 edit in trunk/WebCore/platform/graphics/qt/GraphicsContextQt.cpp

Fix spelling error in Qt code..

9:17 PM Changeset in webkit [18298] by hyatt
  • 1 edit in trunk/WebCore/platform/graphics/qt/GraphicsContextQt.cpp

Fix Qt build bustage by removing uses of Pen and replacing with new stroke APIS.

9:02 PM Changeset in webkit [18297] by hyatt
  • 1 edit in trunk/WebCore/platform/graphics/qt/GraphicsContextQt.cpp

Fix Qt build bustage by removing setPlatformPen.

8:58 PM Changeset in webkit [18296] by hyatt
  • 2 edits in trunk/WebCore

Add save/restore calls around the painting of text areas on Mac, since the methods in question
alter the current fill color in CG destructively.

Reviewed by olliej

  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintButton): (WebCore::RenderThemeMac::paintTextField): (WebCore::RenderThemeMac::paintTextArea): (WebCore::RenderThemeMac::paintSliderTrack): (WebCore::RenderThemeMac::paintSliderThumb):
8:31 PM Changeset in webkit [18295] by hyatt
  • 2 edits in trunk/WebCore

Fix list markers to properly stroke and fill. I screwed this up when changing how text draws.

Reviewed by olliej

  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
8:21 PM Changeset in webkit [22686] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Adam and Oliver.

<rdar://problem/4856014> Target weekly ad doesn't work.


Store the real base URL and use it for requests.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::getURLNotify): (WebCore::PluginViewWin::getURL): (WebCore::PluginViewWin::handlePost): (WebCore::PluginViewWin::PluginViewWin):
  • plugins/win/PluginViewWin.h:
8:16 PM Changeset in webkit [22685] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/platform/win/FontWin.cpp

Boomer side of pen removal changes.

8:00 PM Changeset in webkit [18294] by hyatt
  • 18 edits in trunk/WebCore

Eliminate the Pen object in favor of separate stroke variables, since most code just wants to set the
stroke color. This also makes it easier for us to push only stroke color through into CG synchronously
while leaving the others alone.

Reviewed by olliej

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContextState::GraphicsContextState): (WebCore::GraphicsContext::setStrokeThickness): (WebCore::GraphicsContext::setStrokeStyle): (WebCore::GraphicsContext::setStrokeColor): (WebCore::GraphicsContext::strokeThickness): (WebCore::GraphicsContext::strokeStyle): (WebCore::GraphicsContext::strokeColor): (WebCore::GraphicsContext::setPlatformStrokeStyle): (WebCore::GraphicsContext::setPlatformStrokeThickness):
  • platform/graphics/GraphicsContext.h: (WebCore::):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::drawArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::drawLineForText): (WebCore::GraphicsContext::setPlatformStrokeColor):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::toQPenStyle): (WebCore::GraphicsContext::setPlatformStrokeColor): (WebCore::GraphicsContext::setPlatformStrokeStyle): (WebCore::GraphicsContext::setPlatformStrokeThickness):
  • platform/mac/FontMac.mm: (WebCore::Font::drawComplexText): (WebCore::Font::drawGlyphs):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintDecorations):
  • rendering/InlineTextBox.cpp: (WebCore::updateTextColor): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintDecoration): (WebCore::InlineTextBox::paintMarkedTextUnderline):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject):
  • rendering/RenderBox.cpp:
  • rendering/RenderBox.h:
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::userResize):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::drawBorderArc): (WebCore::RenderObject::drawBorder):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paint):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paint):
  • rendering/RenderText.cpp:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuListButton):
6:44 PM Changeset in webkit [22684] by darin
  • 2 edits in branches/WindowsMerge/WebCore
  • platform/win/FontWin.cpp: (WebCore::Font::drawGlyphs): Fix build, wrong variable name.
6:30 PM Changeset in webkit [18293] by darin
  • 7 edits in trunk/WebCore

Reviewed by Adele.

  • change DOMActivate events to be created as a part of default handling of click events instead of having the sender of the click event also send a DOMActivate event
  • fixed some edge cases in the slider thumb element handler; since this is inside a shadow DOM, it's likely none of these can arise in practice

No easy way to test the command-click part since the behavior is in Safari.
To make a test we'd have to provide JavaScript access to the modifiers passed
to the policy delegate or have some way to query the underlying event from
JavaScript.

  • dom/EventTargetNode.cpp: Change all assert to ASSERT. (WebCore::EventTargetNode::dispatchMouseEvent): Renamed some local variables for clarity. Added a RefPtr for relatedTarget since it might be deallocated by the handlers for the click event and is used in the code that creates the dblclick event. Removed the code to create a DOMActivate event, since that's now done in the default event handler for the click event. (WebCore::EventTargetNode::defaultEventHandler): Added code to check for a click event and dispatch a DOMActivate event using the click event as the underlying event. The part of this that fixes the bug is that we use the click event as the underlying event; the old code used the same underlying event as for the click event, not the click event itself. The underlying event for the click event is usually 0, since we propagate the key state to the click event instead of using an underlying event in the common case.
  • dom/Document.cpp: (WebCore::Document::defaultEventHandler): Added call to the base class's defaultEventHandler function, except in the case where the event is already handled.
  • html/HTMLInputElement.h: Removed clickX() and clickY().
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::appendFormData): Use xPos and yPos directly, so we can remove clickX() and clickY(). (WebCore::HTMLInputElement::defaultEventHandler): Removed code that calls setDefaultHandled for click events since we are just recording the x and y coordinates of the events; that's not "handling" an event, and setting the flag prevents us from calling the base class's default event handler, which is now needed to submmit the form.
  • rendering/RenderSlider.cpp: (WebCore::HTMLSliderThumbElement::defaultEventHandler): Added some missing isMouseEvent checks in code that casts to a MouseEvent. Added check document()->frame() in code that manipulates the frame so that fake events, which might happen when there's no frame, can't cause a crash. Added an m_inDragMode check so we don't try to handle mouseup events when we are not handling a drag. Remove the setDefaultHandled call from the mousemove case, because mousemove events are observed, and not "handled" in the "nobody else should look at this event" sense. Added a call to the base class's default event handler, and some return statements so that we won't call it when the event has been handled.
  • html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::defaultEventHandler): Removed an unneeded "return" for a function that has no return value.
6:04 PM Changeset in webkit [18292] by bdash
  • 2 edits in trunk/LayoutTests

2006-12-18 Mark Rowe <bdash@webkit.org>

Reviewed by Brady.

Bug 11870: Bug 11866 caused layout test regression in fast/forms/input-value.html
http://bugs.webkit.org/show_bug.cgi?id=11870

  • fast/forms/input-value-expected.txt: Updated results.
5:38 PM Changeset in webkit [18291] by bdakin
  • 4 edits
    4 adds in trunk

WebCore:

Fix for <rdar://problem/4749770> WebCore crashes on a blog website
in WebCore::InlineBox::root() + 6

We null-check inlineBoxWrapper everywhere else in the code except
for these 3 spots. This patch adds them in. Only one of the checks
is required to fix the crash. What we render for the test case now
matches shipping Safari, but still seems wrong because we do not
match Firefox. I will file a follow-up about the rendering problem.

  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::positionListMarker): This is the required null-check.
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::setSelectionState): Null-check for safety. (WebCore::RenderListMarker::selectionRect): Same.

LayoutTests:

Reviewed by Adele.

Test case for <rdar://problem/4749770> WebCore crashes on a blog
website in WebCore::InlineBox::root() + 6

  • fast/lists/inlineBoxWrapperNullCheck-expected.checksum: Added.
  • fast/lists/inlineBoxWrapperNullCheck-expected.png: Added.
  • fast/lists/inlineBoxWrapperNullCheck-expected.txt: Added.
  • fast/lists/inlineBoxWrapperNullCheck.html: Added.
5:26 PM Changeset in webkit [22683] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

Boomer side of my changes for filling/stroking of text.

Reviewed by olliej

  • platform/win/FontWin.cpp: (WebCore::Font::drawGlyphs):
5:18 PM Changeset in webkit [18290] by hyatt
  • 14 edits in trunk/WebCore

Fix performance regression caused by adding setting of stroke colors as well as fill colors to every font drawing
call on Mac. Fix is rather involved:

(1) Fill color is now updated in CG synchronously. There is no more delay in the push. I used the model that
Qt added for this, setPlatformFillColor, so we're the same now.

(2) Text was being drawn using the pen color, which is tantamount to using the stroke color. Since text in HTML
is really a fill and not a stroke, all cross-platform code that draws text has been patched to use fill instead
of the pen.

(3) Added a new API to GraphicsContext to set the text drawing mode to any combination of fill/stroke/clip.
Ports should implement setPlatformTextDrawingMode or just query the mode in their drawGlyphs/drawComplexText
method on their Font class to get the new functionality.

(4) InlineTextBox will set the fill and stroke colors appropriately now rather than always assuming fill.

(5) Fixed a bug in GraphicsContextCG where fillRectWithColor was updating the CG fill color in the state object
as a side effect, creating a mismatch between CG's fill color and the stored cross-platform fill color.

Reviewed by olliej

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContextState::GraphicsContextState): (WebCore::GraphicsContext::textDrawingMode): (WebCore::GraphicsContext::setTextDrawingMode): (WebCore::GraphicsContext::setPlatformTextDrawingMode): (WebCore::GraphicsContext::setPlatformPen):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::setPlatformTextDrawingMode): (WebCore::GraphicsContext::setPlatformFillColor):
  • platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp: (WebCore::SVGPaintServerGradient::teardown): (WebCore::SVGPaintServerGradient::setup):
  • platform/graphics/svg/cg/SVGPaintServerPatternCg.cpp: (WebCore::SVGPaintServerPattern::setup): (WebCore::SVGPaintServerPattern::teardown):
  • platform/graphics/svg/cg/SVGPaintServerSolidCg.cpp: (WebCore::SVGPaintServerSolid::setup):
  • platform/mac/FontMac.mm: (WebCore::Font::drawComplexText): (WebCore::Font::drawGlyphs):
  • platform/mac/WebCoreTextRenderer.mm: (WebCoreDrawTextAtPoint):
  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint):
  • rendering/InlineTextBox.cpp: (WebCore::correctedTextColor): (WebCore::updateTextColor): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintTextMatchMarker):
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
3:28 PM Changeset in webkit [18289] by bdash
  • 3 edits
    5 adds in trunk

2006-12-18 Dex Deacon <occupant4@gmail.com>

Reviewed by Maciej.

Bug 11760: Animated GIFs with offsets crash WebKit
http://bugs.webkit.org/show_bug.cgi?id=11760

  • platform/image-decoders/gif/GIFImageDecoder.cpp: ensure we don't write past the end of the image buffer when the offset is nonzero. also fix the way we composite frames when animating. (WebCore::GIFImageDecoder::initFrameBuffer): (WebCore::GIFImageDecoder::haveDecodedRow):

2006-12-18 Dex Deacon <occupant4@gmail.com>

Reviewed by Maciej.

Layout tests for http://bugs.webkit.org/show_bug.cgi?id=11760

  • ChangeLog:
  • fast/images/animated-gif-with-offsets-expected.txt: Added.
  • fast/images/animated-gif-with-offsets.html: Added.
  • fast/images/resources/animated-gif-with-offsets.gif: Added.
3:22 PM Changeset in webkit [18288] by bdash
  • 3 edits
    4 adds in trunk

2006-12-18 Kirby White <KWhiteRight@gmail.com>

Reviewed by Darin.

Changed hidden input controls to reset to their initial values
when the form is reset. Also added layout tests for resetting
other input controls.

Fixes http://bugs.webkit.org/show_bug.cgi?id=11866

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::storesValueSeparateFromAttribute):

2006-12-18 Kirby White <KWhiteRight@gmail.com>

Reviewed by Darin.

Layout tests for http://bugs.webkit.org/show_bug.cgi?id=11866

  • fast/dom/HTMLInputElement/input-checked-reset-expected.txt: Added.
  • fast/dom/HTMLInputElement/input-checked-reset.html: Added.
  • fast/dom/HTMLInputElement/input-text-reset-expected.txt: Added.
  • fast/dom/HTMLInputElement/input-text-reset.html: Added.
2:57 PM Changeset in webkit [22682] by aliceli1
  • 4 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

<rdar://problem/4853363> hook up various deletion-related functions in WebView

  • WebCore.vcproj/WebCore.vcproj: Added file EditorDeleteAction.h

WebKitWin:

Reviewed by Adam.

<rdar://problem/4853363> hook up various deletion-related functions in WebView

  • WebView.cpp: (WebView::execCommand): Removed the case for ForwardDelete, since it shouldn't be handled there (WebView::deleteSelection): Implemented (WebView::copy): (WebView::cut): (WebView::paste): (WebView::delete_): Use the Editor's execCommand for these editor-responsible functions
2:49 PM Changeset in webkit [18287] by aliceli1
  • 1 edit
    1 add in trunk/WebCore

Oops forgot a file.

  • editing/EditorDeleteAction.h: Added. (WebCore::):
2:47 PM Changeset in webkit [18286] by aliceli1
  • 11 edits in trunk

WebCore:

Reviewed by Adam.

Have the Editor handle deletion instead of WebHTMLView

  • WebCore.exp: Exposed Editor::deleteWithDirection and ::deleteRange()
  • WebCore.xcodeproj/project.pbxproj: Added EditorDeleteAction.h
  • editing/Editor.cpp: (WebCore::Editor::deleteRange): (WebCore::Editor::deleteWithDirection): Implemented

(WebCore::Editor::deleteSelectionWithSmartDelete):
Overloaded to take no params, in which case canSmartCopyOrDelete is called

(WebCore::execCopy):
(WebCore::execCut):
(WebCore::execDelete):
(WebCore::execPaste):
Call the editor instead of asking frame to cut/copy/paste/delete

(WebCore::execBackwardDelete):
(WebCore::execForwardDelete):
Call deleteWithDirection instead of just executing a TypingCommand

(WebCore::CommandEntry::):
distinguished delete (which deletes selection) from backwards delete (single character, no selection)

(WebCore::Editor::cut):
(WebCore::Editor::performDelete):
Trivial changes

  • editing/Editor.h: Added some functons. (WebCore::Editor::setStartNewKillRingSequence): (WebCore::Editor::propogateDOMException): (WebCore::Editor::addToKillRing):
  • editing/mac/EditorMac.mm: Factored out support for Kill Rings to this file
  • platform/mac/PasteboardMac.mm: Trivial change

WebKit:

Reviewed by Adam.

Have the Editor handle deletion instead of WebHTMLView

  • WebKitPrefix.h: Turned on WebCore deletion
  • WebView/WebHTMLViewInternal.h: Moved ownership of startNewKillRingSequence to the WebCore::Editor
  • WebView/WebHTMLView.m: (-[NSArray becomeFirstResponder]): Use the Editor's startNewKillRingSequence flag

(-[NSArray deleteForward:]):
(-[NSArray deleteBackward:]):
(-[NSArray deleteWordForward:]):
(-[NSArray deleteWordBackward:]):
(-[NSArray deleteToBeginningOfLine:]):
(-[NSArray deleteToEndOfLine:]):
(-[NSArray deleteToBeginningOfParagraph:]):
(-[NSArray deleteToEndOfParagraph:]):
(-[NSArray deleteToMark:]):
use Editor::deleteWithDirection instead of WebHTMLView's

2:39 PM Changeset in webkit [22681] by kmccullo
  • 5 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Oliver.

  • Remove CG header includes in OpenSource files
  • config.h:
  • platform/graphics/cg/GraphicsContextPlatformPrivate.h:

WebKitWin:

Reviewed by Oliver.

  • Remove CG header includes in open source files
  • WebView.cpp:
2:32 PM Changeset in webkit [18285] by kmccullo
  • 2 edits in trunk/WebCore

Reviewed by Oliver.

  • Removed CG header include
  • platform/graphics/ImageSource.h:
2:18 PM Changeset in webkit [18284] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Tim Hatcher

  • fixed <rdar://problem/4887764> GMAIL: Crash occurs at WebCore::Range::cloneRange() when I ctrl-click in a empty list item
  • editing/mac/EditorMac.mm: (WebCore::isRangeUngrammatical): bail out immediately for nil range (which selectionController()->toRange().get() can return). Also save some work by bailing out immediately for collapsed ranges.
1:36 PM Changeset in webkit [18283] by yongjzha
  • 2 edits in S60/branches/3.1m/WebKit

2006-12-13 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by yongjun.zhang@nokia.com.
DESC: TSW Id:ELMA-6W2CGN - Browser: Fail to upload an image again
http://bugs.webkit.org/show_bug.cgi?id=11817

  • ResourceLoader/src/PostDataItems.cpp: (CFileDataItem::~CFileDataItem): (CFileDataItem::DataL):
1:31 PM Changeset in webkit [18282] by yongjzha
  • 3 edits in S60/branches/3.1m/WebKit

2006-12-15 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by Yongjun Zhang and Steve Winship.
DESC: TSW id:EYWG-6W7B4F: Error note "Program closed:BrowserNG" after clicking Submit button on test page
http://bugs.webkit.org/show_bug.cgi?id=11781

  • BrowserView/inc/FormDataAutoFillStore.h:
  • BrowserView/src/FormDataAutoFillStore.cpp: (CFormDataAutoFillStore::GetDataL): (CFormDataAutoFillStore::DeleteData): (CFormDataAutoFillStore::InsertData): (CFormDataAutoFillStore::SaveData): (CFormDataAutoFillStore::CreateDatabase): (CFormDataAutoFillStore::CreateFormDataTableL):
1:28 PM Changeset in webkit [18281] by spadma
  • 6 edits in S60/branches/3.1m

2006-12-18 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Minimap and toolbar are displayed under flash content
http://bugs.webkit.org/show_bug.cgi?id=11707

  • BrowserView/inc/WebKitToolBarInterface.h:
  • BrowserView/inc/WebKitView.h:
  • BrowserView/src/WebKitView.cpp: (CWebKitView::PageControlView): (CWebKitView::ResetFlags):
1:21 PM Changeset in webkit [18280] by yongjzha
  • 2 edits in S60/trunk/WebKit

2006-12-13 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by yongjun.zhang@nokia.com.
DESC: TSW Id:ELMA-6W2CGN - Browser: Fail to upload an image again
http://bugs.webkit.org/show_bug.cgi?id=11817

  • ResourceLoader/src/PostDataItems.cpp: (CFileDataItem::~CFileDataItem): (CFileDataItem::DataL):
1:00 PM Changeset in webkit [18279] by spadma
  • 6 edits in S60/trunk

2006-12-18 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Minimap and toolbar are displayed under flash content
http://bugs.webkit.org/show_bug.cgi?id=11707

  • BrowserView/inc/WebKitToolBarInterface.h:
  • BrowserView/inc/WebKitView.h:
  • BrowserView/src/WebKitView.cpp: (CWebKitView::PageControlView): (CWebKitView::ResetFlags):
12:27 PM Changeset in webkit [18278] by ap
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Mitz.

Test for http://bugs.webkit.org/show_bug.cgi?id=7170
`window.parent.[frameName].location=' fails if the target frame has not yet loaded a document

  • fast/frames/resources/set-unloaded-frame-location-1.html: Added.
  • fast/frames/resources/set-unloaded-frame-location-2.html: Added.
  • fast/frames/set-unloaded-frame-location-expected.txt: Added.
  • fast/frames/set-unloaded-frame-location.html: Added.
11:41 AM Changeset in webkit [18277] by thatcher
  • 1 copy in tags/WebKit-419/WebKit

New tag (part 2.)

11:41 AM Changeset in webkit [18276] by thatcher
  • 1 add in tags/WebKit-419

new tag (part 1.)

11:27 AM Changeset in webkit [18275] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Versioning.

10:44 AM Changeset in webkit [18274] by aliceli1
  • 2 edits in trunk/WebCore

Leopard build fix.

  • platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded):
9:58 AM Changeset in webkit [22680] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

Build fixes.

  • WebCore.vcproj/WebCore.vcproj: Removed deleted files.
  • platform/win/CursorWin.cpp: Added missing method. (WebCore::noneCursor):
Note: See TracTimeline for information about the timeline view.