Timeline
Jan 13, 2007:
- 11:53 PM Changeset in webkit [18837] by
-
- 9 edits in trunk
2007-01-14 Mark Rowe <mrowe@apple.com>
Reviewed by Mitz.
Minor fixes to JavaScript pretty-printing.
- JavaScriptCore.exp:
- kjs/Parser.cpp: (KJS::Parser::prettyPrint): Return line number and error message if parsing fails.
- kjs/Parser.h:
- kjs/nodes2string.cpp: (ElementNode::streamTo): Include comma delimiters in array literals. (PropertyNameNode::streamTo): Quote property names in object literals to handle the case when the property name is not a valid identifier.
- kjs/testkjs.cpp: (doIt): Print any errors encountered while pretty-printing.
2007-01-14 Mark Rowe <mrowe@apple.com>
Reviewed by Mitz.
Layout tests for fixes to JavaScript pretty-printing.
- fast/js/pretty-print-expected.txt:
- fast/js/resources/pretty-print.js: Test handling of object literal with non-identifier property name, and of array literals.
- 1:07 PM Changeset in webkit [18836] by
-
- 2 edits in trunk/WebCore
While optimizing form controls and fixing their clipping, I caused this text zoom regression. The layout
of text is necessary because it needs to recalc minmaxwidth. This is still a really unfortunate
bit of code... since a lot of properties don't apply to text (e.g., borders), we're marking text renderers
as dirty when we don't have to.
Reviewed by mitz
- rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle):
- 12:01 PM Changeset in webkit [18835] by
-
- 2 edits in trunk/WebCore
Reviewed by Alexey
String::format() was relying on undefined behaviour, which
happened to work on lots of systems (Mac and 32bit Linux at least)
but broke badly on 64bit Linux.
- 10:48 AM Changeset in webkit [18834] by
-
- 2 edits in trunk/WebCore
Fix for bug 11924: WebCore would crash on any HTML content
with a non-empty <table> tag in it on a 64-bit machine. The
size_t (64bit) vs int (32bit) cast is now fixed in ensureRows,
and the clients of this function have been updated to check
for a false return code.
Reviewed by Darin
- 8:33 AM Changeset in webkit [18833] by
-
- 3 edits2 adds in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=12165
REGRESSION: text encoding problem at jn.sapo.pt
Test: fast/encoding/script-in-head.html
- loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset): Ignore tags within <script> elements in head, just like we do for <title>.
- 3:21 AM Changeset in webkit [18832] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej
Don't crash when constructing a GraphicsContext with a 0
PlatformGraphicsContext and don't do anything if painting
is disabled.
- 3:02 AM Changeset in webkit [18831] by
-
- 3 edits in trunk/WebKitQt
Make the Qt port compile again.
- 1:49 AM Changeset in webkit [18830] by
-
- 7 edits4 adds in trunk
2007-01-13 Eric Seidel <eric@eseidel.com>
Reviewed by hyatt.
RichDraw demo does not live-update in Safari
(SVG elements should ignore CSS position)
http://bugs.webkit.org/show_bug.cgi?id=10364
- css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): ignore position for everything but <svg>
- ksvg2/svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::rebuildRenderer): move path generation into layout()
- rendering/RenderContainer.cpp: (WebCore::RenderContainer::layout): ASSERT kids marked as having completed layout
- rendering/RenderPath.cpp: (WebCore::RenderPath::layout): move path generation into layout()
- rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout): ASSERT kids marked as having completed layout
- 12:16 AM Changeset in webkit [18829] by
-
- 1 edit in trunk/WebCore/rendering/RenderBlock.cpp
Fix leak of column vector.
Jan 12, 2007:
- 11:11 PM Changeset in webkit [18828] by
-
- 4 adds in trunk/LayoutTests/fast/multicol
Add layout test for column rules.
- 11:08 PM Changeset in webkit [18827] by
-
- 3 edits in trunk/WebCore
Add support for column rules.
Reviewed by bdash
fast/multicol/column-rules.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintColumns):
- rendering/RenderStyle.h: (WebCore::RenderStyle::columnRuleIsTransparent):
- 9:32 PM Changeset in webkit [18826] by
-
- 3 edits in trunk/WebCore
Make multicolumn layout work with floats.
Reviewed by andersca
Added fast/multicol/float-multicol.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::paintColumns): (WebCore::RenderBlock::paintObject):
- rendering/RenderBlock.h:
- 9:31 PM Changeset in webkit [18825] by
-
- 6 adds in trunk/LayoutTests/fast/multicol
New fancy float multicol test (thanks Mozilla!)
- 8:22 PM Changeset in webkit [18824] by
-
- 3 edits4 adds in trunk
LayoutTests:
Reviewed by Maciej.
- test for fast/css/line-height.html REGRESSION (r18816-r18818): Assertion failure in WebCore::Length::Length[in-charge](int, WebCore::LengthType, bool)
- fast/css/line-height-expected.checksum: Added.
- fast/css/line-height-expected.png: Added.
- fast/css/line-height-expected.txt: Added.
- fast/css/line-height.html: Added.
WebCore:
Reviewed by Maciej.
- fix http://bugs.webkit.org/show_bug.cgi?id=12239 REGRESSION (r18816-r18818): Assertion failure in WebCore::Length::Length[in-charge](int, WebCore::LengthType, bool)
Test: fast/css/line-height.html
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createInnerTextStyle): Use a float to create a percent Length.
- 6:15 PM Changeset in webkit [22763] by
-
- 3 edits in branches/WindowsMerge/WebKitWin
Build fixes.
- WebFrame.cpp: (WebFrame::assignIdentifierToInitialRequest): (WebFrame::dispatchWillSendRequest): (WebFrame::dispatchDidReceiveResponse): (WebFrame::dispatchDidReceiveContentLength): (WebFrame::dispatchDidFinishLoading): (WebFrame::dispatchDidFailLoading): (WebFrame::incrementProgress): (WebFrame::completeProgress): (WebFrame::dispatchDidReceiveAuthenticationChallenge): (WebFrame::dispatchDidCancelAuthenticationChallenge):
- WebFrame.h:
- 5:47 PM Changeset in webkit [18823] by
-
- 1 edit in trunk/JavaScriptCore/wtf/HashTraits.h
Forgot to save.
- 5:44 PM Changeset in webkit [18822] by
-
- 16 edits in trunk
Reviewed by Darin.
- wtf/HashTraits.h: Add hash traits for unsigned long and unsigned long long.
WebCore:
Reviewed by Darin.
Use unsigned long for identifiers instead of Objective-C objects.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::FrameLoader::startLoadingMainResource): (WebCore::FrameLoader::startLoading): (WebCore::FrameLoader::assignIdentifierToInitialRequest): (WebCore::FrameLoader::opened): (WebCore::FrameLoader::sendRemainingDelegateMessages): (WebCore::FrameLoader::requestFromDelegate): (WebCore::FrameLoader::loadedResourceFromMemoryCache):
- loader/FrameLoader.h:
- loader/FrameLoaderClient.h:
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::willSendRequest):
- loader/ResourceLoader.h: (WebCore::ResourceLoader::setIdentifier): (WebCore::ResourceLoader::identifier):
- page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::createUniqueIdentifier):
- page/Page.h:
- platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::assignIdentifierToInitialRequest): (WebCore::SVGEmptyFrameLoaderClient::dispatchWillSendRequest): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveResponse): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveContentLength): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFinishLoading): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFailLoading): (WebCore::SVGEmptyFrameLoaderClient::incrementProgress): (WebCore::SVGEmptyFrameLoaderClient::completeProgress):
WebKit:
Reviewed by Darin.
Add a HashMap between unsigned longs and Objective-C objects and use it for
the resource load delegate.
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::assignIdentifierToInitialRequest): (WebFrameLoaderClient::dispatchIdentifierForInitialRequest): (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebFrameLoaderClient::dispatchDidFinishLoading): (WebFrameLoaderClient::dispatchDidFailLoading): (WebFrameLoaderClient::incrementProgress): (WebFrameLoaderClient::completeProgress):
- WebView/WebView.mm: (-[WebViewPrivate init]): (-[WebViewPrivate dealloc]): (-[WebView _addObject:forIdentifier:]): (-[WebView _objectForIdentifier:]): (-[WebView _removeObjectForIdentifier:]):
- WebView/WebViewInternal.h:
- 5:19 PM Changeset in webkit [18821] by
-
- 2 edits in trunk/WebCore
2007-01-12 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=12235 REGRESSION (r18815): Marquees do not scroll
- css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): Apply the '-webkit-marquee' value of 'overflow-x' and 'overflow-y'.
- 4:45 PM Changeset in webkit [22762] by
-
- 6 edits1 add in branches/WindowsMerge/WebKitWin
2007-01-12 Ada Chan <adachan@apple.com>
Reviewed by Steve.
WebKitWin:
- Added IWebBackForwardListPrivate which contains the removeItem method, used in undo/redo of closing tabs.
- Fixed a null dereference I ran into in WebFrame::dispatchDidFirstLayout.
- Interfaces/IWebBackForwardListPrivate.idl: Added.
- WebBackForwardList.cpp: (WebBackForwardList::QueryInterface): (WebBackForwardList::removeItem):
- WebBackForwardList.h:
- WebFrame.cpp: (WebFrame::dispatchDidFirstLayout):
- WebKit.vcproj/Interfaces.vcproj:
- WebKit.vcproj/WebKitGUID.vcproj:
- 3:07 PM Changeset in webkit [18820] by
-
- 17 edits4 adds in trunk
LayoutTests:
Reviewed by hyatt
<rdar://problem/4875425>
EBay, GMail, and GoogleDocs RTEs font size popups don't work
Added to test changes:
- editing/style/fontsize-1-expected.checksum: Added.
- editing/style/fontsize-1-expected.png: Added.
- editing/style/fontsize-1-expected.txt: Added.
- editing/style/fontsize-1.html: Added.
Removed use of "px" and "pt" values passed to
execCommand("FontSize", ...) (other browsers don't
support them):
- editing/input/attributed-substring-from-range-lines.html-disabled:
- editing/style/block-style-004-expected.checksum:
- editing/style/block-style-004-expected.png:
- editing/style/block-style-004-expected.txt:
- editing/style/block-style-004.html:
- editing/style/block-style-005-expected.checksum:
- editing/style/block-style-005-expected.png:
- editing/style/block-style-005-expected.txt:
- editing/style/block-style-005.html:
- editing/style/block-style-006-expected.checksum:
- editing/style/block-style-006-expected.png:
- editing/style/block-style-006-expected.txt:
- editing/style/block-style-006.html:
WebCore:
Reviewed by hyatt
<rdar://problem/4875425>
EBay, GMail, and GoogleDocs RTEs font size popups don't work
Changed execCommand("FontSize", ...) to match the spec
and the behavior of other browsers. It expects a number,
n, which, the spec says can be 1 through 7. Other browsers
perform the font size change by creating a font element
wrapper with size="n". We convert n into one of the absolute
size CSS keywords (x-small, medium, etc.).
- editing/JSEditor.cpp: Call cssValueFromFontSizeNumber. If successful, perform the style change.
- html/HTMLFontElement.cpp: (WebCore::HTMLFontElement::cssValueFromFontSizeNumber): Added. Moved this code from parsedMappedAttribute so that it could be called from the Editor. (WebCore::HTMLFontElement::parseMappedAttribute): Moved code into cssValueFromFontSizeNumber.
- html/HTMLFontElement.h:
- 2:53 PM Changeset in webkit [18819] by
-
- 18 edits in trunk/WebCore
Fix for bug 11598, implement lightweight control clipping mechanism for
buttons, list boxes, and dropdown lists. Make sure list box respects
scrollLeft/Top/Width/Height as well as clientWidth/Height.
Fix bugs in RenderStyle::diff. CursorData was not being compared properly.
vertical-align had a non-inline display check that was wrong (preventing
dynamic changes to keyword-based vertical-align from working).
Reviewed by mitz
- page/EventHandler.cpp: (WebCore::EventHandler::selectClosestWordFromMouseEvent):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::layout): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::determineHorizontalPosition): (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::paint): (WebCore::RenderBlock::fillHorizontalSelectionGap): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::layoutColumns):
- rendering/RenderBox.cpp: (WebCore::RenderBox::computeAbsoluteRepaintRect):
- rendering/RenderBox.h:
- rendering/RenderButton.cpp: (WebCore::RenderButton::setStyle): (WebCore::RenderButton::controlClipRect):
- rendering/RenderButton.h: (WebCore::RenderButton::hasControlClip):
- rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): (WebCore::RenderFlexibleBox::layoutHorizontalBox): (WebCore::RenderFlexibleBox::layoutVerticalBox):
- rendering/RenderFlow.cpp: (WebCore::RenderFlow::addFocusRingRects):
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::itemBoundingBoxRect): (WebCore::RenderListBox::paintObject): (WebCore::RenderListBox::itemHeight): (WebCore::RenderListBox::verticalScrollbarWidth): (WebCore::RenderListBox::scrollWidth): (WebCore::RenderListBox::scrollHeight): (WebCore::RenderListBox::scrollLeft): (WebCore::RenderListBox::setScrollLeft): (WebCore::RenderListBox::scrollTop): (WebCore::RenderListBox::setScrollTop): (WebCore::RenderListBox::controlClipRect):
- rendering/RenderListBox.h: (WebCore::RenderListBox::hasControlClip):
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::setStyle): (WebCore::RenderMenuList::controlClipRect):
- rendering/RenderMenuList.h: (WebCore::RenderMenuList::hasControlClip):
- rendering/RenderObject.cpp: (WebCore::RenderObject::verticalScrollbarWidth): (WebCore::RenderObject::horizontalScrollbarHeight): (WebCore::RenderObject::clientWidth): (WebCore::RenderObject::clientHeight): (WebCore::RenderObject::setStyle):
- rendering/RenderObject.h: (WebCore::RenderObject::hasControlClip): (WebCore::RenderObject::controlClipRect): (WebCore::RenderObject::contentWidth): (WebCore::RenderObject::contentHeight):
- rendering/RenderStyle.cpp: (WebCore::StyleVisualData::StyleVisualData): (WebCore::cursorDataEqvuialent): (WebCore::StyleInheritedData::operator==): (WebCore::CursorList::operator==): (WebCore::RenderStyle::diff):
- rendering/RenderStyle.h: (WebCore::LengthBox::operator!=): (WebCore::StyleVisualData::operator==): (WebCore::CursorData::operator==): (WebCore::CursorData::operator!=): (WebCore::CursorList::operator!=): (WebCore::RenderStyle::setTableLayout):
- rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
- 2:46 PM Changeset in webkit [18818] by
-
- 1 edit in trunk/WebCore/rendering/RenderTextControl.cpp
Ooops left off paren.
- 2:43 PM Changeset in webkit [18817] by
-
- 13 edits in S60/branches/3.1m
Index: WebCore/ChangeLog
===================================================================
--- WebCore/ChangeLog (revision 18804)
+++ WebCore/ChangeLog (working copy)
@@ -1,3 +1,24 @@
+2007-01-12 w3liu <wei.liu@nokia.com>
+
+ Reviewed by yongjun.zhang@nokia.com.
+ DESC: [S60] Search, GSM_2006_wk37_V16 Internet: The page displays wrongly when browsing snapshot in Search.
+ http://bugzilla.opendarwin.org/show_bug.cgi?id=12225
+
+ WARNING: NO TEST CASES ADDED OR CHANGED
+
+ * BWINS/WEBCOREU.DEF:
+ * EABI/WebCoreU.DEF:
+ * bridge/WebCoreBridge.cpp:
+ (CWebCoreBridge::CreateDocumentWithEncoding):
+ * bridge/WebCoreBridge.h:
+ * khtml/khtml_part.cpp:
+ (KHTMLPart::write):
+ (KHTMLPart::setEncoding):
+ * khtml/khtmlpart_p.h:
+ * kwq/KWQKHTMLPart.cpp:
+ (KWQKHTMLPart::setEncoding):
+ * kwq/KWQKHTMLPart.h:
+
- 2:35 PM Changeset in webkit [18816] by
-
- 2 edits in trunk/WebCore
Fix for bug 9934, smaller line heights should not be allowed on
text fields.
Reviewed by darin
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createInnerTextStyle):
- 2:26 PM Changeset in webkit [18815] by
-
- 6 edits in trunk
LayoutTests:
Reviewed by Hyatt. Patch by Mitz.
- test updated for http://bugs.webkit.org/show_bug.cgi?id=12215 Treat 'overflow' and '-webkit-border-radius' as shorthands when parsing and when removing.
- fast/css/remove-shorthand-expected.txt:
- fast/css/remove-shorthand.html:
WebCore:
Reviewed by Hyatt. Patch by Mitz.
- http://bugs.webkit.org/show_bug.cgi?id=12215 Treat 'overflow' and '-webkit-border-radius' as shorthands when parsing and when removing.
Test: fast/css/remove-shorthand.html (updated)
- css/CSSMutableStyleDeclaration.cpp: (WebCore::initShorthandMap):
- css/cssparser.cpp: (WebCore::CSSParser::parseValue):
- 1:49 PM Changeset in webkit [18814] by
-
- 3 edits4 adds in trunk
Reviewed by Mitz.
Do not mix up JSSVGPolygonElement and JSSVGPolylineElement.
- 1:46 PM Changeset in webkit [18813] by
-
- 2 edits in trunk/WebCore
Reviewed by andersca.
Fixed: <rdar://problem/4701326>21.2 ms launch time regression spent in +[WebPluginDatabase installedPlugins]
- dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): Added a guard clause for text/html which used to be in WebKit before a lot of the loader plumbing was moved to WebCore. Pinging the plug-in database to ask it if it supports a given mime type has the side effect of reading from disk on first call, therefore such a check should be a last resort.
- 1:23 PM Changeset in webkit [18812] by
-
- 10 edits in S60/trunk/WebKit
2007-01-12 spadma <Sachin.Padma@nokia.com>
Reviewed by Yongjun.
DESC: Autoform fill and key event handling
http://bugs.webkit.org/show_bug.cgi?id=
- BrowserCore/Formcontrols/inc/FControlInputSkin.h:
- BrowserCore/Formcontrols/inc/FControlInputWidget.h:
- BrowserCore/Formcontrols/inc/FControlSelectWidget.h: (CControlSelectWidget::GetSelectWidgetRect):
- BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::HandlePointerEventL): (CFormInputSkin::ActivateL): (CFormInputSkin::UpdatePopupL):
- BrowserCore/Formcontrols/src/FControlInputWidget.cpp: (CControlInputWidget::HandlePointerEventL):
- BrowserCore/Formcontrols/src/FControlSelectWidget.cpp: (CControlSelectWidget::ConstructL): (CControlSelectWidget::PositionListBox): (CControlSelectWidget::HandlePointerEventL): (CControlSelectWidget::HandleListBoxEventL):
- BrowserView/inc/PointerEventHandler.h:
- BrowserView/inc/WebKitView.h:
- BrowserView/src/PointerEventHandler.cpp: (CPointerEventHandler::HandlePointerEventL):
- 1:11 PM Changeset in webkit [18811] by
-
- 8 edits in trunk/JavaScriptCore
RS by Brady Eidson.
Rolling back in r18786 with leaks fixed, and these renames slightly reworked:
Because they can return 0:
rootObjectForImp => findRootObject (overloaded for JSObject* and Interpreter*)
rootObjectForInterpreter => findRootObject (ditto)
findReferenceSet => findProtectCountSet
- 1:10 PM Changeset in webkit [18810] by
-
- 3 edits in trunk/WebCore
WebCore:
Reviewed by Darin. Patch by Mitz.
- fix http://bugs.webkit.org/show_bug.cgi?id=12223 REGRESSION: Leaks under CSSStyleSelector::applyProperty
No test possible (no change to functionality).
- rendering/RenderObject.h: Removed unused forward declaration.
- rendering/RenderStyle.cpp: (WebCore::StyleRareNonInheritedData::~StyleRareNonInheritedData): Delete shadow data.
- 12:52 PM Changeset in webkit [18809] by
-
- 2 edits in S60/trunk/WebKit
2007-01-11 sareen sareen <shyam.sareen@nokia.com>
Reviewed by Sachin Padma.
DESC: Can't change input mode in WAP CSS formatted fields.(TSW ID: TMCN-6S5HZR)
http://bugs.webkit.org/show_bug.cgi?id=12188
- BrowserCore/Formcontrols/src/FInputlFormattedEditor.cpp: (CInputFormattedEditor::UpdateEditingParameters):
- 12:24 PM Changeset in webkit [18808] by
-
- 2 edits in S60/trunk/WebCore
2007-01-12 sareen <shyam.sareen@yahoo.com>
Reviewed by Yongjun.
DESC: Wrong rendering of danish national characters for UTF8 coded web pages.(TSW ID: TMCN-6UQNXY)
http://bugs.webkit.org/show_bug.cgi?id=12217
WARNING: NO TEST CASES ADDED OR CHANGED
- kwq/KWQTextCodec.cpp: (validateUtf8):
- 12:20 PM Changeset in webkit [18807] by
-
- 13 edits in S60/trunk
2007-01-12 w3liu <wei.liu@nokia.com>
Reviewed by yongjun.zhang@nokia.com.
DESC: [S60] Search, GSM_2006_wk37_V16 Internet: The page displays wrongly when browsing snapshot in Search.
http://bugs.webkit.org/show_bug.cgi?id=12225
- BrowserView/inc/WebKitControl.h: (CWebKitControl::DefaultLocaleCharset):
- BrowserView/src/LoadListeners.cpp: (CPageLoadListener::HeadersL):
- BrowserView/src/WebKitControl.cpp: (CWebKitControl::ConstructL):
- 12:06 PM Changeset in webkit [22761] by
-
- 11 edits in branches/WindowsMerge
WebCoreWin:
Reviewed by Darin.
WARNING: NO TEST CASES ADDED OR CHANGED
- loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::didChangeTitle): Copied here from FrameLoaderMac.mm
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::start): Removed setting referrer and user-agend and added a check for null page.
(WebCore::ResourceHandle::cancel):
Don't call didFail.
- platform/win/TemporaryLinkStubs.cpp: (FrameWin::getAppletInstanceForWidget): Use LOG_NOIMPL here.
WebKitWin:
Reviewed by Darin.
Move WebKitWin over to the new WebCore loader. There are still some leftover functions
from FrameWinClient that aren't used and should be removed.
- WebDataSource.cpp: (WebDataSource::WebDataSource): (WebDataSource::~WebDataSource): (WebDataSource::createInstance): (WebDataSource::documentLoader): (WebDataSource::overrideEncoding): (WebDataSource::setOverrideEncoding): (WebDataSource::QueryInterface): (WebDataSource::initWithRequest): (WebDataSource::data): (WebDataSource::representation): (WebDataSource::webFrame): (WebDataSource::initialRequest): (WebDataSource::request): (WebDataSource::response): (WebDataSource::textEncodingName): (WebDataSource::isLoading): (WebDataSource::unreachableURL):
- WebDataSource.h:
- WebFrame.cpp: (WebFrame::WebFramePrivate::m_policyFunction): (WebFrame::WebFrame): (WebFrame::~WebFrame): (WebFrame::QueryInterface): (WebFrame::loadRequest): (WebFrame::loadData): (getWebDataSource): (WebFrame::dataSource): (WebFrame::provisionalDataSource): (WebFrame::stopLoading): (WebFrame::reload): (WebFrame::firstLayoutDone): (WebFrame::loadType): (WebFrame::stopMainResourceLoad): (WebFrame::canProvideDocumentSource): (WebFrame::createFrame): (WebFrame::submitForm): (WebFrame::setTitle): (WebFrame::originalRequestURL): (WebFrame::hasWebView): (WebFrame::hasFrameView): (WebFrame::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebFrame::dispatchDidReceiveTitle): (WebFrame::dispatchDidFirstLayout): (WebFrame::dispatchShow): (WebFrame::cancelPolicyCheck): (WebFrame::dispatchWillSubmitForm): (WebFrame::finishedLoading): (WebFrame::canHandleRequest): (WebFrame::canShowMIMEType): (WebFrame::representationExistsForURLScheme): (WebFrame::updateGlobalHistoryForStandardLoad): (WebFrame::shouldGoToHistoryItem): (WebFrame::createDocumentLoader): (WebFrame::receivedData): (WebFrame::setUpPolicyListener): (WebFrame::receivedPolicyDecision): (WebFrame::committedLoad): (WebFrame::dispatchDecidePolicyForMIMEType): (WebFrame::dispatchCreatePage): (WebFrame::dispatchDidCancelAuthenticationChallenge):
- WebFrame.h:
- WebView.cpp: (WebView::WebView): (WebView::~WebView): (WebViewWndProc): (WebView::close): (WebView::frameLoadDelegate): (WebView::backForwardList): (WebView::setMaintainsBackForwardList): (WebView::goBack): (WebView::goForward): (WebView::goToBackForwardItem): (WebView::setCustomTextEncodingName): (WebView::customTextEncodingName): (WebView::canGoBack): (WebView::canGoForward): (WebView::frameLoadDelegatePrivate):
- WebView.h:
- 11:59 AM Changeset in webkit [18806] by
-
- 2 edits in trunk/WebCore
Build fix.
- WebCore.xcodeproj/project.pbxproj: Remove SubresourceLoaderMac.mm.
- 11:56 AM Changeset in webkit [18805] by
-
- 6 edits1 delete in trunk/WebCore
Reviewed by Darin and Anders.
Make some more of the loader code platform independent.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::createEmptyDocument): (WebCore::FrameLoader::setTitle): (WebCore::FrameLoader::originalRequestURL): (WebCore::FrameLoader::referrer):
- loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::load): (WebCore::SubresourceLoader::create): (WebCore::SubresourceLoader::willSendRequest): (WebCore::SubresourceLoader::didReceiveResponse): (WebCore::SubresourceLoader::didReceiveData): (WebCore::SubresourceLoader::didFinishLoading): (WebCore::SubresourceLoader::didFail): (WebCore::SubresourceLoader::didCancel): (WebCore::SubresourceLoader::stopLoading):
- loader/SubresourceLoader.h:
- loader/mac/FrameLoaderMac.mm:
- loader/mac/SubresourceLoaderMac.mm: Removed.
- loader/qt/FrameLoaderQt.cpp:
- 10:53 AM Changeset in webkit [22760] by
-
- 9 edits2 adds in branches/WindowsMerge/WebKitWin
Reviewed by Geoff.
More loader preparations.
- WebContextMenuClient.cpp: (WebContextMenuClient::getCustomMenuFromDefaultItems): (WebContextMenuClient::contextMenuItemSelected): Use ::createInstance to create the element property bags.
- WebElementPropertyBag.cpp: (WebElementPropertyBag::WebElementPropertyBag): (WebElementPropertyBag::~WebElementPropertyBag): (WebElementPropertyBag::createInstance): (convertStringToVariant):
- WebElementPropertyBag.h: Fix ownership issues so WebElementPropertyBag can one day be a value in another property bag.
- WebFramePolicyListener.cpp: Added. (WebFramePolicyListener::WebFramePolicyListener): (WebFramePolicyListener::~WebFramePolicyListener): (WebFramePolicyListener::createInstance): (WebFramePolicyListener::QueryInterface): (WebFramePolicyListener::AddRef): (WebFramePolicyListener::Release): (WebFramePolicyListener::use): (WebFramePolicyListener::download): (WebFramePolicyListener::ignore): (WebFramePolicyListener::continueSubmit): (WebFramePolicyListener::receivedPolicyDecision): (WebFramePolicyListener::invalidate):
- WebFramePolicyListener.h: Added. Add policy listener implementation.
- WebFrame.cpp: (WebFrame::receivedPolicyDecision):
- WebFrame.h: Add stub to be used by the policy listener.
- WebView.cpp: (WebView::WebView): (WebView::~WebView): (WebView::paint): (WebView::closeWindow): (WebView::handleMouseEvent): (WebViewWndProc): (WebView::initWithFrame): (WebView::setUIDelegate): (WebView::uiDelegate): (WebView::setFrameLoadDelegate): (WebView::frameLoadDelegate): (WebView::preferences): (WebView::elementAtPoint): (WebView::setFormDelegate): (WebView::formDelegate): (WebView::setFrameLoadDelegatePrivate): (WebView::frameLoadDelegatePrivate):
- WebView.h: Cleanup, use COMPtr in a couple of places.
- 7:05 AM Changeset in webkit [18804] by
-
- 7 edits in trunk/WebKitTools
Reviewed by Zack
Get DumpRenderTree to work again for the Qt build.
Make run-webkit-tests a little less verbose when testing
Qt, and add an option to run DumpRenderTree inside valgrind
(useful for debugging)
- 7:00 AM Changeset in webkit [18803] by
-
- 2 edits in trunk/WebCore
Reviewed by Zack
Valgrind reported uninitialized variable.
- platform/network/qt/ResourceHandleManagerQt.cpp: (WebCore::FileLoader::request):
- 4:40 AM Changeset in webkit [18802] by
-
- 2 edits in trunk/WebCore
Reviewed by rwlbuis.
- add missing null check in new fixed table layout code
- 12:47 AM Changeset in webkit [18801] by
-
- 2 edits in trunk/WebKitTools
Add WEBKIT_FULLBUILD to the qmake relevant build part to force
make clean before make as they fix stale dependencies (for buildbot mainly)
- 12:39 AM Changeset in webkit [18800] by
-
- 3 edits in trunk/WebCore
Fix the Qt build after the Authentication changes.
- 12:11 AM Changeset in webkit [18799] by
-
- 2 edits in trunk/WebCore
Fix for bug 9569. Make sure the selection offset for selection roots excludes border and padding.
Reviewed by Eric
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::leftSelectionOffset): (WebCore::RenderBlock::rightSelectionOffset):
Jan 11, 2007:
- 10:46 PM Changeset in webkit [18798] by
-
- 3 edits in trunk/WebCore
Fix for bug 8705, readonly text fields should not get focus rings. Add a rule to that effect to
html4.css and then also add readonly as a special case for style sharing so that we can retain the
performance boost from sharing styles on inputs.
Reviewed by bdash
- css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): (WebCore::CSSStyleSelector::checkOneSelector):
- css/html4.css:
- 10:28 PM Changeset in webkit [18797] by
-
- 3 edits in trunk/LayoutTests/fast/overflow
Update overflow layout test results after autoscroll fix.
- 10:25 PM Changeset in webkit [18796] by
-
- 2 edits in trunk/WebCore
Fix for bug 11595. Autoscrolling of layers didn't really work at all unless the layer was coincidentally
in the root layer's coordinate space. The event point was an absolute position within the document, but
the layer's rect was only local coords. This patch makes sure to use absolute bounds for the layer
when comparing it with the point.
This is covered by the scrollRevealButton test case already in the tree... the results change to be more
correct.
Reviewed by ggaren
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible):
- 10:25 PM Changeset in webkit [18795] by
-
- 9 edits in trunk/JavaScriptCore
RS by Brady Eidson.
Rolling out r18786 because it caused leaks.
- 9:50 PM Changeset in webkit [22759] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
2007-01-11 Steve Falkenburg <sfalken@apple.com>
- WebKit.vcproj/WebKit.make:
- 9:33 PM Changeset in webkit [18794] by
-
- 9 edits in trunk/WebCore
Reviewed by Oliver
-Move more HTTP Auth handling towards ResourceHandle, away from ResourceHandleClient
-Make more of ResourceLoader cross-platform
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::releaseResources): (WebCore::ResourceLoader::didCancel): (WebCore::ResourceLoader::didReceiveAuthenticationChallenge): (WebCore::ResourceLoader::didCancelAuthenticationChallenge): (WebCore::ResourceLoader::receivedCancellation):
- loader/ResourceLoader.h: (WebCore::ResourceLoader::willStopBufferingData): (WebCore::ResourceLoader::didCancelAuthenticationChallenge): (WebCore::ResourceLoader::willCacheResponse):
- loader/mac/ResourceLoaderMac.mm:
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::willStopBufferingData):
- platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (WebCore::ResourceHandle::didCancelAuthenticationChallenge): (WebCore::ResourceHandle::receivedCredential): (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential): (WebCore::ResourceHandle::receivedCancellation): (WebCore::ResourceHandle::clearAuthentication): (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate useCredential:forAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate continueWithoutCredentialForAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate cancelAuthenticationChallenge:]):
- 8:48 PM Changeset in webkit [18793] by
-
- 2 edits in trunk/WebCore
A hit test is returning a null renderer. Make sure to null-check it in the autoscroll code.
This really shouldn't happen, but I'm just going to bullet proof for now given that it's happening
on the front page of yahoo.com!
Reviewed by mark
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll):
- 8:37 PM Changeset in webkit [18792] by
-
- 3 edits5 adds in trunk
LayoutTests:
Force column-width to parse in strict mode so that there is no confusion when it is used in the columns
shorthand (it can be mistaken for column-count otherwise).
Reviewed by Mark
- fast/multicol/columns-shorthand-parsing-expected.checksum: Added.
- fast/multicol/columns-shorthand-parsing-expected.png: Added.
- fast/multicol/columns-shorthand-parsing-expected.txt: Added.
- fast/multicol/columns-shorthand-parsing.html: Added.
WebCore:
Force column-width to parse in strict mode so that there is no confusion when it is used in the columns
shorthand (it can be mistaken for column-count otherwise).
Reviewed by Mark
fast/multicol/columns-shorthand-parsing.html
- css/cssparser.cpp: (WebCore::CSSParser::parseValue):
- 8:29 PM Changeset in webkit [18791] by
-
- 27 edits in trunk
2007-01-11 Mitz Pettel <mitz@webkit.org>
Reviewed by Hyatt.
- fix http://bugs.webkit.org/show_bug.cgi?id=12124 RenderTable::section{Above,Below}() can return the wrong answer for the {footer,header}
- rendering/RenderTable.cpp: (WebCore::resetSectionPointerIfNotBefore): Added this function to help with checking if a section being inserted is the going to be the first of its kind. (WebCore::RenderTable::addChild): Changed to maintain the pointers to the header, the footer, the caption and the first table body properly when objects are inserted in the middle. Also changed to make the first caption win over any other captions. This matches Firefox and what already used to happen when a section recalc took place. (WebCore::RenderTable::layout): Changed to use sectionBelow() for iterating over the sections from top to bottom. (WebCore::RenderTable::calcBorderLeft): Changed to really find the section containing the first row. (WebCore::RenderTable::calcBorderRight): Ditto. (WebCore::RenderTable::sectionAbove): Fixed a bug when the last section was skipped if the input was the footer. (WebCore::RenderTable::sectionBelow): Ditto for "first" and "header" respectively.
2007-01-11 Mitz Pettel <mitz@webkit.org>
Reviewed by Hyatt.
- updated results for http://bugs.webkit.org/show_bug.cgi?id=12124 RenderTable::section{Above,Below}() can return the wrong answer for the {footer,header}
Collapsed borders changed in the "marvin" tests, as the footer cells now
collapse correctly with the last row of the body. Visual differences not
captured by the pixel results since they occurred below 600px.
The "other" test has changed since in a table with multiple captions,
now the first one wins. No visual difference in this case since both captions
are the same.
- tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
- tables/mozilla/marvin/backgr_position-table-expected.txt:
- tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
- tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
- tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
- tables/mozilla/marvin/backgr_simple-table-expected.txt:
- tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
- tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
- tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
- tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
- tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
- tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
- tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
- tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
- tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
- tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
- tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
- tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
- tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
- tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
- tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
- tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
- tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
- tables/mozilla_expected_failures/other/test4-expected.txt:
- 8:28 PM Changeset in webkit [18790] by
-
- 13 edits in trunk
2007-01-11 Mitz Pettel <mitz@webkit.org>
Reviewed by Hyatt.
- fix http://bugs.webkit.org/show_bug.cgi?id=12115 RTL text is jumbled on display
Fixed fixed table layout. Implemented an algorithm that matches the behavior
of Firefox, up to rounding errors.
Fixes three existing table tests.
- rendering/FixedTableLayout.cpp: Undid accidental search-and-replace of "width" to "m_width" in the comments. Removed an outdated comment, since WebKit no longer honors table-layout:fixed for variable-width tables. (WebCore::FixedTableLayout::calcWidthArray): Fixed the logic that finds the first row. Changed to divide the width specified for a cell that spans multiple columns between the columns rather than assign its entire width to each column. (WebCore::FixedTableLayout::calcMinMaxWidth): (WebCore::FixedTableLayout::layout): Implemented the behavior observed in Firefox.
- rendering/FixedTableLayout.h:
2007-01-11 Mitz Pettel <mitz@webkit.org>
Reviewed by Hyatt.
- updated results for http://bugs.webkit.org/show_bug.cgi?id=12115 RTL text is jumbled on display (fixing fixed table layout)
- tables/mozilla/bugs/bug157890-expected.checksum:
- tables/mozilla/bugs/bug157890-expected.png:
- tables/mozilla/bugs/bug157890-expected.txt:
- tables/mozilla/bugs/bug44505-expected.checksum:
- tables/mozilla/bugs/bug44505-expected.png:
- tables/mozilla/bugs/bug44505-expected.txt:
- tables/mozilla_expected_failures/bugs/bug7243-expected.checksum:
- tables/mozilla_expected_failures/bugs/bug7243-expected.png:
- tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
- 8:25 PM Changeset in webkit [18789] by
-
- 2 edits in trunk/WebKitTools
2007-01-11 Mitz Pettel <mitz@webkit.org>
Reviewed by Hyatt.
- http://bugs.webkit.org/show_bug.cgi?id=10249 Temporarily disable tests that are causing kernel panics
Changed the ImageDiff tool not to use CoreImage filters.
- DumpRenderTree/ImageDiff.m: (main): (createImageFromStdin): (compareImages): (getDifferenceBitmap):
- 8:24 PM Changeset in webkit [18788] by
-
- 6 edits4 adds in trunk
2007-01-11 Mitz Pettel <mitz@webkit.org>
Reviewed by Hyatt.
- fix http://bugs.webkit.org/show_bug.cgi?id=8438 iExploder(#460): Assertion failure in RenderObject::drawBorder()
Test: fast/block/basic/fieldset-stretch-to-legend.html
- rendering/RenderBox.cpp: (WebCore::RenderBox::calcWidth): Stretch to the minimum intrinsic width if the object requires it. (WebCore::RenderBox::calcHorizontalMargins): Some style cleanup. (WebCore::RenderBox::calcAbsoluteHorizontal): Stretch to the minimum intrinsic width if the object requires it.
- rendering/RenderBox.h: (WebCore::RenderBox::stretchesToMinIntrinsicWidth): Added. Returns false.
- rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::calcMinMaxWidth): Overloaded RenderBlock's implementation to ensure that the legend's will fit in the fieldset's minimum intrinsic width. (WebCore::RenderFieldset::findLegend): Made const. (WebCore::RenderFieldset::paintBoxDecorations): (WebCore::RenderFieldset::paintBorderMinusLegend): Fixed the behavior when the legend does overflow the fieldset. This is the part of the fix that prevents the assertion failure. If the legend intersects with a corner of the fieldset's border, that corner will not be painted, even if it is not completely occluded. This edge case can be improved with clipping in the future. Added FIXME to implement border-radius.
- rendering/RenderFieldset.h: (WebCore::RenderFieldset::stretchesToMinIntrinsicWidth): Overloaded to return true.
2007-01-11 Mitz Pettel <mitz@webkit.org>
Reviewed by Hyatt.
- test for http://bugs.webkit.org/show_bug.cgi?id=8438 iExploder(#460): Assertion failure in RenderObject::drawBorder()
- fast/block/basic/fieldset-stretch-to-legend-expected.checksum: Added.
- fast/block/basic/fieldset-stretch-to-legend-expected.png: Added.
- fast/block/basic/fieldset-stretch-to-legend-expected.txt: Added.
- fast/block/basic/fieldset-stretch-to-legend.html: Added.
- 6:53 PM Changeset in webkit [22758] by
-
- 2 edits in branches/WindowsMerge/WebCore
- platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::cfURLResponse): Add getter that I forgot to commit.
- 5:14 PM Changeset in webkit [22757] by
-
- 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION
Bump version for submit
- 5:05 PM Changeset in webkit [18787] by
-
- 1 copy in tags/Safari-521.32.11b
New tag.
- 4:46 PM Changeset in webkit [18786] by
-
- 8 edits in trunk/JavaScriptCore
Reviewed by Anders Carlsson.
Even more cleanup in preparation for fixing <rdar://problem/4608404>
WebScriptObject's _executionContext lack of ownership policy causes
crashes (e.g., in Dashcode)
Layout tests pass.
Renames:
ReferencesSet | ProtectCounts => ProtectCountSet (because it's a typename for a set of GC protect counts)
ReferencesByRootMap => RootObjectMap (because RootObjectToProtectCountSetMap would have been confusing)
pv => protectedValues
rootObjectForImp => getRootObject (overloaded for JSObject* and Interpreter*)
rootObjectForInterpreter => getRootObject (ditto)
findReferenceSet => getProtectCountSet
imp => jsObject
(KJS::Bindings::getRootObjectMap): Changed to take advantage of built-in
facility for initializing static variables.
(KJS::Bindings::getProtectCountSet):
(KJS::Bindings::destroyProtectCountSet): Added. Helps encapsulate the fact
that getting a ProtectCountSet entails adding a RootObject to a hash table,
and destroying one entails the reverse.
(KJS::Bindings::getRootObject): Removed spurious NULL check.
(KJS::Bindings::findReferenceSet): Renamed. Changed to use getRootObject()
instead of iterating on its own.
(KJS::Bindings::addNativeReference): Changed to use an early return instead
of indenting the whole function.
(KJS::Bindings::removeNativeReference): Ditto.
- 3:35 PM Changeset in webkit [22756] by
-
- 4 edits in branches/WindowsMerge/WebKitWin
2007-01-11 Steve Falkenburg <sfalken@apple.com>
Reviewed by Lou.
Implement "Make Text Normal Size".
- WebView.cpp: (WebView::canMakeTextStandardSize): Added (WebView::makeTextStandardSize): Added (WebView::toggleContinuousSpellChecking): Added (WebView::toggleSmartInsertDelete): Added
- 3:14 PM Changeset in webkit [18785] by
-
- 2 edits in trunk/WebCore
Reviewed by Build Fix Karma
I broke the release build (debug build passed)
- platform/network/mac/AuthenticationMac.mm: (WebCore::core):
- 3:04 PM Changeset in webkit [22755] by
-
- 5 edits in branches/WindowsMerge
Make it build again after my HTTP Auth opensource checkin
- 2:35 PM Changeset in webkit [18784] by
-
- 1 edit in trunk/WebCore/platform/network/mac/AuthenticationMac.mm
Blind build fix attempt
- 2:20 PM Changeset in webkit [18783] by
-
- 23 edits8 adds in trunk
WebCore:
Reviewed by Anders
Rewrites HTTP Authentication setting up a more platform-independent structure
- WebCore.exp:
- WebCore.xcodeproj/project.pbxproj:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::didReceiveAuthenticationChallenge): (WebCore::FrameLoader::didCancelAuthenticationChallenge):
- loader/FrameLoader.h:
- loader/FrameLoaderClient.h:
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::didCancel):
- loader/ResourceLoader.h: (WebCore::ResourceLoader::didReceiveAuthenticationChallenge): (WebCore::ResourceLoader::didCancelAuthenticationChallenge): (WebCore::ResourceLoader::receivedCredential): (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential): (WebCore::ResourceLoader::receivedCancellation):
- loader/mac/FrameLoaderMac.mm:
- loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::didReceiveAuthenticationChallenge): (WebCore::ResourceLoader::didCancelAuthenticationChallenge): (WebCore::ResourceLoader::receivedCredential): (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential): (WebCore::ResourceLoader::receivedCancellation):
- platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
- platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::willSendRequest): (WebCore::ResourceHandleClient::didReceiveAuthenticationChallenge): (WebCore::ResourceHandleClient::didCancelAuthenticationChallenge): (WebCore::ResourceHandleClient::receivedCredential): (WebCore::ResourceHandleClient::receivedRequestToContinueWithoutCredential): (WebCore::ResourceHandleClient::receivedCancellation): (WebCore::ResourceHandleClient::willCacheResponse):
- platform/network/ResourceResponse.h: (WebCore::operator!=):
- platform/network/URLAuthenticationChallenge.cpp: Added. (WebCore::URLAuthenticationChallenge::URLAuthenticationChallenge): (WebCore::URLAuthenticationChallenge::previousFailureCount): (WebCore::URLAuthenticationChallenge::proposedCredential): (WebCore::URLAuthenticationChallenge::protectionSpace): (WebCore::URLAuthenticationChallenge::failureResponse): (WebCore::URLAuthenticationChallenge::error): (WebCore::URLAuthenticationChallenge::isNull): (WebCore::URLAuthenticationChallenge::nullify): (WebCore::operator==): (WebCore::operator!=):
- platform/network/URLAuthenticationChallenge.h: Added. (WebCore::URLAuthenticationChallenge::sender): (WebCore::URLAuthenticationChallenge::nsURLAuthenticationChallenge):
- platform/network/URLCredential.cpp: Added. (WebCore::URLCredential::URLCredential): (WebCore::URLCredential::user): (WebCore::URLCredential::password): (WebCore::URLCredential::hasPassword): (WebCore::URLCredential::persistence): (WebCore::operator==):
- platform/network/URLCredential.h: Added. (WebCore::): (WebCore::operator!=):
- platform/network/URLProtectionSpace.cpp: Added. (WebCore::URLProtectionSpace::URLProtectionSpace): (WebCore::URLProtectionSpace::host): (WebCore::URLProtectionSpace::port): (WebCore::URLProtectionSpace::serverType): (WebCore::URLProtectionSpace::realm): (WebCore::URLProtectionSpace::authenticationScheme): (WebCore::operator==):
- platform/network/URLProtectionSpace.h: Added. (WebCore::): (WebCore::operator!=):
- platform/network/mac/AuthenticationMac.h: Added.
- platform/network/mac/AuthenticationMac.mm: Added. (WebCore::URLAuthenticationChallenge::URLAuthenticationChallenge): (WebCore::mac): (WebCore::core):
- platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate useCredential:forAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate continueWithoutCredentialForAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate cancelAuthenticationChallenge:]):
- platform/network/mac/ResourceResponseMac.mm: (WebCore::operator==):
WebKit:
Reviewed by Anders
Rewrites HTTP Authentication setting up a more platform-independent structure
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
- WebKit.xcodeproj/project.pbxproj:
WebKitQt:
Keep the fancy new FrameLoaderClientQt building with a small api change in WebCore
Yay for the loader on QT!
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidReceiveAuthenticationChallenge): (WebCore::FrameLoaderClientQt::dispatchDidCancelAuthenticationChallenge):
- WebCoreSupport/FrameLoaderClientQt.h:
- 2:02 PM Changeset in webkit [18782] by
-
- 8 edits in trunk
Reviewed by Anders Carlsson.
Even more cleanup in preparation for fixing <rdar://problem/4608404>
WebScriptObject's _executionContext lack of ownership policy causes
crashes (e.g., in Dashcode)
Layout tests pass.
Renames:
findRootObjectForNativeHandleFunction => createRootObject
FindRootObjectForNativeHandleFunctionPtr => CreateRootObjectFunction
Also removed unnecessary use of "Bindings::" prefix.
- JavaScriptCore.exp:
- bindings/jni/jni_jsobject.cpp: (JavaJSObject::createNative): (JavaJSObject::convertValueToJObject): (JavaJSObject::convertJObjectToValue):
- bindings/runtime_root.cpp: (KJS::Bindings::RootObject::setCreateRootObject):
- bindings/runtime_root.h: (KJS::Bindings::RootObject::createRootObject):
WebCore:
Reviewed by Anders Carlsson.
Even more cleanup in preparation for fixing <rdar://problem/4608404>
WebScriptObject's _executionContext lack of ownership policy causes
crashes (e.g., in Dashcode)
Layout tests pass.
Renames:
findRootObjectForNativeHandleFunction => createRootObject
FindRootObjectForNativeHandleFunctionPtr => createRootObjectFunction
rootForView => createRootObject
getInstanceForView => getPluginInstanceForWidget
- page/mac/FrameMac.mm: (WebCore::FrameMac::getAppletInstanceForWidget): Put the NSView * in a void* variable named "nativeHandle" to be more explicit about the fact that JavaScript's "nativeHandle" is just an NSView *.
(WebCore::getPluginInstanceForWidget): This function now does the NSView *
fetching that its callers used to do.
(WebCore::FrameMac::getEmbedInstanceForWidget): Updated for rename.
(WebCore::FrameMac::getObjectInstanceForWidget): ditto
- page/mac/WebCoreFrameBridge.mm: Killed the WebCoreBridgeInternal category, which was really more of a shmategory. (createRootObject): Removed rootObjectForView, folding it into its only caller, the similarly named rootForView. Renamed the pair to "createRootObject" because that's what they do.
(-[WebCoreFrameBridge init]): Updated for renames
- 1:52 PM Changeset in webkit [18781] by
-
- 1 edit in trunk/WebCore/loader/DocLoader.cpp
Get rid of garbage
- 1:47 PM Changeset in webkit [18780] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
Fix crash on platforms that don't use the new loader yet.
- loader/DocLoader.cpp: (WebCore::DocLoader::requestResource):
- 1:45 PM Changeset in webkit [18779] by
-
- 3 edits2 adds in trunk
LayoutTests:
Reviewed by Adam.
- test for http://bugs.webkit.org/show_bug.cgi?id=11449 Type-to-select in unopened popups doesn't work with Hebrew
- fast/forms/select-type-ahead-non-latin-expected.txt: Added.
- fast/forms/select-type-ahead-non-latin.html: Added.
WebCore:
Reviewed by Adam.
- fix http://bugs.webkit.org/show_bug.cgi?id=11449 Type-to-select in unopened popups doesn't work with Hebrew
Test: fast/forms/select-type-ahead-non-latin.html
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::defaultEventHandler): Changed locale-specific isprint() condition to a Unicode isPrintableChar().
- 1:41 PM Changeset in webkit [18778] by
-
- 3 edits4 adds in trunk
LayoutTests:
Reviewed by geoff
<rdar://problem/4889140>
GMail Editor: List creation fails in new message
- editing/execCommand/insert-list-empty-div-expected.checksum: Added.
- editing/execCommand/insert-list-empty-div-expected.png: Added.
- editing/execCommand/insert-list-empty-div-expected.txt: Added.
- editing/execCommand/insert-list-empty-div.html: Added.
WebCore:
Reviewed by geoff
<rdar://problem/4889140>
GMail Editor: List creation fails in new message
- editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply): Inserting the list into an empty paragraph not held open by a br or a '\n', will invalidate start and end. Insert a placeholder and then recompute start and end.
- 1:15 PM Changeset in webkit [18777] by
-
- 2 edits1 delete in trunk/WebCore
This one is not needed any longer neither.
- 1:04 PM Changeset in webkit [18776] by
-
- 2 edits in trunk/WebKitTools
fix compilation of DumpRenderTree. Will hopefully
make the built bot happy :)
- 12:45 PM Changeset in webkit [18775] by
-
- 2 edits1 delete in trunk/WebCore
remove now unused file.
- 12:33 PM Changeset in webkit [18774] by
-
- 3 edits in trunk/WebCore
WebCore:
Reviewed by NOBODY (build fix).
- loader/mac/FrameLoaderMac.mm: Removed import of LoaderNSURLRequestExtras.h.
- loader/mac/SubresourceLoaderMac.mm: Ditto.
- 12:03 PM Changeset in webkit [18773] by
-
- 2 edits in trunk/WebCore
Fix compile
- 12:00 PM Changeset in webkit [22754] by
-
- 3 edits in branches/WindowsMerge/WebCore
Build fix.
- WebCore.vcproj/WebCore.vcproj:
- platform/win/TemporaryLinkStubs.cpp: (WebCore::Editor::advanceToNextMisspelling):
- 11:53 AM Changeset in webkit [18772] by
-
- 8 edits in trunk/WebCore
Fix build.
- dom/XMLTokenizer.cpp:
- loader/CachedCSSStyleSheet.cpp:
- loader/CachedImage.cpp:
- loader/DocLoader.cpp:
- loader/loader.cpp:
- xml/XSLTProcessor.cpp:
- xml/xmlhttprequest.cpp:
- 11:30 AM Changeset in webkit [18771] by
-
- 8 edits5 deletes in trunk/WebCore
Reviewed by Adam.
Loader cleanup, get rid of unused code.
- WebCore.xcodeproj/project.pbxproj:
- loader/CachedResource.h:
- loader/DocLoader.cpp: (WebCore::DocLoader::requestResource): (WebCore::DocLoader::checkCacheObjectStatus):
- loader/DocLoader.h:
- loader/LoaderFunctions.h: Removed.
- loader/mac/CachedResourceMac.mm: Removed.
- loader/mac/LoaderFunctionsMac.mm: Removed.
- loader/mac/LoaderNSURLRequestExtras.h: Removed.
- loader/mac/LoaderNSURLRequestExtras.m: Removed.
- loader/mac/SubresourceLoaderMac.mm:
- page/mac/WebCoreFrameBridge.mm:
- platform/network/ResourceHandle.cpp:
- 10:25 AM Changeset in webkit [18770] by
-
- 1 edit in trunk/WebCore/ChangeLog
Better Changelog.
- 10:19 AM Changeset in webkit [18769] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam.
Fix for http://bugs.webkit.org/show_bug.cgi?id=12135 REGRESSION:
<input> and <textarea> not focused on right click (4908884 in
Radar)
- page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEvent): Ask if we *have* swallowed the event instead of if we *haven't* when deciding to perform a selection.
- 8:42 AM Changeset in webkit [18768] by
-
- 2 edits in trunk/WebCore
Reviewed by Anders.
- fix http://bugs.webkit.org/show_bug.cgi?id=12189 REGRESSION(r18614-18640): Crash in WebCore::SharedBuffer::hasPlatformData()
- loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus): Added null check.
- 8:39 AM Changeset in webkit [18767] by
-
- 2 edits in trunk/WebKit
Reviewed by Mitz.
- fix http://bugs.webkit.org/show_bug.cgi?id=12180 REGRESSION: Double-clicking on JS exception in JS log crashes in -[SharedBufferData initWithSharedBuffer:]
- WebView/WebDataSource.mm: (-[WebDataSource data]): Added null check.
- 6:55 AM Changeset in webkit [18766] by
-
- 2 edits in trunk/WebCore
- platform/CharacterNames.h: Oops! horizontalEllipsis != zeroWidthSpace!
- 4:34 AM Changeset in webkit [18765] by
-
- 10 edits in trunk
Start using the loader in the Qt port.
- 4:23 AM Changeset in webkit [18764] by
-
- 22 edits6 deletes in trunk
WebCore:
Reviewed by Hyatt.
- removed a couple Mac bridging classes; put the code in WebKit instead
- WebCore.exp: Updated for new WebKit uses.
- WebCore.xcodeproj/project.pbxproj: Removed files.
- bridge/mac/WebCoreEncodings.h: Removed.
- bridge/mac/WebCoreEncodings.mm: Removed.
- bridge/mac/WebMimeTypeRegistryBridge.h: Removed.
- bridge/mac/WebMimeTypeRegistryBridge.mm: Removed.
- platform/mac/WebNSAttributedStringExtras.h: Removed.
- platform/mac/WebNSAttributedStringExtras.mm: Removed.
- platform/mac/PasteboardMac.mm: (WebCore::stripAttachmentCharacters): Added. Moved code from WebNSAttributedStringExtras.mm, and fixed a garbage collection problem (a global with a plain old retain rather than HardRetain). (WebCore::Pasteboard::writeSelection): Updated to use stripAttachmentCharacters.
- removed some DeprecatedCString use
- loader/FrameLoader.cpp: Changed to use String more to eliminate use of DeprecatedCString here in the mailto form support. But maybe we can remove this entirely. Do we really care about mailto forms any more?
- platform/Pasteboard.h: Removed unneeded DeprecatedCString declaration.
- platform/PlatformString.h: Added replace that takes two strings.
- platform/StringImpl.h: Ditto.
- platform/StringImpl.cpp: (WebCore::StringImpl::replace): Ditto.
- platform/TextStream.h: Remove DeprecatedCString case.
- platform/TextStream.cpp: Ditto.
- made a few more files use CharacterNames.h
- platform/CharacterNames.h: Added some more character names and sorted alphabetically.
- bridge/mac/WebCoreStringTruncator.mm: (centerTruncateToBuffer): Use character name from CharacterNames.h. (rightTruncateToBuffer): Ditto. (truncateString): Ditto.
- platform/mac/FontMac.mm: (WebCore::addDirectionalOverride): Ditto.
- rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox): Ditto.
- rendering/bidi.cpp: (WebCore::RenderBlock::checkLinesForTextOverflow): Ditto.
WebKit:
Reviewed by Hyatt.
- moved code from a couple WebCore bridging classes here instead
- Misc/WebNSPasteboardExtras.mm: (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:]): Use MimeTypeRegistry instead of WebMimeTypeRegistryBridge.
- WebView/WebHTMLRepresentation.mm: (stringArray): Added. Helper to convert a HashSet to an NSArray. (concatenateArrays): Added. Helper to concatenate two NSArray objects. (+[WebHTMLRepresentation supportedMIMETypes]): Use MimeTypeRegistry instead of WebMimeTypeRegistryBridge. Also fix a potential GC problem by using a RetainPtr instead of a [retain] on a global variable. (+[WebHTMLRepresentation supportedNonImageMIMETypes]): Ditto. (+[WebHTMLRepresentation supportedImageMIMETypes]): Ditto.
- WebView/WebHTMLView.mm: (-[WebHTMLView _imageExistsAtPaths:]): Use MimeTypeRegistry instead of WebMimeTypeRegistryBridge. (-[WebHTMLView _documentFragmentWithPaths:]): Ditto.
- WebView/WebView.mm: (+[WebView _decodeData:]): Moved code here from the old WebCoreEncodings class.
- WebKit.xcodeproj/project.pbxproj: Let Xcode have its way with this file. Moved WebRenderNode into the appropriate group.
- 4:22 AM Changeset in webkit [18763] by
-
- 2 edits in trunk/LayoutTests/fast/overflow
Land reverted layout tests for the two overflow cases. Although the new results were better, there are issues with what I did to achieve them, so for now going back to the (broken) old results.
- 4:21 AM Changeset in webkit [18762] by
-
- 3 edits in trunk/WebCore
Fix two bugs in positionForCoordinates. (Make it work when you have a margin in between your border and
your first child block.)
Rewrite column rebalancing to have two modes: constrained and unconstrained. In unconstrained mode,
the system will dynamically rebalance as it loses space to breaks and compute a final intrinsic height
for the overall block. In constrained mode, columns flow into the fixed height block, and extra columns
spill out horizontally in the appropriate direction (RTL/LTR).
Make columns work properly with both LTR and RTL overflow blocks.
Initial column test suite coming soon now that the basic layout is right.
Reviewed by darin
- rendering/RenderBlock.cpp: (WebCore:::RenderFlow): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::paintColumns): (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition): (WebCore::RenderBlock::hitTestColumns): (WebCore::RenderBlock::positionForCoordinates): (WebCore::RenderBlock::availableWidth): (WebCore::RenderBlock::calcColumnWidth): (WebCore::RenderBlock::layoutColumns): (WebCore::RenderBlock::adjustPointToColumnContents):
- rendering/RenderBlock.h: (WebCore::RenderBlock::hasColumns):
- 3:13 AM Changeset in webkit [18761] by
-
- 4 edits in trunk/LayoutTests/svg/custom
Fix SVG test cases.
- 12:51 AM Changeset in webkit [18760] by
-
- 14 edits in trunk
Reviewed by Eric.
http://bugs.webkit.org/show_bug.cgi?id=12201
Fix image dragging issues with http://www.carto.net/papers/svg/gui/scrollbar/index.svg
Fix calculation of absolute transform so that viewport x,y
translation is always done, also when viewBox is set.
Jan 10, 2007:
- 11:48 PM Changeset in webkit [18759] by
-
- 1 edit in trunk/WebCore/rendering/RenderBlock.cpp
Remove unused variable.
- 11:26 PM Changeset in webkit [18758] by
-
- 30 edits in trunk/WebCore
Rework positionForCoordinates to be more efficient and to handle multi-column content. This entailed
adding a new field to HitTestResult called localPoint that cached the mouse coordinate in the coordinate
space of the renderer.
positionForCoordinates now takes local coordinates and so no longer needs to waste time recomputing
absolute positions over and over again.
Reviewed by darin
- bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject value]): (-[WebCoreAXObject doAXTextMarkerRangeForLine:]): (-[WebCoreAXObject doAXTextMarkerForPosition:]):
- dom/Document.cpp: (WebCore::Document::prepareMouseEvent):
- editing/SelectionController.cpp: (WebCore::SelectionController::contains):
- editing/visible_units.cpp: (WebCore::previousLinePosition): (WebCore::nextLinePosition):
- page/EventHandler.cpp: (WebCore::EventHandler::selectClosestWordFromMouseEvent): (WebCore::EventHandler::handleMousePressEventDoubleClick): (WebCore::EventHandler::handleMousePressEventTripleClick): (WebCore::EventHandler::handleMousePressEventSingleClick): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::handleMouseReleaseEvent): (WebCore::EventHandler::sendContextMenuEvent):
- page/EventHandler.h:
- page/MouseEventWithHitTestResults.cpp: (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
- page/MouseEventWithHitTestResults.h: (WebCore::MouseEventWithHitTestResults::localPoint):
- page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge _visiblePositionForPoint:]):
- rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::nodeAtPoint):
- rendering/HitTestResult.h: (WebCore::HitTestResult::localPoint): (WebCore::HitTestResult::setLocalPoint):
- rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::nodeAtPoint):
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::nodeAtPoint):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestContents): (WebCore::RenderBlock::positionForCoordinates):
- rendering/RenderBox.cpp: (WebCore::RenderBox::nodeAtPoint):
- rendering/RenderContainer.cpp: (WebCore::RenderContainer::positionForCoordinates):
- rendering/RenderFlow.cpp: (WebCore::RenderFlow::hitTestLines):
- rendering/RenderInline.cpp: (WebCore::RenderInline::positionForCoordinates):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): (WebCore::RenderLayer::hitTestLayer):
- rendering/RenderObject.cpp: (WebCore::RenderObject::updateHitTestResult):
- rendering/RenderObject.h:
- rendering/RenderPath.cpp: (WebCore::RenderPath::nodeAtPoint):
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::positionForCoordinates):
- rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::nodeAtPoint):
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::nodeAtPoint):
- rendering/RenderText.cpp: (WebCore::RenderText::positionForCoordinates):
- rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::nodeAtPoint): (WebCore::RootInlineBox::closestLeafChildForXPos):
- rendering/RootInlineBox.h:
- 11:12 PM Changeset in webkit [18757] by
-
- 9 edits in trunk
Fix Qt build again
- 8:44 PM Changeset in webkit [18756] by
-
- 2 edits in trunk/WebKit
2007-01-10 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=11775 'Show URLs in Tool Tips' preference is ignored
- WebView/WebHTMLView.mm: (-[WebHTMLView _resetCachedWebPreferences:]): (-[WebHTMLView setDataSource:]): Added a call to _resetCachedWebPreferences:. Added an assertion that the view is not closed, instead of reopening it. Reopening should not occur, now that <http://bugs.webkit.org/show_bug.cgi?id=12087> is fixed.
- 6:24 PM Changeset in webkit [18755] by
-
- 11 edits12 adds in trunk
2007-01-10 Kirby White <KWhiteRight@gmail.com>
Reviewed by Darin.
Set image size to fit alt text when image or input-image element
has no src attribute, so that those images show their alt text instead
of showing nothing at all.
- html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::attach):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::attach):
- rendering/RenderImage.cpp: (WebCore::RenderImage::setImageSizeForAltText): (WebCore::RenderImage::imageChanged):
- rendering/RenderImage.h:
2007-01-10 Kirby White <KWhiteRight@gmail.com>
Reviewed by Darin.
New and adjusted test cases for
http://bugs.webkit.org/show_bug.cgi?id=11841
- fast/dom/HTMLImageElement/image-alt-text-expected.checksum: Added.
- fast/dom/HTMLImageElement/image-alt-text-expected.png: Added.
- fast/dom/HTMLImageElement/image-alt-text-expected.txt: Added.
- fast/dom/HTMLImageElement/image-alt-text.html: Added.
- fast/dom/HTMLImageElement/resources/blue_rect.jpg: Added.
- fast/dom/HTMLInputElement/input-image-alt-text-expected.checksum: Added.
- fast/dom/HTMLInputElement/input-image-alt-text-expected.png: Added.
- fast/dom/HTMLInputElement/input-image-alt-text-expected.txt: Added.
- fast/dom/HTMLInputElement/input-image-alt-text.html: Added.
- fast/dom/HTMLInputElement/resources/blue_rect.jpg: Added.
- fast/forms/focus2-expected.txt:
- fast/forms/focus2.html:
- fast/forms/input-value-expected.checksum:
- fast/forms/input-value-expected.png:
- fast/forms/input-value-expected.txt:
- 6:18 PM Changeset in webkit [18754] by
-
- 2 edits in trunk/WebCore
2007-01-11 Mark Rowe <mrowe@apple.com>
Build fix.
- rendering/RenderView.cpp: (WebCore::RenderView::printing):
- 5:47 PM Changeset in webkit [22753] by
-
- 3 edits in branches/WindowsMerge/WebCore
2007-01-10 Steve Falkenburg <sfalken@apple.com>
Reviewed by Lou.
<rdar://problem/4818840> Crash occurs after selecting Print Preview from under the File menu if no printer is selected
- bridge/win/FrameWin.cpp: (WebCore::FrameWin::computePageRects): removed calls to setupRootForPrinting
- bridge/win/FrameWin.h: removed setupRootForPrinting
- 5:46 PM Changeset in webkit [18753] by
-
- 4 edits2 adds in trunk
2007-01-10 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=9284 Quirksmode (CSS1): Removing inline border styles is impossible
Test: fast/css/remove-shorthand.html
- css/CSSMutableStyleDeclaration.cpp: (WebCore::PropertyLonghand::PropertyLonghand): Added this structure containing a pointer to an array if properties and the array's length. (WebCore::PropertyLonghand::properties): (WebCore::PropertyLonghand::length): (WebCore::initShorthandMap): Initialize the mapping from shorthand properties to their dependent properties. (WebCore::CSSMutableStyleDeclaration::removeProperty): Changed to check if the property being removed is a shorthand, and if so, to remove all of its dependent properties. (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet): Added a 'notifyChanged' boolean parameter which controls whether this method calls setChanged() if it actually removes any property.
- css/CSSMutableStyleDeclaration.h:
2007-01-10 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- test for http://bugs.webkit.org/show_bug.cgi?id=9284 Quirksmode (CSS1): Removing inline border styles is impossible
- fast/css/remove-shorthand-expected.txt: Added.
- fast/css/remove-shorthand.html: Added.
- 5:39 PM Changeset in webkit [18752] by
-
- 9 edits in trunk/WebCore
2007-01-10 Steve Falkenburg <sfalken@apple.com>
Reviewed by Kevin.
Removed unnecessary printing state
- 5:23 PM Changeset in webkit [22752] by
-
- 3 edits in branches/WindowsMerge/WebKitWin
Another build fix.
- WebContextMenuClient.cpp: (WebContextMenuClient::lookUpInDictionary):
- WebContextMenuClient.h:
- 5:20 PM Changeset in webkit [22751] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
Another build fix.
- WebContextMenuClient.cpp: (WebContextMenuClient::lookUpInDictionary):
- 5:11 PM Changeset in webkit [22750] by
-
- 2 edits in branches/WindowsMerge/WebCore
Yet another build fix.
- platform/win/TemporaryLinkStubs.cpp: (DocumentLoader::getResponseModifiedHeader):
- 4:56 PM Changeset in webkit [18751] by
-
- 4 edits in trunk/WebCore
Reviewed by Maciej.
Get the Refresh header directly from the ResourceResponse.
- loader/DocumentLoader.h:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad):
- loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::getResponseModifiedHeader):
- 4:17 PM Applications using WebKit edited by
- (diff)
- 4:16 PM Changeset in webkit [18750] by
-
- 2 edits in trunk/WebKitSite
- coding/coding-style.html: Fixed minor validation error.
- 4:10 PM Changeset in webkit [18749] by
-
- 2 edits in trunk/WebKitSite
Reviewed by Beth Dakin.
Updated coding style guidelines to cover a lot of stuff previously absent.
- coding/coding-style.html:
- 3:42 PM Changeset in webkit [22749] by
-
- 3 edits in branches/WindowsMerge/WebKitWin
Reviewed by John.
Fix for <rdar://problem/4914258> REGRESSION: Search in Google now
operates on the current WebView instead of invoking Safari's
service
- WebContextMenuClient.cpp: (WebContextMenuClient::searchWithGoogle): Do all of the work we used to do in WebCore over here in WebKit.
- WebContextMenuClient.h:
- 3:32 PM Changeset in webkit [18748] by
-
- 8 edits in trunk
WebCore:
Reviewed by John.
Fix for <rdar://problem/4914258> REGRESSION: Search in Google now
operates on the current WebView instead of invoking Safari's
service
- page/ContextMenuClient.h: New call to the client to search in google.
- page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Call into the client instead of forming a new url string and loading it.
- platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyContextMenuClient::searchWithGoogle): New call.
WebKit:
Reviewed by John.
Fix for <rdar://problem/4914258> REGRESSION: Search in Google now
operates on the current WebView instead of invoking Safari's
service
- WebCoreSupport/WebContextMenuClient.h:
- WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::searchWithGoogle): Call into WebView to search in Google.
- WebView/WebViewInternal.h: Make _searchWithGoogleFromMenu available.
- 1:38 PM Changeset in webkit [18747] by
-
- 2 edits in trunk/WebCore
Rubberstamped by Darin.
- page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Pass 0 instead of an empty Event to FrameLoader::load and FrameLoader::urlSelected.
- 12:58 PM Changeset in webkit [22748] by
-
- 6 edits in branches/WindowsMerge
WebCoreWin:
Another build fix.
- bridge/win/FrameWin.h:
- loader/win/FrameLoaderWin.cpp:
WebKitWin:
Build fix.
- WebFrame.cpp: (WebFrame::dispatchDidFirstLayout):
- WebFrame.h:
- 12:57 PM Changeset in webkit [18746] by
-
- 2 edits in trunk/WebCore
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::~ResourceLoader): Disable assertion (I forgot to do this even though I added the comment!)
- 12:53 PM Changeset in webkit [18745] by
-
- 2 edits in trunk/WebCore
Reviewed and landed by Anders.
Fix case in vcproj file (the GTK+ port uses the vcproj file).
- WebCore.vcproj/WebCore/WebCore.vcproj:
- 12:12 PM Changeset in webkit [18744] by
-
- 6 edits2 deletes in trunk/WebCore
Make the Qt build compile again after
the ResourceLoader was made platform
independent.
- 12:01 PM Changeset in webkit [22747] by
-
- 5 edits2 adds in branches/WindowsMerge/WebKitWin
Reviewed by Darin.
Add WebDocumentLoader. Implement some of the FrameLoaderClient methods.
Add a resourceRequest() getter to WebMutableURLRequest.
- WebDocumentLoader.cpp: Added. (WebDocumentLoader::WebDocumentLoader): (WebDocumentLoader::setDataSource): (WebDocumentLoader::dataSource): (WebDocumentLoader::attachToFrame): (WebDocumentLoader::detachFromFrame):
- WebDocumentLoader.h: Added.
- WebFrame.cpp: (WebFrame::dispatchWillPerformClientRedirect): (WebFrame::dispatchDidChangeLocationWithinPage): (WebFrame::dispatchWillClose): (WebFrame::dispatchDidStartProvisionalLoad): (WebFrame::dispatchDidReceiveTitle): (WebFrame::dispatchDidCommitLoad): (WebFrame::dispatchDidFinishLoad): (WebFrame::updateGlobalHistoryForStandardLoad): (WebFrame::updateGlobalHistoryForReload): (WebFrame::dispatchDecidePolicyForMIMEType): (WebFrame::dispatchDecidePolicyForNewWindowAction): (WebFrame::dispatchDecidePolicyForNavigationAction): (WebFrame::dispatchDidFailProvisionalLoad): (WebFrame::dispatchDidFailLoad):
- WebKit.vcproj/WebKit.vcproj:
- WebMutableURLRequest.cpp: (WebMutableURLRequest::resourceRequest):
- WebMutableURLRequest.h:
- 11:59 AM Changeset in webkit [22746] by
-
- 2 edits in branches/WindowsMerge/WebCore
Build fix.
- platform/win/TemporaryLinkStubs.cpp: (ResourceHandle::setDefersLoading):
- 11:39 AM Changeset in webkit [18743] by
-
- 9 edits1 delete in trunk/WebCore
Rubber-stamped by Maciej.
Move most of ResourceLoader and MainResourceLoader into the platform-independent files.
- WebCore.xcodeproj/project.pbxproj:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::didFinishLoad):
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::MainResourceLoader): (WebCore::MainResourceLoader::~MainResourceLoader): (WebCore::MainResourceLoader::create): (WebCore::MainResourceLoader::receivedError): (WebCore::MainResourceLoader::didCancel): (WebCore::MainResourceLoader::interruptionForPolicyChangeError): (WebCore::MainResourceLoader::stopLoadingForPolicyChange): (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy): (WebCore::MainResourceLoader::continueAfterNavigationPolicy): (WebCore::MainResourceLoader::isPostOrRedirectAfterPost): (WebCore::MainResourceLoader::addData): (WebCore::MainResourceLoader::willSendRequest): (WebCore::shouldLoadAsEmptyDocument): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::callContinueAfterContentPolicy): (WebCore::MainResourceLoader::didReceiveResponse): (WebCore::MainResourceLoader::didReceiveData): (WebCore::MainResourceLoader::didFinishLoading): (WebCore::MainResourceLoader::didFail): (WebCore::MainResourceLoader::loadNow): (WebCore::MainResourceLoader::load): (WebCore::MainResourceLoader::setDefersLoading):
- loader/MainResourceLoader.h:
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::releaseResources): (WebCore::ResourceLoader::load): (WebCore::ResourceLoader::setDefersLoading): (WebCore::ResourceLoader::frameLoader): (WebCore::ResourceLoader::addData): (WebCore::ResourceLoader::clearResourceData): (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didReceiveResponse): (WebCore::ResourceLoader::didReceiveData): (WebCore::ResourceLoader::willStopBufferingData): (WebCore::ResourceLoader::didFinishLoading): (WebCore::ResourceLoader::didFinishLoadingOnePart): (WebCore::ResourceLoader::didFail): (WebCore::ResourceLoader::didCancel): (WebCore::ResourceLoader::cancel): (WebCore::ResourceLoader::response): (WebCore::ResourceLoader::cancelledError):
- loader/ResourceLoader.h: (WebCore::ResourceLoader::willStopBufferingData): (WebCore::ResourceLoader::setRequest):
- loader/mac/FrameLoaderMac.mm:
- loader/mac/MainResourceLoaderMac.mm: Removed.
- loader/mac/ResourceLoaderMac.mm:
- 10:46 AM Changeset in webkit [18742] by
-
- 2 edits5 adds5 deletes in trunk/WebCore
Move files to the correct location, and remove a few
unused methods from LoaderFunctionsQt.cpp
- 10:45 AM Changeset in webkit [22745] by
-
- 5 edits in branches/WindowsMerge/WebKitWin
Reviewed by Brady.
Make WebBackForwardList wrap a WebCore::BackForwardList. Add wrapper map to WebHistoryItem.
- WebBackForwardList.cpp: (backForwardListWrappers): (WebBackForwardList::WebBackForwardList): (WebBackForwardList::~WebBackForwardList): (WebBackForwardList::createInstance): (WebBackForwardList::addItem): (WebBackForwardList::goBack): (WebBackForwardList::goForward): (WebBackForwardList::goToItem): (WebBackForwardList::backItem): (WebBackForwardList::currentItem): (WebBackForwardList::forwardItem): (WebBackForwardList::backListWithLimit): (WebBackForwardList::forwardListWithLimit): (WebBackForwardList::capacity): (WebBackForwardList::setCapacity): (WebBackForwardList::backListCount): (WebBackForwardList::forwardListCount): (WebBackForwardList::containsItem): (WebBackForwardList::itemAtIndex): (WebBackForwardList::setPageCacheSize): (WebBackForwardList::pageCacheSize): (WebBackForwardList::setDefaultPageCacheSizeIfNecessary):
- WebBackForwardList.h:
- WebHistoryItem.cpp: (historyItemWrappers): (WebHistoryItem::WebHistoryItem): (WebHistoryItem::~WebHistoryItem): (WebHistoryItem::createInstance): (WebHistoryItem::initFromDictionaryRepresentation): (WebHistoryItem::QueryInterface): (WebHistoryItem::initWithURLString): (WebHistoryItem::historyItem):
- WebHistoryItem.h:
- 9:20 AM Changeset in webkit [18741] by
-
- 1 edit in trunk/WebCore/ChangeLog
Corrected Radar reference.
- 9:15 AM Changeset in webkit [18740] by
-
- 2 edits in trunk/WebCore
Reviewed by Geoff.
Fix: <rdar://problem/4903003> ContextMenuController leaks Events
No layout tests possible.
- page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Use RefPtr to manage the lifetime of Shared objects.
- 6:11 AM Changeset in webkit [18739] by
-
- 3 edits in trunk/WebCore
Reviewed by Sam.
http://bugs.webkit.org/show_bug.cgi?id=12196
SVGPatternElement should not be locatable
Replace SVGStyledLocatableElement derivation with
SVGStyledElement.
- 4:14 AM Changeset in webkit [18738] by
-
- 2 edits in trunk/WebCore
Build fix, not reviewed.
Use correct method name in the ASSERT in RenderSVGText.
- 3:40 AM Changeset in webkit [18737] by
-
- 102 edits in trunk
Reviewed by Eric.
Large SVG dynamic update rework/optimization.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=10262 (SVG fails to redraw top 20 pixels)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=10263 (SVG seems to repaint way too many times during load)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=10404 (Invalidation issues with text skew)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=10407 (bad SVG text invalidation issues on mouseover/mouseout)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=10806 (failing manual-tests/svg-repaint-group.svg)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=10913 (SVG charts from plotkit fail to render unless you scroll them offscreen)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=10964 (inclusion of svg into svg leave a ghost invisible rectangle)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11680 (DojoKit SVG test chart fails to render (clipping issue?))
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11883 (SVG Text has updating/repainting issues)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11907 (RenderSVGContainer does not mark itself for repaint after setting viewBox, slice or align)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11913 (Invalidation issues in SVG javascript-based animation example)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11979 (SVG text does not respect font-size scaling in bbox calculation)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11984 (SVG <text> does not calculate the correct absoluteRepaintRect)
Partly fixes: http://bugs.webkit.org/show_bug.cgi?id=10745 (SVG layout needs to move out of DOM and into rendering tree during layout() call)
Fixes text redrawing issues seen in svg/carto.net (when actually playing with those files, manually)
Fixes svg/carto.net/window.svg (moving "Navigation Window" caused artefacts)
Fixes svg/W3C-SVG-1.1/types-basicDOM-01-b.svg (bbox calculations had one pixel offset)
- 1:57 AM Changeset in webkit [18736] by
-
- 2 edits in trunk/JavaScriptCore
Use the new functionality in Qt 4.3, to make
the methods closer compliant with the Unicode
spec.
Keep the old code so that it still compiles against
Qt 4.2.
- 12:59 AM Changeset in webkit [18735] by
-
- 2 edits in trunk/WebCore
Make the selectionRect() method of RenderText better by reusing computeAbsoluteRepaintRect. This enables
the method to be multi-column aware and also to understand when the selection is clipped out by overflow.
Reviewed by bdash
- rendering/RenderText.cpp: (WebCore::RenderText::selectionRect):
- 12:09 AM Changeset in webkit [18734] by
-
- 5 edits in trunk/WebCore
Make the absolutePosition method multi-column aware. Note that there is now a real problem with the
absoluteRects method, since an object can split across multiple columns and break into multiple rects.
absolutePosition just returns the top-left corner of the element's box in the first column in which it
appears.
Reviewed by bdash
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::adjustRectForColumns):
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp: (WebCore::RenderBox::absolutePosition): (WebCore::RenderBox::computeAbsoluteRepaintRect):
- rendering/RenderFlow.cpp: (WebCore::RenderFlow::getAbsoluteRepaintRect):
Jan 9, 2007:
- 11:47 PM Changeset in webkit [22744] by
-
- 8 edits1 add in branches/WindowsMerge/WebKitWin
2007-01-09 Ada Chan <adachan@apple.com>
Reviewed by Steve.
<rdar://4602355> Undo/Redo
WebKitWin changes:
- Added new undo methods in the IWebUIDelegate.
- Removed the internal WebUndoManager in WebEditorClient. Instead, we'll call methods on the ui delegate to register undo operations, execute undo/redo, etc.
- 11:39 PM Changeset in webkit [18733] by
-
- 2 edits in trunk/WebCore
Avoid crashing when repainting multiple columns... make sure to use the current vector's size and
not the newly-computed column count.
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutColumns): (WebCore::RenderBlock::adjustRepaintRectForColumns):
- 11:24 PM Changeset in webkit [18732] by
-
- 5 edits in trunk/WebCore
Break up painting and hit testing of children into helper methods and add multi-column versions for both.
Make incremental repainting able to invalidate the right spot in multiple column layouts so that e.g., link
hover works.
Turn off selection gap filling in columns for now until it can be made to work correctly.
Improve the column balancing heuristic by adding in the block's lineHeight/2 to each column initially to
account for column break adjustments that shrink the columns slightly. Avoid clipping of the last column's
contents by ensuring it gets all the remaining available height.
Reviewed by mitz
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintColumns): (WebCore::RenderBlock::paintContents): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::fillSelectionGaps): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestColumns): (WebCore::RenderBlock::layoutColumns): (WebCore::RenderBlock::adjustRepaintRectForColumns):
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp: (WebCore::RenderBox::computeAbsoluteRepaintRect):
- rendering/RenderFlow.cpp: (WebCore::RenderFlow::getAbsoluteRepaintRect):
- 8:42 PM Changeset in webkit [18731] by
-
- 2 edits in trunk/WebCore
WebCore:
Reviewed by Darin and Eric.
Don't use memset to set float to 0
- platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp: (WebCore::cgGradientCallback):
- 7:45 PM Changeset in webkit [22743] by
-
- 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION
Bump version for submit
- 7:36 PM Changeset in webkit [18730] by
-
- 1 copy in tags/Safari-521.32.10b
New tag.
- 5:21 PM Changeset in webkit [22742] by
-
- 6 edits1 add in branches/WindowsMerge/WebKitWin
Reviewed by Darin.
Add COMPtr. Make MemoryStream backed by a SharedBuffer. Use SharedBuffer in
WebFrame.
- COMPtr.h: Added. (COMPtr::COMPtr): (COMPtr::~COMPtr): (COMPtr::get): (COMPtr::operator*): (COMPtr::operator->): (COMPtr::operator&): (COMPtr::operator!): (COMPtr::operator UnspecifiedBoolType): (::copyTo): (::adopt): (::operator):
- MemoryStream.cpp: (MemoryStream::MemoryStream): (MemoryStream::~MemoryStream): (MemoryStream::createInstance): (MemoryStream::Clone):
- MemoryStream.h:
- WebFrame.cpp: (WebFrame::WebFrame): (WebFrame::didReceiveResponse): (WebFrame::didReceiveData):
- WebFrame.h: (WebFrame::data):
- WebKit.vcproj/WebKit.vcproj:
- 5:19 PM Changeset in webkit [22741] by
-
- 2 edits in branches/WindowsMerge/WebCore
2007-01-09 Steve Falkenburg <sfalken@apple.com>
B&I build fix
- WebCore.vcproj/WebCore.vcproj:
- 5:09 PM Changeset in webkit [18729] by
-
- 30 edits4 adds in trunk/LayoutTests/fast/overflow
Update overflow tests. Add new overflow test.
- 4:54 PM Changeset in webkit [18728] by
-
- 3 edits in trunk/WebCore
Reviewed by Brady.
Add default constructor to SharedBuffer.
- platform/SharedBuffer.cpp: (WebCore::SharedBuffer::SharedBuffer):
- platform/SharedBuffer.h:
- 4:52 PM Changeset in webkit [18727] by
-
- 11 edits in trunk/WebCore
This patch gets rudimentary column layout working. Normal flow content only gets laid out into
columns properly and painted correctly initially. What doesn't work: hit testing, incremental repainting,
column rule painting, child layers.
Some work needs to be done on the render tree dumper before column tests will be
meaningful.
Also reworked overflow and fixed a bunch of bugs with the computation of overflow. These include an error
in the height calculations caused by not adding in the horizontal scrollbar height and other errors caused
by not checking overflow in lowest/rightmostPosition. Existing tests improve their rendering to match
Firefox with this change.
Fixed a bug where a table cell incorrectly expanded to encompass floats inside an overflow:auto block.
This should not have happened. Covered by new test fast/overflow/table-overflow-float.html.
Reviewed by mitz
- page/Frame.cpp:
- rendering/RenderBlock.cpp: (WebCore:::RenderFlow): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::paintContents): (WebCore::RenderBlock::paintChildren): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition): (WebCore::RenderBlock::avoidsFloats): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestContents): (WebCore::RenderBlock::layoutColumns):
- rendering/RenderBlock.h: (WebCore::RenderBlock::hasOverhangingFloats): (WebCore::RenderBlock::hasColumns):
- rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): (WebCore::RenderFlexibleBox::layoutHorizontalBox): (WebCore::RenderFlexibleBox::layoutVerticalBox):
- rendering/RenderFlow.cpp: (WebCore::RenderFlow::paintLines): (WebCore::RenderFlow::lowestPosition): (WebCore::RenderFlow::rightmostPosition): (WebCore::RenderFlow::leftmostPosition):
- rendering/RenderFlow.h: (WebCore::RenderFlow::hasColumns):
- rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
- rendering/RenderObject.h: (WebCore::RenderObject::expandsToEncloseOverflow):
- rendering/RenderTableCell.h: (WebCore::RenderTableCell::expandsToEncloseOverflow):
- rendering/RenderView.cpp: (WebCore::RenderView::paint):
- 4:23 PM Changeset in webkit [18726] by
-
- 1 edit in trunk/LayoutTests/editing/pasteboard/4840662.html
Removed some extraneous text from this layout test. It passes now.
- 4:21 PM Changeset in webkit [22740] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
2007-01-09 Steve Falkenburg <sfalken@apple.com>
Reviewed by Lou.
<rdar://4906546> Win2K: crash when entering new URL in address field
Win2K compatibility fix. SafeArrayCreateVector doesn't work correctly on older systems (Win2K, etc.)
Some references to people stumbling across this bug (apologies for not being able to find a Microsoft support article):
http://discuss.develop.com/archives/wa.exe?A2=ind0104a&L=dotnet&D=0&T=0&P=69575
http://www.eggheadcafe.com/ng/microsoft.public.platformsdk.com_ole/Jul2005/post22989606.asp
http://www.pcreview.co.uk/forums/thread-1470025.php
- MarshallingHelpers.cpp: (MarshallingHelpers::stringArrayToSafeArray): (MarshallingHelpers::intArrayToSafeArray): (MarshallingHelpers::intRectToSafeArray): (MarshallingHelpers::iunknownArrayToSafeArray):
- 4:11 PM Changeset in webkit [18725] by
-
- 3 edits17 moves in trunk/WebKit
Reviewed by Darin.
Rename the now ObjC++ files to be .mm and remove the explicit file types.
- DOM/WebDOMOperations.m: Removed.
- DefaultDelegates/WebDefaultContextMenuDelegate.m: Removed.
- English.lproj/StringsNotToBeLocalized.txt:
- Misc/WebCoreStatistics.m: Removed.
- Misc/WebElementDictionary.m: Removed.
- Misc/WebIconDatabase.m: Removed.
- Misc/WebNSAttributedStringExtras.m: Removed.
- Misc/WebNSPasteboardExtras.m: Removed.
- Plugins/WebNetscapePluginEmbeddedView.m: Removed.
- Plugins/WebNullPluginView.m: Removed.
- Plugins/WebPluginContainerCheck.m: Removed.
- WebCoreSupport/WebViewFactory.m: Removed.
- WebKit.xcodeproj/project.pbxproj:
- WebView/WebArchiver.m: Removed.
- WebView/WebHTMLRepresentation.m: Removed.
- WebView/WebHTMLView.m: Removed.
- WebView/WebRenderNode.m: Removed.
- WebView/WebResource.m: Removed.
- WebView/WebScriptDebugDelegate.m: Removed.
- 4:08 PM Changeset in webkit [18724] by
-
- 30 edits in trunk
- update 2007 Apple copyright for the new company name
- kjs/DateMath.cpp:
WebCore:
- update all 2007 Apple copyrights for the new company name
- css/cssstyleselector.cpp:
- html/HTMLLIElement.cpp:
- platform/CharacterNames.h:
- platform/TextBreakIterator.h:
- platform/TextBreakIteratorICU.cpp:
- platform/graphics/ImageBuffer.h:
- rendering/CounterNode.cpp:
- rendering/CounterNode.h:
- rendering/RenderBox.h:
- rendering/RenderContainer.cpp:
- rendering/RenderCounter.cpp:
- rendering/RenderCounter.h:
- rendering/RenderImage.h:
- rendering/RenderListItem.h:
- rendering/RenderListMarker.h:
- rendering/RenderObject.cpp:
- rendering/RenderObject.h:
- rendering/RenderStyle.cpp:
- rendering/RenderStyle.h:
- rendering/RenderTable.cpp:
- rendering/RenderTableCell.cpp:
- rendering/RenderTableCell.h:
- rendering/RenderText.cpp:
- rendering/RenderText.h:
- rendering/RenderTreeAsText.cpp:
- rendering/SVGRenderTreeAsText.cpp:
- rendering/break_lines.cpp:
- 2:49 PM Changeset in webkit [18723] by
-
- 3 edits8 adds in trunk
LayoutTests:
Reviewed by john
- editing/inserting/4840662-expected.checksum: Added.
- editing/inserting/4840662-expected.png: Added.
- editing/inserting/4840662-expected.txt: Added.
- editing/inserting/4840662.html: Added.
- editing/pasteboard/4840662-expected.checksum: Added.
- editing/pasteboard/4840662-expected.png: Added.
- editing/pasteboard/4840662-expected.txt: Added.
- editing/pasteboard/4840662.html: Added.
WebCore:
Reviewed by john
<rdar://problem/4840662>
REGRESSION: Mail crash when dragging text into a link
moveParagraphs fails to move content into a display:block
anchor because of code in positionAvoidingSpecialElementBoundary,
and so it infinitely recurs.
- editing/htmlediting.cpp: (WebCore::positionAvoidingSpecialElementBoundary): Don't avoid anchors that have display:block so that content is inserted in the expected paragraph. This fixes the bug and weird behavior when typing before/after anchors with display:block.
- 2:29 PM Changeset in webkit [18722] by
-
- 4 edits8 adds in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=12145
Color parsing is too relaxed in strict mode
http://bugs.webkit.org/show_bug.cgi?id=12166
REGRESSION (r18480): "336633" is not parsed as a color
Fix a regression by using String::format return value.
Also make strict mode more strict for cases where hexcolors
lack a #.
- 1:48 PM Changeset in webkit [18721] by
-
- 2 edits in trunk/WebCore
Reviewed by Maciej.
- fixed regression where redirects did not have user-agent any more
Showed up as a failure in one of the http tests, so no new test needed.
- loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willSendRequest): Don't use a copy of the ResourceRequest; pass the original so it can be modified.
- 1:39 PM Changeset in webkit [22739] by
-
- 2 edits in branches/WindowsMerge/WebCore
Build fix.
- platform/win/TextBoundariesWin.cpp:
- 1:36 PM Changeset in webkit [18720] by
-
- 2 edits in S60/branches/3.1m/WebKit
2007-01-09 sareen <shyam.sareen@nokia.com>
Reviewed by Sachin Padma.
DESC: Switching to landscape while graphical back is open causes UI problem.
http://bugs.webkit.org/show_bug.cgi?id=12168
- BrowserView/src/WebKitView.cpp: (CWebKitView::SizeChanged):
- 1:32 PM Changeset in webkit [18719] by
-
- 2 edits in S60/trunk/WebKit
2007-01-09 sareen <shyam.sareen@nokia.com>
Reviewed by Sachin Padma.
DESC: Switching to landscape while graphical back is open causes UI problem.
http://bugs.webkit.org/show_bug.cgi?id=12168
- BrowserView/src/WebKitView.cpp: (CWebKitView::SizeChanged):
- 1:19 PM Changeset in webkit [18718] by
-
- 2 edits in trunk/JavaScriptCore
- fix build
- kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction): Actually compile it this time.
- 1:13 PM Changeset in webkit [18717] by
-
- 2 edits in trunk/JavaScriptCore
- fix build
- kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction): Change types.
- 1:11 PM Changeset in webkit [18716] by
-
- 2 edits in trunk/JavaScriptCore
- fix build on platforms where Unicode::UChar is != uint16_t
- kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction): Change types.
- 9:38 AM Changeset in webkit [18715] by
-
- 7 edits2 adds in trunk
2007-01-09 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- changes for http://bugs.webkit.org/show_bug.cgi?id=11078 Forms Don't Submit (ASP Pages)
- JavaScriptCore.exp:
- kjs/value.cpp: (KJS::JSValue::toInt32): Folded toInt32Inline into this method, which was its only caller. (KJS::JSValue::toUInt32): Added a variant that reports if the conversion has succeeded.
- kjs/value.h:
WebCore:
- bindings/js/kjs_html.cpp: (KJS::JSHTMLCollectionProtoFunc::callAsFunction): Changed item() to fall back to namedItem() if its argument does not convert to a number.
LayoutTests:
- fast/dom/collection-namedItem-via-item-expected.txt: Added.
- fast/dom/collection-namedItem-via-item.html: Added.
- 7:13 AM Changeset in webkit [18714] by
-
- 2 edits in S60/branches/3.1m/MemoryManager
2007-01-09 spadma <Sachin.Padma@nokia.com>
Reviewed by Yongjun.
DESC: Fix build break caused by removing simple notifier
http://bugzilla.opendarwin.org/show_bug.cgi?id=
- EABI/MemManU.DEF:
- 6:57 AM Changeset in webkit [18713] by
-
- 2 edits in S60/trunk/MemoryManager
2007-01-09 spadma <Sachin.Padma@nokia.com>
Reviewed by Yongjun.
DESC: Fix build break by removing SimpleNotifier.
http://bugs.webkit.org/show_bug.cgi?id=
- EABI/MemManU.DEF:
- 6:54 AM Changeset in webkit [18712] by
-
- 39 edits1 add in trunk
Reviewed by Maciej.
- fix http://bugs.webkit.org/show_bug.cgi?id=12174 improve Unicode use (less WTF::Unicode:: prefix, centralized character names)
- wtf/unicode/icu/UnicodeIcu.h: Change parameter and return types to UChar32 and UChar. Removed unneeded type casts and added some const to functions that lacked it. Removed WTF::Unicode::memcmp. (WTF::Unicode::umemcasecmp): Renamed from strcasecmp since this doesn't work on 0-terminated strings as the str functions do.
- wtf/unicode/qt4/UnicodeQt4.h: Ditto.
- got rid of namespace prefixes from most uses of WTF::Unicode
- kjs/function.cpp: (KJS::isStrWhiteSpace): (KJS::escapeStringForPrettyPrinting):
- kjs/lexer.cpp: (KJS::Lexer::isWhiteSpace): (KJS::Lexer::isIdentStart): (KJS::Lexer::isIdentPart):
- kjs/string_object.cpp: (KJS::StringProtoFunc::callAsFunction):
WebCore:
Reviewed by Maciej.
- fix http://bugs.webkit.org/show_bug.cgi?id=12174 improve Unicode use (less WTF::Unicode:: prefix, centralized character names)
- got rid of namespace prefixes from most uses of WTF::Unicode
- updated for removal of WTF::Unicode::memcmp
- updated for renaming of WTF::Unicode::strcasecmp to umemcasecmp.
- unified constants for special Unicode characters in a new CharacterNames.h header
- WebCore.xcodeproj/project.pbxproj:
- css/cssparser.cpp: (WebCore::ParseString::lower):
- dom/Document.cpp: (WebCore::isValidNameStart): (WebCore::isValidNamePart):
- dom/Position.cpp: (WebCore::Position::leadingWhitespacePosition): (WebCore::Position::trailingWhitespacePosition):
- editing/CompositeEditCommand.cpp: (WebCore::isWhitespace):
- editing/HTMLInterchange.cpp:
- editing/TextIterator.cpp: (WebCore::CircularSearchBuffer::CircularSearchBuffer): (WebCore::CircularSearchBuffer::append):
- editing/htmlediting.cpp: (WebCore::stringWithRebalancedWhitespace): (WebCore::nonBreakingSpaceString):
- editing/htmlediting.h:
- html/HTMLFontElement.cpp: (WebCore::parseFontSizeNumber):
- html/HTMLParser.cpp: (WebCore::HTMLParser::handleError):
- html/HTMLSelectElement.cpp: (WebCore::stripLeadingWhiteSpace):
- platform/Font.cpp: (WebCore::WidthIterator::advance): (WebCore::WidthIterator::normalizeVoicingMarks):
- platform/GlyphMap.cpp: (WebCore::GlyphMap::locatePage):
- platform/MimeTypeRegistry.h:
- platform/StringHash.h:
- platform/StringImpl.cpp: (WebCore::isSpace): (WebCore::StringImpl::append): (WebCore::StringImpl::insert): (WebCore::StringImpl::truncate): (WebCore::StringImpl::remove): (WebCore::parseLength): (WebCore::StringImpl::isLower): (WebCore::StringImpl::lower): (WebCore::StringImpl::upper): (WebCore::StringImpl::secure): (WebCore::StringImpl::foldCase): (WebCore::StringImpl::capitalize):t (WebCore::StringImpl::toInt): (WebCore::equalIgnoringCase): (WebCore::StringImpl::find):
- platform/TextBoundaries.h:
- platform/TextCodec.h:
- platform/TextCodecLatin1.cpp:
- platform/TextEncoding.h:
- platform/TextEncodingRegistry.h:
- platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeSelection):
- platform/mac/TextCodecMac.cpp: (WebCore::TextCodecMac::decode):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter):
- rendering/RenderListMarker.cpp: (WebCore::listMarkerText): (WebCore::RenderListMarker::paint):
- rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache): (WebCore::isSpaceAccordingToStyle): (WebCore::RenderText::setInternalString):
- rendering/RenderTreeAsText.cpp: (WebCore::quoteAndEscapeNonPrintables): (WebCore::operator<<):
- rendering/bidi.cpp: (WebCore::BidiState::BidiState): (WebCore::BidiContext::BidiContext): (WebCore::bidiNext): (WebCore::bidiFirst): (WebCore::BidiIterator::direction): (WebCore::appendRun): (WebCore::embed): (WebCore::RenderBlock::bidiReorderLine): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::skipNonBreakingSpace): (WebCore::RenderBlock::findNextLineBreak):
- rendering/break_lines.cpp: (WebCore::nextBreakablePosition):
- rendering/break_lines.h:
- xml/XPathParser.cpp: (WebCore::XPath::charCat):
- 6:43 AM Changeset in webkit [18711] by
-
- 1 edit in trunk/WebCore/ChangeLog
Another change log tweak.
- 6:42 AM Changeset in webkit [18710] by
-
- 1 edit in trunk/WebCore/ChangeLog
Add the bug number.
- 6:36 AM Changeset in webkit [18709] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
- rendering/RenderText.h: (WebCore::RenderText::selectionState): Change the m_selectionState enum-bitfield to an unsigned-bitfield, because enums on Windows are signed, which caused it to become negative (whereas the valid values are all positive).
- 6:28 AM Changeset in webkit [18708] by
-
- 5 edits in trunk/WebCore
Reviewed by Hyatt.
- http://bugs.webkit.org/show_bug.cgi?id=12175 port break_lines.cpp to be platform independent
- platform/TextBreakIterator.h: Added lineBreakIterator. Removed ICU-specific stuff from the header.
- platform/TextBreakIteratorICU.cpp: (WebCore::setUpIterator): Added helper to be shared by the three different creation functions. (WebCore::characterBreakIterator): Changed to use setUpIterator. (WebCore::wordBreakIterator): Ditto. (WebCore::lineBreakIterator): Added.
- platform/qt/TextBreakIteratorQt.cpp: (WebCore::lineBreakIterator): Added a stub.
- rendering/break_lines.cpp: (WebCore::isBreakableSpace): Added. (WebCore::shouldBreakAfter): Added. (WebCore::needsAdvancedBreakAnalysis): Added. (WebCore::nextBreakablePosition): Changed to use TextBreakIterator on platforms other than Mac.
- 6:19 AM Changeset in webkit [18707] by
-
- 1 edit4 adds in trunk/LayoutTests
Reviewed by Mitz.
- added a Thai line breaking test
- fast/text/international/thai-line-breaks-expected.checksum: Added.
- fast/text/international/thai-line-breaks-expected.png: Added.
- fast/text/international/thai-line-breaks-expected.txt: Added.
- fast/text/international/thai-line-breaks.html: Added.
- 6:15 AM Changeset in webkit [18706] by
-
- 4 edits in trunk/WebCore
Reviewed by Darin.
- move WebDataProtocol load handling from ResourceLoader to MainResourceLoader
(it's only ever used for main resources)
- loader/ResourceLoader.h: (WebCore::ResourceLoader::setRequest):
- loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::willSendRequest): (WebCore::MainResourceLoader::continueAfterContentPolicy):
- loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didReceiveResponse):
- 5:56 AM Changeset in webkit [18705] by
-
- 4 edits4 adds in trunk
Reviewed by Eric.
http://bugs.webkit.org/show_bug.cgi?id=12129
repaint issue after setting viewBox attribute with ECMAScript
Make sure RenderSVGContainer updates after setting viewBox from js.
- 5:50 AM Changeset in webkit [18704] by
-
- 5 edits in trunk/WebKit
Reviewed by Darin.
- remove window display throttling code; no longer used
- Misc/WebNSWindowExtras.h:
- Misc/WebNSWindowExtras.m:
- WebView/WebFrameView.mm: (-[WebFrameView initWithFrame:]):
- WebView/WebPreferenceKeysPrivate.h:
- 12:20 AM Changeset in webkit [18703] by
-
- 6 edits in trunk/WebCore
Make the Qt build compile... again!
- 12:15 AM Changeset in webkit [18702] by
-
- 2 edits in trunk/WebCore
Fix for background: inherit bug where background-color wasn't getting properly overridden. This was a
regression from Safari 1.3 to 2.0.
Reviewed by bdash
fast/backgrounds/background-color-inherit-bug.html
- css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
- 12:14 AM Changeset in webkit [18701] by
-
- 4 adds in trunk/LayoutTests/fast/backgrounds
Add new layout test for background inherit color bug.
