Timeline



Feb 13, 2007:

10:31 PM Changeset in webkit [22940] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-02-13 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.


Send tab keypresses to IWebFormDelegate::doCommandBySelector.

  • WebEditorClient.cpp: (WebEditorClient::handleKeyPress): Call doTextFieldCommandFromEvent if we get a tab keypress
9:23 PM Changeset in webkit [19619] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=12763
REGRESSION: button title is displayed incorrectly at quotes.burntelectrons.org

Test: fast/parser/entities-in-attributes.xhtml

  • dom/XMLTokenizer.cpp: (WebCore::getEntityHandler): Set a correct type for the found entity (I'm not really sure if XML_INTERNAL_GENERAL_ENTITY is _the_ correct one, but it fixes the problem).
8:10 PM Changeset in webkit [22939] by beidson
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam

Switch permanently from CFStreamError to CFErrorRef in ResourceHandleCF

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didFail): (WebCore::ResourceHandle::start):
7:11 PM Changeset in webkit [19618] by weinig
  • 2 edits in trunk/LayoutTests

Reviewed by Mark.

  • fast/dom/Window/window-properties-expected.txt: Update results.
6:05 PM Changeset in webkit [19617] by darin
  • 10 edits in trunk/WebCore

Reviewed by Hyatt.

  • removed some bogus names (Hyatt smacked me since this doesn't fix a P1)
  • dom/EventNames.h: Removed half-implemented khtmlDragdrop and khtmlMove (you could add listeners, but nobody ever sent the events). Renamed the other two khtml-prefixed internal event names to use the webkit prefix.
  • bindings/js/kjs_dom.cpp: (KJS::DOMEventTargetNode::getValueProperty): Removed ondragdrop and onmove. (KJS::DOMEventTargetNode::putValueProperty): Ditto.
  • bindings/js/kjs_dom.h:
  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty): Ditto. (KJS::Window::put): Ditto.
  • bindings/js/kjs_window.h:
  • dom/BeforeTextInsertedEvent.cpp: (WebCore::BeforeTextInsertedEvent::BeforeTextInsertedEvent): Renamed to webkit.
  • editing/Editor.cpp: (WebCore::dispatchEditableContentChangedEvents): Ditto.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): Ditto.
  • html/HTMLTextFieldInnerElement.cpp: (WebCore::HTMLTextFieldInnerTextElement::defaultEventHandler): Ditto.
5:39 PM Changeset in webkit [19616] by darin
  • 2 edits in trunk/WebCore

Rubber stamped by Maciej.

  • dom/EventNames.h: Resort names. Removed unused names.
5:24 PM Changeset in webkit [22938] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

5:23 PM Changeset in webkit [19615] by sfalken
  • 1 copy in tags/Safari-521.34.4b

New tag.

2:57 PM Changeset in webkit [19614] by oliver
  • 2 edits in trunk/WebKit

2007-02-13 Oliver Hunt <​oliver@apple.com>

Reviewed by John.

Modify entry point ASSERTs for dragging functions to allow for the case
where a load has occurred mid-drag. The load may detach the HTMLView
from the WebView so it is no longer possible to check _isTopHTMLView.

The assertion changes match that of revision 14897 which fixed the
more common case ([WebHTMLView draggedImage:endedAt:operation:])

It's also necessary to check for a null Page now prior to accessing
the DragController, which is necessary in all of these methods.

See rdar://problem/4994870


  • WebView/WebHTMLView.mm: (-[WebHTMLView draggingSourceOperationMaskForLocal:]): (-[WebHTMLView draggedImage:movedTo:]): (-[WebHTMLView draggedImage:endedAt:operation:]): (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
2:44 PM Changeset in webkit [22937] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • WebCore.vcproj/WebCore.vcproj: Remove SVGDOMImplementation.(cpp|h)
2:19 PM Changeset in webkit [19613] by beidson
  • 2 edits in trunk/JavaScriptCore

Tweaked Vector a bit

1:47 PM Changeset in webkit [19612] by andersca
  • 3 edits
    3 adds in trunk

LayoutTests:

Reviewed by Kevin Decker.

<rdar://problem/4990049>
​http://bugs.webkit.org/show_bug.cgi?id=12718
REGRESSION: Segmentation fault when loading abc.go.com (12718)

  • http/tests/misc/redirect-to-about-blank-expected.txt: Added.
  • http/tests/misc/redirect-to-about-blank.html: Added.
  • http/tests/misc/resources/redirect-to-about-blank.php: Added.

WebCore:

Reviewed by Kevin Decker.

<rdar://problem/4990049>
​http://bugs.webkit.org/show_bug.cgi?id=12718
REGRESSION: Segmentation fault when loading abc.go.com (12718)

The problem is that redirecting to about:blank causes the delegate to be released even though the load wasn't finished.
This is usally not a problem since NSURLConnection retains its delegate. However, the proxy delegate does not retain _it's_
delegate. The solution is to make releaseDelegate clear out the proxy delegate's delegate.


  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::releaseDelegate): If there's a proxy, nil out its delegate too.
1:28 PM Changeset in webkit [19611] by brmorris
  • 5 edits in S60/branches/3.1m/WebCore

bujtas, reviewed by yongjun

DESC: merging trunk r16319 to s60/3.1m PKAI-6Y2PBN
Fix fieldsets so that they properly expand to enclose overhanging floats
when the fieldset has auto height. This is a nifty undocumented behavior
of the fieldset element. ​http://bugs.webkit.org/show_bug.cgi?id=3898

​http://bugs.webkit.org/show_bug.cgi?id=12748

1:11 PM Changeset in webkit [19610] by ap
  • 1 edit in trunk/LayoutTests/ChangeLog

Correcting ChangeLog entry (thx Mitz!).

1:06 PM Changeset in webkit [19609] by ap
  • 1 edit
    4 deletes in trunk/LayoutTests

Actually removed pixel results that were supposed to be removed three
weeks ago, in r12290.

  • fast/parser/entity-surrogate-pairs-expected.checksum: Removed.
  • fast/parser/entity-surrogate-pairs-expected.png: Removed.
  • fast/parser/head-comment-expected.checksum: Removed.
  • fast/parser/head-comment-expected.png: Removed.
11:31 AM Changeset in webkit [19608] by ap
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12643
NPN_Status is using latin-1 encoding for the message instead of UTF-8

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView status:]): Use kCFStringEncodingUTF8.
11:23 AM Changeset in webkit [19607] by beidson
  • 1 edit
    5 adds in trunk/LayoutTests

Reviewed by The Spirit of Layout Test Fixing!

Re-added a directory and some files Darin removed that one of my layout tests
relied on.

  • http/tests/security/resources/green250x50.png: Added.
  • http/tests/security/resources/red200x100.png: Added.
  • http/tests/security/resources/showRefererImage.php: Added.
10:32 AM Changeset in webkit [19606] by darin
  • 4 edits in trunk

JavaScriptCore:

Reviewed by Darin.

  • wtf/Vector.h: fixed comparison operators (WTF::operator==): (WTF::operator!=):

WebCore:

Reviewed by Darin.

  • rendering/RenderStyle.h: Added a != operator for StyleDashboardRegion. The only reason this compiled before was that the comparing two vectors with a != was simply comparing the pointers.
10:16 AM Changeset in webkit [19605] by darin
  • 519 edits
    1 delete in trunk/LayoutTests
  • update test results for Hyatt's focus node enhancement (fix for 12149) 518 of tests had extra "begin editing" delegate callbacks.
  • editing: Updated test results of many tests in this directory.
  • removed tests for rolled-out fix for rdar://problem/4922454
  • http/tests/security/local-JavaScript-from-remote-expected.txt: Removed.
  • http/tests/security/local-JavaScript-from-remote.html: Removed.
  • http/tests/security/local-iFrame-from-remote-expected.txt: Removed.
  • http/tests/security/local-iFrame-from-remote.html: Removed.
  • http/tests/security/local-image-from-remote-expected.txt: Removed.
  • http/tests/security/local-image-from-remote.html: Removed.
  • http/tests/security/resources/compass.jpg: Removed.
  • http/tests/security/resources/green250x50.png: Removed.
  • http/tests/security/resources/localPage.html: Removed.
  • http/tests/security/resources/localScript.js: Removed.
  • http/tests/security/resources/red200x100.png: Removed.
  • http/tests/security/resources/showRefererImage.php: Removed.
10:11 AM Changeset in webkit [19604] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Fix wording of a change log comment.

9:58 AM Changeset in webkit [19603] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/run-webkit-tests: Fix a bug where --reset-results output would all go in one giant line.
9:52 AM Changeset in webkit [19602] by darin
  • 2 edits in trunk/WebCore
  • roll out fix for <rdar://problem/4874059> REGRESSION: Painter IX:register -
Crash in WebCore
ResourceLoader::willSendRequest()

This fix was causing a crash in at least one layout test.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopAllLoaders): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
5:09 AM Changeset in webkit [19601] by mjs
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/lists/item-not-in-list-line-wrapping-expected.checksum: Added.
  • fast/lists/item-not-in-list-line-wrapping-expected.png: Added.
  • fast/lists/item-not-in-list-line-wrapping-expected.txt: Added.
  • fast/lists/item-not-in-list-line-wrapping.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/lists/item-not-in-list-line-wrapping.html

  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Use the list marker's isInside() instead of looking at its style()->listStylePosition(), since if the list item is not in a list, the marker is inside regardless of the style.
3:02 AM Changeset in webkit [19600] by rwlbuis
  • 13 edits in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12578
WebKit incorrectly strokes zero-width/height rectangles

Create an empty path when encountering zero-width/height rectangles, similar to circles with zero radius.

2:05 AM Changeset in webkit [19599] by rwlbuis
  • 3 edits
    2 deletes in trunk/WebCore

Reviewed by Maciej.

Remove SVGDOMImplementation from the project.

1:52 AM Changeset in webkit [19598] by mjs
  • 2 edits in trunk/LayoutTests

Reviewed by Maciej.


  • fixed to still be a valid test (wouldn't crash without the relevant fix).
  • fast/text/text-shadow-extreme-value.html:
12:59 AM Changeset in webkit [19597] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Maciej and Adam

Fixes <rdar://problem/4985497> - Crash when opening a new window to "Same Page"

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadItem): Null check documentLoader() since if we're a brand new WebView, cloning the history of another view, we have no documentLoader()
12:55 AM Changeset in webkit [19596] by antti
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

-fix REGRESSION: <select disabled size="5"> listbox cannot be scrolled
​http://bugs.webkit.org/show_bug.cgi?id=11852
<rdar://problem/4960129>


Pass mouse press events to scrollbars even if event is swallowed.


No layout test, DumpRenderTree eventSender can't hit scrollbars.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent):

Feb 12, 2007:

8:49 PM Changeset in webkit [19595] by hyatt
  • 7 edits in trunk/WebCore

Fix for bug 12149 (Radar Bug#4928692), external CSS causes incomplete
text field focus.

Make sure to clear out the focus node in willRemove() rather than in
detach(), since detach/attach caused by style recalc should not affect
the focused node.

Reviewed by aroben

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::willRemove):
  • dom/Document.cpp: (WebCore::Document::focusedNodeRemoved): (WebCore::Document::setFocusedNode):
  • dom/Document.h:
  • dom/Element.cpp: (WebCore::Element::updateFocusAppearance):
  • dom/Node.cpp: (WebCore::Node::willRemove): (WebCore::Node::detach):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::updateFocusAppearance):
8:46 PM Changeset in webkit [19594] by bdash
  • 2 edits in trunk/WebKit

2007-02-13 Mark Rowe <​mrowe@apple.com>

Reviewed by Timothy Hatcher.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=12745
Bug 12745: REGRESSION: Webkit will not load a plugin that Safari can load (symbol missing _objc_msgSend_fpret)

Treat libobjc as a sub-library of WebKit in Debug/Release so that plugins and applications linked against an
umbrella framework version of WebKit that expect to find libobjc symbols in WebKit can do so.

  • WebKit.xcodeproj/project.pbxproj:
5:41 PM Changeset in webkit [19593] by bdash
  • 118 edits
    8 deletes in trunk

Rolling out r19588 as it caused a build failure and a hang in layout tests after the obvious build fix was applied.

5:37 PM Changeset in webkit [19592] by bdash
  • 1 edit in tags/Safari-521.34.1/WebKit/Info.plist

Versioning.

5:35 PM Changeset in webkit [19591] by bdash
  • 2 edits in tags/Safari-521.34.1/WebKit

Merge in r19484.

5:35 PM Changeset in webkit [19590] by kmccullo
  • 21 edits
    6 deletes in trunk

LayoutTests:

Reviewed by .

  • reverting change to not cause regressions and performance problems.
  • fast/loader/local-JavaScript-from-local-expected.txt: Removed.
  • fast/loader/local-JavaScript-from-local.html: Removed.
  • fast/loader/local-iFrame-source-from-local-expected.txt: Removed.
  • fast/loader/local-iFrame-source-from-local.html: Removed.
  • fast/loader/local-image-from-local-expected.txt: Removed.
  • fast/loader/local-image-from-local.html: Removed.

WebCore:

Reviewed by .

  • reverting change to not cause regressions and performance problems.
  • bindings/objc/DOM.mm: (-[DOMElement image]): (-[DOMElement _imageTIFFRepresentation]):
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::notifyFinished):
  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::dispatchLoadEvent):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::reset): (WebCore::HTMLTokenizer::notifyFinished):
  • ksvg2/misc/SVGImageLoader.cpp: (WebCore::SVGImageLoader::dispatchLoadEvent):
  • loader/Cache.cpp: (WebCore::Cache::requestResource): (WebCore::Cache::remove):
  • loader/CachedImage.h: (WebCore::CachedImage::canRender): (WebCore::CachedImage::isErrorImage):
  • loader/CachedResource.h:
  • loader/CachedScript.h: (WebCore::CachedScript::errorOccurred):
  • loader/DocLoader.cpp: (WebCore::DocLoader::requestResource): (WebCore::DocLoader::setLoadInProgress):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::canLoad):
  • page/EventHandler.cpp: (WebCore::selectCursor):
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::image):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::setCachedImage): (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::paint): (WebCore::RenderImage::layout): (WebCore::RenderImage::calcAspectRatioWidth): (WebCore::RenderImage::calcAspectRatioHeight):
  • rendering/RenderImage.h: (WebCore::RenderImage::isErrorImage):
  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::setStyle):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::isImage):

WebKit:

Reviewed by .

  • reverting change to not cause regressions and performance problems.
  • Misc/WebNSAttributedStringExtras.mm: (fileWrapperForElement):
5:23 PM Changeset in webkit [19589] by bdash
  • 1 copy in tags/Safari-521.34.1

New tag.

3:57 PM Changeset in webkit [22936] by adachan
  • 12 edits in branches/WindowsMerge

2007-02-12 Ada Chan <​adachan@apple.com>

WebCoreWin:

Reviewed by Steve.

<rdar://4952715> Events not being passed from WebCore/WebKit up through IWebForm::doCommandBySelector
Frame::doTextFieldCommandFromEvent()'s signature has changed from taking in a PlatformKeyboardEvent
to KeyboardEvent. Match that in FrameWin.

  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::doTextFieldCommandFromEvent):
  • bridge/win/FrameWin.h:


WebKitWin:

Reviewed by Steve.


Also, checked in a fix in WebContextMenuClient that Adam made on my machine, reviewed by me.

<rdar://4952715> Events not being passed from WebCore/WebKit up through IWebForm::doCommandBySelector
Inform form delegate about delete key press.


DOM event fixes:

  • Removed DOMEventTarget class.
  • IDOMEventTarget no longer extends IDOMObject
  • DOMNode now implements IDOMEventTarget
  • DOMEvent::CoCreateInstance creates the correct subclasses of DOMEvents based on the type of event
  • Added IDOMDocumentEvent interface, which DOMDocument implements.
  • Fixed the out parameter in IDOMUIEvent::view to be IDOMWindow


Implemented DOMHTMLDocument::body and DOMHTMLElement::setInnerText.

  • DOMCoreClasses.cpp: (DOMNode::addEventListener): added as DOMNode now needs to implement IDOMEventTarget (DOMNode::removeEventListener): ditto above (DOMNode::dispatchEvent): ditto above (DOMDocument::QueryInterface): DOMDocument now also implements IDOMDocumentEvent (DOMDocument::createEvent): added as DOMDocument implements IDOMDocumentEvent (DOMElement::focus): implemented
  • DOMCoreClasses.h:
  • DOMEventsClasses.cpp: (DOMEvent::DOMEvent): The data member m_event is now a RefPtr, and the WebCore::Event is now passed into the constructor via a PassRefPtr. (DOMEvent::~DOMEvent): No longer need to deref m_event since we are using a RefPtr. (DOMEvent::createInstance): instantiate the correct DOMEvent subclass based on event type. (DOMEvent::QueryInterface): be able to QI IID_DOMEvent, which returns back the DOMEvent type. (DOMUIEvent::view): fixed the API (DOMKeyboardEvent::ctrlKey): call .get() on RefPtr (DOMKeyboardEvent::shiftKey): ditto above (DOMKeyboardEvent::altKey): ditto above (DOMKeyboardEvent::metaKey): ditto above (DOMKeyboardEvent::altGraphKey): ditto above (DOMMouseEvent::ctrlKey): ditto above (DOMMouseEvent::shiftKey): ditto above (DOMMouseEvent::altKey): ditto above (DOMMouseEvent::metaKey): ditto above
  • DOMEventsClasses.h: (DOMEvent::coreEvent): Added an API to get the WebCore::Event out of a DOMEvent. Used in DOMNode::dispatchEvent. (DOMUIEvent::DOMUIEvent): made public so it can be called in DOMEvent::createInstance (DOMKeyboardEvent::DOMKeyboardEvent): ditto above (DOMKeyboardEvent::view): fixed API (DOMMouseEvent::DOMMouseEvent): made public so it can be called in DOMEvent::createInstance (DOMMouseEvent::view): fixed API (DOMMutationEvent::DOMMutationEvent): made public so it can be called in DOMEvent::createInstance (DOMOverflowEvent::DOMOverflowEvent): made public so it can be called in DOMEvent::createInstance (DOMWheelEvent::DOMWheelEvent): made public so it can be called in DOMEvent::createInstance (DOMWheelEvent::view): fixed API
  • DOMHTMLClasses.cpp: (DOMHTMLDocument::body): (DOMHTMLElement::setInnerText):
  • Interfaces/DOMEvents.idl: IDOMEventTarget no longer extends IDOMObject. Added IDOMDocumentEvent.
  • WebContextMenuClient.cpp: (WebContextMenuClient::getCustomMenuFromDefaultItems): check for error from calling contextMenuItemsForElement.
  • WebFrame.cpp: (WebFrame::textWillBeDeletedInTextField): call form delegate callback doCommandBySelector with VK_BACK when deleting text.


3:52 PM Changeset in webkit [19588] by bdash
  • 120 edits
    8 adds in trunk

2007-02-12 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

Tests: fast/repaint/float-overflow.html

fast/repaint/float-overflow-right.html

Reflected in existing test results.

Unified floats and overflow for the purposes of painting and hit-testing.
Overhanging and overflowing floats are now factored into a block's overflow
unless their painting has been propagated to an ancestor.

Changed table cells to no longer expand to enclose overflow, thus making
it purely "visual overflow", having no effect on layout in WebCore. It
still determines scrolling dimensions.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): Include inline blocks' horizontal overflow in the inline box's dimensions.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Removed the expand to enclose overflows behavior. Added code to add this block's floats (and their overflow) to its overflow rect if it is not in a block formatting context. Otherwise, the inclusion of floats in the overflow is deferred until this block's parent examines its floats and possibly adopts overhanging floats. (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::paint): (WebCore::RenderBlock::floatRect): Changed to return an empty rect if there are no floats or the floats are clipped, instead of returning the border box. (WebCore::RenderBlock::addOverhangingFloats): Any floats of the child that are not to be painted by the parent are added to the child's overflow rect. (WebCore::RenderBlock::addVisualOverflow): Added. Adjusts the overflow bounds to include the given rect. (WebCore::RenderBlock::nodeAtPoint):
  • rendering/RenderBlock.h:
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): (WebCore::RenderFlexibleBox::layoutHorizontalBox): After placing a normal child, add its floats to its overflow, since painting of floats does not propagate to flexible boxes. (WebCore::RenderFlexibleBox::layoutVerticalBox): Ditto.
  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::layout):
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::layout):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::layout):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::absoluteBoundingBox):
  • rendering/RenderLayer.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
  • rendering/RenderObject.h: (WebCore::RenderObject::expandsToEncloseOverhangingFloats):
  • rendering/RenderPath.cpp: (WebCore::RenderPath::layout):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::layout):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout):
  • rendering/RenderTableCell.h: (WebCore::RenderTableCell::expandsToEncloseOverhangingFloats):

2007-02-12 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

  • css1/formatting_model/inline_elements-expected.checksum:
  • css1/formatting_model/inline_elements-expected.png:
  • css1/formatting_model/inline_elements-expected.txt:
  • css2.1/t0905-c414-flt-00-d-expected.txt:
  • css2.1/t0905-c414-flt-01-d-g-expected.txt:
  • css2.1/t0905-c414-flt-02-c-expected.txt:
  • css2.1/t0905-c414-flt-03-c-expected.txt:
  • css2.1/t0905-c414-flt-04-c-expected.txt:
  • css2.1/t0905-c414-flt-wrap-01-d-g-expected.txt:
  • css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt:
  • css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt:
  • css2.1/t090501-c414-flt-02-d-g-expected.txt:
  • css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
  • fast/block/float/008-expected.txt:
  • fast/block/float/013-expected.checksum:
  • fast/block/float/013-expected.txt:
  • fast/block/float/029-expected.txt:
  • fast/block/float/031-expected.txt:
  • fast/block/float/float-in-float-painting-expected.txt:
  • fast/block/margin-collapse/059-expected.checksum:
  • fast/block/margin-collapse/059-expected.png:
  • fast/block/margin-collapse/059-expected.txt:
  • fast/block/margin-collapse/062-expected.txt:
  • fast/block/margin-collapse/063-expected.txt:
  • fast/box-shadow/basic-shadows-expected.txt:
  • fast/forms/floating-textfield-relayout-expected.checksum:
  • fast/forms/floating-textfield-relayout-expected.txt:
  • fast/lists/003-expected.txt:
  • fast/media/mq-relative-constraints-08-expected.txt:
  • fast/multicol/float-multicol-expected.txt:
  • fast/repaint/float-overflow-expected.checksum: Added.
  • fast/repaint/float-overflow-expected.png: Added.
  • fast/repaint/float-overflow-expected.txt: Added.
  • fast/repaint/float-overflow-right-expected.checksum: Added.
  • fast/repaint/float-overflow-right-expected.png: Added.
  • fast/repaint/float-overflow-right-expected.txt: Added.
  • fast/repaint/float-overflow-right.html: Added.
  • fast/repaint/float-overflow.html: Added.
  • fast/table/009-expected.checksum:
  • fast/table/009-expected.png:
  • fast/table/009-expected.txt:
  • fast/text/text-shadow-extreme-value.html:
  • fast/text/whitespace/012-expected.txt:
  • tables/mozilla/bugs/bug120364-expected.txt:
  • tables/mozilla/bugs/bug196870-expected.checksum:
  • tables/mozilla/bugs/bug196870-expected.png:
  • tables/mozilla/bugs/bug196870-expected.txt:
  • tables/mozilla/bugs/bug45055-2-expected.txt:
  • tables/mozilla/bugs/bug72359-expected.txt:
  • tables/mozilla/marvin/x_table_align_left-expected.txt:
  • tables/mozilla/marvin/x_table_align_right-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_table-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_table-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_table-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_valign_bottom-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_valign_bottom-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_valign_bottom-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_valign_middle-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_valign_middle-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_valign_middle-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_valign_top-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_valign_top-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_valign_top-expected.txt:
3:36 PM Changeset in webkit [19587] by darin
  • 16 edits
    2 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • update pixel results in cases where overline and line-through were used, because our old code put them 1px too low
  • css1/cascade/cascade_order-expected.checksum: Updated because this has line-through style.
  • css1/cascade/cascade_order-expected.png: Ditto.
  • css1/text_properties/text_decoration-expected.checksum: Updated because this has overline and line-through.
  • css1/text_properties/text_decoration-expected.png: Ditto.
  • css2.1/t1504-c543-txt-decor-00-d-g-expected.checksum: Ditto.
  • css2.1/t1504-c543-txt-decor-00-d-g-expected.png: Ditto.
  • fast/text/stroking-decorations-expected.checksum: Ditto.
  • fast/text/stroking-decorations-expected.png: Ditto.
  • added some missing pixel-test results
  • fast/forms/disabled-select-change-index-expected.checksum: Added.
  • fast/forms/disabled-select-change-index-expected.png: Added.

WebCore:

Reviewed by Hyatt.

  • fix bug where overline and line-through were 1px lower than we intended
  • platform/graphics/GraphicsContext.h: Removed unneeded y offset parameter.
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawLineForText): Removed bogus y offset and +1.
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawLineForText): Ditto.
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawLineForText): Ditto.
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintTextDecorations): Added the "+1" that used to be inside drawLineForText to the underline-drawing code. Changed the other callers of drawLineForText to include the y offset in the y coordinate.
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintDecoration): Ditto. Also renamed _tx and _ty to remove the gratuitious underscores. (WebCore::InlineTextBox::paintMarkedTextUnderline): Made the default thickness be 1px instead of 0 (which ends up being roughly 1px in the CG code path anyway). Fixed the code computing the position to put the underline at the bottom of the line (different from regular underlines which are put 1px under the baseline). The old code used to put the underline 1px further down in the thick case, and 2px further down in the non-thick case. Both of those are bad, because they could be completely clipped out in many cases.
3:35 PM Changeset in webkit [19586] by brmorris
  • 5 edits in S60/trunk/WebCore

zalan, Reviewed by yongjun.

DESC: merging WebKit/trunk r16319 to s60/trunk PKAI-6Y2PBN
Fix fieldsets so that they properly expand to enclose overhanging floats
when the fieldset has auto height. This is a nifty undocumented behavior
of the fieldset element. See ​http://bugs.webkit.org/show_bug.cgi?id=3898

​http://bugs.webkit.org/show_bug.cgi?id=12748

3:31 PM Changeset in webkit [19585] by brmorris
  • 2 edits in S60/branches/3.1m/WebCore

w3liu, Reviewed by Zalan Bujtas <​zbujtas@gmail.com>.

DESC: [S60] Web page teamwork.com not displayed on 3.1 browser AKKO-6XGJZT
Fix: Insert html node if the main document element is not available (document starts

with comment element)

​http://bugs.webkit.org/show_bug.cgi?id=12683

3:24 PM Changeset in webkit [19584] by andersca
  • 7 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

<rdar://problem/4846962>
Aperture: Aperture 1.5 - DOM exception occurs when exporting a web gallery

  • fast/dom/Document/replace-child-expected.txt: Added.
  • fast/dom/Document/replace-child.html: Added.

WebCore:

Reviewed by Darin.

<rdar://problem/4846962>
Aperture: Aperture 1.5 - DOM exception occurs when exporting a web gallery

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::replaceChild): Call checkReplaceChild here.


  • dom/Document.cpp: (WebCore::Document::canReplaceChild):
  • dom/Document.h: Add implementation of canReplaceChild that makes sure that doing the replacement won't cause more than one element and document type node to end up in the document.


  • dom/Node.cpp: (WebCore::Node::canReplaceChild): Base implementation of canReplaceChild.


(WebCore::Node::checkReplaceChild):
New function that does what checAddChild does but calls canReplaceChild.

3:01 PM Changeset in webkit [19583] by kdecker
  • 2 edits in trunk/WebCore

Reviewed by Anders.

Fixed: <rdar://problem/4874059> REGRESSION: Painter IX:register - …
ResourceLoader::willSendRequest() What happened here was that a WebDataSource was being dealloced *while* a load for that resource is still in progress.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopAllLoaders): Calling stopAllLoaders cancels loads and informs the frame load delegate accordingly. The delegate however may decide to kick off a new provisional load as the result of the cancel. Therefore a local variable for the provisional and main doucment loader is introduced, and we now only nil out the provisional loader if the local and member provisional variables represent the exact same load. (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Added the same check here, too.
1:41 PM Changeset in webkit [19582] by lars
  • 8 edits
    2 adds in trunk

Reviewed by Mitz.

Do not create child renderers for table column groups
if the child has not a table column display type.

12:28 PM Changeset in webkit [19581] by antti
  • 2 edits in trunk/WebCore

Reviewed by Mitz

Fix assertion failure in layout test.

  • html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::parseMappedAttribute):
11:58 AM Changeset in webkit [19580] by kmccullo
  • 3 edits in trunk/WebCore

Reviewed by Brady.

  • Fixing a performance regression caused by r19500. The heart of the matter is that we now call canLoad on every resource request even ones in the cache, to avoid a security issue. So I could not take out the canLoad call, but I but I could try to make it more efficient.
  • loader/DocLoader.cpp: (WebCore::DocLoader::requestResource): (WebCore::DocLoader::setLoadInProgress):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::canLoad):
11:05 AM Changeset in webkit [19579] by darin
  • 29 edits in trunk

WebCore:

Reviewed by Oliver.

This area still needs work because keypress events are being sent for all the
events before they go to the input methods, and it seems that this is not
compatible with what other browsers do and with what sites assume. That's covered
by this bug:

​http://bugs.webkit.org/show_bug.cgi?id=10871
<rdar://problem/4823129> REGRESSION: IME key events different in nightly (10871)

which is still open.

  • bindings/objc/ExceptionHandlers.h: Remove selectRange helper that doesn't really belong here, and also isn't needed since the callers don't want to raise ObjC exceptions.
  • bindings/objc/ExceptionHandlers.mm: Ditto. Also removed unneeded external globals that aren't exported anyway and unneeded includes.
  • bridge/EditorClient.h: Added Mac-specific function, markedTextAbandoned. Long term this might move into platform instead, but it's fine to have it on the client for now as long as it doesn't cause trouble for platforms other than Mac.
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): Since all the event handling code in this function is intended to run on the node itself, not parent nodes, check and do nothing if this event is bubbling up from another node. Added code to call a function on EventHandler for default handling of text input events.
  • dom/KeyboardEvent.h:
  • dom/KeyboardEvent.cpp: (WebCore::findKeyboardEvent): Added. Just like the findUIEventWithKeyState function, but specific to keyboard events.
  • dom/TextEvent.h: Added isLineBreak and isBackTab flags so that we can carry additional information about what a text input event is trying to do, but still go through the DOM event machinery.
  • dom/TextEvent.cpp: Ditto.
  • editing/Editor.h:
  • editing/Editor.cpp: (WebCore::Editor::handleKeyPress): Removed unneeded check of isCaretOrRange, since isContentEditable already checks that. (WebCore::Editor::canEdit): Ditto. (WebCore::Editor::canEditRichly): Ditto. (WebCore::Editor::canPaste): Changed to call canEdit for brevity. (WebCore::Editor::replaceSelectionWithText): Changed to take a const String&. (WebCore::Editor::shouldInsertText): Ditto. (WebCore::hasEditableSelection): Removed unneeded check of isCaretOrRange, since isContentEditable already checks that. (WebCore::Editor::Editor): Initialize the new m_ignoreMarkedTextSelectionChange flag. Moved here from WebHTMLView. (WebCore::Editor::insertText): Moved most of the code from -[WebHTMLView insertText:] here, since this needs to be done in response to a text input event and we don't want to go back over the WebKit side for that. (WebCore::Editor::insertLineBreak): Added. Moved here from -[WebHTMLView insertLineBreak:] for the same reason -- needs to be done in response to text input events. (WebCore::Editor::insertParagraphSeparator): Ditto. (WebCore::Editor::selectMarkedText): Added. Used by insertText. (WebCore::Editor::discardMarkedText): Added. Used by insertText. (WebCore::Editor::unmarkText): Added. Used by insertText.
  • editing/mac/EditorMac.mm: (WebCore::Editor::unmarkText): Added. Used by insertText.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::canHaveSelection): Changed to use isTextField to avoid repeating the switch statement. (WebCore::HTMLInputElement::selectionStart): Ditto. (WebCore::HTMLInputElement::selectionEnd): Ditto. (WebCore::HTMLInputElement::setSelectionStart): Ditto. (WebCore::HTMLInputElement::setSelectionEnd): Ditto. (WebCore::HTMLInputElement::select): Ditto. (WebCore::HTMLInputElement::setSelectionRange): Ditto. (WebCore::HTMLInputElement::createRenderer): Resorted cases alphaebtically. (WebCore::HTMLInputElement::defaultEventHandler): Added code to make hitting return cause the form to be submitted when it comes through as a text input event. This is now the normal case on Macintosh, because enter key presses normally turn into this. In addition, change the other event handling to run only after trying the base defaultEventHandler. That makes the key handling done in EventTargetNode take precedence over the event handling here for editable text fields, which is what we want. This gets rid of the need for the hack where we check inputManagerHasMarkedText and suppress the handling of the enter key.
  • page/EventHandler.h: Removed unneeded includes. Moved EventHandlerDragState down into the private part of the class. Changed sendContextMenuEvent to take a const&. Added new handleTextInputEvent and defaultTextInputEventHandler functions. Made eventLoopHandleMouseUp and eventLoopHandleMouseDragged private. Added private defaultTabEventHandler function.
  • page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEvent): Changed parameter to be a const&. (WebCore::EventHandler::defaultKeyboardEventHandler): Rearranged things so that the key bindings handling in handleKeyPress comes before special tab event handling. In cases where the tab turns into text to insert, we now handle it in the text input event handler. (WebCore::EventHandler::handleTextInputEvent): Added. Creates and dispatches a text input event. (WebCore::EventHandler::defaultTextInputEventHandler): Added. Inserts text, but has special cases for the tab and newline character cases. (WebCore::EventHandler::defaultTabEventHandler): Added. Shared by the tab-handling code in the keyboard event and text input event handlers.
  • page/mac/EventHandlerMac.mm: Tweak formatting, remove some unused functions.
  • page/FocusController.h: Removed unnneded includes and forwards, and added an overload of advanceFocus that takes a FocusDirection parameter.
  • page/FocusController.cpp: (WebCore::FocusController::advanceFocus): Changed to allow a 0 for the event pointer. Also added a version where the direction is passed explicitly, to be used for cases where we want to tab backward even if the event doesn't have a shift modifier key set.
  • platform/graphics/svg/SVGImageEmptyClients.h: Updated for change to EditorClient. This should really probably just use 0 for the EditorClient.
  • WebCore.exp: Update both for newly used and no-longer-used entry points.
  • page/mac/WebCoreFrameBridge.h:
  • page/mac/WebCoreFrameBridge.mm: Removed two unused methods.

WebKit:

Reviewed by Oliver.

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::markedTextAbandoned): Added.
  • WebView/WebHTMLView.mm: (-[WebHTMLView menuForEvent:]): Added explicit constructor needed now that the function takes a const&. (-[WebHTMLView becomeFirstResponder]): Removed fake event code, no longer needed since advanceFocus now works fine with 0 for a DOM event. (-[WebHTMLView _expandSelectionToGranularity:]): Changed to use the normal selection controller function instead of selectRange. (-[WebHTMLView insertTab:]): Changed to call bottleneck that receives the DOM event. (-[WebHTMLView insertBacktab:]): Ditto. (-[WebHTMLView insertNewline:]): Ditto. (-[WebHTMLView insertLineBreak:]): Ditto. (-[WebHTMLView insertParagraphSeparator:]): Ditto. (-[WebHTMLView insertNewlineIgnoringFieldEditor:]): Ditto. (-[WebHTMLView insertTabIgnoringFieldEditor:]): Ditto. (-[WebHTMLView yank:]): Updated to call Editor directly since the insertText code now works via a text input event which is not what we want for paste-like things such as yank. (-[WebHTMLView yankAndSelect:]): Ditto. (-[WebHTMLView selectToMark:]): Changed to use the normal selection controller function instead of selectRange, which also allows us to remove the ObjC exception handling code. (-[WebHTMLView swapWithMark:]): Ditto. (-[WebHTMLView transpose:]): Ditto. (-[WebHTMLView unmarkText]): Since this is one of the calls back from the input manager, added code to set the "event was handled" flag. Moved the actual work into the Editor class in WebCore and just call that from here. (-[WebHTMLView _selectRangeInMarkedText:]): Changed to use the normal selection controller function instead of selectRange. (-[WebHTMLView setMarkedText:selectedRange:]): Since this is one of the calls back from the input manager, added code to set the "event was handled" flag. Also changed the ignoreMarkedTextSelectionChange to use the flag over on the WebCore side, since we moved it there and to call selectMarkedText over on the WebCore side too. (-[WebHTMLView doCommandBySelector:]): Added special cases for newline and tab selectors so that the event is passed along. These selectors are special because they are ones that turn into text input events. (-[WebHTMLView _discardMarkedText]): Moved the body of this function into the Editor class in WebCore and just call that from here. (-[WebHTMLView insertText:]): Added code to send a text input event instead of calling the editor to do text insertion. The insertion is then done in the default handler for the text input event. (-[WebHTMLView _insertNewlineWithEvent:isLineBreak:]): Added. Sends a text input event. (-[WebHTMLView _insertTabWithEvent:isBackTab:]): Ditto. (-[WebHTMLView _updateSelectionForInputManager]): Changed to use the ignoreMarkedTextSelectionChange flag in Editor now that the one here is gone.
  • WebView/WebHTMLViewInternal.h: Remove ignoreMarkedTextSelectionChange field.
  • WebView/WebView.mm: (-[WebView setSelectedDOMRange:affinity:]): Changed to use the normal selection controller function instead of selectRange.
10:07 AM Changeset in webkit [19578] by antti
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin

  • fast/images/imagemap-case-expected.checksum: Added.
  • fast/images/imagemap-case-expected.png: Added.
  • fast/images/imagemap-case-expected.txt: Added.
  • fast/images/imagemap-case.html: Added.

WebCore:

Reviewed by Darin.


Make imagemap names case insensitive in HTML mode

  • dom/Document.cpp: (WebCore::Document::getImageMap):
  • html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::parseMappedAttribute):
9:15 AM Changeset in webkit [19577] by ggaren
  • 2 edits in trunk/LayoutTests

Updated results for this failing test. It looks like Maciej generated
the original results before he made the test "dump as text."

  • fast/text/text-shadow-extreme-value-expected.txt:
7:28 AM Changeset in webkit [19576] by brmorris
  • 5 edits in S60/trunk/WebKit

bujtas, Reviewed by Yongjun, merged by Brad.

DESC: Merge of r19540 to s60/trunk: Can not open the Browser application ALES-6Y9GG7
fix: delay formmanager construct
​http://bugs.webkit.org/show_bug.cgi?id=12714

6:59 AM Changeset in webkit [19575] by brmorris
  • 3 edits in S60/trunk/WebKit

yaharon, reviewed by yongjun

DESC: [S60] BrowserNG: Passwords stored without notifying the user MLIO-6XXE6N
​http://bugs.webkit.org/show_bug.cgi?id=12712

6:56 AM Changeset in webkit [19574] by brmorris
  • 2 edits in S60/trunk/WebKit

sareen, reviewed by <​yongjun.zhang@nokia.com>.

DESC: Squares are displayed instead of characters for Greek web pages.
​http://bugs.webkit.org/show_bug.cgi?id=11469

3:59 AM Changeset in webkit [19573] by mjs
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Antti.



  • fast/text/text-shadow-extreme-value.html: Added.
  • fast/text/text-shadow-extreme-value-expected.txt: Added.

WebCore:

Reviewed by Antti.


Test: fast/text/text-shadow-extreme-value.html

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setShadow): Clamp shadow value to 1000px, anything more seems to make CG unhappy.

Feb 11, 2007:

11:37 PM Changeset in webkit [19572] by beidson
  • 3 edits in trunk/WebCore

Reviewed by Maciej

First in what will be a series of HistoryItem enhancements to help debugging

  • history/HistoryItem.cpp: (WebCore::HistoryItem::showTree): (WebCore::HistoryItem::showTreeWithIndent): (showTree): Outside of WebCore namespace, and extern "C" - to make even the DWARF debugger able to find it... *sigh*
  • history/HistoryItem.h:
11:21 PM Changeset in webkit [19571] by mjs
  • 7 edits
    2 adds in trunk

LayoutTests:

Test case not reviewed; based on manual test by David Kilzer.


  • svg/custom/use-events-crash.svg: Added.

WebCore:

Reviewed by Anders.


Test: svg/cust/use-events-crash.svg

  • bindings/js/kjs_dom.cpp: (KJS::toJS):
  • ksvg2/svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::toNode):
  • ksvg2/svg/SVGElementInstance.h:

WebKitTools:

Reviewed by Mitz.


  • add contextClick() operation to eventSender to be able to test this
  • DumpRenderTree/EventSendingController.m: (+[EventSendingController isSelectorExcludedFromWebScript:]): (-[EventSendingController contextClick]):
11:06 PM Changeset in webkit [19570] by bdash
  • 13 edits
    3 adds in trunk/LayoutTests

Binary portion of patch landed in r19490 that I forgot to land.

8:47 PM Changeset in webkit [22935] by aroben
  • 3 edits in branches/WindowsMerge/WebKitWin

Fixing line endings.

  • WebResource.cpp:
  • WebResource.h:
8:06 PM Changeset in webkit [19569] by mjs
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/text/delete-hard-break-character-expected.checksum: Added.
  • fast/text/delete-hard-break-character-expected.png: Added.
  • fast/text/delete-hard-break-character-expected.txt: Added.
  • fast/text/delete-hard-break-character.html: Added.

WebCore:

Reviewed by Maciej.

Test: fast/text/delete-hard-break-character.html

The bug was caused by not updating a line whose line break object and offset
has been deleted. When deleting text, all lines containing the deleted text
are marked dirty. However, if the first character being deleted is a newline
which serves as a hard line break for the previous line, then that line will
not be marked, and since it will be a clean line ending with a line break,
relayout will begin at the next line. The fix is to check for this when
determining where to relayout from.

  • rendering/bidi.cpp: (WebCore::RenderBlock::determineStartPosition): Changed the condition for including the last clean line in relayout to include the case where the last clean line ends with a line break, but that line break is a newline that has been deleted.
5:19 PM Changeset in webkit [19568] by weinig
  • 2 edits in trunk/WebKit

Reviewed by Mark.

Switch the initial value of box-sizing property from "border-box" to "content-box".

4:18 PM Changeset in webkit [19567] by antti
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.


Test for REGRESSION: Google Calendar cell highlight misplaced
​http://bugs.webkit.org/show_bug.cgi?id=12687

  • fast/block/positioning/offsetLeft-offsetTop-borders-expected.checksum: Added.
  • fast/block/positioning/offsetLeft-offsetTop-borders-expected.png: Added.
  • fast/block/positioning/offsetLeft-offsetTop-borders-expected.txt: Added.
  • fast/block/positioning/offsetLeft-offsetTop-borders.html: Added.

WebCore:

Reviewed by Maciej.


REGRESSION: Google Calendar cell highlight misplaced
​http://bugs.webkit.org/show_bug.cgi?id=12687


Make offsetLeft/offsetTop/offsetParent behavior match Firefox.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::offsetLeft): (WebCore::RenderObject::offsetTop): (WebCore::RenderObject::offsetParent):
3:50 PM Changeset in webkit [19566] by antti
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.


Test for REGRESSION: No day/week scrollbar in Google Calendar
​http://bugs.webkit.org/show_bug.cgi?id=11985

  • fast/layers/overflow-scroll-auto-switch-expected.checksum: Added.
  • fast/layers/overflow-scroll-auto-switch-expected.png: Added.
  • fast/layers/overflow-scroll-auto-switch-expected.txt: Added.
  • fast/layers/overflow-scroll-auto-switch.html: Added.

WebCore:

Reviewed by Maciej.

Make sure overflow:auto scrollbars are always enabled. If they were overflow:scroll
and dynamically changed to auto they might still be disabled.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateScrollInfoAfterLayout):
10:28 AM Changeset in webkit [19565] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/check-for-global-initializers: Fix case where executable doesn't exist at all so it doesn't give a perl exception (happens in clean builds, for example).
1:05 AM Changeset in webkit [19564] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Hyatt.

​http://bugs.webkit.org/show_bug.cgi?id=12581
XPath title shouldn't match <title> in XHTML

Test: fast/xpath/ensure-null-namespace.xhtml

  • xml/XPathStep.cpp: (WebCore::XPath::Step::nodeTestMatches): Only let a null namespace match any for HTML.
12:28 AM Changeset in webkit [19563] by ap
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Adam.

​http://bugs.webkit.org/show_bug.cgi?id=12701
REGRESSION: After javascript, onChange not triggered when selecting same option

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex): Remember m_lastOnChangeIndex value, as it can change from setSelected() now. (WebCore::HTMLSelectElement::notifyOptionSelected): Update m_lastOnChangeIndex.
  • manual-tests/select-onchange-after-js.html: Added. Also tests for bug 11402.

Feb 10, 2007:

11:31 PM Changeset in webkit [22934] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Rubberstamped by Oliver.

10:01 PM Changeset in webkit [22933] by aroben
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Steve.

Fix <rdar://problem/4989705> Loading eBay puts many items into back list

The bug was that WebFrame::createFrame was calling loadRequest on the
new child frame, which would initiate a load of FrameLoadTypeStandard,
when in fact we wanted to do a FrameLoadTypeInternal load. I ported
-[WebFrame _loadURL:referrer:intoChild:] to WebFrame, which contains
the logic we need.

  • WebFrame.cpp: (WebFrame::createFrame): Use a COMPtr to manage the new WebFrame, and call loadURLIntoChild instead of just calling loadRequest. (WebFrame::loadURLIntoChild): Ported from Mac WebFrame.
  • WebFrame.h: Added declaration.
6:59 PM Changeset in webkit [19562] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Adam.

  • Scripts/svn-create-patch: (findSourceFileAndRevision($)): Use File::Spec->abs2rel() instead of substr() to generate a relative path to the copied file.
6:32 PM Changeset in webkit [19561] by thatcher
  • 2 edits in trunk/WebKitTools

Reviewed by Sam Weinig.

  • Drosera/Drosera.icns: updated the icon with 512px and 256px variants
6:29 PM Changeset in webkit [19560] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Timothy.

  • Scripts/svn-apply: Binary patches don't need a trailing newline after the base64 encoded text.
6:17 PM Changeset in webkit [19559] by ddkilzer
  • 5 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Maciej.

  • bindings/jni/jni_utility.h: added new type for array, array_type
  • bindings/jni/jni_runtime.cpp: add support for new array type (JavaField::valueFromInstance): (JavaField::setValueToInstance): (JavaMethod::JavaMethod): (JavaMethod::signature):
  • bindings/jni/jni_utility.cpp: add support for new array type (KJS::Bindings::callJNIMethod): (KJS::Bindings::callJNIStaticMethod): (KJS::Bindings::callJNIMethodIDA): (KJS::Bindings::JNITypeFromClassName): (KJS::Bindings::signatureFromPrimitiveType): (KJS::Bindings::JNITypeFromPrimitiveType): (KJS::Bindings::getJNIField): (KJS::Bindings::convertArrayInstanceToJavaArray): new method converts the Javascript array to the requested Java array. (KJS::Bindings::convertValueToJValue):

WebCore:

Reviewed by Maciej.

Manual tests for ​http://bugs.webkit.org/show_bug.cgi?id=12636
Call different Java methods that take a variety of Array parameters
from Javascript, passing a Javascript array.

  • manual-tests/liveconnect-applet-array-parameters.html: Added.
  • manual-tests/resources/ArrayParameterTestApplet.class: Added.
  • manual-tests/resources/ArrayParameterTestApplet.java: Added.
6:06 PM Changeset in webkit [19558] by weinig
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12724
Crash when enumerating XPath namespace axis

Test adapted from Python-based 4XPath test suite,
<​http://sourceforge.net/projects/foursuite/>

  • fast/xpath/namespace-nodes-expected.txt: Added.
  • fast/xpath/namespace-nodes.html: Added.

WebCore:

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12724
Crash when enumerating XPath namespace axis

  • xml/XPathStep.cpp: (WebCore::XPath::Step::nodesInAxis): Namespace axis enumeration was broken in that it crashed, and also in that it returned attribute nodes instead of XPath namespace ones. Removed it altogether.
5:05 PM Changeset in webkit [19557] by ddkilzer
  • 2 edits
    1 add in trunk/WebCore

WebCore:

Reviewed by Adam.

  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::parseValues): Changed the string length math to avoid truncating the last character of each value.
  • manual-tests/svg-animation-parseValues.svg: Added.
5:01 PM Changeset in webkit [19556] by ddkilzer
  • 2 edits
    1 add in trunk/WebCore

WebCore:

Reviewed by Adam.

No automated test case because dumping the render tree updates layer positions anyway.

  • manual-tests/slider-thumb-tracking.html: Added.
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::setCurrentPosition): Added call to updateLayerPosition() for the thumb's layer.
4:52 PM Changeset in webkit [19555] by ddkilzer
  • 3 edits in trunk/LayoutTests

LayoutTests:

Reviewed by Adam.

  • fast/events/frame-click-focus-expected.txt: Update results to include main frame blur.
  • fast/events/frame-click-focus.html: Update to click in main frame first.
6:00 AM Changeset in webkit [19554] by weinig
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

  • WebInspector/webInspector/inspector.css: Added the search field to the undraggable dashboard-region.
2:38 AM Changeset in webkit [19553] by beidson
  • 6 edits
    6 adds in trunk

LayoutTests:

Reviewed by Maciej

<rdar://problem/4965133> WebKit sends ​file:// url referrers

Added a new category of http tests - "local" where the test is run as a local file but
the test involves remote resources from the httpd.
This test had to be done with cached subresources to tickle the code path that was failing before,
hence the bizarre different-sized images instead of simple success/failure text

  • http/tests/local/file-url-sent-as-referer-expected.txt: Added.
  • http/tests/local/file-url-sent-as-referer.html: Added - document.writes an img source that ends up testing the http-referer
  • http/tests/security/resources/green250x50.png: Added.
  • http/tests/security/resources/red200x100.png: Added.
  • http/tests/security/resources/showRefererImage.php: Added - By scanning the referrer, sends back either the success or failure image

WebCore:

Reviewed by Maciej

<rdar://problem/4965133> WebKit sends ​file:// url referrers

  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): In SubresourceLoader::create(), we make a copy of the original request to use for the load. We then call FrameLoader::canLoad() which tells us if we should hide the referer. Before this fix if it said to hide the referrer, we would simply not apply a new referrer to our copy of the request. But if the original request already had a referrer, so did our copy. We simply have to clear the referrer from the copied request.

WebKitTools:

Reviewed by Maciej

<rdar://problem/4965133> WebKit sends ​file:// url referrers

  • Scripts/run-webkit-tests: Enhanced the http tests so that we can run layout tests on local files, but have an httpd for remote resources
2:35 AM Changeset in webkit [19552] by mjs
  • 3 edits
    1 add in trunk/LayoutTests
  • add missing result and update tests to work right from DumpRenderTree
  • fast/dom/Window/resources/window-appendages-cleared-results.html:
  • fast/dom/Window/window-appendages-cleared-expected.txt: Added.
  • fast/dom/Window/window-appendages-cleared.html:
1:12 AM Changeset in webkit [19551] by mjs
  • 4 edits
    2 adds in trunk

LayoutTests:

Regression not reviewed, based loosely on test case from Ian Eng.

  • test case for <rdar://problem/4988091> objects attached to Window not cleared (memory leak)


  • fast/dom/Window/resources/window-appendages-cleared-results.html: Added.
  • fast/dom/Window/window-appendages-cleared.html: Added.

WebCore:

Reviewed by me, patch from Ian Eng (cleaned up by me some).

  • fixed <rdar://problem/4988091> objects attached to Window not cleared (memory leak)


Test case: fast/dom/Window/window-appendages-cleared.html

  • bindings/js/kjs_window.cpp: (KJS::Window::clearHelperObjectProperties): (KJS::Window::clear):
  • bindings/js/kjs_window.h:

Feb 9, 2007:

9:15 PM Changeset in webkit [22932] by sfalken
  • 7 edits in branches/WindowsMerge/WebKitWin

Land Maciej's patch so I can check in.
(Looks like he forgot, since he did move the bug to integrate)

5:57 PM Changeset in webkit [22931] by aliceli1
  • 4 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Brady and Adam.

Fixed <rdar://4986194> Typing in content editable body does not automatically scroll to reveal cursor

  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::updateScrollbars): The scrollview's scrolloffset wasn't getting set in cases where there were no scrollbars You can have a scrolloffset even if you don't have scrollbars

WebKitWin:

Reviewed by Brady and Adam.

Fixed <rdar://4986194> Typing in content editable body does not automatically scroll to reveal cursor
fix depends on corresponding fix in WebCoreWin

  • WebView.cpp: (WebViewWndProc): call the editor to handle inserting text and scrolling/focus changes
5:39 PM Changeset in webkit [19550] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Tim Hatcher

<rdar://problem/4985497> - Plugs a potential null DocumentLoader deref when
transitioning out of the Bookmarks View

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::recursiveGoToItem): add a null check
4:58 PM Changeset in webkit [19549] by kdecker
  • 2 edits in trunk/WebKit

Reviewed by Darin & Maciej.

Fixed: <rdar://problem/4930688> REGRESSION: missing images when reloading webarchives (11962)


  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::canUseArchivedResource): The bug here is that because a reload sets a cache policy of NSURLRequestReloadIgnoringCacheData (rightfully so), this method was refusing to load subresources in WebArchives. It's OK to use archive subresources for the NSURLRequestReloadIgnoringCacheData cache policy because we're not worried about the actual contents of a WebArchive changing on disk.
4:15 PM Changeset in webkit [19548] by thatcher
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Attempt to fix the build when using buildit.

3:53 PM Changeset in webkit [19547] by bdakin
  • 2 edits in trunk/WebCore

Rubber-stamped by John . . . and Adam.

  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Missing break.
3:27 PM Changeset in webkit [19546] by justing
  • 7 edits
    4 adds in trunk

LayoutTests:

Reviewed by darin

  • editing/selection/4975120-expected.checksum: Added.
  • editing/selection/4975120-expected.png: Added.
  • editing/selection/4975120-expected.txt: Added.
  • editing/selection/4975120.html: Added.

WebCore:

Reviewed by darin

<rdar://problem/4975120>
REGRESSION: double-cursor after switching window away/back (11770)
<​http://bugs.webkit.org/show_bug.cgi?id=11328>
Gmail Editor: Caret can simultaneously appear in both the TO: and message body fields

  • page/mac/WebCoreFrameBridge.h: Removed two unused methods left over from the old form control implementation.

WebKit:

Reviewed by darin


<rdar://problem/4975120>
REGRESSION: double-cursor after switching window away/back (11770)
<​http://bugs.webkit.org/show_bug.cgi?id=11328>
Gmail Editor: Caret can simultaneously appear in both the TO: and message body fields

  • WebCoreSupport/WebFrameBridge.mm: Removed unused methods.
  • WebView/WebHTMLView.mm: Ditto. (-[WebHTMLView _web_firstResponderCausesFocusDisplay]): Don't appear focused if a descendant view is firstResponder. (-[WebHTMLView _updateActiveState]): Removed the check for a BOOL that was always false.
  • WebView/WebHTMLViewInternal.h: Removed a BOOL that's always false.
2:51 PM Changeset in webkit [19545] by sullivan
  • 2 edits in trunk/WebCore
  • rendering/bidi.cpp: (WebCore::bidiNext): At Darin's suggestion, moved the "next = 0" line from my previous patch to the start of the loop body
2:37 PM Changeset in webkit [19544] by brmorris
  • 3 edits in S60/branches/3.1m/WebKit

yaharon, Reviewed by yongjun

DESC: [S60] BrowserNG: Passwords stored without notifying the user MLIO-6XXE6N
​http://bugs.webkit.org/show_bug.cgi?id=12712

2:35 PM Changeset in webkit [19543] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by john


<rdar://problem/4960116>
REGRESSION: Nightly Safari crashes in WebCore::SelectionController::xPosForVerticalArrowNavigation (12416)

  • editing/selection/4960116-expected.checksum: Added.
  • editing/selection/4960116-expected.png: Added.
  • editing/selection/4960116-expected.txt: Added.
  • editing/selection/4960116.html: Added.

WebCore:

Reviewed by john


<rdar://problem/4960116>
REGRESSION: Nightly Safari crashes in WebCore::SelectionController::xPosForVerticalArrowNavigation (12416)

  • editing/SelectionController.cpp: (WebCore::SelectionController::xPosForVerticalArrowNavigation): Null check. VisiblePosition creation can fail if a node that contains the selection was made invisible after the selection was made and before this function is called during a selection modification operation.
2:25 PM Changeset in webkit [19542] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by john


<rdar://problem/4983858>
REGRESSION: In a new mail message, attempting to select a single word causes the selection to extend to the previous line


  • editing/selection/4983858-expected.checksum: Added.
  • editing/selection/4983858-expected.png: Added.
  • editing/selection/4983858-expected.txt: Added.
  • editing/selection/4983858.html: Added.

WebCore:

Reviewed by john


<rdar://problem/4983858>
REGRESSION: In a new mail message, attempting to select a single word causes the selection to extend to the previous line

  • editing/TextIterator.cpp: (WebCore::SimplifiedBackwardsTextIterator::exitNode): We recently split shouldEmitNewlineForNode into shouldEmitNewline{Before, After}Node, so this function now needs an implementation that is different from SimplifiedBackwardsTextIterator::handleNonTextNode. The difference is that we must call shouldEmit*BeforeNode instead of shouldEmit*AfterNode since we are a) exiting nodes and b) moving backward.
2:11 PM Changeset in webkit [19541] by justing
  • 13 edits
    4 adds in trunk

LayoutTests:

Reviewed by john

<rdar://problem/4916541>
Some of the selection isn't preserved during an Indent opreration


Added:

  • editing/execCommand/4916541-expected.checksum: Added.
  • editing/execCommand/4916541-expected.png: Added.
  • editing/execCommand/4916541-expected.txt: Added.
  • editing/execCommand/4916541.html: Added. Fixed:
  • editing/execCommand/4641880-2-expected.checksum:
  • editing/execCommand/4641880-2-expected.png:
  • editing/execCommand/4641880-2-expected.txt:
  • editing/execCommand/indent-selection-expected.checksum:
  • editing/execCommand/indent-selection-expected.png:
  • editing/execCommand/indent-selection-expected.txt: Added a FIXME:
  • editing/execCommand/indent-list-item-expected.checksum:
  • editing/execCommand/indent-list-item-expected.png:
  • editing/execCommand/indent-list-item-expected.txt:
  • editing/execCommand/indent-list-item.html:

WebCore:

Reviewed by john

<rdar://problem/4916541>
Some of the selection isn't preserved during an Indent opreration

  • editing/IndentOutdentCommand.cpp: (WebCore::indexForVisiblePosition): Added. (WebCore::IndentOutdentCommand::indentRegion): Use rangeLength and rangeFromLocationAndLength to restore the selection after the repeated moveParagraph calls necessary to perform indent are finished.
2:05 PM Changeset in webkit [19540] by brmorris
  • 5 edits in S60/branches/3.1m/WebKit

bujtas, Reviewed by Yongjun.

DESC: Can not open the Browser application. fix: delay formmanager construct ALES-6Y9GG7
​http://bugs.webkit.org/show_bug.cgi?id=12714

2:05 PM Changeset in webkit [19539] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Kevin Decker


  • fixed <rdar://problem/4960095> REPRODUCIBLE HANG: WebKit freezes when printing as PDF a certain kind of code (12449)


No test case because I don't know how to make the bug occur without printing.

  • rendering/bidi.cpp: (WebCore::bidiNext): reset loop's "next" variable after using it; we were setting "current" to the same value of "next" each subsequent time through the loop, which is not helpful.
1:50 PM Changeset in webkit [22930] by darin
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adele.

  • Add TextEvent to the DOM (based on the proposed DOM level 3) to be used to fix some international input bugs soon. At this point, we don't send any text events.
  • Remove some obsolete files.
  • WebCore.vcproj/WebCore.vcproj: Add new files, remove obsolete files.
1:49 PM Changeset in webkit [19538] by darin
  • 14 edits
    3 adds
    4 deletes in trunk/WebCore

Reviewed by Adele.

  • Add TextEvent to the DOM (based on the proposed DOM level 3) to be used to fix some international input bugs soon. At this point, we don't send any text events.
  • Remove some obsolete files.
  • CMakeLists.txt:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl: Add new files, remove obsolete files.
  • DerivedSources.make: Add TextEvent to the Objective-C and JavaScript bindings lists.
  • WebCore.exp: Export DOMTextEvent Objective-C wrapper.
  • bindings/js/kjs_events.cpp: (KJS::toJS): Added TextEvent to the list of Event subclasses so we make the right kind of JS wrapper.
  • bindings/objc/DOMEvents.mm: (+[DOMEvent _eventWith:]): Same thing, for Objective-C.
  • bindings/objc/DOMInternal.h: Added DOMTextEventInternal.h.
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::hasFeature): Added "TextEvents", "3.0" to the list of things we'll answer true for (as specified in the DOM Level 3 documentation). This isn't so great until we actually send textInput events, but that's coming soon.
  • dom/Document.cpp: (WebCore::Document::createEvent): Add "TextEvent" as a way to make a TextEvent (as specified in the DOM Level 3 documentation).
  • dom/Event.h:
  • dom/Event.cpp: (WebCore::Event::isTextEvent): Added virtual function to be used for runtime type checking of Event objects (as for other event types).
  • dom/TextEvent.cpp: Added.
  • dom/TextEvent.h: Added.
  • dom/TextEvent.idl: Added.
  • platform/mac/WebCoreWidgetHolder.h: Removed.
  • rendering/CounterListItem.h: Removed.
  • rendering/CounterResetNode.cpp: Removed.
  • rendering/CounterResetNode.h: Removed.
1:16 PM Changeset in webkit [22929] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest): Add the stream to the m_streams hash set.
12:33 PM Changeset in webkit [19537] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/4816376>
REGRESSION: NetNewsWire 3.0 - Crashes in WebDocumentLoaderMac::attachToFrame() (12674)


The bug was that the NNW policy delegate never calls back on the policy listener so we'll try to do a load
while there's a policy decision underway. The extra call to setPolicyDocumentLoader would cause a detached (and deallocated)
WebDataSource to be reattached and thus causing a crash.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::load): Remove extra call to setPolicyDocumentLoader.
12:06 PM Changeset in webkit [19536] by bdakin
  • 8 edits in trunk

WebCore:

Fix for <rdar://problem/4674537> REGRESSION: Adobe Acrobat 8 - Text
blinks when mouse is moved, and is invisible otherwise

Acrobat 8 was relying on a WebKit bug that was fixed about a year
ago with r12753. The bug was that we would not reload a page if the
source of an iframe was set to the same value it already was. Now
that we have fixed the bug, Acrobat constantly reloads their EULA,
making it blinky and impossible to read.

No layout test since the fix is to add an Acrobat-specific quirk.

  • WebCore.exp:
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::setLocation): If the new url is the same as the old one and we are honoring the Acrobat quirk, don't do anything.
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setNeedsAcrobatFrameReloadingQuirk):
  • page/Settings.h: (WebCore::Settings::needsAcrobatFrameReloadingQuirk):

WebKit:

Reviewed by Darin.

Fix for <rdar://problem/4674537> REGRESSION: Adobe Acrobat 8 - Text
blinks when mouse is moved, and is invisible otherwise

Allow quirk if the Application was linked before 3.0 and if the
application is Adobe Acrobat.

  • Misc/WebKitVersionChecks.h:
  • WebView/WebView.mm: (-[WebView _updateWebCoreSettingsFromPreferences:]):
12:00 PM Changeset in webkit [19535] by beidson
  • 2 edits in trunk/WebCore

Rubberstamped by Dave Harrison

Disable the thread-check assertion in WebCore, as well as Webkit

  • WebCore.xcodeproj/project.pbxproj:
11:28 AM Changeset in webkit [19534] by andersca
  • 8 edits in trunk

JavaScriptCore:

Reviewed by Geoff.

<rdar://problem/4930614>
Safari complains about "Slow Script" if GMail is left open and machine is busy


<rdar://problem/4649516>
Turn off slow script dialog or crank up time that makes it come up


<rdar://problem/4963589>
Slow script warning is displayed after closing of PROMPT or PRINT dialog


Re-do the way script timeouts are handled. No longer use a unix timer that sends signals. Instead, add a
tick count and increment it in loop bodies. If the tick count reaches a threshold, do a timeout check. If the total time executing
is higher than the timeout value, (possibly) interrupt the script. The timeout checker also adjusts the threshold dynamically
to prevent doing the timeout check too often.



  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add winmm.lib.
  • kjs/interpreter.cpp: (KJS::Interpreter::init): (KJS::Interpreter::~Interpreter): (KJS::Interpreter::startTimeoutCheck): (KJS::Interpreter::stopTimeoutCheck): (KJS::Interpreter::resetTimeoutCheck): (KJS::getCurrentTime): (KJS::Interpreter::checkTimeout):
  • kjs/interpreter.h: (KJS::Interpreter::timedOut):
  • kjs/nodes.cpp: (DoWhileNode::execute): (WhileNode::execute): (ForNode::execute):

WebCore:

Reviewed by Geoff.

No need to pause timeout checks anymore.


  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
11:07 AM Changeset in webkit [19533] by brmorris
  • 2 edits in S60/trunk/WebKit

raalexan, Reviewed by Yongjun.

DESC: Input element deactivation methods not working (TSW TMCN-6XYRVX)
​http://bugs.webkit.org/show_bug.cgi?id=12699

11:04 AM Changeset in webkit [19532] by brmorris
  • 3 edits in S60/trunk/WebCore

yaharon, reviewed by zalan

DESC: [S60] Browser crashes when selecting the left Soft key Options when the cursor is in textarea field (SCHY-6Y7SHD)
​http://bugs.webkit.org/show_bug.cgi?id=12706

10:48 AM Changeset in webkit [19531] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Brady.

  • WebKit.exp: Add WebBaseNetscapePluginView to the export list.
10:44 AM Changeset in webkit [19530] by thatcher
  • 1 edit in trunk/WebKitTools/DumpRenderTree/EventSendingController.m

Build fix. Use 0 or 0.0 instead of nil to prevent a compile warning.

8:50 AM Changeset in webkit [22928] by sullivan
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Beth

  • WebKitWin part of fix for radar 4939636, problems with context menu items and binaries linked against WebKit 2.0.
  • Interfaces/IWebUIDelegate.idl: bumped enum value for new SPI tags to match change in WebCore/WebKit
8:48 AM Changeset in webkit [19529] by sullivan
  • 7 edits in trunk

WebCore:

Reviewed by Beth


  • WebCore part of fix for radar 4939636, problems with context menu items and binaries linked against WebKit 2.0.
  • platform/ContextMenuItem.h: (WebCore::): Tweaked comment; bumped enum value for new SPI tags to avoid conflict with pre-3.0 SPI tag values.

WebKit:

Reviewed by Beth

  • WebKit part of fix for radar 4939636, problems with context menu items and binaries linked against WebKit 2.0.
  • WebKit.xcodeproj/project.pbxproj: Changed DYLIB_CURRENT_VERSION to 2 (was 1)
  • Misc/WebKitVersionChecks.h: Added constant WEBKIT_FIRST_VERSION_WITH_3_0_CONTEXT_MENU_TAGS, which is 2 but in the weird format that these version checks use.
  • WebView/WebUIDelegatePrivate.h: Tweaked comments; included the old values for three tags for context menu items that changed from SPI to API in 3.0; renamed WEBMENUITEMTAG_SPI_START to WEBMENUITEMTAG_WEBKIT_3_0_SPI_START for clarity, and bumped its value to avoid conflict with the three old values
  • WebCoreSupport/WebContextMenuClient.mm: (isAppleMail): new helper function that checks the bundle identifier (fixMenusToSendToOldClients): Removed return value for clarity; now checks linked-on version and also makes special case for Mail; now replaces three API tags with their old SPI values for clients that linked against old WebKit version, in addition to replacing new API with WebMenuItemTagOther for items that had no specific tag before. (fixMenusReceivedFromOldClients): Removed return value for clarity; removed defaultMenuItems parameter because it's no longer necessary; removed code that tried to recognize menus that got confused by the SPI -> API change (we now pass the old SPI values to these clients to avoid confusing them); now restores the tags for the items whose tags were replaced in fixMenusToSendToOldClients (this used to restore the tags of the default items rather than the new items, which was incorrect but happened to work since the clients we tested were using the objects from the default items array in their new items array) (WebContextMenuClient::getCustomMenuFromDefaultItems): Updated to account for the removed return values for the two fix-up methods; moved the autorelease of newItems here, which is clearer and was the source of a leak before.
5:55 AM Changeset in webkit [19528] by bdash
  • 6 edits
    18 adds in trunk

2007-02-09 Nicholas Shanks <​webkit@nickshanks.com>

Reviewed by Dave Hyatt.

Removed broken recognition of :last-* and :only-* selectors

  • css/CSSGrammar.y:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector):

2007-02-09 Nicholas Shanks <​webkit@nickshanks.com>

Reviewed by Dave Hyatt.

Removed broken recognition of :last-* and :only-* selectors
Test results show red indicating property unsupported
Previous behaviour was to erroneously make everything green

  • css3/expected_failures/css3-modsel-33-expected.checksum: Added.
  • css3/expected_failures/css3-modsel-33-expected.png: Added.
  • css3/expected_failures/css3-modsel-33-expected.txt: Added.
  • css3/expected_failures/css3-modsel-33.html: Added.
  • css3/expected_failures/css3-modsel-35-expected.checksum: Added.
  • css3/expected_failures/css3-modsel-35-expected.png: Added.
  • css3/expected_failures/css3-modsel-35-expected.txt: Added.
  • css3/expected_failures/css3-modsel-35.html: Added.
  • css3/expected_failures/css3-modsel-36-expected.checksum: Added.
  • css3/expected_failures/css3-modsel-36-expected.png: Added.
  • css3/expected_failures/css3-modsel-36-expected.txt: Added.
  • css3/expected_failures/css3-modsel-36.html: Added.
  • css3/expected_failures/css3-modsel-37-expected.checksum: Added.
  • css3/expected_failures/css3-modsel-37-expected.png: Added.
  • css3/expected_failures/css3-modsel-37-expected.txt: Added.
  • css3/expected_failures/css3-modsel-37.html: Added.
5:24 AM Changeset in webkit [19527] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Mark.

<rdar://problem/4980176>

  • page/Frame.cpp: (WebCore::Frame::pageDestroyed): Since this frame is getting disconnected from its page, ensure it is not the focus node.
2:57 AM Changeset in webkit [19526] by kjk
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

gdklauncher crashes when compiled with NDEBUG defined.

  • Projects/gdk/webcore-gdk.bkl:
2:44 AM Changeset in webkit [19525] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Mitz.

<rdar://problem/4971224> REGRESSION: ASSERT in WebCore with Mail (12491)
​http://bugs.webkit.org/show_bug.cgi?id=12491

No test case. Not testable since there is no way to do substitute
data loads from layout tests.


  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::continueAfterContentPolicy): Don't dispatch data load callback when loading empty data.
12:50 AM Changeset in webkit [19524] by bdash
  • 4 edits in trunk/WebCore

2007-02-09 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12705
REGRESSION: Crash with user stylesheet set

Allow the Frame::canLoad check to skipped so that user stylesheets can be loaded in remote documents.

  • ChangeLog:
  • loader/DocLoader.cpp: (WebCore::DocLoader::requestCSSStyleSheet): Skip canLoad check if this is a user stylesheet. (WebCore::DocLoader::requestUserCSSStyleSheet): (WebCore::DocLoader::requestResource): Allow canLoad check to be skipped.
  • loader/DocLoader.h:
  • page/Frame.cpp: (WebCore::UserStyleSheetLoader::UserStyleSheetLoader):
Note: See TracTimeline for information about the timeline view.