Timeline



Feb 23, 2007:

11:42 PM Changeset in webkit [19838] by kdecker
  • 3 edits in trunk/WebCore

Reviewed by Anders.

Fixed: <rdar://problem/4971226> REGRESSION: Replying to closed HTML mail message does not quote original body (12503)


There were two problems here:


  • page/mac/WebCoreFrameBridge.mm: (+[WebCoreFrameBridge stringWithData:textEncodingName:]): The old code said "if there is no text encoding name than assume WindowsLatin1 (iso-8859-1) and try to decode that". That's not sufficient because it doesn't handle the fallback case for unknown encodings. This method will now attempt to decode using WindowsLatin1 for unknown encoding types.
  • platform/mac/mac-encodings.txt: Added the missing "macroman" encoding type.
8:35 PM Changeset in webkit [22992] by andersca
  • 2 adds in branches/WindowsMerge/LayoutTests

Reviewed by Adam.

<rdar://problem/4516049>
Basic Infrastructure: Get regression tests running.


Make boomer-run-webkit-tests work with our internal setup.


  • Scripts/boomer-run-webkit-tests:
6:55 PM Changeset in webkit [19837] by weinig
  • 4 edits in trunk

LayoutTests:

Reviewed by Maciej.

  • editing/deleting/delete-3800834-fix-expected.txt:

WebCore:

Reviewed by Maciej.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): If the fragment to be inserted is empty, first delete the selection, and only then bail out.
6:52 PM Changeset in webkit [19836] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5001923>
REGRESSION: Crash when navigating forward from an error page in WebFrameLoaderClient::dispatchDidReceiveContentLength

Fix an error that was introduced in revision r18541. We should check if the provisional document loader
has an unreachable URL, not the actual document loader.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::updateHistoryForCommit):
6:35 PM Changeset in webkit [19835] by weinig
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/events/selectstart-during-autoscroll-expected.txt: Added.
  • fast/events/selectstart-during-autoscroll.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/events/selectstart-during-autoscroll.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): Invoke the renderer's shouldSelect() -- which dispatches the selection DOM event and gives it a chance to cancel the selection -- before updating the selection during autoscroll.
6:22 PM Changeset in webkit [19834] by weinig
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

  • WebView/WebHTMLView.mm: (-[WebTextCompleteController endRevertingChange:moveLeft:]):
6:21 PM Changeset in webkit [22991] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

<rdar://problem/4761543>
nike.com doesn't finish loading if Flash plugin is installed.


If a plugin requests a JavaScript URL with a non null frame target, execute the JavaScript expression. If the result
is not "undefined", replace the contents of the frame with the result converted to a string.

  • plugins/win/PluginViewWin.cpp: (WebCore::getString): (WebCore::PluginViewWin::performRequest): (WebCore::PluginViewWin::requestTimerFired):
5:25 PM Changeset in webkit [19833] by oliver
  • 1 edit in trunk/WebCore/ChangeLog

Correcting ChangeLog

5:22 PM Changeset in webkit [19832] by oliver
  • 2 edits
    1 add in trunk/WebCore

2007-02-23 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12870

It turns out short circuiting DragData::containsURL() was bad

  • ChangeLog:
  • WebCore.xcodeproj/project.pbxproj:
  • manual-tests/directory-drop-on-view.html: Added.
  • platform/mac/DragDataMac.mm: (WebCore::DragData::containsURL):
2:35 PM Changeset in webkit [19831] by brmorris
  • 2 edits in S60/trunk/WebKit

forrest, reviewed by sachin

DESC: re-insert ability to handle EDoNothing case for disposition of downloaded content SXUU-6XZ232

11:13 AM Changeset in webkit [19830] by thatcher
  • 5 edits in trunk/WebKit

Reviewed by Brady.

<rdar://problem/5016395> _recursive_pauseNullEventsForAllNetscapePlugins still gone

  • WebView/WebFrameInternal.h: Remove _recursive_pauseNullEventsForAllNetscapePlugins
  • WebView/WebFramePrivate.h: Add _recursive_pauseNullEventsForAllNetscapePlugins
  • WebView/WebFrame.mm: More _recursive_pauseNullEventsForAllNetscapePlugins
8:43 AM Changeset in webkit [19829] by mjs
  • 1 edit in trunk/WebCore/ChangeLog

Added missing bug numbers.

8:32 AM Changeset in webkit [19828] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Mitz.

  • 12.5% speedup on BenchJS test 6


It turns out that calling documentVisibleRect on an NSScrollView is pretty expensive,
and calling visibleRect even more so. Take measures to call them less often.

  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::visibleContentRect): Use documentVisibleRect when possible. (WebCore::ScrollView::updateContents): Use visibleContentRect to be able to use documentVisibleRect when possible.
  • rendering/RenderView.cpp: (WebCore::RenderView::repaintViewRectangle): Don't get or intersect with viewRect if we don't have a parent frame, since the ScrollView will do that anyway. Also, don't get contentX and contentY separately since they are in the viewRect already. (WebCore::RenderView::viewRect): Use visibleContentRect instead of getting each coordinate individually, to avoid calling documentVisibleRect repeatedly.
8:25 AM Changeset in webkit [19827] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Mitz.

  • 2% speedup on BenchJS test 6
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText): Use format() instead of number() followed by append of a constant string.
7:34 AM Changeset in webkit [19826] by staikos
  • 2 edits in trunk/JavaScriptCore

add return values (!!)

7:26 AM Changeset in webkit [19825] by staikos
  • 2 edits in trunk/WebCore

Fix the Qt build.

7:08 AM Changeset in webkit [19824] by zack
  • 2 edits in trunk/WebKitQt

Adding a little bit of eye-candy to the last
commit (animations on hover events)

6:21 AM Changeset in webkit [19823] by zack
  • 7 edits in trunk/WebKitQt

Adding API and code for notification of when the
mouse is hovering over a link and adding code to
the sample app to showcase it.
r=Lars

Feb 22, 2007:

10:54 PM Changeset in webkit [22990] by oliver
  • 2 edits in branches/WindowsMerge/WebCore

2007-02-22 Oliver Hunt <​oliver@apple.com>

rs = adam


Replacing radar numbers from previous patch with one
the isn't fictitious <rdar://problem/5018591>

  • platform/win/CursorWin.cpp: (WebCore::columnResizeCursor): (WebCore::rowResizeCursor): (WebCore::verticalTextCursor):
10:48 PM Changeset in webkit [19822] by kjk
  • 14 edits
    1 add in trunk/WebCore

Reviewed by Adam Roben, who never sleeps.

To avoid code duplication, move notImplementedGdk() macro to a separate
header file. Remove existing notImplementedGdk() macros and replace
remaining notImplemented() to notImplementedGdk() in gdk code.

  • loader/gdk/DocumentLoaderGdk.cpp: (WebCore::DocumentLoader::getResponseModifiedHeader):
  • loader/gdk/FrameLoaderClientGdk.cpp: (WebCore::FrameLoaderClientGdk::hasWebView): (WebCore::FrameLoaderClientGdk::hasFrameView):
  • page/gdk/ContextMenuClientGdk.cpp: (WebCore::ContextMenuClientGdk::contextMenuDestroyed): (WebCore::ContextMenuClientGdk::getCustomMenuFromDefaultItems): (WebCore::ContextMenuClientGdk::contextMenuItemSelected): (WebCore::ContextMenuClientGdk::downloadURL): (WebCore::ContextMenuClientGdk::copyImageToClipboard): (WebCore::ContextMenuClientGdk::searchWithGoogle): (WebCore::ContextMenuClientGdk::lookUpInDictionary): (WebCore::ContextMenuClientGdk::speak): (WebCore::ContextMenuClientGdk::stopSpeaking):
  • page/gdk/EventHandlerGdk.cpp:
  • platform/gdk/CursorGdk.cpp: (WebCore::Cursor::Cursor):
  • platform/gdk/EditorClientGdk.cpp:
  • platform/gdk/NotImplementedGdk.h: Added.
  • platform/gdk/PopupMenuGdk.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::updateFromElement):
  • platform/gdk/RenderThemeGdk.cpp:
  • platform/gdk/ScreenGdk.cpp: (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):
  • platform/gdk/TemporaryLinkStubs.cpp:
  • platform/graphics/gdk/ImageGdk.cpp: (WebCore::Image::drawPattern):
  • platform/network/gdk/ResourceHandleCurl.cpp: (WebCore::ResourceHandle::setDefersLoading):
  • platform/network/gdk/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::setupPUT): (WebCore::ResourceHandleManager::setupPOST):
10:30 PM Changeset in webkit [22989] by oliver
  • 2 edits in branches/WindowsMerge/WebCore

2007-02-22 Oliver Hunt <​oliver@apple.com>

Reviewed by Ada.

Implemented a couple more cursor methods

  • platform/win/CursorWin.cpp: (WebCore::columnResizeCursor): (WebCore::rowResizeCursor): (WebCore::verticalTextCursor): Added radar bug reference <rdar://problem/5018452> (WebCore::progressCursor): (WebCore::noDropCursor): (WebCore::notAllowedCursor): Making them return the correct cursor


8:32 PM Changeset in webkit [19821] by thatcher
  • 2 edits in trunk/WebKitTools

Reviewed by Tim H.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12852
Bug#12852: Drosera should select function name, not "function" keyword when selecting from function list pop-up

  • Drosera/debugger.js: Fixed some logic errors resulting in generating double IDs and names.
7:48 PM Changeset in webkit [19820] by weinig
  • 7 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/events/remove-event-listener-expected.txt: Added.
  • fast/events/remove-event-listener.html: Added.

WebCore:

Reviewed by Maciej.

and

Problem: RemoveEventListener leaks memory if the listener is not
registered.
Fix: Added Window::findJSEventListener function w/o creating a
JSEventListener; Renamed getJSEventListener to findOrCreateJSEventListener;

As an enhancement, added a leak counter for EventListeners.

Added a test case, LayoutTests/fast/events/remove-event-listener.html.

  • WebCore/bindings/js/kjs_dom.cpp:
  • WebCore/bindings/js/kjs_window.h:
  • WebCore/bindings/js/kjs_window.cpp:
  • WebCore/bindings/js/kjs_event.cpp: Add a leak counter.
  • WebCore/bindings/js/JSXMLHttpRequest.cpp:
  • LayoutTests/fast/events/remove-event-listener.html:
7:38 PM Changeset in webkit [19819] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/4998203>
REGRESSION: Back-forward list gets messed up when navigating to error pages with back-forward cache turned off


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::load): Remove call to setPolicyDocumentLoader(), the policy document loader is set immediately after, and setting it before calling shouldReloadToHandleUnreachableURL causes us to get the wrong URL.


(WebCore::FrameLoader::shouldReloadToHandleUnreachableURL):
Check if the unreachable URL is equal to the document loader's request.


(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
Check the provisional document loader's unreachable URL.

6:47 PM Changeset in webkit [22988] by oliver
  • 5 edits in branches/WindowsMerge/WebCore

2007-02-22 Oliver Hunt <​oliver@apple.com>

Reviewed by Anders.

Removing accessive COMPtr use from ClipboardWin constructors
Adding data verification to ClipoardWin::SetData
Small amount code tidying, and allowing for failure when writing an URL

  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::createDraggingClipboard): Updated for new ClipboardWin constructor
  • platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::ClipboardWin): (WebCore::writeURL): (WebCore::ClipboardWin::getData): Tidying code, and allowing failure (WebCore::ClipboardWin::setData): Verifying that we're writing a valid url


  • platform/win/ClipboardWin.h:
  • platform/win/EditorWin.cpp: (WebCore::Editor::newGeneralClipboard): Updated for new ClipboardWin constructor
5:13 PM Changeset in webkit [19818] by bdash
  • 4 edits in trunk

Versioning.

4:35 PM Changeset in webkit [19817] by bdash
  • 4 edits in tags/Safari-5522

Versioning.

4:32 PM Changeset in webkit [19816] by bdash
  • 2 edits in tags/Safari-5522/WebCore

Merge in r19806.

2007-02-22 Adele Peterson <​adele@apple.com>

Reviewed by Darin.

Fix for <rdar://problem/5014970> 9A374: Tabs don't work in the message body

Test: fast/events/keypress-insert-tab.html

  • page/EventHandler.cpp: (WebCore::EventHandler::defaultTextInputEventHandler): If the defaultTabEventHandler doesn't handle the event, then go on to the insertText case.
4:29 PM Changeset in webkit [19815] by bdash
  • 3 edits in tags/Safari-5522/JavaScriptGlue

Merge in r19805.

2007-02-22 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.


Fixed <rdar://problem/4942528> Installer.app Stuck "Examining additional
volumes..."


The problem was that JavaScriptGlue held a JSObject in a static pointer
without protecting it from garbage collection.


sUserObjectPrototypeImp = new UserObjectPrototypeImp();
static ProtectedPtr<UserObjectPrototypeImp> protectPrototype; valiant, brave, but useless

Through an interesting comedy of errors, this object would be collected
and then assigned as the prototype of another object allocated at the
same address, thus becoming its own prototype. (See ​http://www.ziplo.com/grandpa.htm
for further explanation of this phenomenon.) Hence the infinte loop in
property lookup.


The solution is equally humorous: all of this code was completely useless --
it only served to create an empty object in the prototype chain -- so
I just removed it.

  • UserObjectImp.cpp: (UserObjectImp::UserObjectImp):
  • UserObjectImp.h:
4:26 PM Changeset in webkit [19814] by bdash
  • 2 edits in tags/Safari-5522/WebCore

Merge in r19783.

2007-02-21 Brady Eidson <​beidson@apple.com>

Reviewed by Dave Harrison

<rdar://problem/5014313> - Crash in FrameLoader::restoreScrollPositionAndViewState()
after regaining network connection

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::restoreScrollPositionAndViewState): Leave an assertion for debug build exploration, but gracefully handle the release build case
4:21 PM Changeset in webkit [19813] by bdash
  • 1 copy in tags/Safari-5522

New tag.

4:12 PM Changeset in webkit [22987] by adele
  • 2 edits in branches/WindowsMerge/WebKitWin

Updating this file to match WebCore.

  • WebKit.vcproj/textAreaResizeCorner.png:
4:03 PM Changeset in webkit [19812] by adele
  • 3 edits in trunk/WebKit

Reviewed by John.

Updating this image to match the one in WebCore.

  • WebKit.vcproj/textAreaResizeCorner.png:
3:59 PM Changeset in webkit [22986] by bdakin
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12399 REGRESSION:
Unable to prevent default context menu from appearing. <rdar://
problem/5017416>

  • WebView.cpp: (WebView::handleContextMenuEvent): Clear the controller's context menu before propagating a new context menu event through the DOM.
3:51 PM Changeset in webkit [19811] by justing
  • 19 edits
    8 adds in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/5007143>
REGRESSION: WebKit doesn't remember horizontal position of caret when moving forward by line

Added, tests the removal of the use of the
recalc bool from xPosForVerticalArrowNavigation(...):

  • editing/selection/5007143-2-expected.checksum: Added.
  • editing/selection/5007143-2-expected.png: Added.
  • editing/selection/5007143-2-expected.txt: Added.
  • editing/selection/5007143-2.html: Added. Added, demonstrate the changes to modify:
  • editing/selection/5007143-expected.checksum: Added.
  • editing/selection/5007143-expected.png: Added.
  • editing/selection/5007143-expected.txt: Added.
  • editing/selection/5007143.html: Added. Demonstrates a bug (filed 5017312):
  • editing/style/block-style-004-expected.txt:
  • editing/style/block-style-005-expected.txt:
  • editing/style/block-style-006-expected.txt: Fixed:
  • editing/selection/3690703-2-expected.checksum:
  • editing/selection/3690703-2-expected.png:
  • editing/selection/3690703-2-expected.txt:
  • editing/style/create-block-for-style-009-expected.checksum:
  • editing/style/create-block-for-style-009-expected.png:
  • editing/style/create-block-for-style-009-expected.txt:
  • editing/style/create-block-for-style-011-expected.checksum:
  • editing/style/create-block-for-style-011-expected.png:
  • editing/style/create-block-for-style-011-expected.txt:

WebCore:

Reviewed by darin


<rdar://problem/5007143>
REGRESSION: WebKit doesn't remember horizontal position of caret when moving forward by line

  • editing/SelectionController.cpp: (WebCore::SelectionController::SelectionController): Initialize m_xPosForVerticalArrowNavigation. (WebCore::SelectionController::setSelection): Call the new setter. (WebCore::SelectionController::modifyMovingRightForward): For line and paragraph granularities, use the saved xPosForVerticalArrowNavigation even if the old selection was a range. Use the x position of the *start*, not the end of the selection if there is no saved xPosForVerticalArrowNavigation. This matches TextEdit's behavior. (WebCore::SelectionController::modifyMovingLeftBackward): For line and paragraph granularities, use the saved xPosForVerticalArrowNavigation even if the old selection was a range. (WebCore::SelectionController::modify): Preserve the xPosForVerticalArrowNavigation for line and paragraph granularities. (WebCore::SelectionController::xPosForVerticalArrowNavigation): Removed the recalc bool because it is now always false. (WebCore::SelectionController::setXPosForVerticalArrowNavigation): Added.
  • editing/SelectionController.h: Moved m_xPosForVerticalArrowNavigation from Frame.
  • page/Frame.cpp: Moved m_xPosForVerticalArrowNavigation to SelectionController.
  • page/Frame.h: Ditto.
  • page/FramePrivate.h: Ditto.
3:49 PM Changeset in webkit [19810] by bdakin
  • 6 edits
    1 add in trunk

WebCore:

Reviewed by Adam. Manual test added.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12399 REGRESSION:
Unable to prevent default context menu from appearing. <rdar://
problem/5017416>

This problem appeared because of two facets of the current context
menu design. First, all context menu events are now considered to
be "swallowed" since we take care of building up the regular
context menu through the defaultEventHandler(). Second, the context
menu controller holds onto it's context menu until a new one is
created. There would be logistical problems changing this since
AppKit relies on the menu being around for as long as it is
visible on the screen and we don't get any notification once the
menu is popped-down.

This patch fixes the problem by giving WebKit a way to clear the
controller's context menu. WebKit now clears the menu before it
propagates a new context menu event through the DOM.

  • WebCore.exp:
  • manual-tests/DOMContextMenuEvent.html: Added.
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::clearContextMenu):
  • page/ContextMenuController.h:

WebKit:

Reviewed by Adam.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12399 REGRESSION:
Unable to prevent default context menu from appearing. <rdar://
problem/5017416>

  • WebView/WebHTMLView.mm: (-[WebHTMLView menuForEvent:]): Clear the controller's context menu before propagating a new context menu event through the DOM.
3:44 PM Changeset in webkit [22985] by oliver
  • 15 edits
    1 move
    4 adds in branches/WindowsMerge

2007-02-22 Oliver Hunt <​oliver@apple.com>

Reviewed by Ada, Lou, and Steve.

WebKit:

Last of the major changes for drag and drop

  • Move COMPtr.h to WebCore
  • Added WebDragSource, a modified version of SDataSource from the App that can notify a WebView's eventhandler of drag events
  • Implement the last bits of the DragClient
  • As part of drag client added code to draw the "doubled" text used by drag links. May be useful for other parts of WebKit/App


  • COMPtr.h: Removed. Moving to WebCore
  • WebDragClient.cpp: (WebDragClient::actionMaskForDrag): (WebDragClient::willPerformDragDestinationAction): (WebDragClient::dragSourceActionMaskForPoint): (WebDragClient::willPerformDragSourceAction):
Removing WebCore
as i'm now using the WebCore namespace (WebDragClient::startDrag): Implemented client method (allocImage): (dragLabelFont): Helper functions for generating the link dragging image (WebDragClient::createDragImageForLink): Implemented client method
  • WebDropSource.cpp: Added. (WebDropSource::createInstance): (WebDropSource::WebDropSource): (WebDropSource::QueryInterface): (WebDropSource::AddRef): (WebDropSource::Release): (generateMouseEvent): Generates a mouse event for the EventHandler (WebDropSource::QueryContinueDrag): (WebDropSource::GiveFeedback): Copied from SDataObject in the App. Minor changes per suggestions from Ada and Steve (error codes, potential leaks) Also includes logic to notify the source WebView of drag events (moving and drag end)
  • WebDropSource.h: Added. Header for the above
  • WebKit.vcproj/WebKit.vcproj: Removing COMPtr.h, and adding WebDropSource.{h,cpp}
  • WebKitGraphics.cpp: (DrawDoubledTextAtPoint): Utility function for drawing double text, as used by link dragging image
This resolves <rdar://problem/4821407> Cannot drag link to bookmarks bar to create new link <rdar://problem/4869496> User Interaction Essentials: Drag
  • WebCore.vcproj/WebCore.vcproj: Adding new files


  • page/win/DragControllerWin.cpp: (WebCore::DragController::maxDragImageSize): Maximum size of drag image to allow sharp edges is 208x208


  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::createDraggingClipboard): Properly implemented now


  • platform/win/ClipboardWin.cpp: (WebCore::): (WebCore::clipboardTypeFromMIMEType): (WebCore::ClipboardWin::ClipboardWin): (WebCore::ClipboardWin::~ClipboardWin): (WebCore::writeURL): Helper function to write a url to a WCDataObject (WebCore::ClipboardWin::clearData): (WebCore::ClipboardWin::clearAllData): (WebCore::ClipboardWin::getData): (WebCore::ClipboardWin::setData): (WebCore::addMimeTypesForFormat): Helper function for ClipboardWin::types (WebCore::ClipboardWin::types): (WebCore::ClipboardWin::setDragImage): (WebCore::ClipboardWin::setDragImageElement): General setters, match behaviour of WebKit/Mac (WebCore::ClipboardWin::createDragImage): Creates a drag image for a DOM specified Image is specified can't currently generate an image for an arbitrary element (WebCore::imageToMarkup): Wraps a url in an img tag (WebCore::ClipboardWin::declareAndWriteDragImage): (WebCore::ClipboardWin::writeURL): (WebCore::ClipboardWin::writeRange): (WebCore::ClipboardWin::hasData): Implement Clipboard required by DragController. Provides read/write DOM Clipboard implementation for dragging, read only when accessing system clipboard.


  • platform/win/ClipboardWin.h: (WebCore::ClipboardWin::dataObject): Provide an accessor for the dataObject


  • platform/win/DragDataWin.cpp: (WebCore::urlWFormat): (WebCore::urlFormat): (WebCore::plainTextFormat): (WebCore::plainTextWFormat): (WebCore::texthtmlFormat): (WebCore::htmlFormat): (WebCore::getURL): (WebCore::DragData::asURL): (WebCore::getPlainText): (WebCore::DragData::asPlainText): (WebCore::DragData::asFragment): Refactoring and removing of a few static modifiers to allow sharing with Clipboard


  • platform/win/DragImageWin.cpp: (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::allocImage): (WebCore::createCgContextFromBitmap): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage): Implement DragImage functions


  • platform/win/EditorWin.cpp: (WebCore::Editor::newGeneralClipboard): Creating a Clipboard that wraps the system clipboard


  • platform/win/PasteboardWin.cpp: (WebCore::createGlobalData): (WebCore::markupToCF_HTML): (WebCore::urlToMarkup): (WebCore::replaceNBSP): removing 'static'


  • platform/win/WCDataObject.cpp: Added. (WebCore::WCEnumFormatEtc::WCEnumFormatEtc): (WebCore::WCEnumFormatEtc::QueryInterface): (WebCore::WCEnumFormatEtc::AddRef): (WebCore::WCEnumFormatEtc::Release): (WebCore::WCEnumFormatEtc::Next): (WebCore::WCEnumFormatEtc::Skip): (WebCore::WCEnumFormatEtc::Reset): (WebCore::WCEnumFormatEtc::Clone): (WebCore::WCDataObject::createInstance): (WebCore::WCDataObject::WCDataObject): (WebCore::WCDataObject::~WCDataObject): (WebCore::WCDataObject::QueryInterface): (WebCore::WCDataObject::AddRef): (WebCore::WCDataObject::Release): (WebCore::WCDataObject::GetData): (WebCore::WCDataObject::GetDataHere): (WebCore::WCDataObject::QueryGetData): (WebCore::WCDataObject::GetCanonicalFormatEtc): (WebCore::WCDataObject::SetData): (WebCore::WCDataObject::CopyMedium): (WebCore::WCDataObject::EnumFormatEtc): (WebCore::WCDataObject::DAdvise): (WebCore::WCDataObject::DUnadvise): (WebCore::WCDataObject::EnumDAdvise): (WebCore::WCDataObject::clearData): Copied from SDataObject in the App createInstance and clearData are the only new functions. clearData removes any entries in the object with a specified CLIPFORMAT. Have also made a few error and memory handling changes suggested by Steve and Ada
  • platform/win/WCDataObject.h: Added. Header for the above


3:42 PM Changeset in webkit [19809] by sullivan
  • 4 edits in trunk/WebCore

Reviewed by Kevin and Adele


  • fixed <rdar://problem/4129417> Need final art for textarea's resize corner


This probably broke some layout pixel tests since the image changed. I'm going to
track those down in a moment (non-trivial since there are a bunch failing for other
reasons).

  • Resources/textAreaResizeCorner.tiff: new art
  • Resources/deleteButton.tiff:
  • Resources/deleteButtonPressed.tiff: these got smaller when I ran compress-tiffs on this directory
3:40 PM Changeset in webkit [19808] by oliver
  • 7 edits in trunk/WebCore

2007-02-22 Oliver Hunt <​oliver@apple.com>

Reviewed by Ada, Lou and Steve.

Moving basic components of ClipboardMac to Clipboard,
last of the basic common code merge will come later (namely setting the
drag element/image).


Tidying up in DragController including a few bad PassRefPtr uses and
removing unnecessary accessors. Also initialise fields properly to
fix <rdar:/problems/5014889>

  • dom/Clipboard.cpp: (WebCore::Clipboard::Clipboard): New constructor


  • dom/Clipboard.h: (WebCore::Clipboard::isForDragging): (WebCore::Clipboard::dragLocation): (WebCore::Clipboard::dragImage): (WebCore::Clipboard::dragImageElement): Exposing common data


  • page/DragController.cpp: (WebCore::DragController::DragController): Initialise m_isHandlingDrag (oops) (WebCore::documentFragmentFromDragData): (WebCore::DragController::tryDocumentDrag): Fixing PassRefPtr misuse (WebCore::DragController::canProcessDrag): (WebCore::DragController::startDrag): (WebCore::DragController::doSystemDrag): Make sure we're using the correct coordinate space


  • page/EventHandler.cpp: (WebCore::EventHandler::handleDrag): Reset drag source correctly


  • platform/mac/ClipboardMac.h:
  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::ClipboardMac): update constructor to use new Clipboard constructor
3:07 PM Changeset in webkit [22984] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adele.

Make sure we always paint the right size search results icon.

3:02 PM Changeset in webkit [22983] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

3:00 PM Changeset in webkit [19807] by sfalken
  • 1 copy in tags/Safari-521.35.2b

New tag.

2:20 PM Changeset in webkit [19806] by adele
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for <rdar://problem/5014970> 9A374: Tabs don't work in the message body

  • fast/events/keypress-insert-tab-expected.txt: Added.
  • fast/events/keypress-insert-tab.html: Added.

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/5014970> 9A374: Tabs don't work in the message body

Test: fast/events/keypress-insert-tab.html

  • page/EventHandler.cpp: (WebCore::EventHandler::defaultTextInputEventHandler): If the defaultTabEventHandler doesn't handle the event, then go on to the insertText case.

WebKitTools:

Reviewed by Darin.

Added option in layoutTestController to setTabKeyCyclesThroughElements, so we
can test <rdar://problem/5014970> 9A374: Tabs don't work in the message body

  • DumpRenderTree/DumpRenderTree.m: (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController setTabKeyCyclesThroughElements:]):
2:10 PM Changeset in webkit [19805] by ggaren
  • 3 edits in trunk/JavaScriptGlue

Reviewed by Darin Adler.


Fixed <rdar://problem/4942528> Installer.app Stuck "Examining additional
volumes..."


The problem was that JavaScriptGlue held a JSObject in a static pointer
without protecting it from garbage collection.


sUserObjectPrototypeImp = new UserObjectPrototypeImp();
static ProtectedPtr<UserObjectPrototypeImp> protectPrototype; valiant, brave, but useless

Through an interesting comedy of errors, this object would be collected
and then assigned as the prototype of another object allocated at the
same address, thus becoming its own prototype. (See ​http://www.ziplo.com/grandpa.htm
for further explanation of this phenomenon.) Hence the infinte loop in
property lookup.


The solution is equally humorous: all of this code was completely useless --
it only served to create an empty object in the prototype chain -- so
I just removed it.

  • UserObjectImp.cpp: (UserObjectImp::UserObjectImp):
  • UserObjectImp.h:
1:55 PM Changeset in webkit [19804] by brmorris
  • 4 edits in S60/trunk/WebKit

naguo, reviewed by sachin

DESC: Open while downloading UI setting functionality is not working correctly SCHY-6YFQ66
​http://bugs.webkit.org/show_bug.cgi?id=12846

1:25 PM Changeset in webkit [19803] by brmorris
  • 2 edits in S60/trunk/WebCore

hongzhao, reviewed by Zalan, merged by mbradley++

DESC: merge of r19802 to s60 trunk. Cache memory collector is not initialized in 3.2 HZHO-6YMQCK
Fix: Initialize the initial size of cache memory collector after create it.
​http://bugs.webkit.org/show_bug.cgi?id=12844

1:22 PM Changeset in webkit [19802] by brmorris
  • 2 edits in S60/branches/3.1m/WebCore

hongzhao, Reviewed by Zalan

DESC: [S60] Cache memory collector is not initialized in 3.1m HZHO-6YMQCK
Fix: Initialze the initial size of cache mem collector after create it.
​http://bugs.webkit.org/show_bug.cgi?id=12844

1:16 PM Changeset in webkit [19801] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

sareen by yongjun

DESC: Merge of r19655 to s60/3.1m. Selection list not shown correctly in www.elisa.fi HMNN-6XQJMX
​http://bugs.webkit.org/show_bug.cgi?id=12719

1:00 PM Changeset in webkit [19800] by thatcher
  • 8 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4948887> REGRESSION: Correct differences in public DOM API that inadvertently changed in Leopard

  • bindings/objc/PublicDOMInterfaces.h: Changes return types for two size properties, adds deprecated DOMEventTarget methods.
  • bindings/scripts/CodeGeneratorObjC.pm: Fixed public API checking for protocols, adds support for ConvertToString.
  • dom/EventTarget.idl: Marks addEventListener and removeEventListener with the OldStyleObjC attribute.
  • html/HTMLBaseFontElement.idl: Changes the size property to a DOMString for ObjC only.
  • html/HTMLInputElement.idl: Changes the size property to a DOMString for ObjC only.
  • html/HTMLOptionsCollection.idl: Changes the length property to be unsigned.
12:50 PM Changeset in webkit [19799] by adele
  • 2 edits in trunk/WebCore

Reviewed by John.

Fix <rdar://problem/5016969> REGRESSION: "Check Spelling As You Type" context menu item is never checked

  • platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded): Set shouldCheck for ContextMenuItemTagCheckSpellingWhileTyping.
12:19 PM Changeset in webkit [19798] by ggaren
  • 87 edits in trunk

LayoutTests:

Used svn merge -r19786:19785 to roll out previous SVG results produced by
hack to work around SVG painting issue in DRT.


The new work-around preserves the old SVG results -- both text and pixel.
This should fix the ~400 new pixel failures introduced in r19786.

  • svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt:
  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
  • svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
  • svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
  • svg/W3C-SVG-1.1/interact-events-01-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
  • svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-01-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-use-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-02-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-03-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
  • svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-deco-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt:
  • svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-text-03-b-expected.txt:
  • svg/W3C-SVG-1.1/text-text-08-b-expected.txt:
  • svg/W3C-SVG-1.1/text-tref-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
  • svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-ws-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-ws-02-t-expected.txt:
  • svg/carto.net/button-expected.txt:
  • svg/carto.net/colourpicker-expected.txt:
  • svg/carto.net/combobox-expected.txt:
  • svg/carto.net/scrollbar-expected.txt:
  • svg/carto.net/selectionlist-expected.txt:
  • svg/carto.net/slider-expected.txt:
  • svg/carto.net/tabgroup-expected.txt:
  • svg/carto.net/textbox-expected.txt:
  • svg/carto.net/window-expected.txt:
  • svg/custom/gradient-stop-style-change-expected.txt:
  • svg/custom/js-late-clipPath-and-object-creation-expected.txt:
  • svg/custom/js-late-clipPath-creation-expected.txt:
  • svg/custom/js-late-gradient-and-object-creation-expected.txt:
  • svg/custom/non-opaque-filters-expected.txt:
  • svg/custom/pointer-events-text-expected.txt:
  • svg/custom/text-clip-expected.txt:
  • svg/custom/text-filter-expected.txt:
  • svg/custom/text-image-opacity-expected.txt:
  • svg/custom/text-repaint-including-stroke-expected.txt:
  • svg/custom/use-elementInstance-event-target-expected.txt:
  • svg/custom/use-on-text-expected.txt:

WebKitTools:

Used svn merge -r19786:19785 to roll out previous hack to work around
SVG painting issue in DRT.


Implemented new work-around, which makes --paint paint *after* dumping
the render tree instead of before, so that painting doesn't influence
the SVG render tree.

This should fix the ~400 new pixel failures introduced in r19786.

  • DumpRenderTree/DumpRenderTree.m: (dump):
  • Scripts/run-webkit-tests:
11:57 AM Changeset in webkit [19797] by antti
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.


  • fast/forms/select-initial-position-expected.checksum: Added.
  • fast/forms/select-initial-position-expected.png: Added.
  • fast/forms/select-initial-position-expected.txt: Added.
  • fast/forms/select-initial-position.html: Added.

WebCore:

Reviewed by Darin.


Initiate scroll when selected <option> is added to <select>.

  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::insertedIntoDocument):
  • html/HTMLOptionElement.h:
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::notifyOptionSelected): (WebCore::HTMLSelectElement::updateListBoxSelection): (WebCore::HTMLSelectElement::scrollToSelection):
  • html/HTMLSelectElement.h:
11:32 AM Changeset in webkit [19796] by zack
  • 2 edits in trunk/WebCore

Fix sites with fixed positioned backgrounds. (my blog =) )
r=Lars,George

11:18 AM Changeset in webkit [19795] by ggaren
  • 2 edits in trunk/WebKitTools

Resetting --leaks mode default to run 1000 tests at a time because setting it
to 750 didn't stop the stack logging related crashes, and running more tests
at a time is faster. The crashes seem to be a real bug in stack logging,
not an out of memory condition.

  • Scripts/run-webkit-tests:
9:38 AM Changeset in webkit [19794] by sullivan
  • 3 edits in trunk/WebKit

Reviewed by Darin


Removed some unused keyView-related code that I happened to run across.
Replacement code is now in WebChromeClient.

  • WebCoreSupport/WebFrameBridge.h:
  • WebCoreSupport/WebFrameBridge.mm: removed unused stuff
8:52 AM Changeset in webkit [19793] by zack
  • 4 edits in trunk/WebKitQt

Fixing the default scroll offset, cleaning
up private methods and making the default
look not use any frames.
r=Lars

8:17 AM Changeset in webkit [19792] by zack
  • 9 edits
    2 deletes in trunk

Properly implement canvas/scrollview's. Get
rid of ScrollViewCanvasQt and replace it with
a tailor abstractscrollview (now in qwebframe).
Scrolling of pages is finally completely smooth :)
r=Lars

7:59 AM Changeset in webkit [19791] by weinig
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

Fix ARM-specific alignment problem in FastMalloc
​http://bugs.webkit.org/show_bug.cgi?id=12841

  • wtf/FastMalloc.cpp: Modify how pageheap_memory is declared to ensure proper alignment on architectures such as ARM
7:45 AM Changeset in webkit [19790] by weinig
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

This patch also fixes a bug where using the arrow keys while
the suggestion popup is open moves the caret instead of changing the
selection in the popup (for up/down) or accepting the selection and
closing the popup (for left/right).

  • WebView/WebHTMLView.mm: (-[WebHTMLView keyDown:]): Changed to close the popup only if it was open before the current event, so that the Option-Esc that opens the popup will not close it immediately. (-[WebHTMLView _interceptEditingKeyEvent:]): Give the completion popup a chance to intercept keydown events. (-[WebTextCompleteController popupWindowIsOpen]): Added. Returns whether the suggestion popup is open.
7:34 AM Changeset in webkit [19789] by weinig
  • 2 edits in trunk/WebKit

Reviewed by Mark (age 21).

  • WebView/WebHTMLView.mm: (-[WebTextCompleteController _buildUI]): Uncommented the call to the NSWindow SPI that forces the scroll bar to look active. Also replaced a call to the deprecated NSTableView method setAutoresizesAllColumnsToFit: with the new method setColumnAutoresizingStyle: to eliminate console spew.

Feb 21, 2007:

11:20 PM Changeset in webkit [19788] by kjk
  • 6 edits in trunk/WebCore

Reviewed by Adam Roben.

Improve notImplemented() macro for gdk. Rename to notImplementedGdk() to
give it a unique name (so that it doesn't clash with notImplemented()
for other platforms).
Make it print a given warning only once, so that frequently called
functions don't clutter the output.
Don't print the warning if DISABLE_NI_WARNING env variable is set.

  • loader/gdk/FrameLoaderClientGdk.cpp: (WebCore::FrameLoaderClientGdk::dispatchDidReceiveAuthenticationChallenge): (WebCore::FrameLoaderClientGdk::dispatchDidCancelAuthenticationChallenge): (WebCore::FrameLoaderClientGdk::dispatchWillSendRequest): (WebCore::FrameLoaderClientGdk::assignIdentifierToInitialRequest): (WebCore::FrameLoaderClientGdk::createPlugin): (WebCore::FrameLoaderClientGdk::createFrame): (WebCore::FrameLoaderClientGdk::redirectDataToPlugin): (WebCore::FrameLoaderClientGdk::createJavaAppletWidget): (WebCore::FrameLoaderClientGdk::objectContentType): (WebCore::FrameLoaderClientGdk::overrideMediaType): (WebCore::FrameLoaderClientGdk::windowObjectCleared): (WebCore::FrameLoaderClientGdk::hasWebView): (WebCore::FrameLoaderClientGdk::hasFrameView): (WebCore::FrameLoaderClientGdk::frameLoadCompleted): (WebCore::FrameLoaderClientGdk::saveViewStateToItem): (WebCore::FrameLoaderClientGdk::restoreViewState): (WebCore::FrameLoaderClientGdk::privateBrowsingEnabled): (WebCore::FrameLoaderClientGdk::makeDocumentView): (WebCore::FrameLoaderClientGdk::makeRepresentation): (WebCore::FrameLoaderClientGdk::forceLayout): (WebCore::FrameLoaderClientGdk::forceLayoutForNonHTML): (WebCore::FrameLoaderClientGdk::setCopiesOnScroll): (WebCore::FrameLoaderClientGdk::detachedFromParent1): (WebCore::FrameLoaderClientGdk::detachedFromParent2): (WebCore::FrameLoaderClientGdk::detachedFromParent3): (WebCore::FrameLoaderClientGdk::detachedFromParent4): (WebCore::FrameLoaderClientGdk::loadedFromPageCache): (WebCore::FrameLoaderClientGdk::dispatchDidHandleOnloadEvents): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebCore::FrameLoaderClientGdk::dispatchDidCancelClientRedirect): (WebCore::FrameLoaderClientGdk::dispatchWillPerformClientRedirect): (WebCore::FrameLoaderClientGdk::dispatchDidChangeLocationWithinPage): (WebCore::FrameLoaderClientGdk::dispatchWillClose): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveIcon): (WebCore::FrameLoaderClientGdk::dispatchDidStartProvisionalLoad): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveTitle): (WebCore::FrameLoaderClientGdk::dispatchDidCommitLoad): (WebCore::FrameLoaderClientGdk::dispatchDidFinishDocumentLoad): (WebCore::FrameLoaderClientGdk::dispatchDidFirstLayout): (WebCore::FrameLoaderClientGdk::dispatchShow): (WebCore::FrameLoaderClientGdk::cancelPolicyCheck): (WebCore::FrameLoaderClientGdk::dispatchDidLoadMainResource): (WebCore::FrameLoaderClientGdk::revertToProvisionalState): (WebCore::FrameLoaderClientGdk::clearUnarchivingState): (WebCore::FrameLoaderClientGdk::willChangeTitle): (WebCore::FrameLoaderClientGdk::finishedLoading): (WebCore::FrameLoaderClientGdk::finalSetupForReplace): (WebCore::FrameLoaderClientGdk::setDefersLoading): (WebCore::FrameLoaderClientGdk::isArchiveLoadPending): (WebCore::FrameLoaderClientGdk::cancelPendingArchiveLoad): (WebCore::FrameLoaderClientGdk::clearArchivedResources): (WebCore::FrameLoaderClientGdk::canHandleRequest): (WebCore::FrameLoaderClientGdk::canShowMIMEType): (WebCore::FrameLoaderClientGdk::representationExistsForURLScheme): (WebCore::FrameLoaderClientGdk::generatedMIMETypeForURLScheme): (WebCore::FrameLoaderClientGdk::provisionalLoadStarted): (WebCore::FrameLoaderClientGdk::didFinishLoad): (WebCore::FrameLoaderClientGdk::prepareForDataSourceReplacement): (WebCore::FrameLoaderClientGdk::setTitle): (WebCore::FrameLoaderClientGdk::setDocumentViewFromPageCache): (WebCore::FrameLoaderClientGdk::dispatchDidReceiveContentLength): (WebCore::FrameLoaderClientGdk::dispatchDidFinishLoading): (WebCore::FrameLoaderClientGdk::dispatchDidFailLoading): (WebCore::FrameLoaderClientGdk::dispatchDidLoadResourceFromMemoryCache): (WebCore::FrameLoaderClientGdk::dispatchDidFailProvisionalLoad): (WebCore::FrameLoaderClientGdk::dispatchDidFailLoad): (WebCore::FrameLoaderClientGdk::download): (WebCore::FrameLoaderClientGdk::cancelledError): (WebCore::FrameLoaderClientGdk::cannotShowURLError): (WebCore::FrameLoaderClientGdk::interruptForPolicyChangeError): (WebCore::FrameLoaderClientGdk::cannotShowMIMETypeError): (WebCore::FrameLoaderClientGdk::fileDoesNotExistError): (WebCore::FrameLoaderClientGdk::shouldFallBack): (WebCore::FrameLoaderClientGdk::willUseArchive): (WebCore::FrameLoaderClientGdk::saveDocumentViewToPageCache): (WebCore::FrameLoaderClientGdk::canCachePage): (WebCore::FrameLoaderClientGdk::dispatchCreatePage): (WebCore::FrameLoaderClientGdk::dispatchUnableToImplementPolicy): (WebCore::FrameLoaderClientGdk::setMainDocumentError): (WebCore::FrameLoaderClientGdk::startDownload): (WebCore::FrameLoaderClientGdk::updateGlobalHistoryForStandardLoad): (WebCore::FrameLoaderClientGdk::updateGlobalHistoryForReload): (WebCore::FrameLoaderClientGdk::shouldGoToHistoryItem):
  • page/gdk/EventHandlerGdk.cpp: (WebCore::EventHandler::passMouseDownEventToWidget): (WebCore::EventHandler::eventActivatedView): (WebCore::EventHandler::passSubframeEventToSubframe): (WebCore::EventHandler::passWheelEventToWidget): (WebCore::EventHandler::createDraggingClipboard):
  • platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::shouldDeleteRange): (WebCore::EditorClientGdk::isContinuousSpellCheckingEnabled): (WebCore::EditorClientGdk::isGrammarCheckingEnabled): (WebCore::EditorClientGdk::spellCheckerDocumentTag): (WebCore::EditorClientGdk::shouldBeginEditing): (WebCore::EditorClientGdk::shouldEndEditing): (WebCore::EditorClientGdk::shouldInsertText): (WebCore::EditorClientGdk::shouldChangeSelectedRange): (WebCore::EditorClientGdk::shouldApplyStyle): (WebCore::EditorClientGdk::didBeginEditing): (WebCore::EditorClientGdk::respondToChangedContents): (WebCore::EditorClientGdk::didEndEditing): (WebCore::EditorClientGdk::didWriteSelectionToPasteboard): (WebCore::EditorClientGdk::didSetSelectionTypesForPasteboard): (WebCore::EditorClientGdk::selectWordBeforeMenuEvent): (WebCore::EditorClientGdk::isEditable): (WebCore::EditorClientGdk::registerCommandForUndo): (WebCore::EditorClientGdk::registerCommandForRedo): (WebCore::EditorClientGdk::clearUndoRedoOperations): (WebCore::EditorClientGdk::canUndo): (WebCore::EditorClientGdk::canRedo): (WebCore::EditorClientGdk::undo): (WebCore::EditorClientGdk::redo): (WebCore::EditorClientGdk::shouldInsertNode): (WebCore::EditorClientGdk::pageDestroyed): (WebCore::EditorClientGdk::smartInsertDeleteEnabled): (WebCore::EditorClientGdk::toggleContinuousSpellChecking): (WebCore::EditorClientGdk::textFieldDidBeginEditing): (WebCore::EditorClientGdk::textFieldDidEndEditing): (WebCore::EditorClientGdk::textDidChangeInTextField): (WebCore::EditorClientGdk::doTextFieldCommandFromEvent): (WebCore::EditorClientGdk::textWillBeDeletedInTextField): (WebCore::EditorClientGdk::textDidChangeInTextArea):
  • platform/gdk/RenderThemeGdk.cpp: (WebCore::RenderThemeGdk::setCheckboxSize): (WebCore::RenderThemeGdk::setRadioSize): (WebCore::RenderThemeGdk::adjustTextFieldStyle):
  • platform/gdk/TemporaryLinkStubs.cpp: (FrameView::updateBorder): (Widget::setEnabled): (Widget::isEnabled): (Widget::focusPolicy): (Widget::enableFlushDrawing): (Widget::disableFlushDrawing): (Widget::lockDrawingFocus): (Widget::unlockDrawingFocus): (Widget::removeFromParent): (Widget::paint): (Widget::setIsSelected): (Widget::invalidate): (Widget::invalidateRect): (PlatformMouseEvent::PlatformMouseEvent): (WebCore::findNextSentenceFromIndex): (WebCore::findSentenceBoundary): (WebCore::findNextWordFromIndex): (ChromeClientGdk::chromeDestroyed): (ChromeClientGdk::windowRect): (ChromeClientGdk::setWindowRect): (ChromeClientGdk::pageRect): (ChromeClientGdk::scaleFactor): (ChromeClientGdk::focus): (ChromeClientGdk::unfocus): (ChromeClientGdk::createWindow): (ChromeClientGdk::createModalDialog): (ChromeClientGdk::show): (ChromeClientGdk::canRunModal): (ChromeClientGdk::runModal): (ChromeClientGdk::setToolbarsVisible): (ChromeClientGdk::toolbarsVisible): (ChromeClientGdk::setStatusbarVisible): (ChromeClientGdk::statusbarVisible): (ChromeClientGdk::setScrollbarsVisible): (ChromeClientGdk::scrollbarsVisible): (ChromeClientGdk::setMenubarVisible): (ChromeClientGdk::menubarVisible): (ChromeClientGdk::setResizable): (ChromeClientGdk::closeWindowSoon): (ChromeClientGdk::canTakeFocus): (ChromeClientGdk::takeFocus): (ChromeClientGdk::canRunBeforeUnloadConfirmPanel): (ChromeClientGdk::addMessageToConsole): (ChromeClientGdk::runBeforeUnloadConfirmPanel): (ChromeClientGdk::runJavaScriptAlert): (ChromeClientGdk::runJavaScriptConfirm): (ChromeClientGdk::runJavaScriptPrompt): (ChromeClientGdk::setStatusbarText): (ChromeClientGdk::shouldInterruptJavaScript): (ChromeClientGdk::tabsToLinks): (ChromeClientGdk::windowResizerRect): (ChromeClientGdk::addToDirtyRegion): (ChromeClientGdk::scrollBackingStore): (ChromeClientGdk::updateBackingStore): (PlugInInfoStore::createPluginInfoForPluginAtIndex): (PlugInInfoStore::pluginCount): (WebCore::PlugInInfoStore::supportsMIMEType): (WebCore::refreshPlugins): (SearchPopupMenu::saveRecentSearches): (SearchPopupMenu::loadRecentSearches): (SearchPopupMenu::SearchPopupMenu): (PlatformScrollbar::PlatformScrollbar): (PlatformScrollbar::~PlatformScrollbar): (PlatformScrollbar::setEnabled): (PlatformScrollbar::paint): (PlatformScrollbar::updateThumbPosition): (PlatformScrollbar::updateThumbProportion): (PlatformScrollbar::setRect): (FileChooser::FileChooser): (FileChooser::~FileChooser): (FileChooser::openFileChooser): (FileChooser::basenameForWidth): (ResourceHandle::willLoadFromCache): (ResourceHandle::loadsBlocked): (ResourceHandle::loadResourceSynchronously): (Icon::Icon): (Icon::~Icon): (Icon::newIconForFile): (Icon::paint): (Font::drawComplexText): (Font::floatWidthForComplexText): (Font::offsetForPositionForComplexText): (PageCache::close): (Editor::ignoreSpelling): (Editor::learnSpelling): (Editor::isSelectionUngrammatical): (Editor::isSelectionMisspelled): (Editor::guessesForMisspelledSelection): (Editor::guessesForUngrammaticalSelection): (Editor::markMisspellingsAfterTypingToPosition): (Editor::newGeneralClipboard): (Pasteboard::generalPasteboard): (Pasteboard::writeSelection): (Pasteboard::writeURL): (Pasteboard::writeImage): (Pasteboard::clear): (Pasteboard::canSmartReplace): (Pasteboard::documentFragment): (Pasteboard::plainText): (Pasteboard::Pasteboard): (Pasteboard::~Pasteboard): (ContextMenu::ContextMenu): (ContextMenu::~ContextMenu): (ContextMenu::appendItem): (ContextMenuItem::ContextMenuItem): (ContextMenuItem::~ContextMenuItem): (ContextMenuItem::releasePlatformDescription): (ContextMenuItem::type): (ContextMenuItem::setType): (ContextMenuItem::action): (ContextMenuItem::setAction): (ContextMenuItem::title): (ContextMenuItem::setTitle): (ContextMenuItem::platformSubMenu): (ContextMenuItem::setSubMenu): (ContextMenuItem::setChecked): (ContextMenuItem::setEnabled): (WebCore::supportedKeySizes): (WebCore::systemBeep): (WebCore::userIdleTime):
10:40 PM Changeset in webkit [19787] by staikos
  • 2 adds in trunk/WebKitQt/WebCoreSupport

Add missing files from last commit

10:17 PM Changeset in webkit [19786] by ggaren
  • 86 edits in trunk

LayoutTests:

Reviewed by Adam Roben.


Updated results to new, more correct values produced by painting SVGs
before dumping their render trees.

  • svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt:
  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
  • svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
  • svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
  • svg/W3C-SVG-1.1/interact-events-01-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
  • svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-01-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-use-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-02-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-03-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
  • svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-deco-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt:
  • svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-text-03-b-expected.txt:
  • svg/W3C-SVG-1.1/text-text-08-b-expected.txt:
  • svg/W3C-SVG-1.1/text-tref-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
  • svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-ws-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-ws-02-t-expected.txt:
  • svg/carto.net/button-expected.txt:
  • svg/carto.net/colourpicker-expected.txt:
  • svg/carto.net/combobox-expected.txt:
  • svg/carto.net/scrollbar-expected.txt:
  • svg/carto.net/selectionlist-expected.txt:
  • svg/carto.net/slider-expected.txt:
  • svg/carto.net/tabgroup-expected.txt:
  • svg/carto.net/textbox-expected.txt:
  • svg/carto.net/window-expected.txt:
  • svg/custom/gradient-stop-style-change-expected.txt:
  • svg/custom/js-late-clipPath-and-object-creation-expected.txt:
  • svg/custom/js-late-clipPath-creation-expected.txt:
  • svg/custom/js-late-gradient-and-object-creation-expected.txt:
  • svg/custom/non-opaque-filters-expected.txt:
  • svg/custom/pointer-events-text-expected.txt:
  • svg/custom/text-clip-expected.txt:
  • svg/custom/text-filter-expected.txt:
  • svg/custom/text-image-opacity-expected.txt:
  • svg/custom/text-repaint-including-stroke-expected.txt:
  • svg/custom/use-elementInstance-event-target-expected.txt:
  • svg/custom/use-on-text-expected.txt:

WebKitTools:

Reviewed by Adam Roben.


Added hack to force painting when running an SVG test. This is a work-around
for ​http://bugs.webkit.org/show_bug.cgi?id=12849 SVG renderers update at
paint time instead of style resolution time.

We need this so that --leaks mode, which always paints, doesn't appear to
fail SVG tests. We also need this if we ever want to test style application
in SVG, since many SVGs don't apply style to their renderers until they paint.

  • Scripts/run-webkit-tests:
8:31 PM Changeset in webkit [22982] by beidson
  • 2 edits in branches/WindowsMerge/WebKitWin

Build fix

7:31 PM Changeset in webkit [22981] by beidson
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Anders' rubberstamp


  • WebDownload.cpp: (WebDownload::initToResumeWithBundle): Make a copy of the string we truncate so it doesn't affect the original
7:12 PM Changeset in webkit [19785] by weinig
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

​http://bugs.webkit.org/show_bug.cgi?id=12820
REGRESSION (r19706): Caret not painted after popup, failing editing/pasteboard/4641033

add test for caret before <select> case too

  • editing/selection/caret-before-select-expected.checksum: Added.
  • editing/selection/caret-before-select-expected.png: Added.
  • editing/selection/caret-before-select-expected.txt: Added.
  • editing/selection/caret-before-select.html: Added.

WebCore:

Reviewed by Hyatt.

Yet another attempt to figure out exactly who should paint the caret.

  • editing/SelectionController.cpp: (WebCore::SelectionController::isInsideNode):
  • editing/SelectionController.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintCaret):
7:07 PM Changeset in webkit [22980] by beidson
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam

<rdar://problem/4964763> - Hookup resume downloads on the engine side


NOTE: Resume downloads are broken in the current ChickenCat - this functionality requires
a custom ToT CFNetwork as of CFNetwork r3372, or will require CFNetwork 172 or later


  • WebDownload.cpp: (WebDownload::initWithRequest): Changed some logging, plugged some potential leaks (WebDownload::initToResumeWithBundle): Added a real implementation - this now works! (WebDownload::didFinish): Added some logging and fixed up some lifetime issues (extractResumeDataFromBundle): Renamed to imply the modification of the file. Truncate the resume data from the file once it is extracted
6:58 PM Changeset in webkit [19784] by weinig
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/dynamic/staticY-marking-parents-regression-expected.checksum: Added.
  • fast/dynamic/staticY-marking-parents-regression-expected.png: Added.
  • fast/dynamic/staticY-marking-parents-regression-expected.txt: Added.
  • fast/dynamic/staticY-marking-parents-regression.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/dynamic/staticY-marking-parents-regression.html

Changed calls to setChildNeedsLayout(true) during layout to
setChildNeedsLayout(true, false). Prior to r19148, the default behavior
of marking containers did not matter because the caller was the container
and was already marked, but r19148 added marking of the parent of
objects with static Y, which can be different from the caller and not
necessarily marked already.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::collapseMargins): (WebCore::RenderBlock::clearFloatsIfNeeded): (WebCore::RenderBlock::layoutBlockChildren):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::setStaticY):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox):
6:54 PM Changeset in webkit [19783] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Dave Harrison

<rdar://problem/5014313> - Crash in FrameLoader::restoreScrollPositionAndViewState()
after regaining network connection

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::restoreScrollPositionAndViewState): Leave an assertion for debug build exploration, but gracefully handle the release build case
5:14 PM Changeset in webkit [19782] by thatcher
  • 2 edits in trunk/WebCore

Rubber-stamped by Darin.

  • bindings/objc/PublicDOMInterfaces.h: Add missing classes that are really public. Also adds the deprecated selector for getComputedStyle: on DOMDocument.
4:30 PM Changeset in webkit [19781] by andersca
  • 3 edits in trunk/WebKitLibraries

Add new version with WKCGContextIsBitmapContext.


  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
4:10 PM Changeset in webkit [19780] by justing
  • 11 edits in trunk

LayoutTests:

Reviewed by john

<rdar://problem/5012665>
Removing indent from list moves the caret to the line below

No new layout tests needed because the new results
for these tests and the removed FIXMEs cover the bug fix:

  • editing/execCommand/indent-list-item.html:
  • editing/execCommand/indent-list-item-expected.checksum:
  • editing/execCommand/indent-list-item-expected.png:
  • editing/execCommand/indent-list-item-expected.txt:
  • editing/execCommand/remove-list-1.html:
  • editing/execCommand/remove-list-1-expected.checksum:
  • editing/execCommand/remove-list-1-expected.png:
  • editing/execCommand/remove-list-1-expected.txt:

WebCore:

Reviewed by john


<rdar://problem/5012665>
Removing indent from list moves the caret to the line below

Selection preservation during indent, outdent and list
operations uses rangeFromLocationAndLength. Ranges returned
by rangeFromLocationAndLength were incorrect for locations
just before the line breaks that are emitted after blocks.
This is because TextIterator emitted bad ranges for these line
breaks (ranges that started and ended *after* the block).
The fix corrects the start but not the end. This is acceptible
because there is code in rangeFromLocationAndLength that corrects
the ends of runs using the start of the run and VisiblePosition
creation.


  • editing/TextIterator.cpp: (WebCore::TextIterator::exitNode): Emit a position *inside* the block, after its contents.
2:56 PM Changeset in webkit [19779] by ggaren
  • 2 edits in trunk/WebKitTools

Reduced --leaks mode to running only 750 tests at a time, in the hopes
of fixing intermittent crasher that may be caused by out of memory
conditions.

  • Scripts/run-webkit-tests:
2:32 PM Changeset in webkit [19778] by ggaren
  • 3 edits in trunk/WebKitTools

Reviewed by Darin Adler.

Made DRT paint when running run-webkit-tests in --leaks mode, to check
for painting leaks.

  • DumpRenderTree/DumpRenderTree.m: Removed some "NO" initializations, since that's the default for statics. (dumpRenderTree): Added --paint command line option, which specifies that DRT should paint at the end of every test. (displayWebView): New function, called by dump() and -[LayoutTestController display].
  • Scripts/run-webkit-tests: Use the --paint command line option when checking for leaks.
  • Scripts/run-webkit-tests: Added a new, painting leak to the ignore list. Removed stale comment about THRD leaks -- we now ignore them reliably.
2:06 PM Changeset in webkit [22979] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Adele.

Updated for SafariTheme changes.

1:52 PM Changeset in webkit [22978] by adele
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

  • WebCore.vcproj/WebCore.vcproj: Added JSHTMLSelectElementCustom.h
1:49 PM Changeset in webkit [19777] by adele
  • 7 edits
    3 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for <rdar://problem/4999030> Indexing into select element to get to items in the options collection is broken

  • fast/forms/select-index-setter-expected.txt: Added.
  • fast/forms/select-index-setter.html: Added.

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/4999030> Indexing into select element to get to items in the options collection is broken

Test: fast/forms/select-index-setter.html

Added indexSetter for HTMLSelectElement.

  • WebCore.xcodeproj/project.pbxproj: Added JSHTMLSelectElementCustom.h
  • bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::indexSetter): Moved code to selectIndexSetter so it can be shared between these classes.
  • bindings/js/JSHTMLSelectElementCustom.cpp: (WebCore::selectIndexSetter): Added. Moved from JSHTMLOptionsCollection::indexSetter. (WebCore::JSHTMLSelectElement::indexSetter): Calls selectIndexSetter.
  • bindings/js/JSHTMLSelectElementCustom.h: Added.
  • html/HTMLSelectElement.idl: Added HasCustomIndexSetter keyword.
  • bindings/scripts/CodeGeneratorJS.pm: When generating "put" methods, if the propertyName is a number, call the indexSetter first, and then call the version of lookupPut that will also try to use the parent's lookup table. This matches the order of our old code, before we autogenerated the JSHTMLSelectElement class.
12:48 PM Changeset in webkit [19776] by ggaren
  • 2 edits in trunk/WebKitTools

Tools tweak. No review necessary.


  • Scripts/parse-malloc-history: Enabled multiple merge-regexp command line arguments. Changed command line argument variables from special implicit no-op values to specific empty values that we test explicitly.
12:00 PM Changeset in webkit [19775] by thatcher
  • 2 edits in trunk/WebKitTools

Reviewed by Tim H.

Bug 12834: Drosera should remember scroll position of open files like Xcode
​http://bugs.webkit.org/show_bug.cgi?id=12834

  • Drosera/debugger.js: Implemented scrolling memory
10:55 AM Changeset in webkit [19774] by brmorris
  • 3 edits in S60/branches/3.1m/WebKit

brmorris, reviewed by Sachin.

DESC: r19404 caused some regresion, so I'm reverting it. TMCN-6XYSLY
This was a fix for Enhanced Input feature not working in 3.1
​http://bugs.webkit.org/show_bug.cgi?id=12533

8:55 AM Changeset in webkit [19773] by staikos
  • 8 edits in trunk

Add undo/redo support and more editing commands.

5:59 AM Changeset in webkit [19772] by zack
  • 6 edits
    2 adds in trunk/WebCore

Implementing popups for the Qt platform.
r=Lars

4:00 AM Changeset in webkit [19771] by staikos
  • 2 edits in trunk/WebCore

Remove unneeded hack

3:18 AM Changeset in webkit [19770] by zack
  • 2 edits in trunk/WebCore

Fix rendering of lineedits and remove the spurious
padding on push-buttons.
r=Lars

1:13 AM Changeset in webkit [19769] by zack
  • 5 edits in trunk

fixing compilation with Qt

Feb 20, 2007:

11:30 PM Changeset in webkit [19768] by aroben
  • 2 edits in trunk/WebCore

Preemptive build fix.

  • platform/mac/FontCacheMac.mm: Remove unused (and non-existent) header.
10:20 PM Changeset in webkit [19767] by bdash
  • 4 edits in tags/Safari-421.35

Versioning.

10:11 PM Changeset in webkit [19766] by bdash
  • 1 copy in tags/Safari-421.35

New tag.

10:04 PM Changeset in webkit [22977] by bdakin
  • 5 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Maciej.

Some changes needed to match moving writeImage() to the Pasteboard
on the Mac.

  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeURL): Now takes a bool indicating if the url if for an image. (WebCore::Pasteboard::writeImage): This is just a stub for now. I am putting it here instead of on TemporaryLinkStubs because I plan on implementing it very soon.

WebKitWin:

Reviewed by Maciej.

Move copyImage functionality from the ContextMenuClient to the
Pasteboard.

  • WebContextMenuClient.cpp:
  • WebContextMenuClient.h:

M OpenSourceWin/WebKitWin/WebContextMenuClient.cpp
M OpenSourceWin/WebKitWin/ChangeLog
M OpenSourceWin/WebKitWin/WebContextMenuClient.h
M OpenSourceWin/WebCoreWin/platform/win/PasteboardWin.cpp
M OpenSourceWin/WebCoreWin/ChangeLog

10:02 PM Changeset in webkit [19765] by aroben
  • 2 edits in trunk/WebCore

Fix the build the right way.

  • platform/StringTruncator.cpp: (WebCore::truncateString): Keep all widths as floats.
10:00 PM Changeset in webkit [19764] by bdakin
  • 26 edits
    2 adds in trunk

WebCore:

Reviewed by Maciej.

Implement writeImage() on Pasteboard so that the context menus can
call into the editor for the "Copy image" command instead of
calling across the clients.

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/Editor.cpp: (WebCore::Editor::copyImage): Call into the Pasteboard.
  • editing/Editor.h:
  • loader/mac/LoaderNSURLExtras.h: A new NSURL extra needed inside WebCore.
  • loader/mac/LoaderNSURLExtras.m: Made this file Objective-C++ (from Objective-C) since the call into the MIMETypeRegistry will return a Vector. (urlByRemovingComponent): Cast to build as Obj-C++ (urlWithDataRelativeToURL): Same. (vectorContainsString): Helper. (suggestedFilenameWithMIMEType): New function.
  • page/ContextMenuClient.h: Remove copyImageToClipboard()
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Call into the editor instead of the client.
  • page/mac/WebCoreViewFactory.h: New localized String.
  • platform/LocalizedStrings.h: Same.
  • platform/MimeTypeRegistry.h: Expose two additional functions for MIMEType information from WebCore System Interface.
  • platform/Pasteboard.h:
  • platform/SharedBuffer.h: Make platformData() and platformDataSize () public since they are needed to write the image to the pasteboard.
  • platform/mac/LocalizedStringsMac.mm: New localized string. (WebCore::copyImageUnknownFileLabel):
  • platform/mac/MimeTypeRegistryMac.mm: (WebCore::MimeTypeRegistry::getExtensionsForMIMEType): (WebCore::MimeTypeRegistry::getPreferredExtensionForMIMEType):
  • platform/mac/PasteboardMac.mm: (WebCore::writableTypesForImage): (WebCore::Pasteboard::writeURL): Write the correct types if the url is for an image. (WebCore::fileWrapperForImage): (WebCore::Pasteboard::writeFileWrapperAsRTFDAttachment): (WebCore::Pasteboard::writeImage):
  • platform/mac/WebCoreNSStringExtras.h: Added. Some the the NSStringExtras that were in WebKit are now needed by WebCore. To avoid having two copies of these functions, I just moved the implementations to WebCore. The WebKit functions just call into WebCore.
  • platform/mac/WebCoreNSStringExtras.mm: Added. (hasCaseInsensitiveSuffix): (hasCaseInsensitiveSubstring): (filenameByFixingIllegalCharacters):
  • platform/mac/WebCoreSystemInterface.h: wkGetPreferredExtensionForMIMEType and wkGetExtensionsForMIMEType are now needed in WebCore as well as WebKit.
  • platform/mac/WebCoreSystemInterface.mm:

WebKit:

Reviewed by Maciej.

WebKit changes needed to implement writeImage() in WebCore's
Pasteboard class.

  • Misc/WebKitNSStringExtras.m: Call into WebCore for these implementations. (-[NSString _webkit_hasCaseInsensitiveSuffix:]): (-[NSString _webkit_hasCaseInsensitiveSubstring:]): (-[NSString _webkit_filenameByFixingIllegalCharacters]):
  • Misc/WebNSURLExtras.m: Same. (-[NSURL _webkit_suggestedFilenameWithMIMEType:]):
  • WebCoreSupport/WebContextMenuClient.h: Remove copyImageToClipboard()
  • WebCoreSupport/WebContextMenuClient.mm:
  • WebCoreSupport/WebSystemInterface.m: Expose GetExtensionsForMIMEType and GetPreferredExtensionForMIMEType to WebCore. (InitWebCoreSystemInterface):
  • WebCoreSupport/WebViewFactory.mm: New localized string for WebCore. (-[WebViewFactory copyImageUnknownFileLabel]):
9:16 PM Changeset in webkit [19763] by aroben
  • 2 edits in trunk/WebCore

Build fix.

  • platform/StringTruncator.cpp: (WebCore::truncateString): Added explicit casts.
9:06 PM Changeset in webkit [22976] by aroben
  • 8 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Darin and Anders.

  • WebCore.vcproj/WebCore.vcproj: Added new files.
  • platform/win/FileChooserWin.cpp: (WebCore::FileChooser::openFileChooser): (WebCore::FileChooser::basenameForWidth): Added truncation.
  • platform/win/WebCoreTextRenderer.cpp: (WebCore::WebCoreDrawTextAtPoint): Added bottomAlign and centerTruncate parameters.
  • platform/win/WebCoreTextRenderer.h: Ditto.

WebKitWin:

Reviewed by Darin and Anders.

9:03 PM Changeset in webkit [19762] by aroben
  • 10 edits
    2 moves in trunk

WebCore:

Reviewed by Darin and Anders.

Fix <rdar://problem/4736215> Make WebCoreStringTruncator use WebCore types

  • WebCore.exp: Updated symbols.
  • WebCore.xcodeproj/project.pbxproj: Updated file names.
  • bridge/mac/WebCoreStringTruncator.h: Removed.
  • bridge/mac/WebCoreStringTruncator.mm: Removed.
  • platform/StringTruncator.cpp: Added. Moved from bridge/mac/WebCoreStringTruncator.mm. (WebCore::textBreakAtOrPreceding): Added. (WebCore::boundedTextBreakFollowing): Added. (WebCore::centerTruncateToBuffer): (WebCore::rightTruncateToBuffer): (WebCore::stringWidth): Now takes a const Font& instead of a Font*. (WebCore::truncateString): (WebCore::StringTruncator::centerTruncate): (WebCore::StringTruncator::rightTruncate): (WebCore::StringTruncator::width):
  • platform/StringTruncator.h: Added.
  • platform/TextBreakIterator.h: Added isTextBreak declaration.
  • platform/TextBreakIteratorICU.cpp: (WebCore::isTextBreak): Implemented.
  • platform/mac/FileChooserMac.mm: (WebCore::FileChooser::basenameForWidth): Updated for changes to WebCoreStringTruncator.
  • platform/qt/TextBreakIteratorQt.cpp: (WebCore::isTextBreak): Stubbed out.

WebKit:

Reviewed by Darin and Anders.

Update WebKit for WebCore fix for <rdar://problem/4736215> Make
WebCoreStringTruncator use WebCore types.

  • Misc/WebStringTruncator.m: (defaultMenuFont): Moved from WebCoreStringTruncator.mm. (core): Added. (+[WebStringTruncator centerTruncateString:toWidth:]): (+[WebStringTruncator centerTruncateString:toWidth:withFont:]): (+[WebStringTruncator rightTruncateString:toWidth:withFont:]): (+[WebStringTruncator widthOfString:font:]):
  • WebKit.xcodeproj/project.pbxproj: Changed WebStringTruncator to ObjC++.
7:58 PM Changeset in webkit [19761] by justing
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/5006779>
REGRESSION: Paste and Match Style of quoted text onto empty line yields quoted text

  • editing/pasteboard/5006779-expected.checksum: Added.
  • editing/pasteboard/5006779-expected.png: Added.
  • editing/pasteboard/5006779-expected.txt: Added.
  • editing/pasteboard/5006779.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/5006779>
REGRESSION: Paste and Match Style of quoted text onto empty line yields quoted text


We decided to change the copy/paste behavior in both
the Paste and the Paste and Match Style cases.

  • editing/markup.cpp: (WebCore::createMarkup): Don't add mail blockquote wrappers unless the user selected one or more paragraphs.
5:48 PM Changeset in webkit [19760] by thatcher
  • 4 edits in trunk/WebCore

Reviewed by Mark Rowe.

<rdar://problem/4912899> WebCore project ObjC @property cleanup

  • bindings/objc/DOMObject.h: Add the new style @property
  • bindings/objc/PublicDOMInterfaces.h: Update to the new style @property
  • bindings/scripts/CodeGeneratorObjC.pm: Export both new and old style @properties
5:39 PM Changeset in webkit [19759] by thatcher
  • 1 edit in trunk/WebCore/bindings/objc/ExceptionHandlers.mm

Fixes the build!

4:54 PM Changeset in webkit [19758] by thatcher
  • 1 edit in trunk/WebCore/bindings/objc/ExceptionHandlers.mm

Build fix for the no-SVG build.

4:48 PM Changeset in webkit [19757] by thatcher
  • 2 edits in trunk/WebCore/bindings/objc

Better build fix, rolling out part of r19579.

4:40 PM Changeset in webkit [19756] by thatcher
  • 1 edit in trunk/WebCore/bindings/objc/DOM.mm

Build fix.

4:36 PM Changeset in webkit [19755] by ggaren
  • 2 edits in trunk/WebKitTools

Tools tweak. No review necessary.


Made parse-malloc-history executable. (Oops!)


Made parse-malloc-history parse 'leaks' output in addition to 'malloc_history"
output.


Added the ability to merge callstacks by regexp, not just depth, so you
can ask questions like, "How many of these allocations were due to that one
call to ...?"


  • Scripts/parse-malloc-history:
4:12 PM Changeset in webkit [19754] by staikos
  • 2 edits in trunk/WebKitQt

Fix compile

4:07 PM Changeset in webkit [19753] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Sam Weinig.

<rdar://problem/5007248> need to export symbols for DOM exception constants

  • WebCore.exp: Adds DOMEventException, DOMException, DOMRangeException, DOMXPathException
3:56 PM Changeset in webkit [19752] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by John.

Fixes the version number returned when using a CFBundleVersion of "420+".

  • WebView/WebView.mm: (-[WebView _userVisibleBundleVersionFromFullVersion:]): Check the length up to the first non-decimal digit, so this works with versions that have "." and "+".
3:38 PM Changeset in webkit [19751] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Kevin Decker


  • fixed <rdar://problem/4989344> REGRESSION: After clicking on page, Find won't find anything if all hits are before the clicked point


This was caused by a mismatch between WebCore's search code's notion of "selection" and
WebView's search code's notion of "selection". WebCore's search code was starting
just before or just after the "selection", which included collapsed, zero-length
selections. WebKit's search code was only considering non-zero-length selections,
and would not search all of the content when there was a zero-length selection.
The fix was to make WebKit ignore the selection. This has a side effect of increasing
the amount of redundantly-searched content in the case where no matches are found. To
compensate for that, I special-cased the most common case of WebViews with a single frame,
to avoid ever searching redundantly in those.

  • WebView/WebView.mm: (-[WebView searchFor:direction:caseSensitive:wrap:startInSelection:]): remove startHasSelection ivar; special-case WebViews with only one frame; clarify the code that leads to redundant searching with comments.
3:26 PM Changeset in webkit [19750] by thatcher
  • 1 edit in trunk/WebKit/WebView/WebHTMLView.mm

Build fix.

3:26 PM Changeset in webkit [19749] by ggaren
  • 2 edits in trunk/WebKitTools
  • Scripts/parse-malloc-history: Added copyright info.
2:57 PM Changeset in webkit [19748] by brmorris
  • 2 edits in S60/trunk/WebKit

yadavall, reviewed by zalan

DESC: Merge of r19731 to s60/trunk: Browser crashes when trying to open rss link HMNN-6YDEAW
​http://bugs.webkit.org/show_bug.cgi?id=12790

2:55 PM Changeset in webkit [22975] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

2:53 PM Changeset in webkit [19747] by thatcher
  • 21 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/4900579> WebKit -finalize methods are not thread-safe; design change needed

Call WebCoreObjCFinalizeOnMainThread from the initialize method of all the classes
that have a finalizer that needs called on the main thread.

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/WebScriptObject.mm: (+[WebScriptObject initialize]):
  • bridge/mac/WebCoreScriptDebugger.mm: (+[WebCoreScriptDebugger initialize]):
  • platform/mac/SharedBufferMac.mm: (+[SharedBufferData initialize]):
  • platform/mac/WebCoreObjCExtras.c: Added. (WebCoreObjCFinalizeOnMainThread):
  • platform/mac/WebCoreObjCExtras.h: Added.

WebKit:

Reviewed by Darin.

<rdar://problem/4900579> WebKit -finalize methods are not thread-safe; design change needed

Call WebCoreObjCFinalizeOnMainThread from the initialize method of all the classes
that have a finalizer that needs called on the main thread. Assert in finalize that we
are on the main thread.

  • Carbon/CarbonWindowAdapter.m: (+[CarbonWindowAdapter initialize]): (-[CarbonWindowAdapter finalize]):
  • History/WebBackForwardList.mm: (+[WebBackForwardList initialize]): (-[WebBackForwardList finalize]):
  • History/WebHistoryItem.mm: (+[WebHistoryItem initialize]):
  • Misc/WebElementDictionary.mm: (+[WebElementDictionary initialize]): (-[WebElementDictionary finalize]):
  • Plugins/WebBaseNetscapePluginStream.m: (+[WebBaseNetscapePluginStream initialize]): (-[WebBaseNetscapePluginStream finalize]):
  • Plugins/WebBaseNetscapePluginView.mm: (+[WebBaseNetscapePluginView initialize]): (-[WebBaseNetscapePluginView finalize]):
  • Plugins/WebBasePluginPackage.m: (+[WebBasePluginPackage initialize]): (-[WebBasePluginPackage finalize]):
  • Plugins/WebNetscapePluginStream.mm: (-[WebNetscapePluginStream finalize]):
  • WebCoreSupport/WebEditorClient.mm: (+[WebEditCommand initialize]): (-[WebEditCommand finalize]):
  • WebCoreSupport/WebFrameBridge.mm: (+[WebFrameBridge initialize]): (-[WebFrameBridge finalize]):
  • WebCoreSupport/WebFrameLoaderClient.mm: (+[WebFramePolicyListener initialize]): (-[WebFramePolicyListener finalize]):
  • WebView/WebHTMLView.mm: (+[WebHTMLView initialize]): (-[WebHTMLView finalize]):
  • WebView/WebView.mm: (+[WebViewPrivate initialize]): (-[WebViewPrivate finalize]):
2:53 PM Changeset in webkit [19746] by sfalken
  • 1 copy in tags/Safari-521.35.1b

New tag.

2:44 PM Changeset in webkit [19745] by justing
  • 3 edits in trunk/WebKit

Reviewed by darin


<rdar://problem/4838199>
Integrate Mail and WebKit paste operations


Mail overrides paste: because it has different
preferred pasteboard types, but it should use our
fragment creation code.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]): Moved fragment creation code into a new method. (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:]): Moved fragment creation code here.
  • WebView/WebHTMLViewPrivate.h: Exposed _documentFragmentFromPasteboard:forType:inContext: as SPI.
2:32 PM Changeset in webkit [19744] by sullivan
  • 4 edits in trunk/WebKit

Reviewed by Tim Hatcher

  • Misc/WebKitNSStringExtras.h:
  • Misc/WebKitNSStringExtras.m: removed _webkit_userVisibleBundleVersionFromFullVersion; we decided to do this without adding SPI for it.
  • WebView/WebView.mm: (-[WebView _userVisibleBundleVersionFromFullVersion:]): new method, moved here from WebKitNSStringExtras, and is now a WebView method rather than an NSString method (-[WebView _computeUserAgent]): updated for method signature change
2:09 PM Changeset in webkit [19743] by ggaren
  • 1 edit
    1 add in trunk/WebKitTools

Reviewed by Darin Adler.


New script to parse the output from malloc_history, so we can determine
what's using memory in WebKit.

  • Scripts/parse-malloc-history: Added.
1:32 PM Changeset in webkit [19742] by ggaren
  • 2 edits in trunk/WebCore

Not not reviewed by Mitz Pettel.

Fixed ​http://bugs.webkit.org/show_bug.cgi?id=12827 | <rdar://problem/5006671>
REGRESSION: -[DOMCSSStyleDeclaration setValue:forKey:] doesn't have an
immediate effect


Let's just pretend this never happened.


I attempted a layout test but I couldn't get the old code to fail because
there's no obvious way to isolate the ObjC bindings in a test that's
controlled by JS.


  • bindings/objc/WebScriptObject.mm: (_didExecute):
1:21 PM Changeset in webkit [19741] by kjk
  • 14 edits
    2 copies in trunk/WebCore

Reviewed by Maciej S.

Gdk build fixes for recent refactorings.

  • Projects/gdk/webcore-gdk.bkl:
  • WebCoreSources.bkl:
  • page/gdk/DragControllerGdk.cpp: (WebCore::DragController::dragOperation): (WebCore::DragController::maxDragImageSize):
  • page/gdk/EventHandlerGdk.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • platform/DragImage.h:
  • platform/gdk/ChromeClientGdk.h:
  • platform/gdk/CursorGdk.cpp: (WebCore::verticalTextCursor): (WebCore::cellCursor): (WebCore::contextMenuCursor): (WebCore::noDropCursor): (WebCore::copyCursor): (WebCore::progressCursor): (WebCore::aliasCursor): (WebCore::noneCursor): (WebCore::notAllowedCursor):
  • platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::shouldChangeSelectedRange): (WebCore::EditorClientGdk::isEditable): (WebCore::EditorClientGdk::textFieldDidBeginEditing): (WebCore::EditorClientGdk::textFieldDidEndEditing): (WebCore::EditorClientGdk::textDidChangeInTextField): (WebCore::EditorClientGdk::doTextFieldCommandFromEvent): (WebCore::EditorClientGdk::textWillBeDeletedInTextField): (WebCore::EditorClientGdk::textDidChangeInTextArea):
  • platform/gdk/EditorClientGdk.h:
  • platform/gdk/FrameGdk.cpp: (WebCore::Frame::print): (WebCore::Frame::issueTransposeCommand): (WebCore::Frame::respondToChangedSelection): (WebCore::Frame::cleanupPlatformScriptObjects): (WebCore::Frame::isCharacterSmartReplaceExempt): (WebCore::Frame::dragImageForSelection):
  • platform/gdk/FrameGdk.h:
  • platform/gdk/MimeTypeRegistryGdk.cpp: Added.
  • platform/gdk/TemporaryLinkStubs.cpp: (ChromeClientGdk::tabsToLinks): (ChromeClientGdk::windowResizerRect): (ChromeClientGdk::addToDirtyRegion): (ChromeClientGdk::scrollBackingStore): (ChromeClientGdk::updateBackingStore):
  • webcore-base.bkl:
1:13 PM Changeset in webkit [19740] by kjk
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Allow over-writting Product, ProductSub, Vendor and VendorSub
js properties via #define WEBCORE_NAVIGATOR_*

  • bindings/js/kjs_navigator.cpp: (KJS::Navigator::getValueProperty):
12:41 PM Changeset in webkit [19739] by thatcher
  • 4 edits in trunk/WebKit

Reviewed by John.

  • Misc/WebKitNSStringExtras.h: Added _webkit_userVisibleBundleVersionFromFullVersion.
  • Misc/WebKitNSStringExtras.m: (-[NSString _webkit_userVisibleBundleVersionFromFullVersion]): If the version is 4 digits long or longer, then the first digit represents the version of the OS. Our user agent string should not include this first digit, so strip it off and report the rest as the version.
  • WebView/WebView.mm: (-[WebView _computeUserAgent]): Call _webkit_userVisibleBundleVersionFromFullVersion on the CFBundleVersion.
11:33 AM Changeset in webkit [22974] by aliceli1
  • 2 edits in branches/WindowsMerge/WebCore

Build fix

  • WebCore.vcproj/WebCore.vcproj: Added PositionIterator.cpp & h
11:27 AM Changeset in webkit [19738] by kmccullo
  • 1 edit in trunk/WebCore/ChangeLog-2006-12-31
10:56 AM Changeset in webkit [22973] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2007-02-20 Steve Falkenburg <​sfalken@apple.com>

B&I build fix

  • WebCore.vcproj/WebCore.vcproj:
10:20 AM Changeset in webkit [22972] by darin
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Anders.

  • WebFrame.cpp: (WebFrame::redirectDataToPlugin): Update for changes to FrameLoader and DocumentLoader.
10:18 AM Changeset in webkit [19737] by darin
  • 12 edits in trunk

WebCore:

Reviewed by Anders.

  • prepare to fix some "stop loading" bugs by moving state from the FrameLoader class to the DocumentLoader class
  • WebCore.exp: Update since cancelMainResourceLoad is now on the document loader.
  • html/HTMLDocument.h:
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::HTMLDocument): Removed unused bodyElement and htmlElement data members. (WebCore::HTMLDocument::lastModified): Call getResponseModifiedHeader directly on the document loader.
  • loader/DocumentLoader.h: Moved m_mainResourceLoader, m_subresourceLoaders, and m_plugInStreamLoaders here.
  • loader/DocumentLoader.cpp: (WebCore::cancelAll): Moved here from FrameLoader. (WebCore::setAllDefersLoading): Ditto. (WebCore::DocumentLoader::mainResourceData): Moved the body of FrameLoader's mainResourceData function here. (WebCore::DocumentLoader::stopLoading): Replaced calls to hasMainResourceLoader and cancelMainResourceLoad with code that works directly on m_mainResourceLoader. Call the stop functions moved from FrameLoader here on ourselves. (WebCore::DocumentLoader::setupForReplaceByMIMEType): Ditto. (WebCore::DocumentLoader::setPrimaryLoadComplete): Moved the code to store the main resource data here; it doesn't require separate functions. (WebCore::DocumentLoader::isLoadingInAPISense): Removed call to isLoadingSubresources and instead just check if the m_subresourceLoaders set is empty. (WebCore::DocumentLoader::setDefersLoading): Moved code here from FrameLoader. (WebCore::DocumentLoader::stopLoadingPlugIns): Ditto. (WebCore::DocumentLoader::stopLoadingSubresources): Ditto. (WebCore::DocumentLoader::addSubresourceLoader): Ditto. (WebCore::DocumentLoader::removeSubresourceLoader): Ditto. (WebCore::DocumentLoader::addPlugInStreamLoader): Ditto. (WebCore::DocumentLoader::removePlugInStreamLoader): Ditto. (WebCore::DocumentLoader::isLoadingSubresources): Ditto. (WebCore::DocumentLoader::isLoadingPlugIns): Ditto. (WebCore::DocumentLoader::startLoadingMainResource): Ditto. (WebCore::DocumentLoader::cancelMainResourceLoad): Ditto.
  • loader/FrameLoader.h: Removed stopLoadingPlugIns, stopLoadingSubresources, cancelMainResourceLoad, hasMainResourceLoader, isLoadingSubresources, mainResourceData, releaseMainResourceLoader, lastModified, startLoadingMainResource, isLoadingPlugIns, m_mainResourceLoader, m_subresourceLoaders, m_plugInStreamLoaders, m_responseRefreshHeader, and m_responseModifiedHeader.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::setDefersLoading): Call setDefersLoading on all the document loaders. (WebCore::FrameLoader::stopLoading): Get rid of code to set m_responseRefreshHeader and m_responseModifiedHeader. (WebCore::FrameLoader::receivedFirstData): Call httpHeaderField on the response here to get the Refresh, instead of storing it in a data member. (WebCore::FrameLoader::addPlugInStreamLoader): Change to just call this on the document loader. (WebCore::FrameLoader::removePlugInStreamLoader): Ditto. (WebCore::FrameLoader::isLoading): Change to call isLoadingSubresources and isLoadingPlugIns on the document loader. (WebCore::FrameLoader::addSubresourceLoader): Change to just call this on the document loader. (WebCore::FrameLoader::removeSubresourceLoader): Ditto. (WebCore::FrameLoader::commitProvisionalLoad): Call stopLoadingSubresources and stopLoadingPlugIns on the document loader. Removed code to set m_responseModifiedHeader. (WebCore::FrameLoader::startLoading): Call isLoadingMainResource and startLoadingMainResource on the document loader.
  • loader/ImageDocument.cpp: (WebCore::ImageTokenizer::finish): Call mainResourceData() on the document loader instead of the frame loader.
  • other changes
  • loader/DocLoader.cpp: (WebCore::DocLoader::checkCacheObjectStatus): Fixed indentation.

WebKit:

Reviewed by Anders.

  • Plugins/WebPluginController.mm: (-[WebPluginController pluginView:receivedResponse:]): Call cancelMainResourceLoad on the document loader instead of the frame loader.
9:24 AM Changeset in webkit [19736] by andersca
  • 2 edits in trunk/WebKit

Reviewed by Mitz.

<rdar://problem/5009627> REGRESSION: Repro overrelease of WebView in failed load, seen in DumpRenderTree


  • WebView/WebView.mm: (-[WebView _removeObjectForIdentifier:]): Return early if the identifier can't be found in the map.
9:19 AM Changeset in webkit [19735] by zack
  • 3 edits in trunk/WebCore

Fix focus handling and make the forms
work as expected.
r=Lars

8:00 AM Changeset in webkit [19734] by weinig
  • 8 edits
    2 adds in trunk/WebCore

Reviewed by Darin and then Sam.

No test since there is no change in functionality.

  • CMakeLists.txt:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj: Added PositionIterator.{cpp,h}.
  • WebCoreSources.bkl:
  • dom/Position.cpp: (WebCore::Position::Position): Added converting constructor from PositionIterator. (WebCore::Position::previous): Changed assert() to ASSERT(). (WebCore::Position::next): Ditto. (WebCore::isStreamer): Changed the argument to a PositionIterator. (WebCore::Position::upstream): Changed to use PositionIterator. (WebCore::Position::downstream): Ditto. (WebCore::Position::inRenderedText): Made public. (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight): Changed into a static member function. (WebCore::Position::nodeIsUserSelectNone): Ditto.
  • dom/Position.h:
  • dom/PositionIterator.cpp: Added. A Position iterator with constant-time increment, decrement, and several predicates on the Position it is at. Conversion to/from Position is O(n) in the offset. (WebCore::PositionIterator::increment): (WebCore::PositionIterator::decrement): (WebCore::PositionIterator::atStart): (WebCore::PositionIterator::atEnd): (WebCore::PositionIterator::atStartOfNode): (WebCore::PositionIterator::atEndOfNode): (WebCore::PositionIterator::isCandidate):
  • dom/PositionIterator.h: Added. (WebCore::PositionIterator::PositionIterator): (WebCore::PositionIterator::node): (WebCore::PositionIterator::offsetInLeafNode):
  • editing/htmlediting.cpp: (WebCore::nextCandidate): Changed to use PositionIterator. (WebCore::previousCandidate): Changed to use PositionIterator.
7:43 AM Changeset in webkit [19733] by brmorris
  • 2 edits in S60/trunk/WebCore

hongzhao, reviewed by Zalan

DESC: [S60] - Browser NG, ReTe: Some call links on "cti_attribute.html " page are highlighted incorrectly ESZG-6TU9N9
Fix: Add hover sto a[cti].s
​http://bugs.webkit.org/show_bug.cgi?id=12814

7:39 AM Changeset in webkit [19732] by rwlbuis
  • 30 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12439
SVG parser complains about points attribute in polygon and polyline element

Return true when the parsed points specification is valid.

7:07 AM Changeset in webkit [19731] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

yadavall, Reviewed by Zalan Bujtas (​zbujtas@gmail.com).

DESC: Browser crashes when trying to open rss link hs.fi/rss HMNN-6YDEAW
​http://bugs.webkit.org/show_bug.cgi?id=12790

6:46 AM Changeset in webkit [19730] by zack
  • 10 edits in trunk

Make editing of forms work plus make sure that non-void methods
always return something.
r=Lars

4:30 AM Changeset in webkit [19729] by zack
  • 2 edits
    1 add in trunk/WebCore

Redo form-theming (aka. make Qt pretty, so very, very pretty)
r=Lars

2:33 AM Changeset in webkit [19728] by ap
  • 2 edits in trunk/WebCore

2007-02-19 Lars Naesbye Christensen <​lars@naesbye.dk>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12815
Two image files not included in project file

  • WebCore.xcodeproj/project.pbxproj: Added crossHairCursor.png and notAllowedCursor.png.
2:11 AM Changeset in webkit [19727] by gdennis
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin Adler.


Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12802
WebKit.framework is built with SVG_SUPPORT for No-SVG build

  • Scripts/build-webkit: Pass the "FEATURE_DEFINES=" option when building WebKit as well.

Feb 19, 2007:

9:35 PM Changeset in webkit [22971] by ggaren
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam Roben.

Fixed some leaks in RenderThemeSafari.


I just merged some of the code I wrote for RenderThemeMac.


9:33 PM Changeset in webkit [19726] by ggaren
  • 3 edits in trunk/WebCore

Reviewed by Adam Roben.

Fixed some leaks in RenderThemeMac.


No test case because 'leaks' can't detect these leaks inside DRT, even if
DRT forces the WebView to paint. ('leaks' can detect these leaks inside
Safari. Weird.)


  • rendering/RenderThemeMac.h:
    • Renamed data members to m_*, to match our style guidelines.
    • Renamed *Is* to is, to match our style guidelines.
    • Removed a few unnecessary data members.
    • Made cached values like m_checkbox mutable, since they can change inside functions that don't change the logical state of a RenderTheme object. (The alternative was to make some const functions non-const.)

(WebCore::RenderThemeMac::paintMenuList): Took CFType pointers that just
used to leak and placed them in RetainPtrs.
(WebCore::RenderThemeMac::paintMenuListButtonGradients): ditto

Factored inline implementations of lazy initialization into these accessor
functions, for better encapsulation:


(WebCore::RenderThemeMac::checkbox):
(WebCore::RenderThemeMac::radio):
(WebCore::RenderThemeMac::button):
(WebCore::RenderThemeMac::popupButton):
(WebCore::RenderThemeMac::search):
(WebCore::RenderThemeMac::sliderThumbHorizontal): The inline version of
this initialization used to confuse the retained data member with a local
stack value, causing both a leak and a failure to initialize. Fixed now.
(WebCore::RenderThemeMac::sliderThumbVertical): ditto
(WebCore::RenderThemeMac::resizeCornerImage):

9:19 PM Changeset in webkit [19725] by thatcher
  • 4 edits in trunk/JavaScriptGlue

Reviewed by Geoff.

<rdar://problem/4636301> Deprecate JavaScriptGlue

  • JavaScriptGlue.h: adds DEPRECATED_IN_MAC_OS_X_VERSION_10_5_AND_LATER to everything
  • JavaScriptGlue.xcodeproj/project.pbxproj: use -Wno-deprecated-declarations to keep the project building
  • config.h: define DEPRECATED_IN_MAC_OS_X_VERSION_10_5_AND_LATER as empty on other systems
8:38 PM Changeset in webkit [19724] by bdash
  • 3 edits in tags/Safari-521.35

Versioning.

8:33 PM Changeset in webkit [19723] by bdash
  • 2 edits in tags/Safari-521.35/WebCore

Merge in r19665.

8:31 PM Changeset in webkit [19722] by bdash
  • 10 edits in tags/Safari-521.35/WebCore

Merge in r19662.

8:30 PM Changeset in webkit [19721] by bdash
  • 6 edits in tags/Safari-521.35/WebCore

Merge in r19660.

8:24 PM Changeset in webkit [19720] by bdash
  • 1 copy in tags/Safari-521.35

New tag.

7:01 PM Changeset in webkit [19719] by weinig
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/repaint/table-outer-border-expected.checksum: Added.
  • fast/repaint/table-outer-border-expected.png: Added.
  • fast/repaint/table-outer-border-expected.txt: Added.
  • fast/repaint/table-outer-border.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/repaint/table-outer-border.html

  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout): Reordered to initialize horizontal overflow after table sections have computed their outer horizontal borders.
6:39 PM Changeset in webkit [19718] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Darin


  • fixed <rdar://problem/4613701> REGRESSION: A line break in the source HTML of a link becomes visible after drag & drop
  • page/DragController.cpp: (WebCore::DragController::startDrag): Call simplifyWhiteSpace() on the proposed link title to match what's displayed on the web page, instead of using the raw source HTML text.
5:41 PM Changeset in webkit [19717] by hyatt
  • 60 edits
    4 adds in trunk

Fix for Radar 4981605, regression where button grows randomly when a select is
opened. With the new form controls, the WinIE quirk for using line width
ended up being used for them more.

This patch removes the quirk after verifying that Firefox doesn't implement
the quirk at all. usesLineWidth is being renamed to shrinksToAvoidFloats to
make it clear that the new method only applies to block objects that avoid floats
and that have auto width.

Also fixed a regression where whitespace after a floating <select> at the start
of a block got incorrectly rendered. Make sure skipWhitespace always skips
through floating/positioned elements regardless of the whitespace setting (this
way the white-space:pre value on floating <select>s doesn't cause trouble).

Reviewed by darin

fast/block/float/float-avoidance.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::collapseMargins): (WebCore::RenderBlock::clearFloatsIfNeeded): (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::containingBlockWidth):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::shrinkToAvoidFloats):
  • rendering/RenderObject.h:
  • rendering/bidi.cpp: (WebCore::RenderBlock::skipWhitespace):
5:22 PM Changeset in webkit [19716] by weinig
  • 5 edits
    9 adds in trunk

LayoutTests:

Reviewed by Darin.

  1. Test for background image with relative url, when base url element is present. .html has a base url, which according to the html spec is supposed to be absolute, is actually a relative url. Absolute url would not work with ​file:// scheme.
  2. Test for base element and @import with relative url. ​http://bugs.webkit.org/show_bug.cgi?id=12214


  • fast/css/background-image-with-baseurl-expected.checksum: Added.
  • fast/css/background-image-with-baseurl-expected.png: Added.
  • fast/css/background-image-with-baseurl-expected.txt: Added.
  • fast/css/background-image-with-baseurl.html: Added.
  • fast/css/import_with_baseurl-expected.checksum: Added.
  • fast/css/import_with_baseurl-expected.png: Added.
  • fast/css/import_with_baseurl-expected.txt: Added.
  • fast/css/import_with_baseurl.html: Added.
  • fast/css/resources/background_image.css: Added.

WebCore:

Reviewed by Darin.

Update stylesheet href, when document's baseUrl changes. It needs
update when the stylesheet is constructed before the parser hits the base tag.
​http://bugs.webkit.org/show_bug.cgi?id=12214

  • css/StyleSheet.h: (WebCore::StyleSheet::setHref):
  • dom/Document.cpp: (WebCore::Document::setBaseURL):
  • dom/Document.h:
5:05 PM Changeset in webkit [19715] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Adam.

The FrameLoader's responseMIMEType was not being updated when a page was
brought back from the page cache.


Moved the line that updates the MIME type from commitProvisionalLoad() to
transitionToCommitted().

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::transitionToCommitted):
4:01 PM Changeset in webkit [19714] by ggaren
  • 2 edits in trunk/WebKitTools

Build fix.


  • Scripts/check-for-global-initializers: Ignore the global counter I added for SubresourceLoaders.
3:36 PM Changeset in webkit [22970] by aroben
  • 5 edits in branches/WindowsMerge/WebKitWin

Reviewed by Darin.

Fix <rdar://problem/5007566> Crash in WebFrame::dataSource on dni.ru

The fix for the bug was to zero out WebFrame's Frame pointer in
WebFrame::frameLoaderDestroyed, and then to null-check or ASSERT
non-null as appropriate. All IWebFrame methods that depend on the Frame
pointer will return E_FAIL if it is null, and everywhere within
WebFrame that wasn't null-checking before will now explicitly ASSERT.

I also changed all uses of d->frame and WebFrame::impl() to use the
core() function for consistency, and so that there is only one code
path for getting from a WebFrame to a Frame.

Additional more specific comments below.

  • WebChromeClient.cpp: (WebChromeClient::scrollBackingStore): (WebChromeClient::updateBackingStore):
  • WebFrame.cpp: (kit): Null-check the frame parameter. (core): Added two overloads of this. (WebFrame::DOMDocument): Added argument checking. (WebFrame::currentForm): (WebFrame::loadRequest): (WebFrame::loadData): (WebFrame::dataSource): Added argument checking, and return E_FAIL if the dataSource is null. (WebFrame::provisionalDataSource): Ditto. (WebFrame::stopLoading): (WebFrame::reload): (WebFrame::parentFrame): (WebFrame::renderTreeAsExternalRepresentation): Added argument checking. (WebFrame::firstLayoutDone): Ditto. (WebFrame::loadType): Ditto. (WebFrame::invalidate): (WebFrame::setTextSizeMultiplier): (WebFrame::inViewSourceMode): Added argument checking, and changed to return an HRESULT. (WebFrame::setInViewSourceMode): Changed to return an HRESULT. (WebFrame::searchForLabelsBeforeElement): Added argument checking. (WebFrame::matchLabelsAgainstElement): Ditto. (WebFrame::frameLoaderDestroyed): Zero out the Frame pointer because the Frame is being destroyed. (WebFrame::createFrame): (WebFrame::loadURLIntoChild): Added some assertions. (WebFrame::dispatchWillSubmitForm): (WebFrame::frameLoadCompleted): (WebFrame::receivedData): (WebFrame::setUpPolicyListener): (WebFrame::receivedPolicyDecision): (WebFrame::dispatchDecidePolicyForMIMEType): (WebFrame::dispatchDecidePolicyForNewWindowAction): (WebFrame::dispatchDecidePolicyForNavigationAction): (WebFrame::dispatchCreatePage): (WebFrame::createPlugin): (WebFrame::redirectDataToPlugin): (WebFrame::createJavaAppletWidget): (WebFrame::windowObjectCleared): (WebFrame::setPrinting): (WebFrame::setInPrintingMode): (WebFrame::computePageRects): (WebFrame::getPrintedPageCount): Zero out the out parameter before proceeding. (WebFrame::spoolPages): (WebFrame::forceLayoutWithPageWidthRange):
  • WebFrame.h:
  • WebView.cpp: (WebView::paint): Silently fail on a null Frame, because this method could be called at any time. (WebView::mouseWheel): Ditto. (WebViewWndProc): Ditto. (WebView::inViewSourceMode): Return whatever WebFrame::setInViewSourceMode returns. (WebView::setInViewSourceMode): Ditto. (WebView::setCustomTextEncodingName): Replaced check for a null FrameLoader with a check for a null Frame, which is equivalent but, as a bonus, won't crash. (WebView::stringByEvaluatingJavaScriptFromString): (WebView::elementAtPoint): Added argument checking. (WebView::selectedText): Ditto. (WebView::centerSelectionInVisibleArea):
3:34 PM Changeset in webkit [22969] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Fix build.

  • page/win/DragControllerWin.cpp: (WebCore::DragController::maxDragImageSize):
3:32 PM Changeset in webkit [19713] by andersca
  • 5 edits in trunk/WebCore

Reviewed by Oliver.

Make DragController::maxDragImageSize a function to get rid of the global initializer.


  • page/DragController.cpp: (WebCore::DragController::doImageDrag):
  • page/DragController.h:
  • page/mac/DragControllerMac.mm: (WebCore::DragController::maxDragImageSize):
  • page/qt/DragControllerQt.cpp: (WebCore::DragController::maxDragImageSize):
3:19 PM Changeset in webkit [22968] by adele
  • 4 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Adam.

Fix for <rdar://problem/5006882> PlatformScrollbarSafari doesn't support small scroll bars

3:19 PM Changeset in webkit [19712] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Tim Hatcher.

  • Scripts/check-for-global-initializers: Delete the linked executable if the check fails. Without this, you only see the global initializer error once, which makes it very easy to miss them.
3:09 PM Changeset in webkit [19711] by thatcher
  • 3 edits in trunk/WebKit

Reviewed by Darin Adler.

<rdar://problem/4841078> Remove the Mail.app editable link clicking behavior workaround when it is no longer needed

  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebView.mm: (-[WebView setPreferences:]):
2:47 PM Changeset in webkit [22967] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

<rdar://problem/5008424>
Regression: Crash loading mp3.com


  • platform/network/cf/ResourceErrorCF.cpp: (WebCore::ResourceError::ResourceError): Handle null resource errrors.
1:44 PM Changeset in webkit [19710] by darin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

  • <rdar://problem/5006414> REGRESSION: Crash occurs at WebCore::Frame::loader() when loading AFL Ladder widget
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::openURL): Add missing null check so this fails without crashing when called on an element that's no longer in a frame.
1:39 PM Changeset in webkit [19709] by andersca
  • 2 edits in trunk/WebKit

Reviewed by Adam.

<rdar://problem/4868242>
​http://bugs.webkit.org/show_bug.cgi?id=12670
REGRESSION: Many 3rd Party Apps crash in WebCore::DocumentLoader::frameLoader() (12670)


Bring back the semantic we had that a web view should be retained for as long as something is loading. Use the identifier
to object hash map for this.

  • WebView/WebView.mm: (-[WebView _addObject:forIdentifier:]): (-[WebView _removeObjectForIdentifier:]):
11:41 AM Changeset in webkit [19708] by thatcher
  • 3 edits in trunk/WebKit

Remove two imports of FrameMac.h, fixes clean Mac builds.

7:43 AM Changeset in webkit [19707] by antti
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Mitz.


  • fast/forms/select-accesskey-expected.checksum: Added.
  • fast/forms/select-accesskey-expected.png: Added.
  • fast/forms/select-accesskey-expected.txt: Added.
  • fast/forms/select-accesskey.html: Added.

WebCore:

Reviewed by Mitz.


Focus the select element too in accessKeyAction.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::accessKeyAction):
1:20 AM Changeset in webkit [19706] by antti
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.


Avoid double painting caret when it is on a block element.


Layout test for this already went in previous try (it only fails in pixel mode) in r19626.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintCaret):
12:35 AM Changeset in webkit [22966] by aroben
  • 5 edits in branches/WindowsMerge

WebCoreWin:

Build fix.

  • bridge/win/FrameWin.cpp: (WebCore::computePageRectsForFrame): This is no longer an instance method of Frame.
  • bridge/win/FrameWin.h:

WebKitWin:

Build fix.

  • WebFrame.cpp: (WebFrame::computePageRects):
12:13 AM Changeset in webkit [19705] by lars
  • 3 edits in trunk/WebCore

Added a one line patch from Olliej to create the
clipboard on demand (to stop things from crashing),
and added lots of notImplemented() warnings all
over the place.

Note: See TracTimeline for information about the timeline view.