Timeline



Apr 4, 2007:

11:04 PM Changeset in webkit [20717] by thatcher
  • 4 edits in branches/WebInspectorRefresh/WebKit/WebInspector

Move the tree splitter resize code down into JavaScript. Some other cleanup work.

10:24 PM Changeset in webkit [20716] by bdash
  • 2 edits in trunk/WebKitSite

2007-04-05 Mark Malone <​markmalone@mac.com>

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13273
Bug 13273: DOM Interfaces Nav link should go somewhere more useful

  • nav.inc: Link directly to the hierarchy.
10:22 PM Changeset in webkit [20715] by thatcher
  • 1 edit in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector/inspector.js

Make selecting a new root element from the root popup menu work. Also reverse the order of the parent nodes shown in the popup, with the document at the top. Fixes bug 6615.

9:40 PM Changeset in webkit [20714] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13278
REGRESSION: cannot change SELECT option

Test: fast/forms/option-change-single-selected.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex): If multiple selection is not allowed, be sure to deselect the previous option.
9:39 PM Changeset in webkit [20713] by thatcher
  • 1 edit in branches/WebInspectorRefresh/WebKit/WebInspector/WebInspector.m

Remove my machine specific path.

9:37 PM Changeset in webkit [20712] by thatcher
  • 1 edit in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector/AppleScrollbar.js

Only call this.refresh() if this.hidden is true. This was causing a 'maximum call stack size' exception.

9:26 PM Changeset in webkit [20711] by thatcher
  • 3 edits in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector

Move our override scrollbar and scroll-area code to our copies of AppleScrollbar.js and AppleScrollArea.js.

8:43 PM Changeset in webkit [20710] by thatcher
  • 2 edits
    2 adds in branches/WebInspectorRefresh/WebKit/WebInspector

Keep our own copy of AppleScrollbar.js and AppleScrollArea.js, copied /System/Library/WidgetResources/AppleClasses.

6:39 PM Changeset in webkit [23228] by oliver
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-04-04 Oliver Hunt <​oliver@apple.com>

Reviewed by Ada.


Fix <rdar://problem/5111027> Dragging a link on page
shows URL thumbnail as nearly-transparent instead
semi-transparent

Error in createDragImageForLink led me to get wrong
maximum drag image size, now logic and maximum drag
image size corrected.

  • WebDragClient.cpp: (WebDragClient::createDragImageForLink):


6:05 PM Changeset in webkit [20709] by adele
  • 9 edits in trunk/WebCore

Reviewed by Oliver.

Fix for <rdar://5105009> Prepare for fix to send mousedown and mouseup (but not click) events when right-clicking

  • page/EventHandler.cpp: Don't ever send click events for right-clicks. (WebCore::EventHandler::handleMouseDoubleClickEvent): (WebCore::EventHandler::handleMouseReleaseEvent):


Check that the mousedown and mouseup are not with the right button before performing default behavior.

  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::menuListDefaultEventHandler): (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
  • html/HTMLTextFieldInnerElement.cpp: (WebCore::HTMLSearchFieldResultsButtonElement::defaultEventHandler): (WebCore::HTMLSearchFieldCancelButtonElement::defaultEventHandler):
  • ksvg2/svg/SVGAElement.cpp:(WebCore::SVGAElement::defaultEventHandler):
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::userResize):
  • rendering/RenderSlider.cpp: (WebCore::HTMLSliderThumbElement::defaultEventHandler):
2:40 PM Changeset in webkit [23227] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Release build fix for TestNetscapePlugin.

  • WebKit.vcproj/WebKit.vcproj: Make the Release post-build step the same as the Debug one so that the npapi headers get copied.
1:52 PM Changeset in webkit [20708] by sfalken
  • 19 edits in branches/Safari-522/WebCore

Re-merge fix from r20674

1:49 PM Changeset in webkit [20707] by justing
  • 4 edits
    12 adds in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/5026848> Can cut/delete To Do subunits

This tests to make sure that non-editable content
that is in both the start and end editable roots
is removed:

  • editing/deleting/5026848-1-expected.checksum: Added.
  • editing/deleting/5026848-1-expected.png: Added.
  • editing/deleting/5026848-1-expected.txt: Added.
  • editing/deleting/5026848-1.html: Added. This tests to make sure that non-editable content that is not in both the start and end editable roots is not removed:
  • editing/deleting/5026848-2-expected.checksum: Added.
  • editing/deleting/5026848-2-expected.png: Added.
  • editing/deleting/5026848-2-expected.txt: Added.
  • editing/deleting/5026848-2.html: Added. This tests to make sure that editable regions that are not in both the start and end editable roots are cleared (not removed, unless they are in another editable region):
  • editing/deleting/5026848-3-expected.checksum: Added.
  • editing/deleting/5026848-3-expected.png: Added.
  • editing/deleting/5026848-3-expected.txt: Added.
  • editing/deleting/5026848-3.html: Added.

WebCore:

Reviewed by darin


<rdar://problem/5026848> Can cut/delete ToDo subunits


We were removing non-editable content during a delete.

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData): Set m_startRoot and m_endRoot. (WebCore::DeleteSelectionCommand::removeNode): If a node is not inside both the start and end roots, remove it only if it is in editable content.
  • editing/DeleteSelectionCommand.h: Added m_startRoot and m_endRoot, the editable roots that contain the start and end of the selection, respectively. We consult these every time we remove a node, and don't want to recompute them on every call to removeNode().
1:39 PM Changeset in webkit [20706] by sfalken
  • 19 edits in branches/Safari-522/WebCore

Roll out r20705,r20701

11:24 AM Changeset in webkit [20705] by sfalken
  • 1 edit in branches/Safari-522/WebCore/loader/DocLoader.cpp

Fix merge from r20674

10:33 AM Changeset in webkit [20704] by zbujtas
  • 3 edits in S60/trunk/WebCore

2007-04-04 bujtas <​zbujtas@gmail.com>

Reviewed by Sriram.
DESC: change nested <q> behavior so that q q {} gets ' instead of " -antti(c).
​http://bugs.webkit.org/show_bug.cgi?id=13280


  • khtml/css/html4.css:
  • khtml/css/html4_gcce.css:
10:30 AM Changeset in webkit [20703] by andersca
  • 2 edits in trunk/WebKit

Reviewed by John.

<rdar://problem/5107536>
​http://bugs.webkit.org/show_bug.cgi?id=13264
REGRESSION: Crash when canceling about:blank in Activity viewer


  • WebView/WebFrame.mm: (-[WebFrame stopLoading]): Add a null check for the frame loader - it can be null when the frame has been disconnected from the web page.
10:28 AM Changeset in webkit [20702] by zbujtas
  • 3 edits in S60/branches/3.1m/WebCore

2007-04-04 bujtas <​zbujtas@gmail.com>

Reviewed by Sriram.
DESC: change nested <q> behavior so that q q {} gets ' instead of "
​http://bugs.webkit.org/show_bug.cgi?id=13280


  • khtml/css/html4.css:
  • khtml/css/html4_gcce.css:
10:28 AM Changeset in webkit [20701] by sfalken
  • 19 edits in branches/Safari-522/WebCore

Merged fix from r20674

10:12 AM Changeset in webkit [20700] by sfalken
  • 2 edits in branches/Safari-522/WebCore

Merged fix from r20669

9:47 AM Changeset in webkit [20699] by andersca
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Turn's out Brady's not the only one who can rewrite history!

1:25 AM Changeset in webkit [23226] by aroben
  • 2 edits in branches/WindowsMerge/LayoutTests
  • Skipped: Re-enable some tests that no longer crash.

Apr 3, 2007:

11:39 PM Changeset in webkit [20698] by thatcher
  • 6 edits
    2 deletes in branches/WebInspectorRefresh/WebKit/WebInspector

Convert the Web Inspector NSOutlineView into an HTML and JavaScript based tree view. Not everything is working yet.

11:36 PM Changeset in webkit [20697] by thatcher
  • 1 copy in branches/WebInspectorRefresh

New branch to update the Web Inspector to use more HTML and JavaScript and remove the NSOutlineView.

10:55 PM Changeset in webkit [23225] by aroben
  • 6 edits in branches/WindowsMerge

WebKitToolsWin:

Reviewed by Anders.

DRT part of fix for <rdar://problem/5103999> All dom/svg tests are
failing due to extra/missing newlines

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dump): Call IDOMElementPrivate::innerText to match Mac DRT.

WebKitWin:

Reviewed by Anders.

WebKit part of fix for <rdar://problem/5103999> All dom/svg tests are
failing due to extra/missing newlines

  • DOMCoreClasses.cpp: (DOMElement::innerText): Added.
  • DOMCoreClasses.h: Added declaration.
  • Interfaces/DOMPrivate.idl: Ditto.
10:32 PM Changeset in webkit [23224] by aroben
  • 2 edits in branches/WindowsMerge/WebKitTools

Rubberstamped by Adele.

Make all layout tests paint to match Mac DRT. This fixes many tests in
svg/hixie.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dump): Always force a paint.
7:12 PM Changeset in webkit [20696] by kmccullo
  • 2 edits in trunk/JavaScriptCore

Reviewed by Adam.

  • Testing a post-commit hook.
6:32 PM Changeset in webkit [20695] by andersca
  • 4 edits in trunk

JavaScriptCore:

Reviewed by Adam.

<rdar://problem/5107534>
​http://bugs.webkit.org/show_bug.cgi?id=13265
REGRESSION: Crash in KJS::Bindings::convertValueToNPVariant


  • bindings/NP_jsobject.cpp: (_NPN_InvokeDefault): Return false if the object isn't a function.

LayoutTests:

Reviewed by Adam.

<rdar://problem/5107534>
​http://bugs.webkit.org/show_bug.cgi?id=13265
REGRESSION: Crash in KJS::Bindings::convertValueToNPVariant

  • plugins/netscape-invoke-default.html: Test calling NPN_InvokeDefault on an object that isn't a function.
5:22 PM Changeset in webkit [20694] by andersca
  • 7 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

<rdar://problem/5028178>
Crash occurs at WebCore::FrameLoader::activeDocumentLoader() after loading Froggster widget

  • plugins/get-url-that-the-resource-load-delegate-will-disallow-expected.txt: Added.
  • plugins/get-url-that-the-resource-load-delegate-will-disallow.html: Added.

WebKit:

Reviewed by Darin.

<rdar://problem/5028178>
Crash occurs at WebCore::FrameLoader::activeDocumentLoader() after loading Froggster widget


  • Plugins/WebNetscapePluginStream.mm: (-[WebNetscapePluginStream start]): If load returns no the plugin loader has already been removed by the didFail callback.

WebKitTools:

Reviewed by Darin.

Add the notion of a "disallowed URL", which the resource loader won't allow to be loaded.


  • DumpRenderTree/DumpRenderTree.h:
  • DumpRenderTree/DumpRenderTree.m: (dumpRenderTree): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController addDisallowedURL:]): (runTest):
  • DumpRenderTree/ResourceLoadDelegate.m: (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
4:31 PM Changeset in webkit [20693] by hyatt
  • 2 edits in trunk/WebCore

Fix for <rdar://problem/5108896>, make sure the assert for setEncodedSize
deals with the error case.

Reviewed by andersca

  • loader/CachedResource.cpp: (WebCore::CachedResource::setEncodedSize):
4:22 PM Changeset in webkit [20692] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • loader/ImageDocument.cpp: Don't call error() in stopParsing.
3:50 PM Changeset in webkit [20691] by justing
  • 5 edits
    1 delete in trunk/LayoutTests

Reviewed by darin


<​http://bugs.webkit.org/show_bug.cgi?id=13268>
Make editing/selection/drag-in-iframe.html valid and deterministic

  • editing/resources/select-and-drag-iframe.html: Removed.
  • editing/selection/drag-in-iframe-expected.checksum:
  • editing/selection/drag-in-iframe-expected.png:
  • editing/selection/drag-in-iframe-expected.txt:
  • editing/selection/drag-in-iframe.html:
3:12 PM Changeset in webkit [23223] by oliver
  • 2 edits in branches/WindowsMerge/WebCore

2007-04-03 Oliver Hunt <​oliver@apple.com>

Buildfix

  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::doUpdateResourceResponse):

Adding .get() calls

3:07 PM Changeset in webkit [20690] by adele
  • 4 edits in trunk/LayoutTests

Updated results for recent change to always lighten disabled text color for black text.

  • fast/forms/input-disabled-color-expected.checksum:
  • fast/forms/input-disabled-color-expected.png:
  • fast/forms/input-disabled-color-expected.txt:
2:57 PM Changeset in webkit [20689] by justing
  • 119 edits in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/5107422>
TOT REGRESSION: Delete key fails to delete text, and cursor disappears in Mail.app

moveParagraphs no longer calls shouldInsert:

  • editing/deleting/delete-3857753-fix-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
  • editing/deleting/delete-block-merge-contents-001-expected.txt:
  • editing/deleting/delete-block-merge-contents-002-expected.txt:
  • editing/deleting/delete-block-merge-contents-003-expected.txt:
  • editing/deleting/delete-block-merge-contents-004-expected.txt:
  • editing/deleting/delete-block-merge-contents-005-expected.txt:
  • editing/deleting/delete-block-merge-contents-006-expected.txt:
  • editing/deleting/delete-block-merge-contents-007-expected.txt:
  • editing/deleting/delete-block-merge-contents-008-expected.txt:
  • editing/deleting/delete-block-merge-contents-009-expected.txt:
  • editing/deleting/delete-block-merge-contents-010-expected.txt:
  • editing/deleting/delete-block-merge-contents-012-expected.txt:
  • editing/deleting/delete-block-merge-contents-013-expected.txt:
  • editing/deleting/delete-block-merge-contents-014-expected.txt:
  • editing/deleting/delete-block-merge-contents-015-expected.txt:
  • editing/deleting/delete-block-merge-contents-016-expected.txt:
  • editing/deleting/delete-block-merge-contents-017-expected.txt:
  • editing/deleting/delete-block-merge-contents-018-expected.txt:
  • editing/deleting/delete-block-merge-contents-019-expected.txt:
  • editing/deleting/delete-block-merge-contents-020-expected.txt:
  • editing/deleting/delete-block-merge-contents-021-expected.txt:
  • editing/deleting/delete-block-merge-contents-022-expected.txt:
  • editing/deleting/delete-block-table-expected.txt:
  • editing/deleting/delete-br-010-expected.txt:
  • editing/deleting/delete-line-002-expected.txt:
  • editing/deleting/delete-line-004-expected.txt:
  • editing/deleting/delete-line-006-expected.txt:
  • editing/deleting/delete-line-007-expected.txt:
  • editing/deleting/delete-line-008-expected.txt:
  • editing/deleting/delete-line-011-expected.txt:
  • editing/deleting/delete-line-012-expected.txt:
  • editing/deleting/delete-listitem-001-expected.txt:
  • editing/deleting/delete-to-end-of-paragraph-expected.txt:
  • editing/deleting/merge-different-styles-expected.txt:
  • editing/deleting/merge-no-br-expected.txt:
  • editing/deleting/pruning-after-merge-1-expected.txt:
  • editing/deleting/pruning-after-merge-2-expected.txt:
  • editing/execCommand/create-list-from-range-selection-expected.txt:
  • editing/execCommand/create-list-with-hr-expected.txt:
  • editing/execCommand/format-block-expected.txt:
  • editing/execCommand/format-block-from-range-selection-expected.txt:
  • editing/execCommand/format-block-with-braces-expected.txt:
  • editing/execCommand/format-block-with-trailing-br-expected.txt:
  • editing/execCommand/indent-list-item-expected.txt:
  • editing/execCommand/indent-selection-expected.txt:
  • editing/execCommand/insert-list-and-stitch-expected.txt:
  • editing/execCommand/insert-list-with-id-expected.txt:
  • editing/execCommand/nsresponder-indent-expected.txt:
  • editing/execCommand/outdent-selection-expected.txt:
  • editing/execCommand/queryCommandState-01-expected.txt:
  • editing/execCommand/remove-list-1-expected.txt:
  • editing/execCommand/remove-list-from-range-selection-expected.txt:
  • editing/execCommand/remove-list-item-1-expected.txt:
  • editing/execCommand/remove-list-items-expected.txt:
  • editing/execCommand/switch-list-type-expected.txt:
  • editing/inserting/insert-3907422-fix-expected.txt:
  • editing/inserting/insert-div-026-expected.txt:
  • editing/inserting/multiple-lines-selected-expected.txt:
  • editing/inserting/return-key-with-selection-001-expected.txt:
  • editing/inserting/return-key-with-selection-002-expected.txt:
  • editing/pasteboard/4076267-2-expected.txt:
  • editing/pasteboard/4700297-expected.txt:
  • editing/pasteboard/8145-3-expected.txt:
  • editing/pasteboard/display-block-on-spans-expected.txt:
  • editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
  • editing/pasteboard/interchange-newline-1-expected.txt:
  • editing/pasteboard/interchange-newline-2-expected.txt:
  • editing/pasteboard/merge-after-delete-1-expected.txt:
  • editing/pasteboard/merge-after-delete-2-expected.txt:
  • editing/pasteboard/merge-after-delete-expected.txt:
  • editing/pasteboard/merge-end-1-expected.txt:
  • editing/pasteboard/merge-end-2-expected.txt:
  • editing/pasteboard/merge-end-3-expected.txt:
  • editing/pasteboard/merge-end-4-expected.txt:
  • editing/pasteboard/merge-end-5-expected.txt:
  • editing/pasteboard/merge-end-blockquote-expected.txt:
  • editing/pasteboard/merge-end-borders-expected.txt:
  • editing/pasteboard/merge-end-list-expected.txt:
  • editing/pasteboard/merge-end-table-expected.txt:
  • editing/pasteboard/paste-line-endings-007-expected.txt:
  • editing/pasteboard/paste-line-endings-008-expected.txt:
  • editing/pasteboard/paste-line-endings-009-expected.txt:
  • editing/pasteboard/paste-match-style-001-expected.txt:
  • editing/pasteboard/paste-text-002-expected.txt:
  • editing/pasteboard/paste-text-003-expected.txt:
  • editing/pasteboard/paste-text-004-expected.txt:
  • editing/pasteboard/paste-text-005-expected.txt:
  • editing/pasteboard/paste-text-006-expected.txt:
  • editing/pasteboard/paste-text-008-expected.txt:
  • editing/pasteboard/paste-text-009-expected.txt:
  • editing/pasteboard/paste-text-010-expected.txt:
  • editing/pasteboard/smart-paste-001-expected.txt:
  • editing/pasteboard/smart-paste-002-expected.txt:
  • editing/pasteboard/smart-paste-003-expected.txt:
  • editing/pasteboard/smart-paste-004-expected.txt:
  • editing/pasteboard/smart-paste-005-expected.txt:
  • editing/pasteboard/smart-paste-006-expected.txt:
  • editing/pasteboard/smart-paste-007-expected.txt:
  • editing/pasteboard/smart-paste-008-expected.txt:
  • editing/style/create-block-for-style-001-expected.txt:
  • editing/style/create-block-for-style-002-expected.txt:
  • editing/style/create-block-for-style-003-expected.txt:
  • editing/style/create-block-for-style-004-expected.txt:
  • editing/style/create-block-for-style-007-expected.txt:
  • editing/style/create-block-for-style-009-expected.txt:
  • editing/style/create-block-for-style-010-expected.txt:
  • editing/style/create-block-for-style-011-expected.txt:
  • editing/style/create-block-for-style-012-expected.txt:
  • editing/style/create-block-for-style-013-expected.txt:
  • editing/style/smoosh-styles-001-expected.txt:
  • editing/style/smoosh-styles-002-expected.txt:
  • editing/style/style-boundary-005-expected.txt:
  • editing/unsupported-content/list-delete-001-expected.txt:

WebCore:

Reviewed by darin


<rdar://problem/5107422>
TOT REGRESSION: Delete key fails to delete text, and cursor disappears in Mail.app
<rdar://problem/5107413>
TOT REGRESSION: Crash deleting text in email (infinite recursion in shouldInsertNode)

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Back out the call to shouldInsert until we add WebViewInsertActionMoved, because Mail returns NO from shouldInsert for WebViewInsertActionPasted to override our Paste operation.
2:39 PM Changeset in webkit [20688] by andersca
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Mitz.

Add tests for innerWidth/innerHeight and clientWidth/clientHeight in quirks mode.

Modify the strict clientWidth/clientHeight test to test the behavior with scrollbars visible.


  • fast/dom/client-width-height-quirks-expected.txt: Added.
  • fast/dom/client-width-height-quirks.html: Added.
  • fast/dom/client-width-height.html:
  • fast/dom/inner-width-height-expected.txt: Added.
  • fast/dom/inner-width-height.html: Added.

WebCore:

Reviewed by Mitz.

Make window.innerWidth/innerHeight include the size of any present scrollbar to match Firefox.


Make document.body.clientWidth/clientHeight return the width/height of the visible content when in
quirks mode to match WinIE.


  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty): Return the width and height of the scroll view, not the visible width and height.


  • dom/Element.cpp: (WebCore::Element::clientWidth): (WebCore::Element::clientHeight): Return the visible size if the element is the body element and we're in quirks mode.
1:51 PM Changeset in webkit [20687] by spadma
  • 4 edits in S60/branches/3.1m/WebKit

2007-03-30 ligman <​joseph.ligman@nokia.com>

Reviewed by Sachin.
DESC: When the request dispatcher does not define a loader

no pending transaction will exist, so set this undefined status
to KErrCancel so the callers don't wait indefinitely. Also, create, use,
and close the download property string when it's needed to avoid closing
the rstring after the string pool which it's using has somehow gone away.

​http://bugs.webkit.org/show_bug.cgi?id=13232

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
  • ResourceLoader/inc/BaseTransaction.h:
  • ResourceLoader/src/HttpTransaction.cpp: (CHttpTransaction::~CHttpTransaction): (CHttpTransaction::MHFRunL): (CHttpTransaction::MHFRunError): (CHttpTransaction::HandleGotResponseHeadersL):
1:50 PM Changeset in webkit [20686] by spadma
  • 4 edits in S60/trunk/WebKit

2007-03-30 ligman <​joseph.ligman@nokia.com>

Reviewed by Sachin.
DESC: When the request dispatcher does not define a loader

no pending transaction will exist, so set this undefined status
to KErrCancel so the callers don't wait indefinitely. Also, create, use,
and close the download property string when it's needed to avoid closing
the rstring after the string pool which it's using has somehow gone away.

​http://bugs.webkit.org/show_bug.cgi?id=13232

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
  • ResourceLoader/inc/BaseTransaction.h:
  • ResourceLoader/src/HttpTransaction.cpp: (CHttpTransaction::~CHttpTransaction): (CHttpTransaction::MHFRunL): (CHttpTransaction::MHFRunError): (CHttpTransaction::HandleGotResponseHeadersL):
1:15 PM Changeset in webkit [23222] by mjs
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Alice.

  • fixed <rdar://problem/5107069> WebCore leaks a copy of the CFHTTPMessage CFDictionary (from CFHTTPMessageCopyAllHeaderFields)
  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::doUpdateResourceResponse): Use RetainPtr (once to avoid a leak and once just as style cleanup).
12:22 PM Changeset in webkit [20685] by adele
  • 3 edits in trunk/WebCore

Reviewed by Darin.

Updated fix for <rdar://problem/5107095> REGRESSION: disabled text color calculations are slowing down launchtime measurements

  • platform/graphics/Color.cpp: Moved optimization for lightening black and darkening white into the Color class. (WebCore::Color::light): (WebCore::Color::dark):
  • rendering/RenderTextControl.cpp: (WebCore::disabledTextColor): Skip the difference calculation for black text, which will always be lightened.
11:35 AM Changeset in webkit [20684] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Tim.

<rdar://problem/4649516>
Turn off slow script dialog or crank up time that makes it come up


  • bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::ScriptInterpreter): Increase the timeout to 10 seconds to match Firefox.
11:30 AM Changeset in webkit [23221] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Fix crashes seen when running the plugin layout tests.


  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::load): Fill in the enumerate pointer, not the evaluate pointer (it's already been filled in).


  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::didFinishLoading): Handle the case where there was no plugin stream data at all.
7:51 AM Changeset in webkit [20683] by yongjzha
  • 3 edits in S60/branches/3.1m/WebKit

2007-03-27 raalexan <​rasvan.alexandrescu@nokia.com>

Reviewed by Yongjun.
DESC: Connection shown as Normal in secure page
​http://bugs.webkit.org/show_bug.cgi?id=13206
TSW ID: HMNN-6ZGH6J

  • BrowserControl/src/BrCtl.cpp: (CBrCtl::CertInfo):
  • BrowserControl/src/WmlDispatcher.cpp: (CWmlDispatcher::HeadersL):
7:44 AM Changeset in webkit [20682] by yongjzha
  • 2 edits in S60/trunk/WebKit

rathnasa, reviewed by Yongjun.

DESC: Reset the iDownloadContent flag properly.

TSW Id: TKWG-6Z477F-Browser auto exit when browsing web Page

​http://bugs.webkit.org/show_bug.cgi?id=13207

  • ResourceLoader/src/DefaultContentHandler.cpp: (CDefaultContentHandler::ProcessHeadersL):
7:39 AM Changeset in webkit [20681] by yongjzha
  • 4 edits in S60/branches/3.1m/WebKit

2007-04-02 hongzhao <set EMAIL_ADDRESS environment variable>

Reviewed by ​yongjun.zhang@nokia.com
DESC: [S60]Animated images with DRM content won't be displayed in Browser in 3.1m.
Fix: Handle DRM image content during construct the content.
​http://bugs.webkit.org/show_bug.cgi?id=13258

  • BrowserCore/Renderers/inc/AnimationDecoder.h:
  • BrowserCore/Renderers/inc/StaticImageDecoder.h:
  • BrowserCore/Renderers/src/StaticImageDecoder.cpp: (CRawData::ConstructL): (CRawData::DecodeDRMImageContentL): (CStaticImageDecoder::LoadNextImage):
7:29 AM Changeset in webkit [20680] by yongjzha
  • 3 edits in S60/branches/3.1m/WebKit

2007-04-02 ligman <​joseph.ligman@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com
DESC: Animated gif in xhtml fails. Start the animation timer for single scaled animated bitmaps.
​http://bugs.webkit.org/show_bug.cgi?id=13254

  • BrowserCore/Renderers/inc/ImageRenderer.h: (CImageRenderer::GetParent):
  • BrowserCore/Renderers/src/ImageRenderer.cpp: (CImageRenderer::DrawImageInRect): (NextFrameCb): (CImageRenderer::NextFrame): (CImageRenderer::InitAnimationCallback):
7:26 AM Changeset in webkit [20679] by yongjzha
  • 3 edits in S60/trunk/WebKit

ligman, reviewed by <reviewer>

DESC: Animated gif in xhtml fails. Start animation timer for single animated gifs
​http://bugs.webkit.org/show_bug.cgi?id=13255

  • BrowserCore/Renderers/inc/ImageRenderer.h: (CImageRenderer::GetParent):
  • BrowserCore/Renderers/src/ImageRenderer.cpp: (CImageRenderer::DrawImageInRect): (NextFrameCb): (CImageRenderer::NextFrame): (CImageRenderer::InitAnimationCallback):
5:56 AM Changeset in webkit [20678] by bdash
  • 8 edits in trunk

2007-04-03 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Covered by existing editing tests.

  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::getFloatValue): Added ASSERTs that the requested conversion is from a scalar type to a scalar type. The intermittent failures in the test were the result of trying to convert an identifier type to a scalar type.
  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::checkForLegacyHTMLStyleChange): Added a check that the font-size property value is an absolute length. If it is not (such as in the case of relative units or keywords like "x-large"), then no corresponding 'size' attribute will be generated for legacy HTML.

2007-04-03 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • editing/style/block-style-004-expected.txt:
  • editing/style/block-style-005-expected.txt:
  • editing/style/block-style-006-expected.txt:
  • editing/style/fontsize-1-expected.txt:
5:51 AM Changeset in webkit [20677] by bdash
  • 2 edits
    1 add in trunk/WebCore

2007-04-03 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • manual-tests/stale-currentEvent.html: Added.
  • page/EventHandler.cpp: (WebCore::EventHandler::hoverTimerFired): Instead of faking a mouse event, just hit-test the last mouse event coordinates and update for hover state changes. This eliminates the use of currentEvent, which can be a non-mouse event or even a stale event.
4:24 AM Changeset in webkit [20676] by bdash
  • 2 edits in trunk/WebKitTools

2007-04-03 Mark Rowe <​mrowe@apple.com>

Reviewed by Antti.

  • BuildSlaveSupport/build-launcher-dmg: Use bzip2 compression in nightly build disk images rather than gzip.

Apr 2, 2007:

10:54 PM Changeset in webkit [20675] by adele
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/5107095> REGRESSION: disabled text color calculations are slowing down launchtime measurements

Hardcode disabled text colors for the most common cases- black and white.

  • rendering/RenderTextControl.cpp: (WebCore::disabledTextColor):
6:11 PM Changeset in webkit [20674] by hyatt
  • 19 edits in trunk/WebCore

Fix for <rdar://problem/5105784>, assertion failure in cache. Encoded sizes were being set to
garbage by accident because of a mismatch between derived class and base class constructors. This
patch cleans all of this up and gets rid of expiration date as a concept separate from the response.

Reviewed by anders

  • dom/Document.cpp: (WebCore::Document::processHttpEquiv):
  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::updateFromElement):
  • loader/Cache.cpp: (WebCore::createResource): (WebCore::Cache::requestResource):
  • loader/Cache.h:
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
  • loader/CachedCSSStyleSheet.h:
  • loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage):
  • loader/CachedImage.h:
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::finish):
  • loader/CachedResource.h:
  • loader/CachedScript.cpp: (WebCore::CachedScript::CachedScript):
  • loader/CachedScript.h:
  • loader/CachedXBLDocument.cpp: (WebCore::CachedXBLDocument::CachedXBLDocument):
  • loader/CachedXBLDocument.h:
  • loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
  • loader/CachedXSLStyleSheet.h:
  • loader/DocLoader.cpp: (WebCore::DocLoader::DocLoader): (WebCore::DocLoader::requestResource):
  • loader/DocLoader.h:
6:01 PM Changeset in webkit [20673] by antti
  • 7 edits in trunk/WebCore

Reviewed by Hyatt.

Render tree memory savings, part 3


These changes shrink all RenderBlocks by additional 28 bytes. Together with parts 1 and 2
RenderBlock goes from 172 bytes to 128 bytes, a saving of 26%.


  • Pack bitfields together in RenderFlow
  • Move top/bottom min/max margin values to a struct that is only allocated in case these variables have non default values. Usually this is <5% of all blocks.
  • Move rarely used column variables to hash
  • rendering/RenderBlock.cpp: (WebCore::ColumnInfo::ColumnInfo): (WebCore::RenderBlock::RenderBlock): (WebCore::RenderBlock::~RenderBlock): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::collapseMargins): (WebCore::RenderBlock::clearFloatsIfNeeded): (WebCore::RenderBlock::setCollapsedBottomMargin): (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::paintColumns): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::fillSelectionGaps): (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestColumns): (WebCore::RenderBlock::positionForCoordinates): (WebCore::RenderBlock::availableWidth): (WebCore::RenderBlock::calcColumnWidth): (WebCore::RenderBlock::setDesiredColumnCountAndWidth): (WebCore::RenderBlock::desiredColumnWidth): (WebCore::RenderBlock::desiredColumnCount): (WebCore::RenderBlock::columnRects): (WebCore::RenderBlock::layoutColumns): (WebCore::RenderBlock::adjustPointToColumnContents): (WebCore::RenderBlock::adjustRectForColumns): (WebCore::RenderBlock::setMaxTopMargins): (WebCore::RenderBlock::setMaxBottomMargins):
  • rendering/RenderBlock.h: (WebCore::RenderBlock::maxTopMargin): (WebCore::RenderBlock::maxBottomMargin): (WebCore::RenderBlock::maxTopPosMargin): (WebCore::RenderBlock::maxTopNegMargin): (WebCore::RenderBlock::maxBottomPosMargin): (WebCore::RenderBlock::maxBottomNegMargin): (WebCore::RenderBlock::initMaxMarginValues): (WebCore::RenderBlock::MaxMargin::MaxMargin): (WebCore::RenderBlock::MaxMargin::topPosDefault): (WebCore::RenderBlock::MaxMargin::topNegDefault): (WebCore::RenderBlock::MaxMargin::bottomPosDefault): (WebCore::RenderBlock::MaxMargin::bottomNegDefault):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock):
  • rendering/RenderFlow.h: (WebCore::RenderFlow::RenderFlow): (WebCore::RenderFlow::hasColumns):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::RenderInline):
  • rendering/RenderInline.h:
6:00 PM Changeset in webkit [23220] by sfalken
  • 4 edits in branches/WindowsMerge/WebKitWin
5:54 PM Changeset in webkit [23219] by andersca
  • 4 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

Check that NPStream pointers passed to NPN_DestroyStream are valid.


  • plugins/win/PluginStreamWin.cpp: (WebCore::streams): (WebCore::PluginStreamWin::PluginStreamWin): (WebCore::PluginStreamWin::~PluginStreamWin): (WebCore::PluginStreamWin::ownerForStream):
  • plugins/win/PluginStreamWin.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::destroyStream):
5:22 PM Changeset in webkit [20672] by antti
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.


Test you don't crash when you have abs positioned elements inside rel inline.

  • fast/block/positioning/abs-inside-inline-rel-expected.checksum: Added.
  • fast/block/positioning/abs-inside-inline-rel-expected.png: Added.
  • fast/block/positioning/abs-inside-inline-rel-expected.txt: Added.
  • fast/block/positioning/abs-inside-inline-rel.html: Added.

WebCore:

Reviewed by Hyatt.

Fix asserts, these may also be called for rel positioned elements

  • rendering/RenderBox.cpp: (WebCore::RenderBox::setStaticX): (WebCore::RenderBox::setStaticY):
4:49 PM Changeset in webkit [20671] by andersca
  • 4 edits in trunk/WebKit

Reviewed by Geoff.

Fix crash when running plugins/destroy-stream-twice.html under GuardMalloc

  • Plugins/WebBaseNetscapePluginStream.h:
  • Plugins/WebBaseNetscapePluginStream.mm: (+[WebBaseNetscapePluginStream ownerForStream:]): (-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]): (-[WebBaseNetscapePluginStream dealloc]): (-[WebBaseNetscapePluginStream finalize]): Change the streams hash map to contain an NPStream*, and change ownerForStream to take an NPStream*.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView destroyStream:reason:]): Check that the NPStream pointer is valid before accessing stream->ndata.
4:41 PM Changeset in webkit [20670] by hyatt
  • 2 edits in trunk/WebCore

Throw in an assert to try to track down a problem where an image is being set to a smaller encoded
size.

  • loader/CachedResource.cpp: (WebCore::CachedResource::setEncodedSize):
4:32 PM Changeset in webkit [23218] by andersca
  • 4 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

<rdar://problem/5095582>
PluginViewWin doesn't implement NPN_DestroyStream.

  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::startStream): Handle the case where NPN_DestroyStream is called from the newstream handler.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::destroyStream): Implement this.
3:29 PM Changeset in webkit [20669] by adachan
  • 2 edits in trunk/WebCore

2007-04-02 Ada Chan <​adachan@apple.com>

Reviewed by Adele.

<rdar://5105331> Missing null check in Editor::execCommand
Added null check.

  • editing/Editor.cpp: (WebCore::Editor::execCommand):
3:19 PM Changeset in webkit [23217] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Dave Hyatt.

<rdar://problem/5097225>
Mouse cursors don't work with windowless plugins


  • platform/win/WidgetWin.cpp: (WebCore::Widget::setCursor): Add an "ignoreNextSetCursor" boolean and don't call SetCursor if it's true.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::handleMouseEvent): Store away the current cursor and make sure that it won't be reset.
2:28 PM Changeset in webkit [23216] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Fix logic in windowless paint functions.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::invalidateRect): (WebCore::PluginViewWin::invalidateRegion): (WebCore::PluginViewWin::forceRedraw):
2:15 PM Changeset in webkit [20668] by darin
  • 3 edits in trunk/WebKit

Reviewed by Geoff.

  • set clip path for CoreGraphics plug-ins in the same way we do for QuickDraw plug-ins this is a better fix for <rdar://problem/4939511> WebKit should set the the CG clip path for plug-ins that draw using Core Graphics

Incorporates changes from a patch by Mark Ambachtsheer.

Here are the changes:

1) Don't try to use the offscreen code path if GGBitmapContextGetData returns 0.
2) Handle kCGBitmapByteOrderDefault when computing the QD pixel format, even though

we don't have any evidence that this happens in practice.

3) Keep the GWorld around until we create a new one or the plug-in is destroyed.
4) Use the GWorld pointer itself as a flag to indicate whether we are using an

offscreen GWorld.

5) Set up clipping for CoreGraphics in the same way we do for QuickDraw; remove an

earlier attempt that handled CoreGraphics differently.

  • Plugins/WebBaseNetscapePluginView.h: Added a field named offscreenGWorld to hold the GWorld until it's needed.
  • Plugins/WebBaseNetscapePluginView.mm: (getQDPixelFormatForBitmapContext): Replaced QDPixelFormatFromCGBitmapInfo. Used the "get" prefix so we don't intrude on the QD namespace. Added code to handle the kCGBitmapByteOrderDefault case, although I'm not sure it will really come up in practice -- it wasn't really coming up in the buggy case. (getNPRect): Added helper functions. Used to make the code below clearer. (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Use getNPRect to streamline code. Use GetGWorld to save the port since we use SetGWorld to restore it later. Store the GWorld we create in the offscreenGWorld field and dispose the existing one. Don't treat the CGBitmapContext as an offscreen bitmap if it has a data pointer of 0. Set up the clip based on the result of -[NSView getRectsBeingDrawn:count] when setting up the port for CoreGraphics (after saving the port state). (-[WebBaseNetscapePluginView restorePortState:]): Remove now-unneeded code to destroy the offscreen GWorld, and simplified the code that restores the port so we don't need a separate case for offscreen. (-[WebBaseNetscapePluginView fini]): Renamed from freeAttributeKeysAndValues, since this method now does more than just the attributes. This is the shared method that does things needed in both dealloc and finalize. Added a call to DisposeGWorld here. (-[WebBaseNetscapePluginView dealloc]): Updated for name change. (-[WebBaseNetscapePluginView finalize]): Ditto. (-[WebBaseNetscapePluginView drawRect:]): Removed code to set clip. This is done in the saveAndSetNewPortStateForUpdate: method instead.
1:38 PM Changeset in webkit [20667] by zbujtas
  • 2 edits in S60/branches/3.1m/WebCore

2007-03-30 jadhan <​jade.han@nokia.com>

Reviewed by Zalan <​zbujtas@gmail.com>
DESC: special handling for utf8 encoding of danish character. Merged fix from 3.2 to 3.1
​http://bugs.webkit.org/show_bug.cgi?id=13231

WARNING: NO TEST CASES ADDED OR CHANGED

  • ChangeLog:
  • kwq/KWQTextCodec.cpp: (validateUtf8):
1:30 PM Changeset in webkit [23215] by andersca
  • 2 edits in branches/WindowsMerge/WebKitTools
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Add TestNetscapeObject project.
1:23 PM Changeset in webkit [23214] by andersca
  • 1 edit in branches/WindowsMerge/WebKitTools/ChangeLog

Adam is not a nobody.

1:23 PM Changeset in webkit [23213] by andersca
  • 4 edits
    4 adds in branches/WindowsMerge/WebKitTools

WebKitToolsWin:

Reviewed by NOBODY (OOPS!).

Add netscape test plugin VC project. Make DumpRenderTree look for the test plugin.


12:46 PM Changeset in webkit [20666] by bdash
  • 5 edits in branches/Safari-522/WebKit

Merge r20571.

12:37 PM Changeset in webkit [20665] by bdash
  • 7 edits in branches/Safari-522

Merge r20593 and r20596.

12:33 PM Changeset in webkit [20664] by andersca
  • 2 edits in trunk/WebKitTools
  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Don't use #import in a header included by C files.
12:23 PM Changeset in webkit [20663] by bdash
  • 5 edits in branches/Safari-522

Merge r20555 and r20560.

11:37 AM Changeset in webkit [20662] by spadma
  • 4 edits in S60/trunk/WebKit

2007-04-02 bujtas <​zbujtas@gmail.com>

Reviewed by Sachin.
DESC: user hits cancel on connection dialog, send EventLoadError to the host app
​http://bugs.webkit.org/show_bug.cgi?id=13257

  • BrowserView/inc/WebKitControl.h:
  • BrowserView/src/HttpLoaderEventToUiListener.cpp: (CHttpLoaderEventToUiListener::ConnectionRequestCancelled):
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::HandleLoaderCommandL): (CWebKitControl::FinalProgressComplete):
11:37 AM Changeset in webkit [20661] by spadma
  • 4 edits in S60/branches/3.1m/WebKit

2007-04-02 bujtas <​zbujtas@gmail.com>

Reviewed by Sachin.
DESC: user hits cancel on connection dialog, send EventLoadError to the host app
​http://bugs.webkit.org/show_bug.cgi?id=13257

  • BrowserView/inc/WebKitControl.h:
  • BrowserView/src/HttpLoaderEventToUiListener.cpp: (CHttpLoaderEventToUiListener::ConnectionRequestCancelled):
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::HandleLoaderCommandL): (CWebKitControl::FinalProgressComplete):
11:23 AM Changeset in webkit [20660] by justing
  • 3 edits
    8 adds in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/5058163>
Hitting return inserts a new line between two To Dos, but caret is position after second ToDo

  • editing/inserting/5058163-1-expected.checksum: Added.
  • editing/inserting/5058163-1-expected.png: Added.
  • editing/inserting/5058163-1-expected.txt: Added.
  • editing/inserting/5058163-1.html: Added.
  • editing/inserting/5058163-2-expected.checksum: Added.
  • editing/inserting/5058163-2-expected.png: Added.
  • editing/inserting/5058163-2-expected.txt: Added.
  • editing/inserting/5058163-2.html: Added.

WebCore:

Reviewed by darin

<rdar://problem/5058163>
Hitting return inserts a new line between two To Dos, but caret is position after second ToDo

  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Removed refPos, it was unused. Don't assume that upstream() moves to a different node. This assumption caused the line break to be inserted *after* the caret and a bad position to be set (added a testcase). Use isStartOfParagraph instead of checking for the existence of a br because the line might be broken by a newline character in text that preserves newlines. Paragraphs that are created in other ways, like with blocks, are handled above (added a testcase).
11:22 AM Changeset in webkit [20659] by spadma
  • 5 edits in S60/trunk/WebKit

2007-04-02 bujtas <​zbujtas@gmail.com>

Reviewed by Sachin.
DESC: implement client side accept header support
​http://bugs.webkit.org/show_bug.cgi?id=13256

  • BrowserControl/src/BrCtl.cpp: (CBrCtl::SetParamL):
  • ResourceLoader/inc/LoaderContainer.h: (CLoaderContainer::ClientAcceptHeaders):
  • ResourceLoader/src/HttpTransaction.cpp: (CHttpTransaction::AddRequestHeadersL):
  • ResourceLoader/src/LoaderContainer.cpp: (CLoaderContainer::~CLoaderContainer): (CLoaderContainer::SetClientAcceptHeadersL):
11:22 AM Changeset in webkit [20658] by spadma
  • 5 edits in S60/branches/3.1m/WebKit

2007-04-02 bujtas <​zbujtas@gmail.com>

Reviewed by Sachin.
DESC: implement client side accept header support
​http://bugs.webkit.org/show_bug.cgi?id=13256

  • BrowserControl/src/BrCtl.cpp: (CBrCtl::SetParamL):
  • ResourceLoader/inc/LoaderContainer.h: (CLoaderContainer::ClientAcceptHeaders):
  • ResourceLoader/src/HttpTransaction.cpp: (CHttpTransaction::AddRequestHeadersL):
  • ResourceLoader/src/LoaderContainer.cpp: (CLoaderContainer::~CLoaderContainer): (CLoaderContainer::SetClientAcceptHeadersL):
10:39 AM Changeset in webkit [20657] by zbujtas
  • 3 edits in S60/trunk/WebCore

2007-04-02 yongjzha <​yonjun.zhang@nokia.com>

Reviewed by ​bjutas@gmail.com.
DESC: suppress false memory leaking alert.
​http://bugs.webkit.org/show_bug.cgi?id=13253

  • khtml/css/css_base.h: (DOM::):
  • khtml/css/cssparser.h: (DOM::Value::): (DOM::qString): (DOM::domString): (DOM::atomicString): (DOM::):
10:36 AM Changeset in webkit [20656] by harrison
  • 2 edits in trunk/WebCore

2007-04-02 David Harrison <​harrison@apple.com>

Reviewed by Darin.

<rdar://problem/4906488> text attributes are not working for frame based web page

Attribute handling now treats each WebArea as its own world, rather than sometimes
referring back up to the top WebArea. e.g. getting/setting the selection now
operates on the WebArea containing the WebCoreAXObject that is being messaged (self).
The methods that sit above this and are able to go into arbitrary WebAreas
are accessibilityFocusedUIElement and doAXTextMarkerForPosition, allowing VoiceOver
to navigate between frames.


  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject topRenderer]): (-[WebCoreAXObject frameView]): (-[WebCoreAXObject topFrameView]): Removed topDocument, renamed topView to topFrameView, added frameView.


(-[WebCoreAXObject accessibilityAttributeValue:]):
AXSelectedTextMarkerRange, AXStartTextMarker, and AXEndTextMarker now use
self's WebArea, rather than the top WebArea.


(-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
Use self's WebArea, rather than the top WebArea.

(-[WebCoreAXObject doAXTextMarkerForPosition:]):
Use renamed methods for accessing top WebArea.


(-[WebCoreAXObject doAXBoundsForTextMarkerRange:]):
Use renamed methods for accessing self's WebArea.

(AXAttributeStringSetColor):
(AXAttributeStringSetNumber):
(AXAttributeStringSetFont):
(AXAttributeStringSetStyle):
(AXAttributeStringSetElement):
(-[WebCoreAXObject rendererForView:]):
Clean up uses of nil and NULL.


(-[WebCoreAXObject accessibilityFocusedUIElement]):
Find the focused node on the whole page. If there is no focused node,
return the WebArea for the focused document.


(-[WebCoreAXObject doSetAXSelectedTextMarkerRange:]):
Use self's WebArea, rather than the top WebArea.

10:36 AM Changeset in webkit [20655] by zbujtas
  • 3 edits in S60/branches/3.1m/WebCore

2007-04-02 yongjzha <​yonjun.zhang@nokia.com>

Reviewed by ​bjutas@gmail.com.
DESC: suppress false memory leaking alert.
​http://bugs.webkit.org/show_bug.cgi?id=13253

  • khtml/css/css_base.h: (DOM::):
  • khtml/css/cssparser.h: (DOM::Value::): (DOM::qString): (DOM::domString): (DOM::atomicString): (DOM::):
3:06 AM Changeset in webkit [20654] by antti
  • 2 edits in trunk/WebCore

Fix build. This one was not supposed to be checked in.

  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock):
2:43 AM Changeset in webkit [20653] by antti
  • 9 edits in trunk/WebCore

Reviewed by Hyatt.

Render tree memory savings, part 2


  • Move staticX and staticY variables to RenderLayer since they are only applicable to positioned objects
  • Move very rarely used overrideSize variable to hash


These changes shrink all box types by 12 bytes

  • rendering/RenderBox.cpp: (WebCore::RenderBox::RenderBox): (WebCore::RenderBox::destroy): (WebCore::RenderBox::overrideSize): (WebCore::RenderBox::setOverrideSize): (WebCore::RenderBox::overrideWidth): (WebCore::RenderBox::overrideHeight): (WebCore::RenderBox::position): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcHeight): (WebCore::RenderBox::staticX): (WebCore::RenderBox::staticY): (WebCore::RenderBox::setStaticX): (WebCore::RenderBox::setStaticY): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteVertical): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
  • rendering/RenderBox.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::staticX): (WebCore::RenderLayer::staticY): (WebCore::RenderLayer::setStaticX): (WebCore::RenderLayer::setStaticY):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject):
  • rendering/RenderObject.h: (WebCore::): (WebCore::RenderObject::hasOverrideSize): (WebCore::RenderObject::setHasOverrideSize):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy):

Apr 1, 2007:

8:04 PM Changeset in webkit [20652] by sfalken
  • 1 copy in tags/Safari-522.5.4b

New tag.

4:29 PM Changeset in webkit [20651] by sfalken
  • 2 edits in branches/Safari-522/WebCore

Merge fix from r20570

4:27 PM Changeset in webkit [20650] by sfalken
  • 14 edits in branches/Safari-522

Merge fix from r20565

4:01 PM Changeset in webkit [20649] by kjk
  • 2 edits in trunk/WebCore

Not reviewed - gdk build fix.

  • platform/gdk/TemporaryLinkStubs.cpp: (Font::selectionRectForComplexText): (Font::drawComplexText):

Mar 31, 2007:

10:41 PM Changeset in webkit [20648] by ap
  • 2 edits in trunk/WebCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12778
REGRESSION: Nightly won't load Curl plugin for full page use

  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): Re-order cases to give more priority to plugins. This also fixes Adobe SVG Viewer and any plugins that register XML MIME types. Added a case for XHTML to avoid enumerating plugins.
10:33 PM Changeset in webkit [23212] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/platform/win/FontWin.cpp

Remove bogus comment.

10:30 PM Changeset in webkit [23211] by hyatt
  • 5 edits in branches/WindowsMerge/WebCore

Fix layout of justified selected text.

10:21 PM Changeset in webkit [20647] by hyatt
  • 4 adds in trunk/LayoutTests/fast/text
10:20 PM Changeset in webkit [20646] by hyatt
  • 13 edits in trunk/WebCore

Fix for bug 13234, layout of selected justified text is broken. Rework TextRuns to avoid having
from/to members. Let those be passed in only by the functions that need them (drawing and selection rect).

Reviewed by mitz

fast/text/justified-selection-at-edge.html

  • platform/Font.cpp: (WebCore::WidthIterator::WidthIterator): (WebCore::WidthIterator::advance): (WebCore::Font::canUseGlyphCache): (WebCore::Font::drawSimpleText): (WebCore::Font::drawText): (WebCore::Font::floatWidth): (WebCore::Font::floatWidthForSimpleText): (WebCore::Font::selectionRectForText): (WebCore::Font::selectionRectForSimpleText): (WebCore::Font::offsetForPositionForSimpleText):
  • platform/Font.h: (WebCore::TextRun::m_len):
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawText): (WebCore::GraphicsContext::drawHighlightForText):
  • platform/graphics/GraphicsContext.h:
  • platform/mac/FontMac.mm: (WebCore::addDirectionalOverride): (WebCore::overrideLayoutOperation): (WebCore::ATSULayoutParameters::initialize): (WebCore::Font::selectionRectForComplexText): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText):
  • platform/qt/FontQt.cpp: (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText):
  • platform/qt/TemporaryLinkStubs.cpp: (Font::selectionRectForComplexText):
  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::calcMinMaxWidth): (WebCore::RenderListMarker::getRelativeMarkerRect):
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateOptionsWidth):
  • rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache): (WebCore::RenderText::width):
10:04 PM Changeset in webkit [20645] by bdash
  • 2 edits in trunk/WebCore

2007-03-31 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

<rdar://problem/5103226>

REGRESSION (r20506): Repro crash/assert when using scroll wheel on a list box taller than its contents

  • platform/ScrollBar.cpp: (WebCore::Scrollbar::setValue): Cleaned up a little. (WebCore::Scrollbar::scroll): Changed to apply the minimum and maximum constraints in the right order, and cleaned up a little.
9:59 PM Changeset in webkit [20644] by andrew
  • 3 edits
    2 adds in trunk

2007-03-31 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • fast/images/text-content-crash-expected.txt: Added.
  • fast/images/text-content-crash.html: Added.

2007-03-31 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Test: fast/images/text-content-crash.html

  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute): Added a check that the renderer is an image. (WebCore::HTMLImageElement::attach): Ditto.
9:50 PM Changeset in webkit [20643] by bdash
  • 2 edits in trunk/WebKitTools

2007-03-31 Mark Rowe <​mrowe@apple.com>

Reviewed by Mitz.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=13239
Bug 13239: REGRESSION (r20343): Drosera hits exception trying to call "count" cross-process

Use -[WebScriptObject valueForKey:@"length"] to retrieve the length of a JavaScript array
rather than -[WebScriptObject count].

  • Drosera/DebuggerDocument.m: (-[DebuggerDocument webScriptAttributeKeysForScriptObject:]):
9:48 PM Changeset in webkit [20642] by bdash
  • 3 edits in trunk/WebCore

2007-03-31 Mark Rowe <​mrowe@apple.com>

Reviewed by Darin.

A more correct fix for ​http://bugs.webkit.org/show_bug.cgi?id=13129
Bug 13129: Democracy Player dies in NSException from WebScriptObject on startup

The previous attempt at a fix in r20343 attempted to conditionally expose the 'count'
method. It did not work which resulted in 'count' always being hidden. This change
disables -[WebScriptObject count] completely until it can be determined whether it is
needed and how to support it without breaking third-party applications.

  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject count]):
  • bindings/objc/WebScriptObjectPrivate.h:
9:28 PM Changeset in webkit [23210] by sfalken
  • 3 edits in branches/WindowsMerge/WebKitWin

Filesystem layout changes:

<rdar://problem/5091159> Boomer has no bundle identifier - is the bundle correctly formed?
<rdar://problem/5088764> Move the "Icon.db" file under "Local Settings"

11:24 AM Changeset in webkit [23209] by adele
  • 2 edits in branches/WindowsMerge/WebKitTools

Reviewed by Adam.

A little cleanup from my last change. Added a comment, and moved a JSStringRelease call to a better place.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: (keyDownCallback):
8:32 AM Changeset in webkit [20641] by ddkilzer
  • 3 edits in trunk/LayoutTests

Replaced bogus 'text/plain' svn property with svn:mime-type property set to 'text/javascript'.
Fixed one instance where 'allow-tabs' property and 'true' value were reversed.

4:30 AM Changeset in webkit [20640] by ddkilzer
  • 2 edits in trunk/LayoutTests/fast/js/resources

Replaced bogus 'text/plain' svn property with svn:mime-type property set to 'text/javascript'.

3:25 AM Changeset in webkit [20639] by ap
  • 2 edits
    4 adds in trunk

2007-03-31 Mitz Pettel <​mitz@webkit.org>

Reviewed by Sam Weinig.

  • pixel test for partially selected justified text
  • fast/text/justified-selection-expected.checksum: Added.
  • fast/text/justified-selection-expected.png: Added.
  • fast/text/justified-selection-expected.txt: Added.
  • fast/text/justified-selection.html: Added.
3:18 AM Changeset in webkit [20638] by ap
  • 1 edit
    4 adds in trunk/LayoutTests

2007-03-31 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

A layout test documenting shrink-to-fit width calculation for floating elements.

  • fast/block/float/shrink-to-fit-width-expected.checksum: Added.
  • fast/block/float/shrink-to-fit-width-expected.png: Added.
  • fast/block/float/shrink-to-fit-width-expected.txt: Added.
  • fast/block/float/shrink-to-fit-width.html: Added.
3:07 AM Changeset in webkit [20637] by ap
  • 3 edits
    2 adds in trunk

2007-03-31 Nicholas Shanks <​webkit@nickshanks.com>

Reviewed by Adele.

​http://bugs.webkit.org/show_bug.cgi?id=13184
HTMLImageElement longdesc should be complete resolved URL

Test: fast/dom/HTMLImageElement/image-longdesc-absolute-url.html

  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::longDesc): Return absolute URL. Behaviour now matches Firefox and Opera.
1:26 AM Changeset in webkit [20636] by ap
  • 5 edits
    4 adds in trunk

2007-03-31 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

Test: fast/repaint/list-marker-2.html

A list marker can increase the horizontal overflow after layoutInlineChildren(),
so made that function return only the vertical bounds of the repaint rect. As the
horizontal bounds, made layoutBlock() just use the overflow bounds after layout.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
  • rendering/RenderBlock.h:
  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
12:59 AM Changeset in webkit [20635] by ap
  • 3 edits
    4 adds in trunk

2007-03-31 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

Test: fast/text/wide-zero-width-space.html

  • platform/FontData.cpp: (WebCore::FontData::FontData): Force the ZERO WIDTH SPACE glyph to have width 0, unless the SPACE character maps to the same glyph.
12:49 AM Changeset in webkit [20634] by ap
  • 11 edits
    2 adds in trunk

2007-03-31 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

WebCore:

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): Made "<" terminate tag and attribute names. This matches Firefox.

LayoutTests:

  • fast/overflow/002-expected.checksum:
  • fast/overflow/002-expected.png:
  • fast/overflow/002-expected.txt:
  • fast/overflow/002.html: Added missing ">" to one of the BR tags.
  • fast/text/atsui-multiple-renderers-expected.checksum:
  • fast/text/atsui-multiple-renderers-expected.png:
  • fast/text/atsui-multiple-renderers-expected.txt:
  • fast/text/atsui-multiple-renderers.html: Added missing ">" to the TITLE tag.
  • fast/tokenizer/lessthan-terminates-tags-and-attrs-expected.txt: Added.
  • fast/tokenizer/lessthan-terminates-tags-and-attrs.html: Added.
Note: See TracTimeline for information about the timeline view.