Timeline



Apr 30, 2007:

11:05 PM Changeset in webkit [23337] by aliceli1
  • 7 edits in branches/WindowsMerge

WebKitToolsWin:

Reviewed by Adam.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (main): As a consequence of <rdar://5126201>, removed call to webView->close() and patched leak resulting from that change.

WebKitWin:

Reviewed by Adam.

Fixed <rdar://5126201> crash closing tab when the two following tabs are empty.
Basically this fix involved one thing, which lead to another thing. First, the crash
was fixed by moving the call to webView->close from SearchableWebView::onDestroy to
WebViewWndProc when WM_DESTROY message is processed. We now want only WebKit handling
the closure of a WebView, so all calls to WebView::close have been removed, save for
the one call in WebViewWndProc.

  • Interfaces/IWebView.idl: removed close() from public interface
  • WebInspector/WebInspector.cpp: (WebInspector::onDestroy): removed call to close()
  • WebView.cpp: (WebView::~WebView): move the deleting of m_page down a bit to avoid a crash (WebView::close): changed from public API to just a public function (WebViewWndProc): webView->close() was moved here from SearchableWebView::onDestroy
  • WebView.h: changed close() to a public function not exposed in the WebKit interface
9:57 PM Changeset in webkit [21199] by hyatt
  • 38 edits
    4 adds in trunk

LayoutTests:

Fix for bug 12691, generated content and display: table-cell duplicates
content on a size change. Make sure that the code to update before/after
content is smart enough to drill into anonymous containers to find the
old child.

Reviewed by olliej

  • fast/css-generated-content/table-cell-before-content-expected.checksum: Added.
  • fast/css-generated-content/table-cell-before-content-expected.png: Added.
  • fast/css-generated-content/table-cell-before-content-expected.txt: Added.
  • fast/css-generated-content/table-cell-before-content.html: Added.

WebCore:

Fix for bug 12691, generated content and display: table-cell duplicates
content on a size change. Make sure that the code to update before/after
content is smart enough to drill into anonymous containers to find the
old child.

Reviewed by olliej

Added fast/css-generated-content/table-cell-before-content.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::setStyle):
  • rendering/RenderButton.cpp: (WebCore::RenderButton::updateBeforeAfterContent):
  • rendering/RenderButton.h:
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::beforeAfterContainer): (WebCore::RenderContainer::updateBeforeAfterContent): (WebCore::RenderContainer::updateBeforeAfterContentForObject):
  • rendering/RenderContainer.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::setStyle): (WebCore::RenderInline::addChildToFlow): (WebCore::RenderInline::splitInlines):
9:32 PM Changeset in webkit [21198] by justing
  • 2 edits in trunk/WebCore

Reviewed by justin


<​http://bugs.webkit.org/show_bug.cgi?id=13552>
comment to Range::comparePoint in dom/Range.cpp has
'0xD0' in place of '-': leading to a compiler warning

  • dom/Range.cpp: (WebCore::Range::comparePoint):
4:45 PM Changeset in webkit [21197] by justing
  • 7 edits
    8 adds in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/4875189> List gets deleted when replacing contents

Replacing the contents of a list:

  • editing/inserting/4875189-1-expected.checksum: Added.
  • editing/inserting/4875189-1-expected.png: Added.
  • editing/inserting/4875189-1-expected.txt: Added.
  • editing/inserting/4875189-1.html: Added. Of a floating div:
  • editing/inserting/4875189-2-expected.checksum: Added.
  • editing/inserting/4875189-2-expected.png: Added.
  • editing/inserting/4875189-2-expected.txt: Added.
  • editing/inserting/4875189-2.html: Added. Pasting a list on top of itself now creates a nested list:
  • editing/pasteboard/paste-4039777-fix-expected.checksum:
  • editing/pasteboard/paste-4039777-fix-expected.png:
  • editing/pasteboard/paste-4039777-fix-expected.txt:

WebCore:

Reviewed by darin

<rdar://problem/4875189> List gets deleted when replacing contents

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Don't expand to include elements, like lists, when deleting a selection to replace it.
3:06 PM Changeset in webkit [21196] by justing
  • 4 edits in trunk/WebCore

Reviewed by ggaren


Buildfix. Leave in grammar checking machinery to
keep WebKit building on other platforms but don't
operate on sentence sized chunks so that we don't
re-introduce 5157329.

  • editing/Editor.h:
  • editing/mac/EditorMac.mm: (WebCore::Editor::markMisspellingsAfterTypingToPosition): (WebCore::markMisspellingsOrBadGrammar): (WebCore::Editor::markMisspellings): (WebCore::Editor::markBadGrammar):
  • page/Frame.cpp: (WebCore::Frame::respondToChangedSelection):
2:14 PM Changeset in webkit [21195] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/5168598> Crash when deleting a link inside an input field

  • editing/deleting/5168598-expected.checksum: Added.
  • editing/deleting/5168598-expected.png: Added.
  • editing/deleting/5168598-expected.txt: Added.
  • editing/deleting/5168598.html: Added.

WebCore:

Reviewed by darin

<rdar://problem/5168598>
Crash when deleting a link inside an input field


Deletion code tries to update one of its positions to keep
it valid and nullifies it. Later in mergeParagraphs we try
to find out if it's valid by checking to see if it's still in
the document and crash.


The fix is just to not bother keeping the position,
m_upstreamStart, valid, since after the point in the code
under examination, it doesn't need to be valid anymore.
Besides, code to update DeleteSelectionCommand's positions
should go in the functions that handle the content removal
that might invalid them (there are already FIXMEs about this).


Also, users shouldn't be able to insert links (or any rich content)
into plaintext-only regions like text fields, even if those
text fields are inside richly editable regions. This is a
separate bug and is filed as 5171552.

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete): Don't bother updating m_upstreamStart.
2:03 PM Changeset in webkit [21194] by pyeh
  • 7 edits
    1 add in trunk/WebCore

<rdar://problem/5108546> REGRESSION: Zoom follows keyboard focus does not work

  • WebCore.xcodeproj/project.pbxproj: Add new file SelectionControllerMac.mm
  • dom/Document.cpp: (WebCore::Document::updateSelection): Move the code to fire off AXSelectedTextChanged notification to a new method notifyAccessibilityForSelectionChange in SelectionControllerMac.mm
  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): call notifyAccessibilityForSelectionChange to handle firing of accessibility notification and zoomFocusChange
  • editing/SelectionController.h: Add notifyAccessibilityForSelectionChange method for Mac platform
  • platform/Widget.h:
  • platform/mac/WidgetMac.mm: (WebCore::Widget::convertToScreenCoordinate): Add a helper routine that takes IntPoint in local coordinate and convert that to screen coordinate
12:43 PM Changeset in webkit [21193] by justing
  • 4 edits in trunk/WebCore

Reviewed by harrison

<rdar://problem/5157329>
REGRESSION: Crash at WTF::fastFree() when arrowing or deleting backward through editable text (13493)


Backing out the changes for 4859132.

  • editing/Editor.h:
  • editing/mac/EditorMac.mm: (WebCore::Editor::markMisspellingsAfterTypingToPosition): (WebCore::Editor::markMisspellings):
  • page/Frame.cpp: (WebCore::Frame::respondToChangedSelection):
10:43 AM Changeset in webkit [21192] by kmccullo
  • 2 edits in trunk/WebKitTools
  • Removed debugging statements and took out the removal of the deletion of the symlink. This is because multiple instances of run-webkit-tests can be running at the same time.
  • Scripts/run-webkit-tests:
7:40 AM Changeset in webkit [21191] by spadma
  • 2 edits in S60/trunk/WebKit

raalexan, reviewed by <​sachin.padma@nokia.com>

DESC: Browser crashes while loading www.cnn.com
​http://bugs.webkit.org/show_bug.cgi?id=13488

TSW ID : AKUR-6UED6S

  • ResourceLoader/src/AboutTransaction.cpp:
7:40 AM Changeset in webkit [21190] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

raalexan, reviewed by <​sachin.padma@nokia.com>

DESC: Browser crashes while loading www.cnn.com
​http://bugs.webkit.org/show_bug.cgi?id=13488

TSW ID : AKUR-6UED6S

  • ResourceLoader/src/AboutTransaction.cpp:
7:35 AM Changeset in webkit [21189] by yongjzha
  • 4 edits in S60/trunk/WebKit

raalexan, reviewed by Yongjun

DESC: can't do the chinese keyword searching on the brower
​http://bugs.webkit.org/show_bug.cgi?id=13418
TSW ID: RLEA-6ZFCBF

  • BrowserCore/Formcontrols/inc/FControlInputSkin.h:
  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::SelectedLanguage):
  • BrowserCore/Formcontrols/src/FControlInputWidget.cpp: (CControlInputWidget::OfferKeyEventL):
3:44 AM Changeset in webkit [21188] by antti
  • 4 edits in trunk/WebCore

Reviewed by Oliver.

Fix <rdar://problem/5169261>
REGRESSION: Google Maps zooming too sensitive when using two fingers on trackpad


Use line based delta values when generating DOM wheel events, use pixel deltas
for scrolling only.


No test case, requires user interaction and specific hardware.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleWheelEvent):
  • platform/PlatformWheelEvent.h: (WebCore::PlatformWheelEvent::continuousDeltaX): (WebCore::PlatformWheelEvent::continuousDeltaY):
  • platform/mac/WheelEventMac.mm: (WebCore::PlatformWheelEvent::PlatformWheelEvent):

Apr 29, 2007:

11:27 PM Changeset in webkit [21187] by oliver
  • 2 edits in trunk/WebCore

Reviewed by Brady.

Build fix for experimental features build

  • rendering/RenderForeignObject.cpp:
8:29 PM Changeset in webkit [21186] by bdash
  • 3 edits
    4 adds in trunk

2007-04-29 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

Test: fast/repaint/layer-hide-when-needs-layout.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): If we get a layout hint, we count on layout() or updateLayerPositions() to repaint. In the case of a layer going invisible, however, we need to repaint here since neither of the above will do it.

2007-04-29 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

  • fast/repaint/layer-hide-when-needs-layout-expected.checksum: Added.
  • fast/repaint/layer-hide-when-needs-layout-expected.png: Added.
  • fast/repaint/layer-hide-when-needs-layout-expected.txt: Added.
  • fast/repaint/layer-hide-when-needs-layout.html: Added.
5:24 PM Changeset in webkit [23336] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Build fix after r21183.

  • WebCore.vcproj/WebCore.vcproj: Added LayoutState.(h|cpp).
3:40 PM Changeset in webkit [23335] by oliver
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Steve.

Fix for <rdar://problem/5126393> REGRESSION (r19672-19697): Safari drag image drags at original size (13261)


Prevent build bustage from opensource changes, correct scaling

  • platform/win/DragImageWin.cpp: (WebCore::scaleDragImage):
3:31 PM Changeset in webkit [21185] by oliver
  • 7 edits in trunk/WebCore

Reviewed by Steve.

Fix for <rdar://problem/5126393> REGRESSION (r19672-19697): Safari drag image drags at original size (13261)

Added logic to ensure that when we create the drag image
we're looking at the rendered image size.

  • page/DragController.cpp: (WebCore::DragController::doImageDrag): Pass the rendered image size to fitDragImageToMaxSize
  • platform/DragImage.cpp: (WebCore::fitDragImageToMaxSize):

Need to do scaling relative to rendered image size

  • platform/DragImage.h:

scaleDragImage needs x and y scales to allow for them to be
scaled seperately on a page

  • platform/gdk/DragImageGdk.cpp: (WebCore::scaleDragImage):

Prevent build bustage

  • platform/mac/DragImageMac.mm: (WebCore::scaleDragImage):

scale width and height independently

  • platform/qt/DragImageQt.cpp: (WebCore::scaleDragImage):

Prevent build bustage

1:32 PM Changeset in webkit [21184] by darin
  • 18 edits in trunk/WebCore

Reviewed by Adele.

This patch changes things so that resizing can make things larger than their
initial size, but not smaller. I believe this resolves the problem for Gmail,
but you can still get strange behavior if you have a small right-aligned <textarea>.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::resize): Rewrote to use more IntPoint and IntSize and add in a new minimum-size algorithm. This function now has the side effect of storing a new minimumSizeForResizing in the element being resized, and respects any existing minimum as well. (WebCore::RenderLayer::offsetFromResizeCorner): Reversed this so it converts the point into coordinates relative to the resize corner, hence negative numbers mean the point is above and to the left. This is used only in the algorithm above.
  • dom/Element.h: Removed unneeded include of Attr.h, and added forward declarations as needed. Removed all friend declarations; there was no need for any of them. Tweaked formatting of various declarations and removed unneeded parameter names. Made as much as possible private, and a couple things public to avoid the need for friend classes. Added minimumSizeForResizing, setMinimumSizeForResizing, rareData, and createRareData functions.
  • dom/Element.cpp: (WebCore::rareDataMap): Added. Function to return the single global map. (WebCore::rareDataFromMap): Added. For use by inlined functions to get the data from the map in the case where it's present. (WebCore::ElementRareData::ElementRareData): Added. (WebCore::Element::~Element): Added code to delete the element from the rare data map when appropriate. (WebCore::Element::rareData): Added. (WebCore::Element::createRareData): Added. (WebCore::Element::setAttributeNodeNS): Got rid of the old inline version of this, since it was the sole reason we had to include Attr.h in Element.h. (WebCore::Element::minimumSizeForResizing): Added. Accesses rare data. (WebCore::Element::setMinimumSizeForResizing): Ditto.
  • dom/Node.h: Renamed the m_specified bit since it's now used for two purposes. Its new long name is m_attrWasSpecifiedOrElementHasRareData.
  • dom/Attr.cpp: (WebCore::Attr::Attr): Updated for bit name change.
  • dom/Attr.h: (WebCore::Attr::specified): Ditto. (WebCore::Attr::setSpecified): Added, since setting the bit directly is pretty ugly now.
  • dom/Document.cpp: (WebCore::Document::adoptNode): Updated for bit name change.
  • dom/Node.cpp: (WebCore::Node::Node): Ditto. (WebCore::Node::dump): Ditto.
  • dom/NamedAttrMap.cpp: (WebCore::NamedAttrMap::isReadOnlyNode): Moved out of line, since this was the sole reason we had to include Element.h in NamedAttrMap.h.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::nodeName): Changed to use tagQName() since that's a public way to do something that's now private. (WebCore::HTMLElement::cloneNode): Ditto.
  • dom/Attribute.cpp:
  • dom/NamedAttrMap.h:
  • dom/NamedMappedAttrMap.cpp:
  • dom/StyledElement.h:
  • html/HTMLTokenizer.h:
  • xml/XPathFunctions.cpp:
  • xml/XPathStep.cpp: Updated includes, and other administrivia.
1:09 PM Changeset in webkit [21183] by weinig
  • 31 edits
    6 adds in trunk

LayoutTests:

Reviewed by Darin and Hyatt.

  • fast/repaint/bugzilla-3509-expected.checksum:
  • fast/repaint/bugzilla-3509-expected.png:
  • fast/repaint/intermediate-layout-position-clip-expected.checksum: Added.
  • fast/repaint/intermediate-layout-position-clip-expected.png: Added.
  • fast/repaint/intermediate-layout-position-clip-expected.txt: Added.
  • fast/repaint/intermediate-layout-position-clip.html: Added.
  • fast/repaint/intermediate-layout-position-expected.checksum:
  • fast/repaint/intermediate-layout-position-expected.png:

WebCore:

Reviewed by Darin and Hyatt.

Test for a bug fixed by this patch: fast/repaint/intermediate-layout-position-clip.html

By keeping track of the total translation and clip during layout, absolutePosition and
computeAbsoluteRepaintRect become O(1).

  • WebCore.pro: Added LayoutState.cpp
  • WebCore.vcproj/WebCore/WebCore.vcproj: Added LayoutState.{cpp,h}
  • WebCore.xcodeproj/project.pbxproj: Added LayoutState.{cpp,h}
  • WebCoreSources.bkl: Added LayoutState.cpp
  • page/FrameView.cpp: (WebCore::FrameView::layout): When doing subtree layout, push an initial layout state for the layout root.
  • rendering/LayoutState.cpp: Added. A LayoutState corresponding to a box consists of the origin of its coordinate system in view coordinates and possibly the clip rect, in view coordinates, which applies to its children. (WebCore::LayoutState::LayoutState): (WebCore::LayoutState::destroy): (WebCore::throw): (WebCore::LayoutState::operator delete):
  • rendering/LayoutState.h: Added. (WebCore::LayoutState::LayoutState):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Factored out the "only positioned objects" case into layoutOnlyPositionedObjects(). Added code to push/pop LayoutState, unless we have columns, in which case we disable/enable LayoutState. Removed the translation by the layout delta of the old absolute rects, since that is now integral to absoluteClippedOverflowRect() and absoluteOutlineBox(). (WebCore::RenderBlock::layoutOnlyPositionedObjects): Added this helper function that checks for and handles the case where only positioned objects need layout. Returns true in that case. (WebCore::RenderBlock::repaintOverhangingFloats): Disabled LayoutState when repainting floats, since they may belong to other containers. (WebCore::RenderBlock::updateFirstLetter): Disabled LayoutState when adding and removing from the first letter container, since it may be different than ourselves.
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle): Minor cleanup: changed element()->document() to the equivalent document(). (WebCore::RenderBox::offsetForPositionedInContainer): Added. Factored out common code from absolutePosition, computeAbsoluteRepaintRect and RenderLayer::updateLayerPosition into this function. (WebCore::RenderBox::absolutePosition): Added an O(1) code path when this function is called during layout (and LayoutState has not been disabled). Factored out some code into offsetForPositionedInContainer. (WebCore::RenderBox::absoluteClippedOverflowRect): Added the layout delta here, so callers don't need to. (WebCore::RenderBox::computeAbsoluteRepaintRect): Added an O(1) code path when this function is called during layout (and LayoutState has not been disabled). Factored out some code into offsetForPositionedInContainer.
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::layout): Added LayoutState push/pop.
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): Factored out the "only positioned objects" case into layoutOnlyPositionedObjects(). Added LayoutState push/pop. Removed the translation by the layout delta of the old absolute rects, since that is now integral to absoluteClippedOverflowRect() and absoluteOutlineBox().
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::absoluteClippedOverflowRect): Added an ASSERT.
  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::layout): Disabled LayoutState because it is incompatible with arbitrary affine transforms.
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::layout): Removed the translation by the layout delta of the old absolute rects, since that is now integral to absoluteClippedOverflowRect() and absoluteOutlineBox().
  • rendering/RenderImage.cpp: (WebCore::RenderImage::layout): Ditto.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): Added ASSERTs. Factored out some code into RenderBox::offsetForPositionedInContainer. (WebCore::RenderLayer::updateScrollInfoAfterLayout): Disabled LayoutState around the call to scrollToOffset.
  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::updateMarkerLocation): Disabled LayoutState when moving the list marker, since it can trigger repainting in other containers.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::isRoot): Minor cleanup: changed element()->document() to the equivalent document(). (WebCore::RenderObject::computeAbsoluteRepaintRect): Removed 'return' at the end of the function. (WebCore::RenderObject::container): Reordered to avoid calling isText() twice. (WebCore::RenderObject::absoluteOutlineBox): Added the layout delta here, so callers don't need to.
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout): Disabled LayoutState because it is incompatible with arbitrary affine transforms.
  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout): Factored out the "only positioned objects" case into layoutOnlyPositionedObjects(). Added LayoutState push/pop. Removed the translation by the layout delta of the old absolute rects, since that is now integral to absoluteClippedOverflowRect() and absoluteOutlineBox().
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::absoluteClippedOverflowRect): Added the layout delta here, so callers don't need to. (WebCore::RenderTableCell::computeAbsoluteRepaintRect): For the O(1) code path, skipped the correction for the parent row, because RenderTableRow doesn't push a translation into LayoutState. (WebCore::RenderTableCell::absolutePosition): Ditto.
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::layout): Added LayoutState push/pop.
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::setCellWidths): Added LayoutState push/pop if cells are repainted or receive layout. (WebCore::RenderTableSection::calcRowHeight): Ditto. (WebCore::RenderTableSection::layoutRows): Added LayoutState push/pop.
  • rendering/RenderView.cpp: (WebCore::RenderView::RenderView): (WebCore::RenderView::layout): Added initial LayoutState setup for the layout. (WebCore::RenderView::paintBoxDecorations): Minor cleanup: changed element()->document() to the equivalent document(). (WebCore::RenderView::repaintViewRectangle): Ditto. (WebCore::RenderView::pushLayoutState): Added. Pushes initial layout state for subtree layout.
  • rendering/RenderView.h: (WebCore::RenderView::pushLayoutState): (WebCore::RenderView::popLayoutState): (WebCore::RenderView::layoutState): (WebCore::RenderView::disableLayoutState): (WebCore::RenderView::enableLayoutState):
3:33 AM Changeset in webkit [21182] by hyatt
  • 4 adds in trunk/LayoutTests/fast/block/positioning

Add layout test for previous checkin.

3:30 AM Changeset in webkit [21181] by hyatt
  • 2 edits in trunk/WebCore

Fix for bugzilla 13535, regression from positioning cleanup a while
back. Some code got added to compute available width for a relpositioned
inline, only the code meant to be used for inline flows and not inline blocks.

Reviewed by mjs

fast/block/positioning/inline-block-relposition.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::containingBlockWidthForPositioned):
3:17 AM Changeset in webkit [21180] by oliver
  • 12 edits in trunk

2007-04-29 Oliver Hunt <​oliver@apple.com>

Drag and drop support for WebKit/Qt

WebCore:

Reviewed by Zack.

Implement basic drag and drop support for qt
this allows content and link dragging but does not
provide the DOM data access methods.

  • platform/DragData.h:
  • platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::ClipboardQt): (WebCore::ClipboardQt::~ClipboardQt): (WebCore::ClipboardQt::clearData): (WebCore::ClipboardQt::clearAllData): (WebCore::ClipboardQt::setData): (WebCore::ClipboardQt::declareAndWriteDragImage): (WebCore::ClipboardQt::writeURL): (WebCore::ClipboardQt::writeRange): (WebCore::ClipboardQt::hasData):
  • platform/qt/ClipboardQt.h: (WebCore::ClipboardQt::clipboardData): (WebCore::ClipboardQt::invalidateWritableData):
  • platform/qt/DragDataQt.cpp: (WebCore::DragData::canSmartReplace): (WebCore::DragData::containsPlainText): (WebCore::DragData::asPlainText): (WebCore::DragData::createClipboard): (WebCore::DragData::containsCompatibleContent): (WebCore::DragData::containsURL): (WebCore::DragData::asURL): (WebCore::DragData::asFragment):

WebKitQt:

Reviewed by Zack.

Tie QT drag events to the DragController logic
to allow drag and drop events to be handled by
webkit.

  • Api/qwebframe.cpp:
  • Api/qwebframe.h:
  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): (QWebPage::QWebPage): (dropActionToDragOp): (dragOpToDropAction): (QWebPage::dragEnterEvent): (QWebPage::dragLeaveEvent): (QWebPage::dragMoveEvent): (QWebPage::dropEvent):
  • Api/qwebpage.h:
  • WebCoreSupport/DragClientQt.cpp: (WebCore::DragClientQt::startDrag):
  • WebCoreSupport/DragClientQt.h: (WebCore::DragClientQt::DragClientQt):
12:33 AM Changeset in webkit [21179] by mjs
  • 22 edits in trunk/WebCore

Reviewed by Darin and Oliver.

  • change Document to hold onto Frame* instead of FrameView*


This is an architectural cleanup and a prerequisite to fixing citibank login
in an architecturally sound way.

Some fixups for the page cache:


  • history/CachedPage.cpp: (WebCore::CachedPage::restore): Add an assert that the document's view matches the cached page's view - this needs to be true by the time this function is called. (WebCore::CachedPage::clear): Change assert to require frame matching, not view matching.
  • history/CachedPage.h: (WebCore::CachedPage::view): Add a way to get the view out.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): pass Frame, not FrameView, when creating document (WebCore::FrameLoader::open): restore view based on CachedPage, not Document.

Remaining changes are just straightforward updates based on which
pointer is held or passed:


  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): (WebCore::DOMImplementation::createHTMLDocument):
  • dom/DOMImplementation.h:
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::view): (WebCore::Document::frame): (WebCore::Document::recalcStyle): (WebCore::Document::updateLayout): (WebCore::Document::attach): (WebCore::Document::detach): (WebCore::Document::createTokenizer): (WebCore::Document::recalcStyleSelector): (WebCore::Document::setInPageCache): (WebCore::Document::applyXSLTransform):
  • dom/Document.h:
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::HTMLDocument):
  • html/HTMLDocument.h:
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
  • html/HTMLViewSourceDocument.h:
  • ksvg2/svg/SVGDocument.cpp: (WebCore::SVGDocument::SVGDocument):
  • ksvg2/svg/SVGDocument.h:
  • loader/ImageDocument.cpp: (WebCore::ImageDocument::ImageDocument):
  • loader/ImageDocument.h:
  • loader/PluginDocument.cpp: (WebCore::PluginDocument::PluginDocument):
  • loader/PluginDocument.h:
  • loader/TextDocument.cpp: (WebCore::TextDocument::TextDocument):
  • loader/TextDocument.h:
  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource): (WebCore::XSLTProcessor::transformToDocument):
  • xml/XSLTProcessor.h:

Apr 28, 2007:

11:42 PM Changeset in webkit [21178] by bdash
  • 2 edits in trunk/JavaScriptCore

2007-04-28 Jungshik Shin <​jungshik.shin@gmail.com>

Reviewed by Sam Weinig.

  • bindings/npruntime.h:
10:32 PM Changeset in webkit [21177] by adele
  • 3 edits
    2 adds in trunk

LayoutTests:

Added test to cover updated fix for <rdar://problem/5152299>

  • fast/events/no-blur-on-enter-button-expected.txt: Added.
  • fast/events/no-blur-on-enter-button.html: Added.

WebCore:

RS by Darin.

Update to fix for <rdar://problem/5152299>

Test: fast/events/no-blur-on-enter-button.html

  • html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::defaultEventHandler): Don't blur the button when handling the enter key. This matches our new behavior for input elements.
9:35 PM Changeset in webkit [21176] by darin
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Improved the ChangeLog comment. Maybe the code needs a comment like this too.

9:25 PM Changeset in webkit [21175] by darin
  • 3 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Maciej.

  • fix <rdar://problem/5154144> Hamachi test fails: assertion failure in ListHashSet

Test: fast/forms/add-remove-form-elements-stress-test.html

  • wtf/ListHashSet.h: (WTF::ListHashSetNodeAllocator::ListHashSetNodeAllocator): Initialize m_isDoneWithInitialFreeList to false. (WTF::ListHashSetNodeAllocator::allocate): Added assertions based on a debug-only m_isAllocated flag that make sure we don't allocate a block that's already allocated. These assertions helped pinpoint the bug. Set m_isDoneWithInitialFreeList when we allocate the last block of the initial free list. Once we're done with the initial free list, turn off the rule that says that the next node in the pool after the last node in the free list is also free. This rule works because any free nodes are added to the head of the free list, so a node that hasn't been allocated even once is always at the tail of the free list. But it doesn't work any longer once the entire pool has been used at least once. (WTF::ListHashSetNodeAllocator::deallocate): Set the node's m_isAllocated to false. (WTF::ListHashSetNodeAllocator::pastPool): Added. Used above. (WTF::ListHashSetNodeAllocator::inPool): Changed to use the pastPool function. (WTF::ListHashSetNode::ListHashSetNode): Initialize m_isAllocated to true. (WTF::ListHashSetNode::operator new): Removed variable name for unused size parameter. (WTF::ListHashSetNode::destroy): Changed to call the destructor rather than delete -- this gets rid of the need to define an operator delete.

LayoutTests:

Reviewed by Maciej.

  • test for <rdar://problem/5154144> Hamachi test fails: assertion failure in ListHashSet
  • fast/forms/add-remove-form-elements-stress-test-expected.txt: Added.
  • fast/forms/add-remove-form-elements-stress-test.html: Added.
9:09 PM Changeset in webkit [21174] by adele
  • 4 edits
    4 adds in trunk

LayoutTests:

Tests for <rdar://problem/5152299> REGRESSION: <button> elements do not respond to space and return key as similar <input> elements do

  • fast/forms/button-enter-click-expected.txt: Added.
  • fast/forms/button-enter-click.html: Added.
  • fast/forms/button-spacebar-click-expected.txt: Added.
  • fast/forms/button-spacebar-click.html: Added.

WebCore:

Fix by Darin, reviewed by me.

Fix for <rdar://problem/5152299> REGRESSION: <button> elements do not respond to space and return key as similar <input> elements do

Tests:
fast/forms/button-spacebar-click.html
fast/forms/button-enter-click.html

  • html/HTMLButtonElement.h: (WebCore::HTMLButtonElement::): Made type enum private. Removed unnecessary m_value and m_currValue, and unused m_dirty.
  • html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::HTMLButtonElement): Removed initialization of m_dirty. (WebCore::HTMLButtonElement::parseMappedAttribute): Removed case to parse value and accesskey attributes, which don't do anything. (WebCore::HTMLButtonElement::defaultEventHandler): Removed unnecessary check for button type. Added cases to handle spacebar and enter keys in the same way that they're handled for <input type=button/reset/submit> buttons. (WebCore::HTMLButtonElement::isSuccessfulSubmitButton): Shortened comment. (WebCore::HTMLButtonElement::appendFormData): Use value() instead of m_currValue. Renamed encoding argument to formData.
6:36 PM Changeset in webkit [21173] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/dynamic/anonymous-block-layer-lost-expected.checksum: Added.
  • fast/dynamic/anonymous-block-layer-lost-expected.png: Added.
  • fast/dynamic/anonymous-block-layer-lost-expected.txt: Added.
  • fast/dynamic/anonymous-block-layer-lost.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/dynamic/anonymous-block-layer-lost.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::removeChild): Avoid cutting off layers when removing the anonymous block.
6:34 PM Changeset in webkit [21172] by darin
  • 3 edits
    1 add in trunk/WebCore

Reviewed by Darin.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): Replaced direct access to Frame's d->m_doc with a call to Frame::setDocument. (WebCore::FrameLoader::begin): Ditto. (WebCore::FrameLoader::open): Ditto. (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady): Ditto. (WebCore::FrameLoader::canCachePage): Added a comment.
  • manual-tests/secure-keyboard-enabled-after-submit.html: Added.
  • page/Frame.cpp: (WebCore::Frame::setDocument): Reset secure keyboard entry, in case the old document's focused node has set it.
6:30 PM Changeset in webkit [21171] by darin
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Adele.

  • manual-tests/update-empty-popup.html: Added.
  • platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Added a call to the client's hidePopup() callback before returning in the case that the menu is empty. Otherwise the client thinks that the menu stayed open.
12:00 PM Changeset in webkit [21170] by adele
  • 3 edits
    3 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for <rdar://problem/4806988> REGRESSION: history.go(0) doesn't reload page (affects buttons at facebook.com)

  • fast/history/history_reload-expected.txt: Added.
  • fast/history/history_reload.html: Added.
  • fast/history/resources/history_reload_window.html: Added.

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/4806988> REGRESSION: history.go(0) doesn't reload page (affects buttons at facebook.com)

Test: fast/history/history_reload.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::scheduleHistoryNavigation): We avoid doing a redirection when going to the same url in a history navigation, but we have to still schedule a redirection when the number of steps is zero so we can force a reload.
11:29 AM Changeset in webkit [21169] by ap
  • 5 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13514
REGRESSION (r20997-21003): Crash in WebCore::Node::document

Test: fast/dom/NodeList/childNodes-reset-cache.html

  • dom/Node.cpp: (WebCore::Node::notifyLocalNodeListsChildrenChanged): Reset the common caches for child node lists. We cannot rely on notifications, since there may be no list objects left around.
  • dom/ChildNodeList.cpp: (WebCore::ChildNodeList::rootNodeChildrenChanged):
  • dom/ChildNodeList.h: Override rootNodeChildrenChanged() with an empty implementation, now that caches are reset in Node::notifyLocalNodeListsChildrenChanged().
4:36 AM Changeset in webkit [21168] by bdash
  • 2 edits in trunk/WebCore

2007-04-28 Mark Rowe <​mrowe@apple.com>

Build fix. Change use of nil to 0 in C++ source file.

  • editing/Editor.cpp: (WebCore::Editor::increaseSelectionListLevel): (WebCore::Editor::increaseSelectionListLevelOrdered): (WebCore::Editor::increaseSelectionListLevelUnordered):
1:11 AM Changeset in webkit [21167] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Adele.

  • fast/dom/namespaces-1-expected.txt: Added.
  • fast/dom/namespaces-1.html: Added.

WebCore:

Reviewed by Adele.

  • dom/Node.cpp: (WebCore::TagNodeList::TagNodeList): Changed parameter to PassRefPtr, tweaked formatting. (WebCore::TagNodeList::item): Tweaked formatting. (WebCore::TagNodeList::nodeMatches): Tweaked formatting. (WebCore::Node::setPrefix): Tweaked formatting. (WebCore::Node::getElementsByTagNameNS): Added special case to turn empty namespaces into null namespaces.
1:07 AM Changeset in webkit [21166] by darin
  • 4 edits in trunk

LayoutTests:

Reviewed by Kevin Decker.

  • update test result for fix for <rdar://problem/5148271> Chinese numbers are incorrect in numbered lists (including pasting from TextEdit to Mail)
  • fast/lists/w3-list-styles-expected.txt: Updated. The new test results match the behavior of Firefox.

WebCore:

Reviewed by Kevin Decker.

  • fix <rdar://problem/5148271> Chinese numbers are incorrect in numbered lists (including pasting from TextEdit to Mail)

Covered by an existing regression test, which had wrong results checked in.

Hyatt told me not to use the algorithm in the CSS 3 specification, but I didn't listen!
This corrects mistakes there and makes our results match current Firefox.

  • rendering/RenderListMarker.cpp: (WebCore::toCJKIdeographic): Added code to strip off trailing zero digits. Added special case for zero, since that's the one case where we don't want to strip off trailing zero digits. Fixed mixed-up logic that would put the digits in each group backwards. (WebCore::listMarkerText): Corrected character values for the CJK_IDEOGRAPHIC case.
1:02 AM Changeset in webkit [21165] by darin
  • 2 edits in trunk/WebCore

Reviewed by Oliver.

  • fix <rdar://problem/5138250> REGRESSION (r18245): Changing any one aspect of a font applies all the aspects to selected text

Since this bug is only visible with the font panel, I don't
think there's any way to make a DumpRenderTree-driven test.

  • editing/Editor.cpp: (WebCore::Editor::fontForSelection): Set hasMultipleFonts properly. The old code had an early exit that was left over from when hasMultipleFonts was a pointer.

Apr 27, 2007:

11:57 PM Changeset in webkit [21164] by aroben
  • 2 edits in trunk/WebKitTools

Reviewed by Maciej.

Cleaned up prepare-ChangeLog

  • Scripts/prepare-ChangeLog: No code changes, but style now matches the prevalent style of our perl scripts.
11:48 PM Changeset in webkit [21163] by bdash
  • 5 edits in trunk/LayoutTests

2007-04-27 Mitz Pettel <​mitz@webkit.org>

Reviewed by Antti.

  • fast/css/percentage-non-integer-expected.checksum:
  • fast/css/percentage-non-integer-expected.png:
  • fast/css/percentage-non-integer-expected.txt:
  • fast/css/percentage-non-integer.html:
11:40 PM Changeset in webkit [21162] by bdash
  • 3 edits in trunk/WebCore

2007-04-27 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

No test possible as there is no change to functionality.

No test possible since text fields are no longer implemented as flexboxes.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::scheduleRelayout): Added a check that the subtree root is in the tree and not free-floating.
  • rendering/bidi.cpp: (WebCore::RenderBlock::bidiReorderCharacters): Changed addChild and removeChild to appendChildNode and removeChildNode to save some unnecessary overhead. These calls still mark the tree for relayout, but the change in scheduleRelayout ensures that a layout won't be scheduled.
10:04 PM Changeset in webkit [21161] by thatcher
  • 1 edit in trunk/WebKit/WebKit.xcodeproj/project.pbxproj

Add back in WebInspectorPanel.

9:54 PM Changeset in webkit [21160] by thatcher
  • 2 edits in trunk/WebKit

Revert some unintended changes and fix the build.

9:48 PM Changeset in webkit [21159] by thatcher
  • 8 edits
    2 deletes in trunk/WebKit

2007-04-27 Timothy Hatcher <​timothy@apple.com>

Reviewed by Darin.

There were only a couple calls to ResourceLoadDelegate forwarder left,
this removed the calls and added a new cached method for didFailLoad.

  • WebKit/DefaultDelegates/WebDefaultResourceLoadDelegate.h: Removed.
  • WebKit/DefaultDelegates/WebDefaultResourceLoadDelegate.m: Removed.
  • WebKit/Plugins/WebNullPluginView.mm: Call the resource load delegate directly.
  • WebKit/WebCoreSupport/WebFrameLoaderClient.mm: Call the cached didFailLoad delegate function.
  • WebKit/WebKit.xcodeproj/project.pbxproj: Remove WebDefaultResourceLoadDelegate.
  • WebKit/WebView/WebDataSource.mm: Remove the #import for WebDefaultResourceLoadDelegate.h
  • WebKit/WebView/WebView.mm: Remove the ResourceLoadDelegate forwarder, and remove a method that isn't used.
  • WebKit/WebView/WebViewInternal.h: Ditto.
  • WebKit/WebView/WebViewPrivate.h: Remove a method that is no longer used.
6:41 PM Changeset in webkit [21158] by pyeh
  • 2 edits in trunk/WebCore

<rdar://problem/5153017> REPRODUCIBLE ASSERT: range != nil in WebViewFactory.mm:415 -[WebViewFactory startOfTextMarkerRange:] (13354)

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject textMarkerRangeForRange:]): Fix the range length check. It was incorrectly assuming that the max range requested cannot be equal to the length of the string. Since NSRange location is index based, it's perfectly valid to have the max range equal to the the text length.
6:04 PM Changeset in webkit [21157] by harrison
  • 14 edits in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/5160627> Export JS list creation support as ObjC SPI for Mail

  • WebCore.exp:
  • editing/Editor.h:
  • editing/Editor.cpp: (WebCore::Editor::insertOrderedList): (WebCore::Editor::insertUnorderedList): (WebCore::Editor::canIncreaseSelectionListLevel): (WebCore::Editor::canDecreaseSelectionListLevel): (WebCore::Editor::increaseSelectionListLevel): (WebCore::Editor::increaseSelectionListLevelOrdered): (WebCore::Editor::increaseSelectionListLevelUnordered): (WebCore::Editor::decreaseSelectionListLevel): Add insertOrderedList() and insertUnorderedList(). Move existing list management functions from WebCoreFrameBridge. The level increasing functions now return a PassRefPtr<Node> instead of Node. Add check for canEditRichly.


  • in many other functions, condense the check for nil client().


  • editing/InsertListCommand.h:
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::insertList): (WebCore::InsertListCommand::fixOrphanedListChild): (WebCore::InsertListCommand::doApply): Add insertList(), which returns the new list element. Don't set the list element's ID if the specified ID was an empty string.


  • editing/ModifySelectionListLevel.h:
  • editing/ModifySelectionListLevel.cpp: (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelWithType): (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevel): (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelOrdered): (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelUnordered): Return PassRefPtr<Node> instead of Node.
  • page/mac/WebCoreFrameBridge.h:
  • page/mac/WebCoreFrameBridge.mm: Move list management functions to Editor.h and Editor.cpp.

WebKit:

Reviewed by Darin.

<rdar://problem/5160627> Export JS list creation support as ObjC SPI for Mail

  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebHTMLView.mm: (-[WebHTMLView _selectedRange]): (-[WebHTMLView _shouldDeleteRange:]): (-[WebHTMLView _canEdit]): (-[WebHTMLView _canEditRichly]): (-[WebHTMLView _hasSelection]): (-[WebHTMLView _hasSelectionOrInsertionPoint]): (-[WebHTMLView _hasInsertionPoint]): (-[WebHTMLView _isEditable]): Condense the check for nil [self frame]. Remove canEditRichly checks and rely on the editor to do the check instead.


(-[WebHTMLView _insertOrderedList]):
(-[WebHTMLView _insertUnorderedList]):
New.


(-[WebHTMLView _canIncreaseSelectionListLevel]):
(-[WebHTMLView _canDecreaseSelectionListLevel]):
(-[WebHTMLView _increaseSelectionListLevel]):
(-[WebHTMLView _increaseSelectionListLevelOrdered]):
(-[WebHTMLView _increaseSelectionListLevelUnordered]):
(-[WebHTMLView _decreaseSelectionListLevel]):
Moved from bridge to frame editor.

  • WebView/WebHTMLViewPrivate.h: Add _insertOrderedList and _insertUnorderedList to WebHTMLView(WebPrivate)
5:48 PM Changeset in webkit [21156] by hyatt
  • 2 edits in trunk/WebCore

Fix for <rdar://problem/5134254>, toolbar buttons don't work in gmail after double-click. Make sure
to clear out the capturing frame, since you don't get a second up when a double-click happens.

Reviewed by mjs

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseDoubleClickEvent):
2:59 PM Changeset in webkit [21155] by justing
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by oliver


<rdar://problem/5164796>
Enable execCommand("CreateLink", ...) for caret selections

  • editing/execCommand/5164796-expected.checksum: Added.
  • editing/execCommand/5164796-expected.png: Added.
  • editing/execCommand/5164796-expected.txt: Added.
  • editing/execCommand/5164796.html: Added.

WebCore:

Reviewed by oliver

<rdar://problem/5164796>
Enable execCommand("CreateLink", ...) for caret selections

  • editing/CreateLinkCommand.cpp: (WebCore::CreateLinkCommand::doApply): For a caret selection, insert a link at the caret position with the url as the link text.
  • editing/JSEditor.cpp: Enable CreateLink for caret selections.
1:03 PM Changeset in webkit [21154] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

hongzhao <​hong.a.zhao@nokia.com>

Reviewed by Yongjun.
DESC: To add .lib for linking problems in 3.1m.
​http://bugs.webkit.org/show_bug.cgi?id=13523

12:58 PM Changeset in webkit [21153] by zbujtas
  • 2 edits in S60/trunk/WebCore

2007-04-27 w3liu <​wei.liu@nokia.com>

reviewed by Zalan <​zbujtas@gmail.com>
DESC: handle codebase in HTMLImageLoader
​http://bugs.webkit.org/show_bug.cgi?id=13491

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/html/html_imageimpl.cpp: (HTMLImageLoader::updateFromElement):
12:56 PM Changeset in webkit [21152] by zbujtas
  • 2 edits in S60/branches/3.1m/WebCore

2007-04-27 w3liu <​wei.liu@nokia.com>

reviewed by Zalan <​zbujtas@gmail.com>
DESC: handle codebase in HTMLImageLoader
​http://bugs.webkit.org/show_bug.cgi?id=13491

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/html/html_imageimpl.cpp: (HTMLImageLoader::updateFromElement):
12:48 PM Changeset in webkit [21151] by zbujtas
  • 2 edits in S60/branches/3.1m/WebCore

2007-04-27 w3liu <​wei.liu@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: NUPA-729B2V: WCSS dotted HORIZONTAL RULES not displaying at all
​http://bugs.webkit.org/show_bug.cgi?id=13524

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/rendering/render_object.cpp: (RenderObject::drawBorder):
12:23 PM Changeset in webkit [21150] by zbujtas
  • 9 edits in S60/trunk

rathnasa, reviewed by zbujtas

DESC: Widget Menu API
​http://bugs.webkit.org/show_bug.cgi?id=13494

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/ecma/kjs_window.cpp: (Window::get):
10:02 AM Changeset in webkit [21149] by beidson
  • 2 edits in trunk/WebKit

Rubberstamped by Mark

Remove default implementation of UIDelegate method that was removed

I have also been instructed to give Tim a hard time about this one - apparently
it was his job to clean it out and he failed... failed miserably.

:)

  • DefaultDelegates/WebDefaultUIDelegate.m: Removed webViewPrint:
7:55 AM Changeset in webkit [21148] by bdash
  • 2 edits in trunk/WebKitTools

2007-04-27 Nazar Kulyk <​schamane@myeburg.net>

Reviewed by Mark Rowe.

Basic auto-correction of user-entered URLs.

  • GdkLauncher/main.cpp: (autocorrectURL): (goToURLBarText): (main):
6:08 AM Changeset in webkit [21147] by antti
  • 1 edit
    1 add in trunk/LayoutTests

Forgot this png from previous commit.

  • fast/table/empty-cells-expected.png: Added.
5:36 AM Changeset in webkit [21146] by bdash
  • 2 edits in trunk/WebKitTools

2007-04-28 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by Anders.

Rename some methods and variables to match the style guidelines.

  • GdkLauncher/main.cpp: (stringIsEmpty): (stringIsEqual): (goToURLBarText): (goButtonClickedCallback): (urlBarEnterCallback): (frameResizeCallback): (frameDestroyCallback): (menuMainBackCallback): (menuMainForwardCallback): (menuMainQuitCallback): (main):
4:32 AM Changeset in webkit [21145] by antti
  • 38 edits
    3 adds in trunk

LayoutTests:

Reviewed by Darin, Hyatt.


Test for ​http://bugs.webkit.org/show_bug.cgi?id=13081
Empty table cells not handled correctly
<rdar://problem/5067926>


Added test case and checked in updated results for others. Changes represent
progressions or are not visible in rendering output.

  • fast/block/positioning/negative-right-pos-expected.txt:
  • fast/css/acid2-expected.txt:
  • fast/css/acid2-pixel-expected.txt:
  • fast/css/percentage-non-integer-expected.checksum:
  • fast/css/percentage-non-integer-expected.png:
  • fast/css/percentage-non-integer-expected.txt:
  • fast/repaint/table-cell-move-expected.checksum:
  • fast/repaint/table-cell-move-expected.png:
  • fast/repaint/table-cell-move-expected.txt:
  • fast/table/012-expected.txt:
  • fast/table/032-expected.txt:
  • fast/table/empty-cells-expected.checksum: Added.
  • fast/table/empty-cells-expected.txt: Added.
  • fast/table/empty-cells.html: Added.
  • fast/table/empty-section-crash-expected.txt:
  • http/tests/misc/acid2-expected.txt:
  • http/tests/misc/acid2-pixel-expected.txt:
  • tables/mozilla/bugs/bug100334-expected.txt:
  • tables/mozilla/bugs/bug1188-expected.txt:
  • tables/mozilla/bugs/bug16012-expected.checksum:
  • tables/mozilla/bugs/bug16012-expected.png:
  • tables/mozilla/bugs/bug16012-expected.txt:
  • tables/mozilla/bugs/bug1818-6-expected.txt:
  • tables/mozilla/bugs/bug222336-expected.txt:
  • tables/mozilla/bugs/bug222467-expected.txt:
  • tables/mozilla/bugs/bug78162-expected.txt:
  • tables/mozilla/core/misc-expected.checksum:
  • tables/mozilla/core/misc-expected.png:
  • tables/mozilla/core/misc-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug14007-1-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug14007-1-expected.png:
  • tables/mozilla_expected_failures/bugs/bug14007-1-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug72393-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug72393-expected.png:
  • tables/mozilla_expected_failures/bugs/bug72393-expected.txt:
  • tables/mozilla_expected_failures/other/empty_cells-expected.txt:

WebCore:

Reviewed by Darin, Hyatt.


Fix ​http://bugs.webkit.org/show_bug.cgi?id=13081
Empty table cells not handled correctly
<rdar://problem/5067926>


To match Firefox and IE, empty table cells with variable width need to be
treated as special case. They generally get zero width.

  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::layout):
  • rendering/AutoTableLayout.h: (WebCore::AutoTableLayout::Layout::Layout):
  • rendering/RenderStyle.h: (WebCore::RenderStyle::hasPadding):
4:20 AM Changeset in webkit [21144] by rwlbuis
  • 4 edits
    4 adds in trunk

Reviewed by Oliver.

​http://bugs.webkit.org/show_bug.cgi?id=13052
Text not rendered in a second inline SVG element

Correct the rendering of svg text when embedded in non-svg container.

1:43 AM Changeset in webkit [21143] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Mark.


<rdar://problem/5154113> Repro ASSERT (would be crash) in KJS::GCLock::GCLock (13462)
​http://bugs.webkit.org/show_bug.cgi?id=13462

  • WebInspector/WebInspector.m: (-[WebInspectorPrivate dealloc]): Delay release of WebView to avoid GC re-entrancy.
1:40 AM Changeset in webkit [21142] by bdash
  • 2 edits in trunk/WebCore

2007-04-27 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

  • WebCore.pro: Remove non-existent paths from qmake files.
1:10 AM Changeset in webkit [21141] by andersca
  • 2 edits in trunk/WebKit

Reviewed by Mitz.

<rdar://problem/5165755>
View Source is broken; empty window is shown


Return YES for applewebdata URLs.


  • WebView/WebView.mm: (+[WebView _canHandleRequest:]):
12:52 AM Changeset in webkit [21140] by bdash
  • 5 edits in trunk/WebCore

2007-04-25 Lars Naesbye Christensen <​lars@naesbye.dk>

Reviewed by Timothy Hatcher.

​http://bugs.webkit.org/show_bug.cgi?id=13477
Bug 13477: Help and context menu cursors need dropshadows.

  • Resources/cellCursor.png:
  • Resources/contextMenuCursor.png:
  • Resources/helpCursor.png:
  • platform/mac/CursorMac.mm: (WebCore::contextMenuCursor): (WebCore::copyCursor): (WebCore::progressCursor): (WebCore::noDropCursor):
12:44 AM Changeset in webkit [21139] by bdash
  • 1 edit
    3 copies
    2 adds
    1 delete in trunk/JavaScriptCore

2007-04-27 Christopher Brichford <​chrisb@adobe.com>

Reviewed by Timothy Hatcher.

Fix for: Bug 13211: Move JavaScriptCore mac project files for apollo port
​http://bugs.webkit.org/show_bug.cgi?id=13211

  • JavaScriptCore.apolloproj/mac/JavaScriptCore.Debug.xcconfig: Added.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore.Release.xcconfig: Added.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore.xcconfig: Added.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore.xcodeproj/project.pbxproj: Added.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.Debug.xcconfig: Removed.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.Release.xcconfig: Removed.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcconfig: Removed.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj: Removed.
12:37 AM Changeset in webkit [21138] by bdash
  • 7 edits
    7 deletes in trunk

2007-04-27 Holger Freyther <​freyther@kde.org>

Reviewed by Maciej.

Remove unmaintained CMake build system.

  • CMakeLists.txt: Removed.

2007-04-27 Holger Freyther <​freyther@kde.org>

Reviewed by Maciej.

Remove unmaintained CMake build system.

  • CMakeLists.txt: Removed.
  • pcre/CMakeLists.txt: Removed.

2007-04-27 Holger Freyther <​freyther@kde.org>

Reviewed by Maciej.

Remove unmaintained CMake build system.

  • CMakeLists.txt: Removed.

2007-04-27 Holger Freyther <​freyther@kde.org>

Reviewed by Maciej.

Remove unmaintained CMake build system.

  • QtLauncher/CMakeLists.txt: Removed.
  • WebKitPart/CMakeLists.txt: Removed.

2007-04-27 Holger Freyther <​freyther@kde.org>

Reviewed by Maciej.

Remove unmaintained CMake build system.

  • DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt: Removed.
  • Scripts/build-webkit: Remove references to CMake.
  • Scripts/webkitdirs.pm: Remove references to CMake.

Apr 26, 2007:

11:03 PM Changeset in webkit [21137] by bdash
  • 4 edits in trunk

2007-04-27 Mark Rowe <​mrowe@apple.com>

Reviewed by Oliver.

  • JavaScriptCore.xcodeproj/project.pbxproj: Improve dependencies in Xcode project by marking dftables as a dependency of Generate Derived Sources rather than of JavaScriptCore itself.

2007-04-27 Mark Rowe <​mrowe@apple.com>

Reviewed by Oliver.

  • JavaScriptGlue.xcodeproj/project.pbxproj: Improve dependencies in Xcode project by marking JavaScriptGlue as a dependency of testjsglue.
10:48 PM Changeset in webkit [21136] by bdash
  • 2 edits in trunk/WebCore

2007-04-26 Matt Perry <​mpComplete@gmail.com>

Reviewed by Maciej.

Added a version check to hackAroundLibXMLEntityBug, since that bug has
been fixed in recent versions of libxml2.

  • dom/XMLTokenizer.cpp: (WebCore::hackAroundLibXMLEntityBug):
10:36 PM Changeset in webkit [21135] by bdash
  • 1 edit
    7 adds in trunk/WebCore

2007-04-26 Christopher Brichford <​chrisb@adobe.com>

Reviewed by Timothy Hatcher.

  • WebCore.apolloproj/mac/WebCore.Debug.xcconfig: Added.
  • WebCore.apolloproj/mac/WebCore.Release.xcconfig: Added.
  • WebCore.apolloproj/mac/WebCore.xcconfig: Added.
  • WebCore.apolloproj/mac/WebCore.xcodeproj/project.pbxproj: Added.
10:11 PM Changeset in webkit [21134] by bdash
  • 2 edits in trunk/WebCore

2007-04-26 Alp Toker <​alp@atoker.com>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=13505
Cast loses precision on x86_64

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): Use a stack of opacity values instead of Cairo user data.
10:09 PM Changeset in webkit [21133] by bdash
  • 2 edits in trunk/WebKitTools

2007-04-26 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

  • GdkLauncher/main.cpp: (main): Avoid use of deprecated API.
10:00 PM Changeset in webkit [21132] by bdash
  • 3 edits
    4 adds in trunk

2007-04-26 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Test: fast/forms/listbox-scrollbar-incremental-load.html

The scroller position was not updated correctly during insertion, since
scrollbar proportions are updated only during layout

  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::selectionChanged): Delay scrolling to reveal the selection until after layout if m_optionsChanged is set. Layout is guaranteed to happen soon when the flag is set.

2007-04-26 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • fast/forms/listbox-scrollbar-incremental-load-expected.checksum: Added.
  • fast/forms/listbox-scrollbar-incremental-load-expected.png: Added.
  • fast/forms/listbox-scrollbar-incremental-load-expected.txt: Added.
  • fast/forms/listbox-scrollbar-incremental-load.html: Added.
6:41 PM Changeset in webkit [21131] by ggaren
  • 5 edits in trunk/JavaScriptCore

Build fix -- added #includes that we used to get implicitly through
JSStringRef.h.

  • API/JSNode.c:
  • API/JSNodeList.c:
  • API/minidom.c:
  • API/testapi.c:
6:15 PM Changeset in webkit [21130] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak, Adam Roben.


Fixed
<rdar://problem/4885130> Remove #include of JSStringRefCF.h from JSStringRef.h
<rdar://problem/4885123> JavaScriptCore is not cross-platform -- JSStringRef.h references CF datatypes

  • API/JSStringRef.h: Removed #include -- no clients need it anymore.
5:36 PM Changeset in webkit [21129] by hyatt
  • 1 edit in trunk/LayoutTests/fast/dom/Range/surroundContents-1-expected.txt

Fix layout test results jnow that we no longer make empty render texts.

5:35 PM Changeset in webkit [21128] by hyatt
  • 1 edit in trunk/LayoutTests/fast/dom/delete-contents-expected.txt

Fix layout test results jnow that we no longer make empty render texts.

5:34 PM Changeset in webkit [21127] by hyatt
  • 3 edits in trunk/LayoutTests/editing/execCommand

Fix layout test results jnow that we no longer make empty render texts.

5:33 PM Changeset in webkit [21126] by hyatt
  • 3 edits in trunk/LayoutTests/editing/deleting

Fix layout test results jnow that we no longer make empty render texts.

5:30 PM Changeset in webkit [21125] by hyatt
  • 4 edits in trunk/WebCore

Fix for 13511, crash on a counters page. Make sure that RenderTexts
never get a null StringImpl. I would have added an assert that the length
had to be nonzero also, but unfortunately editing creates empty RenderTexts
because of its EditingText DOM subclass that always forces renderers to be
made. I suppose there is a good reason for this...

Reviewed by aroben

  • dom/CharacterData.cpp: (WebCore::CharacterData::setData): (WebCore::CharacterData::appendData): (WebCore::CharacterData::insertData): (WebCore::CharacterData::deleteData): (WebCore::CharacterData::replaceData):
  • rendering/RenderCounter.cpp: (WebCore::RenderCounter::RenderCounter):
  • rendering/RenderText.cpp: (WebCore::RenderText::RenderText): (WebCore::RenderText::trimmedPrefWidths): (WebCore::RenderText::setTextWithOffset): (WebCore::RenderText::setTextInternal): (WebCore::RenderText::setText):
4:21 PM Changeset in webkit [21124] by aliceli1
  • 2 edits in trunk/WebCore

Reviewed by Oliver.

  • editing/SelectionController.cpp: (WebCore::SelectionController::selectAll): adding null check
2:53 PM Changeset in webkit [21123] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by oliver


<rdar://problem/5120591> Crash when creating a link in Leopard wiki server

  • editing/execCommand/5120591-expected.checksum: Added.
  • editing/execCommand/5120591-expected.png: Added.
  • editing/execCommand/5120591-expected.txt: Added.
  • editing/execCommand/5120591.html: Added.

WebCore:

Reviewed by oliver

<rdar://problem/5120591>
Crash when creating a link in Leopard wiki server

  • editing/CreateLinkCommand.cpp: (WebCore::CreateLinkCommand::doApply): Use a RefPtr, setting the anchor's href can destroy it if there is an ancestor with a subtree modified event listener.
2:15 PM Changeset in webkit [21122] by ddkilzer
  • 2 edits in trunk/JavaScriptCore

2007-04-25 David Kilzer <​ddkilzer@apple.com>

Reviewed by Maciej.

Add assertions for debug builds.

  • kjs/JSLock.cpp: (KJS::JSLock::lock): Assert the return value of pthread_mutex_lock() in debug builds. (KJS::JSLock::unlock): Assert the return value of pthread_mutex_unlock() in debug builds.
1:37 PM Changeset in webkit [21121] by kmccullo
  • 2 edits in trunk/WebKitTools
  • Changed debugging statements for more information.
  • Scripts/run-webkit-tests:
12:51 PM Changeset in webkit [21120] by hyatt
  • 7 edits in trunk/WebCore

Reviewed by hyatt

No tests added since there is no change to functionality. Several
tests in fast/repaint test repainting of objects that move during layout.

  • page/FrameView.cpp: (WebCore::FrameView::layout):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): Removed an early setNeedsLayout(false). Resetting the bit here prevents the full repaint that we rely on when we decide not to repaint children that move.
  • rendering/RenderBlock.h:
  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::setCellWidths): Replaced the call to repaintObjectsBeforeLayout() if the cell didn't need layout with an unconditional repaint(). We don't bother with repainting only the delta between the old and new widths, since by marking the cell for layout results in a full repaint with the new width anyway.
12:24 PM Changeset in webkit [21119] by hyatt
  • 2 edits in trunk/WebCore

Fix for 13509. Don't recur to parent inline flows if they have been
marked as needing layout themselves.

Reviewed by adele

  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::dirtyLinesFromChangedChild):
12:21 PM Changeset in webkit [21118] by ap
  • 3 edits
    3 adds in trunk

2007-04-26 Matt Perry <​mpComplete@gmail.com>

Reviewed and landed by Alexey.

​http://bugs.webkit.org/show_bug.cgi?id=13495
Crash when referencing an undefined entity in an XHTML document

Test: fast/parser/badentity.xhtml

  • dom/XMLTokenizer.cpp: (WebCore::getEntityHandler): Check for a NULL returned from getXHTMLEntity
11:37 AM Changeset in webkit [21117] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

<rdar://problem/4851944>
REGRESSION: With TOT, BMP images can no longer be opened in the browser window


On Tiger, the MIME type for the com.microsoft.bmp UTI isn't in the registry, so add it manually.


  • platform/MimeTypeRegistry.cpp: (WebCore::initialiseSupportedImageMIMETypes):
11:30 AM Changeset in webkit [21116] by hyatt
  • 4 edits in trunk/WebCore

Fix for bug 13503, invalidateContainingBlockPrefWidths is 15% of the
nesting PLT. Avoid O(n2) behavior by including inlines in the minmax
dirty chain.

Reviewed by kevin

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcInlinePrefWidths):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::setPrefWidthsDirty): (WebCore::RenderObject::invalidateContainerPrefWidths):
  • rendering/RenderObject.h:
11:11 AM Changeset in webkit [21115] by kmccullo
  • 2 edits in trunk/WebKitTools
  • Adding debugging statements to see why these tests fail. These will be removed.
  • Scripts/run-webkit-tests:
10:37 AM Changeset in webkit [21114] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5067925>
Reproducible crash (infinite recursion) with a layout test that submits on unload (13078)


Ask the document loader whether it's loading the main resource, since there are cases where the frame
loader's variable isn't updated correctly.


In the distant future, the frame loader shouldn't have an instance variable but this is the least intrusive fix for now.


I couldn't come up with a good test case for this since it requires running three tests in a row and scheduleLoad didn't work. Also,
calling submit in the onunload prevents any new tests from loading!


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::isLoading):
8:52 AM BuildingGdk edited by alp@atoker.com
(diff)
5:48 AM Changeset in webkit [21113] by zbujtas
  • 2 edits in S60/trunk/WebKit

yadavall, reviewed by <​zbujtas@gmail.com>

DESC: Fix build break
​http://bugs.webkit.org/show_bug.cgi?id=13497


  • group/EABI/browserengineU.def:
3:10 AM Changeset in webkit [21112] by bdash
  • 5 edits in tags/WebKit-419.1/WebKit

Merge r10259 and r15845.

2:41 AM Changeset in webkit [21111] by bdash
  • 3 edits in tags/WebKit-419.1/WebKit

Merge r20042 and follow-ups from r20050, r20058, r20064, r20077 and r20668.

2:20 AM Changeset in webkit [21110] by oliver
  • 2 edits in trunk/WebKit

2007-04-26 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Fix <rdar://problem/5061252> REGRESSION: In Gmail, image fails
to be inserted into message field after dragging

Don't try to create <img> tags for local image files as it results
in the potential to submit forms that look like they have an image,
when in reality they don't.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _documentFragmentWithPaths:]):
2:19 AM Changeset in webkit [21109] by bdash
  • 1 copy in tags/WebKit-419.1

New tag.

12:09 AM Changeset in webkit [21108] by andersca
  • 2 edits in trunk/WebCore

... and fix the build.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::continueAfterNavigationPolicy):
12:06 AM Changeset in webkit [21107] by andersca
  • 2 edits in trunk/WebCore

Revert the previous change - activeDocumentLoader never returns the policy document loader.
Instead, add a null check for the policy document loader.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::continueAfterNavigationPolicy):
12:02 AM Changeset in webkit [21106] by andersca
  • 2 edits in trunk/WebCore

Use the active document loader instead of the policy document loader.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::continueAfterNavigationPolicy):
Note: See TracTimeline for information about the timeline view.