Context Navigation

← Previous Period
Next Period →

Timeline

May 5, 2007:

10:17 PM Changeset in webkit [21274] by ap

5 edits in trunk/WebCore

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13304
REGRESSION(14784): WebKit doesn't dynamically reflect changes to the highlight color in System Preferences

Implemented a notification observer that invalidates cached system colors.

No automated test possible.

rendering/RenderTheme.cpp: (WebCore::RenderTheme::activeSelectionBackgroundColor): (WebCore::RenderTheme::inactiveSelectionBackgroundColor): (WebCore::RenderTheme::platformColorsDidChange):
rendering/RenderTheme.h:
rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm: (-[WebCoreRenderThemeNotificationObserver initWithTheme:WebCore::]): (-[WebCoreRenderThemeNotificationObserver systemColorsDidChange:]): (WebCore::theme): (WebCore::RenderThemeMac::RenderThemeMac): (WebCore::RenderThemeMac::~RenderThemeMac): (WebCore::RenderThemeMac::checkbox): (WebCore::RenderThemeMac::radio): (WebCore::RenderThemeMac::button): (WebCore::RenderThemeMac::popupButton): (WebCore::RenderThemeMac::search): (WebCore::RenderThemeMac::sliderThumbHorizontal): (WebCore::RenderThemeMac::sliderThumbVertical):

4:23 PM Changeset in webkit [21273] by kevino

1 edit in branches/wx-port-alpha/trunk/Bakefiles/presets.bkl

Run *-config scripts when running make, not when generating the makefiles.

3:53 AM Changeset in webkit [21272] by rwlbuis

28 edits in trunk/WebCore

Reviewed by Oliver.

http://bugs.webkit.org/show_bug.cgi?id=13592
parseMappedAttribute inconsistency

Do not use local vars in parseMappedAttribute for attr name and value.

12:10 AM Changeset in webkit [21271] by oliver

2 edits in trunk/WebCore

Reviewed by Hyatt.

Initialise default fill with Color::black rather than parsing
the string "black"

ksvg2/svg/SVGPaint.cpp: (WebCore::SVGPaint::defaultFill):

May 4, 2007:

9:19 PM Changeset in webkit [23344] by sfalken

5 edits in branches/WindowsMerge

2007-05-04 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin.

Fix crash when using "check spelling while typing".

WebCore.vcproj/WebCore.vcproj: Added TextBreakIteratorInternalICUWin.cpp
platform/win/TemporaryLinkStubs.cpp: Removed findSentenceBoundary, findNextSentenceFromIndex.

2007-05-04 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin.

Fix crash when using "check spelling while typing".

WebView.cpp: (WebView::preflightSpellChecker): Set delegate static global for use in spell checker init.

9:08 PM Changeset in webkit [21270] by sfalken

9 edits
2 adds in trunk/WebCore

Reviewed by Oliver.

Use TextBreakIterator for sentence breaking instead of TextBoundaries.

WebCore.xcodeproj/project.pbxproj: Added TextBreakIeratorInternalICUMac.mm
editing/visible_units.cpp: (WebCore::startSentenceBoundary): Call TextBreakIterator instead of TextBoundaries. (WebCore::endSentenceBoundary): Call TextBreakIterator instead of TextBoundaries. (WebCore::previousSentencePositionBoundary): Call TextBreakIterator instead of TextBoundaries. (WebCore::nextSentencePositionBoundary): Call TextBreakIterator instead of TextBoundaries.
platform/TextBoundaries.h: Removed findSentenceBoundary, findNextSentenceFromIndex.
platform/TextBreakIterator.h: Added sentenceBreakIterator.
platform/TextBreakIteratorICU.cpp: (WebCore::setUpIterator): Add locale parameter (needed to maintain functionality that TextBoundaries code had). (WebCore::characterBreakIterator): Pass en_us for locale (same as old code). (WebCore::wordBreakIterator): Pass en_us for locale (same as old code). (WebCore::lineBreakIterator): Pass en_us for locale (same as old code). (WebCore::sentenceBreakIterator): Added.
platform/TextBreakIteratorInternalICU.h: Added.
platform/gdk/TemporaryLinkStubs.cpp: Removed findNextSentenceFromIndex, findSentenceBoundary. (WebCore::currentTextBreakLocaleID): Added stub.
platform/mac/TextBoundaries.mm: Removed currentTextBreakLocaleID, findSentenceBoundary, findNextSentenceFromIndex.
platform/mac/TextBreakIteratorInternalICUMac.mm: Added. (WebCore::currentTextBreakLocaleID): Moved from TextBoundaries.mm
platform/qt/TextBoundaries.cpp: Removed findNextSentenceFromIndex, findSentenceBoundary.

5:17 PM Changeset in webkit [21269] by adele

2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/5116871> REGRESSION: Can't select options in widget's listbox

Don't use user-select to determine whether or not options can be selected in listboxes.
This will match Firefox behavior for -moz-user-select.

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::canSelectAll): (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):

4:50 PM Changeset in webkit [21268] by thatcher

1 edit in tags/JavaScriptCore-418.5/JavaScriptCore/Info.plist

Versioning

4:49 PM Changeset in webkit [21267] by thatcher

1 copy in tags/JavaScriptCore-418.5

New tag.

4:47 PM Changeset in webkit [21266] by thatcher

1 edit in branches/Safari-2-0-branch/JavaScriptCore/kjs/collector.cpp

Build fix.

4:46 PM Changeset in webkit [21265] by thatcher

2 edits in tags/JavaScriptCore-418.3/JavaScriptCore

Reverting commit to the wrong tag.

4:43 PM Changeset in webkit [21264] by thatcher

1 delete in tags/JavaScriptCore-418.4/JavaScriptCore-418.3

Removing bad tag.

4:40 PM Changeset in webkit [21263] by thatcher

1 edit in tags/JavaScriptCore-418.4/JavaScriptCore/kjs/collector.cpp

Build fix.

4:39 PM Changeset in webkit [21262] by thatcher

2 edits in tags/JavaScriptCore-418.3/JavaScriptCore

Versioning

4:39 PM Changeset in webkit [21261] by ggaren

8 edits in trunk

WebCore:

Reviewed by Tim Hatcher.

First step in fixing <rdar://problem/5055182> The back cache has no global cap

Stop giving SnapBack infinite cache-ability. Instead, make SnapBack rely
on the underlying back cache.

WebCore.exp:
history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem):
history/HistoryItem.h:
loader/FrameLoader.cpp: (WebCore::FrameLoader::purgePageCache):

WebKit:

Reviewed by Tim Hatcher.

First step in fixing <rdar://problem/5055182> The back cache has no global cap

Stop giving SnapBack infinite cache-ability. Instead, make SnapBack rely
on the underlying back cache.

I left -setAlwaysAttemptToUsePageCache: as an empty stub because we don't
want to break Safari 2.0, but I removed its header declaration so nobody
else starts using it.

History/WebHistoryItem.mm: (-[WebHistoryItem setAlwaysAttemptToUsePageCache:]):
History/WebHistoryItemPrivate.h:

4:38 PM Changeset in webkit [21260] by thatcher

1 copy in tags/JavaScriptCore-418.4/JavaScriptCore-418.3

New tag.

4:38 PM Changeset in webkit [21259] by thatcher

2 edits in tags/JavaScriptCore-418.3/JavaScriptCore

Merge fix from r16614 (with build fix).

2:15 PM Changeset in webkit [21258] by ggaren

10 edits in trunk

WebCore:

Reviewed by Brady Eidson.

Removed export of clearPageCache(), since it was unused externally. I plan
to remove its use from WebCore eventually, too.

Removed usesPageCache(), since it was unused and it duplicated pageCacheSize().

WebCore.exp:
history/BackForwardList.cpp:
history/BackForwardList.h: Moved statics to the top of the class definition.
loader/FrameLoader.cpp: (WebCore::FrameLoader::canCachePage):

WebKit:

Reviewed by Brady Eidson.

Some cleanup in preparation for fixing <rdar://problem/5055182> The
back/forward cache has no global cap

Unified naming of WebKit/WebCore b/f lists -- instead of the potpourri
of webBackForwardList, backForwardList, list, kitList, coreList, listWrapper,
and webCoreBackForwardList, we use webBackForwardList for WebKit and
backForwardList for WebCore, matching their respective class names.

Removed "private" versions of kit() and core() -- kit() and core() are
canonically used for converting between WebKit API objects and WebCore
API objects. I think it's clearer to have only one way to do this.

Removed COMPUTE_DEFAULT_PAGE_CACHE_SIZE, since it was unused.

Removed _clearPageCache, since it was unused and it duplicated -setPageCacheSize:0.

Removed _usesPageCache, since it was unused and it duplicated -pageCacheSize.

11:19 AM Changeset in webkit [23343] by aliceli1

3 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

changed use of DeprecatedString::fromUTF8 to UTF8Encoding().decode()

platform/win/DragDataWin.cpp: (WebCore::fragmentFromHTML):
platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::documentFragment):

10:38 AM Changeset in webkit [21257] by darin

2 edits in trunk

Added bugs.webkit.org URL.

10:14 AM Changeset in webkit [21256] by darin

5 edits in trunk

JavaScriptCore:

Reviewed by Adele.

fix <rdar://problem/5007921> Number.toExponential doesn't work for negative numbers

kjs/number_object.cpp: (NumberProtoFunc::callAsFunction): Added a call to fabs before calling log10.

LayoutTests:

Reviewed by Adele.

test for <rdar://problem/5007921> Number.toExponential doesn't work for negative numbers

fast/js/kde/resources/Number.js: Added negative number versions of some tests of toFixed, toExponential, toPrecision, etc.
fast/js/kde/Number-expected.txt: Updated, new tests all passing.

10:13 AM Changeset in webkit [21255] by beidson

2 edits in trunk/WebKit

Reviewed by Mark Rowe

Added main thread assertion to WebHTMLView to help make sure 3rd party clients aren't trying
to draw on secondary threads

WebView/WebHTMLView.mm: (-[WebHTMLView drawRect:]): Added ASSERT_MAIN_THREAD()

9:42 AM Changeset in webkit [21254] by bdash

7 edits in trunk

2007-05-04 Anders Carlsson <andersca@apple.com>

Reviewed by Antti.

<rdar://problem/5179977> Use the correct URLs when dispatching delegate methods for data loads.

Restore behavior to matching release WebKit by adding a response URL to SubstituteData. If a nil base URL is
passed, set the _request_ URL to "about:blank", but the response URL to a generated "applewebdata" URL.

loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad): First, check for the SubstituteData's response URL.

(WebCore::FrameLoader::continueAfterNavigationPolicy):
No need to special case applewebdata URLs here, they're only used in the response.

loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::handleDataLoadNow): If the substitute data has a response URL, use it.

(WebCore::MainResourceLoader::loadNow):
Only load "about:blank" as an empty document if there's no substitute data.

loader/SubstituteData.h: (WebCore::SubstituteData::SubstituteData): (WebCore::SubstituteData::responseURL): Add responseURL member to SubstituteData.

2007-05-04 Anders Carlsson <andersca@apple.com>

Reviewed by Antti.

<rdar://problem/5179977> Use the correct URLs when dispatching delegate methods for data loads.

WebView/WebFrame.mm: (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): If the base URL is nil, set it to "about:blank", and set the response URL to a generated applewebdata URL.

WebView/WebView.mm: (+[WebView _canHandleRequest:]): No need to special-case applewebdata URLs here anymore, they're only used in responses.

5:25 AM Changeset in webkit [21253] by lars

2 edits in trunk/WebKitTools

Reviewed by Zack

Revert on line of the last commit. We still want to keep the RPATH
support in the pro file.

4:41 AM Changeset in webkit [21252] by lars

112 edits
1 add
15 deletes in trunk

Reviewed by Zack

Remove the old bitmap fonts I tried using to get reliable results from
DumpRenderTree on X11. Instead we now use the URW Type1 fonts from
ghostscript. I've added a mirror to simply check them out at
svn://labs.trolltech.com/svn/webkit/testfonts.

Fixed DumpRenderTree to make sure these fonts are the only ones we use
on X11 and added a fonts.conf file to get a well defined fontconfig
configuration.

Made sure run-webkit-tests forwards the WEBKIT_TESTFONTS environment variable
I use to find the fonts to DumpRenderTree.

Updated results for css1 to work with the new set of fonts.
Will update the other results once I see this works on all
machines we have.

1:07 AM Changeset in webkit [21251] by bdash

2 edits in tags/JavaScriptCore-418.4/JavaScriptCore

Versioning.

1:05 AM Changeset in webkit [21250] by bdash

2 edits in tags/JavaScriptCore-418.4/JavaScriptCore

Merge r16614.

12:56 AM Changeset in webkit [21249] by bdash

1 copy in tags/JavaScriptCore-418.4

New tag.

12:52 AM Changeset in webkit [21248] by bdash

2 edits in branches/Safari-2-0-branch/JavaScriptCore

Merge r16614.

12:43 AM Changeset in webkit [21247] by bdash

3 edits in branches/Safari-2-0-branch/WebKit

Merge r20042 and follow-ups from r20050, r20058, r20064, r20077 and r20668.

May 3, 2007:

11:59 PM Changeset in webkit [23342] by sfalken

8 edits in branches/WindowsMerge

2007-05-03 Steve Falkenburg <sfalken@apple.com>

Reviewed by Ada, Oliver.

Checkpoint:
<rdar://problem/4602372> Spelling
<rdar://problem/4769763> Spell checking engine support

2007-05-03 Steve Falkenburg <sfalken@apple.com>

Reviewed by Ada, Oliver.

Checkpoint:
<rdar://problem/4602372> Spelling
<rdar://problem/4769763> Spell checking engine support

Spelling panel is now partially functional with this check-in.
Learn/Ignore not yet implemented, Find Next, Correct, language
selection, grammar toggle works.

Grammar checking is functional with this check-in.

2007-05-03 Steve Falkenburg <sfalken@apple.com>

Reviewed by Ada, Oliver.

Checkpoint:
<rdar://problem/4602372> Spelling
<rdar://problem/4769763> Spell checking engine support

Interfaces/IWebEditingDelegate.idl: Add userDescription parameter.
WebEditorClient.cpp: (WebEditorClient::updateSpellingUIWithGrammarString): Set user description for spelling errors.
WebEditorClient.h:
WebView.cpp: (WebView::replaceSelectionWithText): Implemented.

2007-05-03 Steve Falkenburg <sfalken@apple.com>

Reviewed by Ada, Oliver.

Checkpoint:
<rdar://problem/4602372> Spelling
<rdar://problem/4769763> Spell checking engine support

platform/win/EditorWin.cpp: (WebCore::findFirstBadGrammarInRange): Account for start offset when reporting bad grammar range (fixed my porting mistake). (WebCore::Editor::advanceToNextMisspelling): Include user description with spelling error. (WebCore::isRangeUngrammatical): Include user description with spelling error.

11:44 PM Changeset in webkit [21246] by sfalken

10 edits in trunk

2007-05-03 Steve Falkenburg <sfalken@apple.com>

Reviewed by Oliver.

Add missing user description parameter to spelling-related editor client method.

WebCoreSupport/WebEditorClient.h: (WebEditorClient::updateSpellingUIWithGrammarString):

2007-05-03 Steve Falkenburg <sfalken@apple.com>

Reviewed by Oliver.

Add missing user description parameter to spelling-related editor client method.

bridge/EditorClient.h:
platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::updateSpellingUIWithGrammarString):
platform/gdk/EditorClientGdk.h:
platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyEditorClient::updateSpellingUIWithGrammarString):

2007-05-03 Steve Falkenburg <sfalken@apple.com>

Reviewed by Oliver.

Add missing user description parameter to spelling-related editor client method.

WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::updateSpellingUIWithGrammarString):
WebCoreSupport/EditorClientQt.h:

11:14 PM Changeset in webkit [23341] by aliceli1

3 edits in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Fixed <rdar://5181466> HTML formatted clipboard data is not converted from UTF8 when pasted

platform/win/DragDataWin.cpp: (WebCore::fragmentFromHTML):
platform/win/PasteboardWin.cpp: (WebCore::fragmentFromCF_HTML): (WebCore::Pasteboard::documentFragment):

11:05 PM Changeset in webkit [23340] by oliver

2 edits in branches/WindowsMerge/WebCore

2007-05-03 Oliver Hunt <oliver@apple.com>

Reviewed by Steve

Fix misuse of GlobalLock.

platform/win/PasteboardWin.cpp: (WebCore::createGlobalData):

9:35 PM Changeset in webkit [21245] by beidson

6 edits in trunk/WebCore

Reviewed by Oliver

Resolve an outstanding FIXME in Loader::numRequests()

Before, numRequests() would iterate through the list of requests pending load and the list of currently
loading requests and tally up a count matching the current DocLoader.

I noticed while studying and cleaning up the loader code that numRequests() is potentially very hot!
Indeed load a complex site with many resources and multiple frames, and this method gets called very often,
tallying up this number every time.

The FIXME was to keep a collection of Requests mapped to each DocLoader. In reality, since this map would
simply be used for retrieving a count, that was overkill. Keeping a request count in the DocLoader itself
along with maintaining that count in Loader as requests come and go is a much better way to do this.

loader/DocLoader.cpp: (WebCore::DocLoader::DocLoader): (WebCore::DocLoader::incrementRequestCount): (WebCore::DocLoader::decrementRequestCount): (WebCore::DocLoader::requestCount): Emulate the defunct Loader::numRequests()
loader/DocLoader.h:

loader/FrameLoader.cpp: (WebCore::numRequests): Call DocLoader::requestCount() directly (WebCore::FrameLoader::checkCompleted): Use numRequests()

loader/loader.cpp: (WebCore::Loader::load): Increment the DocLoader's request count (WebCore::Loader::servePendingRequests): If the SubresourceLoader failed to create, decrement the count (WebCore::Loader::didFinishLoading): If the Request is not Multipart, decrement the count (WebCore::Loader::didFail): If the Request is not Multipart, decrement the count (WebCore::Loader::didReceiveResponse): If the Request becomes Multipart, decrement the count (WebCore::Loader::cancelRequests): Decrement the count for the pending requests being tossed, and ASSERT the count is zero after all requests have been cancelled
loader/loader.h:

9:34 PM Changeset in webkit [23339] by oliver

3 edits in branches/WindowsMerge/WebCore

2007-05-03 Oliver Hunt <oliver@apple.com>

Reviewed by Steve.

Add logic to draw underlines for grammar and spelling errors.
(rdar://problem/4769832)

platform/win/GraphicsContextWin.cpp: (WebCore::spellingPatternColor): (WebCore::grammarPatternColor): Can't define global const with constructor so use function scoped globals instead. (WebCore::setCGStrokeColor): Utility function pulled over from GraphicsContextCG (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):

platform/win/TemporaryLinkStubs.cpp: Remove old drawLineForMisspellingOrBadGrammar stub

8:55 PM Changeset in webkit [21244] by ggaren

3 edits in trunk/WebCore

Reviewed by Brady Eidson.

Some cleanup in preparation for fixing <rdar://problem/5055182> The
back/forward cache has no global cap

loader/FrameLoader.cpp: (WebCore::FrameLoader::provisionalLoadStarted): Moved "Can I cache this page?" logic to canCachePage(). Moved "I am caching this page" logic to cachePageToHistoryItem(). (WebCore::FrameLoader::canCachePage): Moved above logic here. (WebCore::FrameLoader::cachePageToHistoryItem): Removed bogus NULL check and failure return value. Moved above logic here. Don't call setCachedPage() until the CachedPage is fully constructed. (WebCore::FrameLoader::purgePageCache): Removed comment that duplicated the function name.
loader/FrameLoader.h:

6:54 PM Changeset in webkit [21243] by harrison

2 edits in trunk/WebCore

Reviewed by harrison.

<rdar://problem/5120281> CrashTracer: [USER] 1 crash in Mail at WebCore::CSSComputedStyleDeclaration::copyInheritableProperties() const

Problem is that checkAncestor and lastClosed can be nil when createMarkup is called unrendered nodes, and that was not checked for.

editing/markup.cpp: (WebCore::createMarkup): Nil-check checkAncestor and lastClosed.

5:51 PM Changeset in webkit [21242] by bdash

1 copy in tags/Safari-4522.7

New tag.

5:50 PM Changeset in webkit [21241] by bdash

4 edits in branches/Safari-522

Versioning.

4:08 PM Changeset in webkit [21240] by thatcher

2 edits in trunk/WebKit

Reviewed by Kevin.

<rdar://problem/4975212> REGRESSION: With NetNewsWire 2.1.1, the contextual menu shows extra menu items when focus
is placed in input or textarea field

The NetNewsWire UI delegate isn't expecting calls for form controls, so we need to do a linked-on-or-after check.
If the application was linked against Tiger or earlier and the element is a text form control, just return the
default menu items and bypass the delegate call completely.

WebCoreSupport/WebContextMenuClient.mm: (isPreVersion3Client): Cache the result of the WebKitLinkedOnOrAfter call (fixMenusToSendToOldClients): Call the new isPreVersion3Client() (fixMenusReceivedFromOldClients): Ditto. (WebContextMenuClient::getCustomMenuFromDefaultItems): Return the default menu items if the element is a text form control.

3:50 PM Changeset in webkit [21239] by bdash

2 edits in branches/Safari-522/WebKit

Merge r21238.

3:48 PM Changeset in webkit [21238] by bdash

2 edits in trunk/WebKit

2007-05-03 Mark Rowe <mrowe@apple.com>

Reviewed by Geoff and Kevin.

<rdar://problem/5141290> WebAssertions.h is still needed by some internal clients

Second shot at fixing this error. Stub out the macros rather than forwarding to JavaScriptCore, which would
leave clients using this header trying to resolve JavaScriptCore symbols against WebKit when linking. This
should only happen in production builds when assertions should be disabled anyway as anyone building a
development configuration should be in a position to move away from using this header.

Misc/WebAssertions.h:

3:23 PM Changeset in webkit [21237] by thatcher

2 edits in trunk/WebCore

Reviewed by Kevin.

<rdar://problem/5016318> Contextual menu item for opening links is missing in compose windows but present in viewer

Add the Open Link, Open Link in New Window, Download Linked File and Copy Link menu
items to the content editable context menu.

platform/ContextMenu.cpp: (WebCore::ContextMenu::populate):

3:10 PM Changeset in webkit [21236] by brmorris

2 edits in S60/trunk/WebKit

brmorris, reviewed by sachin

DESC: stub this out in SDK development environment:

BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::SelectedLanguage):

3:04 PM Changeset in webkit [21235] by hausmann

14 edits
1 add in trunk

Gdk build fixes using the Qt build's qmake tool from Holger Freyther, reviewed by Zack.

2:50 PM Changeset in webkit [21234] by thatcher

2 edits in trunk/WebKit

Reviewed by Kevin.

<rdar://problem/5067707> REGRESSION: "Open Link" contextual menu item appears twice in Mail

Remove the check for Mail in fixMenusToSendToOldClients and fixMenusReceivedFromOldClients
when linked on or after Leopard. The isAppleMail() function is still used for Tiger Mail fixups.

WebCoreSupport/WebContextMenuClient.mm: (fixMenusToSendToOldClients): (fixMenusReceivedFromOldClients):

2:37 PM Changeset in webkit [21233] by adele

2 edits in trunk/WebCore

Use BUILDING_ON_TIGER.

page/mac/FrameMac.mm: (WebCore::Frame::setUseSecureKeyboardEntry):

2:35 PM Changeset in webkit [21232] by beidson

3 edits in trunk/WebCore

Reviewed by Darin

Some more minor cleanup that resolves a FIXME and ditches another pointless method

No change in functionality == no layout test

loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad): Updated a comment (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): Folded startLoading() into this method (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): continueAfterWillSubmitForm becomes continueLoadAfterWillSubmitForm
loader/FrameLoader.h: Removed startLoading()

2:30 PM Changeset in webkit [21231] by brmorris

3 edits in S60/trunk/S60Internals

brmorris, reviewed by rasvcan

DESC: land some changes to wmlengine that i forgot to commit :(

S60DynamicLibs.zip: updated wmlengine.lib
S60Headers.zip: updated wmlengineinterface.h

2:29 PM Changeset in webkit [21230] by adele

2 edits in trunk/WebCore

Reviewed by Tim Hatcher.

Fix for <rdar://problem/4727607> REGRESSION: KeyScript is deprecated, need a new solution for forcing Roman input for password fields on Leopard

page/mac/FrameMac.mm: (WebCore::Frame::setUseSecureKeyboardEntry): Use TSMSetDocumentProperty and TSMRemoveDocumentProperty on Leopard disable and enable non-ascii input sources.

11:50 AM Changeset in webkit [21229] by beidson

3 edits in trunk/WebCore

Reviewed by Anders

commitProvisionalLoad() was the name of two methods.
One of them was private and only called from one other private place.
This was driving me crazy. I had to change that.

No change in functionality == no layout test

loader/FrameLoader.cpp: (WebCore::FrameLoader::transitionToCommitted): roll commitProvisionalLoad() into this method
loader/FrameLoader.h: Removed commitProvisionalLoad()

11:37 AM Changeset in webkit [21228] by ggaren

2 edits in trunk/WebKitTools

Build fix: Add AllInOneFile.o to the ignore list, since it includes files
in the ignore list.

Scripts/check-for-global-initializers:

9:23 AM Changeset in webkit [21227] by darin

6 edits in trunk/WebCore

Reviewed by Anders.

make ICU initialization lazy to speed up application start-up time (when it includes an initial webpage load)

platform/TextCodecICU.h: Replaced registerEncodingNames and registerCodecs with registerBaseEncodingNames, registerBaseCodecs, registerExtendedEncodingNames, and registerExtendedCodecs.
platform/TextCodecICU.cpp: (WebCore::newTextCodecICU): Moved up to the top of the file. (WebCore::TextCodecICU::registerBaseEncodingNames): Added. Registers just UTF-8. (WebCore::TextCodecICU::registerBaseCodecs): Ditto. (WebCore::TextCodecICU::registerExtendedEncodingNames): Renamed. (WebCore::TextCodecICU::registerExtendedCodecs): Ditto. (WebCore::TextCodecICU::createICUConverter): Compare with the name "GBK" in a way that does not require extending the maps.

platform/TextEncoding.cpp: (WebCore::TextEncoding::usesVisualOrdering): Added code so this will just return false if we haven't used any extended encoding names yet. The result will be correct, and we won't ask for an encoding name that will require registering the extended encoding names. (WebCore::TextEncoding::isJapanese): Ditto. (WebCore::TextEncoding::backslashAsCurrencySymbol): Ditto, but return a backslash instead of false.

platform/TextEncodingRegistry.h: Added a new function named noExtendedTextEncodingNameUsed.
platform/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps): Added. Registers the base encodings, including Latin-1 because it's the default, and the UTF encodings. (WebCore::extendTextCodecMaps): Added. Registers all the other encodings. (WebCore::newTextCodec): Removed the all to buildTextCodecMap because we always build the map when making the canonical encoding name. (WebCore::atomicCanonicalTextEncodingName): Changed code to build only the base maps at first, then extend the maps the first time we run into a name we don't know. (WebCore::noExtendedTextEncodingNameUsed): Added.

May 2, 2007:

9:39 PM Changeset in webkit [21226] by bdash

2 edits in trunk/WebCore

2007-05-03 Mark Rowe <mrowe@apple.com>

Qt build fix. In r21185 the Qt version of WebCore::scaleDragImage was
updated to have the incorrect signature.

platform/qt/DragImageQt.cpp: (WebCore::scaleDragImage):

3:27 PM Changeset in webkit [21225] by bdakin

2 edits in trunk/WebCore

dom/Node.h: Just fixing a variable name because it's driving me mad.

3:16 PM Changeset in webkit [21224] by bdakin

15 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/4513966> Never-ending identical repaint @
orbitz.com (Safari eating 85% CPU)

We need to be a little bit more savvy about when we do a FULL style
recalc since it can be unnecessary and expensive.

css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::setChanged): Now takes a StyleChangeType as a parameter. (WebCore::CSSMutableStyleDeclaration::setProperty): Send InlineStyleChange as the paramter. This is the optimization!
css/CSSMutableStyleDeclaration.h: setChanged takes a StyleChangeType as a parameter.
dom/Document.cpp: setChanged now takes a StyleChangeType instead of a bool. (WebCore::Document::recalcStyle): Same.
dom/Element.cpp: (WebCore::Element::recalcStyle): This is the fix!! Only set change to Force is we use descendant rules AND it's a FullStyleChange.
dom/Node.cpp: m_hasStyle was an unused bit on Node, so this patch gets rid of it and uses that extra bit for m_changed to be a StyleChangeType instead of a bool. (WebCore::Node::Node): (WebCore::Node::setChanged): (WebCore::Node::dump):
dom/Node.h: Same. (WebCore::): Define the StyleChangeType enum. (WebCore::Node::hasClass): (WebCore::Node::changed): (WebCore::Node::styleChangeType): (WebCore::Node::setHasClass):
dom/StyledElement.cpp: (WebCore::StyledElement::parseMappedAttribute): Don't bother calling setHasStyle() since m_hasStyle is gone now. It was never used, and this was the only place it was set.
dom/Text.cpp: (WebCore::Text::recalcStyle): setChanged now takes a StyleChangeType instead of a bool.
html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::recalcStyle): Same.
html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::restoreState): Same. (WebCore::HTMLSelectElement::reset): Same.
html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValue): Same.
ksvg2/misc/SVGTimer.cpp: (WebCore::SVGTimer::applyAnimations): Same.
ksvg2/svg/SVGUseElement.cpp: (WebCore::SVGUseElement::recalcStyle): Same.
platform/graphics/svg/SVGResource.cpp: (WebCore::SVGResource::repaintClients): Same.

12:36 PM Changeset in webkit [21223] by andersca

2 edits in trunk/WebKit

Reviewed by Brady.

<rdar://problem/5151113> Assertion firing in [FrameProgressEntry addChild:forDataSource:] when navigating cnn.com

The assertion fired because a plug-in was trying to load a subresource when a new load had started but not yet
committed. The check that would have prevented this was removed in order to fix <rdar://problem/5085897>.

This puts back the check but changes it to allow loads where the target is the same frame as the plugin's parent frame.

Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):

7:54 AM Changeset in webkit [21222] by harrison

3 edits in trunk/WebCore

Reviewed by Antti.

<rdar://problem/4859132> Grammar must always be checked in entire-sentence chunks, and shouldn't show markers for current sentence

Restore the remainder of the original fix now that blocking bug rdar://5174862 is addressed.

John made the original patch on 2007-04-10, but this fell prey to rdar://5157329.
Justin backed out the whole patch on 2007-04-30 to avoid the crash.
Justin then restored most of the original patch, but used word granularity instead, to keep the build working.
I just addressed the root cause of rdar://5157329 in rdar://5174862.
This patch switches the temp uses of word granularity back to sentence granularity.

editing/mac/EditorMac.mm: (WebCore::Editor::markMisspellingsAfterTypingToPosition):
page/Frame.cpp: (WebCore::Frame::respondToChangedSelection):

6:11 AM Changeset in webkit [21221] by harrison

6 edits
4 adds in trunk

JavaScriptCore:

Reviewed by Antti.

<rdar://problem/5174862> Crash resulting from DeprecatedString::insert()

Added insertion support for more than one value.

wtf/Vector.h: (WTF::::insert): Added support for inserting multiple values.

(WTF::::prepend):
New. Insert at the start of vectors. Convenient for vectors used as strings.

LayoutTests:

Reviewed by Antti.

test for <rdar://problem/5174862> Crash resulting from DeprecatedString::insert()

editing/selection/move-by-sentence-001-expected.checksum: Added.
editing/selection/move-by-sentence-001-expected.png: Added.
editing/selection/move-by-sentence-001-expected.txt: Added.
editing/selection/move-by-sentence-001.html: Added.

WebCore:

Reviewed by Antti.

<rdar://problem/5174862> Crash resulting from DeprecatedString::insert()

Test added: editing/selection/move-by-sentence-001.html

editing/visible_units.cpp: (WebCore::previousBoundary): (WebCore::nextBoundary): Use a UChar Vector instead of DeprecatedString. Avoid creating an extra string for secure bullet replacement unless it is actually needed.

platform/DeprecatedString.cpp: (WebCore::DeprecatedString::insert): Call forceUnicode() before setLength(), so that only the unicode buffer is resized.

(WebCore::DeprecatedString::setLength):

Adjust the unicode buffer even if the ascii buffer is valid.

2:21 AM Changeset in webkit [21220] by bdash

3 edits in trunk/WebKitTools

2007-05-02 Holger Freyther <freyther@kde.org>

Reviewed by Mark Rowe.

Scripts/build-webkit: Remove the CMake call.
Scripts/webkitdirs.pm: Remove isQtWithQMake as QMake is now the only buildsystem for the Qt port.

2:20 AM Changeset in webkit [21219] by bdash

6 edits in trunk/WebCore

2007-05-02 Mitz Pettel <mitz@webkit.org>

Reviewed by Brady.

http://bugs.webkit.org/show_bug.cgi?id=13564 Remove friend class FrameLoader from Frame

No test added since there is no change in functionality.

loader/FrameLoader.cpp: (WebCore::FrameLoader::didOpenURL): (WebCore::FrameLoader::begin): (WebCore::FrameLoader::open):
loader/FrameLoader.h: Made clear() private.
page/Frame.cpp: (WebCore::Frame::setDocument): Changed the argument into a PassRefPtr.
page/Frame.h:
xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource):

2:17 AM Changeset in webkit [21218] by bdash

3 edits
5 adds in trunk

2007-05-02 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=9276 Quirksmode: Image swap resize bug

Test: fast/replaced/image-resize-width.html

rendering/RenderImage.cpp: (WebCore::RenderImage::imageChanged): Moved the call to dirtyPrefWidths() before the call to calcWidth().

2007-05-02 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

test for http://bugs.webkit.org/show_bug.cgi?id=9276 Quirksmode: Image swap resize bug

fast/replaced/image-resize-width-expected.checksum: Added.
fast/replaced/image-resize-width-expected.png: Added.
fast/replaced/image-resize-width-expected.txt: Added.
fast/replaced/image-resize-width.html: Added.
fast/replaced/resources/rectangle-red-200x100.png: Added.

1:44 AM Changeset in webkit [21217] by hyatt

4 adds in trunk/LayoutTests/fast/block/positioning

Add layout test for dashboard bug.

1:39 AM Changeset in webkit [21216] by hyatt

2 edits in trunk/WebCore

Fix for bug 13566, broken Dashboard widgets. setPrefWidthsDirty did
the wrong thing for text children of a positioned element.

Reviewed by mitz

fast/block/positioning/pref-width-change.html

rendering/RenderObject.cpp: (WebCore::RenderObject::setPrefWidthsDirty):

May 1, 2007:

6:40 PM Changeset in webkit [21215] by darin

2 edits in trunk/WebCore

rendering/RenderReplaced.cpp: Fix typo in a comment.

3:31 PM Changeset in webkit [21214] by hyatt

4 adds in trunk/LayoutTests/fast/css-generated-content

Add layout test for 13558.

3:27 PM Changeset in webkit [21213] by hyatt

2 edits in trunk/WebCore

Fix for 13558, crash when using absolutely positioned generated content
inside an inline.

Reviewed by darin

fast/css-generated-content/absolute-position-inside-inline.html

rendering/RenderContainer.cpp: (WebCore::RenderContainer::updateBeforeAfterContentForContainer):

3:20 PM Changeset in webkit [21212] by justing

12 edits
4 adds in trunk

LayoutTests:

Reviewed by darin

<rdar://problem/5002441>
Pressing space key does nothing above quoted content or a signature

Demonstrates the bug:

editing/inserting/5002441-expected.checksum: Added.
editing/inserting/5002441-expected.png: Added.
editing/inserting/5002441-expected.txt: Added.
editing/inserting/5002441.html: Added.

Fixed. Spaces passed to execCommand("InsertText", ...)
are no longer collapsed:

editing/inserting/editable-html-element-expected.checksum:
editing/inserting/editable-html-element-expected.png:
editing/inserting/editable-html-element-expected.txt:
editing/pasteboard/4989774-expected.checksum:
editing/pasteboard/4989774-expected.png:
editing/pasteboard/4989774-expected.txt:
editing/selection/4983858-expected.checksum:
editing/selection/4983858-expected.png:
editing/selection/4983858-expected.txt:

WebCore:

Reviewed by darin

<rdar://problem/5002441>
Pressing space key does nothing above quoted content or a signature

Inserting a space under these circumstances inserts a single
text node containing a regular space and then does a layout.
That space isn't rendered (which is correct). Whitespace
rebalancing is supposed to correct it but failed. It replaces
the space with a non-breaking space, but that change doesn't
dirty line boxes (9441) and so the space isn't rendered.

This workaround turns all incoming spaces into non-breaking
spaces before they're inserted (they're rebalanced after
insertion and turned back into regular spaces if possible).

editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::prepareForTextInsertion): Removed an old irrelevant FIXME. (WebCore::InsertTextCommand::input): Turn incoming spaces into non breaking spaces before inserting them.

3:10 PM Changeset in webkit [21211] by darin

14 edits
4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

test for http://bugs.webkit.org/show_bug.cgi?id=13559 REGRESSION: Canvas aspect ratio is incorrect

fast/canvas/canvas-size-change-after-layout-expected.checksum: Added.
fast/canvas/canvas-size-change-after-layout-expected.png: Added.
fast/canvas/canvas-size-change-after-layout-expected.txt: Added.
fast/canvas/canvas-size-change-after-layout.html: Added.

WebCore:

Reviewed by Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=13559 REGRESSION: Canvas aspect ratio is incorrect

remove intrinsicWidth/Height functions from RenderObject

Test: fast/canvas/canvas-size-change-after-layout.html

html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createRenderer): Removed code to set the intrinsic size, because the renderer now takes care of this in its constructor. (WebCore::HTMLCanvasElement::reset): Instead of calling the setIntrinsicWidth/Height functions, call canvasSizeChanged, which takes care of layout, but only if the size actually changed. Also call repaint if the contents of the canvas changed.

rendering/RenderApplet.h:
rendering/RenderApplet.cpp: (WebCore::RenderApplet::intrinsicSize): Override the new intrinsicSize function. This override still doesn't make sense, so left a FIXME in here.

rendering/RenderBox.h: Added an intrinsicSize function here to replace the intrinsicWidth/Height functions removed from RenderObject.
rendering/RenderBox.cpp: (WebCore::RenderBox::calcReplacedWidthUsing): Use intrinsicSize instead of intrinsicWidth. (WebCore::RenderBox::calcReplacedHeightUsing): Ditto, but for height.

rendering/RenderHTMLCanvas.h: Changed the constructor parameter to be an HTMLCanvasElement* instead of Node*. Also added a canvasSizeChanged function.
rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::RenderHTMLCanvas): Pass an initial intrinsic size based on the current size of the canvas element. This is now the responsibility of the renderer and the DOM element calls the canvasSizeChanged function when the size changes. (WebCore::RenderHTMLCanvas::paint): Removed checks of the type of the element, and used the node() function because we don't have to worry about the anonymous case in this class. (WebCore::RenderHTMLCanvas::canvasSizeChanged): Added. Changes the size and then calls setNeedsLayout and setPrefWidthsDirty as needed. I based the logic here on careful reading of RenderImage::imageChanged.

rendering/RenderImage.cpp: (WebCore::RenderImage::RenderImage): Pass a default intrinsic size of 0,0 instead of calling setIntrinsicWidth/Height. (WebCore::RenderImage::setImageSizeForAltText): Call the new intrinsic size functions instead of the width/height ones. Simplifies the logic since we handle both dimensions at once. (WebCore::RenderImage::imageChanged): Ditto. (WebCore::RenderImage::layout): Ditto. (WebCore::RenderImage::calcAspectRatioWidth): Ditto. (WebCore::RenderImage::calcAspectRatioHeight): Ditto.

rendering/RenderObject.h: Removed intrinsicWidth/Height virtual functions.

rendering/RenderReplaced.h: Replaced intrinsicWidth, intrinsicHeight, setIntrinsicWidth, setIntrinsicHeight, m_intrinsicWidth, and m_intrinsicHeight with intrinsicSize, setIntrinsicSize, and m_intrinsicSize.
rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::RenderReplaced): Added a second contructor that takes an intrinsic size parameter. Also updated constructor since the intrinsic size is now an IntSize instead of two integers. (WebCore::RenderReplaced::intrinsicSize): Added. No point in making this inline because it's a virtual function. (WebCore::RenderReplaced::setIntrinsicSize): Added. Didn't make this inline, partly because in the future we might want this to be more than just a simple setter function, factoring in common code used in both RenderImage and RenderHTMLCanvas.

rendering/RenderWidget.h: Removed a stray using declaration that wasn't needed.

2:37 PM Changeset in webkit [21210] by spadma

2 edits in S60/trunk/WebKit

yadavall, reviewed by <sachin.padma@nokia.com>

DESC: Toolbar should be activated only on long keypress
http://bugs.webkit.org/show_bug.cgi?id=12816

BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleOfferKeyEventL): (CKeyEventHandler::HandleActivateKeysL):

1:44 PM Changeset in webkit [23338] by sfalken

4 edits in branches/WindowsMerge

2007-05-01 Steve Falkenburg <sfalken@apple.com>

Reviewed by Oliver.

Fix usage errors in COM enumeration.

WebEditorClient.cpp: (WebEditorClient::checkGrammarOfString): Call Next correctly. (WebEditorClient::getGuessesForWord): Call Next correctly.

2007-05-01 Steve Falkenburg <sfalken@apple.com>

Reviewed by Oliver.

Fix crash when retrieving title of context menu after it has been selected.
Necessary to get spelling corrections code working.

platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::itemWithAction): menu item info fType is a set of flags, MFT_STRING is 0, so we need to or off flags before comparing.

1:11 PM Changeset in webkit [21209] by hyatt

4 edits in trunk/WebCore

Fix for hang when incorrectly trying to add before/after content to
a <select>. Disallow generated content in all selects and also turn it
off for <input> buttons.

Reviewed by aroben

rendering/RenderBlock.cpp: (WebCore::RenderBlock::setStyle):
rendering/RenderButton.cpp: (WebCore::RenderButton::canHaveChildren):
rendering/RenderButton.h:

12:59 PM Changeset in webkit [21208] by darin

114 edits
2 adds in trunk

LayoutTests:

Reviewed by Hyatt.

added a test for <rdar://problem/5172596> HTML-parser-created tbody elements are being ignored when processing CSS child rules

fast/css/child-selector-implicit-tbody.html: Added.
fast/css/child-selector-implicit-tbody-expected.txt: Added.

updated test results for <rdar://problem/5172607> XML parser is creating implicit tbody elements; the only change is the tag name that's dumped

fast/table/037-expected.txt:
tables/mozilla/marvin/x_caption_align_bottom-expected.txt:
tables/mozilla/marvin/x_caption_align_top-expected.txt:
tables/mozilla/marvin/x_caption_class-expected.txt:
tables/mozilla/marvin/x_caption_id-expected.txt:
tables/mozilla/marvin/x_caption_style-expected.txt:
tables/mozilla/marvin/x_col_align_center-expected.txt:
tables/mozilla/marvin/x_col_align_char-expected.txt:
tables/mozilla/marvin/x_col_align_justify-expected.txt:
tables/mozilla/marvin/x_col_align_left-expected.txt:
tables/mozilla/marvin/x_col_align_right-expected.txt:
tables/mozilla/marvin/x_col_span-expected.txt:
tables/mozilla/marvin/x_col_valign_baseline-expected.txt:
tables/mozilla/marvin/x_col_valign_bottom-expected.txt:
tables/mozilla/marvin/x_col_valign_middle-expected.txt:
tables/mozilla/marvin/x_col_valign_top-expected.txt:
tables/mozilla/marvin/x_col_width_pct-expected.txt:
tables/mozilla/marvin/x_col_width_px-expected.txt:
tables/mozilla/marvin/x_col_width_rel-expected.txt:
tables/mozilla/marvin/x_colgroup_align_center-expected.txt:
tables/mozilla/marvin/x_colgroup_align_char-expected.txt:
tables/mozilla/marvin/x_colgroup_align_justify-expected.txt:
tables/mozilla/marvin/x_colgroup_align_left-expected.txt:
tables/mozilla/marvin/x_colgroup_align_right-expected.txt:
tables/mozilla/marvin/x_colgroup_span-expected.txt:
tables/mozilla/marvin/x_colgroup_valign_baseline-expected.txt:
tables/mozilla/marvin/x_colgroup_valign_bottom-expected.txt:
tables/mozilla/marvin/x_colgroup_valign_middle-expected.txt:
tables/mozilla/marvin/x_colgroup_valign_top-expected.txt:
tables/mozilla/marvin/x_colgroup_width_rel-expected.txt:
tables/mozilla/marvin/x_table_align_center-expected.txt:
tables/mozilla/marvin/x_table_align_left-expected.txt:
tables/mozilla/marvin/x_table_align_right-expected.txt:
tables/mozilla/marvin/x_table_bgcolor_name-expected.txt:
tables/mozilla/marvin/x_table_bgcolor_rgb-expected.txt:
tables/mozilla/marvin/x_table_cellpadding-expected.txt:
tables/mozilla/marvin/x_table_cellpadding_pct-expected.txt:
tables/mozilla/marvin/x_table_cellspacing-expected.txt:
tables/mozilla/marvin/x_table_cellspacing_pct-expected.txt:
tables/mozilla/marvin/x_table_class-expected.txt:
tables/mozilla/marvin/x_table_id-expected.txt:
tables/mozilla/marvin/x_table_style-expected.txt:
tables/mozilla/marvin/x_table_width_pct-expected.txt:
tables/mozilla/marvin/x_table_width_px-expected.txt:
tables/mozilla/marvin/x_td_align_center-expected.txt:
tables/mozilla/marvin/x_td_align_char-expected.txt:
tables/mozilla/marvin/x_td_align_justify-expected.txt:
tables/mozilla/marvin/x_td_align_left-expected.txt:
tables/mozilla/marvin/x_td_align_right-expected.txt:
tables/mozilla/marvin/x_td_bgcolor_name-expected.txt:
tables/mozilla/marvin/x_td_bgcolor_rgb-expected.txt:
tables/mozilla/marvin/x_td_class-expected.txt:
tables/mozilla/marvin/x_td_colspan-expected.txt:
tables/mozilla/marvin/x_td_height-expected.txt:
tables/mozilla/marvin/x_td_id-expected.txt:
tables/mozilla/marvin/x_td_nowrap-expected.txt:
tables/mozilla/marvin/x_td_rowspan-expected.txt:
tables/mozilla/marvin/x_td_style-expected.txt:
tables/mozilla/marvin/x_td_valign_baseline-expected.txt:
tables/mozilla/marvin/x_td_valign_bottom-expected.txt:
tables/mozilla/marvin/x_td_valign_middle-expected.txt:
tables/mozilla/marvin/x_td_valign_top-expected.txt:
tables/mozilla/marvin/x_td_width-expected.txt:
tables/mozilla/marvin/x_th_align_center-expected.txt:
tables/mozilla/marvin/x_th_align_char-expected.txt:
tables/mozilla/marvin/x_th_align_justify-expected.txt:
tables/mozilla/marvin/x_th_align_left-expected.txt:
tables/mozilla/marvin/x_th_align_right-expected.txt:
tables/mozilla/marvin/x_th_bgcolor_name-expected.txt:
tables/mozilla/marvin/x_th_bgcolor_rgb-expected.txt:
tables/mozilla/marvin/x_th_class-expected.txt:
tables/mozilla/marvin/x_th_colspan-expected.txt:
tables/mozilla/marvin/x_th_height-expected.txt:
tables/mozilla/marvin/x_th_id-expected.txt:
tables/mozilla/marvin/x_th_nowrap-expected.txt:
tables/mozilla/marvin/x_th_rowspan-expected.txt:
tables/mozilla/marvin/x_th_style-expected.txt:
tables/mozilla/marvin/x_th_valign_baseline-expected.txt:
tables/mozilla/marvin/x_th_valign_bottom-expected.txt:
tables/mozilla/marvin/x_th_valign_middle-expected.txt:
tables/mozilla/marvin/x_th_valign_top-expected.txt:
tables/mozilla/marvin/x_th_width-expected.txt:
tables/mozilla/marvin/x_tr_align_center-expected.txt:
tables/mozilla/marvin/x_tr_align_char-expected.txt:
tables/mozilla/marvin/x_tr_align_justify-expected.txt:
tables/mozilla/marvin/x_tr_align_left-expected.txt:
tables/mozilla/marvin/x_tr_align_right-expected.txt:
tables/mozilla/marvin/x_tr_bgcolor_name-expected.txt:
tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.txt:
tables/mozilla/marvin/x_tr_class-expected.txt:
tables/mozilla/marvin/x_tr_id-expected.txt:
tables/mozilla/marvin/x_tr_style-expected.txt:
tables/mozilla/marvin/x_tr_valign_baseline-expected.txt:
tables/mozilla/marvin/x_tr_valign_bottom-expected.txt:
tables/mozilla/marvin/x_tr_valign_middle-expected.txt:
tables/mozilla/marvin/x_tr_valign_top-expected.txt:
tables/mozilla_expected_failures/bugs/bug178855-expected.txt:
tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.txt:
tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.txt:
tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.txt:
tables/mozilla_expected_failures/marvin/x_colgroup_width_px-expected.txt:

WebCore:

Reviewed by Hyatt.

removed the m_implicit bit from Node, freeing up a bit

fixed <rdar://problem/5172607> XML parser is creating implicit tbody elements
fixed <rdar://problem/5172596> HTML-parser-created tbody elements are being ignored when processing CSS child rules

Test: fast/css/child-selector-implicit-tbody.html

css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkSelector): Removed code that used to look at implicitNode(), which no longer exists.

css/html4.css: Added a style rule to handle cases where we have a tr inside a table with no intervening table section.

dom/Node.h: Removed the bit.
dom/Node.cpp: (WebCore::Node::Node): Don't initialize the bit. (WebCore::Node::dump): Don't dump the bit.

dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::startElementNs): Remove the code that made a table body element. This is handled in the render tree, the DOM tree should not be mangled. (WebCore::XMLTokenizer::endElementNs): Removed code that used to look at implicitNode(), which no longer exists.

html/HTMLElementFactory.cpp: (WebCore::tableSectionConstructor): Removed boolean parameter that was passed to the HTMLTableSectionElement constructor.
html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): Ditto.
html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::createTHead): Ditto. (WebCore::HTMLTableElement::createTFoot): Ditto. (WebCore::HTMLTableElement::insertRow): Changed to return a PassRefPtr, because it's possible the row could be removed from the table by JavaScript code responding to DOM mutation events before the function returns. Just something I noticed by code inspection.

html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::HTMLTableSectionElement): Removed boolean "implicit" parameter to the constructor. (WebCore::HTMLTableSectionElement::insertRow): Changed to return a PassRefPtr for the same reason cited above.

html/HTMLTableElement.h: Changed the return value of insertRow to be a PassRefPtr.
html/HTMLTableSectionElement.h: Ditto.

12:04 PM Changeset in webkit [21207] by sfalken