Timeline



May 7, 2007:

10:41 PM Changeset in webkit [21295] by oliver
  • 2 edits in trunk/WebCore

2007-05-07 Atul Mehrotra <​atul.mehrotra@celunite.com>

Reviewed by Maciej.

GDK Build fix

  • platform/gdk/TemporaryLinkStubs.cpp:
9:59 PM Changeset in webkit [21294] by oliver
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.

Test the behaviour of canvas methods called with inf/nan parameters

  • fast/canvas/canvas-with-incorrect-args-expected.txt: Added.
  • fast/canvas/canvas-with-incorrect-args.html: Added.

WebCore:

Reviewed by Maciej.

Correcting comparisons to handle NaN in the same manner
as other Canvas methods.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::arcTo): (WebCore::CanvasRenderingContext2D::arc): Correcting arc/arcTo to match the WHAT WG draft. (WebCore::CanvasRenderingContext2D::rect): (WebCore::CanvasRenderingContext2D::clearRect): (WebCore::CanvasRenderingContext2D::fillRect): (WebCore::CanvasRenderingContext2D::strokeRect):
5:57 PM Changeset in webkit [21293] by hyatt
  • 4 edits in trunk/WebCore

Add some comments to the glyph/font code (patch from MarvinD, tweaked by
me to correct a few bits and to make it forward-compatible with the work
going on in 3315.

Reviewed by me

  • ChangeLog:
  • platform/Font.cpp: (WebCore::Font::glyphDataForCharacter):
  • platform/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::initializePage):
  • platform/GlyphPageTreeNode.h:
4:55 PM Changeset in webkit [21292] by justing
  • 2 edits in trunk/WebCore

Fix layout test failures.

  • editing/SelectionController.cpp: (WebCore::SelectionController::contains): Use comparePositions instead of Range::comparePoint, because comparePositions can handle positions inside shadow trees.
4:37 PM Changeset in webkit [23347] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-05-07 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin.

Fix typo in prefs code.

  • WebPreferences.cpp: (WebPreferences::preferencesPath): Fix typo in error handling.
4:01 PM Changeset in webkit [23346] by aliceli1
  • 5 edits
    2 adds in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Fixed <rdar://5087119> Paste fidelity isn't as good as it is on the mac
and <rdar://5087118> Plain text copy/paste yields bad line endings on Boomer
and re-organized standalone functions in DragDataWin.cpp and PasteboardWin.cpp
into ClipboardUtilitiesWin.h/cpp.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/ClipboardUtilitiesWin.cpp: Added. (WebCore::cfHDropFormat): (WebCore::getWebLocData): (WebCore::extractURL): (WebCore::texthtmlFormat): (WebCore::createGlobalData): (WebCore::markupToCF_HTML): (WebCore::urlToMarkup): (WebCore::replaceNewlinesWithWindowsStyleNewlines): (WebCore::replaceNBSPWithSpace): (WebCore::urlWFormat): (WebCore::urlFormat): (WebCore::plainTextFormat): (WebCore::plainTextWFormat): (WebCore::filenameWFormat): (WebCore::filenameFormat): (WebCore::htmlFormat): (WebCore::getURL): (WebCore::getPlainText): (WebCore::fragmentFromFilenames): (WebCore::containsFilenames): (WebCore::fragmentFromCF_HTML): (WebCore::fragmentFromHTML): (WebCore::containsHTML):
  • platform/win/ClipboardUtilitiesWin.h: Added.
  • platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::writeRange):
  • platform/win/DragDataWin.cpp:
  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::documentFragment):
3:15 PM Changeset in webkit [21291] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/4895428> Can't drag selected To Do if it is not showing a due date

  • editing/selection/4895428-1-expected.checksum: Added.
  • editing/selection/4895428-1-expected.png: Added.
  • editing/selection/4895428-1-expected.txt: Added.
  • editing/selection/4895428-1.html: Added.

WebCore:

Reviewed by darin


<rdar://problem/4895428> Can't drag selected To Do if it is not showing a due date


The code in SelectionController::contains returned false
incorrectly if the selection end just after a table
and the position was inside that table.

  • editing/SelectionController.cpp: (WebCore::SelectionController::contains): Compare the position with the ends of the selection and then use Range::comparePoint.
3:09 PM Changeset in webkit [21290] by beidson
  • 2 edits in trunk/WebKit

Actually finish the code move from my last checkin

  • History/WebHistoryItem.mm: (-[WebHistoryItem _transientPropertyForKey:]): (-[WebHistoryItem _setTransientProperty:forKey:]):
2:57 PM Changeset in webkit [21289] by beidson
  • 4 edits in trunk/WebKit

Rubberstamped by Kevin (Sarge)

Make _transientPropertyForKey: and _setTransientProperty:forKey: SPI

  • History/WebHistoryItemInternal.h:
  • History/WebHistoryItemPrivate.h:
1:23 PM Changeset in webkit [23345] by sfalken
  • 1 add in branches/WindowsMerge/WebCore/platform/win/TextBreakIteratorInternalICUWin.cpp

Forgot to check in this file.

10:25 AM Changeset in webkit [21288] by darin
  • 2 deletes in trunk/LayoutTests/fast/dom/HTMLElement

Removed files. Not sure why they didn't get removed before.

9:25 AM Changeset in webkit [21287] by darin
  • 4 edits in trunk

LayoutTests:

  • rolling out setInnerHTML optimization until I can figure out why tests are failing

WebCore:

  • rolling out setInnerHTML optimization until I can figure out why tests are failing
8:34 AM Changeset in webkit [21286] by brmorris
  • 1 edit
    1 delete in S60/trunk/LayoutTests

brmorris, reviewed by nobody

DESC: This is actually a resource file, not a test case.

  • fast/js/new-location.html: Removed.
8:04 AM Changeset in webkit [21285] by lars
  • 912 edits in trunk/LayoutTestResults

Reviewed by Zack.

New baseline for the table tests.
Skip the fast tests for now.

7:45 AM Changeset in webkit [21284] by darin
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/dom/HTMLElement/set-inner-outer-optimization-expected.txt: Added.
  • fast/dom/HTMLElement/set-inner-outer-optimization.html: Added.

WebCore:

Reviewed by Hyatt.

Optimize setInnerHTML, setOuterHTML, and setInnerText so they don't change the DOM at all
if they don't need to.

Test: fast/dom/HTMLElement/set-inner-outer-optimization.html

  • html/HTMLElement.cpp: (WebCore::equal): Added. Helper function that compares two Text nodes or two NamedAttrMap attribute maps. (WebCore::shallowEqual): Added. Helper function that compares two Element nodes or two arbitrary nodes. (WebCore::replaceChildrenWithFragment): Added. Helper function used by setInnerHTML and setInnerText. Optimizes the cases where all the nodes are the same, where both the current and the new content are single text nodes, and where the current content is a single node that can be replaced with replaceChild. (WebCore::replaceChildrenWithText): Added. Helper function used by setInnerText. Optimizes the case where the current content is a single text node or a single node that can be replaced with replaceChild. (WebCore::HTMLElement::setInnerHTML): Changed to call replaceChildrenWithFragment. (WebCore::HTMLElement::setOuterHTML): Added special case to optimize when the new content exactly matches the current node. (WebCore::HTMLElement::setInnerText): Changed to call replaceChildrenWithText in a few cases instead of doing removeChildren/appendChild. Changed code that was using DeprecatedString to instead use String. Changed general case to use a document fragment and replaceChildrenWithFragment.
  • dom/CharacterData.cpp: (WebCore::CharacterData::dispatchModifiedEvent): Fixed bug where we would not dispatch the DOMSubtreeModified event unless someone was registered for the DOMCharacterDataModified event. Caused trouble in the test.
6:56 AM Changeset in webkit [21283] by lars
  • 8 edits
    6 adds in trunk

Change 5 results in css2.1 that were wrong due to a Qt bug.
Add css3 baseline.

Fix the default font in DRT to 9pt Sans Serif.

12:07 AM Changeset in webkit [21282] by lars
  • 486 edits in trunk/LayoutTestResults

New baseline for the css2.1 tests.

May 6, 2007:

8:07 PM Changeset in webkit [21281] by darin
  • 2 edits in trunk/WebCore
  • blind try at fixing the Qt build
  • platform/qt/TextBreakIteratorQt.cpp: (WebCore::sentenceBreakIterator): Added a placeholder.
8:03 PM Changeset in webkit [21280] by darin
  • 5 edits
    2 deletes in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/canvas/drawImage-with-invalid-args.html: Changed to a dumpAsText test. Added logging and a negative-size test.
  • fast/canvas/drawImage-with-invalid-args-expected.txt: Updated.
  • fast/canvas/drawImage-with-invalid-args-expected.checksum: Removed.
  • fast/canvas/drawImage-with-invalid-args-expected.png: Removed.

WebCore:

Reviewed by Hyatt.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage): Don't raise an exception if the source or destination rectangle is empty.
7:57 PM Changeset in webkit [21279] by darin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

  • fix <rdar://problem/4585593> REGRESSION: Some 2-byte characters in printed page header are drawn with too-large font and clipped

Doesn't affect text within web pages, so no layout test.

  • platform/mac/FontCacheMac.mm: (WebCore::FontCache::getFontDataForCharacters): Base the substitute font on the FontPlatformData rather than the FontDescription. Before, it was a mix of both. This works properly for fonts where we have no FontDescription and is also more internally consistent.
7:56 PM Changeset in webkit [21278] by darin
  • 12 edits in trunk/WebCore

Reviewed by Hyatt.

  • dom/Node.h: Made first/lastChild be inline functions that call virtual functions. This lets us hide the functions with another inline function in a derived class, yet still override the behavior here in the base class by overriding the virtual functions too.
  • dom/Node.cpp: (WebCore::Node::virtualFirstChild): Renamed virtual functions. There are now non-virtual inline functions that call these virtual functions. (WebCore::Node::virtualLastChild): Ditto.
  • dom/ContainerNode.h: Added non-virtual first/lastChild functions that hide the ones inherited from the Node class; these also replace the fastFirst/LastChild functions, and transparently give callers the faster form if they have a pointer of the right type. But still override the virtual functions named virtualFirst/LastChild, because those can still be called through a Node*. Removed the "fast" from the names of fastSetFirst/LastChild.
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::virtualFirstChild): Renamed virtual functions. There are now also non-virtual inline versions. (WebCore::ContainerNode::virtualLastChild): Ditto.
  • dom/CharacterData.cpp: Removed implementations of data and length functons.
  • dom/CharacterData.h: Made data, setData, length, substringData, appendData, insertData, deleteData, and replaceData all non-virtual, and made data and length both be inline.
  • dom/NamedAttrMap.h: (WebCore::NamedAttrMap::attributeItem): Removed a null check from this function. If the length of the map is known to be greater than 0, then the null check isn't needed. But if the length of the map hasn't been checked at all, then it's unsafe to call this function since it doesn't range check the array index. Thus the null check is never needed. I also looked at all callers.
  • dom/Attr.cpp: (WebCore::Attr::createTextChild):
  • dom/Document.cpp: (WebCore::Document::recalcStyle):
  • dom/Element.cpp: (WebCore::Element::recalcStyle):
  • ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::haveLoadedRequiredResources): Removed "fast" prefix from calls to fastFirst/LastChild and fastSetFirst/LastChlld. It's not needed any more -- you still get fast behavior if the pointer has a type that's ContainerNode or derived from it.
7:36 PM Changeset in webkit [21277] by bdash
  • 3 edits in trunk

2007-05-06 Erik Bunce <​kde@bunce.us>

Reviewed by Mark Rowe.

  • WebKit.pri: Removed unnecessary dependency on MacPorts (/opt/local)

2007-05-06 Erik Bunce <​kde@bunce.us>

Reviewed by Mark Rowe.

  • WebCore.pro: Removed unnecessary dependency on MacPorts (/opt/local)
9:42 AM Changeset in webkit [21276] by ap
  • 4 edits
    4 adds in trunk

2007-05-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

Test: fast/css-generated-content/positioned-background-hit-test-crash.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::enclosingElement): Added. Factored out of hitTestLayer(). (WebCore::RenderLayer::hitTestLayer): Implemented the fix for <rdar://problem/3552346> from r6106 to the self hit test as well, namely: return the enclosing element for generated positioned content.
  • rendering/RenderLayer.h:
9:05 AM Changeset in webkit [21275] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13584
<script> code wrongly assumes requests can't fail

Test: fast/loader/unloadable-script.html

  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::parseMappedAttribute): (WebCore::HTMLScriptElement::insertedIntoDocument): Check the return value of requestScript().

May 5, 2007:

10:17 PM Changeset in webkit [21274] by ap
  • 5 edits in trunk/WebCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13304
REGRESSION(14784): WebKit doesn't dynamically reflect changes to the highlight color in System Preferences

Implemented a notification observer that invalidates cached system colors.

No automated test possible.

  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::activeSelectionBackgroundColor): (WebCore::RenderTheme::inactiveSelectionBackgroundColor): (WebCore::RenderTheme::platformColorsDidChange):
  • rendering/RenderTheme.h:
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (-[WebCoreRenderThemeNotificationObserver initWithTheme:WebCore::]): (-[WebCoreRenderThemeNotificationObserver systemColorsDidChange:]): (WebCore::theme): (WebCore::RenderThemeMac::RenderThemeMac): (WebCore::RenderThemeMac::~RenderThemeMac): (WebCore::RenderThemeMac::checkbox): (WebCore::RenderThemeMac::radio): (WebCore::RenderThemeMac::button): (WebCore::RenderThemeMac::popupButton): (WebCore::RenderThemeMac::search): (WebCore::RenderThemeMac::sliderThumbHorizontal): (WebCore::RenderThemeMac::sliderThumbVertical):
4:23 PM Changeset in webkit [21273] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/Bakefiles/presets.bkl

Run *-config scripts when running make, not when generating the makefiles.

3:53 AM Changeset in webkit [21272] by rwlbuis
  • 28 edits in trunk/WebCore

Reviewed by Oliver.

​http://bugs.webkit.org/show_bug.cgi?id=13592
parseMappedAttribute inconsistency

Do not use local vars in parseMappedAttribute for attr name and value.

12:10 AM Changeset in webkit [21271] by oliver
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Initialise default fill with Color::black rather than parsing
the string "black"

  • ksvg2/svg/SVGPaint.cpp: (WebCore::SVGPaint::defaultFill):

May 4, 2007:

9:19 PM Changeset in webkit [23344] by sfalken
  • 5 edits in branches/WindowsMerge

2007-05-04 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin.

Fix crash when using "check spelling while typing".

  • WebCore.vcproj/WebCore.vcproj: Added TextBreakIteratorInternalICUWin.cpp
  • platform/win/TemporaryLinkStubs.cpp: Removed findSentenceBoundary, findNextSentenceFromIndex.

2007-05-04 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin.


Fix crash when using "check spelling while typing".

  • WebView.cpp: (WebView::preflightSpellChecker): Set delegate static global for use in spell checker init.
9:08 PM Changeset in webkit [21270] by sfalken
  • 9 edits
    2 adds in trunk/WebCore

Reviewed by Oliver.

Use TextBreakIterator for sentence breaking instead of TextBoundaries.

  • WebCore.xcodeproj/project.pbxproj: Added TextBreakIeratorInternalICUMac.mm
  • editing/visible_units.cpp: (WebCore::startSentenceBoundary): Call TextBreakIterator instead of TextBoundaries. (WebCore::endSentenceBoundary): Call TextBreakIterator instead of TextBoundaries. (WebCore::previousSentencePositionBoundary): Call TextBreakIterator instead of TextBoundaries. (WebCore::nextSentencePositionBoundary): Call TextBreakIterator instead of TextBoundaries.
  • platform/TextBoundaries.h: Removed findSentenceBoundary, findNextSentenceFromIndex.
  • platform/TextBreakIterator.h: Added sentenceBreakIterator.
  • platform/TextBreakIteratorICU.cpp: (WebCore::setUpIterator): Add locale parameter (needed to maintain functionality that TextBoundaries code had). (WebCore::characterBreakIterator): Pass en_us for locale (same as old code). (WebCore::wordBreakIterator): Pass en_us for locale (same as old code). (WebCore::lineBreakIterator): Pass en_us for locale (same as old code). (WebCore::sentenceBreakIterator): Added.
  • platform/TextBreakIteratorInternalICU.h: Added.
  • platform/gdk/TemporaryLinkStubs.cpp: Removed findNextSentenceFromIndex, findSentenceBoundary. (WebCore::currentTextBreakLocaleID): Added stub.
  • platform/mac/TextBoundaries.mm: Removed currentTextBreakLocaleID, findSentenceBoundary, findNextSentenceFromIndex.
  • platform/mac/TextBreakIteratorInternalICUMac.mm: Added. (WebCore::currentTextBreakLocaleID): Moved from TextBoundaries.mm
  • platform/qt/TextBoundaries.cpp: Removed findNextSentenceFromIndex, findSentenceBoundary.
5:17 PM Changeset in webkit [21269] by adele
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/5116871> REGRESSION: Can't select options in widget's listbox

Don't use user-select to determine whether or not options can be selected in listboxes.
This will match Firefox behavior for -moz-user-select.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::canSelectAll): (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
4:50 PM Changeset in webkit [21268] by thatcher
  • 1 edit in tags/JavaScriptCore-418.5/JavaScriptCore/Info.plist

Versioning

4:49 PM Changeset in webkit [21267] by thatcher
  • 1 copy in tags/JavaScriptCore-418.5

New tag.

4:47 PM Changeset in webkit [21266] by thatcher
  • 1 edit in branches/Safari-2-0-branch/JavaScriptCore/kjs/collector.cpp

Build fix.

4:46 PM Changeset in webkit [21265] by thatcher
  • 2 edits in tags/JavaScriptCore-418.3/JavaScriptCore

Reverting commit to the wrong tag.

4:43 PM Changeset in webkit [21264] by thatcher
  • 1 delete in tags/JavaScriptCore-418.4/JavaScriptCore-418.3

Removing bad tag.

4:40 PM Changeset in webkit [21263] by thatcher
  • 1 edit in tags/JavaScriptCore-418.4/JavaScriptCore/kjs/collector.cpp

Build fix.

4:39 PM Changeset in webkit [21262] by thatcher
  • 2 edits in tags/JavaScriptCore-418.3/JavaScriptCore

Versioning

4:39 PM Changeset in webkit [21261] by ggaren
  • 8 edits in trunk

WebCore:

Reviewed by Tim Hatcher.

First step in fixing <rdar://problem/5055182> The back cache has no global cap

Stop giving SnapBack infinite cache-ability. Instead, make SnapBack rely
on the underlying back cache.

  • WebCore.exp:
  • history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem):
  • history/HistoryItem.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::purgePageCache):

WebKit:

Reviewed by Tim Hatcher.

First step in fixing <rdar://problem/5055182> The back cache has no global cap

Stop giving SnapBack infinite cache-ability. Instead, make SnapBack rely
on the underlying back cache.


I left -setAlwaysAttemptToUsePageCache: as an empty stub because we don't
want to break Safari 2.0, but I removed its header declaration so nobody
else starts using it.

  • History/WebHistoryItem.mm: (-[WebHistoryItem setAlwaysAttemptToUsePageCache:]):
  • History/WebHistoryItemPrivate.h:
4:38 PM Changeset in webkit [21260] by thatcher
  • 1 copy in tags/JavaScriptCore-418.4/JavaScriptCore-418.3

New tag.

4:38 PM Changeset in webkit [21259] by thatcher
  • 2 edits in tags/JavaScriptCore-418.3/JavaScriptCore

Merge fix from r16614 (with build fix).

2:15 PM Changeset in webkit [21258] by ggaren
  • 10 edits in trunk

WebCore:

Reviewed by Brady Eidson.


Removed export of clearPageCache(), since it was unused externally. I plan
to remove its use from WebCore eventually, too.

Removed usesPageCache(), since it was unused and it duplicated pageCacheSize().

  • WebCore.exp:
  • history/BackForwardList.cpp:
  • history/BackForwardList.h: Moved statics to the top of the class definition.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::canCachePage):

WebKit:

Reviewed by Brady Eidson.


Some cleanup in preparation for fixing <rdar://problem/5055182> The
back/forward cache has no global cap


Unified naming of WebKit/WebCore b/f lists -- instead of the potpourri
of webBackForwardList, backForwardList, list, kitList, coreList, listWrapper,
and webCoreBackForwardList, we use webBackForwardList for WebKit and
backForwardList for WebCore, matching their respective class names.


Removed "private" versions of kit() and core() -- kit() and core() are
canonically used for converting between WebKit API objects and WebCore
API objects. I think it's clearer to have only one way to do this.

Removed COMPUTE_DEFAULT_PAGE_CACHE_SIZE, since it was unused.


Removed _clearPageCache, since it was unused and it duplicated -setPageCacheSize:0.

Removed _usesPageCache, since it was unused and it duplicated -pageCacheSize.

11:19 AM Changeset in webkit [23343] by aliceli1
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

changed use of DeprecatedString::fromUTF8 to UTF8Encoding().decode()

  • platform/win/DragDataWin.cpp: (WebCore::fragmentFromHTML):
  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::documentFragment):
10:38 AM Changeset in webkit [21257] by darin
  • 2 edits in trunk

Added bugs.webkit.org URL.

10:14 AM Changeset in webkit [21256] by darin
  • 5 edits in trunk

JavaScriptCore:

Reviewed by Adele.

  • fix <rdar://problem/5007921> Number.toExponential doesn't work for negative numbers
  • kjs/number_object.cpp: (NumberProtoFunc::callAsFunction): Added a call to fabs before calling log10.

LayoutTests:

Reviewed by Adele.

  • test for <rdar://problem/5007921> Number.toExponential doesn't work for negative numbers
  • fast/js/kde/resources/Number.js: Added negative number versions of some tests of toFixed, toExponential, toPrecision, etc.
  • fast/js/kde/Number-expected.txt: Updated, new tests all passing.
10:13 AM Changeset in webkit [21255] by beidson
  • 2 edits in trunk/WebKit

Reviewed by Mark Rowe

Added main thread assertion to WebHTMLView to help make sure 3rd party clients aren't trying
to draw on secondary threads

  • WebView/WebHTMLView.mm: (-[WebHTMLView drawRect:]): Added ASSERT_MAIN_THREAD()
9:42 AM Changeset in webkit [21254] by bdash
  • 7 edits in trunk

2007-05-04 Anders Carlsson <​andersca@apple.com>

Reviewed by Antti.

<rdar://problem/5179977> Use the correct URLs when dispatching delegate methods for data loads.

Restore behavior to matching release WebKit by adding a response URL to SubstituteData. If a nil base URL is
passed, set the _request_ URL to "about:blank", but the response URL to a generated "applewebdata" URL.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad): First, check for the SubstituteData's response URL.

(WebCore::FrameLoader::continueAfterNavigationPolicy):
No need to special case applewebdata URLs here, they're only used in the response.

  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::handleDataLoadNow): If the substitute data has a response URL, use it.

(WebCore::MainResourceLoader::loadNow):
Only load "about:blank" as an empty document if there's no substitute data.

  • loader/SubstituteData.h: (WebCore::SubstituteData::SubstituteData): (WebCore::SubstituteData::responseURL): Add responseURL member to SubstituteData.

2007-05-04 Anders Carlsson <​andersca@apple.com>

Reviewed by Antti.

<rdar://problem/5179977> Use the correct URLs when dispatching delegate methods for data loads.

  • WebView/WebFrame.mm: (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): If the base URL is nil, set it to "about:blank", and set the response URL to a generated applewebdata URL.


  • WebView/WebView.mm: (+[WebView _canHandleRequest:]): No need to special-case applewebdata URLs here anymore, they're only used in responses.
5:25 AM Changeset in webkit [21253] by lars
  • 2 edits in trunk/WebKitTools

Reviewed by Zack

Revert on line of the last commit. We still want to keep the RPATH
support in the pro file.

4:41 AM Changeset in webkit [21252] by lars
  • 112 edits
    1 add
    15 deletes in trunk

Reviewed by Zack

Remove the old bitmap fonts I tried using to get reliable results from
DumpRenderTree on X11. Instead we now use the URW Type1 fonts from
ghostscript. I've added a mirror to simply check them out at
​svn://labs.trolltech.com/svn/webkit/testfonts.

Fixed DumpRenderTree to make sure these fonts are the only ones we use
on X11 and added a fonts.conf file to get a well defined fontconfig
configuration.

Made sure run-webkit-tests forwards the WEBKIT_TESTFONTS environment variable
I use to find the fonts to DumpRenderTree.

Updated results for css1 to work with the new set of fonts.
Will update the other results once I see this works on all
machines we have.

1:07 AM Changeset in webkit [21251] by bdash
  • 2 edits in tags/JavaScriptCore-418.4/JavaScriptCore

Versioning.

1:05 AM Changeset in webkit [21250] by bdash
  • 2 edits in tags/JavaScriptCore-418.4/JavaScriptCore

Merge r16614.

12:56 AM Changeset in webkit [21249] by bdash
  • 1 copy in tags/JavaScriptCore-418.4

New tag.

12:52 AM Changeset in webkit [21248] by bdash
  • 2 edits in branches/Safari-2-0-branch/JavaScriptCore

Merge r16614.

12:43 AM Changeset in webkit [21247] by bdash
  • 3 edits in branches/Safari-2-0-branch/WebKit

Merge r20042 and follow-ups from r20050, r20058, r20064, r20077 and r20668.

May 3, 2007:

11:59 PM Changeset in webkit [23342] by sfalken
  • 8 edits in branches/WindowsMerge

2007-05-03 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Ada, Oliver.

Checkpoint:
<rdar://problem/4602372> Spelling
<rdar://problem/4769763> Spell checking engine support

2007-05-03 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Ada, Oliver.

Checkpoint:
<rdar://problem/4602372> Spelling
<rdar://problem/4769763> Spell checking engine support


Spelling panel is now partially functional with this check-in.
Learn/Ignore not yet implemented, Find Next, Correct, language
selection, grammar toggle works.


Grammar checking is functional with this check-in.

2007-05-03 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Ada, Oliver.


Checkpoint:
<rdar://problem/4602372> Spelling
<rdar://problem/4769763> Spell checking engine support

  • Interfaces/IWebEditingDelegate.idl: Add userDescription parameter.
  • WebEditorClient.cpp: (WebEditorClient::updateSpellingUIWithGrammarString): Set user description for spelling errors.
  • WebEditorClient.h:
  • WebView.cpp: (WebView::replaceSelectionWithText): Implemented.

2007-05-03 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Ada, Oliver.

Checkpoint:
<rdar://problem/4602372> Spelling
<rdar://problem/4769763> Spell checking engine support

  • platform/win/EditorWin.cpp: (WebCore::findFirstBadGrammarInRange): Account for start offset when reporting bad grammar range (fixed my porting mistake). (WebCore::Editor::advanceToNextMisspelling): Include user description with spelling error. (WebCore::isRangeUngrammatical): Include user description with spelling error.
11:44 PM Changeset in webkit [21246] by sfalken
  • 10 edits in trunk

2007-05-03 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Oliver.

Add missing user description parameter to spelling-related editor client method.

  • WebCoreSupport/WebEditorClient.h: (WebEditorClient::updateSpellingUIWithGrammarString):

2007-05-03 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Oliver.

Add missing user description parameter to spelling-related editor client method.

  • bridge/EditorClient.h:
  • platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::updateSpellingUIWithGrammarString):
  • platform/gdk/EditorClientGdk.h:
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyEditorClient::updateSpellingUIWithGrammarString):

2007-05-03 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Oliver.

Add missing user description parameter to spelling-related editor client method.

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::updateSpellingUIWithGrammarString):
  • WebCoreSupport/EditorClientQt.h:
11:14 PM Changeset in webkit [23341] by aliceli1
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Fixed <rdar://5181466> HTML formatted clipboard data is not converted from UTF8 when pasted

  • platform/win/DragDataWin.cpp: (WebCore::fragmentFromHTML):
  • platform/win/PasteboardWin.cpp: (WebCore::fragmentFromCF_HTML): (WebCore::Pasteboard::documentFragment):
11:05 PM Changeset in webkit [23340] by oliver
  • 2 edits in branches/WindowsMerge/WebCore

2007-05-03 Oliver Hunt <​oliver@apple.com>

Reviewed by Steve

Fix misuse of GlobalLock.

  • platform/win/PasteboardWin.cpp: (WebCore::createGlobalData):
9:35 PM Changeset in webkit [21245] by beidson
  • 6 edits in trunk/WebCore

Reviewed by Oliver

Resolve an outstanding FIXME in Loader::numRequests()

Before, numRequests() would iterate through the list of requests pending load and the list of currently
loading requests and tally up a count matching the current DocLoader.

I noticed while studying and cleaning up the loader code that numRequests() is potentially very hot!
Indeed load a complex site with many resources and multiple frames, and this method gets called very often,
tallying up this number every time.

The FIXME was to keep a collection of Requests mapped to each DocLoader. In reality, since this map would
simply be used for retrieving a count, that was overkill. Keeping a request count in the DocLoader itself
along with maintaining that count in Loader as requests come and go is a much better way to do this.

  • loader/DocLoader.cpp: (WebCore::DocLoader::DocLoader): (WebCore::DocLoader::incrementRequestCount): (WebCore::DocLoader::decrementRequestCount): (WebCore::DocLoader::requestCount): Emulate the defunct Loader::numRequests()
  • loader/DocLoader.h:
  • loader/FrameLoader.cpp: (WebCore::numRequests): Call DocLoader::requestCount() directly (WebCore::FrameLoader::checkCompleted): Use numRequests()
  • loader/loader.cpp: (WebCore::Loader::load): Increment the DocLoader's request count (WebCore::Loader::servePendingRequests): If the SubresourceLoader failed to create, decrement the count (WebCore::Loader::didFinishLoading): If the Request is not Multipart, decrement the count (WebCore::Loader::didFail): If the Request is not Multipart, decrement the count (WebCore::Loader::didReceiveResponse): If the Request becomes Multipart, decrement the count (WebCore::Loader::cancelRequests): Decrement the count for the pending requests being tossed, and ASSERT the count is zero after all requests have been cancelled
  • loader/loader.h:
9:34 PM Changeset in webkit [23339] by oliver
  • 3 edits in branches/WindowsMerge/WebCore

2007-05-03 Oliver Hunt <​oliver@apple.com>

Reviewed by Steve.

Add logic to draw underlines for grammar and spelling errors.
(rdar://problem/4769832)

  • platform/win/GraphicsContextWin.cpp: (WebCore::spellingPatternColor): (WebCore::grammarPatternColor): Can't define global const with constructor so use function scoped globals instead. (WebCore::setCGStrokeColor): Utility function pulled over from GraphicsContextCG (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):


  • platform/win/TemporaryLinkStubs.cpp: Remove old drawLineForMisspellingOrBadGrammar stub
8:55 PM Changeset in webkit [21244] by ggaren
  • 3 edits in trunk/WebCore

Reviewed by Brady Eidson.


Some cleanup in preparation for fixing <rdar://problem/5055182> The
back/forward cache has no global cap

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::provisionalLoadStarted): Moved "Can I cache this page?" logic to canCachePage(). Moved "I am caching this page" logic to cachePageToHistoryItem(). (WebCore::FrameLoader::canCachePage): Moved above logic here. (WebCore::FrameLoader::cachePageToHistoryItem): Removed bogus NULL check and failure return value. Moved above logic here. Don't call setCachedPage() until the CachedPage is fully constructed. (WebCore::FrameLoader::purgePageCache): Removed comment that duplicated the function name.
  • loader/FrameLoader.h:
6:54 PM Changeset in webkit [21243] by harrison
  • 2 edits in trunk/WebCore

Reviewed by harrison.

<rdar://problem/5120281> CrashTracer: [USER] 1 crash in Mail at WebCore::CSSComputedStyleDeclaration::copyInheritableProperties() const

Problem is that checkAncestor and lastClosed can be nil when createMarkup is called unrendered nodes, and that was not checked for.


  • editing/markup.cpp: (WebCore::createMarkup): Nil-check checkAncestor and lastClosed.
5:51 PM Changeset in webkit [21242] by bdash
  • 1 copy in tags/Safari-4522.7

New tag.

5:50 PM Changeset in webkit [21241] by bdash
  • 4 edits in branches/Safari-522

Versioning.

4:08 PM Changeset in webkit [21240] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Kevin.

<rdar://problem/4975212> REGRESSION: With NetNewsWire 2.1.1, the contextual menu shows extra menu items when focus
is placed in input or textarea field

The NetNewsWire UI delegate isn't expecting calls for form controls, so we need to do a linked-on-or-after check.
If the application was linked against Tiger or earlier and the element is a text form control, just return the
default menu items and bypass the delegate call completely.

  • WebCoreSupport/WebContextMenuClient.mm: (isPreVersion3Client): Cache the result of the WebKitLinkedOnOrAfter call (fixMenusToSendToOldClients): Call the new isPreVersion3Client() (fixMenusReceivedFromOldClients): Ditto. (WebContextMenuClient::getCustomMenuFromDefaultItems): Return the default menu items if the element is a text form control.
3:50 PM Changeset in webkit [21239] by bdash
  • 2 edits in branches/Safari-522/WebKit

Merge r21238.

3:48 PM Changeset in webkit [21238] by bdash
  • 2 edits in trunk/WebKit

2007-05-03 Mark Rowe <​mrowe@apple.com>

Reviewed by Geoff and Kevin.

<rdar://problem/5141290> WebAssertions.h is still needed by some internal clients

Second shot at fixing this error. Stub out the macros rather than forwarding to JavaScriptCore, which would
leave clients using this header trying to resolve JavaScriptCore symbols against WebKit when linking. This
should only happen in production builds when assertions should be disabled anyway as anyone building a
development configuration should be in a position to move away from using this header.

  • Misc/WebAssertions.h:
3:23 PM Changeset in webkit [21237] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Kevin.

<rdar://problem/5016318> Contextual menu item for opening links is missing in compose windows but present in viewer

Add the Open Link, Open Link in New Window, Download Linked File and Copy Link menu
items to the content editable context menu.

  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate):
3:10 PM Changeset in webkit [21236] by brmorris
  • 2 edits in S60/trunk/WebKit

brmorris, reviewed by sachin

DESC: stub this out in SDK development environment:

  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::SelectedLanguage):
3:04 PM Changeset in webkit [21235] by hausmann
  • 14 edits
    1 add in trunk

Gdk build fixes using the Qt build's qmake tool from Holger Freyther, reviewed by Zack.

2:50 PM Changeset in webkit [21234] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Kevin.

<rdar://problem/5067707> REGRESSION: "Open Link" contextual menu item appears twice in Mail

Remove the check for Mail in fixMenusToSendToOldClients and fixMenusReceivedFromOldClients
when linked on or after Leopard. The isAppleMail() function is still used for Tiger Mail fixups.

  • WebCoreSupport/WebContextMenuClient.mm: (fixMenusToSendToOldClients): (fixMenusReceivedFromOldClients):
2:37 PM Changeset in webkit [21233] by adele
  • 2 edits in trunk/WebCore

Use BUILDING_ON_TIGER.

  • page/mac/FrameMac.mm: (WebCore::Frame::setUseSecureKeyboardEntry):
2:35 PM Changeset in webkit [21232] by beidson
  • 3 edits in trunk/WebCore

Reviewed by Darin

Some more minor cleanup that resolves a FIXME and ditches another pointless method

No change in functionality == no layout test

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad): Updated a comment (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): Folded startLoading() into this method (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): continueAfterWillSubmitForm becomes continueLoadAfterWillSubmitForm
  • loader/FrameLoader.h: Removed startLoading()
2:30 PM Changeset in webkit [21231] by brmorris
  • 3 edits in S60/trunk/S60Internals

brmorris, reviewed by rasvcan

DESC: land some changes to wmlengine that i forgot to commit :(

  • S60DynamicLibs.zip: updated wmlengine.lib
  • S60Headers.zip: updated wmlengineinterface.h
2:29 PM Changeset in webkit [21230] by adele
  • 2 edits in trunk/WebCore

Reviewed by Tim Hatcher.

Fix for <rdar://problem/4727607> REGRESSION: KeyScript is deprecated, need a new solution for forcing Roman input for password fields on Leopard

  • page/mac/FrameMac.mm: (WebCore::Frame::setUseSecureKeyboardEntry): Use TSMSetDocumentProperty and TSMRemoveDocumentProperty on Leopard disable and enable non-ascii input sources.
11:50 AM Changeset in webkit [21229] by beidson
  • 3 edits in trunk/WebCore

Reviewed by Anders

commitProvisionalLoad() was the name of two methods.
One of them was private and only called from one other private place.
This was driving me crazy. I had to change that.

No change in functionality == no layout test

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::transitionToCommitted): roll commitProvisionalLoad() into this method
  • loader/FrameLoader.h: Removed commitProvisionalLoad()
11:37 AM Changeset in webkit [21228] by ggaren
  • 2 edits in trunk/WebKitTools

Build fix: Add AllInOneFile.o to the ignore list, since it includes files
in the ignore list.


  • Scripts/check-for-global-initializers:
9:23 AM Changeset in webkit [21227] by darin
  • 6 edits in trunk/WebCore

Reviewed by Anders.

  • make ICU initialization lazy to speed up application start-up time (when it includes an initial webpage load)
  • platform/TextCodecICU.h: Replaced registerEncodingNames and registerCodecs with registerBaseEncodingNames, registerBaseCodecs, registerExtendedEncodingNames, and registerExtendedCodecs.
  • platform/TextCodecICU.cpp: (WebCore::newTextCodecICU): Moved up to the top of the file. (WebCore::TextCodecICU::registerBaseEncodingNames): Added. Registers just UTF-8. (WebCore::TextCodecICU::registerBaseCodecs): Ditto. (WebCore::TextCodecICU::registerExtendedEncodingNames): Renamed. (WebCore::TextCodecICU::registerExtendedCodecs): Ditto. (WebCore::TextCodecICU::createICUConverter): Compare with the name "GBK" in a way that does not require extending the maps.
  • platform/TextEncoding.cpp: (WebCore::TextEncoding::usesVisualOrdering): Added code so this will just return false if we haven't used any extended encoding names yet. The result will be correct, and we won't ask for an encoding name that will require registering the extended encoding names. (WebCore::TextEncoding::isJapanese): Ditto. (WebCore::TextEncoding::backslashAsCurrencySymbol): Ditto, but return a backslash instead of false.
  • platform/TextEncodingRegistry.h: Added a new function named noExtendedTextEncodingNameUsed.
  • platform/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps): Added. Registers the base encodings, including Latin-1 because it's the default, and the UTF encodings. (WebCore::extendTextCodecMaps): Added. Registers all the other encodings. (WebCore::newTextCodec): Removed the all to buildTextCodecMap because we always build the map when making the canonical encoding name. (WebCore::atomicCanonicalTextEncodingName): Changed code to build only the base maps at first, then extend the maps the first time we run into a name we don't know. (WebCore::noExtendedTextEncodingNameUsed): Added.
Note: See TracTimeline for information about the timeline view.