Timeline



Jun 16, 2007:

10:51 PM Changeset in webkit [23559] by hyatt
  • 4 edits in trunk/WebKit

Back out fix for 13972. Quicktime will no longer clip correctly. :(
Too many regressions in Mail caused by inserting an extra view into the
hierarchy. Can revisit later.

Reviewed by olliej

  • Plugins/WebPluginController.mm: (-[WebPluginController destroyPlugin:]): (-[WebPluginController destroyAllPlugins]):
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:DOMElement:loadManually:]):
  • WebView/WebHTMLView.mm: (-[WebHTMLView addSubview:]): (-[WebHTMLView willRemoveSubview:]):

Jun 15, 2007:

8:14 PM Changeset in webkit [23558] by hyatt
  • 4 edits in trunk/WebCore

Fix for bugzilla bugs 14183 and 14184, 'repeat' regressed in border-image
because of a botched 'round' support removal. Also update for a change in
the spec that has the second stretch/round/repeat keyword match the first
if omitted.


Reviewed by olliej

  • css/cssparser.cpp: (WebCore::BorderImageParseContext::commitBorderImage):
  • platform/graphics/Image.cpp: (WebCore::Image::drawTiled):
  • platform/graphics/Image.h: (WebCore::Image::):
6:47 PM Changeset in webkit [23557] by weinig
  • 22 edits
    1 move in trunk

LayoutTests:

Reviewed by Darin.

Update test for http://bugs.webkit.org/show_bug.cgi?id=14053
Autogenerate JS binding for Rect

  • fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=14053
Autogenerate JS binding for Rect

  • Renames RectImpl to Rect, DOMStyleSheetList to JSStyleSheetList and DOMRGBColor to JSRGBColor
  • Moves JSStyleSheetList and JSRGBColor into the WebCore namespace.
  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_css.cpp: (WebCore::): (WebCore::JSStyleSheetList::JSStyleSheetList): (WebCore::JSStyleSheetList::~JSStyleSheetList): (WebCore::JSStyleSheetList::getValueProperty): (WebCore::JSStyleSheetList::indexGetter): (WebCore::JSStyleSheetList::nameGetter): (WebCore::JSStyleSheetList::getOwnPropertySlot): (WebCore::toJS): (WebCore::JSStyleSheetListFunc::callAsFunction): (WebCore::JSRGBColor::JSRGBColor): (WebCore::JSRGBColor::~JSRGBColor): (WebCore::JSRGBColor::getOwnPropertySlot): (WebCore::JSRGBColor::getValueProperty): (WebCore::getJSRGBColor):
  • bindings/js/kjs_css.h: (WebCore::JSStyleSheetList::classInfo): (WebCore::JSStyleSheetList::): (WebCore::JSStyleSheetList::impl): (WebCore::JSRGBColor::classInfo): (WebCore::JSRGBColor::): (WebCore::JSRGBColor::impl):
  • bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • css/CSSBorderImageValue.cpp: (WebCore::CSSBorderImageValue::CSSBorderImageValue):
  • css/CSSBorderImageValue.h:
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::cssText):
  • css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::getRectValue): (WebCore::CSSPrimitiveValue::):
  • css/DashboardRegion.h:
  • css/Rect.h: Copied from css/RectImpl.h. (WebCore::Rect::~Rect): (WebCore::Rect::top): (WebCore::Rect::right): (WebCore::Rect::bottom): (WebCore::Rect::left): (WebCore::Rect::setTop): (WebCore::Rect::setRight): (WebCore::Rect::setBottom): (WebCore::Rect::setLeft):
  • css/Rect.idl:
  • css/RectImpl.h: Removed.
  • css/cssparser.cpp: (WebCore::CSSParser::parseShape): (WebCore::BorderImageParseContext::commitBorderImage):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • page/DOMWindow.idl:

WebKit:

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=14053
Autogenerate JS binding for Rect

  • Fix conflicts by using ::Rect instead of Rect.
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebBaseNetscapePluginView sendEvent:]): (-[WebBaseNetscapePluginView tellQuickTimeToChill]): (-[WebBaseNetscapePluginView invalidateRegion:]): (-[WebBaseNetscapePluginView _printedPluginBitmap]):
5:53 PM Changeset in webkit [23556] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebKitTools/Scripts/build-wxwebkit

Allow users to specify whether they're using a debug or wxPython build of wx.

5:29 PM Changeset in webkit [23555] by kevino
  • 5 edits in branches/wx-port-alpha/trunk

Fix for cases where the wxpresets don't define WX_PYTHON, and only have the webcore and jscore templates include flags. (these are not linked to directly by wx clients)

4:21 PM Changeset in webkit [23554] by zimmermann
  • 19 edits
    9 adds in branches/feature-branch

Reviewed by Eric.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=14015 (SVGTransformList::initialize() has no effect)

Fix SVGTransformList usage in SVG DOM exposed to JS.
This also fixes SVG space invaders including most repainting issues. (still some unrelated ones left)

This is basically the _same_ fix applied to SVGPointList some months ago. We just forgot
to add JSSVGTransformListCustom when switching from SVGTransform* -> SVGTransform (POD type).

3:07 PM Changeset in webkit [23553] by andersca
  • 2 edits in trunk/WebKit

Reviewed by Kevin.

A better fix for <rdar://problem/5271774>. Only try to access the element if the
view has an associated window. This also works with GC. (Fix suggested by Kevin.)

  • Plugins/WebKitPluginContainerView.mm: (-[WebKitPluginContainerView dealloc]): (-[WebKitPluginContainerView visibleRect]):
2:17 PM Changeset in webkit [23552] by andersca
  • 2 edits in trunk/WebKit

Reviewed by Kevin.

<rdar://problem/5271774> REGRESSION: A crash occurs when closing a window that contains a QT movie


In some cases, calling [super dealloc] might end up calling visibleRect, so make sure to
set _element to 0 so we won't send a message to a freed object and crash.


  • Plugins/WebKitPluginContainerView.mm: (-[WebKitPluginContainerView dealloc]): (-[WebKitPluginContainerView visibleRect]):
12:21 PM Changeset in webkit [23551] by zimmermann
  • 4 edits
    4 adds in branches/feature-branch

Reviewed by Eric.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=14155

JSSVGMatrix was not working properly.
"matrix.translate(10, 10)" actually altered 'matrix' instead of returning a
new SVGMatrix object, as described in SVG 1.1 specification.

10:32 AM Changeset in webkit [23550] by spadma
  • 2 edits in S60/trunk/WebKit

vbradley, reviewed by Sachin

DESC: EYLG-6ZVCLT - Chinese candidate and autofill boxes overlap
http://bugs.webkit.org/show_bug.cgi?id=13925

  • BrowserView/src/WebKitControl.cpp: (CStaticObjectContainer::FormDataManagerHandlerL):
10:27 AM Changeset in webkit [23549] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2007-06-14 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>

Reviewed by Sachin Padma.
DESC: Plug-in request for execution of JavaScript through NpnGetUrl API not working
http://waplabdc.nokia-boston.com/browser/users/MaheshKK/geturl.html

  • WebKit\Plugin\PluginLoader.cpp: (CPluginLoader::LoadPluginContentL): Do not resolve URL when "javascript:" is in the URL


10:25 AM Changeset in webkit [23548] by spadma
  • 2 edits in S60/trunk/WebKit

007-06-14 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>

Reviewed by Sachin Padma.
DESC: Plug-in request for execution of JavaScript through NpnGetUrl API not working
http://waplabdc.nokia-boston.com/browser/users/MaheshKK/geturl.html

  • WebKit\Plugin\PluginLoader.cpp: (CPluginLoader::LoadPluginContentL): Do not resolve URL when "javascript:" is in the URL
9:54 AM Changeset in webkit [23547] by eseidel
  • 2 edits in branches/feature-branch/WebCore

2007-06-15 Eric Seidel <eric@webkit.org>

Reviewed by Niko.

Fix the release build.

  • rendering/SVGRootInlineBox.cpp: (WebCore::applyTextAnchorToTextChunk):

Jun 14, 2007:

7:51 PM Changeset in webkit [23546] by staikos
  • 3 edits in trunk/WebKitQt

Add evaluateJavaScript() method

7:31 PM Changeset in webkit [23545] by staikos
  • 7 edits in trunk

Add quite a bit of keyboard handling in editing and non-editing mode for
QtWebKit, as well as some focus fixes.

6:41 PM Changeset in webkit [23544] by rwlbuis
  • 3 edits
    4 adds in branches/feature-branch

Reviewed by Eric.

http://bugs.webkit.org/show_bug.cgi?id=14051
<svg:image> fails to position correctly when <svg> is inside an inline <div>

Leave parent translation to the containers.

5:02 PM Changeset in webkit [23543] by zimmermann
  • 5 edits in branches/feature-branch/WebCore

Reviewed by Eric.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=13963

Fix SVG space invaders. It actually highlighted a bad problem with our JSSVGPODTypeWrapper's.
Introduce a new "2nd-level cache" for all readwrite POD properties. Subsequent calls to ie.
myRect.x.baseVal.value don't create a new wrapper everytime, but are properly cached now.
This leads to a massive reduction in created wrappers.

4:50 PM Changeset in webkit [23542] by thatcher
  • 12 edits
    4 copies in branches/Safari-522

Merge r21212.

4:39 PM Changeset in webkit [23541] by thatcher
  • 2 edits in branches/Safari-522/WebCore

Merge r20855.

3:15 PM Changeset in webkit [23540] by andersca
  • 2 edits in trunk/JavaScriptCore

Fix Windows build.


  • bindings/runtime_object.cpp: (RuntimeObjectImp::canPut):
2:58 PM Changeset in webkit [23539] by hyatt
  • 3 edits in trunk/WebCore

Fix for missing text in non-English Windows installs.

2:43 PM Changeset in webkit [23538] by andersca
  • 14 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Darin.

<rdar://problem/5103077>
Crash at _NPN_ReleaseObject when quitting page at http://eshop.macsales.com/shop/ModBook


<rdar://problem/5183692>
http://bugs.webkit.org/show_bug.cgi?id=13547
REGRESSION: Crash in _NPN_ReleaseObject when closing Safari on nba.com (13547)


<rdar://problem/5261499>
CrashTracer: [USER] 75 crashes in Safari at com.apple.JavaScriptCore: KJS::Bindings::CInstance::~CInstance + 40


Have the root object track all live instances of RuntimeObjectImp. When invalidating
the root object, also invalidate all live runtime objects by zeroing out their instance ivar.
This prevents instances from outliving their plug-ins which lead to crashes.


  • bindings/c/c_utility.cpp: (KJS::Bindings::convertValueToNPVariant):
  • bindings/jni/jni_jsobject.cpp: (JavaJSObject::convertValueToJObject):
  • bindings/jni/jni_utility.cpp: (KJS::Bindings::convertValueToJValue):
  • bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::callAsFunction):
  • bindings/runtime_array.cpp: (RuntimeArray::RuntimeArray):
  • bindings/runtime_array.h: (KJS::RuntimeArray::getConcreteArray):
  • bindings/runtime_method.cpp: (RuntimeMethod::callAsFunction):
  • bindings/runtime_method.h:
  • bindings/runtime_object.cpp: (RuntimeObjectImp::RuntimeObjectImp): (RuntimeObjectImp::~RuntimeObjectImp): (RuntimeObjectImp::invalidate): (RuntimeObjectImp::fallbackObjectGetter): (RuntimeObjectImp::fieldGetter): (RuntimeObjectImp::methodGetter): (RuntimeObjectImp::getOwnPropertySlot): (RuntimeObjectImp::put): (RuntimeObjectImp::canPut): (RuntimeObjectImp::defaultValue): (RuntimeObjectImp::implementsCall): (RuntimeObjectImp::callAsFunction): (RuntimeObjectImp::getPropertyNames): (RuntimeObjectImp::throwInvalidAccessError):
  • bindings/runtime_object.h:
  • bindings/runtime_root.cpp: (KJS::Bindings::RootObject::invalidate): (KJS::Bindings::RootObject::addRuntimeObject): (KJS::Bindings::RootObject::removeRuntimeObject):
  • bindings/runtime_root.h:

LayoutTests:

Reviewed by Darin.

Add test that manipulates plug-in script objects after the plug-in has been destroyed.


  • plugins/netscape-destroy-plugin-script-objects-expected.txt: Added.
  • plugins/netscape-destroy-plugin-script-objects.html: Added.
2:42 PM Changeset in webkit [23537] by weinig
  • 3 edits in trunk/WebKitTools

Reviewed by Brady.

Update set of files to download for cygwin to include
diffutils and regenerate the zip file. This should fix
an issue on vista where svn-create-patch doesn't work.

  • CygwinDownloader/cygwin-downloader.py:
  • CygwinDownloader/cygwin-downloader.zip:
2:08 PM Changeset in webkit [23536] by andersca
  • 4 edits in trunk/WebCore

Reviewed by Geoff.

Add Frame::cleanupScriptObjectsForPlugin which will invalidate the root object
for a given plug-in.

  • WebCore.exp:
  • page/Frame.cpp: (WebCore::Frame::cleanupScriptObjectsForPlugin):
  • page/Frame.h:
2:06 PM Changeset in webkit [23535] by andersca
  • 4 edits in trunk/WebKit

Reviewed by Geoff.

Call cleanupScriptObjectsForPlugin on the frame after destroying the plug-in.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView _destroyPlugin]):
  • Plugins/WebPluginController.mm: (-[WebPluginController destroyPlugin:]): (-[WebPluginController destroyAllPlugins]):
1:02 PM Changeset in webkit [23534] by kdecker
  • 2 edits in branches/Safari-2-0-branch/WebKit

Reviewed by John and Darin and Anders!

Fixed: <rdar://problem/5269008> REGRESSION (Safari 3 Beta 1): Package Tracker widget fails (can't find localized strings due to bundle ID)

  • Misc.subproj/WebLocalizableStrings.m: The problem was that WebLocalizableStrings.m has the system WebKit bundle identifier, not WebKitForDashboard's bundle identifier. The code therefore couldn't find the localizable string "Recent searches", thus returned a nil string and therefore triggered an assertion failure in NSMenuItem. I fixed this by changing the bundle constant to "com.apple.WebKitForDashboard".
12:22 PM Changeset in webkit [23533] by eseidel
  • 4 edits in branches/feature-branch/WebCore

2007-06-14 Eric Seidel <eric@webkit.org>

Reviewed by Niko.

Text gradients are broken on feature branch
http://bugs.webkit.org/show_bug.cgi?id=14142

  • rendering/SVGRenderSupport.cpp: (WebCore::prepareToRenderSVGContent):
  • rendering/SVGRootInlineBox.cpp: (WebCore::prepareTextRendering): (WebCore::SVGRootInlineBox::paint): (WebCore::SVGRootInlineBox::paintInlineBoxes): (WebCore::SVGRootInlineBox::paintChildInlineTextBox): (WebCore::SVGRootInlineBox::paintChildInlineFlowBox):
  • rendering/SVGRootInlineBox.h:
12:16 PM Changeset in webkit [23532] by zimmermann
  • 2 edits in branches/feature-branch/WebCore

Reviewed by Sam.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11273

Implement pixelUnitToMillimeterX(), pixelUnitToMillimeterY() in SVGSVGElement.
Use cssPixelsPerInch, just like done in CSSPrimitiveValue & SVGLength.

11:43 AM Applications using WebKit edited by ruben@mailplaneapp.com
Added Mailplane (diff)
11:33 AM Changeset in webkit [23531] by bdash
  • 2 edits in trunk/WebKitTools

2007-06-14 Mark Rowe <mrowe@apple.com>

Update script to match new nightly.webkit.org infrastructure.

  • BuildSlaveSupport/build-launcher-dmg: Upload to the live web server, not the caching proxy. Let the server know it's a Mac build.
10:50 AM Changeset in webkit [23530] by rwlbuis
  • 3 edits
    4 adds in branches/feature-branch

Reviewed by Eric.

http://bugs.webkit.org/show_bug.cgi?id=9752
%-sizing of elements with a html parent is broken

Calculate width/height for length percentages when embedded in xhtml.

10:21 AM Changeset in webkit [23529] by andersca
  • 3 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/5211677>
-[WebPreferences setJavaEnabled:] only disables java inside <applet>, not <object>


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): If the object is a Java MIME type and Java is disabled, don't load the plug-in.


  • platform/MimeTypeRegistry.cpp: (WebCore::MimeTypeRegistry::isJavaAppletMIMEType): Clean this up and add another applet MIME type.
10:13 AM Changeset in webkit [23528] by staikos
  • 8 edits in trunk

Implement the javascript dialogs and file chooser dialog, along with some
cleanups.

9:47 AM Changeset in webkit [23527] by staikos
  • 2 edits in trunk/WebCore

Add missing null-init of pointer (will fix an upcoming crash)

9:13 AM Changeset in webkit [23526] by andersca
  • 5 edits in trunk

JavaScriptCore:

Reviewed by Mitz.

<rdar://problem/5244948>
Safari keeps on complaining about slow script playing NBC TV video (14133)

http://bugs.webkit.org/show_bug.cgi?id=14133
Runaway JavaScript timer fires when spinning around in Google Maps street view

Make sure to start and stop the timeout checker around calls to JS.


  • bindings/NP_jsobject.cpp: (_NPN_InvokeDefault): (_NPN_Invoke): (_NPN_Evaluate):
  • bindings/jni/jni_jsobject.cpp: (JavaJSObject::call): (JavaJSObject::eval):

WebCore:

Reviewed by Mitz.

<rdar://problem/5244948>
Safari keeps on complaining about slow script playing NBC TV video (14133)

http://bugs.webkit.org/show_bug.cgi?id=14133
Runaway JavaScript timer fires when spinning around in Google Maps street view

Make sure to start and stop the timeout checker around calls to JS.

  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]):
4:41 AM Changeset in webkit [23525] by hausmann
  • 2 edits in trunk/WebKitQt

Removed QWebHistoryItem::parent() as it is not implemented and WebCore's

HistoryItem itself doesn't seem to have a parent pointer either.

4:40 AM Changeset in webkit [23524] by hausmann
  • 3 edits in trunk/WebKitQt

Make it possible to copy QWebHistoryItem objects.

Jun 13, 2007:

11:59 PM Changeset in webkit [23523] by staikos
  • 3 edits
    2 adds in trunk

Fix mod-by-zero crash when typeahead is triggered on an empty select.

11:55 PM Changeset in webkit [23522] by rwlbuis
  • 2 edits in branches/feature-branch/WebCore

Build fix.

9:58 PM Changeset in webkit [23521] by darin
  • 4 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Mark Rowe.

Test: fast/js/sort-large-array.html

  • kjs/array_instance.h: Replaced pushUndefinedObjectsToEnd with compactForSorting, and removed ExecState parameters.
  • kjs/array_object.cpp: (ArrayInstance::sort): Changed to call compactForSorting. (ArrayInstance::compactForSorting): Do the get and delete of the properties directly on the property map instead of using public calls from JSObject. The public calls would just read the undefined values from the compacted sort results array!

LayoutTests:

Reviewed by Mark Rowe.

  • fast/js/resources/sort-large-array.js: Added.
  • fast/js/sort-large-array-expected.txt: Added.
  • fast/js/sort-large-array.html: Added.
9:25 PM Changeset in webkit [23520] by lars
  • 2 edits in trunk/WebKitQt

Fix a crash when a request from the plugin resulted
in a HTTP redirect.

8:28 PM Changeset in webkit [23519] by lars
  • 2 edits in trunk/WebKitQt

Work around a bug in Qt's QHttp implementation and
get web pages to load again.

7:48 PM Changeset in webkit [23518] by staikos
  • 2 edits in trunk/JavaScriptCore

Fix Mac OS X build

7:32 PM Changeset in webkit [23517] by staikos
  • 1 edit in trunk/WebCore/WebCore.pro

missed this in my last checkin - obsolete line

7:24 PM Changeset in webkit [23516] by staikos
  • 4 edits in trunk

Compile without trying to link ourself.

7:23 PM Changeset in webkit [23515] by lars
  • 4 edits in trunk/JavaScriptCore

Disable FastMalloc for the Qt build and make sure we
don't reimplement the global new/delete operators
when using the system malloc.

6:11 PM Changeset in webkit [23514] by darin
  • 2 edits in trunk/WebCore

Reviewed by Kevin Decker.

  • fix <rdar://problem/5264923> Safari frequently "stalls" beneath +[NSFont fontWithName:size:] while loading a web page (searching on disk for the font)
  • platform/mac/WebFontCache.mm: (+[WebFontCache internalFontWithFamily:traits:size:]): Renamed from fontWithFamily. Took out the auto-activation code. (+[WebFontCache fontWithFamily:traits:size:]): Added. Calls internalFontWithFamily, then calls NSFont to trigger activation if that returned nil, then calls internalFontWithFamily again.
5:55 PM Changeset in webkit [23513] by sfalken
  • 1 copy in tags/Safari-522.12.1b

New tag.

5:10 PM Changeset in webkit [23512] by andersca
  • 17 edits in trunk

JavaScriptCore:

Reviewed by Geoff.

Make sure that bindings instances get correct root objects.


  • JavaScriptCore.exp:
  • bindings/NP_jsobject.cpp: (listFromVariantArgs): (_NPN_InvokeDefault): (_NPN_Invoke): (_NPN_SetProperty):
  • bindings/c/c_instance.cpp: (KJS::Bindings::CInstance::invokeMethod): (KJS::Bindings::CInstance::invokeDefaultMethod):
  • bindings/c/c_runtime.cpp: (KJS::Bindings::CField::valueFromInstance):
  • bindings/c/c_utility.cpp: (KJS::Bindings::convertNPVariantToValue):
  • bindings/c/c_utility.h:
  • bindings/objc/objc_instance.mm: (ObjcInstance::invokeMethod): (ObjcInstance::invokeDefaultMethod): (ObjcInstance::getValueOfUndefinedField):
  • bindings/objc/objc_runtime.mm: (ObjcField::valueFromInstance): (ObjcArray::valueAt):
  • bindings/objc/objc_utility.h:
  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertObjcValueToValue):
  • bindings/runtime.h:

WebCore:

Reviewed by Geoff.

Pass the root object to methods that end up creating new ObjcInstance objects.


  • bindings/objc/WebScriptObject.mm: (listFromNSArray): (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]): (-[WebScriptObject setValue:forKey:]): (-[WebScriptObject valueForKey:]): (-[WebScriptObject removeWebScriptKey:]): (-[WebScriptObject setWebScriptValueAtIndex:value:]):
4:44 PM Changeset in webkit [23511] by andersca
  • 2 edits in branches/Safari-522-2/WebCore

Merge r23510

4:31 PM Changeset in webkit [23510] by andersca
  • 4 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5267992>
Make sure an alert doesn't allow loading to continue inside a script.


Make sure to defer all loads where it's possible for a second main loop to be running.


  • page/Chrome.cpp: (WebCore::Chrome::runModal): (WebCore::Chrome::runBeforeUnloadConfirmPanel): (WebCore::Chrome::runJavaScriptAlert): (WebCore::Chrome::runJavaScriptConfirm): (WebCore::Chrome::runJavaScriptPrompt): (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):


  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::setDefersLoading): Implement this.
4:14 PM Changeset in webkit [23509] by rwlbuis
  • 19 edits
    2 adds
    2 deletes in branches/feature-branch/WebCore

Reviewed by Eric.

http://bugs.webkit.org/show_bug.cgi?id=12207
RenderSVGContainer should be split into multiple classes
http://bugs.webkit.org/show_bug.cgi?id=14125
KCanvasRenderingStyle should be removed

Introduce the RenderSVGRoot class and kill the KCanvas enums.

3:26 PM Changeset in webkit [23508] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Adele Peterson


  • fixed <rdar://problem/5267607> Clicking the "Save to Downloads" button in PDF overlay too soon results in corrupt file
  • WebView/WebPDFView.mm: (-[WebPDFView PDFViewSavePDFToDownloadFolder:]): Just beep if the document isn't available yet, since trying to save it as a file really isn't a good idea.
2:28 PM Nightly Builds edited by ordody@freeshell.org
(diff)
1:39 PM Changeset in webkit [23507] by bdash
  • 4 edits
    8 adds in trunk/WebCore

2007-06-13 Alp Toker <alp.toker@collabora.co.uk>

Reviewed by Rob.

http://bugs.webkit.org/show_bug.cgi?id=14060
Cairo SVG support

  • WebCore.pro: Add new files to the build.
  • platform/graphics/svg/SVGPaintServerPattern.h:
  • platform/graphics/svg/SVGPaintServerSolid.h:
  • platform/graphics/svg/cairo: Added.
  • platform/graphics/svg/cairo/RenderPathCairo.cpp: Added. (WebCore::RenderPath::strokeContains): (WebCore::RenderPath::strokeBBox):
  • platform/graphics/svg/cairo/SVGPaintServerCairo.cpp: Added. (WebCore::SVGPaintServer::draw): (WebCore::SVGPaintServer::teardown): (WebCore::SVGPaintServer::renderPath):
  • platform/graphics/svg/cairo/SVGPaintServerGradientCairo.cpp: Added. (WebCore::SVGPaintServerGradient::setup):
  • platform/graphics/svg/cairo/SVGPaintServerPatternCairo.cpp: Added. (WebCore::SVGPaintServerPattern::setup):
  • platform/graphics/svg/cairo/SVGPaintServerSolidCairo.cpp: Added. (WebCore::SVGPaintServerSolid::setup):
  • platform/graphics/svg/cairo/SVGResourceClipperCairo.cpp: Added. (WebCore::SVGResourceClipper::applyClip):
  • platform/graphics/svg/cairo/SVGResourceMaskerCairo.cpp: Added. (WebCore::SVGResourceMasker::applyMask):
1:30 PM Changeset in webkit [23506] by sfalken
  • 1 copy in tags/Safari-522.11.5b

New tag.

12:27 PM Changeset in webkit [23505] by sfalken
  • 2 edits in branches/Safari-522-2/WebCore

Merged fix from r20855.

11:45 AM Web Inspector edited by ordody@freeshell.org
(diff)
11:39 AM Drosera edited by ordody@freeshell.org
(diff)
11:27 AM BuildingOnWindows edited by ordody@freeshell.org
environment updates (diff)
8:25 AM BuildingOnWindows edited by thiago.correa@gmail.com
Missing pkg-config dependency (diff)
8:01 AM Changeset in webkit [23504] by hausmann
  • 4 edits in trunk

Fix the build: WebKitQt is now called QtWebKit

7:38 AM Changeset in webkit [23503] by hausmann
  • 3 edits
    2 adds in trunk

Added a make install target that installs the Qt port and renamed
WebKitQt to QtWebKit

7:25 AM Changeset in webkit [23502] by spadma
  • 2 edits in S60/trunk/WebKit

yaharon, reviewed by sachin

DESC: [S60] Fix a crash when tapping the page before it is loaded
http://bugs.webkit.org/show_bug.cgi?id=13955

  • BrowserView/src/PointerEventHandler.cpp: (CPointerEventHandler::HandlePointerEventL):
7:17 AM Changeset in webkit [23501] by spadma
  • 2 edits in S60/trunk/WebKit

spadma, reviewed by Zalan

DESC: Memory leak in BrowserNG, RArray needs to be closed
http://bugs.webkit.org/show_bug.cgi?id=13952

TSW ID: AVAO-73NFEK

  • BrowserView/src/SmartLinkMap.cpp: (CSmartLinkMap::IndexingCallbackL):
6:05 AM Changeset in webkit [23500] by hausmann
  • 3 edits in trunk/WebKitQt

Added httpHeaderField setter/getter to QWebNetworkRequest for convenience.

6:05 AM Changeset in webkit [23499] by hausmann
  • 4 edits in trunk/WebKitQt

Changed QWebObjectPluginConnector::requestUrl to take a QWebNetworkRequest as argument.

6:05 AM Changeset in webkit [23498] by hausmann
  • 4 edits in trunk/WebKitQt

Added a QWebNetworkRequest convenience constructor.

6:04 AM Changeset in webkit [23497] by hausmann
  • 3 edits in trunk/WebKitQt

Changed the QWebPage::open(const QUrl &url, const QHttpRequestHeader &httpHeader, const QByteArray &postData)
overload to take a QWebNetworkRequest instead.

6:04 AM Changeset in webkit [23496] by hausmann
  • 2 edits in trunk/WebKitQt

In QWebPage::open(const QUrl &, const QHttpRequestHeader &, ...) don't make the population
of the WebCore::ResourceRequest depend on the validity of the QHttpRequestHeader but just
pick the individual fields if we can use them.

6:04 AM Changeset in webkit [23495] by hausmann
  • 3 edits in trunk/WebKitQt

Minor QWebNetworkRequet API fixlet

6:04 AM Changeset in webkit [23494] by hausmann
  • 7 edits in trunk/WebKitQt

Use QWebNetworkRequest for QWebPage::navigationRequested.

6:04 AM Changeset in webkit [23493] by hausmann
  • 2 edits in trunk/WebKitQt

Some docs for QWebNetworkRequest

6:03 AM Changeset in webkit [23492] by hausmann
  • 4 edits in trunk/WebKitQt

Moved QWebNetworkJob::Method enum into QWebNetworkRequest.

6:03 AM Changeset in webkit [23491] by hausmann
  • 3 edits in trunk/WebKitQt

Rename QWebNetworkJob::request() into QWebNetworkJob::httpHeader() and added

6:03 AM Changeset in webkit [23490] by hausmann
  • 5 edits in trunk/WebKitQt

Introduce QWebNetworkRequest in the public API.

6:03 AM Changeset in webkit [23489] by hausmann
  • 4 edits in trunk/WebKitQt

Changed QWebNetworkJobPrivate to aggregate a QWebNetworkRequest instead of inheriting from it.

6:03 AM Changeset in webkit [23488] by hausmann
  • 4 edits in trunk/WebKitQt

Rename QWebNetworkRequest::request into QWebNetworkRequest::httpHeader.

12:25 AM Changeset in webkit [23487] by aroben
  • 2 edits in trunk/WebCore

Fix one more BITMAPINFO/BITMAPINFOHEADER typo.

Rubberstamped by Oliver.

  • platform/win/DragImageWin.cpp: (WebCore::allocImage):

Jun 12, 2007:

11:56 PM Changeset in webkit [23486] by oliver
  • 5 edits in trunk

WebCore:

Reviewed by Darin.

Use correct size for BITMAPINFOHEADER -- whoops.

  • platform/win/CursorWin.cpp: (WebCore::Cursor::Cursor):
  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeImage):

WebKit:

Reviewed by Darin.

Use correct size for BITMAPINFOHEADER -- whoops.

  • win/WebIconDatabase.cpp: (createDIB): (WebIconDatabase::getOrCreateDefaultIconBitmap):
11:53 PM Changeset in webkit [23485] by sfalken
  • 5 edits in branches/Safari-522-2

Merged fix from r21529.

11:20 PM Changeset in webkit [23484] by sfalken
  • 1 copy in branches/Safari-522-2

Branched Safari-522 from r21983.

9:57 PM Changeset in webkit [23483] by andersca
  • 2 edits in trunk/JavaScriptCore

Another build fix.


  • bindings/qt/qt_instance.cpp: (KJS::Bindings::QtInstance::invokeMethod):
9:52 PM Changeset in webkit [23482] by andersca
  • 8 edits in trunk/JavaScriptCore

Reviewed by Geoff.

Move the notion of field type to the JNI runtime since that's the only
one that was actually using it.


  • bindings/c/c_runtime.h: (KJS::Bindings::CField::CField):
  • bindings/jni/jni_runtime.h:
  • bindings/objc/objc_runtime.h:
  • bindings/objc/objc_runtime.mm:
  • bindings/qt/qt_runtime.h:
  • bindings/runtime.h:
  • bindings/runtime_method.cpp:
9:43 PM Changeset in webkit [23481] by andersca
  • 3 edits in trunk/JavaScriptCore

Build fix.


  • bindings/qt/qt_class.cpp: (KJS::Bindings::QtClass::methodsNamed):
  • bindings/qt/qt_instance.cpp: (KJS::Bindings::QtInstance::invokeMethod):
9:42 PM Changeset in webkit [23480] by staikos
  • 2 edits in trunk/WebKitQt

Fix from Lars to remove duplicate symbols.

9:25 PM Changeset in webkit [23479] by andersca
  • 12 edits in trunk/JavaScriptCore

Reviewed by Oliver.


Get rid of the MethodList class and use a good ol' Vector instead.

  • bindings/c/c_class.cpp: (KJS::Bindings::CClass::methodsNamed):
  • bindings/c/c_instance.cpp: (KJS::Bindings::CInstance::invokeMethod):
  • bindings/jni/jni_class.cpp: (JavaClass::JavaClass): (JavaClass::~JavaClass):
  • bindings/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
  • bindings/objc/objc_class.mm: (KJS::Bindings::ObjcClass::methodsNamed):
  • bindings/objc/objc_instance.mm: (ObjcInstance::invokeMethod):
  • bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::callAsFunction):
  • bindings/runtime.cpp:
  • bindings/runtime.h:
  • bindings/runtime_method.cpp: (RuntimeMethod::lengthGetter): (RuntimeMethod::callAsFunction):
  • bindings/runtime_object.cpp: (RuntimeObjectImp::getOwnPropertySlot):
9:06 PM Changeset in webkit [23478] by andersca
  • 3 edits in trunk/JavaScriptCore

Reviewed by Geoff.

Make RuntimeMethod's method list a pointer so that the object size doesn't
grow beyond 32 bytes when we later will replace MethodList with a Vector.


  • bindings/runtime_method.cpp: (RuntimeMethod::RuntimeMethod): (RuntimeMethod::lengthGetter): (RuntimeMethod::callAsFunction):
  • bindings/runtime_method.h:
8:57 PM Changeset in webkit [23477] by andersca
  • 5 edits in trunk/JavaScriptCore

Reviewed by Geoff.

Get rid of the Parameter class.


  • bindings/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
  • bindings/jni/jni_runtime.cpp: (JavaMethod::signature):
  • bindings/jni/jni_runtime.h: (KJS::Bindings::JavaParameter::JavaParameter): (KJS::Bindings::JavaParameter::~JavaParameter): (KJS::Bindings::JavaParameter::type): (KJS::Bindings::JavaMethod::parameterAt): (KJS::Bindings::JavaMethod::numParameters):
  • bindings/runtime.h:
8:54 PM Changeset in webkit [23476] by andersca
  • 1 edit in trunk/JavaScriptCore/bindings/qt/qt_class.h
8:54 PM Changeset in webkit [23475] by andersca
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Build fix.


  • bindings/qt/qt_class.h:
8:49 PM Changeset in webkit [23474] by bdash
  • 2 edits in trunk/JavaScriptCore

2007-06-12 Mark Rowe <mrowe@apple.com>

Build fix.

  • bindings/objc/objc_runtime.h:
8:43 PM Changeset in webkit [23473] by andersca
  • 8 edits in trunk/JavaScriptCore

Reviewed by Geoff.

Get rid of Constructor and its only subclass JavaConstructor.


  • bindings/c/c_class.h:
  • bindings/jni/jni_class.cpp: (JavaClass::JavaClass): (JavaClass::~JavaClass):
  • bindings/jni/jni_class.h:
  • bindings/jni/jni_runtime.cpp:
  • bindings/jni/jni_runtime.h:
  • bindings/objc/objc_class.h:
  • bindings/runtime.h:
8:24 PM Changeset in webkit [23472] by andersca
  • 8 edits in trunk/JavaScriptCore

Reviewed by Geoff.

Use RetainPtr throughout the bindings code.


  • bindings/objc/objc_class.h:
  • bindings/objc/objc_class.mm: (KJS::Bindings::ObjcClass::ObjcClass): (KJS::Bindings::ObjcClass::methodsNamed): (KJS::Bindings::ObjcClass::fieldNamed):
  • bindings/objc/objc_instance.h: (KJS::Bindings::ObjcInstance::getObject):
  • bindings/objc/objc_instance.mm: (ObjcInstance::ObjcInstance): (ObjcInstance::~ObjcInstance): (ObjcInstance::implementsCall): (ObjcInstance::invokeMethod): (ObjcInstance::invokeDefaultMethod): (ObjcInstance::defaultValue):
  • bindings/objc/objc_runtime.h: (KJS::Bindings::ObjcMethod::setJavaScriptName): (KJS::Bindings::ObjcMethod::javaScriptName): (KJS::Bindings::ObjcArray::getObjcArray):
  • bindings/objc/objc_runtime.mm: (ObjcField::name): (ObjcArray::ObjcArray): (ObjcArray::setValueAt): (ObjcArray::valueAt): (ObjcArray::getLength):
  • wtf/RetainPtr.h:
7:40 PM Changeset in webkit [23471] by weinig
  • 6 edits in trunk/WebCore

Reviewed by Oliver.

Patch for http://bugs.webkit.org/show_bug.cgi?id=14109
Cleanup JSEvent and JSClipboard in preperation for autogeneration

  • bindings/js/kjs_events.cpp: (KJS::DOMEvent::DOMEvent): (KJS::DOMEvent::getValueProperty): (KJS::DOMEvent::put): (KJS::DOMEvent::putValueProperty): (KJS::DOMEventPrototypeFunction::callAsFunction): (KJS::toJS): (KJS::toEvent): (KJS::): (KJS::JSClipboard::JSClipboard): (KJS::JSClipboard::~JSClipboard): (KJS::JSClipboard::getOwnPropertySlot): (KJS::JSClipboard::getValueProperty): (KJS::JSClipboard::put): (KJS::JSClipboard::putValueProperty): (KJS::JSClipboardPrototypeFunction::callAsFunction): (KJS::toClipboard):
  • bindings/js/kjs_events.h: (KJS::DOMEvent::): (KJS::DOMEvent::impl): (KJS::JSClipboard::impl):
  • dom/ClipboardEvent.h:
  • dom/Event.h: (WebCore::Event::srcElement): (WebCore::Event::returnValue): (WebCore::Event::clipboardData): (WebCore::Event::dataTransfer): (WebCore::Event::clipboard):
  • dom/MouseEvent.h:
6:48 PM Changeset in webkit [23470] by andersca
  • 4 edits in trunk/JavaScriptCore

Reviewed by Maciej.

Have JSCell inherit from Noncopyable.


  • bindings/objc/objc_runtime.h:
  • bindings/runtime_object.h:
  • kjs/value.h:
6:22 PM Changeset in webkit [23469] by lars
  • 4 edits in trunk

Fix compilation, and remove dependency on Qt
private header.

5:39 PM Changeset in webkit [23468] by lars
  • 10 edits
    1 add in trunk

Parts of the patch done by Zack.
Fix up some parts in the implementation of QWebNetworkInterface
so it can be used by plugins.
Change the plugin API so we can actually get all the information
required by the JS bridge from them as well.
Implement the parts required for the JS bridge
to know about the plugins.

5:22 PM Changeset in webkit [23467] by andersca
  • 14 edits in trunk/JavaScriptCore

Reviewed by Darin and Maciej.

More cleanup. Use our Noncopyable WTF class, add a root object member
to the Array class.


  • bindings/c/c_class.h:
  • bindings/jni/jni_class.h:
  • bindings/jni/jni_instance.h:
  • bindings/jni/jni_runtime.cpp: (JavaArray::JavaArray):
  • bindings/jni/jni_runtime.h:
  • bindings/objc/objc_class.h:
  • bindings/objc/objc_runtime.h:
  • bindings/objc/objc_runtime.mm: (ObjcArray::ObjcArray):
  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertObjcValueToValue):
  • bindings/runtime.cpp: (KJS::Bindings::Array::Array): (KJS::Bindings::Array::~Array):
  • bindings/runtime.h:
  • bindings/runtime_object.h:
  • bindings/runtime_root.h:
4:58 PM Changeset in webkit [23466] by aroben
  • 3 edits
    5 adds in trunk

WebKitTools:

Land CygwinDownloader.

Rubberstamped by Hyatt.

  • CygwinDownloader/cygwin-downloader.py: Added.
  • CygwinDownloader/cygwin-downloader.zip: Added.
  • CygwinDownloader/make-zip.sh: Added.
  • CygwinDownloader/setup.py: Added.

WebKitSite:

Update the location of cygwin-downloader.zip.

Rubberstamped by Hyatt.

  • building/tools.html:
3:40 PM Changeset in webkit [23465] by hyatt
  • 1 edit in trunk/WebCore/platform/graphics/cg/GraphicsContextPlatformPrivate.h

Fix build bustage.

2:53 PM Changeset in webkit [23464] by aroben
  • 8 edits
    1 add in trunk/WebKitSite

Add Windows checkout/build instructions to website.

2:51 PM Changeset in webkit [23463] by aroben
  • 21 edits
    1 copy
    2 adds
    5 deletes in trunk

Update scripts and project paths to make the Windows build work.

2:50 PM Changeset in webkit [23462] by aroben
  • 112 copies in trunk

Merge WindowsMerge to trunk

12:46 AM Changeset in webkit [23461] by aroben
  • 9 adds in branches/WindowsMerge/LibrariesWin

Check in WebKitSystemInterface

Note: See TracTimeline for information about the timeline view.