Timeline


and

07/05/07:

23:14 Changeset [24043] by staikos
  • 2 edits in trunk/WebKitTools

Add optional --qmake= and --qt arguments to force Qt builds and force with a
specific qmake binary

22:12 Changeset [24042] by staikos
  • 5 edits in trunk

Switch USE(ICONDATABASE) to ENABLE(ICONDATABASE)

20:49 Changeset [24041] by sullivan
  • 18 edits in trunk

WebCore:

Reviewed by Adam

  • WebCore part of fix for <rdar://problem/5315033>
  • rendering/RenderObject.h: replaced PaintRestrictionSelectionOnlyWhiteText with PaintRestrictionSelectionOnlyBlackText (WebCore::RenderObject::PaintInfo::PaintInfo): replaced forceWhiteText with forceBlackText
  • rendering/RenderObject.cpp: (WebCore::RenderObject::addLineBoxRects): added a useSelectionHeight parameter, which defaults to false; this method is unimplemented at this level so this has no effect.
  • rendering/RenderText.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::addLineBoxRects): added a useSelectionHeight parameter, which defaults to false. If true, use the vertical position and height returned by selectionRect rather than replacing it with the more tight-fitting position and height of the line box.
  • dom/Range.h:
  • dom/Range.cpp: (WebCore::Range::addLineBoxRects): added a useSelectionHeight parameter, which defaults to false. Passes this along to RenderObject.
  • page/Frame.h: renamed parameter to selectionImage
  • page/Frame.cpp: (WebCore::Frame::selectionTextRects): pass true for addLineBoxRects new useSelectionHeight parameter, so the rects returned by this new method will match the height that the selection would be painted here (WebCore::Frame::paint): updated for white->black name changes


  • page/mac/FrameMac.mm: (WebCore::Frame::selectionImage): updated for white->black name changes


  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintTextDecorations): updated for white->black name changes
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): updated for white->black name changes
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): updated for white->black name changes, and actually use black instead of white. This was the goal of all the name changes.

WebKit:

Reviewed by Adam


  • WebKit part of fix for <rdar://problem/5315033>
  • WebView/WebDocumentPrivate.h: new selectionImageForcingBlackText: method. selectionImageForcingWhiteText: is no longer used and was never in an official release of WebKit, so it could be removed, except that doing so would cause trouble for people using nightly WebKit with Safari 3.0 beta. So I left it in, but made it just force black text instead of white text, which will look different for those nightly WebKit/Safari 3.0 beta people but not break anything.


  • Misc/WebSearchableTextView.m: (-[WebSearchableTextView selectionImageForcingBlackText:]): new unimplemented protocol method for this obsolete class


  • WebView/WebHTMLView.mm: (-[WebHTMLView selectionImageForcingBlackText:]): calls through to WebCore the way selectionImageForcingWhiteText: used to (-[WebHTMLView selectionImageForcingWhiteText:]): now just calls selectionImageForcingBlackText:, thus not working as you would expect from the name


  • WebView/WebPDFView.mm: (-[WebPDFView selectionImageForcingBlackText:]): guts of old selectionImageForcingWhiteText:, but with black substituted for white (-[WebPDFView selectionImageForcingWhiteText:]): now just calls selectionImageForcingBlackText:, thus not working as you would expect from the name
20:33 Changeset [24040] by aroben
  • 1 edit in trunk/LayoutTests/win/Skipped

Forgot the file extension

20:31 Changeset [24039] by aroben
  • 2 edits in trunk/LayoutTests

Updated the Windows Skipped file

  • win/Skipped:
19:28 Changeset [24038] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Oliver.

Fix layout test failures.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad): Don't make a representation if we're creating the initial document.
18:58 Changeset [24037] by aroben
  • 4 edits
    4 adds
    4 deletes in trunk

Fix Bug 14388: Input in text fields limited to 1024 characters

WebCore:

2007-07-05 Alp Toker <alp.toker@collabora.co.uk>

Fix Bug 14388: Input in text fields limited to 1024 characters
http://bugs.webkit.org/show_bug.cgi?id=14388

Slightly modified by Adam Roben.

Reviewed by Adele.

Test: fast/forms/input-length.html

  • html/HTMLInputElement.cpp: Bump limit to 524288. (WebCore::HTMLInputElement::init): (WebCore::HTMLInputElement::parseMappedAttribute):
  • html/HTMLInputElement.h:

LayoutTests:

Added two tests for Bug 14388: Input in text fields limited to 1024 characters

fast/forms/input-maxlength-2.html is obsoleted by
fast/forms/input-maxlength.html.

Reviewed by Adele.

  • fast/forms/input-implicit-length-limit-expected.txt: Added.
  • fast/forms/input-implicit-length-limit.html: Added.
  • fast/forms/input-maxlength-2-expected.checksum: Removed.
  • fast/forms/input-maxlength-2-expected.png: Removed.
  • fast/forms/input-maxlength-2-expected.txt: Removed.
  • fast/forms/input-maxlength-2.html: Removed.
  • fast/forms/input-maxlength-expected.txt: Added.
  • fast/forms/input-maxlength.html: Added.
18:58 Changeset [24036] by aroben
  • 2 edits in trunk/LayoutTests

Add another hanging test to the Leopard Skipped file

Rubberstamped by Adele.

  • mac/leopard/Skipped:
18:14 Changeset [24035] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebCore/platform/wx/RenderThemeWx.cpp

Selected text under MSW should be white too.

18:02 Changeset [24034] by justing
  • 1 edit in trunk/LayoutTests/fast/frames/iframe-double-attach-expected.txt

Updating expected results for r24027.

17:56 Changeset [24033] by kevino
  • 3 edits in branches/wx-port-alpha/trunk/WebKit/wx

Get RunScript working and add a way to test it in the demo.

17:40 Changeset [24032] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebKit/wx/bindings/python/webview.i

Add checks to ensure that you won't get a crash when trying to create a wxWebView or wxWebFrame without a running wx app instance.

17:34 Changeset [24031] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebCore/platform/graphics/wx/ColorWx.cpp

Fix wxColor->Color conversion.

16:12 Changeset [24030] by andersca
  • 2 edits in trunk/WebCore

Build fix.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::init):
16:04 Changeset [24029] by ggaren
  • 2 edits in trunk/LayoutTests

Forgot to add this file for the test for <rdar://problem/5303566> REGRESSION:
XMLHttpRequest.responseXML. Darin added a dummy file before -- here's the
real one.

  • fast/loader/resources/plist.app:
15:56 Changeset [24028] by weinig
  • 8 edits in trunk/WebCore

Reviewed by Geoff.

Add focus, blur and close functions to DOMWindow implementation class
and move bindings from Window to JSDOMWindow.

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot):
  • bindings/js/kjs_window.cpp: (KJS::Window::getOwnPropertySlot): (KJS::WindowFunc::callAsFunction):
  • bindings/js/kjs_window.h: (KJS::Window::):
  • bindings/scripts/CodeGeneratorJS.pm: Move prototype function declaration from the implementation to the header.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::focus): (WebCore::DOMWindow::blur): (WebCore::DOMWindow::close):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
15:52 Changeset [24027] by justing
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Harrison.


<rdar://problem/5279521> REGRESSION: In Mail, a crash occurs at WebCore::Range::startPosition() when attempting to apply alignment to selected image/text in message body


Demonstrates bug:

  • editing/style/5279521-expected.checksum: Added.
  • editing/style/5279521-expected.png: Added.
  • editing/style/5279521-expected.txt: Added.
  • editing/style/5279521.html: Added.


Fixed:

  • fast/forms/radio-check-click-and-drag-expected.txt:
  • fast/forms/textarea-type-spaces-expected.txt:

WebCore:

Reviewed by Harrison.

<rdar://problem/5279521> REGRESSION: In Mail, a crash occurs at WebCore::Range::startPosition() when attempting to apply alignment to selected image/text in message body

  • editing/TextIterator.cpp: (WebCore::TextIterator::exitNode): Previously emitted content shouldn't have to come from a text node in order to emit a '\n' as we exit block containers.
15:50 Changeset [24026] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/5315284> REGRESSION: Leopard Launch Time - plugins are being accessed at startup.

Set a response that has a MIME type of "text/html" on the document loader so WebKit won't refresh the
plugin database looking for a plug-in that can handle the document's MIME type (which will be null anyway).


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::init):
15:34 Changeset [24025] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Oliver.

<rdar://problem/5106788>
WebKit loads user style sheets too late as seen in Mail (breaks DataDetectors; Mail flashes wrong font)

Let the document know when the user style sheet is loading so that it try not to display anything
until the user style sheet has finished loading.


  • page/Frame.cpp: (WebCore::UserStyleSheetLoader::UserStyleSheetLoader): (WebCore::UserStyleSheetLoader::~UserStyleSheetLoader): (WebCore::UserStyleSheetLoader::setCSSStyleSheet): (WebCore::Frame::setUserStyleSheetLocation):
14:02 Changeset [24024] by aroben
  • 2 edits in trunk/WebKit/win

Fix a leak in WebView::setToolTip

Reviewed by Beth.

  • WebView.cpp:

(WebView::setToolTip):

13:43 Changeset [24023] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by John.

<rdar://problem/5314993> Shiira 2.1 throws an exception open a new window: -window: unrecognized selector

Add an empty implementation of this method to prevent Shiira from throwing an exception.
Also log that this method is obsolete and the class will be removed.

  • WebInspector/WebInspector.mm: (-window):
13:16 Changeset [24022] by aroben
  • 4 edits in trunk/WebKit/win

Fix Bug 14143: Tooltips not displayed on Windows
http://bugs.webkit.org/show_bug.cgi?id=14143
<rdar://problem/4719799>

Reviewed by Oliver.

  • WebChromeClient.cpp:

(WebChromeClient::setToolTip): Call up to WebView.

  • WebView.cpp:

(WebView::WebView): Initialize m_toolTipHwnd member.
(WebView::initWithFrame): Set up the tool tip window.
(initCommonControls): Added.
(WebView::initializeToolTipWindow): Added.
(WebView::setToolTip): Set the tool tip text and enable/disable the
tool tip.

  • WebView.h: Added/updated declarations.
13:11 Applications using WebKit edited by jalkut@red-sweater.com
Update MarsEdit info with info and link pertinent to Red Sweater … (diff)
11:09 Changeset [24021] by weinig
  • 4 edits in trunk/WebCore

Reviewed by Darin.

Move JSDOMWindow overriding getOwnPropertySlot logic from KJS::Window
up into JSDOMWindow. No change in functionality so no testcase required.

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot):
  • bindings/js/kjs_window.cpp: (KJS::Window::getOwnPropertySlot):
  • bindings/js/kjs_window.h:
10:51 Changeset [24020] by darin
  • 3 edits
    1 copy
    2 adds in trunk/LayoutTests
  • tweaked IDN test and checked in both Tiger results and Leopard
  • fast/encoding/idn-security.html: Changed test to only test lowercase "a" since the behavior for uppercase letters has changed in the new ICU. Also added code to detect the older ICU and expect different results.
  • fast/encoding/idn-security-expected.txt: Regenerated results.
  • mac/leopard/fast/encoding/idn-security-expected.txt: Copied from fast/encoding/idn-security-expected.txt. The modified.
10:02 Changeset [24019] by weinig
  • 2 edits in trunk/WebCore

Reviewed and Landed by Sam.

  • fix bug 14465 for window.showModalDialog
  • bindings/js/kjs_window.cpp: (KJS::parseModalDialogFeatures): (KJS::showModalDialog):
09:14 Changeset [24018] by weinig
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Mitz.

Patch for http://bugs.webkit.org/show_bug.cgi?id=14465
window.open() uses the literal "undefined" as the URL

  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction): add checks for undefined and null values when setting the url.
  • manual-tests/open-url-undefined.html: Added.
06:51 Changeset [24017] by bdash
  • 4 edits in trunk/WebCore

2007-07-05 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Rob Buis.

Rework FontData and FontPlatformData for the Gdk work to make valgrind
happy.

Move destroying of FontConfig and Cairo objects held in FontPlatformData
to FontData::platformDestroy. The ownership of these objects is held by
FontData. This is following the Mac and Qt port at least.

Currently it is possible that FontPlatformData will not create cairo resources
in this case at least make sure the variables are initialized to 0.
Initialize x,y of the cairo_glyph_t with zero to avoid extents.x_advance depending
on subtracing with not defined values.

FontPlatformData::hash. Using FontDescription is a bad idea as we don't have a clue
about how it is packed, if holes are present, etc. The FcPattern and the m_fontMatrix
should be good enough to describe the Font. All other objects are created using these
variables

Replace C-style casts with C++ casts, in this case reinterpret_cast.

  • platform/gdk/FontDataGdk.cpp: (WebCore::FontData::platformInit): Don't assert (WebCore::FontData::platformDestroy): Take over ownership (WebCore::FontData::platformWidthForGlyph): initialize (WebCore::FontData::setFont): be paranoid and assert
  • platform/gdk/FontPlatformData.h: (WebCore::FontPlatformData::FontPlatformData): Initialize everything (WebCore::FontPlatformData::hash): make valgrind happy and don't use m_fontDescription
  • platform/gdk/FontPlatformDataGdk.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::~FontPlatformData): FontData::platformDestroy will do this (WebCore::FontPlatformData::list): Don't use C-style casts. (WebCore::FontPlatformData::setFont): m_fontFace, m_fontMatrix, m_options might not be initialized (WebCore::FontPlatformData::operator==): Don't use C-style casts.
06:47 Changeset [24016] by bdash
  • 4 edits in trunk/WebCore

2007-07-05 Alp Toker <alp.toker@collabora.co.uk>

Reviewed by Mark Rowe.

http://bugs.webkit.org/show_bug.cgi?id=14445
GraphicsContextCairo code style cleanup

Follow the cr naming convention for cairo_t*.
Remove trailing whitespace.
Replace C casts with C++ casts.
Avoid needless casts.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::platformContext): (WebCore::GraphicsContext::savePlatformState): (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::drawRect): (WebCore::adjustLineToPixelBoundaries): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::strokeArc): Save/restore the graphics state. (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::drawFocusRing): (WebCore::GraphicsContext::roundToDevicePixels): (WebCore::GraphicsContext::translate): (WebCore::GraphicsContext::origin): (WebCore::GraphicsContext::setPlatformStrokeThickness): (WebCore::GraphicsContext::setPlatformStrokeStyle): (WebCore::GraphicsContext::setPlatformFont): (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::setLineCap): (WebCore::GraphicsContext::setLineJoin): (WebCore::GraphicsContext::setMiterLimit): (WebCore::GraphicsContext::setCompositeOperation): (WebCore::GraphicsContext::beginPath): (WebCore::GraphicsContext::addPath): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::scale):
  • platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::ImageBuffer):
  • platform/graphics/cairo/ImageCairo.cpp: Avoid the confusing ctxt/context naming scheme. (WebCore::BitmapImage::draw): (WebCore::Image::drawPattern):
06:45 Changeset [24015] by bdash
  • 2 edits in trunk/WebCore

2007-07-05 Alp Toker <alp.toker@collabora.co.uk>

Reviewed by Mark Rowe.

http://bugs.webkit.org/show_bug.cgi?id=14531
Cairo SVGImage::nativeImageForCurrentFrame() has no return

Return the Cairo surface from the frame cache.

Also add a fall-through else macro with notImplemented() so that future
ports do not make the same mistake.

  • platform/graphics/svg/SVGImage.cpp: (WebCore::SVGImage::nativeImageForCurrentFrame):
06:43 Changeset [24014] by bdash
  • 2 edits in trunk/WebCore

2007-07-05 Alp Toker <alp.toker@collabora.co.uk>

Reviewed by Mark Rowe.

http://bugs.webkit.org/show_bug.cgi?id=14513
Cairo animated GIF support is broken

Implement ImageSource::frameIsCompleteAtIndex() to enable animated GIFs.

  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::frameIsCompleteAtIndex):
02:15 Changeset [24013] by aroben
  • 1 edit
    3 adds in trunk/LayoutTests

Add a Skipped file for Leopard.

Reviewed by Mark.

  • mac/leopard/Skipped: Added.
01:21 Changeset [24012] by aroben
  • 2 edits in trunk/WebKitTools

Warn about tests in the Skipped file that succeeded

  • Scripts/run-webkit-tests:
01:10 Changeset [24011] by aroben
  • 1 edit
    1 delete in trunk/WebKitTools

Removed unused install-win-extras script

Rubberstamped by Mark.

  • Scripts/install-win-extras: Removed.
00:51 Changeset [24010] by aroben
  • 2 edits in trunk/WebKitTools

Show the test's extension in the results page

  • Scripts/run-webkit-tests:
00:49 Changeset [24009] by aroben
  • 2 edits in trunk/WebKitTools

Add more options for controlling the interpretation of the Skipped file

Reviewed by Mark.

  • Scripts/run-webkit-tests:

07/04/07:

23:56 Changeset [24008] by aroben
  • 2 edits in trunk/WebKitTools

Add --skipped-only option to run-webkit-tests

When this option is specified, only those tests listed in the Skipped
file are run.

Reviewed by Mark.

  • Scripts/run-webkit-tests:
23:42 Changeset [24007] by aroben
  • 2 edits in trunk/WebKitTools

Clean up/alphabetize the run-webkit-tests help message

  • Scripts/run-webkit-tests:
23:24 Changeset [24006] by aroben
  • 3 edits in trunk/WebKitTools

Enable a Leopard-specific Skipped list.

Reviewed by Mark.

  • Scripts/run-webkit-tests: Check for Leopard.
  • Scripts/webkitdirs.pm: Added isTiger/isLeopard.
23:12 Changeset [24005] by bdash
  • 2 edits in trunk

... and it was reviewed by Adam.

23:08 Changeset [24004] by bdash
  • 3 edits
    9 adds in trunk

2007-07-04 Matt Perry <mpComplete@gmail.com>

Fix for http://bugs.webkit.org/show_bug.cgi?id=13400
Bug 13400: REGRESSION (r20809-20814): No back entry created for navigations created by assigning to document.location
<rdar://problem/5153025>

Treat userGesture as always true for setLocation, forcing a back/forward
entry to be created.

  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::setLocation):

2007-07-04 Matt Perry <mpComplete@gmail.com>

Test for http://bugs.webkit.org/show_bug.cgi?id=13400
Bug 13400: REGRESSION (r20809-20814): No back entry created for navigations created by assigning to document.location
<rdar://problem/5153025>

Test that assigning to document.location in various ways adds an
item to the back/forward list.

  • http/tests/navigation/document-location-click-expected.txt: Added.
  • http/tests/navigation/document-location-click-timeout-expected.txt: Added.
  • http/tests/navigation/document-location-click-timeout.html: Added.
  • http/tests/navigation/document-location-click.html: Added.
  • http/tests/navigation/document-location-mouseover-expected.txt: Added.
  • http/tests/navigation/document-location-mouseover.html: Added.
  • http/tests/navigation/document-location-onload-expected.txt: Added.
  • http/tests/navigation/document-location-onload.html: Added.
  • http/tests/navigation/resources/document-location.js: Added.
23:04 Changeset [24003] by aroben
  • 2 edits in trunk/WebCore

Restore MouseEventWithHitTestResults::targetNode's old behavior

Reviewed by Mark.

Fixes fast/images/imagemap-case and fast/replace/image-map.

  • page/MouseEventWithHitTestResults.cpp:

(WebCore::MouseEventWithHitTestResults::targetNode): Use the inner
node, not the inner non-shared node.

22:21 Changeset [24002] by aroben
  • 5 edits in trunk/WebCore

Mac, Qt, and Gdk build fixes.

  • page/EventHandler.h:
  • page/gdk/EventHandlerGdk.cpp:
  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passSubframeEventToSubframe):

  • page/qt/EventHandlerQt.cpp:
20:23 Changeset [24001] by aroben
  • 3 edits in trunk/WebCore

Fix the Qt/Gdk builds.

  • page/gdk/EventHandlerGdk.cpp:
  • page/qt/EventHandlerQt.cpp:
20:00 Changeset [24000] by aroben
  • 20 edits in trunk

Move tooltip logic down into WebCore so that it can be shared cross-platform

WebCore:

Move tooltip logic down into WebCore so that it can be shared cross-platform

Reviewed by Sam.

  • page/Chrome.cpp: (WebCore::Chrome::setToolTip): Added.
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/EventHandler.cpp: (WebCore::EventHandler::mouseMoved): Call Chrome::setToolTip.
  • platform/graphics/svg/SVGImageEmptyClients.h:

Added stubs for Gdk:

  • platform/gdk/ChromeClientGdk.h:
  • platform/gdk/TemporaryLinkStubs.cpp: (ChromeClientGdk::setToolTip):

WebKit:

Move tooltip logic down into WebCore so that it can be shared cross-platform

Reviewed by Sam.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::setToolTip): Added.
  • WebView/WebHTMLView.mm: Removed _resetCachedWebPreferences. (-[WebHTMLView _updateMouseoverWithEvent:]): Removed tooltip code. (-[WebHTMLView initWithFrame:]): Removed call to _resetCachedWebPreferences. (-[WebHTMLView setDataSource:]): Ditto.
  • WebView/WebHTMLViewInternal.h: Removed showsURLsInToolTips ivar.
  • WebView/WebHTMLViewPrivate.h: Added declaration for _setTooltip so that WebChromeClient can call it.

WebKit/win:

Added a stub for WebChromeClient::setToolTip

Reviewed by Sam.

  • WebChromeClient.cpp:
  • WebChromeClient.h:

WebKitQt:

Added a stub for ChromeClientQt::setToolTip

Reviewed by Sam.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::setToolTip):
  • WebCoreSupport/ChromeClientQt.h:
20:00 Changeset [23999] by aroben
  • 8 edits in trunk

Add/initialize Settings::showsURLsInToolTips

WebCore:

Add Settings::showsURLsInToolTips

Reviewed by Sam.

  • WebCore.exp:
  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h:

WebKit:

Initialize Settings::showsURLsInToolTips

Reviewed by Sam.

  • WebView/WebView.mm: (-[WebView _updateWebCoreSettingsFromPreferences:]):

WebKit/win:

Initialize Settings::showsURLsInToolTips

Reviewed by Sam.

  • WebView.cpp: (WebView::updateWebCoreSettingsFromPreferences):
20:00 Changeset [23998] by aroben
  • 9 edits in trunk

Move logic for calling mouseDidMoveOverElement into WebCore

WebCore:

Move logic for calling mouseDidMoveOverElement into WebCore

Reviewed by Sam.

  • page/EventHandler.cpp: (WebCore::EventHandler::mouseMoved): Added. Calls Chrome::mouseDidMoveOverElement. (WebCore::EventHandler::handleMouseMoveEvent): Now takes an optional HitTestResult* parameter which is used to communicate to the caller the node the mouse is over.
  • page/EventHandler.h:
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::mouseMoved): Changed to call the overloaded mouseMoved(). (WebCore::EventHandler::passMouseMoveEventToSubframe): Pass hoveredNode through to the subframe so we can get the deepest node hovered, not just the node's parent frame.
  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::passMouseMoveEventToSubframe): Ditto.

WebKit:

Removed call to mouseDidMoveOverElement now that WebCore handles it

Reviewed by Sam.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _updateMouseoverWithEvent:]):

WebKit/win:

Removed call to mouseDidMoveOverElement now that WebCore handles it

Reviewed by Sam.

  • WebView.cpp: (WebView::handleMouseEvent):
20:00 Changeset [23997] by aroben
  • 16 edits in trunk

Add Chrome::mouseDidMoveOverElement

WebCore:

Add Chrome::mouseDidMoveOverElement

This does the work of calling up to the ChromeClient (which will call
the UI delegate).

Reviewed by Sam.

  • page/Chrome.cpp: (WebCore::Chrome::mouseDidMoveOverElement): Added.
  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/graphics/svg/SVGImageEmptyClients.h: Updated for change to ChromeClient.
  • platform/gdk/ChromeClientGdk.h:
  • platform/gdk/TemporaryLinkStubs.cpp: (ChromeClientGdk::mouseDidMoveOverElement):

WebKit:

Add WebChromeClient::mouseDidMoveOverElement

This is not called yet.

Reviewed by Sam.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

WebKit/win:

Add WebChromeClient::mouseDidMoveOverElement

This is not called yet.

Reviewed by Sam.

  • WebChromeClient.cpp: (WebChromeClient::mouseDidMoveOverElement):
  • WebChromeClient.h:

WebKitQt:

Added a stub for ChromeClientQt::mouseDidMoveOverElement

Reviewed by Sam.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::mouseDidMoveOverElement):
  • WebCoreSupport/ChromeClientQt.h:
20:00 Changeset [23996] by aroben
  • 4 edits in trunk/WebCore

Changed PlatformMouseEvent to store the modifier flags of the event

Reviewed by Sam.

  • platform/PlatformMouseEvent.h:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):

  • platform/mac/PlatformMouseEventMac.mm:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):

  • platform/win/PlatformMouseEventWin.cpp:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):

19:59 Changeset [23995] by aroben
  • 4 edits in trunk/WebCore

Add HitTestResult::setToNonShadowAncestor

Reviewed by Sam.

  • page/EventHandler.cpp:

(WebCore::EventHandler::hitTestResultAtPoint): Moved logic into
HitTestResult::setToNonShadowAncestor.

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::setToNonShadowAncestor):

  • rendering/HitTestResult.h:
19:59 Changeset [23994] by aroben
  • 4 edits in trunk/WebCore

Change MouseEventWithHitTestResults to hold onto a HitTestResult

Reviewed by Sam.

  • dom/Document.cpp:

(WebCore::Document::prepareMouseEvent):

  • page/MouseEventWithHitTestResults.cpp:

(WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
(WebCore::MouseEventWithHitTestResults::targetNode):
(WebCore::MouseEventWithHitTestResults::localPoint):
(WebCore::MouseEventWithHitTestResults::scrollbar):

  • page/MouseEventWithHitTestResults.h:

(WebCore::MouseEventWithHitTestResults::event):
(WebCore::MouseEventWithHitTestResults::hitTestResult):

19:52 Changeset [23993] by darin
  • 3 edits in trunk/LayoutTests
  • take out infinity tests from the test for bug 5292262 (see below) for now since they give different results on PowerPC and Intel and are not an important part of the intent of this test anyway; the bug was about normal numbers, not edge cases like infinity

If we want to test the infinity behavior, we should make a separate test later.

  • fast/objc/longlongTest-expected.txt: Removed results from infinity tests.
  • fast/objc/longlongTest.html: Removed infinity tests.
18:16 Changeset [23992] by pewtermoose
  • 2 edits in trunk/WebCore

Not reviewed, gdk build fix.

  • platform/gdk/FrameGdk.cpp:
15:54 Changeset [23991] by antti
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by John.


Test for Repro crash due to infinite recursion in HTMLParser::handleError @ youos.com
<rdar://problem/5237811>

  • fast/table/incomplete-table-in-fragment-hang-expected.txt: Added.
  • fast/table/incomplete-table-in-fragment-hang.html: Added.

WebCore:

Reviewed by John.


Fix Repro crash due to infinite recursion in HTMLParser::handleError @ youos.com
<rdar://problem/5237811>


It is possible to add table parts (thead etc) without table ancestor to a document fragment. If a new table element
was added to such a part, as in


div.innerHTML = '<tbody><table>';


the parser error handling code would try to pop the previous table as normal. However since
the table does not actually exist nothing would happen and parser would go to infinite recursion.


Solution here is to pop table parts one by one when handling the error inside a fragment instead of trying to pop
the table straight away (as it might not exist).

  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError):
14:57 Changeset [23990] by kevino
  • 2 edits in branches/wx-port-alpha/trunk/WebCore/platform/graphics/wx

Fix transparent image support on Windows, and likely GTK too.

14:33 Changeset [23989] by staikos
  • 2 edits in trunk/WebCore

Patch from Qing Zhao to fix combobox rendering

14:23 Changeset [23988] by staikos
  • 3 edits in trunk/WebCore

Compile

13:04 Changeset [23987] by weinig
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed by Mitz.

Test for http://bugs.webkit.org/show_bug.cgi?id=14504
REGRESSION (r23573): Amazon Book Excerpt can not be viewed in recent nightly

  • fast/dom/Window/window-property-shadowing-expected.txt: Added.
  • fast/dom/Window/window-property-shadowing.html: Added.

WebCore:

Reviewed by Mitz.

Patch for http://bugs.webkit.org/show_bug.cgi?id=14504
REGRESSION (r23573): Amazon Book Excerpt can not be viewed in recent nightly

  • Made it possible (again) to shadow window properties with local variable names.

Test: fast/dom/Window/window-property-shadowing.html

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customPut):
  • bindings/js/kjs_window.cpp: (KJS::Window::put):
  • bindings/scripts/CodeGeneratorJS.pm:
  • page/DOMWindow.idl:
11:37 Changeset [23986] by aliceli1
  • 10 edits
    3 adds in trunk/WebCore

Reviewed by Adam.

Fixed <rdar://problem/5225119> support smart pasting on Windows

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Added new files

  • editing/SmartReplace.cpp: Added. (WebCore::isCharacterSmartReplaceExempt):

Added non-CF implementation placeholder

  • editing/SmartReplace.h: Added.
  • editing/SmartReplaceCF.cpp: Added. (WebCore::getSmartSet): (WebCore::isCharacterSmartReplaceExempt):

Added new implementation

  • bridge/win/FrameWin.cpp:
  • page/Frame.h:
  • page/mac/FrameMac.mm:

Removed old declaration and implementation

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):

Changed to call the new function instead of old

  • page/mac/WebCoreFrameBridge.h:
  • page/mac/WebCoreFrameBridge.mm:

Removed old declaration and implementation

(-[WebCoreFrameBridge smartInsertForString:replacingRange:beforeString:afterString:]):

Changed to call the new function instead of old

  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::Pasteboard):

Register new clipboard format

(WebCore::Pasteboard::writeSelection):

Set data for smartpaste format on clipboard

(WebCore::Pasteboard::canSmartReplace):

Added non-stub implementation

11:33 Changeset [23985] by thatcher
  • 2 edits in trunk

Reenable some code for 64-bit now that <rdar://problem/5311640> and <rdar://problem/5311690> are resolved.

08:15 Changeset [23984] by staikos
  • 2 edits in trunk/WebCore

Patch from Qing Zhao: Similar to the PlatformScrollbar fixes, adjust the
painter to make the styler draw all subcontrols, and in this case the focus
rect, in the proper location

03:56 Changeset [23983] by bdash
  • 3 edits in trunk/WebCore

2007-07-04 Mitz Pettel <mitz@webkit.org>

Reviewed by Maciej.

No test possible because DumpRenderTree cannot query the current cursor.

  • page/EventHandler.cpp: (WebCore::EventHandler::selectCursor): Changed into a member function and added that if the last mouse down event could not have started a selection, then the cursor should not change to an I-beam unconditionally. (WebCore::EventHandler::handleMouseMoveEvent):
  • page/EventHandler.h:
03:52 Changeset [23982] by bdash
  • 2 edits in trunk/WebCore

2007-07-04 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Rob Buis.

A little progress in tracking dependencies.

  • WebCore.pro: Add DEPENDPATH for the Gdk port.
00:13 Changeset [23981] by bdash
  • 1 edit in tags/Safari-5522.10.1/WebCore/Configurations/Version.xcconfig

Versioning.

00:13 Changeset [23980] by bdash
  • 1 delete in tags/Safari-5522.10.1/WebCore/ForwardingHeaders/JavaScriptCore

Build fix.

00:10 Changeset [23979] by bdash
  • 1 copy in tags/Safari-5522.10.1

New tag.

07/03/07:

20:02 Changeset [23978] by darin
  • 2 edits in trunk/WebKit
  • StringsNotToBeLocalized.txt: Updated for recent changes.
18:07 Changeset [23977] by thatcher
  • 10 edits
    1 copy in trunk/WebKit

Reviewed by Darin.

Remove HIWebView in 64-bit.

Also disable a few calls that are now gone in 64-bit and filed these bugs:

<rdar://problem/5311653> WebKit needs to adopt HIGetMousePosition where we used GetGlobalMouse before
<rdar://problem/5311648> WebKit needs to move off of CopyEvent in WebBaseNetscapePluginView
<rdar://problem/5311640> WebKit needs a new solution for HISearchWindowShow on 64-bit

  • Carbon/CarbonUtils.m:
  • Carbon/CarbonWindowAdapter.m:
  • Carbon/CarbonWindowContentView.m:
  • Carbon/CarbonWindowFrame.m:
  • Carbon/HIViewAdapter.m: (SetViewNeedsDisplay):
  • Carbon/HIWebView.m: (Draw): (SyncFrame):
  • Configurations/WebKit.xcconfig:
  • Plugins/WebBaseNetscapePluginView.mm: (+[WebBaseNetscapePluginView getCarbonEvent:]): (TSMEventHandler):
  • WebKit.LP64.exp: Added.
  • WebView/WebView.mm: (-[WebView _searchWithSpotlightFromMenu:]):
18:04 Changeset [23976] by thatcher
  • 2 edits in trunk

Disable the strict aliasing warning until <rdar://problem/5311093> is fixed.

18:02 Changeset [23975] by thatcher
  • 1 edit in trunk/WebCore/page/mac/FrameMac.mm

64-bit build fix.

17:58 Changeset [23974] by aroben
  • 2 edits
    1 delete in trunk/WebKitTools

Fixed update-webkit-localizable-strings to work with new extract-localizable-strings

Got rid of extract-webkit-localizable-strings because it was trying to
do update-webkit-localizable-strings' job.

Rubberstamped by Darin.

  • Scripts/extract-webkit-localizable-strings: Removed.
  • Scripts/update-webkit-localizable-strings: Renamed from

extract-localizable-strings.

17:56 Changeset [23973] by thatcher
  • 10 edits
    1 copy in tags/Safari-5522.10/WebKit

Reviewed by Darin.

Remove HIWebView in 64-bit.

Also disable a few calls that are now gone in 64-bit and filed these bugs:

<rdar://problem/5311653> WebKit needs to adopt HIGetMousePosition where we used GetGlobalMouse before
<rdar://problem/5311648> WebKit needs to move off of CopyEvent in WebBaseNetscapePluginView
<rdar://problem/5311640> WebKit needs a new solution for HISearchWindowShow on 64-bit

  • Carbon/CarbonUtils.m:
  • Carbon/CarbonWindowAdapter.m:
  • Carbon/CarbonWindowContentView.m:
  • Carbon/CarbonWindowFrame.m:
  • Carbon/HIViewAdapter.m: (SetViewNeedsDisplay):
  • Carbon/HIWebView.m: (Draw): (SyncFrame):
  • Configurations/WebKit.xcconfig:
  • Plugins/WebBaseNetscapePluginView.mm: (+[WebBaseNetscapePluginView getCarbonEvent:]): (TSMEventHandler):
  • WebKit.LP64.exp: Added.
  • WebView/WebView.mm: (-[WebView _searchWithSpotlightFromMenu:]):
17:40 Changeset [23972] by aroben
  • 6 edits
    1 move
    1 add
    1 delete in trunk

Merge the Windows and Mac localized strings and exceptions files

WebKit:

Merge the Windows and Mac localized strings and exceptions files

Reviewed by Darin and Anders.

  • English.lproj/Localizable.strings: Added Windows strings.
  • StringsNotToBeLocalized.txt: Renamed from WebKit/English.lproj/StringsNotToBeLocalized.txt.

WebKit/win:

Merge the Windows and Mac localized strings and exceptions files

Reviewed by Darin and Anders.

  • English.lproj/Localizable.strings: Added Mac strings.
  • English.lproj/StringsNotToBeLocalized.txt: Removed.

WebKitTools:

Modify scripts to keep Mac/Windows localized strings in sync

extract-webkit-localizable-strings now handles extracting strings from
both the Mac and Windows WebKit ports and updating their respective
Localizable.strings files. extract-localizable-strings is now really a
piece of plumbing rather than a top-level tool.

Reviewed by Darin and Anders.

  • Scripts/extract-localizable-strings: Changed to handle multiple directories.
  • Scripts/extract-webkit-localizable-strings: Added.
17:29 Changeset [23971] by adele
  • 2 edits in trunk/WebKit

Removed printf I accidently left in.

  • Misc/WebNSURLExtras.m: (mapHostNames):
17:06 Changeset [23970] by thatcher
  • 4 edits in tags/Safari-5522.10/WebKit

Merge r23946 to fix 64-bit build.

17:04 Changeset [23969] by darin
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Tim Hatcher.

  • tests for <rdar://problem/5221297> Font family name in the cssText for a DOMCSSStyleDeclaration needs quotes
  • editing/style/font-family-with-space-expected.txt: Added.
  • editing/style/font-family-with-space.html: Added.
  • fast/inspector/style-expected.txt: Updated expected results to expect "Lucida Grande" in quote marks.

WebCore:

Reviewed by Tim Hatcher.

  • fix <rdar://problem/5221297> Font family name in the cssText for a DOMCSSStyleDeclaration needs quotes

Test: editing/style/font-family-with-space.html

  • css/FontFamilyValue.cpp: (WebCore::isValidCSSIdentifier): Added. Implements the same rule that the CSS lexer does. (WebCore::quoteStringIfNeeded): Changed to call isValidCSSIdentifier instead of just checking for a leading "#" character.
  • editing/markup.cpp: (WebCore::escapeTextForMarkup): Changed to take a String parameter for better efficiency. (WebCore::renderedText): Changed to return a String for better efficiency. (WebCore::addNamespace): Updated to pass String to escapeTextForMarkup. (WebCore::startMarkup): Updated to pass String to escapeTextForMarkup. Added missing call to escapeTextForMarkup in the special case for the style property. (WebCore::createMarkup): Changed from single quotes to double quotes and also added missing call to escapeTextForMarkup in two special cases for the style property.
16:56 Changeset [23968] by thatcher
  • 1 edit in tags/Safari-5522.10/WebCore/page/mac/FrameMac.mm

64-bit build fix.

16:54 Changeset [23967] by adele
  • 1 edit in trunk/WebKit/Misc/WebNSURLExtras.m

Updating comment

16:46 Changeset [23966] by thatcher
  • 2 edits in tags/Safari-5522.10

Disable the strict aliasing warning, not strict aliasing.

16:21 Changeset [23965] by thatcher
  • 2 edits in tags/Safari-5522.10

Turn off strict aliasing until <rdar://problem/5311093> is fixed.

16:19 Changeset [23964] by weinig
  • 6 edits in trunk/WebCore

Reviewed by Darin.

Twelfth round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

  • Add casts and accompanying FIXMEs to avoid remaining compiler errors.
  • WebCore.xcodeproj/project.pbxproj:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::opened): (WebCore::FrameLoader::sendRemainingDelegateMessages):
  • loader/FrameLoader.h:
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::didReceiveData):
  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]): (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]):
  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::nsURLResponse):
16:16 Changeset [23963] by adele
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for: <rdar://problem/5292988> domain names shouldn't contain ignorable characters

  • fast/encoding/idn-security-expected.txt: Added.
  • fast/encoding/idn-security.html: Added.
  • win/Skipped: Blocked by <rdar://problem/5301954>.

WebKit:

Reviewed by Darin.

Fix for: <rdar://problem/5292988> domain names shouldn't contain ignorable characters

  • Misc/WebNSURLExtras.m: (isLookalikeCharacter): Renamed. Also excludes any non-printable character, any character considered as whitespace that isn't already converted to a space by ICU, any ignorable character, and any character excluded in Mozilla's blacklist: http://kb.mozillazine.org/Network.IDN.blacklist_chars (allCharactersInIDNScriptWhiteList):

WebKitTools:

Reviewed by Darin.

Extended DumpRenderTree to test encoding and decoding host names.

  • DumpRenderTree/DumpRenderTree.m: (+[LayoutTestController isSelectorExcludedFromWebScript:]): Added cases for encodeHostName and decodeHostName. (+[LayoutTestController webScriptNameForSelector:]): ditto. (-[LayoutTestController decodeHostName:]): Added. (-[LayoutTestController encodeHostName:]): Added.
16:03 Changeset [23962] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebKit/wx/bindings/python/samples/simple.py

Add some more functionality to the basic sample.

15:51 Changeset [23961] by weinig
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.

Eleventh round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

Add functions to test long long and unsigned long long.

  • DumpRenderTree/DumpRenderTree.m: (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController objCLongLongRoundTrip:]): (-[LayoutTestController objCUnsignedLongLongRoundTrip:]):
15:37 Changeset [23960] by weinig
  • 3 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Darin.

Eleventh round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

  • Fixes a real bug where where we were setting long long and unsigned long long values to a long field.
  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue):

LayoutTests:

Reviewed by Darin.

Eleventh round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

  • fast/objc: Added.
  • fast/objc/longlongTest-expected.txt: Added.
  • fast/objc/longlongTest.html: Added.
15:11 Changeset [23959] by thatcher
  • 2 edits in tags/Safari-5522.10/WebCore

Merge r23894.

15:04 Changeset [23958] by thatcher
  • 3 edits in tags/Safari-5522.10

Turn off -Wshorten-64-to-32 until <rdar://problems/5292100&5292113&5292262> are fixed.

15:02 Changeset [23957] by darin
  • 4 edits in trunk/WebKit

Reviewed by Maciej.

  • fix <rdar://problem/5310848> WebDataSource lifetime problem -- may be cause of the leaks seen on the buildbot
  • WebView/WebDataSource.mm: (-[WebDataSourcePrivate dealloc]): Added a call to the new detachDataSource function. (-[WebDataSourcePrivate finalize]): Ditto.
  • WebView/WebDocumentLoaderMac.h: Added detachDataSource function to be used when the WebDataSource is deallocated. Added retain/releaseDataSource helper functions to be used to retain and release the data source object. Replaced the m_hasEverBeenDetached boolean with a more primitive and hence easier to understand m_isDataSourceRetained boolean.
  • WebView/WebDocumentLoaderMac.mm: (WebDocumentLoaderMac::WebDocumentLoaderMac): Initialize m_isDataSourceRetained to false. (WebDocumentLoaderMac::setDataSource): Call retainDataSource instead of calling HardRetain on the dataSource parameter. Also updated a comment. (WebDocumentLoaderMac::attachToFrame): Call retainDataSource unconditionally rather than trying to use m_hasEverBeenDetached to decide if a retain is needed. Also got rid of an assertion that m_loadingResources is empty -- not important any more. (WebDocumentLoaderMac::detachFromFrame): Call releaseDataSource instead of using HardRelease, but only if m_loadingResources is empty. If it's non-empty, then we'll do the releaseDataSource later in decreaseLoadCount. (WebDocumentLoaderMac::increaseLoadCount): Call retainDataSource unconditionally rather than calling HardRetain only if the old set of resources was empty. (WebDocumentLoaderMac::decreaseLoadCount): Call releaseDataSource if m_loadingResources is empty and we're not attached to a frame. If we are attached to a frame, then we'll do the releaseDataSource later in detachFromFrame. (WebDocumentLoaderMac::retainDataSource): Added. Calls CFRetain, but only if the data source is not already retained (according to the boolean). (WebDocumentLoaderMac::releaseDataSource): Added. Calls CFRelease, but only if the data source is currently retained (according to the boolean). (WebDocumentLoaderMac::detachDataSource): Added. Sets m_dataSource to nil. Since this is only called from WebDataSource's dealloc and finalize methods, it won't ever be called when the m_isDataSourceRetained boolean is true.
15:01 Changeset [23956] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5093862>
Nothing shown in plugin area when trying to play content using the DivX plugin


Defer calling SetWindow for the DivX plugin, just like we do with the WMP plugin.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::determineQuirks):
14:35 Changeset [23955] by weinig
  • 2 edits in trunk/JavaScriptCore

Reviewed by Brady Eidson.

Tenth round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

  • Add explicit casts.
  • kjs/dtoa.cpp: (Bigint::):
14:21 Changeset [23954] by darin
  • 2 edits in trunk/WebKit
  • forgot to check in one file in the fix for <rdar://problem/5307880> some classes need finalize methods because of non-trivial work done in dealloc methods
  • WebView/WebView.mm: (-[WebViewPrivate finalize]): Delete identifierMap so it doesn't leak.
14:17 Changeset [23953] by weinig
  • 3 edits in trunk/WebCore

Reviewed by Brady Eidson.

Ninth round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

  • Fix function signature to use unsigned long instead of unsigned long long.
  • loader/ProgressTracker.cpp: (WebCore::ProgressTracker::completeProgress):
  • loader/ProgressTracker.h:
14:11 Changeset [23952] by thatcher
  • 1 copy in tags/Safari-5522.10

New tag.

13:46 Changeset [23951] by weinig
  • 44 edits in trunk/WebCore

Reviewed by Oliver.

Eighth round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

  • Convert SVG implementation files to use floats instead of doubles to match the spec/IDLs.
  • bindings/scripts/CodeGeneratorJS.pm:
  • ksvg2/svg/SVGAngle.cpp:
  • ksvg2/svg/SVGAnimatedTemplate.h:
  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::getEndTime): (WebCore::SVGAnimationElement::getStartTime): (WebCore::SVGAnimationElement::getCurrentTime): (WebCore::SVGAnimationElement::getSimpleDuration):
  • ksvg2/svg/SVGAnimationElement.h:
  • ksvg2/svg/SVGFitToViewBox.cpp: (WebCore::SVGFitToViewBox::parseViewBox):
  • ksvg2/svg/SVGLength.cpp: (WebCore::SVGLength::setValueAsString):
  • ksvg2/svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::buildGradient):
  • ksvg2/svg/SVGMatrix.idl:
  • ksvg2/svg/SVGNumber.idl:
  • ksvg2/svg/SVGParserUtilities.cpp: (WebCore::SVGPathParser::parseSVG): (WebCore::SVGPathParser::calculateArc): (WebCore::SVGPathParser::svgLineToHorizontal): (WebCore::SVGPathParser::svgLineToVertical): (WebCore::SVGPathParser::svgCurveToCubicSmooth): (WebCore::SVGPathParser::svgCurveToQuadratic): (WebCore::SVGPathParser::svgCurveToQuadraticSmooth): (WebCore::SVGPathParser::svgArcTo):
  • ksvg2/svg/SVGParserUtilities.h:
  • ksvg2/svg/SVGPathElement.cpp: (WebCore::SVGPathElement::SVGPathElement): (WebCore::SVGPathElement::getTotalLength): (WebCore::SVGPathElement::getPointAtLength): (WebCore::SVGPathElement::getPathSegAtLength): (WebCore::SVGPathElement::createSVGPathSegMovetoAbs): (WebCore::SVGPathElement::createSVGPathSegMovetoRel): (WebCore::SVGPathElement::createSVGPathSegLinetoAbs): (WebCore::SVGPathElement::createSVGPathSegLinetoRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel): (WebCore::SVGPathElement::createSVGPathSegArcAbs): (WebCore::SVGPathElement::createSVGPathSegArcRel): (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs): (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel): (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs): (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel): (WebCore::SVGPathElement::svgMoveTo): (WebCore::SVGPathElement::svgLineTo): (WebCore::SVGPathElement::svgLineToHorizontal): (WebCore::SVGPathElement::svgLineToVertical): (WebCore::SVGPathElement::svgCurveToCubic): (WebCore::SVGPathElement::svgCurveToCubicSmooth): (WebCore::SVGPathElement::svgCurveToQuadratic): (WebCore::SVGPathElement::svgCurveToQuadraticSmooth): (WebCore::SVGPathElement::svgArcTo): (WebCore::SVGPathElement::parseMappedAttribute):
  • ksvg2/svg/SVGPathElement.h:
  • ksvg2/svg/SVGPathSegArc.cpp: (WebCore::SVGPathSegArcAbs::SVGPathSegArcAbs): (WebCore::SVGPathSegArcAbs::setX): (WebCore::SVGPathSegArcAbs::x): (WebCore::SVGPathSegArcAbs::setY): (WebCore::SVGPathSegArcAbs::y): (WebCore::SVGPathSegArcAbs::setR1): (WebCore::SVGPathSegArcAbs::r1): (WebCore::SVGPathSegArcAbs::setR2): (WebCore::SVGPathSegArcAbs::r2): (WebCore::SVGPathSegArcAbs::setAngle): (WebCore::SVGPathSegArcAbs::angle): (WebCore::SVGPathSegArcRel::SVGPathSegArcRel): (WebCore::SVGPathSegArcRel::setX): (WebCore::SVGPathSegArcRel::x): (WebCore::SVGPathSegArcRel::setY): (WebCore::SVGPathSegArcRel::y): (WebCore::SVGPathSegArcRel::setR1): (WebCore::SVGPathSegArcRel::r1): (WebCore::SVGPathSegArcRel::setR2): (WebCore::SVGPathSegArcRel::r2): (WebCore::SVGPathSegArcRel::setAngle): (WebCore::SVGPathSegArcRel::angle):
  • ksvg2/svg/SVGPathSegArc.h:
  • ksvg2/svg/SVGPathSegCurvetoCubic.cpp: (WebCore::SVGPathSegCurvetoCubicAbs::SVGPathSegCurvetoCubicAbs): (WebCore::SVGPathSegCurvetoCubicAbs::setX): (WebCore::SVGPathSegCurvetoCubicAbs::x): (WebCore::SVGPathSegCurvetoCubicAbs::setY): (WebCore::SVGPathSegCurvetoCubicAbs::y): (WebCore::SVGPathSegCurvetoCubicAbs::setX1): (WebCore::SVGPathSegCurvetoCubicAbs::x1): (WebCore::SVGPathSegCurvetoCubicAbs::setY1): (WebCore::SVGPathSegCurvetoCubicAbs::y1): (WebCore::SVGPathSegCurvetoCubicAbs::setX2): (WebCore::SVGPathSegCurvetoCubicAbs::x2): (WebCore::SVGPathSegCurvetoCubicAbs::setY2): (WebCore::SVGPathSegCurvetoCubicAbs::y2): (WebCore::SVGPathSegCurvetoCubicRel::SVGPathSegCurvetoCubicRel): (WebCore::SVGPathSegCurvetoCubicRel::setX): (WebCore::SVGPathSegCurvetoCubicRel::x): (WebCore::SVGPathSegCurvetoCubicRel::setY): (WebCore::SVGPathSegCurvetoCubicRel::y): (WebCore::SVGPathSegCurvetoCubicRel::setX1): (WebCore::SVGPathSegCurvetoCubicRel::x1): (WebCore::SVGPathSegCurvetoCubicRel::setY1): (WebCore::SVGPathSegCurvetoCubicRel::y1): (WebCore::SVGPathSegCurvetoCubicRel::setX2): (WebCore::SVGPathSegCurvetoCubicRel::x2): (WebCore::SVGPathSegCurvetoCubicRel::setY2): (WebCore::SVGPathSegCurvetoCubicRel::y2):
  • ksvg2/svg/SVGPathSegCurvetoCubic.h:
  • ksvg2/svg/SVGPathSegCurvetoCubicSmooth.cpp: (WebCore::SVGPathSegCurvetoCubicSmoothAbs::SVGPathSegCurvetoCubicSmoothAbs): (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setX): (WebCore::SVGPathSegCurvetoCubicSmoothAbs::x): (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setY): (WebCore::SVGPathSegCurvetoCubicSmoothAbs::y): (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setX2): (WebCore::SVGPathSegCurvetoCubicSmoothAbs::x2): (WebCore::SVGPathSegCurvetoCubicSmoothAbs::setY2): (WebCore::SVGPathSegCurvetoCubicSmoothAbs::y2): (WebCore::SVGPathSegCurvetoCubicSmoothRel::SVGPathSegCurvetoCubicSmoothRel): (WebCore::SVGPathSegCurvetoCubicSmoothRel::setX): (WebCore::SVGPathSegCurvetoCubicSmoothRel::x): (WebCore::SVGPathSegCurvetoCubicSmoothRel::setY): (WebCore::SVGPathSegCurvetoCubicSmoothRel::y): (WebCore::SVGPathSegCurvetoCubicSmoothRel::setX2): (WebCore::SVGPathSegCurvetoCubicSmoothRel::x2): (WebCore::SVGPathSegCurvetoCubicSmoothRel::setY2): (WebCore::SVGPathSegCurvetoCubicSmoothRel::y2):
  • ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
  • ksvg2/svg/SVGPathSegCurvetoQuadratic.cpp: (WebCore::SVGPathSegCurvetoQuadraticAbs::SVGPathSegCurvetoQuadraticAbs): (WebCore::SVGPathSegCurvetoQuadraticAbs::setX): (WebCore::SVGPathSegCurvetoQuadraticAbs::x): (WebCore::SVGPathSegCurvetoQuadraticAbs::setY): (WebCore::SVGPathSegCurvetoQuadraticAbs::y): (WebCore::SVGPathSegCurvetoQuadraticAbs::setX1): (WebCore::SVGPathSegCurvetoQuadraticAbs::x1): (WebCore::SVGPathSegCurvetoQuadraticAbs::setY1): (WebCore::SVGPathSegCurvetoQuadraticAbs::y1): (WebCore::SVGPathSegCurvetoQuadraticRel::SVGPathSegCurvetoQuadraticRel): (WebCore::SVGPathSegCurvetoQuadraticRel::setX): (WebCore::SVGPathSegCurvetoQuadraticRel::x): (WebCore::SVGPathSegCurvetoQuadraticRel::setY): (WebCore::SVGPathSegCurvetoQuadraticRel::y): (WebCore::SVGPathSegCurvetoQuadraticRel::setX1): (WebCore::SVGPathSegCurvetoQuadraticRel::x1): (WebCore::SVGPathSegCurvetoQuadraticRel::setY1): (WebCore::SVGPathSegCurvetoQuadraticRel::y1):
  • ksvg2/svg/SVGPathSegCurvetoQuadratic.h: (WebCore::SVGPathSegCurvetoQuadraticRel::toString):
  • ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.cpp: (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::SVGPathSegCurvetoQuadraticSmoothAbs): (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::setX): (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::x): (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::setY): (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::y): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::SVGPathSegCurvetoQuadraticSmoothRel): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::setX): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::x): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::setY): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::y):
  • ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
  • ksvg2/svg/SVGPathSegLineto.cpp: (WebCore::SVGPathSegLinetoAbs::SVGPathSegLinetoAbs): (WebCore::SVGPathSegLinetoAbs::setX): (WebCore::SVGPathSegLinetoAbs::x): (WebCore::SVGPathSegLinetoAbs::setY): (WebCore::SVGPathSegLinetoAbs::y): (WebCore::SVGPathSegLinetoRel::SVGPathSegLinetoRel): (WebCore::SVGPathSegLinetoRel::setX): (WebCore::SVGPathSegLinetoRel::x): (WebCore::SVGPathSegLinetoRel::setY): (WebCore::SVGPathSegLinetoRel::y):
  • ksvg2/svg/SVGPathSegLineto.h:
  • ksvg2/svg/SVGPathSegLinetoHorizontal.cpp: (WebCore::SVGPathSegLinetoHorizontalAbs::SVGPathSegLinetoHorizontalAbs): (WebCore::SVGPathSegLinetoHorizontalAbs::setX): (WebCore::SVGPathSegLinetoHorizontalAbs::x): (WebCore::SVGPathSegLinetoHorizontalRel::SVGPathSegLinetoHorizontalRel): (WebCore::SVGPathSegLinetoHorizontalRel::setX): (WebCore::SVGPathSegLinetoHorizontalRel::x):
  • ksvg2/svg/SVGPathSegLinetoHorizontal.h:
  • ksvg2/svg/SVGPathSegLinetoVertical.cpp: (WebCore::SVGPathSegLinetoVerticalAbs::SVGPathSegLinetoVerticalAbs): (WebCore::SVGPathSegLinetoVerticalAbs::setY): (WebCore::SVGPathSegLinetoVerticalAbs::y): (WebCore::SVGPathSegLinetoVerticalRel::SVGPathSegLinetoVerticalRel): (WebCore::SVGPathSegLinetoVerticalRel::setY): (WebCore::SVGPathSegLinetoVerticalRel::y):
  • ksvg2/svg/SVGPathSegLinetoVertical.h:
  • ksvg2/svg/SVGPathSegList.cpp: (WebCore::SVGPathSegList::getPathSegAtLength):
  • ksvg2/svg/SVGPathSegList.h:
  • ksvg2/svg/SVGPathSegMoveto.cpp: (WebCore::SVGPathSegMovetoAbs::SVGPathSegMovetoAbs): (WebCore::SVGPathSegMovetoAbs::setX): (WebCore::SVGPathSegMovetoAbs::x): (WebCore::SVGPathSegMovetoAbs::setY): (WebCore::SVGPathSegMovetoAbs::y): (WebCore::SVGPathSegMovetoRel::SVGPathSegMovetoRel): (WebCore::SVGPathSegMovetoRel::setX): (WebCore::SVGPathSegMovetoRel::x): (WebCore::SVGPathSegMovetoRel::setY): (WebCore::SVGPathSegMovetoRel::y):
  • ksvg2/svg/SVGPathSegMoveto.h:
  • ksvg2/svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::svgPolyTo):
  • ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::viewport): (WebCore::SVGSVGElement::getCurrentTime):
  • ksvg2/svg/SVGStopElement.cpp: (WebCore::SVGStopElement::SVGStopElement): (WebCore::SVGStopElement::parseMappedAttribute):
  • ksvg2/svg/SVGStopElement.h:
  • ksvg2/svg/SVGTransform.cpp: (SVGTransform::translate): (SVGTransform::scale):
  • ksvg2/svg/SVGTransformDistance.cpp: (WebCore::SVGTransformDistance::addToSVGTransform): (WebCore::SVGTransformDistance::distance):
  • ksvg2/svg/SVGTransformable.cpp: (WebCore::SVGTransformable::parseTransformAttribute):
13:15 Changeset [23950] by andersca
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

<rdar://problem/5289718>
http://bugs.webkit.org/show_bug.cgi?id=14437
CrashTracer: [REGRESSION] 76 crashes in Safari at com.apple.WebCore: WebCore::Frame::settings const + 6 (14437)


Add test from Alexey Proskuryakov.


  • plugins/plugin-remove-subframe-expected.txt: Added.
  • plugins/plugin-remove-subframe.html: Added.

WebCore:

Reviewed by Darin.

<rdar://problem/5289718>
http://bugs.webkit.org/show_bug.cgi?id=14437
CrashTracer: [REGRESSION] 76 crashes in Safari at com.apple.WebCore: WebCore::Frame::settings const + 6 (14437)


Based on a patch from Maxime Britto.


  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]): If the script caused the frame to go away, return nil. This can only happen if a plugin in a subframe destroys its frame.

(-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
ASSERT that this is only called on the main frame.

WebKit:

Reviewed by Darin.

  • WebView/WebView.mm: (-[WebView stringByEvaluatingJavaScriptFromString:]): ASSERT that the value returned isn't nil. It can't be nil when invoked on the main frame.
12:22 Changeset [23949] by sullivan
  • 2 edits in trunk/WebCore

Written by Darin, reviewed by me


  • fixed <rdar://problem/5249730> REGRESSION (Leopard, around 9A464): Safari opens the same local documents more than once due to canonicalization change
  • loader/mac/LoaderNSURLExtras.m: (canonicalURL): pass URL through KURL so we get KURL's version of canonicalization as well as NSURLProtocol's version of canonicalization
12:14 Changeset [23948] by weinig
  • 38 edits in trunk

LayoutTests:

Reviewed by Darin.

Seventh round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

  • Change from double -> float caused some slight changes.
  • svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-37-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-81-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-units-02-b-expected.txt:
  • svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-02-b-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-03-b-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-04-b-expected.txt:
  • svg/W3C-SVG-1.1/shapes-circle-02-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.txt:
  • svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
  • svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt:

WebCore:

Reviewed by Darin.

Seventh round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

  • Adds more narrowPrecision functions to FloatPoint, FloatSize and FloatRect.
  • Changes over more implicit conversions to use new functions.
  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
  • platform/graphics/FloatPoint.cpp: (WebCore::FloatPoint::matrixTransform): (WebCore::FloatPoint::narrowPrecision):
  • platform/graphics/FloatPoint.h:
  • platform/graphics/FloatRect.cpp: (WebCore::FloatRect::narrowPrecision):
  • platform/graphics/FloatRect.h:
  • platform/graphics/FloatSize.cpp: (WebCore::FloatSize::narrowPrecision):
  • platform/graphics/FloatSize.h:
  • platform/graphics/Path.cpp: (WebCore::Path::createRoundedRectangle): (WebCore::Path::createRectangle): (WebCore::Path::createEllipse):
  • platform/graphics/mac/ColorMac.mm: (WebCore::nsColor):
  • platform/graphics/mac/IconMac.mm: (WebCore::Icon::paint):
  • platform/graphics/svg/cg/CgSupport.cpp: (WebCore::applyStrokeStyleToContext):
  • platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp: (WebCore::CGShadingRefForRadialGradient): (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache): (WebCore::SVGPaintServerGradient::handleBoundingBoxModeAndGradientTransformation):
  • platform/graphics/svg/cg/SVGResourceMaskerCg.mm: (WebCore::applyLuminanceToAlphaFilter): (WebCore::applyExpandAlphatoGrayscaleFilter): (WebCore::transformImageIntoGrayscaleMask):
  • platform/mac/WebCoreTextRenderer.mm: (WebCoreDrawTextAtPoint):
  • rendering/RenderPath.cpp: (WebCore::RenderPath::mapAbsolutePointToLocal):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::calcViewport):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::nodeAtPoint):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::relativeBBox):
10:55 Changeset [23947] by andersca
  • 3 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5261523>
Crash playing MP11 on cnbc.com


The WMP Netscape plugin still creates a window even when windowless mode is turned on. Work around this by
always removing the "windowlessvideo" parameter before passing it to the plugin.
According to http://msdn2.microsoft.com/en-us/library/bb249373.aspx, "The windowlessVideo property is not
supported for Netscape Navigator. Setting a value for this property in Navigator may yield unexpected results."


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWndProc): (WebCore::PluginViewWin::paint): (WebCore::PluginViewWin::invalidateRect): (WebCore::PluginViewWin::determineQuirks): (WebCore::PluginViewWin::setParameters): (WebCore::PluginViewWin::PluginViewWin): (WebCore::PluginViewWin::init):
  • plugins/win/PluginViewWin.h: (WebCore::):
09:21 Changeset [23946] by bdash
  • 4 edits in trunk/WebKit

2007-07-04 Mark Rowe <mrowe@apple.com>

Unreviewed 64-bit build fixes.

  • WebCoreSupport/WebInspectorClient.mm: Let the compiler know that WebFrameView is a subclass of NSView.
  • WebView/WebDocumentInternal.h: Remove our preprocessor macro once we're done with it.
  • WebView/WebHTMLView.mm: (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Fix argument types.
08:29 Changeset [23945] by staikos
  • 2 edits in trunk/WebCore

Patch from Qing Zhao to fix sunken state improperly set.

06:42 Changeset [23944] by antti
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.


Test for REGRESSION: misplaced selection ring remains after link is no longer focused.
<rdar://problem/5205580>

  • fast/repaint/focus-layers-expected.checksum: Added.
  • fast/repaint/focus-layers-expected.png: Added.
  • fast/repaint/focus-layers-expected.txt: Added.
  • fast/repaint/focus-layers.html: Added.

WebCore:

Reviewed by Maciej.


REGRESSION: misplaced selection ring remains after link is no longer focused.
<rdar://problem/5205580>


Fix placement of selection ring when part of the ring is in a different layer.

  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::addFocusRingRects): Get coordinates right when moving to a different layer.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): Don't reset state variables when not necessary. When repaint() was called at the end of setSyle() it would get repaint rects wrong in some cases.
06:31 Changeset [23943] by antti
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Blind fix for CrashTracer: [USER] 25 crashes in Safari at com.apple.WebCore: WebCore::Frame::document const + 6
<rdar://problem/5263939>


No one has managed to reproduce this but it looks like null check is needed here. There are plausible ways
m_frame could be null for a live FrameView object.

  • page/FrameView.cpp: (WebCore::FrameView::needsLayout):
05:58 Changeset [23942] by rwlbuis
  • 2 edits in branches/feature-branch/LayoutTests

Correcting the pixel test result that was supposed to go in during r23849.

07/02/07:

22:52 Changeset [23941] by aroben
  • 2 edits in trunk/LayoutTests

Update the Windows Skipped list.

  • win/Skipped:
18:36 Changeset [23940] by aroben
  • 6 edits in trunk/LayoutTests

Update results after r23938.

  • fast/inline-block/14498-positionForCoordinates-expected.txt:
  • fast/table/click-near-anonymous-table-expected.txt:
  • svg/custom/pointer-events-image-expected.txt:
  • svg/custom/pointer-events-path-expected.txt:
  • svg/custom/text-hit-test-expected.txt:
17:53 Changeset [23939] by oliver
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/5098378> single-pixel image optimization needs to be rewritten to not depend on floating point bitmap
Tested by fast/replaced/image-solid-color-with-alpha.html

Switch from float to byte based bitmap when pulling the color from 1x1 pixel images so
that we can use the single pixel image optimisation in WebKit/win.

  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::checkForSolidColor):
16:54 Changeset [23938] by aroben
  • 3 edits
    2 adds in trunk

Fix Bug 14498: RenderContainer::positionForCoordinates contains an order of operations error

WebCore:

Fix Bug 14498: RenderContainer::positionForCoordinates contains an order of operations error
http://bugs.webkit.org/show_bug.cgi?id=14498

There were two bugs:
1) xPos/yPos were flipped
2) + binds tighter than ?:, so the order of operations was incorrect

Reviewed by Darin.

Test: fast/inline-block/14498-positionForCoordinates.html

  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::positionForCoordinates):

LayoutTests:

Test for Bug 14498: RenderContainer::positionForCoordinates contains an order of operations error
http://bugs.webkit.org/show_bug.cgi?id=14498

Reviewed by Darin.

  • fast/inline-block/14498-positionForCoordinates-expected.txt: Added.
  • fast/inline-block/14498-positionForCoordinates.html: Added.
16:30 Changeset [23937] by darin
  • 6 edits in trunk/WebKit

Reviewed by Kevin Decker and Tim Hatcher.

  • fix <rdar://problem/5307880> some classes need finalize methods because of non-trivial work done in dealloc methods
  • DefaultDelegates/WebScriptDebugServer.m: (-[WebScriptDebugServer dealloc]): Added a comment about how this probably won't work under GC.
  • WebInspector/WebNodeHighlight.m: (-[WebNodeHighlight dealloc]): Ditto.
  • WebView/WebDataSource.mm: (+[WebDataSourcePrivate initialize]): Added. Makes finalize run on main thread. (-[WebDataSourcePrivate finalize]): Added. Calls deref on the document loader.
  • WebView/WebHTMLView.mm: (+[WebHTMLViewPrivate initialize]): Added. Makes finalize run on main thread. (-[WebHTMLViewPrivate finalize]): Added. Calls deref on promisedDragTIFFDataSource.
  • WebKit.xcodeproj/project.pbxproj: Let Xcode be Xcode.
16:29 Changeset [23936] by darin
  • 4 edits in trunk/WebCore

Reviewed by Kevin Decker and Tim Hatcher.

  • fix <rdar://problem/5307906> some classes need finalize methods because of non-trivial work done in dealloc methods
  • bindings/objc/DOMRGBColor.mm: (+[DOMRGBColor initialize]): Added. Tells finalizer to run on main thread, which is needed because we are sharing a CFDictionary here with no locking.
  • bridge/mac/WebCoreAXObject.mm: (+[WebCoreAXObject initialize]): Added. Tells finalizer to run on main thread. (-[WebCoreAXObject finalize]): Added. Calls detach.
  • WebCore.xcodeproj/project.pbxproj: Let Xcode do what it wants to do.
16:20 Changeset [23935] by weinig
  • 8 edits in trunk/WebCore

Reviewed by Darin.

Sixth round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

Use new narrowPrecisionToFloat() and narrowPrecisionToCGFloat() where
appropriate.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setShadow): (WebCore::CanvasRenderingContext2D::applyShadow):
  • html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor): (WebCore::CanvasStyle::applyFillColor):
  • ksvg2/svg/SVGAngle.cpp:
  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::parseKeyNumbers): (WebCore::parseKeySplines): (WebCore::SVGAnimationElement::handleTimerEvent): (WebCore::SVGAnimationElement::updateAnimatedValueForElapsedSeconds):
  • ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::buildPattern):
  • ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
  • platform/graphics/cg/AffineTransformCG.cpp: (WebCore::AffineTransform::AffineTransform): (WebCore::AffineTransform::setMatrix): (WebCore::AffineTransform::map): (WebCore::AffineTransform::setA): (WebCore::AffineTransform::setB): (WebCore::AffineTransform::setC): (WebCore::AffineTransform::setD): (WebCore::AffineTransform::setE): (WebCore::AffineTransform::setF): (WebCore::AffineTransform::scale): (WebCore::AffineTransform::rotate): (WebCore::AffineTransform::translate): (WebCore::AffineTransform::shear):
16:05 Changeset [23934] by kevino
  • 6 edits in branches/wx-port-alpha/trunk

Enable RTTI and exceptions for now, fix a linking issue with libjpeg on Win, and improve support for building with Python versions other than 2.5.

15:14 Changeset [23933] by sullivan
  • 2 edits in trunk/WebCore
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]): added a comment
13:47 Changeset [23932] by weinig
  • 5 edits
    1 move in trunk/WebCore

Rubberstamped by Darin.

Rename FloatConversionUtilities.h to FloatConversion.h.
Fix Win32 build.

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/DeprecatedString.cpp:
  • platform/FloatConversion.h: Copied from platform/FloatConversionUtilities.h.
  • platform/FloatConversionUtilities.h: Removed.
  • platform/StringImpl.cpp:
13:41 Changeset [23931] by weinig
  • 12 edits
    1 add in trunk

JavaScriptCore:

Reviewed by Kevin McCullough.

Fourth round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

Add custom piDouble and piFloat constants to use instead of M_PI.

  • kjs/math_object.cpp: (MathObjectImp::getValueProperty):
  • wtf/MathExtras.h: (wtf_atan2):

WebCore:

Reviewed by Darin.

Fifth round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

Add toFloat() method to string classes and use it where appropriate.

  • WebCore.xcodeproj/project.pbxproj:
  • css/cssparser.cpp: (WebCore::CSSParser::lex):
  • ksvg2/svg/SVGAngle.cpp: (WebCore::SVGAngle::setValueAsString):
  • platform/AtomicString.h: (WebCore::AtomicString::toFloat):
  • platform/DeprecatedString.cpp: (WebCore::DeprecatedString::toFloat):
  • platform/DeprecatedString.h:
  • platform/FloatConversionUtilities.h: Added. (WebCore::narrowPrecisionToFloat): (WebCore::narrowPrecisionToCGFloat):
  • platform/PlatformString.h:
  • platform/String.cpp: (WebCore::String::toFloat):
  • platform/StringImpl.cpp: (WebCore::StringImpl::toFloat):
  • platform/StringImpl.h:
11:44 Changeset [23930] by weinig
  • 11 edits in trunk

JavaScriptCore:

Reviewed by Kevin McCullough.

Third round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

Add custom piDouble and piFloat constants to use instead of M_PI.

  • kjs/math_object.cpp: (MathObjectImp::getValueProperty):
  • wtf/MathExtras.h: (wtf_atan2):

WebCore:

Reviewed by Kevin McCullough.

Third round of fixes for implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

Use new piDouble and piFloat constants instead of M_PI.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::rotate):
  • ksvg2/svg/SVGParserUtilities.cpp: (WebCore::SVGPathParser::calculateArc):
  • platform/graphics/Path.cpp: (WebCore::pathLengthApplierFunction): (WebCore::Path::createEllipse):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::strokeArc):
  • platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::setCurrentPage):
  • platform/graphics/svg/filters/cg/SVGFEHelpersCg.h:
  • rendering/RenderPath.cpp: (WebCore::drawMarkerWithData):
11:12 BuildingGdk edited by alp@atoker.com
Update deps and tasks (diff)
08:52 Changeset [23929] by brmorris
  • 2 edits in S60/trunk/WebKit

brad, rs'd by sachin.

DESC: merge r23928 to trunk: noise suppression - typo in version.mk
causing a scanlog error ..

  • group/version.mk: typo in RELEASABLES phase.
08:50 Changeset [23928] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

brad, rs'd by sachin.

DESC: noise suppression - typo in version.mk causing a scanlog error ..

  • group/version.mk: typo in RELEASABLES phase.
07:08 Changeset [23927] by bdash
  • 2 edits in trunk/WebKitSite

2007-07-02 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

  • quality/reduction.html:
00:42 Changeset [23926] by oliver
  • 2 edits in trunk/WebKit

Reviewed by Justin.

Fix for

<rdar://problem/5290113> WebKit does not correctly handle replacement ranges from the IM in -[WebHTMLView insertText:]
http://bugs.webkit.org/show_bug.cgi?id=13664

We replicate the logic of -[WebHTMLView setMarkedText:selectedRange:] to handle the Input Method
feeding us a replacement string through insertText: so we can handle IMs that use insertText to
replace text.

  • WebView/WebHTMLView.mm: (-[WebHTMLView insertText:]):

07/01/07:

22:48 Changeset [23925] by aroben
  • 2 edits in trunk/WebCore

Clarify/fix {Shadow,BorderImage}ParseContext's memory management

Prefast emitted warnings that drew my attention to
{Shadow,BorderImage}ParseContext::failed(). It turned out that these
methods were actually correct, but rather confusing. "failed" really
meant "abort and clean up" rather than "did you fail?", which was
unclear. However, once I figured that out, the "and clean up" part was
still a bit confusing, because all failed() did was to set a flag that
would later cause the ParseContext's members to be deleted in the
destructor. To clear this up, I've gotten rid of the failed() method
altogether. It always returned false, so I've replaced all calls to
it with the value false.

I also noticed that the lifetime management of the ParseContexts'
members was in all cases confusing, and in some cases wrong. The
m_border{Top,Right,Bottom,Left} members of BorderImageParseContext
were leaked whenever a border-image property was successfully parsed.
I fixed that by holding these members in OwnPtrs. The
CSSPrimitiveValue members of {Shadow,BorderImage}ParseContext, which
inherit from Shared, were being explicitly deleted, which is not a
safe way to manage the lifetime of objects that inherit from Shared.
To fix this, I put those members inside RefPtrs. These two changes
allowed me to remove the destructors entirely.

Reviewed by Darin.

All regression tests pass.

  • css/cssparser.cpp:

(WebCore::ShadowParseContext::commitValue): Use .release() to avoid
ref-count churn.
(WebCore::ShadowParseContext::commitLength): Use a RefPtr for the new value to
avoid a leak.
(WebCore::CSSParser::parseShadow): Use 'false' instead of
'context.failed()', and use .release() to avoid ref-count churn.
(WebCore::BorderImageParseContext::commitWidth): Updated to use
OwnPtr.
(WebCore::CSSParser::parseBorderImage): Use 'false' instead of
'context.failed'.

22:18 Changeset [23924] by oliver
  • 2 edits in trunk/WebKit

Reviewed by Alexey.

Fix for <rdar://problem/5306210> Some events are still passed to WebCore despite being handled by the IM
http://bugs.webkit.org/show_bug.cgi?id=14457

We have to assume that the IM will consume all events, so we remove the dependency
on -[WebHTMLView hasMarkedText].

  • WebView/WebHTMLView.mm: (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]):
21:13 Changeset [23923] by andersca
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan.

<rdar://problem/5297146>
Crash in Mail at WebCore::Frame::setUserStyleSheetLocation (reproducible w/ particular message)


  • loader/Cache.cpp: (WebCore::Cache::requestResource): Only insert the resource in the LRU list if the cache is enabled.


(WebCore::Cache::insertInLRUList):
(WebCore::Cache::resourceAccessed):
Assert that the resource is in the cache.

19:26 Changeset [23922] by darin
  • 3 edits
    4 deletes in trunk
  • css/tokenizer.flex: Rolled out the fix for 14453. The layout test wasn't passing. We'll try again.
17:51 Changeset [23921] by kevino
  • 8 edits in branches/wx-port-alpha/trunk

Restore the Windows build after libpng/libjpeg and Python extension changes.

17:44 Changeset [23920] by aroben
  • 2 edits in trunk/WebCore

Fix a crash in ~PluginViewWin()

This crash was introduced in r23827.

Reviewed by Anders.

Fixes dom/html/level2/html/HTMLAnchorElement01.html

  • plugins/win/PluginViewWin.cpp:

(WebCore::PluginViewWin::~PluginViewWin): Allow m_plugin to be null.

16:47 Changeset [23919] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

Regression test for:
http://bugs.webkit.org/show_bug.cgi?id=14453
REGRESSION: www.nzherald.co.nz almost all the formating is gone

  • css2.1/hex-color-regression-expected.checksum: Added.
  • css2.1/hex-color-regression-expected.png: Added.
  • css2.1/hex-color-regression-expected.txt: Added.
  • css2.1/hex-color-regression.html: Added.

WebCore:

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=14453
REGRESSION: www.nzherald.co.nz almost all the formating is gone


  • css/tokenizer.flex: Allow hex colors with 2, 4, or 5 hex digits.
16:22 Changeset [23918] by darin
  • 2 edits in trunk/LayoutTests

Fixed a no-SVG test failure by removing a node that was affecting the test results differently
depending on whether SVG support was compiled in or not.

  • fast/xpath/namespace-vs-predicate.xhtml: Remove the r_00 node at the end of the test.
16:01 Changeset [23917] by aroben
  • 2 edits in trunk/WebKitTools

Fix some paths to make http tests work again on Windows

Rubberstamped by Sam.

  • Scripts/run-webkit-tests:
10:38 Changeset [23916] by weinig
  • 15 edits in trunk

LayoutTests:

Reviewed by Oliver.

Third round of implicit 64-32 bit conversion errors fixes.
<rdar://problem/5292262>

getFloatValue() used to return a double and now returns a float for a small
loss of precision.

  • fast/css/getFloatValueForUnit-expected.checksum:
  • fast/css/getFloatValueForUnit-expected.png:
  • fast/css/getFloatValueForUnit-expected.txt:
  • fast/css/getFloatValueForUnit.html:

WebCore:

Reviewed by Oliver.

Third round of implicit 64-32 bit conversion errors fixes.
<rdar://problem/5292262>

  • Use new CSSPrimitiveValue::getDoubleValue() and CSSPrimitiveValue::getIntValue() methods instead of CSSPrimitiveValue::getFloatValue() where appropriate.
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::computeLengthInt): (WebCore::CSSPrimitiveValue::computeLengthIntForLength): (WebCore::CSSPrimitiveValue::computeLengthShort): (WebCore::CSSPrimitiveValue::computeLengthFloat): (WebCore::CSSPrimitiveValue::computeLengthDouble): (WebCore::CSSPrimitiveValue::getDoubleValue):
  • css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::getDoubleValue): (WebCore::CSSPrimitiveValue::getFloatValue): (WebCore::CSSPrimitiveValue::getIntValue):
  • css/Counter.h: (WebCore::Counter::listStyleNumber):
  • css/MediaQueryEvaluator.cpp: (WebCore::parseAspectRatio):
  • css/cssparser.cpp: (WebCore::BorderImageParseContext::commitBorderImage):
  • css/cssstyleselector.cpp: (WebCore::convertToLength): (WebCore::applyCounterList): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::mapBackgroundSize): (WebCore::CSSStyleSelector::mapBackgroundXPosition): (WebCore::CSSStyleSelector::mapBackgroundYPosition):
  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::parseMappedAttribute):
  • ksvg2/css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::KSVGPainterFactory::cssPrimitiveToLength): (WebCore::KSVGPainterFactory::dashArrayFromRenderingStyle):
10:23 Changeset [23915] by darin
  • 1 edit
    2 moves in trunk/LayoutTests

Fixed a no-SVG test failure by moving a test that requires SVG into the svg directory.

  • fast/dom/svg-element-attribute-js-null-expected.txt: Removed.
  • fast/dom/svg-element-attribute-js-null.xhtml: Removed.
  • svg/dom/svg-element-attribute-js-null-expected.txt: Copied from fast/dom/svg-element-attribute-js-null-expected.txt.
  • svg/dom/svg-element-attribute-js-null.xhtml: Copied from fast/dom/svg-element-attribute-js-null.xhtml.
10:05 Changeset [23914] by darin
  • 1 edit
    1 add in trunk/LayoutTests

Added a missing file for the test for <rdar://problem/5303567> REGRESSION: XMLHttpRequest.responseXML

  • fast/loader/resources/plist.app: Added. Just some random XML file I found somewhere; seems to make the test succeed instead of failing every time!
08:52 Changeset [23913] by bdash
  • 3 edits
    2 deletes in trunk

Roll out r23911 as it introduced two layout test failures.

07:26 Changeset [23912] by bdash
  • 7 edits in trunk

2007-07-01 Pamela Greene <pamg.bugs@gmail.com>

Reviewed by Darin.

Fix for <http://bugs.webkit.org/show_bug.cgi?id=14320>
Bug 14320: <canvas> gradient stops at identical offsets are applied in the wrong order
<rdar://problem/5290084>

Use std::stable_sort() instead of qsort() to sort gradient stops.
Adjust the comparison function accordingly.

  • html/CanvasGradient.cpp: (WebCore::compareStops): (WebCore::CanvasGradient::findStop):

2007-07-01 Pamela Greene <pamg.bugs@gmail.com>

Reviewed by Darin.

Tests for <http://bugs.webkit.org/show_bug.cgi?id=14320>
Bug 14320: <canvas> gradient stops at identical offsets are applied in the wrong order
<rdar://problem/5290084>

Add tests for various combinations of stops, including multiple stops at
the same offsets, sorted and unsorted. Update results accordingly.

  • fast/canvas/fillrect_gradient-expected.checksum:
  • fast/canvas/fillrect_gradient-expected.png:
  • fast/canvas/fillrect_gradient-expected.txt:
  • fast/canvas/fillrect_gradient.html:
07:20 Changeset [23911] by bdash
  • 3 edits
    2 adds in trunk

2007-07-01 MorganL <morganl.webkit@yahoo.com>

Reviewed by Darin.

Fix for http://bugs.webkit.org/show_bug.cgi?id=14448
HTMLObjectElement::data should return an absolute URL

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::isImageType): (WebCore::HTMLObjectElement::data):

2007-07-01 MorganL <morganl.webkit@yahoo.com>

Reviewed by Darin.

Tests for http://bugs.webkit.org/show_bug.cgi?id=14448
HTMLObjectElement::data should return an absolute URL

  • fast/dom/object-data-absurl-expected.txt: Added.
  • fast/dom/object-data-absurl.html: Added.
07:17 Changeset [23910] by bdash
  • 2 edits in trunk/WebCore

2007-07-01 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Darin.

m_usesPageCache was not initialized. As the b/f cache is only
implemented in the Mac port and WebView.mm is taking care of calling
Settings::setUsesPageCache I decided to make it false by default.

  • page/Settings.cpp: (WebCore::Settings::Settings): m_usesPageCache was not initialized
07:16 Changeset [23909] by bdash
  • 2 edits in trunk/WebCore

2007-07-01 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Darin.

Inherited- and NonInheritedFlags is a bit field. But for comparsion
the other part of the union _iflags/_niflags is used for comparions.
This will compare 5 uninitialized bits of _iflags and 22 of _niflags.
Make sure the unused bits have a specified value.

  • ksvg2/css/SVGRenderStyle.h: (WebCore::SVGRenderStyle::setBitDefaults): Make sure the unused bits have a value as well.
07:14 Changeset [23908] by bdash
  • 2 edits in trunk/WebKitSite

2007-07-01 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

  • coding/lgpl-license.html:
Note: See TracTimeline for information about the timeline view.