Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Sep 16, 2007:

5:09 PM Changeset in webkit [25591] by weinig

• 4 edits
  2 adds in trunk

WebCore:

Reviewed by Maciej.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=14693
document.width/height doesn't force layout

Test: fast/dom/document-width-height-force-layout.html

• html/HTMLDocument.cpp: (WebCore::HTMLDocument::width): Force layout. (WebCore::HTMLDocument::height): ditto.
• html/HTMLDocument.h:

LayoutTests:

Reviewed by Maciej.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=14693

• fast/dom/document-width-height-force-layout-expected.txt: Added.
• fast/dom/document-width-height-force-layout.html: Added.

1:52 PM Changeset in webkit [25590] by zecke

• 3 edits in trunk/WebCore

2007-09-14 Sven Herzberg <​sven@imendio.com>

Reviewed by George.

Don't maintain obsolete code, fixes:
​http://bugs.webkit.org/show_bug.cgi?id=15215

• platform/gdk/FontPlatformData.cpp: remove static FontPlatformData::list() (isn't used at any place)

12:58 PM Changeset in webkit [25589] by zecke

• 4 edits in trunk

WebCore:

2007-09-15 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Mark.

Use the new WebCore::String::fromUTF8 function to create
the labels.

• platform/gdk/LocalizedStringsGdk.cpp: (WebCore::submitButtonDefaultLabel): (WebCore::inputElementAltText): (WebCore::resetButtonDefaultLabel): (WebCore::searchableIndexIntroduction): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (WebCore::contextMenuItemTagOpenLinkInNewWindow): (WebCore::contextMenuItemTagDownloadLinkToDisk): (WebCore::contextMenuItemTagCopyLinkToClipboard): (WebCore::contextMenuItemTagOpenImageInNewWindow): (WebCore::contextMenuItemTagDownloadImageToDisk): (WebCore::contextMenuItemTagCopyImageToClipboard): (WebCore::contextMenuItemTagOpenFrameInNewWindow): (WebCore::contextMenuItemTagCopy): (WebCore::contextMenuItemTagGoBack): (WebCore::contextMenuItemTagGoForward): (WebCore::contextMenuItemTagStop): (WebCore::contextMenuItemTagReload): (WebCore::contextMenuItemTagCut): (WebCore::contextMenuItemTagPaste): (WebCore::contextMenuItemTagNoGuessesFound): (WebCore::contextMenuItemTagIgnoreSpelling): (WebCore::contextMenuItemTagLearnSpelling): (WebCore::contextMenuItemTagSearchWeb): (WebCore::contextMenuItemTagLookUpInDictionary): (WebCore::contextMenuItemTagOpenLink): (WebCore::contextMenuItemTagIgnoreGrammar): (WebCore::contextMenuItemTagSpellingMenu): (WebCore::contextMenuItemTagShowSpellingPanel): (WebCore::contextMenuItemTagCheckSpelling): (WebCore::contextMenuItemTagCheckSpellingWhileTyping): (WebCore::contextMenuItemTagCheckGrammarWithSpelling): (WebCore::contextMenuItemTagFontMenu): (WebCore::contextMenuItemTagBold): (WebCore::contextMenuItemTagItalic): (WebCore::contextMenuItemTagUnderline): (WebCore::contextMenuItemTagOutline): (WebCore::contextMenuItemTagWritingDirectionMenu): (WebCore::contextMenuItemTagDefaultDirection): (WebCore::contextMenuItemTagLeftToRight): (WebCore::contextMenuItemTagRightToLeft): (WebCore::contextMenuItemTagInspectElement): (WebCore::searchMenuNoRecentSearchesText): (WebCore::searchMenuRecentSearchesText): (WebCore::searchMenuClearRecentSearchesText):

WebKit:
2007-09-15 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Mark.

Use the new WebCore::String::fromUTF8 function to convert
from the Gtk+ representation of a string to WebCore::String.

• WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::runJavaScriptPrompt):

12:58 PM Changeset in webkit [25588] by zecke

• 3 edits in trunk/WebCore

2007-09-15 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Mark.

Add WebCore::String::fromUTF8 to convert from UTF-8
to a WebCore::String. This is meant to be used by
the Gtk+ port and the signature and implementation
is similiar to the one of DeprecatedString.

• platform/PlatformString.h:
• platform/String.cpp: (WebCore::String::fromUTF8):

12:58 PM Changeset in webkit [25587] by zecke

• 3 edits
  1 add in trunk/WebCore

2007-09-13 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Anders.

Implement the fileExists and deleteFile functions
using glib.

• WebCore.pro:
• platform/gdk/FileSystemGdk.cpp: Added. (WebCore::fileExists):
• platform/gdk/TemporaryLinkStubs.cpp:

10:04 AM Changeset in webkit [25586] by harrison

• 14 edits in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/5472125> REGRESSION (9A535-9A548): No VO cursor shown when navigating in a mail message body

The problem was that the visible units code was mishandling non-editable content, generating null
VisiblePositions instead of the actual boundary VisiblePositions.

Updated tests:

• fast/dom/Window/window-xy-properties-expected.txt:
• fast/dom/plugin-attributes-enumeration-expected.txt:
• fast/events/onerror-bubbling-expected.txt:
• fast/events/related-target-expected.txt:
• fast/forms/select-namedItem-expected.txt:
• fast/table/incomplete-table-in-fragment-2-expected.txt:
• fast/table/incomplete-table-in-fragment-hang-expected.txt:
• fast/table/large-rowspan-crash-expected.txt:
• plugins/embed-attributes-setting-expected.txt:

Source Changes:

• editing/VisiblePosition.cpp: (WebCore::VisiblePosition::next): (WebCore::VisiblePosition::previous): (WebCore::VisiblePosition::honorEditableBoundaryAtOrBefore): (WebCore::VisiblePosition::honorEditableBoundaryAtOrAfter): Rename firstEditablePositionAtOrAfter to honorEditableBoundaryAtOrAfter. Rename firstEditablePositionAtOrBefore to honorEditableBoundaryAtOrBefore. Changed these two functions to handle non-editable positions.

• editing/VisiblePosition.h:
• editing/visible_units.cpp: (WebCore::previousWordPosition): (WebCore::nextWordPosition): (WebCore::positionAvoidingFirstPositionInTable): (WebCore::startPositionForLine): (WebCore::startOfLine): (WebCore::endOfLine): (WebCore::previousSentencePosition): (WebCore::nextSentencePosition): Rename firstEditablePositionAtOrAfter to honorEditableBoundaryAtOrAfter. Rename firstEditablePositionAtOrBefore to honorEditableBoundaryAtOrBefore. Also, startOfLine() now calls positionAvoidingFirstPositionInTable() in the empty block early return case. positionAvoidingFirstPositionInTable() was the logic startOfLine() used in the normal case. Now in a reusable function.

LayoutTests:

Reviewed by Darin.

Updated for
<rdar://problem/5472125> REGRESSION (9A535-9A548): No VO cursor shown when navigating in a mail message body

Newlines are now emitted when the first content of document is block element without text (like an empty table
or an HR), followed by text.

• fast/dom/Window/window-xy-properties-expected.txt:
• fast/dom/plugin-attributes-enumeration-expected.txt:
• fast/events/onerror-bubbling-expected.txt:
• fast/events/related-target-expected.txt:
• fast/forms/select-namedItem-expected.txt:
• fast/table/incomplete-table-in-fragment-2-expected.txt:
• fast/table/incomplete-table-in-fragment-hang-expected.txt:
• fast/table/large-rowspan-crash-expected.txt:
• plugins/embed-attributes-setting-expected.txt:

Sep 15, 2007:

1:45 PM Changeset in webkit [25585] by darin

• 2 edits in trunk/WebKit

Reviewed by John Sullivan.

• fix <rdar://problem/5391540> REGRESSION: Can't drag images from Safari to applications in the dock (Tiger Preview, others in Leopard)

• Misc/WebNSPasteboardExtras.mm: (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]): Re-implement code here that has been missing for the last couple of years since we did some image refactoring. Was pretty easy now that we can freely call C++ code in WebKit.

10:58 AM Changeset in webkit [25584] by darin

• 2 edits in trunk/JavaScriptCore

• fix Mac build

• JavaScriptCore.exp: Export WTFLogVerbose.

8:34 AM Changeset in webkit [25583] by bdash

• 2 edits in trunk/WebKitTools

2007-09-15 Mark Rowe <​mrowe@apple.com>

Build fix for DumpRenderTree.

• DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Reinstate -Wno-deprecated-declarations on DumpRenderTree.mm.

Sep 14, 2007:

7:41 PM Changeset in webkit [25582] by oliver

• 2 edits in trunk/WebCore

Reviewed by Adam.

Mac doesn't have any kind of not implemented macro, so we'll actually implement
fileSize.

• platform/mac/FileSystemMac.mm: (WebCore::fileSize):

7:26 PM Changeset in webkit [25581] by weinig

• 5 edits
  2 adds in trunk/WebKitTools

Rubber stamped by Adam Roben.

Split the WaitUntilDoneDelegate into a UIDelegate and a FrameLoadDelegate.

• The UIDelegate was put into a new file while the FrameLoadDelegate was kept in the WaitUntilDoneDelegate file for the time being.

• DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (main):
• DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
• DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Added. (UIDelegate::QueryInterface): (UIDelegate::AddRef): (UIDelegate::Release): (UIDelegate::hasCustomMenuImplementation): (UIDelegate::setFrame): (UIDelegate::webViewFrame): (UIDelegate::runJavaScriptAlertPanelWithMessage): (UIDelegate::webViewAddMessageToConsole): (UIDelegate::doDragDrop): (UIDelegate::webViewGetDlgCode):
• DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Added. (UIDelegate::UIDelegate): (UIDelegate::createWebViewWithRequest): (UIDelegate::webViewShow): (UIDelegate::webViewClose): (UIDelegate::webViewFocus): (UIDelegate::webViewUnfocus): (UIDelegate::webViewFirstResponder): (UIDelegate::makeFirstResponder): (UIDelegate::setStatusText): (UIDelegate::webViewStatusText): (UIDelegate::webViewAreToolbarsVisible): (UIDelegate::setToolbarsVisible): (UIDelegate::webViewIsStatusBarVisible): (UIDelegate::setStatusBarVisible): (UIDelegate::webViewIsResizable): (UIDelegate::setResizable): (UIDelegate::setContentRect): (UIDelegate::webViewContentRect): (UIDelegate::runJavaScriptConfirmPanelWithMessage): (UIDelegate::runJavaScriptTextInputPanelWithPrompt): (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): (UIDelegate::runOpenPanelForFileButtonWithResultListener): (UIDelegate::mouseDidMoveOverElement): (UIDelegate::contextMenuItemsForElement): (UIDelegate::validateUserInterfaceItem): (UIDelegate::shouldPerformAction): (UIDelegate::dragDestinationActionMaskForDraggingInfo): (UIDelegate::willPerformDragDestinationAction): (UIDelegate::dragSourceActionMaskForPoint): (UIDelegate::willPerformDragSourceAction): (UIDelegate::contextMenuItemSelected): (UIDelegate::trackCustomPopupMenu): (UIDelegate::measureCustomMenuItem): (UIDelegate::drawCustomMenuItem): (UIDelegate::addCustomMenuDrawingData): (UIDelegate::cleanUpCustomMenuDrawingData): (UIDelegate::canTakeFocus): (UIDelegate::takeFocus): (UIDelegate::registerUndoWithTarget): (UIDelegate::removeAllActionsWithTarget): (UIDelegate::setActionTitle): (UIDelegate::undo): (UIDelegate::redo): (UIDelegate::canUndo): (UIDelegate::canRedo): (UIDelegate::webViewResizerRect): (UIDelegate::webViewDrawResizer): (UIDelegate::webViewScrolled): (UIDelegate::webViewShouldInterruptJavaScript): (UIDelegate::webViewReceivedFocus): (UIDelegate::webViewLostFocus):
• DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: (FrameLoadDelegate::QueryInterface): (FrameLoadDelegate::AddRef): (FrameLoadDelegate::Release): (FrameLoadDelegate::didStartProvisionalLoadForFrame): (FrameLoadDelegate::didCommitLoadForFrame): (FrameLoadDelegate::didReceiveTitle): (FrameLoadDelegate::processWork): (processWorkTimer): (FrameLoadDelegate::locationChangeDone): (FrameLoadDelegate::didFinishLoadForFrame): (FrameLoadDelegate::didFailLoadWithError): (FrameLoadDelegate::windowScriptObjectAvailable):
• DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: (FrameLoadDelegate::FrameLoadDelegate):

6:43 PM Changeset in webkit [25580] by thatcher

• 2 edits in trunk/WebCore

Initialize m_dialogArguments to 0. Fixes the newly crashing layout tests.

• bindings/js/kjs_window.cpp: (KJS::WindowPrivate::WindowPrivate):

6:25 PM Changeset in webkit [25579] by oliver

• 3 edits in trunk/WebCore

<rdar://problem/5483632> File system operation wrappers are unimplemented on windows

Implement Windows versions of fileExists and deleteFile.
Also corrects fileSize to use a 64-bit version of stat.

• platform/win/FileSystemWin.cpp: (WebCore::fileSize): Renamed argument to be more consistent with others. And converted to _stat32i64 to allow 64-bit filesizes (WebCore::fileExists): (WebCore::deleteFile):
• platform/win/TemporaryLinkStubs.cpp:

6:01 PM Changeset in webkit [25578] by weinig

• 3 edits
  1 move
  1 add in trunk/WebKitTools

Reviewed by Kevin McCullough.

Move mac specific globals in to mac/DumpRenderTreeMac.h

• DumpRenderTree/DumpRenderTree.h:
• DumpRenderTree/DumpRenderTree.mm: Removed.
• DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
• DumpRenderTree/mac/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.mm.
• DumpRenderTree/mac/DumpRenderTreeMac.h: Added.

5:10 PM Changeset in webkit [25577] by oliver

• 7 edits
  1 copy in trunk/WebCore

Need to use _wstat instead of _stat to stat files on windows

_stat doesn't handle multibyte character sequences, unless (afaict)
the current codepage supports them, and then it uses the current
codepage. In order to correctly handle multibyte characters in a
file path we have to use _wstat.

In deference to the fact that the CF implementation may be used on
platforms other than windows i've added fileSize to the FileSystem
helper functions, and added a windows impl.

4:53 PM Changeset in webkit [25576] by thatcher

• 6 edits
  4 adds in trunk

WebCore:

Reviewed by Sam.

<rdar://problem/5472970> REGRESSION (r24276): TinyMCE popups show an empty window with no content

Accessing the document of a window before the load finished would cause the window
object to hold onto the initial empty document, and never switch over to the real document
once the load finished. This regression was caused by r24276 which added a check to prevent
clearing the window object when the load finished. The absence of this clear allowed the
dialogArguments set with showModalDialog to persist on the window after the load. However,
not clearing the window would keep other properties (and the empty document object) around.

So the fix is to store away the dialog arguments that were passed to showModalDialog and
put them back on the window object in the dialogArguments property each time
the window is cleared.

• bindings/js/kjs_window.cpp: (KJS::createWindow): No longer put dialogArguments on the window here. (KJS::showModalDialog): Put dialogArguments on the window and call setDialogArgumentsAndReturnValueSlot to remember the arguments. (KJS::Window::clear): Put m_dialogArguments back on the window as dialogArguments. (KJS::WindowFunc::callAsFunction): Call the new setDialogArgumentsAndReturnValue. (KJS::Window::setDialogArgumentsAndReturnValue): Store the arguments in m_dialogArguments.
• bindings/js/kjs_window.h: Rename setReturnValueSlot to setDialogArgumentsAndReturnValueSlot.
• manual-tests/modal-dialog-arguments.html: Confirmed that this test still passes.

Reverted r24276 which was all the changes in FrameLoader.cpp and FrameLoader.h.

• loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): Remove m_shouldClearWindowProperties. (WebCore::FrameLoader::createWindow): Remove the call to setShouldClearWindowProperties. (WebCore::FrameLoader::clear): No longer check m_shouldClearWindowProperties, clear the window whenever clearWindowProperties is set. (WebCore::FrameLoader::begin): Remove m_shouldClearWindowProperties. (WebCore::FrameLoader::open): Ditto.
• loader/FrameLoader.h: Remove m_shouldClearWindowProperties.

LayoutTests:

Reviewed by Sam.

<rdar://problem/5472970> REGRESSION (r24276): TinyMCE popups show an empty window with no content

• fast/dom/Document/early-document-access.html: Added.
• fast/dom/Document/resources: Added.
• fast/dom/Document/resources/early-document-access-popup.html: Added.

3:48 PM Changeset in webkit [25575] by beidson

• 2 edits in trunk/WebCore

Build fixes work best when they fix *all* platforms

3:40 PM Changeset in webkit [25574] by beidson

• 3 edits in trunk/WebKitTools

Rubberstamped by Weinig

You know, Sam, some of us use case-sensitve filesystems...

• DumpRenderTree/DumpRenderTree.h:
• DumpRenderTree/mac/UIDelegate.mm:

3:13 PM Changeset in webkit [25573] by kmccullo

• 2 edits in trunk/JavaScriptCore

Reviewed by Sam.

• Copy JSRetainPtr to include folder.

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

2:39 PM Changeset in webkit [25572] by beidson

• 5 edits in trunk/WebCore

Roll out my previous build fix and just make the stupid thing inline
(I knew there was something easier but oh boy, no coffee yet... weinig?)

2:27 PM Changeset in webkit [25571] by bdash

• 4 edits in trunk/WebKit

2007-09-14 Mark Rowe <​mrowe@apple.com>

Build fix for Tiger.

• WebView/WebArchive.m: (-[WebArchive initWithCoder:]): Use @catch(id) rather than @catch(...).
• WebView/WebPreferences.m: (-[WebPreferences initWithCoder:]): Ditto.
• WebView/WebResource.mm: (-[WebResource initWithCoder:]): Ditto. (-[WebResource _initWithPropertyList:]): Ditto.

2:09 PM Changeset in webkit [25570] by beidson

• 2 edits in trunk/WebCore

Rubberstamped by Mark Rowe

Add the logging channel I just created to the initialize list on Mac

• platform/mac/LoggingMac.mm: (WebCore::InitializeLoggingChannelsIfNecessary):

2:04 PM Changeset in webkit [25569] by beidson

• 5 edits in trunk/WebCore

Build fix

That method can't go in the header, apparently

• platform/Threading.h:
• platform/gdk/TemporaryLinkStubs.cpp: (WebCore::initializeThreading):
• platform/mac/Threading.mm: (WebCore::initializeThreading):
• platform/qt/TemporaryLinkStubs.cpp: (WebCore::initializeThreading):

1:43 PM Changeset in webkit [25568] by beidson

• 7 edits
  1 add in trunk/WebCore

Reviewed by Darin

-Add callOnMainThread() implementation to Windows

• WebCore.vcproj/WebCore.vcproj:

• loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::open): Call initializeThreading() from the main thread before kicking off the secondary thread

• platform/Logging.cpp: Added Threading logging channel (WebCore::):
• platform/Logging.h: Ditto

• platform/Threading.h: (WebCore::initializeThreading): Added - only needs Windows impl for now
• platform/win/ThreadingWin.cpp: Added. (WebCore::callFunctionsOnMainThread): Calls each function currently in the main-thread queue (WebCore::ThreadingWindowWndProc): (WebCore::initializeThreading): Creates a message-only window to use for callOnMainThread() (WebCore::callOnMainThread): Queues the function to be called and posts a message to the threading window such that the function-call-queue can be addressed

• platform/win/TemporaryLinkStubs.cpp: (WebCore::signedPublicKeyAndChallengeString):

1:42 PM Changeset in webkit [25567] by darin

• 5 edits in trunk/WebKit

Reviewed by Geoff Garen and Tim Hatcher.

• fixed <rdar://problem/5482745> initFromCoder: and initWithPropertyList: functions should guard against incorrect types

• WebView/WebArchive.m: (isArrayOfClass): Added helper function. (-[WebArchive _initWithPropertyList:]): Tweaked function to remove the need for a type cast. (-[WebArchive initWithCoder:]): Added type checking for the main resource, subresources array, and subframe archives array. Also replaced NS_DURING with @try.
• WebView/WebPreferences.m: (-[WebPreferences initWithCoder:]): Added type checking for the identifier and the values dictionary, including ensuring that it's a mutable dictionary.
• WebView/WebResource.mm: (-[WebResource initWithCoder:]): Added type checking for all the fields. (-[WebResource _initWithPropertyList:]): Added type checking for the NSURLResponse.

• WebKit.exp: Removed accidentally exported internal symbol; I checked and it's not used anywhere.

12:37 PM Changeset in webkit [25566] by weinig

• 6 edits
  30 moves
  1 add in trunk/WebKitTools

Rubber stamped by Adam Roben.

• Move dump state data to LayoutTestContoller and add getter/setters to accommodate.
• Move mac specific DumpRenderTree files to DumpRenderTree/mac

• DumpRenderTree/AppleScriptController.h: Removed.
• DumpRenderTree/AppleScriptController.m: Removed.
• DumpRenderTree/DumpRenderTree.h:
• DumpRenderTree/DumpRenderTree.mm: (startJavaScriptThreads): (stopJavaScriptThreads): (activateAhemFont): (setDefaultColorProfileToRGB): (makeLargeMallocFailSilently): (dumpFrameScrollPosition): (dumpFramesAsText): (dump): (runTest): (-[DumpRenderTreeWindow isKeyWindow]):
• DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
• DumpRenderTree/DumpRenderTreeDraggingInfo.h: Removed.
• DumpRenderTree/DumpRenderTreeDraggingInfo.m: Removed.
• DumpRenderTree/EditingDelegate.h: Removed.
• DumpRenderTree/EditingDelegate.m: Removed.
• DumpRenderTree/EventSendingController.h: Removed.
• DumpRenderTree/EventSendingController.m: Removed.
• DumpRenderTree/FrameLoadDelegate.h: Removed.
• DumpRenderTree/FrameLoadDelegate.mm: Removed.
• DumpRenderTree/GCController.mm: Removed.
• DumpRenderTree/ImageDiff.m: Removed.
• DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (dumpAsTextCallback): (dumpBackForwardListCallback): (dumpChildFramesAsTextCallback): (dumpChildFrameScrollPositionsCallback): (dumpDOMAsWebArchiveCallback): (dumpEditingCallbacksCallback): (dumpFrameLoadCallbacksCallback): (dumpResourceLoadCallbacksCallback): (dumpSelectionRectCallback): (dumpSourceAsWebArchiveCallback): (dumpTitleChangesCallback): (repaintSweepHorizontallyCallback): (setCallCloseOnWebViewsCallback): (setCanOpenWindowsCallback): (setCloseRemainingWindowsWhenCompleteCallback): (testRepaintCallback): (addFileToPasteboardOnDragCallback): (waitUntilDoneCallback):
• DumpRenderTree/LayoutTestController.h: (LayoutTestController::dumpAsText): (LayoutTestController::setDumpAsText): (LayoutTestController::dumpBackForwardList): (LayoutTestController::setDumpBackForwardList): (LayoutTestController::dumpChildFrameScrollPositions): (LayoutTestController::setDumpChildFrameScrollPositions): (LayoutTestController::dumpChildFramesAsText): (LayoutTestController::setDumpChildFramesAsText): (LayoutTestController::dumpDOMAsWebArchive): (LayoutTestController::setDumpDOMAsWebArchive): (LayoutTestController::dumpSelectionRect): (LayoutTestController::setDumpSelectionRect): (LayoutTestController::dumpSourceAsWebArchive): (LayoutTestController::setDumpSourceAsWebArchive): (LayoutTestController::dumpTitleChanges): (LayoutTestController::setDumpTitleChanges): (LayoutTestController::dumpEditingCallbacks): (LayoutTestController::setDumpEditingCallbacks): (LayoutTestController::dumpResourceLoadCallbacks): (LayoutTestController::setDumpResourceLoadCallbacks): (LayoutTestController::dumpFrameLoadCallbacks): (LayoutTestController::setDumpFrameLoadCallbacks): (LayoutTestController::addFileToPasteboardOnDrag): (LayoutTestController::setAddFileToPasteboardOnDrag): (LayoutTestController::callCloseOnWebViews): (LayoutTestController::setCallCloseOnWebViews): (LayoutTestController::canOpenWindows): (LayoutTestController::setCanOpenWindows): (LayoutTestController::closeRemainingWindowsWhenComplete): (LayoutTestController::setCloseRemainingWindowsWhenComplete): (LayoutTestController::testRepaint): (LayoutTestController::setTestRepaint): (LayoutTestController::testRepaintSweepHorizontally): (LayoutTestController::setTestRepaintSweepHorizontally): (LayoutTestController::waitToDump): (LayoutTestController::windowIsKey):
• DumpRenderTree/LayoutTestControllerMac.mm: Removed.
• DumpRenderTree/NavigationController.h: Removed.
• DumpRenderTree/NavigationController.m: Removed.
• DumpRenderTree/ObjCController.h: Removed.
• DumpRenderTree/ObjCController.m: Removed.
• DumpRenderTree/ObjCPlugin.h: Removed.
• DumpRenderTree/ObjCPlugin.m: Removed.
• DumpRenderTree/ObjCPluginFunction.h: Removed.
• DumpRenderTree/ObjCPluginFunction.m: Removed.
• DumpRenderTree/PolicyDelegate.h: Removed.
• DumpRenderTree/PolicyDelegate.m: Removed.
• DumpRenderTree/ResourceLoadDelegate.h: Removed.
• DumpRenderTree/ResourceLoadDelegate.m: Removed.
• DumpRenderTree/TextInputController.h: Removed.
• DumpRenderTree/TextInputController.m: Removed.
• DumpRenderTree/UIDelegate.h: Removed.
• DumpRenderTree/UIDelegate.mm: Removed.
• DumpRenderTree/WorkQueueItemMac.mm: Removed.
• DumpRenderTree/mac: Added.
• DumpRenderTree/mac/AppleScriptController.h: Copied from DumpRenderTree/AppleScriptController.h.
• DumpRenderTree/mac/AppleScriptController.m: Copied from DumpRenderTree/AppleScriptController.m.
• DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.h.
• DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.m.
• DumpRenderTree/mac/EditingDelegate.h: Copied from DumpRenderTree/EditingDelegate.h.
• DumpRenderTree/mac/EditingDelegate.mm: Copied from DumpRenderTree/EditingDelegate.m. (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]): (-[EditingDelegate webView:shouldEndEditingInDOMRange:]): (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]): (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]): (-[EditingDelegate webView:shouldDeleteDOMRange:]): (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]): (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]): (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]): (-[EditingDelegate webViewDidBeginEditing:]): (-[EditingDelegate webViewDidChange:]): (-[EditingDelegate webViewDidEndEditing:]): (-[EditingDelegate webViewDidChangeTypingStyle:]): (-[EditingDelegate webViewDidChangeSelection:]):
• DumpRenderTree/mac/EventSendingController.h: Copied from DumpRenderTree/EventSendingController.h.
• DumpRenderTree/mac/EventSendingController.mm: Copied from DumpRenderTree/EventSendingController.m.
• DumpRenderTree/mac/FrameLoadDelegate.h: Copied from DumpRenderTree/FrameLoadDelegate.h.
• DumpRenderTree/mac/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.mm. (-[FrameLoadDelegate init]): (-[FrameLoadDelegate dealloc]): (-[FrameLoadDelegate processWork:]): (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): (-[FrameLoadDelegate webView:didCommitLoadForFrame:]): (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]): (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]): (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]): (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]): (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]): (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]): (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]): (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]): (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]): (-[FrameLoadDelegate webView:willCloseFrame:]): (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]): (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
• DumpRenderTree/mac/GCControllerMac.mm: Copied from DumpRenderTree/GCController.mm.
• DumpRenderTree/mac/ImageDiff.m: Copied from DumpRenderTree/ImageDiff.m.
• DumpRenderTree/mac/LayoutTestControllerMac.mm: Copied from DumpRenderTree/LayoutTestControllerMac.mm. (LayoutTestController::notifyDone): (LayoutTestController::setWindowIsKey): (LayoutTestController::setWaitToDump):
• DumpRenderTree/mac/NavigationController.h: Copied from DumpRenderTree/NavigationController.h.
• DumpRenderTree/mac/NavigationController.m: Copied from DumpRenderTree/NavigationController.m.
• DumpRenderTree/mac/ObjCController.h: Copied from DumpRenderTree/ObjCController.h.
• DumpRenderTree/mac/ObjCController.m: Copied from DumpRenderTree/ObjCController.m.
• DumpRenderTree/mac/ObjCPlugin.h: Copied from DumpRenderTree/ObjCPlugin.h.
• DumpRenderTree/mac/ObjCPlugin.m: Copied from DumpRenderTree/ObjCPlugin.m.
• DumpRenderTree/mac/ObjCPluginFunction.h: Copied from DumpRenderTree/ObjCPluginFunction.h.
• DumpRenderTree/mac/ObjCPluginFunction.m: Copied from DumpRenderTree/ObjCPluginFunction.m.
• DumpRenderTree/mac/PolicyDelegate.h: Copied from DumpRenderTree/PolicyDelegate.h.
• DumpRenderTree/mac/PolicyDelegate.mm: Copied from DumpRenderTree/PolicyDelegate.m.
• DumpRenderTree/mac/ResourceLoadDelegate.h: Copied from DumpRenderTree/ResourceLoadDelegate.h.
• DumpRenderTree/mac/ResourceLoadDelegate.mm: Copied from DumpRenderTree/ResourceLoadDelegate.m. (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]): (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]): (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]): (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]): (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
• DumpRenderTree/mac/TextInputController.h: Copied from DumpRenderTree/TextInputController.h.
• DumpRenderTree/mac/TextInputController.m: Copied from DumpRenderTree/TextInputController.m.
• DumpRenderTree/mac/UIDelegate.h: Copied from DumpRenderTree/UIDelegate.h.
• DumpRenderTree/mac/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.mm. (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]): (-[UIDelegate webViewFocus:]): (-[UIDelegate webView:createWebViewWithRequest:]): (-[UIDelegate webViewClose:]):
• DumpRenderTree/mac/WorkQueueItemMac.mm: Copied from DumpRenderTree/WorkQueueItemMac.mm.

11:04 AM Changeset in webkit [25565] by andersca

• 2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5316743>
Safari does not handle filename parameter of content-disposition

Use CFURLResponseCopySuggestedFilename instead of our own hand-rolled implementation.

While we do return the correct filename in all cases I've tried, using CFNetwork is better because
it might handle corner cases that we don't.

• platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::doUpdateResourceResponse):

11:02 AM Changeset in webkit [25564] by kmccullo

• 6 edits in trunk/WebKitTools

Reviewed by Adam.

• Changing Win version of Drosera work with recent changes.

• Drosera/DebuggerDocument.cpp:
• Drosera/DebuggerDocument.h:
• Drosera/mac/DebuggerDocumentPlatform.mm: (NSStringCreateWithJSStringRef): (JSValueRefCreateWithNSString):
• Drosera/win/DebuggerClient.cpp: (DebuggerClient::stepInto):
• Drosera/win/Drosera.vcproj/Drosera.vcproj:

10:06 AM Changeset in webkit [25563] by ggaren

• 6 edits
  2 adds in trunk

WebCore:

Reviewed by Adam Roben.

Fixed ​http://bugs.webkit.org/show_bug.cgi?id=15209
Sometimes removing an iframe from the DOM does not remove its frame
from the page

• loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): Use the contentFrame pointer directly instead of searching for a frame by the frame element's name, because the frame element's name may have changed. (Another reason to do this is that it's just plain more straight-forward and efficient.)

LayoutTests:

Reviewed by Adam Roben.

Layout test for ​http://bugs.webkit.org/show_bug.cgi?id=15209
Sometimes removing an iframe from the DOM does not remove its frame
from the page.

• fast/frames/iframe-remove-after-id-change-expected.txt: Added.
• fast/frames/iframe-remove-after-id-change.html: Added.

Updated results in this test. New results indicate that the frame's
contents are preserved between removal and reinsertion, which matches
Firefox.

• fast/frames/iframe-option-crash-expected.checksum:
• fast/frames/iframe-option-crash-expected.png:
• fast/frames/iframe-option-crash-expected.txt:
• fast/frames/iframe-option-crash.xhtml:

8:38 AM Changeset in webkit [25562] by darin

• 3 edits
  4 adds in trunk

WebCore:

Reviewed by Mitz and Kevin Decker.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=15197 <rdar://problem/5478271> REGRESSION: Some Yahoo text entry fields render as lines rather than text entry boxes

Test: fast/forms/textarea-rows-cols.html

• html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::HTMLTextAreaElement): Use constants for the default number of rows and columns. (WebCore::HTMLTextAreaElement::parseMappedAttribute): If rows/cols attribute has a value that's missing, non-numeric, or zero, then use the default value. Also check for the case where the effective value of the attribute isn't changing.

LayoutTests:

Reviewed by Mitz and Kevin Decker.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=15197 <rdar://problem/5478271> REGRESSION: Some Yahoo text entry fields render as lines rather than text entry boxes

• fast/forms/textarea-rows-cols.html: Added.
• platform/mac/fast/forms/textarea-rows-cols-expected.checksum: Added.
• platform/mac/fast/forms/textarea-rows-cols-expected.png: Added.
• platform/mac/fast/forms/textarea-rows-cols-expected.txt: Added.

2:47 AM Changeset in webkit [25561] by bdash

• 2 edits in trunk/WebCore

2007-09-14 Sven Herzberg <​sven@imendio.com>

Reviewed by Adam Roben.

Don't use fontconfig types if necessary, fixes:
​http://bugs.webkit.org/show_bug.cgi?id=15203

• platform/gdk/FontPlatformData.cpp: don't use an FcBool to store the initialized state, use a plain c++ bool instead

1:20 AM Changeset in webkit [25560] by sfalken

• 1 copy in tags/Safari-523.6b

New tag.

1:20 AM Changeset in webkit [25559] by sfalken

• 1 edit in trunk/WebKit/win/WebKit.vcproj/VERSION

Bump version for submit

12:33 AM Changeset in webkit [25558] by sfalken

• 2 edits in trunk/WebKit/win

Fix build.

Sep 13, 2007:

6:46 PM Changeset in webkit [25557] by beidson

• 4 edits in trunk/WebCore

Reviewed by Maciej

<rdar://problem/5480437> - No site icon at launch and related error messages

The error message was actually indicative of a larger bug that might've resulted in icons getting
improperly pruned because they were never added to the set of retained page URLs.

To solve the no-icon-at-launch problem, we send the "didReceiveIcon:" delegate call for every page
load that has an icon, whether the icon comes in from network, from disk, or was already in ram

• loader/FrameLoader.cpp: (WebCore::FrameLoader::startIconLoader): Always send the didReceiveIcon delegate call when an icon's image data is known

• loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::retainIconForPageURL): Much more accurately track the set of retained pages by adding them when their retain count moves from 0 to 1

• loader/icon/PageURLRecord.h: (WebCore::PageURLRecord::retain): Correctly distinguish the "retain count just went from 0 to 1" case in the return value

6:02 PM Changeset in webkit [25556] by bdash

• 1 copy in tags/Safari-4523.6

New tag.

5:58 PM Changeset in webkit [25555] by bdash

• 4 edits in trunk

Versioning.

5:57 PM Changeset in webkit [25554] by bdash

• 1 copy in tags/Safari-5523.6

New tag.

5:35 PM Changeset in webkit [25553] by beidson

• 4 edits in trunk/WebCore

Rubberstamped by Geoff and Maciej

Fix MSVC build warning due to out of range data in a char array

• loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::defaultIcon): The buffer is now unsigned data

• platform/SharedBuffer.cpp: (WebCore::SharedBuffer::SharedBuffer): Add the "unsigned char*" c'tor
• platform/SharedBuffer.h:

4:59 PM Changeset in webkit [25552] by kmccullo

• 6 edits in trunk/WebKitTools

Reviewed by Tim.

• Moved isPaused into the JS for efficiency and simplicity.

• Drosera/DebuggerDocument.cpp: (DebuggerDocument::DebuggerDocument): (DebuggerDocument::pauseCallback): (DebuggerDocument::resumeCallback): (DebuggerDocument::isPaused): (DebuggerDocument::staticFunctions):
• Drosera/DebuggerDocument.h:
• Drosera/console.js:
• Drosera/debugger.js:
• Drosera/mac/DebuggerClient.mm: (-[DebuggerClient validateUserInterfaceItem:]):

4:05 PM Changeset in webkit [25551] by bdash

• 3 edits in branches/Safari-2.0-dashboard/JavaScriptCore

2007-09-13 Mark Rowe <​mrowe@apple.com>

Merge r23846 from trunk to Safari-2.0-dashboard.

2007-06-27 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Darin.

• <rdar://problem/5271937> REGRESSION: Apparent WebKit JavaScript memory smasher when submitting comment to iWeb site (crashes in kjs_pcre_compile2)
• Correctly evaluate the return value of _pcre_ucp_findchar.

• pcre/pcre_compile.c: (compile_branch):
• pcre/pcre_exec.c: (match):

4:05 PM Changeset in webkit [25550] by bdash

• 2 edits in branches/Safari-2.0-dashboard/WebCore

2007-09-13 Mark Rowe <​mrowe@apple.com>

Merge r12652 from trunk to Safari-2.0-dashboard.

2006-02-07 Adele Peterson <​adele@apple.com>

Reviewed by Maciej.

• Fixed <rdar://problem/3727939> Safari strips \0 characters from HTML tags making them valid

Test: fast/encoding/decoder-allow-null-chars.html

• kwq/KWQTextCodec.cpp: (KWQTextDecoder::convertLatin1): Removed stripping of null characters (unwanted): ditto.

4:05 PM Changeset in webkit [25549] by bdash

• 2 edits in branches/Safari-2.0-dashboard/WebCore

2007-09-13 Mark Rowe <​mrowe@apple.com>

Merge r24181 from trunk to Safari-2.0-dashboard.

2007-07-10 Sam Weinig <​sam@webkit.org>

Reviewed by Geoff.

Fix for <rdar://problem/5326791> XSS vulnerability: ability to set window.defaultStatus,
window.defaultstatus and window.status cross domains

Test: http/tests/security/cross-frame-access-put.html

• bindings/js/kjs_window.cpp: (KJS::Window::put): Adds isSafeScript check for defaultStatus, defaultstatus and status cases.

4:05 PM Changeset in webkit [25548] by bdash

• 2 edits in branches/Safari-2.0-dashboard/WebKit

2007-09-13 Mark Rowe <​mrowe@apple.com>

Merge r18562 from trunk to Safari-2.0-dashboard.

2007-01-03 John Sullivan <​sullivan@apple.com>

Reviewed by Kevin Decker

• fixed <rdar://problem/4145714> WebKit's PDFView's "Open in Preview" puts the PDF in /tmp, both group and world-readable

• WebView/WebPDFView.mm: (-[WebPDFView _openWithFinder:]): Make the file only readable by the current user

4:03 PM Changeset in webkit [25547] by darin

• 32 edits in trunk

WebCore:

Reviewed by Oliver.

• fix <rdar://problem/5470457> REGRESSION: Input method inline hole is mishandled in text <input> elements with maxlength limit

• editing/Editor.h: Moved MarkedTextUnderline here and renamed it CompositionUnderline. Moved the rest of the marked text API here and used the term that will be more familiar to those on platforms other than Macintosh, "composition". This helps prevent confusion with the other kinds of mark -- the emacs "mark" and spelling/grammar marks. Also cleaned up the conditionals a bit for the Macintosh-specific parts of this header.

• editing/Editor.cpp: (WebCore::Editor::Editor): Updated for name change. (WebCore::Editor::clear): Added. To be called by FrameLoader::clear(). (WebCore::Editor::insertTextWithoutSendingTextEvent): Removed code to make inserted text replace the marked text range -- we now deal with this explicitly by not calling this function to replace marked text. Also removed unneeded code that was specific to the use of this to replace the marked text. (WebCore::Editor::selectComposition): Renamed from selectMarkedText. Updated since the composition range is not stored as a Range. (WebCore::Editor::confirmComposition): Added. To be called when changing a composition into actual text. Unlike the old code path, deletes the composition first, then inserts the text, triggering the normal insertion code path and events. This is helpful because it means the inserted text will be truncated by the <input> element, for example. (WebCore::Editor::confirmCompositionWithoutDisturbingSelection): Added. (WebCore::Editor::setComposition): Added. To be called when changing the composition. Takes parameters for the underlines and selection. Unlike the old code path, this passes a flag down that indicates the inserted text is part of a composition. This is helpful because we don't send the event that will cause the <input> element to do truncation. It's also a better API for future improvements to our input method handling. (WebCore::Editor::revealSelectionAfterEditingOperation): Updated for name change. (WebCore::Editor::setIgnoreCompositionSelectionChange): Ditto. (WebCore::Editor::compositionRange): Added. Needed now that the composition is not stored as a Range. (WebCore::Editor::getCompositionSelection): Added.

• editing/TypingCommand.h:
• editing/TypingCommand.cpp: (WebCore::TypingCommand::insertText): Added an insertedTextIsComposition parameter, and don't send the BeforeTextInsertedEvent if it's true.

• loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): Replaced the Macintosh-specific call to setMarkedTextRange with a call to the new Editor::clear().

• page/Frame.h:
• page/Frame.cpp:
• page/FramePrivate.h:
• page/mac/FrameMac.mm: Removed the marked text code. It was streamlined and moved to Editor, except for the Mac-specific code, which was moved into WebKit.

• page/mac/WebCoreFrameBridge.h:
• page/mac/WebCoreFrameBridge.mm: Removed some now-unneeded marked text code. (-[WebCoreFrameBridge markedTextNSRange]): Updated for name/API change.

• rendering/InlineTextBox.h:
• rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): Updated marked text code for name changes, and also streamlined the code a bit for the case where there is no composition. (WebCore::InlineTextBox::paintCompositionBackground): Name change. (WebCore::InlineTextBox::paintCompositionUnderline): Ditto.

• rendering/RenderTextControl.h:
• rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::finishText): Added. Helper function shared by the (WebCore::RenderTextControl::text): (WebCore::getNextSoftBreak): (WebCore::RenderTextControl::textWithHardLineBreaks):

• platform/CharacterNames.h: Added newlineCharacter.

• dom/Range.h: Remove the now-unneeded version of toString that converts <br> elements into newlines.
• dom/Range.cpp: (WebCore::Range::toString): Changed this to use a Vector<UChar> instead of a String so it will not have pathological reallocation performance, and removed the <br> feature. (WebCore::Range::pastEndNode): Made this return 0 when there is no start node. This bit of extra robustness guarantees you can't do a null dereference if the start node is 0 and the end node is not. Not sure this case really exists.

• page/ContextMenuController.cpp: (ContextMenuController::contextMenuItemSelected): Removed a semi-bogus use of Range::toString(true). The right function to use here is plainText().

• bridge/EditorClient.h: Removed obsolete markedTextAbandoned function.

• WebCore.exp: Updated for above changes.

WebKit:

Reviewed by Oliver.

• fix <rdar://problem/5470457> REGRESSION: Input method inline hole is mishandled in text <input> elements with maxlength limit

• WebView/WebHTMLView.mm: (-[WebHTMLView _selectionChanged]): Tweaked code a bit. (-[WebHTMLView markedRange]): Simplified logic, since markedTextNSRange works when there's no composition range. (-[WebHTMLView hasMarkedText]): Call directly to Editor instead of bridge. (-[WebHTMLView unmarkText]): Call new confirmComposition to make it clear that this is confirming text, not just unmarking it to discard it. (extractUnderlines): Added. Converts directly from an NSAttributedString to the CompositionUnderline vector that's used by WebCore. (-[WebHTMLView setMarkedText:selectedRange:]): Changed to use the new setComposition. (-[WebHTMLView insertText:]): Changed to use confirmComposition when appropriate, instead of relying on special behavior of Editor::insertText. (-[WebHTMLView _updateSelectionForInputManager]): Rewrote to use getCompositionSelection and confirmCompositionWithoutDisturbingSelection.

• WebCoreSupport/WebEditorClient.h:
• WebCoreSupport/WebEditorClient.mm: Removed obsolete markedTextAbandoned function.

win:

Reviewed by Oliver.

• fix <rdar://problem/5470457> REGRESSION: Input method inline hole is mishandled in text <input> elements with maxlength limit

• WebView.cpp: (WebView::resetIME): Change to use confirmCompositionWithoutDisturbingSelection. (WebView::updateSelectionForIME): Update for name changes, and to use new functions in Editor. (WebView::onIMEStartComposition): Removed unneeded call to unmarkText. (compositionToUnderlines): Removed startOffset parameter, since setComposition now handles this. (WebView::onIMEComposition): Changed to use confirmComposition and setComposition. Logic gets a lot cleaner. (WebView::onIMEEndComposition): Removed unneeded calls to Editor. (WebView::onIMERequestCharPosition): Updated for name changes.

LayoutTests:

Reviewed by Oliver.

• updated test results changed by change in input manager logic

• platform/mac/editing/input/firstrectforcharacterrange-styled-expected.txt:
• platform/mac/editing/input/text-input-controller-expected.txt:
• platform/mac/editing/input/wrapped-line-char-rect-expected.txt: Updated. Small changes in which delegate methods are called.

3:20 PM Changeset in webkit [25546] by andersca

• 5 edits in trunk/WebCore

Reviewed by Adam and Geoff.

<rdar://problem/5304000>
Windows Safari doesn't always call NPP_SetWindow() for NPAPI plugins.

This does two things:

1. Makes sure that the plug-in get the correct initial size.

2. Always updates the size of the HWND, even if the widget size didn't change. This is because the widget size can be different before the HWND has been created.

• plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::createPluginView):
• plugins/win/PluginDatabaseWin.h:
• plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::setFrameGeometry): (WebCore::PluginViewWin::PluginViewWin):
• plugins/win/PluginViewWin.h:

3:01 PM Changeset in webkit [25545] by kmccullo

• 3 edits
  2 adds in trunk

WebCore:

Reviewed by Geof, Sam, Adam, Hyatt, Darin.

• <rdar://problem/5480234> JS setTimeout function requires a second argument
• Removed check for number of arguments in setTimeout to behave like other browsers.
• Added layoutTest setTimeout-no-arguments.html

• bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):

LayoutTests:

Reviewed by Geof, Sam, Adam, Hyatt, Darin.

• <rdar://problem/5480234> JS setTimeout function requires a second argument
• Removed check for number of arguments in setTimeout to behave like other browsers.

• fast/dom/Window/setTimeout-no-arguments-expected.txt: Added.
• fast/dom/Window/setTimeout-no-arguments.html: Added.

1:51 PM Changeset in webkit [25544] by weinig

• 13 edits
  1 add in trunk/WebKitTools

Rubber stamped by Darin.

Make DumpRenderTree more cross platform ready.

• Convert GCController to use the JSCore API instead of the WebScriptObject.
• Use CF types instead of NS objects.
• General cleanup.

• DumpRenderTree/DumpRenderTree.h:
• DumpRenderTree/DumpRenderTree.mm: (dumpRenderTree): (dump): (runTest):
• DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
• DumpRenderTree/EditingDelegate.m:
• DumpRenderTree/FrameLoadDelegate.h:
• DumpRenderTree/FrameLoadDelegate.mm: (-[FrameLoadDelegate init]): (-[FrameLoadDelegate dealloc]): (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
• DumpRenderTree/GCController.cpp: Added. (GCController::GCController): (GCController::~GCController): (collectCallback): (collectOnAlternateThreadCallback): (getJSObjectCountCallback): (GCController::makeWindowObject): (GCController::getJSClass): (GCController::staticFunctions):
• DumpRenderTree/GCController.h:
• DumpRenderTree/GCController.mm: (GCController::collect): (GCController::collectOnAlternateThread): (GCController::getJSObjectCount):
• DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::makeWindowObject): (LayoutTestController::getJSClass):
• DumpRenderTree/LayoutTestController.h:
• DumpRenderTree/LayoutTestControllerMac.mm: (LayoutTestController::addDisallowedURL): (waitUntilDoneWatchdogFired): (LayoutTestController::waitUntilDone):
• DumpRenderTree/ResourceLoadDelegate.m: (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):

1:15 PM Changeset in webkit [25543] by hyatt

• 4 edits in trunk/WebCore

Win32 font improvements.

12:07 PM Changeset in webkit [25542] by ggaren

• 2 edits in trunk/JavaScriptCore

Try to fix GDK build.

• wtf/MathExtras.h: (wtf_random_init):

11:52 AM Changeset in webkit [25541] by ggaren

• 4 edits in trunk/JavaScriptCore

2007-09-12 Geoff Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

Fixed <rdar://problem/5429064> 141885 Safari JavaScript: Math.random() slightly less randomly distributed than on Safari / Mac

Math.random was skewed slightly upward because it assumed that RAND_MAX was outside the range of
values that rand() might return. This problem was particularly pronounced on Windows because
the range of values returned by rand() on Windows is 2^{16 smaller than the range of values
return by rand() on Mac.}

Fixed by accounting for RAND_MAX return values. Also, switched Windows over to rand_s, which has
a range that's equal to rand()'s range on Mac.

• kjs/config.h:

• kjs/math_object.cpp: (MathFuncImp::callAsFunction): Use the new new thing.

• wtf/MathExtras.h: Platform abstraction for random numbers, to cover over differences on Windows. (wtf_random_init): (wtf_random):

11:10 AM Changeset in webkit [25540] by andersca

• 2 edits in trunk/WebCore

Reviewed, tweaked and landed by Anders.

<rdar://problem/5461153>
​http://bugs.webkit.org/show_bug.cgi?id=15143
Crash seen on Windows

Null check frame before calling Frame::settings.

• loader/PluginDocument.cpp: (WebCore::PluginTokenizer::writeRawData):

10:25 AM Changeset in webkit [25539] by kmccullo

• 2 edits in trunk/WebKitTools

Reviewed by Stephanie.

Fix leaks in mac DumpRenderTree.

• DumpRenderTree/FrameLoadDelegate.mm: (-[FrameLoadDelegate init]): Initalize in the correct order. (-[FrameLoadDelegate processWork:]): Delete WorkQueueItem's after dequeueing them.
• DumpRenderTree/LayoutTestController.cpp: (decodeHostNameCallback): Put return value in a temporary JSRetainPtr to ensure it gets released. (encodeHostNameCallback): ditto.
• DumpRenderTree/LayoutTestController.h:
• DumpRenderTree/LayoutTestControllerMac.mm: (LayoutTestController::copyDecodedHostName): Rename function to signal that it follows the Create rule. (LayoutTestController::copyEncodedHostName): ditto (LayoutTestController::queueLoad): Use a JSRetainPtr to ensure the url gets released.

10:06 AM Changeset in webkit [25538] by zecke

• 3 edits
  1 add in trunk/WebCore

2007-09-12 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Mark.

Implement the FileChooser for the WebKit/Gtk+ port by using
the GtkFileChooserDialog and g_path_get_basename to get the
basename for the current filename.

• WebCore.pro:
• platform/gdk/FileChooserGdk.cpp: Added. (WebCore::FileChooser::FileChooser): (WebCore::FileChooser::~FileChooser): (WebCore::FileChooser::openFileChooser): (WebCore::FileChooser::basenameForWidth):
• platform/gdk/TemporaryLinkStubs.cpp:

10:05 AM Changeset in webkit [25537] by zecke

• 3 edits
  1 add in trunk/WebCore

2007-09-12 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Mark.

Move the "string" functions from the TemporaryLinkStubs.cpp
to LocalizedStringsGdk.cpp and implement them using the text
from the win port and glib-i18n (gettext).

• platform/gdk/LocalizedStringsGdk.cpp: Added. (WebCore::submitButtonDefaultLabel): (WebCore::inputElementAltText): (WebCore::resetButtonDefaultLabel): (WebCore::searchableIndexIntroduction): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (WebCore::contextMenuItemTagOpenLinkInNewWindow): (WebCore::contextMenuItemTagDownloadLinkToDisk): (WebCore::contextMenuItemTagCopyLinkToClipboard): (WebCore::contextMenuItemTagOpenImageInNewWindow): (WebCore::contextMenuItemTagDownloadImageToDisk): (WebCore::contextMenuItemTagCopyImageToClipboard): (WebCore::contextMenuItemTagOpenFrameInNewWindow): (WebCore::contextMenuItemTagCopy): (WebCore::contextMenuItemTagGoBack): (WebCore::contextMenuItemTagGoForward): (WebCore::contextMenuItemTagStop): (WebCore::contextMenuItemTagReload): (WebCore::contextMenuItemTagCut): (WebCore::contextMenuItemTagPaste): (WebCore::contextMenuItemTagNoGuessesFound): (WebCore::contextMenuItemTagIgnoreSpelling): (WebCore::contextMenuItemTagLearnSpelling): (WebCore::contextMenuItemTagSearchWeb): (WebCore::contextMenuItemTagLookUpInDictionary): (WebCore::contextMenuItemTagOpenLink): (WebCore::contextMenuItemTagIgnoreGrammar): (WebCore::contextMenuItemTagSpellingMenu): (WebCore::contextMenuItemTagShowSpellingPanel): (WebCore::contextMenuItemTagCheckSpelling): (WebCore::contextMenuItemTagCheckSpellingWhileTyping): (WebCore::contextMenuItemTagCheckGrammarWithSpelling): (WebCore::contextMenuItemTagFontMenu): (WebCore::contextMenuItemTagBold): (WebCore::contextMenuItemTagItalic): (WebCore::contextMenuItemTagUnderline): (WebCore::contextMenuItemTagOutline): (WebCore::contextMenuItemTagWritingDirectionMenu): (WebCore::contextMenuItemTagDefaultDirection): (WebCore::contextMenuItemTagLeftToRight): (WebCore::contextMenuItemTagRightToLeft): (WebCore::contextMenuItemTagInspectElement): (WebCore::searchMenuNoRecentSearchesText): (WebCore::searchMenuRecentSearchesText): (WebCore::searchMenuClearRecentSearchesText): (WebCore::unknownFileSizeText):
• platform/gdk/TemporaryLinkStubs.cpp:

10:05 AM Changeset in webkit [25536] by zecke

• 3 edits
  2 adds in trunk/WebCore

2007-09-10 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Mark.

EventHandlerGdk::createDraggingClipboard must succeed otherwise an
ASSERT is hit. Add Clipboard stubs for the Gdk/Gtk+ port and
instantiate ClipboardGdk from the EventHandlerGdk to make the ASSERT
go away. In contrast to the Windows and Mac port this clipboard is not
inheriting CachedResourceClient. This was proposed by Oliver.

• WebCore.pro:
• page/gdk/EventHandlerGdk.cpp:
• platform/gdk/ClipboardGdk.cpp: Added. (WebCore::ClipboardGdk::ClipboardGdk): (WebCore::ClipboardGdk::~ClipboardGdk): (WebCore::ClipboardGdk::clearData): (WebCore::ClipboardGdk::clearAllData): (WebCore::ClipboardGdk::getData): (WebCore::ClipboardGdk::setData): (WebCore::ClipboardGdk::types): (WebCore::ClipboardGdk::dragLocation): (WebCore::ClipboardGdk::dragImage): (WebCore::ClipboardGdk::setDragImage): (WebCore::ClipboardGdk::dragImageElement): (WebCore::ClipboardGdk::setDragImageElement): (WebCore::ClipboardGdk::createDragImage): (WebCore::ClipboardGdk::declareAndWriteDragImage): (WebCore::ClipboardGdk::writeURL): (WebCore::ClipboardGdk::writeRange): (WebCore::ClipboardGdk::hasData):
• platform/gdk/ClipboardGdk.h: Added.

7:50 AM Changeset in webkit [25535] by antti

• 5 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

Small addition to previous path to cover
​http://bugs.webkit.org/show_bug.cgi?id=11399
window.eval runs in the global scope of the calling window

Switch variable scope as well.

• kjs/function.cpp: (KJS::GlobalFuncImp::callAsFunction):

LayoutTests:

Reviewed by Maciej.

Change test case to cover
​http://bugs.webkit.org/show_bug.cgi?id=11399
too.

• fast/js/window-eval-context-expected.txt:
• fast/js/window-eval-context.html:

6:54 AM Changeset in webkit [25534] by antti

• 5 edits
  2 adds in trunk

JavaScriptCore:

Reviewed by Geoff, Maciej.

Fix <rdar://problem/5445058>
REGRESSION: Unable to upload picture to eBay auction due to domain security check

eBay uses window.eval() between windows. In Firefox window.eval() switches execution
and security context to the target window, something WebKit did not do. With WebKit
security tightening in r24781, this broke picture uploads.

Fix by making WebKit switch context in window.eval().

• kjs/Context.cpp: (KJS::Context::Context): (KJS::Context::~Context):
• kjs/context.h: Save and restore interpreter context independently from calling context.

• kjs/function.cpp: (KJS::GlobalFuncImp::callAsFunction): If eval is called for global object different than current one, switch execution context to that object and push it to scope.

LayoutTests:

Reviewed by Geoff, Maciej.

Test for <rdar://problem/5445058>
REGRESSION: Unable to upload picture to eBay auction due to domain security check

• fast/js/window-eval-context-expected.txt: Added.
• fast/js/window-eval-context.html: Added.

1:03 AM Changeset in webkit [25533] by justing

• 1 edit in trunk/LayoutTests/editing/execCommand/5144139-1-expected.txt

Forgot to check in this new expected result which reflect corrected selection endpoints.

Sep 12, 2007:

11:27 PM Changeset in webkit [25532] by oliver

• 3 edits in trunk/WebCore

2007-09-12 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Corrections missed in previous revision

• platform/Cursor.h:
• platform/win/CursorWin.cpp: (WebCore::loadCursorByName):

10:51 PM Changeset in webkit [25531] by ddkilzer

• 3 edits in trunk/LayoutTests

LayoutTests:

Reviewed by Darin.

• plugins/mouse-events.html: Removed invalid return statement.
• plugins/open-and-close-window-with-plugin.html: Ditto.

10:33 PM Changeset in webkit [25530] by oliver

• 9 edits
  3 adds in trunk

2007-09-12 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

WebKit:

Fixing

<rdar://problem/5018591> Windows doesn't have a standard vertical text cursor
<rdar://problem/5224996> Add zoom in and zoom out cursors

Add images for vertical text and zoom in and out cursors to WebKit resources.

• WebKit.vcproj/verticalTextCursor.png: Added.
• WebKit.vcproj/WebKit.rc:
• WebKit.vcproj/WebKit.vcproj:
• WebKit.vcproj/resource.h:
• WebKit.vcproj/zoomInCursor.png: Added.
• WebKit.vcproj/zoomOutCursor.png: Added.
• WebKitDLL.cpp: (loadResourceIntoBuffer):

WebCore:

Fixing

<rdar://problem/5018591> Windows doesn't have a standard vertical text cursor
<rdar://problem/5224996> Add zoom in and zoom out cursors

Added SharedCursor for CursorWin so we can correctly track lifetime of custom/image
based cursors, such as the vertical text and zooming cursors.

• platform/Cursor.h: (WebCore::SharedCursor::SharedCursor): (WebCore::SharedCursor::~SharedCursor): (WebCore::SharedCursor::nativeCursor):
• platform/win/CursorWin.cpp: (WebCore::Cursor::Cursor): (WebCore::loadCursorByName): (WebCore::loadSharedCursor): (WebCore::pointerCursor): (WebCore::crossCursor): (WebCore::handCursor): (WebCore::iBeamCursor): (WebCore::waitCursor): (WebCore::helpCursor): (WebCore::eastResizeCursor): (WebCore::northResizeCursor): (WebCore::northEastResizeCursor): (WebCore::northWestResizeCursor): (WebCore::southResizeCursor): (WebCore::southEastResizeCursor): (WebCore::southWestResizeCursor): (WebCore::westResizeCursor): (WebCore::northSouthResizeCursor): (WebCore::eastWestResizeCursor): (WebCore::northEastSouthWestResizeCursor): (WebCore::northWestSouthEastResizeCursor): (WebCore::columnResizeCursor): (WebCore::rowResizeCursor): (WebCore::moveCursor): (WebCore::verticalTextCursor): (WebCore::progressCursor): (WebCore::notAllowedCursor): (WebCore::zoomInCursor): (WebCore::zoomOutCursor):
• platform/win/WidgetWin.cpp: (WebCore::Widget::setCursor):

8:10 PM Changeset in webkit [25529] by weinig

• 5 edits in trunk/WebKitTools

Reviewed by Stephanie.

Fix leaks in mac DumpRenderTree.

• DumpRenderTree/FrameLoadDelegate.mm: (-[FrameLoadDelegate init]): Initalize in the correct order. (-[FrameLoadDelegate processWork:]): Delete WorkQueueItem's after dequeueing them.
• DumpRenderTree/LayoutTestController.cpp: (decodeHostNameCallback): Put return value in a temporary JSRetainPtr to ensure it gets released. (encodeHostNameCallback): ditto.
• DumpRenderTree/LayoutTestController.h:
• DumpRenderTree/LayoutTestControllerMac.mm: (LayoutTestController::copyDecodedHostName): Rename function to signal that it follows the Create rule. (LayoutTestController::copyEncodedHostName): ditto (LayoutTestController::queueLoad): Use a JSRetainPtr to ensure the url gets released.

7:29 PM Changeset in webkit [25528] by aroben

• 3 edits in trunk/WebKit/win

Initialize SafariTheme early in WebKit's instantiation

New versions of SafariTheme will require this initialization. We have
to use GetProcAddress for now since the initialize method doesn't
exist in any released SafariTheme.

Reviewed by Ada.

• WebKit.vcproj/debug_internal.vsprops: Pick up the debug SafariTheme.
• WebKitClassFactory.cpp: (WebKitClassFactory::WebKitClassFactory): Call STInitialize.

7:16 PM Changeset in webkit [25527] by weinig

• 2 edits in trunk/JavaScriptCore

Reviewed by Geoffrey Garen.

<rdar://problem/5478717> JSStringCreateWithCFString leaks when passed a zero length CFStringRef

• API/JSStringRefCF.cpp: (JSStringCreateWithCFString): Special case the zero length string and remove the UTF16 optimized path since it will always leak due to the fact that we won't be able to free the backing store that the CFStringRef provides.

7:08 PM Changeset in webkit [25526] by beidson

• 3 edits in trunk/WebCore

Reviewed by Geoff Garen

<rdar://problem/5478577> - Further improve cold launch time with Icon Database changes

• loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::open): Store the directory and full path for later usage and access in the API, respectively Move the makeAllDirectories() call to the background thread. (WebCore::IconDatabase::IconDatabase): Don't set up the timer here... (WebCore::IconDatabase::scheduleOrDeferSyncTimer): Create the timer on demand (WebCore::IconDatabase::iconDatabaseSyncThread): makeAllDirectories() here where it's not as expensive (WebCore::IconDatabase::cleanupSyncThread): Cleanup the directory as well as full path

• loader/icon/IconDatabase.h: m_syncTimer becomes an OwnPtr, and we add the database directory as a member to set it on the main thread and act with it on the background thread

6:53 PM Changeset in webkit [25525] by adachan

• 2 edits in trunk/WebKit/win

<rdar://problem/5478690> Regression: printing: footer only appears on the first page of print

Reviewed by Adam.

• WebFrame.cpp: (WebFrame::spoolPages): the footer rect is relative to the top left of the current page. So instead of passing pageRect.bottom() as the top of the footer rect (which is relative to the document), we should pass in headerHeight plus the height of the pageRect.

6:31 PM Changeset in webkit [25524] by kmccullo

• 5 edits
  1 add in trunk/WebKitTools

Reviewed by Darin.

• Simplified code paths and extracted out functions to increase encapsulation.

• Drosera/DebuggerDocument.cpp: (DebuggerDocument::breakpointEditorHTMLCallback): (DebuggerDocument::isPausedCallback): (DebuggerDocument::pauseCallback): (DebuggerDocument::resumeCallback): (DebuggerDocument::stepIntoCallback): (DebuggerDocument::evaluateScriptCallback): (DebuggerDocument::currentFunctionStackCallback): (DebuggerDocument::localScopeVariableNamesForCallFrameCallback): (DebuggerDocument::valueForScopeVariableNamedCallback): (DebuggerDocument::logCallback):
• Drosera/DebuggerDocument.h: (DebuggerDocument::getPaused):
• Drosera/mac/DebuggerClient.mm: (-[DebuggerClient pause:]): (-[DebuggerClient resume:]): (-[DebuggerClient stepInto:]): (-[DebuggerClient stepOver:]): (-[DebuggerClient stepOut:]): (-[DebuggerClient showConsole:]): (-[DebuggerClient closeCurrentFile:]): (-[DebuggerClient validateUserInterfaceItem:]):
• Drosera/mac/DebuggerDocumentPlatform.mm: Added. (+[NSString stringOrNilFromWebScriptResult:]): (DebuggerDocument::platformPause): (DebuggerDocument::platformResume): (DebuggerDocument::platformStepInto): (DebuggerDocument::platformEvaluateScript): (DebuggerDocument::getPlatformCurrentFunctionStack): (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame): (DebuggerDocument::platformValueForScopeVariableNamed): (DebuggerDocument::platformLog):
• Drosera/mac/Drosera.xcodeproj/project.pbxproj:

5:23 PM Changeset in webkit [25523] by andersca

• 2 edits in trunk/WebKit/win

Reviewed by Darin (reluctantly).

<rdar://problem/5320461>
​http://bugs.webkit.org/show_bug.cgi?id=14548
REGRESSION (r23987-r24061) : Reproducible crash with a local stylesheet file

Add a workaround which converts the string passed in to an URL if it's a path.

• WebView.cpp: (WebView::updateWebCoreSettingsFromPreferences):

5:04 PM Changeset in webkit [25522] by justing

• 7 edits
  6 adds
  3 deletes in trunk

WebCore:

Reviewed by Tristan.

<rdar://problem/5469868>
GoogleDocs: A hang occurs when applying list styling to a selection in a <table>

When list insertion moves selected paragraphs into list items, it relies on
the selection preservation code inside moveParagraphs to iterate over the
selected paragraphs. If a selection is ever restored incorrectly (before
the original, or inside the original) list insertion will go into an infinite loop.

In this hang, a table was selected and the selection preservation code incorrectly
restored a selection, placing it inside the table.

The bug was that a TextIterator, when being used for selection preservation, must
emit a character between every VisiblePosition in the Range used to create the
iterator.

• editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator): Renamed the boolean that we use for selection preservation. It used to be m_emitForReplacedElements because we believed that replaced elements were the only case where TextIterators should have emitted differently when used for selection preservation. (WebCore::TextIterator::handleReplacedElement): Ditto. (WebCore::TextIterator::shouldRepresentNodeOffsetZero): Represent the position before block tables, but only if we are emitting for selection preservation. (WebCore::TextIterator::shouldEmitSpaceBeforeAndAfterNode): We should emit a space before and after block tables if we are emitting for selection preservation (because we have VisiblePositions before and after them). (WebCore::TextIterator::handleNonTextNode): Use a renamed variable.
• editing/TextIterator.h: Made shouldEmitSpaceBeforeAndAfterNode a member function, because whether or not we emit spaces before and after a block table depends we're emitting for selection preservation.

LayoutTests:

Reviewed by Tristan.

Demonstrates bug:

• editing/execCommand/5469868-expected.txt: Added.
• editing/execCommand/5469868.html: Added.

Fixed (and moved expected results to platform/mac):

• editing/style/table-selection-expected.checksum: Removed.
• editing/style/table-selection-expected.png: Removed.
• editing/style/table-selection-expected.txt: Removed.
• platform/mac/editing/style: Added.
• platform/mac/editing/style/table-selection-expected.checksum: Added.
• platform/mac/editing/style/table-selection-expected.png: Added.
• platform/mac/editing/style/table-selection-expected.txt: Added.

Fixed:

• platform/mac/editing/execCommand/5432254-2-expected.checksum:
• platform/mac/editing/execCommand/5432254-2-expected.png:
• platform/mac/editing/execCommand/5432254-2-expected.txt:

4:53 PM Changeset in webkit [25521] by bdakin

• 9 edits
  4 adds in trunk

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/5464998> REGRESSION (9A543): Using Sort
options takes you back to search screen on zappos.com

The current mechanism for preserving form elements across removes
did not work in the case where the input was moved by the parser to
be out of scope of the form. This fixes that problem by having the
parser keep track of the preserve boolean rather than the current
form element.

• dom/Tokenizer.h: (WebCore::Tokenizer::isHTMLTokenizer): New function.
• html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement): Get rid of m_preserveAcrossRemove.
• html/HTMLFormElement.h: (WebCore::HTMLFormElement::isMalformed): Get rid of m_preserveAcrossRemove.
• html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::removedFromTree): Ask the parser if it is currently handling residual style rather than asking the form if it wants to preserveAcrossRemove.
• html/HTMLParser.cpp: (WebCore::HTMLParser::HTMLParser): New boolean to initialize. (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Set m_handlingResidualStyleAcrossBlocks to true at the beginning and false at the end.
• html/HTMLParser.h: (WebCore::HTMLParser::isHandlingResidualStyleAcrossBlocks):
• html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::isHTMLTokenizer): (WebCore::HTMLTokenizer::htmlParser):

LayoutTests:

Reviewed by Hyatt.

Test for <rdar://problem/5464998> REGRESSION (9A543): Using Sort
options takes you back to search screen on zappos.com

• fast/forms/preserveFormDuringResidualStyle.html: Added.
• platform/mac/fast/forms/preserveFormDuringResidualStyle-expected.checksum: Added.
• platform/mac/fast/forms/preserveFormDuringResidualStyle-expected.png: Added.
• platform/mac/fast/forms/preserveFormDuringResidualStyle-expected.txt: Added.

4:43 PM Changeset in webkit [25520] by hyatt

• 1 edit in trunk/WebCore/platform/win/KeyEventWin.cpp

LAnd piece of alt patch I forgot to.

3:23 PM Changeset in webkit [25519] by ddkilzer

• 2 edits in trunk/WebKit

WebKit:

Rubber-stamped by Darin and reviewed by Adam.

Removed import of unused icon database headers.

• WebCoreSupport/WebFrameBridge.mm:

2:12 PM Changeset in webkit [25518] by thatcher

• 1 edit in trunk/WebKitTools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj

Add back the -Wno-deprecated-declarations flag to DumpRenderTree.mm. Fixes the build on Leopard.

1:11 PM Changeset in webkit [25517] by weinig

• 2 edits in trunk/WebKitTools

Build fix for Buildbot.

• DumpRenderTree/DumpRenderTree.mm: (dump):

1:00 PM Changeset in webkit [25516] by kmccullo

• 2 edits in trunk/WebKitTools

Reviewed by Geof.

• Updated the leaks list for leopard to help identify regressions.

• Scripts/run-webkit-tests:

12:51 PM Changeset in webkit [25515] by weinig

• 19 edits
  3 copies
  3 moves
  4 adds
  1 delete in trunk

WebKitTools:

Rubber stamped by Darin.

Convert the LayoutTestController to use the JSCore API instead of WebScriptObject.

• DumpRenderTree/DumpRenderTree.h: Re-order variables.
• DumpRenderTree/DumpRenderTree.m: Removed.
• DumpRenderTree/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.m. (stopJavaScriptThreads): Fix initialization. (setDefaultColorProfileToRGB): Add explicit cast from void*. (dumpRenderTree): Ditto. (runTest): Used the WorkQueue from the windows DRT instead of the old NSMutableArray one.

• DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
• DumpRenderTree/FrameLoadDelegate.h: Add LayoutTestController instance variable.
• DumpRenderTree/FrameLoadDelegate.m: Removed.
• DumpRenderTree/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.m. (-[FrameLoadDelegate init]): (-[FrameLoadDelegate dealloc]): (-[FrameLoadDelegate processWork:]): (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]): Convert to use the new JSCore based LayoutTestController and the new WorkQueue.

• DumpRenderTree/LayoutTestController.cpp: Added. (LayoutTestController::LayoutTestController): (LayoutTestController::~LayoutTestController): (dumpAsTextCallback): (dumpBackForwardListCallback): (dumpChildFramesAsTextCallback): (dumpChildFrameScrollPositionsCallback): (dumpDOMAsWebArchiveCallback): (dumpEditingCallbacksCallback): (dumpFrameLoadCallbacksCallback): (dumpResourceLoadCallbacksCallback): (dumpSelectionRectCallback): (dumpSourceAsWebArchiveCallback): (dumpTitleChangesCallback): (repaintSweepHorizontallyCallback): (setCallCloseOnWebViewsCallback): (setCanOpenWindowsCallback): (setCloseRemainingWindowsWhenCompleteCallback): (testRepaintCallback): (addFileToPasteboardOnDragCallback): (addDisallowedURLCallback): (clearBackForwardListCallback): (decodeHostNameCallback): (displayCallback): (encodeHostNameCallback): (keepWebHistoryCallback): (notifyDoneCallback): (queueBackNavigationCallback): (queueForwardNavigationCallback): (queueLoadCallback): (queueReloadCallback): (queueScriptCallback): (setAcceptsEditingCallback): (setCustomPolicyDelegateCallback): (setMainFrameIsFirstResponderCallback): (setTabKeyCyclesThroughElementsCallback): (setUseDashboardCompatibilityModeCallback): (setUserStyleSheetEnabledCallback): (setUserStyleSheetLocationCallback): (setWindowIsKeyCallback): (waitUntilDoneCallback): (windowCountCallback): (LayoutTestController::makeWindowObject): (LayoutTestController::getLayoutTestControllerJSClass): (LayoutTestController::staticFunctions):
• DumpRenderTree/LayoutTestController.h: Replaced.
• DumpRenderTree/LayoutTestController.m: Removed.
• DumpRenderTree/LayoutTestControllerMac.mm: Added. (LayoutTestController::dumpAsText): (LayoutTestController::dumpBackForwardList): (LayoutTestController::dumpChildFramesAsText): (LayoutTestController::dumpChildFrameScrollPositions): (LayoutTestController::dumpDOMAsWebArchive): (LayoutTestController::dumpEditingCallbacks): (LayoutTestController::dumpFrameLoadCallbacks): (LayoutTestController::dumpResourceLoadCallbacks): (LayoutTestController::dumpSelectionRect): (LayoutTestController::dumpSourceAsWebArchive): (LayoutTestController::dumpTitleChanges): (LayoutTestController::repaintSweepHorizontally): (LayoutTestController::setCallCloseOnWebViews): (LayoutTestController::setCanOpenWindows): (LayoutTestController::setCloseRemainingWindowsWhenComplete): (LayoutTestController::testRepaint): (LayoutTestController::addFileToPasteboardOnDrag): (LayoutTestController::addDisallowedURL): (LayoutTestController::clearBackForwardList): (LayoutTestController::decodeHostName): (LayoutTestController::encodeHostName): (LayoutTestController::display): (LayoutTestController::keepWebHistory): (LayoutTestController::notifyDone): (LayoutTestController::queueBackNavigation): (LayoutTestController::queueForwardNavigation): (LayoutTestController::queueLoad): (LayoutTestController::queueReload): (LayoutTestController::queueScript): (LayoutTestController::setAcceptsEditing): (LayoutTestController::setCustomPolicyDelegate): (LayoutTestController::setMainFrameIsFirstResponder): (LayoutTestController::setTabKeyCyclesThroughElements): (LayoutTestController::setUseDashboardCompatibilityMode): (LayoutTestController::setUserStyleSheetEnabled): (LayoutTestController::setUserStyleSheetLocation): (LayoutTestController::setWindowIsKey): (+[WaitToDumpWatchdog waitUntilDoneWatchdogFired]): (LayoutTestController::waitUntilDone): (LayoutTestController::windowCount): Use the JSCore API to implement the LayoutTestController.

• DumpRenderTree/ObjCController.h:
• DumpRenderTree/ObjCController.m: (+[ObjCController isSelectorExcludedFromWebScript:]): (+[ObjCController webScriptNameForSelector:]): (-[ObjCController accessStoredWebScriptObject]): (-[ObjCController storeWebScriptObject:]): (-[ObjCController dealloc]): (-[ObjCController invokeUndefinedMethodFromWebScript:withArguments:]): Move WebScriptObject tests to ObjCController.

• DumpRenderTree/UIDelegate.m: Removed.
• DumpRenderTree/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.m.

• DumpRenderTree/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
• DumpRenderTree/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
• DumpRenderTree/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h. (WorkQueueItem::~WorkQueueItem): (LoadItem::LoadItem): (LoadItem::url): (LoadItem::target): (ScriptItem::ScriptItem): (ScriptItem::script):
• DumpRenderTree/WorkQueueItemMac.mm: Added. (LoadItem::invoke): (ReloadItem::invoke): (ScriptItem::invoke): (BackForwardItem::invoke): Copy WorkQueue and WorkQueueItem from windows DRT. Changed the WorkQueueItem to use JSStringRefs instead of wstrings to avoid conversion until the last possible moment. These changes will be merged with the windows DRT when we start sharing code.

LayoutTests:

Rubber stamped by Darin.

Fix layout tests for new JSCore API based LayoutTestController.

• fast/dom/resources/wrapper-identity-base.js: Use ObjCController for objective-c tests.
• http/tests/local/file-url-sent-as-referer.html: Remove unused illegal call that now causes controller to fail due to not allowing undefined method calls.
• http/tests/xmlhttprequest/default-content-type-dashboard.html: Fix typo in function name.
• http/tests/xmlhttprequest/svg-created-by-xhr-disallowed-in-dashboard.html: Fix typo in function name.
• plugins/call-as-function-test-expected.txt:
• plugins/call-as-function-test.html: Use ObjCController to test WebScriptObject.
• plugins/root-object-premature-delete-crash.html: Use ObjCController to test WebScriptObject
• plugins/undefined-property-crash.html: Use ObjCController to test WebScriptObject.
• svg/custom/embedded-svg-disallowed-in-dashboard.xml: Fix typo in function name.
• svg/custom/manually-parsed-embedded-svg-disallowed-in-dashboard.html: Fix typo in function name.
• svg/custom/manually-parsed-svg-disallowed-in-dashboard.html: Fix typo in function name.
• svg/custom/svg-disallowed-in-dashboard-object.html: Fix typo in function name.

11:46 AM Changeset in webkit [25514] by staikos

• 2 edits in trunk/WebCore

2007-09-12 George Staikos <​staikos@kde.org>

Fix compilation in some configurations for patch I reviewed and missed
this option on.

• platform/qt/CursorQt.cpp: (WebCore::Cursor::Cursor):

11:45 AM Changeset in webkit [25513] by kmccullo

• 8 edits in trunk/WebKitTools

Reviewed by Maciej.

• Updated Win side to take advantage of the platform separating changes.

• Drosera/DebuggerDocument.cpp: (DebuggerDocument::localScopeVariableNamesForCallFrame):
• Drosera/DebuggerDocument.h:
• Drosera/win/DebuggerClient.cpp: (DebuggerClient::pause): (DebuggerClient::resume): (DebuggerClient::stepInto): (DebuggerDocument::platformPause): (DebuggerDocument::platformResume): (DebuggerDocument::platformStepInto): (DebuggerDocument::platformEvaluateScript): (DebuggerDocument::getPlatformCurrentFunctionStack): (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame): (DebuggerDocument::platformValueForScopeVariableNamed): (DebuggerDocument::platformLog):
• Drosera/win/DebuggerClient.h:
• Drosera/win/Drosera.cpp: (Drosera::Drosera): (Drosera::windowScriptObjectAvailable): (Drosera::initWithServerName): (Drosera::switchToServerNamed):
• Drosera/win/Drosera.h:
• Drosera/win/Drosera.vcproj/Drosera.vcproj:

11:39 AM Changeset in webkit [25512] by beidson

• 3 edits
  1 delete in trunk/WebCore

Reviewed by Tim Hatcher and Kevin Decker

<rdar://problem/5367045> - Launch time regression due to accessing resource from a different bundle

When the default icon was moved from WebKit to WebCore, we had to access an entirely new bundle on launch which
measurably increased time during launch accessing the disk.

Instead of moving it back to the WebKit bundle, lets make launch time even faster by compiling in the icon.

• Resources/urlIcon.tiff: Removed.

• WebCore.xcodeproj/project.pbxproj: Removed urlIcon.tiff

• loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::defaultIcon): Compile in the icon data here.

11:15 AM Changeset in webkit [25511] by aroben

• 2 edits in trunk/WebCore

Always specify that slider thumbs are small when painting with SafariTheme

This is the only size we support.

Reviewed by Sam.

• rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintSliderThumb):

11:03 AM Changeset in webkit [25510] by beidson

• 2 edits in trunk/WebCore

Reviewed by Darin

<rdar://problem/5474753> - ASSERT in IconDatabase ReadySQLStatement

• loader/icon/IconDatabase.cpp: (WebCore::readySQLStatement): This is a LOG_ERROR situation, not really an ASSERT situation

10:52 AM Changeset in webkit [25509] by aroben

• 2 edits in trunk/WebCore

Don't ask SafariTheme to draw focus rings around text controls

We do this ourselves.

Reviewed by Oliver.

• rendering/RenderThemeSafari.cpp:

10:48 AM Changeset in webkit [25508] by beidson

• 2 edits in trunk/WebCore

Reviewed by Darin

<rdar://problem/5475639> and ​http://bugs.webkit.org/show_bug.cgi?id=15185 -
Prevent two WebKits from fighting over the database schema in the future in case it ever changes again

By telling the "older schema" WebKit to simply close itself and not bother to do any icon related stuff
if the database schema is newer, we prevent the possibility of an older webkit run side-by-side with a newer
WebKit causing icon database issues.

• loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::defaultDatabaseFilename): Rev the icon database filename to be "WebpageIcons.db" The name is more appropriate for what is actually stored in the file, and since we're already not converting v5 to v6 icons, making this leap now makes sense and gives us a good "future-proof" baseline (WebCore::isValidDatabase): Change the validity check to be "less then" instead of "not equal to" - the "greater than" case is now handled in performOpenInitialization() (WebCore::IconDatabase::performOpenInitialization): If the schema version is greater than the current, then close the database as to not conflict with the newer version. Also noted that the integrity check failure should actually close the sql database, not the icondatabase (WebCore::IconDatabase::syncThreadMainLoop): If termination has already been requested, skip straight to cleanup (WebCore::IconDatabase::cleanupSyncThread): More correctly set the "sync thread running" flag to false here, as the thread can now decide to exit on its own

10:16 AM Changeset in webkit [25507] by treat

• 2 edits in trunk/WebCore

Patch from Mike Fenton to allow custom cursors.

10:12 AM Changeset in webkit [25506] by oliver

• 10 edits in trunk/LayoutTests

Rubber stamped by Kevin D.

Fix layout test results effected by turning off <use> entirely

• svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum:
• svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
• svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
• svg/W3C-SVG-1.1/struct-use-01-t-expected.checksum:
• svg/W3C-SVG-1.1/struct-use-01-t-expected.png:
• svg/W3C-SVG-1.1/struct-use-01-t-expected.txt:
• svg/W3C-SVG-1.1/text-text-05-t-expected.checksum:
• svg/W3C-SVG-1.1/text-text-05-t-expected.png:
• svg/W3C-SVG-1.1/text-text-05-t-expected.txt: