Timeline



Sep 21, 2007:

9:20 PM Changeset in webkit [25699] by bdash
  • 5 edits in trunk/WebCore

2007-09-21 Mark Rowe <mrowe@apple.com>

Build fix for non-Mac platforms after r25697.

Rename Frame::cleanupPlatformScriptObjects to Frame::clearPlatformScriptObjects.

  • bridge/win/FrameWin.cpp:
  • page/gdk/FrameGdk.cpp:
  • page/qt/FrameQt.cpp:
  • platform/wx/TemporaryLinkStubs.cpp:
8:56 PM Changeset in webkit [25698] by adele
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Sam.

Fix for <rdar://problem/5497357> REGRESSION: Safari doesn't show the month days on AirFrance reservation page

Test: fast/dom/HTMLSelectElement/options-collection-set-string-length.html

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::setLength): Convert the value to a number. We already have code here to check if the value is not a number. This matches other browsers, which allow a string value to be used to set the length.

LayoutTests:

Reviewed by Sam.

Test for <rdar://problem/5497357> REGRESSION: Safari doesn't show the month days on AirFrance reservation page

  • fast/dom/HTMLSelectElement/options-collection-set-string-length-expected.txt: Added.
  • fast/dom/HTMLSelectElement/options-collection-set-string-length.html: Added.
5:49 PM Changeset in webkit [25697] by thatcher
  • 12 edits in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded

Calling -[WebView windowScriptObject] before the page loads would give you nil. This behavior didn't match Tiger.
The API behavior in Tiger let you get the window script object once and keep ahold of it as long as you needed it.
The window object would remain valid even after page loads. This change restores the Tiger behavior.

<rdar://problem/5495790> NULL dereference crash beneath Bindings::RootObject::interpreter when saving Dashcode document

The changes to WebScriptObject's _isSafeScript call also fixed the crash in Dashcode.

  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject _setOriginRootObject:andRootObject:]): New method used to update the the root objects, so the WebScriptObject can still be used after a page load. (-[WebScriptObject _isSafeScript]): Call [self _rootObject] instead of accessing the data member directly. DOMNode has an override for the _rootObject method, and it can return 0 when _private->_rootObject is non-zero. We would return YES here when it wasn't safe and later crash with my modified layout tests. Checking _rootObject first prevents other calls sites from needing to check for a valid root object, this fixed the Dashcode crash. (-[WebScriptObject _imp]): Ditto.
  • bindings/objc/WebScriptObjectPrivate.h: Add _setOriginRootObject:andRootObject:.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): Call the renamed clearScriptObjects function. (WebCore::FrameLoader::dispatchWindowObjectAvailable): Some gratuitous code cleanup.
  • page/Frame.cpp: (WebCore::Frame::clearScriptObjects): Renamed cleanupScriptObject to clearScriptObjects. Call clearPlatformScriptObjects last so m_bindingRootObject is already NULL. (WebCore::Frame::windowScriptNPObject): Hold a JSLock before accessing the window. This change is unrelated to the bug, but should be fixed.
  • page/mac/FrameMac.mm: (WebCore::Frame::windowScriptObject): Return a script object even if the interpreter is NULL. This resotres the Tiger behavior of always being able to access the window object. (WebCore::Frame::clearPlatformScriptObjects): Keep the window script object around, and update the root objects for the window script object.
  • page/Frame.h: Rename cleanupScriptObject to clearScriptObjects.
  • page/FramePrivate.h: Use a RetainPtr for m_windowScriptObject.

WebKitTools:

Reviewed by Darin.

<rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)

Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
This is tested by plugins/root-object-premature-delete-crash.html.

  • DumpRenderTree/mac/ObjCController.m: (-[ObjCController accessStoredWebScriptObject]):

LayoutTests:

Reviewed by Darin.

<rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)

Updated results to show the didClearWindowScriptObject delegate call. Tweaked plugins/root-object-premature-delete-crash.html
to test a non-window script object half the time. This change works with a change to DumpRenderTree.

  • http/tests/loading/empty-subframe-expected.txt:
  • http/tests/loading/simple-subframe-expected.txt:
  • plugins/root-object-premature-delete-crash.html:
  • webarchive/loading/test-loading-archive-expected.txt:
5:30 PM Changeset in webkit [25696] by staikos
  • 2 edits in trunk/WebCore

2007-09-21 Mike Fenton <mike@staikos.net>

Reviewed by George Staikos.

Fix styled pen support by not clobbering QPen properties.

  • html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor): (WebCore::CanvasStyle::applyFillColor):
5:00 PM Changeset in webkit [25695] by oliver
  • 1 edit in trunk/WebCore/ChangeLog

Darin reviewed as well, and pointed out mistake in ChangeLog

4:51 PM Changeset in webkit [25694] by oliver
  • 2 edits in trunk/WebCore

Reviewed by Tristan.

http://bugs.webkit.org/show_bug.cgi?id=15239
<rdar://problem/5491955> REGRESSION (r25547): With Hanin IME, one cannot input characters into forms (15239)


This problem was caused by the setComposition method failing to clearing
the composition markers in the presence of an empty string. This would
result in the caret being locked within the 0 length bounds of the "composition"
and so preventing basic keyboard interaction.

  • editing/Editor.cpp: (WebCore::Editor::setComposition):
4:29 PM Changeset in webkit [25693] by adele
  • 3 edits in trunk/WebCore

Reviewed by Tristan.

Fix for <rdar://problem/5497346> "Check spelling when I click Send" crashes on stationery messages every time

No test. I wasn't able to find a way to get this to occur with Safari or DumpRenderTree.

  • editing/Editor.cpp: (WebCore::Editor::advanceToNextMisspelling): Updated comment.
  • editing/htmlediting.cpp: (WebCore::firstEditablePositionAfterPositionInRoot): Only return the root position if its editable. (WebCore::maxDeepOffset): Added nil check & assert.
4:18 PM Changeset in webkit [25692] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Steve.

<rdar://problem/5404339>
Site redirects continuosly, starving UI thread, causing app to hang.


Use GetQueueStatus to see if there are input messages in the queue that aren't being processed.
If so, use a low-priority timer instead of PostMessage.


  • platform/win/SharedTimerWin.cpp: (WebCore::setSharedTimerFireTime):
4:11 PM Changeset in webkit [25691] by tristan
  • 8 edits in branches/Safari-2.0-dashboard/WebCore

Merge r24938 and r24946 from ToT to Safari-2.0-dashboard.


2007-08-08 Sam Weinig <sam@webkit.org>


Reviewed by Geoff Garen.

Fix for <rdar://problem/5354635>

Match Firefox's model for data: URLs by not allowing them script access
to any frames other then itself.

  • bindings/js/kjs_window.cpp: (KJS::Window::isSafeScript):
  • dom/Document.cpp: (WebCore::Document::initSecurityPolicyURL):


2007-08-08 Sam Weinig <sam@webkit.org>

Reviewed by Brady.

Make protocol and host compares case-insensitive.

  • bindings/js/kjs_window.cpp: (KJS::Window::isSafeScript):
  • dom/Document.cpp: (WebCore::Document::initSecurityPolicyURL):
  • platform/DeprecatedString.cpp: (WebCore::equalIgnoringCase):
  • platform/DeprecatedString.h: (WebCore::equalIgnoringCase):
3:47 PM Changeset in webkit [25690] by darin
  • 4 edits in trunk/WebCore

Reviewed by Anders.

  • add QueryInterface capabilities to COMPtr
  • platform/win/COMPtr.h: (COMPtr::COMPtr): Added constructor that takes a Query tag and does an appropriate QueryInterface. (COMPtr::query): Added function to do a queryInterface. (COMPtr::copyQueryInterfaceRef): Added private helper used by both of the above. Note that when the query fails you get a 0, which is the same thing you get if a 0 pointer is passed in.
  • platform/win/FontCacheWin.cpp: (WebCore::FontCache::getFontLinkInterface): Convert to using the new query as a test case. Also eliminate the unnecessary second global variable and use COMPtr objects rather than just leaking references.
  • platform/win/WCDataObject.h: Removed unneeded include and using statements.
2:58 PM Changeset in webkit [25689] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5494790>
clicking any link in the Flash regions at bananarepublic.com results in bad page

Don't replace the frame contents, the Mac version doesn't do this.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest):
1:15 PM Changeset in webkit [25688] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5496700>
Repro crash loading http://www.tivo.com/whatistivo/tivohd/index.html

Don't continue if the plug-in cancelled the stream.


  • loader/win/NetscapePlugInStreamLoaderWin.cpp: (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
1:12 PM Changeset in webkit [25687] by kmccullo
  • 2 edits in trunk/WebKitTools

Reviewed by Oliver.

  • We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
  • DumpRenderTree/win/FrameLoaderDelegate.cpp: (FrameLoadDelegate::FrameLoadDelegate):
12:48 PM Changeset in webkit [25686] by kdecker
  • 2 edits in trunk/WebKit
  • Plugins/WebBaseNetscapePluginView.mm: Build fix. The first argument of aglChoosePixelFormat() has changed from const AGLDevice *gdevs on Tiger to const void *gdevs on Leopard.
12:15 PM Changeset in webkit [25685] by kdecker
  • 3 edits in trunk/WebKit

Reviewed by Darin Adler.

<rdar://problem/5493093>

Reduced launch time by lazily linking both the AGL and OpenGL frameworks until they are really needed.

  • Plugins/WebBaseNetscapePluginView.mm: Soft link all AGL and OpenGL functions used by WebBaseNetscapePluginView.
  • WebKit.xcodeproj/project.pbxproj: Removed AGL and OpenGL from the project.
12:14 PM Changeset in webkit [25684] by kdecker
  • 2 edits in trunk/WebCore
  • platform/mac/SoftLinking.h: Build fix; added necessary #imports.
12:06 PM Changeset in webkit [25683] by kdecker
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Darin Adler.

  • WebCore.xcodeproj/project.pbxproj: Added SoftLinking.h to the project.
  • platform/mac/SoftLinking.h: Contains a new macro; useful in helping to lazily load frameworks.
10:15 AM Changeset in webkit [25682] by kmccullo
  • 2 edits in trunk/WebKit/win
  • Fixed a syntax guideline mistake.
  • WebChromeClient.cpp: (WebChromeClient::scrollbarsVisible):
4:06 AM Changeset in webkit [25681] by bdash
  • 2 edits in trunk/JavaScriptCore

2007-09-21 Mark Rowe <mrowe@apple.com>

Reviewed by Antti Koivisto.

http://bugs.webkit.org/show_bug.cgi?id=15250
<rdar://problem/5496942> REGRESSION: Reproducible crash in Safari when evaluating script in Drosera console (15250)

  • kjs/function.cpp: (KJS::GlobalFuncImp::callAsFunction): Null-check thisObj before passing it to interpreterForGlobalObject.
12:02 AM Changeset in webkit [25680] by oliver
  • 3 edits in trunk/WebKit/win

2007-09-20 Oliver Hunt <oliver@apple.com>

Reviewed by Steve.

<rdar://problem/5487153> Korean characters are displayed as garbage with default encoding in some Korean web sites

Adding support for per-localisation default character encodings on
windows.

  • English.lproj/Localizable.strings:
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings):

Sep 20, 2007:

5:48 PM Changeset in webkit [25679] by kmccullo
  • 2 edits in trunk/WebKit/win

Reviewed by Oliver.

  • Added the ability to ask if scrollbars are visible
  • <rdar://problem/5496211> scrollbarsVisible in WebChromeClient is not implemented
  • WebChromeClient.cpp: (WebChromeClient::scrollbarsVisible):
5:28 PM Changeset in webkit [25678] by darin
  • 1 edit in trunk/WebKitLibraries/win/lib

Ignore WebKitAuxiliaryLibraries files put here by update-webkit.

5:27 PM Changeset in webkit [25677] by darin
  • 1 edit in trunk/WebKitLibraries/win/include

Ignore WebKitAuxiliaryLibraries files put here by the update-webkit script.

5:19 PM Changeset in webkit [25676] by adachan
  • 6 edits in trunk

<rdar://problem/5477240> Regression: Footer is too high in print preview


Reviewed by Steve.

WebCore:

Make computePageRectsForFrame() return the height of the page adjusted for margins.

  • bridge/win/FrameWin.cpp: (WebCore::computePageRectsForFrame):
  • bridge/win/FrameWin.h:


WebKit/win:

  • WebFrame.cpp: (WebFrame::WebFrame): initialize new data member m_pageHeight, which is the height of the page adjusted for margins. (WebFrame::computePageRects): get the height of the page adjusted for margins by passing m_pageHeight to computePageRectsForFrame(). (WebFrame::spoolPages): footer rect's top is the max of the bottom of the page content and the bottom of the page minus footer height.
  • WebFrame.h:
4:26 PM Changeset in webkit [25675] by kmccullo
  • 8 edits in trunk

WebCore:

Reviewed by Hyatt.

  • <rdar://problem/5101991> Avril Lavigne music player comes up in a window with scrollbars
  • Implementing missing scrollbar functionality to allow turning off scrollbars correctly.
  • platform/ScrollView.h:
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::setAllowsScrolling): (WebCore::ScrollView::ScrollViewPrivate::allowsScrolling): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::setAllowsScrolling): (WebCore::ScrollView::allowsScrolling):

win:

Reviewed by Hyatt.

  • <rdar://problem/5101991> Avril Lavigne music player comes up in a window with scrollbars
  • Implementing missing scrollbar functionality to allow turning off scrollbars correctly.
  • Interfaces/IWebFrame.idl:
  • Interfaces/IWebFrameView.idl:
  • WebChromeClient.cpp: (WebChromeClient::setScrollbarsVisible):
  • WebFrame.cpp: (WebFrame::setAllowsScrolling): (WebFrame::allowsScrolling): (WebFrame::frameView):
  • WebFrame.h:
4:13 PM Changeset in webkit [25674] by beidson
  • 6 edits in trunk

WebCore:

Reviewed by Dave Hyatt

<rdar://problem/5245981> - No favicon shows up for cnet.com


CNet's favicon has two images in it - a 32x32 white square, and a 16x16 image that is their actual icon
Till now on Windows we've always gone straight for the first image in an icon for the favicon, now we
actually do proper size matching

  • platform/graphics/BitmapImage.h:
  • platform/graphics/Image.h: (WebCore::Image::getHBITMAPOfSize): (WebCore::Image::drawFrameMatchingSourceSize): Search through the frames of the image for the correct size
  • platform/graphics/win/ImageWin.cpp: (WebCore::BitmapImage::getHBITMAP): (WebCore::BitmapImage::getHBITMAPOfSize): (WebCore::BitmapImage::drawFrameMatchingSourceSize):

WebKit/win:

Reviewed by Dave Hyatt

<rdar://problem/5245981> - No favicon shows up for cnet.com


  • WebIconDatabase.cpp: (WebIconDatabase::iconForURL): Call getHBITMAPOfSize (WebIconDatabase::getOrCreateDefaultIconBitmap): Ditto
2:58 PM Changeset in webkit [25673] by sfalken
  • 2 edits in trunk/WebCore

Reviewed by Brady.

Call ascii() instead of utf8() from debug logging code to avoid threading
issues associated w/ converting to UTF8.

11:53 AM Changeset in webkit [25672] by staikos
  • 4 edits in trunk/WebCore

2007-09-20 Mike Fenton <mike@staikos.net>

Reviewed by George Staikos.

Implement gradients and more of canvas for Qt. Style changes and some
of the stroking fixes by George.

  • html/CanvasGradient.cpp: (WebCore::CanvasGradient::CanvasGradient): (WebCore::CanvasGradient::~CanvasGradient): (WebCore::CanvasGradient::addColorStop): (WebCore::CanvasGradient::platformShading):
  • html/CanvasGradient.h:
  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fill): (WebCore::CanvasRenderingContext2D::stroke): (WebCore::CanvasRenderingContext2D::fillRect): (WebCore::CanvasRenderingContext2D::applyFillPattern):
10:26 AM Changeset in webkit [25671] by sullivan
  • 2 edits in trunk/WebKit

Build fix for stoooopid old PPC gcc compiler

  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::checkSpellingOfString): replace perfectly valid ?: syntax with if/else
4:05 AM Changeset in webkit [25670] by ddkilzer
  • 3 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Adam.

Fix: http://bugs.webkit.org/show_bug.cgi?id=15223
webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt

Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
Now isQt() and isGdk() use global variables that are only set once.

An array of all the parameters is now given to build-dumprender which includes
the platform on linux.

  • Scripts/build-dumprendertree:
  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm:
3:53 AM Changeset in webkit [25669] by ddkilzer
  • 1 edit in trunk/WebCore/ChangeLog

Added radar.

1:52 AM Changeset in webkit [25668] by rwlbuis
  • 3 edits
    2 adds in trunk

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=15235
Options can not be removed from a Select element with OptGroup's using JavaScript

Remove HTMLOptionElement children against the proper parent node.

Sep 19, 2007:

11:44 PM Changeset in webkit [25667] by sfalken
  • 1 copy in tags/Safari-523.7b

New tag.

11:44 PM Changeset in webkit [25666] by sfalken
  • 1 edit in trunk/WebKit/win/WebKit.vcproj/VERSION

Bump version for submit

10:56 PM Changeset in webkit [25665] by weinig
  • 2 edits in trunk/WebKit/win

Rubber stamped by Adam Roben.

  • WebKit.vcproj/WebKit.sln: Update location of DumpRenderTree and TestNetscapePlugin to point to their new locations.
7:03 PM Changeset in webkit [25664] by bdash
  • 4 edits in trunk

Versioning.

7:03 PM Changeset in webkit [25663] by bdash
  • 1 copy in tags/Safari-4523.7

New tag.

7:02 PM Changeset in webkit [25662] by bdash
  • 1 copy in tags/Safari-5523.7

New tag.

5:43 PM Changeset in webkit [25661] by sullivan
  • 4 edits in trunk

WebCore:

Reviewed by Darin Adler.


  • WebCore part of speculative fix for <rdar://problem/5490627>, about crashes constructing a String using the values filled in by checkSpellingOfString()
  • editing/Editor.cpp: (WebCore::findFirstMisspellingInRange): initialize out parameters the way we do elsewhere; add many assertions for improper results from checkSpellingOfString(); don't create a String at all until we've checked all the ways that checkSpellingOfString() results could indicate invalid string, even the unexpected ones; as an optimization, don't construct a String at all when looping through to mark all instances.

WebKit:

Reviewed by Darin Adler.

  • WebKit part of speculative fix for <rdar://problem/5490627>, about crashes constructing a String using the values filled in by checkSpellingOfString()
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::checkSpellingOfString): convert NSNotFound to -1, since WebCore code expects -1 for this purpose. We already do this in checkGrammarOfString.
5:17 PM Changeset in webkit [25660] by aroben
  • 1 edit
    1 delete in trunk/WebKitTools

Rubberstamped by Hyatt.

  • Spinneret: Removed.
5:13 PM Changeset in webkit [25659] by bdash
  • 2 edits in branches/Safari-2.0-dashboard/WebKit

2007-09-19 Mark Rowe <mrowe@apple.com>

Merge r18567 from trunk to Safari-2.0-dashboard.

2007-01-03 John Sullivan <sullivan@apple.com>

  • WebView/WebPDFView.mm: (-[WebPDFView _openWithFinder:]): Tiger build fix: use [NSNumber initWithInt:] rather than the new [NSNumber initWithInteger:]
4:55 PM Changeset in webkit [25658] by zecke
  • 2 edits in trunk/JavaScriptCore

2007-09-19 Holger Hans Peter Freyther <zecke@selfish.org>

Rubber stamped by Adam.

Make the guard/#if use the same name (ENABLE_FTPDIR) as the #define. This follows
the ENABLE_ICONDATABASE example from a couple of lines above.

  • wtf/Platform.h:
4:14 PM Changeset in webkit [25657] by zecke
  • 1 edit in trunk/WebCore/ChangeLog

Restore the ChangeLog entries accidently removed by r25646 which was spotted by Mark.

4:00 PM Changeset in webkit [25656] by zecke
  • 4 edits in trunk/WebCore

2007-09-18 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Adam.

There is no need to have FTPDirectoryDocument stubs. We can
compile FTPDirectoryDocument.cpp and FTPDirectoryTokenizer.cpp
instead.

  • WebCore.pro:
  • platform/gdk/TemporaryLinkStubs.cpp:
  • platform/qt/TemporaryLinkStubs.cpp:
4:00 PM Changeset in webkit [25655] by zecke
  • 2 edits in trunk/WebCore

2007-09-18 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Adam.

Remove includes that are not needed.

  • platform/gdk/TemporaryLinkStubs.cpp:
3:59 PM Changeset in webkit [25654] by zecke
  • 3 edits
    1 add in trunk/WebCore

2007-09-18 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Adam.

Move the Pasteboard stubs to PasteboardGdk.cpp.

  • WebCore.pro:
  • platform/gdk/PasteboardGdk.cpp: Added. (WebCore::Pasteboard::generalPasteboard): (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::writeImage): (WebCore::Pasteboard::clear): (WebCore::Pasteboard::canSmartReplace): (WebCore::Pasteboard::documentFragment): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::Pasteboard):
  • platform/gdk/TemporaryLinkStubs.cpp:
3:57 PM Changeset in webkit [25653] by zecke
  • 3 edits
    1 add in trunk/WebCore

2007-09-18 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Adam.

Move the Icon stubs to IconGdk.cpp

  • WebCore.pro:
  • platform/gdk/TemporaryLinkStubs.cpp:
  • platform/graphics/gdk/IconGdk.cpp: Added. (WebCore::Icon::Icon): (WebCore::Icon::~Icon): (WebCore::Icon::newIconForFile):
3:48 PM Changeset in webkit [25652] by zecke
  • 3 edits in trunk/WebCore

2007-09-18 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Adam.

Move the Font stubs to FontGdk.cpp

  • platform/gdk/FontGdk.cpp: (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText):
  • platform/gdk/TemporaryLinkStubs.cpp:
3:45 PM Changeset in webkit [25651] by zecke
  • 3 edits
    1 add in trunk/WebCore

2007-09-18 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Adam.

Move the SearchPopupMenu stubs to SearchPopupMenuGdk.cpp

  • WebCore.pro:
  • platform/gdk/SearchPopupMenuGdk.cpp: Added. (WebCore::SearchPopupMenu::SearchPopupMenu): (WebCore::SearchPopupMenu::saveRecentSearches): (WebCore::SearchPopupMenu::loadRecentSearches): (WebCore::SearchPopupMenu::enabled):
  • platform/gdk/TemporaryLinkStubs.cpp:
3:39 PM Changeset in webkit [25650] by zecke
  • 3 edits
    2 adds in trunk/WebCore

2007-09-18 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Adam.

Move the ContextMenu and ContextMenuItem stubs to
ContextMenuGdk.cpp and ContextMenuItemGdk.cpp.

  • WebCore.pro:
  • platform/gdk/ContextMenuGdk.cpp: Added. (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::~ContextMenu): (WebCore::ContextMenu::appendItem): (WebCore::ContextMenu::setPlatformDescription): (WebCore::ContextMenu::platformDescription): (WebCore::ContextMenu::releasePlatformDescription):
  • platform/gdk/ContextMenuItemGdk.cpp: Added. (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::~ContextMenuItem): (WebCore::ContextMenuItem::releasePlatformDescription): (WebCore::ContextMenuItem::type): (WebCore::ContextMenuItem::setType): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::title): (WebCore::ContextMenuItem::setTitle): (WebCore::ContextMenuItem::platformSubMenu): (WebCore::ContextMenuItem::setSubMenu): (WebCore::ContextMenuItem::setChecked):
  • platform/gdk/TemporaryLinkStubs.cpp:
3:36 PM Changeset in webkit [25649] by zecke
  • 3 edits in trunk/WebCore

2007-09-18 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Adam.

Implement the WebCore::fileSize function using g_stat.

  • platform/gdk/FileSystemGdk.cpp: (WebCore::fileSize):
  • platform/gdk/TemporaryLinkStubs.cpp:
3:33 PM Changeset in webkit [25648] by zecke
  • 4 edits in trunk/WebCore

2007-09-18 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Adam.

Move the ResourceHandle stubs from TemporaryLinkStubs
to the ResourceHandleCurl.cpp file. This affects the
Gtk+ and wx port as they share the curl implementation.

  • platform/gdk/TemporaryLinkStubs.cpp:
  • platform/network/curl/ResourceHandleCurl.cpp: (WebCore::ResourceHandle::willLoadFromCache): (WebCore::ResourceHandle::loadsBlocked):
  • platform/wx/TemporaryLinkStubs.cpp:
3:26 PM Changeset in webkit [25647] by zecke
  • 4 edits in trunk/WebKit/gtk

2007-09-17 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Adam.

WebKitGtkPage and WebKitGtkFrame have a dependency on each other. To
allow client code to include both headers the typedef's for
WebKitGtkFrame, WebKitGtkPage, WebKitGtkFrameData and WebKitGtkNetworkRequest
are moved into webkitgtkdefines.h and included by both webkitgtkpage.h and
webkitgtkframe.h

  • Api/webkitgtkdefines.h:
  • Api/webkitgtkframe.h:
  • Api/webkitgtkpage.h:
3:17 PM Changeset in webkit [25646] by zecke
  • 2 edits in trunk/WebCore

2007-09-17 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Mark.

Take http://bugs.webkit.org/show_bug.cgi?id=15221 into account
and change the variable names from nameSystem to systemName and
change the name of the function to stringByAdoptingFileSystemRepresentation.

  • platform/gdk/FileChooserGdk.cpp: (WebCore::stringByAdoptingFileSystemRepresentation): (WebCore::FileChooser::basenameForWidth):
3:02 PM Changeset in webkit [25645] by kmccullo
  • 2 edits in trunk/LayoutTests

Reviewed by.

  • Layout Test fixe
  • fast/dom/Window/new-window-opener.html:
2:25 PM Changeset in webkit [25644] by kmccullo
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Geoff and Sam.

  • Added test cases for the different features of a new opened window.
  • fast/dom/Window/new-window-opener-expected.txt: Added.
  • fast/dom/Window/new-window-opener.html: Added.
1:51 PM Changeset in webkit [25643] by weinig
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Geoff Garen.

Fix <rdar://problem/5492141> Assertion in isdigit() on windows Safari

Test: fast/css/hexColor-isDigit-assert.html

  • platform/DeprecatedString.cpp: (WebCore::isCharacterAllowedInBase): Check that the character is ascii to avoid an assertions on Windows.

LayoutTests:

Reviewed by Geoff Garen.

Test for <rdar://problem/5492141> Assertion in isdigit() on windows Safari

  • fast/css/hexColor-isDigit-assert-expected.txt: Added.
  • fast/css/hexColor-isDigit-assert.html: Added.
1:17 PM Changeset in webkit [25642] by andersca
  • 3 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/5489879>
Combination of real player with high connection quality in selecting player makes Safari quit.


Prevent the Real Player plug-in from calling the window proc recursively.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::wndProc): (WebCore::PluginViewWin::setNPWindowRect): (WebCore::PluginViewWin::determineQuirks): (WebCore::PluginViewWin::PluginViewWin):
  • plugins/win/PluginViewWin.h: (WebCore::):
11:04 AM Changeset in webkit [25641] by adele
  • 25 edits
    1 move
    2 adds
    2 deletes in trunk

WebCore:

Reviewed by Maciej.

Fix for <rdar://problem/5472062> -webkit-user-select: none makes selection difficult
and for <rdar://problem/5472056> REGRESSION: Cannot type into edit fields on a form (sccsheriff.org)

Tests:

This fix has a few steps:
1) Removes the ignore value for the -webkit-user-select property. We now decide when to prevent selection from starting by calling canStartSelection on the node.
2) Implements canStartSelection which returns false for all elements that used to have -webkit-user-select:ignore set, true for content editable nodes,

and walks up the tree to ask the parent before allowing selection to be started on any other nodes.

3) We used to disallow selection from starting within -webkit-user-select:none blocks, but now we only use canStartSelection for that. This will allow easy selections

in cases like iChat where there's a mix of selectable and non-selectable content.

4) Makes -webkit-user-select inherited. After removing the "ignore" value, -webkit-user-select would behave like it was inherited anyways since we already allowed the text value to override the none value.

  • css/html4.css: Removed all usage of -webkit-user-select: ignore. This is now handled internally with canStartSelection(). Now -webkit-user-select won't be unintentionally overridden by nodes that don't want to allow selection to be started, but do want to honor the -webkit-user-select to determine whether or not selection is allowed at all.
  • editing/SelectionController.cpp: (WebCore::SelectionController::selectAll): Don't try to determine whether selection is allowed inside the root node here. VisiblePosition and Selection creation will keep Selection endpoints out of -webkit-user-select:none regions.


  • dom/Node.h:
  • dom/Node.cpp: (WebCore::Node::canStartSelection): Added. Always allows selection to be started in a content editable node. If there's a parent, ask the parent if starting a selection is allowed. If there's no parent, default to allowing selection.
  • html/HTMLAnchorElement.h:
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::canStartSelection): Added. If its not a link, then calls the base class. Disallows selection for non-editable links. Allows selection for editable links. This logic used to be done in CSSStyleSelector by changing the user-select property.
  • html/HTMLButtonElement.h: (WebCore::HTMLButtonElement::canStartSelection): Added. Disallows selection from starting in buttons.
  • html/HTMLImageElement.h: (WebCore::HTMLImageElement::canStartSelection): Added. Disallows selection from starting in images.
  • html/HTMLInputElement.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::canStartSelection): Added. Disallows selection from anything that's not a text field. Text fields call up to the base class. When they're editable, text controls will always be selectable because of the case for content editable content. Otherwise, they'll respect their parent element's decision about starting a selection.
  • html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::canStartSelection): Added. Disallows selection from starting in popup buttons.
  • page/EventHandler.cpp: (WebCore::EventHandler::selectClosestWordFromMouseEvent): Use canMouseDownStartSelect instead of the ambiguously named shouldSelect(). (WebCore::EventHandler::handleMousePressEventTripleClick): ditto. (WebCore::EventHandler::handleMousePressEventSingleClick): ditto. (WebCore::EventHandler::updateSelectionForMouseDrag): Use canMouseDragExtendSelect. (WebCore::EventHandler::selectCursor): Paint an ibeam in any region that allows you to click to create a selection. (WebCore::EventHandler::canMouseDownStartSelect): Now fires the selectStart event, and calls canStartSelection instead of checking the user-select property. (WebCore::EventHandler::canMouseDragExtendSelect): This is identical to canMouseDownStartSelect because of 12823, even though it seems strange that we would fire the selectStart event here.
  • page/EventHandler.h:
  • page/FocusController.cpp: (WebCore::clearSelectionIfNeeded): Calls canStartSelection instead of checking the user-select property to decide when to prevent selection creation.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::draggableNode): ditto.
  • rendering/RenderObject.h: Removed helper methods that are no longer needed.
  • rendering/RenderStyle.h: Made userSelect inherited. After removing the "ignore" value, -webkit-user-select would behave like it was inherited anyways since we already allowed the text value to override the none value. Removed the SELECT_AUTO and SELECT_IGNORE values since they're no longer used. (WebCore::): (WebCore::RenderStyle::userSelect): (WebCore::RenderStyle::setUserSelect): (WebCore::RenderStyle::initialUserSelect):
  • rendering/RenderStyle.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleRareInheritedData::operator==): (WebCore::RenderStyle::diff):
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Remove case for SELECT_AUTO and SELECT_IGNORE
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): Remove adjustment for links. This is now handled in HTMLAnchorElement::canStartSelection. (WebCore::CSSStyleSelector::applyProperty): Map CSS_VAL_AUTO to SELECT_TEXT. Remove CSS_VAL_IGNORE.

LayoutTests:

Reviewed by Maciej.

Tests for <rdar://problem/5472062> -webkit-user-select: none makes selection difficult
and for <rdar://problem/5472056> REGRESSION: Cannot type into edit fields on a form (sccsheriff.org)

  • fast/css/computed-style-expected.txt: Updated for default -webkit-user-select value.
  • fast/css/computed-style-without-renderer-expected.txt: ditto.
  • editing/selection/5333725.html: Re-enabled.
  • editing/selection/5333725.html-disabled: Removed.
  • editing/selection/user-select-text-inside-user-select-ignore.html-disabled: Removed. Adjusted this test to be more specific and renamed it to textfield-inside-anchor.
  • editing/selection/user-select-text-inside-user-select-ignore-expected.txt: Removed.
  • fast/forms/textfield-inside-anchor-expected.txt: Added.
  • fast/forms/textfield-inside-anchor.html: Added.
10:59 AM Changeset in webkit [25640] by kdecker
  • 3 edits in trunk/WebKit

Reviewed by Darin Adler.

<rdar://problem/5491066> soft link Accelerate.framework


  • Misc/WebGraphicsExtras.c: (WebConvertBGRAToARGB): Improve launch time performance and reduce vsize footprint by soft linking the Accelerate.framework.
  • WebKit.xcodeproj/project.pbxproj: Remove no longer needed frameworks.
9:11 AM Changeset in webkit [25639] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by David Kilzer.

  • Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.
7:40 AM Changeset in webkit [25638] by staikos
  • 2 edits in trunk/WebCore

2007-09-19 George Staikos <staikos@kde.org>

As discussed with Brady and Maciej, on platforms without pthreads, use
IconDatabaseNone for now and don't use pthreads. Fixes Qt Win32 build
for now.

  • loader/icon/IconDatabase.h:
3:07 AM Changeset in webkit [25637] by bdash
  • 2 edits in trunk/JavaScriptCore

2007-09-19 Mark Rowe <mrowe@apple.com>

Reviewed by Maciej.

<rdar://problem/5487107> NULL dereference crash in FastMallocZone::enumerate when running leaks against Safari

Storing remote pointers to their local equivalents in mapped memory was leading to the local pointer being
interpreted as a remote pointer. This caused a crash when using the result of mapping this invalid remote pointer.
The fix is to follow the pattern used elsewhere in FastMallocZone by always doing the mapping after reading and
never storing the mapped pointer.

  • wtf/FastMalloc.cpp: (WTF::FastMallocZone::enumerate):
2:45 AM Changeset in webkit [25636] by antti
  • 4 edits
    2 adds in trunk

WebCore:

Reviewed by Maciej.

Fix <rdar://problem/5488539>
(9A550) iPhone Banner on O2.UK site not clickable with Safari due to styled noscript element


Don't create renderer for noscript if scripts are enabled.


Test: fast/dom/noscript-style.html

  • html/HTMLElement.cpp: (WebCore::HTMLElement::mapToEntry): (WebCore::HTMLElement::parseMappedAttribute): (WebCore::HTMLElement::checkDTD): (WebCore::HTMLElement::rendererIsNeeded): (WebCore::HTMLElement::createRenderer):
  • html/HTMLElement.h:

LayoutTests:

Reviewed by Maciej.


Test for <rdar://problem/5488539>
(9A550) iPhone Banner on O2.UK site not clickable with Safari due to styled noscript element

  • fast/dom/noscript-style-expected.txt: Added.
  • fast/dom/noscript-style.html: Added.

Sep 18, 2007:

11:14 PM Changeset in webkit [25635] by beidson
  • 9 edits in trunk/WebKit/win

Reviewed by Adam

Final part of <rdar://problem/5471308> - Hook up async icon database on Windows

  • CFDictionaryPropertyBag.cpp: (CFDictionaryPropertyBag::CFDictionaryPropertyBag): Took the opportunity to rewrite with a RetainPtr since it became available after the initial implementation (CFDictionaryPropertyBag::setDictionary): (CFDictionaryPropertyBag::dictionary): Added accessor to the CFDictionaryRef to ease use within WebKit (CFDictionaryPropertyBag::QueryInterface): Added IID_CFDictionaryPropertyBag accessor (CFDictionaryPropertyBag::Read): (CFDictionaryPropertyBag::Write):
  • CFDictionaryPropertyBag.h: Added IID_CFDictionaryPropertyBag


  • WebFrame.cpp: (WebFrame::url): Added accessor, gets the current URL from WebCore (WebFrame::dispatchDidReceiveIcon): Calls through to the WebView (WebFrame::registerForIconNotification): Ditto
  • WebFrame.h:
  • WebIconDatabase.cpp: (WebIconDatabase::iconDatabaseDidAddIconNotification): (WebIconDatabase::iconDatabaseNotificationUserInfoURLKey): (WebIconDatabase::iconDatabaseDidRemoveAllIconsNotification): (postDidRemoveAllIconsNotification): (postDidAddIconNotification):
  • WebIconDatabase.h:
  • WebView.cpp: (WebView::close): Unregister for the notification, just in case (WebView::notifyDidAddIcon): Called when the webview gets the didAddIcon notification, compares the url in the notification to the current main frame URL. If they match, calls to dispatchDidReceiveIconFromWebFrame (WebView::registerForIconNotification): (WebView::dispatchDidReceiveIconFromWebFrame): Dispatches the FrameLoadDelegate call. Once the delegate call is dispatched, either via the FrameLoaderClient interface of by listening for a notification, we know that our info is up to date in the IconDatabase and we don't need to listen for the generic notification any long, so we unregister for it here, as well. (WebView::onNotify): The WebView listens for two notifications now, so make the decision which was received
  • WebView.h:
6:39 PM Changeset in webkit [25634] by thatcher
  • 8 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/5478250> REGRESSION: After pasting text copied from Mail subject and typing return, the cursor disappears because of negative left margin

When pasting text from the Mail subject line, the RTF pasteboard contains text that has a first line negative indent along with a
paragraph indent that has a counteracting positive indent. This results in the first line being flush left justified, and the remaining
wrapped lines being indented. When this is converted to a DOM fragment, AppKit makes a block element with a margin-left and a negative
text-indent that matches the RTF. So far this is all correct behavior.

When this content is pasted on the line of an existing paragraph that has content, ReplaceSelectionCommand will decided to merge the paragraphs.
This will convert the block element to a style span that has all inherited style properties. These inherited properties will still contain block
properties that have no affect on inline elements. These block properties will hang around on the style span and will get cloned to new block
elements if the user hit return on that line. The new block elements would then have the text-indent but not the margin-left, so the text would be
hidden off the left edge of the page.

In the end, we should never hang on to block-only properties in our style spans. This cuts out meaningless properties and prevents properties
from magically affecting blocks later if the style is cloned for a new block element during a future editing operation.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Remove any inherited block properties that are now in the span's style.
  • editing/markup.cpp: (WebCore::createMarkup): Ditto.

LayoutTests:

Reviewed by Darin.

Test for <rdar://problem/5478250> REGRESSION: After pasting text copied from Mail subject and typing return, the cursor disappears because of negative left margin

  • editing/pasteboard/5478250.html: Added.
  • platform/mac/editing/pasteboard/5478250-expected.txt: Added.

Updated results that are affected by the style span being removed or added with different style properties.

  • editing/execCommand/5144139-1-expected.txt:
  • editing/execCommand/create-list-with-hr-expected.txt:
  • editing/pasteboard/merge-end-blockquote-expected.txt:
  • editing/pasteboard/styled-element-markup-expected.txt:
5:04 PM Changeset in webkit [25633] by ggaren
  • 2 edits in trunk/WebKitLibraries

Build fix. Ran update-webkitsysteminterface script on Tiger, because
the resulting binary differs when built on Tiger. See
<rdar://problem/5490613>.

  • libWebKitSystemInterface.a:
4:47 PM Changeset in webkit [25632] by hyatt
  • 2 edits
    2 adds in trunk/WebCore

Land a new UnicodeRange helper class that will be used to determine languages for fonts.

4:12 PM Changeset in webkit [25631] by beidson
  • 3 edits in trunk/WebKit/win

Reviewed by Ada and Geoff

Part of <rdar://problem/5471308> - Get async Icon Database fully hooked up on Windows


Hook up main thread delivery of Icon Database notifications from the secondary thread


  • WebIconDatabase.cpp: (WebIconDatabase::WebIconDatabase): Initialize m_deliveryRequested (WebIconDatabase::init): Set the IconDatabaseClient to the shared WebIconDatabase (WebIconDatabase::dispatchDidRemoveAllIcons): Queue the notification to be delivered on the main thread then ask for the delivery (WebIconDatabase::dispatchDidAddIconForPageURL): Ditto (WebIconDatabase::scheduleNotificationDelivery): If the m_deliveryRequested hasn't been set, then set it and perform the callOnMainThread() for WebIconDatabase::deliverNotifications (postDidRemoveAllIconsNotification): (postDidAddIconNotification): (WebIconDatabase::deliverNotifications): Deliver all notifications in the current queue
  • WebIconDatabase.h:
3:59 PM Changeset in webkit [25630] by weinig
  • 1 edit in trunk/WebKitTools/DumpRenderTree/win/GCControllerWin.cpp

Touch file in DRT to recompile it now. Frowny-face.

3:54 PM Changeset in webkit [25629] by ggaren
  • 3 edits in trunk/WebKitLibraries

Build fix. Ran update-webkitsysteminterface script.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
3:25 PM Changeset in webkit [25628] by aroben
  • 1 copy in tags/Safari-523.6.1b

New tag.

3:25 PM Changeset in webkit [25627] by aroben
  • 1 edit in trunk/WebKit/win/WebKit.vcproj/VERSION

Bump version for submit

3:23 PM Changeset in webkit [25626] by ggaren
  • 2 edits in trunk/WebKit

Reviewed by Darin Adler.


Fixed <rdar://problem/5490204> In some cases, WebKit can make the
Foundation disk cache way too big or way too small


Use the actual location of the foundation disk cache, rather than
the user's home directory, when determining how big to make it.

  • WebView/WebView.mm: (+[WebView _setCacheModel:]):
3:16 PM Changeset in webkit [25625] by weinig
  • 1 edit in trunk/JavaScriptCore/kjs/CommonIdentifiers.cpp

Touch JavaScriptCore file to force rebuild.

2:34 PM Changeset in webkit [25624] by hyatt
  • 2 edits in trunk/WebCore

Fix some HDC badness with my previous checkin.

2:32 PM Changeset in webkit [25623] by weinig
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.

Patch for <rdar://problem/5488478> Safari crashes when passing null to Range.insertNode()

Test: fast/dom/Range-insertNode-crash.html

  • dom/Range.cpp: (WebCore::Range::insertNode): Null check the passed in node to insert.

LayoutTests:

Reviewed by Darin.

Test for <rdar://problem/5488478> Safari crashes when passing null to Range.insertNode()

  • fast/dom/Range-insertNode-crash-expected.txt: Added.
  • fast/dom/Range-insertNode-crash.html: Added.
1:59 PM Changeset in webkit [25622] by weinig
  • 2 edits in trunk/WebKitTools

Add JSRetainPtr.h #include to fix some builds.

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:
1:58 PM Changeset in webkit [25621] by staikos
  • 2 edits in trunk/WebCore

2007-09-18 Mike Fenton <mike@staikos.net>

Reviewed by George Staikos.

Retain the pen properties when changing one aspect of the pen.

  • html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor):
1:55 PM Changeset in webkit [25620] by staikos
  • 2 edits in trunk/WebCore

2007-09-18 Mike Fenton <mike@staikos.net>

Reviewed by George Staikos.

Make <canvas> work in more cases by restarting the painter after we
finish painting, and restoring the pen and opacity.

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::paint):
11:33 AM Changeset in webkit [25619] by weinig
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.

Test: fast/dom/CSSStyleDeclaration-empty-string-property.html

  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::cssPropertyName): Added an early return if the property name is the empty string, thus avoiding a loop that is not prepared for that case.

LayoutTests:

Reviewed by Darin.

  • fast/dom/CSSStyleDeclaration-empty-string-property-expected.txt: Added.
  • fast/dom/CSSStyleDeclaration-empty-string-property.html: Added.
10:52 AM Changeset in webkit [25618] by darin
  • 2 edits in trunk/WebCore

Reviewed by Adam.

  • fix <rdar://problem/5415734> <select> dras incorrectly if size of menu options is changed after it pops up once
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::PopupMenu): Removed unnecessary initialization of IntRect. (WebCore::PopupMenu::show): Check that the clientRect is empty instead of checking the entire windowRect -- this fixes a bug where we pop up a tiny 2-pixel high black box when you click on an empty menu. (WebCore::PopupMenu::visibleItems): Base the number of items on the client rect instead of the window rect. Rounding down means this would have worked anyway, but it's more correct to do it this way. (WebCore::PopupMenu::paint): Deallocate the bitmap so it gets reallocated if it has the wrong width or height (or if GetObject returns false, which should not happen in practice).
10:23 AM Changeset in webkit [25617] by harrison
  • 12 edits in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/5486974> REGRESSION(r25373): 1/4 second to doubleclick word in GMail when using Kotoeri IM, also slow in other IMs (15163)

Updated tests:

  • fast/dom/Window/window-xy-properties-expected.txt:
  • fast/dom/plugin-attributes-enumeration-expected.txt:
  • fast/events/onerror-bubbling-expected.txt:
  • fast/events/related-target-expected.txt:
  • fast/forms/select-namedItem-expected.txt:
  • fast/table/incomplete-table-in-fragment-2-expected.txt:
  • fast/table/incomplete-table-in-fragment-hang-expected.txt:
  • fast/table/large-rowspan-crash-expected.txt:
  • plugins/embed-attributes-setting-expected.txt:
  • editing/TextIterator.cpp: (WebCore::TextIterator::shouldRepresentNodeOffsetZero): Avoid VisiblePosition check if the current node is a descendant of the start container and the start offset was 0. In that case we already had enough context to correctly decide whether to emit a newline after a preceding block. We chose not to emit (m_haveEmitted is false), so don't second guess that.


(WebCore::TextIterator::exitNode):
Changed some comments.

LayoutTests:

Reviewed by Darin.

Updated for:
<rdar://problem/5486974> REGRESSION(r25373): 1/4 second to doubleclick word in GMail when using Kotoeri IM, also slow in other IMs (15163)

NOTE: This reverts the test result changes I made for rdar://5472125, back to not emitting
a newline for collapsed block or hr at start of range.


  • fast/dom/Window/window-xy-properties-expected.txt:
  • fast/dom/plugin-attributes-enumeration-expected.txt:
  • fast/events/onerror-bubbling-expected.txt:
  • fast/events/related-target-expected.txt:
  • fast/forms/select-namedItem-expected.txt:
  • fast/table/incomplete-table-in-fragment-2-expected.txt:
  • fast/table/incomplete-table-in-fragment-hang-expected.txt:
  • fast/table/large-rowspan-crash-expected.txt:
  • plugins/embed-attributes-setting-expected.txt:
6:55 AM Changeset in webkit [25616] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Adam.

  • Scripts/prepare-ChangeLog:
  • Properly parse GECOS field.
  • Use git configuration for user name and email when appropriate.

Sep 17, 2007:

11:08 PM Changeset in webkit [25615] by weinig
  • 2 edits in trunk/WebKitTools

Build fix.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
10:56 PM Changeset in webkit [25614] by weinig
  • 4 edits
    3 moves
    1 delete in trunk/WebKitTools

Reviewed by Adam Roben.

Share more code between mac and windows DRT.

  • GCController is now shared.
  • Rename WaitUntilDoneDelegate to FrameLoadDelegate for consistency.
  • DumpRenderTree/GCController.cpp:
  • DumpRenderTree/win/DumpRenderTree.cpp:
  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/FrameLoaderDelegate.cpp: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.cpp. (FrameLoadDelegate::FrameLoadDelegate): (FrameLoadDelegate::~FrameLoadDelegate): (FrameLoadDelegate::windowScriptObjectAvailable):
  • DumpRenderTree/win/FrameLoaderDelegate.h: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.h.
  • DumpRenderTree/win/GCController.cpp: Removed.
  • DumpRenderTree/win/GCController.h: Removed.
  • DumpRenderTree/win/GCControllerWin.cpp: Copied from DumpRenderTree/win/GCController.cpp. (GCController::collect): (GCController::collectOnAlternateThread): (GCController::getJSObjectCount):
  • DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Removed.
  • DumpRenderTree/win/WaitUntilDoneDelegate.h: Removed.
7:44 PM Changeset in webkit [25613] by weinig
  • 7 edits
    3 moves
    4 deletes in trunk/WebKitTools

Reviewed by Adam Roben.

Begin sharing code between mac and windows DRT.

  • both now share LayoutTestController.h/cpp and implement platform dependant operations in LayoutTestControllerMac/Win.
  • DumpRenderTree.h is now shared.
  • WorkQueue and WorkQueueItem are also shared.
  • DumpRenderTree/DumpRenderTree.h:
  • DumpRenderTree/LayoutTestController.cpp:
  • DumpRenderTree/win/DumpRenderTree.cpp: (displayWebView): (dumpFrameScrollPosition): (dumpFramesAsText): (dump): (runTest):
  • DumpRenderTree/win/DumpRenderTree.h: Removed.
  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/DumpRenderTreeWin.h: Copied from DumpRenderTree/win/DumpRenderTree.h.
  • DumpRenderTree/win/EditingDelegate.cpp: (EditingDelegate::shouldBeginEditingInDOMRange): (EditingDelegate::shouldEndEditingInDOMRange): (EditingDelegate::shouldInsertNode): (EditingDelegate::shouldInsertText): (EditingDelegate::shouldDeleteDOMRange): (EditingDelegate::shouldChangeSelectedDOMRange): (EditingDelegate::shouldApplyStyle): (EditingDelegate::shouldChangeTypingStyle): (EditingDelegate::doPlatformCommand): (EditingDelegate::webViewDidBeginEditing): (EditingDelegate::webViewDidChange): (EditingDelegate::webViewDidEndEditing): (EditingDelegate::webViewDidChangeTypingStyle): (EditingDelegate::webViewDidChangeSelection):
  • DumpRenderTree/win/LayoutTestController.cpp: Removed.
  • DumpRenderTree/win/LayoutTestController.h: Removed.
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: Copied from DumpRenderTree/win/LayoutTestController.cpp. (LayoutTestController::addDisallowedURL): (LayoutTestController::clearBackForwardList): (LayoutTestController::copyDecodedHostName): (LayoutTestController::copyEncodedHostName): (LayoutTestController::display): (LayoutTestController::keepWebHistory): (LayoutTestController::notifyDone): (LayoutTestController::queueBackNavigation): (LayoutTestController::queueForwardNavigation): (jsStringRefToWString): (LayoutTestController::queueLoad): (LayoutTestController::queueReload): (LayoutTestController::queueScript): (LayoutTestController::setAcceptsEditing): (LayoutTestController::setCustomPolicyDelegate): (LayoutTestController::setMainFrameIsFirstResponder): (LayoutTestController::setTabKeyCyclesThroughElements): (LayoutTestController::setUseDashboardCompatibilityMode): (LayoutTestController::setUserStyleSheetEnabled): (LayoutTestController::setUserStyleSheetLocation): (LayoutTestController::setWindowIsKey): (waitUntilDoneWatchdogFired): (LayoutTestController::setWaitToDump): (LayoutTestController::windowCount):
  • DumpRenderTree/win/WaitUntilDoneDelegate.cpp: (FrameLoadDelegate::didReceiveTitle): (FrameLoadDelegate::processWork): (FrameLoadDelegate::locationChangeDone): (FrameLoadDelegate::windowScriptObjectAvailable):
  • DumpRenderTree/win/WorkQueue.cpp: Removed.
  • DumpRenderTree/win/WorkQueue.h: Removed.
  • DumpRenderTree/win/WorkQueueItem.cpp: Removed.
  • DumpRenderTree/win/WorkQueueItem.h: Removed.
  • DumpRenderTree/win/WorkQueueItemWin.cpp: Copied from DumpRenderTree/win/WorkQueueItem.cpp. (jsStringRefToWString): (LoadItem::invoke): (ScriptItem::invoke):
7:11 PM Changeset in webkit [25612] by ggaren
  • 8 edits in trunk

WebCore:

Reviewed by Darin Adler.

Speculative fix for <rdar://problem/5479443> REGRESSION: Hang due to
infinite JS recursion on close @ engadget.com (onunload-based ad)


If page is NULL, shouldInterruptScript now returns true, so you can't
get stuck in a state in which a script executes forever without putting
up a UI to ask if it should stop.

  • bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::shouldInterruptScript):

WebKit:

Reviewed by Darin Adler.

Fixed a hang due to an infinite script running in the window's unload
event handler, which may be the cause of <rdar://problem/5479443>
REGRESSION: Hang due to infinite JS recursion on close @ engadget.com
(onunload-based ad)

  • WebView/WebUIDelegatePrivate.h: Added FIXME.


  • WebView/WebView.h: Clarified headerdoc ambiguity about when delegate methods stop firing.
  • WebView/WebView.mm: (-[WebView _close]): The fix: don't nil out our delegates until after detaching the FrameLoader, because the act of detaching the FrameLoader might fire important delegate methods, like webViewShouldInterruptJavaScript:. Don't do other tear-down either, because the unload event handler needs to run in a fully constructed page.


This change is fairly low risk because niling out our delegates is a
very recent, never-shipped feature in WebKit, so it's unlikely that any
apps rely on it in a crazy way.

win:

Reviewed by Darin Adler.

Fixed a hang due to an infinite script running in the window's unload
event handler, which may be the cause of <rdar://problem/5479443>
REGRESSION: Hang due to infinite JS recursion on close @ engadget.com
(onunload-based ad)


Added a bunch of WebKitMac's close features, and reordered others to
match WebKitMac.

  • WebView.cpp: (WebView::close): (WebView::removeDragCaret):
5:36 PM Changeset in webkit [25611] by hyatt
  • 5 edits in trunk/WebCore

Fix for 14743, missing glyphs because of mlang's tiny font cache.

5:30 PM Changeset in webkit [25610] by aroben
  • 3 edits
    1 add in trunk/WebCore

Fix <rdar://5423441> Should get focus ring color from SafariTheme

Reviewed by Hyatt.

No regression test possible.

  • WebCore.vcproj/WebCore.vcproj: Added ColorSafari.cpp.
  • platform/graphics/win/ColorSafari.cpp: Added. (WebCore::makeRGBAFromCGColor): Added. (WebCore::focusRingColor): Added. Gets the focus ring color from SafariTheme if SafariTheme has support for it. (WebCore::setFocusRingColorChangeFunction): Added.
  • platform/win/TemporaryLinkStubs.cpp: Removed focus ring color functions.
5:27 PM Changeset in webkit [25609] by andersca
  • 3 edits in trunk/WebCore

Fix Windows build.

  • WebCore.vcproj/WebCore.vcproj:
  • loader/NetscapePlugInStreamLoader.h:
5:22 PM Changeset in webkit [25608] by andersca
  • 3 edits
    1 copy in trunk/WebCore

Fix Mac build.


  • loader/NetscapePlugInStreamLoader.cpp:
  • loader/NetscapePlugInStreamLoader.h:
  • loader/win/NetscapePlugInStreamLoaderWin.cpp: Copied from loader/NetscapePlugInStreamLoader.cpp.
5:11 PM Changeset in webkit [25607] by andersca
  • 6 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5483346>
crash at vw.com WebCore::PluginViewWin::disconnectStream.


The following events would lead to this crash:


  1. a plug-in stream finishes loading and calls NPP_DestroyStream.
  2. the DestroyStream handler calls NPN_Evaluate, submitting a form through JavaScript.
  3. A new page is going to be loaded and DocumentLoader::stopLoading is called.
  4. DocumentLoader::stopLoading will stop all loader, including the one that is done loading!


The fix is to port NetscapePluginStreamLoader over from the Mac code and use it instead. This fixes the crash
because it disassociates the stream loader with the document loader _before_ calling NPP_DestroyStream, whereas
SubresourceLoader does this _after_ calling NPP_DestroyStream.


  • loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader): (WebCore::NetscapePlugInStreamLoader::~NetscapePlugInStreamLoader): (WebCore::NetscapePlugInStreamLoader::create): (WebCore::NetscapePlugInStreamLoader::isDone): (WebCore::NetscapePlugInStreamLoader::releaseResources): (WebCore::NetscapePlugInStreamLoader::didReceiveResponse): (WebCore::NetscapePlugInStreamLoader::didReceiveData): (WebCore::NetscapePlugInStreamLoader::didFinishLoading): (WebCore::NetscapePlugInStreamLoader::didFail): (WebCore::NetscapePlugInStreamLoader::didCancel):
  • loader/NetscapePlugInStreamLoader.h: (WebCore::NetscapePlugInStreamLoaderClient::didFinishLoading):
  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::didReceiveResponse): (WebCore::PluginStreamWin::didReceiveData): (WebCore::PluginStreamWin::didFail): (WebCore::PluginStreamWin::didFinishLoading):
  • plugins/win/PluginStreamWin.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::load):
5:06 PM Changeset in webkit [25606] by andersca
  • 3 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5483839>
Crash loading http://www.microsoft.com if Silverlight 1.0 is installed.


Work around a problem in our NPRuntime implementation by never unloading the silverlight plug-in dll.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::~PluginViewWin): (WebCore::PluginViewWin::determineQuirks):
  • plugins/win/PluginViewWin.h: (WebCore::):
4:41 PM Changeset in webkit [25605] by beidson
  • 1 edit in trunk/WebCore/ChangeLog

Having bad Changelog composition issues today

4:38 PM Changeset in webkit [25604] by beidson
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan

Fix for http://bugs.webkit.org/show_bug.cgi?id=15178
and
<rdar://problem/5474001>

The stress test proves that this was an overzealous ASSERT. It is very possible to mark and icon
for addition to the on-disk database and then mark it for removal before it is ever added. This
is not an error and was already handled gracefully

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::removeIconFromSQLDatabase): Don't ASSERT of log if the icon wasn't on disk
3:59 PM Changeset in webkit [25603] by beidson
  • 1 edit in trunk/WebCore/ChangeLog

Reviewed by Oliver

<rdar://problem/5487048> - ASSERT in stress test in IconDatabase

If a PageURLRecord went away, it never clears its URL from the IconRecord it retained.

  • loader/icon/PageURLRecord.cpp: (WebCore::PageURLRecord::~PageURLRecord): Set the icon record to 0, clearing the page url
  • loader/icon/PageURLRecord.h: Add the destructor
3:55 PM Changeset in webkit [25602] by beidson
  • 1 edit in trunk/WebCore/ChangeLog

That Changelog was HORRIBLE

3:54 PM Changeset in webkit [25601] by beidson
  • 3 edits in trunk/WebCore

Reviewed by Oliver

<rdar://problem/5487048> - ASSERT in stress test in IconDatabase

If a PageURLRecord went away, it never clear it's URL from the IconRecord it retained.

  • loader/icon/PageURLRecord.cpp: (WebCore::PageURLRecord::~PageURLRecord): Set the icon record to 0, clearing the page url
  • loader/icon/PageURLRecord.h: Add the destructor
2:34 PM Changeset in webkit [25600] by aroben
  • 2 edits in trunk/WebKit/win

Fix <rdar://4979801> overflow divs don't respond to keyboard scrolling (affects RSS pages)

Reviewed by Hyatt.

  • WebView.cpp: (WebView::keyDown): Attempt to scroll an overflow area before scrolling the whole frame.
1:43 PM Changeset in webkit [25599] by beidson
  • 1 edit in trunk/WebKit/win/WebKitDLL.cpp

Didn't save this line before checking in *sigh*

1:42 PM Changeset in webkit [25598] by antti
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.


Fix <rdar://problem/5480050>
Leopard9A551 with Dashcode 112: Dashcode crash when dragging image into canvas.


If @import stylesheet was modified through CSS DOM style selector would not get updated. This
could lead to crashes.

Test: fast/css/import-style-update.html

  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::styleSheetChanged):

LayoutTests:

Reviewed by Darin.


Test for <rdar://problem/5480050>
Leopard9A551 with Dashcode 112: Dashcode crash when dragging image into canvas.


Non-crashing test case, but it demonstrates the same problem that would crash
under some circumstances.

  • fast/css/import-style-update-expected.txt: Added.
  • fast/css/import-style-update.html: Added.
1:41 PM Changeset in webkit [25597] by beidson
  • 2 edits in trunk/WebKit/win

Reviewed by Adam


<rdar://problem/5471308> - Get async Icon Database fully hooked up on Windows


Add a global "shut down WebKit" procedure to do cleanup at the engine level on quit.
Critical now for the IconDatabase and might be for other things in the future.

  • WebKitDLL.cpp: (shutDownWebKit): For now, just close the IconDatabase (DllMain): On DLL_PROCESS_DETACH, call shutDownWebKit
11:53 AM Changeset in webkit [25596] by weinig
  • 2 edits in trunk/WebKitTools/DumpRenderTree

Add svn:ignore for moved directories

11:48 AM Changeset in webkit [25595] by weinig
  • 3 edits
    25 copies
    1 add
    1 delete in trunk/WebKitTools

Reviewed by Adam Roben.

  • Move Windows DumpRenderTree and TestNetscapePlugin to WebCoreTools/DumpRenderTree/win
  • DumpRenderTree/DumpRenderTree.sln: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln.
  • DumpRenderTree/DumpRenderTree.vcproj: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/main.c: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/resource.h: Removed.
  • DumpRenderTree/win: Added.
  • DumpRenderTree/win/DraggingInfo.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h.
  • DumpRenderTree/win/DumpRenderTree.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp.
  • DumpRenderTree/win/DumpRenderTree.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h.
  • DumpRenderTree/win/DumpRenderTree.vcproj: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj.
  • DumpRenderTree/win/EditingDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp.
  • DumpRenderTree/win/EditingDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h.
  • DumpRenderTree/win/EventSender.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp.
  • DumpRenderTree/win/EventSender.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h.
  • DumpRenderTree/win/GCController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp.
  • DumpRenderTree/win/GCController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h.
  • DumpRenderTree/win/LayoutTestController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp.
  • DumpRenderTree/win/LayoutTestController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h.
  • DumpRenderTree/win/TestNetscapePlugin: Copied from DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin.
  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
  • DumpRenderTree/win/UIDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp.
  • DumpRenderTree/win/UIDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h.
  • DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp.
  • DumpRenderTree/win/WaitUntilDoneDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h.
  • DumpRenderTree/win/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
  • DumpRenderTree/win/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
  • DumpRenderTree/win/WorkQueueItem.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp.
  • DumpRenderTree/win/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
  • DumpRenderTree/win/debug.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops.
  • DumpRenderTree/win/debug_internal.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops.
  • DumpRenderTree/win/release.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops.
  • Scripts/run-webkit-tests: Update to point to the new location of the sln.
11:01 AM Changeset in webkit [25594] by andersca
  • 9 edits in trunk

WebCore:

Reviewed by Adam.

<rdar://problem/5421997>
http://bugs.webkit.org/show_bug.cgi?id=14247
Display problem with Flash - image does not stop changing


Port the manual load code over from the Mac version.

  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::createPluginView):
  • plugins/win/PluginDatabaseWin.h: Add load manually parameter.


  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::stop): If we're loading manually, cancel the main resource load.


(WebCore::PluginStreamWin::destroyStream):
Don't disconnect the stream if we're loading manually.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::setFrameGeometry): Always call updateWindow()


(WebCore::PluginViewWin::PluginViewWin):
Initialize loadManually.


(WebCore::PluginViewWin::init):
Don't set the width and height of the window here since it will make the plug-in HWND show briefly
before it's been positioned.


(WebCore::PluginViewWin::didReceiveResponse):
Create the manual stream.


(WebCore::PluginViewWin::didReceiveData):
(WebCore::PluginViewWin::didFinishLoading):
(WebCore::PluginViewWin::didFail):
Call through to the manual stream.


  • plugins/win/PluginViewWin.h:

win:

Reviewed by Adam.

<rdar://problem/5421997>
http://bugs.webkit.org/show_bug.cgi?id=14247
Display problem with Flash - image does not stop changing

Port the manual load code over from the Mac version.

  • WebFrame.cpp: (WebFrame::WebFramePrivate::WebFramePrivate): Initialize the plugin pointer.


(WebFrame::finishedLoading):
(WebFrame::setMainDocumentError):
(WebFrame::committedLoad):
Feed the data to the plug-in.


(WebFrame::redirectDataToPlugin):
Store the plug-in widget.

7:57 AM Changeset in webkit [25593] by zecke
  • 4 edits in trunk/WebKit/gtk

2007-09-17 Cyril Brulebois <cyril.brulebois@enst-bretagne.fr>

Reviewed by Mark, some Coding Style changes by Holger.

This is from http://bugs.webkit.org/show_bug.cgi?id=14812.

Add title and location to WebKitGtkFramePrivate, add
webkit_gtk_frame_get_location to the WebKitGtkFrame API as well
as a title_changed callback, implement
webkit_gtk_frame_get_title and webkit_gtk_frame_get_location.

Initial patch by Diego Escalante Urrelo.

  • Api/webkitgtkframe.cpp:
  • Api/webkitgtkframe.h:
  • Api/webkitgtkprivate.h:
7:56 AM Changeset in webkit [25592] by zecke
  • 2 edits in trunk/WebCore

2007-09-15 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Mark.

Convert the filenames from WebCore::String to the filesystem encoding
and vice versa using g_filename_{from,to}_utf8 functions. Also add the needed NULL
checks for the return values where glib and gtk+ can return NULL.

  • platform/gdk/FileChooserGdk.cpp: (WebCore::convertToStringByAdoptingTheFilesystemRepresentation): (WebCore::FileChooser::openFileChooser): (WebCore::FileChooser::basenameForWidth):
Note: See TracTimeline for information about the timeline view.