Timeline



Oct 8, 2007:

6:52 PM Changeset in webkit [26155] by eseidel
  • 3 edits in branches/feature-branch/WebKitTools

HackTop [26957:WebKitTools]% less ChangeLog Stuff/Projects/WebKit/WebKitTools
2007-10-08 Eric Seidel <eric@webkit.org>

Reviewed by Mark Rowe.

  • Scripts/build-webkit: add --help, remove unused --color
4:15 PM Changeset in webkit [26154] by oliver
  • 8 edits in branches/feature-branch

Add closing markers for merge

End merging of trunk:25970-26102

4:14 PM Changeset in webkit [26153] by oliver
  • 2 edits in branches/feature-branch/WebCore

Fix Bug 15305: Crash when dragging an image when "load images automatically" preference is off

http://bugs.webkit.org/show_bug.cgi?id=15305
<rdar://problem/5524774>

Reviewed by Eric Seidel.

No test possible: to reproduce this you have to change a WebKit

preference and reload the page. See
http://bugs.webkit.org/show_bug.cgi?id=15414

  • platform/win/ClipboardWin.cpp: (WebCore::createGlobalImageFileDescriptor): ASSERT that we have an image and that it has a SharedBuffer. (WebCore::writeImageToDataObject): The fix: null-check imageBuffer.
4:14 PM Changeset in webkit [26152] by oliver
  • 2 edits in branches/feature-branch/WebKitTools

2007-10-07 Holger Hans Peter Freyther <zecke@selfish.org>

Rubber stamped by Eric.

Connect to the "hovering-over-link" signal emitted by WebKitPage and
show the current link inside the statusbar.
This shows how to make use of this signal and allows to easily test
http://bugs.webkit.org/show_bug.cgi?id=15299.

  • GtkLauncher/main.cpp: (hoveringOverLink): (main):
4:14 PM Changeset in webkit [26151] by oliver
  • 8 edits in branches/feature-branch

JavaScriptCore:

Reviewed by Sam Weinig.

Added JSObject::removeDirect, to support the fix for
<rdar://problem/5522487> REGRESSION: With JavaScript disabled, any
page load causes a crash in PropertyMap::put

  • kjs/object.cpp: (KJS::JSObject::removeDirect):
  • kjs/object.h:

WebCore:

Reviewed by Sam Weinig.

New fix for <rdar://problem/5522487> REGRESSION: With JavaScript
disabled, any page load causes a crash in PropertyMap::put

Explicitly remove the "document" property from the window. The old
solution would leave a stale "document" property around after JavaScript
was re-enabled.

The architecture for disabling JavaScript could use some consolidation.
It seems wrong that a script proxy even exists when JavaScript is
disabled. It also seems wrong that so many individual call sites are
responsible for checking whether JavaScript is enabled. I've filed a
bug about this: http://bugs.webkit.org/show_bug.cgi?id=15385.

  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::clearDocumentWrapper):
  • bindings/js/kjs_proxy.h:
  • page/Frame.cpp: (WebCore::Frame::setDocument):
4:14 PM Changeset in webkit [26150] by oliver
  • 2 edits in branches/feature-branch/WebCore

2007-10-05 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Anders.

<rdar://5520913> Ticketmaster.com doesn't display correctly (Flash
related?)

The plugin is requesting files that don't exist on the server, and
we are passing the 404 error page to the plugin. This change cancels the
stream if the response code indicates a failure.

This is a port of the safari / mac code.

  • loader/win/NetscapePlugInStreamLoaderWin.cpp: (WebCore::NetscapePlugInStreamLoader::didReceiveResponse): If the response code indicates a failure, cancel the stream
4:13 PM Changeset in webkit [26149] by oliver
  • 2 edits in branches/feature-branch/WebCore

Reviewed by Sam Weinig.

Fixed <rdar://problem/5522487> REGRESSION: With JavaScript disabled,
any page load causes a crash in PropertyMap::put

The problem was that we were using JavaScript when JavaScript was
disabled. The architecture for disabling JavaScript could use some
consolidation, but this is the simplest, safest change for now.

Currently passing layout tests still pass.

  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::updateDocumentWrapper):
4:13 PM Changeset in webkit [26148] by oliver
  • 4 edits in branches/feature-branch

WebCore:

Reviewed by John Sullivan.

Fix for <rdar://problem/5441823> REGRESSION (r25142, Tiger only):
Vertical scroll bar not redrawn properly when going back in history
(15033)

This fix if-defs r25142 to be Leopard-only since it causes
correctness issues on Tiger and does not seem to have any
performance impact on Tiger either.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::transitionToCommitted):

WebKit:

Reviewed by John Sullivan.

Fix for <rdar://problem/5441823> REGRESSION (r25142, Tiger only):
Vertical scroll bar not redrawn properly when going back in history
(15033)

This fix if-defs r25142 to be Leopard-only since it causes
correctness issues on Tiger and does not seem to have any
performance impact on Tiger either.

  • WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView setScrollBarsSuppressed:repaintOnUnsuppress:]): (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
4:13 PM Changeset in webkit [26147] by oliver
  • 2 edits in branches/feature-branch/WebKit/win

<rdar://problem/5436617>
Implement WebIconDatabase::delayDatabaseCleanup() and WebIconDatabase::allowDatabaseCleanup().

Reviewed by Brady.

  • WebIconDatabase.cpp: (WebIconDatabase::delayDatabaseCleanup): (WebIconDatabase::allowDatabaseCleanup):
4:12 PM Changeset in webkit [26146] by oliver
  • 2 edits in branches/feature-branch/WebCore

<rdar://problem/5436617> Favicons sometimes don't show up even when they are
in the database

  • A client can try to retain an icon for a page before the database is actually opened. Since isOpened() is not a requirement to retain an icon, remove the check for that. Instead, we'll check to make sure whether this database is enabled before proceeding.

Reviewed by Brady.

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::retainIconForPageURL): (WebCore::IconDatabase::releaseIconForPageURL): only check isOpen() before we schedule for a sync.
4:12 PM Changeset in webkit [26145] by oliver
  • 5 edits in branches/feature-branch/LayoutTests/platform/qt

these tests deliver the same results as on the Mac, which
makes them pass :)

4:12 PM Changeset in webkit [26144] by oliver
  • 4 edits in branches/feature-branch

fix a hang in editing/selection/extend-by-word-002.html

4:11 PM Changeset in webkit [26143] by oliver
  • 1 edit
    2 adds in branches/feature-branch/WebKitTools

forgot to add these files in r26061.

4:11 PM Changeset in webkit [26142] by oliver
  • 14 deletes in branches/feature-branch/LayoutTests/platform/qt/traversal

remove platform specific results, after r26045 turned
these tests into being text only.

4:11 PM Changeset in webkit [26141] by oliver
  • 1 edit in branches/feature-branch/LayoutTests/platform/qt/Skipped

remove four more passing tests from the skipped list.

4:10 PM Changeset in webkit [26140] by oliver
  • 10 edits in branches/feature-branch

add proper error messages to the FrameLoaderClient.
Implement ChromeClientQt::closeWindowSoon and
FrameLoaderClientQt::dispatchCreatePage (which should go
away IMO).
Some fixes in DRT to make it work correctly with multiple
windows.

4:10 PM Changeset in webkit [26139] by oliver
  • 9 edits in branches/feature-branch

Add a dummy plugin to DRT to fix fast/dom/Window/Plug-Ins.html.
Add support for layoutTextController.setCanOpenWindows() to DRT
fixing another 2 test cases in fast/dom/Window.

4:09 PM Changeset in webkit [26138] by oliver
  • 8 edits in branches/feature-branch

2007-10-04 Mark Rowe <mrowe@apple.com>

Reviewed by Oliver.

Switch to default level of debugging symbols to resolve <rdar://problem/5488678>.
The "full" level appears to offer no observable benefits even though the documentation
suggests it be used for dead code stripping. This should also decrease link times.

  • Configurations/Base.xcconfig:
4:09 PM Changeset in webkit [26137] by oliver
  • 1 edit in branches/feature-branch/WebKitTools/ChangeLog

Rubber stamped by Adam.

Remove empty directories.

  • DumpRenderTree/DumpRenderTree.qtproj: Removed.
  • DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
4:09 PM Changeset in webkit [26136] by oliver
  • 2 edits in branches/feature-branch/WebKit/win
  • Interfaces/IWebViewPrivate.idl: Moving setInitialFocus down to the end to avoid breaking the OpenSource build.
4:08 PM Changeset in webkit [26135] by oliver
  • 10 edits in branches/feature-branch

WebCore:

Reviewed by Darin.

WebCore part of fix for <rdar://problem/5369017> REGRESSION: Can't tab to webview that doesn't have editable content

  • page/FocusController.h: Added FocusDirection argument.
  • page/FocusController.cpp: (WebCore::FocusController::setInitialFocus): Use FocusDirection argument instead of key modifiers to send direction to advanceFocus.
  • WebCore.exp: Updated symbol.

WebKit:

Reviewed by Darin.

WebKit part of fix for <rdar://problem/5369017> REGRESSION: Can't tab to webview that doesn't have editable content

  • WebView/WebHTMLView.mm: (-[WebHTMLView becomeFirstResponder]): Pass in the FocusDirection.

win:

Reviewed by Darin.

WebKit/win part of fix for <rdar://problem/5369017> REGRESSION: Can't tab to webview that doesn't have editable content

  • WebView.cpp: Added setInitialFocus so the application can specify that its handing off focus to WebKit and so that it can specify the focus direction.
  • WebView.h: ditto.
  • Interfaces/IWebViewPrivate.idl: ditto.
4:05 PM Changeset in webkit [26134] by oliver
  • 2 edits in branches/feature-branch/WebKit
  • WebView/WebHTMLView.mm: (-[WebHTMLView _updateActiveState]): Removed a bogus comment.
4:04 PM Changeset in webkit [26133] by oliver
  • 15 edits
    14 adds
    42 deletes in branches/feature-branch/LayoutTests

Rubber-stamped by Darin.

Make traversal tests dumpAsText.

  • platform/mac/traversal: Removed.
  • platform/mac/traversal/node-iterator-001-expected.checksum: Removed.
  • platform/mac/traversal/node-iterator-001-expected.png: Removed.
  • platform/mac/traversal/node-iterator-001-expected.txt: Removed.
  • platform/mac/traversal/node-iterator-002-expected.checksum: Removed.
  • platform/mac/traversal/node-iterator-002-expected.png: Removed.
  • platform/mac/traversal/node-iterator-002-expected.txt: Removed.
  • platform/mac/traversal/node-iterator-003-expected.checksum: Removed.
  • platform/mac/traversal/node-iterator-003-expected.png: Removed.
  • platform/mac/traversal/node-iterator-003-expected.txt: Removed.
  • platform/mac/traversal/node-iterator-004-expected.checksum: Removed.
  • platform/mac/traversal/node-iterator-004-expected.png: Removed.
  • platform/mac/traversal/node-iterator-004-expected.txt: Removed.
  • platform/mac/traversal/node-iterator-005-expected.checksum: Removed.
  • platform/mac/traversal/node-iterator-005-expected.png: Removed.
  • platform/mac/traversal/node-iterator-005-expected.txt: Removed.
  • platform/mac/traversal/node-iterator-006-expected.checksum: Removed.
  • platform/mac/traversal/node-iterator-006-expected.png: Removed.
  • platform/mac/traversal/node-iterator-006-expected.txt: Removed.
  • platform/mac/traversal/node-iterator-007-expected.checksum: Removed.
  • platform/mac/traversal/node-iterator-007-expected.png: Removed.
  • platform/mac/traversal/node-iterator-007-expected.txt: Removed.
  • platform/mac/traversal/node-iterator-008-expected.checksum: Removed.
  • platform/mac/traversal/node-iterator-008-expected.png: Removed.
  • platform/mac/traversal/node-iterator-008-expected.txt: Removed.
  • platform/mac/traversal/stay-within-root-expected.checksum: Removed.
  • platform/mac/traversal/stay-within-root-expected.png: Removed.
  • platform/mac/traversal/stay-within-root-expected.txt: Removed.
  • platform/mac/traversal/tree-walker-001-expected.checksum: Removed.
  • platform/mac/traversal/tree-walker-001-expected.png: Removed.
  • platform/mac/traversal/tree-walker-001-expected.txt: Removed.
  • platform/mac/traversal/tree-walker-002-expected.checksum: Removed.
  • platform/mac/traversal/tree-walker-002-expected.png: Removed.
  • platform/mac/traversal/tree-walker-002-expected.txt: Removed.
  • platform/mac/traversal/tree-walker-003-expected.checksum: Removed.
  • platform/mac/traversal/tree-walker-003-expected.png: Removed.
  • platform/mac/traversal/tree-walker-003-expected.txt: Removed.
  • platform/mac/traversal/tree-walker-004-expected.checksum: Removed.
  • platform/mac/traversal/tree-walker-004-expected.png: Removed.
  • platform/mac/traversal/tree-walker-004-expected.txt: Removed.
  • platform/mac/traversal/tree-walker-005-expected.checksum: Removed.
  • platform/mac/traversal/tree-walker-005-expected.png: Removed.
  • platform/mac/traversal/tree-walker-005-expected.txt: Removed.
  • traversal/node-iterator-001-expected.txt: Added.
  • traversal/node-iterator-001.html:
  • traversal/node-iterator-002-expected.txt: Added.
  • traversal/node-iterator-002.html:
  • traversal/node-iterator-003-expected.txt: Added.
  • traversal/node-iterator-003.html:
  • traversal/node-iterator-004-expected.txt: Added.
  • traversal/node-iterator-004.html:
  • traversal/node-iterator-005-expected.txt: Added.
  • traversal/node-iterator-005.html:
  • traversal/node-iterator-006-expected.txt: Added.
  • traversal/node-iterator-006.html:
  • traversal/node-iterator-007-expected.txt: Added.
  • traversal/node-iterator-007.html:
  • traversal/node-iterator-008-expected.txt: Added.
  • traversal/node-iterator-008.html:
  • traversal/stay-within-root-expected.txt: Added.
  • traversal/stay-within-root.html:
  • traversal/tree-walker-001-expected.txt: Added.
  • traversal/tree-walker-001.html:
  • traversal/tree-walker-002-expected.txt: Added.
  • traversal/tree-walker-002.html:
  • traversal/tree-walker-003-expected.txt: Added.
  • traversal/tree-walker-003.html:
  • traversal/tree-walker-004-expected.txt: Added.
  • traversal/tree-walker-004.html:
  • traversal/tree-walker-005-expected.txt: Added.
  • traversal/tree-walker-005.html:
4:03 PM Changeset in webkit [26132] by oliver
  • 2 edits in branches/feature-branch/WebCore

Reviewed by John.

<rdar://problems/5516309>

  • page/FrameView.cpp: (WebCore::FrameView::updateControlTints): Avoid the expense of updating tints on controls for the empty-window case since this can take a significant amount of time even on windows that have no content at all. Note this fix specifically optimizes the empty window/tab case; for a more broad fix John wrote up rdar://problem/5521050.
4:03 PM Changeset in webkit [26131] by oliver
  • 2 edits in branches/feature-branch/WebCore
  • page/Frame.h: Put functions into categories to indicate other classes we'd like to move them into in the future. Just organizational -- no code change.
4:02 PM Changeset in webkit [26130] by oliver
  • 3 edits
    2 adds in branches/feature-branch

fix a crash in the FrameLoader that can happen under certain
conditions in the Qt port.

4:01 PM Changeset in webkit [26129] by oliver
  • 1 edit
    1 move in branches/feature-branch/LayoutTests

forgot to move one file in the last commit.

4:00 PM Changeset in webkit [26128] by oliver
  • 1 edit
    317 adds
    317 deletes in branches/feature-branch/LayoutTests

Move png files that are not test results and where mistakenly moved in r26026
back to where they belong.

3:59 PM Changeset in webkit [26127] by oliver
  • 2 edits in branches/feature-branch/WebKitTools

Reviewed by Adam.

  • Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if we find the internal libraries in the libraries directory. This is helpful for Safari team engineers at Apple.
3:58 PM Changeset in webkit [26126] by oliver
  • 4 edits in branches/feature-branch/WebKit/win

<rdar://problem/5521230> Implement IWebIconDatabase::iconURLForURL in WebKit for windows

Reviewed by Steve and Brady.

  • Interfaces/IWebIconDatabase.idl:
  • WebIconDatabase.cpp: (WebIconDatabase::iconURLForURL):
  • WebIconDatabase.h:
3:51 PM Changeset in webkit [26125] by oliver
  • 1 edit
    8920 adds
    8914 deletes in branches/feature-branch/LayoutTests

Move pixel test results that were mistakenly left in place after r25970

Rubberstamped by Sam.

3:42 PM Changeset in webkit [26124] by oliver
  • 2 edits in branches/feature-branch/LayoutTests

Add some sometimes-timing-out tests to the Skipped file

Rubberstamped by Sam.

  • platform/win/Skipped:
3:39 PM Changeset in webkit [26123] by oliver
  • 2 edits in branches/feature-branch/WebKitTools

Update the location of AHEM_.TTF after r25968

Reviewed by Sam.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3:36 PM Changeset in webkit [26122] by oliver
  • 23 edits in branches/feature-branch

2007-10-03 Alp Toker <alp@atoker.com>

Reviewed by Adam.

http://bugs.webkit.org/show_bug.cgi?id=14726
[gtk] API design. Mapping the WebView delegates to signals.

Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.

3:33 PM Changeset in webkit [26121] by oliver
  • 7 edits in branches/feature-branch/WebCore

2007-10-03 Alp Toker <alp@atoker.com>

Reviewed by Eric.

http://bugs.webkit.org/show_bug.cgi?id=14129
[CAIRO] Support the canvas element

Add a new canvas implementation using Cairo for rendering.

  • html/CanvasGradient.cpp: (WebCore::CanvasGradient::CanvasGradient): (WebCore::CanvasGradient::~CanvasGradient): (WebCore::CanvasGradient::addColorStop): (WebCore::CanvasGradient::platformShading):
  • html/CanvasGradient.h:
  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setFillStyle): (WebCore::CanvasRenderingContext2D::fill): (WebCore::CanvasRenderingContext2D::stroke): (WebCore::CanvasRenderingContext2D::fillRect): (WebCore::CanvasRenderingContext2D::drawImage): (WebCore::CanvasRenderingContext2D::applyStrokePattern):
  • html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor):
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::~HTMLCanvasElement): (WebCore::HTMLCanvasElement::reset): (WebCore::HTMLCanvasElement::paint): (WebCore::HTMLCanvasElement::createDrawingContext): (WebCore::HTMLCanvasElement::createPlatformImage):
  • html/HTMLCanvasElement.h:
3:30 PM Changeset in webkit [26120] by oliver
  • 3 edits in branches/feature-branch/WebKit/gtk

2007-10-02 Cosimo Cecchi <cosimoc@svn.gnome.org>

Reviewed by Mark.

http://bugs.webkit.org/show_bug.cgi?id=15299
Fix "hovering_over_link" signal being fired every time mouse moves.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::ChromeClient): (WebKit::ChromeClient::mouseDidMoveOverElement):
  • WebCoreSupport/ChromeClientGtk.h:
3:26 PM Changeset in webkit [26119] by oliver
  • 3 edits in branches/feature-branch/WebKit/gtk

2007-09-21 Sean Egan <seanegan@gmail.com>

Reviewed by Alp.

Add an "execute_script" method to programmatically call Javascript
http://bugs.webkit.org/show_bug.cgi?id=15255

  • Api/webkitgtkpage.cpp:
  • Api/webkitgtkpage.h:
3:24 PM Changeset in webkit [26118] by oliver
  • 2 edits in branches/feature-branch/WebKitTools

This fixes --strict mode in run-webkit-tests again after
the platform dependent test results have been moved.

3:21 PM Changeset in webkit [26117] by oliver
  • 2 edits in branches/feature-branch/JavaScriptCore

Fix a stupid bug in Unicode::toUpper/toLower.
Fixes all three test failures in the JavaScriptCore test
suite.

3:17 PM Changeset in webkit [26116] by oliver
  • 2 edits
    25 adds in branches/feature-branch/LayoutTests/platform/qt

add some more passing tests, and update one result.

3:14 PM Changeset in webkit [26115] by oliver
  • 4 edits
    1 add
    4 deletes in branches/feature-branch

remove the hack in run-webkit-tests that forced text only test
to be taken from the platform independent dir. It was only left
there from early days.

Remove platform dependent results for tests that are text only nowadays,
and add one platform dependent result for a text only test that requires it.

3:11 PM Changeset in webkit [26114] by oliver
  • 7 adds in branches/feature-branch/LayoutTests/platform/qt

add some more results.

3:05 PM Changeset in webkit [26113] by oliver
  • 1 edit
    4428 adds
    4291 deletes in branches/feature-branch/LayoutTests

Move all test results that are platform dependent but
stored in the platform independent part to their
correct locations (inside platform/mac).

This will make it a lot easier to maintain test
results for other platforms than mac.

Signed off by aroben.

2:59 PM Changeset in webkit [26112] by oliver
  • 7 edits in branches/feature-branch

Add initial merge markers for 25970-26102 trunk merge

2:24 PM Changeset in webkit [26111] by eseidel
  • 3 edits
    2 moves in branches/feature-branch/WebCore

2007-10-08 Eric Seidel <eric@webkit.org>

Reviewed by Oliver.

Build fix. Fix circular build rule for CSS*.in files evident on clean build.

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • ksvg2/css/CSSPropertyNames.in: Removed.
  • ksvg2/css/CSSValueKeywords.in: Removed.
  • ksvg2/css/SVGCSSPropertyNames.in: Copied from ksvg2/css/CSSPropertyNames.in.
  • ksvg2/css/SVGCSSValueKeywords.in: Copied from ksvg2/css/CSSValueKeywords.in.
2:07 PM Changeset in webkit [26110] by weinig
  • 3 edits
    2 adds in trunk

Merge r26108 from feature-branch to trunk.

1:33 PM Changeset in webkit [26109] by eseidel
  • 15 edits
    4 adds
    2 deletes in branches/feature-branch

2007-10-08 Eric Seidel <eric@webkit.org>

Reviewed by hyatt.

Implement getComputedStyle support for SVG CSS values
http://bugs.webkit.org/show_bug.cgi?id=15422


This also unifies SVG and non-SVG CSS hash lookups. A unified hash
solves correctness problems as well as offers improved speed.


Test: svg/css/getComputedStyle-basic.xhtml

  • DerivedSources.make: unify SVG and non-SVG CSS hash files
  • WebCore.xcodeproj/project.pbxproj: remove old SVG CSS hash files
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): call getPropertyCSSValue
  • css/CSSComputedStyleDeclaration.h: add getPropertyCSSValue
  • css/CSSGrammar.y:
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
  • css/CSSStyleDeclaration.cpp: (WebCore::propertyID):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • ksvg2/css/CSSPropertyNames.in: remove font-size-adjust
  • ksvg2/css/SVGCSSComputedStyleDeclaration.cpp: Added. (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue): added.
  • ksvg2/css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue):
  • ksvg2/css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
  • ksvg2/scripts/cssmakeprops: Removed.
  • ksvg2/scripts/cssmakevalues: Removed.
  • ksvg2/svg/SVGAnimationElement.cpp:
  • ksvg2/svg/SVGStyledElement.cpp: (WebCore::mapAttributeToCSSProperty): (WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName): remove font-size-adjust
11:37 AM Changeset in webkit [26108] by weinig
  • 3 edits
    2 adds in branches/feature-branch

WebCore:

Reviewed by Steve Falkenburg;

Fix for <rdar://problem/5519698> CrashTracer: [USER] 47 crashes in Safari at com.apple.WebCore: WebCore::XMLTokenizer::lineNumber const + 9

Test: fast/innerHTML/innerHTML-script-tag-crash.xhtml

  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::lineNumber): Return 1 when there is no context. (WebCore::XMLTokenizer::columnNumber): ditto.

LayoutTests:

Reviewed by Steve Falkenburg.

Test for <rdar://problem/5519698> CrashTracer: [USER] 47 crashes in Safari at com.apple.WebCore: WebCore::XMLTokenizer::lineNumber const + 9

  • fast/innerHTML/innerHTML-script-tag-crash-expected.txt: Added.
  • fast/innerHTML/innerHTML-script-tag-crash.xhtml: Added.
11:05 AM Changeset in webkit [26107] by ap
  • 2 edits in branches/feature-branch/WebCore
  • platform/mac/FontPlatformDataMac.mm: (WebCore::FontPlatformData::setFont): Restored one of the -1 checks removed in the previous change - we do need to check m_font!
9:53 AM Changeset in webkit [26106] by eseidel
  • 2 edits in branches/feature-branch/WebKitTools

2007-10-07 Eric Seidel <eric@webkit.org>

Reviewed by darin.

  • Drosera/mac/DebuggerDocumentPlatform.mm: (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
9:21 AM Changeset in webkit [26105] by ap
  • 2 edits in branches/feature-branch/WebCore

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=15397
Layout tests freeze in HashTable::lookup

Fixes a DRT freeze on PowerPC.

  • platform/mac/FontPlatformDataMac.mm: (WebCore::FontPlatformData::FontPlatformData): Don't ask for a size of a nil font, the result is undefined. (WebCore::FontPlatformData::setFont): Ditto. Also removed some checks for -1 that were not sufficient, and thus likely unnecessary,
9:16 AM Changeset in webkit [26104] by zimmermann
  • 13 edits in branches/feature-branch/LayoutTests

Not reviewed.
Forgot to land some result test changes in my last commit.

Oct 7, 2007:

5:41 PM Changeset in webkit [26103] by zimmermann
  • 35 edits in branches/feature-branch

Reviewed by Eric.

Fix some issues with rotation & baseline-shift, when spanning
across <tspan> elements. Highlighted by the existing batik tests.

5:14 PM Changeset in webkit [26102] by aroben
  • 2 edits in trunk/WebCore

Fix Bug 15305: Crash when dragging an image when "load images automatically" preference is off

http://bugs.webkit.org/show_bug.cgi?id=15305
<rdar://problem/5524774>

Reviewed by Eric Seidel.

No test possible: to reproduce this you have to change a WebKit

preference and reload the page. See
http://bugs.webkit.org/show_bug.cgi?id=15414

  • platform/win/ClipboardWin.cpp: (WebCore::createGlobalImageFileDescriptor): ASSERT that we have an image and that it has a SharedBuffer. (WebCore::writeImageToDataObject): The fix: null-check imageBuffer.
7:37 AM Changeset in webkit [26101] by bdash
  • 4 edits
    2 adds in branches/feature-branch

2007-10-07 Mark Rowe <mrowe@apple.com>

Reviewed by Maciej.

Bug 5122: Need an equivalent of Mozilla's DOMContentLoaded event
http://bugs.webkit.org/show_bug.cgi?id=5122

This is based on a patch by Daniel Peebles (pumpkingod@gmail.com).

Test: http/tests/loading/DOMContentLoaded-event.html

  • dom/Document.cpp: (WebCore::Document::finishedParsing): Dispatch the DOMContentLoaded event when parsing completes.
  • dom/EventNames.h: Add DOMContentLoaded to the list of events.

2007-10-07 Mark Rowe <mrowe@apple.com>

Reviewed by Maciej.

Test for Bug 5122: Need an equivalent of Mozilla's DOMContentLoaded event
http://bugs.webkit.org/show_bug.cgi?id=5122

  • http/tests/loading/DOMContentLoaded-event-expected.txt: Added.
  • http/tests/loading/DOMContentLoaded-event.html: Added.
5:17 AM Changeset in webkit [26100] by zimmermann
  • 5 edits in branches/feature-branch/LayoutTests

Reviewed by Mark.
Fix textLength.svg testcase - missed xmlns.

4:21 AM Changeset in webkit [26099] by ap
  • 4 edits in branches/feature-branch/JavaScriptCore

2007-10-07 Ed Schouten <ed@fxq.nl>

Reviewed and landed by Alexey Proskuryakov.

Add PLATFORM(FREEBSD), so we can fix the build on FreeBSD-like
systems by including <pthread_np.h>. Also fix some (disabled)
regcomp()/regexec() code; it seems some variable names have
changed.

  • kjs/config.h:
  • kjs/regexp.cpp: (KJS::RegExp::RegExp):
  • wtf/Platform.h:
4:16 AM Changeset in webkit [26098] by ap
  • 1 edit in branches/feature-branch/JavaScriptCore/tests/mozilla/expected.html

Forgot to commit this with r25958.

1:54 AM Changeset in webkit [26097] by ap
  • 3 edits
    4 adds in branches/feature-branch

Reviewed by Eric Seidel.

http://bugs.webkit.org/show_bug.cgi?id=15368
xsl:import fails when preceded by comment

Test: fast/xsl/import-after-comment.xml

  • xml/XSLStyleSheet.cpp: (WebCore::XSLStyleSheet::loadChildSheets): It's OK for xsl:import to be preceded by non-element nodes.
1:37 AM Changeset in webkit [26096] by eseidel
  • 5 edits
    6 adds in branches/feature-branch

2007-10-07 Vincent Ricard <magic@magicninja.org>

Reviewed by Maciej. Landed by eseidel.

http://bugs.webkit.org/show_bug.cgi?id=15062
Implement document.compatMode

Tests: fast/dom/compatMode-AlmostStrict.html

fast/dom/compatMode-Compat.html
fast/dom/compatMode-Strict.html

  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::compatMode):
  • html/HTMLDocument.h:
  • html/HTMLDocument.idl:
1:07 AM Changeset in webkit [26095] by zecke
  • 2 edits in trunk/WebKitTools

2007-10-07 Holger Hans Peter Freyther <zecke@selfish.org>

Rubber stamped by Eric.

Connect to the "hovering-over-link" signal emitted by WebKitPage and
show the current link inside the statusbar.
This shows how to make use of this signal and allows to easily test
http://bugs.webkit.org/show_bug.cgi?id=15299.

  • GtkLauncher/main.cpp: (hoveringOverLink): (main):
1:06 AM Changeset in webkit [26094] by eseidel
  • 16 edits
    1 add in branches/feature-branch

2007-10-07 Sam Weinig <sam@webkit.org>

Reviewed by Darin & Nikolas. Landed by eseidel.

Patch for http://bugs.webkit.org/show_bug.cgi?id=14455
Autogenerate the JS bindings for the StyleSheetList

  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSStyleSheetListCustom.cpp: Added. (WebCore::JSStyleSheetList::canGetItemsForName): (WebCore::JSStyleSheetList::nameGetter):
  • bindings/js/kjs_css.cpp:
  • bindings/js/kjs_css.h:
  • bindings/objc/DOMUtility.mm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • css/StyleSheetList.cpp: (WebCore::StyleSheetList::StyleSheetList): (WebCore::StyleSheetList::documentDestroyed): (WebCore::StyleSheetList::getNamedItem):
  • css/StyleSheetList.h: Add Document member variable and getNamedItem function to accommodate the odd javascript name getter functionality.
  • css/StyleSheetList.idl:
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document):
  • page/DOMWindow.idl: Add StyleSheetListConstructor
12:40 AM Changeset in webkit [26093] by eseidel
  • 2 edits in branches/feature-branch/WebCore

2007-10-07 Lars Naesbye Christensen <lars@naesbye.dk>

Reviewed by Eric Seidel.

make CSS cell cursor more mac-like
http://bugs.webkit.org/show_bug.cgi?id=15325

  • Resources/cellCursor.png:

Oct 6, 2007:

10:08 PM Changeset in webkit [26092] by eseidel
  • 3 edits in branches/feature-branch/WebCore

2007-10-06 Eric Seidel <eric@webkit.org>

Reviewed by Oliver.


SVG does not correctly handle onfocusin, onfocusout or onactivate
http://bugs.webkit.org/show_bug.cgi?id=12573

Test: svg/W3C-SVG-1.1/script-handle-02-b.svg

  • ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::parseMappedAttribute):
  • ksvg2/svg/svgattrs.in: add onfocusin, onfocusout and onactivate
7:00 PM SVG TODO List - Short notes edited by eric@webkit.org
(diff)
5:23 PM SVG TODO List - Short notes edited by zimmermann@kde.org
Fix some typos. (diff)
5:22 PM SVG TODO List - Short notes edited by zimmermann@kde.org
(diff)
5:20 PM SVG TODO List - Short notes edited by zimmermann@kde.org
(diff)
4:55 PM SVG TODO List - Short notes edited by zimmermann@kde.org
(diff)
4:55 PM SVG TODO List - Short notes edited by zimmermann@kde.org
Nicer output. (diff)
4:50 PM SVG TODO List - Short notes edited by zimmermann@kde.org
(diff)
3:47 PM Changeset in webkit [26091] by zimmermann
  • 3 edits in branches/feature-branch/WebCore

Reviewed by Oliver.
Never pass null input images to CICrop filter.

3:00 PM Changeset in webkit [26090] by zimmermann
  • 3 edits in branches/feature-branch/LayoutTests

Reviewed by Mark.

Remove useless onload/onunload handlers from js-update-container.svg,
causing a console message saying these handlers don't exist.

2:51 PM Changeset in webkit [26089] by zimmermann
  • 724 edits
    3 deletes in branches/feature-branch/LayoutTests

Rubberstamped by Oliver.
Update SVG baseline with Tiger. No regressions.

1:58 PM Changeset in webkit [26088] by bdash
  • 8 edits in tags/Safari-4523.10.3

Merge r26050.

1:19 PM Changeset in webkit [26087] by bdash
  • 1 copy in tags/Safari-4523.10.3

New tag.

1:19 PM Changeset in webkit [26086] by bdash
  • 4 edits in tags/Safari-5523.10.3

Versioning.

1:18 PM Changeset in webkit [26085] by bdash
  • 8 edits in tags/Safari-5523.10.3

Merge r26074.

JavaScriptCore:

Reviewed by Sam Weinig.

Added JSObject::removeDirect, to support the fix for
<rdar://problem/5522487> REGRESSION: With JavaScript disabled, any
page load causes a crash in PropertyMap::put

  • kjs/object.cpp: (KJS::JSObject::removeDirect):
  • kjs/object.h:

WebCore:

Reviewed by Sam Weinig.

New fix for <rdar://problem/5522487> REGRESSION: With JavaScript
disabled, any page load causes a crash in PropertyMap::put

Explicitly remove the "document" property from the window. The old
solution would leave a stale "document" property around after JavaScript
was re-enabled.

The architecture for disabling JavaScript could use some consolidation.
It seems wrong that a script proxy even exists when JavaScript is
disabled. It also seems wrong that so many individual call sites are
responsible for checking whether JavaScript is enabled. I've filed a
bug about this: http://bugs.webkit.org/show_bug.cgi?id=15385.

  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::clearDocumentWrapper):
  • bindings/js/kjs_proxy.h:
  • page/Frame.cpp: (WebCore::Frame::setDocument):
1:18 PM Changeset in webkit [26084] by bdash
  • 2 edits in tags/Safari-5523.10.3/WebCore

Merge r26071.

Reviewed by Sam Weinig.

Fixed <rdar://problem/5522487> REGRESSION: With JavaScript disabled,
any page load causes a crash in PropertyMap::put

The problem was that we were using JavaScript when JavaScript was
disabled. The architecture for disabling JavaScript could use some
consolidation, but this is the simplest, safest change for now.

Currently passing layout tests still pass.

  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::updateDocumentWrapper):
1:08 PM Changeset in webkit [26083] by bdash
  • 1 copy in tags/Safari-5523.10.3

New tag.

6:30 AM Changeset in webkit [26082] by bdash
  • 3 edits in branches/feature-branch/WebCore

2007-10-06 Mark Rowe <mrowe@apple.com>

Reviewed by Alp Toker.

Gtk+ build fix and minor code cleanup.

  • WebCore.pro:
  • platform/gtk/FontCacheGtk.cpp: (WebCore::FontCache::getLastResortFallbackFont): (WebCore::FontCache::fontExists):
4:00 AM Changeset in webkit [26081] by ap
  • 3 edits
    2 adds in branches/feature-branch

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=15380
XPath: id('foo') doesn't resolve correctly

Test: fast/xpath/id-simple.html

  • xml/XPathFunctions.cpp: (WebCore::XPath::FunId::evaluate): Fixed a logic error in id() parameter parsing.
3:44 AM Changeset in webkit [26080] by ap
  • 1 edit in branches/feature-branch/WebCore/ChangeLog

Removing a conflict marker.

2:08 AM Changeset in webkit [26079] by ap
  • 2 edits in branches/feature-branch/LayoutTests
  • fast/dom/xmlhttprequest-get-expected.txt: Updated event properties for changes made in bug 15102.
1:56 AM Changeset in webkit [26078] by ap
  • 36 edits
    4 deletes in branches/feature-branch

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13707
REGRESSION: JavaScript exceptions on quotes.burntelectrons.org

http://bugs.webkit.org/show_bug.cgi?id=12628
document.body is not supported in XHTML documents

http://bugs.webkit.org/show_bug.cgi?id=14213
On page with MIME type application/xhtml+xml, cookie don't work

WebCore:

Moved a bunch of methods and properties from HTMLDocument down into Document to make
them available for all documents (xml, svg).
What was kept in HTMLDocument:

  • some methods and properties that are not in HTML5 (yet?);
  • open/write/writeln/close, as they will need to be modified to work on XML documents, and aren't of much use for those anyway;
  • designMode, because its definition in HTML5 is incompatible with our implementation.

Covered by existing tests.

  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::location): (WebCore::JSDocument::setLocation):
  • bindings/js/JSHTMLDocumentCustom.cpp:
  • bindings/objc/PublicDOMInterfaces.h:
  • dom/Document.cpp: (WebCore::Document::setBody): (WebCore::Document::cookie): (WebCore::Document::setCookie): (WebCore::Document::lastModified):
  • dom/Document.h: (WebCore::Document::title):
  • dom/Document.idl:
  • html/HTMLDocument.cpp:
  • html/HTMLDocument.h:
  • html/HTMLDocument.idl:

LayoutTests:

  • dom/xhtml/level2/html/HTMLBaseElement01-expected.checksum: Removed.
  • dom/xhtml/level2/html/HTMLBaseElement01-expected.png: Removed.
  • dom/xhtml/level2/html/HTMLBaseElement01-expected.txt:
  • dom/xhtml/level2/html/HTMLBaseElement01.xhtml:
  • dom/xhtml/level2/html/HTMLBaseElement02-expected.checksum: Removed.
  • dom/xhtml/level2/html/HTMLBaseElement02-expected.png: Removed.
  • dom/xhtml/level2/html/HTMLBaseElement02-expected.txt:
  • dom/xhtml/level2/html/HTMLBaseElement02.xhtml:
  • dom/xhtml/level2/html/HTMLBodyElement07-expected.txt:
  • dom/xhtml/level2/html/HTMLBodyElement08-expected.txt:
  • dom/xhtml/level2/html/HTMLBodyElement09-expected.txt:
  • dom/xhtml/level2/html/HTMLBodyElement10-expected.txt:
  • dom/xhtml/level2/html/HTMLBodyElement11-expected.txt:
  • dom/xhtml/level2/html/HTMLBodyElement12-expected.txt:
  • dom/xhtml/level2/html/HTMLDocument01-expected.txt:
  • dom/xhtml/level2/html/HTMLDocument02-expected.txt:
  • dom/xhtml/level2/html/HTMLDocument03-expected.txt:
  • dom/xhtml/level2/html/HTMLDocument05-expected.txt:
  • dom/xhtml/level2/html/HTMLDocument07-expected.txt:
  • dom/xhtml/level2/html/HTMLDocument08-expected.txt:
  • dom/xhtml/level2/html/HTMLDocument09-expected.txt:
  • dom/xhtml/level2/html/HTMLDocument10-expected.txt:
  • dom/xhtml/level2/html/HTMLDocument11-expected.txt:
  • dom/xhtml/level2/html/HTMLDocument12-expected.txt:
  • dom/xhtml/level2/html/HTMLDocument13-expected.txt:
  • dom/xhtml/level2/html/HTMLDocument14-expected.txt:
  • dom/xhtml/level2/html/doc01-expected.txt: These now pass. Changed HTMLBaseElement* to dump as text.
  • fast/dom/Window/window-properties-expected.txt: Added Document.prototype.getElementsByName
1:49 AM Changeset in webkit [26077] by eseidel
  • 21 edits in branches/feature-branch/WebCore

2007-10-06 Eric Seidel <eric@webkit.org>

Reviewed by Oliver Hunt.

RenderSVGContainer (<g>) should not repaint when its bounds change (unless it has a filter)
http://bugs.webkit.org/show_bug.cgi?id=15388
This makes the Sun Lively Kernel invalidate only what it should!


No tests possible in DRT.

  • ksvg2/svg/SVGCircleElement.cpp: (WebCore::SVGCircleElement::notifyAttributeChange): replace call to rebuildRenderer
  • ksvg2/svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::notifyAttributeChange): replace call to rebuildRenderer
  • ksvg2/svg/SVGImageElement.cpp: (WebCore::SVGImageElement::notifyAttributeChange): replace call to rebuildRenderer (WebCore::SVGImageElement::hasRelativeValues): implemented
  • ksvg2/svg/SVGImageElement.h:
  • ksvg2/svg/SVGLineElement.cpp: (WebCore::SVGLineElement::notifyAttributeChange): replace call to rebuildRenderer
  • ksvg2/svg/SVGPathElement.cpp: (WebCore::SVGPathElement::notifyAttributeChange): replace call to rebuildRenderer
  • ksvg2/svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::notifyAttributeChange): replace call to rebuildRenderer
  • ksvg2/svg/SVGRectElement.cpp: (WebCore::SVGRectElement::notifyAttributeChange): replace call to rebuildRenderer
  • ksvg2/svg/SVGStyledElement.cpp:
  • ksvg2/svg/SVGStyledElement.h: (WebCore::SVGStyledElement::hasRelativeValues): default to true instead
  • ksvg2/svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::updateLocalTransform): don't layout if no change
  • ksvg2/svg/SVGStyledTransformableElement.h:
  • ksvg2/svg/SVGTransform.h:
  • rendering/RenderPath.cpp: (WebCore::RenderPath::layout):
  • rendering/RenderPath.h:
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout): (WebCore::RenderSVGContainer::selfWillPaint): return true if have a filter (WebCore::RenderSVGContainer::paint):
  • rendering/RenderSVGContainer.h:
  • rendering/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::layout):
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::layout):
  • rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::layout): (WebCore::RenderSVGViewportContainer::calcViewport): use floats
1:28 AM Changeset in webkit [26076] by rwlbuis
  • 16 edits in branches/feature-branch/WebCore

Reviewed by Eric.

Use document() instead of ownerDocument() and a few other cleanups.

Oct 5, 2007:

5:56 PM Changeset in webkit [26075] by eseidel
  • 6 edits in branches/feature-branch/WebCore

2007-10-05 Eric Seidel <eric@webkit.org>

Reviewed by Oliver Hunt.

SVG invalidates way too much during layout()
http://bugs.webkit.org/show_bug.cgi?id=14003

  • ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::ownerSVGElement): simplify if (WebCore::SVGElement::viewportElement): simplify if
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout): only layout children if parent changed
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::layout): only layout children when size changes
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::layout): hack to avoid bad RenderBlock::layout code
  • rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::layout): don't use RenderSVGContainer::layout()
5:54 PM Changeset in webkit [26074] by ggaren
  • 8 edits in trunk

JavaScriptCore:

Reviewed by Sam Weinig.


Added JSObject::removeDirect, to support the fix for
<rdar://problem/5522487> REGRESSION: With JavaScript disabled, any
page load causes a crash in PropertyMap::put

  • kjs/object.cpp: (KJS::JSObject::removeDirect):
  • kjs/object.h:

WebCore:

Reviewed by Sam Weinig.


New fix for <rdar://problem/5522487> REGRESSION: With JavaScript
disabled, any page load causes a crash in PropertyMap::put


Explicitly remove the "document" property from the window. The old
solution would leave a stale "document" property around after JavaScript
was re-enabled.

The architecture for disabling JavaScript could use some consolidation.
It seems wrong that a script proxy even exists when JavaScript is
disabled. It also seems wrong that so many individual call sites are
responsible for checking whether JavaScript is enabled. I've filed a
bug about this: http://bugs.webkit.org/show_bug.cgi?id=15385.

  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::clearDocumentWrapper):
  • bindings/js/kjs_proxy.h:
  • page/Frame.cpp: (WebCore::Frame::setDocument):
5:22 PM Changeset in webkit [26073] by oliver
  • 2 edits in branches/feature-branch/WebCore

30%+ performance improvement for svg embedded in xhtml

Reviewed by Eric.

Relayout internal to SVG was incorrectly being propagated to
the containing xhtml element, which subsequently resulted in
a full paint of the SVG, rather than just the dirty regions.

  • rendering/RenderObject.cpp:

(WebCore::objectIsRelayoutBoundary):
(WebCore::RenderObject::markContainingBlocksForLayout):

2:38 PM Changeset in webkit [26072] by honeycutt
  • 2 edits in trunk/WebCore

2007-10-05 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Anders.

<rdar://5520913> Ticketmaster.com doesn't display correctly (Flash
related?)

The plugin is requesting files that don't exist on the server, and
we are passing the 404 error page to the plugin. This change cancels the
stream if the response code indicates a failure.

This is a port of the safari / mac code.

  • loader/win/NetscapePlugInStreamLoaderWin.cpp: (WebCore::NetscapePlugInStreamLoader::didReceiveResponse): If the response code indicates a failure, cancel the stream
1:12 PM Changeset in webkit [26071] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Sam Weinig.


Fixed <rdar://problem/5522487> REGRESSION: With JavaScript disabled,
any page load causes a crash in PropertyMap::put


The problem was that we were using JavaScript when JavaScript was
disabled. The architecture for disabling JavaScript could use some
consolidation, but this is the simplest, safest change for now.


Currently passing layout tests still pass.

  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::updateDocumentWrapper):
1:04 PM Changeset in webkit [26070] by bdakin
  • 4 edits in trunk

WebCore:

Reviewed by John Sullivan.

Fix for <rdar://problem/5441823> REGRESSION (r25142, Tiger only):
Vertical scroll bar not redrawn properly when going back in history
(15033)

This fix if-defs r25142 to be Leopard-only since it causes
correctness issues on Tiger and does not seem to have any
performance impact on Tiger either.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::transitionToCommitted):

WebKit:

Reviewed by John Sullivan.

Fix for <rdar://problem/5441823> REGRESSION (r25142, Tiger only):
Vertical scroll bar not redrawn properly when going back in history
(15033)

This fix if-defs r25142 to be Leopard-only since it causes
correctness issues on Tiger and does not seem to have any
performance impact on Tiger either.

  • WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView setScrollBarsSuppressed:repaintOnUnsuppress:]): (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
9:57 AM Changeset in webkit [26069] by adachan
  • 2 edits in trunk/WebKit/win

<rdar://problem/5436617>
Implement WebIconDatabase::delayDatabaseCleanup() and WebIconDatabase::allowDatabaseCleanup().

Reviewed by Brady.

  • WebIconDatabase.cpp: (WebIconDatabase::delayDatabaseCleanup): (WebIconDatabase::allowDatabaseCleanup):
9:52 AM Changeset in webkit [26068] by adachan
  • 2 edits in trunk/WebCore

<rdar://problem/5436617> Favicons sometimes don't show up even when they are
in the database

  • A client can try to retain an icon for a page before the database is actually opened. Since isOpened() is not a requirement to retain an icon, remove the check for that. Instead, we'll check to make sure whether this database is enabled before proceeding.

Reviewed by Brady.

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::retainIconForPageURL): (WebCore::IconDatabase::releaseIconForPageURL): only check isOpen() before we schedule for a sync.
3:56 AM Changeset in webkit [26067] by lars
  • 5 edits in trunk/LayoutTests/platform/qt

these tests deliver the same results as on the Mac, which
makes them pass :)

3:25 AM Changeset in webkit [26066] by lars
  • 4 edits in trunk

fix a hang in editing/selection/extend-by-word-002.html

2:10 AM Changeset in webkit [26065] by lars
  • 1 edit
    2 adds in trunk/WebKitTools

forgot to add these files in r26061.

2:06 AM Changeset in webkit [26064] by lars
  • 14 deletes in trunk/LayoutTests/platform/qt/traversal

remove platform specific results, after r26045 turned
these tests into being text only.

2:04 AM Changeset in webkit [26063] by lars
  • 1 edit in trunk/LayoutTests/platform/qt/Skipped

remove four more passing tests from the skipped list.

1:57 AM Changeset in webkit [26062] by lars
  • 10 edits in trunk

add proper error messages to the FrameLoaderClient.
Implement ChromeClientQt::closeWindowSoon and
FrameLoaderClientQt::dispatchCreatePage (which should go
away IMO).
Some fixes in DRT to make it work correctly with multiple
windows.

1:57 AM Changeset in webkit [26061] by lars
  • 9 edits in trunk

Add a dummy plugin to DRT to fix fast/dom/Window/Plug-Ins.html.
Add support for layoutTextController.setCanOpenWindows() to DRT
fixing another 2 test cases in fast/dom/Window.

12:45 AM Changeset in webkit [26060] by bdash
  • 1 copy in tags/WebKit-419.2.1-dashboard/WebKit

New tag (part 2).

12:45 AM Changeset in webkit [26059] by bdash
  • 1 copy in tags/WebCore-419.2.1-dashboard/WebCore

New tag (part 2).

12:45 AM Changeset in webkit [26058] by bdash
  • 1 copy in tags/JavaScriptCore-419.2.2-dashboard/JavaScriptCore

New tag (part 2).

12:44 AM Changeset in webkit [26057] by bdash
  • 1 add in tags/WebKit-419.2.1-dashboard

New tag (part 1).

12:44 AM Changeset in webkit [26056] by bdash
  • 1 add in tags/WebCore-419.2.1-dashboard

New tag (part 1).

12:44 AM Changeset in webkit [26055] by bdash
  • 1 add in tags/JavaScriptCore-419.2.2-dashboard

New tag (part 1).

12:41 AM Changeset in webkit [26054] by bdash
  • 6 edits in branches/Safari-2.0-dashboard

Versioning.

Oct 4, 2007:

9:11 PM Changeset in webkit [26053] by bdash
  • 4 edits in tags/Safari-4523.10.2

Versioning.

9:11 PM Changeset in webkit [26052] by bdash
  • 8 edits in tags/Safari-4523.10.2

Merge r26050.

8:55 PM Changeset in webkit [26051] by bdash
  • 1 copy in tags/Safari-4523.10.2

New tag.

8:52 PM Changeset in webkit [26050] by bdash
  • 8 edits in trunk

2007-10-04 Mark Rowe <mrowe@apple.com>

Reviewed by Oliver.

Switch to default level of debugging symbols to resolve <rdar://problem/5488678>.
The "full" level appears to offer no observable benefits even though the documentation
suggests it be used for dead code stripping. This should also decrease link times.

  • Configurations/Base.xcconfig:
8:37 PM Changeset in webkit [26049] by weinig
  • 1 edit
    1 delete in trunk/WebKitTools

Rubber stamped by Adam.

Remove empty directories.

  • DumpRenderTree/DumpRenderTree.qtproj: Removed.
  • DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
4:23 PM Changeset in webkit [26048] by adele
  • 2 edits in trunk/WebKit/win
  • Interfaces/IWebViewPrivate.idl: Moving setInitialFocus down to the end to avoid breaking the OpenSource build.
3:21 PM Changeset in webkit [26047] by adele
  • 10 edits in trunk

WebCore:

Reviewed by Darin.

WebCore part of fix for <rdar://problem/5369017> REGRESSION: Can't tab to webview that doesn't have editable content

  • page/FocusController.h: Added FocusDirection argument.
  • page/FocusController.cpp: (WebCore::FocusController::setInitialFocus): Use FocusDirection argument instead of key modifiers to send direction to advanceFocus.
  • WebCore.exp: Updated symbol.

WebKit:

Reviewed by Darin.

WebKit part of fix for <rdar://problem/5369017> REGRESSION: Can't tab to webview that doesn't have editable content

  • WebView/WebHTMLView.mm: (-[WebHTMLView becomeFirstResponder]): Pass in the FocusDirection.

win:

Reviewed by Darin.

WebKit/win part of fix for <rdar://problem/5369017> REGRESSION: Can't tab to webview that doesn't have editable content

  • WebView.cpp: Added setInitialFocus so the application can specify that its handing off focus to WebKit and so that it can specify the focus direction.
  • WebView.h: ditto.
  • Interfaces/IWebViewPrivate.idl: ditto.
1:34 PM Changeset in webkit [26046] by darin
  • 2 edits in trunk/WebKit
  • WebView/WebHTMLView.mm: (-[WebHTMLView _updateActiveState]): Removed a bogus comment.
11:33 AM Changeset in webkit [26045] by weinig
  • 15 edits
    14 adds
    1 delete in trunk/LayoutTests

Rubber-stamped by Darin.

Make traversal tests dumpAsText.

  • platform/mac/traversal: Removed.
  • platform/mac/traversal/node-iterator-001-expected.checksum: Removed.
  • platform/mac/traversal/node-iterator-001-expected.png: Removed.
  • platform/mac/traversal/node-iterator-001-expected.txt: Removed.
  • platform/mac/traversal/node-iterator-002-expected.checksum: Removed.
  • platform/mac/traversal/node-iterator-002-expected.png: Removed.
  • platform/mac/traversal/node-iterator-002-expected.txt: Removed.
  • platform/mac/traversal/node-iterator-003-expected.checksum: Removed.
  • platform/mac/traversal/node-iterator-003-expected.png: Removed.
  • platform/mac/traversal/node-iterator-003-expected.txt: Removed.
  • platform/mac/traversal/node-iterator-004-expected.checksum: Removed.
  • platform/mac/traversal/node-iterator-004-expected.png: Removed.
  • platform/mac/traversal/node-iterator-004-expected.txt: Removed.
  • platform/mac/traversal/node-iterator-005-expected.checksum: Removed.
  • platform/mac/traversal/node-iterator-005-expected.png: Removed.
  • platform/mac/traversal/node-iterator-005-expected.txt: Removed.
  • platform/mac/traversal/node-iterator-006-expected.checksum: Removed.
  • platform/mac/traversal/node-iterator-006-expected.png: Removed.
  • platform/mac/traversal/node-iterator-006-expected.txt: Removed.
  • platform/mac/traversal/node-iterator-007-expected.checksum: Removed.
  • platform/mac/traversal/node-iterator-007-expected.png: Removed.
  • platform/mac/traversal/node-iterator-007-expected.txt: Removed.
  • platform/mac/traversal/node-iterator-008-expected.checksum: Removed.
  • platform/mac/traversal/node-iterator-008-expected.png: Removed.
  • platform/mac/traversal/node-iterator-008-expected.txt: Removed.
  • platform/mac/traversal/stay-within-root-expected.checksum: Removed.
  • platform/mac/traversal/stay-within-root-expected.png: Removed.
  • platform/mac/traversal/stay-within-root-expected.txt: Removed.
  • platform/mac/traversal/tree-walker-001-expected.checksum: Removed.
  • platform/mac/traversal/tree-walker-001-expected.png: Removed.
  • platform/mac/traversal/tree-walker-001-expected.txt: Removed.
  • platform/mac/traversal/tree-walker-002-expected.checksum: Removed.
  • platform/mac/traversal/tree-walker-002-expected.png: Removed.
  • platform/mac/traversal/tree-walker-002-expected.txt: Removed.
  • platform/mac/traversal/tree-walker-003-expected.checksum: Removed.
  • platform/mac/traversal/tree-walker-003-expected.png: Removed.
  • platform/mac/traversal/tree-walker-003-expected.txt: Removed.
  • platform/mac/traversal/tree-walker-004-expected.checksum: Removed.
  • platform/mac/traversal/tree-walker-004-expected.png: Removed.
  • platform/mac/traversal/tree-walker-004-expected.txt: Removed.
  • platform/mac/traversal/tree-walker-005-expected.checksum: Removed.
  • platform/mac/traversal/tree-walker-005-expected.png: Removed.
  • platform/mac/traversal/tree-walker-005-expected.txt: Removed.
  • traversal/node-iterator-001-expected.txt: Added.
  • traversal/node-iterator-001.html:
  • traversal/node-iterator-002-expected.txt: Added.
  • traversal/node-iterator-002.html:
  • traversal/node-iterator-003-expected.txt: Added.
  • traversal/node-iterator-003.html:
  • traversal/node-iterator-004-expected.txt: Added.
  • traversal/node-iterator-004.html:
  • traversal/node-iterator-005-expected.txt: Added.
  • traversal/node-iterator-005.html:
  • traversal/node-iterator-006-expected.txt: Added.
  • traversal/node-iterator-006.html:
  • traversal/node-iterator-007-expected.txt: Added.
  • traversal/node-iterator-007.html:
  • traversal/node-iterator-008-expected.txt: Added.
  • traversal/node-iterator-008.html:
  • traversal/stay-within-root-expected.txt: Added.
  • traversal/stay-within-root.html:
  • traversal/tree-walker-001-expected.txt: Added.
  • traversal/tree-walker-001.html:
  • traversal/tree-walker-002-expected.txt: Added.
  • traversal/tree-walker-002.html:
  • traversal/tree-walker-003-expected.txt: Added.
  • traversal/tree-walker-003.html:
  • traversal/tree-walker-004-expected.txt: Added.
  • traversal/tree-walker-004.html:
  • traversal/tree-walker-005-expected.txt: Added.
  • traversal/tree-walker-005.html:
10:45 AM Changeset in webkit [26044] by kdecker
  • 2 edits in trunk/WebCore

Reviewed by John.


<rdar://problems/5516309>


  • page/FrameView.cpp: (WebCore::FrameView::updateControlTints): Avoid the expense of updating tints on controls for the empty-window case since this can take a significant amount of time even on windows that have no content at all. Note this fix specifically optimizes the empty window/tab case; for a more broad fix John wrote up rdar://problem/5521050.
10:13 AM Changeset in webkit [26043] by darin
  • 2 edits in trunk/WebCore
  • page/Frame.h: Put functions into categories to indicate other classes we'd like to move them into in the future. Just organizational -- no code change.
8:19 AM Changeset in webkit [26042] by eseidel
  • 6 edits
    12 adds
    6 deletes in branches/feature-branch

2007-10-03 Eric Seidel <eric@webkit.org>

Reviewed by Maciej.


http://bugs.webkit.org/show_bug.cgi?id=12310
Remove static variables from removeAllChildren causing crash.
removeAllChildren now iterates over the entire tree instead of recursing.
Also (according to Maciej) a possible 1-2% speedboost on HTML iBench.

Test: fast/images/svg-background-crash-on-refresh.html

  • WebCore.xcodeproj/project.pbxproj:
  • dom/ContainerNode.cpp: (WebCore::addChildNodesToDeletionQueue): (WebCore::ContainerNode::removeAllChildren): use new addChildNodesToDeletionQueue
1:45 AM Changeset in webkit [26041] by lars
  • 3 edits
    2 adds in trunk

fix a crash in the FrameLoader that can happen under certain
conditions in the Qt port.

1:09 AM Changeset in webkit [26040] by hyatt
  • 1 edit in branches/feature-branch/WebCore/WebCore.vcproj/WebCore.vcproj

Fix Windows build bustage once and for all. Feature branch builds on Windows now.

12:36 AM Changeset in webkit [26039] by lars
  • 1 edit
    1 move in trunk/LayoutTests

forgot to move one file in the last commit.

12:32 AM Changeset in webkit [26038] by lars
  • 1 edit
    317 moves in trunk/LayoutTests

Move png files that are not test results and where mistakenly moved in r26026
back to where they belong.

12:29 AM Changeset in webkit [26037] by hyatt
  • 1 edit in branches/feature-branch/WebCore/WebCore.vcproj/WebCore.vcproj

Fix Windows build bustage once and for all. Feature branch builds on Windows now.

Note: See TracTimeline for information about the timeline view.