Timeline



Nov 25, 2007:

11:29 PM Changeset in webkit [28038] by Adam Roben
  • 2 edits in trunk/WebKit/win

Fix a leak pointed out by Alexey

  • WebView.cpp: (getUpdateRects): Use a Vector<unsigned char>, since OwnPtr doesn't know to call delete[].
11:06 PM Changeset in webkit [28037] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

Bug 16052: prepare-ChangeLog doesn't report deleted files
<​http://bugs.webkit.org/show_bug.cgi?id=16052>

Reviewed by Sam.

  • Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
11:02 PM Changeset in webkit [28036] by Adam Roben
  • 3 edits in trunk/WebKit/win

Fix Bug 16138: Reduce code duplication in WebView.cpp

​http://bugs.webkit.org/show_bug.cgi?id=16138

Reviewed by Sam.

  • WebView.cpp: (getUpdateRects): Factored code out of updateBackingStore and paint into this new helper function. (WebView::updateBackingStore): Use getUpdateRects. (WebView::paint): Ditto. (WebView::paintIntoBackingStore): Changed to take a const IntRect&. (WebView::paintIntoWindow): Ditto.
  • WebView.h:
10:00 PM Changeset in webkit [28035] by ddkilzer@apple.com
  • 2 edits
    1 delete in trunk/WebKitTools

Bug 15864: Replace merge-changelog with resolve-ChangeLogs
<​http://bugs.webkit.org/show_bug.cgi?id=15864>

Reviewed by Adam.

Roll functionality of merge-changelog into resolve-ChangeLogs
script. The script now checks for ChangeLog.rej and
ChangeLog.orig files first. If it finds them, it uses the
ChangeLog.rej file as a patch (in old contextual diff format) to
apply with --fuzz=3.

  • Scripts/merge-changelog: Removed.
  • Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
9:26 PM Changeset in webkit [28034] by Adam Roben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Add a known failure.
9:25 PM Changeset in webkit [28033] by Adam Roben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Remove an unnecessary entry.
8:16 PM Changeset in webkit [28032] by weinig@apple.com
  • 4 edits
    2 adds in trunk/WebKitTools

Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.

Reviewed by Mark Rowe.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/mac/Configurations/Base.xcconfig:
  • DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
  • DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
  • DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
7:52 PM Changeset in webkit [28031] by weinig@apple.com
  • 2 edits
    4 adds in trunk/WebKitTools

Convert DumpRenderTree to ues .xcconfig files.

Reviewed by Mark Rowe.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/mac/Configurations: Added.
  • DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
  • DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
  • DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
6:54 PM Changeset in webkit [28030] by weinig@apple.com
  • 12 edits
    8 adds in trunk/WebKitTools

Add ForwardingHeaders to wtf for DumpRenderTree.

Reviewed by Mark Rowe.

  • DumpRenderTree/DumpRenderTree.h:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/ForwardingHeaders: Added.
  • DumpRenderTree/ForwardingHeaders/wtf: Added.
  • DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
  • DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
  • DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
  • DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
  • DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
  • DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
  • DumpRenderTree/LayoutTestController.cpp:
  • DumpRenderTree/WorkQueue.cpp:
  • DumpRenderTree/mac/DumpRenderTree.mm:
  • DumpRenderTree/mac/FrameLoadDelegate.mm:
  • DumpRenderTree/mac/JavaScriptThreading.cpp:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
  • DumpRenderTree/mac/ObjCController.m:
  • DumpRenderTree/mac/UIDelegate.mm:
  • DumpRenderTree/mac/WorkQueueItemMac.mm:
6:37 PM Changeset in webkit [28029] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2007-11-25 Rodney Dawes <​dobey@wayofthemonkey.com>

Reviewed by Maciej Stachowiak.

Remove the unneeded CFNETWORK #ifdefs.

  • loader/NetscapePlugInStreamLoader.h:
6:12 PM Changeset in webkit [28028] by mrowe@apple.com
  • 5 edits in trunk/WebCore

2007-11-24 Laszlo Gombos <​laszlo.gombos@gmail.com>

Reviewed by Sam Weinig.

Add printf format attribute to several functions. Use the the new WTF_ATTRIBUTE_PRINTF define.

  • dom/XMLTokenizer.cpp:
  • dom/XMLTokenizer.h:
  • platform/DeprecatedString.h:
  • platform/PlatformString.h:
6:12 PM Changeset in webkit [28027] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

2007-11-24 Laszlo Gombos <​laszlo.gombos@gmail.com>

Reviewed by Maciej Stachowiak.

Fix minor compiler warning (GCC 4.1.3)

  • pcre/pcre_internal.h:
  • pcre/pcre_ucp_searchfuncs.cpp: (_pcre_ucp_othercase):
5:53 PM Changeset in webkit [28026] by Adam Roben
  • 2 edits in trunk/WebKitTools

Fix some test failures caused by r28019

Now that stdout is in binary mode, we need to always use printf
instead of wprintf. Otherwise we'll end up with UTF-16 characters in
the output.

Reviewed by Sam.

  • DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with printf. (UIDelegate::runJavaScriptAlertPanelWithMessage): (UIDelegate::runJavaScriptConfirmPanelWithMessage): (UIDelegate::runJavaScriptTextInputPanelWithPrompt): (UIDelegate::webViewAddMessageToConsole):
5:06 PM Changeset in webkit [28025] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

  • fix off-center error images

Covered by many pixel tests with missing images

  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint): Account for the 1 pixel outline when positioning the error image.
4:13 PM Changeset in webkit [28024] by Adam Roben
  • 2 edits in trunk/WebKitTools

Set the font smoothing preference in DRT

This makes the pixel results on Windows closer to the Mac results.

Reviewed by Mitz.

  • DumpRenderTree/win/DumpRenderTree.cpp: (initializePreferences):
4:03 PM Changeset in webkit [28023] by Adam Roben
  • 4 edits
    2 adds in trunk

Fix Bug 16133: Implement pixel test support on Windows

WebKit/win:

Add ImageDiff.vcproj to WebKit.sln

Reviewed by Sam.

  • WebKit.vcproj/WebKit.sln:

WebKitTools:

Port ImageDiff to CG and C++

Final part of ​http://bugs.webkit.org/show_bug.cgi?id=16133
<rdar://5071708>

Reviewed by Sam.

  • DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
  • DumpRenderTree/cg/ImageDiffCG.cpp: Added. (main): (createImageFromStdin): (compareImages): (getDifferenceBitmap): (computePercentageDifferent):
  • DumpRenderTree/win/ImageDiff.vcproj: Added.
4:03 PM Changeset in webkit [28022] by Adam Roben
  • 2 edits in trunk/WebKitTools

Fix image diff link generation on Windows

Reviewed by Sam.

  • Scripts/run-webkit-tests: Removed unnecessary and incorrect calls to toURL.
4:02 PM Changeset in webkit [28021] by Adam Roben
  • 3 edits
    7 adds in trunk/WebKitTools

Implement pixel dumping in Windows DRT

Part of ​http://bugs.webkit.org/show_bug.cgi?id=16133
<rdar://5071708>

Reviewed by Sam.

  • DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added. (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a Content-Length header. (getMD5HashStringForBitmap): (dumpWebViewAsPixelsAndCompareWithExpected):
  • DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
  • DumpRenderTree/win/DumpRenderTree.cpp: (dump): Do a pixel dump if requested. (main): Parse pixel test options.
  • DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added the cg/ subdirectory to the include path.
  • DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't available in a header or import library, so we have to go through this LoadLibrary/GetProcAddress dance to use them. (cryptDLL): (init): (update): (final): (MD5_Init): (MD5_Update): (MD5_Final):
  • DumpRenderTree/win/MD5.h: Added.
  • DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be moved up to the top level to share it with Mac eventually.
  • DumpRenderTree/win/PixelDumpSupportWin.cpp: Added. (getBitmapContextFromWebView): Forces the WebView to paint using a WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
4:02 PM Changeset in webkit [28020] by Adam Roben
  • 2 edits in trunk/WebKitTools

Clean up Windows DRT's option parsing a little bit

Reviewed by Sam.

  • DumpRenderTree/win/DumpRenderTree.cpp: (main): Put non-option arguments into a Vector.
4:01 PM Changeset in webkit [28019] by Adam Roben
  • 3 edits in trunk/WebKitTools

Make Windows DRT stop changing LF into CRLF

Reviewed by Sam.

  • DumpRenderTree/win/DumpRenderTree.cpp: (main): Put stdout in binary mode.
  • Scripts/run-webkit-tests: Remove the CRLF hack.
2:14 PM Changeset in webkit [28018] by mrowe@apple.com
  • 3 edits
    3 adds in trunk

Fix bug 16129: REGRESSION (r27761-r27811): malloc error while visiting ​http://mysit.es (crashes release build)

  • pcre/pcre_compile.cpp: Change errorcode to be passed by reference so that any error code is propagated

to our caller like they expect.

Reviewed by Dan Bernstein.

1:16 PM Changeset in webkit [28017] by kevino@webkit.org
  • 4 edits in trunk

wx build fixes for Linux/GTK+ port.

5:06 AM Changeset in webkit [28016] by Nikolas Zimmermann
  • 1 edit in trunk/WebCore/ChangeLog

Fix wrong bug number in ChangeLog. Not reviewed.

5:04 AM Changeset in webkit [28015] by Nikolas Zimmermann
  • 14 edits
    4 adds in trunk

Reviewed by Adam Roben.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=15393

Fix problems with hidden glyphs. They were taken into account for quite
some operations (hit testing, length calulcations etc..) except painting.
Especially fixes boundaries of <textPath> (see using Web Inspector) if
text-anchor isn't equal to 'start'.

Added testcase:
svg/text/textPathBoundsBug.svg

Fixed testcase: (all showed text selection problems on text paths)
svg/batik/text/textGlyphOrientationHorizontal.svg
svg/batik/text/textOnPath.svg
svg/batik/text/textOnPath3.svg
svg/batik/text/verticalTextOnPath.svg
svg/text/text-align-04-b.svg
svg/W3C-SVG-1.1/text-align-04-b.svg

1:45 AM Changeset in webkit [28014] by ap@webkit.org
  • 9 edits
    2 adds in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=15919
XSLTProcessor.transformToFragment creates an extra not defined TEXT_NODE at the end

Test: fast/xsl/extra-lf-at-end.html

  • xml/XSLTProcessor.cpp: (WebCore::writeToVector): Changed to use Vector to avoid slow String::apend(). (WebCore::saveResultToString): Remove trailing line feed if present.
12:48 AM Changeset in webkit [28013] by alp@webkit.org
  • 7 edits in trunk/WebKit/gtk

2007-11-24 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=15691
[GTK] Public API does not follow GTK+ conventions

Public API enhancements:

Implement webkit_page_get_editable() and webkit_page_set_editable().

Implement webkit_frame_get_name().

Remove definitions for functions that are unusable or not implemented.
This has caused much confusion for application developers.

Improve documentation.

Correct/constify some return types.

Add parameter checks.

Make the default fixed font "Courier New" to match the other Web
font names.

  • Api/webkitgtkframe.cpp:
  • Api/webkitgtkframe.h:
  • Api/webkitgtkpage.cpp:
  • Api/webkitgtkpage.h:
  • Api/webkitgtkprivate.h:
  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::isEditable):

Nov 24, 2007:

11:15 PM Changeset in webkit [28012] by ddkilzer@apple.com
  • 3 edits in trunk/LayoutTests

Added tests for select.options.remove(boolean).

Reviewed by Maciej.

  • fast/js/resources/select-options-add.js: Added two tests.
  • fast/js/select-options-add-expected.txt: Updated results.
7:39 PM Changeset in webkit [28011] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2007-11-24 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=16125
[GTK] Up key doesn't work properly when content is editable

Add a missing 'break' to avoid falling through to the next case when
handling VK_UP keystrokes. This was noticed when working on editing
support in the GTK+ port.

I've checked the other cases for similar typos and they seem fine.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::handleKeypress):
7:13 PM Changeset in webkit [28010] by ddkilzer@apple.com
  • 1 edit
    1 delete in trunk/WebKitTools

2007-11-24 David Kilzer <​ddkilzer@webkit.org>

Removed empty directory.

  • Scripts/resources: Removed.
6:53 PM Changeset in webkit [28009] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2007-11-24 Xan Lopez <​xan@gnome.org>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=15745
[GTK] Arrow keys do not Scroll


  • Api/webkitgtkpage.cpp:

Support Up/Down/Right/Left keys to scroll. Slight hack, see FIXME for
details.

5:23 PM Changeset in webkit [28008] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2007-11-24 Christian Dywan <​christian@twotoasts.de>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=15891
[GTK] Javascript console and dialogs are not implemented

Fix call to gtk_message_dialog_new() which expects a format string.

  • Api/webkitgtkpage.cpp:
4:23 PM HackingGtk edited by alp@atoker.com
Mention the build bots (diff)
3:56 PM Changeset in webkit [28007] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Tiger build fix.

Use WebCFAutorelease in place of NSMakeCollectable then autorelease as this also works on Tiger.

3:48 PM Changeset in webkit [28006] by mrowe@apple.com
  • 7 edits in trunk

Fix <rdar://problem/5432686> 333MB RPRVT seems to leak @ www.43folders.com (1hr plug-in stream).
​http://bugs.webkit.org/show_bug.cgi?id=13705

Reviewed by Tim Hatcher.

Have NP_ASFILE and NP_ASFILEONLY streams write the data to disk as they receive it rather than
dumping the data to disk in a single go when the stream has completed loading. On a test case
involving a 150MB Flash movie being streamed from a local web server this reduces memory consumption
on page load from around 400MB to 22MB.

The only plugin I have found that uses NP_ASFILE or NP_ASFILEONLY on the Mac is our NetscapeMoviePlugin
example code so the NP_ASFILE portion of this change has not had any testing with a real-world plugin.

3:43 PM Changeset in webkit [28005] by Adam Roben
  • 8 edits
    2 deletes in trunk

Get rid of WebCoreSystemInterface on Windows

WebCore:

Get rid of WebCoreSystemInterface on Windows

The one function defined in that file is now in WebKitSystemInterface.

Reviewed by Tim.

  • WebCore.vcproj/WebCore.vcproj: Removed WebCoreSystemInterface.{cpp,h}.
  • platform/graphics/cg/ImageCG.cpp: Made #include of WebCoreSystemInterface.h Mac-only.
  • platform/win/GraphicsContextWin.cpp: Ditto.
  • platform/win/WebCoreSystemInterface.cpp: Removed.
  • platform/win/WebCoreSystemInterface.h: Removed.

WebKitLibraries:

Add wkSetPatternPhaseInUserSpace to WebKitSystemInterface on Windows

Reviewed by Tim.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h: Added declaration.
  • win/lib/WebKitSystemInterface.lib: Updated.
  • win/lib/WebKitSystemInterface_debug.lib: Updated.
3:33 PM Changeset in webkit [28004] by Adam Roben
  • 6 edits in trunk/WebCore

Replace uses of %@ with %s in the inspector

Rubberstamped by Tim.

  • English.lproj/InspectorLocalizedStrings.js: Changed %@ to %s.
  • page/inspector/DatabasePanel.js: Ditto.
  • page/inspector/StylesSidebarPane.js: Ditto.
  • page/inspector/inspector.js: Ditto.
  • page/inspector/utilities.js: (String.vsprintf): Removed @ as a format specifier.
3:32 PM Changeset in webkit [28003] by Adam Roben
  • 3 edits in trunk/WebCore

Windows build fix

Turn off the change made in r27984 on Windows for now.

  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::transformToString):
  • xml/XSLTUnicodeSort.cpp:
2:35 PM Changeset in webkit [28002] by timothy@apple.com
  • 12 edits in trunk/WebCore

Reviewed by Adam Roben.

Bug 16121: Web Inspector needs helper functions that pass a 'this' object to
addEventListener and setTimeout
​http://bugs.webkit.org/show_bug.cgi?id=16121

Add Function.prototype.bind. This helper will return a wrapper function
that will call the original function with the supplied arguments
and using the supplied 'this' object.

  • page/inspector/Database.js: Remove a use of setTimeout by inheriting some common functions from Resource.
  • page/inspector/DatabasePanel.js: Use the new bind function.
  • page/inspector/ConsolePanel.js: Ditto.
  • page/inspector/DocumentPanel.js: Ditto.
  • page/inspector/NetworkPanel.js: Ditto.
  • page/inspector/PropertiesSection.js: Ditto.
  • page/inspector/Resource.js: Ditto.
  • page/inspector/SidebarPane.js: Ditto.
  • page/inspector/inspector.html: Moved Database.js after Resource.js, now that Database.js uses it.
  • page/inspector/inspector.js: Use the new bind function. Also removed a setTimeout used for the localized strings code. There is now a load event listener added to the localized strings script element that will call WebInspector.loaded.
  • page/inspector/utilities.js: Add Function.prototype.bind.
2:20 PM Changeset in webkit [28001] by timothy@apple.com
  • 1 edit in trunk/WebCore/English.lproj/InspectorLocalizedStrings.js

Add missing strings.

1:52 PM Changeset in webkit [28000] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2007-11-24 Christian Dywan <​christian@twotoasts.de>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=15793
[GTK] Webkit doesn't show title attribute tooltip when hovering over an image

Implement tooltip support using the new Tooltip API.

Support for older versions of GTK+ is still lacking.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::setToolTip):
11:18 AM Changeset in webkit [27999] by timothy@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Adam Roben.

Bug 16112: Some Web Inspector UI elements use offsetWidth and offsetHeight before the stylesheet loads
​http://bugs.webkit.org/show_bug.cgi?id=16112

In the places where we use offsetWidth and offsetHeight before
the stylesheet loads there is now a check. If the body's
offsetWidth is not greater than zero, then set a timeout
to do the updates requiring the stylesheet later.

The three places this happened:

  • DOM tree selection highlight would show up at the wrong height when using Inspect Element to open the inspector.
  • DOM tree breadcrumbs would not collapse when using Inspect Element to open the inspector.
  • Network Timeline divider lines would not show when opening directly into the timeline.
  • page/inspector/DocumentPanel.js: Check if the stylesheet loaded.
  • page/inspector/NetworkPanel.js: Ditto.
  • page/inspector/inspector.html: Include the stylesheet before any scripts, this will help get it loaded sooner.
10:18 AM Changeset in webkit [27998] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Add wx implementation for pathGetFilename

Reviewed by David D. Kilzer.

Nov 23, 2007:

10:09 PM Changeset in webkit [27997] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

Fix bisect-builds to work with recent WebKit nightly builds.

Reviewed by Dan.

  • Scripts/bisect-builds: Check for the WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use it for the DYLD_FRAMEWORK_PATH environment variable, else fallback to WebKit.app/Contents/Resources.
8:48 PM Changeset in webkit [27996] by timothy@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

Bug 16110: Clicking inside the resource headers in the network timeline collapses them
​http://bugs.webkit.org/show_bug.cgi?id=16110

Toggle the resource headers only if the click happens on the
resource row, not within the headers area.

  • WebCore.xcodeproj/project.pbxproj:
  • page/inspector/NetworkPanel.js:
8:11 PM HackingGtk edited by alp@atoker.com
Add WebCore and WebKit specific hacking guides (diff)
7:14 PM Changeset in webkit [27995] by oliver@apple.com
  • 2 edits in trunk/WebKit/mac

Fixed <rdar://problem/3759190> allow input methods the option of processing mouse events themselves

Reviewed by Mark Rowe.

4:52 PM Changeset in webkit [27994] by kevino@webkit.org
  • 7 edits in trunk

Windows build fixes for USE(CURL) and MSVC compilation for ports.

Reviewed by Adam Roben.

4:11 PM BuildingGtk edited by alp@atoker.com
Fix the link, split out the hacking guide (diff)
4:11 PM HackingGtk created by alp@atoker.com
Add GTK+ hacking information verbatim
4:05 PM BuildingGtk edited by alp@atoker.com
Add link to HackingGtk (diff)
3:22 PM Changeset in webkit [27993] by kevino@webkit.org
  • 2 edits in trunk

Forgot to add JSCore and WebCore ChangeLog during previous commit.

3:17 PM Changeset in webkit [27992] by kevino@webkit.org
  • 11 edits in trunk

Fix the wx buildbot after removal of move-js-headers.sh..

2:03 PM Changeset in webkit [27991] by alp@webkit.org
  • 4 edits in trunk/WebKit/gtk

2007-11-22 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

Implement and document several WebKitFrame functions, some of which
are necessary to support DRT.

Correct NULL handling and improve run-time checks.

  • Api/webkitgtkframe.cpp:
  • Api/webkitgtkframe.h:
  • Api/webkitgtkprivate.cpp:
12:07 PM Changeset in webkit [27990] by Antti Koivisto
  • 17 edits in trunk/LayoutTests

Set video src from script, not from the element attribute. This
guarantees load events do not fire before event listeners are registered.
This change does not affect test results.

  • media/progress-event.html:
  • media/video-autoplay.html:
  • media/video-buffered.html:
  • media/video-currentTime-set.html:
  • media/video-currentTime-set2.html:
  • media/video-currentTime.html:
  • media/video-dom-autoplay.html:
  • media/video-error-abort.html:
  • media/video-error-does-not-exist.html:
  • media/video-load-networkState.html:
  • media/video-load-readyState.html:
  • media/video-no-autoplay.html:
  • media/video-seekable.html:
  • media/video-seeking.html:
  • media/video-size.html:
  • media/video-src.html:
  • media/video-start.html:
7:56 AM Changeset in webkit [27989] by Simon Hausmann
  • 2 edits in trunk/WebCore

Another build fix specific to trunk (instead of the stable branch) to fix make clean (which the buildbots call).

Signed-off-by: George Staikos <​staikos@kde.org>

7:44 AM Changeset in webkit [27988] by Simon Hausmann
  • 3 edits in trunk/JavaScriptCore

Fix make (dist)clean on Windows.

OBJECTS_DIR_WTR does not exist anymore, use GENERATED_SOURCES_DIR.

Signed-off-by: George Staikos <​staikos@kde.org>

6:37 AM QtWebKitGitInstructions edited by Simon Hausmann
(diff)
5:56 AM QtWebKitGitInstructions edited by Simon Hausmann
(diff)
5:30 AM UsingGitWithWebKit edited by Simon Hausmann
(diff)
5:30 AM QtWebKitGitInstructions created by Simon Hausmann
5:29 AM QtWebKitContrib edited by Simon Hausmann
(diff)
5:29 AM QtWebKitContrib edited by Simon Hausmann
(diff)
5:21 AM UsingGitWithWebKit edited by Simon Hausmann
(diff)
5:19 AM UsingGitWithWebKit edited by Simon Hausmann
(diff)
4:27 AM Changeset in webkit [27987] by ap@webkit.org
  • 2 edits in trunk/WebCore

Not reviewed, trivial leak fix.

Fix xsltUnicodeSortFunction() memory leaks.

  • xml/XSLTUnicodeSort.cpp: (WebCore::xsltUnicodeSortFunction):
2:52 AM ProjectVision created by lars@webkit.org
2:19 AM Changeset in webkit [27986] by ap@webkit.org
  • 6 edits
    8 adds in trunk

Reviewed by Maciej.

<rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
not closed (affects digg.com)

Tests: fast/loader/meta-refresh-vs-open.html

fast/loader/redirect-with-open-subframe-2.html
fast/loader/redirect-with-open-subframe.html
http/tests/loading/onload-vs-immediate-refresh.pl

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::scheduleRedirection): Only check whether the load is complete for HTTP redirects - JavaScript-initiated ones are effective immediately.

WebKitTools:

  • DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank one after finishing with a test to avoid having its delayed onload handler fired when starting the next test. This is ugly and still unreliable (see LayoutTests ChangeLog), but it helps somewhat.
1:39 AM WebKit Team edited by Simon Hausmann
(diff)
1:24 AM QtWebKit edited by lars@webkit.org
(diff)
1:21 AM WebKit Team edited by staikos@webkit.org
Remove irc handle (diff)
1:20 AM Changeset in webkit [27985] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Alexey Proskuryakov.

  • apply matrix transforms on the correct side of the transformation matrix (not on the side where the vector is multiplied).

Test: fast/transforms/matrix-02.html

  • rendering/RenderStyle.h: (WebCore::MatrixTransformOperation::apply):

LayoutTests:

Reviewed by Alexey Proskuryakov.

  • test the matrix transforms are applied on the correct side
  • fast/transforms/matrix-02.html: Added.
  • platform/mac/fast/transforms/matrix-02-expected.checksum: Added.
  • platform/mac/fast/transforms/matrix-02-expected.png: Added.
  • platform/mac/fast/transforms/matrix-02-expected.txt: Added.
12:29 AM Changeset in webkit [27984] by ap@webkit.org
  • 7 edits
    7 adds in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=16077
<rdar://problem/5609785> XSLT processor <xsl:sort> algorithm is incompatible with other
browser implementations

Test: fast/xsl/sort-unicode.xml

  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::transformToString): Set a custom sort function.
  • xml/XSLTUnicodeSort.cpp: Added. (init_xsltTransformError): (xsltTransformError): (WebCore::xsltUnicodeSortFunction):
  • xml/XSLTUnicodeSort.h: Added. ICU-based implementation of xsl:sort, using an example from libxslt distribution. Only minimal coding style fixes to ease synchronization with upstream in the future.
  • icu/unicode/ucol.h: Added.
  • icu/unicode/uset.h: Added. Taken from ICU 3.2
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl: Added XSLTUnicodeSort.cpp.

Nov 22, 2007:

10:43 PM Changeset in webkit [27983] by ap@webkit.org
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=14977
Hixie's DOM Core performance test shows insert >10x slower than append

Each invocation of Element.childNodes[n] was creating and registering a new ChildNodeList,
which persisted and listened to notifications until GC.

A fix is to avoid registering child node lists for notifications - they don't need them, as
they share a common cache in Node.

  • dom/Node.cpp: (WebCore::Node::registerNodeList): (WebCore::Node::unregisterNodeList): (WebCore::Node::notifyLocalNodeListsAttributeChanged): (WebCore::Node::notifyLocalNodeListsChildrenChanged):
  • dom/NodeList.h: (WebCore::NodeList::needsNotifications):
10:04 PM Changeset in webkit [27982] by mitz@apple.com
  • 14 edits in trunk

WebCore:

Reviewed by Antti Koivisto.

Defer plug-in loading until after attach and recalcStyle using the
post-attach callback mechanism. Netscape plug-ins are still loaded only
after layout.

  • dom/ContainerNode.cpp: Made NodeCallbackQueue elements retain the Node because callbacks might delete nodes that are in the callback queue. (WebCore::ContainerNode::suspendPostAttachCallbacks): Added. Needed to prevent post-attach callbacks from being dispatched under recalcStyle(). (WebCore::ContainerNode::resumePostAttachCallbacks): Ditto. (WebCore::ContainerNode::dispatchPostAttachCallbacks): Factored out from attach(). (WebCore::ContainerNode::attach):
  • dom/ContainerNode.h:
  • dom/Document.cpp: (WebCore::Document::recalcStyle): Added calls to suspendPostAttachCallbacks() and resumePostAttachCallbacks().
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::HTMLEmbedElement): (WebCore::HTMLEmbedElement::attach): Changed to queue the widget update for post-attach. (WebCore::HTMLEmbedElement::updateWidget): Added. Called by the post-attach callback.
  • html/HTMLEmbedElement.h: Added an m_needWidgetUpdate member needed to prevent a double update if another plug-in's post-attach updateWidget() triggers a layout which updates the widget before this plug-in's post-attach callback is invoked. (WebCore::HTMLEmbedElement::setNeedWidgetUpdate): Added a setter for m_needWidgetUpdate.
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::attach): Changed to queue the widget update for post-attach. (WebCore::HTMLObjectElement::updateWidget): Added. Called by the post-attach callback.
  • html/HTMLObjectElement.h: (WebCore::HTMLObjectElement::setNeedWidgetUpdate): Added a setter for m_needWidgetUpdate.
  • html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::updateWidgetCallback): Added.
  • html/HTMLPlugInElement.h: (WebCore::HTMLPlugInElement::updateWidget):
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): Added calls to setNeedWidgetUpdate(false) so that if this method is called from FrameView::layout() during post-attach dispatch of another plug-in, it will not be called again when this plug-in's post-attach callback is dispatched.
  • rendering/RenderPartObject.h: (WebCore::RenderPartObject::updateWidget) Renamed argument to match the method definition.

WebKit/mac:

Reviewed by Antti Koivisto.

8:45 PM Changeset in webkit [27981] by timothy@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Dan Bernstein.

Fix the Element.hasStyleClass and Element.removeStyleClass helpers
to not find and replace substrings, but whole class names at the
beginning or end of the string or surrounded by whitespace.

  • page/inspector/utilities.js:
8:23 PM Changeset in webkit [27980] by timothy@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix typo.

8:20 PM Changeset in webkit [27979] by timothy@apple.com
  • 3 edits in trunk/WebCore

Revert part of my r27935 change that made the Tip balloons
animate with CSS transitions. The balloon was only opacity 0,
so it would cause it's row to highlight when hovering over
another row.

  • page/inspector/NetworkPanel.js:
  • page/inspector/inspector.css:
8:11 PM Changeset in webkit [27978] by mitz@apple.com
  • 6 edits
    4 adds in trunk

WebCore:

Reviewed by Maciej Stachowiak.

Test: fast/transforms/matrix-01.html

Parse all six matrix entries as numbers.

  • css/CSSParser.cpp: (WebCore::TransformOperationInfo::TransformOperationInfo): (WebCore::CSSParser::parseTransform):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • rendering/RenderStyle.cpp: (WebCore::MatrixTransformOperation::blend):
  • rendering/RenderStyle.h: (WebCore::MatrixTransformOperation::MatrixTransformOperation): (WebCore::MatrixTransformOperation::apply):

LayoutTests:

Reviewed by Maciej Stachowiak.

  • fast/transforms/matrix-01.html: Added.
  • platform/mac/fast/transforms/matrix-01-expected.checksum: Added.
  • platform/mac/fast/transforms/matrix-01-expected.png: Added.
  • platform/mac/fast/transforms/matrix-01-expected.txt: Added.
6:53 PM Changeset in webkit [27977] by alp@webkit.org
  • 12 edits in trunk/WebKit/gtk

2007-11-22 Alp Toker <​alp@atoker.com>

Whitespace fixes only.

  • Api/webkitgtkframe.cpp:
  • Api/webkitgtkpage.cpp:
  • Api/webkitgtkpage.h:
  • Api/webkitgtkprivate.h:
  • WebCoreSupport/ChromeClientGtk.cpp:
  • WebCoreSupport/ContextMenuClientGtk.cpp:
  • WebCoreSupport/ContextMenuClientGtk.h:
  • WebCoreSupport/DragClientGtk.h:
  • WebCoreSupport/EditorClientGtk.h:
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchWillSendRequest): (WebKit::FrameLoaderClient::assignIdentifierToInitialRequest): (WebKit::FrameLoaderClient::postProgressEstimateChangedNotification): (WebKit::FrameLoaderClient::createFrame): (WebKit::FrameLoaderClient::createJavaAppletWidget): (WebKit::FrameLoaderClient::registerForIconNotification): (WebKit::FrameLoaderClient::setMainFrameDocumentReady): (WebKit::FrameLoaderClient::dispatchDidFinishLoad): (WebKit::FrameLoaderClient::frameLoadCompleted): (WebKit::FrameLoaderClient::saveViewStateToItem): (WebKit::FrameLoaderClient::restoreViewState): (WebKit::FrameLoaderClient::shouldGoToHistoryItem): (WebKit::FrameLoaderClient::setTitle):
  • WebCoreSupport/FrameLoaderClientGtk.h:
5:52 PM Changeset in webkit [27976] by alp@webkit.org
  • 9 edits in trunk/WebKit/gtk

2007-11-22 Michael Natterer <​mitch@imendio.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=15984
Implement "navigation-requested" signal for WebKit Gtk

  • Api/webkitgtknetworkrequest.h: fix parent class member.
  • Api/webkitgtknetworkrequest.cpp
  • Api/webkitgtkprivate.h: basic implementation featuring an "url" member and API.
  • Api/webkitgtkdefines.h: added network request typedefs.
  • Api/webkitgtkpage.h: fix enum name: s/WEBKIT_NAVIGATION_REQUEST_RESPONSE/WebKitNavigationRequestResponse/ and sanitized enum values.
  • Api/webkitgtkpage.cpp: made "navigation-requested" a signal.
  • Api/webkitgtk-marshal.list: added INT:OBJECT,OBJECT
  • WebCoreSupport/FrameLoaderClientGtk.cpp: emit the new signal in dispatchDecidePolicyForNavigationAction().
5:48 PM Changeset in webkit [27975] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

2007-11-22 Mark Rowe <​mrowe@apple.com>

Reviewed by Alp Toker.

Fix build-webkit to propagate make's exit status if it fails.

  • Scripts/webkitdirs.pm:
5:03 PM Changeset in webkit [27974] by alp@webkit.org
  • 2 edits in trunk

2007-11-22 Alp Toker <​alp@atoker.com>

GTK+ build fix. Pass a correct LIBDIR value.

  • WebKit.pri:
4:04 PM Changeset in webkit [27973] by alp@webkit.org
  • 2 edits in trunk/WebCore

2007-11-22 Laszlo Gombos <​laszlo.gombos@gmail.com>

Reviewed by Alp Toker.

Fix some compilation warnings. Do not reference undefined (platform) specific type (WebCore::CachedFont::m_fontData)

  • loader/CachedFont.cpp: (WebCore::CachedFont::~CachedFont): (WebCore::CachedFont::allReferencesRemoved):
1:02 PM Changeset in webkit [27972] by alp@webkit.org
  • 2 edits in trunk/WebCore

2007-11-22 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

GTK+ drawing fix.

Add a check to avoid crashing when the GraphicsContext is not
associated with a GdkEventExpose. This was noticed when adding
printing support but might be triggered in other situations too.

  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::paint):
9:36 AM Changeset in webkit [27971] by mitz@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Mark Rowe.

  • fix crash when running pixel tests
  • DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Parse the command line options before setting up the environment so that we know if we need to set up the pixel dump machinery.
9:02 AM QtWebKitContrib edited by treat@kde.org
(diff)
5:04 AM QtWebKitTodo edited by treat@kde.org
(diff)
5:03 AM QtWebKit edited by treat@kde.org
(diff)
3:35 AM WikiStart edited by treat@kde.org
Reorganize a bit and add page for Git (diff)
3:30 AM UsingGitWithWebKit edited by treat@kde.org
Tips and tricks (diff)
3:03 AM Changeset in webkit [27970] by ap@webkit.org
  • 3 edits
    2 adds in trunk

2007-11-22 Julien Chaffraix <​julien.chaffraix@gmail.com>

Reviewed by Alexey.

Bug 15530: XMLHttpRequest should not support certain methods

Test: http/tests/xmlhttprequest/xmlhttprequest-forbidden-methods-exception.html

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::open):
2:55 AM Changeset in webkit [27969] by mrowe@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Remove WARNING notes from change logs that committers neglected to remove when landing.

2:42 AM WebKit Team edited by mjs@apple.com
(diff)
2:37 AM WebKit Team edited by mjs@apple.com
(diff)
2:24 AM WebKit Team edited by mjs@apple.com
(diff)
2:20 AM WebKit Team edited by mrowe@apple.com
(diff)
2:18 AM WebKit Team edited by alp@atoker.com
Update (diff)
2:16 AM Changeset in webkit [27968] by Simon Hausmann
  • 1 edit in trunk/WebKit/qt/ChangeLog

Fix changelog

2:13 AM Changeset in webkit [27967] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Fix compilation (don't define notImplemented twice)

2:12 AM Changeset in webkit [27966] by Simon Hausmann
  • 4 edits in trunk

Use Q_SIGNALS/Q_SLOTS in the public API

2:12 AM Changeset in webkit [27965] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Fixed the signature of the QWebPage constructor to follow Qt guidelines.

2:12 AM Changeset in webkit [27964] by Simon Hausmann
  • 11 edits in trunk/WebKit/qt

Use <QtModule/headerfile.h> instead of <Classname> in public HEADER files, to not require the include paths for the other modules to be present

2:11 AM Changeset in webkit [27963] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Removed inline copy of QExplicitlySharedDataPointer. This is not needed anymore since we require Qt >= 4.3.0.

2:11 AM Changeset in webkit [27962] by Simon Hausmann
  • 2 edits in trunk/WebCore

For the build inside Qt include qbase.pri and don't duplicate what qbase.pri otherwise does (install targets, etc.)

2:11 AM Changeset in webkit [27961] by Simon Hausmann
  • 2 edits in trunk/WebCore

Don't set OBJECTS_DIR when building inside Qt

2:10 AM Changeset in webkit [27960] by Simon Hausmann
  • 2 edits in trunk/WebCore

Use ../generated as path for the generated sources for builds inside Qt

2:10 AM Changeset in webkit [27959] by Simon Hausmann
  • 5 edits in trunk

Make the directory of where to put the generated sources configurable through the GENERATED_SOURCE_DIR variable

2:10 AM Changeset in webkit [27958] by Simon Hausmann
  • 5 edits in trunk

Centralize the setup for all the extra compilers in a addExtraCompiler function.

This allows adding a "generated_files" target that builds all generated files
using "make generated_files". For the build inside Qt we do not generate
actual rules for the extra compilers but instead do the variable substitution
of compiler.output manually and add the generated sources to SOURCES.

2:06 AM UsingGitWithWebKit created by treat@kde.org
Start new page for collecting info for using git with webkit
2:03 AM QtWebKitContrib edited by treat@kde.org
Add a link for new page describing tips and tricks for using git with … (diff)
1:58 AM WikiStart edited by treat@kde.org
(diff)
1:40 AM WebKit Team edited by alp@atoker.com
Fix own entry (diff)
1:21 AM QtWebKit edited by treat@kde.org
(diff)
1:19 AM QtWebKitContrib edited by treat@kde.org
More information for new contributors (diff)
1:12 AM Open Source Contributors edited by treat@kde.org
(diff)
1:11 AM WikiStart edited by treat@kde.org
Don't need this anymore as we can add people to the Team page. (diff)
1:10 AM WebKit Team edited by treat@kde.org
Add lots more contributors and add review/commit info. (diff)
1:08 AM Changeset in webkit [27957] by Simon Hausmann
  • 5 edits in trunk/WebKit/qt

Fix license headers

Signed-off-by: Simon Hausmann <​hausmann@kde.org>

12:50 AM Changeset in webkit [27956] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Fix shadowing of "page" variable that is passed as argument as well as a member variable.

This also fixes compilation with gcc 4.3.

Signed-off-by: George Staikos <​staikos@kde.org>

Nov 21, 2007:

11:06 PM Changeset in webkit [27955] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2007-11-21 Eric Seidel <​eric@webkit.org>

Speculative build fix for Tiger.

  • DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
10:48 PM Changeset in webkit [27954] by mrowe@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Update changelog entry to match reality.

9:54 PM Changeset in webkit [27953] by timothy@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Eric Seidel.

Show Fonts as Yellow in the network timeline.

  • page/inspector/NetworkPanel.js:
  • page/inspector/inspector.css:
9:23 PM Changeset in webkit [27952] by mitz@apple.com
  • 6 edits
    4 adds in trunk

WebCore:

Reviewed by Eric Seidel.

  • fix <rdar://problem/5607037> REGRESSION (r27351): Departure date does not repaint when changed on Google Maps public transit planner (16034)

Test: fast/repaint/subtree-root-skipped.html

  • page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): Initialize the layout root to 0. (WebCore::FrameView::layoutRoot): Changed to return a RenderObject instead of a Node. (WebCore::FrameView::layout): Changed for layout root being a renderer rather than a DOM node. Also replaced clearing the repaint rects set with asserting that it is empty if this is the top-level call to layout(). If it is not, the set may contain rects from enclosing layout() and those should not be removed. (WebCore::FrameView::scheduleRelayout): Changed for layout root being a renderer rather than a DOM node. (WebCore::isObjectAncestorContainerOf): Added this helper function that tests whether one object will be marked by calling markContainingBlocksForLayout() on the other. (WebCore::FrameView::scheduleRelayoutOfSubtree): Changed for layout root being a renderer rather than a DOM node. Changed the check if new and current layout roots are on the same path from the root to use the subgraph of the render tree defined by container()hood instead of the DOM tree and parenthood.
  • page/FrameView.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcWidth): Changed for layout root being a renderer rather than a DOM node.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::~RenderObject): Added an assertion that the object being deleted is not currently the layout root. (WebCore::RenderObject::scheduleRelayout): Changed for layout root being a renderer rather than a DOM node.

LayoutTests:

Reviewed by Eric Seidel.

  • repaint test for <rdar://problem/5607037> REGRESSION (r27351): Departure date does not repaint when changed on Google Maps public transit planner (16034)
  • fast/repaint/subtree-root-skipped.html: Added.
  • platform/mac-leopard/fast/repaint/subtree-root-skipped-expected.checksum: Added.
  • platform/mac-leopard/fast/repaint/subtree-root-skipped-expected.png: Added.
  • platform/mac/fast/repaint/subtree-root-skipped-expected.txt: Added.
8:32 PM Changeset in webkit [27951] by mrowe@apple.com
  • 15 edits in trunk

Fix JavaScriptGlue, WebCore and WebKit to build without warnings using GCC 4.2.

Reviewed by Eric.

8:13 PM Changeset in webkit [27950] by mrowe@apple.com
  • 2 edits in trunk/WebKitSite

2007-11-21 Mark Rowe <​mrowe@apple.com>

Reviewed by Eric.

Update coding style to cover control statements with no body.

  • coding/coding-style.html:
8:03 PM Changeset in webkit [27949] by eric@webkit.org
  • 8 edits
    4 copies
    2 adds in trunk/WebKitTools

2007-11-21 Eric Seidel <​eric@webkit.org>

Reviewed by Tim Hatcher.

Break out more of DumpRenderTree.mm into individual files

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/mac/CheckedMalloc.cpp: Added. (checkedMalloc): (checkedRealloc): (makeLargeMallocFailSilently):
  • DumpRenderTree/mac/CheckedMalloc.h: Added.
  • DumpRenderTree/mac/DumpRenderTree.mm: (crashHandler): (dump):
  • DumpRenderTree/mac/DumpRenderTreeMac.h:
  • DumpRenderTree/mac/DumpRenderTreePasteboard.h:
  • DumpRenderTree/mac/DumpRenderTreePasteboard.m:
  • DumpRenderTree/mac/DumpRenderTreeWindow.h:
  • DumpRenderTree/mac/DumpRenderTreeWindow.mm:
  • DumpRenderTree/mac/JavaScriptThreading.cpp: Added. (javaScriptThreads): (runJavaScriptThread): (startJavaScriptThreads): (stopJavaScriptThreads):
  • DumpRenderTree/mac/JavaScriptThreading.h: Added.
  • DumpRenderTree/mac/PixelDumpSupport.h: Added.
  • DumpRenderTree/mac/PixelDumpSupport.mm: Added. (restoreColorSpace): (setDefaultColorProfileToRGB): (initializeColorSpaceAndScreeBufferForPixelTests): (md5HashStringForBitmap): (dumpWebViewAsPixelsAndCompareWithExpected):
7:28 PM Changeset in webkit [27948] by alp@webkit.org
  • 2 edits in trunk/WebCore

2007-11-21 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=16071
Curl backend handles EINTR incorrectly

Defer timers during select() to avoid interruption by timer signals.

  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::downloadTimerCallback):
7:08 PM Changeset in webkit [27947] by mrowe@apple.com
  • 13 edits in trunk

Fix <rdar://problem/5602936> Need to resolve new GCC 4.2 warnings.

Reviewed by Tim Hatcher.

Fix all warnings emitted by GCC 4.2 when building JavaScriptCore. This allows builds with
-Werror to succeed. At present they will crash when executed due to code that is not safe
under strict aliasing (<rdar://problem/5536806>).

This required some format strings to be modified in WebCore and WebKit as their format
specifiers did not match the argument type.

7:01 PM Changeset in webkit [27946] by kevino@webkit.org
  • 2 edits
    1 move in trunk/WebKitTools

Restore the wx buildbot for Mac by automatically installing dependencies not provided by the OS into WebKitLibraries.

Reviewed by Mark Rowe

6:19 PM Changeset in webkit [27945] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2007-11-21 Eric Seidel <​eric@webkit.org>

Reviewed by Adam.

More refactoring for greater code readability

  • DumpRenderTree/mac/DumpRenderTree.mm: (initializeGlobalsFromCommandLineOptions): (initializeColorSpaceAndScreeBufferForPixelTests): (addTestPluginsToPluginSearchPath): (useLongRunningServerMode): (runTestingServerLoop): (prepareConsistentTestingEnvironment): (dumpRenderTree): (main): (dumpFramesAsText): (dumpBackForwardListForWebView): (sizeWebViewForCurrentTest): (methodNameStringForFailedTest): (dumpBackForwardListForAllWindows): (dumpWebViewAsPixelsAndCompareWithExpected): (invalidateAnyPreviousWaitToDumpWatchdog): (dump):
  • DumpRenderTree/mac/DumpRenderTreeMac.h:
  • DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:createWebViewWithRequest:]):
4:24 PM Changeset in webkit [27944] by alp@webkit.org
  • 2 edits in trunk/WebCore

2007-11-21 Xan Lopez <​xan@gnome.org>

Reviewed by Alp Toker.

Clarify scroll event processing with a comment.

  • platform/gtk/PlatformScrollBarGtk.cpp: (gtkScrollEventCallback):
3:40 PM Changeset in webkit [27943] by timothy@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

Bug 16085: Web Inspector's Network Timeline graph code clean up and misc. fixes
​http://bugs.webkit.org/show_bug.cgi?id=16085


Changes include:

  • Refactor the drawing code as nested functions instead of global functions.
  • Compute the segment percentages only once per call to drawSummaryGraph.
  • Account for percentages that rounded down to total less-than 100%.
  • Draw the pill shadow better using the canvas shadow drawing properties.
  • Removes a couple canvas context saves and restores.
  • page/inspector/NetworkPanel.js:
11:29 AM Changeset in webkit [27942] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2007-11-21 Eric Seidel <​eric@webkit.org>

Reviewed by Tim Hatcher.

Abstract more of DRT into static methods

  • DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting): (setupSignalHandlers): (allocateGlobalControllers): (releaseAndZero): (releaseGlobalControllers): (dumpRenderTree): (shouldLogFrameLoadDelegates): (createCFURLFromPathOrURL): (resetWebViewToConsistentStateBeforeTesting): (runTest):
11:28 AM Changeset in webkit [27941] by eric@webkit.org
  • 4 edits
    2 copies
    2 adds in trunk/WebKitTools

2007-11-21 Eric Seidel <​eric@webkit.org>

Reviewed by Tim Hatcher.

Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files

  • DumpRenderTree/DumpRenderTree.h:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): (dump): (runTest):
  • DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
  • DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added. (+[DumpRenderTreePasteboard _pasteboardWithName:]): (+[DumpRenderTreePasteboard releaseLocalPasteboards]): (-[DumpRenderTreePasteboard declareType:owner:]): (+[LocalPasteboard alloc]): (-[LocalPasteboard init]): (-[LocalPasteboard dealloc]): (-[LocalPasteboard name]): (-[LocalPasteboard releaseGlobally]): (-[LocalPasteboard declareTypes:owner:]): (-[LocalPasteboard addTypes:owner:]): (-[LocalPasteboard changeCount]): (-[LocalPasteboard types]): (-[LocalPasteboard availableTypeFromArray:]): (-[LocalPasteboard setData:forType:]): (-[LocalPasteboard dataForType:]): (-[LocalPasteboard setPropertyList:forType:]): (-[LocalPasteboard setString:forType:]):
  • DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
  • DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added. (+[DumpRenderTreeWindow allWindows]): (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): (-[DumpRenderTreeWindow dealloc]): (-[DumpRenderTreeWindow isKeyWindow]): (-[DumpRenderTreeWindow keyDown:]):
10:48 AM BuildingGtk edited by alp@atoker.com
Add public API and GtkLauncher to the list of code modules (diff)
8:18 AM QtWebKitContrib edited by treat@kde.org
(diff)
8:15 AM BuildingQtOnWindows edited by treat@kde.org
(diff)
8:14 AM QtWebKitContrib edited by treat@kde.org
(diff)
8:13 AM BuildingQtOnLinux edited by treat@kde.org
(diff)
8:11 AM BuildingQtOnLinux edited by treat@kde.org
(diff)
8:08 AM QtWebKitContrib edited by treat@kde.org
(diff)
8:07 AM QtWebKitTodo edited by treat@kde.org
(diff)
8:07 AM QtWebKit edited by treat@kde.org
(diff)
8:06 AM QtWebKitContrib edited by treat@kde.org
(diff)
8:01 AM QtWebKitContrib created by treat@kde.org
7:16 AM QtWebKit edited by treat@kde.org
(diff)
5:02 AM Changeset in webkit [27940] by treat@webkit.org
  • 3 edits in trunk/WebKit/qt
  • Connect up the signal for all subframes too.
4:20 AM Changeset in webkit [27939] by ap@webkit.org
  • 2 edits in trunk/LayoutTests

Reviewed by Maciej.

<rdar://problem/5230233> dom/xhtml/level2/html/frame.xhtml is failing on Windows

This isn't actually a test, but an unused resource - we should re-work the W3C test rig to
support subresource loading from (X)HTML.
Anyway, it doesn't fail for me, I suppose this problem was fixed since the bug was filed.

  • platform/win/Skipped:
4:07 AM QtWebKitTodo edited by Simon Hausmann
(diff)
3:54 AM Changeset in webkit [27938] by ap@webkit.org
  • 3 edits in trunk/LayoutTests

Reviewed by Maciej.

Fix a copy/paste error in the test (introduced in bug 12194).

  • http/tests/xmlhttprequest/zero-length-response-sync-expected.txt:
  • http/tests/xmlhttprequest/zero-length-response-sync.html:
2:01 AM WikiStart edited by Adam Roben
(diff)
12:10 AM Changeset in webkit [27937] by ap@webkit.org
  • 11 edits in trunk/WebCore

Reviewed by Adam Roben.

​http://bugs.webkit.org/show_bug.cgi?id=16056
Unicode not being interpreted correctly in Web Inspector source view

Cannot be tested automatically.

  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::encoding):
  • loader/CachedCSSStyleSheet.h:
  • loader/CachedResource.h: (WebCore::CachedResource::encoding):
  • loader/CachedScript.cpp: (WebCore::CachedScript::encoding):
  • loader/CachedScript.h:
  • loader/CachedXBLDocument.cpp: (WebCore::CachedXBLDocument::encoding):
  • loader/CachedXBLDocument.h:
  • loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::encoding):
  • loader/CachedXSLStyleSheet.h: Teach textual CachedResources to report their encodings.
  • page/InspectorController.cpp: (WebCore::addSourceToFrame): (WebCore::updateResourceResponse): Use the actual encoding - the network layer has little idea about it.
Note: See TracTimeline for information about the timeline view.