Timeline


and

12/22/07:

18:18 Changeset [28965] by alp@webkit.org

2007-12-22 Xan Lopez <xan@gnome.org>

Reviewed by Alp Toker.

Use webView, web_view, etc for variable names instead of page, which
was left over from the old API.

15:54 Changeset [28964] by alp@webkit.org

2007-12-22 Alp Toker <alp@atoker.com>

GTK+ build fix

GTK_TARGET_OTHER_APP is not available in older GTK+ versions. Pass
empty target flags for now.

Check GTK+, not GLib versions, since they are different.

15:12 Changeset [28963] by alp@webkit.org

2007-12-22 Luca Bruno <lethalman88@gmail.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16311
[Gtk] Copy rich text to clipboard as text/plain and text/html.

Add copy and paste targets for WebView and implement
WebCore::PasteboardHelper.

13:39 Changeset [28962] by zimmermann@webkit.org

Reviewed by Oliver.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=15966 (Crash in SVGRootInlineBox::walkTextChunks() on mouse hover)

Add new isSVGRootInlineBox() function to InlineBox to be able to differentiate between RootInlineBox/SVGRootInlineBox.
SVG assumed it's root inline box (for <text> elements) is always of type SVGRootInlineBox, which is not the case
for HTML text in <foreignObject>. Text selection doesn't work so far as line box offsets are wrong - which is visible
in Web Inspector.

13:04 Changeset [28961] by antti@apple.com

Fix a typo.

12:03 Changeset [28960] by alp@webkit.org

2007-12-22 Alp Toker <alp@atoker.com>

LOW_BANDWIDTH_DISPLAY build fix

Track recent KURL DeprecatedString changes.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
08:48 Changeset [28959] by mitz@apple.com
  • Windows build fix
  • WebCore.vcproj/WebCore.vcproj:
08:35 Changeset [28958] by alp@webkit.org

2007-12-22 Xan Lopez <xan@gnome.org>

Reviewed by Alp Toker.

Follow up to http://bugs.webkit.org/show_bug.cgi?id=16144

  • WebView/webkitwebview.cpp: Fix signal id arguments for g_signal_emit in clipboard functions.
08:34 Changeset [28957] by alp@webkit.org

2007-12-22 Xan Lopez <xan@gnome.org>

Reviewed by Alp Toker.

Add missing return 0 to fix a compile warning.

  • page/gtk/FrameGtk.cpp: (WebCore::Frame::createScriptInstanceForWidget):

12/21/07:

23:26 Changeset [28956] by dsmith@webkit.org

At bdash's suggestion, display a message if someone attempts to run the 'native' version of the getElementsByClassName benchmark in a browser that doesn't support that.

  • blog-files/gebcnspeedtest.html:
23:02 Changeset [28955] by dsmith@webkit.org

Add the benchmark from the previous commit as well.

  • blog-files/gebcnspeedtest.html: Added.
  • blog-files/prototype-for-gebcn-test.js: Added.
22:45 Changeset [28954] by dsmith@webkit.org

Add a graph of benchmark results for an upcoming blog post.

  • blog-files/gebcnwebkitonly.png: Added.
22:12 Changeset [28953] by mrowe@apple.com

Versioning.

22:11 Changeset [28952] by mrowe@apple.com

New tag.

22:11 Changeset [28951] by mrowe@apple.com

New tag.

21:54 Changeset [28950] by mrowe@apple.com

2007-12-21 Mark Rowe <mrowe@apple.com>

Reviewed by Oliver Hunt.

20:40 Changeset [28949] by mrowe@apple.com

Fix http://bugs.webkit.org/show_bug.cgi?id=16549 (WebKit nightly build failing to launch on PowerPC G3s).

Rubber-stamped by Dan Bernstein.

  • libWebKitSystemInterfaceTiger.a: Update to a G3-friendly version.
20:18 Changeset [28948] by weinig@apple.com

Reviewed by Mark Rowe.

  • Disable the back/forward cache using the new WebPreferences API instead of through the BackForwardList. This makes us match what we do on Windows.
  • DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): (setDefaultsToConsistentValuesForTesting):
17:39 Changeset [28947] by mitz@apple.com

Reviewed by Mark Rowe.

  • disable the back/forward cache in Windows DumpRenderTree. It is already disabled in Mac DumpRenderTree.
  • DumpRenderTree/win/DumpRenderTree.cpp: (initializePreferences):
17:09 Changeset [28946] by antti@apple.com

Reviewed by Darin and Steve.

Add instructions to install the QuickTime SDK for Windows.

17:07 Changeset [28945] by antti@apple.com

Reviewed by Darin, Adam and Steve.

Add media playback support for Windows.


The implementation uses low level QuickTime API. DLL is
needed to work around CF use in both WebKit and QuickTime.


This makes Windows build depend on the QuickTime SDK


http://developer.apple.com/quicktime/download/


but not QuickTime itself.


QTMovieWinTimer contains some copy code from SharedTimerWin. It
is used in the QuickTime access DLL which can't use WebCore
SharedTimer due to dependency problems.

17:01 Changeset [28944] by alp@webkit.org

2007-12-21 Brent Fulgham <bfulgham@gmail.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16558
Cairo WebCore Rendering Fails on arc drawing

Fix for bug reported (and patched) by Apollo team in which
arcs were draw in reverse (resulting in inverted images).
Review of the source found that the 'clockwise' term was
actually meant to mean 'anticlockwise' so the IDL and
supporting classes have been changed to match this.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::arc):
  • html/CanvasRenderingContext2D.idl:
  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::addArc): (WebCore::Path::addEllipse):
  • platform/graphics/Path.h:
16:41 Changeset [28943] by alp@webkit.org

2007-12-21 Alp Toker <alp@atoker.com>

Documentation typo fix: s/wether/whether

  • WebView/webkitwebview.cpp:
16:36 Changeset [28942] by alp@webkit.org

2007-12-21 Christian Dywan <christian@twotoasts.de>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16144
[GTK] Clipboard/ selection handling functions

  • WebView/webkitprivate.h:
  • WebView/webkitwebview.cpp:
  • WebView/webkitwebview.h:
16:35 Changeset [28941] by weinig@apple.com

Reviewed by Adele.

Fix another mistaken duplication, this time in cross-frame-access-parent-explicit-domain.html,
that was causing intermittent failures.

  • http/tests/security/cross-frame-access-parent-explicit-domain-expected.txt:
  • http/tests/security/cross-frame-access-parent-explicit-domain.html:
  • http/tests/security/cross-frame-access-port-explicit-domain-expected.txt:
16:01 Changeset [28940] by weinig@apple.com

Reviewed by Dan Bernstein.

Fix mistaken duplication in cross-frame-access-child-explicit-domain.html that was causing
intermittent failures.

  • http/tests/security/cross-frame-access-child-explicit-domain-expected.txt:
  • http/tests/security/cross-frame-access-child-explicit-domain.html:
  • http/tests/security/cross-frame-access-custom-expected.txt:
15:15 Changeset [28939] by adachan@apple.com

Implemented DOMDocument::getElementById().

Reviewed by Darin.

  • DOMCoreClasses.cpp: (DOMDocument::getElementById):
14:02 Changeset [28938] by darin@apple.com

Requested by Maciej.

  • kjs/nodes.h: Use the new NEVER_INLINE here and eliminate the old KJS_NO_INLINE. We don't want to have two, and we figured it was better to keep the one that's in WTF.
13:54 Changeset [28937] by darin@apple.com

Reviewed by Eric.

1.022x as fast on SunSpider.

  • kjs/NodeInfo.h: Renamed SourceElementsStub to SourceElements, since that more accurately describes the role of this object, which is a reference-counted wrapper for a Vector.
  • kjs/Parser.cpp: (KJS::Parser::didFinishParsing): Changed parameter type to SourceElements, and use plain assignment instead of set.
  • kjs/Parser.h: Changed parameter type of didFinishParsing to a SourceElements. Also changed m_sourceElements; we now use a RefPtr instead of an OwnPtr as well.
  • kjs/grammar.y: Got rid of all the calls to release() on SourceElements. That's now handed inside the constructors for various node types, since we now use vector swapping instead.
  • kjs/nodes.cpp: (KJS::Node::rethrowException): Added NEVER_INLINE, because this was getting inlined and we want exception handling out of the normal code flow. (KJS::SourceElements::append): Moved here from the header. This now handles creating a BreakpointCheckStatement for each statement in the debugger case. That way we can get breakpoint handling without having it in every execute function. (KJS::BreakpointCheckStatement::BreakpointCheckStatement): Added. (KJS::BreakpointCheckStatement::execute): Added. Contains the code that was formerly in the StatementNode::hitStatement function and the KJS_BREAKPOINT macro. (KJS::BreakpointCheckStatement::streamTo): Added. (KJS::ArgumentListNode::evaluateList): Use KJS_CHECKEXCEPTIONVOID since the return type is void. (KJS::VarStatementNode::execute): Removed KJS_BREAKPOINT. (KJS::BlockNode::BlockNode): Changed parameter type to SourceElements. Changed code to use release since the class now contains a vector rather than a vector point. (KJS::BlockNode::optimizeVariableAccess): Updated since member is now a vector rather than a vector pointer. (KJS::BlockNode::execute): Ditto. (KJS::ExprStatementNode::execute): Removed KJS_BREAKPOINT. (KJS::IfNode::execute): Ditto. (KJS::IfElseNode::execute): Ditto. (KJS::DoWhileNode::execute): Ditto. (KJS::WhileNode::execute): Ditto. (KJS::ContinueNode::execute): Ditto. (KJS::BreakNode::execute): Ditto. (KJS::ReturnNode::execute): Ditto. (KJS::WithNode::execute): Ditto. (KJS::CaseClauseNode::optimizeVariableAccess): Updated since member is now a vector rather than a vector pointer. (KJS::CaseClauseNode::executeStatements): Ditto. (KJS::SwitchNode::execute): Removed KJS_BREAKPOINT. (KJS::ThrowNode::execute): Ditto. (KJS::TryNode::execute): Ditto. (KJS::ScopeNode::ScopeNode): Changed parameter type to SourceElements. (KJS::ProgramNode::ProgramNode): Ditto. (KJS::EvalNode::EvalNode): Ditto. (KJS::FunctionBodyNode::FunctionBodyNode): Ditto. (KJS::ScopeNode::optimizeVariableAccess): Updated since member is now a vector rather than a vector pointer.
  • kjs/nodes.h: Removed hitStatement. Renamed SourceElements to StatementVector. Renamed SourceElementsStub to SourceElements and made it derive from ParserRefCounted rather than from Node, hold a vector rather than a pointer to a vector, and changed the release function to swap with another vector rather than the pointer idiom. Updated BlockNode and CaseClauseNode to hold actual vectors instead of pointers to vectors. Added BreakpointCheckStatement.
  • kjs/nodes2string.cpp: (KJS::statementListStreamTo): Changed to work on a vector instead of a pointer to a vector. (KJS::BlockNode::streamTo): Ditto. (KJS::CaseClauseNode::streamTo): Ditto.
  • wtf/AlwaysInline.h: Added NEVER_INLINE.
  • wtf/PassRefPtr.h: Tweaked formatting. Added clear() function that matches the ones in OwnPtr and auto_ptr.
  • wtf/RefPtr.h: Ditto.
12:17 Changeset [28936] by ap@webkit.org

Reviewed by Steve and Darin.

<rdar://problem/5497037> Win32: Accelerator keys (ctrl-x,c,v,w,q,etc) only fire keyUp,
keyDown/Press consumed by accelerator table (14104)

<rdar://problem/5346299> preventing default behavior for key down does not block accelerators like Ctrl+N

This is WebKit part of a fix, most of which will be in Safari.

  • WebView.cpp: (WebViewWndProc): Return our result for WM_(SYS)KEYDOWN to let the client know whether further procesing is desired.
07:36 Changeset [28935] by darin@apple.com
  • fix broken regression tests

The broken tests were fast/js/do-while-expression-value.html and
fast/js/while-expression-value.html.

  • kjs/nodes.cpp: Check in the correct version of this file. I had accidentally landed an old version of my patch for bug 16471. (KJS::statementListExecute): The logic here was backwards. Have to set the value even for non-normal execution results.
03:00 Changeset [28934] by ap@webkit.org

Reviewed by Oliver.

<rdar://problem/5629995> Incorrect display of Danish characters on web site.

Test: http/tests/xmlhttprequest/response-encoding.html

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::didReceiveData): Default to UTF-8 for HTML, too. It's unfortunate that we have to use different rules for main content and XHR responses, but this matches both IE and Firefox.
02:57 Changeset [28933] by ap@webkit.org

Correct ChangeLog spelling.

02:55 Changeset [28932] by ap@webkit.org

Build fix: cannot use framework-style include for ProgIDMacros.h,
because the file is only created on a leter step.

  • ForEachCoClass.h:
01:09 Changeset [28931] by kevino@webkit.org

Buildbot fix for wx port.

12/20/07:

23:40 Changeset [28930] by ap@webkit.org

Windows build fix

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Copy npruntime_internal.h to WebKitBuild.
23:21 Changeset [28929] by eric@webkit.org

2007-12-17 Eric Seidel <eric@webkit.org>

Reviewed by mjs.

Split IfNode into IfNode and IfElseNode for speedup.
http://bugs.webkit.org/show_bug.cgi?id=16470

SunSpider claims this is 1.003x as fast as before.
(This required running with --runs 15 to get consistent enough results to tell!)

  • kjs/grammar.y:
  • kjs/nodes.cpp: (KJS::IfNode::optimizeVariableAccess): (KJS::IfNode::execute): (KJS::IfNode::getDeclarations): (KJS::IfElseNode::optimizeVariableAccess): (KJS::IfElseNode::execute): (KJS::IfElseNode::getDeclarations):
  • kjs/nodes.h: (KJS::IfNode::): (KJS::IfElseNode::):
  • kjs/nodes2string.cpp: (KJS::IfNode::streamTo): (KJS::IfElseNode::streamTo):
22:57 Changeset [28928] by jhoneycutt@apple.com

2007-12-20 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Kevin Decker.

<rdar://problem/5655797> REGRESSION(304-306A10) Safari does not find
shockwave plugin on freshly installed OS

Look for Director plugin in its native directory.

  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::getPluginsInPaths): The Director plugin doesn't start with "np," so special case its filename. (WebCore::addMacromediaPluginPaths): Add Flash and "Shockwave 10" directories to the plugin paths. (WebCore::PluginDatabaseWin::defaultPluginPaths):
22:07 Changeset [28927] by darin@apple.com

Reviewed by Oliver.

  • fix <rdar://problem/5658787> Selector -[WebView insertLineBreak:] is not implemented
  • WebView/WebView.mm: Added all selectors implemented by WebHTMLView to the list of selectors to forward here. The new ones are: changeBaseWritingDirection:, changeSpelling:, deleteToMark:, insertLineBreak:, moveParagraphBackwardAndModifySelection:, moveParagraphForwardAndModifySelection:, pageDownAndModifySelection:, pageUpAndModifySelection:, selectToMark:, setMark:, swapWithMark:, takeFindStringFromSelection:, toggleBaseWritingDirection:, and transpose:.
22:06 Changeset [28926] by darin@apple.com

Reviewed by Sam.

  • wtf/OwnPtr.h: (WTF::operator==): Added. (WTF::operator!=): Added.
19:56 Changeset [28925] by alp@webkit.org

2007-12-20 Peter Kasting <zerodpx@gmail.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16508
Fix regression in GIFImageDecoder.cpp: "Haeberli hack" led to wrongly
decoded transparent areas.

  • platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::haveDecodedRow):
  • platform/image-decoders/gif/GIFImageDecoder.h:
  • platform/image-decoders/gif/GIFImageReader.cpp: (GIFImageReader::output_row):
18:55 Changeset [28924] by justin.garcia@apple.com

WebCore:

Reviewed by Oliver Hunt.

<rdar://problem/5543472> GoogleDocs: Safari hangs when creating a list from a particular selection


Still need to fix similar issues with the other operations that iterate
over selected paragraphs, like FormatBlock, Indent and Outdent (<rdar://problem/5658933>).

  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::indentRegion): Added a FIXME.
  • editing/IndentOutdentCommand.h: Removed an unused function.
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::modifyRange): Renamed visibleStart to startOfSelection and visibleEnd to endOfSelection. Call the new selectionForParagraphIteration, which a) prevents operations like this one from being performed on a table that isn't fully selected (where the selection starts just before the table and ends inside it), and b) helps prevent paragraph iteration from going past the end of the selection. Call the new startOfNextParagraph, instead of using endOfParagraph(v).next(), since when v is in the last paragraph of the last cell of a table, that expression will return the position after the table, not the start of the next paragraph.
  • editing/htmlediting.cpp: (WebCore::enclosingListChild): Don't go above a table cell, so that list operations take effect inside the table cell where they are performed. (WebCore::selectionForParagraphIteration): Added, see above. (WebCore::indexForVisiblePosition): Moved from IndentOutdentCommand.cpp.
  • editing/htmlediting.h:
  • editing/visible_units.cpp: (WebCore::startOfNextParagraph): Added, see above.
  • editing/visible_units.h:
  • editing/TextIterator.h: (WebCore::TextIterator::exitNode): Added a FIXME.

LayoutTests:

Reviewed by Oliver Hunt.


<rdar://problem/5543472> GoogleDocs: Safari hangs when creating a list from a particular selection

  • editing/execCommand/5543472-1-expected.txt: Added.
  • editing/execCommand/5543472-1.html: Added.
  • editing/execCommand/5543472-2-expected.txt: Added.
  • editing/execCommand/5543472-2.html: Added.
  • editing/execCommand/5543472-3-expected.txt: Added.
  • editing/execCommand/5543472-3.html: Added.
18:18 Changeset [28923] by ggaren@apple.com

Reviewed by Oliver Hunt.


AST optimization: Avoid NULL-checking ForNode's child nodes.


0.6% speedup on SunSpider.


This is a proof of concept patch that demonstrates how to optimize
grammar productions with optional components, like


for (optional; optional; optional) {

...

}


The parser emits NULL for an optional component that is not present.

Instead of checking for a NULL child at execution time, a node that
expects an optional component to be present more often than not checks
for a NULL child at construction time, and substitutes a viable
alternative node in its place.

(We'd like the parser to start emitting NULL a lot more once we teach
it to emit NULL for certain no-op productions like EmptyStatement and
VariableStatement, so, as a foundation, it's important for nodes with
NULL optional components to be fast.)

  • kjs/Parser.cpp: (KJS::Parser::didFinishParsing): Check for NULL SourceElements. Also, moved didFinishParsing into the .cpp file because adding a branch while it was in the header file caused a substantial and inexplicable performance regression. (Did I mention that GCC is crazy?)
  • kjs/grammar.y:
  • kjs/nodes.cpp: (KJS::BlockNode::BlockNode): Check for NULL SourceElements. (KJS::ForNode::optimizeVariableAccess): No need to check for NULL here. (KJS::ForNode::execute): No need to check for NULL here.
  • kjs/nodes.h: (KJS::ForNode::): Check for NULL SourceElements. Substitute a TrueNode because it's semantically harmless, and it evaluates to boolean in an efficient manner.
17:31 Changeset [28922] by mitz@apple.com

Reviewed by John Sullivan.

  • reorganize skipped test list
  • platform/win/Skipped:
16:33 Changeset [28921] by alp@webkit.org

2007-12-20 Alp Toker <alp@atoker.com>

Rubber-stamped by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=16542
[GTK] Text is missing with old Pango version

Back out commits r28880, r28876, r28865, r28864 which added Pango font
selection support. These changes caused a regression where no text was
displayed with older Pango versions.

16:24 Changeset [28920] by eric@webkit.org

2007-12-20 Eric Seidel <eric@webkit.org>

Reviewed by mjs.

  • sunspider: increase default number of runs for more accurate numbers
15:59 Changeset [28919] by oliver@apple.com

ChangeLog entry corrections

15:46 Changeset [28918] by timothy@apple.com

Reviewed by Sam Weinig.

<rdar://problem/5604897> Double-clicking on JavaScript console error
won't show the line where it occurred

Make the URLs clickable in the console, since double clicking is used for
word text selection. Makes the word "line" localizable. Messages that don't
have a URL will no longer print "undefined". Messages that have a line number
less than or equal to 0 will no longer be printed.

  • English.lproj/InspectorLocalizedStrings.js: Add "%s (line %d)".
  • page/inspector/ConsolePanel.js: Tweak how the DOM nodes are created and change the click handler to look for a link with the "console-message-url" class name.
  • page/inspector/SourcePanel.js: Call setupSourceFrameIfNeeded() if a line row is needed.
  • page/inspector/inspector.css: Update the look of the URL in the console.
15:43 Changeset [28917] by eric@webkit.org

2007-12-20 Eric Seidel <eric@webkit.org>

Reviewed by mjs.

Fix major Array regression introduced by 28899.

SunSpider claims this is at least 1.37x as fast as pre-regression. :)

  • kjs/array_instance.cpp: make Array's fast again!
15:39 Changeset [28916] by oliver@apple.com

Slight logic reordering in JSImmediate::from(double)

Reviewed by Geoff.

This gives a 0.1% improvement in SunSpider.

15:30 Changeset [28915] by sfalken@apple.com

New tag.

15:30 Changeset [28914] by sfalken@apple.com

Bump versions for submit

14:46 Changeset [28913] by eric@webkit.org

2007-12-20 Eric Seidel <eric@webkit.org>

Reviewed by Geoff, then re-rubber-stamped by Geoff after final search/replace and testing.

Small reworking of Date code for 4% speedup on Date tests (0.2% overall)
http://bugs.webkit.org/show_bug.cgi?id=16537

Make msToYear human-readable
Make msToDayInMonth slightly more readable and avoid recalculating msToYear
Remove use of isInLeapYear to avoid calling msToYear
Remove dayInYear call by changing msToDayInMonth to dayInMonthFromDayInYear
Remove more duplicate calls to dayInYear and getUTCOffset for further speedup

  • kjs/DateMath.cpp: (KJS::daysFrom1970ToYear): (KJS::msToYear): (KJS::monthFromDayInYear): (KJS::checkMonth): (KJS::dayInMonthFromDayInYear): (KJS::dateToDayInYear): (KJS::getDSTOffsetSimple): (KJS::getDSTOffset): (KJS::gregorianDateTimeToMS): (KJS::msToGregorianDateTime):
14:39 Changeset [28912] by weinig@apple.com

WebCore:

Reviewed and landed by Sam Weinig.

http://bugs.webkit.org/show_bug.cgi?id=15313
<rdar://problem/5514516>

The same-origin check was incorrect in two cases (both fixed in this
patch):

A) If both the source and the target have set their document.domain

to the same value, the protocol must also match in order for
access to be allowed. Without this requirement, the browser is
vulnerable to the following attack:

1) Suppose there is an HTTPS site (www.example.com) that sets

document.domain = "example.com".

2) A network attacker redirects the browser to http://www.example.com/

a) injects script to set document.domain = "example.com", and
b) opens a window to https://www.example.com/

3) Now the network attacker can inject script into the HTTPS page,

stealing cookies and issuing banking transactions.

B) If only one of the source and target has set document.domain, then

access should be denied. With this behavior, the browser is
vulnerable to the following attack:

1) Suppose http://foo.example.com/ opens an iframe to

http://foo.example.com/frame.html that
a) sets document.domain = "example.com", and
b) opens an iframe to http://bar.example.com/
This is a common usage of document.domain for cross-domain
communication, see for example:

http://www.collinjackson.com/research/papers/fp801-jackson.pdf

2) The inner-most iframe, which is from bar.example.com, sets

document.domain = "example.com".

3) Now the inner-most iframe can inject script into the middle

iframe (say via document.write). This bar.example.com script
now has access to the outer-most frame (from foo.example.com).

Both these changes cause WebKit to match the behavior of Firefox 2 and
IE6 in these cases. This patch includes regression tests for both
issues.

Internet Explorer 7 and Opera 9 are more strict in that they require
the port numbers to match when both pages have document.domain set.
Opera 9 allows access when only one page has set document.domain, but
this is a security vulnerability.

Tests: http/tests/security/cross-frame-access-child-explicit-domain.html

http/tests/security/cross-frame-access-parent-explicit-domain.html

  • bindings/js/kjs_window.cpp: (KJS::createWindow): (KJS::Window::allowsAccessFrom):
  • dom/Document.cpp: (WebCore::Document::domain): (WebCore::Document::setDomain): (WebCore::Document::initSecurityOrigin):
  • dom/Document.h: (WebCore::Document::securityOrigin):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): (WebCore::FrameLoader::checkCallImplicitClose): (WebCore::FrameLoader::shouldAllowNavigation):
  • platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::setForURL): (WebCore::SecurityOrigin::createForFrame): (WebCore::SecurityOrigin::canAccess):
  • platform/SecurityOrigin.h: (WebCore::SecurityOrigin::domain):
  • storage/Database.cpp: (WebCore::Database::openDatabase): (WebCore::Database::Database): (WebCore::Database::securityOriginData):
  • storage/Database.h: (WebCore::Database::databaseDebugName):
  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::canEstablishDatabase):
  • storage/SQLTransaction.cpp: (WebCore::SQLTransaction::postflightAndCommit): (WebCore::SQLTransaction::cleanupAfterTransactionErrorCallback):

LayoutTests:

Reviewed and landed by Sam Weinig.

Update LayoutTests for http://bugs.webkit.org/show_bug.cgi?id=15313

  • http/tests/security/cross-frame-access-child-explicit-domain-expected.txt: Added.
  • http/tests/security/cross-frame-access-child-explicit-domain.html: Added.
  • http/tests/security/cross-frame-access-custom-expected.txt:
  • http/tests/security/cross-frame-access-parent-explicit-domain-expected.txt: Added.
  • http/tests/security/cross-frame-access-parent-explicit-domain.html: Added.
  • http/tests/security/cross-frame-access-port-explicit-domain-expected.txt:
  • http/tests/security/cross-frame-access-protocol-explicit-domain-expected.txt:
  • http/tests/security/cross-frame-access-protocol-explicit-domain.html:
14:17 Changeset [28911] by mrowe@apple.com

2007-12-20 Rodney Dawes <dobey@wayofthemonkey.com>

Reviewed by Darin Adler.

Proxy includes of npruntime.h or npapi.h through npruntime_internal.h
Include stdio.h in npapi.h for the use of FILE with XP_UNIX defined
This is for building with X11, as some type and enum names conflict
with #define names in X11 headers.
http://bugs.webkit.org/show_bug.cgi?id=15669

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bindings/NP_jsobject.h:
  • bindings/npapi.h:
  • bindings/npruntime.cpp:
  • bindings/npruntime_impl.h:
  • bindings/npruntime_priv.h:
  • bindings/npruntime_internal.h:
  • bindings/testbindings.cpp:
  • bindings/c/c_class.h:
  • bindings/c/c_runtime.h:
  • bindings/c/c_utility.h:

2007-12-20 Rodney Dawes <dobey@wayofthemonkey.com>

Reviewed by Darin Adler.

Define XP_UNIX when building with plugins on X11.
Use new npruntime_internal.h instead of npruntime.h.
http://bugs.webkit.org/show_bug.cgi?id=15669

  • ForwardingHeaders/bindings/npruntime_internal.h
  • WebCore.pro:
  • html/HTMLPlugInElement.h:
14:16 Changeset [28910] by kmccullough@apple.com

WebKit/win:

Reviewed by Steve.

  • <rdar://5656485> Drosera: Win: Nightly does not reliably connect to WebKit.
  • Drosera and Safari need to use the same ProgIDs in order for CoCreateInstance to work properly. The most robust way to do this is for WebKit to dynamically publish those ProgIDs.
  • ForEachCoClass.cpp: Added. (setUseOpenSourceWebKit): (progIDForClass):
  • ForEachCoClass.h: Added functionality to publish ProgIDs.
  • WebKit.vcproj/WebKit.def: Exposed added functions for applications.
  • WebKit.vcproj/WebKit.vcproj: Added ForEachCoClass.cpp
  • WebKit.vcproj/WebKit_debug.def: Exposed added functions fori applications.

WebKitTools:

Reviewed by Steve.

  • <rdar://5656485> Drosera: Win: Nightly does not reliably connect to WebKit.
  • Drosera and Safari need to use the same ProgIDs in order for CoCreateInstance to work properly. The most robust way to do this is for WebKit to dynamically publish those ProgIDs.
  • Drosera/win/DebuggerClient.cpp: Use the published ProgIDs (DebuggerClient::createWebViewWithRequest):
  • Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some statics. (Drosera::initUI): (Drosera::attach): (Drosera::attemptToCreateServerConnection):
  • Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
  • Drosera/win/ServerConnection.cpp: Reformat the connection function and make use of the published ProgIDs. (ServerConnection::attemptToCreateServerConnection):
14:10 Changeset [28909] by slewis@apple.com

revert script check-ins that I didn't mean to commit

14:05 Changeset [28908] by slewis@apple.com

Any attribute name start with a unicode which like #xx00(x could be any hex number[0-9a-f]) will cause HTMLTokenizer parse error
Actually any unicode characters which great than 255 in attribute name will cause Webkit parse the attribute name wrong. So after comparing
the same scenario in IE 6/7, FireFox 2/3, Opera, we should treat those characters as part of attribute name.

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseEntity): Handle Unicode Entity Name by using ASCII version of findEntity. (WebCore::HTMLTokenizer::parseTag): Let type of ptr match type of cBuffer.
  • html/HTMLTokenizer.h: Change type of cBuffer from char to UChar.
13:57 Changeset [28907] by darin@apple.com

Same patch as last time with the test failures problem fixed.

  • kjs/function.cpp: (KJS::GlobalFuncImp::callAsFunction): Make sure to check the completion type from newExec to see if the execute raised an exception.
13:22 Changeset [28906] by sfalken@apple.com

New tag.

13:22 Changeset [28905] by sfalken@apple.com

Bump versions for submit

13:21 Changeset [28904] by mrowe@apple.com

Versioning.

13:21 Changeset [28903] by mrowe@apple.com

Merge r28057.

13:06 Changeset [28902] by kdecker@apple.com

Reviewed by Anders.


Fixed: <rdar://problem/5638288> REGRESSION: Flash movies show up in other tabs above the page (16373)

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView updateAndSetWindow]): QuickDraw plug-ins must manually be told when to stop writing to the window backing store. The problem was that change-set 28400 introduced an early return which prevented this necessary operation. The fix is to limit the scope of the early return to CG and GL plug-ins and to tweak the needsFocus check to prevent an exception from occurring in QuickDraw-based plug-ins.
13:01 Changeset [28901] by kmccullough@apple.com
  • <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
  • Build bot and leak fix.
  • DumpRenderTree/LayoutTestController.cpp: (pathToLocalResourceCallback):
12:40 Changeset [28900] by mrowe@apple.com

New tag.

12:33 Changeset [28899] by darin@apple.com
  • roll out that last change -- it was causing test failures; I'll check it back in after fixing them
12:10 Changeset [28898] by mrowe@apple.com

Versioning.

12:10 Changeset [28897] by mrowe@apple.com

Merge r28057.

12:08 Changeset [28896] by mrowe@apple.com

Versioning.

12:08 Changeset [28895] by mrowe@apple.com

Merge r28057.

12:05 Changeset [28894] by mrowe@apple.com

Merge r28057.

11:40 Changeset [28893] by mrowe@apple.com

New tag.

11:40 Changeset [28892] by mrowe@apple.com

New tag.

11:21 Changeset [28891] by eric@webkit.org

2007-12-20 Eric Seidel <eric@webkit.org>

Reviewed by Nikolas Zimmermann.

WebKit claims to support SVG feature strings it shouldn't
http://bugs.webkit.org/show_bug.cgi?id=15480

  • dom/DOMImplementation.cpp: (WebCore::isSVG10Feature): (WebCore::isSVG11Feature):
10:49 Changeset [28890] by sullivan@apple.com

Reviewed by Oliver and Geoff


  • fix <rdar://problem/5536858> Yellow highlight for find results is sometimes shorter than white "hole" behind it
  • rendering/RenderText.cpp: (WebCore::RenderText::addLineBoxRects): respect useSelectionHeight in all cases; we were only respecting it in one of the two cases
10:28 Changeset [28889] by mitz@apple.com

Reviewed by Darin Adler.

  • fix <rdar://problem/5656368> REGRESSION(3.0.4-ToT): Acid2 test fails to render anything
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::maximumScroll): Changed back to return the maximum scroll offsets even if scrolling is not allowed, because navigation and scrollTo should still work. (WebCore::ScrollView::wheelEvent): Added early return if scrolling is not allowed.
10:09 Changeset [28888] by alp@webkit.org

2007-12-17 Tony Chang <idealisms@gmail.com>

Reviewed by Darin.

Test: fast/text/reset-drag-on-mouse-down.html

09:42 Changeset [28887] by darin@apple.com

Reviewed by Eric.

SuSpider shows 2.4% speedup.

Stop using completions in the execution engine.
Instead, the completion type and label target are both
stored in the ExecState.

  • API/JSContextRef.cpp: Removed unneeded include of "completion.h".
  • bindings/runtime_method.cpp: Removed unused execute function.
  • bindings/runtime_method.h: Ditto.
  • kjs/ExecState.h: Added completionType, breakOrContinueTarget, setCompletionType, setNormalCompletion, setBreakCompletion, setContinueCompletion, setReturnValueCompletion, setThrowCompletion, setInterruptedCompletion, m_completionType, and m_breakOrContinueTarget.
  • kjs/completion.h: Removed constructor and getter for target for break and continue from Completion. This class is now only used for the public API to Interpreter and such.
  • kjs/date_object.h: Removed unused execute function.
  • kjs/function.cpp: (KJS::FunctionImp::callAsFunction): Removed some unneeded exception processing. Updated to call the new execute function and to get the completion type from the ExecState. Merged in the execute function, which repeated some of the same logic and was called only from here. (KJS::GlobalFuncImp::callAsFunction): More of the same for eval.
  • kjs/function.h: Removed execute.
  • kjs/interpreter.cpp: (KJS::Interpreter::evaluate): Added code to convert the result of execut into a Completion.
  • kjs/nodes.cpp: (KJS::Node::setErrorCompletion): Renamed from createErrorCompletion. Now sets the completion type in the ExecState. (KJS::Node::rethrowException): Now sets the completion type in the ExecState. (KJS::StatementNode::hitStatement): Now sets the completion type in the ExecState. (KJS::VarStatementNode::execute): Updated to put completion type in the ExecState instead of a Completion object. (KJS::statementListExecute): Ditto. Also changed the for loop to use indices instead of iterators. (KJS::BlockNode::execute): Updated return type. (KJS::EmptyStatementNode::execute): Updated to put completion type in the ExecState instead of a Completion object. (KJS::ExprStatementNode::execute): Ditto. (KJS::IfNode::execute): Ditto. (KJS::DoWhileNode::execute): Ditto. Also streamlined the logic a little to make the normal case a little faster and moved the end outside the loop so that "break" can do a break. (KJS::WhileNode::execute): Ditto. (KJS::ForNode::execute): Ditto. (KJS::ForInNode::execute): Ditto. (KJS::ContinueNode::execute): Updated to put completion type in the ExecState instead of a Completion object. (KJS::BreakNode::execute): Ditto. (KJS::ReturnNode::execute): Ditto. (KJS::WithNode::execute): Ditto. (KJS::CaseClauseNode::executeStatements): Ditto. Also renamed to have execute in its name to reflect the fact that it's a member of the same family of functions. (KJS::CaseBlockNode::executeBlock): Ditto. (KJS::SwitchNode::execute): Ditto. (KJS::LabelNode::execute): Ditto. (KJS::ThrowNode::execute): Ditto. (KJS::TryNode::execute): Ditto. (KJS::ProgramNode::execute): Ditto. (KJS::EvalNode::execute): Ditto. (KJS::FunctionBodyNode::execute): Ditto. (KJS::FuncDeclNode::execute): Ditto.
  • kjs/nodes.h: Renamed setErrorCompletion to createErrorCompletion, made hitStatement protected, changed return value of execute to a JSValue, renamed evalStatements to executeStatements, and evalBlock to executeBlock.
  • kjs/number_object.h: Removed unused execute function.
05:17 QtWebKitTodo edited by zecke2@selfish.org
(diff)
02:31 Changeset [28886] by ggaren@apple.com

Added Radar number.

  • kjs/nodes.cpp: (KJS::ProgramNode::processDeclarations):
01:41 Changeset [28885] by ggaren@apple.com

Linux build fix: config.h has to come first.

  • kjs/error_object.cpp:
01:32 Changeset [28884] by ggaren@apple.com

JavaScriptCore:

Reviewed by Oliver Hunt.


Optimized global access to global variables, using a symbol table.


SunSpider reports a 1.5% overall speedup, a 6.2% speedup on 3d-morph,
and a whopping 33.1% speedup on bitops-bitwise-and.

  • API/JSCallbackObjectFunctions.h: Replaced calls to JSObject:: with calls to Base::, since JSObject is not always our base class. This was always a bug, but the bug is even more apparent after some of my changes.

(KJS::::staticFunctionGetter): Replaced use of getDirect with call to
getOwnPropertySlot. Global declarations are no longer stored in the
property map, so a call to getDirect is insufficient for finding
override properties.

  • API/testapi.c:
  • API/testapi.js: Added test for the getDirect change mentioned above.
  • kjs/ExecState.cpp:
  • kjs/ExecState.h: Dialed back the optimization to store a direct pointer to the localStorage buffer. One ExecState can grow the global object's localStorage without another ExecState's knowledge, so ExecState can't store a direct pointer to the localStorage buffer unless/until we invent a way to update all the relevant ExecStates.
  • kjs/JSGlobalObject.cpp: Inserted the symbol table into get and put operations. (KJS::JSGlobalObject::reset): Reset the symbol table and local storage, too. Also, clear the property map here, removing the need for a separate call.
  • kjs/JSVariableObject.cpp:
  • kjs/JSVariableObject.h: Added support for saving localStorage and the symbol table to the back/forward cache, and restoring them.
  • kjs/function.cpp: (KJS::GlobalFuncImp::callAsFunction): Renamed progNode to evalNode because it's an EvalNode, not a ProgramNode.
  • kjs/lookup.h: (KJS::cacheGlobalObject): Replaced put with faster putDirect, since that's how the rest of lookup.h works. putDirect is safe here because cacheGlobalObject is only used for objects whose names are not valid identifiers.
  • kjs/nodes.cpp: The good stuff!

(KJS::EvalNode::processDeclarations): Replaced hasProperty with
the new hasOwnProperty, which is slightly faster.

  • kjs/object.h: Nixed clearProperties because clear() does this job now.
  • kjs/property_map.cpp:
  • kjs/property_map.h: More back/forward cache support.


  • wtf/Vector.h: (WTF::::grow): Added fast non-branching grow function. I used it in an earlier version of this patch, even though it's not used anymore.

JavaScriptGlue:

Build fix.

  • ForwardingHeaders/wtf/VectorTraits.h: Added.

WebCore:

Reviewed by Oliver Hunt.

Build support:

  • ForwardingHeaders/kjs/SymbolTable.h: Added.
  • ForwardingHeaders/wtf/VectorTraits.h: Added.
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot): Replaced use of getDirectLocation with getOwnPropertySlot. getDirectLocation is no longer valid, since global declarations are not stored in the property map.

(WebCore::JSDOMWindow::customPut): Replaced use of JSObject::put with
JSGlobalObject::put. JSObject::put is no longer valid, since global
declarations are not stored in the property map.

  • bindings/js/kjs_window.cpp: Replaced JSObject:: calls with Base:: calls, since JSObject is not our base class. This was always a bug, but the bug is even more apparent after some of my changes.

(KJS::Window::clear): Removed call to clearProperties because
JSGlobalObject::reset takes care of that now.

  • history/CachedPage.cpp:
  • history/CachedPage.h: Added support for saving a symbol table and localStorage to the page cache, and restoring it.

WebKit/mac:

Reviewed by Oliver Hunt.

Build fix.

  • ForwardingHeaders/kjs/SymbolTable.h: Added.
  • ForwardingHeaders/wtf/VectorTraits.h: Added.

LayoutTests:

Reviewed by Oliver Hunt.


Added some tests to verify some of the changes I made while optimizing
global access to global variables.

  • fast/dom/Window/resources/window-property-clearing-iframe0.html: Added.
  • fast/dom/Window/resources/window-property-clearing-iframe1.html: Added.
  • fast/dom/Window/window-property-clearing-expected.txt: Added.
  • fast/dom/Window/window-property-clearing.html: Added.
  • fast/dom/getter-on-window-object2-expected.txt: Added.
  • fast/dom/getter-on-window-object2.html: Added.

Checked in failing results for these const tests. The symbol table
optimization broke const. (We didn't know this before because our only
tests used global variables.)

  • fast/js/const-expected.txt:
  • fast/js/kde/const-expected.txt:
  • fast/js/resources/for-in-avoid-duplicates.js: Fixed a typo I noticed. Not related to this patch.
  • fast/dom/Window/window-property-shadowing.html: Changed this test to use "this" instead of "window". The fact that "window" worked before, despite an overriding / shadowing var declaration, was a bug.

12/19/07:

22:40 Changeset [28883] by mitz@apple.com
  • remove two more tests that pass now due to changed font fallback
  • platform/win/Skipped:
22:29 BuildingGtk edited by chad.kittel@gmail.com
added Lunar-Linux's package information. (diff)
22:21 Changeset [28882] by mitz@apple.com

WebCore:

Reviewed by Darin Adler and Dave Hyatt.

  • Substitute the user's preferred standard font for an unknown primary font before falling back on the platform's last resort font

Cannot be tested in DumpRenderTree because it sets the standard font to
Times, which is also the hard-coded last resort font on Mac.

  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::getFontData): Changed the early bail out condition to allow getting generic font families from settings even if there are not @font-face rules. Fixed a typo that mapped fantasy to cursive. Added a mapping from -webkit-standard to the standard family.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): Changed to always create a font selector. (WebCore::CSSRuleSet::addRulesFromSheet): (WebCore::CSSStyleSelector::applyProperty): Changed to always use the font selector.
  • css/CSSStyleSelector.h: (WebCore::CSSStyleSelector::fontSelector):
  • platform/graphics/FontCache.cpp: (WebCore::FontCache::getFontData): Try the user's preferred standard font before the platform's last resort font.

LayoutTests:

  • remove passing tests following the change to font fallback
  • platform/win/Skipped: Removed tests that failed only because they specified as primary font family a font family that was not available on Windows and therefore were rendered using the platform last resort font, Times New Roman. Now they are rendered using the 'standard' font family, which is set to Times on both Mac and Windows when running the tests.
20:24 Changeset [28881] by ddkilzer@apple.com

Make svn-apply/svn-unapply work with patches from git-format-patch.

Reviewed by Darin.

  • Scripts/svn-apply: (patch): If 'Index:' can't be found in the text passed in, print it out with a warning and return early.
  • Scripts/svn-unapply: (patch): Ditto.
19:03 Changeset [28880] by alp@webkit.org

2007-12-19 Sven Herzberg <sven@imendio.com>

Reviewed by Alp Toker.

Scaled font destruction takes place in FontData::platformDestroy(). No
need to do it in FontPlatformData::~FontPlatformData().

Destroying platform data in platformDestroy() is a convention we
borrow from the Mac and Win ports.

  • platform/graphics/gtk/FontPlatformDataGtk.cpp:
17:12 Changeset [28879] by alice.liu@apple.com

build fix (Windows)

Changed uint to unsigned int. uint caused Windows build breakage

  • page/Page.cpp: (WebCore::Page::markAllMatchesForText):
  • page/Page.h:
16:23 Changeset [28878] by alp@webkit.org

2007-12-19 Christian Dywan <christian@twotoasts.de>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16222
[GTK] Implement inline search and highlighting of matching strings.

16:02 Changeset [28877] by ggaren@apple.com

Reviewed by Sam Weinig, Dan Bernstein.

Tiger build fix: restored some graphics code still needed on Tiger.

  • platform/graphics/GraphicsTypes.h:
  • platform/graphics/cg/GraphicsContextCG.cpp:
  • platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::setCompositeOperation):
15:22 Changeset [28876] by alp@webkit.org

2007-12-19 Alp Toker <alp@atoker.com>

Build fix for Pango < 1.18.0 breakage introduced in r28864. Use Fc and
the Pango backend API in these cases.

  • platform/graphics/gtk/FontPlatformDataGtk.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::~FontPlatformData):
14:51 Changeset [28875] by alice.liu@apple.com

WebCore:

Reviewed by Darin.

Fixed <rdar://problem/5592485> Safari crashed trying to get a motorcycle insurance quote
on Geico.com WebCore::Document::inPageCache()

Calling Node::willRemove on the focusedNode would immediately tell the document to remove
the focused node, and trigger JS events. This means that the document is mutated while
the engine is trying to tell all child nodes that it's about to removed. To avoid
crashing, we need to hold off on mutating the document until node traversal is finished.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChild): (WebCore::ContainerNode::removeChildren):
  • dom/Node.cpp:
  • dom/Node.h: (WebCore::Node::willRemove):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::clear):

LayoutTests:

Reviewed by Darin.

Fixed <rdar://problem/5592485> Safari crashed trying to get a motorcycle insurance quote
on Geico.com WebCore::Document::inPageCache()

  • fast/events/nested-event-remove-node-crash-expected.txt: Added.
  • fast/events/nested-event-remove-node-crash.html: Added.
13:57 Changeset [28874] by aboule@apple.com

LayoutTests:

Reviewed by Dan Bernstein.

Adding tests for canvas compositing modes to make sure the results don't change after:
<rdar://problem/5640059> GraphicsContext::setCompositeOperation should use CGContextSetBlendMode

The following compositing modes don't pass however that is covered by another bug:
source-in
source-out
destination-in
destination-atop
copy
<rdar://problem/5651783> Some canvas tag compositing modes don't render correctly

  • fast/canvas/canvas-composite.html: Added.
  • platform/mac/fast/canvas/canvas-composite-expected.checksum: Added.
  • platform/mac/fast/canvas/canvas-composite-expected.png: Added.
  • platform/mac/fast/canvas/canvas-composite-expected.txt: Added.

WebCore:

Reviewed by Dan Bernstein.

Test: fast/canvas/canvas-composite.html

Fix for:
<rdar://problem/5640059> GraphicsContext::setCompositeOperation should use CGContextSetBlendMode

This fix makes setCompositeOperation consistent across all platforms that use CG.

The following compositing modes don't pass however that is covered by another bug:
source-in
source-out
destination-in
destination-atop
copy
<rdar://problem/5651783> Some canvas tag compositing modes don't render correctly

  • platform/graphics/GraphicsTypes.h:
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setCompositeOperation):
  • platform/graphics/mac/GraphicsContextMac.mm:
  • platform/win/GraphicsContextWin.cpp:
13:45 Changeset [28873] by mitz@apple.com

WebCore:

Reviewed by Dave Hyatt.

  • fix <rdar://problem/5650045> REGRESSION: major layout problems in svn r28754 WebKit on Vox.com page

Test: fast/dynamic/subtree-boundary-percent-height.html

  • rendering/RenderObject.cpp: (WebCore::objectIsRelayoutBoundary): Do not allow overflows with percent heights because sometimes they compute to 'auto'.

LayoutTests:

Reviewed by Dave Hyatt.

  • test for <rdar://problem/5650045> REGRESSION: major layout problems in svn r28754 WebKit on Vox.com page
  • fast/dynamic/subtree-boundary-percent-height.html: Added.
  • platform/mac/fast/dynamic/subtree-boundary-percent-height-expected.checksum: Added.
  • platform/mac/fast/dynamic/subtree-boundary-percent-height-expected.png: Added.
  • platform/mac/fast/dynamic/subtree-boundary-percent-height-expected.txt: Added.
13:21 Changeset [28872] by hyatt@apple.com

Fix unsigned/enum problem on Win32. r=darin.

12:26 Changeset [28871] by bdakin@apple.com

Oops! Typo!

12:15 Changeset [28870] by hyatt@apple.com

Fix unsigned/enum problem on Win32. r=darin.

12:14 Changeset [28869] by hyatt@apple.com

Fix unsigned/enum problem on Win32. r=darin.

12:11 Changeset [28868] by weinig@apple.com

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=16511
Speed up ClassNodeList and NamedNodeList by using the caching mechanism employed by ChildNodeList.

  • dom/ChildNodeList.cpp: Use the caching NodeList constructor to turn on caching. (WebCore::ChildNodeList::ChildNodeList):
  • dom/ClassNodeList.cpp: (WebCore::ClassNodeList::ClassNodeList):
  • dom/ClassNodeList.h:

Move getElementsByName and getElementsByClassName to Node so they
can use easily employ the caching already used by ChildNodeLists. In the case of
getElementsByClassName, this reduces code duplication in Element as well

  • dom/Document.cpp:
  • dom/Document.h:

Move getElementsByClassName to Node.

  • dom/Element.cpp:
  • dom/Element.h:
  • dom/NameNodeList.cpp: Use the caching NodeList constructor to turn on caching. (WebCore::NameNodeList::NameNodeList): (WebCore::NameNodeList::item):
  • dom/NameNodeList.h:

Add maps of caches for ClassNodeLists and NameNodeList to NodeListsNodeData.

  • dom/Node.cpp: (WebCore::TagNodeList::TagNodeList): (WebCore::Node::Node): (WebCore::Node::~Node): (WebCore::Node::childNodes): (WebCore::Node::registerNodeList): (WebCore::Node::getElementsByName): (WebCore::Node::getElementsByClassName):
  • dom/Node.h: Make m_nodeLists an OwnPtr. Moved getElementsByName and getElementsByClassName here

Allow subclasses to choose whether they want to receive the notifications using a new bit.

  • dom/NodeList.cpp: (WebCore::NodeList::NodeList):
  • dom/NodeList.h: (WebCore::NodeList::needsNotifications):
11:24 Changeset [28867] by hyatt@apple.com

Add support for GDI text on Windows.

11:13 Changeset [28866] by hyatt@apple.com

Add fourth preference value for GDI text font smoothing to WebKit.

10:41 Changeset [28865] by alp@webkit.org

2007-12-19 Alp Toker <alp@atoker.com>

Remove the cairo-ft pkg-config check. The GTK+ port doesn't use
cairo-ft directly following changes in r28864.

  • WebKit.pri:
10:00 Changeset [28864] by alp@webkit.org

2007-12-19 Sven Herzberg <sven@imendio.com>

Reviewed by Alp Toker.

Replace the fontconfig/freetype based font management with a pango
based one. Fixes:
http://bugs.webkit.org/show_bug.cgi?id=15229

  • platform/gtk/FontDataGtk.cpp (FontData::platformDestroy()): updated the platform specific destroy code (FontData::containsCharacters()): implemented font coverage with pango
  • platform/gtk/FontPlatformData.h: replaced fontconfig specific members with pango-specific ones
  • platform/gtk/FontPlatformDataGtk.cpp: added static members for the FontPlatformData class (FontPlatformData::FontPlatformData()): implemented the font-matching with a PangoFontDescription instead of an FcPattern; initialize the scaled font by using the API for PangoCairoFont (FontPlatformData::init()): initialize the PangoFontMap and set up a hash table to translate the font family name into a font family (FontPlatformData::isFixedPitch()): implemented by querying the PangoFontFamily (FontPlatformData::operator==): compare the FontPlatformData by comparing the font pointers or the described fonts
  • platform/gtk/GlyphPageTreeNodeGtk.cpp (pango_font_get_glyph()): added a function to query a glyph from a PangoFont (GlyphPage::fill()): implemented the fill function with Pango instead of fontconfig/freetype
09:36 Changeset [28863] by kevino@webkit.org

wx build process improvements, including added checks and outdated changes after the move to trunk.

Reviewed by Alp Toker

09:00 Changeset [28862] by alp@webkit.org

2007-12-19 Alp Toker <alp@atoker.com>

Reviewed by Holger Freyther.

Delete when Destroy functions are called to avoid leaks

This matches the Mac port.

  • WebCoreSupport/ChromeClientGtk.cpp:
  • WebCoreSupport/ContextMenuClientGtk.cpp:
  • WebCoreSupport/InspectorClientGtk.cpp:
08:55 Changeset [28861] by alp@webkit.org

2007-12-19 Alp Toker <alp@atoker.com>

Reviewed by Holger Freyther.

Improve graphics operator approximations

These changes match Cairo's own CG approximations.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::toCairoOperator):
08:55 Changeset [28860] by alp@webkit.org

2007-12-19 Alp Toker <alp@atoker.com>

Reviewed by Holger Freyther.

Check the bounding box before doing a full hit test

  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::contains):
01:10 Changeset [28859] by mrowe@apple.com

Build fix for non-Mac platforms. Move NodeInfo into its own header so that the YYTYPE declaration in grammar.h is able to declare members of that type.

00:41 Changeset [28858] by weinig@apple.com

Reviewed by Geoff.

Fix for <rdar://problem/5646478>
REGRESSION: fast/events/event-view-toString fails on Leopard

This fixes an issue where we were incorrectly setting the lastInPrototypeChain
for the JSDOMWindow (the global object) before a call to setPrototype overwrote
it. This fixes it by passing the prototype up the constructor chain so that it
is set before any calls can be made.

  • bindings/js/kjs_window.cpp: (KJS::Window::Window):
  • bindings/js/kjs_window.h:
  • bindings/scripts/CodeGeneratorJS.pm:
00:13 Changeset [28857] by oliver@apple.com

Make appendToVarDeclarationList static

RS=Weinig

12/18/07:

23:53 Changeset [28856] by bdakin@apple.com

WebCore:

Reviewed by Oliver.

Fix for <rdar://problem/5616982> SVGs with width and height 100%
fail to render when used as <img> or CSS image (16167)

This final part of the work fixes the <img> tag.

This is the real fix.

  • rendering/RenderImage.cpp: (WebCore::RenderImage::calcReplacedWidth): Set the container size on the image. Setting the container size only actually sticks if the values are non-zero, so if the container size really was set, use the imageSize that is calculated using the container size. If it did not stick but the image does have relative width (meaning that the container size is 0), set the width to 0 by hand. We want to avoid setting the width before we have a container size or we will end up incorrectly using the default size of 300x150. (WebCore::RenderImage::calcReplacedHeight): Same as above, but for height.

A few more pieces of information have to be exposed through cached
image to make this happen.

  • loader/CachedImage.cpp: (WebCore::CachedImage::usesImageContainerSize): As mentioned above, when setContainerSize() is called, the container size is only actually set if the values are non-zero. This call tells you if it was set. (WebCore::CachedImage::imageHasRelativeWidth): (WebCore::CachedImage::imageHasRelativeHeight):
  • loader/CachedImage.h:
  • platform/graphics/Image.h: (WebCore::Image::usesContainerSize):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::usesContainerSize):
  • svg/graphics/SVGImage.h:

LayoutTests:

Reviewed by Oliver.

Test for <rdar://problem/5616982> SVGs with width and height 100%
fail to render when used as <img> or CSS image (16167)

  • fast/images/resources/green-relative-size-rect.svg: Added.
  • fast/images/svg-as-relative-image.html: Added.
  • platform/mac/fast/images/svg-as-relative-image-expected.checksum: Added.
  • platform/mac/fast/images/svg-as-relative-image-expected.png: Added.
  • platform/mac/fast/images/svg-as-relative-image-expected.txt: Added.
23:42 Changeset [28855] by oliver@apple.com

Remove dead code due to removal of post-parse declaration discovery.

RS=Geoff.

Due to the removal of the declaration discovery pass after parsing we
no longer need any of the logic used for that discovery.

23:42 Changeset [28854] by oliver@apple.com

Replace post-parse pass to find declarations with logic in the parser itself

Reviewed by Geoff.

Instead of finding declarations in a pass following the initial parsing of
a program, we incorporate the logic directly into the parser. This lays
the groundwork for further optimisations (such as improving performance in
declaration expressions -- var x = y; -- to match that of standard assignment)
in addition to providing a 0.4% performance improvement in SunSpider.

21:04 Changeset [28853] by mrowe@apple.com

Versioning.

21:02 Changeset [28852] by mrowe@apple.com

New tag.

21:02 Changeset [28851] by mrowe@apple.com

New tag.

20:58 Changeset [28850] by mrowe@apple.com

Fix typo in hosted SunSpider page.

20:54 Changeset [28849] by sfalken@apple.com

Correct link to Visual Studio Express 2005.
Old link points to 2008.


Reviewed by Mark.

  • building/tools.html:
19:11 Changeset [28848] by darin@apple.com
  • Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
18:58 Changeset [28847] by ddkilzer@apple.com

2007-12-18 Xan Lopez <xan@gnome.org>

Reviewed by Geoff.

Fix http://bugs.webkit.org/show_bug.cgi?id=14521
Bug 14521: JavaScriptCore fails to build on Linux/PPC gcc 4.1.2


  • wtf/TCSpinLock.h: (TCMalloc_SpinLock::Unlock):

Use less strict memory operand constraint on inline asm generation.
PLATFORM(DARWIN) left unpatched due to Apple's GCC bug.

Patch by David Kilzer <ddkilzer@webkit.org>

18:12 Changeset [28846] by mrowe@apple.com

Remove outdated and non-functioning project files for the Apollo port. Rubber-stamped by Maciej Stachowiak and Chris Brichford.

17:41 Changeset [28845] by mitz@apple.com

Reviewed by John Sullivan.

  • remove passing test and reclassify one failing test
  • platform/win/Skipped: Removed fast/text/international/002.html.
17:12 Changeset [28844] by weinig@apple.com

Reviewed by Geoffrey.

  • http/tests/security/cross-frame-access-history-expected.txt:
  • http/tests/security/cross-frame-access-history.html:
16:58 Changeset [28843] by sfalken@apple.com

Add script to run Drosera as part of the nightly.


Reviewed by Kevin M.

  • Scripts/run-drosera.cmd: Added.
16:35 Changeset [28842] by darin@apple.com
  • Scripts/do-webcore-rename: Remove a stray K.
16:34 Changeset [28841] by darin@apple.com
  • fix Windows build
  • pcre/pcre_exec.cpp: (jsRegExpExecute): Change back from false/true to 0/1 -- I probably should not have deleted MATCH_MATCH and MATCH_NOMATCH, but I'm going to leave them out.
15:40 Changeset [28840] by darin@apple.com
  • Scripts/do-webcore-rename: Plan more renaming.
15:38 Changeset [28839] by sfalken@apple.com

<rdar://problem/5649911> REGRESSION (304-306A9): Typing 'p' in popup menu for type-to-select brings up Safari Help


Need to translate the char back into a key code for posting our WM_KEYDOWN.


Reviewed by Ada.

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupWndProc):
14:56 Changeset [28838] by sfalken@apple.com

<rdar://problem/5651534> REGRESSION(r28764-r28765): GDI leak drawing text when no appropriate font is available


Our captured metafile from Uniscribe may contain multiple calls to CreateFontIndirect.
Only create a font with the last one.


Reviewed by Mitz, Darin.

  • platform/graphics/win/FontCacheWin.cpp: (WebCore::metaFileEnumProc): (WebCore::FontCache::getFontDataForCharacters):
14:32 Changeset [28837] by darin@apple.com
  • fix failing regression test
  • fast/regex/resources/TEMPLATE.html: Updated this template -- I accidentally landed the one that was copied without updating the paths.
  • fast/regex/slow.html: Regenerated.
13:50 Changeset [28836] by alice.liu@apple.com

Reviewed by Darin.

Fixed <rdar://problem/5646454> REGRESSION: dom/xhtml/level2/html/HTMLDocument12 fails on Leopard

  • fast/cookies/local-file-can-set-cookies.html: cookies are matched by domain and path, and since layout tests are file URLs, they all match on domain. setting a cookie without specifying the path will make CFNetwork pick up the path from the URL automatically. Since fast/cookies/local-file-can-set-cookies.html set a specific path of /, that cookie will be set for EVERY local file loaded in Safari. removing that component from the cookie string will fix the problem.
13:37 Changeset [28835] by alp@webkit.org

2007-12-17 Brent Fulgham <bfulgham@gmail.com>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=16464
Modify WebCore to use win32 thread primitives

Updates to support native windows threading primitives
rather than pthreads emulation library.

  • WebCore.vcproj/WebCore.vcproj:
  • config.h:
  • platform/Threading.h:
  • platform/win/MutexWin.cpp: Added. (WebCore::Mutex::Mutex): (WebCore::Mutex::~Mutex): (WebCore::Mutex::lock): (WebCore::Mutex::tryLock): (WebCore::Mutex::unlock):
  • platform/win/ThreadConditionWin.cpp: Added. (WebCore::ThreadCondition::ThreadCondition): (WebCore::ThreadCondition::~ThreadCondition): (WebCore::ThreadCondition::wait): (WebCore::ThreadCondition::signal): (WebCore::ThreadCondition::broadcast):
  • platform/win/ThreadingWin.cpp: (WebCore::threadMapMutex): (WebCore::threadMap): (WebCore::storeThreadHandleByIdentifier): (WebCore::identifierByThreadHandle): (WebCore::threadHandleForIdentifier): (WebCore::clearThreadHandleForIdentifier): (WebCore::createThread): (WebCore::waitForThreadCompletion): (WebCore::detachThread): (WebCore::currentThread):
13:36 Changeset [28834] by alp@webkit.org

2007-12-18 Rodney Dawes <dobey@wayofthemonkey.com>

Reviewed by Darin Adler.

Handle EINTR when set by select() and try the select() again
http://bugs.webkit.org/show_bug.cgi?id=16071

  • platform/network/curl/ResourceHandleManager.cpp: (ResourceHandleManager::downloadTimerCallback):
11:30 Changeset [28833] by darin@apple.com

JavaScriptCore:

Reviewed by Geoff.

Test: fast/regex/slow.html

Slows down SunSpider a bit (about 1.01x); filed a bug to follow up on that:
http://bugs.webkit.org/show_bug.cgi?id=16503

  • pcre/pcre.h: Changed name of error code to not specifically mention "recursion".
  • pcre/pcre_exec.cpp: (match): Replaced the depth limit, MATCH_RECURSION_LIMIT, with a total match looping limit, matchLimit. Also eliminated the constants for MATCH_MATCH and MATCH_NOMATCH, since they are just true and false (1 and 0). (jsRegExpExecute): More of the MATCH_MATCH change.

LayoutTests:

Reviewed by Geoff.

  • fast/regex/resources: Added.
  • fast/regex/resources/TEMPLATE.html: Copied from fast/js/resources/TEMPLATE.html.
  • fast/regex/resources/slow.js: Added.
  • fast/regex/slow-expected.txt: Added.
  • fast/regex/slow.html: Added.
10:58 Changeset [28832] by mitz@apple.com

Reviewed by Dave Hyatt.

  • avoid the simplified Chinese font linking code for characters that are not in any Windows code page
  • platform/graphics/win/FontCacheWin.cpp: (WebCore::FontCache::getFontDataForCharacters):
10:35 Changeset [28831] by mitz@apple.com

Reviewed by John Sullivan.

  • remove passing test
  • platform/win/Skipped: Removed fast/text/international/wrap-CJK-001.html
10:19 Changeset [28830] by beidson@apple.com

Reviewed by Adele

<rdar://problem/5525770> REGRESSION: HTTP Auth protected favicon request results in a password sheet

Some http-auth protected sites have the main resource(s) unprotected, but many subresources are
protected by authentication. Occasionally one can view the main page of a site but the favicon
is behind the iron curtain - in these cases, we should *not* prompt for a username and password
solely for the favicon.

  • loader/ResourceLoader.h: Make didReceiveAuthenticationChallenge virtual
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didReceiveAuthenticationChallenge): Now that this method is virtual from ResourceLoader, SubresourceLoader can override. First call to the SubresourceLoaderClient. If they cancel the resource load, return early. Otherwise, let ResourceLoader work its magic (resulting in the auth sheet coming down)
  • loader/SubresourceLoader.h:
  • loader/SubresourceLoaderClient.h: (WebCore::SubresourceLoaderClient::didReceiveAuthenticationChallenge):
  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::didReceiveAuthenticationChallenge): Cancel the resource load, since we should never prompt the user for credentials just for a favicon.
  • loader/icon/IconLoader.h:
09:07 Changeset [28829] by sullivan@apple.com

Reviewed by Brady


  • fixed <rdar://problem/5652380> Initial prompt shows "" for databases with no user-visible name
  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::canEstablishDatabase): pass "name" instead of "displayName" if there's no displayName
01:27 Changeset [28828] by mjs@apple.com

Reviewed by Eric.


  • give an extra digit of precision for small differences.
  • resources/sunspider-compare-results.js:
Note: See TracTimeline for information about the timeline view.