Timeline



Dec 31, 2007:

7:04 PM Changeset in webkit [29058] by weinig@apple.com
  • 10 edits
    8 adds
    2 deletes in trunk

WebCore:

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=16637
Acid3 expects ExeceptionCode constants to be defined on DOMException objects

  • Make DOMException a real JS object.

Test: fast/dom/DOMException/prototype-object.html

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:

This is no longer needed as the autogenerated classes now includes the
constructor.

  • bindings/js/JSDOMExceptionConstructor.cpp: Removed.
  • bindings/js/JSDOMExceptionConstructor.h: Removed.

Create on demand and use the new class for DOMExceptions.

  • bindings/js/kjs_binding.cpp: (KJS::setDOMException):

Remove no longer needed custom constructor getter.

  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):

Don't expose DOMCoreException as the name of class by special casing
the user visible class name to be DOMException.

  • bindings/scripts/CodeGeneratorJS.pm:

The DOMException class/file needs to be named DOMCoreException because there is
name conflict with one of the Objective-C bindings classes. It should be renamed
to DOMException when the Objective-C bindings are moved into WebKit.

  • dom/DOMCoreException.cpp: Added. (WebCore::DOMCoreException::DOMCoreException): (WebCore::DOMCoreException::toString):
  • dom/DOMCoreException.h: Added. (WebCore::DOMCoreException::): (WebCore::DOMCoreException::code): (WebCore::DOMCoreException::name): (WebCore::DOMCoreException::message):
  • dom/DOMCoreException.idl: Added.
  • page/DOMWindow.idl:

LayoutTests:

Reviewed by Darin.

Test for http://bugs.webkit.org/show_bug.cgi?id=16637
Acid3 expects ExeceptionCode constants to be defined on DOMException objects

  • fast/dom/DOMException: Added.
  • fast/dom/DOMException/prototype-object-expected.txt: Added.
  • fast/dom/DOMException/prototype-object.html: Added.
  • fast/dom/DOMException/resources: Added.
  • fast/dom/DOMException/resources/prototype-object.js: Added.
  • fast/dom/Window/window-properties-expected.txt:
  • http/tests/xmlhttprequest/connection-error-sync-expected.txt:
6:01 PM Changeset in webkit [29057] by weinig@apple.com
  • 5 edits in trunk/WebCore

Re-enable querySelector and querySelectorAll and touch the necessary files to not
kill the windows build.

  • WebCore.vcproj/build-generated-files.sh:
  • bindings/scripts/CodeGeneratorCOM.pm:
  • dom/Document.idl:
  • dom/Element.idl:
5:45 PM Changeset in webkit [29056] by Darin Adler
  • 2 edits in trunk/LayoutTests
  • fast/dom/HTMLFormElement/elements-not-in-document-expected.txt: Updated results to expect success. I accdidentally landed an expected failure instead!
5:37 PM Changeset in webkit [29055] by Darin Adler
  • 3 edits in trunk/WebCore
  • fix Windows build
  • dom/Document.idl: Temporarily disable querySelector and querySelectorAll, since they are showing up as pure virtual functions. Sam can fix this later.
  • dom/Element.idl: Ditto.
5:32 PM Changeset in webkit [29054] by mitz@apple.com
  • 21 edits
    5 adds in trunk

WebCore:

Reviewed by Darin Adler.

Test: fast/dynamic/create-renderer-for-whitespace-only-text.html

  • dom/Node.cpp: (WebCore::Node::attach): Added code to check if this node's renderer has become the "previous renderer" of any sibling text node, and if so, ensure that that node gets a renderer if it now needs one. (WebCore::Node::createRendererIfNeeded): Removed the assertion that the node is not attached.

LayoutTests:

Reviewed by Darin Adler.

  • fast/dynamic/create-renderer-for-whitespace-only-text.html: Added.
  • fast/dynamic/style-access-late-stylesheet-load-expected.txt:
  • platform/mac-leopard/fast/dynamic: Added.
  • platform/mac-leopard/fast/dynamic/create-renderer-for-whitespace-only-text-expected.checksum: Added.
  • platform/mac-leopard/fast/dynamic/create-renderer-for-whitespace-only-text-expected.png: Added.
  • platform/mac/editing/deleting/delete-block-merge-contents-001-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-019-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-020-expected.txt:
  • platform/mac/editing/inserting/editable-html-element-expected.txt:
  • platform/mac/editing/inserting/editing-empty-divs-expected.txt:
  • platform/mac/editing/pasteboard/paste-TIFF-expected.txt:
  • platform/mac/editing/selection/4983858-expected.txt:
  • platform/mac/editing/selection/5136696-expected.txt:
  • platform/mac/editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • platform/mac/editing/style/remove-underline-across-paragraph-expected.txt:
  • platform/mac/editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
  • platform/mac/editing/style/remove-underline-after-paragraph-expected.txt:
  • platform/mac/editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
  • platform/mac/editing/style/remove-underline-from-stylesheet-expected.txt:
  • platform/mac/fast/dynamic/create-renderer-for-whitespace-only-text-expected.txt: Added.
  • platform/mac/fast/dynamic/move-node-with-selection-expected.txt:
  • platform/mac/fast/forms/input-align-expected.txt:
  • platform/mac/fast/inline/positionedLifetime-expected.txt:
5:17 PM Changeset in webkit [29053] by Darin Adler
  • 7 edits
    6 adds in trunk

WebCore:

Reviewed by Mitz.

Test: fast/dom/HTMLFormElement/elements-not-in-document.html

This was a bug specific to forms that are not in the document tree.
The fix was to change the code to increment the document version number to match
up with other document change tracking. Maybe at some point we can clean these up
so we don't have so many competing change notification systems.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::replaceChild): Removed bogus comment. (WebCore::ContainerNode::addChild): Added an explicit incDOMTreeVersion call here, since this code path bypasses the subtree-modified event code.
  • dom/Element.cpp: (WebCore::Element::setAttribute): Remove the inDocument() check -- not all HTML collections are for things in the document. (WebCore::Element::setAttributeMap): Ditto.
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchSubtreeModifiedEvent): Added a call to incDOMTreeVersion here; covers most cases of tree structure changes.
  • dom/Node.cpp: (WebCore::Node::attach): Remove call to incDOMTreeVersion -- creating a renderer has nothing to do with changes to the DOM tree! (WebCore::Node::detach): Ditto.
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::registerFormElement): Remove call to incDOMTreeVersion. This is handled at a lower level and doesn't need to be here. (WebCore::HTMLFormElement::removeFormElement): Ditto.

LayoutTests:

Reviewed by Mitz.

  • fast/dom/HTMLFormElement: Added.
  • fast/dom/HTMLFormElement/elements-not-in-document-expected.txt: Added.
  • fast/dom/HTMLFormElement/elements-not-in-document.html: Added.
  • fast/dom/HTMLFormElement/resources: Added.
  • fast/dom/HTMLFormElement/resources/TEMPLATE.html: Added.
  • fast/dom/HTMLFormElement/resources/elements-not-in-document.js: Added.
4:20 PM Changeset in webkit [29052] by Darin Adler
  • 2 edits in trunk/WebKitTools

Suggested by Antti.

  • Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until we get it installed on the build bots.
4:18 PM Changeset in webkit [29051] by Darin Adler
  • 16 edits
    8 adds in trunk

WebCore:

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=14994
Support for MessageEvent and cross-domain messaging

Test: http/tests/messaging/cross-domain-message-send.html

  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot): Allow cross-domain access to the postMessage function. (WebCore::JSDOMWindow::postMessage):
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • dom/Event.cpp: (WebCore::Event::isMessageEvent):
  • dom/Event.h:
  • dom/EventNames.h: New event name
  • dom/MessageEvent.cpp: Added.
  • dom/MessageEvent.h: Added.
  • dom/MessageEvent.idl: Added.
  • page/DOMWindow.cpp: (WebCore::DOMWindow::postMessage): Added.
  • page/DOMWindow.h:
  • page/DOMWindow.idl:

LayoutTests:

Reviewed by Darin.

Test for http://bugs.webkit.org/show_bug.cgi?id=14994
Support for MessageEvent and cross-domain messaging

  • fast/dom/Window/window-properties-expected.txt:
  • http/tests/messaging: Added.
  • http/tests/messaging/cross-domain-message-send-expected.txt: Added.
  • http/tests/messaging/cross-domain-message-send.html: Added.
  • http/tests/messaging/resources: Added.
  • http/tests/messaging/resources/cross-domain-message-receive.html: Added.
3:56 PM Changeset in webkit [29050] by Darin Adler
  • 3 edits in trunk/WebCore

Suggested by Antti.

  • turn ENABLE_VIDEO back off for Windows until we can install QuickTime on the build bots
  • WebCore.vcproj/WebCore.vcproj: Removed ENABLE_VIDEO.
  • WebCore.vcproj/build-generated-files.sh: Ditto.
4:56 AM ApplicationsGtk edited by alp@atoker.com
Add a feed reader app (diff)

Dec 30, 2007:

11:48 PM Changeset in webkit [29049] by alp@webkit.org
  • 2 edits in trunk/WebCore

2007-12-30 Alp Toker <alp@atoker.com>

Reviewed by Dan Bernstein.

Silence warning.

  • dom/NodeList.h:
11:06 PM Changeset in webkit [29048] by pewtermoose@webkit.org
  • 3 edits in trunk/WebKit/win

Reviewed by Darin.

Bug 16578: Windows Web Inspector window needs minimum size
http://bugs.webkit.org/show_bug.cgi?id=16578

  • WebInspectorClient.cpp: (WebInspectorClient::onGetMinMaxInfo): (WebInspectorWndProc):
  • WebInspectorClient.h:
11:03 PM Changeset in webkit [29047] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Sam.

More small cleanup to array_object.cpp

  • kjs/array_object.cpp: (KJS::ArrayProtoFuncToString::callAsFunction): (KJS::ArrayProtoFuncToLocaleString::callAsFunction): (KJS::ArrayProtoFuncJoin::callAsFunction): (KJS::ArrayProtoFuncConcat::callAsFunction): (KJS::ArrayProtoFuncReverse::callAsFunction): (KJS::ArrayProtoFuncShift::callAsFunction): (KJS::ArrayProtoFuncSlice::callAsFunction): (KJS::ArrayProtoFuncSort::callAsFunction): (KJS::ArrayProtoFuncSplice::callAsFunction): (KJS::ArrayProtoFuncUnShift::callAsFunction): (KJS::ArrayProtoFuncFilter::callAsFunction): (KJS::ArrayProtoFuncMap::callAsFunction): (KJS::ArrayProtoFuncEvery::callAsFunction):
11:03 PM Changeset in webkit [29046] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Sam.

Apply wkstyle to array_object.cpp

  • kjs/array_object.cpp: (KJS::ArrayPrototype::ArrayPrototype): (KJS::ArrayPrototype::getOwnPropertySlot): (KJS::ArrayProtoFuncConcat::callAsFunction): (KJS::ArrayProtoFuncPop::callAsFunction): (KJS::ArrayProtoFuncReverse::callAsFunction): (KJS::ArrayProtoFuncShift::callAsFunction): (KJS::ArrayProtoFuncSlice::callAsFunction): (KJS::ArrayProtoFuncSort::callAsFunction): (KJS::ArrayProtoFuncSplice::callAsFunction): (KJS::ArrayProtoFuncUnShift::callAsFunction): (KJS::ArrayProtoFuncFilter::callAsFunction): (KJS::ArrayProtoFuncMap::callAsFunction): (KJS::ArrayProtoFuncEvery::callAsFunction): (KJS::ArrayProtoFuncLastIndexOf::callAsFunction): (KJS::ArrayObjectImp::ArrayObjectImp): (KJS::ArrayObjectImp::implementsConstruct): (KJS::ArrayObjectImp::construct): (KJS::ArrayObjectImp::callAsFunction):
11:02 PM Changeset in webkit [29045] by eric@webkit.org
  • 4 edits in trunk/JavaScriptCore

Reviewed by Sam.

Remove maxInt/minInt, replacing with std:max/min<int>()

  • kjs/array_object.cpp: (KJS::ArrayProtoFuncSplice::callAsFunction):
  • kjs/operations.cpp:
  • kjs/operations.h:
11:02 PM Changeset in webkit [29044] by weinig@apple.com
  • 4 edits
    3 adds in trunk

WebCore:

Reviewed by Oliver Hunt.

Fix for http://bugs.webkit.org/show_bug.cgi?id=16387
Variable names can be enumerated across domains
<rdar://problem/5640454>

Test: http/tests/security/cross-frame-access-enumeration.html

  • bindings/js/kjs_window.cpp: (KJS::Window::getPropertyNames): Override method to test same-origin policy.
  • bindings/js/kjs_window.h:

LayoutTests:

Reviewed by Oliver Hunt.

Test for http://bugs.webkit.org/show_bug.cgi?id=16387

  • http/tests/security/cross-frame-access-enumeration-expected.txt: Added.
  • http/tests/security/cross-frame-access-enumeration.html: Added.
  • http/tests/security/resources/cross-frame-iframe-for-enumeration-test.html: Added.
11:01 PM Changeset in webkit [29043] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

Reviewed by Sam.

  • Scripts/do-webcore-rename: Add a few more planned renames s/(\w+)Imp/\1/
10:37 PM Changeset in webkit [29042] by Darin Adler
  • 1 edit
    1 add in trunk/LayoutTests
  • added missing results file
  • fast/events/event-instanceof-expected.txt: Added.
2:24 PM Changeset in webkit [29041] by weinig@apple.com
  • 13 edits
    2 adds in trunk

WebCore:

Reviewed by Oliver Hunt.

Patch for http://bugs.webkit.org/show_bug.cgi?id=10686
event instanceof MouseEvent throws exception

Add JS constructors for all the Event types.

Test: fast/events/event-instanceof.html

  • WebCore.xcodeproj/project.pbxproj:
  • dom/KeyboardEvent.idl:
  • dom/MouseEvent.idl:
  • dom/MutationEvent.idl:
  • dom/OverflowEvent.idl:
  • dom/ProgressEvent.idl:
  • dom/TextEvent.idl:
  • dom/UIEvent.idl:
  • dom/WheelEvent.idl:
  • page/DOMWindow.idl:

LayoutTests:

Reviewed by Oliver Hunt.

Test for http://bugs.webkit.org/show_bug.cgi?id=10686
event instanceof MouseEvent throws exception

  • fast/dom/Window/window-properties-expected.txt:
  • fast/events/event-instanceof.html: Added.
  • fast/events/resources/event-instanceof.js: Added.
9:44 AM Changeset in webkit [29040] by alp@webkit.org
  • 2 edits in trunk

2007-12-30 Alp Toker <alp@atoker.com>

Build fix for older autoconf versions.

  • configure.ac:
9:05 AM Changeset in webkit [29039] by ddkilzer@apple.com
  • 6 edits
    8 moves
    2 adds in trunk

WebCore:

Reviewed by Darin.

The problem occurs when a replaced element (image, canvas, etc.) with
a percent-height attribute is contained by a table cell with an auto-
or percent-height attribute. If there are no other conditions to cause
the table cell's height to expand, an available height of zero will
always be returned. In these cases, the intrinsic height of the
replaced element should be used if it is greater than the available
height of the table cell.

Tests: fast/replaced/table-percent-height.html

tables/mozilla/bugs/bug137388-1.html
tables/mozilla/bugs/bug137388-2.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcReplacedHeightUsing):

LayoutTests:

Reviewed by Darin.

This test was added specifically for this bug. It tests the height of
replaced elements (canvas, embed, img, object, button, input, isindex,
select, textarea ) within table cells.

  • fast/replaced/table-percent-height-expected.txt: Added.
  • fast/replaced/table-percent-height.html: Added.

These test results were updated because they are more correct.

  • platform/mac/fast/replaced/width100percent-image-expected.checksum: Updated.
  • platform/mac/fast/replaced/width100percent-image-expected.png: Updated.
  • platform/mac/fast/replaced/width100percent-image-expected.txt: Updated.

Moved tests and results for these two tests from tables/mozilla_expected_failures/bugs
to tables/mozilla/bugs since these results have been fixed.

  • platform/mac/tables/mozilla/bugs/bug137388-1-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug137388-1-expected.checksum.
  • platform/mac/tables/mozilla/bugs/bug137388-1-expected.png: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug137388-1-expected.png.
  • platform/mac/tables/mozilla/bugs/bug137388-1-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug137388-1-expected.txt.
  • platform/mac/tables/mozilla/bugs/bug137388-2-expected.checksum: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug137388-2-expected.checksum.
  • platform/mac/tables/mozilla/bugs/bug137388-2-expected.png: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug137388-2-expected.png.
  • platform/mac/tables/mozilla/bugs/bug137388-2-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug137388-2-expected.txt.
  • platform/mac/tables/mozilla_expected_failures/bugs/bug137388-1-expected.checksum: Removed.
  • platform/mac/tables/mozilla_expected_failures/bugs/bug137388-1-expected.png: Removed.
  • platform/mac/tables/mozilla_expected_failures/bugs/bug137388-1-expected.txt: Removed.
  • platform/mac/tables/mozilla_expected_failures/bugs/bug137388-2-expected.checksum: Removed.
  • platform/mac/tables/mozilla_expected_failures/bugs/bug137388-2-expected.png: Removed.
  • platform/mac/tables/mozilla_expected_failures/bugs/bug137388-2-expected.txt: Removed.
  • tables/mozilla/bugs/bug137388-1.html: Copied from LayoutTests/tables/mozilla_expected_failures/bugs/bug137388-1.html.
  • tables/mozilla/bugs/bug137388-2.html: Copied from LayoutTests/tables/mozilla_expected_failures/bugs/bug137388-2.html.
  • tables/mozilla_expected_failures/bugs/bug137388-1.html: Removed.
  • tables/mozilla_expected_failures/bugs/bug137388-2.html: Removed.
8:21 AM Changeset in webkit [29038] by mrowe@apple.com
  • 17 edits in trunk/WebKitSite

2007-12-30 Mark Rowe <mrowe@apple.com>

Unreviewed. Update WordPress to 2.3.2, which includes security fixes.

  • blog/wp-admin/admin.php:
  • blog/wp-admin/includes/file.php:
  • blog/wp-admin/install.php:
  • blog/wp-admin/setup-config.php:
  • blog/wp-app.php:
  • blog/wp-includes/formatting.php:
  • blog/wp-includes/functions.php:
  • blog/wp-includes/pluggable.php:
  • blog/wp-includes/post.php:
  • blog/wp-includes/query.php:
  • blog/wp-includes/taxonomy.php:
  • blog/wp-includes/version.php:
  • blog/wp-includes/wp-db.php:
  • blog/wp-mail.php:
  • blog/wp-settings.php:
  • blog/xmlrpc.php:
3:52 AM Changeset in webkit [29037] by alp@webkit.org
  • 2 edits in trunk/WebCore

2007-12-30 Luca Bruno <lethalman88@gmail.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16099
Crash in CURL for empty POST

We have to set POST even when the data is empty, otherwise cURL will
hang while waiting for a response.

  • platform/network/curl/ResourceHandleManager.cpp (ResourceHandleManager::setupPOST): allow empty POST
12:38 AM Changeset in webkit [29036] by eric@webkit.org
  • 12 edits
    1 add in trunk

Reviewed by Sam.

Update Number.toString to properly throw exceptions.
Cleanup code in Number.toString implementation.

  • kjs/number_object.cpp: (KJS::numberToString):
  • kjs/object.cpp: (KJS::Error::create): Remove bogus debug lines.

Dec 29, 2007:

10:47 PM Changeset in webkit [29035] by alp@webkit.org
  • 4 edits in trunk

2007-12-29 Jan Michael Alonzo <jmalonzo@unpluggable.com>

Reviewed by Alp Toker.

Enable Database, XPath and XSLT features by default

Move all SVG related stuff inside SVG block. Don't include
SVGNames, SVGElementFactory, and XLinkNames when SVG is not
enabled

10:13 PM Changeset in webkit [29034] by ap@webkit.org
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=14428
FCKEditor: Images disappear on drag/drop and copy/paste

Test: editing/pasteboard/drag-image-in-about-blank-frame.html

  • editing/markup.cpp: (WebCore::createFragmentFromMarkup): Don't use "about:blank" as a base URL, just like we don't use an empty one.
7:33 PM Changeset in webkit [29033] by alp@webkit.org
  • 15 edits in trunk

2007-12-29 Jan Michael Alonzo <jmalonzo@unpluggable.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16669
autotools update and fixes

4:33 PM Changeset in webkit [29032] by Darin Adler
  • 2 edits in trunk/WebKitTools

Reviewed by Oliver.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginInvoke): Added a missing free.
8:06 AM Changeset in webkit [29031] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

Reviewed by Alexey.

Respect horiz-origin-x / horiz-origin-y / vert-origin-x / vert-origin-y properties when drawing SVG Fonts.
(Fixes fonts-elem-05-t.svg in a --svg-fonts build)

6:00 AM Changeset in webkit [29030] by alp@webkit.org
  • 4 edits in trunk

2007-12-29 Alp Toker <alp@atoker.com>

Fix typo.

  • hosted/sunspider.html:
5:50 AM Changeset in webkit [29029] by Nikolas Zimmermann
  • 7 edits in trunk/WebCore

Reviewed by Oliver.

Further SVG Font work. Parse all <glyph> attributes, using SVGGlyphElement::buildGlyphIdentifier.
SVGFontElement::collectGlyphs() now uses this method. Per character advance values work well now.

5:03 AM Changeset in webkit [29028] by alp@webkit.org
  • 4 edits in trunk

2007-12-29 Alp Toker <alp@atoker.com>

Reviewed by Maciej.

Provide the current URL in the SunSpider results page. Useful for
copying benchmark results out of browsers without a location bar or
where the location bar can't handle long URLs.

  • hosted/sunspider-results.html:
4:50 AM Changeset in webkit [29027] by Nikolas Zimmermann
  • 4 edits in trunk/WebCore

Reviewed by Oliver.

Refactor SVGAnimationElement::parseValues into a generic function parseDelimitedString.
SVGAnimationElement needs to parse semicolon-seperated strings, SVGGlyphElement comma-seperated.

3:59 AM Changeset in webkit [29026] by Nikolas Zimmermann
  • 7 edits in trunk/WebCore

Reviewed by Maciej.

Add new helper structure SVGFontData - FontData holds this object as OwnPtr.
Store several attribute values there (horiz-adv-x, horiz-origin-x etc..)

To optimize for the common case ('FontData' used for HTML rendering) it feels
better to hold one OwnPtr in FontData, than several floats.

Parse all <font> attributes in SVGFontFaceElement::createFontData.

1:31 AM ApplicationsGtk edited by alp@atoker.com
Add more applications (diff)

Dec 28, 2007:

11:42 PM Changeset in webkit [29025] by Darin Adler
  • 3 edits in trunk/WebCore
  • try to fix Windows and WX builds (broken by SVG Fonts check-in)
  • platform/graphics/win/FontWin.cpp: (WebCore::Font::drawGlyphs): Pass font size to FontData::ascent, now that it requires it. I can't see how it can be right to require the font size for ascent and descent, but not for other metrics functions in FontData.
  • platform/graphics/wx/FontWx.cpp: (WebCore::Font::drawGlyphs): Pass font size to FontData::ascent and FontData::descent.
11:35 PM Changeset in webkit [29024] by ap@webkit.org
  • 2 edits in trunk/LayoutTests

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=15734
fast/xpath/namespace-vs-predicate.xhtml fails unexpectedly in no-SVG build

  • fast/xpath/namespace-vs-predicate.xhtml: Use (hopefully) correct code to remove an SVG element.
11:27 PM Changeset in webkit [29023] by Darin Adler
  • 3 edits in trunk/LayoutTests
  • checked in these files that were supposed to be part of the previous check-in, but somehow weren't
  • fast/js/number-tofixed-expected.txt: Updated.
  • fast/js/number-toprecision-expected.txt: Ditto.
9:51 PM Changeset in webkit [29022] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

2007-12-28 Eric Seidel <eric@webkit.org>

Reviewed by Oliver.

ASSERT when debugging via Drosera due to missed var lookup optimization.
http://bugs.webkit.org/show_bug.cgi?id=16634

No test case possible.

  • kjs/nodes.cpp: (KJS::BreakpointCheckStatement::optimizeVariableAccess):
  • kjs/nodes.h:
8:19 PM Changeset in webkit [29021] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe.

Covered by existing pixel tests.

  • platform/graphics/mac/FontMac.mm: (WebCore::Font::drawComplexText): Corrected to maintain the style information in the adjusted text run when passing it to ATSUILayoutParameters. Prior to r28298 the style was passed separately.
8:01 PM Changeset in webkit [29020] by eric@webkit.org
  • 7 edits
    5 adds in trunk

Reviewed by Oliver.

Fix (-0).toFixed() and re-factor a little
Fix (-0).toExponential() and printing of trailing 0s in toExponential
Fix toPrecision(nan) handling

  • kjs/number_object.cpp: (KJS::numberToFixed): (KJS::fractionalPartToString): (KJS::numberToExponential): (KJS::numberToPrecision):
7:27 PM Changeset in webkit [29019] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

Build fix, not reviewed.
Add wtf/OwnPtr.h include, to fix --svg-fonts build.

7:17 PM Changeset in webkit [29018] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Sam.

More changes to make number code readable

  • kjs/number_object.cpp: (KJS::integer_part_noexp): (KJS::numberToFixed): (KJS::numberToExponential):
7:16 PM Changeset in webkit [29017] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Sam.

More small cleanups to toPrecision

  • kjs/number_object.cpp: (KJS::numberToPrecision):
7:16 PM Changeset in webkit [29016] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Sam.

More small attempts to make number code readable

  • kjs/number_object.cpp: (KJS::exponentialPartToString): (KJS::numberToExponential): (KJS::numberToPrecision):
7:15 PM Changeset in webkit [29015] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2007-12-28 Eric Seidel <eric@webkit.org>

Reviewed by Sam.

Break out callAsFunction implementations into static functions

  • kjs/number_object.cpp: (KJS::numberToString): (KJS::numberToFixed): (KJS::numberToExponential): (KJS::numberToPrecision): (KJS::NumberProtoFunc::callAsFunction):
7:14 PM Changeset in webkit [29014] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

Reviewed by Sam.

Apply wkstyle/astyle and fix placement of *

  • kjs/number_object.cpp: (KJS::): (KJS::NumberInstance::NumberInstance): (KJS::NumberPrototype::NumberPrototype): (KJS::NumberProtoFunc::NumberProtoFunc): (KJS::integer_part_noexp): (KJS::intPow10): (KJS::NumberProtoFunc::callAsFunction): (KJS::NumberObjectImp::NumberObjectImp): (KJS::NumberObjectImp::getOwnPropertySlot): (KJS::NumberObjectImp::getValueProperty): (KJS::NumberObjectImp::implementsConstruct): (KJS::NumberObjectImp::construct): (KJS::NumberObjectImp::callAsFunction):
  • kjs/object.cpp: (KJS::JSObject::put):
6:48 PM Changeset in webkit [29013] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2007-12-28 Christian Dywan <christian@twotoasts.de>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16642
[GTK] webkit_web_view_has_selection returns the opposite result

Invert the return value.

  • WebView/webkitwebview.cpp:
6:41 PM Changeset in webkit [29012] by Nikolas Zimmermann
  • 48 edits
    13 adds
    4 deletes in trunk

Reviewed by Eric.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=10649 (WebKit SVG needs SVG Fonts support)

Begin implementation of SVG Fonts module. Basic documents using SVG Fonts already work.
Only local, in-document fonts who declare their glyphs using the <glyph d="..."> path syntax
are supported. (<glyph> containing arbitary SVG content as child elements, not supported yet).

5:36 PM BuildingOnWindows edited by webkit@mattlilek.com
Add info on building in VS (diff)

Dec 27, 2007:

11:50 PM Changeset in webkit [29011] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Alexey Proskuryakov.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::~RenderLayer): Avoid calling EventHandler::resizeLayerDestroyed() if the document is being destroyed.
11:13 PM ApplicationsGtk created by alp@atoker.com
List WebKit/GTK+ applications (feel free to add more)
7:22 PM Changeset in webkit [29010] by mitz@apple.com
  • 5 edits
    2 adds in trunk

WebCore:

Reviewed by Oliver Hunt.

Test: fast/layers/resize-layer-deletion-crash.html

The event handler has only a weak reference to the layer that is
currently in resize mode, so it is the layer's responsibility to let
the event handler know if it has been destroyed while in that mode.

  • page/EventHandler.cpp: (WebCore::EventHandler::resizeLayerDestroyed): Added. Resets m_resizeLayer to 0.
  • page/EventHandler.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::~RenderLayer): Added a call to EventHandler::resizeLayerDestroyed() if the layer is in resize mode.

LayoutTests:

Reviewed by Oliver Hunt.

  • fast/layers/resize-layer-deletion-crash-expected.txt: Added.
  • fast/layers/resize-layer-deletion-crash.html: Added.
5:25 PM Changeset in webkit [29009] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Reviewed by Alice Liu.

  • platform/win/Skipped: Remove xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame.html since it is now passing.
4:57 PM Changeset in webkit [29008] by weinig@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Sam Weinig.

http://bugs.webkit.org/show_bug.cgi?id=16539
<rdar://problem/5659269>

The same-origin check was missing in the implementation of
setTimeout, setInterval, addEventListener, and removeEventListener.

Suppose <http://www.badguy.com/> contains an iframe to
<http://www.goodguy.com/>. Now www.badguy.com can steal
www.goodguy.com cookies by running this code:

setTimeout.call(frames[0], "alert(document.cookie)", 1000);

This patch changes the behavior so that setTimeout to does
nothing and returns an undefined value if the caller is not
permitted to script the window whose setTimeout method is being
called. The same applies to setInterval, addEventListener, and
removeEventListener.

Tests: http/tests/security/cross-frame-access-call.html

  • bindings/js/kjs_window.cpp: (KJS::WindowProtoFuncSetTimeout::callAsFunction) (KJS::WindowProtoFuncSetInterval::callAsFunction) (KJS::WindowProtoFuncAddEventListener::callAsFunction) (KJS::WindowProtoFuncRemoveEventListener::callAsFunction)

LayoutTests:

Reviewed by Sam Weinig.

Tests for http://bugs.webkit.org/show_bug.cgi?id=16539
<rdar://problem/5659269>

  • http/tests/security/cross-frame-access-call-expected.txt: Added.
  • http/tests/security/cross-frame-access-call.html: Added.
4:11 PM Changeset in webkit [29007] by mitz@apple.com
  • 3 edits
    8 adds in trunk

WebCore:

Reviewed by Dave Hyatt and Sam Weinig.

  • fix <rdar://problem/5605937> Inspector: Disclosure triangle not drawn in node's properties panel until click

Test: fast/layers/add-layer-with-nested-stacking.html
Test: fast/layers/remove-layer-with-nested-stacking.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::addChild): If the new child is overflow-only but has children of its own, dirty the stacking context's z-order lists since the grandchildren might need to be in them. (WebCore::RenderLayer::removeChild): Similarly for the old child.

LayoutTests:

Reviewed by Dave Hyatt and Sam Weinig.

  • pixel tests for <rdar://problem/5605937> Inspector: Disclosure triangle not drawn in node's properties panel until click
  • fast/layers/add-layer-with-nested-stacking.html: Added.
  • fast/layers/remove-layer-with-nested-stacking.html: Added.
  • platform/mac/fast/layers/add-layer-with-nested-stacking-expected.checksum: Added.
  • platform/mac/fast/layers/add-layer-with-nested-stacking-expected.png: Added.
  • platform/mac/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
  • platform/mac/fast/layers/remove-layer-with-nested-stacking-expected.checksum: Added.
  • platform/mac/fast/layers/remove-layer-with-nested-stacking-expected.png: Added.
  • platform/mac/fast/layers/remove-layer-with-nested-stacking-expected.txt: Added.
3:14 PM Changeset in webkit [29006] by alp@webkit.org
  • 6 edits in trunk

2007-12-27 Jan Michael Alonzo <jmalonzo@unpluggable.com>

Reviewed by Alp Toker.

http://bugs.webkit.org/show_bug.cgi?id=16353
[GTK] Check for deprecated API use (G_DISABLE_DEPRECATED etc.)

Added the flags mentioned in the bug only when doing 'debug'
builds. -DGST_DISABLE_DEPRECATED only added when video is enabled.

2:20 PM Changeset in webkit [29005] by eric@webkit.org
  • 3 edits
    3 adds in trunk

Reviewed by Sam.

ASSERT in JavaScriptCore while viewing WICD test case
http://bugs.webkit.org/show_bug.cgi?id=16626

  • kjs/nodes.cpp: (KJS::ForInNode::execute): move KJS_CHECK_EXCEPTION to proper place
1:58 PM Changeset in webkit [29004] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Reviewed by Alice Liu.

  • platform/mac-leopard/Skipped: Remove dom/html/level2/html/HTMLDocument12.html from the Skipped list because it is now passing.
12:55 PM Changeset in webkit [29003] by mitz@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix typo in ChangeLog

12:54 PM Changeset in webkit [29002] by mitz@apple.com
  • 3 edits
    3 adds in trunk

WebCore:

Reviewed by Eric Seidel.

Test: fast/dynamic/paused-event-dispatch.html

  • page/FrameView.cpp: (WebCore::FrameView::~FrameView): (WebCore::FrameView::layout): Changed to always pause event dispatch and always resume event dispatch, regardless of whether the post-layout task time is active. However, if it is active, assert that event dispatch is still paused.

LayoutTests:

Reviewed by Eric Seidel.

  • fast/dynamic/paused-event-dispatch-expected.txt: Added.
  • fast/dynamic/paused-event-dispatch.html: Added.
  • fast/dynamic/resources/paused-event-dispatch-iframe.html: Added.
8:54 AM Changeset in webkit [29001] by mrowe@apple.com
  • 2 edits in trunk/PlanetWebKit

Add another feed to Planet WebKit.

12:34 AM Changeset in webkit [29000] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Reviewed by Maciej.

  • platform/win/Skipped: Move cross-frame-access-protocol* tests to show that they are failing because of a lack of ssl on windows.
12:28 AM Changeset in webkit [28999] by weinig@apple.com
  • 48 edits in trunk/LayoutTests

Rubber-stamped by Maciej.

  • Change more tests to use the new layoutTestController.globalFlag style polling instead of the "flag frame hack".
  • http/tests/security/cross-frame-access-parent-explicit-domain-expected.txt:
  • http/tests/security/cross-frame-access-port-expected.txt:
  • http/tests/security/cross-frame-access-private-browsing-expected.txt:
  • http/tests/security/cross-frame-access-protocol-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url.html:
  • http/tests/security/host-compare-case-insensitive-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom.html:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value.html:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom.html:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute.html:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS.html:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode.html:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS.html:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value.html:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom.html:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute.html:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS.html:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode.html:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt:
  • http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS.html:
  • http/tests/security/javascriptURL/resources/foreign-domain-javascript-url-accessee-iframe.html:
  • http/tests/security/javascriptURL/resources/foreign-domain-javascript-url-accessee-opened-frame.html:
  • http/tests/security/javascriptURL/resources/foreign-domain-javascript-url-accessor-iframe.html:
  • http/tests/security/javascriptURL/resources/foreign-domain-javascript-url-accessor-opened-frame.html:
  • http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame-2-level.html:
  • http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-window-open.html:
  • http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-subframe-expected.txt:
  • http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-subframe.html:
  • http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-window-open-expected.txt:
  • http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-window-open.html:
  • http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-subframe-expected.txt:
  • http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-subframe.html:
  • http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-window-open.html:
  • http/tests/security/protocol-compare-case-insensitive-expected.txt:
  • http/tests/security/resources/cross-frame-iframe.html:
12:22 AM Changeset in webkit [28998] by ap@webkit.org
  • 3 edits
    10 adds in trunk

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=14500
need to be more generous about charset declaration with meta tag


http://bugs.webkit.org/show_bug.cgi?id=12526
<rdar://problem/4867183> Safari ignores encoding description "charset=Shift_JIS" in invalid html

<rdar://problem/4892428> Unlike other browsers, WebKit ignores <meta> charset definitions outside the head

<rdar://problem/5643774> REGRESSION: Text is garbled when clicking a link inside an Arabic website

Tests: fast/encoding/ahram-org-eg.html

fast/encoding/bandai-co-jp-releases.html
fast/encoding/floraexpress-ru.html
fast/encoding/hanarei-blog32-fc2-com.html
fast/encoding/yahoo-mail.html

  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset): Don't stop looking for <meta> until we've seen at least 512 bytes of input.
Note: See TracTimeline for information about the timeline view.