Timeline



May 11, 2008:

10:14 PM Changeset in webkit [33037] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

Previous commit made bdash sad. Restore happiness state by fixing missed style issue.

10:06 PM Changeset in webkit [33036] by kevino@webkit.org
  • 5 edits in trunk/WebKit/wx

Reviewed by Kevin Ollivier.

Fix scrolling issues by implementing transitionToCommittedNewPage() so the scroll positions are reset when a new page is loaded, and also maintained so that back and next restore the scroll positions as well. This also simplifies the logic for initializing and managing wxWebView.

​https://bugs.webkit.org/show_bug.cgi?id=18992

9:58 PM Changeset in webkit [33035] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

Since wx popup menus dismiss themselves when an item is selected we need to call hidePopup so webkit's internal state is correct.

​https://bugs.webkit.org/show_bug.cgi?id=19000

5:34 PM Changeset in webkit [33034] by weinig@apple.com
  • 4 edits
    1 add in trunk/WebCore

2008-05-11 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Move some generic parsing functions into a new ParserUtilities header so that
they can be used for non-SVG builds too.

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/text/ParserUtilities.h: Added. (WebCore::skipString):
  • svg/SVGParserUtilities.h: (WebCore::isWhitespace): (WebCore::skipOptionalSpaces): (WebCore::skipOptionalSpacesOrDelimiter):
1:26 PM Changeset in webkit [33033] by weinig@apple.com
  • 6 edits
    6 adds in trunk/WebCore

2008-05-11 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Add scaffolding for the implementation of Access Control for Cross-site Requests.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • xml/AccessControlList.cpp: Added. (WebCore::AccessControlList::AccessControlList): (WebCore::AccessControlList::~AccessControlList): (WebCore::AccessControlList::parseAccessControlHeader): (WebCore::AccessControlList::checkOrigin):
  • xml/AccessControlList.h: Added.
  • xml/AccessItem.cpp: Added. (WebCore::AccessItem::AccessItem): (WebCore::AccessItem::parseAccessItem): (WebCore::AccessItem::matches):
  • xml/AccessItem.h: Added.
  • xml/AccessItemRule.cpp: Added. (WebCore::AccessItemRule::AccessItemRule): (WebCore::AccessItemRule::parseAccessItemRule):
  • xml/AccessItemRule.h: Added.
9:36 AM Changeset in webkit [33032] by jchaffraix@webkit.org
  • 2 edits in trunk/WebCore

2008-05-11 Julien Chaffraix <​jchaffraix@webkit.org>

Debug build fix.

  • loader/appcache/ApplicationCache.cpp: Include stdio.h as we are using printf in ApplicationCache::dump().
4:15 AM Changeset in webkit [33031] by cwzwarich@webkit.org
  • 3 edits
    3 adds in branches/squirrelfish

2008-05-11 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Bug 18961: SQUIRRELFISH: Gmail doesn't load
<​https://bugs.webkit.org/show_bug.cgi?id=18961>

Fix codegen for logical nodes so that they don't use their destination
as a temporary.

  • kjs/nodes.cpp: (KJS::LogicalAndNode::emitCode): (KJS::LogicalOrNode::emitCode):
  • fast/js/codegen-temporaries-expected.txt: Added.
  • fast/js/codegen-temporaries.html: Added.
  • fast/js/resources/codegen-temporaries.js: Added.

May 10, 2008:

7:28 PM Changeset in webkit [33030] by mitz@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Jessica Kahn.

  • add a copy assignment operator to FontPlatformData on Mac to properly retain the m_font data member.
  • platform/graphics/mac/FontPlatformData.h:
  • platform/graphics/mac/FontPlatformDataMac.mm: (WebCore::FontPlatformData::FontPlatformData): (WebCore::~FontPlatformData): (WebCore::FontPlatformData::operator=): (WebCore::FontPlatformData::setFont):
3:01 PM Changeset in webkit [33029] by adele@apple.com
  • 2 edits in trunk/WebCore

2008-05-10 Adele Peterson <​adele@apple.com>

Reviewed by Tim Hatcher.

Fix crash for WebKit clients that don't set a group name for the WebView/Page.

  • page/PageGroup.cpp: (WebCore::PageGroup::PageGroup): Instead of adding the Page directly to the group, call the addPage method, since it does extra work initializing m_localStorage.
2:18 PM Changeset in webkit [33028] by mjs@apple.com
  • 1 edit
    1 add in branches/squirrelfish/WebCore

2008-05-10 Maciej Stachowiak <​mjs@apple.com>

Build fix.


  • add missing forwarding header
  • ForwardingHeaders/kjs/SourceProvider.h: Added.
1:36 PM Changeset in webkit [33027] by mjs@apple.com
  • 38 edits
    3 adds in branches/squirrelfish

JavaScriptCore:

2008-05-10 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver.


Three layout tests are fixed:

fast/js/toString-elision-trailing-comma.html
fast/js/toString-prefix-postfix-preserve-parens.html
fast/js/kde/lval-exceptions.html


Functions now save a shared subrange of the original source used
to make them (so in the common case this adds no storage above the
memory cache).


  • kjs/SourceProvider.h: Added. (KJS::SourceProvider): New abstract base class for classes that provide on-demand access to the source for a JavaScript program. This allows function objects to have access to their original source without copying. (KJS::UStringSourceProvider): SourceProvider subclass backed by a KJS::UString. (KJS::UStringSourceProvider::create): (KJS::UStringSourceProvider::getRange): (KJS::UStringSourceProvider::data): (KJS::UStringSourceProvider::length): (KJS::UStringSourceProvider::UStringSourceProvider):
  • kjs/SourceRange.h: Added. (KJS::SourceRange::SourceRange): Class that holds a SourceProvider and a character range into the source, to encapsulate on-demand access to the source of a function. (KJS::SourceRange::toString):
  • VM/Machine.cpp: (KJS::eval): Pass a UStringSourceProvider to the parser.
  • kjs/Parser.cpp: (KJS::Parser::parse): Take a SourceProvider and pass it on to the lexer.
  • kjs/Parser.h: (KJS::Parser::parse): Take a SourceProvider.
  • kjs/lexer.cpp: (KJS::Lexer::setCode): Take a SourceProvider; keep it around, and use it to get the raw buffer and length.
  • kjs/lexer.h: (KJS::Lexer::sourceRange): Convenience function to get a source range based on the lexer's source provieder, and char offsets right before and after the desired range.
  • kjs/function.cpp: (KJS::globalFuncEval): Pass a UStringSourceProvider to the parser.
  • kjs/function_object.cpp: (KJS::functionProtoFuncToString): Use toSourceString to get the source. (KJS::FunctionObjectImp::construct): Give the parser a UStringSourceProvider.
  • kjs/grammar.y: When parsing a function declaration, function expression, or getter or setter, tell the function body about its SourceRange.
  • kjs/interpreter.cpp: (KJS::Interpreter::checkSyntax): Pass a SourceProvider to the parser. (KJS::Interpreter::evaluate): Pass a SourceProvider to the parser.
  • kjs/interpreter.h:
  • kjs/nodes.h: (KJS::FunctionBodyNode::setSource): Establish a SourceRange for this function. (KJS::FunctionBodyNode::toSourceString): Get the source string out of the SourceRange. (KJS::FuncExprNode::): Take a SourceRange and set it on the body. (KJS::FuncDeclNode::): ditto
  • kjs/testkjs.cpp: (prettyPrintScript): Use a SourceProvider appropriately.
  • JavaScriptCore.exp: Export new symbols.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add new files.
  • JavaScriptCore.xcodeproj/project.pbxproj: Add new files.

JavaScriptGlue:

2008-05-10 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver.


  • JSRun.cpp: (JSRun::Evaluate): Use UString version of eveluate() instead of the now departed UChar*/length variant; use of the lower-level version was gratuitous in any case. (JSRun::CheckSyntax): Ditto for checkSyntax().

WebCore:

2008-05-10 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver.

  • bindings/js/StringSourceProvider.h: Added. SourceProvider subclass backed by a WebCore::String. (WebCore::StringSourceProvider::create): (WebCore::StringSourceProvider::getRange): (WebCore::StringSourceProvider::data): (WebCore::StringSourceProvider::length): (WebCore::StringSourceProvider::StringSourceProvider):
  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::evaluate): Pass a StringSourceProvider to evaluate() instead of UChar* / length.
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::text): Modified to return the original string as-is when the script element contains only a single text node, to avoid excess memory use.


  • WebCore.vcproj/WebCore.vcproj: Add new file to build.
  • WebCore.xcodeproj/project.pbxproj: ditto

LayoutTests:

2008-05-10 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver.

All of these tests expected function.toString to somewhat change
things from the raw original source. They are now prepared for the
fact that this does not happen.


  • fast/js/function-decompilation-operators.html:
  • fast/js/function-names-expected.txt:
  • fast/js/function-prototype-expected.txt:
  • fast/js/function-prototype.html:
  • fast/js/function-toString-object-literals-expected.txt:
  • fast/js/function-toString-parentheses-expected.txt:
  • fast/js/kde/lval-exceptions-expected.txt:
  • fast/js/modify-non-references-expected.txt:
  • fast/js/resources/function-names.js:
  • fast/js/resources/function-toString-object-literals.js:
  • fast/js/resources/function-toString-parentheses.js:
  • fast/js/resources/modify-non-references.js:
  • fast/js/resources/toString-prefix-postfix-preserve-parens.js:
  • fast/js/toString-prefix-postfix-preserve-parens-expected.txt:
6:09 AM Changeset in webkit [33026] by jchaffraix@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-05-10 Julien Chaffraix <​jchaffraix@webkit.org>

Qt & wx build fix.

  • JavaScriptCore.pri: Add profiler/Profile.cpp.
  • JavaScriptCoreSources.bkl: Ditto.
2:43 AM Changeset in webkit [33025] by rwlbuis@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

Gtk+ build fix

1:15 AM Changeset in webkit [33024] by oliver@apple.com
  • 6 edits in branches/squirrelfish/JavaScriptCore

Bring back RegisterFile tainting in order to correctly handle
natively implemented getters and setters that re-enter JavaScript

Reviewed by Maciej

May 9, 2008:

9:44 PM Changeset in webkit [33023] by weinig@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2008-05-09 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=18958
NULL pointer dereference in NamedAttrMap::setNamedItem

Test: fast/dom/NamedNodeMap-setNamedItem-crash.html

  • dom/NamedAttrMap.cpp: (WebCore::NamedAttrMap::setNamedItem): Null check the argument.

LayoutTests:

2008-05-09 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Test for ​https://bugs.webkit.org/show_bug.cgi?id=18958
NULL pointer dereference in NamedAttrMap::setNamedItem

  • fast/dom/NamedNodeMap-setNamedItem-crash-expected.txt: Added.
  • fast/dom/NamedNodeMap-setNamedItem-crash.html: Added.
8:44 PM Changeset in webkit [33022] by mrowe@apple.com
  • 8 edits
    1 delete in trunk/WebKit

Roll out r33018 as it broke the builds.

8:37 PM Changeset in webkit [33021] by mjs@apple.com
  • 4 edits in branches/squirrelfish/JavaScriptCore

2008-05-09 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver.


  • track character offsets of open and close braces, in preparation for saving function source


I verified that there is no performance regression from this change.

  • kjs/grammar.y:
  • kjs/lexer.cpp: (KJS::Lexer::lex): (KJS::Lexer::matchPunctuator):
  • kjs/lexer.h:
5:46 PM Changeset in webkit [33020] by andersca@apple.com
  • 2 edits in trunk

2008-05-09 Anders Carlsson <​andersca@apple.com>

Reviewed by Mark.

Add x86_64 rule.


  • Makefile:
5:44 PM Changeset in webkit [33019] by mrowe@apple.com
  • 3 edits in trunk/WebKitTools

Update TestNetscapePlugIn to build 64-bit using the Cocoa event model.

It currently does not attempt to print events which means that plugins/mouse-events.html
will fail when run 64-bit. All other tests that use this plugin pass.

Reviewed by Anders Carlsson.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:

(testGetIntIdentifier):

  • DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:

(NPP_New):
(NPP_HandleEvent):

5:40 PM Changeset in webkit [33018] by andersca@apple.com
  • 8 edits
    1 add in trunk/WebKit

WebKit:

2008-05-09 Anders Carlsson <​andersca@apple.com>

Reviewed by Oliver.

<rdar://problem/5774495> Make Unicode text input possible in Netscape-style plug-ins


Add nptextinput.h as a public header.


  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-05-09 Anders Carlsson <​andersca@apple.com>

Reviewed by Oliver.

<rdar://problem/5774495> Make Unicode text input possible in Netscape-style plug-ins


  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView start]): Get the plug-in text input vtable pointer.


(-[WebBaseNetscapePluginView stop]):
Set the plug-in text input vtable pointer to 0.


(-[WebBaseNetscapePluginView inputContext]):
Return 0 for Carbon plug-ins since we don't want Cocoa to handle text input for them.


(-[WebBaseNetscapePluginView hasMarkedText]):
(-[WebBaseNetscapePluginView insertText:]):
(-[WebBaseNetscapePluginView markedRange]):
(-[WebBaseNetscapePluginView selectedRange]):
(-[WebBaseNetscapePluginView setMarkedText:selectedRange:]):
(-[WebBaseNetscapePluginView unmarkText]):
(-[WebBaseNetscapePluginView validAttributesForMarkedText]):
(-[WebBaseNetscapePluginView attributedSubstringFromRange:]):
(-[WebBaseNetscapePluginView characterIndexForPoint:]):
(-[WebBaseNetscapePluginView doCommandBySelector:]):
(-[WebBaseNetscapePluginView firstRectForCharacterRange:]):
(-[WebBaseNetscapePluginView conversationIdentifier]):
Implement NSTextInput and call into the plug-in text input vtable.


(browserTextInputFuncs):
New method which returns the browser input vtable.


(-[WebBaseNetscapePluginView getVariable:value:]):
Support getting the browser input vtable pointer.


  • Plugins/WebNetscapePluginEventHandlerCocoa.h:
  • Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::keyDown): (WebNetscapePluginEventHandlerCocoa::sendKeyEvent): If the plug-in returns 0 when a NPCocoaEventKeyDown is passed to NPP_HandleEvent, it means that the event should be passed on to the input manager.


  • Plugins/npapi.mm: (NPN_MarkedTextAbandoned): (NPN_MarkedTextSelectionChanged): Add implementations of browser input method methods.


  • Plugins/nptextinput.h: Added. Add file with new text input API.
5:26 PM Changeset in webkit [33017] by beidson@apple.com
  • 9 edits in trunk

WebKit/win:

Reviewed by Adam Roben

Fix a hang-on-quit bug where in the DLL_PROCESS_DETACH DllMain callback, we assummed that
we could cleanly shutdown WebKit but we couldn't because any background threads have already
been uncleanly aborted at that point.


  • ForEachCoClass.cpp: (shutDownWebKit): Moved from WebKitDLL to here, to be exposed via WebKit.def
  • ForEachCoClass.h:


  • WebKit.vcproj/WebKit.def:
  • WebKit.vcproj/WebKit_debug.def:


  • WebKitDLL.cpp: (DllMain): Don't call shutDownWebKit here


WebKitTools:

Reviewed by Adam Roben

Explicitly call shutDownWebKit() before quitting.

  • Drosera/win/Drosera.cpp: (_tWinMain):
  • DumpRenderTree/win/DumpRenderTree.cpp: (main):
5:25 PM Changeset in webkit [33016] by ddkilzer@apple.com
  • 1 edit in trunk/WebCore/DerivedSources.make

Changed tabs into spaces for VPATH and DOM_CLASSES items.

4:51 PM Changeset in webkit [33015] by oliver@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

Debug build fix

No reviewer

4:47 PM Changeset in webkit [33014] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Fix the Tiger build of Drosera.

  • Drosera/config.h: Define BUILDING_ON_TIGER when building on Tiger.
4:10 PM Changeset in webkit [33013] by oliver@apple.com
  • 13 edits in branches/squirrelfish

Build fixes for SquirrelFish on windows.

Reviewed by Geoff

2:28 PM Changeset in webkit [33012] by beidson@apple.com
  • 2 edits in trunk/JavaScriptCore

Build Fix

2:08 PM Changeset in webkit [33011] by ggaren@apple.com
  • 2 edits in branches/squirrelfish/LayoutTests

2008-05-09 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Restored the expected results for viewsource-empty-attribute-value.html
to what they were prior to r31100. These results expect that the
top-level name in the frame path is "" instead of "1".


It's not clear how r31100 changed the top-level frame in the frame path
to be named "1". The change definitely wasn't related to any expected
behavior in r31100, which was about default margin-bottom for form
elements in quirks mode.


It's also not clear how squirrelfish changes things back.


Sam mentioned that the test result changes intermittently on trunk.


For now, I don't think we need to think deeply about this issue,
since the "" result seems more correct than the "1" result.

  • fast/frames/viewsource-empty-attribute-value-expected.txt:
2:06 PM Changeset in webkit [33010] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2008-05-09 Kevin McCullough <​kmccullough@apple.com>

Build fix.

  • page/Console.cpp: (WebCore::Console::profile):
1:52 PM Changeset in webkit [33009] by weinig@apple.com
  • 20 edits in trunk

WebCore:

2008-05-09 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Mark Rowe.

Remove the ENABLE_CROSS_DOCUMENT_MESSAGING #ifdefs.

  • Configurations/WebCore.xcconfig:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/build-generated-files.sh:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot): (WebCore::JSDOMWindow::postMessage):
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • bindings/objc/DOMEvents.mm: (+[DOMEvent _wrapEvent:WebCore::]):
  • dom/Document.cpp: (WebCore::Document::createEvent):
  • dom/Event.cpp: (WebCore::Event::isMessageEvent):
  • dom/Event.h:
  • dom/MessageEvent.cpp:
  • dom/MessageEvent.h:
  • dom/MessageEvent.idl:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::postMessageTimerFired):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:

WebKit/win:

2008-05-09 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Mark Rowe.

Remove the ENABLE_CROSS_DOCUMENT_MESSAGING #ifdefs.

  • WebKit.vcproj/WebKit.vcproj:

WebKitTools:

2008-05-09 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Mark Rowe.

Remove the ENABLE_CROSS_DOCUMENT_MESSAGING #ifdefs.

  • Scripts/build-webkit:
1:43 PM Changeset in webkit [33008] by Adam Roben
  • 2 edits in trunk/WebKit/win

Build fix

  • Interfaces/WebKit.idl: Touched.
1:18 PM Changeset in webkit [33007] by kmccullough@apple.com
  • 5 edits
    2 adds in trunk/JavaScriptCore

2008-05-09 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Tim.

-<rdar://problem/5770054> JavaScript profiler (10928)
-Add Profile class so that all profiles can be stored and retrieved by
the WebInspector when that time comes.

  • JavaScriptCore.exp: Export the new function signatures.
  • JavaScriptCore.xcodeproj/project.pbxproj: Add the new files to the project
  • profiler/Profile.cpp: Added. This class represents a single run of the profiler. (KJS::Profile::Profile): (KJS::Profile::willExecute): (KJS::Profile::didExecute): (KJS::Profile::printDataInspectorStyle): (KJS::functionNameCountPairComparator): (KJS::Profile::printDataSampleStyle):
  • profiler/Profile.h: Added. Ditto (KJS::Profile::stopProfiling):
  • profiler/Profiler.cpp: Now the profiler keeps track of many profiles but only runs one at a time. (KJS::Profiler::startProfiling): (KJS::Profiler::stopProfiling): (KJS::Profiler::willExecute): (KJS::Profiler::didExecute): (KJS::Profiler::printDataInspectorStyle): (KJS::Profiler::printDataSampleStyle):
  • profiler/Profiler.h: Ditto. (KJS::Profiler::~Profiler): (KJS::Profiler::allProfiles): (KJS::Profiler::clearProfiles):
1:14 PM Changeset in webkit [33006] by weinig@apple.com
  • 21 edits
    2 adds in trunk

WebCore:

2008-05-09 Adam Barth <​abarth-webkit@adambarth.com>

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=18771

Make postMessage generate an event on the window instead of the
document.

Test: http/tests/messaging/cross-domain-message-event-dispatch.html

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchWindowEvent):
  • dom/EventTargetNode.h:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::postMessageTimerFired):

LayoutTests:

2008-05-09 Adam Barth <​abarth-webkit@adambarth.com>

Reviewed by Sam Weinig.

Update tests to listen for message events on the window instead of
the document. Also, added a test that the event is sent to the
window and not to the document.

  • http/tests/messaging/cross-domain-message-event-dispatch-expected.txt: Added.
  • http/tests/messaging/cross-domain-message-event-dispatch.html: Added.
  • http/tests/messaging/cross-domain-message-send.html:
  • http/tests/messaging/resources/cross-domain-message-receive.html:
  • http/tests/security/cross-frame-access-delete.html:
  • http/tests/security/cross-frame-access-history-put.html:
  • http/tests/security/cross-frame-access-location-put.html:
  • http/tests/security/postMessage/delivery-order.html:
  • http/tests/security/postMessage/invalid-origin-throws-exception.html:
  • http/tests/security/postMessage/javascript-page-still-sends-origin.html:
  • http/tests/security/postMessage/origin-unaffected-by-base-tag.html:
  • http/tests/security/postMessage/origin-unaffected-by-document-domain.html:
  • http/tests/security/postMessage/resources/post-message-listener.html:
  • http/tests/security/postMessage/target-origin.html:
  • http/tests/security/resources/cross-frame-iframe-for-delete-test.html:
  • http/tests/security/resources/cross-frame-iframe-for-history-put-test.html:
  • http/tests/security/resources/cross-frame-iframe-for-location-put-test.html:
  • http/tests/security/xss-eval.html:
6:08 AM Changeset in webkit [33005] by Simon Hausmann
  • 2 edits in trunk

Simon Hausmann <Simon Hausmann>

Removed explicit linkage against libxml and libxslt on Qt/Mac builds.

This dependency is completely unnecessary here and creates only problems by
propagating through WebCore.pro over libQtWebKit.prl right now customer
applications.

4:40 AM Changeset in webkit [33004] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

Thiago Macieira <​tjmaciei@trolltech.com>

Fix bad includes in QtWebKit public headers.

Make sure to include qglobal.h using the QtCore prefix so that an explicit
include/QtCore is not needed in the application's build system. Also make sure
that qwebsettings.h includes the local qwebkitglobal.h.

3:21 AM Changeset in webkit [33003] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-05-09 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon.

Replaced all instances of qDebug() with LOG(Media, ...)
in MediaPlayerPrivatePhonon.

2:38 AM Changeset in webkit [33002] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-05-09 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon

Fix the Qt/Mac build.

1:48 AM Changeset in webkit [33001] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2008-05-08 Marc Ordinas i Llopis <​marc.ordinasillopis@collabora.co.uk>

Reviewed by Simon.

​https://bugs.webkit.org/show_bug.cgi?id=18935

Based on work by Sriram Neelakandan for the Gtk port.

12:43 AM SquirrelFishBlockers edited by ggaren@apple.com
(diff)
12:41 AM Changeset in webkit [33000] by ggaren@apple.com
  • 1 edit
    1 add in branches/squirrelfish/LayoutTests

2008-05-09 Geoffrey Garen <​ggaren@apple.com>

Added expected results for this test.

  • fast/js/closure-inside-extra-arg-call-expected.txt: Added.
12:25 AM Changeset in webkit [32999] by ggaren@apple.com
  • 6 edits in branches/squirrelfish/WebCore

2008-05-08 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Fixed platform/mac/plugins/bindings-test-objc.html.


I've restored -[WebScriptObject setException] and
+[WebScriptObject throwException].


Instead of mucking around in the JavaScript engine's execution state,
throwing an exception sets a global exception string, along with the
environment in which to throw it. An ObjC callback checks the global
exception string and, if it's non-nil and the environment matches the
current exceution environment, throws the global exception string as a
JS exception.

I also removed the old currentGlobalObject infrastructure: it's no longer
used.

May 8, 2008:

11:45 PM Changeset in webkit [32998] by mjs@apple.com
  • 3 edits
    2 adds in branches/squirrelfish

JavaScriptCore:

2008-05-08 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Geoff.


  • fix activation tearoff in the case where functions are called with too many arguments


Fixes:
fast/canvas/patternfill-repeat.html
fast/dom/SelectorAPI/bug-17313.html

  • VM/Machine.cpp: (KJS::slideRegisterWindowForCall): (KJS::scopeChainForCall): (KJS::Machine::execute): (KJS::Machine::privateExecute):

LayoutTests:

2008-05-08 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Geoff.


Add test cases for failures similar to the SquirrelFish failure on
fast/dom/SelectorAPI/bug-17313.html


  • fast/js/closure-inside-extra-arg-call.html: Added.
  • fast/js/resources/closure-inside-extra-arg-call.js: Added.
11:16 PM Changeset in webkit [32997] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Another attempt at a Tiger build fix.

Use DumpRenderTreeMac.h rather than DumpRenderTree.h as DumpRenderTreePasteboard is not an Obj-C++ file.

  • DumpRenderTree/mac/DumpRenderTreePasteboard.m:
11:08 PM Changeset in webkit [32996] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Tiger build fix. Include DumpRenderTree.h so that BUILDING_ON_TIGER will be defined.

10:43 PM Changeset in webkit [32995] by mrowe@apple.com
  • 8 edits in trunk/WebKitTools

Update DumpRenderTree to build 64-bit.

The three major changes here are:
1) Use NSInteger in the appropriate places.
2) Use ColorSync API that is available in 64-bit to switch display profiles.
3) Use method-swizzling to achieve similar results to class posing when using the Obj-C 2.0 runtime.

The build of DumpRenderTree will still fail in 64-bit for now as the TestNetscapePlugIn target also
needs updated to successfully build.

Reviewed by Oliver Hunt and Dan Bernstein.

  • DumpRenderTree/mac/Configurations/Base.xcconfig: Don't prevent Xcode from building 64-bit.
  • DumpRenderTree/mac/DumpRenderTree.mm:

(swizzleAllMethods):
(poseAsClass):
(prepareConsistentTestingEnvironment):

  • DumpRenderTree/mac/DumpRenderTreeMac.h:
  • DumpRenderTree/mac/DumpRenderTreePasteboard.h:
  • DumpRenderTree/mac/DumpRenderTreePasteboard.m:
  • DumpRenderTree/mac/DumpRenderTreeWindow.mm:
  • DumpRenderTree/mac/PixelDumpSupportMac.mm:

(restoreColorSpace):
(failedGettingCurrentProfile):
(setDefaultColorProfileToRGB):

10:43 PM Changeset in webkit [32994] by mrowe@apple.com
  • 3 edits in trunk/WebKitTools

Clean up Drosera so that it will build 64-bit.

Reviewed by Darin Adler.

  • Drosera/mac/DebuggerApplication.mm:

(-[DebuggerApplication numberOfRowsInTableView:]): Use NSInteger rather than int.
(-[DebuggerApplication tableView:objectValueForTableColumn:row:]): Ditto.

  • Drosera/mac/Drosera.xcodeproj/project.pbxproj: Use the default value for VALID_ARCHS.
10:13 PM Changeset in webkit [32993] by weinig@apple.com
  • 3 edits in trunk/WebCore

2008-05-08 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Rename the XMLHttpRequestState enum values to match the spec.

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseXML): (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::callReadyStateChangeListener): (WebCore::XMLHttpRequest::open): (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::abort): (WebCore::XMLHttpRequest::setRequestHeader): (WebCore::XMLHttpRequest::getAllResponseHeaders): (WebCore::XMLHttpRequest::getResponseHeader): (WebCore::XMLHttpRequest::status): (WebCore::XMLHttpRequest::statusText): (WebCore::XMLHttpRequest::processSyncLoadResults): (WebCore::XMLHttpRequest::didFinishLoading): (WebCore::XMLHttpRequest::didReceiveData):
  • xml/XMLHttpRequest.h: (WebCore::):
10:06 PM Changeset in webkit [32992] by mitz@apple.com
  • 6 edits
    4 adds in trunk

WebCore:

Reviewed by Mark Rowe.

Test: fast/css/first-letter-float-after-float.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter): Changed to add the first letter container right before the rest of the text it is taken from, instead of at the beginning of the block.

LayoutTests:

Reviewed by Mark Rowe.

  • ChangeLog:
  • fast/css/first-letter-float-after-float.html: Added.
  • platform/mac-leopard/fast/css/first-letter-skip-out-of-flow-expected.checksum:
  • platform/mac-leopard/fast/css/first-letter-skip-out-of-flow-expected.png:
  • platform/mac/fast/css/first-letter-float-after-float-expected.checksum: Added.
  • platform/mac/fast/css/first-letter-float-after-float-expected.png: Added.
  • platform/mac/fast/css/first-letter-float-after-float-expected.txt: Added.
  • platform/mac/fast/css/first-letter-skip-out-of-flow-expected.txt:
6:18 PM SquirrelFishBlockers edited by ggaren@apple.com
(diff)
6:09 PM SquirrelFishBlockers edited by ggaren@apple.com
(diff)
6:08 PM SquirrelFishBlockers edited by ggaren@apple.com
(diff)
6:08 PM Changeset in webkit [32991] by ggaren@apple.com
  • 4 edits
    4 adds in branches/squirrelfish

JavaScriptCore:

2008-05-08 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.


Fixed failure in fast/canvas/canvas-pattern-behaviour.html.


SunSpider reports a small speedup. Not sure what that's about.

  • VM/CodeBlock.cpp: (KJS::CodeBlock::dump): Fixed op_call_eval to dump as "op_call_eval". This helped me while debugging.
  • VM/Machine.cpp: (KJS::Machine::unwindCallFrame): When looking for an activation to tear off, don't use the scope chain. Inside eval, the scope chain doesn't belong to us; it belongs to our calling function.


Also, don't use the needsFullScopeChain flag to decide whether to tear
off the activation. "function.arguments" can create an activation
for a function whose needsFullScopeChain flag is set to false.

LayoutTests:

2008-05-08 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.


Added specific test cases for the root cause of squirrelfish's failure
in fast/canvas/canvas-pattern-behaviour.html.

  • fast/js/exception-thrown-from-eval-inside-closure-expected.txt: Added.
  • fast/js/exception-thrown-from-eval-inside-closure.html: Added.
  • fast/js/exception-thrown-from-function-with-lazy-activation-expected.txt: Added.
  • fast/js/exception-thrown-from-function-with-lazy-activation.html: Added.
5:02 PM Changeset in webkit [32990] by Chris Fleizach
  • 3 edits in trunk/WebCore

<rdar://problem/5921046> AX: list box options have wrong AXPosition

4:59 PM Changeset in webkit [32989] by jchaffraix@webkit.org
  • 5 edits in trunk/WebCore

2008-05-08 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.

Bug 18916: make_names.pl --factory needs to support custom c++ guard

Add --guardFactoryWith to handle the cpp guard around generated factories.

  • DerivedSources.make: Set the guardFactoryWith variable for SVG factory.
  • GNUmakefile.am: Ditto.
  • WebCore.pro: Ditto.
  • dom/make_names.pl: Add guardFactoryWith option.
2:36 PM Changeset in webkit [32988] by andersca@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-05-08 Anders Carlsson <​andersca@apple.com>

Reviewed by Mark.

Enable NPAPI plug-ins on 64-bit.


  • wtf/Platform.h:
1:32 PM Changeset in webkit [32987] by jchaffraix@webkit.org
  • 4 edits in trunk/WebCore

2008-05-08 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Adam Roben.

wx & Gtk build fix.

Should also fix the cURL backend for the Windows port.

  • WebCore.vcproj/WebCore.vcproj: Add FormDataStreamCurl information.
  • platform/network/curl/FormDataStreamCurl.h: Include stdio.h which fixes the build on some machine.
  • webcore-wx.bkl: Add FormDataStreamCurl.cpp.
1:00 PM Changeset in webkit [32986] by timothy@apple.com
  • 2 edits in trunk/WebCore

2008-05-08 Timothy Hatcher <​timothy@apple.com>

Fixes the bug where the Web Inspector could not
find any localization strings.

Reviewed by Mark Rowe.

  • WebCore.xcodeproj/project.pbxproj: Add the localizedStrings.js file to the WebCore Copy Resources phase. Also removes an idl from the Copy Resources phase.
12:04 PM Changeset in webkit [32985] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

  • fix <rdar://problem/5697957> "No recent searches" label in a narrow search field's history popup is truncated
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::calculatePositionAndSize): Changed to use a bold font for measuring labels.
11:54 AM Changeset in webkit [32984] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Geoffrey Garen.

  • page/Frame.cpp: (WebCore::Frame::matchLabelsAgainstElement):
11:14 AM SquirrelFishBlockers edited by ggaren@apple.com
(diff)
11:11 AM Changeset in webkit [32983] by ggaren@apple.com
  • 2 edits in branches/squirrelfish/LayoutTests

2008-05-08 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.


Updated test results to reflect correct behavior: The line number in
the old results was off by 2.

  • fast/js/recursion-limit-equal-expected.txt:
11:11 AM Changeset in webkit [32982] by mrowe@apple.com
  • 2 edits in trunk/WebKitSite

2008-05-08 Mark Rowe <​mrowe@apple.com>

Reviewed by Sam Weinig.

Add a link to the Mac OS Forge terms of use.

  • nav.inc:
10:48 AM SquirrelFishBlockers edited by ggaren@apple.com
(diff)
7:58 AM Changeset in webkit [32981] by Simon Hausmann
  • 5 edits
    2 copies in trunk/WebCore

2008-05-08 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Simon.

Simple ImageBuffer::image implementation.

In contrast to cg and cairo we do not use a special BitmapImage because
the ownership of the FrameData inside the BitmapImage is a bit backward
(actually owned by the ImageDecoderQt...). Further work is needed for image
and pixmap handling in the qt port...

7:57 AM Changeset in webkit [32980] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-05-08 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Simon.

Update the WebKit.qrc of the inspector to be functional again

6:53 AM Changeset in webkit [32979] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-05-08 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon

Fix the Qt/Mac build.

3:40 AM Changeset in webkit [32978] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Warwick Allison <​warwick@trolltech.com>

Fixes: WebKit expects initial input method state to be *disabled*.

At least QWS does not need the initial input method state to be forced to
enabled, but other platforms (esp. X11) do. Until fixed/tested on those
platforms, this is specific to QWS.

3:23 AM Changeset in webkit [32977] by mjs@apple.com
  • 2 edits
    2 moves
    6 deletes in branches/squirrelfish/LayoutTests

2008-05-08 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver.


  • move frame.xhtml and iframe.xhtml into a resources dir, as they were never meant to be tests
  • dom/xhtml/level2/html/HTMLFrameElement09.xhtml-disabled:
  • dom/xhtml/level2/html/frame.xhtml: Removed.
  • dom/xhtml/level2/html/iframe.xhtml: Removed.
  • dom/xhtml/level2/html/resources/frame.xhtml: Copied from dom/xhtml/level2/html/frame.xhtml.
  • dom/xhtml/level2/html/resources/iframe.xhtml: Copied from dom/xhtml/level2/html/iframe.xhtml.
  • platform/mac/dom/xhtml/level2/html/frame-expected.checksum: Removed.
  • platform/mac/dom/xhtml/level2/html/frame-expected.png: Removed.
  • platform/mac/dom/xhtml/level2/html/frame-expected.txt: Removed.
  • platform/mac/dom/xhtml/level2/html/iframe-expected.checksum: Removed.
  • platform/mac/dom/xhtml/level2/html/iframe-expected.png: Removed.
  • platform/mac/dom/xhtml/level2/html/iframe-expected.txt: Removed.
2:39 AM Changeset in webkit [32976] by Simon Hausmann
  • 3 edits in trunk/WebCore

2008-05-08 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Simon.

Use native Windows library handling (instead of QLibrary)
for Qt/Win32's PlatformModule.

  • platform/FileSystem.h: (WebCore::PlatformModuleVersion::PlatformModuleVersion):
  • platform/qt/FileSystemQt.cpp: (WebCore::unloadModule):
2:39 AM Changeset in webkit [32975] by mjs@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

2008-05-08 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver.


  • fix function.call for calls of more than 8 arguments


Fixes svg/carto.net/button.svg

  • kjs/list.cpp: (KJS::List::getSlice): properly set up the m_buffer of the target list.
2:38 AM Changeset in webkit [32974] by Simon Hausmann
  • 4 edits in trunk

2008-05-08 Simon Hausmann <Simon Hausmann>

Reviewed and found by Holger.

Include .css in the list of extensions for text/css. Fixes
fast/loader/local-css-allowed-in-strict-mode.html.

1:36 AM Changeset in webkit [32973] by mjs@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

2008-05-08 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver.


  • don't return a null RegisterID from RegExpNode in the exception case, since the caller may need a real register

Fixes:

  • fast/regex/early-acid3-86.html
  • http/tests/misc/acid3.html


  • kjs/nodes.cpp: (KJS::RegExpNode::emitCode):
12:45 AM Changeset in webkit [32972] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-05-08 Simon Hausmann <Simon Hausmann>

Fix the Qt and Wx build when compiling without offline app support.

May 7, 2008:

11:12 PM SquirrelFishBlockers edited by ggaren@apple.com
(diff)
11:11 PM Changeset in webkit [32971] by ggaren@apple.com
  • 13 edits
    2 adds in branches/squirrelfish/LayoutTests

o2008-05-07 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

Added this test to demonstrate that, for "f(x)", it is correct to evaluate
"x" even if "f" is not a function, and therefore "f(x)" will throw an exception.

  • fast/js/function-argument-evaluation-before-exception-expected.txt: Added.
  • fast/js/function-argument-evaluation-before-exception.html: Added.


These tests now have an extra "access denied" message in them, because
of the behavior change mentioned above.


I also added try/catch clauses to eliminate the "is not object"
exception messages from the test output.


  • http/tests/security/listener/resources/targetChild-JSTargetNode-onclick-addEventListener.html:
  • http/tests/security/listener/resources/targetChild-JSTargetNode-onclick-shortcut.html:
  • http/tests/security/listener/resources/targetChild-XMLHttpRequest-addEventListener.html:
  • http/tests/security/listener/resources/targetChild-XMLHttpRequest-shortcut.html:
  • http/tests/security/listener/resources/targetChild-window-onclick-addEventListener.html:
  • http/tests/security/listener/resources/targetChild-window-onclick-shortcut.html:
  • http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt:
  • http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt:
  • http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt:
  • http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt:
  • http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt:
  • http/tests/security/listener/xss-window-onclick-shortcut-expected.txt:
10:16 PM SquirrelFishBlockers edited by ggaren@apple.com
(diff)
9:36 PM Changeset in webkit [32970] by ggaren@apple.com
  • 11 edits in branches/squirrelfish/LayoutTests

2008-05-07 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.


Fixed up a few more tests that depended on the exact text of exception
messages.


  • In these tests, I fixed a bug in frame.html and iframe.html that caused a function to execute too many times.
  • dom/html/level2/html/HTMLFrameElement09-expected.txt:
  • dom/html/level2/html/HTMLIFrameElement11-expected.txt:
  • dom/html/level2/html/resources/frame.html:
  • dom/html/level2/html/resources/iframe.html:
  • I changed these tests to explicitly report exceptions, so their results don't depend on how the engine constructs messages for implicit exceptions:
  • dom/xhtml/level2/html/HTMLDocument17-expected.txt:
  • dom/xhtml/level2/html/HTMLDocument18-expected.txt:
  • dom/xhtml/level2/html/HTMLDocument19-expected.txt:
  • dom/xhtml/level2/html/HTMLDocument20-expected.txt:
  • dom/xhtml/level2/html/HTMLDocument21-expected.txt:
  • dom/xhtml/level2/html/selfxhtml.js:
8:28 PM Changeset in webkit [32969] by Stephanie Lewis
  • 2 edits in trunk/LayoutTests

2008-05-07 Stephanie Lewis <Stephanie Lewis>

fix messed up result

  • fast/events/onunload-not-on-body-expected.txt:
7:13 PM Changeset in webkit [32968] by weinig@apple.com
  • 5 edits in trunk/WebCore

2008-05-07 Sam Weinig <​sam@webkit.org>

Reviewed by Adele Peterson

Update MessageEvent to match the latest version of the HTML5 spec,
adding the lastEventId attribute.

  • dom/MessageEvent.cpp: (WebCore::MessageEvent::MessageEvent): (WebCore::MessageEvent::initMessageEvent):
  • dom/MessageEvent.h: (WebCore::MessageEvent::lastEventId):
  • dom/MessageEvent.idl:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::postMessage):
6:05 PM Changeset in webkit [32967] by Stephanie Lewis
  • 4 edits
    2 adds in trunk

2008-05-07 Stephanie Lewis <Stephanie Lewis>

Reviewed by Maciej.

remove non-functioning code. If onunload should be fired from these nodes then
a WindowEventListener needs to be set. However, Firefox and IE also do not
fire onunload events for these cases.

Test: fast/events/onunload-not-on-body.html


  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::parseMappedAttribute):
  • html/HTMLObjectElement.cpp (WebCore::HTMLObjectElement::parseMappedAttribute):

Test onunload attr on a frame does not call onunload, but that an onunload attr on the body of
a frame does. Also test that onunloads on object elements are not called.

  • fast/events/onunload-not-on-body-expected.txt: Added.
  • fast/events/onunload-not-on-body.html: Added.
1:44 PM Changeset in webkit [32966] by mitz@apple.com
  • 4 edits
    4 adds in trunk

WebCore:

Reviewed by John Sullivan.

Test: fast/dynamic/positioned-movement-with-positioned-children.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutOnlyPositionedObjects): Cover the case of a positioned object that has only moved and has only positioned children that have changed.
  • rendering/RenderObject.h: (WebCore::RenderObject::needsPositionedMovementLayout): Added this accessor.

LayoutTests:

Reviewed by John Sullivan.

  • fast/dynamic/positioned-movement-with-positioned-children.html: Added.
  • platform/mac/fast/dynamic/positioned-movement-with-positioned-children-expected.checksum: Added.
  • platform/mac/fast/dynamic/positioned-movement-with-positioned-children-expected.png: Added.
  • platform/mac/fast/dynamic/positioned-movement-with-positioned-children-expected.txt: Added.
1:41 PM Changeset in webkit [32965] by andersca@apple.com
  • 4 edits in trunk/WebCore

2008-05-07 Anders Carlsson <​andersca@apple.com>

Reviewed by John.

When no document loaders are associated with an application cache group,
release the reference to the newest cache group. This prevents reference cycles.


  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::ApplicationCacheGroup): (WebCore::ApplicationCacheGroup::documentLoaderDestroyed): (WebCore::ApplicationCacheGroup::cacheDestroyed):
  • loader/appcache/ApplicationCacheGroup.h:


  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::cacheGroupForURL): Return early if the datbase wasn't open.


(WebCore::ApplicationCacheStorage::loadCache):
Add error.

12:42 PM Changeset in webkit [32964] by andersca@apple.com
  • 2 edits in trunk/WebCore

2008-05-07 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam.

Don't put pages with an application cache in the BF cache.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::canCachePage):
11:59 AM Changeset in webkit [32963] by justin.garcia@apple.com
  • 4 edits
    4 adds in trunk

WebCore:

2008-05-07 Justin Garcia <​justin.garcia@apple.com>

Reviewed by John Sullivan.

<rdar://problem/5666354> Crashes in Mail at WebCore::RemoveNodeCommand::doApply


When a single tab or series of tabs was copied, we weren't putting them into a
tab span. On Paste, we would be given a text node with a single tab or series
of tabs in it, and we would crash when inserting it at the start of a block
(where that kind of text becomes completely unrendered).

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds): Clean up correctly and early return if we removed everything that was inserted.
  • editing/markup.cpp: (WebCore::createMarkup): Include the tab span when the only thing copied was a tab or a series of tabs.

LayoutTests:

2008-05-07 Justin Garcia <​justin.garcia@apple.com>

Reviewed by John Sullivan.

<rdar://problem/5666354> Crashes in Mail at WebCore::RemoveNodeCommand::doApply

  • editing/pasteboard/5761530-1-expected.txt: Added.
  • editing/pasteboard/5761530-1.html: Added.
  • editing/pasteboard/5761530-2-expected.txt: Added.
  • editing/pasteboard/5761530-2.html: Added.
11:02 AM Changeset in webkit [32962] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-05-07 Anders Carlsson <​andersca@apple.com>

Reviewed by Mitz.

REGRESSION (3.1.1-TOT): Arrow keys are sticky in Google Maps street view
​https://bugs.webkit.org/show_bug.cgi?id=18880
<rdar://problem/5909513>

Stop suspending key up events before calling handleEvent.


  • Plugins/WebNetscapePluginEventHandlerCarbon.mm: (WebNetscapePluginEventHandlerCarbon::sendEvent):
10:33 AM Changeset in webkit [32961] by ddkilzer@apple.com
  • 2 edits in trunk

Added radar to changelog for r32959.

10:16 AM Changeset in webkit [32960] by jchaffraix@webkit.org
  • 6 edits in trunk

2008-05-07 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Adam Roben.

wx & Gtk build fix.

Add SIZE_MAX definition for the wx port.

  • os-win32/stdint.h:

2008-05-07 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Adam Roben.

wx & Gtk build fix.

  • platform/network/curl/FormDataStreamCurl.cpp: Added stdint.h include. We need to define STDC_LIMIT_MACROS to have SIZE_MAX exported.
  • platform/network/curl/FormDataStreamCurl.h: Removed cstdint include (replaced by stdint.h) as it is not present on the build bots.
  • plugins/gtk/PluginDatabaseGtk.cpp: Added missing #endif.
10:11 AM Changeset in webkit [32959] by ddkilzer@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Bug 18900: Password field has focus but can't type text (i.rememberthemilk.com)
<​https://bugs.webkit.org/show_bug.cgi?id=18900>

Original patch by Aaron Golden and Tim Omernick. Reviewed by Adele.

Test: fast/forms/textfield-to-password-on-focus.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType): If the current node has focus, call updateFocusAppearance() to make sure its state is correct after changing its type.

LayoutTests:

Bug 18900: Password field has focus but can't type text (i.rememberthemilk.com)
<​https://bugs.webkit.org/show_bug.cgi?id=18900>

Reviewed by Adele.

  • fast/forms/textfield-to-password-on-focus-expected.txt: Added.
  • fast/forms/textfield-to-password-on-focus.html: Added.
9:35 AM Changeset in webkit [32958] by Chris Fleizach
  • 6 edits in trunk/WebCore

<rdar://problem/4867889> REGRESSION: "Choose File.." buttons are exposed as AXGroup instead of AXButton

7:21 AM Changeset in webkit [32957] by Simon Hausmann
  • 2 edits in trunk/LayoutTests

2008-05-07 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon

Add ~250 tests that fail to the skipped list so we have a sane baseline.

6:05 AM Changeset in webkit [32956] by jchaffraix@webkit.org
  • 5 edits
    2 adds in trunk/WebCore

2008-05-07 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.

Bug 17971: [Curl] FormData processing should be moved to its own class

Move FormData treatment into FormDataStream. The aim is to have FormDataStream behave like a stream that cURL
could manipulate.

First step into having complete file uploading facility in cURL.

No test case as it is only code refactoring.

  • GNUmakefile.am: Add FormDataStreamCurl.cpp
  • platform/network/ResourceHandleInternal.h: Move code to FormStreamDataCurl.h (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/curl/FormDataStreamCurl.cpp: Added. (WebCore::FormDataStream::~FormDataStream): (WebCore::FormDataStream::read):
  • platform/network/curl/FormDataStreamCurl.h: Added. (WebCore::FormDataStream::FormDataStream):
  • platform/network/curl/ResourceHandleCurl.cpp: (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::readCallback): Move code to FormDataStreamCurl.cpp
5:28 AM Changeset in webkit [32955] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-05-07 Adam Treat <​treat@kde.org>

Reviewed by Simon.

​https://bugs.webkit.org/show_bug.cgi?id=18898

Fixed wrong transform being used for creating the pixmap for a new
transparency layer. This fixes the popup menus on dell.com.

5:10 AM Changeset in webkit [32954] by Simon Hausmann
  • 5 edits in trunk/WebCore

2008-05-07 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Simon.

Share the plug-in directories between Gtk and Qt/X11 port.

  • platform/qt/FileSystemQt.cpp: (WebCore::homeDirectoryPath): Implement it for Qt.
  • plugins/PluginDatabase.cpp: (WebCore::addMozillaPluginDirectories): Shared code. (WebCore::PluginDatabase::defaultPluginDirectories): (WebCore::PluginDatabase::isPreferredPluginDirectory): Shared code.
  • plugins/gtk/PluginDatabaseGtk.cpp: (WebCore::PluginDatabase::isPreferredPluginDirectory): Refactored.
  • plugins/qt/PluginDatabaseQt.cpp: Refactored.
4:46 AM Changeset in webkit [32953] by Simon Hausmann
  • 3 edits in trunk/WebCore

2008-05-07 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon

Fix build issues on Mac and refeactor the .pro file a bit.

4:45 AM Changeset in webkit [32952] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-05-07 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon

Draw scrollview corners (between scrollbars) using the Qt style.

​https://bugs.webkit.org/show_bug.cgi?id=18894

2:50 AM Changeset in webkit [32951] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

Use File::Find and Getopt::Long in make-js-test-wrappers

Reviewed by Darin.

  • Scripts/make-js-test-wrappers:
  • Updated Apple copyright statement.
Added command-line switch parsing and -hhelp switch.
  • Allowed user to pass list of files/directories on which to do a restricted search for TEMPLATE.html files. The default behavior is still to search the entire LayoutTests directory.
  • Removed duplicate 'use strict' statement.
  • Replaced use of find statements with File::Find::find().
  • Remove unneeded chomp() calls now that we use File::Find. (directoryFilter): Added. Filters .svn directories when used with File::Find::find(). (findTemplateFiles): Added. Returns a list of TEMPLATE.html files found.
2:37 AM Changeset in webkit [32950] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-05-07 Simon Hausmann <Simon Hausmann>

Fix the Qt build, added AccessibilityListBox and ListBoxOption.cpp to
the build.

2:37 AM Changeset in webkit [32949] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-05-07 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Simon.

Support for isMainThread in the Qt port.

  • wtf/ThreadingQt.cpp: (WTF::initializeThreading): Adjusted. (WTF::isMainThread): Added.
2:36 AM Changeset in webkit [32948] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-05-07 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Rubber-stamped by Holger.

Fix building without storage support.

  • page/PageGroup.cpp: (WebCore::PageGroup::closeLocalStorage): proper #if
2:36 AM Changeset in webkit [32947] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-05-07 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Rubber-stamped by Oliver Hunt.

Fix building without accessibility.

  • page/AXObjectCache.cpp: (WebCore::AXObjectCache::selectedChildrenChanged): proper #if
2:02 AM Changeset in webkit [32946] by oliver@apple.com
  • 10 edits in branches/squirrelfish/JavaScriptCore

Partial fix for current performance regressions.

Patch from Cameron Zwarich
Reviewed by Oliver

Fix a performance regression caused by the introduction of property
attributes to SymbolTable in r32859 by encoding the attributes and the
register index into a single field of SymbolTableEntry.

This leaves Node::optimizeVariableAccess() definitely broken, although
it was probably not entirely correct in SquirrelFish before this change.

Note: See TracTimeline for information about the timeline view.