Timeline



Jul 1, 2008:

11:35 PM Changeset in webkit [34946] by ap@webkit.org
  • 5 edits in trunk/JavaScriptCore

Reviewed by Darin.

https://bugs.webkit.org/show_bug.cgi?id=19834
Failed assertion in JavaScriptCore/VM/SegmentedVector.h:82

Creating a global object with a custom prototype resets it twice (wasteful!).
So, addStaticGlobals() was called twice, but JSGlobalObject::reset() didn't reset
the register array.

  • kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::reset): Call setRegisterArray(0, 0).
  • kjs/JSVariableObject.h: Changed registerArray to OwnArrayPtr. Also, added private copy constructor and operator= to ensure that no one attempts to copy this object (for whatever reason, I couldn't make Noncopyable work).
  • kjs/JSGlobalObject.h: (KJS::JSGlobalObject::addStaticGlobals): Allocate registerArray with new[].
  • kjs/JSVariableObject.cpp: (KJS::JSVariableObject::copyRegisterArray): Allocate registerArray with new[]. (KJS::JSVariableObject::setRegisterArray): Avoid hitting an assertion in OwnArrayPtr when "changing" the value from 0 to 0.
10:39 PM Changeset in webkit [34945] by ggaren@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-07-01 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.


Removed and/or reordered exception checks in array-style a[n] access.


SunSpider says 1.4% faster.

  • VM/Machine.cpp: (KJS::Machine::privateExecute): No need to check for exceptions before calling toString, toNumber and/or get. If the call ends up being observable through toString, valueOf, or a getter, we short-circuit it there, instead. In the op_del_by_val case, I removed the incorrect comment without actually removing the code, since I didn't want to tempt the GCC fates!
  • kjs/JSObject.cpp: (KJS::callDefaultValueFunction): Added exception check to prevent toString and valueOf functions from observing execution after an exception has been thrown. This removes some of the burden of exception checking from the machine.

(KJS::JSObject::defaultValue): Removed redundant exception check here.

  • kjs/PropertySlot.cpp: (KJS::PropertySlot::functionGetter): Added exception check to prevent getter functions from observing execution after an exception has been thrown. This removes some of the burden of exception checking from the machine.
9:28 PM Changeset in webkit [34944] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Oliver Hunt.

  • fix a CSSParserValueList leak seen on the build bot
  • css/CSSParser.cpp: (WebCore::BorderImageParseContext::commitBorderImage):
9:21 PM Changeset in webkit [34943] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-07-01 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.


Optimized a[n] get and put for cases where n is an immediate unsigned
value.


SunSpider says 3.5% faster.

8:27 PM Changeset in webkit [34942] by oliver@apple.com
  • 2 edits
    5 adds in trunk/WebCore

2008-07-01 Alex Mathews <possessedpenguinbob@gmail.com>

Reviewed by Oliver Hunt.

Prep for more Filter class name changes. Added the first few files for
the new Filter architecture to come.

7:12 PM Changeset in webkit [34941] by mrowe@apple.com
  • 2 edits in trunk/WebKitSite

Update the path to the configuration file.

6:08 PM Changeset in webkit [34940] by cwzwarich@webkit.org
  • 5 edits in trunk

2008-07-01 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Darin.

Bug 19844: JavaScript Switch statement modifies "this"
<https://bugs.webkit.org/show_bug.cgi?id=19844>

Use a temporary when generating code for switch clauses to avoid
overwriting 'this' or a local variable.

JavaScriptCore:

  • kjs/nodes.cpp: (KJS::CaseBlockNode::emitCodeForBlock):

LayoutTests:

  • fast/js/codegen-temporaries-expected.txt:
  • fast/js/resources/codegen-temporaries.js:
5:11 PM Changeset in webkit [34939] by sfalken@apple.com
  • 3 edits in trunk/WebKitLibraries

Bump version numbers.


Reviewed by Mark Rowe.

  • win/tools/scripts/PRODUCTVERSION:
  • win/tools/scripts/VERSION:
5:08 PM Changeset in webkit [34938] by christian@webkit.org
  • 4 edits in trunk

Gtk+ build fix.

4:46 PM Changeset in webkit [34937] by kmccullough@apple.com
  • 4 edits in trunk

JavaScriptCore:

2008-07-01 Kevin McCullough <kmccullough@apple.com>

Build fix.

WebKit/mac:

2008-07-01 Kevin McCullough <kmccullough@apple.com>

Build fix.

  • WebView/WebView.mm:
4:44 PM Changeset in webkit [34936] by andersca@apple.com
  • 8 edits in trunk

WebCore:

2008-07-01 Anders Carlsson <andersca@apple.com>

Reviewed by Darin.

Add PluginMainThreadScheduler.{cpp|h} to build.


  • WebCore.base.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • plugins/PluginMainThreadScheduler.cpp:

WebKit/mac:

2008-07-01 Anders Carlsson <andersca@apple.com>

Reviewed by Darin.

Use the PluginMainThreadScheduler, and implement NPN_PluginThreadAsyncCall.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView _createPlugin]): Register the plug-in instance.


(-[WebBaseNetscapePluginView _destroyPlugin]):
Unegister the plug-in instance.


  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): Set NPN_PluginThreadAsyncCall.


  • Plugins/npapi.mm: (NPN_PluginThreadAsyncCall): Implement this.
3:34 PM Changeset in webkit [34935] by mitz@apple.com
  • 9 edits in trunk

WebCore:

Reviewed by Darin Adler.

  • move the method to set the base writing direction from Frame to Editor
  • WebCore.base.exp: Updated.
  • editing/Editor.cpp: (WebCore::Editor::setBaseWritingDirection): Changed the parameter to a WritingDirection enum value and added the special behavior when the focused node is a text field or a text area.
  • editing/Editor.h:
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Changed back to call the Editor method.
  • page/Frame.cpp: Removed setSelectionBaseWritingDirection().
  • page/Frame.h:

WebKit/mac:

Reviewed by Darin Adler.

  • WebKit part of moving the method to set the base writing direction from Frame to Editor
  • WebView/WebHTMLView.mm: (-[WebHTMLView toggleBaseWritingDirection:]): Changed back to call the Editor method. (-[WebHTMLView changeBaseWritingDirection:]): Ditto. (-[WebHTMLView _changeBaseWritingDirectionTo:]): Ditto.
3:21 PM Changeset in webkit [34934] by Darin Adler
  • 2 edits in trunk/WebCore

2008-07-01 Darin Adler <Darin Adler>

Reviewed by Oliver.

  • slight tweak of the setHash fix
  • bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::setHash): Use oldRef instead of recomputing url.ref().
3:19 PM Changeset in webkit [34933] by mitz@apple.com
  • 4 edits in trunk

JavaScriptCore:

Reviewed by Anders Carlsson.

  • Mac release build fix

WebCore:

Reviewed by Anders Carlsson.

  • Mac release build fix
  • page/Console.cpp:
2:20 PM Changeset in webkit [34932] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Anders Carlsson.

  • fix <rdar://problem/6045896> REGRESSION: Leak in WebCore::StringImpl::create
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cleanup):
2:11 PM Changeset in webkit [34931] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-07-01 Sam Weinig <sam@webkit.org>

Try and fix mac builds.

2:06 PM Changeset in webkit [34930] by andersca@apple.com
  • 2 edits in trunk/WebCore

2008-07-01 Anders Carlsson <andersca@apple.com>

Reviewed by Jon.

Don't add the Mozilla user agent quirk for Flash 10.


  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::isPluginBlacklisted): (WebCore::PluginPackage::determineQuirks):
1:06 PM Changeset in webkit [34929] by ddkilzer@apple.com
  • 4 edits in trunk/WebCore

Move data: URL parsing code in HTMLObjectElement to KURL

Reviewed by Ada and Darin.

No test cases added since there is no change in behavior.

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::isImageType): Extracted data: URL parsing code into WebCore::mimeTypeFromDataURL() in KURL.cpp.
  • platform/KURL.cpp: (WebCore::mimeTypeFromDataURL): Added.
  • platform/KURL.h: (WebCore::mimeTypeFromDataURL): Added.
12:08 PM Changeset in webkit [34928] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • fix <rdar://problem/6045890> REGRESSION: Leak in WebCore::CSSParser::createFloatingValueList()
  • css/CSSParser.cpp: (WebCore::CSSParser::addUnresolvedProperty):
12:05 PM Changeset in webkit [34927] by cwzwarich@webkit.org
  • 3 edits
    2 adds in trunk

2008-07-01 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Brady Eidson.

Bug 19822: REGRESSION (r30243): setting location.hash to "#" causes a reload
<https://bugs.webkit.org/show_bug.cgi?id=19822>

Change JSLocation::setHash() to not schedule navigation in the case
where the old fragment is the null String and the new fragment is an
empty String.

WebCore:

  • bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::setHash):

LayoutTests:

  • http/tests/loading/location-hash-reload-cycle-expected.txt: Added.
  • http/tests/loading/location-hash-reload-cycle.html: Added.
11:31 AM Changeset in webkit [34926] by andersca@apple.com
  • 6 edits
    2 adds in trunk/WebCore

2008-06-30 Anders Carlsson <andersca@apple.com>

Reviewed by Adam.

Add PluginMainThreadScheduler, a singleton which is responsible for scheduling plug-in
callbacks on the main thread. Use this to implement NPN_PluginThreadAsyncCall on Windows.


  • WebCore.vcproj/WebCore.vcproj: Add PluginMainThreadScheduler.{cpp|h}


  • plugins/PluginMainThreadScheduler.cpp: Added.
  • plugins/PluginMainThreadScheduler.h: Added.
  • plugins/PluginView.cpp: (WebCore::PluginView::start): Register with the thread scheduler.


  • plugins/npapi.cpp: (NPN_PluginThreadAsyncCall): Call the thread scheduler.


  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::load): Initialize the NPN_PluginThreadAsyncCall callback.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::stop): Unregister with the scheduler. This makes sure that we won't try to deliver callbacks after the plug-in has been destroyed.
11:02 AM Changeset in webkit [34925] by Adam Roben
  • 105 edits
    2 moves
    2 adds
    7 deletes in trunk

Roll out r34913, as it broke the Windows build due to bad casting

WebCore:

Roll out r34913, as it broke the Windows build due to bad casting

r34913 introduced code that assigned pointers-to-member from a derived
class into a base class pointer-to-member type (e.g., assigned a void
(SVGUseElement::*)() into a void (SVGElement::*)()). This is bad
because it could allow us to call SVGUseElement member functions on a
different SVGElement-derived class. MSVC rightly flagged this as an
error.

Rubberstamped by Anders Carlsson.

LayoutTests:

Roll out r34913, as it broke the Windows build due to bad casting

Rubberstamped by Anders Carlsson.

10:56 AM Changeset in webkit [34924] by Darin Adler
  • 2 edits in trunk/WebCore

2008-07-01 Darin Adler <Darin Adler>

  • fix build
  • bindings/scripts/CodeGeneratorJS.pm: Fix warnings that indicate this was not working propertly.
10:46 AM Changeset in webkit [34923] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

  • fix <rdar://problem/6045893> REGRESSION: Leak in WebCore::HTMLCanvasElement::createPlatformImage() const
  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createPattern):
10:39 AM Changeset in webkit [34922] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-07-01 Sam Weinig <sam@webkit.org>

Fix non-AllInOne builds.

  • kjs/DateMath.cpp:
10:32 AM Changeset in webkit [34921] by weinig@apple.com
  • 17 edits
    3 copies
    1 add in trunk

JavaScriptCore:

2008-07-01 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Split JSCell and JSNumberCell class declarations out of JSValue.h

  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • VM/JSPropertyNameIterator.h:
  • kjs/AllInOneFile.cpp:
  • kjs/JSCell.cpp: Copied from JavaScriptCore/kjs/JSValue.cpp.
  • kjs/JSCell.h: Copied from JavaScriptCore/kjs/JSValue.h. (KJS::JSValue::getJSNumber):
  • kjs/JSNumberCell.cpp:
  • kjs/JSNumberCell.h: Copied from JavaScriptCore/kjs/JSValue.h.
  • kjs/JSObject.h:
  • kjs/JSString.cpp: (KJS::jsString): (KJS::jsOwnedString):
  • kjs/JSString.h: (KJS::JSValue::toThisJSString):
  • kjs/JSValue.cpp:
  • kjs/JSValue.h:

WebCore:

2008-07-01 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Split JSCell and JSNumberCell class declarations out of JSValue.h

  • ForwardingHeaders/kjs/JSNumberCell.h: Added.
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/c/c_instance.cpp:
10:27 AM Changeset in webkit [34920] by Chris Fleizach
  • 8 edits
    2 adds in trunk

<rdar://problem/6041580> REGRESSION: AX: AXSize of radio buttons is 0,0

Fixed incorrect AXSize of radio buttons and checkboxes when they don't have labels

9:42 AM Changeset in webkit [34919] by andersca@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-07-01 Anders Carlsson <andersca@apple.com>

Build fixes.


  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • kjs/JSGlobalObject.h: (KJS::JSGlobalObject::addStaticGlobals):
7:40 AM Changeset in webkit [34918] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Antti Koivisto.

  • fix SVG pointer-events layout test failures
  • css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue):
7:29 AM Changeset in webkit [34917] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2008-07-01 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Simon.

Don't show the tooltip instantly in the QtLauncher.

Let the QWebView handle tooltips by itself, so we get
the expected delay as everywhere else.

5:21 AM Changeset in webkit [34916] by Nikolas Zimmermann
  • 5 edits
    60 adds in trunk

Reviewed by Antti.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=19841
Fix two small problems in the gradient & pattern code.

Added 12 new layout tests: svg/dynamic-updates/SVGLinearGradientElement*.html

5:15 AM Changeset in webkit [34915] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-07-01 Simon Hausmann <Simon Hausmann>

Fix the build, include SVGTransformList.h instead of
SVGTransformlist.h

5:01 AM Changeset in webkit [34914] by ap@webkit.org
  • 5 edits
    2 moves
    2 adds in trunk

Reviewed by Antti.

<rdar://problem/6033080> REGRESSION: Some CH characters display as garbage on webpage for
the first time.

Test: fast/encoding/preload-encoding.html

  • html/PreloadScanner.cpp: (WebCore::PreloadScanner::tokenize): Reset charset when entering a tag, not just when starting a load.
4:33 AM Changeset in webkit [34913] by Nikolas Zimmermann
  • 105 edits
    4 moves
    5 adds in trunk

Reviewed by Antti & Eric.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=17779 (SVG 1.1 Errata demands "SVG JavaScript Liveness" support)

SVG Errata states: "All SVG DOM objects that directly correspond to an
attribute, e.g. the SVGAnimatedLength 'ry' in an SVGRectElement, are live. This
means that any changes made to the attribute are immediately reflected in the
corresponding SVG DOM object." (see linked URL on bug report)

Until now only XML -> SVG DOM changes took affect, aka. changing the 'rx' attribute of a <rect>
element resuted in changes when accessing 'rx' through SVG DOM (rx.baseVal.value).

Add a new synchronization layer to handle SVG DOM -> XML changes.

4:10 AM Changeset in webkit [34912] by oliver@apple.com
  • 23 edits in trunk/WebCore

Class name changes for SVG Light Effect files.

Reviewed by Nikolas Zimmermann.

The class names that changed :

SVGLightSource -> LightSource
SVGDistantLightSource -> DistantLightSource
SVGPointLightSource -> PointLightSource
SVGSpotLightSource -> SpotLightSource

Every other file that is changed is just propagating the class name changes to
dependent files.

1:39 AM Changeset in webkit [34911] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-07-01 Alp Toker <alp@nuanti.com>

Rubber-stamped by Holger.

autotools cleanup: move some GTK+-specific sources from libwebcore to
libwebcoregtk.

  • GNUmakefile.am:
1:19 AM Changeset in webkit [34910] by mitz@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Oliver Hunt.

  • fix the non-SVG build
  • css/CSSValueKeywords.in: Added 'all'.
  • css/SVGCSSValueKeywords.in: Removed 'all'.
12:09 AM Changeset in webkit [34909] by ggaren@apple.com
  • 2 edits in trunk/WebKit/mac

2008-07-01 Geoffrey Garen <ggaren@apple.com>

Build fix: forgot to check in this file.

  • WebView/WebScriptDebugger.mm: (WebScriptDebugger::WebScriptDebugger):
12:07 AM Changeset in webkit [34908] by Simon Hausmann
  • 4 edits in trunk

Build fixes, include OwnPtr.h and DateInstance.h

12:01 AM Changeset in webkit [34907] by ggaren@apple.com
  • 6 edits in trunk/JavaScriptCore

2008-06-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.


Fixed a global object leak caused by the switch to one register file.


Don't unconditionally mark the register file, since that logically
makes all global variables GC roots, even when their global object is
no longer reachable.


Instead, make the global object associated with the register file
responsible for marking the register file.

Jun 30, 2008:

10:45 PM Changeset in webkit [34906] by ggaren@apple.com
  • 16 edits in trunk/JavaScriptCore

2008-06-30 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.


Removed the "registerBase" abstraction. Since the register file never
reallocates, we can keep direct pointers into it, instead of
<registerBase, offset> tuples.


SunSpider says 0.8% faster.

7:49 PM Changeset in webkit [34905] by adele@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2008-06-30 Adele Peterson <adele@apple.com>

Reviewed by Oliver.

Fix for <rdar://problem/5882050> clicking in hidden close box area of empty searchfield causes mousedown to stop firing

Test: fast/forms/search-hidden-cancel-button.html

  • html/HTMLTextFieldInnerElement.cpp: (WebCore::HTMLSearchFieldCancelButtonElement::defaultEventHandler): Don't start capturing mouse events if the cancel button isn't visible. This was causing the button to start but never stop capturing mouse events.

LayoutTests:

2008-06-30 Adele Peterson <adele@apple.com>

Reviewed by Oliver.

Test for <rdar://problem/5882050> clicking in hidden close box area of empty searchfield causes mousedown to stop firing

  • fast/forms/search-hidden-cancel-button-expected.txt: Added.
  • fast/forms/search-hidden-cancel-button.html: Added.
7:21 PM Changeset in webkit [34904] by oliver@apple.com
  • 11 edits in trunk/JavaScriptCore

Fix build by adding all (hopefully) the missing includes.

6:56 PM Changeset in webkit [34903] by cwzwarich@webkit.org
  • 3 edits
    3 adds in trunk

2008-06-30 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Bug 19830: REGRESSION (r34883): Google Reader doesn't show up feed list on sidebar
<https://bugs.webkit.org/show_bug.cgi?id=19830>

Ensure that we do not eliminate a write to a local register when doing
peephole optimizations.

JavaScriptCore:

  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitJumpIfTrue): (KJS::CodeGenerator::emitJumpIfFalse):

LayoutTests:

  • fast/js/codegen-peephole-locals-expected.txt: Added.
  • fast/js/codegen-peephole-locals.html: Added.
  • fast/js/resources/codegen-peephole-locals.js: Added.
6:18 PM Changeset in webkit [34902] by adele@apple.com
  • 1 edit in trunk/WebCore/dom/Node.cpp

Fixing * placement

6:11 PM Changeset in webkit [34901] by weinig@apple.com
  • 19 edits
    1 copy
    1 add in trunk

JavaScriptCore:

2008-06-30 Sam Weinig <sam@webkit.org>

Rubber-stamped by Darin Alder.

Split InternalFunction into its own header file.

  • API/JSCallbackFunction.h:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/ArrayConstructor.h:
  • kjs/BooleanConstructor.h:
  • kjs/DateConstructor.h:
  • kjs/ErrorConstructor.h:
  • kjs/FunctionConstructor.h:
  • kjs/FunctionPrototype.h:
  • kjs/InternalFunction.h: Copied from kjs/JSFunction.h.
  • kjs/JSFunction.h:
  • kjs/NativeErrorConstructor.h:
  • kjs/NumberConstructor.h:
  • kjs/ObjectConstructor.h:
  • kjs/RegExpConstructor.h:
  • kjs/StringConstructor.h:
  • profiler/Profiler.cpp:

WebCore:

2008-06-30 Sam Weinig <sam@webkit.org>

Rubber-stamped by Darin Adler.

Split InternalFunction into its own header file.

  • ForwardingHeaders/kjs/InternalFunction.h: Added.
  • bridge/runtime_method.h:
5:47 PM Changeset in webkit [34900] by adele@apple.com
  • 11 edits
    2 adds in trunk

WebCore:

2008-06-30 Adele Peterson <adele@apple.com>

Reviewed by Anders.

Fix for <rdar://problem/5301322> REGRESSION: Select All selects the whole page when used in readonly textareas

Test: editing/selection/select-all-textarea.html

  • dom/Node.cpp: (WebCore::Node::shadowAncestorNode): Break out code to find the root of the shadow tree into a new helper function. (WebCore::Node::shadowTreeRootNode): Added helper function.
  • dom/Node.h:
  • dom/Range.cpp: (WebCore::Range::shadowTreeRootNode): Added helper function.
  • dom/Range.h:
  • editing/Selection.cpp: (WebCore::Selection::shadowTreeRootNode): ditto.
  • editing/Selection.h:
  • editing/SelectionController.h: (WebCore::SelectionController::shadowTreeRootNode): ditto.
  • editing/SelectionController.cpp: (WebCore::SelectionController::selectAll): If the selection is in a shadow tree, only select the contents of that shadow tree, not the whole document.
  • page/Frame.cpp: (WebCore::Frame::findString): Use the new shadowTreeRootNode helper functions. (WebCore::Frame::markAllMatchesForText): ditto.

LayoutTests:

2008-06-30 Adele Peterson <adele@apple.com>

Reviewed by Anders.

Test for <rdar://problem/5301322> REGRESSION: Select All selects the whole page when used in readonly textareas

  • editing/selection/select-all-textarea-expected.txt: Added.
  • editing/selection/select-all-textarea.html: Added.
4:05 PM Changeset in webkit [34899] by Chris Fleizach
  • 12 edits
    4 adds in trunk

<rdar://problem/4180780> Add attribute to get all the radio buttons in a set

Adds ability for radio buttons to return an array of the other radio buttons in its radio group.
Updates DumpRenderTree to support the linked ui elements attribute

3:52 PM Changeset in webkit [34898] by weinig@apple.com
  • 5 edits
    4 deletes in trunk/JavaScriptCore

2008-06-30 Sam Weinig <sam@webkit.org>

Reviewed by Kevin McCullough.

Remove empty files Instruction.cpp, LabelID.cpp, Register.cpp and RegisterID.cpp.

  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • VM/Instruction.cpp: Removed.
  • VM/LabelID.cpp: Removed.
  • VM/Register.cpp: Removed.
  • VM/RegisterID.cpp: Removed.
3:43 PM Changeset in webkit [34897] by weinig@apple.com
  • 10 edits
    2 moves in trunk/JavaScriptCore

2008-06-30 Sam Weinig <sam@webkit.org>

Rubber-stamped (reluctantly) by Kevin McCullough.

Rename date_object.h/cpp to DateInstance.h/cpp

  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • kjs/AllInOneFile.cpp:
  • kjs/DateConstructor.cpp:
  • kjs/DateInstance.cpp: Copied from kjs/date_object.cpp.
  • kjs/DateInstance.h: Copied from kjs/date_object.h.
  • kjs/DatePrototype.cpp:
  • kjs/DatePrototype.h:
  • kjs/date_object.cpp: Removed.
  • kjs/date_object.h: Removed.
3:10 PM Changeset in webkit [34896] by mitz@apple.com
  • 7 edits in trunk

WebCore:

Reviewed by Adele Peterson.

  • WebCore part of <rdar://problem/3881497> Writing direction context menu item has no effect on text typed in Safari
  • WebCore.base.exp: Removed Editor::setBaseWritingDirection() and added Frame::setSelectionBaseWritingDirection().
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Changed to call Frame::setSelectionBaseWritingDirection().
  • page/Frame.cpp: (WebCore::Frame::setSelectionBaseWritingDirection): Added. If the focused node is a text field or text area, changes its 'dir' attribute. This is what IE does when the user changes the writing direction in a text control. Otherwise, calls down to Editor::setBaseWritingDirection().
  • page/Frame.h:

WebKit/mac:

Reviewed by Adele Peterson.

  • WebKit/mac part of <rdar://problem/3881497> Writing direction context menu item has no effect on text typed in Safari
  • WebView/WebHTMLView.mm: (-[WebHTMLView toggleBaseWritingDirection:]): Changed to call WebCore::Frame::setSelectionBaseWritingDirection() instead of WebCore::Editor::setBaseWritingDirection(). (-[WebHTMLView changeBaseWritingDirection:]): Ditto. (-[WebHTMLView _changeBaseWritingDirectionTo:]): Ditto.
2:12 PM Changeset in webkit [34895] by ddkilzer@apple.com
  • 4 edits in trunk/WebCore

Improve HTMLObjectElement data encapsulation

Reviewed by Dave Hyatt.

HTMLObjectElement has some public member variables that should be
private with accessor methods.

No test cases added since there is no change in behavior.

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::HTMLObjectElement): Reorder initialization of member variables to match defined order in header.
  • html/HTMLObjectElement.h: (WebCore::HTMLObjectElement::classId): Added. (WebCore::HTMLObjectElement::url): Added. (WebCore::HTMLObjectElement::serviceType): Added.
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): Use new accessor methods in HTMLObjectElement now that its member variables are private.
2:09 PM Changeset in webkit [34894] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Anders Carlsson.

  • remove unused member variable
  • page/Page.h: Removed Page::m_focusedNode.
1:52 PM Changeset in webkit [34893] by weinig@apple.com
  • 10 edits
    4 copies
    1 move in trunk/JavaScriptCore

2008-06-30 Sam Weinig <sam@webkit.org>

Rubber-stamped by Darin Adler.

Remove internal.cpp and move its contents to there own .cpp files.

  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • kjs/AllInOneFile.cpp:
  • kjs/GetterSetter.cpp: Copied from kjs/internal.cpp.
  • kjs/InternalFunction.cpp: Copied from kjs/internal.cpp.
  • kjs/JSNumberCell.cpp: Copied from kjs/internal.cpp.
  • kjs/JSString.cpp: Copied from kjs/internal.cpp.
  • kjs/JSString.h:
  • kjs/LabelStack.cpp: Copied from kjs/internal.cpp.
  • kjs/NumberConstructor.cpp:
  • kjs/NumberObject.cpp: (KJS::constructNumber): (KJS::constructNumberFromImmediateNumber):
  • kjs/internal.cpp: Removed.
10:00 AM Changeset in webkit [34892] by andersca@apple.com
  • 2 edits in trunk/WebCore

2008-06-30 Anders Carlsson <andersca@apple.com>

Reviewed by Adam.

<rdar://problem/6014209>
Crash when loading manifest from application cache fails


There is no need to set any handles to 0 after calling cacheUpdateFailed(), since
that is done inside the function. Furthermore, after calling cacheUpdateFailed() the cache
group could be deleted causing us to access freed memory and then crashing.


  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveResponse): (WebCore::ApplicationCacheGroup::didFail): (WebCore::ApplicationCacheGroup::didFailToLoadManifest):
8:58 AM Changeset in webkit [34891] by Adam Roben
  • 13 edits in trunk

Fix <rdar://5954749> Assertion failure due to HashTable's use of operator&

JavaScriptCore:

Fix <rdar://5954749> Assertion failure due to HashTable's use of
operator&

HashTable was passing &value to constructDeletedValue, which in
classes like WebCore::COMPtr would cause an assertion. We now pass
value by reference instead of by address so that the HashTraits
implementations have more flexibility in constructing the deleted
value.

Reviewed by Ada Chan.

  • VM/CodeGenerator.h: Updated for changes to HashTraits.
  • wtf/HashTable.h: (WTF::::deleteBucket): Changed to pass bucket by reference instead of by address. (WTF::::checkKey): Ditto.
  • wtf/HashTraits.h: (WTF::): Updated HashTraits for HashTable change.

WebCore:

Fix <rdar://5954749> Assertion failure due to HashTable's use of
operator&

Reviewed by Ada Chan.

  • bindings/js/JSSVGPODTypeWrapper.h:
  • dom/Document.h:
  • dom/StyledElement.cpp:
  • platform/graphics/FontCache.cpp:
  • platform/graphics/IntSizeHash.h: (WTF::):
  • platform/text/StringHash.h:
  • platform/win/COMPtr.h:
  • svg/SVGAnimatedTemplate.h: Updated all custom HashTraits for HashTable changes.
8:10 AM Changeset in webkit [34890] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

8:09 AM Changeset in webkit [34889] by mrowe@apple.com
  • 1 copy in tags/Safari-6527

New tag.

4:37 AM Changeset in webkit [34888] by Simon Hausmann
  • 1 edit
    14 deletes in trunk/WebKit/qt

2008-06-30 Simon Hausmann <Simon Hausmann>

Rubber-stamped by Niko.

Removed the obsolete and unmaintained WebKitPart. The integration of
QtWebKit into KDE is now done in the webkitkde component inside KDE.

4:28 AM Changeset in webkit [34887] by Nikolas Zimmermann
  • 113 edits in trunk/LayoutTests

Reviewed by Antti.

Fix all existing tests in svg/dynamic-updates to actually reflect repainting changes, by
removing the timing dependency. Instead model them like frame-getSVGDocument.html by
not including the <script src="js-test-post.js"> element within the TEMPLATE.html but
by dynamically injecting it, if the test actually finished.

4:21 AM Changeset in webkit [34886] by ap@webkit.org
  • 5 edits in trunk/JavaScriptCore

Reviewed by Cameron Zwarich.

Make RegisterFile really unmap memory on destruction.

This fixes run-webkit-tests --threaded, which ran out of address space in a few seconds.

  • VM/RegisterFile.cpp: (KJS::RegisterFile::~RegisterFile): Unmap all the memory, not just 1/4 of it.
  • kjs/JSGlobalObject.h: Don't include RegisterFile.h, so that changes to it don't make half of WebCore rebuild.
  • VM/Machine.h: Don't forward declare RegisterFile, as RegisterFile.h is included already.
  • VM/RegisterFile.h: (KJS::RegisterFile::RegisterFile): Assert that the allocation succeeded.
2:38 AM Changeset in webkit [34885] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-06-30 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Rubber-stamped by Oliver.

Correct the documentation for op_put_by_index.

  • VM/Machine.cpp: (KJS::Machine::privateExecute):
1:09 AM Changeset in webkit [34884] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-06-30 Simon Hausmann <Simon Hausmann>

Fix the Qt build.

Added missing includes and changed getItem array calls to use get()
instead.

Jun 29, 2008:

11:17 PM Changeset in webkit [34883] by cwzwarich@webkit.org
  • 6 edits in trunk/JavaScriptCore

2008-06-29 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Oliver.

Bug 19821: Merge the instruction pair (less, jfalse)
<https://bugs.webkit.org/show_bug.cgi?id=19821>

This is a 2.4% win on SunSpider. I needed to add an ALWAYS_INLINE
intrinisc to CodeGenerator::rewindBinaryOp() to avoid a massive
regression in regexp-dna.

  • VM/CodeBlock.cpp: (KJS::CodeBlock::dump):
  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::rewindBinaryOp): (KJS::CodeGenerator::emitJumpIfFalse):
  • VM/Machine.cpp: (KJS::Machine::privateExecute):
  • VM/Opcode.cpp: (KJS::):
  • VM/Opcode.h:
7:07 PM Changeset in webkit [34882] by dsmith@webkit.org
  • 2 edits in trunk/WebCore

2008-06-29 David Smith <catfish.man@gmail.com>

Rubberstamped by Sam Weinig.

Change a redundant node->isElement() check to an ASSERT for a 1.3% speedup on getElementsByTagName.

  • dom/TagNodeList.cpp: (WebCore::TagNodeList::nodeMatches):
6:41 PM Changeset in webkit [34881] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

  • fix SVG layout test regressions
  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule): Made this function work again with primitive values, because the @font-face rules SVG fonts create still use a single primitive value rather than a value list.
5:58 PM Changeset in webkit [34880] by mitz@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

2008-06-29 Dan Bernstein <mitz@apple.com>

  • add a missing file from the last check-in
  • fast/css/resources/font-face-descriptor-multiple-values-parsing.js: Added.
5:31 PM Changeset in webkit [34879] by mitz@apple.com
  • 5 edits
    6 adds in trunk

WebCore:

Reviewed by Sam Weinig.

  • fix <rdar://problem/5734440> Specifying a font-weight for @font-face not working

Tests: fast/css/font-face-descriptor-multiple-values-parsing.html

fast/css/font-face-descriptor-multiple-values.html

  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule): Changed to work with value lists for the descriptor properties.
  • css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): Initialize m_hasFontFaceOnlyValues. (WebCore::CSSParser::parseValue): Added a call to deleteFontFaceOnlyValues() if necessary. (WebCore::CSSParser::parseDeclaration): Ditto. (WebCore::CSSParser::clearProperties): Added code to reset m_hasFontFaceOnlyValues to false. (WebCore::CSSParser::parseFontStyle): Added. If there is a single valid identifier other than 'all', creates a CSSPrimitiveValue and assigns it to the property. If 'all' is the only value, or if there are multiple valid identifiers that are not 'all', creates a CSSValueList and assigns it to the property, and sets m_hasFontFaceOnlyValues to true. (WebCore::CSSParser::parseFontVariant): Ditto. (WebCore::CSSParser::parseFontWeight): Ditto. (WebCore::CSSParser::createStyleRule): Added a call to deleteFontFaceOnlyValues(). (WebCore::CSSParser::createFontFaceRule): Added code to change font descriptor properties that had only one value, and therefore were assigned a CSSPrimitiveValue, into CSSValueLists containing that value. (WebCore::CSSParser::deleteFontFaceOnlyValues): Added. Retroactively invalidates font descriptor properties that had values that are only allowed in @font-face. Those are identified by having CSSValueLists rather than CSSPrimitiveValues as their values.
  • css/CSSParser.h: Added m_hasFontFaceOnlyValues, a flag that says that font descriptor property values that are only valid in @font-face were encountered. This is used when the style declaration is created (and we finally know if it is @font-face or not) to delete invalid properties if needed.

LayoutTests:

Reviewed by Sam Weinig.

  • tests for <rdar://problem/5734440> Specifying a font-weight for @font-face not working
  • fast/css/font-face-descriptor-multiple-values-parsing-expected.txt: Added.
  • fast/css/font-face-descriptor-multiple-values-parsing.html: Added.
  • fast/css/font-face-descriptor-multiple-values.html: Added.
  • platform/mac/fast/css/font-face-descriptor-multiple-values-expected.checksum: Added.
  • platform/mac/fast/css/font-face-descriptor-multiple-values-expected.png: Added.
  • platform/mac/fast/css/font-face-descriptor-multiple-values-expected.txt: Added.
3:22 PM Changeset in webkit [34878] by weinig@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-06-29 Sam Weinig <sam@webkit.org>

Fix non-AllInOne builds.

  • kjs/JSObject.cpp:
  • kjs/JSValue.cpp:
3:18 PM Changeset in webkit [34877] by weinig@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-06-29 Sam Weinig <sam@webkit.org>

Build fix for Qt.

  • kjs/DateMath.cpp:
  • kjs/DatePrototype.cpp:
3:14 PM Changeset in webkit [34876] by weinig@apple.com
  • 20 edits
    8 copies
    2 moves in trunk/JavaScriptCore

2008-06-29 Sam Weinig <sam@webkit.org>

Rubber-stamped by Cameron Zwarich.

Splits ErrorConstructor, ErrorPrototype, NativeErrorConstructor and
NativeErrorPrototype out of error_object.h/cpp and renames it ErrorInstance.

  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • kjs/AllInOneFile.cpp:
  • kjs/ArrayConstructor.cpp:
  • kjs/ArrayPrototype.cpp:
  • kjs/BooleanPrototype.cpp:
  • kjs/DatePrototype.cpp:
  • kjs/ErrorConstructor.cpp: Copied from kjs/error_object.cpp.
  • kjs/ErrorConstructor.h: Copied from kjs/error_object.h.
  • kjs/ErrorInstance.cpp: Copied from kjs/error_object.cpp.
  • kjs/ErrorInstance.h: Copied from kjs/error_object.h.
  • kjs/ErrorPrototype.cpp: Copied from kjs/error_object.cpp.
  • kjs/ErrorPrototype.h: Copied from kjs/error_object.h.
  • kjs/JSGlobalObject.cpp:
  • kjs/JSObject.cpp:
  • kjs/JSValue.cpp:
  • kjs/NativeErrorConstructor.cpp: Copied from kjs/error_object.cpp.
  • kjs/NativeErrorConstructor.h: Copied from kjs/error_object.h.
  • kjs/NativeErrorPrototype.cpp: Copied from kjs/error_object.cpp.
  • kjs/NativeErrorPrototype.h: Copied from kjs/error_object.h.
  • kjs/NumberPrototype.cpp:
  • kjs/RegExpConstructor.cpp:
  • kjs/RegExpObject.cpp:
  • kjs/RegExpPrototype.cpp:
  • kjs/StringPrototype.cpp:
  • kjs/error_object.cpp: Removed.
  • kjs/error_object.h: Removed.
  • kjs/internal.cpp:
3:02 PM Changeset in webkit [34875] by jchaffraix@webkit.org
  • 9 edits
    5 adds in branches/XBL2/WebCore

2008-06-28 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Eric.

Add the <xbl> element. The hierarchy is inspired from svg:

  • XBLElement is the base class for all XBL elements.
  • XBLXBLElement represents the <xbl> element tag.
  • DerivedSources.make: Added build system information.
  • GNUmakefile.am: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/Document.cpp: (WebCore::Document::createElement): Create XBL elements if we are in XBL namespace.
  • dom/Node.h: (WebCore::Node::isXBLElement):
  • dom/make_names.pl:
  • page/Frame.cpp: (WebCore::Frame::Frame): Added XBLNames structures initialization.
  • xbl: Added.
  • xbl/XBLElement.h: Added. (WebCore::XBLElement::XBLElement): (WebCore::XBLElement::isXBLElement):
  • xbl/XBLXBLElement.cpp: Added.
  • xbl/XBLXBLElement.h: Added. (WebCore::XBLXBLElement::XBLXBLElement):
  • xbl/xbltags.in: Added.
1:25 PM Changeset in webkit [34874] by weinig@apple.com
  • 2 edits in trunk/WebKitTools

2008-06-29 Sam Weinig <sam@webkit.org>

Fix Tiger build.

  • DumpRenderTree/mac/EventSendingController.mm: (eventTypeForMouseButtonAndAction):
1:21 PM Changeset in webkit [34873] by weinig@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-06-29 Sam Weinig <sam@webkit.org>

Fix non-AllInOne build.

  • kjs/DateConstructor.cpp:
  • kjs/DateMath.cpp:
  • kjs/JSObject.cpp:
12:53 PM Changeset in webkit [34872] by weinig@apple.com
  • 15 edits
    4 copies in trunk/JavaScriptCore

2008-06-29 Sam Weinig <sam@webkit.org>

Rubber-stamped by Oliver Hunt.

Splits DateConstructor and DatePrototype out of date_object.h/cpp
Moves shared Date code into DateMath.

  • DerivedSources.make:
  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • kjs/AllInOneFile.cpp:
  • kjs/DateConstructor.cpp: Copied from kjs/date_object.cpp.
  • kjs/DateConstructor.h: Copied from kjs/date_object.h.
  • kjs/DateMath.cpp: (KJS::ymdhmsToSeconds): (KJS::): (KJS::skipSpacesAndComments): (KJS::findMonth): (KJS::parseDate): (KJS::timeClip): (KJS::formatDate): (KJS::formatDateUTCVariant): (KJS::formatTime):
  • kjs/DateMath.h: (KJS::gmtoffset):
  • kjs/DatePrototype.cpp: Copied from kjs/date_object.cpp.
  • kjs/DatePrototype.h: Copied from kjs/date_object.h.
  • kjs/JSGlobalObject.cpp:
  • kjs/JSObject.cpp:
  • kjs/date_object.cpp:
  • kjs/date_object.h:
  • kjs/internal.cpp:
12:24 PM Changeset in webkit [34871] by eric@webkit.org
  • 5 edits
    3 adds in trunk

Reviewed by darin.

Add multi-button mouseevent support to DRT
https://bugs.webkit.org/show_bug.cgi?id=15173

It's now possible to specify the mouse button with:
eventSender.mouseDown(1); eventSender.mouseUp(1); etc.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/mac/EventSendingController.h:
  • DumpRenderTree/mac/EventSendingController.mm: (+[EventSendingController isSelectorExcludedFromWebScript:]): (+[EventSendingController webScriptNameForSelector:]): (eventTypeForMouseButtonAndAction): (-[EventSendingController updateClickCountForButton:]): (-[EventSendingController mouseDown:]): (-[EventSendingController mouseUp:]): (-[EventSendingController mouseMoveToX:Y:]): (-[EventSendingController contextClick]):
1:19 AM Changeset in webkit [34870] by jmalonzo@webkit.org
  • 4 edits in trunk/JavaScriptCore

2008-06-29 Jan Michael Alonzo <jmalonzo@webkit.org>

Rubber-stamped by Cameron Zwarich

Fix Gtk non-AllInOne build

  • GNUmakefile.am: include JSVariableObject.cpp
  • kjs/RegExpConstructor.cpp: include RegExpObject.h
  • kjs/RegExpObject.h: forward declare RegExpPrototype

Jun 28, 2008:

10:56 PM Changeset in webkit [34869] by Darin Adler
  • 2 edits in trunk/WebKit/mac

2008-06-28 Darin Adler <Darin Adler>

  • fix build
  • WebView/WebView.mm: (aeDescFromJSValue): Use get instead of getItem, which no longer exists.
10:38 PM Changeset in webkit [34868] by Darin Adler
  • 8 edits
    3 adds in trunk

JavaScriptCore:

2008-06-28 Darin Adler <Darin Adler>

Reviewed by Sam and Cameron.

Test: fast/js/array-holes.html

  • kjs/ArrayPrototype.cpp: (KJS::arrayProtoFuncConcat): Changed to use getProperty instead of JSArray::getItem -- need to handle properties from the prototype chain instead of ignoring them.
  • kjs/JSArray.cpp: Removed getItem.
  • kjs/JSArray.h: Ditto.

WebCore:

2008-06-28 Darin Adler <Darin Adler>

Reviewed by Sam and Cameron.

  • bridge/jni/jni_utility.cpp: (KJS::Bindings::convertArrayInstanceToJavaArray): Use get instead of getItem, since we always want to consider values from the prototypes when looking at JavaScript arrays.

LayoutTests:

2008-06-28 Darin Adler <Darin Adler>

Reviewed by Sam and Cameron.

  • fast/js/array-holes-expected.txt: Added.
  • fast/js/array-holes.html: Added.
  • fast/js/resources/array-holes.js: Added.
8:56 PM Changeset in webkit [34867] by Darin Adler
  • 3 edits in trunk/JavaScriptCore

2008-06-28 Darin Adler <Darin Adler>

Reviewed by Cameron.

SunSpider says 1.8% faster.

  • kjs/JSArray.cpp: (KJS::JSArray::JSArray): Initialize m_fastAccessCutoff when creating arrays. Also updated for new location of m_vectorLength. (KJS::JSArray::getItem): Updated for new location of m_vectorLength. (KJS::JSArray::getSlowCase): Added. Broke out the non-hot parts of getOwnPropertySlot to make the hot part faster. (KJS::JSArray::getOwnPropertySlot): Added a new faster case for indices lower than m_fastAccessCutoff. We can do theese with no additional checks or branches. (KJS::JSArray::put): Added a new faster case for indices lower than m_fastAccessCutoff. We can do theese with no additional checks or branches. Moved the maxArrayIndex handling out of this function. Added code to set m_fastAccessCutoff when the very last hole in an array is filled; this is how the cutoff gets set for most arrays. (KJS::JSArray::putSlowCase): Moved the rest of the put function logic in here, to make the hot part of the put function faster. (KJS::JSArray::deleteProperty): Added code to lower m_fastAccessCutoff when a delete makes a new hole in the array. (KJS::JSArray::getPropertyNames): Updated for new location of m_vectorLength. (KJS::JSArray::increaseVectorLength): Ditto. (KJS::JSArray::setLength): Added code to lower m_fastAccessCutoff when setLength makes the array smaller. (KJS::JSArray::mark): Updated for new location of m_vectorLength. (KJS::JSArray::sort): Ditto. Set m_fastAccessCutoff after moving all the holes to the end of the array. (KJS::JSArray::compactForSorting): Ditto. (KJS::JSArray::checkConsistency): Added consistency checks fro m_fastAccessCutoff and updated for the new location of m_vectorLength.
  • kjs/JSArray.h: Added declarations for slow case functions. Replaced m_vectorLength with m_fastAccessCutoff.
7:33 PM Changeset in webkit [34866] by cwzwarich@webkit.org
  • 5 edits in trunk

2008-06-28 Cameron Zwarich <cwzwarich@uwaterloo.ca>

Reviewed by Sam.

When executing a native call, check for an exception before writing the
return value.

JavaScriptCore:

  • VM/Machine.cpp: (KJS::Machine::privateExecute):

LayoutTests:

  • fast/js/exception-sequencing-expected.txt:
  • fast/js/exception-sequencing.html:
7:21 PM Changeset in webkit [34865] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-06-28 Mark Rowe <mrowe@apple.com>

Build fix. Flag headers as private or public as is appropriate.
These settings were accidentally removed during some project file cleanup.

5:44 PM Changeset in webkit [34864] by mitz@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Darin Adler.

  • allow document markers to touch or overlap if they are not of the same type

Cannot be tested in DumpRenderTree

  • dom/Document.cpp: (WebCore::Document::addMarker):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintDocumentMarkers):
5:09 PM Changeset in webkit [34863] by weinig@apple.com
  • 14 edits
    4 copies in trunk/JavaScriptCore

2008-06-28 Sam Weinig <sam@webkit.org>

Rubber-stamped by Darin Adler.

Splits RegExpConstructor and RegExpPrototype out of RegExpObject.h/cpp

  • DerivedSources.make:
  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • VM/Machine.cpp:
  • kjs/AllInOneFile.cpp:
  • kjs/JSGlobalObject.cpp:
  • kjs/RegExpConstructor.cpp: Copied from kjs/RegExpObject.cpp.
  • kjs/RegExpConstructor.h: Copied from kjs/RegExpObject.h.
  • kjs/RegExpObject.cpp:
  • kjs/RegExpObject.h:
  • kjs/RegExpPrototype.cpp: Copied from kjs/RegExpObject.cpp.
  • kjs/RegExpPrototype.h: Copied from kjs/RegExpObject.h.
  • kjs/StringPrototype.cpp:
  • kjs/internal.cpp:
4:44 PM Changeset in webkit [34862] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-06-28 Sam Weinig <sam@webkit.org>

Fix non-AllInOne builds.

  • kjs/StringConstructor.cpp:
4:30 PM Changeset in webkit [34861] by weinig@apple.com
  • 12 edits
    5 copies
    3 moves
    2 adds in trunk

JavaScriptCore:

2008-06-28 Sam Weinig <sam@webkit.org>

Rubber-stamped by Darin Adler.

Rename string_object.h/cpp to StringObject.h/cpp and split out StringObjectThatMasqueradesAsUndefined,
StringConstructor and StringPrototype.

  • DerivedSources.make:
  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • kjs/AllInOneFile.cpp:
  • kjs/JSGlobalObject.cpp:
  • kjs/StringConstructor.cpp: Copied from JavaScriptCore/kjs/string_object.cpp.
  • kjs/StringConstructor.h: Copied from JavaScriptCore/kjs/string_object.h.
  • kjs/StringObject.cpp: Copied from JavaScriptCore/kjs/string_object.cpp.
  • kjs/StringObject.h: Copied from JavaScriptCore/kjs/string_object.h.
  • kjs/StringObjectThatMasqueradesAsUndefined.h: Copied from JavaScriptCore/kjs/string_object.h.
  • kjs/StringPrototype.cpp: Copied from JavaScriptCore/kjs/string_object.cpp.
  • kjs/StringPrototype.h: Copied from JavaScriptCore/kjs/string_object.h.
  • kjs/internal.cpp:
  • kjs/string_object.cpp: Removed.
  • kjs/string_object.h: Removed.

WebCore:

2008-06-28 Sam Weinig <sam@webkit.org>

Rubber-stamped by Darin Adler.

Update includes after remaming string_object.h to StringObject.h and
splitting out StringObjectThatMasqueradesAsUndefined, StringConstructor
and StringPrototype.

  • ForwardingHeaders/kjs/StringObject.h: Copied from WebCore/ForwardingHeaders/kjs/string_object.h.
  • ForwardingHeaders/kjs/StringObjectThatMasqueradesAsUndefined.h: Added.
  • ForwardingHeaders/kjs/StringPrototype.h: Added.
  • ForwardingHeaders/kjs/string_object.h: Removed.
  • bindings/js/JSCSSStyleDeclarationCustom.cpp:
3:57 PM Changeset in webkit [34860] by jmalonzo@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-06-28 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build fix: JSVariableObject is now part of AllInOne

  • GNUmakefile.am:
3:22 PM Changeset in webkit [34859] by jchaffraix@webkit.org
  • 17 edits in branches/XBL2/WebCore

2008-06-27 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Eric.

Change XBL legacy code's guard to ENABLE(DEPRECATED_XBL)
to enable compilation.

  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document):
  • dom/Document.h:
  • loader/Cache.cpp: (WebCore::createResource): (WebCore::Cache::getStatistics):
  • loader/Cache.h:
  • loader/CachedResource.h: (WebCore::CachedResource::):
  • loader/CachedResourceClient.h:
  • loader/CachedXBLDocument.cpp:
  • loader/CachedXBLDocument.h:
  • loader/DocLoader.cpp: (WebCore::DocLoader::requestResource):
  • loader/DocLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::addLowBandwidthDisplayRequest):
  • loader/loader.cpp: (WebCore::Loader::determinePriority):
  • rendering/style/RenderStyle.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::~StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==):
  • rendering/style/RenderStyle.h:
3:21 PM Changeset in webkit [34858] by Darin Adler
  • 8 edits in trunk/JavaScriptCore

2008-06-28 Darin Adler <Darin Adler>

Reviewed by Oliver.

  • pcre/pcre_compile.cpp: (jsRegExpCompile): Compile in the string if REGEXP_HISTOGRAM is on.
  • pcre/pcre_exec.cpp: (jsRegExpExecute): Add hook to time execution. (Histogram::~Histogram): Print a sorted list of what took time. (Histogram::add): Accumulate records of what took time. (HistogramTimeLogger::~HistogramTimeLogger): Hook that calls Histogram::add at the right moment and creates the global histogram object.
  • pcre/pcre_internal.h: Define REGEXP_HISTOGRAM.
  • pcre/pcre_tables.cpp: Added missing include of "config.h". Not needed any more, but an omissions an earlier version of this patch detected.
  • pcre/pcre_ucp_searchfuncs.cpp: Ditto.
  • pcre/pcre_xclass.cpp: Ditto.
2:54 PM Changeset in webkit [34857] by weinig@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-06-28 Sam Weinig <sam@webkit.org>

Try and fix the Windows build again.

  • kjs/RegExpObject.cpp:
  • kjs/date_object.cpp:
  • kjs/error_object.cpp:
2:45 PM Changeset in webkit [34856] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-06-28 Sam Weinig <sam@webkit.org>

Rubber-stamped by Darin Adler.

Remove unused StringConstructorFunction class.

  • kjs/string_object.h:
2:40 PM Changeset in webkit [34855] by weinig@apple.com
  • 14 edits in trunk/JavaScriptCore

2008-06-28 Sam Weinig <sam@webkit.org>

Fix windows build.

  • kjs/ArrayPrototype.cpp:
  • kjs/BooleanPrototype.cpp:
  • kjs/BooleanPrototype.h:
  • kjs/FunctionPrototype.cpp:
  • kjs/JSImmediate.cpp:
  • kjs/JSObject.cpp:
  • kjs/MathObject.cpp:
  • kjs/NumberPrototype.cpp:
  • kjs/NumberPrototype.h:
  • kjs/ObjectConstructor.cpp:
  • kjs/RegExpObject.h:
  • kjs/error_object.h:
  • kjs/string_object.cpp:
2:22 PM Changeset in webkit [34854] by weinig@apple.com
  • 32 edits
    8 copies
    3 moves
    1 add in trunk

JavaScriptCore:

2008-06-28 Sam Weinig <sam@webkit.org>

Rubber-stamped by Oliver Hunt.

Splits FunctionConstructor out of FunctionPrototype.h/cpp
Splits NumberConstructor and NumberPrototype out of NumberObject.h/cpp
Rename object_object.h/cpp to ObjectPrototype.h/cpp and split out ObjectConstructor.

  • API/JSCallbackConstructor.cpp:
  • API/JSClassRef.cpp:
  • API/JSObjectRef.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • VM/Machine.cpp:
  • kjs/AllInOneFile.cpp:
  • kjs/ArrayConstructor.cpp:
  • kjs/ArrayConstructor.h:
  • kjs/FunctionConstructor.cpp: Copied from JavaScriptCore/kjs/FunctionPrototype.cpp.
  • kjs/FunctionConstructor.h: Copied from JavaScriptCore/kjs/FunctionPrototype.h.
  • kjs/FunctionPrototype.cpp:
  • kjs/FunctionPrototype.h:
  • kjs/JSFunction.cpp:
  • kjs/JSGlobalObject.cpp:
  • kjs/JSImmediate.cpp:
  • kjs/MathObject.h:
  • kjs/NumberConstructor.cpp: Copied from JavaScriptCore/kjs/NumberObject.cpp.
  • kjs/NumberConstructor.h: Copied from JavaScriptCore/kjs/NumberObject.h.
  • kjs/NumberObject.cpp:
  • kjs/NumberObject.h:
  • kjs/NumberPrototype.cpp: Copied from JavaScriptCore/kjs/NumberObject.cpp.
  • kjs/NumberPrototype.h: Copied from JavaScriptCore/kjs/NumberObject.h.
  • kjs/ObjectConstructor.cpp: Copied from JavaScriptCore/kjs/object_object.cpp.
  • kjs/ObjectConstructor.h: Copied from JavaScriptCore/kjs/object_object.h.
  • kjs/ObjectPrototype.cpp: Copied from JavaScriptCore/kjs/object_object.cpp.
  • kjs/ObjectPrototype.h: Copied from JavaScriptCore/kjs/object_object.h.
  • kjs/RegExpObject.h:
  • kjs/Shell.cpp:
  • kjs/error_object.h:
  • kjs/internal.cpp:
  • kjs/nodes.cpp:
  • kjs/object_object.cpp: Removed.
  • kjs/object_object.h: Removed.
  • kjs/string_object.h:

WebCore:

2008-06-28 Sam Weinig <sam@webkit.org>

Rubber-stamped by Oliver Hunt.

Update includes after remaming object_object.h to ObjectPrototype.h and
splitting FunctionConstructor out of FunctionPrototype.h

  • ForwardingHeaders/kjs/FunctionConstructor.h: Added.
  • ForwardingHeaders/kjs/ObjectPrototype.h: Copied from WebCore/ForwardingHeaders/kjs/object_object.h.
  • ForwardingHeaders/kjs/object_object.h: Removed.
  • bindings/js/JSEventListener.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/qt/qt_instance.cpp:
2:11 PM Applications using WebKit edited by bug@insecti.com
new browser this year! (diff)
1:24 PM SquirrelFishPerfIdeas edited by erich@atlasocean.com
(diff)
10:49 AM Changeset in webkit [34853] by mitz@apple.com
  • 5 edits in trunk

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/5994621> REGRESSION (r31090-r31114): Weather widget shows missing image icons briefly when (re)loaded
  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::updateFromElement): Changed to not load an image if the 'src' attribute is the empty string and the document's base URI is a file: URL.

LayoutTests:

Reviewed by Darin Adler.

  • updated test and results for <rdar://problem/5994621> REGRESSION (r31090-r31114): Weather widget shows missing image icons briefly when (re)loaded
  • fast/images/load-img-with-empty-src-expected.txt:
  • fast/images/load-img-with-empty-src.html:
9:03 AM Changeset in webkit [34852] by Darin Adler
  • 4 edits in trunk/JavaScriptCore

2008-06-28 Darin Adler <Darin Adler>

Reviewed by Oliver.

SunSpider says 0.9% faster.

  • VM/CodeGenerator.h: (KJS::CodeGenerator::tempDestination): Create a new temporary for ignoredResult() too, just as we would for 0. (KJS::CodeGenerator::finalDestination): Use the temporary if the register passed in is ignoredResult() too, just as we would for 0. (KJS::CodeGenerator::destinationForAssignResult): Return 0 if the passed in register is ignoredResult(), just as we would for 0. (KJS::CodeGenerator::moveToDestinationIfNeeded): Return 0 if the register passed in is ignoredResult(). What matters is that we don't want to emit a move. The return value won't be looked at. (KJS::CodeGenerator::emitNode): Allow ignoredResult() and pass it through to the node's emitCode function.
  • VM/RegisterID.h: (KJS::ignoredResult): Added. Special value to indicate the result of a node will be ignored and need not be put in any register.
  • kjs/nodes.cpp: (KJS::NullNode::emitCode): Do nothing if dst == ignoredResult(). (KJS::BooleanNode::emitCode): Ditto. (KJS::NumberNode::emitCode): Ditto. (KJS::StringNode::emitCode): Ditto. (KJS::RegExpNode::emitCode): Ditto. (KJS::ThisNode::emitCode): Ditto. (KJS::ResolveNode::emitCode): Do nothing if dst == ignoredResult() and the identifier resolves to a local variable. (KJS::ObjectLiteralNode::emitCode): Do nothing if dst == ignoredResult() and the object is empty. (KJS::PostIncResolveNode::emitCode): If dst == ignoredResult(), then do nothing for the local constant case, and do a pre-increment in all the other cases. (KJS::PostDecResolveNode::emitCode): Ditto. (KJS::PostIncBracketNode::emitCode): Ditto. (KJS::PostDecBracketNode::emitCode): Ditto. (KJS::PostIncDotNode::emitCode): Ditto. (KJS::PostDecDotNode::emitCode): Ditto. (KJS::DeleteValueNode::emitCode): Pass ignoredResult() when evaluating the expression. (KJS::VoidNode::emitCode): Ditto. (KJS::TypeOfResolveNode::emitCode): If dst == ignoredResult(), do nothing if the identifier resolves to a local variable, and don't bother generating a typeof opcode in the other case. (KJS::TypeOfValueNode::emitCode): Ditto. (KJS::PreIncResolveNode::emitCode): Do nothing if dst == ignoredResult() and the identifier resolves to a local constant. (KJS::PreDecResolveNode::emitCode): Ditto. (KJS::AssignResolveNode::emitCode): Turn ignoredResult() into 0 in a couple places, because we need to put the result into a register so we can assign it. At other sites this is taken care of by functions like finalDestination. (KJS::CommaNode::emitCode): Pass ignoredResult() when evaluating the first expression. (KJS::ForNode::emitCode): Pass ignoredResult() when evaluating the first and third expressions. (KJS::ForInNode::emitCode): Pass ignoredResult() when evaluating the first expression.
8:50 AM Changeset in webkit [34851] by Darin Adler
  • 7 edits in trunk/JavaScriptCore

2008-06-28 Darin Adler <Darin Adler>

Reviewed by Oliver.

SunSpider says 0.8% faster.

  • VM/CodeBlock.cpp: (KJS::CodeBlock::dump): Added argv and argc parameters to new_array.
  • VM/Machine.cpp: (KJS::Machine::privateExecute): Ditto.
  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitNewArray): Added.
  • VM/CodeGenerator.h: Added ElementNode* argument to emitNewArray.
  • kjs/nodes.cpp: (KJS::ArrayNode::emitCode): Pass the ElementNode to emitNewArray so it can be initialized with as many elements as possible. If the array doesn't have any holes in it, that's all that's needed. If there are holes, then emit some separate put operations for the other values in the array and for the length as needed.
  • kjs/nodes.h: Added some accessors to ElementNode so the code generator can iterate through elements and generate code to evaluate them. Now ArrayNode does not need to be a friend. Also took out some unused PlacementNewAdoptType constructors.
8:33 AM Changeset in webkit [34850] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

2008-06-28 Darin Adler <Darin Adler>

Reviewed by Oliver Hunt.

  • kjs/nodes.h: Remove obsolete PlacementNewAdopt constructors. We no longer mutate the AST in place.
3:48 AM Changeset in webkit [34849] by jmalonzo@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-06-28 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Oliver Hunt.

Build fix

  • VM/Machine.cpp: include stdio.h
3:47 AM Changeset in webkit [34848] by Nikolas Zimmermann
  • 79 edits
    6 moves
    29 adds in trunk/LayoutTests

Reviewed by Oliver.

Update all (except four) SVG pixel tests, after a long time.
Four tests are broken in trunk, filed bugs 19798 & 19799.

Add all missing png/checksum files, and move files around which were misplaced.

3:23 AM Changeset in webkit [34847] by Nikolas Zimmermann
  • 2 edits in trunk/WebKitTools

Reviewed by Oliver.

Copy <test>-expected.png from the right location to /tmp/layout-test-results.
Use $expectedPixelDir instead of $expectedDir. Allows using SVG pixel tests again.

12:17 AM Changeset in webkit [34846] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Reviewed by Oliver Hunt.

  • make a test valid
  • fast/images/load-img-with-empty-src.html: Renamed the "status" variable to "results", because "status" is a Window property.

Jun 27, 2008:

11:09 PM Changeset in webkit [34845] by weinig@apple.com
  • 8 edits
    9 adds in trunk

WebCore:

2008-06-27 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

<rdar://problem/6025499> Make Cross-site XHR match the final specification

Update the implemented subset of Access-Control for XMLHttpRequest to the
latest version. (Editor's Draft 25 May 2008)

  • Now differentiates between simple and non-simple cross-site requests, the later requiring a preflight.
  • Now sends request headers cross-site, limited by a blacklist.
  • Now allows access to cross-site response headers, limited by a whitelist.
  • Now sends request entity body for non-get cross-site requests after preflight.

Tests: http/tests/xmlhttprequest/access-control-basic-blacklist-request-headers.html

http/tests/xmlhttprequest/access-control-basic-get-fail-non-simple.html
http/tests/xmlhttprequest/access-control-basic-whitelist-response-headers.html

  • xml/XMLHttpRequest.cpp: (WebCore::isOnAccessControllRequestHeaderBlackList): (WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): (WebCore::isOnAccessControlResponseHeaderWhitelist): (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::createRequest): (WebCore::XMLHttpRequest::makeSameOriginRequest): (WebCore::XMLHttpRequest::isSimpleCrossSiteAccessRequest): (WebCore::XMLHttpRequest::makeCrossSiteAccessRequest): (WebCore::XMLHttpRequest::makeSimpleCrossSiteAccessRequest): (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight): (WebCore::XMLHttpRequest::handleAsynchronousPreflightResult): (WebCore::XMLHttpRequest::loadRequestAsynchronously): (WebCore::XMLHttpRequest::abort): (WebCore::XMLHttpRequest::clearRequest): (WebCore::XMLHttpRequest::setRequestHeader): (WebCore::XMLHttpRequest::setRequestHeaderInternal): (WebCore::XMLHttpRequest::getAllResponseHeaders): (WebCore::XMLHttpRequest::getResponseHeader): (WebCore::XMLHttpRequest::didFinishLoading): (WebCore::XMLHttpRequest::didFinishLoadingPreflight): (WebCore::XMLHttpRequest::didReceiveResponse): (WebCore::XMLHttpRequest::didReceiveResponsePreflight): (WebCore::XMLHttpRequest::didReceiveData):
  • xml/XMLHttpRequest.h:

LayoutTests:

2008-06-27 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

<rdar://problem/6025499> Make Cross-site XHR match the final specification
Add tests for the updated implemented subset of Access-Control for XMLHttpRequest.

  • http/tests/xmlhttprequest/access-control-basic-blacklist-request-headers-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-basic-blacklist-request-headers.html: Added.
  • http/tests/xmlhttprequest/access-control-basic-get-fail-non-simple-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-basic-get-fail-non-simple.html: Added.
  • http/tests/xmlhttprequest/access-control-basic-not-get-allow-async-expected.txt:
  • http/tests/xmlhttprequest/access-control-basic-not-get-allow-expected.txt:
  • http/tests/xmlhttprequest/access-control-basic-whitelist-response-headers-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-basic-whitelist-response-headers.html: Added.
  • http/tests/xmlhttprequest/resources/access-control-basic-allow-print-headers.cgi: Added.
  • http/tests/xmlhttprequest/resources/access-control-basic-get-fail-non-simple.cgi: Added.
  • http/tests/xmlhttprequest/resources/access-control-basic-whitelist-response-headers.cgi: Added.
  • http/tests/xmlhttprequest/set-dangerous-headers-expected.txt:
10:20 PM Changeset in webkit [34844] by weinig@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-06-27 Sam Weinig <sam@webkit.org>

Reviewed by Oliver Hunt.

Fix platforms that don't use AllInOne.cpp

  • kjs/BooleanConstructor.h:
  • kjs/BooleanPrototype.h:
  • kjs/FunctionPrototype.cpp:
9:29 PM Changeset in webkit [34843] by weinig@apple.com
  • 21 edits
    6 copies in trunk/JavaScriptCore

2008-06-27 Sam Weinig <sam@webkit.org>

Rubber-stamped by Oliver Hunt.

Splits ArrayConstructor out of ArrayPrototype.h/cpp
Splits BooleanConstructor and BooleanPrototype out of BooleanObject.h/cpp

  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • VM/Machine.cpp:
  • kjs/AllInOneFile.cpp:
  • kjs/ArrayConstructor.cpp: Copied from kjs/ArrayPrototype.cpp.
  • kjs/ArrayConstructor.h: Copied from kjs/ArrayPrototype.h.
  • kjs/ArrayPrototype.cpp:
  • kjs/ArrayPrototype.h:
  • kjs/BooleanConstructor.cpp: Copied from kjs/BooleanObject.cpp.
  • kjs/BooleanConstructor.h: Copied from kjs/BooleanObject.h.
  • kjs/BooleanObject.cpp:
  • kjs/BooleanObject.h:
  • kjs/BooleanPrototype.cpp: Copied from kjs/BooleanObject.cpp.
  • kjs/BooleanPrototype.h: Copied from kjs/BooleanObject.h.
  • kjs/CommonIdentifiers.h:
  • kjs/FunctionPrototype.cpp:
  • kjs/JSArray.cpp:
  • kjs/JSGlobalObject.cpp:
  • kjs/JSImmediate.cpp:
  • kjs/Shell.cpp:
  • kjs/internal.cpp:
  • kjs/nodes.cpp:
  • kjs/string_object.cpp:
9:02 PM Changeset in webkit [34842] by oliver@apple.com
  • 15 edits in trunk/JavaScriptCore

Bug 18626: SQUIRRELFISH: support the "slow script" dialog <https://bugs.webkit.org/show_bug.cgi?id=18626>
<rdar://problem/5973931> Slow script dialog needs to be reimplemented for squirrelfish

Reviewed by Sam

Adds support for the slow script dialog in squirrelfish. This requires the addition
of three new op codes, op_loop, op_loop_if_true, and op_loop_if_less which have the
same behaviour as their simple jump equivalents but have an additional time out check.

Additional assertions were added to other jump instructions to prevent accidentally
creating loops with jump types that do not support time out checks.

Sunspider does not report a regression, however this appears very sensitive to code
layout and hardware, so i would expect up to a 1% regression on other systems.

Part of this required moving the old timeout logic from JSGlobalObject and into Machine
which is the cause of a number of the larger diff blocks.

7:54 PM Changeset in webkit [34841] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-06-27 Sam Weinig <sam@webkit.org>

Rubber-stamped by Mark Rowe.

Clean up sorting in WebCore.xcodeproj.

  • WebCore.xcodeproj/project.pbxproj:
5:24 PM Changeset in webkit [34840] by jmalonzo@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-06-27 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk and Qt build fix: Remove RegisterFileStack from the build
scripts.

4:31 PM Changeset in webkit [34839] by adele@apple.com
  • 5 edits in trunk/JavaScriptCore

2008-06-27 Adele Peterson <adele@apple.com>

Reviewed by Geoff.

Build fixes.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • VM/RegisterFile.h: (KJS::RegisterFile::RegisterFile):
  • kjs/JSGlobalObject.cpp:
  • kjs/collector.cpp:
3:35 PM Changeset in webkit [34838] by ggaren@apple.com
  • 30 edits
    2 adds
    2 deletes in trunk

JavaScriptCore:

2008-06-27 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.


One RegisterFile to rule them all!


SunSpider reports a 0.2% speedup.

This patch removes the RegisterFileStack abstraction and replaces it with
a single register file that


(a) allocates a fixed storage area, including a fixed area for global
vars, so that no operation may cause the register file to reallocate


and

(b) swaps between global storage areas when executing code in different
global objects.


This patch also changes the layout of the register file so that all call
frames, including call frames for global code, get a header. This is
required to support re-entrant global code. It also just makes things simpler.


  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::addGlobalVar): New function. Differs from addVar in that


(a) global vars don't contribute to a CodeBlock's numLocals count, since
global storage is fixed and allocated at startup


and


(b) references to global vars get shifted to elide intermediate stack
between "r" and the global storage area.


  • VM/Machine.cpp: (KJS::Machine::dumpRegisters): Updated this function to match the new register file layout, and added the ability to dump exact identifiers for the different parts of a call frame.


(KJS::Machine::unwindCallFrame): Updated this function to match the new
register file layout.


(KJS::Machine::execute): Updated this function to initialize a call frame
header for global code, and to swap global storage areas when switching
to execution in a new global object.


(KJS::Machine::privateExecute): Got rid of "safeForReentry" and re-reading
of registerBase because the register file is always safe for reentry now,
and registerBase never changes.


  • VM/Machine.h: Moved the call frame header enum from Machine to RegisterFile, to resolve a header dependency problem (a good sign that the enum belonged in RegisterFile all along!)
  • VM/RegisterFile.cpp:
  • VM/RegisterFile.h: Changed RegisterFile to mmap a fixed size register area. This allows us to avoid re-allocting the register file later on. Instead, we rely on the OS to allocate physical pages to the register file as necessary.
  • VM/RegisterFileStack.cpp: Removed. Tada!
  • VM/RegisterFileStack.h: Removed. Tada!
  • kjs/DebuggerCallFrame.cpp: Updated this class to match the new register file layout, greatly simplifying it in the process.
  • kjs/JSActivation.h:
  • kjs/JSActivation.cpp: Moved some of this logic up to JSVariableObject, since the global object now needs to be able to tear off its registers just like the activation object.
  • kjs/JSFunction.cpp: No need to fiddle with the register file anymore.
  • kjs/JSGlobalObject.h:
  • kjs/JSGlobalObject.cpp: Updated JSGlobalObject to support moving its global storage area into and out of the register file.
  • kjs/PropertySlot.cpp: No need to fiddle with the register file anymore.
  • kjs/collector.cpp: Renamed markStackObjectConservatively to markConservatively, since we don't just mark stack objects this way.


Also, added code to mark the machine's register file.

  • kjs/config.h: Moved some platforms #defines from here...
  • wtf/Platform.h: ...to here, to support mmap/VirtualAlloc detection in RegisterFile.h.

LayoutTests:

2008-06-26 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.


Added a test for what happens when a script exceeds the limit on declared
global variables.

  • fast/js/global-var-limit-expected.txt: Added.
  • fast/js/global-var-limit.html: Added.
  • fast/js/global-recursion-on-full-stack-expected.txt: Updated for new (slightly more correct) behavior. Since the stack overflow happens in the middle of a try/catch block, it should be caught, instead of logged to the console.
3:24 PM Changeset in webkit [34837] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKitTools

2008-06-27 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Christian Dywan.

[Gtk] Initialize webview settings before running DRT tests
http://bugs.webkit.org/show_bug.cgi?id=19778

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (setDefaultsToConsistentStateValuesForTesting): (main):
3:24 PM Changeset in webkit [34836] by jmalonzo@webkit.org
  • 3 edits in trunk/WebCore

2008-06-27 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Darin Adler.

Remove unnecessary options to make_names.pl command line
http://bugs.webkit.org/show_bug.cgi?id=19777

  • DerivedSources.make:
  • GNUmakefile.am:
2:08 PM Changeset in webkit [34835] by mitz@apple.com
  • 4 edits in trunk

PlanetWebKit:

Reviewed by Timothy Hatcher.

  • wwwroot/planetwebkit.css: Reduced text shadow offsets.

WebKitSite:

Reviewed by Timothy Hatcher.

  • css/main.css: Reduced text shadow offsets.
1:35 PM Changeset in webkit [34834] by Adam Roben
  • 3 edits in trunk/WebKit/win

Change WebKitGraphics truncation functions to return the length of the truncated string

Reviewed by Darin Adler.

  • WebKitGraphics.cpp: (CenterTruncateStringToWidth): (RightTruncateStringToWidth): Return the length.
  • WebKitGraphics.h: The truncation functions now return an unsigned int that is the length of the truncated string. The whole file has been marked extern "C" to keep the symbols for these functions from changing (which would break nightly builds).
11:11 AM Changeset in webkit [34833] by abarth@webkit.org
  • 4 edits in trunk/LayoutTests/platform/mac/fast/parser

Fix mime-types. Not sure how to do this with git.

11:09 AM Changeset in webkit [34832] by abarth@webkit.org
  • 3 edits
    10 adds in trunk

WebCore:

2008-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=19784

Properly handle untermianted <!-- comments in <textarea>s.

Tests: fast/parser/open-comment-in-script-tricky.html

fast/parser/open-comment-in-style.html
fast/parser/open-comment-in-textarea.html

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::finish):

LayoutTests:

2008-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Test our handling of unterminated <!-- comments in various special
parsing contexts. This change does not test our handling of
unterminated comments in <title> or <iframe> because I'm unsure whether
our behaviour is correct.

  • fast/parser/open-comment-in-script-tricky-expected.txt: Added.
  • fast/parser/open-comment-in-script-tricky.html: Added.
  • fast/parser/open-comment-in-style.html: Added.
  • fast/parser/open-comment-in-textarea.html: Added.
  • platform/mac/fast/parser/open-comment-in-style-expected.checksum: Added.
  • platform/mac/fast/parser/open-comment-in-style-expected.png: Added.
  • platform/mac/fast/parser/open-comment-in-style-expected.txt: Added.
  • platform/mac/fast/parser/open-comment-in-textarea-expected.checksum: Added.
  • platform/mac/fast/parser/open-comment-in-textarea-expected.png: Added.
  • platform/mac/fast/parser/open-comment-in-textarea-expected.txt: Added.
11:09 AM Changeset in webkit [34831] by abarth@webkit.org
  • 3 edits
    16 adds in trunk

WebCore:

2008-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

Fix <https://bugs.webkit.org/show_bug.cgi?id=19784>:

Text areas in Wikipedia edit pages are empty, following content is missing

Don't treat entities as comment starters in parseSpecial.

Tests: fast/parser/comment-in-iframe.html

fast/parser/entity-comment-in-iframe.html
fast/parser/entity-comment-in-script-tricky.html
fast/parser/entity-comment-in-style.html
fast/parser/entity-comment-in-textarea.html
fast/parser/entity-comment-in-title.html

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial):

LayoutTests:

2008-06-27 Adam Barth <abarth@webkit.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=19784

Test that entities are not used to start comments.

  • fast/parser/comment-in-iframe-expected.txt: Added.
  • fast/parser/comment-in-iframe.html: Added.
  • fast/parser/entity-comment-in-iframe-expected.txt: Added.
  • fast/parser/entity-comment-in-iframe.html: Added.
  • fast/parser/entity-comment-in-script-tricky-expected.txt: Added.
  • fast/parser/entity-comment-in-script-tricky.html: Added.
  • fast/parser/entity-comment-in-style.html: Added.
  • fast/parser/entity-comment-in-textarea.html: Added.
  • fast/parser/entity-comment-in-title-expected.txt: Added.
  • fast/parser/entity-comment-in-title.html: Added.
  • platform/mac/fast/parser/entity-comment-in-style-expected.checksum: Added.
  • platform/mac/fast/parser/entity-comment-in-style-expected.png: Added.
  • platform/mac/fast/parser/entity-comment-in-style-expected.txt: Added.
  • platform/mac/fast/parser/entity-comment-in-textarea-expected.checksum: Added.
  • platform/mac/fast/parser/entity-comment-in-textarea-expected.png: Added.
  • platform/mac/fast/parser/entity-comment-in-textarea-expected.txt: Added.
7:32 AM Changeset in webkit [34830] by jchaffraix@webkit.org
  • 7 edits in branches/XBL2

2008-06-27 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Eric.

Add build-webkit --xbl option.

  • configure.ac: Add XBL checks.

WebCore:

2008-06-27 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Eric.

Add build-webkit --xbl option.

  • GNUmakefile.am: Add XBL compilation flags and legacy files.
  • WebCore.pro: Ditto.

WebKitTools:

2008-06-27 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Eric.

Add build-webkit --xbl option.

  • Scripts/build-webkit: Add the option and the build systems' bit.
5:40 AM Changeset in webkit [34829] by Antti Koivisto
  • 3 edits
    2 adds in trunk

WebCore:

2008-06-27 Antti Koivisto <Antti Koivisto>

Reviewed by Oliver.


<rdar://problem/6030720>
REGRESSION: Discrete animation between incompatible paths does not work

Fall back to discrete path animation if paths are not suitable for morphing.


Test: svg/custom/animate-path-discrete.svg


  • svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::calculateAnimatedValue):

LayoutTests:

2008-06-27 Antti Koivisto <Antti Koivisto>

Reviewed by Oliver.


<rdar://problem/6030720>
REGRESSION: Discrete animation between incompatible paths does not work

  • svg/custom/animate-path-discrete.svg: Added.
  • platform/mac/svg/custom/animate-path-discrete-expected.txt: Added.
5:26 AM Changeset in webkit [34828] by jchaffraix@webkit.org
  • 1 copy in branches/XBL2

Create XBL2 branch.

12:00 AM Changeset in webkit [34827] by Darin Adler
  • 2 edits in trunk/WebKitTools

2008-06-26 Darin Adler <Darin Adler>

  • Scripts/check-for-weak-vtables: Fixed comment.
Note: See TracTimeline for information about the timeline view.