Timeline


and

10/14/08:

22:22 Changeset [37601] by darin@chromium.org

2008-10-09 Darin Fisher <darin@chromium.org>

Reviewed by Sam Weinig.

Make pan scrolling a platform configurable option
https://bugs.webkit.org/show_bug.cgi?id=21515

  • page/EventHandler.cpp: (WebCore::EventHandler::handleAutoscroll): (WebCore::EventHandler::autoscrollTimerFired): (WebCore::EventHandler::stopAutoscrollTimer): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::keyEvent):
22:21 Changeset [37600] by darin@chromium.org

2008-10-09 Darin Fisher <darin@chromium.org>

Reviewed by Sam Weinig.

Make pan scrolling a platform configurable option.
https://bugs.webkit.org/show_bug.cgi?id=21515

  • wtf/Platform.h: Add ENABLE_PAN_SCROLLING
22:15 Changeset [37599] by darin@chromium.org

2008-10-10 Darin Fisher <darin@chromium.org>

Reviewed by Darin Adler.

Add some PLATFORM(CHROMIUM) ifdefs to WebCore
https://bugs.webkit.org/show_bug.cgi?id=21511

  • loader/FTPDirectoryDocument.cpp:
  • loader/FTPDirectoryParser.cpp:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedLoadingDocument):
  • platform/ContextMenuItem.h:
  • platform/Cursor.h:
  • platform/DragData.h:
  • platform/DragImage.h:
  • platform/Pasteboard.h:
  • platform/PlatformKeyboardEvent.h: (WebCore::PlatformKeyboardEvent::isSystemKey):
  • platform/PlatformMenuDescription.h:
  • platform/PlatformMouseEvent.h:
  • platform/PlatformWheelEvent.h:
  • platform/PopupMenu.h:
  • platform/ScrollView.h:
  • platform/Widget.h:
  • platform/network/NetworkStateNotifier.h:
20:41 Changeset [37598] by timothy@apple.com

Make the user agent generation method a class method and cache the WebKit
version in a static to prevent generating it every time. This is needed
clean up to fix <rdar://problem/6292331>. Moved all code to WebPrivate so
the class method can be in the WebViewPrivate.h header.

Reviewed by John Sullivan.

  • WebView/WebView.mm: (callGestalt): Moved. Same code. (createMacOSXVersionString): Moved. Same code. (createUserVisibleWebKitVersionString): Moved from _userVisibleBundleVersionFromFullVersion: and returns a copied string. (+[WebView _standardUserAgentWithApplicationName:andWebKitVersion:]): Made into a class method. (-[WebView WebCore::_userAgentForURL:]): Changed to cache the WebKit version.
  • WebView/WebViewPrivate.h: Added +_standardUserAgentWithApplicationName:andWebKitVersion:.
19:39 Changeset [37597] by mjs@apple.com

2008-10-14 Maciej Stachowiak <mjs@apple.com>

Rubber stamped by Sam Weinig.



Turns out GCC 4.2 is still a (small) regression, we'll have to do
more work to turn it on.

  • Configurations/DebugRelease.xcconfig:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • VM/CTI.cpp:
  • VM/CTI.h:
  • VM/Machine.cpp: (JSC::Machine::cti_op_convert_this): (JSC::Machine::cti_op_end): (JSC::Machine::cti_op_add): (JSC::Machine::cti_op_pre_inc): (JSC::Machine::cti_timeout_check): (JSC::Machine::cti_register_file_check): (JSC::Machine::cti_op_loop_if_less): (JSC::Machine::cti_op_loop_if_lesseq): (JSC::Machine::cti_op_new_object): (JSC::Machine::cti_op_put_by_id): (JSC::Machine::cti_op_put_by_id_second): (JSC::Machine::cti_op_put_by_id_generic): (JSC::Machine::cti_op_put_by_id_fail): (JSC::Machine::cti_op_get_by_id): (JSC::Machine::cti_op_get_by_id_second): (JSC::Machine::cti_op_get_by_id_generic): (JSC::Machine::cti_op_get_by_id_fail): (JSC::Machine::cti_op_instanceof): (JSC::Machine::cti_op_del_by_id): (JSC::Machine::cti_op_mul): (JSC::Machine::cti_op_new_func): (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_vm_compile): (JSC::Machine::cti_op_push_activation): (JSC::Machine::cti_op_call_NotJSFunction): (JSC::Machine::cti_op_create_arguments): (JSC::Machine::cti_op_tear_off_activation): (JSC::Machine::cti_op_tear_off_arguments): (JSC::Machine::cti_op_ret_profiler): (JSC::Machine::cti_op_ret_scopeChain): (JSC::Machine::cti_op_new_array): (JSC::Machine::cti_op_resolve): (JSC::Machine::cti_op_construct_JSConstruct): (JSC::Machine::cti_op_construct_NotJSConstruct): (JSC::Machine::cti_op_get_by_val): (JSC::Machine::cti_op_resolve_func): (JSC::Machine::cti_op_sub): (JSC::Machine::cti_op_put_by_val): (JSC::Machine::cti_op_put_by_val_array): (JSC::Machine::cti_op_lesseq): (JSC::Machine::cti_op_loop_if_true): (JSC::Machine::cti_op_negate): (JSC::Machine::cti_op_resolve_base): (JSC::Machine::cti_op_resolve_skip): (JSC::Machine::cti_op_resolve_global): (JSC::Machine::cti_op_div): (JSC::Machine::cti_op_pre_dec): (JSC::Machine::cti_op_jless): (JSC::Machine::cti_op_not): (JSC::Machine::cti_op_jtrue): (JSC::Machine::cti_op_post_inc): (JSC::Machine::cti_op_eq): (JSC::Machine::cti_op_lshift): (JSC::Machine::cti_op_bitand): (JSC::Machine::cti_op_rshift): (JSC::Machine::cti_op_bitnot): (JSC::Machine::cti_op_resolve_with_base): (JSC::Machine::cti_op_new_func_exp): (JSC::Machine::cti_op_mod): (JSC::Machine::cti_op_less): (JSC::Machine::cti_op_neq): (JSC::Machine::cti_op_post_dec): (JSC::Machine::cti_op_urshift): (JSC::Machine::cti_op_bitxor): (JSC::Machine::cti_op_new_regexp): (JSC::Machine::cti_op_bitor): (JSC::Machine::cti_op_call_eval): (JSC::Machine::cti_op_throw): (JSC::Machine::cti_op_get_pnames): (JSC::Machine::cti_op_next_pname): (JSC::Machine::cti_op_push_scope): (JSC::Machine::cti_op_pop_scope): (JSC::Machine::cti_op_typeof): (JSC::Machine::cti_op_is_undefined): (JSC::Machine::cti_op_is_boolean): (JSC::Machine::cti_op_is_number): (JSC::Machine::cti_op_is_string): (JSC::Machine::cti_op_is_object): (JSC::Machine::cti_op_is_function): (JSC::Machine::cti_op_stricteq): (JSC::Machine::cti_op_nstricteq): (JSC::Machine::cti_op_to_jsnumber): (JSC::Machine::cti_op_in): (JSC::Machine::cti_op_push_new_scope): (JSC::Machine::cti_op_jmp_scopes): (JSC::Machine::cti_op_put_by_index): (JSC::Machine::cti_op_switch_imm): (JSC::Machine::cti_op_switch_char): (JSC::Machine::cti_op_switch_string): (JSC::Machine::cti_op_del_by_val): (JSC::Machine::cti_op_put_getter): (JSC::Machine::cti_op_put_setter): (JSC::Machine::cti_op_new_error): (JSC::Machine::cti_op_debug): (JSC::Machine::cti_vm_throw):
  • VM/Machine.h:
  • masm/X86Assembler.h: (JSC::X86Assembler::emitRestoreArgumentReference): (JSC::X86Assembler::emitRestoreArgumentReferenceForTrampoline):
  • wtf/Platform.h:
17:23 Changeset [37596] by sfalken@apple.com

Build fix. Fix dependency chain in sln file.

15:43 Changeset [37595] by pam@chromium.org

2008-10-14 Pamela Greene <pam@chromium.org>

Add test to verify popup properties while they're opening.
The expected result is currently not the desired result.
See https://bugs.webkit.org/show_bug.cgi?id=21419 and
https://bugs.webkit.org/show_bug.cgi?id=21597 .

Reviewed by Eric Seidel.

  • fast/dom/Window/window-open-pending-url-expected.txt: Added.
  • fast/dom/Window/window-open-pending-url.html: Added.
15:16 Changeset [37594] by adachan@apple.com

Fix windows build.

Reviewed by Sam Weinig.

  • DumpRenderTree/cg/PixelDumpSupportCG.cpp:
  • DumpRenderTree/config.h:
  • DumpRenderTree/win/DumpRenderTreeWin.h:
  • DumpRenderTree/win/LayoutTestControllerWin.cpp:
  • DumpRenderTree/win/UIDelegate.cpp:
15:11 Changeset [37593] by aroben@apple.com

Fix Bug 21602: Bugzilla times out trying to display formatted diff for attachment 24345

https://bugs.webkit.org/show_bug.cgi?id=21602

Reviewed by Dave Kilzer.

  • PrettyPatch/PrettyPatch.rb: (PrettyPatch.BINARY_FILE_MARKER_FORMAT): Added. (PrettyPatch.FileDiff.initialize): If any of the lines in the diff are a binary file marker, mark this FileDiff as binary and stop trying to process the lines. (PrettyDiff.FileDiff.to_html): If we're binary, just print a string saying so.
14:31 Changeset [37592] by cmarrin@apple.com

2008-10-14 Chris Marrin <cmarrin@apple.com>

Reviewed by Darin Adler.

Fixed https://bugs.webkit.org/show_bug.cgi?id=21490
Optimize keyframe style sheet changes by avoiding styleSheetChanged()

Test: css3/change-keyframes.html

  • css/WebKitCSSKeyframesRule.cpp: (WebCore::WebKitCSSKeyframesRule::append): (WebCore::WebKitCSSKeyframesRule::deleteRule):
13:35 Changeset [37591] by hyatt@apple.com

WebCore:

2008-10-14 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21595

Clean up background and overflow propagation from the body to the viewport. Make it match the
latest CSS2.1 spec thinking.

Reviewed by Adam Roben

Added many tests at fast/body-propagation/. These are Simon Pieters' tests of propagation handling
(available at http://simon.html5.org/test/css/magic-body/).

  • dom/Document.cpp: (WebCore::Document::body):
  • page/FrameView.cpp: (WebCore::FrameView::layout):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::styleDidChange): (WebCore::RenderBox::paintRootBoxDecorations): (WebCore::RenderBox::paintBoxDecorations): (WebCore::RenderBox::repaintLayerRectsForImage):

LayoutTests:

2008-10-14 David Hyatt <hyatt@apple.com>

Add layout tests for body propagation of overflow and background to the viewport.

Reviewed by Adam Roben

  • fast/body-propagation: Added.
  • fast/body-propagation/background-color: Added.
  • fast/body-propagation/background-color/001-xhtml.xhtml: Added.
  • fast/body-propagation/background-color/001.html: Added.
  • fast/body-propagation/background-color/002-xhtml.xhtml: Added.
  • fast/body-propagation/background-color/002.html: Added.
  • fast/body-propagation/background-color/003-declarative.xhtml: Added.
  • fast/body-propagation/background-color/003-xhtml.xhtml: Added.
  • fast/body-propagation/background-color/003.html: Added.
  • fast/body-propagation/background-color/004-declarative.xhtml: Added.
  • fast/body-propagation/background-color/004-xhtml.xhtml: Added.
  • fast/body-propagation/background-color/004.html: Added.
  • fast/body-propagation/background-color/005-declarative.xhtml: Added.
  • fast/body-propagation/background-color/005-xhtml.xhtml: Added.
  • fast/body-propagation/background-color/005.html: Added.
  • fast/body-propagation/background-color/006-declarative.xhtml: Added.
  • fast/body-propagation/background-color/006-xhtml.xhtml: Added.
  • fast/body-propagation/background-color/006.html: Added.
  • fast/body-propagation/background-color/007-declarative.xhtml: Added.
  • fast/body-propagation/background-color/007-xhtml.xhtml: Added.
  • fast/body-propagation/background-color/007.html: Added.
  • fast/body-propagation/background-color/008-xhtml.xhtml: Added.
  • fast/body-propagation/background-color/008.html: Added.
  • fast/body-propagation/background-image: Added.
  • fast/body-propagation/background-image/001-xhtml.xhtml: Added.
  • fast/body-propagation/background-image/001.html: Added.
  • fast/body-propagation/background-image/002-xhtml.xhtml: Added.
  • fast/body-propagation/background-image/002.html: Added.
  • fast/body-propagation/background-image/003-declarative.xhtml: Added.
  • fast/body-propagation/background-image/003-xhtml.xhtml: Added.
  • fast/body-propagation/background-image/003.html: Added.
  • fast/body-propagation/background-image/004-declarative.xhtml: Added.
  • fast/body-propagation/background-image/004-xhtml.xhtml: Added.
  • fast/body-propagation/background-image/004.html: Added.
  • fast/body-propagation/background-image/005-declarative.xhtml: Added.
  • fast/body-propagation/background-image/005-xhtml.xhtml: Added.
  • fast/body-propagation/background-image/005.html: Added.
  • fast/body-propagation/background-image/006-declarative.xhtml: Added.
  • fast/body-propagation/background-image/006-xhtml.xhtml: Added.
  • fast/body-propagation/background-image/006.html: Added.
  • fast/body-propagation/background-image/007-declarative.xhtml: Added.
  • fast/body-propagation/background-image/007-xhtml.xhtml: Added.
  • fast/body-propagation/background-image/007.html: Added.
  • fast/body-propagation/background-image/008-xhtml.xhtml: Added.
  • fast/body-propagation/background-image/008.html: Added.
  • fast/body-propagation/background-image/009-xhtml.xhtml: Added.
  • fast/body-propagation/background-image/009.html: Added.
  • fast/body-propagation/background-image/010-xhtml.xhtml: Added.
  • fast/body-propagation/background-image/010.html: Added.
  • fast/body-propagation/background-image/resources: Added.
  • fast/body-propagation/background-image/resources/lime.png: Added.
  • fast/body-propagation/background-image/resources/red.png: Added.
  • fast/body-propagation/background-image/resources/white.png: Added.
  • fast/body-propagation/background-image/resources/yellow.png: Added.
  • fast/body-propagation/overflow: Added.
  • fast/body-propagation/overflow/001-xhtml.xhtml: Added.
  • fast/body-propagation/overflow/001.html: Added.
  • fast/body-propagation/overflow/002-xhtml.xhtml: Added.
  • fast/body-propagation/overflow/002.html: Added.
  • fast/body-propagation/overflow/003-declarative.xhtml: Added.
  • fast/body-propagation/overflow/003-xhtml.xhtml: Added.
  • fast/body-propagation/overflow/003.html: Added.
  • fast/body-propagation/overflow/004-declarative.xhtml: Added.
  • fast/body-propagation/overflow/004-xhtml.xhtml: Added.
  • fast/body-propagation/overflow/004.html: Added.
  • fast/body-propagation/overflow/005-declarative.xhtml: Added.
  • fast/body-propagation/overflow/005-xhtml.xhtml: Added.
  • fast/body-propagation/overflow/005.html: Added.
  • fast/body-propagation/overflow/006-declarative.xhtml: Added.
  • fast/body-propagation/overflow/006-xhtml.xhtml: Added.
  • fast/body-propagation/overflow/006.html: Added.
  • fast/body-propagation/overflow/007-declarative.xhtml: Added.
  • fast/body-propagation/overflow/007-xhtml.xhtml: Added.
  • fast/body-propagation/overflow/007.html: Added.
  • platform/mac/fast/body-propagation: Added.
  • platform/mac/fast/body-propagation/background-color: Added.
  • platform/mac/fast/body-propagation/background-color/001-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/001-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/001-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/001-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/001-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/001-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/002-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/002-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/002-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/002-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/002-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/002-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/003-declarative-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/003-declarative-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/003-declarative-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/003-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/003-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/003-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/003-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/003-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/003-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/004-declarative-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/004-declarative-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/004-declarative-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/004-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/004-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/004-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/004-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/004-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/004-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/005-declarative-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/005-declarative-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/005-declarative-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/005-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/005-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/005-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/005-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/005-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/005-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/006-declarative-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/006-declarative-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/006-declarative-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/006-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/006-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/006-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/006-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/006-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/006-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/007-declarative-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/007-declarative-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/007-declarative-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/007-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/007-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/007-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/007-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/007-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/007-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/008-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/008-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/008-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-color/008-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-color/008-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/background-color/008-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image: Added.
  • platform/mac/fast/body-propagation/background-image/001-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/001-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/001-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/001-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/001-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/001-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/002-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/002-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/002-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/002-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/002-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/002-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/003-declarative-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/003-declarative-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/003-declarative-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/003-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/003-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/003-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/003-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/003-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/003-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/004-declarative-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/004-declarative-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/004-declarative-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/004-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/004-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/004-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/004-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/004-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/004-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/005-declarative-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/005-declarative-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/005-declarative-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/005-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/005-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/005-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/005-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/005-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/005-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/006-declarative-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/006-declarative-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/006-declarative-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/006-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/006-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/006-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/006-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/006-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/006-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/007-declarative-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/007-declarative-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/007-declarative-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/007-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/007-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/007-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/007-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/007-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/007-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/008-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/008-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/008-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/008-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/008-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/008-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/009-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/009-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/009-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/009-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/009-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/009-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/010-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/010-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/010-expected.txt: Added.
  • platform/mac/fast/body-propagation/background-image/010-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/background-image/010-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/background-image/010-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/overflow: Added.
  • platform/mac/fast/body-propagation/overflow/001-expected.checksum: Added.
  • platform/mac/fast/body-propagation/overflow/001-expected.png: Added.
  • platform/mac/fast/body-propagation/overflow/001-expected.txt: Added.
  • platform/mac/fast/body-propagation/overflow/001-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/overflow/001-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/overflow/001-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/overflow/002-expected.checksum: Added.
  • platform/mac/fast/body-propagation/overflow/002-expected.png: Added.
  • platform/mac/fast/body-propagation/overflow/002-expected.txt: Added.
  • platform/mac/fast/body-propagation/overflow/002-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/overflow/002-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/overflow/002-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/overflow/003-declarative-expected.checksum: Added.
  • platform/mac/fast/body-propagation/overflow/003-declarative-expected.png: Added.
  • platform/mac/fast/body-propagation/overflow/003-declarative-expected.txt: Added.
  • platform/mac/fast/body-propagation/overflow/003-expected.checksum: Added.
  • platform/mac/fast/body-propagation/overflow/003-expected.png: Added.
  • platform/mac/fast/body-propagation/overflow/003-expected.txt: Added.
  • platform/mac/fast/body-propagation/overflow/003-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/overflow/003-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/overflow/003-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/overflow/004-declarative-expected.checksum: Added.
  • platform/mac/fast/body-propagation/overflow/004-declarative-expected.png: Added.
  • platform/mac/fast/body-propagation/overflow/004-declarative-expected.txt: Added.
  • platform/mac/fast/body-propagation/overflow/004-expected.checksum: Added.
  • platform/mac/fast/body-propagation/overflow/004-expected.png: Added.
  • platform/mac/fast/body-propagation/overflow/004-expected.txt: Added.
  • platform/mac/fast/body-propagation/overflow/004-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/overflow/004-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/overflow/004-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/overflow/005-declarative-expected.checksum: Added.
  • platform/mac/fast/body-propagation/overflow/005-declarative-expected.png: Added.
  • platform/mac/fast/body-propagation/overflow/005-declarative-expected.txt: Added.
  • platform/mac/fast/body-propagation/overflow/005-expected.checksum: Added.
  • platform/mac/fast/body-propagation/overflow/005-expected.png: Added.
  • platform/mac/fast/body-propagation/overflow/005-expected.txt: Added.
  • platform/mac/fast/body-propagation/overflow/005-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/overflow/005-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/overflow/005-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/overflow/006-declarative-expected.checksum: Added.
  • platform/mac/fast/body-propagation/overflow/006-declarative-expected.png: Added.
  • platform/mac/fast/body-propagation/overflow/006-declarative-expected.txt: Added.
  • platform/mac/fast/body-propagation/overflow/006-expected.checksum: Added.
  • platform/mac/fast/body-propagation/overflow/006-expected.png: Added.
  • platform/mac/fast/body-propagation/overflow/006-expected.txt: Added.
  • platform/mac/fast/body-propagation/overflow/006-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/overflow/006-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/overflow/006-xhtml-expected.txt: Added.
  • platform/mac/fast/body-propagation/overflow/007-declarative-expected.checksum: Added.
  • platform/mac/fast/body-propagation/overflow/007-declarative-expected.png: Added.
  • platform/mac/fast/body-propagation/overflow/007-declarative-expected.txt: Added.
  • platform/mac/fast/body-propagation/overflow/007-expected.checksum: Added.
  • platform/mac/fast/body-propagation/overflow/007-expected.png: Added.
  • platform/mac/fast/body-propagation/overflow/007-expected.txt: Added.
  • platform/mac/fast/body-propagation/overflow/007-xhtml-expected.checksum: Added.
  • platform/mac/fast/body-propagation/overflow/007-xhtml-expected.png: Added.
  • platform/mac/fast/body-propagation/overflow/007-xhtml-expected.txt: Added.
12:55 Changeset [37590] by weinig@apple.com

WebCore:

2008-10-14 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed and landed by Sam Weinig.

Due to change in spec (http://dev.w3.org/2006/webapi/selectors-api/#namespace),
remove NSResolver code, leaving only checking for selectors that need
NS resolution and throwing a coresponding error.

  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSDocumentCustom.cpp:
  • bindings/js/JSDocumentFragmentCustom.cpp:
  • bindings/js/JSElementCustom.cpp:
  • bindings/js/JSNSResolver.cpp: Removed.
  • bindings/js/JSNSResolver.h: Removed.
  • dom/Document.idl:
  • dom/DocumentFragment.idl:
  • dom/Element.idl:
  • dom/NSResolver.h: Removed.
  • dom/NSResolver.idl: Removed.
  • dom/Node.h:
  • dom/Node.cpp: (WebCore::forEachTagSelector): (WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()): (WebCore::selectorNeedsNamespaceResolution): (WebCore::Node::querySelector): (WebCore::Node::querySelectorAll):

LayoutTests:

2008-10-14 Dimitri Glazkov <dglazkov@chromium.org>

Reviewed and landed by Sam Weinig.

Due to change in spec (http://dev.w3.org/2006/webapi/selectors-api/#namespace),
remove no longer relevant NSResolver tests.

  • fast/dom/SelectorAPI/NSResolver-basic-expected.txt: Removed.
  • fast/dom/SelectorAPI/NSResolver-basic.xhtml: Removed.
  • fast/dom/SelectorAPI/NSResolver-exceptions-expected.txt: Removed.
  • fast/dom/SelectorAPI/NSResolver-exceptions.xhtml: Removed.
  • fast/dom/SelectorAPI/resources/NSResolver-exceptions.js: Removed.
12:19 Changeset [37589] by darin@apple.com

2008-10-14 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig (all but the FormDataListItem rename).

  • html/FormDataList.cpp: Removed appendFile since it's now inline. Also took incorrect old copyrights off of this file that are left over from when it was split.
  • html/FormDataList.h: Ditto. Renamed FormDataListItem to Item and made it a member of FormDataList. Changed it to hold a File object instead of a path. And made its data members private. Changed FormDataList::appendFile accordingly.
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData): Updated for above changes. Removed the code that special-cases HTMLInputElement, because now the FormDataListItem has everything we need. And if there are multiple files, we'll get multiple list items for them.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::appendFormData): Changed the code for <input type=file> to use File objects instead of path strings and also to append multiple files if the file list has them.
12:17 Changeset [37588] by timothy@apple.com

Make prepare-ChangeLog populate the changed functions for JavaScript files.

https://bugs.webkit.org/show_bug.cgi?id=21567

Reviewed by David Kilzer.

  • Scripts/prepare-ChangeLog: (get_function_line_ranges): Call get_function_line_ranges_for_javascript for files that end with ".js". (get_function_line_ranges_for_javascript): Find functions, anonymous functions and getters/setters.
11:43 Changeset [37587] by darin@apple.com

2008-10-14 Alp Toker <alp@nuanti.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=16299
Add a config.h file to DRT

Add a config.h to DumpRenderTree and reduce use of DumpRenderTree.h as
an ad-hoc config header.

  • DumpRenderTree/AccessibilityController.cpp:
  • DumpRenderTree/AccessibilityUIElement.cpp:
  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/DumpRenderTree.h:
  • DumpRenderTree/GCController.cpp:
  • DumpRenderTree/LayoutTestController.cpp:
  • DumpRenderTree/WorkQueue.cpp:
  • DumpRenderTree/config.h: Added.
  • DumpRenderTree/gtk/DumpRenderTree.cpp:
  • DumpRenderTree/gtk/GCControllerGtk.cpp:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  • DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
  • DumpRenderTree/win/AccessibilityControllerWin.cpp:
  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:
  • DumpRenderTree/win/DumpRenderTree.cpp:
  • DumpRenderTree/win/DumpRenderTreeWin.h:
  • DumpRenderTree/win/EditingDelegate.cpp:
  • DumpRenderTree/win/EventSender.cpp:
  • DumpRenderTree/win/FrameLoadDelegate.cpp:
  • DumpRenderTree/win/GCControllerWin.cpp:
  • DumpRenderTree/win/MD5.cpp:
  • DumpRenderTree/win/PixelDumpSupportWin.cpp:
  • DumpRenderTree/win/PolicyDelegate.cpp:
  • DumpRenderTree/win/ResourceLoadDelegate.cpp:
  • DumpRenderTree/win/WorkQueueItemWin.cpp:
  • GNUmakefile.am:
09:22 Changeset [37586] by ap@webkit.org

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=20256
Array.push and other standard methods disappear

  • kjs/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): (JSC::JSGlobalData::~JSGlobalData): Don't use static hash tables even on platforms that don't enable JSC_MULTIPLE_THREADS - these tables reference IdentifierTable, which is always per-GlobalData.
05:50 Changeset [37585] by vestbo@webkit.org

2008-10-14 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Simon.

Fix QtWebKit scrollbar painting errors

01:46 Changeset [37584] by vestbo@webkit.org

2008-10-14 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Simon.

Clip painter to dirty rect before passing on to WebKit

This was previously done in ScrollViewQt, but after the
refactoring of ScrollView we need to do it in QWebFrame
instead, similar to Safari/Win.

01:43 Changeset [37583] by vestbo@webkit.org

2008-10-14 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Simon.

Fix scrollbar arrows for horizontal scrollbars

01:38 Changeset [37582] by vestbo@webkit.org

2008-10-14 Tor Arne Vestbø <tavestbo@trolltech.com>

Reviewed by Simon.

Use style-painter to draw scrollbars in ScrollbarThemeQt

This has the benefit of setting up the painter properly without
antialiasing and saving and restoring the brush. It also ensures
that we use the style of the QWebView over the QApplication style
if possible.

01:21 Changeset [37581] by mjs@apple.com

2008-10-14 Maciej Stachowiak <mjs@apple.com>

Reviewed by Cameron Zwarich.


  • always use CTI_ARGUMENTS and CTI_ARGUMENTS_FASTCALL


This is a small regression for GCC 4.0, but simplifies the code
for future improvements and lets us focus on GCC 4.2+ and MSVC.

  • VM/CTI.cpp:
  • VM/CTI.h:
  • VM/Machine.cpp: (JSC::Machine::cti_op_convert_this): (JSC::Machine::cti_op_end): (JSC::Machine::cti_op_add): (JSC::Machine::cti_op_pre_inc): (JSC::Machine::cti_timeout_check): (JSC::Machine::cti_register_file_check): (JSC::Machine::cti_op_loop_if_less): (JSC::Machine::cti_op_loop_if_lesseq): (JSC::Machine::cti_op_new_object): (JSC::Machine::cti_op_put_by_id): (JSC::Machine::cti_op_put_by_id_second): (JSC::Machine::cti_op_put_by_id_generic): (JSC::Machine::cti_op_put_by_id_fail): (JSC::Machine::cti_op_get_by_id): (JSC::Machine::cti_op_get_by_id_second): (JSC::Machine::cti_op_get_by_id_generic): (JSC::Machine::cti_op_get_by_id_fail): (JSC::Machine::cti_op_instanceof): (JSC::Machine::cti_op_del_by_id): (JSC::Machine::cti_op_mul): (JSC::Machine::cti_op_new_func): (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_vm_compile): (JSC::Machine::cti_op_push_activation): (JSC::Machine::cti_op_call_NotJSFunction): (JSC::Machine::cti_op_create_arguments): (JSC::Machine::cti_op_tear_off_activation): (JSC::Machine::cti_op_tear_off_arguments): (JSC::Machine::cti_op_ret_profiler): (JSC::Machine::cti_op_ret_scopeChain): (JSC::Machine::cti_op_new_array): (JSC::Machine::cti_op_resolve): (JSC::Machine::cti_op_construct_JSConstruct): (JSC::Machine::cti_op_construct_NotJSConstruct): (JSC::Machine::cti_op_get_by_val): (JSC::Machine::cti_op_resolve_func): (JSC::Machine::cti_op_sub): (JSC::Machine::cti_op_put_by_val): (JSC::Machine::cti_op_put_by_val_array): (JSC::Machine::cti_op_lesseq): (JSC::Machine::cti_op_loop_if_true): (JSC::Machine::cti_op_negate): (JSC::Machine::cti_op_resolve_base): (JSC::Machine::cti_op_resolve_skip): (JSC::Machine::cti_op_resolve_global): (JSC::Machine::cti_op_div): (JSC::Machine::cti_op_pre_dec): (JSC::Machine::cti_op_jless): (JSC::Machine::cti_op_not): (JSC::Machine::cti_op_jtrue): (JSC::Machine::cti_op_post_inc): (JSC::Machine::cti_op_eq): (JSC::Machine::cti_op_lshift): (JSC::Machine::cti_op_bitand): (JSC::Machine::cti_op_rshift): (JSC::Machine::cti_op_bitnot): (JSC::Machine::cti_op_resolve_with_base): (JSC::Machine::cti_op_new_func_exp): (JSC::Machine::cti_op_mod): (JSC::Machine::cti_op_less): (JSC::Machine::cti_op_neq): (JSC::Machine::cti_op_post_dec): (JSC::Machine::cti_op_urshift): (JSC::Machine::cti_op_bitxor): (JSC::Machine::cti_op_new_regexp): (JSC::Machine::cti_op_bitor): (JSC::Machine::cti_op_call_eval): (JSC::Machine::cti_op_throw): (JSC::Machine::cti_op_get_pnames): (JSC::Machine::cti_op_next_pname): (JSC::Machine::cti_op_push_scope): (JSC::Machine::cti_op_pop_scope): (JSC::Machine::cti_op_typeof): (JSC::Machine::cti_op_is_undefined): (JSC::Machine::cti_op_is_boolean): (JSC::Machine::cti_op_is_number): (JSC::Machine::cti_op_is_string): (JSC::Machine::cti_op_is_object): (JSC::Machine::cti_op_is_function): (JSC::Machine::cti_op_stricteq): (JSC::Machine::cti_op_nstricteq): (JSC::Machine::cti_op_to_jsnumber): (JSC::Machine::cti_op_in): (JSC::Machine::cti_op_push_new_scope): (JSC::Machine::cti_op_jmp_scopes): (JSC::Machine::cti_op_put_by_index): (JSC::Machine::cti_op_switch_imm): (JSC::Machine::cti_op_switch_char): (JSC::Machine::cti_op_switch_string): (JSC::Machine::cti_op_del_by_val): (JSC::Machine::cti_op_put_getter): (JSC::Machine::cti_op_put_setter): (JSC::Machine::cti_op_new_error): (JSC::Machine::cti_op_debug): (JSC::Machine::cti_vm_throw):
  • VM/Machine.h:
  • masm/X86Assembler.h: (JSC::X86Assembler::emitRestoreArgumentReference): (JSC::X86Assembler::emitRestoreArgumentReferenceForTrampoline):
  • wtf/Platform.h:
00:49 Changeset [37580] by jhoneycutt@apple.com

2008-10-14 Jon Honeycutt <jhoneycutt@apple.com>

Export currentThread.

Rubber-stamped by Dan Bernstein.

  • WebKit.vcproj/WebKit.def:
  • WebKit.vcproj/WebKit_debug.def:

10/13/08:

23:45 Changeset [37579] by hyatt@apple.com

2008-10-13 David Hyatt <hyatt@apple.com>

Add support for CSS transitions on some SVG properties. This patch is intended to be a guideline
for how to add support for the rest.

Reviewed by Oliver Hunt

  • page/animation/AnimationBase.cpp: (WebCore::ensurePropertyMap):
  • rendering/style/RenderStyle.h: (WebCore::RenderStyle::fillOpacity): (WebCore::RenderStyle::setFillOpacity): (WebCore::RenderStyle::strokeOpacity): (WebCore::RenderStyle::setStrokeOpacity): (WebCore::RenderStyle::floodOpacity): (WebCore::RenderStyle::setFloodOpacity):
23:29 Changeset [37578] by hyatt@apple.com

2008-10-13 David Hyatt <hyatt@apple.com>

<rdar://problem/6289712> REGRESSION(r37432-37490): Scroll bar is not drawn in Bookmark View, Preferences sheets.

Fix for disabled scrollbars not painting in Windows Safari. Make sure that the Windows theme
implements paintTrackBackground so that when the thumb is not present the track still paints.

Reviewed by Oliver Hunt

  • platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::paint):
  • platform/win/ScrollbarThemeWin.cpp: (WebCore::ScrollbarThemeWin::paintTrackBackground):
  • platform/win/ScrollbarThemeWin.h:
23:12 Changeset [37577] by hyatt@apple.com

2008-10-13 David Hyatt <hyatt@apple.com>

Fix over-invalidation of native scrollbars.

Reviewed by Oliver Hunt

  • platform/Scrollbar.h: (WebCore::Scrollbar::styleChanged):
  • platform/mac/ScrollbarThemeMac.mm: (+[ScrollbarPrefsObserver appearancePrefsChanged:]):
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::styleChanged):
22:29 Changeset [37576] by mjs@apple.com

2008-10-13 Maciej Stachowiak <mjs@apple.com>

Reviewed by Cameron Zwarich.


  • make Machine::getArgumentsData an Arguments method and inline it


~2% on v8 raytrace

  • VM/Machine.cpp:
  • kjs/Arguments.h: (JSC::Machine::getArgumentsData):
21:14 Changeset [37575] by alp@webkit.org

2008-10-13 Alp Toker <alp@nuanti.com>

Fix autotools dist build target by listing recently added header
files only. Not reviewed.

19:28 Changeset [37574] by mrowe@apple.com

Don't run a SQLite query on every iteration of the sync thread when the query
will touch a large portion of the icon database while performing no useful work.

Reviewed by Brady Eidson.

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::writeToDatabase): Don't call checkForDanglingPageURLs unless
we modified the database.
(WebCore::IconDatabase::checkForDanglingPageURLs): Don't do any work in a release build
unless we've been asked to prune any dangling pageURLs that we find.

19:16 Changeset [37573] by alp@webkit.org

2008-10-13 Alp Toker <alp@nuanti.com>

GTK+ build fix: Ensure correct builds when debugging is
enabled/disabled by defining NDEBUG in autotoolsconfig.h as needed.
It's still passed as a compiler flag since some sources (DRT) don't
use config.h yet.

  • configure.ac:
18:21 Changeset [37572] by mjs@apple.com

JavaScriptCore:

2008-10-13 Maciej Stachowiak <mjs@apple.com>

Rubber stamped by Mark Rowe.


  • fixed <rdar://problem/5806316> JavaScriptCore should not force building with gcc 4.0
  • use gcc 4.2 when building with Xcode 3.1 or newer on Leopard, even though this is not the default
  • Configurations/DebugRelease.xcconfig:
  • JavaScriptCore.xcodeproj/project.pbxproj:

JavaScriptGlue:

2008-10-13 Maciej Stachowiak <mjs@apple.com>

Rubber stamped by Mark Rowe.


  • use gcc 4.2 when building with Xcode 3.1 or newer on Leopard, even though this is not the default
  • Configurations/DebugRelease.xcconfig:

WebCore:

2008-10-13 Maciej Stachowiak <mjs@apple.com>

Rubber stamped by Mark Rowe.


  • use gcc 4.2 when building with Xcode 3.1 or newer on Leopard, even though this is not the default
  • Configurations/DebugRelease.xcconfig:

WebKit/mac:

2008-10-13 Maciej Stachowiak <mjs@apple.com>

Rubber stamped by Mark Rowe.


  • use gcc 4.2 when building with Xcode 3.1 or newer on Leopard, even though this is not the default
  • Configurations/DebugRelease.xcconfig:
17:59 Changeset [37571] by hyatt@apple.com

2008-10-13 David Hyatt <hyatt@apple.com>

Make dropdown lists on Windows work with CSS custom scrollbars.

Reviewed by Adele

  • platform/PopupMenu.h: (WebCore::PopupMenu::scrollbarCornerPresent):
  • platform/PopupMenuClient.h:
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show):
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::createScrollbar):
  • rendering/RenderMenuList.h:
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createScrollbar):
  • rendering/RenderTextControl.h:
17:20 Changeset [37570] by cwzwarich@webkit.org

2008-10-13 Cameron Zwarich <zwarich@apple.com>

Reviewed by Geoff Garen.

Bug 21541: Move RegisterFile growth check to callee
<https://bugs.webkit.org/show_bug.cgi?id=21541>

Move the RegisterFile growth check to the callee in the common case,
where some of the information is known statically at JIT time. There is
still a check in the caller in the case where the caller provides too
few arguments.

This is a 2.1% speedup on the V8 benchmark, including a 5.1% speedup on
the Richards benchmark, a 4.1% speedup on the DeltaBlue benchmark, and a
1.4% speedup on the Earley-Boyer benchmark. It is also a 0.5% speedup on
SunSpider.

  • VM/CTI.cpp: (JSC::CTI::privateCompile):
  • VM/Machine.cpp: (JSC::Machine::cti_register_file_check): (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_op_construct_JSConstruct):
  • VM/Machine.h:
  • VM/RegisterFile.h:
  • masm/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::cmpl_mr): (JSC::X86Assembler::emitUnlinkedJg):
16:39 Changeset [37569] by hyatt@apple.com

Fix Windows build bustage.

16:39 Changeset [37568] by hyatt@apple.com

Fix Windows build bustage.

15:48 Changeset [37567] by cfleizach@apple.com

<rdar://problem/6271864> Links from image maps not being included in AXLinkUIElements

This also fixes the positions of image map links

15:42 Changeset [37566] by hyatt@apple.com

WebCore:

2008-10-13 David Hyatt <hyatt@apple.com>

Make RenderListBox work with CSS scrollbars. Refactoring this code to support creation/destruction in
the same way RenderLayer does also fixes a bug where the PLT would assert on the next-to-last page (no
idea how to make a test case for that, though, since I couldn't repro without running the whole PLT).

Reviewed by Tim Hatcher

Added scrollbars/listbox-scrollbar-combinations.html

  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::~RenderListBox): (WebCore::RenderListBox::updateFromElement): (WebCore::RenderListBox::createScrollbar): (WebCore::RenderListBox::destroyScrollbar): (WebCore::RenderListBox::setHasVerticalScrollbar):
  • rendering/RenderListBox.h:

LayoutTests:

2008-10-13 David Hyatt <hyatt@apple.com>

Add test case for custom CSS listbox scrollbars.

Reviewed by Tim Hatcher

  • platform/mac/scrollbars/listbox-scrollbar-combinations-expected.checksum: Added.
  • platform/mac/scrollbars/listbox-scrollbar-combinations-expected.png: Added.
  • platform/mac/scrollbars/listbox-scrollbar-combinations-expected.txt: Added.
  • scrollbars/listbox-scrollbar-combinations.html: Added.
15:25 Changeset [37565] by timothy@apple.com

Adds an complex styled scrollbar test that exercises all pseudo-elements and pseudo-classes.
Also uses positive and negative margins on the scrollbar track and track pieces.
Tests all the combinations of scrollbars for overflow elements, with and without resizers.

Rubber-stamped by Dave Hyatt.

  • platform/mac/scrollbars/overflow-scrollbar-combinations-expected.checksum: Added.
  • platform/mac/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
  • platform/mac/scrollbars/overflow-scrollbar-combinations-expected.txt: Added.
  • scrollbars/overflow-scrollbar-combinations.html: Added.
  • scrollbars/resources: Added.
  • scrollbars/resources/corner-inactive.png: Added.
  • scrollbars/resources/corner.png: Added.
  • scrollbars/resources/horizontal-button-active.png: Added.
  • scrollbars/resources/horizontal-button-background-active.png: Added.
  • scrollbars/resources/horizontal-button-background-hover.png: Added.
  • scrollbars/resources/horizontal-button-background-inactive.png: Added.
  • scrollbars/resources/horizontal-button-background.png: Added.
  • scrollbars/resources/horizontal-button-hover.png: Added.
  • scrollbars/resources/horizontal-button-inactive.png: Added.
  • scrollbars/resources/horizontal-button.png: Added.
  • scrollbars/resources/horizontal-decrement-arrow.png: Added.
  • scrollbars/resources/horizontal-increment-arrow.png: Added.
  • scrollbars/resources/horizontal-thumb-active.png: Added.
  • scrollbars/resources/horizontal-thumb-hover.png: Added.
  • scrollbars/resources/horizontal-thumb-inactive.png: Added.
  • scrollbars/resources/horizontal-thumb.png: Added.
  • scrollbars/resources/horizontal-track-active.png: Added.
  • scrollbars/resources/horizontal-track-disabled.png: Added.
  • scrollbars/resources/horizontal-track-hover.png: Added.
  • scrollbars/resources/horizontal-track.png: Added.
  • scrollbars/resources/resizer-inactive.png: Added.
  • scrollbars/resources/resizer.png: Added.
  • scrollbars/resources/vertical-button-active.png: Added.
  • scrollbars/resources/vertical-button-background-active.png: Added.
  • scrollbars/resources/vertical-button-background-hover.png: Added.
  • scrollbars/resources/vertical-button-background-inactive.png: Added.
  • scrollbars/resources/vertical-button-background.png: Added.
  • scrollbars/resources/vertical-button-hover.png: Added.
  • scrollbars/resources/vertical-button-inactive.png: Added.
  • scrollbars/resources/vertical-button.png: Added.
  • scrollbars/resources/vertical-decrement-arrow.png: Added.
  • scrollbars/resources/vertical-increment-arrow.png: Added.
  • scrollbars/resources/vertical-thumb-active.png: Added.
  • scrollbars/resources/vertical-thumb-hover.png: Added.
  • scrollbars/resources/vertical-thumb-inactive.png: Added.
  • scrollbars/resources/vertical-thumb.png: Added.
  • scrollbars/resources/vertical-track-active.png: Added.
  • scrollbars/resources/vertical-track-disabled.png: Added.
  • scrollbars/resources/vertical-track-hover.png: Added.
  • scrollbars/resources/vertical-track.png: Added.
14:53 Changeset [37564] by hyatt@apple.com

2008-10-13 David Hyatt <hyatt@apple.com>

In order to always match the :corner-present pseudo-class properly, delay initial updating of
scrollbar styles until the layer has the scrollbars in its member variables.

Reviewed by Tim Hatcher

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar):
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::RenderScrollbar):
14:41 Changeset [37563] by weinig@apple.com

JavaScriptCore:

2008-10-13 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix for https://bugs.webkit.org/show_bug.cgi?id=21577
5 false positive StructureID leaks

  • Add leak ignore set to StructureID to selectively ignore leaking some StructureIDs.
  • Add create method to JSGlolalData to be used when the data will be intentionally leaked and ignore all leaks caused the StructureIDs stored in it.
  • JavaScriptCore.exp:
  • kjs/JSGlobalData.cpp: (JSC::JSGlobalData::createLeaked):
  • kjs/JSGlobalData.h:
  • kjs/StructureID.cpp: (JSC::StructureID::StructureID): (JSC::StructureID::~StructureID): (JSC::StructureID::startIgnoringLeaks): (JSC::StructureID::stopIgnoringLeaks):
  • kjs/StructureID.h:

WebCore:

2008-10-13 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Fix for https://bugs.webkit.org/show_bug.cgi?id=21577
5 false positive StructureID leaks

In WebCore, we intentionally leak the common JSGlobalData which in turn
leaks 5 StructureIDs. Use the new JSGlobalData::createLeaked in order to
ignore the StructureIDs leaked within.

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::commonJSGlobalData):
14:23 Changeset [37562] by hyatt@apple.com

2008-10-13 David Hyatt <hyatt@apple.com>

Add support for the :corner-present pseudoclass, which enables scrollbar pieces to change their
artwork based on whether there is a scrollbar corner present.

Reviewed by Tim Hatcher

  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollbarCornerPresent):
  • platform/ScrollView.h:
  • platform/ScrollbarClient.h:
  • rendering/RenderLayer.cpp: (WebCore::cornerRect): (WebCore::scrollCornerRect): (WebCore::resizerCornerRect): (WebCore::RenderLayer::scrollbarCornerPresent): (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::horizontalScrollbar): (WebCore::RenderLayer::verticalScrollbar):
  • rendering/RenderListBox.h: (WebCore::RenderListBox::scrollbarCornerPresent):
13:56 Changeset [37561] by hyatt@apple.com

2008-10-13 David Hyatt <hyatt@apple.com>

Make resizers and scrollbar corners respect :window-inactive (one more bug fix and then Tim's master
test case for all this can land).

Reviewed by Tim Hatcher

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkSelector): (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintOverflowControls): (WebCore::RenderLayer::paintScrollCorner): (WebCore::RenderLayer::paintResizer): (WebCore::RenderLayer::styleChanged): (WebCore::RenderLayer::updateScrollCornerStyle): (WebCore::RenderLayer::updateResizerStyle):
  • rendering/RenderLayer.h:
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::paint):
  • rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::paintIntoRect):
13:21 Changeset [37560] by hyatt@apple.com

2008-10-13 David Hyatt <hyatt@apple.com>

Rework resizer and scroll corner painting so that custom resizers and scroll corners will paint
and invalidate properly as images load, etc.

Reviewed by Tim Hatcher

  • rendering/RenderLayer.cpp: (WebCore::cornerRect): (WebCore::scrollCornerRect): (WebCore::resizerCornerRect): (WebCore::RenderLayer::positionOverflowControls): (WebCore::RenderLayer::paintOverflowControls): (WebCore::RenderLayer::paintScrollCorner): (WebCore::RenderLayer::paintResizer): (WebCore::RenderLayer::isPointInResizeControl): (WebCore::RenderLayer::hitTestOverflowControls): (WebCore::RenderLayer::styleChanged):
  • rendering/RenderLayer.h:
  • rendering/RenderObject.h: (WebCore::RenderObject::setRect):
  • rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::styleDidChange): (WebCore::RenderScrollbarPart::imageChanged):
11:55 Changeset [37559] by ddkilzer@apple.com

Bug 21457: resolve-ChangeLogs should be able to operate on a git revision range

<https://bugs.webkit.org/show_bug.cgi?id=21457>

Reviewed by Adam.

  • Scripts/resolve-ChangeLogs: Added optional parameter to
-ffix-merged switch to run the script on a revision range.

Updated command-line validation checks.
(findChangeLog): Fixed long-standing bug that should have used
$_[0] instead of $_.
(fixMergedChangeLog): Renamed to fixOneMergedChangeLog($). Updated
to work when called from git filter-branch. It always restores a
copy of the previous revision before reapplying the patch.
(fixMergedChangeLogs): Added. Calls itself through git filter-branch
to re-merge ChangeLog files across a revision range. Removes
.git/refs/original directory on success.

(parseFixMerged): Added. Custom method to parse the -ffix-merged

switch.
(removeChangeLogArguments): Added. Removes items from @ARGV when
they are ChangeLog paths, and return a list of paths. This makes it
easier to validate the command-line.
(resolveChangeLog): Added. Extracted from main code block. Runs
the traditional single-file merge algorithm.
(usageAndExit): Added. Extracted from main code block. Prints
usage statement and exits with error status.

11:31 Changeset [37558] by sfalken@apple.com

WebCore:

2008-10-13 Steve Falkenburg <sfalken@apple.com>

Roll out r36884.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/win/GraphicsContextCGWin.cpp: (WebCore::CGContextWithHDC): (WebCore::GraphicsContext::GraphicsContext):

WebKit/win:

2008-10-13 Steve Falkenburg <sfalken@apple.com>

Roll out r36883, r36884.

Added unimplemented method to IWebViewPrivate (paintDocumentRectToContext) for nightly compatibility
(we need to preserve vtable order).

  • Interfaces/IWebViewPrivate.idl:
  • WebFrame.cpp: (WebFrame::transitionToCommittedForNewPage): (WebFrame::unmarkAllBadGrammar):
  • WebFrame.h:
  • WebView.cpp: (WebView::WebView): (WebView::paintIntoBackingStore): (WebView::paintDocumentRectToContext):
  • WebView.h:
11:23 Changeset [37557] by sfalken@apple.com

2008-10-13 Steve Falkenburg <sfalken@apple.com>

Reorder methods to preserve compatibility.


Rubber stamped by Oliver Hunt.

  • Interfaces/IWebViewPrivate.idl:
04:44 Changeset [37556] by jmalonzo@webkit.org

2008-10-13 Marco Barisione <marco.barisione@collabora.co.uk>

Reviewed by Darin Adler. Landed by Jan Alonzo.

WebKit GTK Port needs a smartpointer to handle g_free (GFreePtr?)
http://bugs.webkit.org/show_bug.cgi?id=20483

Start the conversion to use GOwnPtr and fix a memory leak.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mediaPlayerPrivateErrorCallback):

2008-10-13 Marco Barisione <marco.barisione@collabora.co.uk>

Reviewed by Darin Adler. Landed by Jan Alonzo.

WebKit GTK Port needs a smartpointer to handle g_free (GFreePtr?)
http://bugs.webkit.org/show_bug.cgi?id=20483

Add a GOwnPtr smart pointer (similar to OwnPtr) to handle memory
allocated by GLib and start the conversion to use it.

  • GNUmakefile.am:
  • wtf/GOwnPtr.cpp: Added. (WTF::GError): (WTF::GList): (WTF::GCond): (WTF::GMutex): (WTF::GPatternSpec): (WTF::GDir):
  • wtf/GOwnPtr.h: Added. (WTF::freeOwnedPtr): (WTF::GOwnPtr::GOwnPtr): (WTF::GOwnPtr::~GOwnPtr): (WTF::GOwnPtr::get): (WTF::GOwnPtr::release): (WTF::GOwnPtr::rawPtr): (WTF::GOwnPtr::set): (WTF::GOwnPtr::clear): (WTF::GOwnPtr::operator*): (WTF::GOwnPtr::operator->): (WTF::GOwnPtr::operator!): (WTF::GOwnPtr::operator UnspecifiedBoolType): (WTF::GOwnPtr::swap): (WTF::swap): (WTF::operator==): (WTF::operator!=): (WTF::getPtr):
  • wtf/Threading.h:
  • wtf/ThreadingGtk.cpp: (WTF::Mutex::~Mutex): (WTF::Mutex::lock): (WTF::Mutex::tryLock): (WTF::Mutex::unlock): (WTF::ThreadCondition::~ThreadCondition): (WTF::ThreadCondition::wait): (WTF::ThreadCondition::timedWait): (WTF::ThreadCondition::signal): (WTF::ThreadCondition::broadcast):

10/12/08:

19:43 Changeset [37555] by jhoneycutt@apple.com

2008-10-12 Jon Honeycutt <jhoneycutt@apple.com>

Windows build fix.

  • loader/TextResourceDecoder.cpp:
19:20 Changeset [37554] by darin@apple.com

2008-10-12 Pamela Greene <pam@chromium.org>

Reviewed by Darin Adler.

Add tests to cover more gradient edge cases: missing endpoints, only
endpoints, only one stop.

  • fast/canvas/fillrect_gradient.html:
  • platform/mac/fast/canvas/fillrect_gradient-expected.checksum:
  • platform/mac/fast/canvas/fillrect_gradient-expected.png:
  • platform/mac/fast/canvas/fillrect_gradient-expected.txt:
19:16 Changeset [37553] by darin@apple.com

2008-10-12 Gabriella Toth <gtoth@inf.u-szeged.hu>

Reviewed by Darin Adler.

  • kjs/nodes.cpp: Deleted a function that is not invoked: statementListInitializeVariableAccessStack.
19:13 Changeset [37552] by darin@apple.com

2008-10-12 Darin Fisher <darin@chromium.org>

Reviewed by Darin Adler.

  • platform/network/NetworkStateNotifier.h: Add the #include.
18:41 Changeset [37551] by abarth@webkit.org

Fix typo in LayoutTests/ChangeLog

18:37 Changeset [37550] by darin@apple.com

2008-10-12 Darin Adler <darin@apple.com>

Based on work by Holger Freyther.

  • GNUmakefile.am: Added new source files.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • WebCoreSources.bkl: Ditto.
  • platform/graphics/Font.cpp: Use WidthIterator from its new place.
  • platform/graphics/WidthIterator.cpp: Added.
  • platform/graphics/WidthIterator.h: Added.
18:29 Changeset [37549] by abarth@webkit.org

2008-10-12 Pamela Greene <pam@chromium.org>

Fixed 'completed' variable name to match 'running' one.
See https://bugs.webkit.org/show_bug.cgi?21506

Reviewed by Darin Adler.
Landed by Adam Barth.

  • dom/html/level2/html/HTMLFrameElement09.js:
  • dom/html/level2/html/HTMLIFrameElement11.js:
18:26 Changeset [37548] by mrowe@apple.com

Merge r37526.

18:15 Changeset [37547] by abarth@webkit.org

2008-10-12 Pamela Greene <pam@chromium.org>

Remove a race condition in a test by promoting layoutTestController
calls outside document.write(). Add document.close().
See https://bugs.webkit.org/show_bug.cgi?id=21524

Reviewed by Darin Adler.
Landed by Adam Barth.

  • fast/encoding/script-in-head.html:
18:15 Changeset [37546] by abarth@webkit.org

2008-10-12 Pamela Greene <pam@chromium.org>

Remove data: URLs to avoid cross-domain security restrictions.
See https://bugs.webkit.org/show_bug.cgi?id=21528

Reviewed by Darin Adler.
Landed by Adam Barth.

  • fast/events/resources/tabindex-focus-blur-all-frame1.html:
  • fast/events/resources/tabindex-focus-blur-all-frame2.html:
  • fast/events/resources/tabindex-focus-blur-all-frame3.html: Added.
  • fast/events/tabindex-focus-blur-all.html:
18:15 Changeset [37545] by abarth@webkit.org

2008-10-12 Pamela Greene <pam@chromium.org>

Fix test when removesExtraParentheses == false.
See https://bugs.webkit.org/show_bug.cgi?id=21529

Reviewed by Darin Adler.
Landed by Adam Barth.

  • fast/js/resources/function-toString-parentheses.js:
18:15 Changeset [37544] by abarth@webkit.org

2008-10-12 Pamela Greene <pam@chromium.org>

Fix a race condition by waiting for all create functions to be called
before terminating.
See https://bugs.webkit.org/show_bug.cgi?id=21531

Reviewed by Darin Adler.
Landed by Adam Barth.

  • platform/mac/svg/carto.net/window-expected.checksum:
  • platform/mac/svg/carto.net/window-expected.png:
  • platform/mac/svg/carto.net/window-expected.txt:
  • svg/carto.net/window.svg:
18:14 Changeset [37543] by abarth@webkit.org

2008-10-12 Pamela Greene <pam@chromium.org>

Remove inadvertent const redefinition, and add specific test for it.
See https://bugs.webkit.org/show_bug.cgi?id=21532

Reviewed by Darin Adler.
Landed by Adam Barth.

  • fast/js/const-expected.txt:
  • fast/js/resources/const.js:
18:14 Changeset [37542] by abarth@webkit.org

2008-10-12 Pamela Greene <pam@chromium.org>

Add a test for null character data.
See https://bugs.webkit.org/show_bug.cgi?id=21535

Reviewed by Darin Adler.
Landed by Adam Barth.

  • fast/dom/null-chardata-crash-expected.txt: Added.
  • fast/dom/null-chardata-crash.html: Added.
18:13 Changeset [37541] by darin@apple.com

2008-10-12 Tony Chang <tony@chromium.org>

Reviewed by Sam Weinig.

  • plugins/PluginInfoStore.cpp: Added an include.
  • plugins/PluginInfoStore.h: Removed struct declarations.
18:07 Changeset [37540] by darin@apple.com

2008-10-12 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

  • platform/graphics/Gradient.cpp: Removed the overload of addColorStop that accepts a CSS color string. That's handled in the DOM now, not here. (WebCore::Gradient::addColorStop): Use getRGBA instead of having our own copy of it here.
  • platform/graphics/Gradient.h: More of the same. Tweak formatting a bit.
17:58 Changeset [37539] by darin@apple.com

WebCore:

2008-10-12 Glenn Wilson <gwilson@google.com>

Reviewed by Darin Adler.

Added feature to allow multi-line inputs into text fields.
HTMLInputElement would cut the set text at the first 'system' character,
so it would truncate at the first carriage return or newline.
This fix modifies that behavior to truncate at any non-space system character
but changes \r, \n, and \r\n to a single space.

Tests: editing/pasteboard/paste-multiline-text-input.html


  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::constrainValue):

LayoutTests:

2008-10-12 Glenn Wilson <gwilson@google.com>

Reviewed by Darin Adler.

Added new test to verify that the user can cut and paste multiple lines of text
into a single line text field.

  • fast/forms/paste-multiline-text-input-expected.txt: Added.
  • fast/forms/paste-multiline-text-input.html: Added.
  • fast/forms/input-truncate-newline-expected.txt: Removed.
  • fast/forms/input-truncate-newline.html: Removed.
  • fast/forms/8250-expected.txt: Added.
  • fast/forms/8250.html: Updated test to be text-only and expect new results.
  • platform/mac/fast/forms/8250-expected.checksum: Removed.
  • platform/mac/fast/forms/8250-expected.png: Removed.
  • platform/mac/fast/forms/8250-expected.txt: Removed.
  • platform/qt/fast/forms/8250-expected.txt: Removed.
17:25 Changeset [37538] by darin@apple.com

WebCore:

2008-10-12 Dirk Schulze <vbs85@gmx.de>

Reviewed by Eric Seidel.

Added exception codes to canvas gradients to match current specification.

Tests: fast/canvas/gradient-addColorStop-with-invalid-color.html

fast/canvas/linearGradient-infinite-values.html
fast/canvas/radialGradient-infinite-values.html

  • html/CanvasGradient.cpp: (WebCore::CanvasGradient::addColorStop):
  • html/CanvasGradient.h:
  • html/CanvasGradient.idl:
  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createLinearGradient): (WebCore::CanvasRenderingContext2D::createRadialGradient):
  • html/CanvasRenderingContext2D.h:
  • html/CanvasRenderingContext2D.idl:

LayoutTests:

2008-10-12 Dirk Schulze <vbs85@gmx.de>

Reviewed by Eric Seidel.

Added new tests to check behavior of canvas gradients to infinite values
or invalid colors.

  • fast/canvas/gradient-addColorStop-with-invalid-color-expected.txt: Added.
  • fast/canvas/gradient-addColorStop-with-invalid-color.html: Added.
  • fast/canvas/linearGradient-infinite-values-expected.txt: Added.
  • fast/canvas/linearGradient-infinite-values.html: Added.
  • fast/canvas/radialGradient-infinite-values-expected.txt: Added.
  • fast/canvas/radialGradient-infinite-values.html: Added.
  • fast/canvas/resources/gradient-addColorStop-with-invalid-color.js: Added.
  • fast/canvas/resources/linearGradient-infinite-values.js: Added.
  • fast/canvas/resources/radialGradient-infinite-values.js: Added.
16:59 Changeset [37537] by darin@apple.com

2008-10-12 Eric Roman <eroman@chromium.org>

Reviewed by David Hyatt.

  • rendering/RenderThemeWin.cpp: (WebCore::cssValueIdToSysColorIndex): (WebCore::RenderThemeWin::systemColor):
  • rendering/RenderThemeWin.h:
16:51 Changeset [37536] by mrowe@apple.com

Merge r36005.

16:50 Changeset [37535] by darin@apple.com

2008-10-12 Aaron Bockover <abockover@novell.com>

Reviewed by Alp Toker.

Add version parsing for Flash, and the PluginQuirkDontSetNullWindowHandleOnDestroy
plugin quirk if Flash 10 or newer since at least in b218, setting a NULL window
handler on destroy crashes WebKit <https://bugs.webkit.org/show_bug.cgi?id=19859>

  • plugins/gtk/PluginPackageGtk.cpp:
16:01 Changeset [37534] by darin@apple.com

2008-10-12 Jonathon Jongsma <jonathon.jongsma@collabora.co.uk>

Reviewed by Oliver Hunt.

  • page/DragController.cpp: (WebCore::DragController::startDrag): When a link is dragged without any text selected (note: for this to work, the EditableLinkBehavior setting must be set to 'live' or 'default') and then dropped into an editable html document it will eventually violate an ASSERT in MoveSelectionCommand that requires that there is a selection. To prevent this, expand the selection to the enclosing anchor tag when the drag begins.
15:53 Changeset [37533] by darin@apple.com

2008-10-12 Darin Adler <darin@apple.com>

Reviewed by Mark Rowe.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::getPseudoStyle): Keep walking up the parent chain until we hit an Element. Nowadays, Node::isElementNode() is just as efficient as RenderObject::isText(), and this guarantees that the node can be cast to Element*, which is done just below. The reason this is hit is that RenderLayer can call getPseudoStyle on a RenderView, which has the document as its element() -- and a document is neither a Text node nor an Element. A loose end is that this seems to mean you can't style the scrollbar corner or the resizer on a RenderView. Hyatt may want to look into that later.
15:51 Changeset [37532] by darin@apple.com

2008-10-12 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

  • wtf/unicode/icu/UnicodeIcu.h: Fixed indentation to match WebKit coding style.
  • wtf/unicode/qt4/UnicodeQt4.h: Ditto.
15:49 Changeset [37531] by darin@apple.com

JavaScriptCore:

2008-10-12 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

  • wtf/unicode/icu/UnicodeIcu.h: Removed isDigit, digitValue, and isFormatChar.
  • wtf/unicode/qt4/UnicodeQt4.h: Ditto.

WebCore:

2008-10-12 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

Tests: fast/dom/HTMLFontElement/size-attribute.html

fast/dom/HTMLInputElement/size-attribute.html
fast/dom/HTMLTableElement/cellpadding-attribute.html

  • html/HTMLFontElement.cpp: (WebCore::parseFontSizeNumber): Use isASCIIDigit instead of Unicode::isDigit, since non-ASCII digits are not valid here.
  • html/HTMLFontElement.h: Tweaked formatting a bit and removed the unneeded destructor declaration.
  • platform/text/String.cpp: (WebCore::lengthOfCharactersAsInteger): Use isASCIIDigit instead of Unicode::isDigit, since non-ASCII digits are not valid.

LayoutTests:

2008-10-12 Darin Adler <darin@apple.com>

Reviewed by Sam Weinig.

The fix was in a function used all over the place. I set a breakpoint in the
function and made some regression tests for the first few places it was used.

  • fast/dom/HTMLFontElement: Added.
  • fast/dom/HTMLFontElement/resources: Added.
  • fast/dom/HTMLFontElement/resources/TEMPLATE.html: Added.
  • fast/dom/HTMLFontElement/resources/size-attribute.js: Added.
  • fast/dom/HTMLFontElement/size-attribute-expected.txt: Added.
  • fast/dom/HTMLFontElement/size-attribute.html: Added.
  • fast/dom/HTMLInputElement/resources/size-attribute.js: Added.
  • fast/dom/HTMLInputElement/size-attribute-expected.txt: Added.
  • fast/dom/HTMLInputElement/size-attribute.html: Added.
  • fast/dom/HTMLTableElement/cellpadding-attribute-expected.txt: Added.
  • fast/dom/HTMLTableElement/cellpadding-attribute.html: Added.
  • fast/dom/HTMLTableElement/resources/cellpadding-attribute.js: Added.
15:38 Changeset [37530] by darin@apple.com

WebCore:

2008-10-12 Jungshik Shin <jshin@chromium.org>

Reviewed by Darin Adler.

Treat x-user-defined as windows-1252 for html files with meta charset
declaration to be compatible with Indian web sites.
( https://bugs.webkit.org/show_bug.cgi?id=18270 )

Test: fast/encoding/charset-xuser-defined.html

  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::setEncoding):

LayoutTests:

2008-10-12 Jungshik Shin <jshin@chromium.org>

Reviewed by Darin Adler.

Treat x-user-defined as windows-1252 for html files with meta charset
declaration to be compatible with Indian web sites.
( https://bugs.webkit.org/show_bug.cgi?id=18270 )

  • fast/encoding/charset-xuser-defined-expected.txt: Added.
  • fast/encoding/charset-xuser-defined.html: Added.
15:24 Changeset [37529] by darin@apple.com

2008-10-12 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

  • svg/custom/immutable-properties.html: Updated path to test resources so it does not go up out of and back into LayoutTests.
  • svg/custom/svg-modify-currentTranslate.html: Ditto.
  • svg/custom/svg-xml-dom-sync.html: Ditto.
  • svg/custom/tearoffs-with-tearoffs.html: Ditto.
  • svg/dynamic-updates/resources/*.js: Allow the make-js-test-wrappers script to add var successfullyParsed = true; to these files. It's not helpful for the tests, but it's not harmful either.
14:32 Changeset [37528] by weinig@apple.com

2008-10-12 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

Remove unneeded forward declaration.

  • platform/graphics/ImageBuffer.h:
13:43 Changeset [37527] by weinig@apple.com

2008-10-12 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

Fix for https://bugs.webkit.org/show_bug.cgi?id=21560
Layering violation: String should not be responsible for creating Lengths

It was a layering violation for String to know haw to parse
into Lengths, LengthArrays, and CoordsArrays.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::parseMappedAttribute):
  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::parseMappedAttribute):
  • platform/text/AtomicString.h: (WebCore::AtomicString::percentage):
  • platform/text/PlatformString.h:
  • platform/text/String.cpp:
  • platform/text/StringImpl.cpp:
  • platform/text/StringImpl.h:
  • rendering/Length.cpp: Added. (WebCore::parseLength): (WebCore::countCharacter): (WebCore::newCoordsArray): (WebCore::newLengthArray):
  • rendering/Length.h: (WebCore::LengthSize::LengthSize):
12:51 Changeset [37526] by andersca@apple.com

2008-10-12 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Make the append method that takes a Vector more strict - it now requires the elements
of the vector to be appended same type as the elements of the Vector they're being appended to.


This would cause problems when dealing with Vectors containing other Vectors.


  • wtf/Vector.h: (WTF::::append):
12:34 Changeset [37525] by darin@apple.com

2008-10-12 Darin Adler <darin@apple.com>

  • Scripts/make-js-test-wrappers: Update exceptions list so the script won't overwrite files and mangle tests.
11:23 Changeset [37524] by darin@apple.com

WebCore:

2008-10-12 Brad Garcia <bgarcia@google.com>

Reviewed by Darin Adler.

Interpret fractional percentage values for %MultiLength values.
Fix for https://bugs.webkit.org/show_bug.cgi?id=3591
Test: fast/frames/frame-length-fractional-percentage.html

  • platform/text/StringImpl.cpp: (WebCore::parseLength):

LayoutTests:

2008-10-12 Brad Garcia <bgarcia@google.com>

Reviewed by Darin Adler.

Testcases for fractional frame lengths.
https://bugs.webkit.org/show_bug.cgi?id=3591

  • fast/frames/frame-length-fractional.html: Added.
  • fast/frames/frame-length-fractional-expected.txt: Added.
10:04 Changeset [37523] by timothy@apple.com

Remember the expanded state of the rules in the Styles pane. So
collapsing a rule will persist across all the elements that have
that same rule. The same applies to Computed Style, so the Computed
Style rule is now collapsed by default. This should help lessen the
confusion on why Computed Style can't be edited (a common confusion.)

https://bugs.webkit.org/show_bug.cgi?id=21553

Reviewed by Darin Adler.

  • inspector/front-end/PropertiesSection.js: (WebInspector.PropertiesSection): Set the _expanded property directly, instead of using the setter. Expanded is the default, so no work is needed. This prevents calling StylesSidebarPane.collapse before object initialization is complete.
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update): Check the Preferences object for the expanded state of the StylePropertiesSection. Collapse computed style by default and expand everything else. (WebInspector.StylePropertiesSection): Make a semi unique identifier to be used when remembering expanded state. (WebInspector.StylePropertiesSection.prototype.expand): Set the expanded state to true for this identifier in Preferences.styleRulesExpandedState. Don't remember the state if the dontRememberState property is true. (WebInspector.StylePropertiesSection.prototype.collapse): Set the expanded state to false for this identifier in Preferences.styleRulesExpandedState.
  • inspector/front-end/inspector.js: (Preferences.styleRulesExpandedState): Initialize to an empty object.
04:47 Changeset [37522] by jmalonzo@webkit.org

2008-10-12 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Alp Toker.

[Gtk] Remove libWebCoreJS.la when doing make clean
https://bugs.webkit.org/show_bug.cgi?id=21544

Remove libWebCoreJS.la when doing a clean target

  • GNUmakefile.am: add libWebCoreJS.la to CLEANFILES

10/11/08:

23:50 Changeset [37521] by alp@webkit.org

2008-10-11 Alp Toker <alp@nuanti.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=20592
The focus ring is not shown while navigating on some pages

Fix drawFocusRing() so it doesn't depend on the current graphics
state, thus matching other platforms which already work this way.

This patch provides two code paths: one using straight Cairo and
one specialised for the GTK+ port with a more conventional appearance.

Also change focusRingColor() to return a null color, allowing the
focus ring to pick up the style's current color if it isn't overridden
with CSS.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawFocusRing):
  • platform/gtk/TemporaryLinkStubs.cpp: (WebCore::focusRingColor):
22:00 Changeset [37520] by cwzwarich@webkit.org

2008-10-11 Cameron Zwarich <zwarich@apple.com>

Reviewed by Sam Weinig.

Clean up RegExpMatchesArray.h to match our coding style.

  • kjs/RegExpMatchesArray.h: (JSC::RegExpMatchesArray::getOwnPropertySlot): (JSC::RegExpMatchesArray::put): (JSC::RegExpMatchesArray::deleteProperty): (JSC::RegExpMatchesArray::getPropertyNames):
21:56 Changeset [37519] by mitz@apple.com

Rubber-stamped by Sam Weinig.

  • change all internal callers to use Cache::evict() instead of remove()
  • loader/Cache.cpp: (WebCore::Cache::revalidateResource): (WebCore::Cache::revalidationSucceeded): (WebCore::Cache::pruneDeadResources): (WebCore::Cache::setDisabled):
21:26 Changeset [37518] by hyatt@apple.com

2008-10-11 David Hyatt <hyatt@apple.com>

Make sure invalidatePart knows how to invalidate the track and scrollbar backgrounds.

Reviewed by Tim Hatcher

  • platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::invalidatePart):
21:20 Changeset [37517] by hyatt@apple.com

2008-10-11 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21549 (regression in before/after track pieces).

Also fixed resizer positioning problems.

Reviewed by Tim Hatcher

  • platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::splitTrack): (WebCore::ScrollbarThemeComposite::trackPosition): (WebCore::ScrollbarThemeComposite::trackLength):
  • platform/ScrollbarThemeComposite.h: (WebCore::ScrollbarThemeComposite::constrainTrackRectToTrackPieces):
  • rendering/RenderLayer.cpp: (WebCore::scrollCornerRect): (WebCore::RenderLayer::positionOverflowControls): (WebCore::RenderLayer::paintOverflowControls): (WebCore::RenderLayer::isPointInResizeControl): (WebCore::RenderLayer::hitTestOverflowControls):
  • rendering/RenderScrollbarTheme.cpp: (WebCore::RenderScrollbarTheme::constrainTrackRectToTrackPieces):
  • rendering/RenderScrollbarTheme.h:
20:48 Changeset [37516] by mrowe@apple.com

Merge ASCIICType.h portion of r36244.

20:33 Changeset [37515] by alp@webkit.org

2008-10-11 Alp Toker <alp@nuanti.com>

Reviewed by David Hyatt.

Implement release/retain for Widget GTK+.

  • platform/Widget.cpp:
  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::~Widget): (WebCore::Widget::releasePlatformWidget): (WebCore::Widget::retainPlatformWidget):
18:38 Changeset [37514] by mrowe@apple.com

Fix ChangeLog header that was mangled in r37484.

18:31 Changeset [37513] by mrowe@apple.com

Disable animations/font-size-using-ems.html as it has been causing the following test, animatinos/generic-from-to.html, to hang since it was added.

16:10 Changeset [37512] by mitz@apple.com

Reviewed by Sam Weinig and Anders Carlsson.

  • update Mac DumpRenderTree to use the new WebView SPI for forcing the complex text code path
  • add --complex-text support to Windows DumpRenderTree
  • DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree):
  • DumpRenderTree/win/DumpRenderTree.cpp: (createWebViewAndOffscreenWindow): (main):
  • Scripts/run-webkit-tests:
15:53 Changeset [37511] by mitz@apple.com

WebCore:

Reviewed by Sam Weinig.

  • rename WebCoreSetAlwaysUseATSU to WebCoreSetAlwaysUsesComplexTextCodePath and add a corresponding getter; add the same functions on Windows
  • WebCore.base.exp:
  • platform/graphics/Font.cpp: (WebCore::Font::setCodePath): (WebCore::codePath): (WebCore::Font::canUseGlyphCache):
  • platform/graphics/Font.h:
  • platform/mac/WebCoreTextRenderer.h:
  • platform/mac/WebCoreTextRenderer.mm: (WebCoreSetAlwaysUsesComplexTextCodePath): (WebCoreAlwaysUsesComplexTextCodePath):
  • platform/win/WebCoreTextRenderer.cpp: (WebCore::WebCoreSetAlwaysUsesComplexTextCodePath): (WebCore::WebCoreAlwaysUsesComplexTextCodePath):
  • platform/win/WebCoreTextRenderer.h:

WebKit/mac:

Reviewed by Sam Weinig.

  • rename _setAlwaysUseATSU to _setAlwaysUsesComplexTextCodePath and update it for the renamed WebCoreTextRenderer method; keep the old method around for clients that use it
  • WebView/WebView.mm: (+[WebView _setAlwaysUseATSU:]): (+[WebView _setAlwaysUsesComplexTextCodePath:]):
  • WebView/WebViewPrivate.h:

WebKit/win:

Reviewed by Sam Weinig.

  • add SPI for forcing the complex text code path to be used for all text
  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp: (WebView::setAlwaysUsesComplexTextCodePath): (WebView::alwaysUsesComplexTextCodePath):
  • WebView.h:
15:20 Changeset [37510] by weinig@apple.com

2008-10-11 Sam Weinig <sam@webkit.org>

Reviewed by Cameron Zwarich.

Stop leaking the event parameter names. The protected strings were showing up
in the caches window after one use. No measurable performance loss.

  • bindings/js/JSEventListener.cpp: (WebCore::eventParameterName):
15:10 Changeset [37509] by weinig@apple.com

2008-10-11 Sam Weinig <sam@webkit.org>

Reviewed by Cameron Zwarich.

Remove unused function getNodeEventListener.

  • bindings/js/JSEventListener.cpp:
  • bindings/js/JSEventListener.h:
13:58 Changeset [37508] by cwzwarich@webkit.org

2008-10-11 Cameron Zwarich <zwarich@apple.com>

Reviewed by Sam Weinig.

Bug 21525: 55 StructureID leaks on Wikitravel's main page
<https://bugs.webkit.org/show_bug.cgi?id=21525>

Bug 21533: Simple JavaScript code leaks StructureIDs
<https://bugs.webkit.org/show_bug.cgi?id=21533>

StructureID::getEnumerablePropertyNames() ends up calling back to itself
via JSObject::getPropertyNames(), which causes the PropertyNameArray to
be cached twice. This leads to a memory leak in almost every use of
JSObject::getPropertyNames() on an object. The fix here is based on a
suggestion of Sam Weinig.

This patch also fixes every StructureID leaks that occurs while running
the Mozilla MemBuster test.

  • kjs/PropertyNameArray.h: (JSC::PropertyNameArray::PropertyNameArray): (JSC::PropertyNameArray::setCacheable): (JSC::PropertyNameArray::cacheable):
  • kjs/StructureID.cpp: (JSC::StructureID::getEnumerablePropertyNames):
00:50 Changeset [37507] by hyatt@apple.com

2008-10-11 David Hyatt <hyatt@apple.com>

Add support for both positive and negative margins to tracks and track pieces.

Reviewed by Tim Hatcher

  • platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::paint): (WebCore::ScrollbarThemeComposite::hitTest): (WebCore::ScrollbarThemeComposite::splitTrack): (WebCore::ScrollbarThemeComposite::trackPieceRects): (WebCore::ScrollbarThemeComposite::trackPosition): (WebCore::ScrollbarThemeComposite::trackLength):
  • platform/ScrollbarThemeComposite.h: (WebCore::ScrollbarThemeComposite::adjustTrackPieceRect):
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::trackRect): (WebCore::RenderScrollbar::trackPieceRectWithMargins):
  • rendering/RenderScrollbar.h:
  • rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::computeScrollbarWidth): (WebCore::RenderScrollbarPart::computeScrollbarHeight):
  • rendering/RenderScrollbarTheme.cpp: (WebCore::RenderScrollbarTheme::adjustTrackPieceRect):
  • rendering/RenderScrollbarTheme.h:

10/10/08:

23:33 Changeset [37506] by hyatt@apple.com

Update scrollbars layout tests to new syntax.

23:30 Changeset [37505] by hyatt@apple.com

2008-10-10 David Hyatt <hyatt@apple.com>

Drop -webkit-scrollbar- from all the scrollbar pseudo-classes, since they are scoped to
the scrollbar pseudo-elements anyway.

Reviewed by Tim Hatcher

  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
23:26 Changeset [37504] by mitz@apple.com

Reviewed by Sam Weinig.

  • separate Cache::remove() into a private method and a public interface, then make Cache::pruneDeadResources() use the private method.
  • loader/Cache.cpp: (WebCore::Cache::pruneDeadResources): (WebCore::Cache::evict):
  • loader/Cache.h: (WebCore::Cache::remove):
23:12 Changeset [37503] by hyatt@apple.com

2008-10-10 David Hyatt <hyatt@apple.com>

Fix a math error when splitting a vertical track. Clean up more of ScrollbarThemeComposite
now that the track pieces meet under the thumb.

Reviewed by Tim Hatcher

  • platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::paint): (WebCore::ScrollbarThemeComposite::splitTrack):
23:04 Changeset [37502] by hyatt@apple.com

2008-10-10 David Hyatt <hyatt@apple.com>

Make the track pieces of a scrollbar extend under the thumb (each gets half the thumb).

Reviewed by Tim Hatcher

  • platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::hitTest): (WebCore::ScrollbarThemeComposite::splitTrack):
22:54 Changeset [37501] by hyatt@apple.com

2008-10-10 David Hyatt <hyatt@apple.com>

Make sure specialized ::scrollbar rules are still triggering custom scrollbar creation.

Reviewed by Tim Hatcher

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar):
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::createCustomScrollbar): (WebCore::RenderScrollbar::RenderScrollbar): (WebCore::RenderScrollbar::setParent): (WebCore::RenderScrollbar::updateScrollbarParts): (WebCore::RenderScrollbar::updateScrollbarPart):
  • rendering/RenderScrollbar.h:
  • rendering/style/RenderStyle.h: (WebCore::RenderStyle::):
22:49 Changeset [37500] by oliver@apple.com

Use fastcall calling convention on GCC > 4.0

Reviewed by Cameron Zwarich

Results in a 2-3% improvement in GCC 4.2 performance, so
that it is no longer a regression vs. GCC 4.0

22:30 Changeset [37499] by hyatt@apple.com

2008-10-10 David Hyatt <hyatt@apple.com>

Make sure scrollbar background images cause proper part invalidation to occur.

Reviewed by Tim Hatcher

  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::setHoveredPart): (WebCore::RenderScrollbar::setPressedPart):
  • rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::styleDidChange): (WebCore::RenderScrollbarPart::imageChanged):
  • rendering/RenderScrollbarPart.h:
19:53 Changeset [37498] by weinig@apple.com

JavaScriptCore:

2008-10-10 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

  • Add a workaround for a bug in ceil in Darwin libc.
  • Remove old workarounds for JS math functions that are not needed anymore.

The math functions are heavily tested by fast/js/math.html.

  • kjs/MathObject.cpp: (JSC::mathProtoFuncAbs): Remove workaround. (JSC::mathProtoFuncCeil): Ditto. (JSC::mathProtoFuncFloor): Ditto.
  • wtf/MathExtras.h: (wtf_ceil): Add ceil workaround for darwin.

LayoutTests:

2008-10-10 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler.

  • Update tests after fixing ceil(-0.1) behavior on darwin.
  • fast/js/math-expected.txt:
  • fast/js/resources/math.js: Remove code to detect sign of 0 now that the harness can handle it.
  • fast/xpath/4XPath/Core/test_core_functions-expected.txt:
  • fast/xpath/4XPath/Core/test_core_functions.html: Update test expect correct result of -0.
19:05 Changeset [37497] by weinig@apple.com

2008-10-10 Sam Weinig <sam@webkit.org>

Reviewed by Darin Adler

Add Assertions to JSObject constructor.

  • kjs/JSObject.h: (JSC::JSObject::JSObject):
17:35 Changeset [37496] by simon.fraser@apple.com

2008-10-10 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=21538

The blendFunc() for TransformOperations should never mess with the
operation lists by replacing some ops with identity, otherwise the lists
no longer match and transitions break.

Test: transitions/matched-transform-functions.html

  • page/animation/AnimationBase.cpp: (WebCore::blendFunc):
17:32 Changeset [37495] by simon.fraser@apple.com

2008-10-10 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler

https://bugs.webkit.org/show_bug.cgi?id=21537

Fix re-targetting a running transition; if the target property
changes, we do need to make a new ImplicitAnimation.

Test: transitions/retargetted-transition.html

  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimationPrivate::updateTransitions):
16:21 Changeset [37494] by oliver@apple.com

Part of <rdar://problem/6278147> Cannot stop a slow script -- Fix assertion

Reviewed by Cameron Zwarich

When JS is terminated by the user choosing to stop a slow script
the exception toString method throws, yet the console logger does
not perform exception checks after logging. This leaves an
exception on the Machine, which in turn results in an assertion
failure next time we attempt to enter JS. The solution is just to
clear the exception state after attempting to record the exception.

15:24 Changeset [37493] by hyatt@apple.com

2008-10-10 David Hyatt <hyatt@apple.com>

Make textareas work with custom CSS scrollbars and resizers. Need to access the correct renderer
when looking for pseudo styles.

Reviewed by Tim Hatcher

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): (WebCore::RenderLayer::styleChanged):
15:19 Changeset [37492] by dino@apple.com

2008-10-10 Dean Jackson <dino@apple.com>

Keyframe example had "0" rather than "0%".

  • WebKitSite/specs/CSSVisualEffects/CSSAnimations.html:
15:16 Changeset [37491] by hyatt@apple.com

2008-10-10 David Hyatt <hyatt@apple.com>

Add the ability to style the scroll corner and the resizer from CSS.

Reviewed by Tim Hatcher

  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::~RenderLayer): (WebCore::RenderLayer::paintOverflowControls): (WebCore::RenderLayer::paintScrollCorner): (WebCore::RenderLayer::paintResizer): (WebCore::RenderLayer::styleChanged):
  • rendering/RenderLayer.h:
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::updateScrollbarPart): (WebCore::RenderScrollbar::paintPart):
  • rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::RenderScrollbarPart): (WebCore::RenderScrollbarPart::paintIntoRect):
  • rendering/RenderScrollbarPart.h:
  • rendering/style/RenderStyle.h: (WebCore::RenderStyle::):
14:05 Changeset [37490] by hyatt@apple.com

2008-10-10 David Hyatt <hyatt@apple.com>

Make CSS scrollbars respect the OS setting regarding where buttons should be placed.

Reviewed by Sam Weinig

No test case possible, since the OS setting can vary.

  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
  • platform/Scrollbar.h: (WebCore::Scrollbar::styleChanged):
  • platform/mac/ScrollbarThemeMac.mm: (+[ScrollbarPrefsObserver appearancePrefsChanged:]): (WebCore::ScrollbarThemeMac::preferencesChanged):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::invalidateScrollbarRect):
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::styleChanged): (WebCore::RenderScrollbar::updateScrollbarPart):
  • rendering/RenderScrollbar.h:
  • rendering/RenderScrollbarTheme.h: (WebCore::RenderScrollbarTheme::buttonsPlacement):
13:43 Changeset [37489] by adachan@apple.com

Bug 21526: The hashmap webPreferencesInstances in WebPreferences.cpp can
potentially hold onto stale instances of WebPreferences
https://bugs.webkit.org/show_bug.cgi?id=21526


webPreferencesInstances now keeps a reference to all the instances it holds.
Fix up callers of WebPreferences::removeReferenceForIdentifier() to call
it after they have released their references to the WebPreferences objects.

Reviewed by Adam Roben.

  • WebPreferences.cpp: (WebPreferences::getInstanceForIdentifier): (WebPreferences::removeReferenceForIdentifier):
  • WebView.cpp: (WebView::close): (WebView::setPreferences):
13:27 Changeset [37488] by timothy@apple.com

Fixes a regression with input search fields, where the placeholder text
would not be updated when the value of the placeholder attribute changed.

https://bugs.webkit.org/show_bug.cgi?id=21521

Reviewed by Adele Peterson.

Test: fast/forms/search-placeholder-value-changed.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): Pass true for the placeholderValueChanged parameter of updatePlaceholderVisibility. (WebCore::HTMLInputElement::updatePlaceholderVisibility): Add parameter for placeholderValueChanged that informs the method that the value changed.
  • html/HTMLInputElement.h: Add the placeholderValueChanged to the updatePlaceholderVisibility method. Made it default to false.
13:12 Changeset [37487] by hyatt@apple.com

2008-10-10 David Hyatt <hyatt@apple.com>

Allow the track part to have negative margins so that it can slightly overlap buttons. This
is necessary to emulate the Aqua look in CSS.

Reviewed by Sam Weinig

  • platform/ScrollbarThemeComposite.cpp: (WebCore::ScrollbarThemeComposite::paint): (WebCore::ScrollbarThemeComposite::hitTest):
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::setHoveredPart): (WebCore::RenderScrollbar::trackRect):
  • rendering/RenderScrollbar.h:
  • rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::computeScrollbarWidth): (WebCore::RenderScrollbarPart::computeScrollbarHeight):
  • rendering/RenderScrollbarTheme.cpp: (WebCore::RenderScrollbarTheme::backButtonRect): (WebCore::RenderScrollbarTheme::forwardButtonRect): (WebCore::RenderScrollbarTheme::trackRect):
12:32 Changeset [37486] by hyatt@apple.com

2008-10-10 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21527

Make CSS scrollbars support :not, :hover and :active.

Reviewed by Adam Roben

Added WebCore/manual-tests/scrollbar-hover-active.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
  • platform/Scrollbar.cpp: (WebCore::Scrollbar::autoscrollPressedPart): (WebCore::Scrollbar::startTimerIfNeeded): (WebCore::Scrollbar::setHoveredPart): (WebCore::Scrollbar::setPressedPart): (WebCore::Scrollbar::mouseMoved): (WebCore::Scrollbar::mouseExited): (WebCore::Scrollbar::mouseUp): (WebCore::Scrollbar::mouseDown):
  • platform/Scrollbar.h:
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::setHoveredPart): (WebCore::RenderScrollbar::setPressedPart): (WebCore::RenderScrollbar::updateScrollbarParts): (WebCore::pseudoForScrollbarPart): (WebCore::RenderScrollbar::updateScrollbarPart):
  • rendering/RenderScrollbar.h:
11:43 Changeset [37485] by cmarrin@apple.com

2008-10-10 Chris Marrin <cmarrin@apple.com>

Reviewed by Dan Bernstein.

Fix for https://bugs.webkit.org/show_bug.cgi?id=21025
CSS transition with duration=0 and delay=0 doesn't override ongoing transition

Test: transitions/interrupt-zero-duration.html

  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions):
11:04 Changeset [37484] by cmarrin@apple.com

2008-10-09 Chris Marrin <cmarrin@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=21310

Redesigned how animation events are sent in order to get rid of
AnimationEventDispatcher. ImplicitAnimation and KeyframeAnimation
are now ref counted. While calling the event handler, I keep a
reference to this class to avoid it getting destroyed out from under me.

I also moved most of the functionality of CompositeAnimation to
and internal class (CompositeAnimationPrivate) to reduce the exposure
of the internals of the various animation classes.

We have several transition and animation LayoutTests which verify that
this fix works as expected and continues to avoid crashes.

10:13 Changeset [37483] by kevino@webkit.org

wx build fix. Add new scrollbar-related sources.

09:59 Changeset [37482] by hyatt@apple.com

WebCore:

2008-10-10 David Hyatt <hyatt@apple.com>

https://bugs.webkit.org/show_bug.cgi?id=21522

Support increment/decrement/start/end on scrollbars. Allows a fully functional scrollbar to be
created. (Just :hover/:active left to finish it up.)

Reviewed by Adam Roben

Added scrollbars/scrollbar-buttons.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):

LayoutTests:

2008-10-10 David Hyatt <hyatt@apple.com>

Add test for scrollbar buttons and track supporting increment/decrement/start/end.

Reviewed by Adam Roben

  • platform/mac/scrollbars/scrollbar-buttons-expected.checksum: Added.
  • platform/mac/scrollbars/scrollbar-buttons-expected.png: Added.
  • platform/mac/scrollbars/scrollbar-buttons-expected.txt: Added.
  • scrollbars/scrollbar-buttons.html: Added.
09:40 Changeset [37481] by hyatt@apple.com

Land updated layout test after pseudoclass rename.

09:40 Changeset [37480] by hyatt@apple.com

2008-10-10 David Hyatt <hyatt@apple.com>

Rename some pseudoclasses. Removing "-scrollbar-" from a bunch of the pseudoclasses. Renaming
back/forward to decrement/increment. Adding start/end pseudoclasses.

Reviewed by Eric Seidel

  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
00:18 Changeset [37479] by weinig@apple.com

2008-10-10 Sam Weinig <sam@webkit.org>

Reviewed by Cameron Zwarich.

Remove now unused m_getterSetterFlag variable from PropertyMap.

  • kjs/PropertyMap.cpp: (JSC::PropertyMap::operator=):
  • kjs/PropertyMap.h: (JSC::PropertyMap::PropertyMap):
00:15 Changeset [37478] by hyatt@apple.com

Fix build.

00:15 Changeset [37477] by hyatt@apple.com

2008-10-10 David Hyatt <hyatt@apple.com>

Switch window-active to window-inactive, since that will work better as far as degrading in other
browsers.

Reviewed by Tim Hatcher

  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
00:06 Changeset [37476] by timothy@apple.com

Yet another Tiger build fix.

00:04 Changeset [37475] by hyatt@apple.com

WebCore:

2008-10-09 David Hyatt <hyatt@apple.com>

Add support for scrollbar orientation as a pseudoclass. Add support for whether or not the scrollbar
is active as well.

Reviewed by Tim Hatcher

Added scrollbars/scrollbar-orientation.html

  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
  • platform/Scrollbar.cpp: (WebCore::Scrollbar::isWindowActive):
  • platform/Scrollbar.h:
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::paint): (WebCore::RenderScrollbar::partForStyleResolve):
  • rendering/RenderScrollbar.h:

LayoutTests:

2008-10-09 David Hyatt <hyatt@apple.com>

Add layout test for scrollbars honoring orientation and window active state.

Reviewed by Tim Hatcher

  • platform/mac/scrollbars/scrollbar-orientation-expected.checksum: Added.
  • platform/mac/scrollbars/scrollbar-orientation-expected.png: Added.
  • platform/mac/scrollbars/scrollbar-orientation-expected.txt: Added.
  • scrollbars/scrollbar-orientation.html: Added.
Note: See TracTimeline for information about the timeline view.