Timeline



Nov 2, 2008:

1:14 PM Changeset in webkit [38068] by pewtermoose@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-02 Matt Lilek <​webkit@mattlilek.com>

Reviewed by Cameron Zwarich.

Bug 22042: REGRESSION(r38066): ASSERTION FAILED: source in CodeBlock
<​https://bugs.webkit.org/show_bug.cgi?id=22042>

Rename parameter name to avoid ASSERT.

  • VM/CodeBlock.h: (JSC::CodeBlock::CodeBlock): (JSC::ProgramCodeBlock::ProgramCodeBlock): (JSC::EvalCodeBlock::EvalCodeBlock):
12:23 PM Changeset in webkit [38067] by christian@webkit.org
  • 4 edits in trunk

2008-11-02 Xan Lopez <​xan@gnome.org>

Reviewed by Holger Freyther

​https://bugs.webkit.org/show_bug.cgi?id=22009
HTML5 Video with GStreamer pulls gnome-vfs without using it.

  • configure.ac: Remove gnome-vfs from configure.ac, it's unused.
3:29 AM Changeset in webkit [38066] by cwzwarich@webkit.org
  • 4 edits in trunk/JavaScriptCore

2008-11-02 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Oliver Hunt.

Bug 22035: Remove the '_' suffix on constructor parameter names for structs
<​https://bugs.webkit.org/show_bug.cgi?id=22035>

  • API/JSCallbackObject.h: (JSC::JSCallbackObject::JSCallbackObjectData::JSCallbackObjectData):
  • VM/CodeBlock.h: (JSC::CodeBlock::CodeBlock): (JSC::ProgramCodeBlock::ProgramCodeBlock): (JSC::EvalCodeBlock::EvalCodeBlock):
  • wrec/WREC.h: (JSC::Quantifier::Quantifier):

Nov 1, 2008:

2:31 AM Changeset in webkit [38065] by abarth@webkit.org
  • 6 edits
    6 adds in trunk

WebCore:

2008-11-01 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Be sure to check the final URLs of requested resources to make sure we
don't get fooled by HTTP redirects.

​https://bugs.webkit.org/show_bug.cgi?id=21963

Tests: http/tests/security/xss-DENIED-xsl-document-redirect.xml

http/tests/security/xss-DENIED-xsl-external-entity-redirect.xml

  • dom/XMLTokenizerLibxml2.cpp: (WebCore::openFunc):
  • loader/DocLoader.cpp: (WebCore::DocLoader::canRequest): (WebCore::DocLoader::requestResource):
  • loader/DocLoader.h:
  • xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc):

LayoutTests:

2008-11-01 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Test that we properly block non-same-origin redirects for these
esoteric loads.

​https://bugs.webkit.org/show_bug.cgi?id=21963

  • http/tests/security/resources/xsl-using-document-redirect.xsl: Added.
  • http/tests/security/resources/xsl-using-external-entity-redirect.xsl: Added.
  • http/tests/security/xss-DENIED-xsl-document-redirect-expected.txt: Copied from LayoutTests/http/tests/security/xss-DENIED-xsl-document-expected.txt.
  • http/tests/security/xss-DENIED-xsl-document-redirect.xml: Added.
  • http/tests/security/xss-DENIED-xsl-external-entity-redirect-expected.txt: Copied from LayoutTests/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt.
  • http/tests/security/xss-DENIED-xsl-external-entity-redirect.xml: Added.
12:21 AM Changeset in webkit [38064] by ap@webkit.org
  • 10 edits
    2 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=22001
AtomicStringImpl* keys of event listener maps can outlive their strings

Test: fast/events/destroyed-atomic-string.html

  • dom/MessagePort.cpp: (WebCore::MessagePort::addEventListener): (WebCore::MessagePort::removeEventListener): (WebCore::MessagePort::dispatchEvent):
  • dom/MessagePort.h:
  • loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::addEventListener): (WebCore::DOMApplicationCache::removeEventListener): (WebCore::DOMApplicationCache::dispatchEvent):
  • loader/appcache/DOMApplicationCache.h:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::addEventListener): (WebCore::XMLHttpRequest::removeEventListener): (WebCore::XMLHttpRequest::dispatchEvent):
  • xml/XMLHttpRequest.h:
  • xml/XMLHttpRequestUpload.cpp: (WebCore::XMLHttpRequestUpload::addEventListener): (WebCore::XMLHttpRequestUpload::removeEventListener): (WebCore::XMLHttpRequestUpload::dispatchEvent):
  • xml/XMLHttpRequestUpload.h: Changed EventListenersMap to use AtomicString as key (instead of AtomicStringImpl*).
12:11 AM Changeset in webkit [38063] by ap@webkit.org
  • 22 edits in trunk/WebCore

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=21998
Use JSDOMGlobalObject in EventListener-related bindings

  • dom/MessagePort.idl: Auto-generate bindings for onclose and onmessage.
  • bindings/scripts/CodeGeneratorJS.pm: Use JSDOMGlobalObject instead of JSDOMWindow in JS bindings for inline event handlers.
  • bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener):
  • bindings/js/JSEventTargetNodeCustom.cpp: (WebCore::JSEventTargetNode::addEventListener): (WebCore::JSEventTargetNode::removeEventListener):
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::removeEventListener):
  • bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::addEventListener): (WebCore::JSSVGElementInstance::removeEventListener):
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener):
  • bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener): Use ScriptExecutionContext and JSDOMGlobalObject in bindings.
  • dom/EventTarget.h:
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::scriptExecutionContext):
  • dom/EventTargetNode.h:
  • dom/MessagePort.cpp:
  • dom/MessagePort.h: (WebCore::MessagePort::scriptExecutionContext):
  • loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::scriptExecutionContext):
  • loader/appcache/DOMApplicationCache.h:
  • svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::scriptExecutionContext):
  • svg/SVGElementInstance.h:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::scriptExecutionContext):
  • xml/XMLHttpRequest.h:
  • xml/XMLHttpRequestUpload.cpp: (WebCore::XMLHttpRequestUpload::scriptExecutionContext):
  • xml/XMLHttpRequestUpload.h: Remove associatedFrame() method, and provide scriptExecutionContext() where it wasn't available yet.

Oct 31, 2008:

9:28 PM Changeset in webkit [38062] by Stephanie Lewis
  • 2 edits in trunk/JavaScriptGlue

2008-10-31 Stephanie Lewis <Stephanie Lewis>

Fix build by including right files.

  • JSRun.cpp:
6:05 PM Changeset in webkit [38061] by cwzwarich@webkit.org
  • 13 edits
    2 moves in trunk

2008-10-31 Cameron Zwarich <​zwarich@apple.com>

Rubber-stamped by Geoff Garen.

Rename SourceRange.h to SourceCode.h.

JavaScriptCore:

  • API/JSBase.cpp:
  • GNUmakefile.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • VM/CodeBlock.h:
  • kjs/SourceCode.h: Copied from kjs/SourceRange.h.
  • kjs/SourceRange.h: Removed.
  • kjs/grammar.y:
  • kjs/lexer.h:
  • kjs/nodes.cpp: (JSC::ForInNode::ForInNode):
  • kjs/nodes.h: (JSC::ThrowableExpressionData::setExceptionSourceCode):

WebCore:

  • ForwardingHeaders/kjs/SourceCode.h: Copied from ForwardingHeaders/kjs/SourceRange.h.
  • ForwardingHeaders/kjs/SourceRange.h: Removed.
  • bindings/js/StringSourceProvider.h:
  • bridge/NP_jsobject.cpp:
5:35 PM Changeset in webkit [38060] by cwzwarich@webkit.org
  • 10 edits in trunk

2008-10-31 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Darin Adler.

Bug 22019: Move JSC::Interpreter::shouldPrintExceptions() to WebCore::Console
<​https://bugs.webkit.org/show_bug.cgi?id=22019>

The JSC::Interpreter::shouldPrintExceptions() function is not used at
all in JavaScriptCore, so it should be moved to WebCore::Console, its
only user.

JavaScriptCore:

WebCore:

  • WebCore.base.exp:
  • page/Console.cpp: (WebCore::printToStandardOut): (WebCore::Console::shouldPrintExceptions): (WebCore::Console::setShouldPrintExceptions):
  • page/Console.h:

WebKit/mac:

  • Misc/WebCoreStatistics.mm: (+[WebCoreStatistics shouldPrintExceptions]): (+[WebCoreStatistics setShouldPrintExceptions:]):
5:26 PM Changeset in webkit [38059] by christian@webkit.org
  • 2 edits in trunk/WebKit/gtk

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=22018
enable-developer-extras doesn't toggle WebInspector

  • webkit/webkitwebview.cpp:

Add missing 'if' in notification for 'enable-developer-extras'.

4:35 PM Changeset in webkit [38058] by mitz@apple.com
  • 12 edits in trunk

WebCore:

Reviewed by John Sullivan.

  • WebCore part of <rdar://problem/6334641> Add WebView SPI for disabling document.cookie
  • dom/Document.cpp: (WebCore::Document::cookie): Added checking if cookies are disabled. (WebCore::Document::setCookie): Ditto.
  • page/Navigator.cpp: (WebCore::Navigator::cookieEnabled): Ditto.
  • page/Page.cpp: (WebCore::Page::Page): Initialize m_cookieEnabled to true.
  • page/Page.h: (WebCore::Page::cookieEnabled): Added. (WebCore::Page::setCookieEnabled): Added.

WebKit/mac:

Reviewed by John Sullivan.

  • WebKit/mac part of <rdar://problem/6334641> Add WebView SPI for disabling document.cookie
  • WebView/WebView.mm: (-[WebView _cookieEnabled]): (-[WebView _setCookieEnabled:]):
  • WebView/WebViewPrivate.h:

WebKit/win:

Reviewed by John Sullivan.

  • WebKit/win part of <rdar://problem/6334641> Add WebView SPI for disabling document.cookie
  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp: (WebView::setCookieEnabled): (WebView::cookieEnabled):
  • WebView.h:
4:25 PM Changeset in webkit [38057] by adele@apple.com
  • 11 edits in trunk

WebCore:

2008-10-31 Adele Peterson <​adele@apple.com>

Reviewed by Darin Adler.

WebCore Windows part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.
​https://bugs.webkit.org/show_bug.cgi?id=22008

  • platform/FileChooser.cpp: (WebCore::FileChooser::chooseIcon): Rename newIconForFile and newIconForFiles to createIconForFile and createIconForFiles.
  • platform/graphics/Icon.h: ditto.
  • platform/graphics/gtk/IconGtk.cpp: (WebCore::Icon::createIconForFile): ditto. (WebCore::Icon::createIconForFiles): ditto.
  • platform/graphics/mac/IconMac.mm: (WebCore::Icon::createIconForFile): ditto. (WebCore::Icon::createIconForFiles): ditto.
  • platform/graphics/qt/IconQt.cpp: (WebCore::Icon::createIconForFile): ditto. (WebCore::Icon::createIconForFiles): ditto.
  • platform/wx/TemporaryLinkStubs.cpp: (Icon::createIconForFile): ditto. (Icon::createIconForFiles): ditto.
  • platform/graphics/win/IconWin.cpp: (WebCore::Icon::createIconForFile): ditto. (WebCore::Icon::createIconForFiles): Add creation of an icon for multiple files.
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration): Improve icon creation code to match new code in Icon::createIconForFiles

WebKit/win:

2008-10-31 Adele Peterson <​adele@apple.com>

Reviewed by Darin Adler.

WebKit Windows part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.
​https://bugs.webkit.org/show_bug.cgi?id=22008


  • WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::runOpenPanel): Add support for mulitple file selection.
3:56 PM Changeset in webkit [38056] by andersca@apple.com
  • 2 edits in trunk/WebKit

2008-10-31 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

Move WebNetscapePluginEventHandler classes to a subgroup of Netscape Plug-Ins.


  • WebKit.xcodeproj/project.pbxproj:
3:26 PM Changeset in webkit [38055] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-10-31 Cameron Zwarich <​zwarich@apple.com>

Not reviewed.

Windows build fix.

3:18 PM Changeset in webkit [38054] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-10-31 Cameron Zwarich <​zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Remove the call to Interpreter::setShouldPrintExceptions() from the
GlobalObject constructor in the shell. The shouldPrintExceptions()
information is not used anywhere in JavaScriptCore, only in WebCore.

  • kjs/Shell.cpp: (GlobalObject::GlobalObject):
2:59 PM Changeset in webkit [38053] by kevino@webkit.org
  • 4 edits in trunk

A couple wxMSW build fixes.

2:40 PM Changeset in webkit [38052] by cwzwarich@webkit.org
  • 6 edits
    7 moves in trunk/JavaScriptCore

2008-10-31 Cameron Zwarich <​zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Move more files from the kjs subdirectory of JavaScriptCore to the
runtime subdirectory.

  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • kjs/AllInOneFile.cpp:
  • kjs/RegExpConstructor.cpp: Removed.
  • kjs/RegExpConstructor.h: Removed.
  • kjs/RegExpMatchesArray.h: Removed.
  • kjs/RegExpObject.cpp: Removed.
  • kjs/RegExpObject.h: Removed.
  • kjs/RegExpPrototype.cpp: Removed.
  • kjs/RegExpPrototype.h: Removed.
  • runtime/RegExpConstructor.cpp: Copied from kjs/RegExpConstructor.cpp.
  • runtime/RegExpConstructor.h: Copied from kjs/RegExpConstructor.h.
  • runtime/RegExpMatchesArray.h: Copied from kjs/RegExpMatchesArray.h.
  • runtime/RegExpObject.cpp: Copied from kjs/RegExpObject.cpp.
  • runtime/RegExpObject.h: Copied from kjs/RegExpObject.h.
  • runtime/RegExpPrototype.cpp: Copied from kjs/RegExpPrototype.cpp.
  • runtime/RegExpPrototype.h: Copied from kjs/RegExpPrototype.h.
2:19 PM Changeset in webkit [38051] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Revert an incorrect portion of r38034.

  • profiler/ProfilerServer.mm:
2:19 PM Changeset in webkit [38050] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix the 64-bit build.

Disable strict aliasing in ProfilerServer.mm as it leads to the compiler being unhappy
with the common Obj-C idiom self = [super init];

1:47 PM Changeset in webkit [38049] by cwzwarich@webkit.org
  • 2 edits in trunk/WebKitTools

2008-10-31 Cameron Zwarich <​zwarich@apple.com>

Not reviewed.

  • Scripts/do-webcore-rename:

Add some renames to contemplate for the future.

1:44 PM Changeset in webkit [38048] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-10-31 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Alexey Proskuryakov.

Change a header guard to match our coding style.

  • kjs/InitializeThreading.h:
12:59 PM Changeset in webkit [38047] by ggaren@apple.com
  • 14 edits
    1 add
    2 deletes in trunk/JavaScriptCore

2008-10-30 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.


Fixed a small bit of ​https://bugs.webkit.org/show_bug.cgi?id=21962
AST uses way too much memory


Removed a word from StatementNode by nixing LabelStack and turning it
into a compile-time data structure managed by CodeGenerator.


v8 tests and SunSpider, run by Gavin, report no change.


  • VM/CodeGenerator.cpp: (JSC::CodeGenerator::CodeGenerator): (JSC::CodeGenerator::newLabelScope): (JSC::CodeGenerator::breakTarget): (JSC::CodeGenerator::continueTarget):
  • VM/CodeGenerator.h: Nixed the JumpContext system because it depended on a LabelStack in the AST, and it was a little cumbersome on the client side. Replaced with LabelScope, which tracks all break / continue information in the CodeGenerator, just like we track LabelIDs and other stacks of compile-time data.
  • kjs/LabelScope.h: Added. (JSC::LabelScope::): (JSC::LabelScope::LabelScope): (JSC::LabelScope::ref): (JSC::LabelScope::deref): (JSC::LabelScope::refCount): (JSC::LabelScope::breakTarget): (JSC::LabelScope::continueTarget): (JSC::LabelScope::type): (JSC::LabelScope::name): (JSC::LabelScope::scopeDepth): Simple abstraction for holding everything you might want to know about a break-able / continue-able scope.
  • kjs/LabelStack.cpp: Removed.
  • kjs/LabelStack.h: Removed.
  • kjs/grammar.y: No need to push labels at parse time -- we don't store LabelStacks in the AST anymore.
  • kjs/nodes.cpp: (JSC::DoWhileNode::emitCode): (JSC::WhileNode::emitCode): (JSC::ForNode::emitCode): (JSC::ForInNode::emitCode): (JSC::ContinueNode::emitCode): (JSC::BreakNode::emitCode): (JSC::SwitchNode::emitCode): (JSC::LabelNode::emitCode):
  • kjs/nodes.h: (JSC::StatementNode::): (JSC::LabelNode::): Use LabelScope where we used to use JumpContext. Simplified a bunch of code. Touched up label-related error messages a bit.
  • kjs/nodes2string.cpp: (JSC::LabelNode::streamTo): Updated for rename.
12:53 PM Changeset in webkit [38046] by cwzwarich@webkit.org
  • 8 edits
    2 copies in trunk/JavaScriptCore

2008-10-31 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Darin Adler.

Bug 22005: Move StructureIDChain into its own file
<​https://bugs.webkit.org/show_bug.cgi?id=22005>

  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • runtime/StructureID.cpp:
  • runtime/StructureID.h:
  • runtime/StructureIDChain.cpp: Copied from runtime/StructureID.cpp.
  • runtime/StructureIDChain.h: Copied from runtime/StructureID.h.
12:53 PM Changeset in webkit [38045] by Darin Adler
  • 2 edits in trunk/WebKitTools

2008-10-31 Darin Adler <Darin Adler>

Requested by Mark Rowe.

  • Scripts/check-for-global-initializers: s/Web Kit/WebKit/.
12:44 PM Changeset in webkit [38044] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-10-31 Steve Falkenburg <​sfalken@apple.com>

Build fix.

12:35 PM Changeset in webkit [38043] by beidson@apple.com
  • 1 edit in trunk/WebKit/mac/ChangeLog

Expand that name!

12:34 PM Changeset in webkit [38042] by beidson@apple.com
  • 2 edits in trunk/WebKit/mac

2008-10-31 Brady Eidson <​beidson@apple.com>

Reviewed by Darin

[WebHistory setLastVisitedTimeInterval:forItem] was internal to WebHistory.mm and
completely unused. Nuke it!

  • History/WebHistory.mm:
11:53 AM Changeset in webkit [38041] by sfalken@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-10-31 Steve Falkenburg <​sfalken@apple.com>

Build fix.

11:49 AM Changeset in webkit [38040] by timothy@apple.com
  • 3 edits
    2 adds in trunk

Emit the WillExecuteStatement debugger hook before the for loop body when the statement node for the body isn't a block. This allows breakpoints on those statements in the Web Inspector.

JavaScriptCore:

2008-10-31 Timothy Hatcher <​timothy@apple.com>

Emit the WillExecuteStatement debugger hook before the for loop body
when the statement node for the body isn't a block. This allows
breakpoints on those statements in the Web Inspector.

​https://bugs.webkit.org/show_bug.cgi?id=22004

Reviewed by Darin Adler.

  • kjs/nodes.cpp: (JSC::ForNode::emitCode): Emit the WillExecuteStatement debugger hook before the statement node if isn't a block. Also emit the WillExecuteStatement debugger hook for the loop as the first op-code. (JSC::ForInNode::emitCode): Ditto.

WebCore:

2008-10-31 Timothy Hatcher <​timothy@apple.com>

Add manual tests that check breakpoints on a blockless body of "for" loops.

​https://bugs.webkit.org/show_bug.cgi?id=22004

Reviewed by Darin Adler.

  • manual-tests/inspector/debugger-pause-on-for-in-statements.html: Added.
  • manual-tests/inspector/debugger-pause-on-for-statements.html: Added.
11:45 AM Changeset in webkit [38039] by Darin Adler
  • 2 edits in trunk/WebCore

2008-10-31 Darin Adler <Darin Adler>

  • fix build
  • platform/win/WCDataObject.cpp: Added missing include of "config.h".
11:08 AM Changeset in webkit [38038] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

Bug 21997: prepare-ChangeLog should filter out ChangeLog files

<​https://bugs.webkit.org/show_bug.cgi?id=21997>

Reviewed by Darin Adler.

  • Scripts/prepare-ChangeLog: (generateFileList): Don't add ChangeLog files to %{$functionLists}. This prevents them from showing up in the new ChangeLog entry. They were already excluded from @{$changedFiles}.
10:59 AM Changeset in webkit [38037] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

2008-10-31 Darin Adler <Darin Adler>

Reviewed by Dan Bernstein.

  • fix storage leak seen on buildbot

Some other cleanup too. The storage leak was caused by the fact
that HashTraits<CallIdentifier>::needsDestruction was false, so
the call identifier objects didn't get deleted.

  • profiler/CallIdentifier.h:


Added a default constructor to create empty call identifiers.

Changed the normal constructor to use const UString&
to avoid extra copying and reference count thrash.


Removed the explicit copy constructor definition, since it's what
the compiler will automatically generate. (Rule of thumb: Either
you need both a custom copy constructor and a custom assignment
operator, or neither.)

Moved the CallIdentifier hash function out of the WTF namespace;
there's no reason to put it there.

Changed the CallIdentifier hash function to be a struct rather than
a specialization of the IntHash struct template. Having it be
a specialization made no sense, since CallIdentifier is not an integer,
and did no good.

Removed explicit definition of emptyValueIsZero in the hash traits,
since inheriting from GenericHashTraits already makes that false.

Removed explicit definition of emptyValue, instead relying on the
default constructor and GenericHashTraits.

Removed explicit definition of needsDestruction, because we want it
to have its default value: true, not false. This fixes the leak!

Changed constructDeletedValue and isDeletedValue to use a line number
of numeric_limits<unsigned>::max() to indicate a value is deleted.
Previously this used empty strings for the empty value and null strings
for the deleted value, but it's more efficient to use null for both.

10:56 AM Changeset in webkit [38036] by Darin Adler
  • 2 edits in trunk/WebKit/win

2008-10-31 Darin Adler <Darin Adler>

  • try to fix build
  • WebView.cpp: (WebView::setCacheModel): Roll out the part of my last change that involved no longer using wkCopyFoundationCacheDirectory.
10:15 AM Changeset in webkit [38035] by Chris Fleizach
  • 2 edits in trunk/WebKit/mac

Bug 22002: AX: scroll bars show should not appear in AX hierarchy when WebFrameView does not allow scrolling
​https://bugs.webkit.org/show_bug.cgi?id=22002

3:17 AM Changeset in webkit [38034] by timothy@apple.com
  • 2 edits in trunk/JavaScriptCore

Fixes console warnings about not having an autorelease pool.
Also fixes the build for Snow Leopard, by including individual
Foundation headers instead of Foundation.h.

​https://bugs.webkit.org/show_bug.cgi?id=21995

Reviewed by Oliver Hunt.

  • profiler/ProfilerServer.mm: (-[ProfilerServer init]): Create a NSAutoreleasePool and drain it.
2:44 AM Changeset in webkit [38033] by ap@webkit.org
  • 11 edits in trunk/WebCore

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=21970
Make MessagePort event dispatch work in workers

  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData): (WebCore::JSDOMGlobalObject::~JSDOMGlobalObject): (WebCore::JSDOMGlobalObject::findJSEventListener): (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener): (WebCore::JSDOMGlobalObject::findJSUnprotectedEventListener): (WebCore::JSDOMGlobalObject::findOrCreateJSUnprotectedEventListener): (WebCore::JSDOMGlobalObject::jsEventListeners): (WebCore::JSDOMGlobalObject::jsInlineEventListeners): (WebCore::JSDOMGlobalObject::jsUnprotectedEventListeners): (WebCore::JSDOMGlobalObject::jsUnprotectedInlineEventListeners): (WebCore::JSDOMGlobalObject::setCurrentEvent): (WebCore::JSDOMGlobalObject::currentEvent): (WebCore::toJSDOMGlobalObject):
  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData): (WebCore::JSDOMWindowBase::~JSDOMWindowBase): (WebCore::JSDOMWindowBase::clearHelperObjectProperties):
  • bindings/js/JSDOMWindowBase.h: Moved event listener tracking from JSDOMWindow to JSDOMGlobalObject.
  • bindings/js/JSEventListener.cpp: (WebCore::JSAbstractEventListener::handleEvent): (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener): (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener): (WebCore::JSUnprotectedEventListener::globalObject): (WebCore::JSUnprotectedEventListener::clearGlobalObject): (WebCore::JSEventListener::JSEventListener): (WebCore::JSEventListener::~JSEventListener): (WebCore::JSEventListener::globalObject): (WebCore::JSEventListener::clearGlobalObject): (WebCore::JSLazyEventListener::JSLazyEventListener): (WebCore::JSLazyEventListener::parseCode):
  • bindings/js/JSEventListener.h: (WebCore::JSUnprotectedEventListener::create): (WebCore::JSEventListener::create): (WebCore::JSLazyEventListener::create): Changed to use JSDOMGlobalObject and ScriptExecutionContext.
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::startConversation): (WebCore::JSMessagePort::addEventListener): (WebCore::JSMessagePort::removeEventListener): (WebCore::JSMessagePort::setOnmessage): (WebCore::JSMessagePort::setOnclose): Updated bindings to work with JSDOMGlobalObject. Next step is to make code generator emit such code, and stop using a custom implementation for JSMessagePort inline event handler getters and setters.
  • dom/Document.cpp: (WebCore::Document::virtualURL):
  • dom/Document.h:
  • dom/ScriptExecutionContext.h: Expose url() method on ScriptExecutionContext (necessary for compiling scripts in JSLazyEventListener).
1:18 AM Changeset in webkit [38032] by cwzwarich@webkit.org
  • 2 edits in trunk/WebCore

2008-10-31 Cameron Zwarich <​zwarich@apple.com>

Not reviewed.

Speculative wxWindows build fix.

  • webcore-base.bkl:
12:42 AM Changeset in webkit [38031] by cwzwarich@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-10-31 Cameron Zwarich <​zwarich@apple.com>

Not reviewed.

Speculative wxWindows build fix.

  • JavaScriptCoreSources.bkl:
  • jscore.bkl:
12:37 AM Changeset in webkit [38030] by cwzwarich@webkit.org
  • 6 edits
    2 moves in trunk/JavaScriptCore

2008-10-31 Cameron Zwarich <​zwarich@apple.com>

Rubber-stamped by Maciej Stachowiak.

Move VM/JSPropertyNameIterator.cpp and VM/JSPropertyNameIterator.h to
the runtime directory.

  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • VM/JSPropertyNameIterator.cpp: Removed.
  • VM/JSPropertyNameIterator.h: Removed.
  • runtime/JSPropertyNameIterator.cpp: Copied from VM/JSPropertyNameIterator.cpp.
  • runtime/JSPropertyNameIterator.h: Copied from VM/JSPropertyNameIterator.h.
12:12 AM Changeset in webkit [38029] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-10-31 Cameron Zwarich <​zwarich@apple.com>

Not reviewed.

Speculative wxWindows build fix.

  • jscore.bkl:

Oct 30, 2008:

11:13 PM Changeset in webkit [38028] by mrowe@apple.com
  • 10 edits in trunk

Explicitly default to building for only the native architecture in debug and release builds.

Reviewed by Jon Homeycutt.

  • Configurations/DebugRelease.xcconfig:
10:56 PM Changeset in webkit [38027] by cwzwarich@webkit.org
  • 26 edits
    7 moves
    3 adds in trunk

2008-10-30 Cameron Zwarich <​zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Create a debugger directory in JavaScriptCore and move the relevant
files to it.

JavaScriptCore:

  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • VM/CodeBlock.cpp:
  • VM/CodeGenerator.h:
  • VM/Machine.cpp:
  • debugger: Added.
  • debugger/Debugger.cpp: Copied from kjs/debugger.cpp.
  • debugger/Debugger.h: Copied from kjs/debugger.h.
  • debugger/DebuggerCallFrame.cpp: Copied from kjs/DebuggerCallFrame.cpp.
  • debugger/DebuggerCallFrame.h: Copied from kjs/DebuggerCallFrame.h.
  • kjs/AllInOneFile.cpp:
  • kjs/DebuggerCallFrame.cpp: Removed.
  • kjs/DebuggerCallFrame.h: Removed.
  • kjs/Parser.cpp:
  • kjs/Parser.h:
  • kjs/debugger.cpp: Removed.
  • kjs/debugger.h: Removed.
  • kjs/interpreter.cpp:
  • kjs/nodes.cpp:
  • runtime/FunctionConstructor.cpp:
  • runtime/JSGlobalObject.cpp:

WebCore:

  • ForwardingHeaders/debugger: Added.
  • ForwardingHeaders/debugger/Debugger.h: Copied from ForwardingHeaders/kjs/debugger.h.
  • ForwardingHeaders/debugger/DebuggerCallFrame.h: Copied from ForwardingHeaders/kjs/DebuggerCallFrame.h.
  • ForwardingHeaders/kjs/DebuggerCallFrame.h: Removed.
  • ForwardingHeaders/kjs/debugger.h: Removed.
  • WebCore.pro:
  • bindings/js/ScriptController.cpp:
  • inspector/JavaScriptCallFrame.cpp:
  • inspector/JavaScriptCallFrame.h:
  • inspector/JavaScriptDebugServer.cpp:
  • inspector/JavaScriptDebugServer.h:

WebKit/mac:

  • ForwardingHeaders/debugger: Added.
  • ForwardingHeaders/debugger/DebuggerCallFrame.h: Copied from ForwardingHeaders/kjs/DebuggerCallFrame.h.
  • ForwardingHeaders/kjs/DebuggerCallFrame.h: Removed.
  • WebView/WebScriptDebugDelegate.mm:
  • WebView/WebScriptDebugger.h:
  • WebView/WebScriptDebugger.mm:
10:54 PM Changeset in webkit [38026] by timothy@apple.com
  • 2 edits in trunk/SunSpider

Fix a bug where when V8's or UBENCH's test suite list file is missing
the error message is suggesting that SunSpider's list file is missing.

Reviewed by Sam Weinig.

  • sunspider: (loadTestsList): Fix the error message to use the right list name.
10:49 PM Changeset in webkit [38025] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fix 2 Windows theme bugs:
1) Checkboxes marked readonly were rendered incorrectly
2) If a button has focus and is pressed, it was rendered

as focused rather than pressed.

​https://bugs.webkit.org/show_bug.cgi?id=21859

Reviewed by Dave Hyatt.

  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::determineState): (WebCore::RenderThemeWin::determineButtonState):
10:36 PM Changeset in webkit [38024] by timothy@apple.com
  • 4 edits in trunk

Add parentheses to fix some gcc warnings.

JavaScriptCore:

2008-10-30 Benjamin K. Stuhl <​bks24@cornell.edu>

gcc 4.3.3/linux-x86 generates "suggest parentheses around && within
"

warnings; add some parentheses to disambiguate things. No functional
changes, so no tests.

​https://bugs.webkit.org/show_bug.cgi?id=21973
Add parentheses to clean up some gcc warnings

Reviewed by Dan Bernstein.

  • wtf/ASCIICType.h: (WTF::isASCIIAlphanumeric): (WTF::isASCIIHexDigit):

WebCore:

2008-10-30 Benjamin K. Stuhl <​bks24@cornell.edu>

gcc 4.3.3/linux-x86 generates "suggest parentheses around && within
"

warnings; add some parentheses to disambiguate things. No functional
changes, so no tests.

​https://bugs.webkit.org/show_bug.cgi?id=21973
Add parentheses to clean up some gcc warnings

Reviewed by Dan Bernstein.

  • platform/graphics/Font.h: (WebCore::Font::treatAsZeroWidthSpace):
10:29 PM Changeset in webkit [38023] by timothy@apple.com
  • 2 edits in trunk/WebCore

Added an explicit dependency on HashMap.h. It was getting pulled in via
<kjs/identifier.h> in the case of JSC, causing errors for the Chromium port.

Reviewed by Darin Adler.

  • platform/text/PlatformString.h:
10:24 PM Changeset in webkit [38022] by timothy@apple.com
  • 3 edits
    2 adds in trunk/JavaScriptCore

Adds ProfilerServer, which is a distributed notification listener
that allows starting and stopping the profiler remotely for use
in conjunction with the profiler's DTace probes.

​https://bugs.webkit.org/show_bug.cgi?id=21719

Reviewed by Timothy Hatcher.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): Calls startProfilerServerIfNeeded.
  • profiler/ProfilerServer.h: Added.
  • profiler/ProfilerServer.mm: Added. (+[ProfilerServer sharedProfileServer]): (-[ProfilerServer init]): (-[ProfilerServer startProfiling]): (-[ProfilerServer stopProfiling]): (JSC::startProfilerServerIfNeeded):
9:09 PM Changeset in webkit [38021] by cwzwarich@webkit.org
  • 2 edits in trunk/WebKitSite

2008-10-30 Cameron Zwarich <​zwarich@apple.com>

Rubber-stamped by Mark Rowe.

Update the link to Mac Subversion binaries.

  • building/tools.html:
8:43 PM Changeset in webkit [38020] by kevino@webkit.org
  • 2 edits in trunk/JavaScriptCore

wx build fix after PropertyMap and StructureID merge.

8:39 PM Changeset in webkit [38019] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-10-30 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Mark Rowe.

Change the JavaScriptCore Xcode project to use relative paths for the
PCRE source files.

6:56 PM Changeset in webkit [38018] by ddkilzer@apple.com
  • 4 edits in trunk/WebCore

2008-10-30 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Sam Weinig

​https://bugs.webkit.org/show_bug.cgi?id=21967

For some platforms the GeolocationService must be suspended and resumed.

  • page/Geolocation.cpp: (WebCore::Geolocation::clearWatch): now uses Geolocation::hasListeners() (WebCore::Geolocation::suspend): calls GeolocationService::suspend() if there are listeners (WebCore::Geolocation::resume): calls GeolocationService::resume() if there are listeners (WebCore::Geolocation::geolocationServicePositionChanged): now uses Geolocation::hasListeners()
  • page/Geolocation.h: (WebCore::Geolocation::hasListeners): Indicates of the Geolocation has interested GeolocationService listeners
  • platform/GeolocationService.h: (WebCore::GeolocationService::suspend): empty implementation (WebCore::GeolocationService::resume): empty implementation
6:54 PM Changeset in webkit [38017] by ddkilzer@apple.com
  • 7 edits in trunk/WebCore

2008-10-30 Greg Bolsinga <​bolsinga@apple.com>

Reviewed by Sam Weinig

​https://bugs.webkit.org/show_bug.cgi?id=21966

The Geolocation spec was updated on 10/27/2008. This brings WebCore up to date.
​http://dev.w3.org/geo/api/spec-source.html

  • page/Geolocation.cpp: (WebCore::Geolocation::GeoNotifier::GeoNotifier): PositionOptions' timeout now unsigned
  • page/Geoposition.cpp: velocity is now called speed (WebCore::Geoposition::toString):
  • page/Geoposition.h: velocity is now called speed (WebCore::Geoposition::create): (WebCore::Geoposition::speed): (WebCore::Geoposition::Geoposition):
  • page/Geoposition.idl: velocity is now called speed
  • page/PositionOptions.h: timeout is now unsigned (WebCore::PositionOptions::create): (WebCore::PositionOptions::timeout): (WebCore::PositionOptions::setTimeout): (WebCore::PositionOptions::PositionOptions):
  • page/PositionOptions.idl: timeout is now unsigned long
5:12 PM Changeset in webkit [38016] by weinig@apple.com
  • 12 edits
    1 move
    1 delete in trunk/JavaScriptCore

2008-10-30 Sam Weinig <​sam@webkit.org>

Reviewed by Cameron Zwarich and Geoffrey Garen.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=21989
Merge PropertyMap and StructureID

  • Move PropertyMap code into StructureID in preparation for lazily creating the map on gets.
  • Make remove with transition explicit by adding removePropertyTransition.
  • Make the put/remove without transition explicit.
  • Make cache invalidation part of put/remove without transition.

1% speedup on SunSpider; 0.5% speedup on v8 suite.

  • GNUmakefile.am:
  • JavaScriptCore.exp:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • kjs/AllInOneFile.cpp:
  • kjs/identifier.h:
  • runtime/JSObject.cpp: (JSC::JSObject::removeDirect):
  • runtime/JSObject.h: (JSC::JSObject::putDirect):
  • runtime/PropertyMap.cpp: Removed.
  • runtime/PropertyMap.h: Removed.
  • runtime/PropertyMapHashTable.h: Copied from runtime/PropertyMap.h.
  • runtime/StructureID.cpp: (JSC::StructureID::dumpStatistics): (JSC::StructureID::StructureID): (JSC::StructureID::~StructureID): (JSC::StructureID::getEnumerablePropertyNames): (JSC::StructureID::addPropertyTransition): (JSC::StructureID::removePropertyTransition): (JSC::StructureID::toDictionaryTransition): (JSC::StructureID::changePrototypeTransition): (JSC::StructureID::getterSetterTransition): (JSC::StructureID::addPropertyWithoutTransition): (JSC::StructureID::removePropertyWithoutTransition): (JSC::PropertyMapStatisticsExitLogger::~PropertyMapStatisticsExitLogger): (JSC::StructureID::checkConsistency): (JSC::StructureID::copyPropertyTable): (JSC::StructureID::get): (JSC::StructureID::put): (JSC::StructureID::remove): (JSC::StructureID::insertIntoPropertyMapHashTable): (JSC::StructureID::expandPropertyMapHashTable): (JSC::StructureID::createPropertyMapHashTable): (JSC::StructureID::rehashPropertyMapHashTable): (JSC::comparePropertyMapEntryIndices): (JSC::StructureID::getEnumerablePropertyNamesInternal):
  • runtime/StructureID.h: (JSC::StructureID::propertyStorageSize): (JSC::StructureID::isEmpty): (JSC::StructureID::get):
5:11 PM Changeset in webkit [38015] by justin.garcia@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2008-10-30 Justin Garcia <​justin.garcia@apple.com>

Also handle preserved newlines.

  • editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply):

LayoutTests:

2008-10-30 Justin Garcia <​justin.garcia@apple.com>

Added another layout test for previous check-in.

  • editing/inserting/6104369-2-expected.txt: Added.
  • editing/inserting/6104369-2.html: Added.
4:46 PM Changeset in webkit [38014] by justin.garcia@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2008-10-30 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Beth Dakin.

<rdar://problem/6104369> Hitting return at the end of a quoted line creates an extraneous quoted line

  • editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply): Don't store the endingSelection() in selection, just call endingSelection() in the few places it's needed. This function is cheap since it just returns a reference to a Selection instead of creating one. Don't store an affinity. In the one place that it was used, isLastVisiblePositionInNode(VisiblePosition(pos, affinity), topBlockquote), we now use visiblePos (in order to avoid VisiblePosition creation). Set pos after we delete the current selection (if there is one), and be consistent about what we set pos to. Before, we upstream()ed it if there was a selection to delete and left it alone otherwise. In fact... ...we need to use downstream() for pos so that when a caret is at the boundary between two nodes, pos is in the first node that we want to move. This fixes the bug, since it lets code that checks for the case where the caret is between text and a br work correctly.

LayoutTests:

2008-10-30 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Beth Dakin.


<rdar://problem/6104369> Hitting return at the end of a quoted line creates an extraneous quoted line

  • editing/inserting/6104369-expected.txt: Added.
  • editing/inserting/6104369.html: Added.
4:36 PM Changeset in webkit [38013] by mitz@apple.com
  • 2 edits in trunk/WebKitTools

2008-10-30 Pierre-Olivier Latour <​pol@apple.com>

Reviewed by Dan Bernstein.

Fixed 64 bit build failure.

  • DumpRenderTree/mac/PixelDumpSupportMac.mm: (setupMainDisplayColorProfile): (createBitmapContextFromWebView):
3:16 PM Changeset in webkit [38012] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-10-30 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Oliver Hunt.

Bug 21987: CTI::putDoubleResultToJSNumberCellOrJSImmediate() hardcodes its result register
<​https://bugs.webkit.org/show_bug.cgi?id=21987>

CTI::putDoubleResultToJSNumberCellOrJSImmediate() hardcodes its result
register as ecx, but it should be tempReg1, which is ecx at all of its
callsites.

  • VM/CTI.cpp: (JSC::CTI::putDoubleResultToJSNumberCellOrJSImmediate):
2:22 PM Changeset in webkit [38011] by alp@webkit.org
  • 2 edits in trunk

2008-10-30 Alp Toker <​alp@nuanti.com>

​https://bugs.webkit.org/show_bug.cgi?id=19395
doltlibtool bug with bash 3.0

autotools dolt build fix for bash version 3.0 and older. Remove
concatenation syntax from doltlibtool to support the older versions
which don't have '+='.

  • acinclude.m4:
2:17 PM Changeset in webkit [38010] by Darin Adler
  • 2 edits in trunk/WebKit/win

2008-10-30 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

  • WebView.cpp: (WebView::setCacheModel): Use CFURLCopySharedURLCache if present.
2:16 PM Changeset in webkit [38009] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-10-30 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Sam Weinig.

Bug 21985: Opcodes should use eax as their destination register whenever possible
<​https://bugs.webkit.org/show_bug.cgi?id=21985>

Change more opcodes to use eax as the register for their final result,
and change calls to emitPutResult() that pass eax to rely on the default
value of eax.

  • VM/CTI.cpp: (JSC::CTI::privateCompileMainPass):
2:13 PM Changeset in webkit [38008] by mitz@apple.com
  • 898 edits
    8 adds in trunk/LayoutTests

2008-10-30 Pierre-Olivier Latour <​pol@apple.com>

Reviewed by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=21821

Imported new image bases for a representative set of pixel tests in order to
fully validate latest DRT and test script changes. These results were generated
by a release build of r38003 on an Intel iMac running Mac OS X 10.5.5 with
QuickTime 7.5.5.

(file listing elided)

1:52 PM Changeset in webkit [38007] by Darin Adler
  • 1 edit in trunk/WebCore/ChangeLog

Fix mismerged change log.

1:45 PM Changeset in webkit [38006] by vestbo@webkit.org
  • 3 edits in trunk/WebCore

2008-10-30 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Darin Adler.

Fix the Qt build.

​https://bugs.webkit.org/show_bug.cgi?id=21969

1:24 PM Changeset in webkit [38005] by mitz@apple.com
  • 2 edits in trunk/WebKit/win

Reviewed by Sam Weinig.

  • export WTFReportAssertionFailureWithMessage()
  • WebKit.vcproj/WebKit_debug.def:
1:06 PM Changeset in webkit [38004] by justin.garcia@apple.com
  • 2 edits in trunk/WebCore

2008-10-30 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Darin Adler.

More preparation for:
<rdar://problem/6104369> Hitting return at the end of a quoted line creates an extraneous quoted line

  • editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply): Added comments. Don't need to use newStartNode. If the startNode needs to change, change it. Afterwords, check to make sure that it hasn't left topBlockquote. This is slightly stricter than before, where we just made sure that it still had a topBlockquote. This doesn't really fix a bug, since we can't really get into a situation where we move to a different topBlockquote, but it simplifies the code.
12:18 PM Changeset in webkit [38003] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-10-30 Alp Toker <​alp@nuanti.com>

Reviewed by Dave Hyatt.

Fix GIF animations. WebCore will not update animated GIFs if
the WebView is marked offscreen so we need to call
frameView->setParentVisible() when necessary like the Mac and Win
ports do. Regression was introduced around r37155 during the
HostWindow refactor.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
11:12 AM Changeset in webkit [38002] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2008-10-29 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

  • Plugins/WebBaseNetscapePluginStream.h:
  • Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::WebNetscapePluginStream): (WebNetscapePluginStream::~WebNetscapePluginStream): (WebNetscapePluginStream::start):
8:34 AM ApplicationsGtk edited by pierre-luc.beaudoin@collabora.co.uk
Add Empathy to the list of apps (diff)
7:09 AM Changeset in webkit [38001] by alp@webkit.org
  • 4 edits in trunk/WebCore

2008-10-30 Dirk Schulze <​vbs85@gmx.de>

Reviewed by Alp Toker.

​https://bugs.webkit.org/show_bug.cgi?id=21883
[CAIRO] globalAlpha has to be stored and restored

Cairo's globalAlpha has to be stored and reloaded on calling
save() and restore(). We use the power of GraphicsContextState for this.

  • platform/graphics/GraphicsContextPrivate.h: (WebCore::GraphicsContextState::GraphicsContextState):
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::setAlpha): (WebCore::GraphicsContext::getAlpha):
  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
6:42 AM Changeset in webkit [38000] by alp@webkit.org
  • 3 edits in trunk/WebKit/gtk

2008-10-30 Alp Toker <​alp@nuanti.com>

Rubber-stamped by Holger Freyther.

Fix typo in recently added web inspector signal. dettach -> detach.

  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::detachWindow):
  • webkit/webkitwebinspector.cpp: (_WebKitWebInspectorPrivate::webkit_web_inspector_class_init):
6:01 AM Changeset in webkit [37999] by alp@webkit.org
  • 1 edit in trunk/JavaScriptCore/VM/Machine.cpp

Back out redundant build fix attempt r37997. The correct fix is r37998.

5:37 AM Changeset in webkit [37998] by alp@webkit.org
  • 1 edit in trunk/JavaScriptCore/VM/Machine.h

Try naming VoidPtrPair struct to fix old gcc/MSVC builds

3:45 AM Changeset in webkit [37997] by alp@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-10-30 Alp Toker <​alp@nuanti.com>

Build fix attempt for older gcc on the trunk-mac-intel build bot
(error: initializer for scalar variable requires one element).

Modify the initializer syntax slightly with an additional comma.

  • VM/Machine.cpp: (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_op_construct_JSConstruct): (JSC::Machine::cti_op_resolve_func): (JSC::Machine::cti_op_post_inc): (JSC::Machine::cti_op_resolve_with_base): (JSC::Machine::cti_op_post_dec):
2:56 AM Changeset in webkit [37996] by alp@webkit.org
  • 2 edits in trunk

2008-10-30 Alp Toker <​alp@nuanti.com>

Rubber-stamped by Oliver Hunt.

autotools build system change to enable JIT features by default. Can
be disabled with --disable-jit (and is disabled automatically on
unsupported platforms).

  • configure.ac:
2:35 AM Changeset in webkit [37995] by alp@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-10-30 Alp Toker <​alp@nuanti.com>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=21571
VoidPtrPair breaks CTI on Linux

The VoidPtrPair return change made in r37457 does not work on Linux
since POD structs aren't passed in registers.

This patch uses a union to vectorize VoidPtrPair to a uint64_t and
matches Darwin/MSVC fixing CTI/WREC on Linux.

Alexey reports no measurable change in Mac performance with this fix.

  • VM/Machine.cpp: (JSC::Machine::cti_op_call_JSFunction): (JSC::Machine::cti_op_construct_JSConstruct): (JSC::Machine::cti_op_resolve_func): (JSC::Machine::cti_op_post_inc): (JSC::Machine::cti_op_resolve_with_base): (JSC::Machine::cti_op_post_dec):
  • VM/Machine.h: (JSC::):
1:55 AM Changeset in webkit [37994] by ap@webkit.org
  • 3 edits in trunk/WebCore

Finish landing the previous renaming, createInlineEventHandler->createInlineEventListener (the files remained unsaved in Xcode).

1:41 AM Changeset in webkit [37993] by ap@webkit.org
  • 35 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.

Rename "attachedToEventTargetNode" to "isInline".

Inline (onXXX) attributes are used not just with event target nodes, but also with Window,
XMLHttpRequest, MessagePort et al.

Also renamed createHTMLEventHandler() (which was a leftover from earlier isHTMLEvent ->
attachedToEventTargetNode rename made for SVG) to createInlineEventListener().
And also renamed EventTargetNode, Document and Window "eventListenerForType" methods to
"inlineEventListenerForType", as they work with inline listeners.

  • bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener):
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::setOnmessage): (WebCore::JSMessagePort::setOnclose):
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener):
  • bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener): Pass a correct value for this argument - callers used to be confused, because they didn't consider themselves event target nodes. This doesn't affect behavior however, as the only difference between inline and non-inline event handlers is that the former treat "return false" as "event.preventDefault()", which is not important to any of these objects.
  • bindings/js/JSEventListener.cpp: (WebCore::JSLazyEventListener::parseCode): Assert that isInline is true instead of checking its value, as the constructor of this class always sets it to true.
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::~JSDOMWindowBase): (WebCore::JSDOMWindowBase::findJSEventListener): (WebCore::JSDOMWindowBase::findOrCreateJSEventListener): (WebCore::JSDOMWindowBase::findJSUnprotectedEventListener): (WebCore::JSDOMWindowBase::findOrCreateJSUnprotectedEventListener): (WebCore::JSDOMWindowBase::jsInlineEventListeners): (WebCore::JSDOMWindowBase::jsUnprotectedInlineEventListeners):
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSEventListener.cpp: (WebCore::JSAbstractEventListener::handleEvent): (WebCore::JSAbstractEventListener::isInline): (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener): (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener): (WebCore::JSEventListener::JSEventListener): (WebCore::JSEventListener::~JSEventListener): (WebCore::JSLazyEventListener::parseCode):
  • bindings/js/JSEventListener.h: (WebCore::JSAbstractEventListener::JSAbstractEventListener): (WebCore::JSUnprotectedEventListener::create): (WebCore::JSEventListener::create):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::createInlineEventHandler):
  • bindings/js/ScriptController.h:
  • dom/Document.cpp: (WebCore::Document::setWindowInlineEventListenerForType): (WebCore::Document::windowInlineEventListenerForType): (WebCore::Document::removeWindowInlineEventListenerForType): (WebCore::Document::createEventListener): (WebCore::Document::setWindowInlineEventListenerForTypeAndAttribute):
  • dom/Document.h:
  • dom/EventListener.h: (WebCore::EventListener::isInline):
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::removeInlineEventListenerForType): (WebCore::EventTargetNode::setInlineEventListenerForType): (WebCore::EventTargetNode::setInlineEventListenerForTypeAndAttribute): (WebCore::EventTargetNode::inlineEventListenerForType): (WebCore::EventTargetNode::on*): (many methods) (WebCore::EventTargetNode::setOn*): (many methods)
  • dom/EventTargetNode.h:
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment):
  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute):
  • html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::parseMappedAttribute):
  • html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute):
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::parseMappedAttribute):
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::parseMappedAttribute):
  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::parseMappedAttribute):
  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::parseMappedAttribute):
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::parseMappedAttribute):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute):
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::parseMappedAttribute):
  • page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::mouseButtonListener):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::setInlineEventListenerForType): (WebCore::DOMWindow::inlineEventListenerForType): (WebCore::DOMWindow::on*): (many methods) (WebCore::DOMWindow::setOn*): (many methods)
  • page/DOMWindow.h:
  • svg/SVGElement.cpp: (WebCore::SVGElement::parseMappedAttribute):
  • svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::on*): (many methods) (WebCore::SVGElementInstance::setOn*): (many methods)
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::parseMappedAttribute): Rename things, as described above.
1:24 AM Changeset in webkit [37992] by alp@webkit.org
  • 6 edits in trunk

2008-10-30 Alp Toker <​alp@nuanti.com>

Bump WebKit GTK+ version to 1.0.3.

Fix version comments for the web inspector added in r37982. Available
since 1.0.3, not 1.0.2.

Oct 29, 2008:

9:33 PM Changeset in webkit [37991] by oliver@apple.com
  • 13 edits in trunk/JavaScriptCore

Initial work to reduce cost of JSNumberCell allocation

Reviewed by Geoffrey Garen

This does the initial work needed to bring more of number
allocation into CTI code directly, rather than just falling
back onto the slow paths if we can't guarantee that a number
cell can be reused.

Initial implementation only used by op_negate to make sure
it all works. In a negate heavy (though not dominated) test
it results in a 10% win in the non-reusable cell case.

8:38 PM Changeset in webkit [37990] by sfalken@apple.com
  • 6 edits in trunk

JavaScriptCore:

2008-10-29 Steve Falkenburg <​sfalken@apple.com>

<rdar://problem/6326563> Crash on launch

For Windows, export explicit functions rather than exporting data for atomicallyInitializedStaticMutex.


Exporting data from a DLL on Windows requires specifying declspec(dllimport) in the header used by
callers, but declspec(dllexport) when defined in the DLL implementation. By instead exporting
the explicit lock/unlock functions, we can avoid this.


Fixes a crash on launch, since we were previously erroneously exporting atomicallyInitializedStaticMutex as a function.


Reviewed by Darin Adler.

  • wtf/Threading.h: (WTF::lockAtomicallyInitializedStaticMutex): (WTF::unlockAtomicallyInitializedStaticMutex):
  • wtf/ThreadingWin.cpp: (WTF::lockAtomicallyInitializedStaticMutex): (WTF::unlockAtomicallyInitializedStaticMutex):

WebKit/win:

2008-10-29 Steve Falkenburg <​sfalken@apple.com>

<rdar://problem/6326563> Crash on launch


For Windows, export explicit functions rather than exporting data for atomicallyInitializedStaticMutex.


Exporting data from a DLL on Windows requires specifying declspec(dllimport) in the header used by
callers, but declspec(dllexport) when defined in the DLL implementation. By instead exporting
the explicit lock/unlock functions, we can avoid this.


Fixes a crash on launch, since we were previously erroneously exporting atomicallyInitializedStaticMutex as a function.


Reviewed by Darin Adler.

  • WebKit.vcproj/WebKit.def:
  • WebKit.vcproj/WebKit_debug.def:
7:44 PM Changeset in webkit [37989] by weinig@apple.com
  • 9 edits in trunk/JavaScriptCore

2008-10-29 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt.

Remove direct use of PropertyMap.

  • JavaScriptCore.exp:
  • runtime/JSObject.cpp: (JSC::JSObject::mark): (JSC::JSObject::put): (JSC::JSObject::deleteProperty): (JSC::JSObject::getPropertyAttributes): (JSC::JSObject::removeDirect):
  • runtime/JSObject.h: (JSC::JSObject::getDirect): (JSC::JSObject::getDirectLocation): (JSC::JSObject::hasCustomProperties): (JSC::JSObject::JSObject): (JSC::JSObject::putDirect):
  • runtime/PropertyMap.cpp: (JSC::PropertyMap::get):
  • runtime/PropertyMap.h: (JSC::PropertyMap::isEmpty): (JSC::PropertyMap::get):
  • runtime/StructureID.cpp: (JSC::StructureID::dumpStatistics):
  • runtime/StructureID.h: (JSC::StructureID::propertyStorageSize): (JSC::StructureID::get): (JSC::StructureID::put): (JSC::StructureID::remove): (JSC::StructureID::isEmpty):
6:38 PM Changeset in webkit [37988] by pewtermoose@webkit.org
  • 2 edits in trunk/WebKit

2008-10-29 Matt Lilek <​webkit@mattlilek.com>

Not reviewed, build fix.

  • WebKit.xcodeproj/project.pbxproj:
5:49 PM Changeset in webkit [37987] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-10-29 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Remove an unused forward class declaration.


  • Plugins/WebBaseNetscapePluginView.h:
5:46 PM Changeset in webkit [37986] by andersca@apple.com
  • 7 edits
    2 deletes in trunk/WebKit/mac

2008-10-29 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Remove WebBaseNetscapePluginViewInternal.h and WebBaseNetscapePluginViewPrivate.h.

  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginViewInternal.h: Removed.
  • Plugins/WebBaseNetscapePluginViewPrivate.h: Removed.
  • Plugins/WebNetscapePluginEventHandler.mm:
  • Plugins/WebNetscapePluginEventHandlerCarbon.mm:
  • Plugins/WebNetscapePluginEventHandlerCocoa.mm:
  • Plugins/npapi.mm:
  • WebView/WebHTMLView.mm:
4:52 PM Changeset in webkit [37985] by weinig@apple.com
  • 6 edits
    1 copy in trunk/JavaScriptCore

2008-10-29 Sam Weinig <​sam@webkit.org>

Reviewed by Geoffrey Garen.

Rename and move the StructureID transition table to its own file.

  • GNUmakefile.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/StructureID.cpp: (JSC::StructureID::addPropertyTransition):
  • runtime/StructureID.h: (JSC::StructureID::):
  • runtime/StructureIDTransitionTable.h: Copied from runtime/StructureID.h. (JSC::StructureIDTransitionTableHash::hash): (JSC::StructureIDTransitionTableHash::equal):
4:47 PM Changeset in webkit [37984] by andersca@apple.com
  • 8 edits
    4 deletes in trunk/WebKit/mac

2008-10-29 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Remove WebNetscapePluginEmbeddedView, it adds nothing extra now.


Remove WebNetscapePlugInStreamLoaderClient since WebNetscapePluginStream is the client now.


  • Plugins/WebBaseNetscapePluginStream.h:
  • Plugins/WebBaseNetscapePluginStream.mm:
  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebKitPluginContainerView.h:
  • Plugins/WebNetscapePluginEmbeddedView.h: Removed.
  • Plugins/WebNetscapePluginEmbeddedView.mm: Removed.
  • Plugins/WebNetscapePluginEventHandler.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::NetscapePluginWidget): (NetscapePluginWidget::handleEvent): (WebFrameLoaderClient::createPlugin):
  • WebCoreSupport/WebNetscapePlugInStreamLoaderClient.h: Removed.
  • WebCoreSupport/WebNetscapePlugInStreamLoaderClient.mm: Removed.
  • WebView/WebHTMLView.mm: (-[NSArray _web_makePluginViewsPerformSelector:withObject:]):
3:53 PM Changeset in webkit [37983] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

2008-10-29 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam Weinig.

Remove the WebBaseNetscapePluginStream Objective-C object.


  • Plugins/WebBaseNetscapePluginStream.h: (WebNetscapePluginStream::create):
  • Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::WebNetscapePluginStream):
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView pluginView:receivedResponse:]): (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
3:39 PM Changeset in webkit [37982] by zecke@webkit.org
  • 13 edits
    2 adds in trunk

2008-10-29 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Holger Freyther.

Added all the files that need to be installed for the Inspector to
work.

WebCore/ChangeLog:
2008-10-29 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed and slightly changed by Holger Freyther.

Added all the files that need to be installed for the Inspector to
work.

  • GNUmakefile.am: Invoke the shell to get the files.

WebKit/gtk:
2008-10-29 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed and slightly changed by Holger Freyther.

Implemented a new WebKitWebInspector class to provide a GObject
API for the Web Inspector. Also implemented InspectorClient.

  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::notifyWebViewDestroyed): (WebKit::InspectorClient::InspectorClient): (WebKit::InspectorClient::inspectorDestroyed): (WebKit::InspectorClient::webViewDestroyed): (WebKit::InspectorClient::createPage): (WebKit::InspectorClient::showWindow): (WebKit::InspectorClient::closeWindow): (WebKit::InspectorClient::attachWindow): (WebKit::InspectorClient::detachWindow): (WebKit::InspectorClient::inspectedURLChanged):
  • WebCoreSupport/InspectorClientGtk.h:
  • webkit/webkit.h:
  • webkit/webkit-marshal.list:
  • webkit/webkitdefines.h:
  • webkit/webkitprivate.h:
  • webkit/webkitwebinspector.cpp: Added. (_WebKitWebInspectorPrivate::webkit_inspect_web_view_request_handled): (_WebKitWebInspectorPrivate::webkit_web_inspector_class_init): (_WebKitWebInspectorPrivate::webkit_web_inspector_init): (_WebKitWebInspectorPrivate::webkit_web_inspector_finalize): (_WebKitWebInspectorPrivate::webkit_web_inspector_set_property): (_WebKitWebInspectorPrivate::webkit_web_inspector_get_property): (_WebKitWebInspectorPrivate::webkit_web_inspector_set_web_view):
  • webkit/webkitwebinspector.h: Added.
  • webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::): (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): (_WebKitWebSettingsPrivate::webkit_web_settings_set_property): (_WebKitWebSettingsPrivate::webkit_web_settings_get_property): (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
  • webkit/webkitwebview.cpp:
  • webkit/webkitwebview.h:
3:27 PM Changeset in webkit [37981] by weinig@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-10-29 Sam Weinig <​sam@webkit.org>

Reviewed by Cameron Zwarich.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=21958
Pack bits in StructureID to reduce the size of each StructureID by 2 words.

  • runtime/PropertyMap.h: (JSC::PropertyMap::propertyMapSize):
  • runtime/StructureID.cpp: (JSC::StructureID::dumpStatistics): Add additional size statistics when dumping. (JSC::StructureID::StructureID):
  • runtime/StructureID.h:
2:45 PM Changeset in webkit [37980] by darin@chromium.org
  • 2 edits in trunk/WebCore

2008-10-29 Andrew Scherkus <​scherkus@chromium.org>

Reviewed by Darin Adler

Add MediaPlayerPrivateChromium to MediaPlayer
​https://bugs.webkit.org/show_bug.cgi?id=21930

  • platform/graphics/MediaPlayer.cpp:
2:43 PM Changeset in webkit [37979] by justin.garcia@apple.com
  • 2 edits in trunk/WebCore

2008-10-29 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Darin Adler.

Some preparation for:
<rdar://problem/6104369> Hitting return at the end of a quoted line creates an extraneous quoted line


Added an early return to avoid a level of if-nesting. No other changes. We probably don't
need to rebalance whitespace before the early return but for now don't risk any change in behavior
I'll revisit that later.

  • editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply):
2:21 PM Changeset in webkit [37978] by jhoneycutt@apple.com
  • 3 edits in trunk/WebKit/win

2008-10-29 Jon Honeycutt <​jhoneycutt@apple.com>

Export atomicallyInitializedStaticMutex.

Rubber-stamped by Steve Falkenburg.

  • WebKit.vcproj/WebKit.def:
  • WebKit.vcproj/WebKit_debug.def:
1:19 PM Changeset in webkit [37977] by zecke@webkit.org
  • 3 edits in trunk

2008-10-29 Mike Hommey <​glandium@debian.org>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=21884
Test presence and link against libpng.

  • GNUmakefile.am:
  • configure.ac:
1:13 PM Changeset in webkit [37976] by kevino@webkit.org
  • 8 edits
    1 add in trunk

wx build fixes after addition of runtime and ImageBuffer changes.

12:59 PM Changeset in webkit [37975] by beidson@apple.com
  • 3 edits in trunk/WebKit/mac

2008-10-29 Brady Eidson <​beidson@apple.com>

Reviewed by Sam Weinig

​https://bugs.webkit.org/show_bug.cgi?id=21952


Address an outstanding FIXME by removing unused SPI

  • History/WebHistory.mm: (-[WebHistory _addItemForURL:title:]): Fold addItem: into this method
  • History/WebHistoryPrivate.h: Removed unused/unneccessary SPI
12:34 PM Changeset in webkit [37974] by jmalonzo@webkit.org
  • 3 edits in trunk

2008-10-29 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Holger Freyther.

Add --enable-optimizations to enable optimized builds. The default
is to enable it for release builds, and disabled for debug builds.
This option will allow builders to have a debug as well as
optimized builds.

  • GNUmakefile.am:
  • configure.ac:
9:38 AM Changeset in webkit [37973] by brettw@chromium.org
  • 2 edits in trunk/WebCore

Allow Skia implementations to get text style changed notifications.

8:19 AM Web Inspector edited by dmitrykichenko@gmail.com
(diff)
8:18 AM Web Inspector edited by dmitrykichenko@gmail.com
The instructions here did not work for me but adding the key into … (diff)
8:02 AM Changeset in webkit [37972] by timothy@apple.com
  • 3 edits
    1 add in trunk

Emit the WillExecuteStatement debugger hook before the "else" body when there is no block for the "else" body. This allows breakpoints on those statements in the Web Inspector.

JavaScriptCore:

2008-10-28 Timothy Hatcher <​timothy@apple.com>

Emit the WillExecuteStatement debugger hook before the "else" body
when there is no block for the "else" body. This allows breakpoints
on those statements in the Web Inspector.

​https://bugs.webkit.org/show_bug.cgi?id=21944

Reviewed by Maciej Stachowiak.

  • kjs/nodes.cpp: (JSC::IfElseNode::emitCode): Emit the WillExecuteStatement debugger hook before the else node if isn't a block.

WebCore:

2008-10-28 Timothy Hatcher <​timothy@apple.com>

Add a manual test that checks breakpoints on a blockless body of
an "else" statement.

​https://bugs.webkit.org/show_bug.cgi?id=21944

Reviewed by Maciej Stachowiak.

  • manual-tests/inspector/debugger-pause-on-else-statements.html: Added.
3:44 AM Changeset in webkit [37971] by ap@webkit.org
  • 4 edits in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=21921
MessagePort messages are dispatched to documents that are not fully active

Covered by corrected fast/events/message-port-inactive-document.html

  • bindings/js/JSEventListener.cpp: (WebCore::JSAbstractEventListener::handleEvent): Don't dispatch messages to contexts that are not fully active.
3:40 AM Changeset in webkit [37970] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Build fix.

3:37 AM Changeset in webkit [37969] by ap@webkit.org
  • 6 edits in trunk

Reviewed by Sam Weinig.

​https://bugs.webkit.org/show_bug.cgi?id=21922
Expose MessagePort global constructor

Covered by existing dumper tests.

  • dom/MessagePort.idl:
  • page/DOMWindow.idl:
3:35 AM Changeset in webkit [37968] by ap@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=21924
HashTable internal index is not always deleted

  • bindings/js/JSDOMBinding.cpp: (WebCore::DOMObjectHashTableMap::~DOMObjectHashTableMap): Call deleteTable for HashTables that are being deleted.
3:31 AM Changeset in webkit [37967] by ap@webkit.org
  • 3 edits in trunk/LayoutTests/platform/mac/svg/carto.net

Missed these files in an earlier check-in for <​https://bugs.webkit.org/show_bug.cgi?id=21893>.

3:26 AM Changeset in webkit [37966] by ap@webkit.org
  • 35 edits
    2 adds in trunk/WebCore

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=21923
Create an abstraction for script execution context

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl: Added ScriptExecutionContext.{h,cpp}.
  • bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor):
  • bindings/js/JSAudioConstructor.h:
  • bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor):
  • bindings/js/JSImageConstructor.h:
  • bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor):
  • bindings/js/JSOptionConstructor.h:
  • bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
  • bindings/js/JSXMLHttpRequestConstructor.h: Pass ScriptExecutionContext instead of Document to make getDOMConstructor() happy. Since these objects can only work within documents now, it is immediately converted back to Document.
  • bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor): (WebCore::JSMessageChannelConstructor::construct):
  • bindings/js/JSMessageChannelConstructor.h: (WebCore::JSMessageChannelConstructor::scriptExecutionContext): MessageChannel needs to be supported in workers right away, so the constructor operates with it directly.
  • dom/ActiveDOMObject.cpp: (WebCore::ActiveDOMObject::ActiveDOMObject): (WebCore::ActiveDOMObject::~ActiveDOMObject): (WebCore::ActiveDOMObject::contextDestroyed):
  • dom/ActiveDOMObject.h: (WebCore::ActiveDOMObject::scriptExecutionContext):
  • bindings/js/JSDOMBinding.cpp: (WebCore::markActiveObjectsForContext): (WebCore::markCrossHeapDependentObjectsForContext): Use ScriptExecutionContext instead of Document, now that ActiveDOMObject and MessagePort tracking is handled by ScriptExecutionContext.
  • bindings/js/JSDOMBinding.h: (WebCore::getDOMPrototype): Moved to JSDOMGlobalObject.
  • bindings/js/JSDOMGlobalObject.h: (WebCore::getDOMConstructor): Moved to this file, as constructors live in JSDOMGlobalObject. Also, the two-argument version that used to be in JSDOMWindowBase.cpp need to be accessible to worker context implementation. (WebCore::scriptExecutionContext): Added a pure virtual method to access ScriptExecutionContext, implemented by subclasses.
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::scriptExecutionContext): Implement by returning the associated document. Note that this method currently gives bogus results after navigation - DOMWindow Frame reference is not zeroed out, so we get a document that is currently in the frame, not the one associated with this window.
  • bindings/js/JSDedicatedWorkerConstructor.cpp: Removed unnecessary include of DOMWindow.h.
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::mark): Call markActiveObjectsForContext() by its new name.
  • dom/DedicatedWorker.cpp: (WebCore::DedicatedWorker::DedicatedWorker): (WebCore::DedicatedWorker::document):
  • dom/DedicatedWorker.h:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::document):
  • xml/XMLHttpRequest.h: Added a document() function that upcasts ScriptExecutionContext, as these objects only work within documents currently (at least for XMLHttpRequest, this will change soon though).
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document): Moved active object and MessagePort tracking up to ScriptExecutionContext, to share code with workers.


  • dom/Document.h: (WebCore::Document::isDocument): (WebCore::Document::refScriptExecutionContext): (WebCore::Document::derefScriptExecutionContext): Inherit from ScriptExecutionContext.
  • dom/MessageChannel.cpp: (WebCore::MessageChannel::MessageChannel):
  • dom/MessageChannel.h: (WebCore::MessageChannel::create): Use ScriptExecutionContext instead of Document.
  • dom/MessagePort.cpp: (WebCore::CloseMessagePortTimer::CloseMessagePortTimer): Make m_port a RefPtr, because MessagePort doesn't ref() itself when posting this event any more (this is a fix for an unrelated issue that was causing random crashes in layout tests). (WebCore::MessagePort::MessagePort): (WebCore::MessagePort::~MessagePort): (WebCore::MessagePort::associatedFrame): (WebCore::MessagePort::clone): (WebCore::MessagePort::postMessage): (WebCore::MessagePort::startConversation): (WebCore::MessagePort::start): (WebCore::MessagePort::contextDestroyed): (WebCore::MessagePort::dispatchMessages):
  • dom/MessagePort.h: (WebCore::MessagePort::create): (WebCore::MessagePort::scriptExecutionContext): Use ScriptExecutionContext instead of Document. This is a step toward making MessagePort work in worker contexts - we need to also make some its method thread safe for cross-thread messaging, and make event dispatching thread safe.
  • dom/ScriptExecutionContext.cpp: Added.
  • dom/ScriptExecutionContext.h: Added. ActiveDOMObject and MessagePort tracking is moved from Document. It is debatable whether ScriptExecutionContext should be a parent of Document or DOMWindow, but as I'm just moving Document code, and it is Document that is the main context object in our implementation currently. Changing ScriptExecutionContext to be a parent of DOMWindow causes a number of bugs that seem non-trivial to fix, and isn't really a part of this task.
Note: See TracTimeline for information about the timeline view.