Timeline
Dec 6, 2008:
- 11:48 PM Changeset in webkit [39079] by
-
- 9 edits3 adds in trunk
2008-12-06 Dirk Schulze <krit@webkit.org>
Reviewed by Oliver Hunt.
WebCore:
Add support for setTransform() in canvas.
<canvas> lacks transform() and setTransform()
https://bugs.webkit.org/show_bug.cgi?id=16604
Test: fast/canvas/canvas-setTransform.html
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::State::State): (WebCore::CanvasRenderingContext2D::setStrokeStyle): (WebCore::CanvasRenderingContext2D::setFillStyle): (WebCore::CanvasRenderingContext2D::scale): (WebCore::CanvasRenderingContext2D::rotate): (WebCore::CanvasRenderingContext2D::translate): (WebCore::CanvasRenderingContext2D::transform): (WebCore::CanvasRenderingContext2D::setTransform): (WebCore::CanvasRenderingContext2D::beginPath): (WebCore::CanvasRenderingContext2D::closePath): (WebCore::CanvasRenderingContext2D::moveTo): (WebCore::CanvasRenderingContext2D::lineTo): (WebCore::CanvasRenderingContext2D::quadraticCurveTo): (WebCore::CanvasRenderingContext2D::bezierCurveTo): (WebCore::CanvasRenderingContext2D::arcTo): (WebCore::CanvasRenderingContext2D::arc): (WebCore::CanvasRenderingContext2D::rect): (WebCore::CanvasRenderingContext2D::fill): (WebCore::CanvasRenderingContext2D::stroke): (WebCore::CanvasRenderingContext2D::clip): (WebCore::CanvasRenderingContext2D::isPointInPath): (WebCore::CanvasRenderingContext2D::clearRect): (WebCore::CanvasRenderingContext2D::fillRect): (WebCore::CanvasRenderingContext2D::strokeRect): (WebCore::CanvasRenderingContext2D::drawImage): (WebCore::CanvasRenderingContext2D::drawImageFromRect): (WebCore::CanvasRenderingContext2D::willDraw): (WebCore::CanvasRenderingContext2D::drawTextInternal):
- html/CanvasRenderingContext2D.h:
- html/CanvasRenderingContext2D.idl:
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::baseTransform):
- html/HTMLCanvasElement.h:
- platform/graphics/ImageBuffer.h: (WebCore::ImageBuffer::baseTransform):
LayoutTests:
Added tests for canvas's setTransform() and updated an existing one.
- fast/canvas/canvas-setTransform-expected.txt: Added.
- fast/canvas/canvas-setTransform.html: Added.
- fast/canvas/resources/canvas-setTransform.js: Added.
- fast/dom/Window/window-properties-expected.txt:
- 10:15 PM Changeset in webkit [39078] by
-
- 3 edits4 adds in trunk
2008-12-06 Simon Fraser <Simon Fraser>
Reviewed by Antti Koivisto, Dan Bernstein
Fix logic related to repainting when transform changes:
If an object has a layer, and the transform changes, then we need
to do a repaintIncludingDescendants(), not just a repaint.
Test: fast/repaint/transform-repaint-descendants.html
- rendering/RenderObject.cpp: (WebCore::RenderObject::styleWillChange):
- 8:20 PM Changeset in webkit [39077] by
-
- 2 edits in trunk/JavaScriptCore
2008-12-06 Sam Weinig <sam@webkit.org>
Fix the Gtk build.
- jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compilePutByIdHotPath):
- 6:05 PM Changeset in webkit [39076] by
-
- 2 edits in trunk/WebCore
2008-12-06 Antti Koivisto <Antti Koivisto>
Reviewed by Darin Adler.
Also copy m_implicit field. Darin wanted this change commited separately.
- css/CSSProperty.h: (WebCore::CSSProperty::operator=):
- 5:40 PM Changeset in webkit [39075] by
-
- 14 edits in trunk
WebCore:
2008-12-06 Antti Koivisto <Antti Koivisto>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22379
Make CSSOM use less memory
Use vector instead of a double linked list for properties in CSSMutableStyleDeclaration.
Taught setter functions to use existing slots to avoid memory moves, plus some
other optimizations.
- WebCore.xcodeproj/project.pbxproj:
- css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration): (WebCore::CSSMutableStyleDeclaration::operator=): (WebCore::CSSMutableStyleDeclaration::getPropertyCSSValue): (WebCore::CSSMutableStyleDeclaration::removeShorthandProperty): (WebCore::CSSMutableStyleDeclaration::removeProperty): (WebCore::CSSMutableStyleDeclaration::getPropertyPriority): (WebCore::CSSMutableStyleDeclaration::getPropertyShorthand): (WebCore::CSSMutableStyleDeclaration::isPropertyImplicit): (WebCore::CSSMutableStyleDeclaration::setProperty): (WebCore::CSSMutableStyleDeclaration::setPropertyInternal): (WebCore::CSSMutableStyleDeclaration::setStringProperty): (WebCore::CSSMutableStyleDeclaration::setImageProperty): (WebCore::CSSMutableStyleDeclaration::parseDeclaration): (WebCore::CSSMutableStyleDeclaration::addParsedProperties): (WebCore::CSSMutableStyleDeclaration::addParsedProperty): (WebCore::CSSMutableStyleDeclaration::setLengthProperty): (WebCore::CSSMutableStyleDeclaration::length): (WebCore::CSSMutableStyleDeclaration::item): (WebCore::CSSMutableStyleDeclaration::cssText): (WebCore::CSSMutableStyleDeclaration::setCssText): (WebCore::CSSMutableStyleDeclaration::merge): (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet): (WebCore::CSSMutableStyleDeclaration::copy): (WebCore::CSSMutableStyleDeclaration::findPropertyWithId):
- css/CSSMutableStyleDeclaration.h: (WebCore::CSSMutableStyleDeclarationConstIterator::operator*): (WebCore::CSSMutableStyleDeclarationConstIterator::operator->): (WebCore::CSSMutableStyleDeclarationConstIterator::operator!=): (WebCore::CSSMutableStyleDeclarationConstIterator::operator==): (WebCore::CSSMutableStyleDeclaration::create): (WebCore::CSSMutableStyleDeclaration::begin): (WebCore::CSSMutableStyleDeclaration::end): (WebCore::CSSMutableStyleDeclarationConstIterator::CSSMutableStyleDeclarationConstIterator): (WebCore::CSSMutableStyleDeclarationConstIterator::~CSSMutableStyleDeclarationConstIterator): (WebCore::CSSMutableStyleDeclarationConstIterator::operator=): (WebCore::CSSMutableStyleDeclarationConstIterator::operator++): (WebCore::CSSMutableStyleDeclarationConstIterator::operator--):
- css/CSSProperty.h: (WTF::):
- css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::diff): (WebCore::CSSStyleDeclaration::copyPropertiesInSet):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::resolveVariablesForDeclaration): (WebCore::CSSStyleSelector::keyframeStylesForAnimation): (WebCore::CSSStyleSelector::applyDeclarations):
- dom/EventTarget.h:
- editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::init): (WebCore::ApplyStyleCommand::isHTMLStyleNode): (WebCore::ApplyStyleCommand::removeHTMLFontStyle): (WebCore::ApplyStyleCommand::removeCSSStyle):
- editing/Editor.cpp: (WebCore::Editor::selectionStartHasStyle): (WebCore::updateState):
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::handleStyleSpans):
- editing/markup.cpp: (WebCore::appendStartMarkup):
LayoutTests:
2008-12-06 Antti Koivisto <Antti Koivisto>
Reusing property slots changed property ordering in this text.
- editing/pasteboard/5780697-2-expected.txt:
- 5:07 PM Changeset in webkit [39074] by
-
- 3 edits in trunk/LayoutTests
2008-12-06 Simon Fraser <Simon Fraser>
Update expected image now that the caret renders in transformed
content.
- platform/mac/fast/forms/search-transformed-expected.checksum:
- platform/mac/fast/forms/search-transformed-expected.png:
- 5:03 PM Changeset in webkit [39073] by
-
- 3 edits4 adds in trunk
2008-12-06 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein
When painting the selection on a replaced element, paint
using local coordinates so that the selection is correctly
painted for transformed elements.
Test: fast/replaced/selection-rect-transform.html
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
- 2:31 PM Changeset in webkit [39072] by
-
- 3 edits in trunk/JavaScriptCore
2008-12-06 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich,
Move CodeBlock constructor into the .cpp file.
Sunspider reports a .7% progression, but I can only assume this
is noise.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::CodeBlock):
- bytecode/CodeBlock.h:
- 2:19 PM Changeset in webkit [39071] by
-
- 8 edits2 copies in trunk/JavaScriptCore
2008-12-06 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Split JumpTable code into its own file.
- GNUmakefile.am:
- JavaScriptCore.pri:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- JavaScriptCoreSources.bkl:
- bytecode/CodeBlock.cpp:
- bytecode/CodeBlock.h:
- bytecode/JumpTable.cpp: Copied from bytecode/CodeBlock.cpp.
- bytecode/JumpTable.h: Copied from bytecode/CodeBlock.h.
- 2:01 PM Changeset in webkit [39070] by
-
- 19 edits in trunk/JavaScriptCore
2008-12-05 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Fix for https://bugs.webkit.org/show_bug.cgi?id=22715
Encapsulate more CodeBlock members in preparation
of moving some of them to a rare data structure.
- bytecode/CodeBlock.cpp: (JSC::locationForOffset): (JSC::printConditionalJump): (JSC::printGetByIdOp): (JSC::printPutByIdOp): (JSC::CodeBlock::printStructure): (JSC::CodeBlock::printStructures): (JSC::CodeBlock::dump): (JSC::CodeBlock::~CodeBlock): (JSC::CodeBlock::unlinkCallers): (JSC::CodeBlock::derefStructures): (JSC::CodeBlock::refStructures): (JSC::CodeBlock::mark): (JSC::CodeBlock::getHandlerForVPC): (JSC::CodeBlock::nativeExceptionCodeForHandlerVPC): (JSC::CodeBlock::lineNumberForVPC): (JSC::CodeBlock::expressionRangeForVPC): (JSC::CodeBlock::shrinkToFit):
- bytecode/CodeBlock.h: (JSC::CodeBlock::CodeBlock): (JSC::CodeBlock::addCaller): (JSC::CodeBlock::removeCaller): (JSC::CodeBlock::isKnownNotImmediate): (JSC::CodeBlock::isConstantRegisterIndex): (JSC::CodeBlock::getConstant): (JSC::CodeBlock::isTemporaryRegisterIndex): (JSC::CodeBlock::getStubInfo): (JSC::CodeBlock::getCallLinkInfo): (JSC::CodeBlock::instructions): (JSC::CodeBlock::setJITCode): (JSC::CodeBlock::jitCode): (JSC::CodeBlock::ownerNode): (JSC::CodeBlock::setGlobalData): (JSC::CodeBlock::setThisRegister): (JSC::CodeBlock::thisRegister): (JSC::CodeBlock::setNeedsFullScopeChain): (JSC::CodeBlock::needsFullScopeChain): (JSC::CodeBlock::setUsesEval): (JSC::CodeBlock::usesEval): (JSC::CodeBlock::setUsesArguments): (JSC::CodeBlock::usesArguments): (JSC::CodeBlock::codeType): (JSC::CodeBlock::source): (JSC::CodeBlock::sourceOffset): (JSC::CodeBlock::addGlobalResolveInstruction): (JSC::CodeBlock::numberOfPropertyAccessInstructions): (JSC::CodeBlock::addPropertyAccessInstruction): (JSC::CodeBlock::propertyAccessInstruction): (JSC::CodeBlock::numberOfCallLinkInfos): (JSC::CodeBlock::addCallLinkInfo): (JSC::CodeBlock::callLinkInfo): (JSC::CodeBlock::numberOfJumpTargets): (JSC::CodeBlock::addJumpTarget): (JSC::CodeBlock::jumpTarget): (JSC::CodeBlock::lastJumpTarget): (JSC::CodeBlock::numberOfExceptionHandlers): (JSC::CodeBlock::addExceptionHandler): (JSC::CodeBlock::exceptionHandler): (JSC::CodeBlock::addExpressionInfo): (JSC::CodeBlock::numberOfLineInfos): (JSC::CodeBlock::addLineInfo): (JSC::CodeBlock::lastLineInfo): (JSC::CodeBlock::jitReturnAddressVPCMap): (JSC::CodeBlock::numberOfIdentifiers): (JSC::CodeBlock::addIdentifier): (JSC::CodeBlock::identifier): (JSC::CodeBlock::numberOfConstantRegisters): (JSC::CodeBlock::addConstantRegister): (JSC::CodeBlock::constantRegister): (JSC::CodeBlock::addFunction): (JSC::CodeBlock::function): (JSC::CodeBlock::addFunctionExpression): (JSC::CodeBlock::functionExpression): (JSC::CodeBlock::addUnexpectedConstant): (JSC::CodeBlock::unexpectedConstant): (JSC::CodeBlock::addRegExp): (JSC::CodeBlock::regexp): (JSC::CodeBlock::symbolTable): (JSC::CodeBlock::evalCodeCache): New inline setters/getters.
(JSC::ProgramCodeBlock::ProgramCodeBlock):
(JSC::ProgramCodeBlock::~ProgramCodeBlock):
(JSC::ProgramCodeBlock::clearGlobalObject):
- bytecode/SamplingTool.cpp: (JSC::ScopeSampleRecord::sample): (JSC::SamplingTool::dump):
- bytecompiler/BytecodeGenerator.cpp:
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/Label.h:
- interpreter/CallFrame.cpp:
- interpreter/Interpreter.cpp:
- jit/JIT.cpp:
- jit/JITCall.cpp:
- jit/JITInlineMethods.h:
- jit/JITPropertyAccess.cpp:
- parser/Nodes.cpp:
- runtime/Arguments.h:
- runtime/ExceptionHelpers.cpp:
- runtime/JSActivation.cpp:
- runtime/JSActivation.h:
- runtime/JSGlobalObject.cpp: Change direct access to use new getter/setters.
- 11:58 AM Changeset in webkit [39069] by
-
- 37 edits4 adds in trunk
2008-12-06 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Fix caret rendering to behave correctly with transforms:
- Rename caretRect() methods to localCaretRect() and absoluteCaretBounds() as appropriate
- Fix localCaretRect() methods to return a rect in the appropriate coordinates.
- Pass tx, ty down through the paintCaret() methods, after fixing them up to account for differences between contents coords, and renderer-local coords (via RenderBlock::offsetForContents()).
- Remove m_caretPositionOnLayout from SelectionController, and instead call invalidateSelection() from RenderLayer::scrollToOffset(), because we can no longer assume simple x/y offsets from scrolling with transforms.
- Move the logic to compute which RenderObject actually paints the caret into SelectionController::caretRenderer(), rather than having it in RenderBlock.
- SelectionController now computes and caches a local caret rect. For invalidation, it computes the absolute bounds of that (possibly transformed) local rect. The local rect is computed in the coordinate system of the RenderObject that will paint the caret (this may require offsetting from the actual renderer at the start of the selection).
- Fix LayoutState(RenderObject* root) to take transforms into account
- Make offsetFromContainer() a virtual method on RenderObject, and implement the RenderObject version. It's used to map from selection start renderer to caret renderer.
Test: fast/transforms/transformed-caret.html
- 9:20 AM Changeset in webkit [39068] by
-
- 1 edit in trunk/WebCore/ChangeLog
Added reference to bugs.webkit.org bug.
- 9:15 AM Changeset in webkit [39067] by
-
- 2 edits in trunk/WebCore
BUILD FIX for r39065: Forgot parentheses after "document".
Bug 22666: Clean up data structures used when collecting URLs of subresources for webarchives
<https://bugs.webkit.org/show_bug.cgi?id=22666>
- svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::addSubresourceAttributeURLs): Changed document to document().
- 8:04 AM Changeset in webkit [39066] by
-
- 2 edits in trunk/WebCore
2008-12-06 Dmitry Titov <dimich@chromium.org>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=22710
Memory leak due to circular reference Document->DOMTimer->ScheduledAction->[JS objects]->Document
- bindings/js/DOMTimer.cpp: (WebCore::DOMTimer::stop): Delete ScheduledAction, which contains a protected object.
- 3:54 AM Changeset in webkit [39065] by
-
- 43 edits in trunk
Bug 22666: Clean up data structures used when collecting URLs of subresources for webarchives
Reviewed by Darin Adler.
WebCore:
When creating a webarchive from WebCore::LegacyWebArchive::create(),
HashSet<String>, Vector<KURL> and Vector<String> were all used to
store a list of URLs for resources found in the document. Instead
use a single ListHashSet<KURL> to store the list and resolve the
relative URLs as they're added. We use a new inline method called
WebCore::addSubresourceURL() to add KURL objects to the ListHashSet
to prevent "null" KURL objects from crashing in the KURL hashing
function.
- WebCore.base.exp: Changed export of WebCore::Node::getSubresourceURLs() to take a ListHashSet<KURL> argument instead of a Vector<KURL>.
- WebCore.xcodeproj/project.pbxproj: Marked KURLHash.h as a private header for use in WebKit.
- css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Renamed from addSubresourceURLStrings(). Changed to use ListHashSet<KURL> instead of HashSet<String>. Cleaned up code.
- css/CSSStyleSheet.h: (WebCore::CSSStyleSheet::addSubresourceStyleURLs): Ditto.
- css/StyleSheet.h: (WebCore::StyleSheet::addSubresourceStyleURLs): Ditto.
- dom/Node.cpp: (WebCore::Node::getSubresourceURLs): Changed to use ListHashSet<KURL> instead of Vector<KURL>. Cleaned up code.
- dom/Node.h: (WebCore::Node::getSubresourceURLs): Ditto. (WebCore::Node::addSubresourceAttributeURLs): Renamed from getSubresourceAttributeStrings(). Changed to use ListHashSet<KURL> instead of Vector<String>. (WebCore::addSubresourceURL): Added. Safely adds new KURL objects to a ListHashSet<KURL> object. A "null" KURL object will cause the hash function to crash since it contains a null StringImpl. Used in Node::addSubresourceAttributeURLs() and addSubresourceStyleURLs() in the style subsystem.
- dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::addSubresourceAttributeURLs): Renamed from getSubresourceAttributeStrings(). Changed to use ListHashSet<KURL> instead of Vector<String>. Use WebCore::addSubresourceURL() to add new KURL objects.
- dom/ProcessingInstruction.h: Ditto.
- html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLBodyElement.h: Ditto.
- html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLEmbedElement.h: Ditto.
- html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLImageElement.h: Ditto.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLInputElement.h: Ditto.
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLLinkElement.h: Ditto.
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLObjectElement.h: Ditto.
- html/HTMLParamElement.cpp: (WebCore::HTMLParamElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLParamElement.h: Ditto.
- html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLScriptElement.h: Ditto.
- html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLStyleElement.h: Ditto.
- html/HTMLTableCellElement.cpp: (WebCore::HTMLTableCellElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLTableCellElement.h: Ditto.
- html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::addSubresourceAttributeURLs): Ditto.
- html/HTMLTableElement.h: Ditto.
- loader/archive/cf/LegacyWebArchive.cpp: (WebCore::LegacyWebArchive::create): Changed from using HashSet<String> to ListHashSet<KURL> for tracking unique subresources. Changed from using Vector<KURL> to ListHashSet<KURL> when calling WebCore::Node::getSubresourceURLs(). Cleaned up code.
- svg/SVGCursorElement.cpp: (WebCore::SVGCursorElement::addSubresourceAttributeURLs): Renamed from getSubresourceAttributeStrings(). Changed to use ListHashSet<KURL> instead of Vector<String>. Use WebCore::addSubresourceURL() to add new KURL objects.
- svg/SVGCursorElement.h: Ditto.
- svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::addSubresourceAttributeURLs): Ditto.
- svg/SVGFEImageElement.h: Ditto.
- svg/SVGImageElement.cpp: (WebCore::SVGImageElement::addSubresourceAttributeURLs): Ditto.
- svg/SVGImageElement.h: Ditto.
- svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::addSubresourceAttributeURLs): Ditto.
- svg/SVGScriptElement.h: Ditto.
WebKit/mac:
- DOM/WebDOMOperations.mm: (-[DOMNode _subresourceURLs]): Changed from using Vector<KURL> to ListHashSet<KURL> when calling WebCore::Node::getSubresourceURLs().
- 3:51 AM Changeset in webkit [39064] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fixed ChangeLog date.
Dec 5, 2008:
- 9:00 PM Changeset in webkit [39063] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Mis-commit in ChangeLog entry
- 8:57 PM Changeset in webkit [39062] by
-
- 2 edits in trunk/JavaScriptCore
2008-12-05 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Please don't die in a fire while trying to compile Interpreter.cpp on GCC 4.2.
Added "-fno-var-tracking" compiler flag.
- JavaScriptCore.xcodeproj/project.pbxproj:
- 7:25 PM Changeset in webkit [39061] by
-
- 4 edits in trunk/JavaScriptCore
2008-12-05 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Ordering of branch operands in MacroAssembler in unnecessarily inconsistent.
je, jg etc take an immediate operand as the second argument, but for the
equality branches (je, jne) the immediate operand was the first argument. This
was unnecessarily inconsistent. Change je, jne methods to take the immediate
as the second argument.
- assembler/MacroAssembler.h: (JSC::MacroAssembler::je32): (JSC::MacroAssembler::jne32):
- jit/JIT.cpp: (JSC::JIT::compileOpStrictEq):
- wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateEnter): (JSC::WREC::Generator::generateNonGreedyQuantifier): (JSC::WREC::Generator::generateGreedyQuantifier): (JSC::WREC::Generator::generatePatternCharacterPair): (JSC::WREC::Generator::generatePatternCharacter): (JSC::WREC::Generator::generateCharacterClassInvertedRange): (JSC::WREC::Generator::generateCharacterClassInverted): (JSC::WREC::Generator::generateAssertionBOL): (JSC::WREC::Generator::generateAssertionWordBoundary):
- 6:27 PM Changeset in webkit [39060] by
-
- 4 edits in trunk/WebCore
Reviewed by Darin Adler.
Make the page group use the proper link hashing functions rather than
calling the string hash functions directly. Add Chromium-specfic ifdefs
in the visited link computation functions to allow integration.
- page/PageGroup.cpp:
(WebCore::PageGroup::isLinkVisited):
(WebCore::PageGroup::addVisitedLink):
- platform/LinkHash.cpp:
(WebCore::visitedLinkHash):
- platform/LinkHash.h:
- 5:42 PM Changeset in webkit [39059] by
-
- 6 edits4 adds in trunk
2008-12-05 Chris Marrin <cmarrin@apple.com>
Reviewed by Dave Hyatt.
Fix for https://bugs.webkit.org/show_bug.cgi?id=22635
For iteration and end events, previous fixes to prevent the deletion of
Animation objects (ref counting and hanging onto a ref during event callbacks)
was sufficient to prevent dangling pointers. But start events are sent in
the styleAvailable() call, which iterates over CompositeAnimation objects,
which are not ref counted. So that object can get destroyed in the event
handler while still active. So I added refcounting for CompositeAnimations.
Additionally, when am iterating over the CompositingAnimation list, it can
be deleted, which mutates the list. So I now make one pass over the list
building a vector of CompositeAnimation objects that need to be called and
then iterate over that vector to make the actual calls.
Finally, to make sure the lifetime of the CompositeAnimation exceeds that of
the Animation objects it owns, I now keep a ref to the CompositeAnimation
in the timer callback for the iteration and end events. That means I no
longer need to keep a ref to the Animation objects themselves in that timer
callback, since the CompositeAnimation already has one.
Tests: animations/animation-iteration-event-destroy-renderer.html
animations/animation-start-event-destroy-renderer.html
- 5:36 PM Changeset in webkit [39058] by
-
- 5 edits in trunk/JavaScriptCore
2008-12-05 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Second tranche of porting JIT.cpp to MacroAssembler interface.
- assembler/MacroAssembler.h: (JSC::MacroAssembler::mul32): (JSC::MacroAssembler::jl32): (JSC::MacroAssembler::jnzSub32): (JSC::MacroAssembler::joAdd32): (JSC::MacroAssembler::joMul32): (JSC::MacroAssembler::jzSub32):
- jit/JIT.cpp: (JSC::JIT::emitSlowScriptCheck): (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases): (JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JIT.h:
- jit/JITInlineMethods.h: (JSC::JIT::emitJumpIfNotJSCell): (JSC::JIT::emitJumpSlowCaseIfNotJSCell):
- 5:07 PM Changeset in webkit [39057] by
-
- 2 edits in trunk
Added bugs.webkit.org URL to ChangeLog entry.
- 5:05 PM Changeset in webkit [39056] by
-
- 7 edits in trunk
<rdar://problem/6331749> Provide a mechanism to disable perfect hashing in the DOM at build time
Reviewed by Darin Adler.
Initial patch by Yosen Lin. Adapted for ToT WebKit by David Kilzer.
Added back the code that generates a "compact" hash (instead of a
perfect hash) as a build-time option using the
ENABLE(PERFECT_HASH_SIZE) macro as defined in Lookup.h.
- create_hash_table: Rename variables to differentiate perfect hash values from compact hash values. Added back code to compute compact hash tables. Generate both hash table sizes and emit conditionalized code based on ENABLE(PERFECT_HASH_SIZE).
- runtime/Lookup.cpp: (JSC::HashTable::createTable): Added version of createTable() for use with compact hash tables. (JSC::HashTable::deleteTable): Updated to work with compact hash tables.
- runtime/Lookup.h: Defined ENABLE(PERFECT_HASH_SIZE) macro here. (JSC::HashEntry::initialize): Set m_next to zero when using compact hash tables. (JSC::HashEntry::setNext): Added for compact hash tables. (JSC::HashEntry::next): Added for compact hash tables. (JSC::HashTable::entry): Added version of entry() for use with compact hash tables.
- runtime/Structure.cpp: (JSC::Structure::getEnumerablePropertyNames): Updated to work with compact hash tables.
WebCore:
- bindings/scripts/CodeGeneratorJS.pm: (GenerateImplementation): Compute the number of elements that will be stored in each hash table and pass it to GenerateHashTable(). (GenerateHashTable): Added new second parameter representing the number of elements to store in the compact hash table. Added back code to compute compact hash tables. Generate both hash table sizes and emit conditionalized code based on ENABLE(PERFECT_HASH_SIZE).
- 4:52 PM Changeset in webkit [39055] by
-
- 2 edits in trunk/JavaScriptCore
2008-12-05 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Remove redundant calls to JIT::emitSlowScriptCheck.
This is checked in the hot path, so is not needed on the slow path - and the code
was being planted before the start of the slow case, so was completely unreachable!
- jit/JIT.cpp: (JSC::JIT::privateCompileSlowCases):
- 4:02 PM Changeset in webkit [39054] by
-
- 1 edit2 adds in trunk/LayoutTests
2008-12-05 Pamela Greene <pam@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22608
Add a test for line numbers of uncaught JS exceptions.
- fast/js/uncaught-exception-line-number-expected.txt: Added.
- fast/js/uncaught-exception-line-number.html: Added.
- 3:57 PM Changeset in webkit [39053] by
-
- 4 edits in trunk/JavaScriptCore
2008-12-05 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Move JIT::compileOpStrictEq to MacroAssembler interface.
The rewrite also looks like a small (<1%) performance progression.
- jit/JIT.cpp: (JSC::JIT::compileOpStrictEq): (JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
- jit/JITInlineMethods.h: (JSC::JIT::emitJumpIfJSCell): (JSC::JIT::emitJumpSlowCaseIfJSCell):
- 3:56 PM Changeset in webkit [39052] by
-
- 1 edit2 adds in trunk/LayoutTests
2008-12-05 Pamela Greene <pam@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22604
Add test for onload handler named 'onload'.
- fast/events/onload-name-collision-expected.txt: Added.
- fast/events/onload-name-collision.html: Added.
- 3:53 PM Changeset in webkit [39051] by
-
- 1 edit4 adds in trunk/LayoutTests
2008-12-05 Pamela Greene <pam@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22601
Add test to verify that calling functions on a Java applet from JS works.
- fast/dom/java-applet-calls-expected.txt: Added.
- fast/dom/java-applet-calls.html: Added.
- fast/dom/resources/TestApplet.class: Added.
- fast/dom/resources/TestApplet.java: Added. (TestApplet): Source of test applet for use by layout test(s). (TestApplet.init): (TestApplet.setString): (TestApplet.getString):
- 3:48 PM Changeset in webkit [39050] by
-
- 1 edit2 adds in trunk/LayoutTests
2008-12-05 Pamela Greene <pam@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22592
Make sure the onload handler is only called once, even when there are
multiple <body> nodes in the document.
- fast/events/onload-fires-twice-expected.txt: Added.
- fast/events/onload-fires-twice.html: Added.
- 3:25 PM Changeset in webkit [39049] by
-
- 1 edit2 adds in trunk/LayoutTests
2008-12-05 Pamela Greene <pam@chromium.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22575
Add a test for accessing NodeList items by name.
- fast/dom/NodeList/nodelist-item-with-name-expected.txt: Added.
- fast/dom/NodeList/nodelist-item-with-name.html: Added.
- 3:22 PM Changeset in webkit [39048] by
-
- 2 edits in trunk/WebCore
Merge branch 'ownptr' into ownptr_commit
- 3:19 PM Changeset in webkit [39047] by
-
- 1 edit2 adds in trunk/LayoutTests
2008-12-05 Pamela Greene <pam@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=22632
Add a test for DOM operations with incompatible receivers or arguments.
- fast/dom/incompatible-operations-expected.txt: Added.
- fast/dom/incompatible-operations.html: Added.
- 3:13 PM Changeset in webkit [39046] by
-
- 2 edits in trunk/WebCore
Reviewed by Eric Seidel.
Add a missing include for OwnPtr to make CSSSelector compile without
precompiled headers.
- css/CSSSelector.h:
- 2:53 PM Changeset in webkit [39045] by
-
- 2 edits in trunk/WebKitTools
Bug 22555: Sort "children" sections in Xcode project files
Reviewed by Darin Adler.
Sort "children" sections alphabetically, moving groups (folders) to
the top of each of the lists. Files are assumed to have extensions,
so %isFile is used to override this behavior.
- Scripts/sort-Xcode-project-file: (sortChildrenByFileName): Added. (sortFilesByFileName): Renamed from sortByFileName().
- 2:15 PM Changeset in webkit [39044] by
-
- 5 edits in trunk/WebKitTools
Reviewed by Geoff Garen.
https://bugs.webkit.org/show_bug.cgi?id=22683
Fix gtk and qt builds which depend on --qt and --gtk being removed from ARGV
Add a new argumentsForConfiguration() function and clean up some old code to use it.
Rename checkArgV to checkForArgumentAndRemoveFromARGV to be more self-documenting.
- Scripts/run-javascriptcore-tests:
- Scripts/run-launcher:
- Scripts/run-webkit-tests:
- Scripts/webkitdirs.pm:
- 2:14 PM Changeset in webkit [39043] by
-
- 5 edits in trunk/JavaScriptCore
2008-12-05 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Remove m_assembler from MacroAssembler::Jump.
Keeping a pointer allowed for some syntactic sugar - "link()" looks nicer
than "link(this)". But maintaining this doubles the size of Jump, which
is even more unfortunate for the JIT, since there are many large structures
holding JmpSrcs. Probably best to remove it.
- assembler/MacroAssembler.h: (JSC::MacroAssembler::Jump::Jump): (JSC::MacroAssembler::Jump::link): (JSC::MacroAssembler::Jump::linkTo): (JSC::MacroAssembler::JumpList::link): (JSC::MacroAssembler::JumpList::linkTo): (JSC::MacroAssembler::jae32): (JSC::MacroAssembler::je32): (JSC::MacroAssembler::je16): (JSC::MacroAssembler::jg32): (JSC::MacroAssembler::jge32): (JSC::MacroAssembler::jl32): (JSC::MacroAssembler::jle32): (JSC::MacroAssembler::jnePtr): (JSC::MacroAssembler::jne32): (JSC::MacroAssembler::jnset32): (JSC::MacroAssembler::jset32): (JSC::MacroAssembler::jump): (JSC::MacroAssembler::jzSub32): (JSC::MacroAssembler::joAdd32): (JSC::MacroAssembler::call):
- wrec/WREC.cpp: (JSC::WREC::Generator::compileRegExp):
- wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateEnter): (JSC::WREC::Generator::generateBackreferenceQuantifier): (JSC::WREC::Generator::generateNonGreedyQuantifier): (JSC::WREC::Generator::generateGreedyQuantifier): (JSC::WREC::Generator::generatePatternCharacter): (JSC::WREC::Generator::generateCharacterClassInvertedRange): (JSC::WREC::Generator::generateCharacterClassInverted): (JSC::WREC::Generator::generateCharacterClass): (JSC::WREC::Generator::generateParenthesesAssertion): (JSC::WREC::Generator::generateParenthesesInvertedAssertion): (JSC::WREC::Generator::generateParenthesesNonGreedy): (JSC::WREC::Generator::generateParenthesesResetTrampoline): (JSC::WREC::Generator::generateAssertionBOL): (JSC::WREC::Generator::generateAssertionEOL): (JSC::WREC::Generator::generateAssertionWordBoundary): (JSC::WREC::Generator::generateBackreference): (JSC::WREC::Generator::terminateAlternative): (JSC::WREC::Generator::terminateDisjunction):
- wrec/WRECParser.h:
- 2:10 PM Changeset in webkit [39042] by
-
- 4 edits in trunk/WebCore
2008-12-05 Finnur Thorarinsson <finnur.webkit@gmail.com>
Reviewed by Darin Adler.
Bug 22579: Providing a function to ScrollbarClient.h which allows us to get at the tickmarks
without relying on high-level WebCore types, as requested by Dave Hyatt.
No functional changes, thus no test cases.
- page/FrameView.cpp: (WebCore::FrameView::getTickmarks):
- page/FrameView.h:
- platform/ScrollbarClient.h:
- 1:54 PM Changeset in webkit [39041] by
-
- 4 edits in trunk/LayoutTests
2008-12-05 Justin Garcia <justin.garcia@apple.com>
Updating these test results. On Tiger the fragment created from RTFD data
contained interchange newlines that we incorrectly handled before r38983.
- platform/mac-tiger/editing/pasteboard/paste-RTFD-expected.checksum:
- platform/mac-tiger/editing/pasteboard/paste-RTFD-expected.png:
- platform/mac-tiger/editing/pasteboard/paste-RTFD-expected.txt:
- 12:56 PM Changeset in webkit [39040] by
-
- 1 edit3 adds in trunk/LayoutTests
2008-12-05 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Added a test for a bug I discovered while working on
https://bugs.webkit.org/show_bug.cgi?id=22685.
- fast/regex/non-capturing-backtracking-expected.txt: Added.
- fast/regex/non-capturing-backtracking.html: Added.
- fast/regex/resources/non-capturing-backtracking.js: Added.
- 12:39 PM Changeset in webkit [39039] by
-
- 4 edits in trunk/JavaScriptCore
2008-12-05 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoffrey Garen.
Simplify JIT generated checks for timeout code, by moving more work into the C function.
https://bugs.webkit.org/show_bug.cgi?id=22688
- interpreter/Interpreter.cpp: (JSC::Interpreter::cti_timeout_check):
- interpreter/Interpreter.h:
- jit/JIT.cpp: (JSC::JIT::emitSlowScriptCheck):
- 12:27 PM Changeset in webkit [39038] by
-
- 6 edits in trunk/JavaScriptCore
2008-12-05 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Encapsulate access to jump tables in the CodeBlock in preparation
of moving them to a rare data structure.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): (JSC::CodeBlock::shrinkToFit):
- bytecode/CodeBlock.h: (JSC::CodeBlock::numberOfImmediateSwitchJumpTables): (JSC::CodeBlock::addImmediateSwitchJumpTable): (JSC::CodeBlock::immediateSwitchJumpTable): (JSC::CodeBlock::numberOfCharacterSwitchJumpTables): (JSC::CodeBlock::addCharacterSwitchJumpTable): (JSC::CodeBlock::characterSwitchJumpTable): (JSC::CodeBlock::numberOfStringSwitchJumpTables): (JSC::CodeBlock::addStringSwitchJumpTable): (JSC::CodeBlock::stringSwitchJumpTable):
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::generate): (JSC::BytecodeGenerator::endSwitch):
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): (JSC::Interpreter::cti_op_switch_imm): (JSC::Interpreter::cti_op_switch_char): (JSC::Interpreter::cti_op_switch_string):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass):
- 11:00 AM Changeset in webkit [39037] by
-
- 4 edits in trunk
2008-12-05 Dean Jackson <dino@apple.com>
Reviewed by David Hyatt.
WebCore:
Make sure Window event listeners also tell the
Document about the event type, so noisy events
will be dispatched even if nothing in the document
is listening.
https://bugs.webkit.org/show_bug.cgi?id=20572
- dom/Document.cpp: (WebCore::Document::addWindowEventListener):
LayoutTests:
No longer need to add a fake listener on a document
node in order to get events passed up to Window.
https://bugs.webkit.org/show_bug.cgi?id=20572
- transitions/transition-end-event-window.html:
- 10:27 AM Changeset in webkit [39036] by
-
- 40 edits in trunk/LayoutTests
2008-12-05 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim Hatcher.
- Fix intermittent profiler test failures. The problem is that idle time only shows up some times, probably dependent on if the system is running a little slow or has a network hiccup. I've removed this.
- I've also added <rdar://problem/6422004> Profiler tests fail because they sometimes don't have (idle) time. This is to investigate whether or not idle time should be showing up at all when running these tests.
- fast/profiler/anonymous-event-handler-expected.txt:
- fast/profiler/anonymous-function-called-from-different-contexts-expected.txt:
- fast/profiler/anonymous-function-calls-built-in-functions-expected.txt:
- fast/profiler/anonymous-function-calls-eval-expected.txt:
- fast/profiler/apply-expected.txt:
- fast/profiler/built-in-function-calls-anonymous-expected.txt:
- fast/profiler/built-in-function-calls-user-defined-function-expected.txt:
- fast/profiler/call-expected.txt:
- fast/profiler/call-nodelist-as-function-expected.txt:
- fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope-expected.txt:
- fast/profiler/compare-multiple-profiles-expected.txt:
- fast/profiler/constructor-expected.txt:
- fast/profiler/dead-time-expected.txt:
- fast/profiler/document-dot-write-expected.txt:
- fast/profiler/event-handler-expected.txt:
- fast/profiler/execution-context-and-eval-on-same-line-expected.txt:
- fast/profiler/heavy-view-expected.txt:
- fast/profiler/inline-event-handler-expected.txt:
- fast/profiler/many-calls-in-the-same-scope-expected.txt:
- fast/profiler/multiple-and-different-scoped-anonymous-function-calls-expected.txt:
- fast/profiler/multiple-and-different-scoped-function-calls-expected.txt:
- fast/profiler/multiple-frames-expected.txt:
- fast/profiler/nested-anonymous-functon-expected.txt:
- fast/profiler/nested-start-and-stop-profiler-expected.txt:
- fast/profiler/one-execution-context-expected.txt:
- fast/profiler/profile-calls-in-included-file-expected.txt:
- fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting-expected.txt:
- fast/profiler/profiling-from-a-nested-location-expected.txt:
- fast/profiler/resources/profiler-test-JS-resources.js: (printProfileNodeWithoutTime):
- fast/profiler/simple-event-call-expected.txt:
- fast/profiler/simple-no-level-change-expected.txt:
- fast/profiler/start-and-stop-profiler-multiple-times-expected.txt:
- fast/profiler/start-and-stop-profiling-in-the-same-function-expected.txt:
- fast/profiler/stop-profiling-after-setTimeout-expected.txt:
- fast/profiler/stop-then-function-call-expected.txt:
- fast/profiler/throw-exception-from-eval-expected.txt:
- fast/profiler/two-execution-contexts-expected.txt:
- fast/profiler/user-defined-function-calls-built-in-functions-expected.txt:
- fast/profiler/window-dot-eval-expected.txt:
- 10:03 AM Changeset in webkit [39035] by
-
- 2 edits in trunk/WebKit
Mac build fix.
- WebKit.xcodeproj/project.pbxproj:
- 9:23 AM Changeset in webkit [39034] by
-
- 2 edits in trunk/JavaScriptCore
2008-12-05 Simon Hausmann <simon.hausmann@nokia.com>
Rubber-stamped by Tor Arne Vestbø.
Disable the JIT for the Qt build alltogether again, after observing
more miscompilations in a wider range of newer gcc versions.
- 9:22 AM Changeset in webkit [39033] by
-
- 2 edits in trunk/WebCore
Windows build fix after r39026
- platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest): (WebCore::ResourceRequest::doUpdateResourceRequest): Add some missing .get()s.
- 9:21 AM Changeset in webkit [39032] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix after r39020
- jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReference): (JSC::JIT::restoreArgumentReferenceForTrampoline): Add some apparently-missing .
- 9:20 AM Changeset in webkit [39031] by
-
- 2 edits in trunk/WebKit
Mac build fix.
- WebKit.xcodeproj/project.pbxproj:
- 8:49 AM Changeset in webkit [39030] by
-
- 5 edits in trunk/JavaScriptCore
2008-12-04 Geoffrey Garen <ggaren@apple.com>
Reviewed by Darin Adler.
Added support for the assertion (?=) and inverted assertion (?!) atoms
in WREC.
- wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateParenthesesAssertion): (JSC::WREC::Generator::generateParenthesesInvertedAssertion): Split the old (unused) generateParentheses into these two functions, with more limited capabilities.
- wrec/WRECGenerator.h: (JSC::WREC::Generator::): Moved an enum to the top of the class definition, to match the WebKit style, and removed a defunct comment.
- wrec/WRECParser.cpp: (JSC::WREC::Parser::parseParentheses): (JSC::WREC::Parser::consumeParenthesesType):
- wrec/WRECParser.h: (JSC::WREC::Parser::): Added support for parsing (?=) and (?!).
- 8:33 AM Changeset in webkit [39029] by
-
- 2 edits in trunk/WebCore
Tiger build fix.
- platform/network/mac/ResourceRequestMac.mm: Define NSUInteger.
- 7:53 AM Changeset in webkit [39028] by
-
- 20 edits2 moves in trunk
Reviewed by Darin Adler.
<rdar://problem/6405599> Tiger Mail crashes when using "Mail Contents of This Page"
in Safari before opening a mail message in Mail
WebCore:
- platform/mac/WebCoreObjCExtras.mm: (WebCoreObjCFinalizeOnMainThread): Don't call initializeThreading: we now expect the caller to do it, to simplify keeping Tiger and post-Tiger behavior in line.
- bindings/objc/DOMRGBColor.mm: (+[DOMRGBColor initialize]):
- bindings/objc/WebScriptObject.mm: (+[WebScriptObject initialize]):
- page/mac/AccessibilityObjectWrapper.mm: (+[AccessibilityObjectWrapper initialize]):
- platform/mac/SharedBufferMac.mm: (+[WebCoreSharedBufferData initialize]): Call JSC::initializeThreading();
WebKit:
- Carbon/CarbonWindowAdapter.m: Removed.
- Carbon/CarbonWindowAdapter.mm: Copied from WebKit/mac/Carbon/CarbonWindowAdapter.m. (+[CarbonWindowAdapter initialize]):
- History/WebBackForwardList.mm: (+[WebBackForwardList initialize]):
- History/WebHistoryItem.mm: (+[WebHistoryItem initialize]):
- Misc/WebElementDictionary.mm: (+[WebElementDictionary initialize]):
- Plugins/Hosted/WebHostedNetscapePluginView.mm: (+[WebHostedNetscapePluginView initialize]):
- Plugins/WebBaseNetscapePluginView.mm:
- Plugins/WebBasePluginPackage.m: Removed.
- Plugins/WebBasePluginPackage.mm: Copied from WebKit/mac/Plugins/WebBasePluginPackage.m. (+[WebBasePluginPackage initialize]):
- Plugins/WebNetscapePluginView.mm: (+[WebNetscapePluginView initialize]):
- WebCoreSupport/WebEditorClient.mm: (+[WebEditCommand initialize]):
- WebCoreSupport/WebFrameLoaderClient.mm:
- WebView/WebArchive.mm: (+[WebArchivePrivate initialize]):
- WebView/WebDataSource.mm: (+[WebDataSourcePrivate initialize]):
- WebView/WebHTMLView.mm: (+[WebHTMLViewPrivate initialize]): (+[WebHTMLView initialize]):
- WebView/WebResource.mm: (+[WebResourcePrivate initialize]):
- WebView/WebView.mm: (+[WebViewPrivate initialize]): Call JSC::initializeThreading();
- 7:47 AM Changeset in webkit [39027] by
-
- 2 edits in trunk/WebKit/win
2008-12-05 Darin Adler <Darin Adler>
Reviewed by Alexey Proskuryakov.
- fix https://bugs.webkit.org/show_bug.cgi?id=22674 Webkit r39005 does not start, an entry point not found
- WebView.cpp: (findCFNetworkModule): Added. (findCopySharedURLCacheFunction): Added. (WebView::setCacheModel): Call CFURLCacheCopySharedURLCache via dynamic loading instead of compiling based on which version of CFNetwork headers are present.
- 6:43 AM Changeset in webkit [39026] by
-
- 6 edits in trunk/WebCore
Reviewed by Darin Adler.
<rdar://problem/4072827> Downloaded non-ASCII file name becomes garbled
- platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::setResponseContentDispositionEncodingFallbackArray):
- platform/network/ResourceRequestBase.h:
- platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::findCFURLRequestSetContentDispositionEncodingFallbackArrayFunction): (WebCore::findCFURLRequestCopyContentDispositionEncodingFallbackArrayFunction): (WebCore::setContentDispositionEncodingFallbackArray): (WebCore::copyContentDispositionEncodingFallbackArray): (WebCore::ResourceRequest::doUpdatePlatformRequest): (WebCore::ResourceRequest::doUpdateResourceRequest):
- platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdateResourceRequest): (WebCore::ResourceRequest::doUpdatePlatformRequest): Added a way to specify encoding fallback list for Content-Disposition header.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest): Generate and pass a list of encodings to try when decoding Content-Disposition header, as described in comments.
- 6:23 AM Changeset in webkit [39025] by
-
- 6 edits2 adds3 deletes in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22672
ASSERT(m_table) when xhr.onabort creates another xhr or calls setTimeout
Test: http/tests/xmlhttprequest/send-on-abort.html
- dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects): (WebCore::ScriptExecutionContext::suspendActiveDOMObjects): (WebCore::ScriptExecutionContext::resumeActiveDOMObjects): (WebCore::ScriptExecutionContext::stopActiveDOMObjects): Add a comment explaining that ActiveDOMObject methods shouldn't execute arbitrary JS.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::stop): Don't dispatch events. This reverts a recent change that made the behavior slightly closer to Firefox - but the compatibility effect should be very minor if any, and Firefox itself behaves inconsistently.
- 5:02 AM Changeset in webkit [39024] by
-
- 2 edits in trunk/WebCore
2008-12-05 Tobias König <tobias.koenig@nokia.com>
Reviewed by Simon Hausmann.
Record required package dependencies for the Qt build for a correct
pkg-config file.
- 4:50 AM Changeset in webkit [39023] by
-
- 2 edits in trunk/JavaScriptCore
2008-12-05 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Disable the JIT for the Qt build on Linux unless gcc is >= 4.2,
due to miscompilations.
- 3:27 AM Changeset in webkit [39022] by
-
- 2 edits in trunk/WebCore
2008-12-05 Tor Arne Vestbø <tavestbo@trolltech.com>
Rubber-stamped by Simon Hausmann.
[Qt/Mac] Blacklist QuickTime plugin until we support the QuickDraw drawing model
- 1:48 AM Changeset in webkit [39021] by
-
- 5 edits2 moves3 adds in trunk
2008-12-05 Jungshik Shin <jshin@chromium.org>
Reviewed by Alexey Proskuryakov.
Revises charset alias map for TextCodecICU.
- Uses windows-949 and windows-874 instead of windows-949-2000 and windows-874-2000
- Replaces 'windows874' in a couple of place with 'windows-874' (for the canonical name)
- Maps 'dos-874' to 'windows-874'. Currently, it's aliases to 'cp874', which is in turn mapped to 'TIS-620'. 'TIS-620' is manually aliased to 'windows-874'. We'd better directly alias 'dos-874' to 'windows-874'.
- Replaces 'EUC-CN' with 'GBK' when it's used as the canonical name. Similar to the above case, we're getting rid of indirection that eventually leads to 'GBK' by directly going to 'GBK'.
- Adds 'x-uhc' as an alias for 'windows-949'. It's used in some web pages.
Tests: fast/encoding/char-decoding-mac.html
fast/encoding/char-decoding.html
- platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames):
Dec 4, 2008:
- 10:58 PM Changeset in webkit [39020] by
-
- 8 edits in trunk/JavaScriptCore
2008-12-04 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Start porting the JIT to use the MacroAssembler.
https://bugs.webkit.org/show_bug.cgi?id=22671
No change in performance.
- assembler/MacroAssembler.h: (JSC::MacroAssembler::Jump::operator X86Assembler::JmpSrc): (JSC::MacroAssembler::add32): (JSC::MacroAssembler::and32): (JSC::MacroAssembler::lshift32): (JSC::MacroAssembler::rshift32): (JSC::MacroAssembler::storePtr): (JSC::MacroAssembler::store32): (JSC::MacroAssembler::poke): (JSC::MacroAssembler::move): (JSC::MacroAssembler::compareImm32ForBranchEquality): (JSC::MacroAssembler::jnePtr): (JSC::MacroAssembler::jnset32): (JSC::MacroAssembler::jset32): (JSC::MacroAssembler::jzeroSub32): (JSC::MacroAssembler::joverAdd32): (JSC::MacroAssembler::call):
- assembler/X86Assembler.h: (JSC::X86Assembler::shll_i8r):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::compileBinaryArithOp):
- jit/JITInlineMethods.h: (JSC::JIT::emitGetVirtualRegister): (JSC::JIT::emitPutCTIArg): (JSC::JIT::emitPutCTIArgConstant): (JSC::JIT::emitGetCTIArg): (JSC::JIT::emitPutCTIArgFromVirtualRegister): (JSC::JIT::emitPutCTIParam): (JSC::JIT::emitGetCTIParam): (JSC::JIT::emitPutToCallFrameHeader): (JSC::JIT::emitPutImmediateToCallFrameHeader): (JSC::JIT::emitGetFromCallFrameHeader): (JSC::JIT::emitPutVirtualRegister): (JSC::JIT::emitInitRegister): (JSC::JIT::emitNakedCall): (JSC::JIT::restoreArgumentReference): (JSC::JIT::restoreArgumentReferenceForTrampoline): (JSC::JIT::emitCTICall): (JSC::JIT::checkStructure): (JSC::JIT::emitJumpSlowCaseIfNotJSCell): (JSC::JIT::emitJumpSlowCaseIfNotImmNum): (JSC::JIT::emitJumpSlowCaseIfNotImmNums): (JSC::JIT::emitFastArithDeTagImmediate): (JSC::JIT::emitFastArithDeTagImmediateJumpIfZero): (JSC::JIT::emitFastArithReTagImmediate): (JSC::JIT::emitFastArithPotentiallyReTagImmediate): (JSC::JIT::emitFastArithImmToInt): (JSC::JIT::emitFastArithIntToImmOrSlowCase): (JSC::JIT::emitFastArithIntToImmNoCheck): (JSC::JIT::emitTagAsBoolImmediate):
- jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition):
- 8:38 PM Changeset in webkit [39019] by
-
- 4 edits in trunk
Versioning.
- 8:36 PM Changeset in webkit [39018] by
-
- 2 edits in tags/Safari-6528.6/JavaScriptCore
Work around a GCC 4.2 bug that leads to the compiler hanging while attempting to build Interpreter.cpp.
- Configurations/JavaScriptCore.xcconfig:
- 8:36 PM Changeset in webkit [39017] by
-
- 2 edits in tags/Safari-6528.6/WebKit/mac
Merge r38950.
- 8:14 PM Changeset in webkit [39016] by
-
- 1 copy in tags/Safari-6528.6
New tag.
- 8:13 PM Changeset in webkit [39015] by
-
- 2 edits in trunk/WebKit/mac
2008-12-04 Stephanie Lewis <Stephanie Lewis>
Fix build.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCLoadURL):
- 7:42 PM Changeset in webkit [39014] by
-
- 3 edits in trunk/WebCore
Reviewed by Kevin Ollivier.
Add a MIME mapping for the .htm extension to wx and GTK ports.
https://bugs.webkit.org/show_bug.cgi?id=22668
- 7:29 PM Changeset in webkit [39013] by
-
- 2 edits in trunk/WebCore
Reviewed by Kevin Ollivier.
Implement basic text paste support in wx and add notImplemented stubs to catch other methods.
https://bugs.webkit.org/show_bug.cgi?id=22667
- 5:55 PM Changeset in webkit [39012] by
-
- 2 edits in trunk/WebCore
wx build fix for !USE(WXGC) build config.
- 5:39 PM Changeset in webkit [39011] by
-
- 2 edits in trunk/WebCore
Reviewed by Kevin Ollivier.
Turn off styled controls until we can implement them properly.
https://bugs.webkit.org/show_bug.cgi?id=22662
- 4:40 PM Changeset in webkit [39010] by
-
- 3 edits in trunk/JavaScriptCore
2008-12-04 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Some refactoring for generateGreedyQuantifier.
SunSpider reports no change (possibly a 0.3% speedup).
- wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateGreedyQuantifier): Clarified label meanings and unified some logic to simplify things.
- wrec/WRECParser.h: (JSC::WREC::Parser::parseAlternative): Added a version of parseAlternative that can jump to a Label, instead of a JumpList, upon failure. (Eventually, when we have a true Label class, this will be redundant.) This makes things easier for generateGreedyQuantifier, because it can avoid explicitly linking things.
- 4:10 PM Changeset in webkit [39009] by
-
- 6 edits2 adds in trunk/WebKit
..:
2008-12-04 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Add HostedNetscapePluginStream.
- WebKit.xcodeproj/project.pbxproj:
../mac:
2008-12-04 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
More work on streams.
- Plugins/Hosted/HostedNetscapePluginStream.h: Added. (WebKit::HostedNetscapePluginStream::create):
- Plugins/Hosted/HostedNetscapePluginStream.mm: Added. (WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream): (WebKit::HostedNetscapePluginStream::startStreamWithResponse): (WebKit::HostedNetscapePluginStream::startStream): (WebKit::HostedNetscapePluginStream::didReceiveData): (WebKit::HostedNetscapePluginStream::didFinishLoading): (WebKit::HostedNetscapePluginStream::didReceiveResponse):
- Plugins/Hosted/NetscapePluginInstanceProxy.h: (WebKit::NetscapePluginInstanceProxy::pluginView): (WebKit::NetscapePluginInstanceProxy::hostProxy):
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::PluginRequest::PluginRequest): (WebKit::NetscapePluginInstanceProxy::PluginRequest::requestID): (WebKit::NetscapePluginInstanceProxy::PluginRequest::request): (WebKit::NetscapePluginInstanceProxy::PluginRequest::frameName): (WebKit::NetscapePluginInstanceProxy::PluginRequest::didStartFromUserGesture): (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): (WebKit::NetscapePluginInstanceProxy::performRequest): (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript): (WebKit::NetscapePluginInstanceProxy::requestTimerFired): (WebKit::NetscapePluginInstanceProxy::loadRequest):
- Plugins/Hosted/WebKitPluginHost.defs:
- 4:03 PM Changeset in webkit [39008] by
-
- 2 edits in trunk/WebCore
Reviewed by Kevin Ollivier.
wx implementations for Path API.
- 2:39 PM Changeset in webkit [39007] by
-
- 41 edits in trunk/WebCore
2008-12-04 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric Seidel.
Bug 22564: Make HTML elements' constructors take a QualifiedName
https://bugs.webkit.org/show_bug.cgi?id=22564
Updated the remaining constructors.
- bindings/js/JSImageConstructor.cpp: (WebCore::constructImage):
- dom/Document.cpp: (WebCore::Document::getCSSCanvasElement):
- editing/DeleteButton.cpp: (WebCore::DeleteButton::DeleteButton):
- html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::HTMLAppletElement):
- html/HTMLAppletElement.h:
- html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::HTMLAreaElement):
- html/HTMLAreaElement.h:
- html/HTMLBaseFontElement.cpp: (WebCore::HTMLBaseFontElement::HTMLBaseFontElement):
- html/HTMLBaseFontElement.h:
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::HTMLCanvasElement):
- html/HTMLCanvasElement.h:
- html/HTMLElementFactory.cpp: (WebCore::hrConstructor): (WebCore::paragraphConstructor): (WebCore::basefontConstructor): (WebCore::fontConstructor): (WebCore::anchorConstructor): (WebCore::imageConstructor): (WebCore::mapConstructor): (WebCore::areaConstructor): (WebCore::canvasConstructor): (WebCore::appletConstructor): (WebCore::embedConstructor): (WebCore::objectConstructor): (WebCore::paramConstructor): (WebCore::scriptConstructor): (WebCore::tableConstructor): (WebCore::tableCaptionConstructor): (WebCore::tableRowConstructor):
- html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::HTMLEmbedElement):
- html/HTMLEmbedElement.h:
- html/HTMLFontElement.cpp: (WebCore::HTMLFontElement::HTMLFontElement):
- html/HTMLFontElement.h:
- html/HTMLHRElement.cpp: (WebCore::HTMLHRElement::HTMLHRElement):
- html/HTMLHRElement.h:
- html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::HTMLImageElement):
- html/HTMLImageElement.h:
- html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::HTMLMapElement):
- html/HTMLMapElement.h:
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::HTMLObjectElement):
- html/HTMLObjectElement.h:
- html/HTMLParagraphElement.cpp: (WebCore::HTMLParagraphElement::HTMLParagraphElement):
- html/HTMLParagraphElement.h:
- html/HTMLParamElement.cpp: (WebCore::HTMLParamElement::HTMLParamElement):
- html/HTMLParamElement.h:
- html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): (WebCore::HTMLParser::mapCreateErrorCheck): (WebCore::HTMLParser::handleIsindex):
- html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::HTMLScriptElement):
- html/HTMLScriptElement.h:
- html/HTMLTableCaptionElement.cpp: (WebCore::HTMLTableCaptionElement::HTMLTableCaptionElement):
- html/HTMLTableCaptionElement.h:
- html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::HTMLTableElement): (WebCore::HTMLTableElement::createCaption): (WebCore::HTMLTableElement::insertRow):
- html/HTMLTableElement.h:
- html/HTMLTableRowElement.cpp: (WebCore::HTMLTableRowElement::HTMLTableRowElement):
- html/HTMLTableRowElement.h:
- html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::insertRow):
- html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createContainingTable): (WebCore::HTMLViewSourceDocument::addLine):
- loader/ImageDocument.cpp: (WebCore::ImageDocumentElement::ImageDocumentElement):
- 2:02 PM Changeset in webkit [39006] by
-
- 2 edits in trunk/WebKit/win
Implement IPropertyBag2::Read.
Fill in dwType for IPropertyBag2::GetPropertyInfo (we always use PROPBAG2_TYPE_DATA).
https://bugs.webkit.org/show_bug.cgi?id=22659
This fixes <rdar://problem/6419127> REGRESSION: Forms autocomplete is broken for "other forms"
Reviewed by Ada Chan, Alice Liu.
- COMPropertyBag.h: (::Read): Implemented. (::GetPropertyInfo): Set dwType to PROPBAG2_TYPE_DATA.
- 1:08 PM Changeset in webkit [39005] by
-
- 1 edit1 add in trunk/WebCore
No review, build fix only.
Add file missing from last commit.
- bindings/js/ScriptState.h: Added.
- 1:01 PM Changeset in webkit [39004] by
-
- 3 edits in trunk/JavaScriptCore
2008-12-04 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Holger Freyther.
Fix crashes in the Qt build on Linux/i386 with non-executable memory
by enabling TCSystemAlloc and the PROT_EXEC flag for mmap.
- 12:51 PM Changeset in webkit [39003] by
-
- 16 edits in trunk/WebCore
Reviewed by Geoff Garen.
Implement ScriptState abstraction (initially, a simple typedef)
as means of carrying exception information across bindings boundaries
and in a script engine-independent way.
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMBinding.cpp: (WebCore::scriptStateFromNode):
- bindings/js/JSDOMBinding.h:
- bindings/js/JSNodeFilterCondition.h:
- bindings/js/ScriptState.h: Added.
- dom/NodeFilter.cpp: (WebCore::NodeFilter::acceptNode):
- dom/NodeFilter.h: (WebCore::NodeFilter::acceptNode):
- dom/NodeFilterCondition.cpp: (WebCore::NodeFilterCondition::acceptNode):
- dom/NodeFilterCondition.h:
- dom/NodeIterator.cpp: (WebCore::NodeIterator::nextNode): (WebCore::NodeIterator::previousNode):
- dom/NodeIterator.h: (WebCore::NodeIterator::nextNode): (WebCore::NodeIterator::previousNode):
- dom/Traversal.cpp: (WebCore::Traversal::acceptNode):
- dom/Traversal.h:
- dom/TreeWalker.cpp: (WebCore::TreeWalker::parentNode): (WebCore::TreeWalker::firstChild): (WebCore::TreeWalker::lastChild): (WebCore::TreeWalker::previousSibling): (WebCore::TreeWalker::nextSibling): (WebCore::TreeWalker::previousNode): (WebCore::TreeWalker::nextNode):
- dom/TreeWalker.h: (WebCore::TreeWalker::parentNode): (WebCore::TreeWalker::firstChild): (WebCore::TreeWalker::lastChild): (WebCore::TreeWalker::previousSibling): (WebCore::TreeWalker::nextSibling): (WebCore::TreeWalker::previousNode): (WebCore::TreeWalker::nextNode):
- 12:44 PM Changeset in webkit [39002] by
-
- 2 edits in trunk/WebCore
2008-12-04 Pierre-Olivier Latour <pol@apple.com>
Reviewed by Dan Bernstein.
Fixed pauseTransitionAtTimeOnElementWithId() in DRT asserting when passed invalid property name
and potential similar issue with pauseAnimationAtTimeOnElementWithId().
- page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimationPrivate::pauseAnimationAtTime): (WebCore::CompositeAnimationPrivate::pauseTransitionAtTime):
- 12:42 PM Changeset in webkit [39001] by
-
- 6 edits in trunk/WebKit/mac
2008-12-04 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Start implementing WKPCLoadURL. Currently this has copied a lot of code from WebNetscapePluginView
but once we have a more complete implementation of NPStreams we can start refactoring things so that the
implementations can share more code.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCLoadURL):
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): (WebKit::NetscapePluginInstanceProxy::loadURL): (WebKit::NetscapePluginInstanceProxy::performRequest): (WebKit::NetscapePluginInstanceProxy::requestTimerFired): (WebKit::NetscapePluginInstanceProxy::loadRequest):
- Plugins/Hosted/WebKitPluginClient.defs:
- Plugins/Hosted/WebKitPluginHost.defs:
- 12:37 PM Changeset in webkit [39000] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
Remove unused Completion.h include.
- html/CanvasRenderingContext2D.cpp: Removed Completion.h include.
- 12:07 PM Changeset in webkit [38999] by
-
- 2 edits in trunk/WebCore
2008-11-13 David Hyatt <hyatt@apple.com>
Fix a bug in ScrollView's refactoring. An isVisible check should have been isSelfVisible.
Reviewed by Darin Adler
- platform/ScrollView.cpp: (WebCore::ScrollView::setParentVisible):
- 11:38 AM Changeset in webkit [38998] by
-
- 4 edits in trunk/WebKit/mac
2008-12-04 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Move requestWithURLCString to WebBaseNetscapePluginView.
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView requestWithURLCString:]):
- Plugins/WebNetscapePluginView.mm:
- 8:38 AM Changeset in webkit [38997] by
-
- 1 edit in trunk/JavaScriptCore/JavaScriptCore.pri
Fix the Qt build
- 8:21 AM Changeset in webkit [38996] by
-
- 2 edits in trunk/JavaScriptCore
2008-12-04 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Tor Arne Vestbø.
Enable ENABLE_JIT_OPTIMIZE_CALL, ENABLE_JIT_OPTIMIZE_PROPERTY_ACCESS
and ENABLE_JIT_OPTIMIZE_ARITHMETIC, as suggested by Niko.
- 6:41 AM Changeset in webkit [38995] by
-
- 2 edits in trunk/WebCore
2008-12-04 Friedemann Kleint <friedemann.kleint@nokia.com>
Reviewed by Tor Arne Vestbø.
Fix small translation glitch in the Qt file chooser.
- 6:32 AM Changeset in webkit [38994] by
-
- 2 edits in trunk/JavaScriptCore
2008-12-04 Kent Hansen <khansen@trolltech.com>
Reviewed by Simon Hausmann.
Enable the JSC JIT for the Qt build by default for release builds on
linux-g++ and win32-msvc.
- 5:01 AM Changeset in webkit [38993] by
-
- 2 edits in trunk/WebCore
2008-12-04 Tor Arne Vestbø <tavestbo@trolltech.com>
Rubber-stamped by Simon Hausmann.
Blacklist Silverlight plugin on Qt/Mac until supported
Currently the plugin crashes with a corrupted stack trace, possibly
related to https://bugs.webkit.org/show_bug.cgi?id=20635
- 3:10 AM Changeset in webkit [38992] by
-
- 7 edits2 copies in trunk/JavaScriptCore
2008-12-04 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Allow JIT to function without property access repatching and arithmetic optimizations.
Controlled by ENABLE_JIT_OPTIMIZE_PROPERTY_ACCESS and ENABLE_JIT_OPTIMIZE_ARITHMETIC switches.
- JavaScriptCore.xcodeproj/project.pbxproj:
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
- jit/JITArithmetic.cpp: Copied from jit/JIT.cpp. (JSC::JIT::compileBinaryArithOp): (JSC::JIT::compileBinaryArithOpSlowCase):
- jit/JITPropertyAccess.cpp: Copied from jit/JIT.cpp. (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::compilePutByIdHotPath): (JSC::JIT::compilePutByIdSlowCase): (JSC::resizePropertyStorage): (JSC::transitionWillNeedStorageRealloc): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength):
- wtf/Platform.h:
- 2:26 AM Changeset in webkit [38991] by
-
- 1 edit in trunk/WebCore/bridge/qt/qt_runtime.cpp
Qt build fix after r38975
- 12:41 AM Changeset in webkit [38990] by
-
- 2 edits in trunk/WebCore
2008-12-03 Dmitry Titov <dimich@chromium.org>
Reviewed by Alexey Proskuryakov.
Fix non-Mac build.
- page/Chrome.cpp: (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
Dec 3, 2008:
- 11:43 PM Changeset in webkit [38989] by
-
- 9 edits in trunk
2008-12-03 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Optimized sequences of characters in regular expressions by comparing
two characters at a time.
1-2% speedup on SunSpider, 19-25% speedup on regexp-dna.
- assembler/MacroAssembler.h: (JSC::MacroAssembler::load32): (JSC::MacroAssembler::jge32): Filled out a few more macro methods.
- assembler/X86Assembler.h: (JSC::X86Assembler::movl_mr): Added a verion of movl_mr that operates without an offset, to allow the macro assembler to optmize for that case.
- wrec/WREC.cpp: (JSC::WREC::Generator::compileRegExp): Test the saved value of index instead of the index register when checking for "end of input." The index register doesn't increment by 1 in an orderly fashion, so testing it for == "end of input" is not valid.
Also, jump all the way to "return failure" upon reaching "end of input,"
instead of executing the next alternative. This is more logical, and
it's a slight optimization in the case of an expression with many alternatives.
- wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateIncrementIndex): Added support for jumping to a failure label in the case where the index has reached "end of input."
(JSC::WREC::Generator::generatePatternCharacterSequence):
(JSC::WREC::Generator::generatePatternCharacterPair): This is the
optmization. It's basically like generatePatternCharacter, but it runs two
characters at a time.
(JSC::WREC::Generator::generatePatternCharacter): Changed to use isASCII,
since it's clearer than comparing to a magic hex value.
- wrec/WRECGenerator.h:
LayoutTests:
2008-12-03 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Added a test for another input length miscalculation.
- fast/regex/alternative-length-miscalculation-expected.txt:
- fast/regex/resources/alternative-length-miscalculation.js:
- 11:27 PM Changeset in webkit [38988] by
-
- 1 edit3 moves14 adds in trunk/LayoutTests
Reviewed by Darin Adler.
Add missing test files (utf-16,32 files) and two php files
for bug 21635 and enabled utf-7 tests (bug 22492). The patch
for bug 21635 was landed in http://trac.webkit.org/changeset/38755,
but binary test files (utf-16/32) were omitted in the changeset.
https://bugs.webkit.org/show_bug.cgi?id=21635
https://bugs.webkit.org/show_bug.cgi?id=22492
- http/tests/misc/resources/check-query-param.php: Added.
- http/tests/misc/resources/echo-query-param.php: Added.
- http/tests/misc/submit-get-in-utf16be.html: Added.
- http/tests/misc/submit-get-in-utf16le.html: Added.
- http/tests/misc/submit-get-in-utf32be.html: Added.
- http/tests/misc/submit-get-in-utf32le.html: Added.
- http/tests/misc/submit-get-in-utf7.html: Copied from http/tests/misc/submit-get-in-utf7.html-disabled.
- http/tests/misc/submit-get-in-utf7.html-disabled: Removed.
- http/tests/misc/submit-post-in-utf16be.html: Added.
- http/tests/misc/submit-post-in-utf16le.html: Added.
- http/tests/misc/submit-post-in-utf32be.html: Added.
- http/tests/misc/submit-post-in-utf32le.html: Added.
- http/tests/misc/submit-post-in-utf7.html: Copied from http/tests/misc/submit-post-in-utf7.html-disabled.
- http/tests/misc/submit-post-in-utf7.html-disabled: Removed.
- http/tests/misc/url-in-utf16be.html: Added.
- http/tests/misc/url-in-utf16le.html: Added.
- http/tests/misc/url-in-utf32be.html: Added.
- http/tests/misc/url-in-utf32le.html: Added.
- http/tests/misc/url-in-utf7.html: Copied from http/tests/misc/url-in-utf7.html-disabled.
- http/tests/misc/url-in-utf7.html-disabled: Removed.
- 11:21 PM Changeset in webkit [38987] by
-
- 2 edits in trunk/WebCore
2008-12-03 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
Remove uses of document() in XMLHttpRequest where simple.
https://bugs.webkit.org/show_bug.cgi?id=22619
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::responseXML): Return NULL in the worker case which is according to spec (and avoids using document()).
(WebCore::XMLHttpRequest::callReadyStateChangeListener):
(WebCore::XMLHttpRequest::initSend):
Use scriptExecutionContext() instead of document().
- 11:20 PM Changeset in webkit [38986] by
-
- 7 edits in trunk/WebCore
Reviewed by Alexey Proskuryakov.
Make ScriptExecutionContextTaskWorkerTask::performTask a pure virtual function.
https://bugs.webkit.org/show_bug.cgi?id=22642
- dom/Document.cpp: (WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer): (WebCore::ScriptExecutionContextTaskTimer::fired): (WebCore::PerformTaskContext::PerformTaskContext): (WebCore::performTask): (WebCore::Document::postTask):
- dom/Document.h:
- dom/ScriptExecutionContext.cpp:
- dom/ScriptExecutionContext.h:
- dom/WorkerContext.cpp: (WebCore::ScriptExecutionContextTaskWorkerTask::create): (WebCore::ScriptExecutionContextTaskWorkerTask::ScriptExecutionContextTaskWorkerTask): (WebCore::ScriptExecutionContextTaskWorkerTask::performTask): (WebCore::WorkerContext::postTask):
- dom/WorkerContext.h:
- 11:19 PM Changeset in webkit [38985] by
-
- 18 edits in trunk/WebCore
2008-12-03 Dmitry Titov <dimich@chromium.org>
Reviewed by Alexey Proskuryakov.
Using ActiveDOMObject as base class for DOMTimer.
https://bugs.webkit.org/show_bug.cgi?id=22620
Using ActiveDOMObject simplifies the code because ActiveDOMObject
is wired for stop/pause/resume on loading/unloading/caching the page etc
so the timer-specific code that does the same can be removed.
In addition, timers can be now paused/resumed 'in place' which
makes it unnecessary to 'serialize' them into special PausedTimeouts
instance, so pause/resumeTimeouts implementation in JSDOMWindowBase can also be removed.
Also, moving TimeoutMap from JSDOMWindowBase to Document matches lifetime
of timeouts and makes it possible to not roundtrip them via PausedTimeouts
every time when JSDOMWindow wrapper is destroyed while the page is in the b/f cache.
Timeouts are now paused with other ActiveDOMObjects:
- before creating CachedPage in FrameLoader::commitProvisionalLoad()
- in JavaScriptDebugServer::setJavaScriptPaused
- during modal UI operations in Chrome::* this is equivalent to previous usage of JSDOMWindowBase::pauseTimeouts()
Timeouts are stopped to prevent future firing from:
- FrameLoader::clear()
- FrameLoader::frameDetached() this is equivalent to previous usage of JSDOMWindowBase::clearAllTimeouts()
This is also one of the steps to having timers in Workers. See the plan of
the next steps in the bug above.
- bindings/js/DOMTimer.cpp: (WebCore::DOMTimer::DOMTimer): (WebCore::DOMTimer::fired): (WebCore::DOMTimer::hasPendingActivity): (WebCore::DOMTimer::contextDestroyed): (WebCore::DOMTimer::stop): (WebCore::DOMTimer::suspend): (WebCore::DOMTimer::resume): (WebCore::DOMTimer::canSuspend): Implemented ActiveDOMObject methods.
- bindings/js/DOMTimer.h:
- bindings/js/JSDOMBinding.cpp: ActiveDOMObject can have no JS wrapper (WebCore::markActiveObjectsForContext):
- bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::~JSDOMWindowBase): (WebCore::JSDOMWindowBase::clear): (WebCore::JSDOMWindowBase::installTimeout): (WebCore::JSDOMWindowBase::removeTimeout): (WebCore::JSDOMWindowBase::timerFired): (WebCore::JSDOMWindowBase::disconnectFrame):
- bindings/js/JSDOMWindowBase.h:
- bindings/js/ScriptController.cpp:
- bindings/js/ScriptController.h:
- dom/Document.cpp: Document now holds a hash map id->timeout (WebCore::Document::addTimeout): (WebCore::Document::removeTimeout): (WebCore::Document::findTimeout):
- dom/Document.h:
- history/CachedPage.cpp: (WebCore::CachedPage::CachedPage): (WebCore::CachedPage::restore): (WebCore::CachedPage::clear):
- history/CachedPage.h:
- inspector/JavaScriptDebugServer.cpp: (WebCore::JavaScriptDebugServer::~JavaScriptDebugServer): (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
- inspector/JavaScriptDebugServer.h:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad): removed clearAllTimeouts since all ActiveDOMObjects will be stopped in FrameLoader::clear(); I don't see how the old comment can be correct - the code in the same method proceeds to invoke 'onunload' and then calls into client which can be external code and can cause any active object created in onunload to fire. We can stop them all before firing onunload but it does not make a lot of sense. I have a test to go with the next patch which verifies that timers set in onunload do not fire.
(WebCore::FrameLoader::open):
- page/Chrome.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
- 9:43 PM Changeset in webkit [38984] by
-
- 7 edits2 copies in trunk/JavaScriptCore
2008-12-03 Gavin Barraclough <barraclough@apple.com>
Reviewed by Camron Zwarich.
Allow JIT to operate without the call-repatching optimization.
Controlled by ENABLE(JIT_OPTIMIZE_CALL), defaults on, disabling
this leads to significant performance regression.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- jit/JIT.cpp: (JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
- jit/JITCall.cpp: Copied from jit/JIT.cpp. (JSC::JIT::compileOpCallInitializeCallFrame): (JSC::JIT::compileOpCallSetupArgs): (JSC::JIT::compileOpCallEvalSetupArgs): (JSC::JIT::compileOpConstructSetupArgs): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase): (JSC::unreachable):
- jit/JITInlineMethods.h: Copied from jit/JIT.cpp. (JSC::JIT::checkStructure): (JSC::JIT::emitFastArithPotentiallyReTagImmediate): (JSC::JIT::emitTagAsBoolImmediate):
- wtf/Platform.h:
- 7:39 PM Changeset in webkit [38983] by
-
- 3 edits2 adds in trunk
WebCore:
2008-12-03 Justin Garcia <justin.garcia@apple.com>
Reviewed by Beth Dakin.
<rdar://problem/6018653> Extra blank line when pasting paragraph in plain text
In SnowLeopard, Mail occasionally adds an empty, unstyled paragraph at the
end of pasted content so that users don't get stuck with non-standard pargraph
spacing. This content threw off our handling of interchange newlines. Any interchange
newline, regardless of it's position in the incoming fragment was considered to be
"at the start" of the fragment, and would result in us inserting in a newline before
inserted content. This patch makes the checks for interchange newlines more strict,
and treats interchange newlines found elsewhere as normal <br>s.
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): (WebCore::ReplacementFragment::removeInterchangeNodes):
- editing/VisiblePosition.cpp: (WebCore::VisiblePosition::init): (WebCore::VisiblePosition::canonicalPosition):
- editing/VisiblePosition.h:
LayoutTests:
2008-12-03 Justin Garcia <justin.garcia@apple.com>
Reviewed by Beth Dakin.
<rdar://problem/6018653> Extra blank line when pasting paragraph in plain text
- editing/pasteboard/6018653-expected.txt: Added.
- editing/pasteboard/6018653.html: Added.
- 6:11 PM Changeset in webkit [38982] by
-
- 2 edits in trunk/WebKit
2008-12-03 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Move WebPluginRequest to its own file.
- WebKit.xcodeproj/project.pbxproj:
- 6:10 PM Changeset in webkit [38981] by
-
- 2 edits2 adds in trunk/WebKit/mac
2008-12-03 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Move WebPluginRequest to its own file.
- Plugins/WebNetscapePluginView.mm:
- Plugins/WebPluginRequest.h: Added.
- Plugins/WebPluginRequest.m: Added. (-[WebPluginRequest initWithRequest:frameName:notifyData:sendNotification:didStartFromUserGesture:]): (-[WebPluginRequest dealloc]): (-[WebPluginRequest request]): (-[WebPluginRequest frameName]): (-[WebPluginRequest isCurrentEventUserGesture]): (-[WebPluginRequest sendNotification]): (-[WebPluginRequest notifyData]):
- 5:47 PM Changeset in webkit [38980] by
-
- 4 edits4 adds in trunk
Rubber-stamped by David Hyatt.
Bring the WebCore chromium build a couple steps closer to building.
- WebCore.scons:
- 5:03 PM Changeset in webkit [38979] by
-
- 2 edits in trunk/WebKit/mac
2008-12-03 Anders Carlsson <andersca@apple.com>
Handle the CA model.
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView setWindowIfNecessary]):
- 4:57 PM Changeset in webkit [38978] by
-
- 2 edits in trunk/WebCore
wx build fix.
- 4:37 PM Changeset in webkit [38977] by
-
- 6 edits in trunk/LayoutTests
Reviewed by George Staikos.
Forgot to rerun make-js-test-wrappers, and update some fast/wml results.
- 4:26 PM Changeset in webkit [38976] by
-
- 2 edits in trunk/JavaScriptCore
2008-12-03 Sam Weinig <sam@webkit.org>
Fix build.
- assembler/X86Assembler.h: (JSC::X86Assembler::orl_i32r):
- 4:10 PM Changeset in webkit [38975] by
-
- 16 edits in trunk/JavaScriptCore
2008-12-03 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Remove shared AssemblerBuffer 1MB buffer and instead give AssemblerBuffer
an 256 byte inline capacity.
1% progression on Sunspider.
- assembler/AssemblerBuffer.h: (JSC::AssemblerBuffer::AssemblerBuffer): (JSC::AssemblerBuffer::~AssemblerBuffer): (JSC::AssemblerBuffer::grow):
- assembler/MacroAssembler.h: (JSC::MacroAssembler::MacroAssembler):
- assembler/X86Assembler.h: (JSC::X86Assembler::X86Assembler):
- interpreter/Interpreter.cpp: (JSC::Interpreter::Interpreter):
- interpreter/Interpreter.h:
- jit/JIT.cpp: (JSC::JIT::JIT):
- parser/Nodes.cpp: (JSC::RegExpNode::emitBytecode):
- runtime/RegExp.cpp: (JSC::RegExp::RegExp): (JSC::RegExp::create):
- runtime/RegExp.h:
- runtime/RegExpConstructor.cpp: (JSC::constructRegExp):
- runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncCompile):
- runtime/StringPrototype.cpp: (JSC::stringProtoFuncMatch): (JSC::stringProtoFuncSearch):
- wrec/WREC.cpp: (JSC::WREC::Generator::compileRegExp):
- wrec/WRECGenerator.h: (JSC::WREC::Generator::Generator):
- wrec/WRECParser.h: (JSC::WREC::Parser::Parser):
- 3:48 PM Changeset in webkit [38974] by
-
- 4 edits10 adds in trunk
Reviewed by George Staikos.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=22636
Implement WML variable substitution & validation.
Created a framework for scriptable WML layout tests, that are able to test variable substiution & validation.
Tests: wml/variable-reference-invalid-character.html
wml/variable-reference-valid.html
- 3:26 PM Changeset in webkit [38973] by
-
- 3 edits in trunk/WebKitTools
Build fix for --gtk and --chromium, no review.
Fix run-javascriptcore-tests to pass --gtk, --qt, --chromium, etc.
through to build-jsc.
- Scripts/build-jsc:
- Scripts/webkitdirs.pm:
- 3:20 PM Changeset in webkit [38972] by
-
- 10 edits in trunk
Reviewed by Cameron Zwarich.
Further preparations for WML layout tests.
- Enable variable substitution in Text.cpp - if the parent is a WMLElement derived class.
- Dump WMLMessageSource messages to the console, just like it's done for JSMessageSource
- Add helper method in Document.idl, to reset the WML page state to a well-known default state. (will be used in the upcoming LayoutTests/wml testcases)
- 2:54 PM Changeset in webkit [38971] by
-
- 4 edits in trunk/JavaScriptCore
2008-12-03 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt, with help from Gavin Barraclough.
orl_i32r was actually coded as an 8bit OR. So, I renamed orl_i32r to
orl_i8r, changed all orl_i32r clients to use orl_i8r, and then added
a new orl_i32r that actually does a 32bit OR.
(32bit OR is currently unused, but a patch I'm working on uses it.)
- assembler/MacroAssembler.h: (JSC::MacroAssembler::or32): Updated to choose between 8bit and 32bit OR.
- assembler/X86Assembler.h: (JSC::X86Assembler::orl_i8r): The old orl_i32r. (JSC::X86Assembler::orl_i32r): The new orl_i32r.
- jit/JIT.cpp: (JSC::JIT::emitFastArithPotentiallyReTagImmediate): (JSC::JIT::emitTagAsBoolImmediate): Use orl_i8r, since we're ORing 8bit values.
- 2:38 PM Changeset in webkit [38970] by
-
- 3 edits in trunk/WebCore
2008-12-03 Antti Koivisto <Antti Koivisto>
Reviewed by Sam Weinig.
Don't leak selectors in case selector list parsing failed.
- css/CSSGrammar.y:
- css/CSSParser.cpp: (WebCore::CSSParser::~CSSParser):
- 2:34 PM Changeset in webkit [38969] by
-
- 1 edit4 adds4 deletes in trunk/LayoutTests
2008-12-03 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Clean up and unify transition and animation test cases that destroy
the renderer in the 'ended' event callback, either through setting display:none,
or removing the element.
- animations/animation-end-event-destroy-renderer-expected.txt: Added.
- animations/animation-end-event-destroy-renderer.html: Added.
- animations/transform-animation-event-destroy-element-expected.txt: Removed.
- animations/transform-animation-event-destroy-element.html: Removed.
- transitions/transform-transition-event-destroy-element-expected.txt: Removed.
- transitions/transform-transition-event-destroy-element.html: Removed.
- transitions/transition-end-event-destroy-renderer-expected.txt: Added.
- transitions/transition-end-event-destroy-renderer.html: Added.
- 2:20 PM Changeset in webkit [38968] by
-
- 2 edits in trunk/WebCore
2008-12-03 Chris Marrin <cmarrin@apple.com>
Reviewed by Dave Hyatt.
This is a regression (causes a crash of LayoutTests/animations/transform-animation-event-destroy-element.html).
This patch fixes the testcase.
This is another case of animations getting destroyed in the end animation callback and causing dangling
pointers on return. This one involves iterating over the CompositeAnimation, which has been destroyed.
So I now check for a null m_object pointer (which is nullified when the CompositeAnimation is destroyed)
and skip that call.
- page/animation/AnimationBase.cpp: (WebCore::AnimationBase::updateStateMachine):
- 2:15 PM Changeset in webkit [38967] by
-
- 1 edit in trunk/WebKit/mac/ChangeLog
Add radar number
- 2:13 PM Changeset in webkit [38966] by
-
- 2 edits in trunk/WebKit/mac
2008-12-03 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
Call NPP_SetWindow for CA plug-ins.
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebNetscapePluginView restorePortState:]): (-[WebNetscapePluginView isNewWindowEqualToOldWindow]): (-[WebNetscapePluginView updateAndSetWindow]): (-[WebNetscapePluginView setWindowIfNecessary]):
- 2:01 PM Changeset in webkit [38965] by
-
- 2 edits in trunk/WebKitTools
Build fix only, no review.
Remove support for build-webkit --svg-experimental.
All of the "experimental" svg features have their own toggles anyway.
I broke --svg-experimental in my last commit (which then broke clean builds)
I can't find any use of --svg-experimental in our source tree, so removing it.
- Scripts/build-webkit:
- 1:52 PM Changeset in webkit [38964] by
-
- 16 edits2 adds in trunk/WebCore
2008-12-03 Antti Koivisto <Antti Koivisto>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22379
Make CSSOM use less memory
Reduce size of the CSSSelector by one more pointer by using an array
instead of a linked list to store them.
- WebCore.xcodeproj/project.pbxproj:
- css/CSSGrammar.y:
- css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::parseSelector): (WebCore::CSSParser::createStyleRule):
- css/CSSParser.h: (WebCore::CSSParser::reusableSelectorVector):
- css/CSSSelector.h: (WebCore::CSSSelector::CSSSelector): (WebCore::CSSSelector::~CSSSelector): (WebCore::CSSSelector::isLastInSelectorList): (WebCore::CSSSelector::setLastInSelectorList):
- css/CSSStyleRule.cpp: (WebCore::CSSStyleRule::CSSStyleRule): (WebCore::CSSStyleRule::~CSSStyleRule): (WebCore::CSSStyleRule::selectorText):
- css/CSSStyleRule.h: (WebCore::CSSStyleRule::adoptSelectorVector): (WebCore::CSSStyleRule::selectorList):
- css/CSSStyleSelector.cpp: (WebCore::CSSRuleSet::addRulesFromSheet):
- dom/Node.cpp: (WebCore::forEachSelector): (WebCore::selectorNeedsNamespaceResolution): (WebCore::Node::querySelector): (WebCore::Node::querySelectorAll):
- dom/SelectorNodeList.cpp: (WebCore::createSelectorNodeList):
- dom/SelectorNodeList.h:
- 1:52 PM Changeset in webkit [38963] by
-
- 3 edits in trunk/WebKitSite/specs/CSSVisualEffects
2008-12-03 Dean Jackson <dino@apple.com>
CSSTransforms.html +
CSSTransforms3D.html:
- Use SYNTAX_ERR for exceptions that are parsing errors in CSSMatrix
- 1:44 PM Changeset in webkit [38962] by
-
- 4 edits3 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22630
Assertion failure in XMLHttpRequest::contextDestroyed
Test: http/tests/xmlhttprequest/close-window.html
- loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): (WebCore::FrameLoader::commitProvisionalLoad): Move stopping active objects to clear(), so that closing a window is also covered.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::abort): Protect the object in abort(), because internalAbort() deref()'s.
- 1:36 PM Changeset in webkit [38961] by
-
- 2 edits in trunk/WebKitSite
2008-12-03 Dean Jackson <dino@apple.com>
Added links to the WebKit and Mozilla bugs for pointer-events.
- specs/PointerEventsProperty.html:
- 1:34 PM Changeset in webkit [38960] by
-
- 5 edits in trunk/WebKitTools
Reviewed by David Hyatt (and Mark Rowe).
Move --coverage support from build-webkit to webkitdirs.pm to share it with build-jsc
Move --coverage support out of run-javascriptcore-tests and into build-jsc
Finally add a buildXCodeProject function to webkitdirs.pm and move --clean support
there from build-webkit (to allow future sharing with other build-* scripts)
Change run-javascriptcore-tests to expect a --jsDriver-args= argument instead of
picking through ARGV with a blacklist of what arguments weren't jsDriver args
this makes run-javascriptcore-tests transparently support all arguments which
webkitdirs.pm gives it support for.
Make run-javascriptcore-tests actually print what commands it's running before running them.
Add --help support to build-jsc and run-javascriptcore-tests!
Make code to support --svg-experimental defaults take up half as many lines.
- Scripts/build-jsc:
- Scripts/build-webkit:
- Scripts/run-javascriptcore-tests:
- Scripts/webkitdirs.pm:
- 12:46 PM Changeset in webkit [38959] by
-
- 14 edits in trunk
2008-12-03 Dean Jackson <dino@apple.com>
Reviewed by Dan Bernstein.
Helper functions for turn -> degrees.
https://bugs.webkit.org/show_bug.cgi?id=22497
- wtf/MathExtras.h: (turn2deg): (deg2turn):
WebCore:
Implement CSS 3 <angle> turn unit and support it
in rotations.
https://bugs.webkit.org/show_bug.cgi?id=22497
- css/CSSGrammar.y:
- css/CSSParser.cpp: (WebCore::CSSParser::validUnit): (WebCore::unitFromString): (WebCore::CSSParser::lex):
- css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText): (WebCore::CSSPrimitiveValue::parserValue):
- css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::createTransformOperations):
- css/tokenizer.flex:
LayoutTests:
Tests for CSS 3 <angle> turn unit
https://bugs.webkit.org/show_bug.cgi?id=22497
- transforms/2d/transform-2d-expected.txt:
- transforms/2d/transform-2d.html:
- transforms/transform-value-types-expected.txt:
- transforms/transform-value-types.html:
- 12:32 PM Changeset in webkit [38958] by
-
- 2 edits in trunk/WebKit/mac
2008-12-03 Anders Carlsson <andersca@apple.com>
Fix the release build.
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::deadNameNotificationCallback):
- 12:00 PM Changeset in webkit [38957] by
-
- 6 edits in trunk/LayoutTests
2008-12-03 Dean Jackson <dino@apple.com>
Reviewed by Dan Bernstein.
Clean up some tests for private DRT API.
https://bugs.webkit.org/show_bug.cgi?id=22498
- platform/win/Skipped:
- transitions/transition-drt-api-delay-expected.txt:
- transitions/transition-drt-api-delay.html:
- transitions/transition-shorthand-delay-expected.txt:
- transitions/transition-shorthand-delay.html:
- 11:57 AM Changeset in webkit [38956] by
-
- 2 edits in trunk/WebKit
Update strings not to be localized.
Reviewed by Adam Roben.
- StringsNotToBeLocalized.txt:
- 11:51 AM Changeset in webkit [38955] by
-
- 2 edits in trunk/WebKitTools
Fix a leak in WinLauncher shutdown
Reviewed by Sam Weinig.
- WinLauncher/WinLauncher.cpp: (_tWinMain): Replaced a delete with a Release. We can't delete the WebView properly since we only have a pointer to one of its interfaces. We also shouldn't be deleting COM objects directly anyway, for a number of reasons.
- 11:51 AM Changeset in webkit [38954] by
-
- 2 edits in trunk/WebKitTools
Fix a crash on exit in WinLauncher
Reviewed by Sam Weinig.
- WinLauncher/WinLauncher.cpp: (_tWinMain): Call shutDownWebKit before exiting.
- 11:50 AM Changeset in webkit [38953] by
-
- 2 edits in trunk/WebKitTools
Add a Debug_Internal configuration to WinLauncher
This matches our other projects.
Reviewed by Sam Weinig.
- WinLauncher/WinLauncher.vcproj: Added a Debug_Internal configuration, which is identical to Debug except that it also references debug_internal.vsprops. Also removed some settings that we should be picking up from the .vsprops files.
- 10:59 AM Changeset in webkit [38952] by
-
- 19 edits5 deletes in trunk
2008-12-03 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
WebCore:
Make use of the gradient code in GraphicsContext and get rid of most of the
platform dependent code.
SVG should use the new Gradient support on GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=20543
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/FloatSize.h: (WebCore::FloatSize::shrunkTo):
- svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::buildGradient):
- svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
- svg/graphics/SVGPaintServer.h:
- svg/graphics/SVGPaintServerGradient.cpp: (WebCore::SVGPaintServerGradient::SVGPaintServerGradient): (WebCore::SVGPaintServerGradient::~SVGPaintServerGradient): (WebCore::SVGPaintServerGradient::gradient): (WebCore::SVGPaintServerGradient::setGradient): (WebCore::findTextRootObject): (WebCore::createMaskAndSwapContextForTextGradient): (WebCore::clipToTextMask): (WebCore::SVGPaintServerGradient::setup): (WebCore::SVGPaintServerGradient::renderPath): (WebCore::SVGPaintServerGradient::teardown):
- svg/graphics/SVGPaintServerGradient.h: (WebCore::SVGPaintServerGradient::setGradientStops): (WebCore::SVGPaintServerGradient::gradientStops):
- svg/graphics/SVGPaintServerLinearGradient.h:
- svg/graphics/SVGPaintServerRadialGradient.h:
- svg/graphics/cairo/SVGPaintServerGradientCairo.cpp: Removed.
- svg/graphics/cg/SVGPaintServerCg.cpp:
- svg/graphics/cg/SVGPaintServerGradientCg.cpp: Removed.
- svg/graphics/qt/SVGPaintServerGradientQt.cpp: Removed.
- svg/graphics/qt/SVGPaintServerLinearGradientQt.cpp: Removed.
- svg/graphics/qt/SVGPaintServerRadialGradientQt.cpp: Removed.
LayoutTests:
Updated/Correcte the SVG pixel tests.
We pass two more SVG tests now.
- platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.checksum:
- platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png:
- platform/mac/svg/batik/text/textEffect3-expected.checksum:
- platform/mac/svg/batik/text/textEffect3-expected.png:
- 10:55 AM Changeset in webkit [38951] by
-
- 2 edits in trunk/WebCore
2008-12-03 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Fix formatting.
- css/CSSSelector.h: (WebCore::CSSSelector::createRareData):
- 10:54 AM Changeset in webkit [38950] by
-
- 2 edits in trunk/WebKit/mac
2008-12-03 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6412234>
Don't crash if we can't launch the plug-in host.
- Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::instantiatePlugin):
- 9:36 AM Changeset in webkit [38949] by
-
- 3 edits in trunk/WebCore
Reviewed by Adam Roben.
As Adam Roben noticed, synchronize MessageSource enum with Console.js, and add a comment.
- 9:00 AM Changeset in webkit [38948] by
-
- 7 edits in trunk/WebCore
Reviewed by Alexey Proskuryakov.
Next steps to make LayoutTests work:
Never access the main frame from WMLRefreshElement/WMLCardElement, but
the current documents frame (WML layout tests will run in an <iframe>)
Prepare WMLErrorHandling for the case that no tokenizer is available anymore
-> report errors through Console::addMessage(), so they get logged in the
expected layout test results.
- 8:53 AM Changeset in webkit [38947] by
-
- 4 edits in trunk
2008-12-03 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon Hausmann.
Allow passing jsNull and jsUndefined to Qt plugins
Currently limited to functions with QString and QVariant arguments,
and properties of these types. Both jsNull and jsUndefined ends up
as default-constructed QStrings and QVariants, which means you can
check for isEmpty() and isValid() in the native plugin code.
Based on patches by Jade Han <jade.han@nokia.com>
- 8:36 AM Changeset in webkit [38946] by
-
- 2 edits in trunk/WebCore
2008-12-03 Trenton Schulz <trenton.schulz@nokia.com>
Reviewed by Simon Hausmann.
Fix the build with Qt for Mac OS X.
- 8:28 AM Changeset in webkit [38945] by
-
- 5 edits in trunk/WebCore
Reviewed by Alexey Proskuryakov.
Fix error handling in WMLSetvarElement. If an invalid variable reference is contained
in the 'name' attribute of <setvar>, a 'WMLErrorInvalidVariab
- 8:12 AM Changeset in webkit [38944] by
-
- 5 edits in trunk/WebCore
Reviewed by Alexey Proskuryakov.
Preparations to get WML layout tests going.
Make WMLPageState an OwnPtr to Page, and let Page create it on demand.
- 7:57 AM Changeset in webkit [38943] by
-
- 3 edits in trunk/WebCore
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=22627
fast/workers/worker-terminate.html fails randomly
The problem is that worker termination uses script timeouts, so an InterruptedExecutionError
is raised, and it sometimes reaches the main thread.
- dom/WorkerMessagingProxy.cpp: (WebCore::WorkerExceptionTask::create): (WebCore::WorkerExceptionTask::WorkerExceptionTask): (WebCore::WorkerExceptionTask::performTask): (WebCore::WorkerMessagingProxy::postWorkerException):
- dom/WorkerMessagingProxy.h: Ignore exceptions that happen in terminated workers.
- 7:52 AM Changeset in webkit [38942] by
-
- 4 edits in trunk/WebCore
Reviewed by Alexey Proskuryakov.
Remove some unncessary includes.
- 7:25 AM Changeset in webkit [38941] by
-
- 3 edits in trunk/WebCore
Rubber-stamped by Cameron Zwarich and Adam Roben.
Fix a typo: m_executionForbidded.
- bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::WorkerScriptController): (WebCore::WorkerScriptController::evaluate): (WebCore::WorkerScriptController::forbidExecution):
- bindings/js/WorkerScriptController.h:
- 7:01 AM Changeset in webkit [38940] by
-
- 2 edits in trunk/WebCore
2008-12-03 Dean McNamee <deanm@chromium.org>
Bug 22623: Uninitialized memory access in cache parsing code
<https://bugs.webkit.org/show_bug.cgi?id=22623>
Reviewed by David Kilzer.
Initialize m_haveParsedCacheControlHeader and m_haveParsedPragmaHeader.
- platform/network/ResourceResponseBase.h: (WebCore::ResourceResponseBase::ResourceResponseBase):
- 6:54 AM Changeset in webkit [38939] by
-
- 1 edit in trunk/WebCore/ChangeLog
Removed unchanged file from ChangeLog entry in r38918.
- 6:10 AM Changeset in webkit [38938] by
-
- 2 edits in trunk
2008-12-03 Simon Hausmann <Simon Hausmann>
Reviewed by Tor Arne Vestbø.
Fix the build of WebKit inside Qt by making sure that qmake generators
that do not produce generated sources (i.e. cpp files) are not
included in SOURCES.
- 2:50 AM Changeset in webkit [38937] by
-
- 1 edit in trunk/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp
2008-12-03 Tor Arne Vestbø <tavestbo@trolltech.com>
Rubber-stamped by Simon Hausmann.
Fix QWebFrame auto-test by giving it a little more time to load the image
- 1:56 AM Changeset in webkit [38936] by
-
- 2 edits in trunk/WebCore
2008-12-03 Antti Koivisto <Antti Koivisto>
Probable build fix.
- WebCoreSources.bkl:
- 1:51 AM Changeset in webkit [38935] by
-
- 3 edits in trunk/WebCore
2008-12-03 Antti Koivisto <Antti Koivisto>
Forgot to commit these.
- dom/Node.cpp: (WebCore::forEachTagSelector): (WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()): (WebCore::Node::querySelector):
- dom/SelectorNodeList.cpp: (WebCore::createSelectorNodeList):
- 1:42 AM Changeset in webkit [38934] by
-
- 12 edits2 deletes in trunk/WebCore
2008-12-03 Antti Koivisto <Antti Koivisto>
Reviewed by Dan Bernstein and Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=22379
Make CSSOM use less memory
Reduce size of the CSSSelector by 3/8 by moving rarely used fields to a rare data
struct. Browsing around with some instrumentation showed that ~0.1% of all selectors
encountered had rare data.
This also eliminates the CSSNthSelector subclass which will make possible to store
CSSSelectors in an array instead of a linked list for futher memory savings.
- css/CSSGrammar.y:
- css/CSSNthSelector.cpp: Removed.
- css/CSSNthSelector.h: Removed.
- css/CSSParser.cpp: (WebCore::CSSParser::createFloatingSelector):
- css/CSSParser.h:
- css/CSSSelector.cpp: (WebCore::CSSSelector::specificity): (WebCore::CSSSelector::operator==): (WebCore::CSSSelector::selectorText): (WebCore::CSSSelector::setTagHistory): (WebCore::CSSSelector::attribute): (WebCore::CSSSelector::setAttribute): (WebCore::CSSSelector::setArgument): (WebCore::CSSSelector::setSimpleSelector): (WebCore::CSSSelector::parseNth): (WebCore::CSSSelector::matchNth): (WebCore::CSSSelector::RareData::parseNth): (WebCore::CSSSelector::RareData::matchNth):
- css/CSSSelector.h: (WebCore::CSSSelector::CSSSelector): (WebCore::CSSSelector::~CSSSelector): (WebCore::CSSSelector::tagHistory): (WebCore::CSSSelector::hasAttribute): (WebCore::CSSSelector::argument): (WebCore::CSSSelector::simpleSelector): (WebCore::CSSSelector::RareData::RareData): (WebCore::CSSSelector::createRareData): (WebCore::CSSSelector::):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkSelector): (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
- 12:30 AM Changeset in webkit [38933] by
-
- 1 edit2 adds in trunk/LayoutTests
2008-12-03 Dmitry Titov <dimich@chromium.org>
Reviewed by Alexey Proskuryakov.
Add test for https://bugs.webkit.org/show_bug.cgi?id=22600,
verifying that timeout callback is executed in the right scope.
- fast/dom/Window/timeout-callback-scope-expected.txt: Added.
- fast/dom/Window/timeout-callback-scope.html: Added.
- 12:27 AM Changeset in webkit [38932] by
-
- 2 edits in trunk/WebCore
2008-12-03 Jian Li <jianli@chromium.org>
Reviewed by Alexey Proskuryakov.
Remove unneeded included file in WorkerThread.cpp.
https://bugs.webkit.org/show_bug.cgi?id=22613
- dom/WorkerThread.cpp: No need to include JSWorkerContext.h.
Dec 2, 2008:
- 11:42 PM Changeset in webkit [38931] by
-
- 12 edits3 adds in trunk
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=22543
Consolidate ActiveDOMObject page cache interaction
Test: http/tests/xmlhttprequest/abort-on-leaving-page.html
- dom/ActiveDOMObject.cpp: (WebCore::ActiveDOMObject::canSuspend): (WebCore::ActiveDOMObject::suspend): (WebCore::ActiveDOMObject::resume):
- dom/ActiveDOMObject.h:
- dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects): (WebCore::ScriptExecutionContext::suspendActiveDOMObjects): (WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
- dom/ScriptExecutionContext.h: Added methods for suspending and resuming active objects.
- dom/Worker.cpp: (WebCore::Worker::canSuspend): (WebCore::Worker::stop):
- dom/Worker.h: Workers cannot be suspended yet. This is a change in behavior, as workers used to keep running until their owner was destroyed.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): No longer call stopActiveDOMObjects() here, because their activity is not necessarily loading. (WebCore::FrameLoader::canCachePage): Can only cache if all active objects can be suspended. Previously, stopLoading() cancelled outstanding XMLHttpRequests, which made the page uncacheable due to no-null main document error. (WebCore::FrameLoader::commitProvisionalLoad): Suspend or stop active objects, depending on whether the document will be cached. (WebCore::FrameLoader::frameDetached): Stop active objects to let them clean up before their context is destroyed.
- xml/XMLHttpRequest.h: added canSuspend().
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::canSuspend): Only XHRs that are not loading can be suspended. (WebCore::XMLHttpRequest::stop): Call abort() instead of internalAbort() to dispatch events for Firefox compatibility. This is a change in behavior that helps test that requests do get aborted. (WebCore::XMLHttpRequest::contextDestroyed): The request must have been stopped by now, so assert that.
- 11:09 PM Disk Cache edited by
- add link to chrome (diff)
- 10:13 PM Changeset in webkit [38930] by
-
- 5 edits3 adds in trunk
2008-12-02 Cameron Zwarich <zwarich@apple.com>
Reviewed by Geoff Garen.
Bug 22504: Crashes during code generation occur due to refing of ignoredResult()
<https://bugs.webkit.org/show_bug.cgi?id=22504>
Since ignoredResult() was implemented by casting 1 to a RegisterID*, any
attempt to ref ignoredResult() results in a crash. This will occur in
code generation of a function body where a node emits another node with
the dst that was passed to it, and then refs the returned RegisterID*.
To fix this problem, make ignoredResult() a member function of
BytecodeGenerator that simply returns a pointe to a fixed RegisterID
member of BytecodeGenerator.
- bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::ignoredResult):
- bytecompiler/RegisterID.h:
- parser/Nodes.cpp: (JSC::NullNode::emitBytecode): (JSC::BooleanNode::emitBytecode): (JSC::NumberNode::emitBytecode): (JSC::StringNode::emitBytecode): (JSC::RegExpNode::emitBytecode): (JSC::ThisNode::emitBytecode): (JSC::ResolveNode::emitBytecode): (JSC::ObjectLiteralNode::emitBytecode): (JSC::PostfixResolveNode::emitBytecode): (JSC::PostfixBracketNode::emitBytecode): (JSC::PostfixDotNode::emitBytecode): (JSC::DeleteValueNode::emitBytecode): (JSC::VoidNode::emitBytecode): (JSC::TypeOfResolveNode::emitBytecode): (JSC::TypeOfValueNode::emitBytecode): (JSC::PrefixResolveNode::emitBytecode): (JSC::AssignResolveNode::emitBytecode): (JSC::CommaNode::emitBytecode): (JSC::ForNode::emitBytecode): (JSC::ForInNode::emitBytecode): (JSC::ReturnNode::emitBytecode): (JSC::ThrowNode::emitBytecode): (JSC::FunctionBodyNode::emitBytecode): (JSC::FuncDeclNode::emitBytecode):
LayoutTests:
- fast/js/ignored-result-ref-crash-expected.txt: Added.
- fast/js/ignored-result-ref-crash.html: Added.
- fast/js/resources/ignored-result-ref-crash.js: Added.
- 8:53 PM Changeset in webkit [38929] by
-
- 4 edits3 adds in trunk
2008-12-02 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Fixed https://bugs.webkit.org/show_bug.cgi?id=22537
REGRESSION (r38745): Assertion failure in jsSubstring() at ge.com
The bug was that index would become greater than length, so our
"end of input" checks, which all check "index == length", would fail.
The solution is to check for end of input before incrementing index,
to ensure that index is always <= length.
As a side benefit, generateJumpIfEndOfInput can now use je instead of
jg, which should be slightly faster.
- wrec/WREC.cpp: (JSC::WREC::Generator::compileRegExp):
- wrec/WRECGenerator.cpp: (JSC::WREC::Generator::generateJumpIfEndOfInput):
LayoutTests:
2008-12-02 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Test for https://bugs.webkit.org/show_bug.cgi?id=22537
REGRESSION (r38745): Assertion failure in jsSubstring() at ge.com
- fast/regex/alternative-length-miscalculation-expected.txt: Added.
- fast/regex/alternative-length-miscalculation.html: Added.
- 6:10 PM Changeset in webkit [38928] by
-
- 2 edits in trunk/JavaScriptCore
2008-12-02 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoffrey Garen.
Plant shift right immediate instructions, which are awesome.
https://bugs.webkit.org/show_bug.cgi?id=22610
~5% on the v8-crypto test.
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
- 5:03 PM Changeset in webkit [38927] by
-
- 17 edits2 adds in trunk
Bug 22606: Can <th> serves as the AXTitleUIElement for <td>?
<th> will serve as a title UI element when it is present in a table
that has not been exposed as an AXTable
- 4:41 PM Changeset in webkit [38926] by
-
- 6 edits in trunk/WebKit/mac
2008-12-02 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Start processing messages sent to the client port.
- Plugins/Hosted/NetscapePluginHostProxy.h:
- Plugins/Hosted/NetscapePluginHostProxy.mm: Add a map from ports to plug-in proxies. Turn the set of instances into a map from pluginID to instance proxy.
(WKPCStatusText):
Look up the right instance proxy and call status().
- Plugins/Hosted/NetscapePluginInstanceProxy.h: (WebKit::NetscapePluginInstanceProxy::pluginID):
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::status): Implement this.
- Plugins/Hosted/WebKitPluginClient.defs: Add the plug-in ID to StatusText.
- 4:17 PM Changeset in webkit [38925] by
-
- 2 edits in trunk/JavaScriptCore
2008-12-02 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Cleaned up SegmentedVector by abstracting segment access into helper
functions.
SunSpider reports no change.
- bytecompiler/SegmentedVector.h: (JSC::SegmentedVector::SegmentedVector): (JSC::SegmentedVector::~SegmentedVector): (JSC::SegmentedVector::size): (JSC::SegmentedVector::at): (JSC::SegmentedVector::operator[]): (JSC::SegmentedVector::last): (JSC::SegmentedVector::append): (JSC::SegmentedVector::removeLast): (JSC::SegmentedVector::grow): (JSC::SegmentedVector::clear): (JSC::SegmentedVector::deleteAllSegments): (JSC::SegmentedVector::segmentFor): (JSC::SegmentedVector::subscriptFor): (JSC::SegmentedVector::ensureSegmentsFor): (JSC::SegmentedVector::ensureSegment):
- 4:13 PM Changeset in webkit [38924] by
-
- 5 edits in trunk/WebKit/wx
Reviewed by Kevin Ollivier.
Add HitTest to wxWebView (and wxWebFrame).
https://bugs.webkit.org/show_bug.cgi?id=22459
- 3:54 PM BuildingCairoOnWindows edited by
- (diff)
- 3:53 PM BuildingOnWindows edited by
- (diff)
- 3:37 PM Changeset in webkit [38923] by
-
- 3 edits in trunk/WebKit/win
Export new-ish JSCore convenience constructor functions
Reviewed by Jon Honeycutt.
- WebKit.vcproj/WebKit.def:
- WebKit.vcproj/WebKit_debug.def: Export JSObjectMakeArray, JSObjectMakeDate, and JSObjectMakeRegExp. Remove duplicate export of JSObjectMakeFunction.
- 3:15 PM Changeset in webkit [38922] by
-
- 4 edits4 adds in trunk
2008-12-02 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Override absoluteClippedOverflowRect() in RenderReplaced to return a rect
that is large enough to encompass the selection, so that the repainting of
selected replaced elements works correctly.
Test: fast/repaint/selected-replaced.html
- rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::selectionRect): (WebCore::RenderReplaced::localSelectionRect): (WebCore::RenderReplaced::absoluteClippedOverflowRect):
- rendering/RenderReplaced.h:
- 2:58 PM Changeset in webkit [38921] by
-
- 5 edits in trunk
Bug 22513: ZOOM: text selection does not send correct zoom bounds
When zoomed, text selection must send the zoom bounds in flipped screen coordinates.
- 2:27 PM Changeset in webkit [38920] by
-
- 6 edits in trunk/WebKit/mac
2008-12-02 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Create a client mach port and pass it to the plug-in host.
- Plugins/Hosted/NetscapePluginHostManager.h:
- Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::hostForPackage): (WebKit::NetscapePluginHostManager::spawnPluginHost):
- Plugins/Hosted/NetscapePluginHostProxy.h:
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
- Plugins/Hosted/WebKitPluginHost.defs:
- 2:16 PM Changeset in webkit [38919] by
-
- 4 edits in trunk/WebCore
2008-12-02 Dean Jackson <dino@apple.com>
Reviewed by Sam Weinig.
Remove support for 'now' from CSS (was
erroneously added to transition and animation delay)
https://bugs.webkit.org/show_bug.cgi?id=22571
- css/CSSParser.cpp: (WebCore::CSSParser::parseAnimationDelay):
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::mapAnimationDelay):
- css/CSSValueKeywords.in:
- 2:03 PM Changeset in webkit [38918] by
-
- 3 edits in trunk/WebCore
Build fix, no review.
Fix the Mac and gtk builds:
Don't use a float to hold a double.
Remove a now duplicate symbol.
- WebCore.xcodeproj/project.pbxproj:
- page/Frame.cpp: (WebCore::Frame::selectionLayoutChanged):
- platform/gtk/TemporaryLinkStubs.cpp:
- 1:52 PM Changeset in webkit [38917] by
-
- 13 edits in trunk/JavaScriptCore
2008-12-02 Geoffrey Garen <ggaren@apple.com>
Reviewed by Geoffrey Garen. (Patch by Cameron Zwarich <zwarich@apple.com>.)
Fixed https://bugs.webkit.org/show_bug.cgi?id=22482
REGRESSION (r37991): Occasionally see "Scene rendered incorrectly"
message when running the V8 Raytrace benchmark
Rolled out r37991. It didn't properly save xmm0, which is caller-save,
before calling helper functions.
SunSpider and v8 benchmarks show little change -- possibly a .2%
SunSpider regression, possibly a .2% v8 benchmark speedup.
- assembler/X86Assembler.h: (JSC::X86Assembler::):
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
- bytecode/Instruction.h: (JSC::Instruction::):
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitUnaryOp):
- bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::emitToJSNumber): (JSC::BytecodeGenerator::emitTypeOf): (JSC::BytecodeGenerator::emitGetPropertyNames):
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
- interpreter/Interpreter.h:
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
- parser/Nodes.cpp: (JSC::UnaryOpNode::emitBytecode): (JSC::BinaryOpNode::emitBytecode): (JSC::EqualNode::emitBytecode):
- parser/ResultType.h: (JSC::ResultType::isReusable): (JSC::ResultType::mightBeNumber):
- runtime/JSNumberCell.h:
- 1:32 PM Changeset in webkit [38916] by
-
- 3 edits in trunk/JavaScriptCore
2008-12-01 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoffrey Garen.
Remove unused (sampling only, and derivable) argument to JIT::emitCTICall.
https://bugs.webkit.org/show_bug.cgi?id=22587
- jit/JIT.cpp: (JSC::JIT::emitCTICall): (JSC::JIT::compileOpCall): (JSC::JIT::emitSlowScriptCheck): (JSC::JIT::compileBinaryArithOpSlowCase): (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases): (JSC::JIT::privateCompile):
- jit/JIT.h:
- 1:29 PM Changeset in webkit [38915] by
-
- 6 edits in trunk
Bug 22596: Some elements don't report AXBlockQuoteLevel
Make sure all AX objects return a block quote level
- 1:26 PM Changeset in webkit [38914] by
-
- 9 edits in trunk/WebKit/mac
2008-12-02 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Let the plug-in views know if the plug-in host crashes.
- Plugins/Hosted/NetscapePluginHostManager.h:
- Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::instantiatePlugin):
- Plugins/Hosted/NetscapePluginHostProxy.h:
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::pluginHostDied): (WebKit::NetscapePluginHostProxy::addPluginInstance): (WebKit::NetscapePluginHostProxy::removePluginInstance):
- Plugins/Hosted/NetscapePluginInstanceProxy.h: (WebKit::NetscapePluginInstanceProxy::create):
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: Keep a pointer to the host proxy.
(WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
Add the instance to the host set.
(WebKit::NetscapePluginInstanceProxy::~NetscapePluginInstanceProxy):
Remove the instance form the host set.
(WebKit::NetscapePluginInstanceProxy::pluginHostDied):
Tell the plug-in view that the plug-in died.
- Plugins/Hosted/WebHostedNetscapePluginView.h:
- Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView createPlugin]): Pass the plug-in view to the instantiatePlugin.
(-[WebHostedNetscapePluginView pluginHostDied]):
Handle the plug-in host crashing.
(-[WebHostedNetscapePluginView drawRect:]):
Fill the plug-in view with a nice red shade if the plug-in crashes.
- 12:43 PM Changeset in webkit [38913] by
-
- 3 edits2 adds in trunk
2008-12-02 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
Fix the inheritance chain for JSFunction.
- runtime/JSFunction.cpp: (JSC::JSFunction::info): Add InternalFunction::info as parent class
- 12:36 PM Changeset in webkit [38912] by
-
- 4 edits in trunk
2008-12-02 Michael Moss <mmoss@chromium.org>
Reviewed by Eric Seidel.
- Fix http/tests/navigation/reload-subframe-*frame.html on Windows. https://bugs.webkit.org/show_bug.cgi?id=20926
Change 31264 fixed this on Mac (since moved to WebCore/loader/FrameLoader.cpp), but was never ported to Windows.
- WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::loadURLIntoChild):
- 12:32 PM Changeset in webkit [38911] by
-
- 6 edits in trunk/WebCore
2008-12-02 Dean McNamee <deanm@chromium.org>
Reviewed by Eric Seidel.
Correctly handle a theme returning a non-blinking interval. We should
not set any timers when the interval is 0 (non-blinking), otherwise we
repeatedly set and destroy a blinking timer, causing a paint and timer
storm. This is applicable to GTK and Windows, where a user can set a
non-blinking caret in their system preferences.
Renamed caretBlinkFrequency to the more accurate caretBlinkInterval.
- page/Frame.cpp: (WebCore::Frame::selectionLayoutChanged):
- platform/Theme.h: (WebCore::Theme::caretBlinkInterval):
- platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::caretBlinkInterval):
- platform/gtk/RenderThemeGtk.h:
- rendering/RenderTheme.h: (WebCore::RenderTheme::caretBlinkInterval):
- 12:27 PM Changeset in webkit [38910] by
-
- 2 edits in trunk/WebCore
Reviewed by Eric Seidel.
startsWith uses find which searches through the whole string if no match is found.
Using reverseFind with an index of 0 has the benefit of only searching for the match
at the beginning of the string. This may only be a small benefit in the overall program,
but it may help in some cases when the string is big.
No observable change in behavior, so no test.
- platform/text/StringImpl.h: (WebCore::StringImpl::startsWith):
- 12:25 PM Changeset in webkit [38909] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
Wrap a JSC-only hack in a USE(JSC) block to fix the v8 build.
https://bugs.webkit.org/show_bug.cgi?id=21951
- svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::forgetWrapper):
- 11:07 AM Changeset in webkit [38908] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
Add an ASSERT to try and catch the root cause of:
https://bugs.webkit.org/show_bug.cgi?id=22168
http://code.google.com/p/chromium/issues/detail?id=4122
- editing/TextIterator.cpp: (WebCore::TextIterator::emitText):
- 11:04 AM Changeset in webkit [38907] by
-
- 2 edits in trunk/WebKitTools
Reviewed by David Kilzer.
Hack build-webkit --chromium to use Win32 python instead
of using the default cygwin python. Scons + CYGWIN tries
to build with GCC by default, we force MSVC in our file
but that just results in errors from Scons. Until we can fix
this latest round of errors, at least make build-webkit --chromium
actually "work" under CYGWIN instead of forcing users to use
a cmd shell directly.
This is working around a Scons bug:
http://scons.tigris.org/issues/show_bug.cgi?id=2266
- Scripts/webkitdirs.pm:
- 11:01 AM Changeset in webkit [38906] by
-
- 4 edits in trunk/WebCore
2008-12-02 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Adam Roben.
Remove some CG-specific code from the Windows Cairo build.
https://bugs.webkit.org/show_bug.cgi?id=22586
No new test cases since this update should create no user-visible
changes, and should be fully covered by the existing regression
tests.
- WebCore.vcproj/WebCore.vcproj: Remove FontDatabase from
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::focusRingColor): Add stub method
- platform/win/TemporaryLinkStubs.cpp: (WebCore::populateFontDatabase): Add stub method.
- 10:32 AM Changeset in webkit [38905] by
-
- 5 edits in trunk/WebKit/mac
2008-12-01 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Recover if the plug-in host dies and we try to instantiate another plugin before we get the port death notification
- Plugins/Hosted/NetscapePluginHostManager.h:
- Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::pluginHostDied): Remove the plug-in host from the map.
(WebKit::NetscapePluginHostManager::instantiatePlugin):
NetscapePluginHostProxy is no longer refcounted.
- Plugins/Hosted/NetscapePluginHostProxy.h: This is no longer refcounted. Add a set of plug-in instances (unused for now).
- Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Create a death notification port.
(WebKit::NetscapePluginHostProxy::pluginHostDied):
Tell the manager that we're gone and delete ourselves.
(WebKit::NetscapePluginHostProxy::deathPortCallback):
New CFMachPort callback.
- 8:14 AM Changeset in webkit [38904] by
-
- 4 edits in trunk/WebKit/qt
2008-12-02 Simon Hausmann <Simon Hausmann>
Rubber-stamped by Tor Arne Vestbø.
Initial API documentation for QWebDatabase, QWebSecurityOrigin and
QWebFrame::securityOrigin().
- 8:03 AM Changeset in webkit [38903] by
-
- 2 edits in trunk/WebCore
2008-12-01 Laszlo Gombos <Laszlo Gombos>
Reviewed by Tor Arne Vestbø.
MinGW compilation fix for PluginPackageWin.cpp
- 7:13 AM Changeset in webkit [38902] by
-
- 2 edits in trunk/WebCore
Build fix for Windows projects with NOMINMAX defined globally
- platform/win/COMPtr.h: Don't redefine NOMINMAX if it's already defined.
- 2:04 AM Changeset in webkit [38901] by
-
- 8 edits in trunk
Top-Level:
2008-12-02 Simon Hausmann <Simon Hausmann>
Reviewed by Tor Arne Vestbø.
Removed JavaScriptCore from SUBDIRS as it's not built separately
anymore.
WebCore:
2008-12-02 Simon Hausmann <Simon Hausmann>
Reviewed by Tor Arne Vestbø.
Build JavaScriptCore into libQtWebKit.so through a direct build
instead of a static library. When linking a static library into
a shared library qmake generates an incorrect .prl file, which
causes all sorts of different build problems when linking against
QtWebKit. Fixing this in qmake requires bigger changes that are
currently not possible, so we need to work around this limitation
for now. The advantages of the separate build did not outweight the
build problems it caused.
2008-12-02 Simon Hausmann <Simon Hausmann>
Reviewed by Tor Arne Vestbø.
Fix ability to include JavaScriptCore.pri from other .pro files.
- 12:49 AM Changeset in webkit [38900] by
-
- 8 edits in trunk/WebCore
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=22588
Move securityOrigin() from Document and WorkerContext into ScriptExecutionContext.
No observable change in behavior, so no test.
- dom/Document.cpp: (WebCore::Document::open): (WebCore::Document::domain): (WebCore::Document::setDomain): (WebCore::Document::initSecurityContext): (WebCore::Document::setSecurityOrigin):
- dom/Document.h:
- dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::setSecurityOrigin):
- dom/ScriptExecutionContext.h: (WebCore::ScriptExecutionContext::securityOrigin):
- dom/WorkerContext.cpp: (WebCore::WorkerContext::WorkerContext):
- dom/WorkerContext.h: These changes are for the move of securityOrigin().
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::createRequest): (WebCore::XMLHttpRequest::makeSimpleCrossSiteAccessRequest): (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight): (WebCore::XMLHttpRequest::handleAsynchronousPreflightResult): (WebCore::XMLHttpRequest::setRequestHeader): (WebCore::XMLHttpRequest::getAllResponseHeaders): (WebCore::XMLHttpRequest::getResponseHeader): (WebCore::XMLHttpRequest::processSyncLoadResults): (WebCore::XMLHttpRequest::willSendRequest): (WebCore::XMLHttpRequest::accessControlCheck): (WebCore::XMLHttpRequest::didReceiveResponsePreflight): Change XMLHttpRequest to use ScriptExecutionContext instead of Document to access securityOrigin().
- 12:26 AM Changeset in webkit [38899] by
-
- 2 edits in trunk/WebCore
2008-12-02 André Pönitz <apoenitz@trolltech.com>
Reviewed by Simon Hausmann.
Disable the creation of debug information for the Qt build when done
inside Qt. With 670 mb it was slowing down gdb start significantly
for third-party applications that usually don't need it.
