Timeline



Jan 21, 2009:

11:54 PM Changeset in webkit [40118] by hyatt@apple.com
  • 5 edits in trunk/WebCore

2009-01-21 David Hyatt <hyatt@apple.com>

Back out a portion of my patch that I did not mean to land. Revert paintOutline back to the way it
was before my landing. Fixes failing SVG focus ring tests.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::paintOutline):
  • rendering/RenderObject.h:
  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
11:19 PM Changeset in webkit [40117] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2009-01-21 David Hyatt <hyatt@apple.com>

Fix Node's renderBox() method on Windows.

  • dom/Node.cpp: (WebCore::Node::renderBox):
11:05 PM Changeset in webkit [40116] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2009-01-21 David Hyatt <hyatt@apple.com>

Fix RenderThemeSafari bustage on Win32.

  • rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::baselinePosition):
10:58 PM Changeset in webkit [40115] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2009-01-21 David Hyatt <hyatt@apple.com>

Fix bustage in RenderThemeWin. It's actually terrible that RenderThemeWin is using absoluteContentBox,
but that's a problem for another day.

  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintSearchFieldCancelButton): (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration): (WebCore::RenderThemeWin::paintSearchFieldResultsButton):
9:59 PM Changeset in webkit [40114] by barraclough@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Because bdash hates freedom (tyop fix).

9:57 PM Changeset in webkit [40113] by barraclough@apple.com
  • 1 edit
    2 copies in trunk/LayoutTests

2009-01-21 Gavin Barraclough <barraclough@apple.com>

Rubber stamped by Geoff "Cameron Zwarich" Garen.

Add pre & post standalone driver stcripts to assist running the javascript layout tests
on jsc, rather than a full webkit build.

  • fast/js/resources/standalone-post.js: Copied from fast/js/resources/js-test-post.js.
  • fast/js/resources/standalone-pre.js: Copied from fast/js/resources/js-test-pre.js. (description): (debug): (escapeString): (testPassed): (testFailed):
9:48 PM Changeset in webkit [40112] by oliver@apple.com
  • 2 edits in trunk/WebCore

Bug 23470: Crash when page load occurs while processing scroll event with MallocScribble enabled
<https://bugs.webkit.org/show_bug.cgi?id=23470>

Reviewed by Dave Hyatt

Add a RefPtr protector to handleWheelEvent to guard against destruction
while processing the scroll event. Alas the absurd set of circumstances
required to trigger this do not appear to be reproducible in DRT.

8:28 PM Changeset in webkit [40111] by barraclough@apple.com
  • 5 edits in trunk

JavaScriptCore:

2009-01-21 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Fix for https://bugs.webkit.org/show_bug.cgi?id=23469.

We need to check all numbers in integer switches, not just those
represented as integer JSImmediates.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): (JSC::Interpreter::cti_op_switch_imm):

LayoutTests:

2009-01-21 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Add layout test for switch (-0).

  • fast/js/resources/switch-behaviour.js:
  • fast/js/switch-behaviour-expected.txt:
7:48 PM Changeset in webkit [40110] by mrowe@apple.com
  • 4 edits in branches/Safari-3-2-branch

Versioning.

7:44 PM Changeset in webkit [40109] by mrowe@apple.com
  • 4 edits in branches/Safari-3-2-branch

Versioning.

7:35 PM Changeset in webkit [40108] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-01-21 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoff Garen.

Fix for https://bugs.webkit.org/show_bug.cgi?id=23468.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
6:31 PM Changeset in webkit [40107] by hyatt@apple.com
  • 101 edits in trunk

WebCore:

2009-01-21 David Hyatt <hyatt@apple.com>

Fix for https://bugs.webkit.org/show_bug.cgi?id=23453

Devirtualize the width/height/x/y methods of the render tree. The methods are now non-virtual on RenderBox.
Many functions that were previously in RenderObject.cpp are now in RenderBox.cpp.

Reviewed by Eric Seidel and Darin Adler

  • WebCore.base.exp:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::sizingBox):
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::getUpperLeftCorner): (WebCore::ContainerNode::getLowerRightCorner):
  • dom/Element.cpp: (WebCore::Element::offsetLeft): (WebCore::Element::offsetTop): (WebCore::Element::offsetWidth): (WebCore::Element::offsetHeight): (WebCore::Element::offsetParent): (WebCore::Element::clientLeft): (WebCore::Element::clientTop): (WebCore::Element::clientWidth): (WebCore::Element::clientHeight): (WebCore::Element::scrollLeft): (WebCore::Element::scrollTop): (WebCore::Element::setScrollLeft): (WebCore::Element::setScrollTop): (WebCore::Element::scrollWidth): (WebCore::Element::scrollHeight):
  • dom/Node.cpp: (WebCore::Node::renderBox): (WebCore::Node::getRect):
  • dom/Node.h:
  • dom/Position.cpp: (WebCore::endsOfNodeAreVisuallyDistinctPositions): (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight): (WebCore::Position::isCandidate):
  • dom/PositionIterator.cpp: (WebCore::PositionIterator::isCandidate):
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded):
  • editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::removeNode):
  • editing/Editor.cpp: (WebCore::Editor::insideVisibleArea):
  • editing/EditorCommand.cpp: (WebCore::verticalScrollDistance):
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::isKeyboardFocusable):
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::willDraw):
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::isFocusable):
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::width): (WebCore::HTMLFrameElementBase::height):
  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::width): (WebCore::HTMLImageElement::height):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::drawNodeHighlight):
  • page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
  • page/FrameView.cpp: (WebCore::FrameView::createScrollbar): (WebCore::FrameView::updateDashboardRegions):
  • page/animation/AnimationBase.cpp: (WebCore::blendFunc):
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::imageRect):
  • rendering/InlineBox.cpp: (WebCore::InlineBox::renderBox): (WebCore::InlineBox::adjustPosition):
  • rendering/InlineBox.h:
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): (WebCore::InlineFlowBox::verticallyAlignBoxes): (WebCore::InlineFlowBox::placeBoxesVertically):
  • rendering/InlineFlowBox.h:
  • rendering/RenderApplet.cpp: (WebCore::RenderApplet::createWidgetIfNecessary):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::overflowHeight): (WebCore::RenderBlock::overflowWidth): (WebCore::RenderBlock::overflowRect): (WebCore::RenderBlock::isSelfCollapsingBlock): (WebCore::RenderBlock::layout): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::adjustPositionedBlock): (WebCore::RenderBlock::adjustFloatingBlock): (WebCore::RenderBlock::handleSpecialChild): (WebCore::RenderBlock::handlePositionedChild): (WebCore::RenderBlock::handleFloatingChild): (WebCore::RenderBlock::handleCompactChild): (WebCore::RenderBlock::insertCompactIfNeeded): (WebCore::RenderBlock::handleRunInChild): (WebCore::RenderBlock::collapseMargins): (WebCore::RenderBlock::clearFloatsIfNeeded): (WebCore::RenderBlock::estimateVerticalPosition): (WebCore::RenderBlock::determineHorizontalPosition): (WebCore::RenderBlock::handleBottomOfBlock): (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::layoutOnlyPositionedObjects): (WebCore::RenderBlock::layoutPositionedObjects): (WebCore::RenderBlock::markPositionedObjectsForLayout): (WebCore::RenderBlock::repaintOverhangingFloats): (WebCore::RenderBlock::paint): (WebCore::RenderBlock::paintChildren): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::paintFloats): (WebCore::RenderBlock::paintContinuationOutlines): (WebCore::clipOutPositionedObjects): (WebCore::RenderBlock::fillSelectionGaps): (WebCore::RenderBlock::fillBlockSelectionGaps): (WebCore::RenderBlock::leftSelectionOffset): (WebCore::RenderBlock::rightSelectionOffset): (WebCore::RenderBlock::insertPositionedObject): (WebCore::RenderBlock::removePositionedObject): (WebCore::RenderBlock::removePositionedObjects): (WebCore::RenderBlock::insertFloatingObject): (WebCore::RenderBlock::removeFloatingObject): (WebCore::RenderBlock::positionNewFloats): (WebCore::RenderBlock::newLine): (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition): (WebCore::RenderBlock::clearFloats): (WebCore::RenderBlock::addOverhangingFloats): (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout): (WebCore::RenderBlock::getClearDelta): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::positionForCoordinates): (WebCore::RenderBlock::layoutColumns): (WebCore::RenderBlock::getBaselineOfFirstLineBox): (WebCore::RenderBlock::getBaselineOfLastLineBox): (WebCore::getHeightForLineCount): (WebCore::RenderBlock::adjustForBorderFit):
  • rendering/RenderBlock.h: (WebCore::RenderBlock::FloatWithRect::FloatWithRect): (WebCore::RenderBlock::hasOverhangingFloats): (WebCore::RenderBlock::CompactInfo::compact): (WebCore::RenderBlock::CompactInfo::set):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::RenderBox): (WebCore::RenderBox::offsetLeft): (WebCore::RenderBox::offsetTop): (WebCore::RenderBox::offsetParent): (WebCore::RenderBox::clientWidth): (WebCore::RenderBox::clientHeight): (WebCore::RenderBox::scrollWidth): (WebCore::RenderBox::scrollHeight): (WebCore::RenderBox::scrollLeft): (WebCore::RenderBox::scrollTop): (WebCore::RenderBox::setScrollLeft): (WebCore::RenderBox::setScrollTop): (WebCore::RenderBox::absoluteRects): (WebCore::RenderBox::absoluteQuads): (WebCore::RenderBox::absoluteContentBox): (WebCore::RenderBox::absoluteContentQuad): (WebCore::RenderBox::absoluteOutlineBounds): (WebCore::RenderBox::addFocusRingRects): (WebCore::RenderBox::reflectionBox): (WebCore::RenderBox::reflectionOffset): (WebCore::RenderBox::reflectedRect): (WebCore::RenderBox::overrideWidth): (WebCore::RenderBox::overrideHeight): (WebCore::RenderBox::nodeAtPoint): (WebCore::RenderBox::paint): (WebCore::RenderBox::maskClipRect): (WebCore::RenderBox::repaintLayerRectsForImage): (WebCore::RenderBox::paintCustomHighlight): (WebCore::RenderBox::getOverflowClipRect): (WebCore::RenderBox::getClipRect): (WebCore::RenderBox::containingBlockWidth): (WebCore::RenderBox::localToAbsolute): (WebCore::RenderBox::offsetFromContainer): (WebCore::RenderBox::position): (WebCore::RenderBox::computeAbsoluteRepaintRect): (WebCore::RenderBox::repaintDuringLayoutIfMoved): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcWidthUsing): (WebCore::RenderBox::calcHorizontalMargins): (WebCore::RenderBox::calcHeight): (WebCore::RenderBox::calcPercentageHeight): (WebCore::RenderBox::calcReplacedHeightUsing): (WebCore::RenderBox::containingBlockWidthForPositioned): (WebCore::RenderBox::containingBlockHeightForPositioned): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteVertical): (WebCore::RenderBox::calcAbsoluteVerticalValues): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): (WebCore::RenderBox::calcAbsoluteVerticalReplaced): (WebCore::RenderBox::localCaretRect): (WebCore::RenderBox::lowestPosition): (WebCore::RenderBox::rightmostPosition): (WebCore::RenderBox::leftmostPosition): (WebCore::RenderBox::localTransform):
  • rendering/RenderBox.h: (WebCore::): (WebCore::RenderBox::x): (WebCore::RenderBox::y): (WebCore::RenderBox::width): (WebCore::RenderBox::height): (WebCore::RenderBox::setX): (WebCore::RenderBox::setY): (WebCore::RenderBox::setWidth): (WebCore::RenderBox::setHeight): (WebCore::RenderBox::location): (WebCore::RenderBox::size): (WebCore::RenderBox::setLocation): (WebCore::RenderBox::setSize): (WebCore::RenderBox::move): (WebCore::RenderBox::frameRect): (WebCore::RenderBox::setFrameRect): (WebCore::RenderBox::borderBoxRect): (WebCore::RenderBox::contentBoxRect): (WebCore::RenderBox::previousSiblingBox): (WebCore::RenderBox::nextSiblingBox): (WebCore::RenderBox::parentBox): (WebCore::RenderBox::overflowHeight): (WebCore::RenderBox::overflowWidth): (WebCore::RenderBox::setOverflowHeight): (WebCore::RenderBox::setOverflowWidth): (WebCore::RenderBox::overflowLeft): (WebCore::RenderBox::overflowTop): (WebCore::RenderBox::overflowRect): (WebCore::RenderBox::contentWidth): (WebCore::RenderBox::contentHeight): (WebCore::RenderBox::offsetWidth): (WebCore::RenderBox::offsetHeight): (WebCore::RenderBox::clientLeft): (WebCore::RenderBox::clientTop): (WebCore::RenderBox::availableWidth): (WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly):
  • rendering/RenderButton.cpp: (WebCore::RenderButton::controlClipRect):
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::layout): (WebCore::RenderContainer::positionForCoordinates):
  • rendering/RenderContainer.h: (WebCore::RenderContainer::firstChildBox): (WebCore::RenderContainer::lastChildBox):
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::calcPrefWidths): (WebCore::RenderFieldset::layoutLegend): (WebCore::RenderFieldset::findLegend): (WebCore::RenderFieldset::paintBoxDecorations): (WebCore::RenderFieldset::paintMask):
  • rendering/RenderFieldset.h:
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::maxFilenameWidth): (WebCore::RenderFileUploadControl::paintObject):
  • rendering/RenderFlexibleBox.cpp: (WebCore::FlexBoxIterator::FlexBoxIterator): (WebCore::FlexBoxIterator::first): (WebCore::FlexBoxIterator::next): (WebCore::RenderFlexibleBox::calcHorizontalPrefWidths): (WebCore::RenderFlexibleBox::calcVerticalPrefWidths): (WebCore::RenderFlexibleBox::layoutBlock): (WebCore::RenderFlexibleBox::layoutHorizontalBox): (WebCore::RenderFlexibleBox::layoutVerticalBox): (WebCore::RenderFlexibleBox::placeChild): (WebCore::RenderFlexibleBox::allowedChildFlex):
  • rendering/RenderFlexibleBox.h:
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::absoluteClippedOverflowRect): (WebCore::RenderFlow::lowestPosition): (WebCore::RenderFlow::rightmostPosition): (WebCore::RenderFlow::leftmostPosition): (WebCore::RenderFlow::localCaretRect): (WebCore::RenderFlow::addFocusRingRects):
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::paint): (WebCore::RenderFrameSet::layout): (WebCore::RenderFrameSet::positionFrames):
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paintReplaced): (WebCore::RenderHTMLCanvas::canvasSizeChanged):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::paintReplaced): (WebCore::RenderImage::nodeAtPoint): (WebCore::RenderImage::calcReplacedWidth):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::absoluteRects): (WebCore::RenderInline::boundingBoxWidth): (WebCore::RenderInline::boundingBoxHeight): (WebCore::RenderInline::positionForCoordinates):
  • rendering/RenderInline.h: (WebCore::RenderInline::offsetWidth): (WebCore::RenderInline::offsetHeight):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateTransform): (WebCore::RenderLayer::updateLayerPosition): (WebCore::RenderLayer::scrollbarCornerPresent): (WebCore::RenderLayer::createScrollbar): (WebCore::RenderLayer::positionOverflowControls): (WebCore::RenderLayer::paintScrollCorner): (WebCore::RenderLayer::paintResizer): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::calculateRects): (WebCore::RenderLayer::boundingBox):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::calcHeight): (WebCore::RenderListBox::controlClipRect):
  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::positionListMarker): (WebCore::RenderListItem::paint):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::layout): (WebCore::RenderListMarker::imageChanged): (WebCore::RenderListMarker::getRelativeMarkerRect): (WebCore::RenderListMarker::selectionRect):
  • rendering/RenderMarquee.cpp: (WebCore::RenderMarquee::computePosition):
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::layout): (WebCore::RenderMedia::lowestPosition): (WebCore::RenderMedia::rightmostPosition): (WebCore::RenderMedia::leftmostPosition):
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::controlClipRect):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject): (WebCore::RenderObject::markAllDescendantsWithFloatsForLayout): (WebCore::RenderObject::paintOutline): (WebCore::RenderObject::addLineBoxRects): (WebCore::RenderObject::absoluteBoundingBoxRect): (WebCore::RenderObject::addAbsoluteRectForLayer): (WebCore::RenderObject::paintingRootRect): (WebCore::RenderObject::container): (WebCore::RenderObject::removeFromObjectLists): (WebCore::RenderObject::updateHitTestResult): (WebCore::RenderObject::addDashboardRegions): (WebCore::RenderObject::localTransform):
  • rendering/RenderObject.h: (WebCore::RenderObject::isBox): (WebCore::RenderObject::hasMask): (WebCore::RenderObject::setIsText): (WebCore::RenderObject::setIsBox): (WebCore::RenderObject::borderTop): (WebCore::RenderObject::borderBottom): (WebCore::RenderObject::absoluteRects): (WebCore::RenderObject::collectAbsoluteLineBoxQuads): (WebCore::RenderObject::absoluteQuads): (WebCore::RenderObject::hasReflection): (WebCore::RenderObject::addFocusRingRects): (WebCore::RenderObject::absoluteOutlineBounds):
  • rendering/RenderPart.cpp: (WebCore::RenderPart::updateWidgetPosition):
  • rendering/RenderPath.cpp: (WebCore::RenderPath::layout): (WebCore::RenderPath::paint): (WebCore::RenderPath::absoluteOutlineBounds):
  • rendering/RenderPath.h:
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::layout): (WebCore::RenderReplaced::paint): (WebCore::RenderReplaced::shouldPaint): (WebCore::RenderReplaced::positionForCoordinates): (WebCore::RenderReplaced::localSelectionRect): (WebCore::RenderReplaced::adjustOverflowForBoxShadow): (WebCore::RenderReplaced::overflowRect):
  • rendering/RenderReplica.cpp: (WebCore::RenderReplica::layout): (WebCore::RenderReplica::calcPrefWidths): (WebCore::RenderReplica::paint):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint): (WebCore::RenderSVGContainer::absoluteOutlineBounds):
  • rendering/RenderSVGContainer.h: (WebCore::RenderSVGContainer::width): (WebCore::RenderSVGContainer::height):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::layout):
  • rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::computeAbsoluteRectForRange): (WebCore::RenderSVGInlineText::positionForCoordinates):
  • rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::layout): (WebCore::RenderSVGRoot::applyContentTransforms): (WebCore::RenderSVGRoot::paint): (WebCore::RenderSVGRoot::absoluteTransform): (WebCore::RenderSVGRoot::nodeAtPoint):
  • rendering/RenderSVGTSpan.cpp: (WebCore::RenderSVGTSpan::absoluteRects): (WebCore::RenderSVGTSpan::absoluteQuads):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::layout): (WebCore::RenderSVGText::relativeBBox):
  • rendering/RenderSVGTextPath.cpp: (WebCore::RenderSVGTextPath::absoluteRects): (WebCore::RenderSVGTextPath::absoluteQuads):
  • rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::nodeAtPoint):
  • rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::createCustomScrollbar): (WebCore::RenderScrollbar::RenderScrollbar): (WebCore::RenderScrollbar::setParent):
  • rendering/RenderScrollbar.h: (WebCore::RenderScrollbar::owningRenderer):
  • rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::layout): (WebCore::RenderScrollbarPart::layoutHorizontalPart): (WebCore::RenderScrollbarPart::layoutVerticalPart): (WebCore::RenderScrollbarPart::computeScrollbarWidth): (WebCore::RenderScrollbarPart::computeScrollbarHeight): (WebCore::RenderScrollbarPart::paintIntoRect):
  • rendering/RenderSlider.cpp: (WebCore::HTMLSliderThumbElement::defaultEventHandler): (WebCore::RenderSlider::layout): (WebCore::RenderSlider::mouseEventIsInThumb): (WebCore::RenderSlider::positionForOffset): (WebCore::RenderSlider::trackSize):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::calcWidth): (WebCore::RenderTable::layout): (WebCore::RenderTable::paint): (WebCore::RenderTable::getBaselineOfFirstLineBox):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::updateWidth): (WebCore::RenderTableCell::computeAbsoluteRepaintRect): (WebCore::RenderTableCell::localToAbsolute): (WebCore::RenderTableCell::absoluteToLocal): (WebCore::RenderTableCell::localToAbsoluteQuad): (WebCore::RenderTableCell::paint): (WebCore::RenderTableCell::paintBackgroundsBehindCell):
  • rendering/RenderTableCell.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild): (WebCore::RenderTableSection::addCell): (WebCore::RenderTableSection::setCellWidths): (WebCore::RenderTableSection::calcRowHeight): (WebCore::RenderTableSection::layoutRows): (WebCore::RenderTableSection::lowestPosition): (WebCore::RenderTableSection::rightmostPosition): (WebCore::RenderTableSection::leftmostPosition): (WebCore::RenderTableSection::getBaselineOfFirstLineBox): (WebCore::RenderTableSection::paint): (WebCore::RenderTableSection::recalcCells): (WebCore::RenderTableSection::nodeAtPoint):
  • rendering/RenderTableSection.h: (WebCore::RenderTableSection::overflowWidth): (WebCore::RenderTableSection::overflowHeight):
  • rendering/RenderText.cpp: (WebCore::RenderText::RenderText): (WebCore::RenderText::boundingBoxX): (WebCore::RenderText::boundingBoxY): (WebCore::RenderText::firstRunX): (WebCore::RenderText::firstRunY): (WebCore::RenderText::boundingBoxHeight): (WebCore::RenderText::boundingBoxWidth):
  • rendering/RenderText.h:
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::textBlockHeight): (WebCore::RenderTextControl::textBlockWidth): (WebCore::RenderTextControl::setSelectionRange): (WebCore::RenderTextControl::calcHeight): (WebCore::RenderTextControl::hitInnerTextBlock): (WebCore::RenderTextControl::controlClipRect):
  • rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::layout): (WebCore::RenderTextControlMultiLine::adjustControlHeightBasedOnLineHeight):
  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::paint): (WebCore::RenderTextControlSingleLine::layout): (WebCore::RenderTextControlSingleLine::nodeAtPoint): (WebCore::RenderTextControlSingleLine::forwardEvent): (WebCore::RenderTextControlSingleLine::textBlockWidth): (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight): (WebCore::RenderTextControlSingleLine::clientPaddingLeft): (WebCore::RenderTextControlSingleLine::clientPaddingRight):
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::hitTestMediaControlPart): (WebCore::RenderTheme::baselinePosition):
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintSearchFieldCancelButton): (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration): (WebCore::RenderThemeMac::paintSearchFieldResultsButton): (WebCore::RenderThemeMac::hitTestMediaControlPart):
  • rendering/RenderTreeAsText.cpp: (WebCore::operator<<):
  • rendering/RenderVideo.cpp: (WebCore::RenderVideo::videoBox):
  • rendering/RenderView.cpp: (WebCore::RenderView::RenderView): (WebCore::RenderView::calcHeight): (WebCore::RenderView::calcWidth): (WebCore::RenderView::layout): (WebCore::RenderView::viewRect): (WebCore::RenderView::docHeight): (WebCore::RenderView::docWidth): (WebCore::RenderView::setBestTruncatedAt):
  • rendering/RenderView.h:
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint): (WebCore::RenderWidget::updateWidgetPosition): (WebCore::RenderWidget::nodeAtPoint):
  • rendering/RootInlineBox.h: (WebCore::RootInlineBox::floats): (WebCore::RootInlineBox::floatsPtr):
  • rendering/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::verticallyAlignBoxes):
  • rendering/SVGInlineFlowBox.h:
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::operator<<): (WebCore::write):
  • rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::verticallyAlignBoxes): (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation): (WebCore::SVGRootInlineBox::layoutInlineBoxes):
  • rendering/SVGRootInlineBox.h:
  • rendering/bidi.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine): (WebCore::RenderBlock::computeVerticalPositionsForLine): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::determineStartPosition): (WebCore::RenderBlock::matchedEndLine): (WebCore::RenderBlock::skipTrailingWhitespace): (WebCore::RenderBlock::skipLeadingWhitespace): (WebCore::RenderBlock::fitBelowFloats): (WebCore::RenderBlock::findNextLineBreak): (WebCore::RenderBlock::checkLinesForOverflow):
  • svg/SVGLength.cpp: (WebCore::SVGLength::PercentageOfViewport):

WebKit/mac:

2009-01-21 David Hyatt <hyatt@apple.com>

Devirtualize width/height/x/y on RenderObject and move the methods to RenderBox.

Reviewed by Eric Seidel and Darin Adler

  • WebView/WebRenderNode.mm: (copyRenderNode):
5:39 PM Changeset in webkit [40106] by andersca@apple.com
  • 8 edits in trunk/WebKit/mac

2009-01-21 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

More browser->plug-in scripting support.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCNPObjectHasPropertyReply): (WKPCNPObjectHasMethodReply): (WKPCNPObjectInvokeReply): MIG reply functions.


(WKPCIdentifierInfo):
Return information about an identifier given its 64-bit value.


  • Plugins/Hosted/NetscapePluginInstanceProxy.h: Add new reply structs.


  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::addValueToArray): Split out code that adds values to the arrays from marshalValue.


(WebKit::NetscapePluginInstanceProxy::marshalValue):
Call addValueToArray.


(WebKit::NetscapePluginInstanceProxy::marshalValues):
Marshal a list of values.


(WebKit::NetscapePluginInstanceProxy::createBindingsInstance):
Actually create a proxy instance.


  • Plugins/Hosted/ProxyInstance.h:
  • Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyClass::methodsNamed): (WebKit::ProxyClass::fieldNamed): Add a proxy ProxyClass class that just forwards everything to the ProxyInstance class.


(WebKit::proxyClass):
Shared proxyClass getter.


(WebKit::ProxyField::ProxyField):
(WebKit::ProxyField::valueFromInstance):
(WebKit::ProxyField::setValueToInstance):
Add a proxy ProxyField class that just forwards everything to the ProxyInstance class.


(WebKit::ProxyMethod::ProxyMethod):
(WebKit::ProxyMethod::serverIdentifier):
(WebKit::ProxyMethod::numParameters):
Add a dummy ProxyMethod class.


(WebKit::ProxyInstance::invokeMethod):
Call _WKPHNPObjectInvoke.


(WebKit::ProxyInstance::defaultValue):
(WebKit::ProxyInstance::stringValue):
(WebKit::ProxyInstance::numberValue):
(WebKit::ProxyInstance::booleanValue):
(WebKit::ProxyInstance::valueOf):
Add dummy implementations (taken from CInstance).


(WebKit::ProxyInstance::methodsNamed):
Call _WKPHNPObjectHasMethod to determine whether a method with the given name exists.


(WebKit::ProxyInstance::fieldNamed):
Call _WKPHNPObjectHasProperty to determine whether a property with the given name exists.


  • Plugins/Hosted/WebKitPluginClient.defs:
  • Plugins/Hosted/WebKitPluginHost.defs: Add new MIG definitions.
5:39 PM Changeset in webkit [40105] by pol@apple.com
  • 2 edits in trunk/WebKitTools

2009-01-21 Pierre-Olivier Latour <pol@apple.com>

Tweaked earlier fix to only print a warning when Perian is installed,
and fail completely only if attempting to generate new pixel test results.

https://bugs.webkit.org/show_bug.cgi?id=23392

  • Scripts/run-webkit-tests:
4:50 PM Changeset in webkit [40104] by andersca@apple.com
  • 3 edits in trunk/WebCore

2009-01-21 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

  • WebCore.LP64.exp: Add some bridge related symbols.


  • WebCore.xcodeproj/project.pbxproj: Make runtime_object.h a private header.
4:22 PM Changeset in webkit [40103] by oliver@apple.com
  • 10 edits
    5 adds in trunk/WebCore

Bug 22720: Make XMLHttpRequest work in Workers
<https://bugs.webkit.org/show_bug.cgi?id=22720>

Contributed by David Levin.

Reviewed by Alexey Proskuryakov

More removal of document usage from XMLHttpRequest.

  • Abstracted away the sync and async requests behind the ThreadableLoader class, which will get an implementation for Workers. It follows the same model as SubresourceLoader, since it is a thin wrapper around it.
  • Consolidated dashboard compatibility checks into usesDashboardBackwardCompatibilityMode which handles workers.

No observable change in behavior, so no test.

4:13 PM Changeset in webkit [40102] by cmarrin@apple.com
  • 6 edits
    2 adds in trunk

Fix for https://bugs.webkit.org/show_bug.cgi?id=23317

The high CPU usage was really from repeatedly firing transitions caused
by a bug in the way we handle background-color animations. If animating
from a valid background color to no background color, we sometimes left
(based on timing) the background color as transparent black, but valid
rather than invalid, which it should be. Fixing that got rid of the
repeated firing.

But we really were doing more expensive iteration of all objects with
animations or transitions on them (running or not). So I added two
optimizations to quickly short circuit when an object had no running
animations or transitions. Things are now as zippy as ever.

3:37 PM Changeset in webkit [40101] by eric@webkit.org
  • 5 edits in trunk

Reviewed by Justin Garcia.

Remove the style= turds left by some editing commands
https://bugs.webkit.org/show_bug.cgi?id=23463

Test: editing/execCommand/toggle-styles.html

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeCSSStyle): check if we just removed the last CSS property and remove the style attribute as well
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::removeNodeAttribute): remove extra ;
3:25 PM Changeset in webkit [40100] by mrowe@apple.com
  • 6 edits in trunk/WebKit/mac

Clean up how we force invocations of API that happened on background threads over to the main thread.

This was previously accomplished in a somewhat ad-hoc manner using a mutable dictionary to pass arguments
and return values back from the function. The new approach is to use a proxy object that forwards an
NSInvocation over to the main thread and applies it to the target object, which leads to a much cleaner
call site.

Reviewed by Tim Hatcher.

  • Misc/WebNSObjectExtras.h:
  • Misc/WebNSObjectExtras.mm:

(-[WebMainThreadInvoker initWithTarget:]):
(-[WebMainThreadInvoker forwardInvocation:]):
(-[WebMainThreadInvoker methodSignatureForSelector:]):
(-[WebMainThreadInvoker handleException:]):
(-[NSInvocation _webkit_invokeAndHandleException:]): Execute the invocation and forward any exception that was
raised back to the WebMainThreadInvoker.
(-[NSObject _webkit_invokeOnMainThread]):

The following methods are updated to use the proxy object to forward methods to the main thread:

  • WebView/WebArchive.mm:

(-[WebArchive initWithMainResource:subresources:subframeArchives:]):
(-[WebArchive mainResource]):
(-[WebArchive subresources]):
(-[WebArchive subframeArchives]):

  • WebView/WebResource.mm:

(-[WebResource data]):
(-[WebResource URL]):
(-[WebResource MIMEType]):
(-[WebResource textEncodingName]):
(-[WebResource frameName]):
(-[WebResource _ignoreWhenUnarchiving]):
(-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
(-[WebResource _initWithData:URL:response:]):
(-[WebResource _suggestedFilename]):
(-[WebResource _response]):
(-[WebResource _stringValue]):

  • WebView/WebView.mm:

(-[WebView initWithFrame:frameName:groupName:]):
(-[WebView initWithCoder:]):

3:20 PM Changeset in webkit [40099] by eric@webkit.org
  • 2 edits in trunk/WebCore

No review, build fix.

Fix release-only build failure (and do a tiny code-cleanup).

  • editing/ApplyStyleCommand.cpp: (WebCore::createFontElement): (WebCore::createStyleSpanElement): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
2:55 PM Changeset in webkit [40098] by Chris Fleizach
  • 10 edits
    2 adds in trunk

Bug 23443: Table accessibility should be re-enabled after fixing crash that occurs at WebCore::AccessibilityTable::isTableExposableThroughAccessibility() when attempting to create a link in a rich text message
https://bugs.webkit.org/show_bug.cgi?id=23443

Re-enable Accessibility tables and make sure accessibility code does not interrogate the render tree
during render tree updates

2:16 PM Changeset in webkit [40097] by eric@webkit.org
  • 8 edits in trunk

Reviewed by Justin Garcia.

Fix execCommand() 'super' and 'sub' commands to add <sup> and <sub> in quirks mode, and to toggle when called twice
https://bugs.webkit.org/show_bug.cgi?id=17733

Test changed: editing/execCommand/toggle-styles-expected.txt

  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::applySubscript): (WebCore::StyleChange::applySuperscript): (WebCore::StyleChange::StyleChange): (WebCore::StyleChange::init): (WebCore::StyleChange::checkForLegacyHTMLStyleChange): (WebCore::ApplyStyleCommand::isHTMLStyleNode): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
  • editing/EditorCommand.cpp: (WebCore::executeSubscript): (WebCore::executeSuperscript):
  • editing/htmlediting.cpp: (WebCore::createHTMLElement):
  • editing/htmlediting.h:
1:52 PM Changeset in webkit [40096] by andersca@apple.com
  • 2 edits in trunk/WebCore

2009-01-21 Anders Carlsson <andersca@apple.com>

Fix 64-bit build.

  • WebCore.LP64.exp:
1:34 PM Changeset in webkit [40095] by mrowe@apple.com
  • 1 copy in tags/Safari-5525.28

New tag.

1:32 PM Changeset in webkit [40094] by mrowe@apple.com
  • 4 edits in branches/Safari-3-2-branch

Versioning.

1:25 PM Changeset in webkit [40093] by mrowe@apple.com
  • 1 edit in branches/Safari-3-2-branch/WebKitLibraries/win/tools/scripts/PRODUCTVERSION

Bump version number.

1:25 PM Changeset in webkit [40092] by mrowe@apple.com
  • 9 edits
    5 adds in branches/Safari-3-2-branch

Merge r33579.

1:25 PM Changeset in webkit [40091] by mrowe@apple.com
  • 2 edits in branches/Safari-3-2-branch/WebCore

Merge r33993.

1:24 PM Changeset in webkit [40090] by mrowe@apple.com
  • 2 edits in branches/Safari-3-2-branch/WebCore

Merge r39247.

1:05 PM Changeset in webkit [40089] by oliver@apple.com
  • 13 edits
    3 copies in trunk/WebCore

Bug 23458: Reintroduce CanvasPixelArray in ImageData.idl
<https://bugs.webkit.org/show_bug.cgi?id=23458>

Reviewed by Alexey Proskuryakov.

Return CanvasPixelArray, et al -- the only difference between this
and the original CPA implementation is that it now uses a ByteArray
rather than a vector. JSC still uses a custom wrapper, but this allows
ObjC, COM, and V8 bindings to be autogenerated again.

12:07 PM Changeset in webkit [40088] by krit@webkit.org
  • 13 edits
    4 deletes in trunk/WebCore

2009-01-21 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Remove last relics of platform dependent PaintServer in SVG.
We draw everything with the help of GraphicsContext.

Remove SVGPaintServerPlatform's
https://bugs.webkit.org/show_bug.cgi?id=23439

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • svg/graphics/SVGPaintServer.cpp: (WebCore::SVGPaintServer::draw): (WebCore::SVGPaintServer::renderPath): (WebCore::SVGPaintServer::teardown):
  • svg/graphics/SVGPaintServer.h:
  • svg/graphics/SVGPaintServerGradient.cpp:
  • svg/graphics/SVGPaintServerGradient.h:
  • svg/graphics/SVGPaintServerPattern.cpp:
  • svg/graphics/SVGPaintServerPattern.h:
  • svg/graphics/SVGPaintServerSolid.cpp:
  • svg/graphics/SVGPaintServerSolid.h:
  • svg/graphics/cairo/SVGPaintServerCairo.cpp: Removed.
  • svg/graphics/cg/SVGPaintServerCg.cpp: Removed.
  • svg/graphics/qt/SVGPaintServerQt.cpp: Removed.
  • svg/graphics/skia/SVGPaintServerSkia.cpp: Removed.
11:49 AM Changeset in webkit [40087] by Nikolas Zimmermann
  • 7 edits in trunk/WebCore

Reviewed by Alexey Proskuryakov.

Move "Element -> ScriptElement" casting functionality into ScriptElement.h
to be consistent with FormControlElement/InputElement/OptionElement/OptionGroupElement.

It was living in XMLTokenizer before, which is not an obvious place for this.
TODO: Rename 'formControlElementForElement' to 'toFormControlElement' (analogous changes for InputElement etc.)

as suggested by Alexey, it really reads better this way.

10:09 AM Changeset in webkit [40086] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Suggested by Oliver Hunt. Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=23456
Function argument names leak

  • parser/Nodes.cpp: (JSC::FunctionBodyNode::~FunctionBodyNode): Destruct parameter names.
8:44 AM Changeset in webkit [40085] by Nikolas Zimmermann
  • 12 edits
    4 adds in trunk/WebCore

Reviewed by George Staikos.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=23444

Refactor some functionality from HTMLOption/OptGroupElement needed by RenderListBox/RenderMenuList
in two abstract base classes: OptionElement & OptionGroupElement living in dom/ - just like it
has been done before for FormControlElement and RenderTextControl.

This is needed to prepare the addtion of WMLOption/OptGroupElement.

7:22 AM QtWebKitJournal edited by Simon Hausmann
(diff)
7:22 AM QtWebKitJournal edited by Simon Hausmann
(diff)

Jan 20, 2009:

11:39 PM Changeset in webkit [40084] by Darin Adler
  • 2 edits in trunk/WebCore

2009-01-20 Darin Adler <Darin Adler>

Reviewed by Alexey Proskuryakov.

Bug 23448: memory leak in Mac version of preferredExtensionForImageSourceType
https://bugs.webkit.org/show_bug.cgi?id=23448

  • platform/graphics/cg/ImageSourceCGMac.mm: (WebCore::preferredExtensionForImageSourceType): Use RetainPtr to avoid the leak.
11:25 PM Changeset in webkit [40083] by Darin Adler
  • 2 edits in trunk/WebKitTools

2009-01-20 Darin Adler <Darin Adler>

Reviewed by Alexey Proskuryakov.

Bug 23450: string leaks seen in DumpRenderTree accessibility test code
https://bugs.webkit.org/show_bug.cgi?id=23450

  • DumpRenderTree/AccessibilityUIElement.cpp: (isAttributeSettableCallback): Add the missing JSStringRelease call. (attributeValueCallback): Ditto.
10:38 PM Changeset in webkit [40082] by Darin Adler
  • 2 edits in trunk/WebCore

2009-01-20 Darin Adler <Darin Adler>

Try to fix Wx build.

  • platform/wx/PasteboardWx.cpp: (WebCore::Pasteboard::writeSelection): Removed code that replaces backslash with backslashAsCurrencySymbol. I'm pretty sure this is not needed when writing to the clipboard. Other platforms don't do it. If it was needed, the new function to use would be displayStringModifiedByEncoding.
9:28 PM Changeset in webkit [40081] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

Teach Cairo post-build stage to copy animation headers.

8:49 PM Changeset in webkit [40080] by alp@webkit.org
  • 3 edits in trunk/WebCore

2009-01-20 Dmitry Titov <dimich@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=23413
Remove unused WebCore::setDeferringTimers()

  • platform/Timer.cpp: (WebCore::updateSharedTimer):
  • platform/Timer.h:
7:51 PM Changeset in webkit [40079] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix

7:19 PM Changeset in webkit [40078] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2009-01-20 David Hyatt <hyatt@apple.com>

Tighten up the type of RenderObject owned by RenderLayer to be a RenderBox. Rename m_object to
m_renderer to be consistent with the corresponding member function.

Reviewed by Jon Honeycutt

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::updateVisibilityStatus): (WebCore::RenderLayer::updateLayerPosition): (WebCore::RenderLayer::stackingContext): (WebCore::RenderLayer::enclosingPositionedAncestor): (WebCore::RenderLayer::enclosingTransformedAncestor): (WebCore::RenderLayer::isTransparent): (WebCore::RenderLayer::convertToLayerCoords): (WebCore::RenderLayer::scrollByRecursively): (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::scrollRectToVisible): (WebCore::RenderLayer::resize): (WebCore::RenderLayer::scrollbarCornerPresent): (WebCore::RenderLayer::createScrollbar): (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar): (WebCore::RenderLayer::positionOverflowControls): (WebCore::RenderLayer::computeScrollDimensions): (WebCore::RenderLayer::updateOverflowStatus): (WebCore::RenderLayer::updateScrollInfoAfterLayout): (WebCore::RenderLayer::paintOverflowControls): (WebCore::RenderLayer::paintScrollCorner): (WebCore::RenderLayer::paintResizer): (WebCore::RenderLayer::isPointInResizeControl): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::updateClipRects): (WebCore::RenderLayer::calculateClipRects): (WebCore::RenderLayer::calculateRects): (WebCore::RenderLayer::clearClipRects): (WebCore::RenderLayer::repaintIncludingDescendants): (WebCore::RenderLayer::styleChanged): (WebCore::RenderLayer::updateScrollCornerStyle): (WebCore::RenderLayer::updateResizerStyle):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::renderer): (WebCore::RenderLayer::hasReflection): (WebCore::RenderLayer::hasTransform):
5:59 PM Changeset in webkit [40077] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2009-01-20 David Hyatt <hyatt@apple.com>

Fix Mac build bustage from my selection changes. I forgot to implement the functions on RenderThemeMac
for returning the appropriate listbox selection colors.

Reviewed by Adele

  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::platformActiveListBoxSelectionForegroundColor): (WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor): (WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor):
5:53 PM Changeset in webkit [40076] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-01-20 Gavin Barraclough <barraclough@apple.com>

Reviewed by Mark Rowe.

Structure property table deleted offset maps are being leaked.
Probably shouldn't be doing that.

https://bugs.webkit.org/show_bug.cgi?id=23442

  • runtime/Structure.cpp: (JSC::Structure::~Structure):
4:30 PM Changeset in webkit [40075] by pol@apple.com
  • 3 edits in trunk/WebKitTools

2009-01-20 Pierre-Olivier Latour <pol@apple.com>

Reviewed by Darin Adler.

Print warning regarding display color profile change in run-webkit-tests instead of DRT.

https://bugs.webkit.org/show_bug.cgi?id=23392

  • DumpRenderTree/mac/PixelDumpSupportMac.mm: (setupMainDisplayColorProfile):
  • Scripts/run-webkit-tests:
3:31 PM Changeset in webkit [40074] by hyatt@apple.com
  • 8 edits in trunk/WebCore

Fix selection colors and focus rings on Windows.

3:25 PM Changeset in webkit [40073] by pol@apple.com
  • 3 edits in trunk/WebKitTools

2009-01-20 Pierre-Olivier Latour <pol@apple.com>

Reviewed by Darin Adler.

Changed run-webkit-tests to abort on the Mac if pixel tests are enabled and Perian is installed,
in order to avoid result differences in some media tests.

https://bugs.webkit.org/show_bug.cgi?id=22615

  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm:
2:35 PM Changeset in webkit [40072] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Attempt to fix gtk build

2:29 PM Changeset in webkit [40071] by Nikolas Zimmermann
  • 12 edits
    6 adds in trunk

Reviewed by George Staikos.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=23434

Add WML <input> element support - it required a lot of changes to the RenderText*/HTMLInput* code.
Now any language can provide <input>-style elements, without having to inherit from HTML* classes.

No WML specific features/attributes are handled so far. A follow-up patch will provide those bits.
Added very simple fast/wml/input.wml, just checking that input elements can be rendered properly now.
Detailed testcases will follow in conjunction with the WML specific attribute support.

1:54 PM Changeset in webkit [40070] by Darin Adler
  • 2 edits in trunk/WebCore

2009-01-20 Darin Adler <Darin Adler>

Reviewed by John Sullivan.

Remove a little dead code left over after the fix for
https://bugs.webkit.org/show_bug.cgi?id=11395, which
moved pointer-events from SVG to be shared with HTML.

  • css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue): Remove SVG's parsing of this property since it's handled in the non-SVG function now so we'll never get here.
1:54 PM Changeset in webkit [40069] by jchaffraix@webkit.org
  • 8 edits in trunk/WebCore

009-01-20 Julien Chaffraix <jchaffraix@webkit.org>

Reviewed by Darin Adler.

Bug 23438: Provide a default value to the .in file parser

Added the default value 1 as it simplifies some of
the format by removing some "=1" that were awkward.

This was suggested by Darin Adler as par of a previous
review.


  • bindings/scripts/InFilesParser.pm: When no value was entered (the second part of the split is undef), provide the default value.
  • html/HTMLAttributeNames.in: Removed unnecessary "=1".
  • html/HTMLTagNames.in: Ditto.
  • svg/svgattrs.in: Ditto.
  • svg/svgtags.in: Ditto.
  • svg/xlinkattrs.in: Ditto.
  • wml/WMLAttributeNames.in: Ditto.
1:41 PM Changeset in webkit [40068] by andersca@apple.com
  • 11 edits in trunk/WebCore

2009-01-20 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

  • bridge/c/c_class.cpp:
  • bridge/c/c_class.h: Get rid of CClass::name().


  • bridge/jni/jni_class.h: Get rid of JavaClass::name().


  • bridge/objc/objc_class.h:
  • bridge/objc/objc_class.mm: Get rid of ObjcClass::name().


  • bridge/objc/objc_instance.h: Get rid of supportsSetValueOfUndefinedField.


  • bridge/objc/objc_instance.mm: (ObjcInstance::setValueOfUndefinedField): Fold supportsSetValueOfUndefinedField into setValueOfUndefinedField.


  • bridge/runtime.cpp: Get rid of getValueOfField and setValueOfField.


  • bridge/runtime.h: (JSC::Bindings::Instance::setValueOfUndefinedField): Have this return a bool and get rid of supportsSetValueOfUndefinedField


  • bridge/runtime_object.cpp: (JSC::RuntimeObjectImp::fieldGetter): Call Field::valueFromInstance on the field.


(JSC::RuntimeObjectImp::put):
Call Field::setValueToInstance on the field.

1:29 PM Changeset in webkit [40067] by Nikolas Zimmermann
  • 6 edits in trunk/WebCore

Not reviewed. Forgot to land build changes for non-mac platforms.
Add InputElement.cpp & FormControlElement.cpp to build.

1:18 PM Changeset in webkit [40066] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

Fix last-minute regression, introduced by simplifying max length determination - by
clamping using min/max, negative maxLength values got broken.

1:02 PM Changeset in webkit [40065] by Nikolas Zimmermann
  • 9 edits
    3 adds in trunk/WebCore

Reviewed by Adam Roben.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=23433

Add InputElement abstraction, similar to the FormControlElement refactorization
done a month ago. The goal is to share as much code as possible between HTML/WMLInputElement.
In a previous patch the RenderTextControl class has been split-up in RenderTextControlSingle/MultiLine,
RenderTextControl itself only depends on FormControlElement, RenderTextControlSingleLine still
depends on HTMLInputElement directly -> change that and make it use the new InputElement abstraction.

A lot of code from HTMLInputElement now lives in InputElement, as static member functions - the
InputElement class itself is an abstract virtual class, just like ScriptElement. HTML/WMLInputElement
derive from InputElement, and hold a InputElementData member variable, that they pass to the
static functions in InputElement. The abstraction is equal to the one chosen for HTML/SVGScriptElement.

12:54 PM Changeset in webkit [40064] by pol@apple.com
  • 3 edits in trunk/LayoutTests

2009-01-20 Pierre-Olivier Latour <pol@apple.com>

Previously uploaded reference images were generated with Perian installed, which affected them
as explained in https://bugs.webkit.org/show_bug.cgi?id=22615.

  • platform/mac/media/video-zoom-expected.checksum:
  • platform/mac/media/video-zoom-expected.png:
11:52 AM Changeset in webkit [40063] by krit@webkit.org
  • 14 edits
    4 deletes in trunk

2009-01-20 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Make SVG pattern platform independent and remove platform code.

Make SVGPattern platform independent
https://bugs.webkit.org/show_bug.cgi?id=21205

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::applyStrokePattern): (WebCore::GraphicsContext::applyFillPattern): (WebCore::GraphicsContext::drawPath): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::strokeRect):
  • svg/graphics/SVGPaintServerPattern.cpp: (WebCore::SVGPaintServerPattern::SVGPaintServerPattern): (WebCore::SVGPaintServerPattern::~SVGPaintServerPattern): (WebCore::SVGPaintServerPattern::setup): (WebCore::SVGPaintServerPattern::renderPath): (WebCore::SVGPaintServerPattern::teardown):
  • svg/graphics/SVGPaintServerPattern.h:
  • svg/graphics/cairo/SVGPaintServerPatternCairo.cpp: Removed.
  • svg/graphics/cg/SVGPaintServerPatternCg.cpp: Removed.
  • svg/graphics/qt/SVGPaintServerPatternQt.cpp: Removed.
  • svg/graphics/skia/SVGPaintServerPatternSkia.cpp: Removed.

LayoutTests:

stroke-pattern is wrong and coords-units-01-b match the behavior of
batik and Firefox.

  • platform/mac/svg/W3C-SVG-1.1/coords-units-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
  • platform/mac/svg/custom/stroked-pattern-expected.checksum:
  • platform/mac/svg/custom/stroked-pattern-expected.png:
11:39 AM Changeset in webkit [40062] by darin@chromium.org
  • 1 edit
    6 adds in trunk/WebCore

2009-01-20 Darin Fisher <darin@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=23436
Upstream rendering/RenderThemeChromium*

  • rendering/RenderThemeChromiumGtk.cpp: Added.
  • rendering/RenderThemeChromiumGtk.h: Added.
  • rendering/RenderThemeChromiumMac.h: Added.
  • rendering/RenderThemeChromiumMac.mm: Added.
  • rendering/RenderThemeChromiumWin.cpp: Added.
  • rendering/RenderThemeChromiumWin.h: Added.
11:33 AM Changeset in webkit [40061] by andersca@apple.com
  • 9 edits
    2 adds in trunk/WebKit

WebKit:

2009-01-20 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add ProxyInstance files.


  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2009-01-19 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add and implement GetScriptableNPObject.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCGetScriptableNPObjectReply): Create a new reply struct and set it as the current reply.


(WKPCEvaluate):
Get rid of an unused variable.


  • Plugins/Hosted/NetscapePluginInstanceProxy.h: (WebKit::NetscapePluginInstanceProxy::Reply::): (WebKit::NetscapePluginInstanceProxy::GetScriptableNPObjectReply::GetScriptableNPObjectReply):
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::createBindingsInstance): Call _WKPHGetScriptableNPObject and wait for a reply.


  • Plugins/Hosted/ProxyInstance.h: Added.
  • Plugins/Hosted/ProxyInstance.mm: Added. Add empty files.


  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView JSC::Bindings::createPluginBindingsInstance:JSC::Bindings::]): Call NetscapePluginInstanceProxy::createBindingsInstance.


  • Plugins/Hosted/WebKitPluginClient.defs:
  • Plugins/Hosted/WebKitPluginHost.defs: Add new declarations.
10:38 AM Changeset in webkit [40060] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

2009-01-20 Darin Adler <Darin Adler>

  • runtime/StringPrototype.cpp: (JSC::substituteBackreferences): Add back the initialization to fix the build.
10:25 AM Changeset in webkit [40059] by Darin Adler
  • 15 edits in trunk

JavaScriptCore:

2009-01-20 Darin Adler <Darin Adler>

Reviewed by Mark Rowe.

Bug 23352: Turn on more compiler warnings in the Mac build
https://bugs.webkit.org/show_bug.cgi?id=23352

First patch: Fix some simple cases of various warnings.

  • pcre/pcre_compile.cpp: (jsRegExpCompile): Use const_cast to change const-ness.
  • runtime/StringPrototype.cpp: (JSC::substituteBackreferences): Remove unneeded initialization and use UChar instead of unsigned short for UTF-16 values.
  • wtf/dtoa.cpp: (WTF::strtod): Use const_cast to change const-ness.

WebCore:

2009-01-20 Darin Adler <Darin Adler>

Reviewed by Mark Rowe.

Bug 23352: Turn on more compiler warnings in the Mac build
https://bugs.webkit.org/show_bug.cgi?id=23352

First patch: Fix some simple cases of various warnings.

  • platform/DeprecatedPtrListImpl.cpp: (WebCore::DeprecatedPtrListImpl::insert): Use const_cast to change const-ness.
  • platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::containsCharacters): Ditto.
  • platform/text/PlatformString.h: Overload for short and unsigned short to avoid ambiguity leading to warnings.
  • platform/text/String.cpp: (WebCore::String::number): Implemented overloads.
  • platform/text/TextStream.cpp: (WebCore::TextStream::operator<<): Overload for bool to avoid ambiguity leading to warnings.
  • platform/text/TextStream.h: Ditto.
  • rendering/InlineFlowBox.h: Fix declaration that was specifying the wrong type.
  • svg/graphics/filters/cg/WKLinearTransferFilter.m: Fix stray characters after #endif that should be a comment instead.
  • svg/graphics/filters/cg/WKSpecularLightingFilter.h: Ditto.
  • xml/XPathPath.h: Remove unneeded redundant declaration.
9:44 AM Changeset in webkit [40058] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

Build fix for WML enabled builds, not reviewed.
Fix unused variable warning.

9:23 AM Changeset in webkit [40057] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

Build fix for WML enabled builds, not reviewed.
Rename 'continuation' to 'virtualContinuation'.

9:04 AM Changeset in webkit [40056] by oliver@apple.com
  • 4 edits in trunk/JavaScriptCore

Whoops, remove runtime/ByteArray references from .pri and .scons builds, update .bkl

Build fix.

8:57 AM Changeset in webkit [40055] by oliver@apple.com
  • 14 edits
    3 moves in trunk

Move runtime/ByteArray to wtf/ByteArray

RS=Dan Bernstein

8:06 AM Changeset in webkit [40054] by darin@chromium.org
  • 1 edit
    2 adds in trunk/WebCore

2009-01-20 Darin Fisher <darin@chromium.org>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=23391
Upstream plugins/chromium/

  • plugins/chromium: Added.
  • plugins/chromium/PluginDataChromium.cpp: Added.
4:26 AM Changeset in webkit [40053] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2009-01-20 Friedemann Kleint <Friedemann.Kleint@nokia.com>

Reviewed by Simon Hausmann.

Fix spelling error in QWebPage

Jan 19, 2009:

11:01 PM Changeset in webkit [40052] by sfalken@apple.com
  • 2 edits
    1 add in trunk/WebCore

Fix Windows release build.
Move SVG files into all-in-one file for Windows build.

  • WebCore.vcproj/WebCore.vcproj:
  • svg/SVGAllInOne.cpp: Added.
7:31 PM Changeset in webkit [40051] by Simon Fraser
  • 1 edit
    4 adds in trunk/LayoutTests

2009-01-19 Simon Fraser <Simon Fraser>

https://bugs.webkit.org/show_bug.cgi?id=18078

New testcases for transitions of shorthand properties.

  • transitions/shorthand-border-transitions-expected.txt: Added.
  • transitions/shorthand-border-transitions.html: Added.
  • transitions/shorthand-transitions-expected.txt: Added.
  • transitions/shorthand-transitions.html: Added.
7:14 PM Changeset in webkit [40050] by sfalken@apple.com
  • 3 edits in trunk/WebCore

Partial build fix.
Move new derived sources into all-in-one DerivedSources.cpp

  • DerivedSources.cpp:
  • WebCore.vcproj/WebCore.vcproj:
6:34 PM Changeset in webkit [40049] by weinig@apple.com
  • 2 edits in trunk/WebKitTools

2009-01-19 Sam Weinig <sam@webkit.org>

  • Scripts/do-webcore-rename: Add JSValuePtr and ProtectedJSValuePtr.
5:29 PM Changeset in webkit [40048] by weinig@apple.com
  • 3 edits in trunk/WebCore

2009-01-19 Sam Weinig <sam@webkit.org>

Fix Qt build.

  • bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::mark):
  • bridge/qt/qt_runtime.cpp: (JSC::Bindings::valueRealType): (JSC::Bindings::convertValueToQVariant): (JSC::Bindings::QtRuntimeConnectionMethod::call): (JSC::Bindings::QtConnectionObject::execute):
5:15 PM Changeset in webkit [40047] by weinig@apple.com
  • 2 edits in trunk/WebCore

2009-01-19 Sam Weinig <sam@webkit.org>

Fix wx build.

  • plugins/PluginView.cpp: (WebCore::getString):
4:54 PM Changeset in webkit [40046] by weinig@apple.com
  • 150 edits in trunk

JavaScriptCore:

2009-01-19 Sam Weinig <sam@webkit.org>

Rubber-stamped by Gavin Barraclough.

Remove temporary operator-> from JSValuePtr.

  • API/JSCallbackFunction.cpp: (JSC::JSCallbackFunction::call):
  • API/JSCallbackObjectFunctions.h: (JSC::::call): (JSC::::toNumber): (JSC::::toString):
  • API/JSObjectRef.cpp: (JSObjectSetPrototype):
  • API/JSValueRef.cpp: (JSValueGetType): (JSValueIsUndefined): (JSValueIsNull): (JSValueIsBoolean): (JSValueIsNumber): (JSValueIsString): (JSValueIsObject): (JSValueIsObjectOfClass): (JSValueToBoolean): (JSValueToNumber): (JSValueToStringCopy): (JSValueToObject):
  • bytecode/CodeBlock.cpp: (JSC::valueToSourceString): (JSC::CodeBlock::mark):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::isKnownNotImmediate):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitEqualityOp): (JSC::keyForImmediateSwitch):
  • interpreter/Interpreter.cpp: (JSC::jsLess): (JSC::jsLessEq): (JSC::jsAddSlowCase): (JSC::jsAdd): (JSC::jsTypeStringForValue): (JSC::jsIsObjectType): (JSC::jsIsFunctionType): (JSC::isNotObject): (JSC::Interpreter::callEval): (JSC::Interpreter::throwException): (JSC::cachePrototypeChain): (JSC::Interpreter::tryCachePutByID): (JSC::countPrototypeChainEntriesAndCheckForProxies): (JSC::Interpreter::tryCacheGetByID): (JSC::Interpreter::privateExecute): (JSC::Interpreter::tryCTICachePutByID): (JSC::Interpreter::tryCTICacheGetByID): (JSC::Interpreter::cti_op_convert_this): (JSC::Interpreter::cti_op_add): (JSC::Interpreter::cti_op_pre_inc): (JSC::Interpreter::cti_op_put_by_id_generic): (JSC::Interpreter::cti_op_get_by_id_generic): (JSC::Interpreter::cti_op_put_by_id): (JSC::Interpreter::cti_op_put_by_id_second): (JSC::Interpreter::cti_op_put_by_id_fail): (JSC::Interpreter::cti_op_get_by_id): (JSC::Interpreter::cti_op_get_by_id_second): (JSC::Interpreter::cti_op_get_by_id_self_fail): (JSC::Interpreter::cti_op_get_by_id_proto_list): (JSC::Interpreter::cti_op_get_by_id_proto_list_full): (JSC::Interpreter::cti_op_get_by_id_proto_fail): (JSC::Interpreter::cti_op_get_by_id_array_fail): (JSC::Interpreter::cti_op_get_by_id_string_fail): (JSC::Interpreter::cti_op_instanceof): (JSC::Interpreter::cti_op_del_by_id): (JSC::Interpreter::cti_op_mul): (JSC::Interpreter::cti_op_call_JSFunction): (JSC::Interpreter::cti_op_call_NotJSFunction): (JSC::Interpreter::cti_op_construct_JSConstruct): (JSC::Interpreter::cti_op_construct_NotJSConstruct): (JSC::Interpreter::cti_op_get_by_val): (JSC::Interpreter::cti_op_get_by_val_byte_array): (JSC::Interpreter::cti_op_sub): (JSC::Interpreter::cti_op_put_by_val): (JSC::Interpreter::cti_op_put_by_val_array): (JSC::Interpreter::cti_op_put_by_val_byte_array): (JSC::Interpreter::cti_op_loop_if_true): (JSC::Interpreter::cti_op_negate): (JSC::Interpreter::cti_op_div): (JSC::Interpreter::cti_op_pre_dec): (JSC::Interpreter::cti_op_not): (JSC::Interpreter::cti_op_jtrue): (JSC::Interpreter::cti_op_post_inc): (JSC::Interpreter::cti_op_lshift): (JSC::Interpreter::cti_op_bitand): (JSC::Interpreter::cti_op_rshift): (JSC::Interpreter::cti_op_bitnot): (JSC::Interpreter::cti_op_mod): (JSC::Interpreter::cti_op_post_dec): (JSC::Interpreter::cti_op_urshift): (JSC::Interpreter::cti_op_bitxor): (JSC::Interpreter::cti_op_bitor): (JSC::Interpreter::cti_op_push_scope): (JSC::Interpreter::cti_op_is_undefined): (JSC::Interpreter::cti_op_is_boolean): (JSC::Interpreter::cti_op_is_number): (JSC::Interpreter::cti_op_to_jsnumber): (JSC::Interpreter::cti_op_in): (JSC::Interpreter::cti_op_put_by_index): (JSC::Interpreter::cti_op_switch_imm): (JSC::Interpreter::cti_op_switch_char): (JSC::Interpreter::cti_op_switch_string): (JSC::Interpreter::cti_op_del_by_val): (JSC::Interpreter::cti_op_put_getter): (JSC::Interpreter::cti_op_put_setter): (JSC::Interpreter::cti_op_new_error):
  • interpreter/Interpreter.h: (JSC::Interpreter::isJSArray): (JSC::Interpreter::isJSString): (JSC::Interpreter::isJSByteArray):
  • interpreter/Register.h: (JSC::Register::marked): (JSC::Register::mark):
  • jit/JITInlineMethods.h: (JSC::JIT::getConstantOperandImmediateInt): (JSC::JIT::isOperandConstantImmediateInt):
  • jsc.cpp: (functionPrint): (functionDebug): (functionRun): (functionLoad): (runWithScripts): (runInteractive):
  • parser/Nodes.cpp: (JSC::processClauseList):
  • profiler/ProfileGenerator.cpp: (JSC::ProfileGenerator::addParentForConsoleStart):
  • profiler/Profiler.cpp: (JSC::Profiler::createCallIdentifier):
  • runtime/ArrayConstructor.cpp: (JSC::constructArrayWithSizeQuirk):
  • runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncToString): (JSC::arrayProtoFuncToLocaleString): (JSC::arrayProtoFuncJoin): (JSC::arrayProtoFuncConcat): (JSC::arrayProtoFuncPop): (JSC::arrayProtoFuncPush): (JSC::arrayProtoFuncReverse): (JSC::arrayProtoFuncShift): (JSC::arrayProtoFuncSlice): (JSC::arrayProtoFuncSort): (JSC::arrayProtoFuncSplice): (JSC::arrayProtoFuncUnShift): (JSC::arrayProtoFuncFilter): (JSC::arrayProtoFuncMap): (JSC::arrayProtoFuncEvery): (JSC::arrayProtoFuncForEach): (JSC::arrayProtoFuncSome): (JSC::arrayProtoFuncIndexOf): (JSC::arrayProtoFuncLastIndexOf):
  • runtime/BooleanConstructor.cpp: (JSC::constructBoolean): (JSC::callBooleanConstructor):
  • runtime/BooleanPrototype.cpp: (JSC::booleanProtoFuncToString): (JSC::booleanProtoFuncValueOf):
  • runtime/Collector.cpp: (JSC::Heap::protect): (JSC::Heap::unprotect): (JSC::Heap::heap): (JSC::Heap::collect): (JSC::typeName):
  • runtime/Completion.cpp: (JSC::evaluate):
  • runtime/DateConstructor.cpp: (JSC::constructDate): (JSC::dateParse): (JSC::dateUTC):
  • runtime/DateInstance.h: (JSC::DateInstance::internalNumber):
  • runtime/DatePrototype.cpp: (JSC::formatLocaleDate): (JSC::fillStructuresUsingTimeArgs): (JSC::fillStructuresUsingDateArgs): (JSC::dateProtoFuncToString): (JSC::dateProtoFuncToUTCString): (JSC::dateProtoFuncToDateString): (JSC::dateProtoFuncToTimeString): (JSC::dateProtoFuncToLocaleString): (JSC::dateProtoFuncToLocaleDateString): (JSC::dateProtoFuncToLocaleTimeString): (JSC::dateProtoFuncGetTime): (JSC::dateProtoFuncGetFullYear): (JSC::dateProtoFuncGetUTCFullYear): (JSC::dateProtoFuncToGMTString): (JSC::dateProtoFuncGetMonth): (JSC::dateProtoFuncGetUTCMonth): (JSC::dateProtoFuncGetDate): (JSC::dateProtoFuncGetUTCDate): (JSC::dateProtoFuncGetDay): (JSC::dateProtoFuncGetUTCDay): (JSC::dateProtoFuncGetHours): (JSC::dateProtoFuncGetUTCHours): (JSC::dateProtoFuncGetMinutes): (JSC::dateProtoFuncGetUTCMinutes): (JSC::dateProtoFuncGetSeconds): (JSC::dateProtoFuncGetUTCSeconds): (JSC::dateProtoFuncGetMilliSeconds): (JSC::dateProtoFuncGetUTCMilliseconds): (JSC::dateProtoFuncGetTimezoneOffset): (JSC::dateProtoFuncSetTime): (JSC::setNewValueFromTimeArgs): (JSC::setNewValueFromDateArgs): (JSC::dateProtoFuncSetYear): (JSC::dateProtoFuncGetYear):
  • runtime/ErrorConstructor.cpp: (JSC::constructError):
  • runtime/ErrorPrototype.cpp: (JSC::errorProtoFuncToString):
  • runtime/ExceptionHelpers.cpp: (JSC::createError): (JSC::createErrorMessage):
  • runtime/FunctionConstructor.cpp: (JSC::constructFunction):
  • runtime/FunctionPrototype.cpp: (JSC::functionProtoFuncToString): (JSC::functionProtoFuncApply): (JSC::functionProtoFuncCall):
  • runtime/GetterSetter.cpp: (JSC::GetterSetter::toObject):
  • runtime/JSActivation.cpp: (JSC::JSActivation::getOwnPropertySlot):
  • runtime/JSArray.cpp: (JSC::JSArray::put): (JSC::JSArray::mark): (JSC::JSArray::sort): (JSC::AVLTreeAbstractorForArrayCompare::compare_key_key): (JSC::JSArray::compactForSorting):
  • runtime/JSByteArray.h: (JSC::JSByteArray::setIndex):
  • runtime/JSCell.h: (JSC::asCell):
  • runtime/JSFunction.cpp: (JSC::JSFunction::call): (JSC::JSFunction::construct):
  • runtime/JSGlobalObject.cpp: (JSC::markIfNeeded): (JSC::lastInPrototypeChain):
  • runtime/JSGlobalObjectFunctions.cpp: (JSC::encode): (JSC::decode): (JSC::globalFuncEval): (JSC::globalFuncParseInt): (JSC::globalFuncParseFloat): (JSC::globalFuncIsNaN): (JSC::globalFuncIsFinite): (JSC::globalFuncEscape): (JSC::globalFuncUnescape): (JSC::globalFuncJSCPrint):
  • runtime/JSImmediate.cpp: (JSC::JSImmediate::toThisObject): (JSC::JSImmediate::toObject): (JSC::JSImmediate::prototype): (JSC::JSImmediate::toString):
  • runtime/JSImmediate.h:
  • runtime/JSObject.cpp: (JSC::JSObject::mark): (JSC::JSObject::put): (JSC::callDefaultValueFunction): (JSC::JSObject::getPrimitiveNumber): (JSC::JSObject::defineGetter): (JSC::JSObject::defineSetter): (JSC::JSObject::lookupGetter): (JSC::JSObject::lookupSetter): (JSC::JSObject::hasInstance): (JSC::JSObject::toNumber): (JSC::JSObject::toString):
  • runtime/JSObject.h: (JSC::JSObject::JSObject): (JSC::JSObject::inlineGetOwnPropertySlot): (JSC::JSObject::getOwnPropertySlotForWrite): (JSC::JSObject::getPropertySlot): (JSC::JSValuePtr::get):
  • runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::create):
  • runtime/JSString.cpp: (JSC::JSString::getOwnPropertySlot):
  • runtime/JSValue.h:
  • runtime/JSWrapperObject.cpp: (JSC::JSWrapperObject::mark):
  • runtime/JSWrapperObject.h: (JSC::JSWrapperObject::setInternalValue):
  • runtime/MathObject.cpp: (JSC::mathProtoFuncAbs): (JSC::mathProtoFuncACos): (JSC::mathProtoFuncASin): (JSC::mathProtoFuncATan): (JSC::mathProtoFuncATan2): (JSC::mathProtoFuncCeil): (JSC::mathProtoFuncCos): (JSC::mathProtoFuncExp): (JSC::mathProtoFuncFloor): (JSC::mathProtoFuncLog): (JSC::mathProtoFuncMax): (JSC::mathProtoFuncMin): (JSC::mathProtoFuncPow): (JSC::mathProtoFuncRound): (JSC::mathProtoFuncSin): (JSC::mathProtoFuncSqrt): (JSC::mathProtoFuncTan):
  • runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::NativeErrorConstructor): (JSC::NativeErrorConstructor::construct):
  • runtime/NumberConstructor.cpp: (JSC::constructWithNumberConstructor): (JSC::callNumberConstructor):
  • runtime/NumberPrototype.cpp: (JSC::numberProtoFuncToString): (JSC::numberProtoFuncToLocaleString): (JSC::numberProtoFuncValueOf): (JSC::numberProtoFuncToFixed): (JSC::numberProtoFuncToExponential): (JSC::numberProtoFuncToPrecision):
  • runtime/ObjectConstructor.cpp: (JSC::constructObject):
  • runtime/ObjectPrototype.cpp: (JSC::objectProtoFuncValueOf): (JSC::objectProtoFuncHasOwnProperty): (JSC::objectProtoFuncIsPrototypeOf): (JSC::objectProtoFuncDefineGetter): (JSC::objectProtoFuncDefineSetter): (JSC::objectProtoFuncLookupGetter): (JSC::objectProtoFuncLookupSetter): (JSC::objectProtoFuncPropertyIsEnumerable): (JSC::objectProtoFuncToLocaleString): (JSC::objectProtoFuncToString):
  • runtime/Operations.h: (JSC::JSValuePtr::equalSlowCaseInline): (JSC::JSValuePtr::strictEqual): (JSC::JSValuePtr::strictEqualSlowCaseInline):
  • runtime/Protect.h: (JSC::gcProtect): (JSC::gcUnprotect):
  • runtime/RegExpConstructor.cpp: (JSC::setRegExpConstructorInput): (JSC::setRegExpConstructorMultiline): (JSC::constructRegExp):
  • runtime/RegExpObject.cpp: (JSC::setRegExpObjectLastIndex): (JSC::RegExpObject::match):
  • runtime/RegExpPrototype.cpp: (JSC::regExpProtoFuncTest): (JSC::regExpProtoFuncExec): (JSC::regExpProtoFuncCompile): (JSC::regExpProtoFuncToString):
  • runtime/StringConstructor.cpp: (JSC::stringFromCharCodeSlowCase): (JSC::stringFromCharCode): (JSC::constructWithStringConstructor): (JSC::callStringConstructor):
  • runtime/StringPrototype.cpp: (JSC::stringProtoFuncReplace): (JSC::stringProtoFuncToString): (JSC::stringProtoFuncCharAt): (JSC::stringProtoFuncCharCodeAt): (JSC::stringProtoFuncConcat): (JSC::stringProtoFuncIndexOf): (JSC::stringProtoFuncLastIndexOf): (JSC::stringProtoFuncMatch): (JSC::stringProtoFuncSearch): (JSC::stringProtoFuncSlice): (JSC::stringProtoFuncSplit): (JSC::stringProtoFuncSubstr): (JSC::stringProtoFuncSubstring): (JSC::stringProtoFuncToLowerCase): (JSC::stringProtoFuncToUpperCase): (JSC::stringProtoFuncLocaleCompare): (JSC::stringProtoFuncBig): (JSC::stringProtoFuncSmall): (JSC::stringProtoFuncBlink): (JSC::stringProtoFuncBold): (JSC::stringProtoFuncFixed): (JSC::stringProtoFuncItalics): (JSC::stringProtoFuncStrike): (JSC::stringProtoFuncSub): (JSC::stringProtoFuncSup): (JSC::stringProtoFuncFontcolor): (JSC::stringProtoFuncFontsize): (JSC::stringProtoFuncAnchor): (JSC::stringProtoFuncLink):
  • runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::getEnumerablePropertyNames): (JSC::Structure::createCachedPrototypeChain):
  • runtime/Structure.h: (JSC::Structure::mark):
  • runtime/StructureChain.cpp: (JSC::StructureChain::StructureChain):

JavaScriptGlue:

2009-01-19 Sam Weinig <sam@webkit.org>

Rubber-stamped by Gavin Barraclough.

Remove temporary operator-> from JSValuePtr.

  • JSUtils.cpp: (KJSValueToJSObject): (KJSValueToCFTypeInternal):
  • JSValueWrapper.cpp: (JSValueWrapper::JSObjectCopyPropertyNames): (JSValueWrapper::JSObjectCopyProperty): (JSValueWrapper::JSObjectSetProperty): (JSValueWrapper::JSObjectCallFunction): (JSValueWrapper::JSObjectMark):
  • UserObjectImp.cpp: (UserObjectImp::getOwnPropertySlot):

WebCore:

2009-01-19 Sam Weinig <sam@webkit.org>

Rubber-stamped by Gavin Barraclough.

Remove temporary operator-> from JSValuePtr.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSAudioConstructor.cpp: (WebCore::constructAudio):
  • bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::toHTMLCanvasStyle): (WebCore::JSCanvasRenderingContext2D::setFillColor): (WebCore::JSCanvasRenderingContext2D::setStrokeColor): (WebCore::JSCanvasRenderingContext2D::strokeRect): (WebCore::JSCanvasRenderingContext2D::drawImage): (WebCore::JSCanvasRenderingContext2D::drawImageFromRect): (WebCore::JSCanvasRenderingContext2D::setShadow): (WebCore::JSCanvasRenderingContext2D::createPattern): (WebCore::JSCanvasRenderingContext2D::putImageData): (WebCore::JSCanvasRenderingContext2D::fillText): (WebCore::JSCanvasRenderingContext2D::strokeText):
  • bindings/js/JSClipboardCustom.cpp: (WebCore::JSClipboard::clearData): (WebCore::JSClipboard::getData): (WebCore::JSClipboard::setData): (WebCore::JSClipboard::setDragImage):
  • bindings/js/JSCustomPositionCallback.cpp: (WebCore::JSCustomPositionCallback::handleEvent):
  • bindings/js/JSCustomPositionErrorCallback.cpp: (WebCore::JSCustomPositionErrorCallback::handleEvent):
  • bindings/js/JSCustomSQLStatementCallback.cpp: (WebCore::JSCustomSQLStatementCallback::handleEvent):
  • bindings/js/JSCustomSQLStatementErrorCallback.cpp: (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
  • bindings/js/JSCustomSQLTransactionCallback.cpp: (WebCore::JSCustomSQLTransactionCallback::handleEvent):
  • bindings/js/JSCustomSQLTransactionErrorCallback.cpp: (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
  • bindings/js/JSCustomVoidCallback.cpp: (WebCore::JSCustomVoidCallback::handleEvent): (WebCore::toVoidCallback):
  • bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::create): (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
  • bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::hasItem): (WebCore::JSDOMApplicationCache::add): (WebCore::JSDOMApplicationCache::remove): (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener):
  • bindings/js/JSDOMBinding.cpp: (WebCore::valueToStringWithNullCheck): (WebCore::valueToStringWithUndefinedOrNullCheck): (WebCore::reportException):
  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::findJSEventListener): (WebCore::JSDOMGlobalObject::findOrCreateJSEventListener): (WebCore::JSDOMGlobalObject::findJSUnprotectedEventListener): (WebCore::JSDOMGlobalObject::findOrCreateJSUnprotectedEventListener):
  • bindings/js/JSDOMStringListCustom.cpp: (WebCore::JSDOMStringList::item):
  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::getOwnPropertySlot): (windowProtoFuncOpen): (WebCore::toJSDOMWindow):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): (WebCore::JSDOMWindow::postMessage): (WebCore::setTimeoutOrInterval): (WebCore::JSDOMWindow::clearTimeout): (WebCore::JSDOMWindow::clearInterval): (WebCore::JSDOMWindow::atob): (WebCore::JSDOMWindow::btoa): (WebCore::JSDOMWindow::addEventListener): (WebCore::JSDOMWindow::removeEventListener): (WebCore::toDOMWindow):
  • bindings/js/JSDatabaseCustom.cpp: (WebCore::JSDatabase::changeVersion): (WebCore::JSDatabase::transaction):
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::setLocation):
  • bindings/js/JSElementCustom.cpp: (WebCore::JSElement::setAttribute): (WebCore::JSElement::setAttributeNS):
  • bindings/js/JSEventListener.cpp: (WebCore::JSAbstractEventListener::handleEvent): (WebCore::JSLazyEventListener::parseCode):
  • bindings/js/JSEventTargetNodeCustom.cpp: (WebCore::JSEventTargetNode::addEventListener): (WebCore::JSEventTargetNode::removeEventListener):
  • bindings/js/JSGeolocationCustom.cpp: (WebCore::createPositionOptions): (WebCore::JSGeolocation::getCurrentPosition): (WebCore::JSGeolocation::watchPosition):
  • bindings/js/JSHTMLCollectionCustom.cpp: (WebCore::callHTMLCollection): (WebCore::JSHTMLCollection::canGetItemsForName): (WebCore::JSHTMLCollection::item): (WebCore::JSHTMLCollection::namedItem):
  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::open): (WebCore::writeHelper):
  • bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::setLength): (WebCore::JSHTMLOptionsCollection::add):
  • bindings/js/JSHTMLSelectElementCustom.cpp: (WebCore::JSHTMLSelectElement::remove): (WebCore::selectIndexSetter):
  • bindings/js/JSImageConstructor.cpp: (WebCore::constructImage):
  • bindings/js/JSInspectedObjectWrapper.cpp: (WebCore::JSInspectedObjectWrapper::wrap): (WebCore::JSInspectedObjectWrapper::prepareIncomingValue):
  • bindings/js/JSInspectorCallbackWrapper.cpp: (WebCore::JSInspectorCallbackWrapper::wrap):
  • bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::evaluate):
  • bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::setHref): (WebCore::JSLocation::setProtocol): (WebCore::JSLocation::setHost): (WebCore::JSLocation::setHostname): (WebCore::JSLocation::setPort): (WebCore::JSLocation::setPathname): (WebCore::JSLocation::setSearch): (WebCore::JSLocation::setHash): (WebCore::JSLocation::replace): (WebCore::JSLocation::assign):
  • bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::mark):
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::startConversation): (WebCore::JSMessagePort::addEventListener): (WebCore::JSMessagePort::removeEventListener):
  • bindings/js/JSNodeFilterCondition.cpp: (WebCore::JSNodeFilterCondition::mark): (WebCore::JSNodeFilterCondition::acceptNode):
  • bindings/js/JSNodeFilterCondition.h:
  • bindings/js/JSNodeFilterCustom.cpp: (WebCore::toNodeFilter):
  • bindings/js/JSNodeListCustom.cpp: (WebCore::callNodeList):
  • bindings/js/JSOptionConstructor.cpp: (WebCore::constructHTMLOptionElement):
  • bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::asWrapper): (WebCore::JSQuarantinedObjectWrapper::construct):
  • bindings/js/JSSQLResultSetRowListCustom.cpp: (WebCore::JSSQLResultSetRowList::item):
  • bindings/js/JSSQLTransactionCustom.cpp: (WebCore::JSSQLTransaction::executeSql):
  • bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::addEventListener): (WebCore::JSSVGElementInstance::removeEventListener):
  • bindings/js/JSSVGLengthCustom.cpp: (WebCore::JSSVGLength::convertToSpecifiedUnits):
  • bindings/js/JSSVGMatrixCustom.cpp: (WebCore::JSSVGMatrix::translate): (WebCore::JSSVGMatrix::scale): (WebCore::JSSVGMatrix::scaleNonUniform): (WebCore::JSSVGMatrix::rotate): (WebCore::JSSVGMatrix::rotateFromVector): (WebCore::JSSVGMatrix::skewX): (WebCore::JSSVGMatrix::skewY):
  • bindings/js/JSSVGPathSegListCustom.cpp: (WebCore::JSSVGPathSegList::getItem): (WebCore::JSSVGPathSegList::insertItemBefore): (WebCore::JSSVGPathSegList::replaceItem): (WebCore::JSSVGPathSegList::removeItem):
  • bindings/js/JSSVGPointListCustom.cpp: (WebCore::JSSVGPointList::getItem): (WebCore::JSSVGPointList::insertItemBefore): (WebCore::JSSVGPointList::replaceItem): (WebCore::JSSVGPointList::removeItem):
  • bindings/js/JSSVGTransformListCustom.cpp: (WebCore::JSSVGTransformList::getItem): (WebCore::JSSVGTransformList::insertItemBefore): (WebCore::JSSVGTransformList::replaceItem): (WebCore::JSSVGTransformList::removeItem):
  • bindings/js/JSStorageCustom.cpp: (WebCore::JSStorage::deleteProperty): (WebCore::JSStorage::customPut):
  • bindings/js/JSWebKitCSSMatrixConstructor.cpp: (WebCore::constructWebKitCSSMatrix):
  • bindings/js/JSWorkerConstructor.cpp: (WebCore::constructWorker):
  • bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::addEventListener): (WebCore::JSWorkerContext::removeEventListener):
  • bindings/js/JSWorkerCustom.cpp: (WebCore::JSWorker::addEventListener): (WebCore::JSWorker::removeEventListener):
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::open): (WebCore::JSXMLHttpRequest::setRequestHeader): (WebCore::JSXMLHttpRequest::send): (WebCore::JSXMLHttpRequest::getResponseHeader): (WebCore::JSXMLHttpRequest::overrideMimeType): (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener):
  • bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener):
  • bindings/js/JSXSLTProcessorCustom.cpp: (WebCore::JSXSLTProcessor::importStylesheet): (WebCore::JSXSLTProcessor::transformToFragment): (WebCore::JSXSLTProcessor::transformToDocument): (WebCore::JSXSLTProcessor::setParameter): (WebCore::JSXSLTProcessor::getParameter): (WebCore::JSXSLTProcessor::removeParameter):
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::executeFunctionInContext):
  • bindings/js/ScriptCallStack.cpp: (WebCore::ScriptCallStack::initialize):
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::createScriptObjectForPluginElement):
  • bindings/js/ScriptValue.cpp: (WebCore::ScriptValue::getString): (WebCore::ScriptValue::isNull): (WebCore::ScriptValue::isUndefined):
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/NP_jsobject.cpp: (_NPN_InvokeDefault): (_NPN_Invoke): (_NPN_HasMethod): (_NPN_Construct):
  • bridge/c/c_utility.cpp: (JSC::Bindings::convertValueToNPVariant):
  • bridge/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
  • bridge/jni/jni_jsobject.mm: (JavaJSObject::call): (JavaJSObject::convertValueToJObject):
  • bridge/jni/jni_runtime.cpp: (JavaField::dispatchValueFromInstance): (JavaField::valueFromInstance): (JavaField::dispatchSetValueToInstance): (JavaField::setValueToInstance):
  • bridge/jni/jni_utility.cpp: (JSC::Bindings::convertArrayInstanceToJavaArray): (JSC::Bindings::convertValueToJValue):
  • bridge/objc/objc_runtime.mm: (JSC::Bindings::callObjCFallbackObject):
  • bridge/objc/objc_utility.mm: (JSC::Bindings::convertValueToObjcValue):
  • bridge/runtime_method.cpp: (JSC::callRuntimeMethod):
  • bridge/runtime_object.cpp: (JSC::RuntimeObjectImp::getOwnPropertySlot): (JSC::callRuntimeConstructor):

WebKit/mac:

2009-01-19 Sam Weinig <sam@webkit.org>

Rubber-stamped by Gavin Barraclough.

Remove temporary operator-> from JSValuePtr.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::invoke): (WebKit::NetscapePluginInstanceProxy::hasMethod): (WebKit::NetscapePluginInstanceProxy::marshalValue):
  • WebView/WebFrame.mm: (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
  • WebView/WebView.mm: (aeDescFromJSValue):

WebKit/win:

2009-01-19 Sam Weinig <sam@webkit.org>

Rubber-stamped by Gavin Barraclough.

Remove temporary operator-> from JSValuePtr.

  • WebScriptCallFrame.cpp: (WebScriptCallFrame::jsValueToString):
  • WebView.cpp: (WebView::stringByEvaluatingJavaScriptFromString):

WebKit/wx:

2009-01-19 Sam Weinig <sam@webkit.org>

Rubber-stamped by Gavin Barraclough.

Remove temporary operator-> from JSValuePtr.

  • WebFrame.cpp: (wxWebFrame::RunScript):
4:33 PM Changeset in webkit [40045] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

2009-01-19 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Make Evaluate an asynchronous method that has a reply method.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCEvaluate):
  • Plugins/Hosted/WebKitPluginClient.defs:
  • Plugins/Hosted/WebKitPluginHost.defs:
4:27 PM Changeset in webkit [40044] by christian@webkit.org
  • 2 edits in trunk/WebCore

2009-01-20 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Mark Rowe.

https://bugs.webkit.org/show_bug.cgi?id=23419
removal of FramePrivate.h breaks GTK+'s make dist

  • GNUmakefile.am: No longer mention FramePrivate.h in our build, since it was removed.
4:16 PM Changeset in webkit [40043] by christian@webkit.org
  • 2 edits in trunk/WebCore

2009-01-20 Alexander V. Butenko <alex@digiqube.com>

Reviewed by Holger Freyther.

http://bugs.webkit.org/show_bug.cgi?id=23116
[GTK] Fix crash due a callback called from GIO after the
destruction of the ResourceHandle

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandle::cancel): Only call didFinishLoading if 'client' is set, otherwise cancelling a load could lead to a crash.
3:33 PM Changeset in webkit [40042] by Darin Adler
  • 5 edits in trunk

JavaScriptCore:

2009-01-19 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Bug 23409: REGRESSION: RegExp 'replace()' function improperly processes '$$'
<https://bugs.webkit.org/show_bug.cgi?id=23409>
<rdar://problem/6505723>

Test: fast/js/string-replace-3.html

  • runtime/StringPrototype.cpp: (JSC::substituteBackreferences): Remove code that adds an extra $ -- not sure how this ever worked.

LayoutTests:

2009-01-19 Darin Adler <Darin Adler>

Reviewed by Sam Weinig.

Bug 23409: REGRESSION: RegExp 'replace()' function improperly processes '$$'
<https://bugs.webkit.org/show_bug.cgi?id=23409>
<rdar://problem/6505723>

  • fast/js/resources/string-replace-3.js:
  • fast/js/string-replace-3-expected.txt:
3:22 PM Changeset in webkit [40041] by Simon Fraser
  • 1 edit in trunk/WebCore/ChangeLog

ChangeLog typo fix.

3:20 PM Changeset in webkit [40040] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-01-19 Simon Fraser <Simon Fraser>

Build fix: remove duplicate entries in the Xcode project, and
sort the project with ort-Xcode-project-file .

  • WebCore.xcodeproj/project.pbxproj:
2:23 PM Changeset in webkit [40039] by Simon Fraser
  • 16 edits
    2 adds in trunk

2009-01-19 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

https://bugs.webkit.org/show_bug.cgi?id=18078

Support animations and transitions of shorthand properties by creating
PropertyWrappers that simply wrap a vector of atomci wrappers, and implement
equal() and blend(). Build that collection of shorthand wrappers using the
shorthand map that CSSMutableStyleDeclaration already has. Skip comparing these
shorthand wrappers during 'all' transitions.

2:16 PM Changeset in webkit [40038] by oliver@apple.com
  • 1 edit
    1 add in trunk/WebCore

Actually add the new header.

2:09 PM Changeset in webkit [40037] by oliver@apple.com
  • 15 edits in trunk/WebCore

2009-01-19 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=22720

Provide a generic class to handle the pattern of task callbacks across worker/parent threads. It
only works for methods that need 6 parameters but similar classes could be added as needed for
other numbers of parameters.

Add addMessage and resourceRetrievedByXMLHttpRequest to ScriptExecutionContext.

Use these methods and others to remove document() from XMLHttpRequest in a few more places.

No observable change in behavior, so no test.

1:43 PM Changeset in webkit [40036] by beidson@apple.com
  • 2 edits in trunk/WebKit/mac

2009-01-19 Brady Eidson <beidson@apple.com>

Rubberstamped by Tim Hatcher

Fix long standing typo.

  • History/WebBackForwardList.h:
12:55 PM Changeset in webkit [40035] by Adam Roben
  • 2 edits in trunk/WebKitSite

Add links to some recommended Visual Studio hotfixes

Reviewed by Dave Hyatt.

  • building/tools.html:
12:51 PM Changeset in webkit [40034] by ap@webkit.org
  • 2 edits in trunk/LayoutTests

Update test results for https://bugs.webkit.org/show_bug.cgi?id=23417.

  • fast/dom/Window/window-properties-expected.txt:
12:31 PM Changeset in webkit [40033] by Chris Fleizach
  • 7 edits
    2 adds in trunk

Bug 23422: AX: AXLinks should expose access key information
https://bugs.webkit.org/show_bug.cgi?id=23422

11:15 AM Changeset in webkit [40032] by ap@webkit.org
  • 14 edits
    4 adds in trunk

Reviewed by Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=23417
Implement application cache obsolete state

Test: http/tests/appcache/remove-cache.html

  • bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::mark):
  • dom/EventNames.h:
  • loader/appcache/DOMApplicationCache.h: (WebCore::DOMApplicationCache::Status): (WebCore::DOMApplicationCache::setOnobsolete): (WebCore::DOMApplicationCache::onobsolete):
  • loader/appcache/DOMApplicationCache.idl: Added "obsolete" event and status.
  • loader/appcache/ApplicationCacheGroup.h: (WebCore::ApplicationCacheGroup::savedNewestCachePointer): Removed, there is no longer any need to track what the newest cache was during teardown. (WebCore::ApplicationCacheGroup::updateStatus): Renamed Status to UpdateStatus, reducing confusion with cache group lifecycle status. (WebCore::ApplicationCacheGroup::m_isObsolete): Added an obsolete state flag.
  • loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::ApplicationCacheGroup): Initialize m_isObsolete. (WebCore::ApplicationCacheGroup::cacheForMainRequest): Assert that the returned cache does not belong to an obsolete group. (WebCore::ApplicationCacheGroup::fallbackCacheForMainRequest): Ditto. (WebCore::ApplicationCacheGroup::disassociateDocumentLoader): Disassociation can now happen via a JS swapCache() call, not only when the loader is destroyed. (WebCore::ApplicationCacheGroup::cacheDestroyed): Don't track m_savedNewestCachePointer. (WebCore::ApplicationCacheGroup::setNewestCache): Remove old newest cache from storage is a caller responsibility, because this method is also used when loading caches from disk. (WebCore::ApplicationCacheGroup::makeObsolete): Added. Mark the cache group as obsolete, and inform cache storage, so that it could be removed. (WebCore::ApplicationCacheGroup::didFailToLoadManifest): Removed, as all this method did was call cacheUpdateFailed(). (WebCore::ApplicationCacheGroup::didReceiveResponse): Added a FIXME about correct failure handing. (WebCore::ApplicationCacheGroup::didFail): Ditto. (WebCore::ApplicationCacheGroup::didReceiveManifestResponse): Call a new manifestNotFound() method for 404 and 410 responses. (WebCore::ApplicationCacheGroup::didFinishLoadingManifest): Call cacheUpdateFailed() directly, instead of the removed didFailToLoadManifest(). (WebCore::ApplicationCacheGroup::manifestNotFound): Implement "remove a cache" algorithm. (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete): Remove superceded cache from storage after update successfully finishes (moved from setNewestCache()). (WebCore::ApplicationCacheGroup::associateDocumentLoaderWithCache): Revive the group using an explicitly passed pointer, without the need to save it during teardown.
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::~DocumentLoader): Call the general ApplicationCacheGroup::disassociateDocumentLoader() method.
  • loader/appcache/ApplicationCacheStorage.h: Added a cacheGroupMadeObsolete() method, updated some comments.
  • loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::cacheGroupForURL): Assert that iterated caches are not obsolete. (WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL): Ditto. (WebCore::ApplicationCacheStorage::cacheGroupDestroyed): Don't do anything for obsolete groups, as they cannot be in storage. (WebCore::ApplicationCacheStorage::cacheGroupMadeObsolete): Remove the cache group from storage completely, so that a new one could replace it, if necessary. (WebCore::ApplicationCacheStorage::storeNewestCache): Added assertions. (WebCore::ApplicationCacheStorage::remove): Remove cache group if its newest cache is removed.
  • loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::status): Added support for OBSOLETE state. (WebCore::DOMApplicationCache::swapCache): Disassociate document loader from cache if the application was removed server-side. (WebCore::DOMApplicationCache::callObsoleteListener): Added support for obsolete event.
  • loader/appcache/DOMApplicationCache.h: (WebCore::DOMApplicationCache::Status): (WebCore::DOMApplicationCache::setOnobsolete): (WebCore::DOMApplicationCache::onobsolete): Added support for OBSOLETE state and obsolete event.
  • loader/appcache/DOMApplicationCache.idl: Ditto.
11:05 AM Changeset in webkit [40031] by andersca@apple.com
  • 2 edits in trunk/WebCore

2009-01-19 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Allow plug-in views to return an instance directly.


  • bindings/js/ScriptControllerMac.mm: (WebCore::ScriptController::createScriptInstanceForWidget):
10:18 AM Changeset in webkit [40030] by Chris Fleizach
  • 3 edits
    2 adds in trunk

Bug 23399: AX: some buttons don't expose AXPress as an action
https://bugs.webkit.org/show_bug.cgi?id=23399

8:28 AM Changeset in webkit [40029] by Adam Roben
  • 5 edits in trunk

Windows build fix

WebCore:

Windows build fix

  • WebCore.vcproj/WebCore.vcproj: Copy headers from page/animation into $WebKitOutputDir so that WebKit can access them.
  • html/HTMLBaseFontElement.cpp: Touched this file to cause a rebuild and header copy.

WebKit/win:

Windows build fix

  • DOMCoreClasses.cpp: Replaced "using namespace WebCore" with individual using directives for each type we need from that namespace, to avoid conflicts between DOMObject and WebCore::DOMObject. (DOMElement::font): Added a now-needed WebCore::.
7:40 AM Changeset in webkit [40028] by ariya@webkit.org
  • 2 edits in trunk/WebCore

2009-01-19 Ariya Hidayat <ariya.hidayat@trolltech.com>

Reviewed by Simon Hausmann.

http://www.qtsoftware.com/developer/task-tracker/index_html?id=211228&method=entry

[Qt] Show focus rect when a button gets the focus for the first time.
This is important at least for Windows style.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::applyTheme):
5:39 AM Changeset in webkit [40027] by Simon Hausmann
  • 4 edits in trunk/WebKit/qt

2009-01-19 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Fix calling of onkeypress event handlers on input elements when pressing enter
and other text insertion commands in the Qt port.

Similar to the win and mac ports don't execute text inserting editor
commands on RawKeyDown but continue processing the event first in
WebCore, i.e. also get a keypress event sent. If unhandled it will
come back to EditorClientQt::handleKeyboardEvent later and we execute
it then.

This also fixes search by pressing enter on www.trafikanten.no.

5:00 AM Changeset in webkit [40026] by ariya@webkit.org
  • 2 edits in trunk/WebCore

2009-01-19 Ariya Hidayat <ariya.hidayat@trolltech.com>

[Qt] Build fix after r39971.

  • platform/qt/LoggingQt.cpp: (WebCore::InitializeLoggingChannelsIfNecessary):
12:45 AM Changeset in webkit [40025] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Fix the build!

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::demarshalValue):
(WebKit::NetscapePluginInstanceProxy::demarshalValues):

Jan 18, 2009:

11:15 PM Changeset in webkit [40024] by weinig@apple.com
  • 13 edits
    1 delete in trunk/WebCore

2009-01-18 Sam Weinig <sam@webkit.org>

Reviewed by Cameron Zwarich.

Fix for https://bugs.webkit.org/show_bug.cgi?id=23415
Remove FramePrivate

Minor PLT speedup.

  • WebCore.base.exp:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/FrameLoader.cpp:
  • page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::~Frame): (WebCore::Frame::init): (WebCore::Frame::loader): (WebCore::Frame::view): (WebCore::Frame::setView): (WebCore::Frame::script): (WebCore::Frame::document): (WebCore::Frame::setDocument): (WebCore::Frame::settings): (WebCore::Frame::selection): (WebCore::Frame::editor): (WebCore::Frame::selectionGranularity): (WebCore::Frame::setSelectionGranularity): (WebCore::Frame::dragCaretController): (WebCore::Frame::animation): (WebCore::Frame::mark): (WebCore::Frame::setMark): (WebCore::Frame::setCaretVisible): (WebCore::Frame::clearCaretRectIfNeeded): (WebCore::Frame::selectionLayoutChanged): (WebCore::Frame::caretBlinkTimerFired): (WebCore::Frame::paintCaret): (WebCore::Frame::paintDragCaret): (WebCore::Frame::zoomFactor): (WebCore::Frame::isZoomFactorTextOnly): (WebCore::Frame::shouldApplyTextZoom): (WebCore::Frame::shouldApplyPageZoom): (WebCore::Frame::setZoomFactor): (WebCore::Frame::setPrinting): (WebCore::Frame::setJSStatusBarText): (WebCore::Frame::setJSDefaultStatusBarText): (WebCore::Frame::jsStatusBarText): (WebCore::Frame::jsDefaultStatusBarText): (WebCore::Frame::setNeedsReapplyStyles): (WebCore::Frame::needsReapplyStyles): (WebCore::Frame::reapplyStyles): (WebCore::Frame::isContentEditable): (WebCore::Frame::updateSecureKeyboardEntryIfActive): (WebCore::Frame::typingStyle): (WebCore::Frame::setTypingStyle): (WebCore::Frame::clearTypingStyle): (WebCore::Frame::computeAndSetTypingStyle): (WebCore::Frame::selectionComputedStyle): (WebCore::Frame::applyEditingStyleToBodyElement): (WebCore::Frame::removeEditingStyleFromBodyElement): (WebCore::Frame::keepAlive): (WebCore::Frame::cancelAllKeepAlive): (WebCore::Frame::clearDOMWindow): (WebCore::Frame::ownerElement): (WebCore::Frame::ownerRenderer): (WebCore::Frame::isDisconnected): (WebCore::Frame::setIsDisconnected): (WebCore::Frame::excludeFromTextSearch): (WebCore::Frame::setExcludeFromTextSearch): (WebCore::Frame::selectionBounds): (WebCore::Frame::selectionTextRects): (WebCore::Frame::isFrameSet): (WebCore::Frame::currentForm): (WebCore::Frame::forceLayout): (WebCore::Frame::sendScrollEvent): (WebCore::Frame::clearTimers): (WebCore::Frame::styleForSelectionStart): (WebCore::Frame::inViewSourceMode): (WebCore::Frame::setInViewSourceMode): (WebCore::Frame::markAllMatchesForText): (WebCore::Frame::markedTextMatchesAreHighlighted): (WebCore::Frame::setMarkedTextMatchesAreHighlighted): (WebCore::Frame::tree): (WebCore::Frame::setDOMWindow): (WebCore::Frame::domWindow): (WebCore::Frame::clearFormerDOMWindow): (WebCore::Frame::page): (WebCore::Frame::eventHandler): (WebCore::Frame::pageDestroyed): (WebCore::Frame::disconnectOwnerElement): (WebCore::Frame::documentAtPoint):
  • page/Frame.h:
  • page/FramePrivate.h: Removed.
  • page/FrameTree.h:
  • page/chromium/FrameChromium.cpp:
  • page/mac/FrameMac.mm: (WebCore::Frame::imageFromRect): (WebCore::Frame::selectionImage): (WebCore::Frame::snapshotDragImage): (WebCore::Frame::nodeImage): (WebCore::Frame::setUserStyleSheetLocation): (WebCore::Frame::setUserStyleSheet):
  • page/qt/FrameQt.cpp: (WebCore::Frame::setUserStyleSheetLocation): (WebCore::Frame::setUserStyleSheet):
  • page/win/FrameCGWin.cpp: (WebCore::Frame::nodeImage):
  • page/win/FrameWin.cpp:
6:31 PM Changeset in webkit [40023] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Fix <https://bugs.webkit.org/show_bug.cgi?id=23414>.
Bug 23414: Reproducible crash accessing View menu with plugins disabled

Reviewed by Anders Carlsson.

  • WebView/WebFrame.mm:

(-[WebFrame _canProvideDocumentSource]): Null-check the PluginData before using it.

9:14 AM Changeset in webkit [40022] by eric.carlson@apple.com
  • 2 edits in trunk/WebCore

2009-01-17 Eric Carlson <eric.carlson@apple.com>

Build fix for !ENABLE(VIDEO) following r40016.

  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::mouseEventIsInThumb):

Jan 17, 2009:

8:30 PM Changeset in webkit [40021] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

Build fix.

  • WebCoreSupport/WebDragClient.cpp: (WebDragClient::createDragImageForLink):
8:15 PM Changeset in webkit [40020] by sfalken@apple.com
  • 3 edits in trunk/WebCore

Build fix.

7:08 PM Changeset in webkit [40019] by hyatt@apple.com
  • 9 edits in trunk/WebCore

2009-01-17 David Hyatt <hyatt@apple.com>

Optimize isTextNode() the same way isElementNode() was optimized in an earlier checkin. isTextNode()
on Node is now non-virtual and just checks a bit that is set at construction time by Text.

Reviewed by Sam Weinig

  • dom/CharacterData.cpp: (WebCore::CharacterData::CharacterData):
  • dom/CharacterData.h:
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::EventTargetNode):
  • dom/EventTargetNode.h:
  • dom/Node.cpp: (WebCore::Node::Node):
  • dom/Node.h: (WebCore::Node::isTextNode): (WebCore::Node::isAttributeNode):
  • dom/Text.cpp: (WebCore::Text::Text):
  • dom/Text.h:
2:20 PM Changeset in webkit [40018] by hyatt@apple.com
  • 2 edits in trunk/LayoutTests/fast/dom

Fix failing CSS Selector layout test. Don't test first-letter in a text test, since that causes some of the selector text to be lost.

1:38 PM Changeset in webkit [40017] by hyatt@apple.com
  • 27 edits in trunk

WebCore:

2009-01-17 David Hyatt <hyatt@apple.com>

Change how backslashAsCurrencySymbol() works. Instead of forcing call sites to do the direct
replacement themselves, the exact transformation is instead done by the encoding (indirectly through
a method on Document).

These changes allow the fast case (where no replacement is needed) checks to be completely inlined for
a slight speedup, and also allow encodings to do future alterations to displayed string content without
having to patch call sites again.

Reviewed by Oliver Hunt

  • WebCore.base.exp:
  • dom/Document.cpp:
  • dom/Document.h: (WebCore::Document::displayStringModifiedByEncoding): (WebCore::Document::displayBufferModifiedByEncoding):
  • editing/Editor.cpp: (WebCore::Editor::addToKillRing):
  • editing/TextIterator.cpp: (WebCore::plainTextToMallocAllocatedBuffer): (WebCore::plainText):
  • editing/TextIterator.h:
  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::groupLabelText):
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::text):
  • loader/DocumentLoader.cpp: (WebCore::canonicalizedTitle):
  • page/Chrome.cpp: (WebCore::displayString): (WebCore::Chrome::runJavaScriptAlert): (WebCore::Chrome::runJavaScriptConfirm): (WebCore::Chrome::runJavaScriptPrompt): (WebCore::Chrome::setStatusbarText):
  • page/Frame.cpp: (WebCore::Frame::shouldClose):
  • page/Frame.h:
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeSelection):
  • platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::encode):
  • platform/text/TextEncoding.cpp: (WebCore::TextEncoding::TextEncoding):
  • platform/text/TextEncoding.h: (WebCore::TextEncoding::displayString): (WebCore::TextEncoding::displayBuffer):
  • rendering/HitTestResult.cpp: (WebCore::displayString):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paintReplaced):
  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::RenderText): (WebCore::RenderText::setTextInternal):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setInnerTextValue): (WebCore::RenderTextControl::finishText):

WebKit/mac:

2009-01-17 David Hyatt <hyatt@apple.com>

Eliminate dependencies on "backslashAsCurrencySymbol()" from WebKit, and make sure these alterations
are done in WebCore instead.

Reviewed by Oliver Hunt

  • WebView/WebFrame.mm: (-[WebFrame _selectedString]): (-[WebFrame _stringForRange:]):

WebKit/win:

2009-01-17 David Hyatt <hyatt@apple.com>

Eliminate dependencies on backslashAsCurrencySymbol from WebKit.

Reviewed by Oliver Hunt

  • WebFrame.cpp: (WebFrame::selectedString):
9:18 AM Changeset in webkit [40016] by eric.carlson@apple.com
  • 33 edits
    1 add in trunk

2009-01-17 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adele Peterson

Complete <rdar://problem/6293969>

  • DerivedSources.make: include mediaControlsQT.css for Mac build.
  • WebCore.xcodeproj/project.pbxproj: add mediaControlsQT.css
  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): add MediaTimelineContainerPart, CSSValueMediaCurrentTimeDisplay, and CSSValueMediaTimeRemainingDisplay
  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): include new media controller element styles
  • css/CSSSelector.h: (WebCore::CSSSelector::): Ditto.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): include new media controller element styles
  • css/CSSValueKeywords.in: add keywords for new media time display controls
  • css/mediaControls.css: adjust css for new control elements
  • css/mediaControlsQT.css: Added.
  • platform/ThemeTypes.h: (WebCore::): add media time display controls to ControlPart
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm: pass controller style to WKSI functions
  • rendering/MediaControlElements.cpp: (WebCore::MediaTextDisplayElement::MediaTextDisplayElement): Added (WebCore::MediaTextDisplayElement::attachToParent): Added (WebCore::MediaTextDisplayElement::update): Added (WebCore::MediaTimeDisplayElement::MediaTimeDisplayElement): Added (WebCore::MediaControlInputElement::MediaControlInputElement): Added (WebCore::MediaControlInputElement::hitTest): Added (WebCore::MediaControlTimelineElement::defaultEventHandler): Update the time display when dragging the thumb
  • rendering/MediaControlElements.h: (WebCore::): Add MediaTextDisplayElement
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::createTimelineContainer): Added (WebCore::RenderMedia::createTimeline): Parent is now the timeline container (WebCore::RenderMedia::createCurrentTimeDisplay): Added (WebCore::RenderMedia::createTimeRemainingDisplay): Added (WebCore::RenderMedia::updateControls): Create new elements. Don't ever start the time update timer when the time display elements are not visible (WebCore::RenderMedia::formatTime): Handle negative times. Don't display 0 hours or minutes (WebCore::RenderMedia::updateTimeDisplay): Do nothing when the time display elements are not visible. Display time remaining as well as current time. (WebCore::RenderMedia::updateControlVisibility): Don't assume opacity should be set to 0 when visibility changes (WebCore::RenderMedia::forwardEvent): Call element hitTest() method instead of local function as we can't assume that all controls are rectangular
  • rendering/RenderMedia.h: Updated
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::mouseEventIsInThumb): When slider is media timeline control, call element hitTest() method instead of assuming it is rectangular
  • rendering/RenderSlider.h: make mouseEventIsInThumb virtual
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::paint): Deal with time display and timeline container
  • rendering/RenderTheme.h: (WebCore::RenderTheme::paintMediaTimelineContainer): Updated (WebCore::RenderTheme::paintMediaCurrentTime): Added (WebCore::RenderTheme::paintMediaTimeRemaining): Added
  • rendering/RenderThemeMac.h: Updated
  • rendering/RenderThemeMac.mm: (WebCore::): (WebCore::mediaControllerTheme): (WebCore::RenderThemeMac::adjustSliderThumbSize): Call WebKitSystemInterface to get the thumb size when appropriate (WebCore::RenderThemeMac::paintMediaFullscreenButton): pass controller style to render function (WebCore::RenderThemeMac::paintMediaMuteButton): Ditto (WebCore::RenderThemeMac::paintMediaPlayButton): Ditto (WebCore::RenderThemeMac::paintMediaSeekBackButton): Ditto (WebCore::RenderThemeMac::paintMediaSeekForwardButton): Ditto (WebCore::RenderThemeMac::paintMediaSliderTrack): Ditto (WebCore::RenderThemeMac::paintMediaSliderThumb): Ditto (WebCore::RenderThemeMac::paintMediaTimelineContainer): Added (WebCore::RenderThemeMac::paintMediaCurrentTime): Added (WebCore::RenderThemeMac::paintMediaTimeRemaining): Added (WebCore::RenderThemeMac::extraMediaControlsStyleSheet): Added (WebCore::RenderThemeMac::hitTestMediaControlPart): Added
  • rendering/style/RenderStyle.h: Updated (WebCore::):

2009-01-17 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adele Peterson

Complete <rdar://problem/6293969>

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Remove UseSharedMediaUI

2009-01-17 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adele Peterson

<rdar://problem/6293969>
Update media controls rendering results for new controls CSS.

  • platform/mac/media/audio-controls-rendering-expected.txt:
  • platform/mac/media/video-controls-rendering-expected.txt:
  • platform/mac/media/video-display-toggle-expected.txt:
1:36 AM Changeset in webkit [40015] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2009-01-17 David Hyatt <hyatt@apple.com>

Inline a few methods in FrameView for speed.

Reviewed by Oliver Hunt

  • page/FrameView.cpp:
  • page/FrameView.h: (WebCore::FrameView::layoutCount): (WebCore::FrameView::needsFullRepaint):
1:27 AM Changeset in webkit [40014] by hyatt@apple.com
  • 4 edits in trunk/WebCore

2009-01-17 David Hyatt <hyatt@apple.com>

Inline Document::documentElement(), since it is used by the (very hot) RenderObject::isRoot(). Split off
the code that fetches and caches the document element into a separate function and inline the part that
does the null check and the return of the already-cached element.

Reviewed by Oliver Hunt

  • dom/Document.cpp: (WebCore::Document::cacheDocumentElement):
  • dom/Document.h: (WebCore::Document::documentElement):
1:11 AM Changeset in webkit [40013] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2009-01-17 David Hyatt <hyatt@apple.com>

Minor tweaks to RenderBox::styleChange to speed it up.

Reviewed by Oliver Hunt

  • rendering/RenderBox.cpp: (WebCore::RenderBox::styleDidChange):
12:41 AM Changeset in webkit [40012] by hyatt@apple.com
  • 4 edits in trunk/WebCore

2009-01-17 David Hyatt <hyatt@apple.com>

Inline FrameLoader::client().

Reviewed by Oliver Hunt

  • WebCore.base.exp:
  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h: (WebCore::FrameLoader::client):
12:30 AM Changeset in webkit [40011] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/graphics/Image.h

isNull() should be size().isEmpty(). Duh.

12:27 AM Changeset in webkit [40010] by hyatt@apple.com
  • 4 edits in trunk/WebCore

2009-01-17 David Hyatt <hyatt@apple.com>

Inline some Image methods for speed. Fix CachedImage's addClient method to just use isNull rather
than needlessly creating a rect.

Reviewed by Oliver Hunt

  • loader/CachedImage.cpp: (WebCore::CachedImage::addClient):
  • platform/graphics/Image.cpp:
  • platform/graphics/Image.h: (WebCore::Image::isNull): (WebCore::Image::rect): (WebCore::Image::width): (WebCore::Image::height):
12:17 AM Changeset in webkit [40009] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2009-01-17 David Hyatt <hyatt@apple.com>

Avoid using the non-inlined isVariable() when adding parsed values during CSS parsing.

Reviewed by Oliver Hunt

  • css/CSSParserValues.cpp: (WebCore::CSSParserValueList::addValue):
12:04 AM Changeset in webkit [40008] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2009-01-17 David Hyatt <hyatt@apple.com>

Inline Document::inPageCache(), since - because of animation code - it is now called every time
styles change on any element and so is now super-hot.

Reviewed by Oliver Hunt

  • dom/Document.cpp:
  • dom/Document.h: (WebCore::Document::inPageCache):
Note: See TracTimeline for information about the timeline view.