Timeline



Mar 2, 2009:

10:15 PM Changeset in webkit [41379] by Simon Fraser
  • 3 edits
    2 adds in trunk

2009-03-02 Simon Fraser <Simon Fraser>

Reviewed by Adele Peterson

https://bugs.webkit.org/show_bug.cgi?id=24313

If RenderTextControlSingleLine::nodeAtPoint() pokes a node into the
HitTestResult, then it had better well return |true|. And m_innerBlock
could never have been set as the hit node by the superclass, because
the superclass knows nothing about m_innerBlock.

Test: fast/forms/input-hit-test-border.html

  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::nodeAtPoint):
6:24 PM Changeset in webkit [41378] by weinig@apple.com
  • 8 edits in trunk

JavaScriptCore:

2009-03-02 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Enable Geolocation (except on Tiger and Leopard).

  • Configurations/JavaScriptCore.xcconfig:

WebCore:

2009-03-02 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Enable Geolocation (except on Tiger and Leopard).

  • Configurations/WebCore.xcconfig:

WebKit/mac:

2009-03-02 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Enable Geolocation (except on Tiger and Leopard).

  • Configurations/WebKit.xcconfig:

WebKitTools:

2009-03-02 Sam Weinig <sam@webkit.org>

Reviewed by Mark Rowe.

Enable Geolocation (except on Tiger and Leopard).

  • Scripts/build-webkit:
6:12 PM Changeset in webkit [41377] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-03-02 Ojan Vafai <ojan@chromium.org>

Reviewed by Adele Peterson.

Fix https://bugs.webkit.org/show_bug.cgi?id=24307
Null out m_highlightedNode on hideHighlight().
Ran WebCore/manual-tests/inspector/highlight-nodes.html.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::hideHighlight):
5:51 PM Changeset in webkit [41376] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2009-03-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

WebKit part of <rdar://problem/6638658>.


  • Plugins/Hosted/NetscapePluginHostManager.h:
  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::createPropertyListFile): Spawn the plug-in host and wait for it to create the property list.


  • Plugins/WebBasePluginPackage.mm: (-[WebBasePluginPackage createPropertyListFile]): Factor code out into a new method.


(-[WebBasePluginPackage pListForPath:createFile:]):
Call the newly added createPropertyListFile method.


  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage createPropertyListFile]): Tell the plug-in host manager to create a property list file for us.
5:47 PM Changeset in webkit [41375] by weinig@apple.com
  • 13 edits
    2 adds in trunk

WebCore:

2009-03-02 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Fix for <rdar://problem/6507404> Add Geolocation support.

This is not yet turned on for any Mac platform.

  • WebCore.xcodeproj/project.pbxproj:
  • page/Chrome.cpp: (WebCore::Chrome::shouldAllowGeolocationForFrame):
  • page/Chrome.h:
  • page/ChromeClient.h: (WebCore::ChromeClient::shouldAllowGeolocationForFrame):
  • page/Geolocation.cpp: (WebCore::Geolocation::Geolocation): (WebCore::Geolocation::disconnectFrame): Remove call to setUsingGeolocation as the document will not be alive at this point. (WebCore::Geolocation::getCurrentPosition): Check if the embedding app allows geolocation and return a PERMISSION_DENIED if not. (WebCore::Geolocation::watchPosition): Ditto. (WebCore::Geolocation::shouldAllowGeolocation): Perform request to embedding layer of whether to allow geolocation and cache the result.
  • page/Geolocation.h: (WebCore::Geolocation::):
  • platform/GeolocationService.cpp:
  • platform/GeolocationService.h: (WebCore::GeolocationService::~GeolocationService): (WebCore::GeolocationService::stopUpdating):
  • platform/mac/GeolocationServiceMac.h: Added. (WebCore::GeolocationServiceMac::lastPosition): (WebCore::GeolocationServiceMac::lastError):
  • platform/mac/GeolocationServiceMac.mm: Added. (WebCore::GeolocationService::create): (WebCore::GeolocationServiceMac::GeolocationServiceMac): (WebCore::GeolocationServiceMac::~GeolocationServiceMac): (WebCore::GeolocationServiceMac::startUpdating): (WebCore::GeolocationServiceMac::stopUpdating): (WebCore::GeolocationServiceMac::suspend): (WebCore::GeolocationServiceMac::resume): (WebCore::GeolocationServiceMac::positionChanged): (WebCore::GeolocationServiceMac::errorOccurred): (-[WebCoreCoreLocationObserver initWithCallback:]): (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]): (-[WebCoreCoreLocationObserver locationManager:didFailWithError:]):

WebKit/mac:

2009-03-02 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Fix for <rdar://problem/6507404> Add Geolocation support.

This is not yet turned on for any Mac platform.

Add SPI to ask the embedding application whether to allow
Geolocation for an origin.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::shouldAllowGeolocationForFrame):
  • WebView/WebUIDelegatePrivate.h:
5:36 PM Changeset in webkit [41374] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-03-02 Anders Carlsson <andersca@apple.com>

Fix PowerPC build.

  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage _tryLoad]):
5:36 PM UsingGitWithWebKit edited by ojan@chromium.org
(diff)
4:20 PM Changeset in webkit [41373] by andersca@apple.com
  • 1 edit in trunk/WebKit/mac/ChangeLog

Fix tyop

4:14 PM Changeset in webkit [41372] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-03-02 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan, Ada Chan.

Factor loading code out into its own method and get rid of a bunch of goots.


  • Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage _tryLoad]): (-[WebNetscapePluginPackage load]):
4:00 PM Changeset in webkit [41371] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-03-02 Anders Carlsson <andersca@apple.com>

Build fix.

  • Plugins/WebNetscapeDeprecatedFunctions.h:
3:58 PM Changeset in webkit [41370] by andersca@apple.com
  • 2 edits in trunk/WebKit

2009-03-02 Anders Carlsson <andersca@apple.com>

WebNetscapePluginPackage.mm is an Objective-C++ file.

  • WebKit.xcodeproj/project.pbxproj:
3:53 PM Changeset in webkit [41369] by andersca@apple.com
  • 3 edits
    1 move in trunk/WebKit

WebKit:

2009-03-02 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan.

Rename WebNetscapePluginPackage.m to WebNetscapePluginPackage.mm


  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2009-03-02 Anders Carlsson <andersca@apple.com>

Reviewed by John Sullivan.

Rename WebNetscapePluginPackage.m to WebNetscapePluginPackage.mm

  • Plugins/WebNetscapePluginPackage.m: Removed.
  • Plugins/WebNetscapePluginPackage.mm: Copied from mac/Plugins/WebNetscapePluginPackage.m.
3:29 PM Changeset in webkit [41368] by kevino@webkit.org
  • 11 edits in trunk

Build fixes for wxWidgets Mac trunk build.

3:25 PM Changeset in webkit [41367] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wxGTK missing header build fix.

1:55 PM Changeset in webkit [41366] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

  • platform/graphics/win/FontCacheWin.cpp: (WebCore::createGDIFont): Added back code to verify that the created HFONT has the requested face name.
1:38 PM Changeset in webkit [41365] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fixes a regression caused by splitting the input and output of console commands.

https://bugs.webkit.org/show_bug.cgi?id=24293

Reviewed by Kevin McCullough.

  • inspector/front-end/Console.js: (WebInspector.Console.prototype.addMessage): Don't treat ConsoleCommandResult as a normal ConsoleMessage when appending. This prevents resetting repeatCounts incorrectly.
1:38 PM Changeset in webkit [41364] by timothy@apple.com
  • 4 edits in trunk/WebCore

Make exception messages and logged Error objects display consistently.

https://bugs.webkit.org/show_bug.cgi?id=18983

Reviewed by Adam Roben.

  • English.lproj/localizedStrings.js: Remove a string for line numbers.
  • inspector/front-end/Console.js: (WebInspector.Console.prototype._enterKeyPressed): Pass the exception boolean to the ConsoleCommandResult constructor and don't pass level. (WebInspector.Console.prototype._formatnode): Fix a className typo. (WebInspector.Console.prototype._formaterror): Add an error-message classed span around the message to show in red and remove the console-message-url class from the link so it doesn't float right. Instead enclose the link in parentheses and use displayNameForURL to shorten the URL in the link. (WebInspector.ConsoleMessage.prototype.toMessageElement): Simplify how line numbers are shown since link underlining a string with parentheses looks bad. (WebInspector.ConsoleCommandResult): Take an exception boolean flag instead of a level and get line and URL based on that flag.
  • inspector/front-end/inspector.css: Tweaks to the styles.
1:38 PM Changeset in webkit [41363] by timothy@apple.com
  • 2 edits in trunk/WebKitTools

Allow for multiline quoted text in JavaScript files when looking for function names.

https://bugs.webkit.org/show_bug.cgi?id=24296

Reviewed by David Kilzer.

  • Scripts/prepare-ChangeLog:
11:16 AM Changeset in webkit [41362] by levin@chromium.org
  • 10 edits in trunk/WebCore

2009-03-02 Ojan Vafai <ojan@chromium.org>

Reviewed by Adele Peterson.

Bug 24048: extra windows button padding doesn't apply when there's no appearance
<https://bugs.webkit.org/show_bug.cgi?id=24048>

Replace adjustButtonInnerStyle with buttonInternalPaddingLeft/Right/Top/Bottom.

No tests added as existing tests already cover this behavior.

  • rendering/RenderButton.cpp: (WebCore::RenderButton::setupInnerStyle):
  • rendering/RenderTheme.cpp:
  • rendering/RenderTheme.h: (WebCore::RenderTheme::buttonInternalPaddingLeft): (WebCore::RenderTheme::buttonInternalPaddingRight): (WebCore::RenderTheme::buttonInternalPaddingTop):
  • rendering/RenderThemeChromiumGtk.cpp: (WebCore::RenderThemeWin::buttonInternalPaddingLeft): (WebCore::RenderThemeWin::buttonInternalPaddingRight): (WebCore::RenderThemeWin::buttonInternalPaddingTop): (WebCore::RenderThemeWin::buttonInternalPaddingBottom):
  • rendering/RenderThemeChromiumGtk.h:
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::buttonInternalPaddingLeft): (WebCore::RenderThemeChromiumWin::buttonInternalPaddingRight): (WebCore::RenderThemeChromiumWin::buttonInternalPaddingTop): (WebCore::RenderThemeChromiumWin::buttonInternalPaddingBottom):
  • rendering/RenderThemeChromiumWin.h:
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::buttonInternalPaddingLeft): (WebCore::RenderThemeWin::buttonInternalPaddingRight): (WebCore::RenderThemeWin::buttonInternalPaddingTop): (WebCore::RenderThemeWin::buttonInternalPaddingBottom):
  • rendering/RenderThemeWin.h:
10:26 AM Changeset in webkit [41361] by treat@webkit.org
  • 5 edits in trunk

2009-03-02 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Eric Seidel.

Add three new drt helper functions that enable all of the tests in
LayoutTests/animation/* and LayoutTests/transitions/* to now pass.

  • Api/qwebframe.cpp: (qt_drt_pauseAnimation): (qt_drt_pauseTransitionOfProperty): (qt_drt_numberOfActiveAnimations):
  • DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::pauseAnimationAtTimeOnElementWithId): (LayoutTestController::pauseTransitionAtTimeOnElementWithId): (LayoutTestController::numberOfActiveAnimations):
  • DumpRenderTree/qt/jsobjects.h:
8:55 AM Changeset in webkit [41360] by treat@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-03-02 Benjamin C Meyer <benjamin.meyer@torchmobile.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=21230
On X11 match the behavior of Firefox and also copy the url to the
clipboard selection when the action Copy Link Location is executed.

  • Api/qwebpage.cpp: (QWebPage::triggerAction):
8:30 AM Changeset in webkit [41359] by treat@webkit.org
  • 2 edits in trunk/WebCore

2009-03-02 Adam Treat <adam.treat@torchmobile.com>

Build fix for Qt port. Remove unnecessary assert.

  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::putImageData):
7:37 AM Changeset in webkit [41358] by treat@webkit.org
  • 9 edits in trunk/WebCore

2009-03-02 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Adam Roben and previously by Eric Seidel and Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24227
Ensure that the checkForSolidColor() optimization is correctly triggered
for all cases of drawPattern. Currently, the optimization was not triggered
when the check had not been previously performed via a request for the
image's NativeImagePtr.

Implement the Qt version of the checkForSolidColor() method. Combined with
the bug fix this reduces the time it takes to draw a repeating background
of a 1x1 image from ~50msecs to ~0msecs on my machine.

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::BitmapImage):
  • platform/graphics/BitmapImage.h: (WebCore::BitmapImage::mayFillWithSolidColor):
  • platform/graphics/Image.h: (WebCore::Image::mayFillWithSolidColor):
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/wx/ImageWx.cpp: (WebCore::BitmapImage::checkForSolidColor):
6:56 AM Changeset in webkit [41357] by kov@webkit.org
  • 4 edits in trunk

2009-03-02 Gustavo Noronha Silva <Gustavo Noronha Silva>

Unreviewed build fix; adding missing files to EXTRA_DIST, so that
they show up in the tarball.

  • GNUmakefile.am:
6:38 AM QtWebKitTodo edited by Simon Hausmann
(diff)
6:38 AM Changeset in webkit [41356] by krit@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

2009-03-02 Dirk Schulze <krit@webkit.org>

Just a correction of the ChangeLog. Removed Ariya Hidayat
from the reviewing process.

6:22 AM Changeset in webkit [41355] by krit@webkit.org
  • 2 edits in trunk/WebCore

2009-03-02 Dirk Schulze <krit@webkit.org>

Reviewed by Holger Freyther, rubber-stamped by Ariya Hidayat.

Added putImageData to Qt.

[Qt] lacks putImageData support in Canvas
https://bugs.webkit.org/show_bug.cgi?id=22186

  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::putImageData):
5:26 AM Changeset in webkit [41354] by Adam Roben
  • 2 edits in trunk/WebKitTools

Windows build fix after r41349

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::getChildrenWithRange):
12:22 AM Changeset in webkit [41353] by timothy@apple.com
  • 2 edits in trunk/WebCore

Show exception messages again when evaluating bad expressions in the
Web Inspector's console.

https://bugs.webkit.org/show_bug.cgi?id=19890

Reviewed by Oliver Hunt.

  • bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::transferExceptionToExecState): Fix the order in which the exception is set and cleared now that the exception is stored in the shared GlobalData, not per ExecState.
12:22 AM Changeset in webkit [41352] by timothy@apple.com
  • 3 edits
    1 add in trunk/WebCore

Make input in the Web Inspector console print before any output
that might be added by the called function.

https://bugs.webkit.org/show_bug.cgi?id=19931

Reviewed by Oliver Hunt.

  • inspector/front-end/Console.js: (WebInspector.Console.prototype._enterKeyPressed): Add the command message before evaluating the result. Associate the originating command to the result, so if they are adjacent there is no divider. (WebInspector.ConsoleCommand): No longer take a result. (WebInspector.ConsoleCommand.prototype.toMessageElement): Result code removed since it isn't used now. (WebInspector.ConsoleCommandResult): Subclass ConsoleMessage. (WebInspector.ConsoleCommandResult.prototype.toMessageElement): Call the ConsoleMessage toMessageElement and add a style class.
  • inspector/front-end/inspector.css: Add a new style class for adjacent results to hide the divider. Also tweak the position of the disclosure triangle for objects to not use the left margin.

Mar 1, 2009:

9:46 PM Changeset in webkit [41351] by timothy@apple.com
  • 1 edit in trunk/WebKitTools/DumpRenderTree/mac/AccessibilityUIElementMac.mm

Fix the Mac build.

8:18 PM Changeset in webkit [41350] by ddkilzer@apple.com
  • 4 edits in trunk/JavaScriptCore

<rdar://problem/6635688> Move HAVE_DTRACE check to Base.xcconfig

Reviewed by Mark Rowe.

  • Configurations/Base.xcconfig: Set HAVE_DTRACE Xcode variable based on PLATFORM_NAME and MAC_OS_X_VERSION_MAJOR. Also define it as a preprocessor macro by modifying GCC_PREPROCESSOR_DEFINITIONS.
  • JavaScriptCore.xcodeproj/project.pbxproj: Changed "Generate DTrace header" script phase to check for HAVE_DTRACE instead of MACOSX_DEPLOYMENT_TARGET.
  • wtf/Platform.h: Removed definition of HAVE_DTRACE macro since it's defined in Base.xcconfig now.
6:55 PM Changeset in webkit [41349] by Chris Fleizach
  • 6 edits in trunk

Bug 24282: AX Palindrome error when asking for a specific index of the AXChildren array
<https://bugs.webkit.org/show_bug.cgi?id=24282>

4:45 PM Changeset in webkit [41348] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-03-01 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

WebKit side of <rdar://problem/6449689>

Pass the visible name to the plug-in host.


  • Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost):
4:41 PM Changeset in webkit [41347] by levin@chromium.org
  • 19 edits in trunk

2009-03-01 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

Bug 24251: Cleanup: replace positionForCoordinates with positionForPoint
<https://bugs.webkit.org/show_bug.cgi?id=24251>

Make RenderObject::positionForCoordinate non-virtual and
RenderObject::positionForPoint virtual in preparation for
removing positionFor* from RenderObject/RenderText.

  • page/Frame.cpp: (WebCore::Frame::visiblePositionForPoint):
  • rendering/RenderBR.cpp: (WebCore::RenderBR::positionForPoint):
  • rendering/RenderBR.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForPoint):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::positionForPoint):
  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::positionForPoint):
  • rendering/RenderInline.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::positionForCoordinates): (WebCore::RenderObject::positionForPoint):
  • rendering/RenderObject.h:
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::positionForPoint):
  • rendering/RenderReplaced.h:
  • rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::positionForPoint):
  • rendering/RenderSVGInlineText.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::positionForPoint):
  • rendering/RenderText.h:
4:41 PM Changeset in webkit [41346] by levin@chromium.org
  • 4 edits in trunk/WebCore

2009-03-01 Larry Ewing <lewing@novell.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24080
NPN_GetValue casting to the wrong type and writing outside bounds

Make sure to cast the value to the correct type so that only
memory owned by the value is written to.

  • plugins/gtk/PluginViewGtk.cpp (PluginView::getValueStatic):
  • plugins/qt/PluginViewQt.cpp (PluginView::getValueStatic):
  • plugins/mac/PluginViewMac.cpp (PluginView::getValueStatic): (PluginView::getValue):
4:41 PM Changeset in webkit [41345] by levin@chromium.org
  • 9 edits in trunk/WebCore

2009-03-01 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24197 and
https://bugs.webkit.org/show_bug.cgi?id=23512

The Windows version of cgColor() is conditionally compiled using
!PLATFORM(MAC) change this to PLATFORM(WIN_OS) so that Chrome
can use the OS X version instead of the Windows version.

Also rename cgColor() -> createCGColor()

No observable change in behavior, so no test.

  • platform/graphics/Color.h:
  • platform/graphics/cg/ColorCG.cpp: (WebCore::createCGColor):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setPlatformShadow):
  • platform/graphics/mac/ColorMac.mm: (WebCore::createCGColor):
  • platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawFocusRing):
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::setLayerBorderColor): (WebCore::setLayerBackgroundColor): (WebCore::GraphicsLayerCA::setBackgroundColor):
  • platform/graphics/win/GraphicsContextCGWin.cpp: (WebCore::GraphicsContext::drawFocusRing):
  • svg/graphics/filters/cg/SVGFEHelpersCg.mm: (WebCore::ciColor):
1:09 PM Changeset in webkit [41344] by levin@chromium.org
  • 17 edits
    9 adds in trunk

WebCore:

2009-03-01 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24271: XMLHttpRequest needs js bindings for Workers.
<https://bugs.webkit.org/show_bug.cgi?id=24271>

Tests: http/tests/xmlhttprequest/workers/methods-async.html

http/tests/xmlhttprequest/workers/methods.html

  • bindings/js/JSWorkerContextBase.cpp: (WebCore::JSWorkerContextBase::getOwnPropertySlot): (jsWorkerContextBaseXMLHttpRequest): (setJSWorkerContextBaseXMLHttpRequest): Expose XMLHttpRequest to Workers.
  • bindings/js/JSWorkerContextBase.h:
  • bindings/js/JSXMLHttpRequestConstructor.cpp: (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor): (WebCore::constructXMLHttpRequest): (WebCore::JSXMLHttpRequestConstructor::mark): Removed the dependencies on Document.
  • bindings/js/JSXMLHttpRequestConstructor.h: (WebCore::JSXMLHttpRequestConstructor::scriptExecutionContext):
  • dom/EventException.idl:
  • dom/EventListener.idl: Chnage to have the NoStaticTables attribute since they are used from XHR.
  • loader/WorkerThreadableLoader.cpp: (WebCore::workerContextDidFinishLoading): (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading): Fixed identifier to be unsigned long.
  • loader/WorkerThreadableLoader.h:
  • workers/WorkerThread.cpp: (WebCore::WorkerThread::workerThread): Stop active objects when the thread is getting shutdown so that xhr gets properly shutdown.
  • xml/XMLHttpRequestUpload.cpp:
  • xml/XMLHttpRequest.idl:
  • xml/XMLHttpRequestException.idl:
  • xml/XMLHttpRequestProgressEvent.idl:
  • xml/XMLHttpRequestUpload.idl: Chnage to have the NoStaticTables attribute since they are used from XHR.

LayoutTests:

2009-03-01 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24271: XMLHttpRequest needs js bindings for Workers.
<https://bugs.webkit.org/show_bug.cgi?id=24271>

Some sanity checks for xhr done from workers. These are the same as
tests done for normal workers.

  • http/tests/xmlhttprequest/workers/methods-async-expected.txt: Added.
  • http/tests/xmlhttprequest/workers/methods-async.html: Added.
  • http/tests/xmlhttprequest/workers/methods-expected.txt: Added.
  • http/tests/xmlhttprequest/workers/methods.html: Added.
  • http/tests/xmlhttprequest/workers/resources/methods-async.js: Added. (onmessage): (log): (done): (onReqAbort): (onSyncReqError): (start): (processStateChange):
  • http/tests/xmlhttprequest/workers/resources/methods.cgi: Copied from LayoutTests/http/tests/xmlhttprequest/methods.cgi.
  • http/tests/xmlhttprequest/workers/resources/methods.js: Added. (log): (done):
12:14 PM Changeset in webkit [41343] by timothy@apple.com
  • 1 edit in trunk/JavaScriptCore/parser/Nodes.h

Build fix. Add isBlock() back since there was a new client since the patch was made.

11:37 AM Applications using WebKit edited by todd.ditchendorf@gmail.com
(diff)
11:35 AM Changeset in webkit [41342] by timothy@apple.com
  • 4 edits
    5 adds in trunk

JavaScriptCore:

2009-03-01 Horia Olaru <olaru@adobe.com>

By looking in grammar.y there are only a few types of statement nodes
on which the debugger should stop.

Removed isBlock and isLoop virtual calls. No need to emit debug hooks in
the "statementListEmitCode" method as long as the necessary hooks can be
added in each "emitCode".

https://bugs.webkit.org/show_bug.cgi?id=21073

Reviewed by Kevin McCullough.

  • parser/Nodes.cpp: (JSC::ConstStatementNode::emitBytecode): (JSC::statementListEmitCode): (JSC::EmptyStatementNode::emitBytecode): (JSC::ExprStatementNode::emitBytecode): (JSC::VarStatementNode::emitBytecode): (JSC::IfNode::emitBytecode): (JSC::IfElseNode::emitBytecode): (JSC::DoWhileNode::emitBytecode): (JSC::WhileNode::emitBytecode): (JSC::ForNode::emitBytecode): (JSC::ForInNode::emitBytecode): (JSC::ContinueNode::emitBytecode): (JSC::BreakNode::emitBytecode): (JSC::ReturnNode::emitBytecode): (JSC::WithNode::emitBytecode): (JSC::SwitchNode::emitBytecode): (JSC::LabelNode::emitBytecode): (JSC::ThrowNode::emitBytecode): (JSC::TryNode::emitBytecode):
  • parser/Nodes.h:

WebCore:

2009-03-01 Horia Olaru <olaru@adobe.com>

Adding manual debugger test cases for bug.

https://bugs.webkit.org/show_bug.cgi?id=21073

Reviewed by Kevin McCullough.

  • manual-tests/inspector/debugger-step-on-do-while-statements.html: Added.
  • manual-tests/inspector/debugger-step-on-for-in-statements.html: Added.
  • manual-tests/inspector/debugger-step-on-for-statements.html: Added.
  • manual-tests/inspector/debugger-step-on-while-statements.html: Added.
  • manual-tests/inspector/resources/loop-statements.js: Added.
11:22 AM Changeset in webkit [41341] by jmalonzo@webkit.org
  • 7 edits in trunk

2009-03-01 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] get the HTTP layout tests going
https://bugs.webkit.org/show_bug.cgi?id=24259

Added API to get the response mime type from a frame. We need this
so we can decide if we need to dump the frame as text or its
render tree

  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp:

2009-03-01 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] get the HTTP layout tests going
https://bugs.webkit.org/show_bug.cgi?id=24259

Determine the frame's response and decide whether to dump as text
or the render tree

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (dump):

2009-02-28 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] get the HTTP layout tests going
https://bugs.webkit.org/show_bug.cgi?id=24259

Enable http tests, excluding tests/folders that fail or untested

  • platform/gtk/Skipped:
11:21 AM Changeset in webkit [41340] by jmalonzo@webkit.org
  • 4 edits in trunk/WebKitTools

2009-03-01 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] get the HTTP layout tests going
https://bugs.webkit.org/show_bug.cgi?id=24259

Implement dumping of WebKitWebBackForwardList and its history
items.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (compareHistoryItems): (dumpHistoryItem): (dumpBackForwardListForWebView): (dump): (runTest):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::clearBackForwardList):
  • DumpRenderTree/gtk/WorkQueueItemGtk.cpp: (BackForwardItem::invoke):
11:21 AM Changeset in webkit [41339] by jmalonzo@webkit.org
  • 4 edits in trunk/WebKit/gtk

2009-03-01 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] get the HTTP layout tests going
https://bugs.webkit.org/show_bug.cgi?id=24259

Create a WebKitWebHistoryItem for each WebCore::HistoryItem when
necessary.
Add necessary API additions for us to be able to dump a WebKitWebHistoryItem

  • webkit/webkitprivate.h:
  • webkit/webkitwebbackforwardlist.cpp: (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_forward_list_with_limit): (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_back_list_with_limit):
  • webkit/webkitwebhistoryitem.cpp: (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_core_item): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_data): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_target): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_is_target_item): (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_children): (WebKit::core): (WebKit::kit):
11:02 AM Changeset in webkit [41338] by mitz@apple.com
  • 4 edits
    2 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • fix <rdar://problem/6634768> Reproducible crash in RenderLayer::updateScrollCornerStyle() using full-page zoom at MobileMe Contacts

Test: fast/events/scroll-during-zoom-change.html

  • dom/Document.cpp: (WebCore::Document::recalcStyle): Pause scheduled events during style reclaculation. Changes to the zoom property result in scroll events being generated during style recalc, and those events need to be deferred until the render tree is consistent.
  • page/FrameView.cpp: (WebCore::FrameView::layout): Changed to account for a case in which the post-layout tasks trigger a nested layout, which reactivates the post-layout task timer.

LayoutTests:

Reviewed by Darin Adler.

  • test for <rdar://problem/6634768> Reproducible crash in RenderLayer::updateScrollCornerStyle() using full-page zoom at MobileMe Contacts
  • fast/events/scroll-during-zoom-change-expected.txt: Added.
  • fast/events/scroll-during-zoom-change.html: Added.
11:00 AM Changeset in webkit [41337] by christian@webkit.org
  • 4 edits in trunk/WebKit/gtk

2009-03-01 Christian Dywan <christian@twotoasts.de>

Reviewed by Holger Freyther.

  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_get_encoding):
  • webkit/webkitwebview.h: Implement 'encoding' and 'custom-encoding' properties as well as webkit_web_view_get_encoding.
10:47 AM Changeset in webkit [41336] by christian@webkit.org
  • 2 edits in trunk/WebKitTools

2009-02-28 Zan Dobersek <zandobersek@gmail.com>

Reviewed by Holger Freyther.

Set the resolution for the default screen to 72.0.
This way, setting font sizes results in expected values.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (setDefaultsToConsistentStateValuesForTesting):
8:53 AM Changeset in webkit [41335] by timothy@apple.com
  • 3 edits in trunk/WebCore

Alphabetically sort scripts in the Script's panel file popup menu.

https://bugs.webkit.org/show_bug.cgi?id=23395

Reviewed by Timothy Hatcher.

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
  • inspector/front-end/utilities.js: (insertionIndexForObjectInListSortedByFunction): (indexOfObjectInListSortedByFunction):
8:42 AM Changeset in webkit [41334] by timothy@apple.com
  • 3 edits in trunk/WebCore

Pass securityOrigin->host() instead of securityOrigin->domain() to WebInspector
when creating databases, localStorage or sessionStorage. Changing document.domain
should have no affect on databases, localStorage and sessionStorage in Web Inspector.

https://bugs.webkit.org/show_bug.cgi?id=23844

Reviewed by Timothy Hatcher.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::addDOMStorageScriptResource): (WebCore::InspectorController::didUseDOMStorage):
  • storage/Database.cpp: (WebCore::Database::openDatabase):
8:22 AM Changeset in webkit [41333] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-03-01 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Holger Freyther.

Avoid leaking errors when reporting GIO errors.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::readCallback): (WebCore::openCallback): (WebCore::queryInfoCallback):
8:21 AM Changeset in webkit [41332] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-03-01 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Holger Freyther.

Fixes crash when the GIO backend is given the URI for a directory.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::networkErrorForFile):
8:04 AM Changeset in webkit [41331] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

Simple wording fix for the NEWS file.

7:39 AM Changeset in webkit [41330] by christian@webkit.org
  • 2 edits in trunk

2009-03-01 Christian Dywan <christian@twotoasts.de>

  • configure.ac: Bump GTK port version to 1.1.1.
7:38 AM Changeset in webkit [41329] by kov@webkit.org
  • 1 edit
    1 add in trunk/WebKit/gtk

2009-03-01 Xan Lopez <xan@gnome.org>

Add NEWS file to track progress between releases.

  • NEWS: Added.
7:29 AM Changeset in webkit [41328] by kov@webkit.org
  • 2 edits in trunk/WebKitTools

2009-02-28 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Holger Freyther.

Adds a WebKitMakeArguments environment variable to enable passing
of arguments such as '-j2' to make for the autotools build.

  • Scripts/webkitdirs.pm:
7:28 AM Changeset in webkit [41327] by kov@webkit.org
  • 2 edits in trunk/WebKitTools

2009-02-28 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by Holger Freyther.

Add a GTK+-only option to enable GNOME Keyring when building.

  • Scripts/build-webkit:

Feb 28, 2009:

10:21 PM Changeset in webkit [41326] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKitTools

2009-02-28 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Holger Freyther.

[Gtk] webkitdirs.pm modify path in when detecting 3D transforms and accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=24076

Refactor gtk lib detection and put it in builtDylibPathForName

  • Scripts/webkitdirs.pm:
9:28 PM Changeset in webkit [41325] by Dimitri Glazkov
  • 3 edits in trunk/WebCore

2009-02-28 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24261
Fix V8 custom binding scrubbing error.

Test: fast/dom/TreeWalker/TreeWalker-currentNode.html
Test: traversal/exception-forwarding.html
TesT: traversal/stay-within-root.html

  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
  • bindings/v8/custom/V8NodeIteratorCustom.cpp: (WebCore::toV8): Replace v8::Undefined() return value with v8::Null().
  • bindings/v8/custom/V8TreeWalkerCustom.cpp: (WebCore::toV8): Ditto.
8:27 PM Changeset in webkit [41324] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-02-28 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=24261
Fix V8 custom binding scrubbing error.

Test: fast/dom/CSSStyleDeclaration/css-properties-case-sensitive.html

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: (WebCore::cssPropertyName): Remove dubious checks, left over from

incomplete conversion of parameter from pointer to pass-by-ref.

(WebCore::NAMED_PROPERTY_GETTER): Initialize parameter.
(WebCore::NAMED_PROPERTY_SETTER): Ditto.

6:47 PM Changeset in webkit [41323] by mitz@apple.com
  • 3 edits in trunk/LayoutTests
  • correct a color profile mismatch in expected pixel results
  • platform/mac/fast/gradients/background-clipped-expected.checksum:
  • platform/mac/fast/gradients/background-clipped-expected.png:
12:29 PM Changeset in webkit [41322] by christian@webkit.org
  • 2 edits in trunk/WebCore

Add a ref to the ResourceHandle in startHttp so we can keep it
alive untill all callbacks have been executed, and unref it when
soup tells us it's done with the SoupMessage (in
finishedCallback). Fixes a number of crashes when calling
didReceiveData whould crash because of the handle dying.

12:12 PM Changeset in webkit [41321] by christian@webkit.org
  • 2 edits in trunk/WebKitTools

Use the new webkit_web_view_load_uri to open URIs.

12:04 PM Changeset in webkit [41320] by christian@webkit.org
  • 2 edits in trunk/WebKit/gtk
  • webkit/webkitwebview.cpp: Let webkit_web_view_open add file:// if a

locale path is passed for compatibility, since we used to support that.

6:43 AM Changeset in webkit [41319] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-02-28 Adam Bergkvist <adam.bergkvist@ericsson.com>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24226
[SOUP] HTTP status text is never set

Set HTTP status text to SoupMessage reason_phrase.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::fillResponseFromMessage):
2:01 AM Changeset in webkit [41318] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • fix malformed project file
  • WebCore.xcodeproj/project.pbxproj:
1:44 AM Changeset in webkit [41317] by mitz@apple.com
  • 4 edits
    4 adds in trunk

WebCore:

Reviewed by Oliver Hunt.

Test: fast/layers/inline-dirty-z-order-lists.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::styleWillChange): Moved the code that dirties a layer's and its stacking context's z-order lists when the layer's z-index or visibility change from here...
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::styleWillChange): ...to here, so that it will apply to RenderInline too.

LayoutTests:

Reviewed by Oliver Hunt.

  • fast/layers/inline-dirty-z-order-lists.html: Added.
  • platform/mac/fast/layers/inline-dirty-z-order-lists-expected.checksum: Added.
  • platform/mac/fast/layers/inline-dirty-z-order-lists-expected.png: Added.
  • platform/mac/fast/layers/inline-dirty-z-order-lists-expected.txt: Added.
12:45 AM Changeset in webkit [41316] by alice.liu@apple.com
  • 2 edits in trunk/WebKit/mac

2009-02-27 Alice Liu <alice.liu@apple.com>

Fix <rdar://problem/6531265> REGRESSION (r39185): adding ".jpeg"
extension to images that already have .jpg extension

Reviewed by Oliver Hunt.

  • WebView/WebHTMLView.mm: (-[NSString matchesExtensionEquivalent:]): (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Relax the check for the proper extension to allow for known equivalents, special-cased in matchesExtensionEquivalent function.
12:06 AM Changeset in webkit [41315] by ap@webkit.org
  • 4 edits in trunk/WebCore

Reviewed by David Hyatt.

Don't include TextResourceDecoder.h in Document.h

This undoes inlining of Document::displayStringModifiedByEncoding() to avoid world rebuilds
when TextResourceDecoder.h is modified. Performance impact is expected to be negligible.

Feb 27, 2009:

7:44 PM Changeset in webkit [41314] by kov@webkit.org
  • 2 edits in trunk

2009-02-27 Gustavo Noronha Silva <Gustavo Noronha Silva>

Unreviewed build fix. Adding the WebKit/gtk/webkitmarshal.list
file to EXTRA_DIST to fix make dist.

  • GNUmakefile.am:
6:21 PM Changeset in webkit [41313] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-02-27 Gustavo Noronha Silva <Gustavo Noronha Silva>

Reviewed by David Hyatt.

Automatically ignore empty requests to avoid crashing. This fixes
the crash in fast/loader/empty-embed-src-attribute.html.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
5:28 PM Changeset in webkit [41312] by levin@chromium.org
  • 3 edits
    4 adds in trunk

WebCore:

2009-02-27 Matt Pennig <pennig@apple.com>

Reviewed by David Hyatt.

Resolves: https://bugs.webkit.org/show_bug.cgi?id=24107
"Fixed elements have 0 as an offsetLeft property"


Code also brings offsetLeft/Top in full conformance with the spec.
Added two tests, one for fixed-position elements, and one for <html>.


Tests: fast/dom/Element/fixed-position-offset-parent.html

fast/dom/Element/offsetLeft-offsetTop-html.html

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::offsetLeft): (WebCore::RenderBoxModelObject::offsetTop):

LayoutTests:

2009-02-27 Matt Pennig <pennig@apple.com>

Reviewed by David Hyatt.


Added two tests:

  1. Tests offsetParent, offsetLeft and offsetTop on fixed-position elements.
  2. Tests offsetLeft and offsetTop on static and positioned <html> elements.
  • fast/dom/Element/fixed-position-offset-parent-expected.txt: Added.
  • fast/dom/Element/fixed-position-offset-parent.html: Added.
  • fast/dom/Element/offsetLeft-offsetTop-html-expected.txt: Added.
  • fast/dom/Element/offsetLeft-offsetTop-html.html: Added.
5:13 PM Changeset in webkit [41311] by dino@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

2009-02-27 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser

Pixel tests for previous commit
https://bugs.webkit.org/show_bug.cgi?id=24252

  • platform/mac/transforms/no_transform_hit_testing-expected.checksum: Added.
  • platform/mac/transforms/no_transform_hit_testing-expected.png: Added.
5:07 PM Changeset in webkit [41310] by dino@apple.com
  • 1 add in trunk/LayoutTests/platform/mac/transforms/no_transform_hit_testing-expected.txt

Forgot -expected file from last commit :(

5:05 PM Changeset in webkit [41309] by dino@apple.com
  • 3 edits
    1 add in trunk

2009-02-27 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser.

renderer()->hasTransform() returns true for elements
with perspective, but no transform, so test for transform
when hit testing. This fixes ASSERT from
https://bugs.webkit.org/show_bug.cgi?id=24252

Test: transforms/no_transform_hit_testing.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTestLayer):
4:01 PM Changeset in webkit [41308] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-02-27 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Fisher.

Fix scrubbing error -- a reversed condition.

  • bindings/v8/ScriptValue.h: (WebCore::ScriptValue::clear): Change early exit for empty value, not the opposite.
3:46 PM Changeset in webkit [41307] by mrowe@apple.com
  • 4 edits in branches/Safari-3-2-branch

Versioning.

3:39 PM Changeset in webkit [41306] by mrowe@apple.com
  • 1 copy in tags/Safari-5525.28.3

New tag.

3:29 PM Changeset in webkit [41305] by levin@chromium.org
  • 4 edits in trunk/WebCore

2009-02-27 Jian Li <jianli@chromium.org>

Reviewed by Alexey Proskuryakov.

Add confirmMessageFromWorkerObject to WorkerObjectProxy.
https://bugs.webkit.org/show_bug.cgi?id=24152

  • workers/WorkerMessagingProxy.cpp: (WebCore::MessageWorkerContextTask::performTask): (WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject):
  • workers/WorkerMessagingProxy.h:
  • workers/WorkerObjectProxy.h:
2:46 PM Changeset in webkit [41304] by andersca@apple.com
  • 9 edits in trunk/WebCore

2009-02-27 Anders Carlsson <andersca@apple.com>

Reviewed by David Hyatt.

Revert r41295, the fix for https://bugs.webkit.org/show_bug.cgi?id=24227
because it leads to assertion failures in the Mac port.


  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::BitmapImage):
  • platform/graphics/BitmapImage.h: (WebCore::BitmapImage::mayFillWithSolidColor):
  • platform/graphics/Image.h: (WebCore::Image::mayFillWithSolidColor):
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::BitmapImage):
  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/wx/ImageWx.cpp: (WebCore::BitmapImage::checkForSolidColor):
2:37 PM Changeset in webkit [41303] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2009-02-27 Anders Carlsson <andersca@apple.com>

Reviewed by Geoffrey Garen.

<rdar://problem/6631436>
CrashTracer: [USER] 1 crash in Safari at com.apple.WebKit • WebKit::NetscapePluginInstanceProxy::addValueToArray + 55


Port the NPN_Evaluate code over from WebCore instead of using the frame loader.


  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::evaluate):
2:24 PM Changeset in webkit [41302] by abarth@webkit.org
  • 1 edit in trunk/WebKit/win/WebPreferenceKeysPrivate.h

Remove mysterious @ sign to fix Windows build.

2:15 PM Changeset in webkit [41301] by abarth@webkit.org
  • 1 edit in trunk/WebKit/win/WebView.cpp

Attempt to fix Windows build.

1:58 PM Changeset in webkit [41300] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2009-02-27 Anders Carlsson <andersca@apple.com>

Reviewed by Geoffrey Garen.

WebKit side of <rdar://problem/6626814>.


  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCInvokeDefault): Make InvokeDefault async.


  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::addValueToArray): Handle passing NPObjects back to the plug-in host.


  • Plugins/Hosted/ProxyInstance.h: (WebKit::ProxyInstance::objectID): Add objectID getter.


  • Plugins/Hosted/WebKitPluginClient.defs: Make InvokeDefault a simpleroutine.
1:53 PM Changeset in webkit [41299] by timothy@apple.com
  • 2 edits in trunk/WebKit/mac

Fixes an exception by null checking the WebResource before adding it to
the subresources array.

<rdar://problem/5950769> Bug in [WebDataSource subresources] can throw an exception

Reviewed by Geoff Garen and Anders Carlsson.

  • WebView/WebDataSource.mm: (-[WebDataSource subresources]): Null check the WebResource before adding it.
1:01 PM Changeset in webkit [41298] by timothy@apple.com
  • 2 edits in trunk/WebKit/mac

Adds a workaround for Automator creating a WebView from a secondary thread.

<rdar://problem/6631951> REGRESSION (Safari 4 Beta): Automator crash on
secondary thread beneath -[WebView initWithFrame:frameName:groupName:]

Reviewed by Geoff Garen.

  • WebView/WebView.mm: (needsWebViewInitThreadWorkaround): Check for com.apple.Automator.
12:52 PM Changeset in webkit [41297] by abarth@webkit.org
  • 17 edits in trunk

WebCore:

2009-02-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=20249

Add a preference to allow universal access from local URLs to mitigate
some attacks. Some clients still want to allow this access, so we
expose this as a preference.

  • WebCore.base.exp:
  • dom/Document.cpp: (WebCore::Document::initSecurityContext):
  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin):
  • page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setAllowUniversalAccessFromFileUrls):
  • page/Settings.h: (WebCore::Settings::allowUniversalAccessFromFileUrls):

WebKit/mac:

2009-02-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add a preference to reduce the power of file:// URLs.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences allowUniversalAccessFromFileUrls]): (-[WebPreferences setAllowUniversalAccessFromFileUrls:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):

WebKit/win:

2009-02-27 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add a preference to reduce the power of file:// URLs.

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::allowUniversalAccessFromFileUrls): (WebPreferences::setAllowUniversalAccessFromFileUrls):
  • WebPreferences.h:
  • WebView.cpp: (WebView::notifyPreferencesChanged):
12:47 PM Changeset in webkit [41296] by treat@webkit.org
  • 2 edits in trunk/WebCore

2009-02-27 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24229
If an image has no alpha channel there is no reason to use SourceOver.

  • platform/graphics/qt/ImageQt.cpp: (WebCore::Image::drawPattern): (WebCore::BitmapImage::draw):
12:42 PM Changeset in webkit [41295] by treat@webkit.org
  • 9 edits in trunk/WebCore

2009-02-27 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Eric Seidel and Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=24227
Ensure that the checkForSolidColor() optimization is correctly triggered
for all cases of drawPattern. Currently, the optimization was not triggered
when the check had not been previously performed via a request for the
image's NativeImagePtr.

Implement the Qt version of the checkForSolidColor() method. Combined with
the bug fix this reduces the time it takes to draw a repeating background
of a 1x1 image from ~50msecs to ~0msecs on my machine.

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::BitmapImage):
  • platform/graphics/BitmapImage.h: (WebCore::BitmapImage::mayFillWithSolidColor):
  • platform/graphics/Image.h: (WebCore::Image::mayFillWithSolidColor):
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::BitmapImage::BitmapImage):
  • platform/graphics/cg/ImageCG.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::BitmapImage::checkForSolidColor):
  • platform/graphics/wx/ImageWx.cpp: (WebCore::BitmapImage::checkForSolidColor):
12:35 PM Changeset in webkit [41294] by krit@webkit.org
  • 2 edits in trunk/WebCore

2009-02-27 Dirk Schulze <krit@webkit.org>

Reviewed by Zack Rusin.

Added support for gradients and pattern on Fonts for Qt.

[Qt] gradients and patterns for FontQt
https://bugs.webkit.org/show_bug.cgi?id=24243

  • platform/graphics/qt/FontQt.cpp: (WebCore::Font::drawComplexText):
12:02 PM Changeset in webkit [41293] by Simon Fraser
  • 2 edits in trunk/WebKit/mac

2009-02-27 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson

https://bugs.webkit.org/show_bug.cgi?id=24242

setCursor(), and resetCursorRects() on Tiger, were using global, not local
coordinates for elementAtPoint:

  • WebView/WebHTMLView.mm: (resetCursorRects): (setCursor):
11:50 AM Changeset in webkit [41292] by levin@chromium.org
  • 3 edits in trunk/LayoutTests

2009-02-27 David Levin <levin@chromium.org>

Reviewed by Alexey Proskuryakov.

Bug 24213: Web Worker: Worker4 test: onmessage will never be called
<https://bugs.webkit.org/show_bug.cgi?id=24213>

  • fast/workers/worker-terminate-expected.txt:
  • fast/workers/worker-terminate.html: Added a log entry to the onmessage handler for worker4 to make it visible that the handler was called and removed the terminate call that happened outside of onmessage.
11:50 AM Changeset in webkit [41291] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-02-27 Jian Li <jianli@chromium.org>

Reviewed by Alexey Proskuryakov.

WorkerContextProxy::create in WorkerMessagingProxy.cpp should only be provided for non-Chromium platform.
https://bugs.webkit.org/show_bug.cgi?id=24113

  • workers/WorkerMessagingProxy.cpp:
11:29 AM Changeset in webkit [41290] by timothy@apple.com
  • 1 add in trunk/WebCore/inspector/front-end/DOMStorageDataGrid.js

Commit a missing file.

10:56 AM Changeset in webkit [41289] by timothy@apple.com
  • 5 edits in trunk/WebCore

Added a refresh button to storage views.

https://bugs.webkit.org/show_bug.cgi?id=24040

Reviewed by Timothy Hatcher.

  • inspector/front-end/DOMStorageItemsView.js: (WebInspector.DOMStorageItemsView): (WebInspector.DOMStorageItemsView.prototype.get statusBarItems): (WebInspector.DOMStorageItemsView.prototype.update): (WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
  • inspector/front-end/DatabaseTableView.js: (WebInspector.DatabaseTableView): (WebInspector.DatabaseTableView.prototype.get statusBarItems): (WebInspector.DatabaseTableView.prototype._refreshButtonClicked):
  • inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel): (WebInspector.DatabasesPanel.prototype.get statusBarItems): (WebInspector.DatabasesPanel.prototype.reset): (WebInspector.DatabasesPanel.prototype.showDatabase): (WebInspector.DatabasesPanel.prototype.showDOMStorage): (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
  • inspector/front-end/inspector.css:
10:28 AM Changeset in webkit [41288] by timothy@apple.com
  • 7 edits in trunk/WebCore

Added support for editing/deleting localStorage and sessionStorage items
directly from Web Inspector.

https://bugs.webkit.org/show_bug.cgi?id=23866.

Reviewed by Timothy Hatcher.

  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/DOMStorageDataGrid.js: Added. (WebInspector.DOMStorageDataGrid): (WebInspector.DOMStorageDataGrid.prototype._ondblclick): (WebInspector.DOMStorageDataGrid.prototype._startEditing): (WebInspector.DOMStorageDataGrid.prototype._editingCommitted): (WebInspector.DOMStorageDataGrid.prototype._editingCancelled): (WebInspector.DOMStorageDataGrid.prototype.deleteSelectedRow):
  • inspector/front-end/DOMStorageItemsView.js: (WebInspector.DOMStorageItemsView): (WebInspector.DOMStorageItemsView.prototype.get statusBarItems): (WebInspector.DOMStorageItemsView.prototype.hide): (WebInspector.DOMStorageItemsView.prototype.update): (WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):
  • inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel): (WebInspector.DatabasesPanel.prototype.get statusBarItems): (WebInspector.DatabasesPanel.prototype.reset): (WebInspector.DatabasesPanel.prototype.showDOMStorage): (WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage): (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css:
  • inspector/front-end/inspector.html:
9:42 AM Changeset in webkit [41287] by brettw@chromium.org
  • 7 edits
    2 adds in trunk/WebCore

Fix Windows transparency for the Chromium port. Implement a helper
class for handling transparency on Windows. It allows semitransparent
ClearType and semitransparent form controls by making new layers in the
background.

It also replaces the "ThemeHelper" which allows better
scaling and transforms on Windows form controls. In addition to the
functionality that the ThemeHelper did, but additionally handles the
antialiasing properly so that the form controls aren't composited on a
white square.

https://bugs.webkit.org/show_bug.cgi?id=24101

Reviewed by Eric Seidel.

8:23 AM Changeset in webkit [41286] by Dimitri Glazkov
  • 1 edit
    2 adds in trunk/WebCore

2009-02-27 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24211
Add ScheduledAction for V8.

  • bindings/v8/ScheduledAction.cpp: Added. (WebCore::ScheduledAction::ScheduledAction): (WebCore::ScheduledAction::~ScheduledAction): (WebCore::ScheduledAction::execute):
  • bindings/v8/ScheduledAction.h: Added. (WebCore::ScheduledAction::ScheduledAction):
6:59 AM Changeset in webkit [41285] by treat@webkit.org
  • 2 edits in trunk/WebCore

2009-02-27 Zack Rusin <zack@kde.org>

Reviewed by Nikolas Zimmermann.

Qt: be more reasonable about scrolled lines

cMouseWheelPixelsPerLineStep is currently a constant set to 13.3. it doesn't
match our metrics meaning that Qt scrolls by ~2 lines by default which is quite
irritating. so lets scroll vertically by the Qt set number of lines * Qt default
single step scroll

  • platform/qt/WheelEventQt.cpp:
3:30 AM Changeset in webkit [41284] by jmalonzo@webkit.org
  • 4 edits in trunk/WebKit/gtk

2009-02-27 Xan Lopez <xan@gnome.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24221
[GTK] Do not emit load-finished when being disposed

webkit_web_view_stop_load() is called from dispose() on
WebKitWebView. This eventually calls postProgressFinishedNotification
in FrameLoaderClientGtk, which emits load-finished. Add
a 'disposing' flag to WebView that we can check here, so
we avoid emitting signals on objects on their way to be
destroyed. This fixes a bunch of critical warnings when
closing a loading WebView.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::postProgressFinishedNotification):
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp:
3:18 AM Changeset in webkit [41283] by jmalonzo@webkit.org
  • 10 edits in trunk

2009-02-27 Xan Lopez <xan@gnome.org>

Rubber-stamped by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24222
[GTK] Remove checks for old glib versions

libsoup, which is a hard dependency, needs at least glib 2.15.3,
so remove all glib checks for versions older than that.

  • platform/gtk/ContextMenuGtk.cpp: (WebCore::ContextMenu::ContextMenu):
  • platform/gtk/ContextMenuItemGtk.cpp: (WebCore::ContextMenuItem::setSubMenu):
  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::show):
  • platform/gtk/WidgetGtk.cpp: (WebCore::Widget::retainPlatformWidget):
  • platform/network/soup/ResourceHandleSoup.cpp:

WebKit/gtk:

2009-02-27 Xan Lopez <xan@gnome.org>

Rubber-stamped by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24222
[GTK] Remove checks for old glib versions

libsoup, which is a hard dependency, needs at least glib 2.15.3,
so remove all glib checks for versions older than that.

  • webkit/webkitwebview.cpp:

WebKitTools:

2009-02-27 Xan Lopez <xan@gnome.org>

Rubber-stamped by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24222
[GTK] Remove checks for old glib versions

libsoup, which is a hard dependency, needs at least glib 2.15.3,
so remove all glib checks for versions older than that.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setWaitToDump):
3:12 AM Changeset in webkit [41282] by mrowe@apple.com
  • 2 edits in branches/Safari-3-2-branch/WebKit/mac

Merge r41070.

3:12 AM Changeset in webkit [41281] by mrowe@apple.com
  • 13 edits in branches/Safari-3-2-branch

Merge r41190.

3:12 AM Changeset in webkit [41280] by mrowe@apple.com
  • 1 edit in branches/Safari-3-2-branch/WebKitLibraries/win/tools/scripts/PRODUCTVERSION

Bump version number.

12:20 AM Changeset in webkit [41279] by krit@webkit.org
  • 3 edits in trunk/WebCore

2009-02-26 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

Added support for Gradients and Patterns on filled or stroked Fonts
in Cairo. I also added support for globalAlpha on FontCairo.

[CAIRO] SVG/Canvas fonts miss gradients/pattern support
https://bugs.webkit.org/show_bug.cgi?id=18617

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawTextInternal):
  • platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):

Feb 26, 2009:

8:00 PM Changeset in webkit [41278] by adele@apple.com
  • 5 edits in trunk/LayoutTests

2009-02-26 Adele Peterson <adele@apple.com>

Reviewed by Alice Liu.

Make the success/failure of this test more obvious.

  • editing/selection/designmode-no-caret.html:
  • platform/mac/editing/selection/designmode-no-caret-expected.checksum:
  • platform/mac/editing/selection/designmode-no-caret-expected.png:
  • platform/mac/editing/selection/designmode-no-caret-expected.txt:
7:32 PM Changeset in webkit [41277] by barraclough@apple.com
  • 6 edits in trunk

JavaScriptCore:

2009-02-26 Gavin Barraclough <barraclough@apple.com>

Reviewed by Geoff Garen.

Fix bug #23614. Switches on double precision values were incorrectly
truncating the scrutinee value. E.g.:

switch (1.1) { case 1: print("FAIL"); }

Was resulting in FAIL.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jit/JITStubs.cpp: (JSC::JITStubs::cti_op_switch_imm):

LayoutTests:

2009-02-26 Gavin Barraclough <barraclough@apple.com>

Rubber stamped by Geoff Garen.

Layout test for bug #23614.

  • fast/js/resources/switch-behaviour.js:
  • fast/js/switch-behaviour-expected.txt:
5:15 PM Changeset in webkit [41276] by adele@apple.com
  • 8 edits in trunk

WebKit/mac:

2009-02-26 Adele Peterson <adele@apple.com>

Reviewed by Geoff Garen.

Fix for <rdar://problem/6618166>
https://bugs.webkit.org/show_bug.cgi?id=24216
(REGRESSION r36919) Safari 4 Beta causes MSN Messenger's text entry field to lose focus after entering a message

During a series of firstResponder changes, at some point while the WebHTMLView was losing first responder status,
we incorrectly marked the page as active, and then when the WebHTMLView became first responder again, setActive did nothing.
This change restores behavior from before r36919 to check if the WebHTMLView is in the middle of losing first responder when calling setActive.

In addition to updating editing/selection/designmode-no-caret.html results, I also made sure the test cases that were
fixed in r36919 and r38570 are still fixed.

  • WebView/WebHTMLView.mm: (-[WebHTMLView resignFirstResponder]): Keep track if we're in the process of resigning first responder. (-[WebHTMLView _isResigningFirstResponder]): Added.
  • WebView/WebHTMLViewInternal.h:
  • WebView/WebView.mm: (-[WebView _updateFocusedAndActiveStateForFrame:]): Don't set the page to be active if the document view is currently resigning first responder.

LayoutTests:

2009-02-26 Adele Peterson <adele@apple.com>

Reviewed by Geoff Garen.

Updating results for <rdar://problem/6618166>
https://bugs.webkit.org/show_bug.cgi?id=24216
(REGRESSION r36919) Safari 4 Beta causes MSN Messenger's text entry field to lose focus after entering a message

We changed these results shortly after r36919, but the original result is actually correct.
The test's text indicates that we expect a caret to be placed in this case.

  • platform/mac/editing/selection/designmode-no-caret-expected.checksum:
  • platform/mac/editing/selection/designmode-no-caret-expected.png:
  • platform/mac/editing/selection/designmode-no-caret-expected.txt:
5:09 PM Changeset in webkit [41275] by barraclough@apple.com
  • 4 edits in trunk/JavaScriptCore

2009-02-26 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Integer Immediate representation need not be canonical in x86 JIT code.
On x86-64 we already have loosened the requirement that the int immediate
representation in canonical, we should bring x86 into line.

This patch is a minor (~0.5%) improvement on sunspider & v8-tests, and
should reduce memory footoprint (reduces JIT code size).

  • jit/JIT.cpp: (JSC::JIT::compileOpStrictEq): (JSC::JIT::privateCompileSlowCases):
  • jit/JIT.h: (JSC::JIT::emitJumpIfImmediateNumber): (JSC::JIT::emitJumpIfNotImmediateNumber):
  • jit/JITArithmetic.cpp: (JSC::JIT::putDoubleResultToJSNumberCellOrJSImmediate): (JSC::JIT::compileBinaryArithOp):
4:20 PM Changeset in webkit [41274] by darin@chromium.org
  • 7 edits in trunk/WebCore

2009-02-26 Stephen White <senorblanco@chromium.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=23957

Fix for SVG gradient and pattern text for Chromium/skia.
Added accessors for the fill and stroke gradients to
GraphicsContext. Changed the paintSkiaText function to take a
GraphicsContext, so we can check for gradients/patterns.
Changed the skiaDrawText function to set the SkPaint shader
correctly, and to scale up the gradient shader matrix to
encompass the entire text string. Also offset each glyph
separately, rather than transforming the canvas, so that the
gradient/pattern stays fixed relative to the text origin.

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::getFillGradient): (WebCore::GraphicsContext::getStrokeGradient): (WebCore::GraphicsContext::getFillPattern): (WebCore::GraphicsContext::getStrokePattern):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawGlyphs):
  • platform/graphics/chromium/UniscribeHelper.cpp: (WebCore::UniscribeHelper::draw):
  • platform/graphics/skia/SkiaFontWin.cpp: (WebCore::windowsCanHandleTextDrawing): (WebCore::skiaDrawText): (WebCore::paintSkiaText):
  • platform/graphics/skia/SkiaFontWin.h:
3:29 PM Changeset in webkit [41273] by Dimitri Glazkov
  • 1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog entry

3:27 PM Changeset in webkit [41272] by Dimitri Glazkov
  • 1 edit
    4 adds in trunk/WebCore

2009-02-26 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

http://codereview.chromium.org/27217
Add custom V8 bindings for Navigator, Clipboard, Document, and Node.

  • bindings/v8/custom/V8ClipboardCustom.cpp: Added. (WebCore::ACCESSOR_GETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8DocumentCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8NavigatorCustom.cpp: Added. (WebCore::ACCESSOR_GETTER):
  • bindings/v8/custom/V8NodeCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
3:00 PM Changeset in webkit [41271] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-02-26 Gustavo Noronha Silva <Gustavo Noronha Silva>

Unreviewed build fix for building with GNOME Keyring enabled.

  • platform/network/soup/webkit-soup-auth-dialog.c: (show_auth_dialog):
2:45 PM Changeset in webkit [41270] by kov@webkit.org
  • 7 edits
    2 adds in trunk

2009-02-26 Xan Lopez <xan@gnome.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=16947
[GTK] Missing HTTP Auth challenge

Add HTTP authentication dialog with optional GNOME Keyring
storage.

  • GNUmakefile.am:
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::currentToplevelCallback): (WebCore::ResourceHandle::startHttp): (WebCore::ResourceHandle::start):
  • platform/network/soup/webkit-soup-auth-dialog.c: Added. (webkit_soup_auth_dialog_class_init): (webkit_soup_auth_dialog_init): (webkit_soup_auth_dialog_session_feature_init): (free_authData): (set_password_callback): (response_callback): (show_auth_dialog): (find_password_callback): (session_authenticate): (attach):
  • platform/network/soup/webkit-soup-auth-dialog.h: Added.
1:11 PM Changeset in webkit [41269] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-02-25 Ojan Vafai <ojan@chromium.org> and Eric Seidel <eric@webkit.org>

Reviewed by Dave Hyatt.

After Ojan's positionForCoordinates fix http://trac.webkit.org/changeset/41191
svg/custom/pointer-events-image.svg and svg/custom/pointer-events-text.svg
started failing because Ojan's new code was now *correctly* calling through to
SVG asking for the closest text offset in the last line box, instead of
just returning the offset at the end of the last line box when clicking below a box.

But! The SVG code was wrong, in that it returned the character offset of the last
character when you asked for a character offset after the end of the box, instead
it should return the offset *after* the last character. This patch fixes
that behavior by reordering the last two clauses in svgCharacterHitsPosition.

The SVG positionForCoordinates function is still wrong, and I've added some FIXMEs
to document what's wrong. I've also cleaned up the code a bit so it's clearer
what it is doing (which also makes more obvious what's wrong with it).

  • rendering/RenderSVGInlineText.cpp: (WebCore::RenderSVGInlineText::positionForCoordinates):
  • rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::SVGInlineTextBoxClosestCharacterToPositionWalker): (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::chunkPortionCallback): (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::offsetOfHitCharacter): (WebCore::SVGInlineTextBox::closestCharacterToPosition): (WebCore::SVGInlineTextBox::svgCharacterHitsPosition):
12:40 PM Changeset in webkit [41268] by darin@chromium.org
  • 3 edits in trunk/WebCore

2009-02-26 Darin Fisher <darin@chromium.org>

Reviewed by Eric Seidel.

Minor cleanup of ChromiumBridge:
Removing unused matchesMIMEType method and s/Javascript/JavaScript/

  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/MimeTypeRegistryChromium.cpp: (WebCore::MIMETypeRegistry::isSupportedImageMIMEType): (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType): (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
12:36 PM Changeset in webkit [41267] by hyatt@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

2009-02-26 David Hyatt <hyatt@apple.com>

Reviewed by Sam Weinig

Fix text-bottom vertical alignment. It was incorrectly aligning the bottom of the descent instead of including
the line-height below the descent.

Added fast/inline/vertical-align-text-bottom.html

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::verticalPosition):

LayoutTests:

2009-02-26 David Hyatt <hyatt@apple.com>

Reviewed by Sam Weinig

Fix text-bottom vertical alignment. It was incorrectly aligning the bottom of the descent instead of including
the line-height below the descent.

  • fast/inline/vertical-align-text-bottom.html: Added.
  • platform/mac/fast/inline/vertical-align-text-bottom-expected.checksum: Added.
  • platform/mac/fast/inline/vertical-align-text-bottom-expected.png: Added.
  • platform/mac/fast/inline/vertical-align-text-bottom-expected.txt: Added.
12:11 PM Changeset in webkit [41266] by krit@webkit.org
  • 12 edits
    5 deletes in trunk

2009-02-26 Dirk Schulze <krit@webkit.org>

Reviewed by Eric Seidel.

Make SVG Masking platform independet with the use of ImageBuffer::getImageData(),
ImageBuffer::putImageData() and GraphicsContext::clipToImageBuffer(). Every platform has
just to implement this three methods to support SVG Masking now.


Make SVG Masking platform aware
https://bugs.webkit.org/show_bug.cgi?id=19243

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::applyMask):
  • svg/graphics/cairo/SVGResourceMaskerCairo.cpp: Removed.
  • svg/graphics/cg/SVGResourceMaskerCg.cpp: Removed.
  • svg/graphics/cg/SVGResourceMaskerCg.mm: Removed.
  • svg/graphics/qt/SVGResourceMaskerQt.cpp: Removed.
  • svg/graphics/skia/SVGResourceMaskerSkia.cpp: Removed.

LayoutTests:
Corrected some tests after the new SVG Masking implementation for Mac.

Make SVG Masking platform aware
https://bugs.webkit.org/show_bug.cgi?id=19243

  • platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • platform/mac/svg/custom/grayscale-gradient-mask-expected.checksum:
  • platform/mac/svg/custom/grayscale-gradient-mask-expected.png:
  • svg/custom/mask-excessive-malloc.svg:
12:09 PM Changeset in webkit [41265] by treat@webkit.org
  • 5 edits
    3 adds in trunk

2009-02-26 Yong Li <yong.li@torchmobile.com>

Reviewed by Darin Adler, Antti Koivisto and Alexey Proskuryakov.

Test: http/tests/misc/slow-preload-cancel.html

https://bugs.webkit.org/show_bug.cgi?id=24133
Clear all pending preloads in the DocLoader object when we decide to
cancel its all requests.

  • loader/DocLoader.cpp: (WebCore::DocLoader::clearPendingPreloads):
  • loader/DocLoader.h:
  • loader/loader.cpp: (WebCore::Loader::cancelRequests):
12:07 PM Changeset in webkit [41264] by andersca@apple.com
  • 5 edits in trunk/WebKit/mac

2009-02-25 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Fix <rdar://problem/6623697>.


  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::print): Ask the plug-in host to print, create a CGImage of the returned bytes and draw the image into the passed in context.


  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView drawRect:]): When printing, call NetscapePluginInstanceProxy::print.


  • Plugins/Hosted/WebKitPluginHost.defs:
11:43 AM Changeset in webkit [41263] by Dimitri Glazkov
  • 1 edit
    3 adds in trunk/WebCore

2009-02-26 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=24182
Add NodeFilter, NodeIterator, and TreeWalker custom V8 bindings.

  • bindings/v8/custom/V8NodeFilterCustom.cpp: Added. (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8NodeIteratorCustom.cpp: Added. (WebCore::toV8): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8TreeWalkerCustom.cpp: Added. (WebCore::toV8): (WebCore::CALLBACK_FUNC_DECL):
11:40 AM Changeset in webkit [41262] by ap@webkit.org
  • 4 edits in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=23500
KURL::parse() incorrectly compares its result to original string

  • platform/KURL.cpp: (WebCore::KURL::parse): Take string length into account.
11:35 AM Changeset in webkit [41261] by Dimitri Glazkov
  • 1 edit
    1 add in trunk/WebCore

2009-02-26 Ojan Vafai <ojan@chromium.org>

Reviewed by Kevin McCullough.

Manual test for inspector node highlighting.

  • manual-tests/inspector/highlight-nodes.html: Added.
11:32 AM Changeset in webkit [41260] by darin@chromium.org
  • 2 edits in trunk/WebCore

2009-02-16 Anantanarayanan Iyengar <ananta@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=23973
ScrollView::scrollContents can be invoked during view shutdown. In
this scenario the FrameView::hostWindow method can return NULL, which
indicates that the frame/page is being destroyed. This causes a crash
when we try to dereference a NULL hostWindow pointer. Fix is to add a
NULL check for this.

  • platform/ScrollView.cpp: (WebCore::ScrollView::scrollContents):
11:11 AM Changeset in webkit [41259] by Dimitri Glazkov
  • 3 edits
    2 adds in trunk

WebCore:

2009-02-26 Rahul Kuchhal <kuchhal@chromium.org>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=24003
Fix a crash caused by unsafe type conversion.

Test: fast/block/positioning/absolute-in-inline-rtl-4.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcAbsoluteHorizontalValues):

LayoutTests:

2009-02-26 Rahul Kuchhal <kuchhal@chromium.org>

Reviewed by Dave Hyatt.

https://bugs.webkit.org/show_bug.cgi?id=24003
Fix a crash caused by unsafe type conversion.

  • fast/block/positioning/absolute-in-inline-rtl-4-expected.txt: Added.
  • fast/block/positioning/absolute-in-inline-rtl-4.html: Added.
10:59 AM Changeset in webkit [41258] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-02-26 Ojan Vafai <ojan@chromium.org>

Reviewed by Adam Roben.

https://bugs.webkit.org/show_bug.cgi?id=24202
Have drawNodeHighlight clip instead of clearing. This makes it work for
both Safari and Chromium since Chromium draws the inspector highlighting
in the same buffer as the page.

  • inspector/InspectorController.cpp: (WebCore::quadToPath): (WebCore::drawOutlinedQuad): (WebCore::drawOutlinedQuadWithClip): (WebCore::drawHighlightForBox):
10:45 AM Changeset in webkit [41257] by hyatt@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

2009-02-26 David Hyatt <hyatt@apple.com>

Reviewed by Dan Bernstein & Darin Adler

Make sure the border/padding are properly omitted at the start of an inline that is a continuation.


Added fast/inline/inline-continuation-borders.html

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):

LayoutTests:

2009-02-26 David Hyatt <hyatt@apple.com>

Reviewed by Dan Bernstein & Darin Adler

Make sure the border/padding are properly omitted at the start of an inline that is a continuation.

  • fast/inline/inline-continuation-borders.html: Added.
  • platform/mac/fast/inline/inline-continuation-borders-expected.checksum: Added.
  • platform/mac/fast/inline/inline-continuation-borders-expected.png: Added.
  • platform/mac/fast/inline/inline-continuation-borders-expected.txt: Added.
10:30 AM Changeset in webkit [41256] by ap@webkit.org
  • 4 edits in trunk/WebKit

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24024
REGRESSION (r39845): Assertion failure in -[WebHistoryItem dictionaryRepresentation] when
archiving a submission to about:blank

I don't know how to make an automated test for this bug.

  • History/WebHistory.mm: (-[WebHistory _visitedURL:withTitle:method:wasFailure:]):
  • WebHistory.cpp: (WebHistory::visitedURL): Account for the fact that HTTP method may be non-empty for non-HTTP requests.
10:21 AM Changeset in webkit [41255] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-02-26 Simon Fraser <Simon Fraser>

Build fix, no review.

Try to fix the wx build after r41218.

  • WebCoreSources.bkl:
10:19 AM Changeset in webkit [41254] by pam@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2009-02-25 Pamela Greene <pam@chromium.org>

Reviewed by Darin Fisher.

Add test that custom DOM properties survive garbage collection.
https://bugs.webkit.org/show_bug.cgi?id=24142

  • fast/dom/Window/customized-property-survives-gc-expected.txt: Added.
  • fast/dom/Window/customized-property-survives-gc.html: Added.
10:17 AM Changeset in webkit [41253] by ap@webkit.org
  • 4 edits
    2 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=19527
ASSERTION FAILED: containerA && containerB

Test: fast/dom/Range/bug-19527.html

  • dom/Range.cpp: (WebCore::Range::isPointInRange): (WebCore::Range::comparePoint): Bring the behavior in line with current Firefox, making it impossible for these methods to pass a null container to compareBoundaryPoints().
9:08 AM Changeset in webkit [41252] by zecke@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-02-26 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24099
ARM Compiler Warnings in pcre_exec.cpp

  • pcre/pcre_exec.cpp: (match):
8:48 AM Changeset in webkit [41251] by zecke@webkit.org
  • 3 edits
    1 add in trunk

2009-02-26 Xan Lopez <xan@gnome.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=16947
[GTK] Missing HTTP Auth challenge

Take marshallers to be built from a manually maintained list
instead of grepping the sources.

It's much faster, especially so now that we want to add
marshallers from WebCore too. A system to only take into account
the modified files when generating the marshallers from sources
could be hacked, but I think it's overkill considering how rarely
a new marshaller is added.

8:40 AM Changeset in webkit [41250] by zecke@webkit.org
  • 1 edit in trunk/WebKit/gtk/ChangeLog

Fix the ChangeLog s/frame/content.

I should have read more about the bug history and should have
done the substitution before landing.

8:33 AM Changeset in webkit [41249] by zecke@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-02-26 Xan Lopez <xan@gnome.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24193
[GTK] Checkbuttons not activated with space

Do not swallow key events with GtkIMContext for non-editable
frames (FIXME: I don't think frame is the right name here).

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::handleInputMethodKeydown):
8:27 AM Changeset in webkit [41248] by zecke@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-02-26 Xan Lopez <xan@gnome.org>

Reviewed by Alexey Proskuryakov.

https://bugs.webkit.org/show_bug.cgi?id=24103
[GTK] Use correct return value for WebView button-release handler

We are returning whatever the core code tells us it did, but this
does not play well with the GTK+ model. GTK+ in general expects it
will see a button-release if it saw a button-press and no
motion/leave/etc events in between. EventHandler.cpp will, in some
cases, not handle press but handle release, confusing the parent
container of the WebView.

As a workaround return always FALSE for button-release (this is
the same than the Windows port does).

  • webkit/webkitwebview.cpp:
8:21 AM Changeset in webkit [41247] by zecke@webkit.org
  • 4 edits in trunk/WebKit/gtk

2009-02-26 Xan Lopez <xan@gnome.org>

Reviewed by Holger Freyther.

https://bugs.webkit.org/show_bug.cgi?id=17585
[gtk] get|set encoding api

Add functions to get and set a custom encoding an a view.

  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_set_custom_encoding): (webkit_web_view_get_custom_encoding):
  • webkit/webkitwebview.h:
8:14 AM Changeset in webkit [41246] by zecke@webkit.org
  • 2 edits in trunk/WebCore

Make font-variant:small-caps work properly (bug #20358)

Set the computed size of the small caps font data rather than the specified size
so that the small-caps text is rendered smaller

6:13 AM Changeset in webkit [41245] by treat@webkit.org
  • 2 edits in trunk/WebCore

2009-02-26 Benjamin Meyer <benjamin.meyer@torchmobile.com>

Reviewed by George Staikos.

https://bugs.webkit.org/show_bug.cgi?id=24062
QNetworkCookieJar expects the url and not the policy url. Sending the
policy url will cause QNetworkCookieJar to behave incorrectly. One
example would be a cookie that does not have a path or domain.
QNetworkCookieJar will use the url it is given to fill in default values.
This allows setting cookies on the url of the main frame from an iFrame
when the cookie should be set on the url of the iFrame.

Originally noticed on http://writer.zoho.com/jsp/home.jsp?serviceurl=/index.do

  • platform/qt/CookieJarQt.cpp: (WebCore::setCookies):
3:09 AM Changeset in webkit [41244] by staikos@webkit.org
  • 3 edits in trunk/WebCore

2009-02-26 Charles Wei <charles.wei@torchmobile.com.cn>

Reviewed by George Staikos.

make WebKit/Qt compile with SVG disabled

  • WebCore.pro:
  • platform/graphics/qt/FontPlatformDataQt.cpp:
Note: See TracTimeline for information about the timeline view.