Timeline
May 24, 2009:
- 11:27 PM Changeset in webkit [44123] by
-
- 2 edits in trunk/WebCore
2009-05-24 Darin Fisher <darin@chromium.org>
Reviewed by Mark Rowe.
Fix build bustage related to PassOwnPtr changes.
- platform/graphics/chromium/TransparencyWin.cpp:
- 10:20 PM Changeset in webkit [44122] by
-
- 2 edits in trunk/WebKit/mac
- revert an accidental change from r43964.
- WebView/WebView.mm: (+[WebView _setShouldUseFontSmoothing:]):
- 8:29 PM Changeset in webkit [44121] by
-
- 2 edits in trunk/WebCore
2009-05-24 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Maciej Stachowiak.
Minor cleanup in PluginPackage::hash. Let the compiler
figure out the size of the array. Do not have it in the
definition and specially not the in the call to
StringImpl::hash.
- plugins/PluginPackage.cpp: (WebCore::PluginPackage::hash):
- 8:29 PM Changeset in webkit [44120] by
-
- 6 edits in trunk/WebCore
2009-05-24 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Maciej Stachowiak.
Move ::hash, ::equal and ::compareFileVersion from
the duplicated copies in PluginPackageQt.cpp and
PluginPackageGtk to PluginPackage.cpp. We need to #ifdef
this for the PluginPackageWin version. Use the new style
ENABLE() for this feature/policy and enable it in the Gtk+
and Qt buildsystem.
- GNUmakefile.am:
- WebCore.pro:
- plugins/PluginPackage.cpp: (WebCore::PluginPackage::hash): (WebCore::PluginPackage::equal): (WebCore::PluginPackage::compareFileVersion):
- plugins/gtk/PluginPackageGtk.cpp:
- plugins/qt/PluginPackageQt.cpp:
- 8:28 PM Changeset in webkit [44119] by
-
- 6 edits in trunk/WebCore
2009-05-24 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Maciej Stachowiak.
So far the initialization of the browserfuncs struct
is done in PluginPackageQt, PluginPackageGtk and
PluginPackageWin there is no need for this duplication.
The PluginPackageWin version got copied to PluginPackage
- plugins/PluginPackage.cpp: (WebCore::PluginPackage::initializeBrowserFuncs):
- plugins/PluginPackage.h:
- plugins/gtk/PluginPackageGtk.cpp: (WebCore::PluginPackage::load):
- plugins/qt/PluginPackageQt.cpp: (WebCore::PluginPackage::load):
- plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::load):
- 3:43 PM Changeset in webkit [44118] by
-
- 5 edits5 adds in trunk/WebCore
2009-05-24 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
WebKit needs cross-platform filter system
https://bugs.webkit.org/show_bug.cgi?id=19991
Added standard input for filter system.
No testcases were added. Filter system is still off.
- GNUmakefile.am:
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/filters/SourceAlpha.cpp: Added. (WebCore::SourceAlpha::create): (WebCore::SourceAlpha::effectName): (WebCore::SourceAlpha::apply): (WebCore::SourceAlpha::dump):
- platform/graphics/filters/SourceAlpha.h: Added. (WebCore::SourceAlpha::SourceAlpha):
- platform/graphics/filters/SourceGraphic.cpp: Added. (WebCore::SourceGraphic::create): (WebCore::SourceGraphic::effectName): (WebCore::SourceGraphic::apply): (WebCore::SourceGraphic::dump):
- platform/graphics/filters/SourceGraphic.h: Added. (WebCore::SourceGraphic::SourceGraphic):
- svg/FilterBuilder.cpp: Added. (WebCore::FilterBuilder::FilterBuilder): (WebCore::FilterBuilder::add): (WebCore::FilterBuilder::getEffectById): (WebCore::FilterBuilder::clearEffects):
- svg/FilterBuilder.h:
- 12:35 PM QtWebKitContrib edited by
- (diff)
- 11:13 AM Changeset in webkit [44117] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-24 Steve Falkenburg <sfalken@apple.com>
Build fix for experimental PGO Windows target.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- 11:10 AM Changeset in webkit [44116] by
-
- 3 edits in trunk/WebCore
2009-05-24 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Maciej Stachowiak.
Add support conditionals in the JSC bindings generator code for attributes,
by placing feature #ifdefs around the setters/getters.
Made the audio and video element specific DOM attributes conditional
in the generated code, by moving the #ifdefs from the IDL files into
the generated code. This allows for re-using the same generated code
with or without ENABLE(VIDEO).
- 9:34 AM Changeset in webkit [44115] by
-
- 2 edits in trunk/WebKit/mac
2009-05-24 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein and Tim Hatcher.
<rdar://problem/6913045> New console message spewed by automator CLI after installing JetstreamLeo40B21a
- Misc/WebNSObjectExtras.mm: (-[WebMainThreadInvoker initWithTarget:]): Tweaked argument name. (-[WebMainThreadInvoker forwardInvocation:]): Removed call to retainArguments. This was unneeded and in the case of a newly created but not yet fully initialized NSView object it caused the abovementioned bug. (-[WebMainThreadInvoker handleException:]): Tweaked argument name. Added assertion. (-[NSInvocation _webkit_invokeAndHandleException:]): Tweaked name of local variable that holds the exception.
- 8:34 AM Changeset in webkit [44114] by
-
- 2 edits in trunk/WebKit
2009-05-24 Darin Adler <Darin Adler>
- StringsNotToBeLocalized.txt: Updated for recent changes. Got rid of most full-file exceptions.
- 12:48 AM Changeset in webkit [44113] by
-
- 2 edits in trunk/WebKit/gtk
2009-05-24 Xan Lopez <xlopez@igalia.com>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=25987
[GTK] Clarify WebKitWebView::download-requested documentation
Explain a bit why this signal is not emitted by default and offer
a common solution/setup for that issue.
- webkit/webkitwebview.cpp: (webkit_web_view_class_init):
May 23, 2009:
- 11:38 PM Changeset in webkit [44112] by
-
- 2 edits in trunk/WebCore
Unreviewed build fix for Qt. Change signature to have PassOwnPtr.
- 10:14 PM Changeset in webkit [44111] by
-
- 5 edits7 adds in trunk/WebKitTools
Land the updated version of WebKitLauncher that the nightly builds have been using.
Reviewed by Oliver Hunt.
Changes include:
1) Support for self-updating via Sparkle.
2) Now respects the "Open using Rosetta" preference.
3) Passes environment variables through to the spawned Safari process.
4) Logs a list of extensions that are detected to the system console.
5) Disables extensions that are known to cause crashes too early in the
launch process to be detected by the extension-detection code.
- WebKitLauncher/Configurations/Base.xcconfig: Added.
- WebKitLauncher/Configurations/WebKitLauncher.xcconfig: Added.
- WebKitLauncher/Configurations/WebKitNightlyEnabler.xcconfig: Added.
- WebKitLauncher/Info.plist:
- WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
- WebKitLauncher/WebKitNightlyEnabler.h: Added.
- WebKitLauncher/WebKitNightlyEnabler.m:
(myBundleDidLoad):
(myApplicationWillFinishLaunching):
(poseAsWebKitApp):
(webKitLauncherBundle):
(enableWebKitNightlyBehaviour):
- WebKitLauncher/WebKitNightlyEnablerSparkle.h: Added.
- WebKitLauncher/WebKitNightlyEnablerSparkle.m: Added.
(initializeSparkle):
(updatePermissionPromptDescription):
(skipSignatureVerificationInDownloadDidFinish):
(updateAlertPanel):
(updateAlertInitForAlertPanel):
(-[NSAlert webKitHandleButtonPress:]):
(setMethodImplementation):
- WebKitLauncher/main.m:
(displayErrorAndQuit):
(getLastVersionShown):
(saveLastVersionShown):
(getPathForStartPage):
(getCurrentVersion):
(getShowStartPageVersion):
(startPageDisabled):
(addStartPageToArgumentsIfNeeded):
(preferredArchitecture):
(myExecve):
(locateSafariBundle):
(currentMacOSXVersion):
(checkFrameworkPath):
(main):
- 9:21 PM Changeset in webkit [44110] by
-
- 1 edit in trunk/ChangeLog
Fix typo "am" -> "an" in the Changelog of my previous commit
- 9:06 PM Changeset in webkit [44109] by
-
- 2 edits in trunk
2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>
Unreviewed build fix. Add gstreamer-video-0.10 libs to
GSTREAMER_LIBS to resolve am undefined reference to gst_video_get_size
- symbol used in MediaPlayerPrivateGstreamer.
- configure.ac:
- 4:28 PM Changeset in webkit [44108] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin Adler.
- clean up ColorMac a little
- platform/graphics/mac/ColorMac.h: Whitespace change.
- platform/graphics/mac/ColorMac.mm: Removed redundant #import statements and sorted the remaining ones. (WebCore::makeRGBAFromNSColor): Replaced four Objective-C method calls with a single call and removed redundant casts to int. (WebCore::nsColor): Removed ".0f" from number literals used as CGFloats. In one case, this avoids an intermediate conversion to float before conversion to double on 64-bit. (WebCore::CGColorFromNSColor): Replaced four Objective-C method calls with a single call. (WebCore::focusRingColor): (+[WebCoreControlTintObserver controlTintDidChange]): Whitespace change.
- 3:55 PM Changeset in webkit [44107] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-23 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Refactored new slow case codegen for == and !=.
SunSpider reports no change, maybe a tiny speedup.
- jit/JITOpcodes.cpp: (JSC::JIT::emitSlow_op_eq): (JSC::JIT::emitSlow_op_neq): Made a vptr comparison a *Ptr operation, instead of *32, to make it portable to 64bit. Reorganized the string and generic cases to make their control flow a little clearer.
- 3:39 PM Changeset in webkit [44106] by
-
- 2 edits in trunk/WebKit/gtk
2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>
Rubber-stamped by Gustavo Noronha.
Break the switch once private browsing is selected.
- webkit/webkitwebsettings.cpp: (webkit_web_settings_set_property): (webkit_web_settings_get_property):
- 3:35 PM Changeset in webkit [44105] by
-
- 7 edits in trunk
2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Gustavo Noronha and Xan Lopez.
[Gtk] Enable database and localStorage support
https://bugs.webkit.org/show_bug.cgi?id=25629
Enable storage/ tests for Gtk.
- platform/gtk/Skipped:
2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Gustavo Noronha and Xan Lopez.
[Gtk] Enable database and localStorage support
https://bugs.webkit.org/show_bug.cgi?id=25629
Add settings to enable or disable database and localStorage
support and enable them by default. This allows databases to be
shown in the WebInspector as well as allow us to run the storage
layout tests.
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy):
- webkit/webkitwebview.cpp: (webkit_web_view_update_settings): (webkit_web_view_settings_notify):
2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Gustavo Noronha and Xan Lopez.
[Gtk] Enable database and localStorage support
https://bugs.webkit.org/show_bug.cgi?id=25629
Enable database and localStorage for running the storage/ tests.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
- 3:22 PM Changeset in webkit [44104] by
-
- 2 edits in trunk/WebCore
2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[Gtk] ROLE_ROW_HEADER should not be used for list item bullets/numbers
https://bugs.webkit.org/show_bug.cgi?id=25900
Use ATK_ROLE_TEXT for ListMarkerRole.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (atkRole):
- 3:20 PM Changeset in webkit [44103] by
-
- 2 edits in trunk
2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[Gtk] Various autotools build refactoring and fixes
https://bugs.webkit.org/show_bug.cgi?id=25286
Refactor library LIBS. Move third-party libs in libwebkit instead
of libWebCore.
- GNUmakefile.am:
- 3:08 PM Changeset in webkit [44102] by
-
- 2 edits in trunk/WebCore
Reformat WebCore::requiresContextForWordBoundary()
- platform/text/TextBoundaries.h: (WebCore::requiresContextForWordBoundary):
- 2:29 PM Changeset in webkit [44101] by
-
- 2 edits in trunk/WebCore
Not reviewed. Roll out ResourceHandle patch, that I accidently included in my last commit.
- 2:25 PM Changeset in webkit [44100] by
-
- 23 edits2 adds in trunk/WebCore
Reviewed by Darin Adler.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=23808
After a long journey, add the last missing ABC to share form control element support with HTMLSelectElement.
RenderListBox/RenderMenuList operates on SelectElement instead of HTMLSelectElement now, querying selected index etc.
This makes it possible to use these render objects for ie. WML, as it's done before for input & option elements.
WMLSelectElement will be created soon, in a follow-up patch, adding more methods to SelectElement, sharing code between
HTMLSelectElement/WMLSelectElement.
- 10:32 AM Changeset in webkit [44099] by
-
- 3 edits in trunk/WebCore
Fix Gtk/Qt builds for PassOwnPtr
- platform/graphics/cairo/ImageCairo.cpp: (WebCore::Image::drawPattern): Use an OwnPtr<ImageBuffer> instead of an std::auto_ptr<ImageBuffer> to store the result of ImageBuffer::create() now that it returns a PassOwnPtr<ImageBuffer>.
- platform/graphics/qt/PathQt.cpp: (WebCore::Path::strokeContains): Ditto. (WebCore::Path::strokeBoundingRect): Ditto.
- 10:16 AM Changeset in webkit [44098] by
-
- 3 edits in trunk/WebKit/win
Windows build fix for PassOwnPtr
- WebHistory.cpp: (WebHistory::visitedURL): Changed std::auto_ptr<Vector<String> >() to 0.
- WebHistoryItem.cpp: (WebHistoryItem::initFromDictionaryRepresentation): Changed type of redirectURLsVector from std::auto_ptr<Vector<String> > to OwnPtr<Vector<String> >.
- 10:06 AM Changeset in webkit [44097] by
-
- 6 edits in branches/nitro-extreme/JavaScriptCore
2009-05-23 Geoffrey Garen <ggaren@apple.com>
Reviewed by Maciej Stachowiak.
Optimized == and != for our new value representation -- especially for strings.
14% speedup on date-format-tofte.
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_eq): (JSC::JIT::emitSlow_op_eq): (JSC::JIT::emit_op_neq): (JSC::JIT::emitSlow_op_neq):
- jit/JITStubCall.h: (JSC::JITStubCall::JITStubCall):
- jit/JITStubs.cpp: (JSC::JITStubs::cti_op_eq): (JSC::JITStubs::cti_op_eq_strings): (JSC::JITStubs::cti_op_call_eval):
- jit/JITStubs.h: (JSC::):
- runtime/JSValue.h:
- 9:39 AM Changeset in webkit [44096] by
-
- 42 edits in trunk
Part 2 of 2: Bug 25495: Implement PassOwnPtr and replace uses of std::auto_ptr
Reviewed by Oliver Hunt.
WebCore:
No test cases added since there is no change in behavior.
- WebCore.base.exp: Updated export for HistoryItem::setRedirectURLs() which now takes a PassOwnPtr.
- dom/Node.cpp: (WebCore::Node::childNodes): Use NodeListsNodeData::create() instead of new NodeListsNodeData. (WebCore::Node::registerDynamicNodeList): Ditto. (WebCore::Node::getElementsByTagNameNS): Ditto. (WebCore::Node::getElementsByName): Ditto. (WebCore::Node::getElementsByClassName): Ditto.
- dom/NodeRareData.h: (WebCore::NodeListsNodeData::create): Added. Implements create() pattern popularized by RefCounted classes. (WebCore::NodeListsNodeData::NodeListsNodeData): Declared private constructor. (WebCore::NodeRareData::setNodeLists): Now takes a PassOwnPtr<> instead of an auto_ptr<>.
- history/HistoryItem.cpp: (WebCore::HistoryItem::setRedirectURLs): Ditto.
- history/HistoryItem.h: (WebCore::HistoryItem::setRedirectURLs): Ditto.
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawTextInternal): Use OwnPtr<> instead of auto_ptr<> for stack variable.
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createImageBuffer): Updated to use assignment operator now that ImageBuffer::create() returns a PassOwnPtr<>.
- loader/EmptyClients.h: (WebCore::EmptyChromeClient::createHTMLParserQuirks): Return a PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.
- page/ChromeClient.h: (WebCore::ChromeClient::createHTMLParserQuirks): Ditto.
- platform/graphics/GeneratedImage.cpp: (WebCore::GeneratedImage::drawPattern): Use OwnPtr<> instead of auto_ptr<> for stack variable.
- platform/graphics/ImageBuffer.h: (WebCore::ImageBuffer::create): Return PassOwnPtr<> instead of auto_ptr<>. Use OwnPtr<> instead of auto_ptr<> for stack variable.
- platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::paint): Use OwnPtr<> instead of auto_ptr<> for stack variable.
- platform/text/TextCodec.h: (WebCore::NewTextCodecFunction): Return PassOwnPtr<> instead of auto_ptr<>.
- platform/text/TextCodecICU.cpp: (WebCore::newTextCodecICU): Ditto.
- platform/text/TextCodecLatin1.cpp: (WebCore::newStreamingTextDecoderWindowsLatin1): Ditto.
- platform/text/TextCodecUTF16.cpp: (WebCore::newStreamingTextDecoderUTF16LE): Ditto. (WebCore::newStreamingTextDecoderUTF16BE): Ditto.
- platform/text/TextCodecUserDefined.cpp: (WebCore::newStreamingTextDecoderUserDefined): Ditto.
- platform/text/TextEncodingRegistry.cpp: (WebCore::newTextCodec): Ditto.
- platform/text/TextEncodingRegistry.h: (WebCore::newTextCodec): Ditto.
- platform/text/mac/TextCodecMac.cpp: (WebCore::newTextCodecMac): Ditto.
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): Use OwnPtr<> instead of auto_ptr<> for stack variable.
- svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent): Ditto. Return OwnPtr<> instead of auto_ptr<>.
- svg/SVGMaskElement.h: (WebCore::SVGMaskElement::drawMaskerContent): Return OwnPtr<> instead of auto_ptr<>.
- svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::buildPattern): Use OwnPtr<> instead of auto_ptr<> for stack variable.
- svg/graphics/SVGImage.cpp: (WebCore::SVGImage::nativeImageForCurrentFrame): Updated to use assignment operator now that ImageBuffer::create() returns a PassOwnPtr<>.
- svg/graphics/SVGPaintServerGradient.cpp: (WebCore::createMaskAndSwapContextForTextGradient): Use OwnPtr<> instead of auto_ptr<> for stack variable.
- svg/graphics/SVGPaintServerPattern.cpp: (WebCore::SVGPaintServerPattern::setTile): Updated to take a PassOwnPtr<> instead of an auto_ptr<>. (WebCore::SVGPaintServerPattern::setup): Use OwnPtr<> instead of auto_ptr<> for stack variable.
- svg/graphics/SVGPaintServerPattern.h: (WebCore::SVGPaintServerPattern::setTile): Updated to take a PassOwnPtr<> instead of an auto_ptr<>.
- svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::applyMask): Updated to use assignment operator now that SVGMaskElement::drawMaskerContent() returns a PassOwnPtr<>. Use OwnPtr<> instead of auto_ptr<> for stack variable.
WebKit/gtk:
- WebCoreSupport/ChromeClientGtk.h: (WebKit::ChromeClient::createHTMLParserQuirks): Return a PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.
WebKit/mac:
- History/WebHistory.mm: (-[WebHistory _visitedURL:withTitle:method:wasFailure:]): Return 0 instead of an empty auto_ptr<>.
- History/WebHistoryItem.mm: (-[WebHistoryItem initFromDictionaryRepresentation:]): Use OwnPtr<> instead of auto_ptr<> for stack variable.
- WebCoreSupport/WebChromeClient.h: (WebChromeClient::createHTMLParserQuirks): Return a PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.
WebKit/qt:
- WebCoreSupport/ChromeClientQt.h: (WebCore::ChromeClientQt::createHTMLParserQuirks): Return a PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.
WebKit/win:
- WebCoreSupport/WebChromeClient.h: (WebChromeClient::createHTMLParserQuirks): Return a PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.
WebKit/wx:
- WebKitSupport/ChromeClientWx.h: (WebCore::ChromeClientWx::createHTMLParserQuirks): Return a PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.
- 9:39 AM Changeset in webkit [44095] by
-
- 10 edits10 adds in trunk
Part 1 of 2: Bug 25495: Implement PassOwnPtr and replace uses of std::auto_ptr
Reviewed by Oliver Hunt.
- GNUmakefile.am: Added OwnPtrCommon.h and PassOwnPtr.h.
- JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
- JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
- wtf/OwnPtr.h: (WTF::OwnPtr::OwnPtr): Added constructors that take a PassOwnPtr. Also added a copy constructor declaration that's required when assigning a PassOwnPtr to a stack-based OwnPtr. (WTF::operator=): Added assignment operator methods that take a PassOwnPtr. (WTF::swap): Reformatted. (WTF::operator==): Whitespace changes. (WTF::operator!=): Ditto.
- wtf/OwnPtrCommon.h: Added. (WTF::deleteOwnedPtr):
- wtf/PassOwnPtr.h: Added. (WTF::PassOwnPtr::PassOwnPtr): (WTF::PassOwnPtr::~PassOwnPtr): (WTF::PassOwnPtr::get): (WTF::PassOwnPtr::clear): (WTF::PassOwnPtr::release): (WTF::PassOwnPtr::operator*): (WTF::PassOwnPtr::operator->): (WTF::PassOwnPtr::operator!): (WTF::PassOwnPtr::operator UnspecifiedBoolType): (WTF::::operator): (WTF::operator==): (WTF::operator!=): (WTF::static_pointer_cast): (WTF::const_pointer_cast): (WTF::getPtr):
JavaScriptGlue:
- ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
- ForwardingHeaders/wtf/PassOwnPtr.h: Added.
WebCore:
- ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
- ForwardingHeaders/wtf/PassOwnPtr.h: Added.
- WebCore.vcproj/WebCore.vcproj: Added OwnPtrCommon.h and PassOwnPtr.h.
WebKit/mac:
- ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
- ForwardingHeaders/wtf/PassOwnPtr.h: Added.
WebKitTools:
- DumpRenderTree/ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
- DumpRenderTree/ForwardingHeaders/wtf/PassOwnPtr.h: Added.
- 9:15 AM Changeset in webkit [44094] by
-
- 14 edits in trunk/WebCore
Fix Mac builds by backing out r44093
- bindings/js/JSCustomPositionCallback.cpp:
- bindings/js/JSCustomPositionCallback.h:
- bindings/js/JSCustomPositionErrorCallback.cpp:
- bindings/js/JSCustomPositionErrorCallback.h:
- bindings/js/JSGeolocationCustom.cpp:
- page/Geolocation.cpp:
- page/Geolocation.idl:
- page/Geoposition.cpp:
- page/Geoposition.h:
- page/Geoposition.idl:
- page/Navigator.cpp: (WebCore::Navigator::disconnectFrame): (WebCore::Navigator::geolocation):
- page/PositionError.idl:
- platform/GeolocationService.cpp: (WebCore::GeolocationService::create):
- 8:28 AM Changeset in webkit [44093] by
-
- 14 edits in trunk/WebCore
2009-05-23 Laszlo Gombos <Laszlo Gombos>
Reviewed by Eric Seidel.
Add GEOLOCATION guards around Geolocation API code
https://bugs.webkit.org/show_bug.cgi?id=25756
- bindings/js/JSCustomPositionCallback.cpp:
- bindings/js/JSCustomPositionCallback.h:
- bindings/js/JSCustomPositionErrorCallback.cpp:
- bindings/js/JSCustomPositionErrorCallback.h:
- bindings/js/JSGeolocationCustom.cpp:
- page/Geolocation.cpp:
- page/Geolocation.idl:
- page/Geoposition.cpp:
- page/Geoposition.h:
- page/Geoposition.idl:
- page/Navigator.cpp: (WebCore::Navigator::disconnectFrame): (WebCore::Navigator::geolocation):
- page/PositionError.idl:
- platform/GeolocationService.cpp:
- 8:21 AM Changeset in webkit [44092] by
-
- 2 edits in trunk/WebKitTools
resolve-ChangeLogs: Add missing newline to status message
- Scripts/resolve-ChangeLogs: Added newline to status message
that is printed when the -ccontinue switch is used but there are unmerged files remaining in the git working directory.
- 8:07 AM Changeset in webkit [44091] by
-
- 4 edits in trunk/WebCore
Rename startupdateStyleIfNeededDispatcher to startUpdateStyleIfNeededDispatcher
In r42377, startUpdateRenderingDispatcher() was renamed to
startupdateStyleIfNeededDispatcher(), but the camelCase "U" was
dropped. This change restores it.
- WebCore.order:
- page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::startUpdateStyleIfNeededDispatcher): (WebCore::AnimationControllerPrivate::addEventToDispatch): (WebCore::AnimationControllerPrivate::addNodeChangeToDispatch): (WebCore::AnimationControllerPrivate::pauseAnimationAtTime): (WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
- page/animation/AnimationControllerPrivate.h:
- 7:03 AM Changeset in webkit [44090] by
-
- 3 edits in trunk/WebKit/qt
2009-05-23 Jakob Truelsen <antialize@gmail.com>
Reviewed by Holger Freyther.
Expose the default text encoding property to Qt.
- Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): (QWebSettings::setDefaultTextEncoding): (QWebSettings::defaultTextEncoding):
- Api/qwebsettings.h:
- 6:55 AM Changeset in webkit [44089] by
-
- 2 edits in trunk/WebCore
Unreviewed build-fix for Qt. Disable SVG Filters.
SVG Filters can not be built right now and Qt should not have
them enabled anyway as they did not carry out any filtering.
- 4:08 AM Changeset in webkit [44088] by
-
- 5 edits in trunk
Remove interpreter specific logic from the JIT builds
Reviewed by Maciej Stachowiak.
This saves ~100k in JSC release builds.
- 2:06 AM Changeset in webkit [44087] by
-
- 1 edit3 adds in trunk/LayoutTests
Add tests to cover exceptions thrown from non-object results of get_by_id
Reviewed by Maciej Stachowiak
- 1:25 AM Changeset in webkit [44086] by
-
- 2 edits in trunk/WebKitTools
Add an error message to a die statement
- 12:32 AM Changeset in webkit [44085] by
-
- 2 edits in trunk/WebCore
2009-05-23 Dirk Schulze <krit@webkit.org>
Unreviewed build-fix for gtk. Remove source input files
for SVG filter system from the build for the moment and
add them later again.
- GNUmakefile.am:
- 12:22 AM Changeset in webkit [44084] by
-
- 2 edits1 delete in trunk/LayoutTests
2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>
Unreviewed. Skip new tests introduced in r44010. These tests
require an eventSender implementation which the gtk port
currently do not have.
Also remove gtk-specific result for
fast/canvas/canvas-composite-alpha. The non-platform specific
result now works.
- platform/gtk/Skipped:
- platform/gtk/fast/canvas/canvas-composite-alpha-expected.txt: Removed.
- 12:19 AM Changeset in webkit [44083] by
-
- 38 edits in trunk/WebCore
2009-05-23 Dirk Schulze <krit@webkit.org>
Reviewed by Eric Seidel.
WebKit needs cross-platform filter system
https://bugs.webkit.org/show_bug.cgi?id=19991
Preparing Filter primitves for the new filter system.
No testcases were added. SVG filters are off by default.
- GNUmakefile.am:
- platform/graphics/filters/FEBlend.cpp: (WebCore::FEBlend::apply):
- platform/graphics/filters/FEBlend.h:
- platform/graphics/filters/FEColorMatrix.cpp: (WebCore::FEColorMatrix::apply):
- platform/graphics/filters/FEColorMatrix.h:
- platform/graphics/filters/FEComponentTransfer.cpp: (WebCore::FEComponentTransfer::apply):
- platform/graphics/filters/FEComponentTransfer.h:
- platform/graphics/filters/FEComposite.cpp: (WebCore::FEComposite::apply):
- platform/graphics/filters/FEComposite.h:
- svg/Filter.h:
- svg/FilterBuilder.h: (WebCore::FilterBuilder::lastFilter):
- svg/FilterEffect.cpp: (WebCore::FilterEffect::FilterEffect):
- svg/FilterEffect.h: (WebCore::FilterEffect::xBoundingBoxMode): (WebCore::FilterEffect::setXBoundingBoxMode): (WebCore::FilterEffect::yBoundingBoxMode): (WebCore::FilterEffect::setYBoundingBoxMode): (WebCore::FilterEffect::widthBoundingBoxMode): (WebCore::FilterEffect::setWidthBoundingBoxMode): (WebCore::FilterEffect::heightBoundingBoxMode): (WebCore::FilterEffect::setHeightBoundingBoxMode): (WebCore::FilterEffect::subRegion): (WebCore::FilterEffect::setSubRegion): (WebCore::FilterEffect::resultImage): (WebCore::FilterEffect::setEffectBuffer):
- svg/graphics/filters/SVGFEConvolveMatrix.cpp: (WebCore::FEConvolveMatrix::apply):
- svg/graphics/filters/SVGFEConvolveMatrix.h:
- svg/graphics/filters/SVGFEDiffuseLighting.cpp: (WebCore::FEDiffuseLighting::apply):
- svg/graphics/filters/SVGFEDiffuseLighting.h:
- svg/graphics/filters/SVGFEDisplacementMap.cpp: (WebCore::FEDisplacementMap::apply):
- svg/graphics/filters/SVGFEDisplacementMap.h:
- svg/graphics/filters/SVGFEFlood.cpp: (WebCore::FEFlood::apply):
- svg/graphics/filters/SVGFEFlood.h:
- svg/graphics/filters/SVGFEGaussianBlur.cpp: (WebCore::FEGaussianBlur::apply):
- svg/graphics/filters/SVGFEGaussianBlur.h:
- svg/graphics/filters/SVGFEImage.cpp: (WebCore::FEImage::apply):
- svg/graphics/filters/SVGFEImage.h:
- svg/graphics/filters/SVGFEMerge.cpp: (WebCore::FEMerge::apply):
- svg/graphics/filters/SVGFEMerge.h:
- svg/graphics/filters/SVGFEMorphology.cpp: (WebCore::FEMorphology::apply):
- svg/graphics/filters/SVGFEMorphology.h:
- svg/graphics/filters/SVGFEOffset.cpp: (WebCore::FEOffset::apply):
- svg/graphics/filters/SVGFEOffset.h:
- svg/graphics/filters/SVGFESpecularLighting.cpp: (WebCore::FESpecularLighting::apply):
- svg/graphics/filters/SVGFESpecularLighting.h:
- svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::apply):
- svg/graphics/filters/SVGFETile.h:
- svg/graphics/filters/SVGFETurbulence.cpp: (WebCore::FETurbulence::apply):
- svg/graphics/filters/SVGFETurbulence.h:
May 22, 2009:
- 11:25 PM Changeset in webkit [44082] by
-
- 2 edits in trunk/WebCore
2009-05-22 Dirk Schulze <krit@webkit.org>
Unreviewed build-fix for gtk. Breakage caused by a wrong call of ImageBuffer.
- platform/graphics/cairo/ImageCairo.cpp: (WebCore::Image::drawPattern):
- 11:00 PM Changeset in webkit [44081] by
-
- 2 edits in trunk/WebCore
2009-05-22 Dirk Schulze <vbs85@gmx.de>
Reviewed by Eric Seidel.
Added the use of tileRect() for a correct drawing of
border-images.
Testcases for border-image are in fast/borders like
border-image-01.html and will be activated for cairo, once
gtk supports pixel tests.
https://bugs.webkit.org/show_bug.cgi?id=19652
[CAIRO] wrong drawing of border-image
- platform/graphics/cairo/ImageCairo.cpp: (WebCore::Image::drawPattern):
- 10:47 PM Changeset in webkit [44080] by
-
- 3 edits in trunk/JavaScriptCore
Part two of an attempted Windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 10:47 PM Changeset in webkit [44079] by
-
- 2 edits in trunk/WebCore
Ask the Scrollbar for the orientation.
https://bugs.webkit.org/show_bug.cgi?id=25684
Use Scrollbar::orientation to figure out the
direction of scrolling.
- 10:13 PM Changeset in webkit [44078] by
-
- 3 edits in trunk/JavaScriptCore
Part one of an attempted Windows build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 9:51 PM Changeset in webkit [44077] by
-
- 2 edits in trunk/WebKit/gtk
Improve network request docs
- 6:48 PM Changeset in webkit [44076] by
-
- 30 edits in trunk/JavaScriptCore
2009-05-21 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
op_method_check
Optimize method calls, by caching specific function values within the Structure.
The new opcode is used almost like an x86 opcode prefix byte to optimize op_get_by_id,
where the property access is being used to read a function to be passed to op-call (i.e.
'foo.bar();'). This patch modifies the Structure class such that when a property is
put to an object for the first time we will check if the value is a function. If it is,
we will cache the function value on the Structure. A Structure in such a state guarantees
that not only does a property with the given identifier exist on the object, but also that
its value is unchanged. Upon any further attempt to put a property with the same identifier
(but a different value) to the object, it will transition back to a normal Structure (where
it will guarantee the presence but not the value of the property).
op_method_check makes use of the new information made available by the Structure, by
augmenting the functionality of op_get_by_id. Upon generating a FunctionCallDotNode a
check will be emitted prior to the property access reading the function value, and the JIT
will generate an extra (initially unlinked but patchable) set of checks prior to the regular
JIT code for get_by_id. The new code will do inline structure and prototype structure check
(unlike a regular get_by_id, which can only handle 'self' accesses inline), and then performs
an immediate load of the function value, rather than using memory accesses to load the value
from the obejct's property storage array. If the method check fails it will revert, or if
the access is polymorphic, the op_get_by_id will continue to operate - and optimize itself -
just as any other regular op_get_by_id would.
~2.5% on v8-tests, due to a ~9% progression on richards.
- API/JSCallbackObjectFunctions.h: (JSC::::put): (JSC::::staticFunctionGetter):
- API/JSObjectRef.cpp: (JSObjectMakeConstructor):
- JavaScriptCore.exp:
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::differenceBetween):
- assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::moveWithPatch):
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
- bytecode/CodeBlock.h: (JSC::getMethodCallLinkInfoReturnLocation): (JSC::CodeBlock::getMethodCallLinkInfo): (JSC::CodeBlock::addMethodCallLinkInfos): (JSC::CodeBlock::methodCallLinkInfo):
- bytecode/Opcode.h:
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitMethodCheck):
- bytecompiler/BytecodeGenerator.h:
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases): (JSC::JIT::privateCompile):
- jit/JIT.h: (JSC::MethodCallCompilationInfo::MethodCallCompilationInfo):
- jit/JITOpcodes.cpp:
- jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_method_check): (JSC::JIT::emitSlow_op_method_check): (JSC::JIT::emit_op_get_by_id): (JSC::JIT::emitSlow_op_get_by_id): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::emitSlow_op_put_by_id): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::compileGetByIdSlowCase): (JSC::JIT::patchMethodCallProto):
- jit/JITStubs.cpp: (JSC::JITStubs::cti_op_get_by_id_method_check): (JSC::JITStubs::cti_op_get_by_id_method_check_second):
- jit/JITStubs.h:
- jsc.cpp: (GlobalObject::GlobalObject):
- parser/Nodes.cpp: (JSC::FunctionCallDotNode::emitBytecode):
- runtime/Arguments.cpp: (JSC::Arguments::put):
- runtime/ArrayConstructor.cpp: (JSC::ArrayConstructor::ArrayConstructor):
- runtime/BooleanConstructor.cpp: (JSC::BooleanConstructor::BooleanConstructor):
- runtime/DateConstructor.cpp: (JSC::DateConstructor::DateConstructor):
- runtime/ErrorConstructor.cpp: (JSC::ErrorConstructor::ErrorConstructor): (JSC::constructError):
- runtime/ErrorPrototype.cpp: (JSC::ErrorPrototype::ErrorPrototype):
- runtime/FunctionConstructor.cpp: (JSC::FunctionConstructor::FunctionConstructor):
- runtime/FunctionPrototype.cpp: (JSC::FunctionPrototype::FunctionPrototype):
- runtime/InternalFunction.cpp: (JSC::InternalFunction::InternalFunction):
- runtime/JSActivation.cpp: (JSC::JSActivation::put): (JSC::JSActivation::putWithAttributes):
- runtime/JSByteArray.cpp: (JSC::JSByteArray::JSByteArray):
- runtime/JSFunction.cpp: (JSC::JSFunction::JSFunction): (JSC::JSFunction::getOwnPropertySlot):
- runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::putWithAttributes): (JSC::JSGlobalObject::reset): (JSC::JSGlobalObject::mark):
- runtime/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): (JSC::JSGlobalObject::methodCallDummy):
- runtime/JSObject.cpp: (JSC::JSObject::put): (JSC::JSObject::putWithAttributes): (JSC::JSObject::deleteProperty): (JSC::JSObject::defineGetter): (JSC::JSObject::defineSetter): (JSC::JSObject::getPropertyAttributes): (JSC::JSObject::getPropertySpecificFunction): (JSC::JSObject::putDirectFunction): (JSC::JSObject::putDirectFunctionWithoutTransition):
- runtime/JSObject.h: (JSC::getJSFunction): (JSC::JSObject::getDirectLocation): (JSC::JSObject::putDirect): (JSC::JSObject::putDirectWithoutTransition):
- runtime/LiteralParser.cpp: (JSC::LiteralParser::parseObject):
- runtime/Lookup.cpp: (JSC::setUpStaticFunctionSlot):
- runtime/Lookup.h: (JSC::lookupPut):
- runtime/MathObject.cpp: (JSC::MathObject::MathObject):
- runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::NativeErrorConstructor): (JSC::NativeErrorConstructor::construct):
- runtime/NativeErrorPrototype.cpp: (JSC::NativeErrorPrototype::NativeErrorPrototype):
- runtime/NumberConstructor.cpp: (JSC::NumberConstructor::NumberConstructor):
- runtime/ObjectConstructor.cpp: (JSC::ObjectConstructor::ObjectConstructor):
- runtime/PropertyMapHashTable.h: (JSC::PropertyMapEntry::PropertyMapEntry):
- runtime/PrototypeFunction.cpp: (JSC::PrototypeFunction::PrototypeFunction):
- runtime/PutPropertySlot.h: (JSC::PutPropertySlot::): (JSC::PutPropertySlot::PutPropertySlot): (JSC::PutPropertySlot::setNewProperty): (JSC::PutPropertySlot::setDespecifyFunctionProperty): (JSC::PutPropertySlot::isCacheable): (JSC::PutPropertySlot::cachedOffset):
- runtime/RegExpConstructor.cpp: (JSC::RegExpConstructor::RegExpConstructor):
- runtime/StringConstructor.cpp: (JSC::StringConstructor::StringConstructor):
- runtime/StringPrototype.cpp: (JSC::StringPrototype::StringPrototype):
- runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::~Structure): (JSC::Structure::materializePropertyMap): (JSC::Structure::addPropertyTransitionToExistingStructure): (JSC::Structure::addPropertyTransition): (JSC::Structure::changeFunctionTransition): (JSC::Structure::addPropertyWithoutTransition): (JSC::Structure::get): (JSC::Structure::despecifyFunction): (JSC::Structure::put): (JSC::Structure::remove):
- runtime/Structure.h: (JSC::Structure::get): (JSC::Structure::specificFunction):
- runtime/StructureTransitionTable.h: (JSC::StructureTransitionTableHashTraits::emptyValue):
- wtf/Platform.h:
- 6:34 PM Changeset in webkit [44075] by
-
- 3 edits2 adds in trunk
WebCore:
2009-05-22 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
<rdar://problem/6916082> Incorrect handling of % as CSS value.
Test: fast/css/percent-character-as-value.html
- css/CSSGrammar.y: Make a stray % character reliably cause CSS parsing to succeed, but the CSS value to be ignored because of incorrect type. A type of 0 has this effect.
LayoutTests:
2009-05-22 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6916082> Incorrect handling of % as CSS value.
- fast/css/percent-character-as-value-expected.txt: Added.
- fast/css/percent-character-as-value.html: Added.
- 6:01 PM Changeset in webkit [44074] by
-
- 1 edit in trunk/WebCore/ChangeLog
Add bugs.webkit.org URL for r44046
- 5:59 PM Changeset in webkit [44073] by
-
- 5 edits in trunk
WebCore:
2009-05-22 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=25971
Correct a handful of build errors in the Windows Cairo variant
due to missing VIDEO support.
- WebCore.vcproj/WebCore.vcproj: Exclude RenderMediaControls for the Cairo-based Windows target.
- rendering/RenderThemeWin.cpp: Avoid #include of RenderMediaControls for non-VIDEO builds.
WebKit/win:
2009-05-22 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=25971
Correct some build errors for Windows Cairo variant.
- WebKit.vcproj/WebKit.vcproj: Remove WTF.lib link commands as the new JavaScriptCore.dll supplies this now.
- 5:54 PM Changeset in webkit [44072] by
-
- 4 edits in branches/WWDC-2009-branch
Versioning.
- 5:53 PM Changeset in webkit [44071] by
-
- 1 copy in tags/Safari-6530.12
New tag.
- 5:48 PM Changeset in webkit [44070] by
-
- 2 edits in trunk/WebCore
One <limits> is enough
- html/HTMLMediaElement.cpp: Removed duplicate #include <limits>.
- 3:58 PM Changeset in webkit [44069] by
-
- 2 edits in trunk/WebKit/mac
2009-05-22 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
- Fix <rdar://problem/6913765> REGRESSION (r42331-r42334): Extra scroll bars appearing on Welcome panels of iLife '09 apps
- WebView/WebView.mm: (needsUnwantedScrollBarWorkaround): Added. Checks if this is a panel where scroll bars are unwanted. For safety, limited to only Apple applications. (-[WebView viewDidMoveToWindow]): If the workaround is needed, disallow scrolling the main frame. This prevents scroll bars from appearing.
- 2:57 PM Changeset in webkit [44068] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-22 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Fix non-SSE enabled builds.
- jit/JITArithmetic.cpp: (JSC::JIT::emitSlow_op_add): Don't early return here, we still need to call the JIT stub. (JSC::JIT::emitSlow_op_sub): Ditto.
- 2:54 PM Changeset in webkit [44067] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-05-22 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Here's a thought: let's not take a jit stub call just to multiply by 1,
bokay?
imul doesn't set the zero flag, so to test for a zero result, we need
an explicit instruction. (Luckily, it does set the overflow flag, so
we can still use that.)
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_mul): (JSC::JIT::emitSlow_op_mul): (JSC::JIT::emitMul32InPlace):
- 2:30 PM Changeset in webkit [44066] by
-
- 2 edits in trunk/WebCore
2009-05-22 Jon Honeycutt <jhoneycutt@apple.com>
<rdar://problem/6915957> REGRESSION: Hang when leaving page with VLC
plug-in
Reviewed by Steve Falkenburg.
- plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::determineQuirks): Look for the VLC plug-in's new name.
- 2:15 PM Changeset in webkit [44065] by
-
- 3 edits in trunk/WebCore
2009-05-22 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
Remove redudant member from Chromium's ResourceRequest. We already
have this data in the cross-platform ResourceRequestBase. Also, rename
ChromiumBridge parameter to be consistant with the new name for this
piece of data.
- platform/chromium/ChromiumBridge.h:
- platform/network/chromium/ResourceRequest.h:
- 2:14 PM Changeset in webkit [44064] by
-
- 4 edits in branches/nitro-extreme/JavaScriptCore
2009-05-22 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey "Premature Commit" Garen.
Add back constant integer cases for op_add.
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_add): (JSC::JIT::emitAdd32Constant): (JSC::JIT::emitSlow_op_add): (JSC::JIT::emitSlowAdd32Constant):
- jit/JITInlineMethods.h: (JSC::JIT::getConstantOperandImmediateDouble): (JSC::JIT::isOperandConstantImmediateDouble):
- 2:11 PM Changeset in webkit [44063] by
-
- 5 edits2 adds in trunk
Modify projects to use CFLite when not building the Apple Windows port.
- 2:07 PM Changeset in webkit [44062] by
-
- 7 edits in branches/nitro-extreme/JavaScriptCore
2009-05-22 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Added fast double cases for op_jnless and op_jnlesseq.
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::JumpList::jumps): New accesor, used by addSlowCase.
- assembler/X86Assembler.h: (JSC::X86Assembler::ucomisd_rm): New method for comparing register to memory.
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_jnless): (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emit_op_jnlesseq): (JSC::JIT::emitSlow_op_jnlesseq): (JSC::JIT::emit_op_add): (JSC::JIT::emit_op_sub): (JSC::JIT::emitBinaryDoubleOp): (JSC::JIT::emit_op_mul): (JSC::JIT::emit_op_div): Modified emitBinaryDoubleOp to accept comparison/jump operations in addition to operations with explicit result registers.
- jit/JITInlineMethods.h: (JSC::JIT::addSlowCase): Added an "addSlowCase" for JumpLists, so clients can track multiple jumps to the same slow case condition together.
- 1:48 PM Changeset in webkit [44061] by
-
- 3 edits in trunk/LayoutTests
2009-05-22 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
- Made the global-function-resolve test independent of hashing order by using a fixed set of properties. This also removes the need for us to update this test every time we add something to the window object or the js-test-pre.js family of scripts.
- fast/js/global-function-resolve-expected.txt: Updated.
- fast/js/resources/global-function-resolve.js: Use a fixed array instead of using all property names from the global object; also made other small changes that don't have an effect on the substance of the test.
- 1:35 PM Changeset in webkit [44060] by
-
- 6 edits in trunk
Reviewed by Kevin Ollivier.
Triple-click support for wx port. Also, switch to allocating GraphicsContext
on the stack in OnPaint since we only need it within that function.
https://bugs.webkit.org/show_bug.cgi?id=25962
- 1:32 PM Changeset in webkit [44059] by
-
- 1 edit in trunk/WebCore/ChangeLog
Date fix on ChangeLog.
- 1:31 PM Changeset in webkit [44058] by
-
- 1 edit2 deletes in trunk/LayoutTests
Reviewed by Darin Adler.
- remove a test that was supposed to test the text/* change to MIME types from r43979, since the change was rolled out, and the test seems to be ineffective anyway, since it was passing on Mac after rolling out the change.
- http/tests/mime/accept-all-text-types-expected.txt: Removed.
- http/tests/mime/accept-all-text-types.html: Removed.
- 1:11 PM Changeset in webkit [44057] by
-
- 2 edits in trunk/WebCore
Reviewed by Kevin Ollivier.
Only account for overhang for multi-character strings.
https://bugs.webkit.org/show_bug.cgi?id=25961
- 1:03 PM Changeset in webkit [44056] by
-
- 3 edits in trunk/WebCore
wx build fix. Switch to CURL cookies so we can benefit from API updates.
- 12:41 PM Changeset in webkit [44055] by
-
- 1 edit in trunk/ChangeLog
Fixing changelog message
- 12:40 PM Changeset in webkit [44054] by
-
- 2 edits in trunk
2009-05-22 Antonio Gomes <antonio.gomes@openbossa.org>
Reviewed by Gustavo Noronha.
Make Gtk build not bail out if gtk-doc-tools is not installed.
Warning message dumped instead.
- autogen.sh:
- 12:07 PM Changeset in webkit [44053] by
-
- 3 edits in trunk
2009-05-22 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Add big warnings about the glib unicode backend being slow and
incomplete, since it is a work in progress.
- autotools/webkit.m4:
- configure.ac:
- 12:06 PM Changeset in webkit [44052] by
-
- 2 edits in trunk/WebKit/gtk
2009-05-21 Xan Lopez <xlopez@igalia.com>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=24818
[GTK] http auth dialog pops up twice after a cancelled atempt
Workaround libsoup bug
http://bugzilla.gnome.org/show_bug.cgi?id=583462, which made
libsoup emit the 'authenticate' signal more often than it was
expected.
We'll be able to remove this when we depend on libsoup > 2.26.2.
- webkit/webkitsoupauthdialog.c: (session_authenticate):
- 11:39 AM Changeset in webkit [44051] by
-
- 8 edits in trunk/WebCore
2009-05-22 Peter Kasting <pkasting@google.com>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=25709 part one
Indent contents of namespaces in header files, to comply with the
style guide. No functional change.
- platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::): (WebCore::RGBA32Buffer::RGBA32Buffer): (WebCore::RGBA32Buffer::clear): (WebCore::RGBA32Buffer::bytes): (WebCore::RGBA32Buffer::rect): (WebCore::RGBA32Buffer::height): (WebCore::RGBA32Buffer::status): (WebCore::RGBA32Buffer::duration): (WebCore::RGBA32Buffer::disposalMethod): (WebCore::RGBA32Buffer::hasAlpha): (WebCore::RGBA32Buffer::setRect): (WebCore::RGBA32Buffer::ensureHeight): (WebCore::RGBA32Buffer::setStatus): (WebCore::RGBA32Buffer::setDuration): (WebCore::RGBA32Buffer::setDisposalMethod): (WebCore::RGBA32Buffer::setHasAlpha): (WebCore::RGBA32Buffer::setRGBA): (WebCore::ImageDecoder::m_failed): (WebCore::ImageDecoder::~ImageDecoder): (WebCore::ImageDecoder::setData): (WebCore::ImageDecoder::size): (WebCore::ImageDecoder::frameCount): (WebCore::ImageDecoder::repetitionCount): (WebCore::ImageDecoder::supportsAlpha): (WebCore::ImageDecoder::failed): (WebCore::ImageDecoder::setFailed): (WebCore::ImageDecoder::clearFrameBufferCache):
- platform/image-decoders/bmp/BMPImageDecoder.h: (WebCore::BMPImageDecoder::filenameExtension):
- platform/image-decoders/gif/GIFImageDecoder.h: (WebCore::GIFImageDecoder::filenameExtension): (WebCore::GIFImageDecoder::frameDurationAtIndex): (WebCore::GIFImageDecoder::):
- platform/image-decoders/ico/ICOImageDecoder.h: (WebCore::ICOImageDecoder::filenameExtension):
- platform/image-decoders/jpeg/JPEGImageDecoder.h: (WebCore::JPEGImageDecoder::filenameExtension): (WebCore::JPEGImageDecoder::supportsAlpha): (WebCore::JPEGImageDecoder::reader): (WebCore::JPEGImageDecoder::setSize):
- platform/image-decoders/png/PNGImageDecoder.h: (WebCore::PNGImageDecoder::filenameExtension): (WebCore::PNGImageDecoder::reader): (WebCore::PNGImageDecoder::decodingFailed):
- platform/image-decoders/xbm/XBMImageDecoder.h: (WebCore::XBMImageDecoder::filenameExtension):
- 11:06 AM Changeset in webkit [44050] by
-
- 14 edits4 adds in trunk
WebCore
2009-05-22 Dominik Röttsches <dominik.roettsches@access-company.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=15914
[GTK] Implement Unicode functionality using GLib
Minor changes that allow building a hybrid version of WebKit
that has WTF Unicode backend based on GLib functions while
text codecs and TextBreakIterator remain based on ICU.
Fixed some includes that were assuming a WTF ICU backend and
introduced temporary usage of WTF_USE_GLIB_ICU_UNICODE_HYBRID
macro.
- platform/ThreadGlobalData.cpp: (WebCore::ThreadGlobalData::ThreadGlobalData): (WebCore::ThreadGlobalData::~ThreadGlobalData):
- platform/ThreadGlobalData.h:
- platform/text/TextBoundariesICU.cpp:
- platform/text/TextCodecICU.h:
- platform/text/TextEncoding.cpp: (WebCore::TextEncoding::encode):
- platform/text/TextEncodingRegistry.cpp: (WebCore::buildBaseTextCodecMaps): (WebCore::extendTextCodecMaps):
2009-05-22 Dominik Röttsches <dominik.roettsches@access-company.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=15914
[GTK] Implement Unicode functionality using GLib
Original patch by Jürg Billeter and Naiem Shaik.
Implementing WTF Unicode functionality based on GLib.
- GNUmakefile.am:
- wtf/unicode/Unicode.h:
- wtf/unicode/glib: Added.
- wtf/unicode/glib/UnicodeGLib.cpp: Added. (WTF::Unicode::foldCase): (WTF::Unicode::toLower): (WTF::Unicode::toUpper): (WTF::Unicode::direction): (WTF::Unicode::umemcasecmp):
- wtf/unicode/glib/UnicodeGLib.h: Added. (WTF::Unicode::): (WTF::Unicode::toLower): (WTF::Unicode::toUpper): (WTF::Unicode::toTitleCase): (WTF::Unicode::isArabicChar): (WTF::Unicode::isFormatChar): (WTF::Unicode::isSeparatorSpace): (WTF::Unicode::isPrintableChar): (WTF::Unicode::isDigit): (WTF::Unicode::isPunct): (WTF::Unicode::mirroredChar): (WTF::Unicode::category): (WTF::Unicode::isLower): (WTF::Unicode::digitValue): (WTF::Unicode::combiningClass): (WTF::Unicode::decompositionType):
- wtf/unicode/glib/UnicodeMacrosFromICU.h: Added.
- 9:59 AM Changeset in webkit [44049] by
-
- 1 edit in trunk/WebKit/win/WebMutableURLRequest.cpp
Unreviewed build fix.
- 9:45 AM Changeset in webkit [44048] by
-
- 16 edits in trunk
WebCore:
2009-05-22 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Remove the policyBaseURL parameter from setCookie. This parameter is
redundant with the document parameter.
- WebCore.base.exp:
- WebCore.order:
- dom/Document.cpp: (WebCore::Document::setCookie):
- platform/CookieJar.h:
- platform/mac/CookieJar.mm: (WebCore::setCookies):
- platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::firstPartyForCookies): (WebCore::ResourceRequestBase::setFirstPartyForCookies):
- platform/network/chromium/CookieJarChromium.cpp: (WebCore::setCookies):
- platform/network/curl/CookieJarCurl.cpp: (WebCore::setCookies):
- platform/network/soup/CookieJarSoup.cpp: (WebCore::setCookies):
- platform/network/win/CookieJarCFNetWin.cpp: (WebCore::setCookies):
- platform/network/win/CookieJarWin.cpp: (WebCore::setCookies):
- platform/qt/CookieJarQt.cpp: (WebCore::setCookies):
WebKit/mac:
2009-05-22 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Remove the policyBaseURL parameter from setCookie. This parameter is
redudant with the document parameter.
- Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::setCookies):
- Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView setVariable:forURL:value:length:]):
- 9:44 AM Changeset in webkit [44047] by
-
- 14 edits in trunk/WebCore
2009-05-22 Adam Barth <abarth@webkit.org>
Reviewed by Maciej Stachowiak.
Rename policyBaseURL and mainDocumentURL to firstPartyForCookies. The
previous names were confusing and inaccurate.
- WebCore.order:
- dom/Document.cpp: (WebCore::Document::setCookie):
- dom/Document.h: (WebCore::Document::firstPartyForCookies): (WebCore::Document::setFirstPartyForCookies):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): (WebCore::FrameLoader::updateFirstPartyForCookies): (WebCore::FrameLoader::setFirstPartyForCookies): (WebCore::FrameLoader::open): (WebCore::FrameLoader::addExtraFieldsToRequest): (WebCore::FrameLoader::loadResourceSynchronously):
- loader/FrameLoader.h:
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::willSendRequest):
- platform/CookieJar.h:
- platform/mac/CookieJar.mm: (WebCore::setCookies):
- platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::adopt): (WebCore::ResourceRequestBase::copyData): (WebCore::ResourceRequestBase::firstPartyForCookies): (WebCore::ResourceRequestBase::setFirstPartyForCookies): (WebCore::equalIgnoringHeaderFields):
- platform/network/ResourceRequestBase.h:
- platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest): (WebCore::ResourceRequest::doUpdateResourceRequest):
- platform/network/chromium/CookieJarChromium.cpp: (WebCore::setCookies):
- platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdateResourceRequest): (WebCore::ResourceRequest::doUpdatePlatformRequest):
- 9:08 AM Changeset in webkit [44046] by
-
- 2 edits in trunk/WebCore
Fix the call to editingCancelled to be this._editingCancelled, since
editingCancelled doesn't exist and throws an exception.
Reviewed by Timothy Hatcher.
- inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
- 8:33 AM Changeset in webkit [44045] by
-
- 2 edits in trunk/WebKitTools
2009-05-22 Andre Pedralho <andre.pedralho@openbossa.org>
Reviewed by Simon Hausmann.
Fixed --makeargs usage in Qt build.
- 8:00 AM Changeset in webkit [44044] by
-
- 2 edits in trunk/WebCore
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25928
Several errors detected by cppcheck
Fix all (the only one) problem in cross-platform code found by the tool. Port maintainers
should take a look at other reports.
- css/CSSParser.cpp: (WebCore::CSSParser::addProperty): Don't leak the property even if there are billions of those.
- 7:26 AM Changeset in webkit [44043] by
-
- 2 edits in trunk/WebKitTools
2009-05-22 Zoltan Horvath <horvath.zoltan.6@stud.u-szeged.hu>
Reviewed by Simon Hausmann.
Correcting error message on missing WEBKIT_TESTFONTS
environment varible in Qt-port.
- 7:26 AM Changeset in webkit [44042] by
-
- 2 edits in trunk/LayoutTests
2009-05-22 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Simon Hausmann.
Skip tests depending on platform dependent results.
- 6:24 AM Changeset in webkit [44041] by
-
- 7 edits in trunk
2009-05-22 Shinichiro Hamaji <hamaji@google.com>
Reviewed by Oliver Hunt.
Remove optimization path alpha=0 case from GraphicContext(CG|Skia).
This optimization doesn't make sense for some composite mode (e.g., 'copy' operation).
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::strokeRect):
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::strokeRect):
- 6:12 AM Changeset in webkit [44040] by
-
- 3 edits1 add in trunk/WebKit/qt
2009-05-21 Antonio Gomes <antonio.gomes@openbossa.org>
Reviewed by Simon Hausmann.
[Qt] Additional test for resource load (CSS file) for QWebFrame.
- tests/qwebframe/qwebframe.qrc:
- tests/qwebframe/style.css: Added.
- tests/qwebframe/tst_qwebframe.cpp:
- 6:03 AM QtWebKitContrib edited by
- (diff)
- 2:10 AM QtWebKitContrib edited by
- (diff)
- 1:37 AM Changeset in webkit [44039] by
-
- 3 edits in trunk/WebCore
2009-05-22 Xan Lopez <xlopez@igalia.com>
Unreviewed build fix.
Revert the whole thing, since we can't figure out a way to make it
work in all platforms.
- rendering/SVGInlineTextBox.cpp: (WebCore::pathForDecoration):
- svg/SVGLength.cpp: (WebCore::SVGLength::PercentageOfViewport):
- 1:36 AM Changeset in webkit [44038] by
-
- 3 edits in trunk/WebKit/qt
2009-05-22 Simon Hausmann <simon.hausmann@nokia.com>
Unreviewed Qt build fix.
Provide dummy implementation of pure virtual EditorClient method.
- 1:20 AM Changeset in webkit [44037] by
-
- 2 edits in trunk/WebCore
2009-05-22 Xan Lopez <xlopez@igalia.com>
Try to fix Windows build.
Apparently it can't tell if '1.0f' is float or double, so cast to
float.
- rendering/SVGInlineTextBox.cpp: (WebCore::pathForDecoration):
- 1:11 AM Changeset in webkit [44036] by
-
- 3 edits in trunk/WebCore
2009-05-22 Xan Lopez <xlopez@igalia.com>
Try to fix breakage from the previous patch.
- rendering/SVGInlineTextBox.cpp: (WebCore::pathForDecoration):
- svg/SVGLength.cpp: (WebCore::SVGLength::PercentageOfViewport):
- 12:28 AM Changeset in webkit [44035] by
-
- 3 edits in trunk/WebCore
2009-05-15 Fridrich Strba <fridrich.strba@bluewin.ch>
Reviewed by Maciej Stachowiak.
https://bugs.webkit.org/show_bug.cgi?id=25805
In debug build, mingw win32 build has problems with powf
Change C-style calls to powf and sqrtf to C++-style calls to
overloaded pow and sqrt. This solves also a problem with mingw
compiler during the debug build.
- rendering/SVGInlineTextBox.cpp: (WebCore::pathForDecoration):
- svg/SVGLength.cpp: (WebCore::SVGLength::PercentageOfViewport):
May 21, 2009:
- 11:20 PM Changeset in webkit [44034] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-21 Xan Lopez <xlopez@igalia.com>
Unreviewed build fix.
Add MacroAssemblerCodeRef.h to file list.
- GNUmakefile.am:
- 9:44 PM Changeset in webkit [44033] by
-
- 2 edits in branches/WWDC-2009-branch/WebCore
Merge r44031.
- 9:44 PM Changeset in webkit [44032] by
-
- 1 edit in branches/WWDC-2009-branch/WebCore/page/DragController.cpp
Build fix.
- 8:57 PM Changeset in webkit [44031] by
-
- 2 edits in trunk/WebCore
2009-05-21 Stephanie Lewis <Stephanie Lewis>
Reviewed by Mark Rowe.
<rdar://problem/6913680> Update image caching options.
Disable extra ImageIO cache because we already handle caching decoded image data.
- platform/graphics/cg/ImageSourceCG.cpp: (WebCore::imageSourceOptions):
- 7:34 PM Changeset in webkit [44030] by
-
- 17 edits1 add in trunk/JavaScriptCore
2009-05-21 Gavin Barraclough <barraclough@apple.com>
Reviewed by Darin Adler.
Addition of MacroAssemblerCodeRef.h rubber stamped by Geoff Garen.
Refactor JIT code-handle objects. The representation of generated code is currently
a bit of a mess. We have a class JITCode which wraps the pointer to a block of
generated code, but this object does not reference the executable pool meaning that
external events (the pool being derefed) could make the pointer become invalid.
To overcome this both the JIT and Yarr implement further (and similar) objects to
wrap the code pointer with a RefPtr to the pool. To add to the mire, as well as the
CodeBlock containing a handle onto the code the FunctionBodyNode also contains a
copy of the code pointer which is used almost (but not entirely) uniquely to access
the JIT code for a function.
Rationalization of all this:
- Add a new type 'MacroAssembler::CodeRef' as a handle for a block of JIT generated code.
- Change the JIT & Yarr to internally handle code using CodeRefs.
- Move the CodeRef (formerly anow defunct JITCodeRef) from CodeBlock to its owner node.
- Remove the (now) redundant code pointer from FunctionBodyNode.
While tidying this up I've made the PatchBuffer return code in new allocations using a CodeRef,
and have enforced an interface that the PatchBuffer will always be used, and 'finalizeCode()' or
'finalizeCodeAddendum()' will always be called exactly once on the PatchBuffer to complete code generation.
This gives us a potentially useful hook ('PatchBuffer::performFinalization()') at the end of generation,
which may have a number of uses. It may be helpful should we wish to switch our generation
model to allow RW/RX exclusive memory, and it may be useful on non-cache-coherent platforms to
give us an oportunity to cache flush as necessary.
No performance impact.
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkCallerToTrampoline): (JSC::AbstractMacroAssembler::CodeRef::CodeRef): (JSC::AbstractMacroAssembler::CodeRef::trampolineAt): (JSC::AbstractMacroAssembler::PatchBuffer::PatchBuffer): (JSC::AbstractMacroAssembler::PatchBuffer::~PatchBuffer): (JSC::AbstractMacroAssembler::PatchBuffer::link): (JSC::AbstractMacroAssembler::PatchBuffer::linkTailRecursive): (JSC::AbstractMacroAssembler::PatchBuffer::patch): (JSC::AbstractMacroAssembler::PatchBuffer::complete): (JSC::AbstractMacroAssembler::PatchBuffer::finalize): (JSC::AbstractMacroAssembler::PatchBuffer::entry):
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::CodeBlock): (JSC::CodeBlock::reparseForExceptionInfoIfNecessary): (JSC::CodeBlock::setJITCode):
- bytecode/CodeBlock.h: (JSC::CodeBlock::getBytecodeIndex): (JSC::CodeBlock::executablePool):
- interpreter/CallFrameClosure.h:
- interpreter/Interpreter.cpp: (JSC::Interpreter::execute): (JSC::Interpreter::prepareForRepeatCall):
- jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::linkCall):
- jit/JIT.h:
- jit/JITCode.h: (JSC::JITCode::JITCode): (JSC::JITCode::operator bool): (JSC::JITCode::addressForCall): (JSC::JITCode::offsetOf): (JSC::JITCode::execute): (JSC::JITCode::size): (JSC::JITCode::executablePool): (JSC::JITCode::HostFunction):
- jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
- jit/JITStubs.cpp: (JSC::JITStubs::cti_vm_dontLazyLinkCall): (JSC::JITStubs::cti_vm_lazyLinkCall):
- parser/Nodes.cpp: (JSC::ProgramNode::generateJITCode): (JSC::EvalNode::generateJITCode): (JSC::FunctionBodyNode::FunctionBodyNode): (JSC::FunctionBodyNode::createNativeThunk): (JSC::FunctionBodyNode::generateJITCode):
- parser/Nodes.h: (JSC::ScopeNode::generatedJITCode): (JSC::ScopeNode::getExecutablePool): (JSC::ScopeNode::setJITCode): (JSC::ProgramNode::jitCode): (JSC::EvalNode::jitCode): (JSC::FunctionBodyNode::jitCode):
- runtime/RegExp.cpp: (JSC::RegExp::match):
- yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::compile): (JSC::Yarr::jitCompileRegex): (JSC::Yarr::executeRegex):
- yarr/RegexJIT.h: (JSC::Yarr::RegexCodeBlock::RegexCodeBlock): (JSC::Yarr::RegexCodeBlock::pcreFallback): (JSC::Yarr::RegexCodeBlock::setFallback): (JSC::Yarr::RegexCodeBlock::operator bool): (JSC::Yarr::RegexCodeBlock::set): (JSC::Yarr::RegexCodeBlock::execute):
- 6:55 PM Changeset in webkit [44029] by
-
- 5 edits1 add in trunk/WebCore
2009-05-21 Albert J. Wong <ajwong@chromium.org>
Reviewed by Eric Seidel.
Bug 25903: Create a default UI theme for media controls in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=25903
Implement a default UI for chromium. Add a style sheet for Chromium
media controls with good defaults and implemented basic draw functions
for play/pause & mute buttons.
- css/mediaControlsChromium.css: Added.
- rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumWin::extraMediaControlsStyleSheet): Export our custom media controls style sheet. (WebCore::RenderThemeChromiumLinux::paintMediaButtonInternal): Paint buttons respecting chromium media controls color scheme. (WebCore::RenderThemeChromiumLinux::paintMediaPlayButton): Paint logic specific to play/pause button. (WebCore::RenderThemeChromiumLinux::paintMediaMuteButton): Paint specific to mute button.
- rendering/RenderThemeChromiumLinux.h: Appropriate header changes.
- rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::extraMediaControlsStyleSheet): Export our custom media controls style sheet. (WebCore::RenderThemeChromiumWin::paintMediaButtonInternal): Paint buttons respecting chromium media controls color scheme. (WebCore::RenderThemeChromiumWin::paintMediaPlayButton): Paint logic specific to play/pause button. (WebCore::RenderThemeChromiumWin::paintMediaMuteButton): Paint specific to mute button. (WebCore::RenderThemeChromiumWin::setDefaultFontSize): Appropriate header changes.
- rendering/RenderThemeChromiumWin.h:
- 6:48 PM Changeset in webkit [44028] by
-
- 4 adds in branches/WWDC-2009-branch/LayoutTests/http/tests
Merge r44027.
- 6:46 PM Changeset in webkit [44027] by
-
- 4 adds in trunk/LayoutTests/http/tests
Checked in layout tests I accidentally left out of my last check-in.
- 6:39 PM Changeset in webkit [44026] by
-
- 4 edits3 adds in branches/WWDC-2009-branch
Merge r44016.
- 6:39 PM Changeset in webkit [44025] by
-
- 2 edits in branches/WWDC-2009-branch/WebCore
Merge r44011.
- 6:39 PM Changeset in webkit [44024] by
-
- 3 edits in branches/WWDC-2009-branch
Merge r44010.
- 6:38 PM Changeset in webkit [44023] by
-
- 2 edits in branches/WWDC-2009-branch/WebCore
Merge r43993.
- 6:38 PM Changeset in webkit [44022] by
-
- 2 edits in branches/WWDC-2009-branch/JavaScriptCore
Merge r43976.
- 6:38 PM Changeset in webkit [44021] by
-
- 2 edits in branches/WWDC-2009-branch/WebKit/mac
Merge r43970.
- 6:35 PM Changeset in webkit [44020] by
-
- 3 edits in trunk/WebKitTools
2009-05-21 Eric Seidel <eric@webkit.org>
Rubber-stamped by Antti Koivisto.
Make it possible to write js-only http tests by exposing a /js-test-resources alias.
https://bugs.webkit.org/show_bug.cgi?id=25915
Second attempt at landing, now using -c instead of -C to make sure
that mod_alias is loaded on Apache 1.x instances before using Alias.
- Scripts/run-webkit-httpd:
- Scripts/run-webkit-tests:
- 6:33 PM Changeset in webkit [44019] by
-
- 6 edits in branches/nitro-extreme/JavaScriptCore
2009-05-21 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Implement op_negate inline fast cases.
- assembler/MacroAssemblerX86Common.h: (JSC::MacroAssemblerX86Common::neg32):
- assembler/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::negl_m): (JSC::X86Assembler::xorpd_rr):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_negate): (JSC::JIT::emitSlow_op_negate):
- 6:10 PM Changeset in webkit [44018] by
-
- 2 edits in trunk/WebCore
Reviewed by Kevin Ollivier.
When stripping the query from a file:// URL, do not leave a trailing question mark.
https://bugs.webkit.org/show_bug.cgi?id=25940
- 5:57 PM Changeset in webkit [44017] by
-
- 2 edits in trunk/WebCore
Reviewed by Kevin Ollivier.
Notify ImageObserver::didDraw to help the cache purge alive resources.
- 5:28 PM Changeset in webkit [44016] by
-
- 4 edits3 adds in trunk
<rdar://problem/6910264> REGRESSION: Cached DOM global object property access fails in browser (25921)
<https://bugs.webkit.org/show_bug.cgi?id=25921>
Reviewed by Maciej Stachowiak.
When caching properties on the global object we need to ensure that we're
not attempting to cache through a shell object.
- 5:15 PM Changeset in webkit [44015] by
-
- 2 edits in trunk/WebCore
2009-05-21 Evan Martin <evan@chromium.org>
Reviewed by Eric Seidel.
Flesh out font fallback for Chromium's Skia port.
getLastResortFallbackFont should fall back on well-known fonts.
https://bugs.webkit.org/show_bug.cgi?id=25860
- platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::getLastResortFallbackFont): try known font names.
- 5:09 PM Changeset in webkit [44014] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix.
- JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
- 4:36 PM Changeset in webkit [44013] by
-
- 1 edit1 delete in branches/WWDC-2009-branch/LayoutTests
Merge r43891.
- 4:36 PM Changeset in webkit [44012] by
-
- 2 edits1 add1 delete in branches/WWDC-2009-branch
Merge r43880.
- 4:32 PM Changeset in webkit [44011] by
-
- 2 edits in trunk/WebCore
Reviewed by John Sullivan.
- speculative fix for <rdar://problem/6890716> crash at FontCache::purgeInactiveFontData + 199
- platform/graphics/FontCache.cpp: (WebCore::FontCache::purgeInactiveFontData): Deleting a SimpleFontData can cause releaseFontData() to be called, which modifies gInactiveFontData. Therefore, avoid deleting SimpleFontData instances while iterating over gInactiveFontData and delete them afterwards.
- 4:26 PM Changeset in webkit [44010] by
-
- 3 edits in trunk
WebCore:
2009-05-21 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Test for <rdar://problem/6910832> | https://bugs.webkit.org/show_bug.cgi?id=25907
Incorrect URL returned to the DOM while the user drags a file
- page/DragController.cpp: (WebCore::DragController::dragExited): (WebCore::DragController::tryDHTMLDrag): Don't base our decision on KURL, since that only looks at the text of the document's URL. Do base our decision on the securityOrigin(), which knows more about the document's actual origin.
LayoutTests:
2009-05-21 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Tests for <rdar://problem/6910832> | https://bugs.webkit.org/show_bug.cgi?id=25907
Incorrect URL returned to the DOM while the user drags a file
- http/tests/local/drag-over-remote-content-expected.txt: Added.
- http/tests/local/drag-over-remote-content.html: Added.
- http/tests/security/drag-over-remote-content-iframe-expected.txt: Added.
- http/tests/security/drag-over-remote-content-iframe.html: Added.
- 4:23 PM Changeset in webkit [44009] by
-
- 1 edit in trunk/WebCore/ChangeLog
Correct change log
- 4:23 PM Changeset in webkit [44008] by
-
- 3 edits in branches/WWDC-2009-branch/WebKit/mac
Merge r43973.
- 4:23 PM Changeset in webkit [44007] by
-
- 2 edits in branches/WWDC-2009-branch/WebKit/mac
Merge r43969.
- 4:22 PM Changeset in webkit [44006] by
-
- 12 edits2 adds in branches/WWDC-2009-branch
Merge r43964.
- 4:22 PM Changeset in webkit [44005] by
-
- 6 edits in branches/WWDC-2009-branch
Merge r43951.
- 4:22 PM Changeset in webkit [44004] by
-
- 2 edits in branches/WWDC-2009-branch/WebCore
Merge r43942.
- 4:22 PM Changeset in webkit [44003] by
-
- 2 edits in branches/WWDC-2009-branch/WebKit/mac
Merge r43937.
- 4:22 PM Changeset in webkit [44002] by
-
- 2 edits in branches/WWDC-2009-branch/WebKit/mac
Merge r43931.
- 4:22 PM Changeset in webkit [44001] by
-
- 3 edits in branches/WWDC-2009-branch/WebCore
Merge r43949.
- 4:22 PM Changeset in webkit [44000] by
-
- 2 edits in trunk/WebCore
Rubber-stamped by Mark Rowe.
- fix https://bugs.webkit.org/show_bug.cgi?id=25947 Assertion failure in FrameLoader::transitionToCommitted on launch in Safari with r43985
Rolled out r43985.
- platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedNonImageMimeTypes): (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
- 4:22 PM Changeset in webkit [43999] by
-
- 13 edits2 adds in branches/WWDC-2009-branch
Merge r43929.
- 4:22 PM Changeset in webkit [43998] by
-
- 2 edits in branches/WWDC-2009-branch/WebKit/mac
Merge r43912.
- 4:22 PM Changeset in webkit [43997] by
-
- 4 edits in branches/WWDC-2009-branch/WebCore
Merge r43878.
- 4:22 PM Changeset in webkit [43996] by
-
- 3 edits2 adds in branches/WWDC-2009-branch
Merge r43876.
- 4:22 PM Changeset in webkit [43995] by
-
- 5 edits in branches/WWDC-2009-branch
Merge r43869.
- 4:21 PM Changeset in webkit [43994] by
-
- 3 edits in branches/WWDC-2009-branch/WebCore
Merge r43866.
- 4:00 PM Changeset in webkit [43993] by
-
- 2 edits in trunk/WebCore
2009-05-21 Sam Weinig <sam@webkit.org>
Reviewed by Brady Eidson and Mark Rowe.
Fix for <rdar://problem/6901522>
REGRESSION: Office 2008: Preview with browser is not shown, and Finder window is in the front of Safari
If the NSURLRequest is annotated with a "ForceHTMLMIMEType" property, force
the MIME type to be text/html.
- platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
- 3:56 PM Changeset in webkit [43992] by
-
- 2 edits in trunk/WebCore
Blind windows fix after last commit.
- 3:42 PM Changeset in webkit [43991] by
-
- 2 edits in trunk/LayoutTests
2009-05-21 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Fixing test to actually use the correct names for the frames.
- http/tests/mime/accept-all-text-types.html:
- 3:29 PM Changeset in webkit [43990] by
-
- 4 edits in trunk/WebCore
Reviewed by Kevin Ollivier.
Use an environment variable to control which logs are on and off.
Also, make a generic function for translating channel name to its log.
https://bugs.webkit.org/show_bug.cgi?id=25936
- 3:15 PM Changeset in webkit [43989] by
-
- 2 edits in trunk/LayoutTests
2009-05-21 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Disable 2 more tests that sometimes fail.
- platform/gtk/Skipped:
- 3:12 PM Changeset in webkit [43988] by
-
- 3 edits in trunk/JavaScriptCore
2009-05-21 Cameron Zwarich <zwarich@apple.com>
Reviewed by Mark Rowe.
Bug 25945: Add support for MADV_FREE to TCMalloc
<https://bugs.webkit.org/show_bug.cgi?id=25945>
<rdar://problem/6910754>
Add support for MADV_FREE to TCMalloc_SystemRelease for platforms that
don't also support MADV_FREE_REUSE. The code is identical to the MADV_DONTNEED
case except for the advice passed to madvise(), so combining the two cases
makes the most sense.
- wtf/Platform.h: Only define HAVE_MADV_FREE when not building on Tiger or Leopard, because while it is defined on these platforms it actually does nothing.
- wtf/TCSystemAlloc.cpp: (TCMalloc_SystemRelease): use MADV_FREE if it is available; otherwise use MADV_DONTNEED.
- 3:07 PM Changeset in webkit [43987] by
-
- 3 edits in trunk/WebKit/wx
wx build fix after method added to EditorClient.
- 2:54 PM Changeset in webkit [43986] by
-
- 1 edit1 add in trunk/LayoutTests
2009-05-21 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Adding file I forgot to add to last commit.
- http/tests/mime/resources/accept-all-text-types.cgi: Added.
- 2:47 PM Changeset in webkit [43985] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-05-21 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Darin Adler.
Test that WebKit accepts any text/* type.
- http/tests/mime/accept-all-text-types-expected.txt: Added.
- http/tests/mime/accept-all-text-types.html: Added.
- 2:36 PM Changeset in webkit [43984] by
-
- 2 edits in trunk/WebKit/mac
2009-05-21 Darin Fisher <darin@chromium.org>
Fix-up coding style.
- WebCoreSupport/WebEditorClient.mm: (WebEditorClient::getAutoCorrectSuggestionForMisspelledWord):
- 2:36 PM Changeset in webkit [43983] by
-
- 2 edits in trunk/WebKit/win
2009-05-21 Darin Fisher <darin@chromium.org>
Fix-up coding style.
- WebCoreSupport/WebEditorClient.cpp: (WebEditorClient::getAutoCorrectSuggestionForMisspelledWord):
- 2:35 PM Changeset in webkit [43982] by
-
- 3 edits in trunk/WebKit/gtk
2009-05-21 Darin Fisher <darin@chromium.org>
Fix build bustage.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::getAutoCorrectSuggestionForMisspelledWord): Add stub for method.
- WebCoreSupport/EditorClientGtk.h:
- 2:19 PM Changeset in webkit [43981] by
-
- 2 edits in trunk/WebCore
2009-05-21 David Levin <levin@chromium.org>
Reviewed by Darin Fisher.
Bug 25946: Chromium needs MIMETypeRegistry::getMediaMIMETypeForExtension implementation.
https://bugs.webkit.org/show_bug.cgi?id=25946
A very simple implementation to keep it working. A bug has been filed in the chromium db
(http://code.google.com/p/chromium/issues/detail?id=12441) to investigate doing something more
complete.
- platform/chromium/MimeTypeRegistryChromium.cpp: (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension):
- 2:02 PM Changeset in webkit [43980] by
-
- 11 edits in trunk
2009-05-20 Siddhartha Chattopadhyaya <sidchat@google.com>
Reviewed by Justin Garcia.
Add automatic spell correction support in WebKit
- editing/Editor.cpp: (WebCore::findFirstMisspellingInRange): (WebCore::Editor::advanceToNextMisspelling): (WebCore::Editor::markMisspellingsAfterTypingToPosition): (WebCore::markAllMisspellingsInRange): (WebCore::markMisspellingsOrBadGrammar): (WebCore::Editor::markMisspellings): (WebCore::Editor::markBadGrammar): (WebCore::Editor::markMisspellingsAndBadGrammar):
- editing/Editor.h:
- loader/EmptyClients.h: (WebCore::EmptyEditorClient::getAutoCorrectSuggestionForMisspelledWord):
- page/EditorClient.h:
- 1:57 PM Changeset in webkit [43979] by
-
- 2 edits in trunk/WebCore
2009-05-21 Christian Dywan <christian@twotoasts.de>
Reviewed by Darin Adler.
Text files which have sub MIME types are treated as not displayable
http://bugs.webkit.org/show_bug.cgi?id=24903
- platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedNonImageMimeTypes): (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType): Regard any MIME type beginning with "text/" as supported and remove all "text/" types from the list.
- 1:54 PM Changeset in webkit [43978] by
-
- 4 edits in trunk
LayoutTests
2009-05-21 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Disable failing HTTP tests now that we are enabling HTTP on the
bot.
- platform/gtk/Skipped:
WebKitTools
2009-05-21 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Default to running HTTP tests for GTK+.
- Scripts/run-webkit-tests:
- 1:30 PM Changeset in webkit [43977] by
-
- 3 edits in trunk/WebKitTools
2009-05-21 Darin Adler <Darin Adler>
Rolled the httpd changes out, since many machines (including the bots)
have an older version of Apache that does not support the Alias command.
Or maybe it's something else, but the bots are failing.
- Scripts/run-webkit-httpd: Rolled back.
- Scripts/run-webkit-tests: Ditto.
- 12:57 PM Changeset in webkit [43976] by
-
- 2 edits in trunk/JavaScriptCore
Fix <https://bugs.webkit.org/show_bug.cgi?id=25917> / <rdar://problem/6910066>.
Bug 25917: REGRESSION (r43559?): Javascript debugger crashes when pausing page
Reviewed by Oliver Hunt.
The debugger currently retrieves the arguments object from an activation rather than pulling
it from a call frame. This is unreliable to due to the recent optimization to lazily create
the arguments object. In the long-term it should stop doing that (<rdar://problem/6911886>),
but for now we force eager creation of the arguments object when debugging.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- 12:25 PM Changeset in webkit [43975] by
-
- 3 edits in trunk/WebKitTools
2009-05-21 Eric Seidel <eric@webkit.org>
Reviewed by Geoffrey Garen.
Make it possible to write js-only http tests by exposing a /js-test-resources alias.
https://bugs.webkit.org/show_bug.cgi?id=25915
- Scripts/run-webkit-httpd:
- Scripts/run-webkit-tests:
- 11:51 AM Changeset in webkit [43974] by
-
- 2 edits in trunk/WebCore
Reviewed by David Kilzer.
https://bugs.webkit.org/show_bug.cgi?id=25890
Implement Network logging channel on Mac
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel): (WebCore::ResourceHandle::setDefersLoading): (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): (-[WebCoreResourceHandleAsDelegate connectionShouldUseCredentialStorage:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]): (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]): (-[WebCoreResourceHandleAsDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]): (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]): (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]): Added logging for async requests (as these are most interesting).
- 11:19 AM Changeset in webkit [43973] by
-
- 3 edits in trunk/WebKit/mac
Reviewed by Darin Adler.
<rdar://problem/6907542> REGRESSION (r43143): Hang in RenderLineBoxList::dirtyLinesFromChangedChild
when clicking link to load Flash animation (http://www.roambi.com)
- WebCoreSupport/WebEditorClient.mm: (WebEditorClient::respondToChangedSelection): Don't call -[NSApplication updateWindows] here, WebHTMLView can take care of this.
- WebView/WebHTMLView.mm: (-[WebHTMLView inputContext]): Use a precomputed boolean stored in WebHTMLViewPrivate, as calling isTextInput() is not always safe. (-[WebHTMLView textStorage]): Ditto. (-[WebHTMLView _updateSelectionForInputManager]): Update _private->exposeInputContext when selection changes, and let AppKit update its cache if necessary.
- 11:17 AM Changeset in webkit [43972] by
-
- 5 edits in trunk/WebCore
2009-05-21 Eric Carlson <eric.carlson@apple.com>
Reviewed by David Kilzer.
<rdar://problem/6902197> WebCore doesn't know about all of the MIME types supported by QTKit
Add a static table to map from some common file extensions to their MIME types so it
is possible to detect support even when the platform mapping is incomplete. Use the
table to lookup types not found by UTI on the OSX, and when looking for a media engine
with a generic or missing type.
- platform/MIMETypeRegistry.cpp: (WebCore::initializeMediaTypeMaps): New, initialize the mediaMIMETypeForExtensionMap. (WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension): New. Look for the specified MIME type in the static mapping table if the platform specific getMIMETypeForExtension doesn't find a match.
- platform/MIMETypeRegistry.h: Declare getMediaMIMETypeForExtension.
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::load): When the type passed is empty, "application/octet-stream", or "text/plain", try to look it up based on the file extension with getMediaMIMETypeForExtension.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::addFileTypesToCache): See if getMediaMIMETypeForExtension can map from file extension to MIME type if UTI fails.
- 9:36 AM Changeset in webkit [43971] by
-
- 3 edits in trunk/WebKitTools
2009-05-21 Andre Pedralho <andre.pedralho@openbossa.org>
Reviewed by Gustavo Noronha.
Added --makeargs flag to the build script.
- Scripts/build-webkit:
- Scripts/webkitdirs.pm:
- 9:29 AM Changeset in webkit [43970] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Darin Adler.
<rdar://problem/5579292> REGRESSION (2-3): "Default default" encoding for Korean changed
from Korean (Windows, DOS) to Korean (ISO 2022-KR), which breaks some sites
- WebView/WebPreferences.mm:
(+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]): Update the existing fix
for the changed result of CFStringConvertEncodingToIANACharSetName().
- 9:03 AM Changeset in webkit [43969] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Darin Adler.
<rdar://problem/6883758> REGRESSION (r43143): First character typed with input method does
not go into inline hole (seen with Chinese & Kotoeri on top Chinese website www.baidu.com)
- WebCoreSupport/WebEditorClient.mm: (WebEditorClient::respondToChangedSelection): Call -[NSApplication updateWindows] to make AppKit re-fetch the input context when selection changes. Since we use SelectionController to check whether the view is editable, it is important not to re-fetch the context too early, e.g. from a focus changed notification.
- 7:05 AM Changeset in webkit [43968] by
-
- 4 edits in trunk/WebCore
2009-05-21 Eric Seidel <eric@webkit.org>
Reviewed by Alexey Proskuryakov.
Clean up DragController
https://bugs.webkit.org/show_bug.cgi?id=25926
I renamed m_document to m_documentUnderMouse to better document what it does
I could call it m_lastDocumentUnderMouse to be most-accurate, but this seemed
long enough.
I also saw copy/paste code involving clearing the selection when moving out of
one document and into another. I moved that code into a function called
mouseMovedIntoDocument.
I also got rid of a couple needless null-checks after confirming via source
inspection they were not ever possible.
In Mac WebKit it's not possible to have a Page that doesn't have a mainFrame()
I left an ASSERT(m_page->mainFrame()) in case some other port ever violates this.
It's also not possible to return a document from documentAtPoint that is not
in a frame (as such a document would not be rendered).
No functional changes, thus no tests.
- page/DragController.cpp: (WebCore::DragController::DragController): (WebCore::DragController::dragIsMove): (WebCore::DragController::dragExited): (WebCore::DragController::performDrag): (WebCore::DragController::mouseMovedIntoDocument): (WebCore::DragController::dragEnteredOrUpdated): (WebCore::DragController::tryDocumentDrag): (WebCore::DragController::operationForLoad): (WebCore::DragController::concludeEditDrag): (WebCore::DragController::canProcessDrag): (WebCore::DragController::tryDHTMLDrag): (WebCore::DragController::placeDragCaret):
- page/DragController.h: (WebCore::DragController::documentUnderMouse):
- 5:50 AM Changeset in webkit [43967] by
-
- 5 edits in trunk
2009-05-21 Eric Seidel <eric@webkit.org>
Reviewed by Alexey Proskuryakov.
Rename DragController::dragOperation() to sourceDragOperation() for clarity
Remove unused setDragOperation()
There are two times DragOperation is used. The source specifies
what drag operations it supports (in a mask) and the destination
picks a subset of those as DragOperations it supports if a drop were
to occur. I was confused when I first saw this accessor as to which
it meant. It turns out that this is only used when WebKit starts a
drag, and we keep it around so that we can provide this information
to other Mac OS X applications when they ask. I've renamed the method
for clarity so the next person in this code will be less confused.
No functional changes, thus no tests.
- page/DragController.h: (WebCore::DragController::sourceDragOperation):
- 5:34 AM Changeset in webkit [43966] by
-
- 1 edit2 adds in trunk/LayoutTests
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=19517
<rdar://problem/6007112> DOM modification of textArea causes Access Violation (NULL pointer?)
This no longer happens with ToT, just adding a test.
- fast/parser/head-parsing-19517-expected.txt: Added.
- fast/parser/head-parsing-19517.html: Added.
- 2:30 AM Changeset in webkit [43965] by
-
- 2 edits in trunk/WebKitLibraries
Rubber-stamped by Mark Rowe.
- correct a copyright header accidently reverted in r43964
- WebKitSystemInterface.h:
- 2:16 AM Changeset in webkit [43964] by
-
- 12 edits2 adds in trunk
WebCore:
Reviewed by Anders Carlsson.
- WebCore part of <rdar://problem/6901751> REGRESSION (r35515): Tiger crash painting the selection on registration page of car2go.com
A bug in old versions of Core Graphics causes memory corruption to occur
when clipping under certain conditions. Make the clipping functions
fail silently under those conditions.
Test: fast/block/float/selection-gap-clip-out-tiger-crash.html
- WebCore.Tiger.exp: Added wkCGContextIsSafeToClip
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::safeCGContextClip): Added a wrapper around CGContextClip that, on Tiger, bails out if wkCGContextIsSafeToClip() returns false. (WebCore::safeCGContextEOClip): Ditto for CGContextEOClip. (WebCore::safeCGContextClipToRect): Ditto for CGContextClipToRect. (WebCore::GraphicsContext::fillPath): Changed to call the safe variants of CGContextClip, CGContextEOClip and CGContextClipToRect. (WebCore::GraphicsContext::strokePath): Ditto. (WebCore::GraphicsContext::fillRect): Ditto. (WebCore::GraphicsContext::clip): Ditto. (WebCore::GraphicsContext::clipOut): Ditto. (WebCore::GraphicsContext::clipOutEllipseInRect): Ditto. (WebCore::GraphicsContext::clipPath): Ditto. (WebCore::GraphicsContext::addInnerRoundedRectClip): Ditto. (WebCore::GraphicsContext::strokeRect): Ditto.
- platform/mac/WebCoreSystemInterface.h: Added wkCGContextIsSafeToClip.
- platform/mac/WebCoreSystemInterface.mm: Added wkCGContextIsSafeToClip.
WebKit/mac:
Reviewed by Anders Carlsson.
- WebKit part of <rdar://problem/6901751> REGRESSION (r35515): Tiger crash painting the selection on registration page of car2go.com
- WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Added CGContextIsSafeToClip.
WebKitLibraries:
Reviewed by Anders Carlsson.
- WebKitSystemInterface part of <rdar://problem/6901751> REGRESSION (r35515): Tiger crash painting the selection on registration page of car2go.com
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceTiger.a:
LayoutTests:
Reviewed by Anders Carlsson.
- test for <rdar://problem/6901751> REGRESSION (r35515): Tiger crash painting the selection on registration page of car2go.com
- fast/block/float/selection-gap-clip-out-tiger-crash-expected.txt: Added.
- fast/block/float/selection-gap-clip-out-tiger-crash.html: Added.
- 2:08 AM Changeset in webkit [43963] by
-
- 2 edits in trunk/WebCore
2009-05-21 Xan Lopez <xlopez@igalia.com>
Unreviewed build fix.
https://bugs.webkit.org/show_bug.cgi?id=25910
WebkitGTK r43960 cannot compile
Do not include local copy of guriescape header, which was
removed. We now use the copy in glib.
- platform/gtk/FileSystemGtk.cpp:
- 1:41 AM Changeset in webkit [43962] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-21 Cameron Zwarich <zwarich@apple.com>
Reviewed by Maciej Stachowiak.
Bug 25912: Harden NumberPrototype.cpp by removing use of strcpy()
<https://bugs.webkit.org/show_bug.cgi?id=25912>
This causes no change on SunSpider.
- runtime/NumberPrototype.cpp: (JSC::integerPartNoExp): replace strcpy() with memcpy(), ASSERT that the temporary buffer has sufficient space to store the result, and move the explicit null-termination closer to the memcpy() for easier visual inspection of the code. (JSC::fractionalPartToString): replace strcpy() with memcpy(), and ASSERT that the temporary buffer has sufficient space to store the result. There is no explicit null-termination because this is done by the caller. The same is already true for exponentialPartToString(). (JSC::numberProtoFuncToExponential): replace strcpy() with memcpy(), explicitly null-terminate the result, and ASSERT that the temporary buffer has sufficient space to store the result.
- 1:02 AM Changeset in webkit [43961] by
-
- 3 edits in trunk/LayoutTests
2009-05-21 Eric Seidel <eric@webkit.org>
Reviewed by Alexey Proskuryakov.
Fix file-input-files-access which was passing for the wrong reasons.
The log was pushing the drop target off screen and the drops were failing!
- editing/pasteboard/file-input-files-access-expected.txt:
- editing/pasteboard/resources/file-input-files-access.js: (testOrderedDraggingWithDirectory): (runTest):
May 20, 2009:
- 10:52 PM Changeset in webkit [43960] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-20 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Cleanup the JSGlobalData when exiting early with the usage statement in jsc.
- jsc.cpp: (printUsageStatement): (parseArguments): (jscmain):
- 10:46 PM Changeset in webkit [43959] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-20 Sam Weinig <sam@webkit.org>
Reviewed by Gavin Barraclough.
Update the patchOffsetGetByIdSlowCaseCall constant for the
case that OPCODE_SAMPLING is enabled.
- jit/JIT.h:
- 9:06 PM Changeset in webkit [43958] by
-
- 2 edits in trunk/WebCore
2009-05-20 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
It turns out the CurrentContext wasn't currect either because it gave
us the frame for the write() function itself. We actually want the
*calling* context.
- bindings/v8/custom/V8HTMLDocumentCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
- 7:52 PM Changeset in webkit [43957] by
-
- 2 edits in trunk/LayoutTests
2009-05-20 Gustavo Noronha Silva <Gustavo Noronha Silva>
Skipping a new test.
- platform/gtk/Skipped:
- 7:45 PM Changeset in webkit [43956] by
-
- 2 edits in trunk/LayoutTests
2009-05-20 Gustavo Noronha Silva <Gustavo Noronha Silva>
Skipping test that fails intermitently.
- platform/gtk/Skipped:
- 7:43 PM Changeset in webkit [43955] by
-
- 4 edits1 add in trunk/WebCore
[GTK] Implement Image::loadPlatformResource.
Install the four resources we are using. For the icons
where an icon name is specified by freedeskop.org try to
map the WebCore name to that name and fallback to the
internal icon. For everything else use the internal icon
name. Remove the temporary link stub as this is not
required any more.
- 7:42 PM Changeset in webkit [43954] by
-
- 2 edits in trunk/WebCore
[GTK] Gtk+ wants to have a themable urlIcon too.
- 7:41 PM Changeset in webkit [43953] by
-
- 1 edit2 adds in trunk/LayoutTests
2009-05-20 Gustavo Noronha Silva <Gustavo Noronha Silva>
Rubber-stamped by Mark Rowe.
Add GTK+-specific results for canvas-composite-alpha. This test
has 'failing' cases that pass on GTK+/cairo.
- platform/gtk/fast/canvas/canvas-composite-alpha-expected.txt: Added.
- 7:28 PM Changeset in webkit [43952] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-20 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Added support for inline subtraction of doubles.
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_sub): (JSC::JIT::emitSlow_op_sub): (JSC::JIT::emitSlowSub32InPlaceLeft): (JSC::JIT::emitBinaryDoubleOp):
- 7:22 PM Changeset in webkit [43951] by
-
- 6 edits in trunk
2009-05-20 Stephanie Lewis <Stephanie Lewis>
Update the order files. <rdar://problem/6881750> Generate new order files.
- JavaScriptCore.order:
- WebCore.order:
- WebKit.order:
- 7:19 PM Changeset in webkit [43950] by
-
- 9 edits in branches/nitro-extreme/JavaScriptCore
2009-05-20 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Added support for inline division.
- assembler/X86Assembler.h: (JSC::X86Assembler::): (JSC::X86Assembler::divsd_rr): (JSC::X86Assembler::divsd_mr):
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
- bytecode/Opcode.h:
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitBinaryOp):
- interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emitBinaryDoubleOp): (JSC::JIT::emit_op_div): (JSC::JIT::emitSlow_op_div):
- 7:14 PM Changeset in webkit [43949] by
-
- 3 edits in trunk/WebCore
Fix some assertion failures in plug-in tests on the Windows debug build bot.
Reviewed by Gavin Barraclough.
- plugins/PluginStream.cpp:
(WebCore::PluginStream::startStream): Switch to using protocolIsJavaScript.
- plugins/PluginView.cpp:
(WebCore::scriptStringIfJavaScriptURL): Ditto.
- 6:31 PM Changeset in webkit [43948] by
-
- 2 edits in branches/nitro-extreme/JavaScriptCore
2009-05-20 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Added support for inline addition of doubles.
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_add): (JSC::JIT::emitSlow_op_add): (JSC::JIT::emitSlowAdd32InPlace): (JSC::JIT::emitBinaryDoubleOp): (JSC::JIT::emit_op_mul): (JSC::JIT::emitSlow_op_mul):
- 5:16 PM Changeset in webkit [43947] by
-
- 3 edits in branches/nitro-extreme/JavaScriptCore
2009-05-20 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Factored inline double operations into a helper function, so that we
can reuse this code for other math operations.
- jit/JIT.h:
- jit/JITArithmetic.cpp: (JSC::JIT::emitBinaryDoubleOp): (JSC::JIT::emit_op_mul):
- jit/JITCall.cpp: (JSC::JIT::compileOpCallInitializeCallFrame):
- 4:58 PM Changeset in webkit [43946] by
-
- 4 edits in trunk
WebCore:
2009-05-20 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
More protocolInHTTPFamily() cleanup.
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send):
WebKit/win:
2009-05-20 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
More protocolInHTTPFamily() cleanup.
- WebHistory.cpp: (WebHistory::visitedURL):
- 4:57 PM Changeset in webkit [43945] by
-
- 5 edits in branches/nitro-extreme/JavaScriptCore
2009-05-20 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Added support for inline multiplication of doubles.
- assembler/X86Assembler.h: (JSC::X86Assembler::cvtsi2sd_mr): New function, useful for loading an int32 into a double register.
- jit/JITArithmetic.cpp: (JSC::JIT::emit_op_mul): (JSC::JIT::emitSlow_op_mul): Filled out these cases for double arithmetic.
- jit/JIT.h:
- jit/JITInlineMethods.h: (JSC::JIT::addressFor): New function, useful for addressing a JSValue's full 64bits as a double.
- 4:57 PM Changeset in webkit [43944] by
-
- 3 edits in trunk/WebKitSite
Prevent search engines from getting creative in their descriptions of webkit.org content.
Rubber-stamped by Eric Seidel.
- blog/wp-content/themes/webkit/header.php:
- header.inc:
- 4:37 PM Changeset in webkit [43943] by
-
- 2 edits in trunk/WebCore
2009-05-21 Christian Dywan <christian@twotoasts.de>
Reviewed by Jan Alonzo.
- platform/network/soup/ResourceHandleSoup.cpp: (WebCore::parseDataUrl): Always use Glib Base64 decoding.
- 4:36 PM Changeset in webkit [43942] by
-
- 2 edits in trunk/WebCore
2009-05-20 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
Fix for <rdar://problem/6905475>
Office 2008: Entourage: Crash when you switch to "My Day" view
The host function callback callObjCFallbackObject was not annotated
with JSC_HOST_CALL which meant that when it was called by the JIT, which
expects the JSC_HOST_CALL calling convention, the arguments are not in the
expected places.
- bridge/objc/objc_runtime.mm: (JSC::Bindings::callObjCFallbackObject): Added missing JSC_HOST_CALL annotation on callObjCFallbackObject.
- 4:32 PM Changeset in webkit [43941] by
-
- 2 edits in trunk/WebCore
2009-05-20 David Levin <levin@chromium.org>
Not Reviewed, build fix.
Need to disable this assert while the chormium code is fixed for it.
- platform/KURLGoogle.cpp: (WebCore::KURL::protocolIs):
- 4:13 PM Changeset in webkit [43940] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Added bugs.webkit.org URL
- 4:09 PM Changeset in webkit [43939] by
-
- 2 edits3 adds in trunk/LayoutTests
Test for <rdar://problem/5666078> Cookie parsing terminates at the first semicolon, ignoring quotes (16699)
Reviewed by Brady Eidson.
- http/tests/cookies/double-quoted-value-with-semi-colon-expected.txt: Added.
- http/tests/cookies/double-quoted-value-with-semi-colon.html: Added.
- http/tests/cookies/resources/double-quoted-value-with-semi-colon.js: Added.
- platform/mac-tiger/Skipped: Added double-quoted-value-with-semi-colon.html since CFNetwork on Tiger stops parsing cookie values when it sees a semi-colon, even inside double quotes.
- 4:01 PM Changeset in webkit [43938] by
-
- 2 edits in trunk/WebCore
2009-05-20 David Levin <levin@chromium.org>
Not Reviewed, build fix.
Change KURLGoogle.cpp to mirror the KURL.cpp changes done in
http://trac.webkit.org/changeset/43929. Fix assert placement.
- platform/KURLGoogle.cpp: (WebCore::KURL::protocolIs): (WebCore::protocolIs):
- 3:35 PM Changeset in webkit [43937] by
-
- 2 edits in trunk/WebKit/mac
2009-05-20 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
<rdar://problem/6905336> REGRESSION: "Clear History" does not save empty history to disk
- History/WebHistory.mm: (-[WebHistoryPrivate data]): If there are no entries, return an empty NSData instead of nil.
- 3:26 PM Changeset in webkit [43936] by
-
- 2 edits in trunk/WebCore
2009-05-20 Nate Chapin <japhet@google.com>
Reviewed by Dimitri Glazkov.
Upstream V8 bindings for V8DomWindow.
https://bugs.webkit.org/show_bug.cgi?id=25869
- bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetTimeoutImpl): Moved from v8_custom.cpp. (WebCore::isAscii): Moved from v8_custom.cpp. (WebCore::convertBase64): Moved from v8_custom.cpp. (WebCore::CALLBACK_FUNC_DECL): Moved from v8_custom.cpp. (WebCore::eventNameFromAttributeName): Moved from v8_custom.cpp. (WebCore::ACCESSOR_SETTER): Moved from v8_custom.cpp. (WebCore::ACCESSOR_GETTER): Moved from v8_custom.cpp. (WebCore::NAMED_ACCESS_CHECK): Moved from v8_custom.cpp. (WebCore::INDEXED_ACCESS_CHECK): Moved from v8_custom.cpp.
- 3:18 PM Changeset in webkit [43935] by
-
- 2 edits in trunk/WebCore
2009-05-21 Christian Dywan <christian@twotoasts.de>
Rubberstamped by Gustavo Noronha.
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::parseDataUrl): Remove Gtk/ Glib Base64 decoding.
- 3:04 PM Changeset in webkit [43934] by
-
- 2 edits2 deletes in trunk/WebCore
2009-05-20 Christian Dywan <christian@twotoasts.de>
Reviewed by Gustavo Noronha.
- GNUmakefile.am:
- platform/gtk/guriescape.c:
- platform/gtk/guriescape.h: Remove copies of g_uri_escape_string and g_uri_unescape_string now that we require Glib 2.16.
- 1:55 PM Changeset in webkit [43933] by
-
- 2 edits in trunk/WebCore
2009-05-20 David Levin <levin@chromium.org>
Not Reviewed, build fix.
Change KURLGoogle.cpp to mirror changes done in
http://trac.webkit.org/changeset/43929.
- platform/KURLGoogle.cpp: (WebCore::protocolIsJavaScript): (WebCore::protocolIs):
- 12:53 PM Changeset in webkit [43932] by
-
- 5 edits in trunk/WebCore
2009-05-20 Brady Eidson <beidson@apple.com>
Rubberstamped by Sam Weinig
At all call sites that check if a KURL has either the http or https protocol,
use the KURL::protocolInHTTPFamily() accessor, instead.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::iconURL): (WebCore::FrameLoader::didOpenURL): (WebCore::FrameLoader::open):
- loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::requestIsHTTPOrHTTPSGet):
- loader/loader.cpp: (WebCore::Loader::load):
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send):
- 12:39 PM Changeset in webkit [43931] by
-
- 2 edits in trunk/WebKit/mac
2009-05-20 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler and Kevin Decker.
WebKit side of <rdar://problem/6895072>
Pass the localization as a launch property.
- Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost):
- 12:36 PM Changeset in webkit [43930] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix ChangeLog typo
- 12:31 PM Changeset in webkit [43929] by
-
- 13 edits2 adds in trunk
WebCore:
2009-05-20 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
Fix <rdar://problem/6904941> and https://bugs.webkit.org/show_bug.cgi?id=25300
KURL parsing changes back in r30243 and r30815 made javascript urls that use the form
"javascript://" be detected as invalid hierarchical URLs. When a KURL is marked as
invalid, you can no longer ask it a question such as "is your protocol javascript?"
Therefore FrameLoader wouldn't recognize them as javascript URLs and instead try to
navigated to them.
URL parsing rules aside, such URLs are in use in the wild (Microsoft's Virtual Earth
being a high profile example) and actually represent valid javascript.
Whenever checking for javascript urls, the new protocolIsJavaScript() should be used
as it functions on a String which doesn't have to pass KURLs parsing rules.
Test: fast/loader/javascript-url-hierarchical-execution.html
- bindings/js/JSAttrCustom.cpp: (WebCore::JSAttr::setValue): Use protocolIsJavaScript().
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): Ditto. (WebCore::createWindow): Ditto. (WebCore::JSDOMWindow::open): Ditto.
- bindings/js/JSElementCustom.cpp: (WebCore::allowSettingSrcToJavascriptURL): Ditto.
- bindings/js/JSHTMLFrameElementCustom.cpp: (WebCore::allowSettingJavascriptURL): Ditto.
- bindings/js/JSHTMLIFrameElementCustom.cpp: (WebCore::JSHTMLIFrameElement::setSrc): Ditto.
- bindings/js/JSLocationCustom.cpp: (WebCore::navigateIfAllowed): Ditto. (WebCore::JSLocation::reload): Ditto.
- editing/markup.cpp: (WebCore::appendQuotedURLAttributeValue): Ditto.
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::parseMappedAttribute): Ditto.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): Ditto. (WebCore::FrameLoader::submitForm): Ditto. (WebCore::FrameLoader::executeIfJavaScriptURL): Ditto.
- platform/KURL.cpp: (WebCore::KURL::init): Use protocolIsJavaScript(). (WebCore::KURL::protocolIs): ASSERT that the protocol being asked about is not javascript.
Such checks should go through protocolIsJavaScript() instead.
(WebCore::encodeRelativeString): Use protocolIsJavaScript().
(WebCore::protocolIsJavaScript):
- platform/KURL.h:
LayoutTests:
2009-05-20 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
Fix <rdar://problem/6904941> and https://bugs.webkit.org/show_bug.cgi?id=25300
- fast/loader/javascript-url-hierarchical-execution-expected.txt: Added.
- fast/loader/javascript-url-hierarchical-execution.html: Added.
- 12:30 PM Changeset in webkit [43928] by
-
- 4 edits in branches/WWDC-2009-branch
Versioning.
- 12:29 PM Changeset in webkit [43927] by
-
- 1 copy in tags/Safari-6530.11
New tag.
- 12:27 PM Changeset in webkit [43926] by
-
- 4 edits in trunk
Versioning.
- 12:21 PM Changeset in webkit [43925] by
-
- 2 edits in branches/WWDC-2009-branch/JavaScriptCore
Merge r43886.
- 12:21 PM Changeset in webkit [43924] by
-
- 3 edits in branches/WWDC-2009-branch/JavaScriptCore
Merge r43885.
- 10:35 AM Changeset in webkit [43923] by
-
- 6 edits2 adds in trunk
[plugins] PluginPackage*.cpp for Gtk+/Qt misassigned hasproperty and hasmethod
https://bugs.webkit.org/show_bug.cgi?id=24510
PluginPackageGtk.cpp and PluginPackageQt.cpp assigned _NPN_HasMethod
to hasproperty and _NPN_HasProperty to hashmethod. This commit is fixing
it. It is also adding test code to PluginObject.cpp and it will invoke
this code from a new test.
- 10:31 AM Changeset in webkit [43922] by
-
- 6 edits in trunk/WebCore
2009-05-20 Sam Weinig <sam@webkit.org>
Reviewed by Timothy Hatcher.
Make absoluteRectsForRange and absoluteQuadsForRange non-virtual
and only exist on RenderText.
- dom/Range.cpp: (WebCore::Range::textRects):
- inspector/InspectorController.cpp: (WebCore::InspectorController::drawNodeHighlight): Use absoluteQuads instead of absoluteQuadsForRange since no range is being specifiec.
- rendering/RenderObject.cpp:
- rendering/RenderObject.h:
- rendering/RenderText.h:
- 10:05 AM Changeset in webkit [43921] by
-
- 2 edits in trunk/WebKit/mac
- fix the build after r43918
- WebCoreSupport/WebChromeClient.h: (WebChromeClient::setCursor):
- 9:59 AM Changeset in webkit [43920] by
-
- 4 edits in trunk/WebCore
2009-05-20 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Implement AtkObject::focus-event and
AtkObject::state-changed:focused signal emission.
Adds a new handleFocusedUIElementChangedWithRenderers, only in the
GTK port, called at the same point than
handleFocusedUIElementChanged but with two parameters, the old and
the newly focused RenderObjects. We need this, since the ATK
signals require us to pass the objects involved in the focus
change as arguments.
- accessibility/AXObjectCache.h:
- accessibility/gtk/AXObjectCacheAtk.cpp: (WebCore::AXObjectCache::handleFocusedUIElementChangedWithRenderers):
- dom/Document.cpp: (WebCore::Document::setFocusedNode):
- 9:23 AM Changeset in webkit [43919] by
-
- 4 edits3 adds in trunk/WebKit/qt
2009-05-20 Ariya Hidayat <ariya.hidayat@nokia.com>
Reviewed by Simon Hausmann and Holger Freyther.
[Qt] Add renderHints property to QWebView.
- Api/qwebview.cpp: (QWebViewPrivate::QWebViewPrivate): (QWebView::renderHints): (QWebView::setRenderHints): (QWebView::setRenderHint): (QWebView::paintEvent):
- Api/qwebview.h:
- tests/qwebview/qwebview.pro: Added.
- tests/qwebview/tst_qwebview.cpp: Added. (tst_QWebView::tst_QWebView): (tst_QWebView::~tst_QWebView): (tst_QWebView::init): (tst_QWebView::cleanup): (tst_QWebView::renderHints):
- tests/tests.pro:
- 9:04 AM Changeset in webkit [43918] by
-
- 15 edits in trunk
[architecture] Make ChromeClient a interface again
https://bugs.webkit.org/show_bug.cgi?id=25834
With recent additions to ChromeClient.h empty defaults were
added. This is bad for porters as these changes go unnoticed
and at runtime no notImplemented warning is logged and grepping
for notImplemented will not show anything. Change this Client
to be like the other Clients again and always have pure virtuals
(but for stuff inside #ifdef PLATFORM(MAC)).
Update the various WebKit/* implementations to compile again.
- 8:34 AM Changeset in webkit [43917] by
-
- 2 edits in trunk/WebKit/qt
2009-05-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Simon Hausmann.
Fix a plugin bug in the WebKit code, similar to the one in WebCore.
The problem is when a non visible QtPluginWidget would show it self
in a sibling frame. The problem was due to our clipping. In Qt,
if setMask is set with an empty QRegion, no clipping will
be performed, so in that case we hide the PluginContainer
- 8:34 AM Changeset in webkit [43916] by
-
- 2 edits2 adds in trunk/WebCore
2009-05-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Simon Hausmann.
Fix a bug where a non visible plugin would show it self in a
sibling frame. The problem was due to our clipping. In Qt,
if setMask is set with an empty QRegion, no clipping will
be performed, so in that case we hide the PluginContainer
Added manual test.
- 8:32 AM Changeset in webkit [43915] by
-
- 2 edits in trunk/WebCore
2009-05-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Simon Hausmann.
Do not call the parent implementation (Widget::) in show() and hide()
of the PluginViewQt, as it always changes the visible state of the
platformWidget (equal to the platformPluginWidget in the Qt port),
thus ignoring the isParentVisible() test.
- 8:26 AM Changeset in webkit [43914] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Simon Hausmann.
Replace WREC with YARR + YARR_JIT for the Qt port. This is only
used when compiled with JIT support for now, so it is a drop-in
replacement for the WREC usage. Still including the wrec headers
as they are being referred from RegExp.h, though the contents of
that header it protected by "#if ENABLE(WREC)".
- 8:08 AM Changeset in webkit [43913] by
-
- 5 edits in trunk/WebCore
2009-05-20 Yichao Yin <yichao.yin@torchmobile.com.cn>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=23452
Change the implementation of HTMLNoScriptElement to avoid the pain of
adding virtual function for XHTMLMP support
Includes changes suggested by Simon Fraser.
- 8:06 AM Changeset in webkit [43912] by
-
- 2 edits in trunk/WebKit/mac
2009-05-20 Darin Adler <Darin Adler>
Reviewed by John Sullivan.
<rdar://problem/4023899> Shift-Tab skips key views in toolbar in Safari, although Tab
iterates through them properly
- WebView/WebView.mm: (-[WebView previousValidKeyView]): Work around a bug in -[NSView previousValidKeyView].
- 8:00 AM Changeset in webkit [43911] by
-
- 2 edits in trunk/WebCore
CURL backend build fix. Make sure URL is always set.
- 7:54 AM Changeset in webkit [43910] by
-
- 2 edits in trunk/WebCore
2009-05-20 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by George Staikos.
Fix Qt WebKit build break in Mac OS.
- platform/FileSystem.h:
- 7:51 AM Changeset in webkit [43909] by
-
- 2 edits in trunk/WebCore
2009-05-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Eric Seidel.
Enable code that was commented out waiting for a way to get a
GdkPixbuf from an image, effectively enabling copying images to
the clipboard.
- platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeImage):
- 7:33 AM Changeset in webkit [43908] by
-
- 2 edits in trunk/WebCore
2009-05-20 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=25414
[GTK] ROLE_PANEL should not be used for paragraphs and list items.
Implement Atk list item role for list items.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_role):
- 7:33 AM Changeset in webkit [43907] by
-
- 2 edits in trunk/WebCore
2009-05-20 Xan Lopez <xlopez@igalia.com>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=25414
[GTK] ROLE_PANEL should not be used for paragraphs and list items.
Implement Atk paragraph role for paragraph elements.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_role):
- 5:42 AM Changeset in webkit [43906] by
-
- 2 edits in trunk
2009-05-20 Eric Seidel <eric@webkit.org>
Fix bug URL in ChangeLogs in r43903.
https://bugs.webkit.org/show_bug.cgi?id=25742
- 5:37 AM Changeset in webkit [43905] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
2009-05-20 Eric Seidel <eric@webkit.org>
No review, build fix only.
Add files I missed in r43903.
Takeshi's patch was right, I just failed to add the files when landing.
- platform/mac/fast/forms/search-styled-expected.checksum: Added.
- platform/mac/fast/forms/search-styled-expected.png: Added.
- 5:37 AM Changeset in webkit [43904] by
-
- 2 adds in trunk/LayoutTests/platform/mac/fast/forms
Add files I missed in r43903
- 5:33 AM Changeset in webkit [43903] by
-
- 6 edits in trunk
2009-05-20 Takeshi Yoshino <tyoshino@google.com>
Reviewed by Eric Seidel.
Bug 24539: Fix RenderThemeChromiumWin::paintTextFieldInternal() not to hide background image.
https://bugs.webkit.org/show_bug.cgi?id=24539
Fix RenderThemeChromiumWin::paintTextFieldInternal().
We shouldn't paint the content area of text fields when o->style() has
background image or transparent background color. paintTextFieldInternal() is
used for painting inner area of HTML option elements by Chromium.
When we pass fillContentArea = true to ChromiumBridge::paintTextField, it hides
the background image rendered by RenderBoxModelObject. So, we should set
fillContentArea = false in such case.
Besides, when background-color:transparent is specified for CSS property,
o->style().backgroundColor returns black color with alpha channel == 0. But
since ThemeEngine for Windows behind ChromiumBridge::paintTextField cannot
recognize alpha channel, it fills the rect with black. I made workaround to set
fillContentArea = false when alpha channel == 0 to avoid this.
And more, I'd like to fallback the color passed to ChromiumBridge to white when
o->style()->backgroundColor() is invalid.
- rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
- 5:26 AM Changeset in webkit [43902] by
-
- 3 edits2 adds in trunk
2009-05-20 Shinichiro Hamaji <hamaji@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25417
Map CompositeCopy to Skia's kSrc_Mode composite operation.
Test: fast/canvas/canvas-composite-alpha.html
- platform/graphics/skia/SkiaUtils.cpp: (WebCore::):
- 4:38 AM Changeset in webkit [43901] by
-
- 2 edits in trunk/JavaScriptCore
2009-05-20 Xan Lopez <xlopez@igalia.com>
Reviewed by Eric Seidel.
Fix GTK debug build.
The function dumpDisjunction, compiled with debug enabled, uses
printf, which needs stdio.h to be included.
- yarr/RegexInterpreter.cpp:
- 4:30 AM Changeset in webkit [43900] by
-
- 2 edits in trunk/WebCore
2009-05-20 Jan Michael Alonzo <jmalonzo@webkit.org>
Rubber-stamped by Xan Lopez.
Remove misplaced extern "C"
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
- 4:16 AM Changeset in webkit [43899] by
-
- 2 edits in trunk/WebCore
2009-05-20 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Xan Lopez.
[GTK] Expose password field with role of PASSWORD_TEXT
https://bugs.webkit.org/show_bug.cgi?id=25682
Check if input type is a password field and return
ATK_ROLE_PASSWORD_TEXT if it is.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
- 3:09 AM Changeset in webkit [43898] by
-
- 2 edits in trunk/WebCore
2009-05-20 Laszlo Gombos <Laszlo Gombos>
Reviewed by George Staikos.
BUG 25845: [Qt] Fix QtWebKit pkgconfig dependencies
<https://bugs.webkit.org/show_bug.cgi?id=25845>
- WebCore.pro: Remove QtDBus; remove QtXml if Qt >= 4.4
- 3:08 AM Changeset in webkit [43897] by
-
- 3 edits1 delete in trunk/LayoutTests
2009-05-20 Eric Seidel <eric@webkit.org>
Build fix only, no review.
Remove dragging subtest from 43890 which used ? char
? is a reserved char on Windows. After removing both the ü and now the ? this
subtest is now useless, so I'm removing it entirely.
- editing/pasteboard/file-input-files-access-expected.txt:
- editing/pasteboard/resources/File With Spaces! For Dragging?.gif: Removed.
- editing/pasteboard/resources/file-input-files-access.js: (runTest):
- 2:58 AM Changeset in webkit [43896] by
-
- 7 edits in trunk
2009-05-20 Laszlo Gombos <Laszlo Gombos>
Reviewed by George Staikos.
BUG 25843: [Qt] Remove qt-port build flag
<https://bugs.webkit.org/show_bug.cgi?id=25843>
- bridge/testbindings.pro:
- JavaScriptCore.pro:
- DumpRenderTree/qt/DumpRenderTree.pro:
- Scripts/webkitdirs.pm:
- 2:49 AM Changeset in webkit [43895] by
-
- 3 edits1 move in trunk/LayoutTests
2009-05-20 Eric Seidel <eric@webkit.org>
Build fix only, no review.
Fix windows and tiger builds after r43890
Commit r43890 caused:
svn: Can't convert string from 'UTF-8' to native encoding:
svn: LayoutTests/editing/pasteboard/resources/File With Spaces! For Dra?\204?\136gging?.gif
On both the windows and tiger buildbots. According to:
http://svnbook.red-bean.com/en/1.2/svn.advanced.l10n.html
this is intentional behavior, and due to the fact that the default
LC_CTYPE for Tiger and Windows makes Subversion think the filesystems
do not support utf8.
The fix would be to execute:
export LC_CTYPE=en_US.UTF-8
On all affected machines. But since that's not going to happen,
I'm removing the utf8 chars from this filename.
This makes the drag-drop test weaker, but I see no other option.
- editing/pasteboard/resources/File With Spaces! For Dragging?.gif: Renamed from "LayoutTests/editing/pasteboard/resources/File With Spaces! For Dra\314\210gging?.gif".
- editing/pasteboard/resources/file-input-files-access.js: (moveMouseToCenterOfElement): use the unused argument (runTest): fix to use the ansii name
- 2:02 AM Changeset in webkit [43894] by
-
- 2 edits in trunk/WebCore
2009-05-20 Laszlo Gombos <Laszlo Gombos>
Reviewed by George Staikos.
[Qt] Cleanup - move files exclusive to JAVASCRIPT_DEBUGGER
and WORKERS under the appropriate build section
- WebCore.pro:
- 1:40 AM Changeset in webkit [43893] by
-
- 2 edits in trunk/WebCore
2009-05-20 Ariya Hidayat <ariya.hidayat@nokia.com>
Unreviewed Qt build fix, after r43892.
- platform/graphics/qt/ImageQt.cpp: included ImageObservser.h
- 1:22 AM Changeset in webkit [43892] by
-
- 2 edits in trunk/WebCore
2009-05-20 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=25856
[Qt] notify an image has been drawn, to help Cache purge alive decoded data.
- 12:32 AM Changeset in webkit [43891] by
-
- 1 edit1 delete in trunk/LayoutTests
2009-05-20 Darin Adler <Darin Adler>
Removed stray file left after some check-ins earlier today.
- fast/tokenizer/preload-scanner-entities.html-disabled: Removed.
- 12:32 AM Changeset in webkit [43890] by
-
- 11 edits8 adds4 deletes in trunk
2009-05-18 Eric Seidel <eric@webkit.org>
Reviewed by Oliver Hunt.
Remove layoutTestController.addFileToPasteboardOnDrag and add eventSender.beginDragWithFiles
https://bugs.webkit.org/show_bug.cgi?id=25852
This allows us to now test multi-file file drags in DumpRenderTree per:
https://bugs.webkit.org/show_bug.cgi?id=25862
I removed the existing tests using addFileToPasteboardOnDrag()
and replaced them with a new test (editing/pasteboard/file-input-files-access)
which covers several more drag-drop cases.
I added a DumpRenderTreeFileDraggingSource class to avoid
the hack of if (!draggingSource) in [DumpRenderTreeDraggingInfo draggingSourceOperationMask]
New Test: editing/pasteboard/file-input-files-access.html
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/DumpRenderTreeFileDraggingSource.h: Added.
- DumpRenderTree/DumpRenderTreeFileDraggingSource.m: Added. (-[DumpRenderTreeFileDraggingSource draggingSourceOperationMaskForLocal:]):
- DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::staticValues): removed addFileToPasteboardOnDrag support (LayoutTestController::staticFunctions): removed addFileToPasteboardOnDrag support
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/mac/DumpRenderTree.mm: (runTest): ASSERT that draggingInfo has been cleared
- DumpRenderTree/mac/EventSendingController.mm: (+[EventSendingController isSelectorExcludedFromWebScript:]): Sorted selectors. (+[EventSendingController webScriptNameForSelector:]): Sorted selectors. (-[EventSendingController beginDragWithFiles:]): (-[EventSendingController mouseMoveToX:Y:]): (-[EventSendingController keyDown:withModifiers:]): (-[EventSendingController fireKeyboardEventsToElement:]): removed spurious { }
- DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]): removed addFileToPasteboardOnDrag support
- 12:24 AM Changeset in webkit [43889] by
-
- 7 edits in trunk/WebCore
2009-05-20 David Levin <levin@chromium.org>
Reviewed by NOBODY, layout tests fix.
https://bugs.webkit.org/show_bug.cgi?id=23727
This reverts commit r43888.
Once that change was checked in many of the fast/flexbox0*.html
tests (and others) started failing.
- WebCore.pro:
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
- css/CSSPropertyNames.in:
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
- css/CSSValueKeywords.in:
- rendering/RenderMarquee.cpp: (WebCore::RenderMarquee::updateMarqueePosition): (WebCore::RenderMarquee::timerFired):
