Timeline
Jun 15, 2009:
- 11:52 PM Changeset in webkit [44713] by
-
- 6 edits in trunk/JavaScriptCore
2009-06-15 Gavin Barraclough <barraclough@apple.com>
Rubber Stamped by Sam Weinig.
Rename PatchBuffer to LinkBuffer. Previously our terminology has been a little
mixed up, but we have decided to fix on refering to the process that takes place
at the end of code generation as 'linking', and on any modifications that take
place later (and once the code has potentially already been executed) as 'patching'.
However, the term 'PatchBuffer' is already in use, and needs to be repurposed.
To try to minimize confusion, we're going to switch the terminology over in stages,
so for now we'll refer to later modifications as 'repatching'. This means that the
new 'PatchBuffer' has been introduced with the name 'RepatchBuffer' instead.
This patch renames the old 'PatchBuffer' to 'LinkBuffer'. We'll leave ToT in this
state for a week or so to try to avoid to much overlap of the meaning of the term
'PatchBuffer', then will come back and rename 'RepatchBuffer'.
- assembler/ARMv7Assembler.h:
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::LinkBuffer::LinkBuffer): (JSC::AbstractMacroAssembler::LinkBuffer::~LinkBuffer):
- jit/JIT.cpp: (JSC::JIT::privateCompile):
- jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
- yarr/RegexJIT.cpp: (JSC::Yarr::RegexGenerator::compile):
- 11:17 PM Changeset in webkit [44712] by
-
- 7 edits in trunk
WebCore:
2009-06-15 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Fix for <rdar://problem/6907228> Pasting a paragraph as quotation leaves you typing in blue instead of black; repros
- editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): When inserting a newline after the blockquote, we don't want to apply the original style after the insertion.
LayoutTests:
2009-06-15 Adele Peterson <adele@apple.com>
Reviewed by Darin Adler.
Updating test for:
<rdar://problem/6907228> Pasting a paragraph as quotation leaves you typing in blue instead of black; repros
This test case covered inserting a newline after a blockquote, but outside of the blockquote. I added some
text insertion to verify that the newline doesn't get any old styles copied from the blockquote.
- editing/pasteboard/5368833.html:
- platform/mac/editing/pasteboard/5368833-expected.checksum:
- platform/mac/editing/pasteboard/5368833-expected.png:
- platform/mac/editing/pasteboard/5368833-expected.txt:
- 10:35 PM Changeset in webkit [44711] by
-
- 11 edits1 copy in trunk/JavaScriptCore
2009-06-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Having moved most of their functionality into the RepatchBuffer class,
we can simplify the CodeLocation* classes.
The CodeLocation* classes are currently a tangle of templatey and friendly
badness, burried in the middle of AbstractMacroAssembler. Having moved
the ability to repatch out into RepatchBufer they are now do-nothing wrappers
on CodePtr (MacroAssemblerCodePtr), that only exist to provide type-safety.
Simplify the code, and move them off into their own header.
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::PatchBuffer::patch):
- assembler/CodeLocation.h: Copied from assembler/AbstractMacroAssembler.h. (JSC::CodeLocationCommon::CodeLocationCommon): (JSC::CodeLocationInstruction::CodeLocationInstruction): (JSC::CodeLocationLabel::CodeLocationLabel): (JSC::CodeLocationJump::CodeLocationJump): (JSC::CodeLocationCall::CodeLocationCall): (JSC::CodeLocationNearCall::CodeLocationNearCall): (JSC::CodeLocationDataLabel32::CodeLocationDataLabel32): (JSC::CodeLocationDataLabelPtr::CodeLocationDataLabelPtr): (JSC::CodeLocationCommon::instructionAtOffset): (JSC::CodeLocationCommon::labelAtOffset): (JSC::CodeLocationCommon::jumpAtOffset): (JSC::CodeLocationCommon::callAtOffset): (JSC::CodeLocationCommon::nearCallAtOffset): (JSC::CodeLocationCommon::dataLabelPtrAtOffset): (JSC::CodeLocationCommon::dataLabel32AtOffset):
- assembler/MacroAssemblerCodeRef.h: (JSC::MacroAssemblerCodePtr::operator!):
- bytecode/CodeBlock.h: (JSC::getStructureStubInfoReturnLocation): (JSC::getCallLinkInfoReturnLocation): (JSC::getMethodCallLinkInfoReturnLocation):
- bytecode/Instruction.h:
- bytecode/JumpTable.h: (JSC::StringJumpTable::ctiForValue): (JSC::SimpleJumpTable::ctiForValue):
- bytecode/StructureStubInfo.h:
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitCatch):
- jit/JIT.cpp: (JSC::JIT::privateCompile):
- jit/JITStubs.cpp: (JSC::JITStubs::DEFINE_STUB_FUNCTION): (JSC::JITStubs::getPolymorphicAccessStructureListSlot):
- 10:03 PM Changeset in webkit [44710] by
-
- 2 edits in trunk/WebCore
2009-06-15 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Remove outdated comment.
- bindings/js/JSDOMWindowBase.h:
- 9:58 PM Changeset in webkit [44709] by
-
- 6 edits in trunk/WebCore
2009-06-15 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Bring CustomGetPropertyNames more inline with the other
extended attributes prefixed with Custom, by making it
require a complete implementation.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getPropertyNames):
- bindings/js/JSHistoryCustom.cpp: (WebCore::JSHistory::getPropertyNames):
- bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::getPropertyNames):
- bindings/js/JSStorageCustom.cpp: (WebCore::JSStorage::getPropertyNames):
- bindings/scripts/CodeGeneratorJS.pm:
- 9:04 PM Changeset in webkit [44708] by
-
- 2 edits in trunk/WebCore
2009-06-15 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Remove commented out ondataunavailable attribute event listener which
has now been removed from HTML 5.
- page/DOMWindow.idl:
- 9:02 PM Changeset in webkit [44707] by
-
- 6 edits in trunk/WebCore
2009-06-15 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Move entire custom implementation of getOwnPropertySlot and put
for JSDOMWindow into JSDOMWindowCustom, eliminating the bit in
JSDOMWindowBase.
- bindings/js/JSDOMWindowBase.cpp:
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::nonCachingStaticFunctionGetter): (WebCore::childFrameGetter): (WebCore::indexGetter): (WebCore::namedItemGetter): (WebCore::JSDOMWindow::getOwnPropertySlot): (WebCore::JSDOMWindow::put): (WebCore::JSDOMWindow::getPropertyAttributes):
- bindings/js/JSDOMWindowCustom.h:
- page/DOMWindow.idl:
- 9:00 PM Changeset in webkit [44706] by
-
- 2 edits in trunk/WebCore
2009-06-15 Jeremy Orlow (jorlow@chromium.org)
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=26356
Define the functions in V8CustomBindings.h. "Forgot" this in my
earlier patch since it wasn't fully upstreamed when I wrote the
patch.
- bindings/v8/custom/V8CustomBinding.h:
- 8:01 PM Changeset in webkit [44705] by
-
- 11 edits in trunk/JavaScriptCore
2009-06-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Having introduced the RepatchBuffer, ProcessorReturnAddress is now a do-nothing
wrapper around ReturnAddressPtr. Remove it. In tugging on this piece of string
it made sense to roll out the use of ReturnAddressPtr a little further into
JITStubs (which had always been the intention).
No performance impact.
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::RepatchBuffer::relinkCallerToTrampoline): (JSC::AbstractMacroAssembler::RepatchBuffer::relinkCallerToFunction): (JSC::AbstractMacroAssembler::RepatchBuffer::relinkNearCallerToTrampoline):
- assembler/MacroAssemblerCodeRef.h: (JSC::ReturnAddressPtr::ReturnAddressPtr):
- bytecode/CodeBlock.h: (JSC::CodeBlock::getStubInfo): (JSC::CodeBlock::getCallLinkInfo): (JSC::CodeBlock::getMethodCallLinkInfo): (JSC::CodeBlock::getBytecodeIndex):
- interpreter/Interpreter.cpp: (JSC::bytecodeOffsetForPC):
- jit/JIT.cpp: (JSC::ctiPatchNearCallByReturnAddress): (JSC::ctiPatchCallByReturnAddress):
- jit/JIT.h: (JSC::JIT::compileGetByIdProto): (JSC::JIT::compileGetByIdChain): (JSC::JIT::compilePutByIdTransition): (JSC::JIT::compilePatchGetArrayLength):
- jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdChain):
- jit/JITStubs.cpp: (JSC::JITThunks::tryCachePutByID): (JSC::JITThunks::tryCacheGetByID): (JSC::StackHack::StackHack): (JSC::returnToThrowTrampoline): (JSC::throwStackOverflowError): (JSC::JITStubs::DEFINE_STUB_FUNCTION):
- jit/JITStubs.h: (JSC::): (JSC::JITStackFrame::returnAddressSlot):
- runtime/JSGlobalData.h:
- 7:13 PM Changeset in webkit [44704] by
-
- 2 edits in trunk/WebKit/qt
2009-06-15 Benjamin C Meyer <benjamin.meyer@torchmobile.com>
Reviewed by Adam Treat.
Support the back/forward/stop/refresh multimedia keys and accept the
event when handling backspace and shift backspace as we should.
- Api/qwebpage.cpp: (QWebPagePrivate::keyPressEvent):
- 6:36 PM Changeset in webkit [44703] by
-
- 2 edits in trunk/WebCore
2009-06-15 Andre Boule <aboule@apple.com>
Reviewed by Cameron Zwarich and Dan Bernstein.
- fix <rdar://problem/6967975> crash with NSString drawAtPoint
No test possible because this crash can only occur if the client uses
WebKit text drawing without ever using WebCore text, and DumpRenderTree
cannot do either.
- platform/graphics/FontCache.cpp: (WebCore::FontCache::purgeInactiveFontData): Null-check
gFontPlatformDataCache.
- 6:27 PM Changeset in webkit [44702] by
-
- 11 edits in trunk
2009-06-15 Simon Fraser <Simon Fraser>
Reviewed by Mark Rowe.
<rdar://problem/6974857>
Define ENABLE_3D_RENDERING and WTF_USE_ACCELERATED_COMPOSITING when building on 10.6.
Move the ENABLE_3D_RENDERING switch from config.h and WebKitPrefix.h to wtf/Platform.h
- 6:12 PM Changeset in webkit [44701] by
-
- 6 edits in trunk/WebCore
2009-06-15 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Make WebInspector's console evaluation/completion asynchronous.
This way of evaluation allows serializing calls between
InspectorController and its frontend.
- inspector/front-end/Console.js: (WebInspector.Console.prototype.completions): (WebInspector.Console.prototype._reportCompletions): (WebInspector.Console.prototype._evalInInspectedWindow): (WebInspector.Console.prototype._enterKeyPressed.printResult): (WebInspector.Console.prototype._enterKeyPressed):
- inspector/front-end/DatabaseQueryView.js:
- inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.evaluateExpression):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
- inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype.complete): (WebInspector.TextPrompt.prototype._completionsReady):
- 5:26 PM Changeset in webkit [44700] by
-
- 4 edits in trunk/JavaScriptCore
2009-06-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Move repatching methods into a set of methods on a class. This will allow us to
coallesce memory reprotection calls. Really, we want this class to be called
PatchBuffer, we want the class PatchBuffer to be called LinkBuffer, we want both
to be memblers of MacroAssembler rather then AbstractMacroAssembler, we don't
want the CodeLocationFoo types anymore (they are now only really there to provide
type safety, and that is completely undermined by the way we use offsets). Then
the link & patch buffers should delegate the actual patching calls to the
architecture-specific layer of the MacroAssembler. Landing all these changes as a
sequence of patches.
No performance impact.
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::CodeLocationCall::CodeLocationCall): (JSC::AbstractMacroAssembler::CodeLocationNearCall::CodeLocationNearCall): (JSC::AbstractMacroAssembler::CodeLocationNearCall::calleeReturnAddressValue): (JSC::AbstractMacroAssembler::RepatchBuffer::RepatchBuffer): (JSC::AbstractMacroAssembler::RepatchBuffer::relink): (JSC::AbstractMacroAssembler::RepatchBuffer::repatch): (JSC::AbstractMacroAssembler::RepatchBuffer::relinkCallerToTrampoline): (JSC::AbstractMacroAssembler::RepatchBuffer::relinkCallerToFunction): (JSC::AbstractMacroAssembler::RepatchBuffer::relinkNearCallerToTrampoline): (JSC::AbstractMacroAssembler::RepatchBuffer::repatchLoadPtrToLEA):
- jit/JIT.cpp: (JSC::ctiPatchNearCallByReturnAddress): (JSC::ctiPatchCallByReturnAddress): (JSC::JIT::unlinkCall): (JSC::JIT::linkCall):
- jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::patchGetByIdSelf): (JSC::JIT::patchMethodCallProto): (JSC::JIT::patchPutByIdReplace): (JSC::JIT::privateCompilePatchGetArrayLength): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdSelfList): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
- 4:19 PM Web Inspector edited by
- (diff)
- 4:19 PM Web Inspector edited by
- (diff)
- 4:16 PM Changeset in webkit [44699] by
-
- 2 edits in trunk/WebKit/mac
2009-06-15 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/6967569>
CrashTracer: 15 crashes in Safari at com.apple.WebKit • WebKit::NetscapePluginHostManager::didCreateWindow + 85
Make sure to remove the entry from the plug-in host map so we won't end up with an entry that has a null value.
- Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::hostForPackage):
- 4:10 PM Changeset in webkit [44698] by
-
- 2 edits in trunk/WebCore
2009-06-15 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim Hatcher.
Reverted previous change as the old behavior was correct for heavy view.
- inspector/front-end/BottomUpProfileDataGridTree.js: (WebInspector.BottomUpProfileDataGridNode.prototype._populate):
- 3:39 PM Changeset in webkit [44697] by
-
- 2 edits in trunk/WebCore
2009-06-15 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim Hatcher.
<rdar://problem/6968125> Profiler 'Call' count is incorrect in Heavy
view (26418)
- Removed code that copied call and time data from it's ancestor.
- inspector/front-end/BottomUpProfileDataGridTree.js: (WebInspector.BottomUpProfileDataGridNode.prototype._populate):
- 3:21 PM Changeset in webkit [44696] by
-
- 5 edits2 adds in trunk
Reviewed by Simon Fraser <Simon Fraser>.
Added logic to updateTransitions similar to that in updateKeyframeAnimations
which detects and removes stale transitions.
Test: transitions/cancel-transition.html
- page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions):
- page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::ImplicitAnimation):
- page/animation/ImplicitAnimation.h: (WebCore::ImplicitAnimation::active): (WebCore::ImplicitAnimation::setActive):
- 2:18 PM Changeset in webkit [44695] by
-
- 11 edits in trunk
WebCore:
Reviewed by Tim Hatcher.
- allow the source code font in the Web Inspector to be customized
- css/view-source.css: Use the default monospace font family and size
for source code.
- inspector/front-end/inspector.css: Use the default monospace font
family and size for console I/O.
WebKit/mac:
Reviewed by Tim Hatcher.
- make the source code font in the Web Inspector match Mac defaults
- WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController init]): Set the default monospace font to 11px Menlo, except on Leopard and Tiger where it is 10px Monaco.
WebKit/win:
Reviewed by Tim Hatcher.
- use a nice source code font in the Web Inspector
- WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::createPage): Set the default monospace font to
13px Courier New, which is the default source code font in Visual
Studio.
LayoutTests:
Reviewed by Tim Hatcher.
- updated results after changing source view to use the default monospace font family and size
- platform/mac/fast/frames/viewsource-attribute-expected.checksum:
- platform/mac/fast/frames/viewsource-attribute-expected.png:
- platform/mac/fast/frames/viewsource-attribute-expected.txt:
- 1:25 PM Changeset in webkit [44694] by
-
- 2 edits in trunk/WebKit/gtk
2009-06-15 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=26377
[GTK] Confusion about range of 'progress' property
Range for the progress property is 0.0 .. 1.0, don't multiply it
by 100 to make it a percentage.
- webkit/webkitwebview.cpp: (webkit_web_view_get_progress):
- 1:17 PM Changeset in webkit [44693] by
-
- 6 edits in trunk/JavaScriptCore
2009-06-15 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Hunt & Oliver Garen.
We are currently generating two copies of the slow path for op_call for no reason. Stop that.
Originally op_call used two slow paths since the first set up the pointer to the CallLinkInfo
for use when linking. However this is now looked up using the return address (as we do for
property accesses) so the two paths are now identical.
No performance impact, reduces memory footprint.
- bytecode/CodeBlock.h:
- jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::linkCall):
- jit/JIT.h:
- jit/JITCall.cpp: (JSC::JIT::compileOpCallSlowCase):
- jit/JITStubs.cpp: (JSC::JITStubs::DEFINE_STUB_FUNCTION):
- 11:39 AM Changeset in webkit [44692] by
-
- 4 edits in trunk/WebKit/qt
2009-06-15 Andre Pedralho <andre.pedralho@openbossa.org>
Reviewed by Adam Treat
https://bugs.webkit.org/show_bug.cgi?id=26351
Remove bool QWebHitTestResult::isScrollBar() const and make sure a null QWebHitTestResult is returned instead.
- 11:39 AM Changeset in webkit [44691] by
-
- 1 edit16 adds in trunk/WebKitExamplePlugins
2009-06-15 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
Add Core Animation movie plug-in example.
- NetscapeCoreAnimationMoviePlugin: Added.
- NetscapeCoreAnimationMoviePlugin/English.lproj: Added.
- NetscapeCoreAnimationMoviePlugin/English.lproj/InfoPlist.strings: Added.
- NetscapeCoreAnimationMoviePlugin/Info.plist: Added.
- NetscapeCoreAnimationMoviePlugin/MovieControllerLayer.h: Added.
- NetscapeCoreAnimationMoviePlugin/MovieControllerLayer.m: Added. (createImageNamed): (-[MovieControllerLayer init]): (-[MovieControllerLayer dealloc]): (-[MovieControllerLayer _playPauseButtonRect]): (-[MovieControllerLayer _sliderRect]): (-[MovieControllerLayer _sliderThumbRect]): (-[MovieControllerLayer _innerSliderRect]): (-[MovieControllerLayer _drawPlayPauseButtonInContext:]): (-[MovieControllerLayer _drawSliderInContext:]): (-[MovieControllerLayer drawInContext:]): (-[MovieControllerLayer _currentTime]): (-[MovieControllerLayer _duration]): (-[MovieControllerLayer _isPlaying]): (-[MovieControllerLayer _updateTime:]): (-[MovieControllerLayer _rateDidChange:]): (-[MovieControllerLayer _timeDidChange:]): (-[MovieControllerLayer actionForKey:]): (-[MovieControllerLayer setMovie:]): (-[MovieControllerLayer _setNewTimeForThumbCenterX:]): (-[MovieControllerLayer handleMouseDown:]): (-[MovieControllerLayer handleMouseUp:]): (-[MovieControllerLayer handleMouseDragged:]):
- NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj: Added.
- NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj/project.pbxproj: Added.
- NetscapeCoreAnimationMoviePlugin/Pause.tiff: Added.
- NetscapeCoreAnimationMoviePlugin/Play.tiff: Added.
- NetscapeCoreAnimationMoviePlugin/SliderTrackCenter.tiff: Added.
- NetscapeCoreAnimationMoviePlugin/SliderTrackLeft.tiff: Added.
- NetscapeCoreAnimationMoviePlugin/SliderTrackRight.tiff: Added.
- NetscapeCoreAnimationMoviePlugin/Thumb.tiff: Added.
- NetscapeCoreAnimationMoviePlugin/main.m: Added. (NP_Initialize): (NP_GetEntryPoints): (NP_Shutdown): (NPP_New): (NPP_Destroy): (NPP_SetWindow): (NPP_NewStream): (NPP_DestroyStream): (NPP_WriteReady): (NPP_Write): (NPP_StreamAsFile): (NPP_Print): (handleMouseDown): (togglePlayPause): (handleMouseUp): (handleMouseDragged): (handleMouseEntered): (handleMouseExited): (handleKeyDown): (handleScrollEvent): (NPP_HandleEvent): (NPP_URLNotify): (NPP_GetValue): (NPP_SetValue):
- NetscapeCoreAnimationMoviePlugin/test.html: Added.
- 11:14 AM Changeset in webkit [44690] by
-
- 1 copy in releases/WebKitGTK/webkit-1.1.10
Tagging 1.1.10.
- 8:40 AM Changeset in webkit [44689] by
-
- 2 edits in trunk/WebKit/gtk
2009-06-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Add new symbols list for 1.1.10 release.
- docs/webkitgtk-docs.sgml:
- 8:39 AM Changeset in webkit [44688] by
-
- 2 edits in trunk/WebKit/gtk
2009-06-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Xan Lopez.
Fix Since tags for the new uri and message properties.
- webkit/webkitnetworkrequest.cpp: (webkit_network_request_class_init):
- 8:38 AM Changeset in webkit [44687] by
-
- 2 edits in trunk/WebCore
2009-06-15 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by and done with Tor Arne Vestbø.
Fix initialization of uninitialized members in FontFallbackListQt, leading
to random crashes when rendering text.
- 8:30 AM Changeset in webkit [44686] by
-
- 2 edits in trunk/WebKit/gtk
2009-06-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Adding new documented API to the generated
documentation.
- docs/webkitgtk-sections.txt:
- 7:38 AM Changeset in webkit [44685] by
-
- 2 edits in trunk/WebKit/qt
2009-06-15 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Adam Treat.
Fix the logic for disabling the fixed layout feature, when an invalid
QSize is set.
- 7:31 AM Changeset in webkit [44684] by
-
- 4 edits in trunk
2009-06-15 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Version bump in preparation for 1.1.10 release.
- configure.ac:
WebKit/gtk:
2009-06-15 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Update NEWS for 1.1.10 release.
- NEWS:
- 7:17 AM Changeset in webkit [44683] by
-
- 2 edits in trunk/WebCore
2009-06-15 Xan Lopez <xlopez@igalia.com>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=25895
[Gtk] Segfault when deleting the last/only character in an entry if a11y is enabled
Use computeOffsetInContainerNode instead of the inline
offsetInContainerNode to return the caret offset, since the former
can handle all types of anchoring. Otherwise we'll hit an ASSERT
in some situations in debug builds, and crash.
- editing/gtk/SelectionControllerGtk.cpp: (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
- 4:53 AM Changeset in webkit [44682] by
-
- 12 edits2 moves in trunk/WebCore
2009-06-15 Joe Ligman <joseph.ligman@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Fix build break
Rename JSONObject to InspectorJSONObject
- 1:39 AM Changeset in webkit [44681] by
-
- 7 edits in trunk
2009-06-12 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Mark Rowe.
Reviewed by Simon Hausmann.
Reviewed by Xan Lopez.
Refactor handling of options in the build-webkit script
Options are now defined in one place, and then reused when creating
the usage help text, the arguments to GetOptions(), and when passing
the options on to the underlying port-dependent build systems.
This allows the Qt port to read the defaults for the options from the
pro file (dynamically), and to pass the options on to qmake at build.
- 12:37 AM Changeset in webkit [44680] by
-
- 2 edits in trunk/WebKitTools
Fix <https://bugs.webkit.org/show_bug.cgi?id=26312>.
Bug 26312: Multiple copies of Safari opened with WebKit nightly and Safari 3.2.3
Reviewed by Cameron Zwarich.
Skip the trampoline detection for versions of Safari < 4.0 as they don't play these
tricks, and having WebKitNightlyEnabler assume that we were in the trampoline was
preventing our LaunchServices trickery from being run. This led to fresh copies of
WebKit.app being launched when a URL or file was opened from an external application
rather than the existing instance being reused.
- WebKitLauncher/WebKitNightlyEnabler.m:
(insideSafari4OnTigerTrampoline):
(enableWebKitNightlyBehaviour):
- 12:02 AM Changeset in webkit [44679] by
-
- 1 edit in trunk/WebCore/platform/graphics/qt/FontFallbackListQt.cpp
Fix Qt build break after r44672
Jun 14, 2009:
- 11:11 PM Changeset in webkit [44678] by
-
- 4 edits5 adds in trunk/WebCore
Bug 26399: REGRESSION: java applet accessibility broken
https://bugs.webkit.org/show_bug.cgi?id=26399
- 9:46 PM Changeset in webkit [44677] by
-
- 20 edits in trunk/WebCore
2009-06-14 Sam Weinig <sam@webkit.org>
Reviewed by Cameron Zwarich.
Rename the CustomGetOwnPropertySlot and CustomPutFunction extended attributes
to DelegatingGetOwnPropertySlot and DelegatingPutFunction to more clearly describe
their functionality (customGetOwnPropertySlot and customPut member functions have
been renamed getOwnPropertySlotDelegate and putDelegate). CustomGetOwnPropertySlot
and CustomPutFunction have been repurposed to mean a complete custom implementation
of the function which is inline with other extended attributes prefixed with Custom.
- bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::putDelegate):
- bindings/js/JSDOMWindowCustom.h: (WebCore::JSDOMWindow::getOwnPropertySlotDelegate): (WebCore::JSDOMWindow::putDelegate):
- bindings/js/JSHTMLAppletElementCustom.cpp: (WebCore::JSHTMLAppletElement::getOwnPropertySlotDelegate): (WebCore::JSHTMLAppletElement::putDelegate):
- bindings/js/JSHTMLEmbedElementCustom.cpp: (WebCore::JSHTMLEmbedElement::getOwnPropertySlotDelegate): (WebCore::JSHTMLEmbedElement::putDelegate):
- bindings/js/JSHTMLObjectElementCustom.cpp: (WebCore::JSHTMLObjectElement::getOwnPropertySlotDelegate): (WebCore::JSHTMLObjectElement::putDelegate):
- bindings/js/JSHistoryCustom.cpp: (WebCore::JSHistory::getOwnPropertySlotDelegate): (WebCore::JSHistory::putDelegate):
- bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::getOwnPropertySlotDelegate): (WebCore::JSLocation::putDelegate): (WebCore::JSLocationPrototype::putDelegate):
- bindings/js/JSStorageCustom.cpp: (WebCore::JSStorage::putDelegate):
- bindings/js/JSWorkerContextCustom.cpp: (WebCore::JSWorkerContext::getOwnPropertySlotDelegate):
- bindings/scripts/CodeGeneratorJS.pm:
- css/CSSStyleDeclaration.idl:
- html/HTMLAppletElement.idl:
- html/HTMLEmbedElement.idl:
- html/HTMLObjectElement.idl:
- page/DOMWindow.idl:
- page/History.idl:
- page/Location.idl:
- storage/Storage.idl:
- workers/WorkerContext.idl:
- 9:36 PM Changeset in webkit [44676] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
- fix https://bugs.webkit.org/show_bug.cgi?id=26395 <rdar://problem/6971333> REGRESSION (r40813-r40884): No caret after going back/forward to page with focused text field
No test, since the back/forward cache is disabled in DumpRenderTree
- loader/FrameLoader.cpp: (WebCore::FrameLoader::open): Added a call to CachedPage::restore(), which was removed in r40870.
- 8:07 PM Changeset in webkit [44675] by
-
- 2 edits in trunk/WebCore
2009-06-14 Darin Adler <Darin Adler>
- editing/TextIterator.cpp: (WebCore::BitStack::push): Use named constant instead of hardcoded numbers. (WebCore::BitStack::top): Ditto.
- 7:39 PM Changeset in webkit [44674] by
-
- 9 edits2 adds in trunk
WebCore:
2009-06-14 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Bug 26364: Search can find text that's hidden by overflow:hidden
https://bugs.webkit.org/show_bug.cgi?id=26364
<rdar://problem/6952081>
Test: fast/text/find-hidden-text.html
- editing/TextIterator.cpp: (WebCore::BitStack::BitStack): Added. (WebCore::BitStack::push): Added. (WebCore::BitStack::pop): Added. (WebCore::BitStack::top): Added. (WebCore::BitStack::size): Added. (WebCore::parentOrShadowParent): Added. Helper function for walking up the parent node chain, crossing shadow tree boundaries. (WebCore::depthCrossingShadowBoundaries): Added for use in assertions. Counts the depth of a node using the parentOrShadowParent function. (WebCore::fullyClipsContents): Added. Returns true for an element that fully clips its contents, currently defined as a box that has zero width or height and hides overflow. We can add other cases here later. (WebCore::ignoresContainerClip): Added. Returns true for an element that ignores its container clip, currently defined as an element with absolute or fixed positioning. (WebCore::pushFullyClippedState): Added. Pushes a bit on the stack indicating if the node in question fully clips its contents. (WebCore::setUpFullyClippedStack): Added. Pushes a bit for each ancestor of a node. Used when creating an iterator. (WebCore::TextIterator::TextIterator): Removed code to initialize m_inShadowContent. Call setUpFullyClippedStack. (WebCore::TextIterator::advance): Use parentOrShadowParent. Call pop when moving up to a parent node, and also one extra time when moving to a sibling node. Call pushFullyClippedState when moving to a child node, or when moving to a sibling node after the aforementioned call to pop. (WebCore::TextIterator::handleTextNode): Return early if the node is fully clipped. (WebCore::TextIterator::handleReplacedElement): Ditto. (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): Call setUpFullyClippedStack. (WebCore::SimplifiedBackwardsTextIterator::advance): Same changes as TextIterator::advance above.
- editing/TextIterator.h: Added BitStack class and added m_fullyClippedStack to both TextIterator and SimplifiedBackwardsTextIterator. Removed unneeded m_inShadowContent.
LayoutTests:
2009-06-14 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
Bug 26364: Search can find text that's hidden by overflow:hidden
https://bugs.webkit.org/show_bug.cgi?id=26364
<rdar://problem/6952081>
- fast/text/find-hidden-text-expected.txt: Added.
- fast/text/find-hidden-text.html: Added.
- fast/block/float/crash-replaced-display-block-expected.txt: Removed a space.
- fast/dom/Range/acid3-surround-contents-expected.txt: Removed a blank line.
- fast/dom/object-embed-plugin-scripting-expected.txt: Removed four spaces.
- fast/parser/badentity-expected.txt: Removed a blank line.
- http/tests/security/local-video-poster-from-remote-expected.txt: Removed a blank line.
- 4:52 PM Changeset in webkit [44673] by
-
- 3 edits in trunk/WebCore
2009-06-14 David Hyatt <hyatt@apple.com>
Reviewed by Simon Fraser.
Back out Simon's fix and replace it with a better one that doesn't needlessly destroy RenderObjects.
Use NoInherit rather than Detach for child index changes, and don't worry about other pseudo-class state
changes, since they were handled already with setNeedsStyleRecalcs on the affected objects themselves.
- dom/Element.cpp: (WebCore::Element::recalcStyle):
- dom/Node.cpp: (WebCore::Node::diff):
- rendering/style/RenderStyle.h: (WebCore::InheritedFlags::setChildIndex):
- 2:57 PM Changeset in webkit [44672] by
-
- 7 edits in trunk/WebCore
2009-06-14 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
Move all of the mutable member variables from Font into the refcounted FontFallbackList. This makes
copying of Fonts more efficient and also effectively makes all of the mutations of a Font object happen
inside the FontFallbackList.
- WebCore.base.exp:
- platform/graphics/Font.cpp: (WebCore::Font::Font): (WebCore::Font::operator=): (WebCore::Font::primaryFont): (WebCore::Font::update):
- platform/graphics/Font.h: (WebCore::Font::setWordSpacing): (WebCore::Font::setLetterSpacing):
- platform/graphics/FontFallbackList.cpp: (WebCore::FontFallbackList::FontFallbackList): (WebCore::FontFallbackList::invalidate): (WebCore::FontFallbackList::determinePitch):
- platform/graphics/FontFallbackList.h: (WebCore::FontFallbackList::primarySimpleFontData): (WebCore::FontFallbackList::primaryFontData):
- platform/graphics/FontFastPath.cpp: (WebCore::Font::glyphDataForCharacter):
- 2:27 PM Changeset in webkit [44671] by
-
- 6 edits4 adds in trunk
2009-06-14 Simon Fraser <Simon Fraser>
Reviewed by Darin Adler
Fix an issue noted on quirksmode.com where dynamically adding siblings does not
update :nth-child style correctly.
Test: fast/css/nth-child-dynamic.html
- dom/Node.h: Change diff() to take const RenderStyle*
- dom/Node.cpp: (WebCore::Node::diff): When comparing styles to decide whether to detach and reattach, we need to look at whether the pseudoclass-related data in the style changed (since RenderStyle::diff doesn't check this).
- rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::getCachedPseudoStyle): (WebCore::RenderStyle::inheritedNotEqual): Make these methods const.
- rendering/style/RenderStyle.h: (WebCore::InheritedFlags::styleType): (WebCore::InheritedFlags::pseudoClassStateEquivalent): Make methods const. Add new method that compares the pseudoclass-related members.
- 12:03 AM Changeset in webkit [44670] by
-
- 7 edits2 adds in trunk/SunSpider
Update V8 benchmark to version 4.
Reviewed by Cameron Zwarich.
- tests/LIST-V8:
- tests/v8-crypto.js:
- tests/v8-deltablue.js:
- tests/v8-earley-boyer.js:
- tests/v8-raytrace.js:
- tests/v8-regexp.js: Added.
- tests/v8-richards.js:
- tests/v8-splay.js: Added.
Jun 13, 2009:
- 11:44 PM Changeset in webkit [44669] by
-
- 5 edits2 adds in trunk/WebCore
2009-06-13 Peter Kasting <pkasting@google.com>
Reviewed by Kevin Ollivier.
https://bugs.webkit.org/show_bug.cgi?id=25709 part eleven
Write a wx implementation so the wx port can compile. For now this is
mostly a copy of the Cairo port, but in the future it can be changed to
use a wxBitmap as the storage type everywhere (just as Cairo can
probably be changed).
Also ASSERT for any other ports who call getAddr() (I don't think there
are any, and besides, they probably won't link, but this doesn't hurt).
Also fixes a dumb Cairo build bustage typo introduced in part ten.
- platform/graphics/wx/ImageSourceWx.cpp: (WebCore::ImageSource::createFrameAtIndex):
- platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::getAddr):
- platform/image-decoders/cairo/ImageDecoderCairo.cpp: (WebCore::RGBA32Buffer::setStatus):
- platform/image-decoders/wx: Added.
- platform/image-decoders/wx/ImageDecoderWx.cpp: Added. (WebCore::RGBA32Buffer::RGBA32Buffer): (WebCore::RGBA32Buffer::clear): (WebCore::RGBA32Buffer::zeroFill): (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::setSize): (WebCore::RGBA32Buffer::asNewNativeImage): (WebCore::RGBA32Buffer::hasAlpha): (WebCore::RGBA32Buffer::setHasAlpha): (WebCore::RGBA32Buffer::setStatus): (WebCore::RGBA32Buffer::operator=): (WebCore::RGBA32Buffer::width): (WebCore::RGBA32Buffer::height):
- webcore-wx.bkl:
- 10:06 PM Changeset in webkit [44668] by
-
- 2 edits in trunk/WebKit/mac
2009-06-09 Justin Garcia <justin.garcia@apple.com>
Reviewed by Eric Seidel. Landed by Adam Barth.
REGRESSION: Copying from TextEdit/OmniGraffle and pasting into editable
region loses images
Prefer RTFD (RTF with inline images) over RTF. In
http://trac.webkit.org/changeset/19745 I accidently reversed their
order.
- WebView/WebHTMLView.mm: (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
- 9:53 PM Changeset in webkit [44667] by
-
- 5 edits in trunk/WebCore
2009-06-13 Stephen White <senorblanco@chromium.org>
Reviewed by Dimitri Glazkov. Landed by Adam Barth.
Some minor code cleanup for chromium/skia port. Removed #ifdef's
around skia API changes, since the new version seems solid and we
don't need to go back. Added some comments to
TransparencyWin.h, as requested by Brett in
https://bugs.webkit.org/show_bug.cgi?id=24584.
- platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::createFontPlatformData):
- platform/graphics/chromium/TransparencyWin.h:
- platform/graphics/skia/PathSkia.cpp: (WebCore::Path::boundingRect): (WebCore::boundingBoxForCurrentStroke):
- platform/graphics/skia/SkiaUtils.cpp: (WebCore::SkPathContainsPoint):
- 9:29 PM Changeset in webkit [44666] by
-
- 1 edit in trunk/WebCore/page/SecurityOrigin.cpp
Build fix: Another missing header. Arg.
- 9:24 PM Changeset in webkit [44665] by
-
- 1 edit in trunk/WebCore/page/SecurityOrigin.cpp
Build fix: add missing header.
- 9:14 PM Changeset in webkit [44664] by
-
- 12 edits in trunk
WebCore:
2009-06-13 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
Moved registerURLSchemeAsLocal and registerURLSchemeAsNoAccess from
FrameLoader to SecurityOrigin.
- WebCore.base.exp:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::loadFrameRequest): (WebCore::FrameLoader::canLoad):
- loader/FrameLoader.h:
- page/SecurityOrigin.cpp: (WebCore::localSchemes): (WebCore::noAccessSchemes): (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::isLocal): (WebCore::SecurityOrigin::registerURLSchemeAsLocal): (WebCore::SecurityOrigin::shouldTreatURLAsLocal): (WebCore::SecurityOrigin::shouldTreatURLSchemeAsLocal): (WebCore::SecurityOrigin::registerURLSchemeAsNoAccess): (WebCore::SecurityOrigin::shouldTreatURLSchemeAsNoAccess):
- page/SecurityOrigin.h:
WebKit/mac:
2009-06-13 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
Move registerURLSchemeAsLocal from FrameLoader to SecurityOrigin
- WebView/WebView.mm: (+[WebView registerURLSchemeAsLocal:]):
WebKit/qt:
2009-06-13 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
Move registerURLSchemeAsLocal from FrameLoader to SecurityOrigin.
- Api/qwebpage.cpp: (QWebPage::acceptNavigationRequest):
WebKit/win:
2009-06-13 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
Move registerURLSchemeAsLocal from FrameLoader to SecurityOrigin.
- WebView.cpp: (WebView::registerURLSchemeAsLocal):
- 8:47 PM Changeset in webkit [44663] by
-
- 3 edits in trunk/WebCore
2009-06-13 Ben Murdoch <benm@google.com>
Reviewed by David Kilzer. Landed by Adam Barth.
This patch changes the way PageGroups create their localStorage
objects. Rather than creating a local storage object for the page group
when a page is added to the group, the local storage object is now
created lazily when the local storage object is requested by the
DOMWindow.
- page/PageGroup.cpp: (WebCore::PageGroup::closeLocalStorage): Before attempting to close a local storage object for a page group, ensure one has been created. (WebCore::PageGroup::addPage): Do not automatically try to create a local storage object when a page is added to the group. (WebCore::PageGroup::localStorage): Create a local storage object if one does not exist and return it.
- page/PageGroup.h: Add private hasLocalStorage method to PageGroup.
- 8:44 PM Changeset in webkit [44662] by
-
- 23 edits in trunk/WebCore
2009-06-13 Ben Murdoch <benm@google.com>
Reviewed by Eric Seidel. Landed by Adam Barth.
Add ENABLE(DOM_STORAGE) guards to the dom storage source files.
- storage/LocalStorage.cpp: Add ENABLE(DOM_STORAGE) guards to the file.
- storage/LocalStorage.h: Ditto
- storage/LocalStorageArea.cpp: Ditto
- storage/LocalStorageArea.h: Ditto
- storage/LocalStorageTask.cpp: Ditto
- storage/LocalStorageTask.h: Ditto
- storage/LocalStorageThread.cpp: Ditto
- storage/LocalStorageThread.h: Ditto
- storage/SessionStorage.cpp: Ditto
- storage/SessionStorage.h: Ditto
- storage/SessionStorageArea.cpp: Ditto
- storage/SessionStorageArea.h: Ditto
- storage/Storage.cpp: Ditto
- storage/Storage.h: Ditto
- storage/StorageArea.cpp: Ditto
- storage/StorageArea.h: Ditto
- storage/StorageEvent.cpp: Ditto
- storage/StorageEvent.h: Ditto
- storage/StorageMap.cpp: Ditto
- storage/StorageMap.h: Ditto
- storage/StorageEvent.idl: Add Conditional=DOM_STORAGE attribute.
- storage/Storage.idl: Ditto
- 6:00 PM Changeset in webkit [44661] by
-
- 3 edits1 add1 delete in trunk/WebCore
2009-06-13 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25709 part ten
Make Skia use the root directory ImageDecoder.h and factor out most
Skia-specific bits into skia/ImageDecoderSkia.cpp. Also fix a pair of
style violations in ImageDecoderCairo.cpp. This is the last patch for
this bug, everything beyond this is an enhancement rather than
unforking.
- platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::getAddr):
- platform/image-decoders/cairo/ImageDecoderCairo.cpp: (WebCore::RGBA32Buffer::hasAlpha): (WebCore::RGBA32Buffer::setHasAlpha): (WebCore::setStatus):
- platform/image-decoders/skia/ImageDecoder.h: Removed.
- platform/image-decoders/skia/ImageDecoderSkia.cpp: Added. (WebCore::RGBA32Buffer::RGBA32Buffer): (WebCore::RGBA32Buffer::clear): (WebCore::RGBA32Buffer::zeroFill): (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::setSize): (WebCore::RGBA32Buffer::asNewNativeImage): (WebCore::RGBA32Buffer::hasAlpha): (WebCore::RGBA32Buffer::setHasAlpha): (WebCore::RGBA32Buffer::setStatus): (WebCore::RGBA32Buffer::operator=): (WebCore::RGBA32Buffer::width): (WebCore::RGBA32Buffer::height):
- 4:11 PM Changeset in webkit [44660] by
-
- 2 edits in trunk/WebKitTools
2009-06-13 Sam Weinig <sam@webkit.org>
Rubber-stamped by Mark "Snowy" Rowe.
Update iExploder/htdocs/cssproperties.in by running update-iexploder-cssproperties.
- iExploder/htdocs/cssproperties.in:
- 2:35 PM Changeset in webkit [44659] by
-
- 2 edits2 adds in trunk/WebCore
2009-06-13 Victor Wang <victorw@chromium.org>
Reviewed by Eric Seidel. Landed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=26333
Alert during a dragenter event handler will crash the renderer
This crash is casued by calling NULL pointer m_documentUnderMouse in
DragController::tryDocumentDrag()
tryDHTMLDrag fires dragenter event. The event listener that listens
to this event may create a nested message loop (open a modal dialog),
which could process dragleave event and reset m_documentUnderMouse in
dragExited.
Fix the crash by checking m_documentUnderMouse after tryDHTMLDrag and
do not continue if the pointer has been set to NULL.
Test: DRT does not show alerts so add a manual test:
manual-tests/drag-enter-alert.html
- manual-tests/drag-enter-alert.html: Added.
- manual-tests/resources/drag-image.png: Added.
- page/DragController.cpp: (WebCore::DragController::tryDocumentDrag):
- 2:27 PM Changeset in webkit [44658] by
-
- 2 edits2 adds in trunk/WebCore
2009-06-13 Nate Chapin <japhet@google.com>
Reviewed by Dimitri Glazkov. Landed by Adam Barth.
Moved V8 Bindings for V8CustomXPathNSResolver to svn.webkit.org.
- bindings/v8/custom/V8CustomXPathNSResolver.cpp: Added. (WebCore::V8CustomXPathNSResolver::V8CustomXPathNSResolver): Moved from src.chromium.org. (WebCore::V8CustomXPathNSResolver::~V8CustomXPathNSResolver): Moved from src.chromium.org. (WebCore::V8CustomXPathNSResolver::lookupNamespaceURI): Moved from src.chromium.org.
- bindings/v8/custom/V8CustomXPathNSResolver.h: Added.
- bindings/v8/custom/V8DocumentCustom.cpp: Updated includes. (WebCore::CALLBACK_FUNC_DECL): Updated class name.
- 2:23 PM Changeset in webkit [44657] by
-
- 1 edit1 delete in trunk/WebKitTools
2009-06-13 John Abd-El-Malek <jam@chromium.org>
Reviewed by Eric Seidel. Landed by Adam Barth.
Removed dead file.
https://bugs.webkit.org/show_bug.cgi?id=26308
- DumpRenderTree/win/TestNetscapePlugin/main.c: Removed.
- 2:19 PM Changeset in webkit [44656] by
-
- 6 edits in trunk/WebCore
2009-06-13 Laszlo Gombos <Laszlo Gombos>
Reviewed by Mark Rowe. Landed by Adam Barth.
Remove obsolete declarations for old Symbian port
https://bugs.webkit.org/show_bug.cgi?id=26339
- platform/graphics/FloatPoint.h: Remove declarations for native SYMBIAN adaptation.
- platform/graphics/FloatRect.h: Ditto.
- platform/graphics/IntPoint.h: Ditto.
- platform/graphics/IntRect.h: Ditto.
- platform/graphics/IntSize.h: Ditto.
- 12:54 PM Changeset in webkit [44655] by
-
- 33 edits10 adds in trunk
2009-06-13 Dirk Schulze <krit@webkit.org>
Reviewed by Eric Seidel.
Added subRegion calculation to SVG filter. Every filter effect is
clipped to the filter region (according to the spec). This makes
ImageBuffers for filter effects smaller and we just need to take
care about big filter regions.
SVGFEImage needed a correction, to avoid an ASSERT. The two filter
effects feOffset and feFlood help to test the new subRegion code.
Tests: svg/filters/subRegion-one-effect.svg
svg/filters/subRegion-two-effects.svg
Added tests for the new subRgion-code on SVG filters.
- platform/mac/svg/filters: Added.
- platform/mac/svg/filters/subRegion-one-effect-expected.checksum: Added.
- platform/mac/svg/filters/subRegion-one-effect-expected.png: Added.
- platform/mac/svg/filters/subRegion-one-effect-expected.txt: Added.
- platform/mac/svg/filters/subRegion-two-effects-expected.checksum: Added.
- platform/mac/svg/filters/subRegion-two-effects-expected.png: Added.
- platform/mac/svg/filters/subRegion-two-effects-expected.txt: Added.
- svg/filters: Added.
- svg/filters/subRegion-one-effect.svg: Added.
- svg/filters/subRegion-two-effects.svg: Added.
- 12:36 PM Changeset in webkit [44654] by
-
- 3 edits in trunk/WebCore
2009-06-13 Peter Kasting <pkasting@google.com>
Bustage: Fix broken GIFs on Cairo due to subtle typo. Fix a warning.
- platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::copyRowNTimes):
- platform/image-decoders/bmp/BMPImageReader.cpp: (WebCore::BMPImageReader::processBitmasks):
- 12:10 PM Changeset in webkit [44653] by
-
- 3 edits in trunk/WebCore
2009-06-13 Peter Kasting <pkasting@google.com>
GTK bustage fix. "inline" is handled differently by different compilers.
- platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::getAddr):
- platform/image-decoders/cairo/ImageDecoderCairo.cpp:
- 11:55 AM Changeset in webkit [44652] by
-
- 4 edits2 adds in trunk/WebCore
2009-06-13 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25709 part nine
Factor Cairo-specific implementation out of ImageDecoder.h into
ImageDecoderCairo.cpp. Add some comments to functions declared
in ImageDecoder.h.
- GNUmakefile.am:
- WebCore.vcproj/WebCore.vcproj:
- platform/image-decoders/ImageDecoder.h:
- platform/image-decoders/cairo: Added.
- platform/image-decoders/cairo/ImageDecoderCairo.cpp: Added. (WebCore::RGBA32Buffer::RGBA32Buffer): (WebCore::RGBA32Buffer::clear): (WebCore::RGBA32Buffer::zeroFill): (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::setSize): (WebCore::RGBA32Buffer::asNewNativeImage): (WebCore::RGBA32Buffer::hasAlpha): (WebCore::RGBA32Buffer::setHasAlpha): (WebCore::RGBA32Buffer::operator=): (WebCore::RGBA32Buffer::width): (WebCore::RGBA32Buffer::height): (WebCore::RGBA32Buffer::getAddr):
- 10:52 AM Changeset in webkit [44651] by
-
- 3 edits in trunk/JavaScriptCore
2009-06-12 Dave Hyatt <hyatt@apple.com>
Reviewed by Anders Carlsson.
Add a new class to Threading in wtf called ReadWriteLock that handles single writer/multiple reader locking.
Provide a pthreads-only implementation of the lock for now, as this class is only going to be used
on Snow Leopard at first.
- wtf/Threading.h: (WTF::ReadWriteLock::impl):
- wtf/ThreadingPthreads.cpp: (WTF::ReadWriteLock::ReadWriteLock): (WTF::ReadWriteLock::~ReadWriteLock): (WTF::ReadWriteLock::readLock): (WTF::ReadWriteLock::tryReadLock): (WTF::ReadWriteLock::writeLock): (WTF::ReadWriteLock::tryWriteLock): (WTF::ReadWriteLock::unlock):
- 10:20 AM Changeset in webkit [44650] by
-
- 4 edits in trunk/WebCore
2009-06-13 David Hyatt <hyatt@apple.com>
Reviewed by Darin Adler.
Cleanup of the new MidpointState class. Turn it into a struct instead. Fix a mistaken
assertion removal and some unintentional whitespace changes.
- platform/text/BidiResolver.h: (WebCore::MidpointState::reset):
- rendering/RenderBlock.h:
- rendering/bidi.cpp: (WebCore::BidiRun::operator delete): (WebCore::chopMidpointsAt): (WebCore::checkMidpoints): (WebCore::addMidpoint): (WebCore::appendRunsForObject): (WebCore::RenderBlock::findNextLineBreak):
Jun 12, 2009:
- 11:04 PM Changeset in webkit [44649] by
-
- 4 edits in trunk/WebCore
2009-06-12 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
Remove the global variables in bidi.cpp. Make a new struct, MidpointState, that holds all of the
midpoint information. Add the remaining global variables as arguments passed down through functions
as needed.
- platform/text/BidiResolver.h: (WebCore::MidpointState::MidpointState): (WebCore::MidpointState::reset): (WebCore::BidiResolver::midpointState):
- rendering/RenderBlock.h:
- rendering/bidi.cpp: (WebCore::BidiRun::operator delete): (WebCore::chopMidpointsAt): (WebCore::checkMidpoints): (WebCore::addMidpoint): (WebCore::appendRunsForObject): (WebCore::RenderBlock::bidiReorderLine): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::determineStartPosition): (WebCore::skipNonBreakingSpace): (WebCore::shouldCollapseWhiteSpace): (WebCore::requiresLineBox): (WebCore::RenderBlock::generatesLineBoxesForInlineChild): (WebCore::RenderBlock::skipTrailingWhitespace): (WebCore::RenderBlock::skipLeadingWhitespace): (WebCore::shouldSkipWhitespaceAfterStartObject): (WebCore::RenderBlock::findNextLineBreak):
- 10:03 PM Changeset in webkit [44648] by
-
- 2 edits in trunk/WebCore
Build fix for Qt. After recent ImageDeocder.h changes.
I want the original change to be backed out as the whole
Skia merging is going in the wrong direction. The discussion
will happen in the bugtracker.
- 9:15 PM WebDevelopers edited by
- (diff)
- 7:41 PM Changeset in webkit [44647] by
-
- 4 edits in trunk
2009-06-12 Jan Michael Alonzo <jmalonzo@webkit.org>
Reviewed by Gustavo Noronha.
[Gtk] Enable more http/tests/navigation tests
- platform/gtk/Skipped:
[Gtk] use strlen instead of g_utf8_strlen so we can enable more tests.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (dumpHistoryItem):
- 7:31 PM Changeset in webkit [44646] by
-
- 2 edits in trunk/WebCore
2009-06-12 Jan Michael Alonzo <jmalonzo@webkit.org>
Gtk build fix: include cstdio so we can use sscanf
Gtk/Win Cairo build fix: use isASCIISpace instead of isspace
Suggested by Brent Fulgham
- platform/image-decoders/xbm/XBMImageDecoder.cpp: (WebCore::XBMImageDecoder::decodeDatum):
- 6:23 PM Changeset in webkit [44645] by
-
- 2 edits in trunk/WebCore
2009-06-12 Peter Kasting <pkasting@google.com>
Yet another Skia bustage fix.
- platform/image-decoders/skia/ImageDecoder.h: (WebCore::RGBA32Buffer::setSize): Avoid symbol name clash. The better fix is to take an IntSize(); I'll do that later.
- 6:18 PM Changeset in webkit [44644] by
-
- 4 edits in trunk/JavaScriptCore
Make LiteralParser non-recursive
Reviewed by Geoff Garen.
Convert LiteralParser from using a simple recursive descent parser
to a hand rolled PDA. Relatively simple conversion, but required
modifications to MarkedArgumentBuffer to make it more suitable as
a generic marked vector. I'll refactor and rename MarkedArgumentBuffer
in future as there are many other cases where it will be useful to
have such a class.
- 5:56 PM Changeset in webkit [44643] by
-
- 3 edits in trunk/WebCore
2009-06-12 Peter Kasting <pkasting@google.com>
Fix remaining Cairo build bustage from
https://bugs.webkit.org/show_bug.cgi?id=25709 changes. Use
Vector<char> in place of std::string.
- platform/image-decoders/xbm/XBMImageDecoder.cpp: (WebCore::XBMImageDecoder::setData): (WebCore::XBMImageDecoder::decodeHeader): (WebCore::XBMImageDecoder::decodeDatum):
- platform/image-decoders/xbm/XBMImageDecoder.h:
- 5:47 PM Changeset in webkit [44642] by
-
- 3 edits in trunk/JavaScriptCore
2009-06-12 David Levin <levin@chromium.org>
Reviewed by NOBODY (build fix for windows).
Adjust the exports for JSC on Windows like what was done for OSX in
the previous commit.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
- 5:41 PM Changeset in webkit [44641] by
-
- 6 edits in trunk
2009-06-12 David Levin <levin@chromium.org>
Reviewed by Darin Adler.
UString shouldn't create sharedBuffer for SmallStrings.
https://bugs.webkit.org/show_bug.cgi?id=26360
The methods changed are not used by JSC, so there is no JS perf impact. However,
there is a potential DOM perf impact, so I re-ran several of the tests that
I ran previously and ensured that the perf stay the same which caused me to
adjust the minLengthToShare.
- JavaScriptCore.exp:
- runtime/UString.cpp: (JSC::UString::Rep::sharedBuffer):
Determines if the buffer being shared is big enough before doing so.
Previously, BaseString::sharedBuffer was called but it would only know
the length of the base string (BaseString::len) which may not be the same
as the string being shared (Rep::len).
(JSC::UString::BaseString::sharedBuffer):
This is now only be used by Rep::sharedBuffer. which does the length check.
- runtime/UString.h:
WebCore:
2009-06-12 David Levin <levin@chromium.org>
Reviewed by Darin Adler.
UString shouldn't create sharedBuffer for SmallStrings.
https://bugs.webkit.org/show_bug.cgi?id=26347
Change the call to use the method UString::Rep::sharedBuffer due
to changes in UString.
No noticable change in behavior, so no test.
- platform/text/StringImpl.cpp: (WebCore::StringImpl::create):
- 5:11 PM Changeset in webkit [44640] by
-
- 3 edits2 adds in trunk
2009-06-12 Simon Fraser <Simon Fraser>
Reviewed by Dan Bernstein
Fix crash when a renderer for an anonymous node is composited
by null-checking renderer()->node().
Test: compositing/generated-content.html
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::createGraphicsLayer): (WebCore::RenderLayerBacking::rendererHasBackground): (WebCore::RenderLayerBacking::rendererBackgroundColor): (WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer): (WebCore::RenderLayerBacking::paintIntoLayer):
- 5:04 PM Changeset in webkit [44639] by
-
- 3 edits in trunk/WebCore
2009-06-12 Peter Kasting <pkasting@google.com>
Fix Chromium and some of Cairo build bustage, fallout from
https://bugs.webkit.org/show_bug.cgi?id=25709 changes.
- WebCore.vcproj/WebCore.vcproj: Add missing XBM decoder files.
- platform/image-decoders/skia/ImageDecoder.h: (WebCore::RGBA32Buffer::copyRowNTimes): Fix typo that broke Skia GIF decoding.
- 4:39 PM Changeset in webkit [44638] by
-
- 4 edits1 copy4 moves3 adds in trunk/WebKitSite
2009-06-12 Brady Eidson <beidson@apple.com>
Reviewed by Oliver Hunt
Add a page indexing the various demo applications we have posted.
- demos/index.html: Added.
- nav.inc: Add a link to the demos page on the side bar
- css/main.css: Add a style for date stamps based on the blog.
- demos/calendar/index.html: Added to redirect to Calendar.html. I'm not moving Calendar.html to index.html as the Calendar.html url has already been published and we should keep it working.
Move the drosera test code to /misc, as it is no longer a meaningful demo:
- demos/drosera: Removed.
- demos/drosera/demo.js: Removed.
- demos/drosera/drosera.png: Removed.
- demos/drosera/index.html: Removed.
- misc/drosera: Copied from demos/drosera.
Move the sticky notes example into /demos:
- demos/sticky-notes: Added.
- demos/sticky-notes/StickyNotes.manifest: Copied from misc/DatabaseExample.manifest.
- demos/sticky-notes/deleteButton.png: Copied from misc/deleteButton.png.
- demos/sticky-notes/deleteButtonPressed.png: Copied from misc/deleteButtonPressed.png.
- demos/sticky-notes/index.html: Copied from misc/DatabaseExample.html.
- misc/DatabaseExample.html: Changed to redirect to demos/sticky-notes/index.html. I'm not removing it altogether as the misc/DatabaseExample.html url has already been published and we should keep it working.
- misc/DatabaseExample.manifest: Removed.
- misc/deleteButton.png: Removed.
- misc/deleteButtonPressed.png: Removed.
- 4:38 PM Changeset in webkit [44637] by
-
- 3 edits in trunk/WebCore
2009-06-12 Simon Fraser <Simon Fraser>
Fix build when ACCELERATED_COMPOSITING is defined.
- loader/EmptyClients.h: (WebCore::EmptyChromeClient::attachRootGraphicsLayer): (WebCore::EmptyChromeClient::setNeedsOneShotDrawingSynchronization): (WebCore::EmptyChromeClient::scheduleViewUpdate): Add stubs for the compositing-related ChromeClient methods.
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateRootLayerPosition): (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): docWidth()/docHeight() became private. Use overflowWidth()/overflowHeight() instead, which matches what is used to size the WebHTMLView.
- 4:20 PM Changeset in webkit [44636] by
-
- 1 edit1 add in trunk/WebCore
2009-06-12 jorlow <jorlow@chromium.org>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=26356
http://crbug.com/14006
Create custom bindings for v8. The rest of these files are still
forked (so the review is happening on the chromium review site).
These bindings have been tested on a hacked up Chromium instance
(also running --single-process) and Android.
- bindings/v8/custom/V8StorageCustom.cpp: Added.
- 4:20 PM Changeset in webkit [44635] by
-
- 3 edits in trunk/WebCore
2009-06-12 Dmitry Titov <dimich@chromium.org>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=26359
[v8] Add XMLHttpRequest to WorkerContextExecutionProxy.
- bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::ToV8Object): Add type == V8ClassIndex::XMLHTTPREQUEST to the convertable types. (WebCore::WorkerContextExecutionProxy::EventTargetToV8Object): same.
- bindings/v8/WorkerContextExecutionProxy.h: fix typo in the comment.
- 3:55 PM Changeset in webkit [44634] by
-
- 7 edits8 moves8 deletes in trunk/WebCore
2009-06-12 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25709 part eight
Replace placeholder Cairo BMP, ICO, XBM decoders with real ones. Remove
all the decoders from skia/ since they are now just mirrors of the Cairo
ones.
- GNUmakefile.am:
- WebCore.vcproj/WebCore.vcproj:
- WebCoreSources.bkl:
- platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::createDecoder): Pass IntSize() to ICOImageDecoder() so it will always decode the largest icon. Enable XBM decoding on Windows.
- platform/graphics/skia/ImageSourceSkia.cpp:
- platform/graphics/wx/ImageSourceWx.cpp: (WebCore::createDecoder): Pass IntSize() to ICOImageDecoder() so it will always decode the largest icon.
- platform/image-decoders/bmp/BMPImageDecoder.cpp: Replaced with WebCore/platform/image-decoders/skia/BMPImageDecoder.cpp.
- platform/image-decoders/bmp/BMPImageDecoder.h: Replaced with WebCore/platform/image-decoders/skia/BMPImageDecoder.h.
- platform/image-decoders/bmp/BMPImageReader.cpp: Copied from WebCore/platform/image-decoders/skia/BMPImageReader.cpp.
- platform/image-decoders/bmp/BMPImageReader.h: Copied from WebCore/platform/image-decoders/skia/BMPImageReader.h.
- platform/image-decoders/ico/ICOImageDecoder.cpp: Replaced with WebCore/platform/image-decoders/skia/ICOImageDecoder.cpp.
- platform/image-decoders/ico/ICOImageDecoder.h: Replaced with WebCore/platform/image-decoders/skia/ICOImageDecoder.h.
- platform/image-decoders/skia/BMPImageDecoder.cpp: Removed.
- platform/image-decoders/skia/BMPImageDecoder.h: Removed.
- platform/image-decoders/skia/BMPImageReader.cpp: Removed.
- platform/image-decoders/skia/BMPImageReader.h: Removed.
- platform/image-decoders/skia/GIFImageDecoder.cpp: Removed.
- platform/image-decoders/skia/GIFImageDecoder.h: Removed.
- platform/image-decoders/skia/GIFImageReader.cpp: Removed.
- platform/image-decoders/skia/GIFImageReader.h: Removed.
- platform/image-decoders/skia/ICOImageDecoder.cpp: Removed.
- platform/image-decoders/skia/ICOImageDecoder.h: Removed.
- platform/image-decoders/skia/JPEGImageDecoder.cpp: Removed.
- platform/image-decoders/skia/JPEGImageDecoder.h: Removed.
- platform/image-decoders/skia/PNGImageDecoder.cpp: Removed.
- platform/image-decoders/skia/PNGImageDecoder.h: Removed.
- platform/image-decoders/skia/XBMImageDecoder.cpp: Removed.
- platform/image-decoders/skia/XBMImageDecoder.h: Removed.
- platform/image-decoders/xbm/XBMImageDecoder.cpp: Replaced with WebCore/platform/image-decoders/skia/XBMImageDecoder.cpp.
- platform/image-decoders/xbm/XBMImageDecoder.h: Replaced with WebCore/platform/image-decoders/skia/XBMImageDecoder.h.
- 3:41 PM Changeset in webkit [44633] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-12 Dimitri Glazkov <Dimitri Glazkov>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26191
Remove xmath include in MathExtras.h, because it is not needed and also
breaks VS2008 builds with TR1 turned on.
- wtf/MathExtras.h: Removed xmath include.
- 3:24 PM Changeset in webkit [44632] by
-
- 4 edits in trunk
2009-06-12 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=25599
[GTK] Enable more tests
Implement dumping of status callback.
- DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewStatusBarTextChanged): (main):
- 3:17 PM Web Inspector edited by
- Changes to be more current. (diff)
- 3:06 PM Changeset in webkit [44631] by
-
- 8 edits in trunk/WebCore
2009-06-11 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=25709 part seven
Update Skia's ImageDecoder.h with a few changes designed to reduce the
delta between specific implementations of ImageDecoder.h. Update
Cairo's ImageDecoder.h to sync up with the API changes in the Skia
version in the last two chage sets. Update Cairo's PNG/JPEG/GIF
decoders to use the APIs as well. All the Cairo image decoder changes
are direct copies of the Skia versions except ImageDecoder.h, which is
modified in the necessary ways for the differences between Cairo and
Skia.
- platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::ImageSource::createFrameAtIndex): Use new RGBA32Buffer::asNewNativeImage() API.
- platform/image-decoders/ImageDecoder.h: Sync up with Skia version. (WebCore::RGBA32Buffer::): (WebCore::RGBA32Buffer::RGBA32Buffer): (WebCore::RGBA32Buffer::clear): (WebCore::RGBA32Buffer::zeroFill): (WebCore::RGBA32Buffer::copyBitmapData): (WebCore::RGBA32Buffer::copyRowNTimes): (WebCore::RGBA32Buffer::setSize): (WebCore::RGBA32Buffer::asNewNativeImage): (WebCore::RGBA32Buffer::hasAlpha): (WebCore::RGBA32Buffer::disposalMethod): (WebCore::RGBA32Buffer::setHasAlpha): (WebCore::RGBA32Buffer::setDisposalMethod): (WebCore::RGBA32Buffer::setRGBA): (WebCore::RGBA32Buffer::operator=): (WebCore::RGBA32Buffer::width): (WebCore::RGBA32Buffer::height): (WebCore::RGBA32Buffer::getAddr):
- platform/image-decoders/gif/GIFImageDecoder.cpp: Sync up with Skia version. (WebCore::GIFImageDecoder::initFrameBuffer): (WebCore::GIFImageDecoder::haveDecodedRow):
- platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Sync up with Skia version. (WebCore::JPEGImageDecoder::outputScanlines):
- platform/image-decoders/png/PNGImageDecoder.cpp: Sync up with Skia version. (WebCore::PNGImageDecoder::rowAvailable):
- platform/image-decoders/skia/ImageDecoder.h: Add various typedefs or helper functions to minimize differences with Cairo version. Reorder functions slightly to match reordering of Cairo's m_hasAlpha variable, which I moved to increase readability. (WebCore::RGBA32Buffer::): (WebCore::RGBA32Buffer::copyRowNTimes): (WebCore::RGBA32Buffer::setSize): (WebCore::RGBA32Buffer::asNewNativeImage): (WebCore::RGBA32Buffer::hasAlpha): (WebCore::RGBA32Buffer::disposalMethod): (WebCore::RGBA32Buffer::setHasAlpha): (WebCore::RGBA32Buffer::setStatus): (WebCore::RGBA32Buffer::setDisposalMethod): (WebCore::RGBA32Buffer::setRGBA): (WebCore::RGBA32Buffer::operator=): (WebCore::RGBA32Buffer::width): (WebCore::RGBA32Buffer::height): (WebCore::RGBA32Buffer::getAddr):
- platform/image-decoders/skia/JPEGImageDecoder.cpp: Add #include needed by JPEG headers on some platforms, plus comment.
- 2:36 PM Changeset in webkit [44630] by
-
- 2 edits in trunk/WebCore
2009-06-12 Brent Fulgham <bfulgham@webkit.org>
Unreviewed build correction.
Revert accidental configuration checkin. Was not meant to
be part of the last changeset.
- config.h:
- 2:34 PM Changeset in webkit [44629] by
-
- 2 edits in trunk/WebCore
(Accidentally missed a couple email addresses in the last patch)
- 2:25 PM Changeset in webkit [44628] by
-
- 9 edits in trunk/WebCore
2009-06-12 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=26353
Corrects handling of Cairo fonts that were getting out of
sync due to default copy construction. Also refactors
some incorrect platform font destruction code that belongs
in the font object's destructor.
- platform/graphics/win/FontPlatformData.h:
- platform/graphics/win/FontPlatformDataCGWin.cpp: (WebCore::FontPlatformData::~FontPlatformData):
- platform/graphics/win/FontPlatformDataCairoWin.cpp: (WebCore::FontPlatformData::platformDataInit): (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::setFont): (WebCore::FontPlatformData::~FontPlatformData):
- platform/graphics/win/FontPlatformDataWin.cpp:
- platform/graphics/win/SimpleFontDataCGWin.cpp:
- platform/graphics/win/SimpleFontDataCairoWin.cpp: (WebCore::SimpleFontData::platformInit): (WebCore::SimpleFontData::platformWidthForGlyph):
- platform/graphics/win/SimpleFontDataWin.cpp:
- 2:19 PM Changeset in webkit [44627] by
-
- 8 edits in trunk
2009-06-12 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
- ChangeLog-2007-10-14: Change pseudonym "Don Gibson" to me (was used while Google Chrome was not public); update my email address.
WebCore:
2009-06-12 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
- ChangeLog-2007-10-14: Update my email address.
- ChangeLog-2008-08-10: Update my email address.
WebKit/mac:
2009-06-12 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
- ChangeLog-2007-10-14: Change pseudonym "Don Gibson" to me (was used while Google Chrome was not public); update my email address.
WebKit/win:
2009-06-12 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
- ChangeLog: Update my email address.
- 1:00 PM QtWebKitTodo edited by
- (diff)
- 11:02 AM Changeset in webkit [44626] by
-
- 1 edit2 adds in trunk/WebCore
2009-06-12 Nate Chapin <japhet@google.com>
Reviewed by David Levin.
Upstream V8Helpers.
- bindings/v8/V8Helpers.cpp: Added. (wrapNPObject): Moved from v8_helpers.cpp. (toV8Context): Moved from v8_helpers.cpp. (toV8Proxy): Moved from v8_helpers.cpp.
- bindings/v8/V8Helpers.h: Added.
- 9:15 AM Changeset in webkit [44625] by
-
- 2 edits in trunk/JavaScriptCore
wx build fix. Adding JSONObject.cpp to the build.
- 8:55 AM Changeset in webkit [44624] by
-
- 4 edits in trunk/WebCore
Index: WebCore/ChangeLog
===================================================================
--- WebCore/ChangeLog (revision 44622)
+++ WebCore/ChangeLog (working copy)
@@ -1,3 +1,23 @@
+2009-06-12 Jessie Berlin <jberlin@apple.com>
+
+ Reviewed by Mark Rowe.
+
+ https://bugs.webkit.org/show_bug.cgi?id=24792
+ rdar://problem/6933055
+
+ Changes the radius in which cursor movement around the 4 arrow icon
+ while pan-scrolling does not cause scrolling from around 10 pixels to
+ 15 pixels, similar to what is found in IE and Firefox.
+
+ * page/EventHandler.cpp:
+ (WebCore::EventHandler::setPanScrollCursor):
+ Factor out the no-pan-scroll radius.
+ * platform/ScrollView.h:
+ Create a constant for the no-pan-scroll radius.
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::panScrollFromPoint):
+ Factor out the no-pan-scroll radius.
+
2009-06-12 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Index: WebCore/page/EventHandler.cpp
===================================================================
--- WebCore/page/EventHandler.cpp (revision 44622)
+++ WebCore/page/EventHandler.cpp (working copy)
@@ -661,11 +661,10 @@ void EventHandler::setPanScrollCursor()
At the original click location we draw a 4 arrowed icon. Over this icon there won't be any scroll
So we don't want to change the cursor over this area
- const int noScrollRadius = 9;
- bool east = m_panScrollStartPos.x() < (m_currentMousePosition.x() - noScrollRadius);
- bool west = m_panScrollStartPos.x() > (m_currentMousePosition.x() + noScrollRadius);
- bool north = m_panScrollStartPos.y() > (m_currentMousePosition.y() + noScrollRadius);
- bool south = m_panScrollStartPos.y() < (m_currentMousePosition.y() - noScrollRadius);
+ bool east = m_panScrollStartPos.x() < (m_currentMousePosition.x() - ScrollView::noPanScrollRadius);
+ bool west = m_panScrollStartPos.x() > (m_currentMousePosition.x() + ScrollView::noPanScrollRadius);
+ bool north = m_panScrollStartPos.y() > (m_currentMousePosition.y() + ScrollView::noPanScrollRadius);
+ bool south = m_panScrollStartPos.y() < (m_currentMousePosition.y() - ScrollView::noPanScrollRadius);
if (north) {
if (east)
Index: WebCore/platform/ScrollView.h
===================================================================
--- WebCore/platform/ScrollView.h (revision 44622)
+++ WebCore/platform/ScrollView.h (working copy)
@@ -214,7 +214,8 @@ public:
virtual void hide();
virtual void setParentVisible(bool);
- Pan scrolling methods.
+ Pan scrolling.
+ static const int noPanScrollRadius = 15;
void addPanScrollIcon(const IntPoint&);
void removePanScrollIcon();
Index: WebCore/rendering/RenderLayer.cpp
===================================================================
--- WebCore/rendering/RenderLayer.cpp (revision 44622)
+++ WebCore/rendering/RenderLayer.cpp (working copy)
@@ -948,7 +948,6 @@ void RenderLayer::panScrollFromPoint(con
const int shortDistanceLimit = 100; We delimit a 200 pixels long square enclosing the original point
const int speedReducer = 2; Within this square we divide the scrolling speed by 2
- const int iconRadius = 10;
Frame* frame = renderer()->document()->frame();
if (!frame)
return;
@@ -965,9 +964,9 @@ void RenderLayer::panScrollFromPoint(con
int xDelta = currentMousePosition.x() - sourcePoint.x();
int yDelta = currentMousePosition.y() - sourcePoint.y();
- if (abs(xDelta) < iconRadius) at the center we let the space for the icon
+ if (abs(xDelta) < ScrollView::noPanScrollRadius) at the center we let the space for the icon
xDelta = 0;
- if (abs(yDelta) < iconRadius)
+ if (abs(yDelta) < ScrollView::noPanScrollRadius)
yDelta = 0;
Let's attenuate the speed for the short distances
- 7:44 AM Changeset in webkit [44623] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-12 Laszlo Gombos <Laszlo Gombos>
Reviewed by Jan Michael Alonzo.
[Qt] Fix build break
https://bugs.webkit.org/show_bug.cgi?id=26340
- JavaScriptCore.pri: Add JSONObject.cpp to LUT files.
Jun 11, 2009:
- 11:46 PM Changeset in webkit [44622] by
-
- 2 edits in trunk/WebCore
2009-06-12 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
https://bugs.webkit.org/show_bug.cgi?id=25609
[GTK] Implement support for get_selection and get_n_selections
Only use the VisibleSelection object if it actually belongs to the
object we are using.
This is pretty hacky-ish, but I can't seem to find a direct API to
get the VisibleSelection for a given object, only the global one.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (selectionBelongsToObject): (webkit_accessible_text_get_n_selections): (webkit_accessible_text_get_selection):
- 5:58 PM Changeset in webkit [44621] by
-
- 2 edits1 add4 deletes in trunk/LayoutTests
2009-06-11 Ryosuke Niwa <rniwa@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=2628i
Converted LayoutTests\editing\deleting\4875189.html from a pixel test t
dumpAsText test
since it only checks whether the result contains exactly two paragraphs
or not.
- editing/deleting/4875189-expected.txt: Added.
- editing/deleting/4875189.html:
- platform/mac/editing/deleting/4875189-expected.checksum: Removed.
- platform/mac/editing/deleting/4875189-expected.png: Removed.
- platform/mac/editing/deleting/4875189-expected.txt: Removed.
- platform/qt/editing/deleting/4875189-expected.txt: Removed.
- 4:47 PM Changeset in webkit [44620] by
-
- 2 edits in trunk/WebKit/gtk
2009-06-11 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Xan Lopez.
Add a test to perform an actual download.
- tests/testdownload.c: (navigation_policy_decision_requested_cb): (notify_status_cb): (download_requested_cb): (test_webkit_download_perform): (main):
- 3:38 PM Changeset in webkit [44619] by
-
- 5 edits in trunk/WebKit/gtk
2009-06-11 Gustavo Noronha Silva <Gustavo Noronha Silva>
Reviewed by Xan Lopez.
Fix crash when downloading, caused by assuming SoupMessage would
be there. This change factors the logic required to create a
ResourceRequest from a WebKitNetworkRequest into a core()
function, like we have for some other classes.
- webkit/webkitdownload.cpp: (webkit_download_start):
- webkit/webkitprivate.cpp: (WebKit::core):
- webkit/webkitprivate.h:
- webkit/webkitwebframe.cpp: (webkit_web_frame_load_request):
- 3:17 PM Changeset in webkit [44618] by
-
- 1 edit12 adds in trunk/LayoutTests
2009-06-11 Eric Seidel <eric@webkit.org>
Rubber stamped by Dave Levin.
Add missing pixel results
- platform/mac/editing/style/apply-through-end-of-document-expected.checksum: Added.
- platform/mac/editing/style/apply-through-end-of-document-expected.png: Added.
- platform/mac/fast/canvas/canvas-empty-image-pattern-expected.checksum: Copied from LayoutTests/platform/mac-tiger/svg/custom/mask-excessive-malloc-expected.checksum.
- platform/mac/fast/canvas/canvas-empty-image-pattern-expected.png: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/canonicalform08-expected.png.
- platform/mac/fast/css/compare-content-style-expected.checksum: Added.
- platform/mac/fast/css/compare-content-style-expected.png: Added.
- platform/mac/fast/dynamic/anchor-lock-expected.checksum: Added.
- platform/mac/fast/dynamic/anchor-lock-expected.png: Added.
- platform/mac/fast/transforms/bounding-rect-zoom-expected.checksum: Added.
- platform/mac/fast/transforms/bounding-rect-zoom-expected.png: Added.
- platform/mac/webarchive/test-link-rel-icon-expected.checksum: Copied from LayoutTests/platform/mac-tiger/svg/custom/mask-excessive-malloc-expected.checksum.
- platform/mac/webarchive/test-link-rel-icon-expected.png: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/canonicalform08-expected.png.
- 2:20 PM Changeset in webkit [44617] by
-
- 4 edits in trunk/WebCore
Speculative fix
- 1:05 PM Changeset in webkit [44616] by
-
- 1 copy in tags/Safari-6530.18
New tag.
- 1:05 PM Changeset in webkit [44615] by
-
- 1 delete in branches/Safari-6530.18
Hrm, this isn't where I should live.
- 1:03 PM Changeset in webkit [44614] by
-
- 4 edits in branches/WWDC-2009-branch
Versioning.
- 1:02 PM Changeset in webkit [44613] by
-
- 1 copy in branches/Safari-6530.18
New tag.
- 12:59 PM Changeset in webkit [44612] by
-
- 13 edits in branches/WWDC-2009-branch
Merge r44591.
- 12:58 PM Changeset in webkit [44611] by
-
- 4 edits in branches/WWDC-2009-branch
Versioning.
- 11:47 AM Changeset in webkit [44610] by
-
- 5 edits in trunk
Lower stringify recursion limit to deal with small windows stack.
- 11:20 AM Changeset in webkit [44609] by
-
- 2 edits in trunk/WebKitTools
2009-06-11 John Abd-El-Malek <jam@chromium.org>
Reviewed by Steve Falkenburg.
Revert 42565 as it leads to DumpRenderTree crashing on startup because
Windows can't find CFURLCacheCopySharedURLCache in CoreNetwork.dll.
- DumpRenderTree/win/DumpRenderTree.cpp:
- 11:15 AM Changeset in webkit [44608] by
-
- 8 edits4 adds in trunk
2009-06-11 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=25512
Handle texts after unfinished special tags (i.e., script, style, textarea,
title, xmp, and iframe) as the text node under the tags in view-source mode.
Before this change, all texts in unfinished special tags cannot be seen even in view-source mode.
- 10:57 AM Changeset in webkit [44607] by
-
- 2 edits in trunk/JavaScriptCore
2009-06-11 Laszlo Gombos <Laszlo Gombos>
Reviewed by Holger Freyther.
Fix compilation warnings
<https://bugs.webkit.org/show_bug.cgi?id=26015>
- wtf/ThreadingNone.cpp: (WTF::ThreadCondition::wait): Fix compilation warning. (WTF::ThreadCondition::timedWait): Ditto.
- 10:39 AM Changeset in webkit [44606] by
-
- 2 edits in trunk
2009-06-11 Laszlo Gombos <Laszlo Gombos>
Reviewed by Holger Freyther.
[Qt] Fix release build detection
https://bugs.webkit.org/show_bug.cgi?id=26267
- WebKit.pri:
- 10:28 AM Changeset in webkit [44605] by
-
- 2 edits in trunk/WebCore
2009-06-11 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Ariya Hidayat.
[Qt] build break in ImageDecoderQt.cpp.
- platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::reset): (WebCore::ImageDecoderQt::setData): (WebCore::ImageDecoderQt::isSizeAvailable):
- platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::setSize):
- 9:34 AM Changeset in webkit [44604] by
-
- 3 edits in trunk/WebKitSite
2009-06-10 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Eric Seidel.
Fixes https://bugs.webkit.org/show_bug.cgi?id=26309.
Update a few items in the testing language to:
(1) Reflect results are now generated with Leopard (not Tiger)
(2) Explain how to generate pixel-level layout tests.
- 6:57 AM Changeset in webkit [44603] by
-
- 1 edit7 deletes in trunk/WebCore
2009-06-11 Simon Hausmann <simon.hausmann@nokia.com>
Rubber-stamped by Ariya Hidayat.
Removed obsolete and unmaintained files from the old Symbian port.
- 4:59 AM QtWebKitTodo edited by
- (diff)
- 4:58 AM QtWebKitTodo edited by
- (diff)
