Timeline


and

08/09/09:

17:47 Changeset [46969] by zimmermann@webkit.org

2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] wml.css lacks <pre> support
https://bugs.webkit.org/show_bug.cgi?id=28135

Add <pre> support for WML.
Extended fast/wml/text-emphasis.wml to cover <pre> support.

  • css/wml.css: <pre> section copied from html.css

2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] wml.css lacks <pre> support
https://bugs.webkit.org/show_bug.cgi?id=28135

Extend fast/wml/text-emphasis.wml test, to cover <pre> formatting.

  • fast/wml/text-emphasis.wml:
  • platform/mac/fast/wml/text-emphasis-expected.txt:
17:01 Changeset [46968] by zimmermann@webkit.org

Reviewed by Oliver Hunt.
Fix non-WML enabled builds. Remove ENABLE(WML) guards around the switch cases 'FrameLoadTypeBackWMLDeckNotAccessible'.

16:55 Changeset [46967] by oliver@apple.com

JSON.stringify replacer returning undefined does not omit object properties
https://bugs.webkit.org/show_bug.cgi?id=28118

Reviewed by George Staikos

Correct behaviour of stringify when using a replacer function that returns
undefined. This is a simple change to move the undefined value check to
after the replacer function is called. This means that the replacer function
is now called for properties with the value undefined, however i've confirmed
that this behaviour is correct.

In addition I've made the cyclic object exception have a more useful error
message.

16:33 Changeset [46966] by zimmermann@webkit.org

2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] Deck access control is completly broken
https://bugs.webkit.org/show_bug.cgi?id=27721

Synchronize WebFrameLoadType with FrameLoadType enum. Append 'WebFrameLoadTypeBackWMLDeckNotAccessible'.

  • WebView/WebFramePrivate.h:

2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] Deck access control is completly broken
https://bugs.webkit.org/show_bug.cgi?id=27721

Synchronize WebFrameLoadType with FrameLoadType enum. Append 'WebFrameLoadTypeBackWMLDeckNotAccessible'.

  • Interfaces/IWebFramePrivate.idl:

2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] Deck access control is completly broken
https://bugs.webkit.org/show_bug.cgi?id=27721

Rewrite WML deck access control, actually works now standalone and within LayoutTests.
Added several new layout tests covering local & remote access support.

In order to detect WML task execution failures from within the WML layout tests a new
method Console::lastWMLErrorMessage() has been added, returning the last recorded WML
error message. Change WML log messages to dump to InspectorClient, just like it's done
for HTML - we used to behave like JSMessageSource, which is wrong.

Tests: http/tests/wml/access-target-domain-deny.html

http/tests/wml/access-target-path-deny.html
http/tests/wml/access-target.html
wml/access-target-deny.html
wml/access-target.html

  • inspector/ConsoleMessage.h: (WebCore::ConsoleMessage::source): Added public method to fetch the message source type. (WebCore::ConsoleMessage::message): Added public method to access the error message.
  • inspector/InspectorController.h: (WebCore::InspectorController::consoleMessages): Added for Console::lastWMLErrorMessage(), to be able to crawl through the list of dumped messages.
  • loader/FrameLoader.cpp: Recognize 'FrameLoadTypeBackWMLDeckNotAccessible', all guarded by ENABLE(WML). (WebCore::isBackForwardLoadType): (WebCore::FrameLoader::restoreDocumentState): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::loadItem):
  • loader/FrameLoaderTypes.h: (WebCore::): Add new load type 'FrameLoadTypeBackWMLDeckNotAccessible', behaving like FrameLoadTypeBack plus WML specific information.
  • page/Console.cpp: (WebCore::Console::addMessage): Don't dump WML messages using ChromeClient (as it's done for JSMessageSource), but go through InspectorController. (WebCore::Console::lastWMLErrorMessage): Crawl InspectorController::consoleMssages() to look up the last WML error message, if present.
  • page/Console.h:
  • page/Console.idl: Add "[DontEnum] DOMString lastWMLErrorMessage()".
  • wml/WMLAccessElement.cpp: Store path/domain as member variables and pass them to WMLPageState once in insertedIntoDocument(). (WebCore::WMLAccessElement::parseMappedAttribute): (WebCore::WMLAccessElement::insertedIntoDocument):
  • wml/WMLAccessElement.h:
  • wml/WMLCardElement.cpp: Handle 'FrameLoadTypeBackWMLDeckNotAccessible' as deck-entry method. Report WML error in current deck. (WebCore::WMLCardElement::handleIntrinsicEventIfNeeded):
  • wml/WMLDocument.cpp: Enable deck-access control in finishedParsing. Take care of method name changes in WMLPageState. (WebCore::WMLDocument::finishedParsing): (WebCore::WMLDocument::initialize):
  • wml/WMLErrorHandling.cpp: Never report 'WMLErrorDeckNotAccessible' messages through the tokenizer, that would alter the page into error state. (WebCore::reportWMLError):
  • wml/WMLPageState.cpp: Completly rewrote access path/domain parsing & deck-access control, strictly following the WML spec. All covered by tests. (WebCore::WMLPageState::WMLPageState): (WebCore::normalizedHostName): (WebCore::hostFromURL): (WebCore::urlForHistoryItem): (WebCore::tryAccessHistoryURLs): (WebCore::WMLPageState::processAccessControlData): (WebCore::WMLPageState::resetAccessControlData): (WebCore::WMLPageState::canAccessDeck): (WebCore::WMLPageState::hostIsAllowedToAccess): (WebCore::WMLPageState::pathIsAllowedToAccess):
  • wml/WMLPageState.h:

2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] Deck access control is completly broken
https://bugs.webkit.org/show_bug.cgi?id=27721

Add several new tests covering WML deck-access control.
Update variable-reference-invalid-character.html result, as console messages aren't dump to the results anymore.

  • http/tests/wml/access-target-domain-deny-expected.txt: Added.
  • http/tests/wml/access-target-domain-deny.html: Added.
  • http/tests/wml/access-target-expected.txt: Added.
  • http/tests/wml/access-target-path-deny-expected.txt: Added.
  • http/tests/wml/access-target-path-deny.html: Added.
  • http/tests/wml/access-target.html: Added.
  • http/tests/wml/resources/access-target-domain-deny.js: Added. (setupTestDocument): (prepareTest): (executeTest):
  • http/tests/wml/resources/access-target-domain-deny.wml: Added.
  • http/tests/wml/resources/access-target-path-deny.js: Added. (setupTestDocument): (prepareTest): (executeTest):
  • http/tests/wml/resources/access-target-path-deny.wml: Added.
  • http/tests/wml/resources/access-target.js: Added. (setupTestDocument): (prepareTest): (executeTest):
  • http/tests/wml/resources/access-target.wml: Added.
  • http/tests/wml/resources/locked-deck.wml: Added.
  • http/tests/wml/resources/unreachable-domain.wml: Added.
  • http/tests/wml/resources/unreachable-path.wml: Added.
  • wml/access-target-deny-expected.txt: Added.
  • wml/access-target-deny.html: Added.
  • wml/access-target-expected.txt: Added.
  • wml/access-target.html: Added.
  • wml/resources/access-target-deny.js: Added. (setupTestDocument): (prepareTest): (executeTest):
  • wml/resources/access-target-deny.wml: Added.
  • wml/resources/access-target.js: Added. (setupTestDocument): (prepareTest): (executeTest):
  • wml/resources/access-target.wml: Added.
  • wml/resources/locked-deck.wml: Added.
  • wml/variable-reference-invalid-character-expected.txt:
15:04 Changeset [46965] by zimmermann@webkit.org

Reviewed by Maciej Stachowiak.

FrameLoadType / WebFrameLoadType enums are out of sync
https://bugs.webkit.org/show_bug.cgi?id=28132

Modify FrameLoadType enum to match the order of WebFrameLoadType in WebFramePrivate.h / IWebFramePrivate.idl.
The mac/win public API exposes the old 'FrameLoadTypeReloadAllowingStaleData' value, which resides between
'FrameLoadTypeReload' and 'FrameLoadTypeSame'. Work around this problem, by assigning 'FrameLoadTypeSame = FrameLoadTypeReload + 2'.

Add a note to the FrameLoadType enum to keep it in sync with WebFramePrivate.h & IWebFramePrivate.idl.

08:41 Changeset [46964] by zimmermann@webkit.org

2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] manual-tests/wml/onevent-prev.wml crashes
https://bugs.webkit.org/show_bug.cgi?id=27722

Fix intrinsic event execution, leading to crashes.
First finish parsing the document, then execute the events. Not the other way round.
-> exposes bugs all over the WML layout tests, which relied on that quirk.

Fixes manual-tests/wml/onevent-prev.wml.

  • wml/WMLDocument.cpp: (WebCore::WMLDocument::WMLDocument): (WebCore::WMLDocument::finishedParsing): (WebCore::WMLDocument::initialize):
  • wml/WMLDocument.h:

2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] manual-tests/wml/onevent-prev.wml crashes
https://bugs.webkit.org/show_bug.cgi?id=27722

Reorganize WML testcases to not rely on the fact that intrinsic events are executed before the document finished parsing.

  • http/tests/wml/resources/go-task-get-method-accept-charset.js:
  • http/tests/wml/resources/go-task-get-method.js:
  • http/tests/wml/resources/go-task-post-method-accept-charset.js:
  • http/tests/wml/resources/go-task-post-method.js:
  • http/tests/wml/resources/post-data-to-server.js:
  • wml/resources/WMLTestCase.js: (onloadHandler): (createStaticWMLTestCase): (createDynamicWMLTestCase): (createWMLTestCase.iframeElement.onload): (createWMLTestCase):
  • wml/resources/enter-card-with-events.js: (executeTest):
  • wml/resources/enter-first-card-with-events.js: (setupTestDocument): (prepareTest): (executeTest):
  • wml/resources/go-task-get-method-external-deck-with-href.js:
  • wml/resources/go-task-get-method-external-deck.js:
  • wml/resources/go-task-get-method-same-deck.js:
  • wml/resources/input-format.js:
  • wml/resources/newcontext-same-deck.js: (setupTestDocument): (executeTest):
  • wml/resources/onenterforward-event.js: (executeTest):
  • wml/resources/onenterforward-inline-event.js:
  • wml/resources/ontimer-event.js: (executeTest):
  • wml/resources/ontimer-inline-event.js: (executeTest):
  • wml/resources/option-element-onpick.js:
  • wml/resources/select-element-variables.js:
  • wml/resources/variable-reference-invalid-character.js:
  • wml/resources/variable-reference-valid.js:
03:33 Changeset [46963] by oliver@apple.com

[ES5] Implement Object.getPrototypeOf
https://bugs.webkit.org/show_bug.cgi?id=28114

Reviewed by Eric Seidel and Sam Weinig.

Implement getPrototypeOf

08/08/09:

18:36 Changeset [46962] by dglazkov@chromium.org

Updated ChangeLog with bug URLs.

18:31 Changeset [46961] by dglazkov@chromium.org

2009-08-08 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

[Chromium] Update WebCore.gyp to add ImageBuffer.cpp,
introduced by http://trac.webkit.org/changeset/46956.

  • WebCore.gypi: Added ImageBuffer.cpp.
16:28 Changeset [46960] by jmalonzo@webkit.org

2009-08-08 Jan Michael Alonzo <jmalonzo@webkit.org>

[Gtk] Skip media/controls-right-click-on-timebar.html as it needs
eventSender which we don't have at the moment.

  • platform/gtk/Skipped:
15:39 Changeset [46959] by zimmermann@webkit.org

Rubber-stamped by Jan Michael Alonzo.

Add [DontEnum] to WML specific initializeWMLPageState/resetWMLPageState methods, to assure
fast/dom/Window/window-properties.html doesn't show any differences when WML is enabled.

13:34 Changeset [46958] by krit@webkit.org

2009-08-08 Dirk Schulze <krit@webkit.org>

Reviewed by Eric Seidel.

SVG Filter need feColorMatrix implementation
https://bugs.webkit.org/show_bug.cgi?id=27711

Adds the filter effect feColorMatrix to SVG filters.

There is already a test in the w3c directory.
Test: svg/W3C-SVG-1.1/filters-color-01-b.svg

  • platform/graphics/filters/FEColorMatrix.cpp: (WebCore::matrix): (WebCore::saturate): (WebCore::huerotate): (WebCore::luminance): (WebCore::FEColorMatrix::apply):
12:32 Changeset [46957] by krit@webkit.org

2009-08-08 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

Build fix for Tiger.

  • platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::ImageBuffer):
12:11 Changeset [46956] by krit@webkit.org

2009-08-08 Dirk Schulze <krit@webkit.org>

Reviewed by Oliver Hunt.

This is an initial implementation for linearRGB and sRGB support for all
platforms. Some platforms like Cg support different color spaces
natively, others like Qt, Cairo and Skia do not. This patch uses the
native implementation of platforms if possible and offers a common version
if not.

Different color spaces are used in SVG Filters. Nearly every Filter test
case is a test for this patch and will be enabled, once Filters are enabled.

  • GNUmakefile.am:
  • WebCore.pro:
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawTextInternal):
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createImageBuffer):
  • platform/graphics/GeneratedImage.cpp: (WebCore::GeneratedImage::drawPattern):
  • platform/graphics/ImageBuffer.cpp: Added. (WebCore::ImageBuffer::transformColorSpace):
  • platform/graphics/ImageBuffer.h: (WebCore::): (WebCore::ImageBuffer::create):
  • platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::ImageBuffer): (WebCore::ImageBuffer::platformTransformColorSpace):
  • platform/graphics/cairo/ImageCairo.cpp: (WebCore::Image::drawPattern):
  • platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::ImageBuffer):
  • platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers):
  • platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::getEffectContext):
  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::ImageBuffer): (WebCore::ImageBuffer::platformTransformColorSpace):
  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::strokeContains): (WebCore::Path::strokeBoundingRect):
  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::ImageBuffer): (WebCore::ImageBuffer::platformTransformColorSpace):
  • platform/graphics/skia/SkiaUtils.cpp: (WebCore::scratchContext):
  • platform/graphics/wx/ImageBufferWx.cpp: (WebCore::ImageBuffer::ImageBuffer):
  • platform/mac/ScrollbarThemeMac.mm: (WebCore::ScrollbarThemeMac::paint):
  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended):
  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::buildPattern):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::nativeImageForCurrentFrame):
  • svg/graphics/SVGPaintServerGradient.cpp: (WebCore::createMaskAndSwapContextForTextGradient):
  • svg/graphics/SVGPaintServerPattern.cpp: (WebCore::SVGPaintServerPattern::setup):
  • svg/graphics/SVGResourceFilter.cpp: (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter):
  • svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::applyMask):
  • svg/graphics/filters/SVGFETile.cpp: (WebCore::FETile::apply):
10:13 Changeset [46955] by xan@webkit.org

WebCore:

2009-08-08 Xan Lopez <xlopez@igalia.com>

Roll out r46928, since it wasn't done in accordance with the
agreed naming.

  • bindings/gdom/GdomDOMObject.cpp: Removed.

WebKit/gtk:

2009-08-08 Xan Lopez <xlopez@igalia.com>

Roll out r46928, since it wasn't done in accordance with the
agreed naming.

  • ChangeLog:

Remove the ChangeLog entry, since it was added at the bottom of
the file.

  • gdom/GdomDOMObject.h: Removed.
  • gdom/GdomDOMObjectPrivate.h: Removed.
09:01 Changeset [46954] by abarth@webkit.org

2009-08-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

bugzilla-tool needs a --quiet option
https://bugs.webkit.org/show_bug.cgi?id=28060

A first pass at a --quiet option. This doesn't do all the excting
things we might want, but it addresses 80% of the use case.

  • Scripts/bugzilla-tool:
02:29 Changeset [46953] by hausmann@webkit.org

Doc: there is no group of explicitly shared classes, only one class uses this.

Patch by Volker Hilsheimer <volker.hilsheimer@nokia.com> on 2009-08-08
Reviewed by Simon Hausmann.

Explain the implications in the QWebHistoryItem documentation, and get rid
of the "group".

  • Api/qwebhistory.cpp:
00:39 Changeset [46952] by jmalonzo@webkit.org

2009-08-08 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[Gtk] Enable accessibility in Gtk DRT
https://bugs.webkit.org/show_bug.cgi?id=25989

Add SPI to get the focused accessible element to be used by DRT.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_focused_element):
  • accessibility/gtk/AccessibilityObjectWrapperAtk.h:
  • webkit/webkitprivate.h:
  • webkit/webkitwebframe.cpp: (webkit_web_frame_get_focused_accessible_element):

Remove passing accessibility tests from the Skipped list

  • platform/gtk/Skipped:

Add Accessibility support to the GTK DRT.

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Added. (AccessibilityController::AccessibilityController): (AccessibilityController::~AccessibilityController): (AccessibilityController::focusedElement): (AccessibilityController::rootElement):
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Added. (AccessibilityUIElement::AccessibilityUIElement): (AccessibilityUIElement::~AccessibilityUIElement): (AccessibilityUIElement::getLinkedUIElements): (AccessibilityUIElement::getDocumentLinks): (AccessibilityUIElement::getChildren): (AccessibilityUIElement::getChildrenWithRange): (AccessibilityUIElement::childrenCount): (AccessibilityUIElement::elementAtPoint): (AccessibilityUIElement::getChildAtIndex): (AccessibilityUIElement::allAttributes): (AccessibilityUIElement::attributesOfLinkedUIElements): (AccessibilityUIElement::attributesOfDocumentLinks): (AccessibilityUIElement::titleUIElement): (AccessibilityUIElement::parentElement): (AccessibilityUIElement::attributesOfChildren): (AccessibilityUIElement::parameterizedAttributeNames): (AccessibilityUIElement::role): (AccessibilityUIElement::title): (AccessibilityUIElement::description): (AccessibilityUIElement::language): (AccessibilityUIElement::x): (AccessibilityUIElement::y): (AccessibilityUIElement::width): (AccessibilityUIElement::height): (AccessibilityUIElement::clickPointX): (AccessibilityUIElement::clickPointY): (AccessibilityUIElement::intValue): (AccessibilityUIElement::minValue): (AccessibilityUIElement::maxValue): (AccessibilityUIElement::valueDescription): (AccessibilityUIElement::isEnabled): (AccessibilityUIElement::insertionPointLineNumber): (AccessibilityUIElement::isActionSupported): (AccessibilityUIElement::isRequired): (AccessibilityUIElement::attributesOfColumnHeaders): (AccessibilityUIElement::attributesOfRowHeaders): (AccessibilityUIElement::attributesOfColumns): (AccessibilityUIElement::attributesOfRows): (AccessibilityUIElement::attributesOfVisibleCells): (AccessibilityUIElement::attributesOfHeader): (AccessibilityUIElement::indexInTable): (AccessibilityUIElement::rowIndexRange): (AccessibilityUIElement::columnIndexRange): (AccessibilityUIElement::lineForIndex): (AccessibilityUIElement::boundsForRange): (AccessibilityUIElement::cellForColumnAndRow): (AccessibilityUIElement::selectedTextRange): (AccessibilityUIElement::setSelectedTextRange): (AccessibilityUIElement::attributeValue): (AccessibilityUIElement::isAttributeSettable): (AccessibilityUIElement::increment): (AccessibilityUIElement::decrement):
  • DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewWindowObjectCleared): (main):
  • GNUmakefile.am:

08/07/09:

23:08 Changeset [46951] by jmalonzo@webkit.org

Gtk build fix - add html/canvas to the binding generator's include path

22:17 Changeset [46950] by oliver@apple.com

Test function declaration parsing

Reviewed by Cameron Zwarich

21:42 Changeset [46949] by simon.fraser@apple.com

2009-08-07 Simon Fraser <simon.fraser@apple.com>

Fix the build on 10.6.

  • WebView/WebHTMLView.mm: (-[WebHTMLView attachRootLayer:]):
21:14 Changeset [46948] by simon.fraser@apple.com

2009-08-07 Simon Fraser <simon.fraser@apple.com>

Fix a stylistic nit related to the location of the *, which, for some
ridiculous reason, WebKit style dictates to be different between Objective-C and C++.

  • WebView/WebDynamicScrollBarsView.mm: (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
21:08 Changeset [46947] by simon.fraser@apple.com

2009-08-07 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

Work around an issue on Leopard where composited layers are misplaced and squished when the page
gets over 4096px tall.
https://bugs.webkit.org/show_bug.cgi?id=27272
<rdar://problem/7067892> [Leopard] Composisted layers are misplaced and squished on on long pages
<rdar://problem/7068252> [Leopard] When switching to a tab with HW layers, they fade in

  • WebView/WebDynamicScrollBarsView.mm: (-[WebDynamicScrollBarsView reflectScrolledClipView:]): Call -_updateLayerHostingViewPosition after scrolling.
  • WebView/WebHTMLView.mm: (-[WebHTMLView _frameOrBoundsChanged]): Call -_updateLayerHostingViewPosition after the view changes size.

(-[WebHTMLView attachRootLayer:]):
Turn off default animations, to avoid animations of sublayer transform, and fading-in
when tab switching.

  • WebView/WebHTMLViewInternal.h: (-[WebHTMLView _updateLayerHostingViewPosition]): New method that constrains the height of the layer-hosting view to a max height of 4096px, and compensates for the height restriction by placing the layer-hosting view at the top of the visible part of the WebHTMLView, and adjusting the position of the hosted layers via sublayer transform.
20:31 Changeset [46946] by jmalonzo@webkit.org

2009-08-07 Jan Michael Alonzo <jmalonzo@webkit.org>

[Gtk] Skip two new tests (from r46896) needing gtk-specific results.

  • platform/gtk/Skipped:
20:06 Changeset [46945] by oliver@apple.com

2009-08-07 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Oliver Hunt.

Fix webkit-jobs link

  • contact.html:
19:33 Changeset [46944] by jmalonzo@webkit.org

Unreviewed Gtk build fix

19:22 Changeset [46943] by oliver@apple.com

Another windows build fix attempt

19:11 Changeset [46942] by oliver@apple.com

Windows build fix

18:57 Changeset [46941] by jmalonzo@webkit.org

2009-08-07 Jan Michael Alonzo <jmalonzo@webkit.org>

Gtk build fix - add html/canvas to the include path.

  • GNUmakefile.am:
18:43 Changeset [46940] by treat@webkit.org

Prospective build fix for Qt following r46937.

Patch by Adam Treat <adam.treat@torchmobile.com> on 2009-08-07

  • WebCore.pro:
18:25 Changeset [46939] by abarth@webkit.org

2009-08-07 Yong Li <yong.li@torchmobile.com>

WINCE PORT: store only width for GlyphBufferAdvance, to save space on low-memory devices
https://bugs.webkit.org/show_bug.cgi?id=27734

  • platform/graphics/GlyphBuffer.h: (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::advanceData): (WebCore::GlyphBuffer::add):
18:24 Changeset [46938] by abarth@webkit.org

2009-08-07 Yong Li <yong.li@torchmobile.com>

Reviewed by Eric Seidel.

WINCE PORT: pass unrecognized glyphs to GDI to handle
https://bugs.webkit.org/show_bug.cgi?id=27734

  • platform/graphics/FontFastPath.cpp: (WebCore::Font::glyphDataForCharacter):
18:01 Changeset [46937] by cmarrin@apple.com

Move Canvas related file to a subdirectories
https://bugs.webkit.org/show_bug.cgi?id=28026

17:54 Changeset [46936] by abarth@webkit.org

2009-08-07 Szabo Carol <carol.szabo@nokia.com>

Reviewed by David Hyatt.

QtWebkit ignores letter-spacing and word-spacing styles.
QtWebkit handles custom letter-spacing and word-spacing in the native QFont
class, but the values for these options are not not passed on from
the platform independent part of the Font class.
Fixed QtWebkit behavior by applying the options to QFont when it is
returned via Font::font()

http://bugs.webkit.org/show_bug.cgi?id=27988

LayoutTests:
fast/css/word-space-extra.html
css2.1/t1604-c542-letter-sp-00-b-a.html
css2.1/t1604-c541-word-sp-01-b-a.html
css1/text_properties/word_spacing.html

  • platform/graphics/qt/FontQt.cpp: (WebCore::Font::font):
17:52 Changeset [46935] by abarth@webkit.org

2009-08-07 Nicolas Weber <thakis@chromium.org>

Reviewed by Darin Adler.

Use correct highlight color for listboxes and completion popups.

https://bugs.webkit.org/show_bug.cgi?id=28090

  • rendering/RenderThemeChromiumMac.h:
  • rendering/RenderThemeChromiumMac.mm: Rename activeListBoxSelectionBackgroundColor to platformActiveListBoxSelectionBackgroundColor, so that it actually overrides a virtual method.
17:48 Changeset [46934] by abarth@webkit.org

2009-08-07 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Eric Seidel.

Added a fourth bunch of Haiku-specific files for WebCore.
https://bugs.webkit.org/show_bug.cgi?id=26988

  • platform/haiku/PasteboardHaiku.cpp: Added. (WebCore::Pasteboard::Pasteboard): (WebCore::Pasteboard::generalPasteboard): (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::canSmartReplace): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment): (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::writeImage): (WebCore::Pasteboard::clear):
  • platform/haiku/PlatformKeyboardEventHaiku.cpp: Added. (WebCore::keyIdentifierForHaikuKeyCode): (WebCore::windowsKeyCodeForKeyEvent): (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent): (WebCore::PlatformKeyboardEvent::currentCapsLockState):
  • platform/haiku/PlatformMouseEventHaiku.cpp: Added. (WebCore::PlatformMouseEvent::PlatformMouseEvent):
  • platform/haiku/PlatformWheelEventHaiku.cpp: Added. (WebCore::PlatformWheelEvent::PlatformWheelEvent):
17:41 Changeset [46933] by abarth@webkit.org

2009-08-07 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Eric Seidel.

Allow custom memory allocation control for Noncopyable class
https://bugs.webkit.org/show_bug.cgi?id=27879

Several classes which are inherited from Noncopyable are instantiated by
operator new, so Noncopyable class has been inherited from FastAllocBase.

  • wtf/Noncopyable.h:

2009-08-07 George Staikos <george.staikos@torchmobile.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=27305
Implement WinCE-specific unicode layer.
Written by George Staikos <george.staikos@torchmobile.com>
with bug fixes by Yong Li <yong.li@torchmobile.com>
refactored by Joe Mason <joe.mason@torchmobile.com>

  • wtf/Platform.h:
  • wtf/unicode/Unicode.h:
  • wtf/unicode/wince/UnicodeWince.cpp: Added. (WTF::Unicode::toLower): (WTF::Unicode::toUpper): (WTF::Unicode::foldCase): (WTF::Unicode::isPrintableChar): (WTF::Unicode::isSpace): (WTF::Unicode::isLetter): (WTF::Unicode::isUpper): (WTF::Unicode::isLower): (WTF::Unicode::isDigit): (WTF::Unicode::isPunct): (WTF::Unicode::toTitleCase): (WTF::Unicode::direction): (WTF::Unicode::category): (WTF::Unicode::decompositionType): (WTF::Unicode::combiningClass): (WTF::Unicode::mirroredChar): (WTF::Unicode::digitValue):
  • wtf/unicode/wince/UnicodeWince.h: Added. (WTF::Unicode::): (WTF::Unicode::isSeparatorSpace): (WTF::Unicode::isHighSurrogate): (WTF::Unicode::isLowSurrogate): (WTF::Unicode::isArabicChar): (WTF::Unicode::hasLineBreakingPropertyComplexContext): (WTF::Unicode::umemcasecmp): (WTF::Unicode::surrogateToUcs4):
17:06 Changeset [46932] by darin@apple.com
  • platform/gtk/Skipped: Skip a newly-failing test. I filed a bug about it too.
17:03 Changeset [46931] by abarth@webkit.org

2009-08-07 Nicolas Weber <thakis@chromium.org>

Teach WebKit how to decode jpegs in cmyk and ycck color spaces.
Heavily inspired by Firefox's take on this issue.

https://bugs.webkit.org/show_bug.cgi?id=27909

Reviewed by Eric Seidel.

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::decode): Tell jpeglib to convert ycck to cmyk and keep cmyk. (WebCore::convertCMYKToRGBA): Added function to convert cmyk to rgb. (WebCore::convertRGBToRGBA): Extracted existing conversion logic into its own function. (WebCore::JPEGImageDecoder::outputScanlines): Call convertCMYKToRGBA for cmyk images, convertRGBToRGBA for rgb images.
17:03 Changeset [46930] by darin@apple.com
  • platform/gtk/Skipped: Updated since textarea-arrow-navigation.html moved.
17:02 Changeset [46929] by bweinstein@apple.com

2009-08-07 Brian Weinstein <bweinstein@apple.com>

Rubber-stamped by Mark Rowe.

Add http/tests/misc/favicon-loads-with-images-disabled.html to get the
Windows Debug bot back green.

  • platform/win/Skipped:
16:51 Changeset [46928] by abarth@webkit.org

2009-07-30 Martin Robinson <mrobinson@appcelerator.com>

Reviewed by Xan Lopez, Gustavo Noronha and Jan Alonzo.

[GTK] new-window-policy-decision-requested provides no information about the target frame
https://bugs.webkit.org/show_bug.cgi?id=27792

Add frameName property to the WebKitWebNavigation object.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::getNavigationAction): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
  • webkit/webkitwebnavigationaction.cpp: (webkit_web_navigation_action_get_property): (webkit_web_navigation_action_set_property): (webkit_web_navigation_action_class_init): (webkit_web_navigation_action_get_target_frame): (webkit_web_navigation_action_set_target_frame):
  • webkit/webkitwebnavigationaction.h:
16:34 Changeset [46927] by darin@apple.com
  • Scripts/commit-log-editor: Fix unchecked access to environment

variable that may not be there.

16:25 Changeset [46926] by darin@apple.com

"Shadow tree" DOM nodes are being accidentally exposed to JavaScript
https://bugs.webkit.org/show_bug.cgi?id=28086

Patch by Darin Adler <darin@apple.com> on 2009-08-07
Reviewed by Adele Peterson.

Rewrite tests that depend on selection inside <input> and <textarea> elements
from showing up with getSelection(), since does not match Firefox and needs to
change soon.

  • editing/deleting/delete-ligature-002-expected.txt: Updated.
  • editing/deleting/delete-ligature-002.html: Changed to use a contenteditable

<div> element instead of a <textarea> element.

  • editing/deleting/delete-ligature-003-expected.txt: Updated.
  • editing/deleting/delete-ligature-003.html: Changed to use a contenteditable

<div> element instead of a <textarea> element.

  • editing/deleting/skip-virama-001-expected.txt: Updated.
  • editing/deleting/skip-virama-001.html: Changed to use a contenteditable

<div> element instead of a <textarea> element.

  • editing/input/textarea-arrow-navigation-expected.txt: Moved to fast/forms.
  • editing/input/textarea-arrow-navigation.html: Ditto.
  • editing/inserting/insert-thai-characters-001-expected.txt: Updated.
  • editing/inserting/insert-thai-characters-001.html: Changed to use a contenteditable

<div> element instead of a <textarea> element.

  • editing/selection/5213963-expected.txt: Added. This is now a text-only test.
  • editing/selection/5213963.html: Added a call to dumpAsText(). Changed selection

testing to use selectionEnd instead of getSelection().type.

  • editing/selection/find-in-text-control-expected.txt: Updated.
  • editing/selection/find-in-text-control.html: Changed test to distinguish the

different text controls. Made it use activeElement to find out if the selection
is inside a control.

  • editing/selection/move-begin-end-expected.txt: Updated.
  • editing/selection/move-begin-end.html: Changed to use a contenteditable

<div> element instead of a <textarea> element.

  • editing/text-iterator/thai-cursor-movement-expected.txt: Updated.
  • editing/text-iterator/thai-cursor-movement.html: Changed to use a contenteditable

<div> element instead of a <textarea> element.

  • fast/forms/textarea-arrow-navigation-expected.txt: Moved from editing/input since

this is a <textarea> test, not a general editing test.

  • fast/forms/textarea-arrow-navigation.html: Ditto.

Changed to use eventSender instead of the editing machinery to test the down arrow.

  • platform/mac/editing/selection/5213963-expected.checksum: Removed.

This is now a text-only test.

  • platform/mac/editing/selection/5213963-expected.png: Ditto.
  • platform/mac/editing/selection/5213963-expected.txt: Ditto.
  • platform/qt/editing/selection/5213963-expected.txt: Ditto.
  • platform/win/editing/selection/5213963-expected.txt: Ditto.
16:24 Changeset [46925] by atwilson@chromium.org

WebCore:

2009-08-07 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

SharedWorkers should be shared
https://bugs.webkit.org/show_bug.cgi?id=28058

Added tracking of shared workers to the SharedWorkerRepository.

  • workers/DefaultSharedWorkerRepository.cpp: (WebCore::SharedWorkerProxy::create): Changed SharedWorkerProxy to derive from ThreadSafeShared, as it needs to outlive the repository (if closed while some documents are still loading). (WebCore::SharedWorkerProxy::thread): (WebCore::SharedWorkerProxy::closing): Added flag used to determine whether the worker has closed itself while loading. (WebCore::SharedWorkerProxy::url): (WebCore::SharedWorkerProxy::name): Proxy now tracks worker URL and name to allow validity checks per section 4.8.3 of the WebWorkers spec. (WebCore::SharedWorkerProxy::SharedWorkerProxy): (WebCore::SharedWorkerProxy::addToDocumentSet): Added API to track the document set for a worker to allow worker shutdown. Currently does nothing. (WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader): Renamed SharedWorkerLoader to be SharedWorkerScriptLoader for clarity. (WebCore::SharedWorkerScriptLoader::load): (WebCore::SharedWorkerScriptLoader::notifyFinished): (WebCore::DefaultSharedWorkerRepository::instance): (WebCore::DefaultSharedWorkerRepository::workerScriptLoaded): Now handles "worker already loaded" case. (WebCore::SharedWorkerRepository::connect): Delegates to DefaultSharedWorkerRepository::connectToWorker (WebCore::DefaultSharedWorkerRepository::connectToWorker): Added code to track the SharedWorkerProxy in a map, and to handle the "worker already loaded" case. (WebCore::DefaultSharedWorkerRepository::getProxy): Atomic get-or-create operation on the internal tracking HashMap.
  • workers/DefaultSharedWorkerRepository.h:
  • workers/SharedWorker.cpp: (WebCore::SharedWorker::SharedWorker):
  • workers/SharedWorkerRepository.h: Removed instance() API and made constructor private to prevent instantiation. (WebCore::SharedWorkerRepository::SharedWorkerRepository):

LayoutTests:

2009-08-07 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

SharedWorkers should be shared
https://bugs.webkit.org/show_bug.cgi?id=28058

Added tracking to the SharedWorkerRepository so instances of SharedWorkers are shared across pages.

  • fast/workers/shared-worker-shared-expected.txt: Added.
  • fast/workers/shared-worker-shared.html-disabled: Added sharing test.
16:14 Changeset [46924] by abarth@webkit.org

2009-08-07 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Eric Seidel.

Added four Haiku-specific files for WebCore:
PopupMenuHaiku.cpp, ScreenHaiku.cpp,
SearchPopupMenuHaiku.cpp and SoundHaiku.cpp
https://bugs.webkit.org/show_bug.cgi?id=28080

  • platform/haiku/PopupMenuHaiku.cpp: Added. (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::updateFromElement): (WebCore::PopupMenu::itemWritingDirectionIsNatural):
  • platform/haiku/ScreenHaiku.cpp: Added. (WebCore::screenRect): (WebCore::screenAvailableRect): (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome):
  • platform/haiku/SearchPopupMenuHaiku.cpp: Added. (WebCore::SearchPopupMenu::SearchPopupMenu): (WebCore::SearchPopupMenu::saveRecentSearches): (WebCore::SearchPopupMenu::loadRecentSearches): (WebCore::SearchPopupMenu::enabled):
  • platform/haiku/SoundHaiku.cpp: Added. (WebCore::systemBeep):
16:14 Changeset [46923] by abarth@webkit.org

2009-08-07 Maxime Simon <simon.maxime@gmail.com>

Reviewed by Eric Seidel.

Added two Haiku-specific files to WebCore:
TemporaryLinkStubs.cpp and WidgetHaiku.cpp
https://bugs.webkit.org/show_bug.cgi?id=28080

  • platform/haiku/TemporaryLinkStubs.cpp: Added. (loadResourceIntoArray): (WebCore::historyContains): (WebCore::supportedKeySizes): (WebCore::signedPublicKeyAndChallengeString): (WebCore::userIdleTime): (WebCore::callOnMainThread): (WebCore::SharedBuffer::createWithContentsOfFile): (WebCore::KURL::fileSystemPath): (WebCore::getSupportedKeySizes):
  • platform/haiku/WidgetHaiku.cpp: Added. (WebCore::Widget::Widget): (WebCore::Widget::~Widget): (WebCore::Widget::frameRect): (WebCore::Widget::setFrameRect): (WebCore::Widget::setFocus): (WebCore::Widget::setCursor): (WebCore::Widget::show): (WebCore::Widget::hide): (WebCore::Widget::paint): (WebCore::Widget::setIsSelected):
16:12 Changeset [46922] by abarth@webkit.org

2009-08-07 Jian Li <jianli@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Fix the problem that isAttribute is set to false for onerror and
onmessage in worker custom code.
https://bugs.webkit.org/show_bug.cgi?id=28083

  • bindings/v8/custom/V8AbstractWorkerCustom.cpp: (WebCore::getEventListener): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
  • bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::ACCESSOR_SETTER):
  • bindings/v8/custom/V8WorkerCustom.cpp: (WebCore::getEventListener): (WebCore::ACCESSOR_SETTER):
16:11 Changeset [46921] by abarth@webkit.org

2009-08-07 Vitaly Repeshko <vitalyr@quad.spb.corp.google.com>

Reviewed by Dimitri Glazkov.

V8 bindings: speed up lookupDOMWrapper by using new V8 API function.

https://bugs.webkit.org/show_bug.cgi?id=28071

  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::lookupDOMWrapper):
16:05 Changeset [46920] by rniwa@webkit.org

WebCore: selectionHasStyle doesn't handle text-specific properties properly
https://bugs.webkit.org/show_bug.cgi?id=27858

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-08-07
Reviewed by Justin Garcia.

This patch modifies selectionHasStyle so that it returns TrueTriState when text styles
(text-decoration, font-style, font-weight, & color) are present in all text nodes,
regardless of whether the style is also present in their ancestor nodes or not.
e.g. New behavior concludes that <b><i>hello</i><i>world</i></b> has italic style.

WebKit now applies the text styles (bold, italic, etc) if the specified style was not present on
at least one text node, rather than at the beginning of selection except on Mac.
On Mac, WebKit applies the text style if the style was not present at the beginning of style.

Test: editing/execCommand/toggle-compound-styles.html

  • editing/ApplyStyleCommand.cpp:

(WebCore::getPropertiesNotInComputedStyle): bug fix, must use copy instead of makeMutable for a mutable style.

  • editing/Editor.cpp:

(WebCore::):
(WebCore::triStateOfStyleInComputedStyle): Added a boolean type to ignore text-specific styles
(WebCore::Editor::selectionHasStyle): Ignores text-specific styles for all but text nodes

  • editing/EditorCommand.cpp:

(WebCore::executeToggleStyle): Uses selectionHasStyle instead of selectionStartHasStyle

LayoutTests: selectionHasStyle doesn't handle text-specific properties properly
https://bugs.webkit.org/show_bug.cgi?id=27858

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-08-07
Reviewed by Justin Garcia.

This patch adds toggle-compound-styles to make sure WebKit can handle nested text styles
such as <b><i>hello</i>world</b> (italicized) and <b><i>hello</i>world</b> (not italicized)
on all platforms except on Mac (to match TextEdit's behavior).

  • editing/execCommand/resources/toggle-compound-styles.js: Added.

(testSingleToggle):

  • editing/execCommand/toggle-compound-styles.html: Added.
  • platform/gtk/editing/execCommand: Added.
  • platform/gtk/editing/execCommand/toggle-compound-styles-expected.txt: Added.
  • platform/mac/editing/execCommand/toggle-compound-styles-expected.txt: Added.
  • platform/qt/editing/execCommand/toggle-compound-styles-expected.txt: Added.
  • platform/win/editing/execCommand: Added.
  • platform/win/editing/execCommand/toggle-compound-styles-expected.txt: Added.
15:36 Changeset [46919] by abarth@webkit.org

2009-08-07 Jian Li <jianli@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Do not register V8 error message listener in WorkerContextExecutionProxy.
https://bugs.webkit.org/show_bug.cgi?id=28082

  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::initV8IfNeeded):
15:25 Changeset [46918] by abarth@webkit.org

2009-08-07 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

Cairo-based Windows port does not handle cookies properly
https://bugs.webkit.org/show_bug.cgi?id=27414

curl handles cookies by itself, so using WinINet functions
to get and set cookies is wrong.

Replace CookieJarWin.cpp with CookieJarCurl.cpp so that
cookies can be implemented later once curl provides an API to
get and set cookies.

  • WebCore.vcproj/WebCore.vcproj:
15:09 Changeset [46917] by dglazkov@chromium.org

2009-08-07 Michael Nordman <michaeln@google.com>

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=28074

V8 bindings for the window.applicationCache attribute.

  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/DOMObjectsInclude.h:
  • bindings/v8/DerivedSourcesAllInOne.cpp:
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getTemplate): (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8DOMApplicationCacheCustom.cpp: Added.
14:41 Changeset [46916] by darin@apple.com

2009-08-07 Darin Adler <darin@apple.com>

Reviewed by Mark Rowe.

Fix three tests so they are not dependent on the getSelection() result
reflecting selections inside <input> and <textarea> elements.

  • fast/events/right-click-focus.html: Removed unneeded check of anchorNode. The test works fine by just testing the actual result of typing.
  • fast/forms/focus-style-pending.html: Detect focus with an onfocus attribute rather than by looking at getSelection().focusNode.
  • fast/forms/search-click-in-placeholder.html: Detect focus with an onfocus attribute rather than by looking at getSelection().baseNode.
14:39 Changeset [46915] by ajwong@chromium.org

WebCore: Right click on timeline of media controls panel cause seek
https://bugs.webkit.org/show_bug.cgi?id=27920

Patch by Alpha Lam <hclam@chromium.org> on 2009-08-07
Reviewed by Eric Seidel.

Add a test simulate the behavior of seeking by right clicking
on the time bar of media controls while playing.

  • media/controls-right-click-on-timebar-expected.txt: Added.
  • media/controls-right-click-on-timebar.html: Added.

LayoutTests: Right click on timeline of media controls panel cause seek
https://bugs.webkit.org/show_bug.cgi?id=27920

Patch by Alpha Lam <hclam@chromium.org> on 2009-08-07
Reviewed by Eric Seidel.

Add a test simulate the behavior of seeking by right clicking
on the time bar of media controls while playing.

  • media/controls-right-click-on-timebar-expected.txt: Added.
  • media/controls-right-click-on-timebar.html: Added.
14:36 Changeset [46914] by rniwa@webkit.org

deprecatedCopyInheritableProperties must be replaced by two different functions
https://bugs.webkit.org/show_bug.cgi?id=28057

Patch by Ryosuke Niwa <rniwa@webkit.org> on 2009-08-07
Reviewed by Justin Garcia.

This patch deletes deprecatedInheritableProperties and modifies call callees to call either editingStyleAtPosition
or prepareEditingStyleToApplyAt. The concept of editing style is introduced in this patch,
which consists of all CSS properties need to be preserved under editing operations.

No test is added since this patch does not change any behavior.

  • css/CSSComputedStyleDeclaration.cpp: Removed deprecatedCopyInheritableProperties
  • css/CSSComputedStyleDeclaration.h: Removed deprecatedCopyInheritableProperties
  • editing/ApplyStyleCommand.cpp:

(WebCore::):
(WebCore::editingStyleAtPosition): Obtains the editing-specific computed style at the position
(WebCore::prepareEditingStyleToApplyAt): Removes redundant editing styles at the specified position
(WebCore::removeStylesAddedByNode): Removes the style derived from the specified node

  • editing/ApplyStyleCommand.h:

(WebCore::):

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::moveParagraphs): Uses editingStyleAtPosition
(WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Uses editingStyleAtPosition

  • editing/DeleteSelectionCommand.cpp:

(WebCore::removeEnclosingAnchorStyle): Uses removeStyleOfNode
(WebCore::DeleteSelectionCommand::saveTypingStyleState): Uses editingStyleAtPosition
(WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete): Uses prepareEditingStyleToApplyAt

  • editing/EditCommand.cpp:
  • editing/EditCommand.h:
  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion): Uses editingStyleAtPosition
(WebCore::InsertParagraphSeparatorCommand::applyStyleAfterInsertion): Uses prepareEditingStyleToApplyAt

  • editing/RemoveFormatCommand.cpp:

(WebCore::RemoveFormatCommand::doApply): Uses editingStyleAtPosition

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::handleStyleSpansBeforeInsertion): Uses editingStyleAtPosition
(WebCore::ReplaceSelectionCommand::handleStyleSpans): Uses editingStyleAtPosition and prepareEditingStyleToApplyAt
(WebCore::ReplaceSelectionCommand::doApply): Uses prepareEditingStyleToApplyAt

  • editing/markup.cpp:

(WebCore::removeEnclosingMailBlockquoteStyle): Uses removeStyleOfNode
(WebCore::removeDefaultStyles): Uses prepareEditingStyleToApplyAt
(WebCore::createMarkup): Uses editingStyleAtPosition

14:36 Changeset [46913] by darin@apple.com

2009-08-07 Darin Adler <darin@apple.com>

Reviewed by Mark Rowe.

Another try at making the gc-9.html test less prone to intermittent failure.

  • fast/dom/gc-9.html: Changed this to do the "before garbage collection" test right after setting the properties. This practically eliminates the possibility that we will get unlucky and get a garbage collection between when theproperty is set and tested, which seems to have happened at least once on the buildbot.
14:10 Changeset [46912] by mrowe@apple.com

Handle the case where only a single test is missing results.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
14:07 Changeset [46911] by abarth@webkit.org

2009-08-07 George Staikos <george.staikos@torchmobile.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=27305
Implement WinCE-specific unicode layer.
Written by George Staikos <george.staikos@torchmobile.com>
with bug fixes by Yong Li <yong.li@torchmobile.com>
refactored by Joe Mason <joe.mason@torchmobile.com>

  • wtf/Platform.h:
  • wtf/unicode/Unicode.h:
  • wtf/unicode/wince/UnicodeWince.cpp: Added. (WTF::Unicode::toLower): (WTF::Unicode::toUpper): (WTF::Unicode::foldCase): (WTF::Unicode::isPrintableChar): (WTF::Unicode::isSpace): (WTF::Unicode::isLetter): (WTF::Unicode::isUpper): (WTF::Unicode::isLower): (WTF::Unicode::isDigit): (WTF::Unicode::isPunct): (WTF::Unicode::toTitleCase): (WTF::Unicode::direction): (WTF::Unicode::category): (WTF::Unicode::decompositionType): (WTF::Unicode::combiningClass): (WTF::Unicode::mirroredChar): (WTF::Unicode::digitValue):
  • wtf/unicode/wince/UnicodeWince.h: Added. (WTF::Unicode::): (WTF::Unicode::isSeparatorSpace): (WTF::Unicode::isHighSurrogate): (WTF::Unicode::isLowSurrogate): (WTF::Unicode::isArabicChar): (WTF::Unicode::hasLineBreakingPropertyComplexContext): (WTF::Unicode::umemcasecmp): (WTF::Unicode::surrogateToUcs4):
13:19 CreatingLayoutTests created by mike.fenton@torchmobile.com
Initial Version
13:15 Changeset [46910] by abarth@webkit.org

2009-08-07 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=28069

Add inline to help winscw compiler resolve specialized argument in
templated functions.

  • runtime/LiteralParser.cpp: (JSC::LiteralParser::Lexer::lexString):
13:09 Changeset [46909] by kenneth@webkit.org

2009-08-07 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by Adam Treat.

Move fast/forms/menulist-style-color.html to Skipped list for mac/win.
Bug filed - https://bugs.webkit.org/show_bug.cgi?id=28079

  • platform/mac/Skipped:
  • platform/win/Skipped:
12:52 Changeset [46908] by andersca@apple.com

2009-08-07 Anders Carlsson <andersca@apple.com>

Fix Tiger build.


  • WebView/WebRenderNode.mm: (-[WebRenderNode _initWithCoreFrame:]):
12:51 Changeset [46907] by abarth@webkit.org

2009-08-07 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Eric Seidel.

Allow custom memory allocation control for RegExpObjectData struct
http://bugs.webkit.org/show_bug.cgi?id=26750

Inherits RegExpObjectData struct from FastAllocBase because
it has been instantiated by 'new' in JavaScriptCore/runtime/RegExpObject.cpp:62

  • runtime/RegExpObject.h:
12:28 Creating and Submitting Layout Tests and Patches edited by mike.fenton@torchmobile.com
(diff)
12:27 Changeset [46906] by abarth@webkit.org

2009-08-07 Steve Block <steveblock@google.com>

Reviewed by Darin Adler.

Bug 27250: Geolocation callback function IDL files are superfluous
https://bugs.webkit.org/show_bug.cgi?id=27250

The objects for the Geolocation success and error callbacks are created 'manually' in
WebCore/bindings/js/JSGeolocationCustom.cpp. Furthermore, the callback interfaces are
marked 'NoInterfaceObject' in the W3C spec, so the prototype should not
appear on the window object. Hence IDL files for these callbacks are not required.

See http://www.w3.org/TR/geolocation-API/#geolocation_interface and
http://www.w3.org/TR/WebIDL/#NoInterfaceObject.

No new tests required.

  • DerivedSources.make: Modified. Removed reference to IDL files.
  • WebCore.gypi: Modified. Removed reference to IDL files.
  • WebCore.xcodeproj/project.pbxproj: Modified. Removed reference to IDL files.
  • page/PositionCallback.idl: Removed.
  • page/PositionErrorCallback.idl: Removed.
12:17 Changeset [46905] by ben@webkit.org

2009-08-07 George Wright <george.wright@torchmobile.com>

Reviewed by Adam Treat.

Fix DumpRenderTree for the Qt port to always dump the
PNG data unless the expected and actual hashes match.

https://bugs.webkit.org/show_bug.cgi?id=28077

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::dump):
11:51 Changeset [46904] by kenneth@webkit.org

2009-08-07 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by Adam Treat.

Add Test results for mac and windows for new tests.

https://bugs.webkit.org/show_bug.cgi?id=28050

  • platform/mac/fast/forms/text-style-color-expected.txt: Added.
  • platform/win/fast/forms/text-style-color-expected.txt: Added.
11:51 Changeset [46903] by abarth@webkit.org

2009-08-07 Adam Treat <adam.treat@torchmobile.com>

Reviewed by David Levin.

Build fix for Qt when ENABLE_VIDEO = 0. This was necessitated by r46890 which
put the idl files back into play regardless of compile time defines.

  • html/TimeRanges.idl:
11:38 Changeset [46902] by pkasting@chromium.org

https://bugs.webkit.org/show_bug.cgi?id=28076
Add fast/images/icon-decoding.html to Qt skip list until it has
results.

Reviewed by Adam Treat.

  • platform/qt/Skipped:
11:36 Changeset [46901] by andersca@apple.com

2009-08-07 Anders Carlsson <andersca@apple.com>

Reviewed by Timothy Hatcher and Sam Weinig.

Change WebRenderNode to take a WebFrame instead of a WebFrameView.


  • WebView/WebRenderNode.h:
  • WebView/WebRenderNode.mm: (-[WebRenderNode _initWithName:position:rect:coreFrame:children:]): (copyRenderNode): (-[WebRenderNode _initWithCoreFrame:]): (-[WebRenderNode initWithWebFrame:]):
11:17 Changeset [46900] by treat@webkit.org

2009-08-07 Adam Treat <adam.treat@torchmobile.com>

Reviewed by David Levin.

Build fix for Qt when ENABLE_VIDEO = 0. This was necessitated by r46890 which
put the idl files back into play regardless of compile time defines.

  • html/TimeRanges.idl:
11:14 Changeset [46899] by abarth@webkit.org

2009-08-07 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Eric Seidel.

commit-log-editor does not produce a git commit log that is git friendly.
https://bugs.webkit.org/show_bug.cgi?id=27754

We make sure we end up with:

  • A first paragraph describing the bug. It is eventually prefixed by "WebKit: <line>" or "WebCore: <line>". This used to be "WebCore:\n\n<line>".
  • The Reviewed By line.
  • An eventual Patch By line if author and committer doesn't match.
  • The rest of the commit.
  • Scripts/commit-log-editor:
10:56 Changeset [46898] by abarth@webkit.org

Make run-webkit-unittests executable.

10:37 Changeset [46897] by kenneth@webkit.org

2009-08-07 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by George Staikos.

Coding style patches for RenderThemeQt.cpp based on results from cpp_style.py.

https://bugs.webkit.org/show_bug.cgi?id=28050

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::baselinePosition): (WebCore::inflateButtonRect): (WebCore::RenderThemeQt::supportsFocus): (WebCore::RenderThemeQt::applyTheme):
10:37 Changeset [46896] by kenneth@webkit.org

2009-08-07 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by Eric Seidel.

Prevent RenderThemeQt AdjustStyle based calls for TextField, MenuList and MenuListButton
from discarding style colour.

Add new tests and remove tests from platform/qt/Skipped that now pass.

https://bugs.webkit.org/show_bug.cgi?id=28050

  • fast/forms/menulist-style-color.html: Added.
  • fast/forms/text-style-color.html: Added.
  • platform/qt/Skipped:
  • platform/qt/fast/forms/menulist-style-color-expected.txt: Added.
  • platform/qt/fast/forms/text-style-color-expected.txt: Added.

2009-08-07 Mike Fenton <mike.fenton@torchmobile.com>

Reviewed by Eric Seidel.

Prevent RenderThemeQt AdjustStyle based calls for TextField, MenuList and MenuListButton
from discarding style colour.

Add tests and remove tests from platform/qt/Skipped that now pass.

https://bugs.webkit.org/show_bug.cgi?id=28050

Tests: fast/forms/menulist-style-color.html

fast/forms/text-style-color.html

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::adjustTextFieldStyle): (WebCore::RenderThemeQt::adjustMenuListStyle): (WebCore::RenderThemeQt::adjustMenuListButtonStyle):
10:22 Changeset [46895] by abarth@webkit.org

2009-08-07 Adam Barth <abarth@webkit.org>

Unreviewed. (Darin Adler indicated he'd prefer if we landed these
kinds of changes unreviewed, like editing the WebKit Team wiki page.)

Added Pierre d'Herbemont to list of committers.

  • Scripts/modules/committers.py:
09:15 QtWebKitTodo edited by andre.pedralho@openbossa.org
(diff)
08:57 Changeset [46894] by dglazkov@chromium.org

2009-08-07 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

https://bugs.webkit.org/show_bug.cgi?id=22495
[V8] Re-land http://trac.webkit.org/changeset/46821, now that
http://trac.webkit.org/changeset/46874 re-landed

  • bindings/v8/DOMObjectsInclude.h:
  • bindings/v8/DerivedSourcesAllInOne.cpp:
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
08:52 Changeset [46893] by treat@webkit.org

2009-08-07 Adam Treat <adam.treat@torchmobile.com>

Reviewed by Darin Adler and George Staikos.

Add rectToRect convenience function which returns the TransformationMatrix
which maps the 'from' rectangle to the 'to' rectangle.

https://bugs.webkit.org/show_bug.cgi?id=28067

No tests as this would require binding the method to js and since it is static
that doesn't seem possible. Please check the math.

  • platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::TransformationMatrix::rectToRect):
  • platform/graphics/transforms/TransformationMatrix.h:
08:35 Changeset [46892] by beidson@apple.com

WebCore:

2009-08-07 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler.

Implement the HTML5 hashchange event.
https://bugs.webkit.org/show_bug.cgi?id=21605

Test: fast/loader/hashchange-event.html

  • dom/EventNames.h: Add "hashchange"
  • html/HTMLAttributeNames.in: Add "onhashchange"
  • loader/FrameLoader.cpp: (WebCore::HashChangeEventTask::create): (WebCore::HashChangeEventTask::performTask): (WebCore::HashChangeEventTask::HashChangeEventTask): (WebCore::FrameLoader::scrollToAnchor): When an anchor navigation is completed and the new fragment identifier is different from the old one, queue a hash change event on the Document.

Add a window event listener for the hashchange event if onhashchange is encountered:

  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::parseMappedAttribute):
  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::parseMappedAttribute):

Add a new string utility method that gives "null and empty are equivalent" behavior:

  • platform/text/PlatformString.h: (WebCore::equalIgnoringNullity):
  • platform/text/StringImpl.cpp: (WebCore::equalIgnoringNullity):
  • platform/text/StringImpl.h:

LayoutTests:

2009-08-07 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler.

Implement the HTML5 hashchange event.
https://bugs.webkit.org/show_bug.cgi?id=21605

  • fast/loader/hashchange-event-expected.txt: Added.
  • fast/loader/hashchange-event.html: Added.
07:57 Changeset [46891] by jberlin@apple.com

2009-08-07 Jessie Berlin <jberlin@apple.com>

Add the initial implementation of the ability to resize the columns in
a DataGrid in the Web Inspector. Enables that functionality in both the
Profile View and in the Local Storage View.


Reviewed by Timothy Hatcher.


https://bugs.webkit.org/show_bug.cgi?id=26182


In this version, resizing a column can change the width of at most two
columns (the columns to the left and right of the resizer being dragged).


Possible changes in future patches:


1) Be able to specify the minimum size of a column and the maximum size

of a column. If the minimum size is equal to the maximum size, the
column can't be resized.

2) Make the behavior more in line with the following description:


Everything before the column that is resized stays fixed size. The
resized column changes sizes. The other columns except the last stay
the same size. And the last column adjusts to fit with a minimum size.
If the last column is already the minimum, the next to last column
shrinks, etc.


3) Make it possible to scale the column sizes appropriately when the

Web Inspector window gets resized.


  • inspector/front-end/DOMStorageItemsView.js: (WebInspector.DOMStorageItemsView.prototype.update): Once the DataGrid is added to the DOM, update the widths of the DataGrid in order to put the resizers in place. (WebInspector.DOMStorageItemsView.prototype.resize): Update the widths of the DataGrid in order to correctly adjust the positions of the resizers.


  • inspector/front-end/DataGrid.js: (WebInspector.DataGrid): Store column groups whose widths can later be changed when the columns are resized by the user. Also, keep track of whether the widths of the columns have been initialized. (WebInspector.DataGrid.prototype.updateWidths): Create the resizers for the columns. (WebInspector.DataGrid.prototype._clickInDataTable): Didn't actually change anything in this method, just added a comma to the end of the function. (WebInspector.DataGrid.prototype._startResizerDragging): Store the resizer that is currently dragging. (WebInspector.DataGrid.prototype._resizerDragging): Constrain the area that the resizer can be dragged to the column to it's left and right, with some padding added to make sure that the neighboring columns don't disappear. (WebInspector.DataGrid.prototype._endResizerDragging):


  • inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel.prototype.resize): Resize the view. (WebInspector.DatabasesPanel.prototype._updateSidebarWidth): ditto.


  • inspector/front-end/ProfileView.js: (WebInspector.ProfileView.prototype.show): Now that the DataGrid is actually attached to the DOM, update the widths of the DataGrid in order to put the resizers in place. (WebInspector.ProfileView.prototype.resize): Update the widths of the DataGrid in order to correctly adjust the positions of the resizers.


  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.resize): Resize the view. (WebInspector.ProfilesPanel.prototype._updateSidebarWidth): ditto.


  • inspector/front-end/inspector.css: Add in a style rule for a resizer in the Data Grid.
03:56 UsingGitWithWebKit edited by pdherbemont@free.fr
(diff)
03:22 WebKit Team edited by jmalonzo@webkit.org
Fix my entry (diff)
02:55 Changeset [46890] by hausmann@webkit.org

2009-08-07 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Tor Arne Vestbø.

Back out r46847 and fix the Qt build system to always generate
all the JS binding files from IDL files. The generated files
have #if feature guards, so the #ifs are not needed in the
files using them.

  • WebCore.pro:
  • bindings/js/JSEventTarget.cpp:
  • bindings/js/JSWorkerContextBase.cpp:
  • bindings/js/WorkerScriptController.cpp:
02:44 WebKit Team edited by zoltan@webkit.org
Add my entry. (diff)
01:21 WebKit Team edited by pdherbemont@apple.com
Add my entry. (diff)
00:32 Changeset [46889] by abarth@webkit.org

2009-08-07 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Adele Peterson.

Cannot scroll for box-reflect:right
https://bugs.webkit.org/show_bug.cgi?id=27979

Update m_overflowLeft an m_overflowWidth for reflection just like
m_overflowTop and m_overflowHeight.

  • fast/reflections/reflection-overflow-scroll-expected.txt: Added.
  • fast/reflections/reflection-overflow-scroll.html: Added.
  • fast/reflections/resources/reflection-overflow-scroll.js: Added.
  • platform/mac/fast/reflections/reflection-nesting-expected.txt:
  • platform/mac/fast/repaint/reflection-redraw-expected.txt:

2009-08-07 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Adele Peterson.

Cannot scroll for box-reflect:right
https://bugs.webkit.org/show_bug.cgi?id=27979

Update m_overflowLeft an m_overflowWidth for reflection just like
m_overflowTop and m_overflowHeight.

Test: fast/reflections/reflection-overflow-scroll.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):

2009-08-07 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Adele Peterson.

Cannot scroll for box-reflect:right
https://bugs.webkit.org/show_bug.cgi?id=27979

Update m_overflowLeft an m_overflowWidth for reflection just like
m_overflowTop and m_overflowHeight.

  • Scripts/make-js-test-wrappers: Added regexp to skip box-shadow-overflo

w-scroll.js

08/06/09:

23:53 WebKit Team edited by jmalonzo@webkit.org
add janm to the team! (diff)
23:53 Changeset [46888] by abarth@webkit.org

2009-08-06 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Adam Barth.

box-shadow's spread is ignored with <table>
https://bugs.webkit.org/show_bug.cgi?id=28017

Use RenderStyle::getBoxShadowExtent just like RenderBlock.

  • fast/box-shadow/box-shadow-overflow-scroll-expected.txt: Added.
  • fast/box-shadow/box-shadow-overflow-scroll.html: Added.
  • fast/box-shadow/resources/box-shadow-overflow-scroll.js: Added.

2009-08-06 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Adam Barth.

box-shadow's spread is ignored with <table>
https://bugs.webkit.org/show_bug.cgi?id=28017

Use RenderStyle::getBoxShadowExtent just like RenderBlock.

Test: fast/box-shadow/box-shadow-overflow-scroll.html

  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout):

2009-08-06 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Adam Barth.

box-shadow's spread is ignored with <table>
https://bugs.webkit.org/show_bug.cgi?id=28017

Use RenderStyle::getBoxShadowExtent just like RenderBlock.

  • Scripts/make-js-test-wrappers: Added regexp to skip box-shadow-overflow-scroll.js
23:44 HackingGtk edited by jmalonzo@webkit.org
Add l10n, docs and tests folder; Removed unused backends and non-existent … (diff)
23:14 Changeset [46887] by jmalonzo@webkit.org

2009-08-06 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[Gtk] Copy expected (txt only) result from Mac for
fast/images/icon-decoding.html from r46871 since we seem to pass this
test as well.

  • platform/gtk/fast/images/icon-decoding-expected.txt: Copied from LayoutTests/platform/mac/fast/images/icon-decoding-expected.txt.
22:51 Changeset [46886] by abarth@webkit.org

2009-08-06 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Inspector: NodeLists Don't Display Well in the Console
https://bugs.webkit.org/show_bug.cgi?id=28061

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._format): Specific check if the object is a NodeList, display as an "array"
22:39 Changeset [46885] by abarth@webkit.org

2009-08-06 Yusuke Sato <yusukes@chromium.org>

Reviewed by David Levin.

Chromium Linux: add support for @font-face
https://bugs.webkit.org/show_bug.cgi?id=28015

  • loader/CachedFont.cpp: (WebCore::CachedFont::~CachedFont): (WebCore::CachedFont::ensureCustomFontData): (WebCore::CachedFont::platformDataFromCustomData): (WebCore::CachedFont::allClientsRemoved):

Modified #ifdefs so that chromium linux can load remote fonts.

  • platform/graphics/chromium/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::FontCustomPlatformData::fontPlatformData): (WebCore::createFontCustomPlatformData):

Create SkTypeface for a web font by calling SkTypeface::CreateFromStream function.

(WebCore::RemoteFontStream::RemoteFontStream):
(WebCore::RemoteFontStream::~RemoteFontStream):
(WebCore::RemoteFontStream::rewind):
(WebCore::RemoteFontStream::read):

New class that implements SkStream interface and wraps wtf's SharedBuffer.

  • platform/graphics/chromium/FontCustomPlatformData.h: (WebCore::FontCustomPlatformData::FontCustomPlatformData):

Added member variables for Linux.

22:09 Changeset [46884] by abarth@webkit.org

2009-08-06 Yong Li <yong.li@torchmobile.com>

Reviewed by Eric Seidel.

Fix JPEGImageDecoder.cpp compile error on WinCE
https://bugs.webkit.org/show_bug.cgi?id=28051

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
21:45 Changeset [46883] by kevino@webkit.org

Reviewed by Eric Seidel.

Adding support for building wx Python bindings using the waf build system.

https://bugs.webkit.org/show_bug.cgi?id=27619

21:24 Changeset [46882] by kevino@webkit.org

Reviewed by Eric Seidel.

Adding WebCore support for the waf build system for wx.

https://bugs.webkit.org/show_bug.cgi?id=27619

21:11 Changeset [46881] by abarth@webkit.org

2009-08-06 Norbert Leser <norbert.leser@nokia.com>

Reviewed by Darin Adler.

Updated patch for bug #27059:
Symbian platform always uses little endian encoding,
regardless of compiler.
We need to make sure that we correctly detect EABI architecture
for armv5 targets on Symbian,
where EABI is set but not ARM_EABI

  • wtf/Platform.h:
20:30 Changeset [46880] by abarth@webkit.org

JavaScriptCore:

2009-08-06 Adam Barth <abarth@webkit.org>

Unreviewed revert.

http://bugs.webkit.org/show_bug.cgi?id=27879

Revert 46877 because it broke GTK.

  • wtf/Noncopyable.h:

WebCore:

2009-08-06 Adam Barth <abarth@webkit.org>

Unreviewed revert.

http://bugs.webkit.org/show_bug.cgi?id=27879

Revert 46877 because it broke GTK.

  • platform/graphics/wince/GraphicsContextWince.cpp:

WebKit/win:

2009-08-06 Adam Barth <abarth@webkit.org>

Unreviewed revert.

http://bugs.webkit.org/show_bug.cgi?id=27879

Revert 46877 because it broke GTK.

  • COMPropertyBag.h:
20:05 Changeset [46879] by barraclough@apple.com

2009-08-06 Gavin Barraclough <barraclough@apple.com>

Reviewed by Oliver Hunt.

Make get_by_id/put_by_id/method_check/call defer optimization using a data flag rather than a code modification.
( https://bugs.webkit.org/show_bug.cgi?id=27635 )

This improves performance of ENABLE(ASSEMBLER_WX_EXCLUSIVE) builds by 2-2.5%, reducing the overhead to about 2.5%.
(No performance impact with ASSEMBLER_WX_EXCLUSIVE disabled).

  • bytecode/CodeBlock.cpp: (JSC::printStructureStubInfo):
    • Make StructureStubInfo store the type as an integer, rather than an OpcodeID.
  • bytecode/CodeBlock.h: (JSC::): (JSC::CallLinkInfo::seenOnce): (JSC::CallLinkInfo::setSeen): (JSC::MethodCallLinkInfo::seenOnce): (JSC::MethodCallLinkInfo::setSeen):
    • Change a pointer in CallLinkInfo/MethodCallLinkInfo to use a PtrAndFlags, use a flag to track when an op has been executed once.
  • bytecode/StructureStubInfo.cpp: (JSC::StructureStubInfo::deref):
    • Make StructureStubInfo store the type as an integer, rather than an OpcodeID.
  • bytecode/StructureStubInfo.h: (JSC::StructureStubInfo::StructureStubInfo): (JSC::StructureStubInfo::initGetByIdSelf): (JSC::StructureStubInfo::initGetByIdProto): (JSC::StructureStubInfo::initGetByIdChain): (JSC::StructureStubInfo::initGetByIdSelfList): (JSC::StructureStubInfo::initGetByIdProtoList): (JSC::StructureStubInfo::initPutByIdTransition): (JSC::StructureStubInfo::initPutByIdReplace): (JSC::StructureStubInfo::seenOnce): (JSC::StructureStubInfo::setSeen):
    • Make StructureStubInfo store the type as an integer, rather than an OpcodeID, add a flag to track when an op has been executed once.
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitGetById): (JSC::BytecodeGenerator::emitPutById):
    • Make StructureStubInfo store the type as an integer, rather than an OpcodeID.
  • jit/JIT.cpp: (JSC::JIT::privateCompileCTIMachineTrampolines): (JSC::JIT::unlinkCall):
    • Remove the "don't lazy link" stage of calls.
  • jit/JIT.h: (JSC::JIT::compileCTIMachineTrampolines):
    • Remove the "don't lazy link" stage of calls.
  • jit/JITCall.cpp: (JSC::JIT::compileOpCallSlowCase):
    • Remove the "don't lazy link" stage of calls.
  • jit/JITStubs.cpp: (JSC::JITThunks::JITThunks): (JSC::JITThunks::tryCachePutByID): (JSC::JITThunks::tryCacheGetByID): (JSC::JITStubs::DEFINE_STUB_FUNCTION): (JSC::JITStubs::getPolymorphicAccessStructureListSlot):
    • Remove the "don't lazy link" stage of calls, and the "_second" stage of get_by_id/put_by_id/method_check.
  • jit/JITStubs.h: (JSC::JITThunks::ctiStringLengthTrampoline): (JSC::JITStubs::):
    • Remove the "don't lazy link" stage of calls, and the "_second" stage of get_by_id/put_by_id/method_check.
  • wtf/PtrAndFlags.h: (WTF::PtrAndFlags::PtrAndFlags): (WTF::PtrAndFlags::operator!): (WTF::PtrAndFlags::operator->):
    • Add ! and -> operators, add constuctor with pointer argument.
18:56 Changeset [46878] by cfleizach@apple.com

2009-08-06 Chris Fleizach <cfleizach@apple.com>

Reviewed by Eric Seidel.

Bug 27956 - AX: roleValue should be cached for performance
https://bugs.webkit.org/show_bug.cgi?id=27956

Caches the role value of an accessibility object instead of calculating it everytime.
The changes gained a 5% speedup using VoiceOver to navigate a webpage.

  • accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::handleAriaRoleChanged):

Use generic role setter instead of specific ARIA role setter.

  • accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::AccessibilityObject):
  • accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::headingLevel):

Make headingLevel into instance method so that it can *safely* be called in the constructor.

(WebCore::AccessibilityObject::setRoleValue):
(WebCore::AccessibilityObject::roleValue):

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::AccessibilityRenderObject): (WebCore::AccessibilityRenderObject::headingLevel): (WebCore::AccessibilityRenderObject::intValue): (WebCore::AccessibilityRenderObject::updateAccessibilityRole): (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
  • accessibility/AccessibilityRenderObject.h:
  • accessibility/mac/AccessibilityObjectWrapper.mm: (AXAttributeStringSetHeadingLevel):
18:09 Changeset [46877] by abarth@webkit.org

2009-08-06 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Adam Barth.

Allow custom memory allocation control for Noncopyable class
https://bugs.webkit.org/show_bug.cgi?id=27879

Several classes which inherited from Noncopyable are instantiated by
operator new, so Noncopyable class has been inherited from FastAllocBase.

  • wtf/Noncopyable.h:

2009-08-06 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Adam Barth.

Change Noncopyable inheriting to public
http://bugs.webkit.org/show_bug.cgi?id=27879

Since Noncopyable is inherited from FastAllocBase, Noncopyable's
inheriting has been changed to public.

  • platform/graphics/wince/GraphicsContextWince.cpp:

2009-08-06 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Adam Barth.

Change Noncopyable inheriting to public
http://bugs.webkit.org/show_bug.cgi?id=27879

Since Noncopyable is inherited from FastAllocBase,
Noncopyable's inheriting has been changed to public.

  • COMPropertyBag.h:
17:59 Changeset [46876] by mrowe@apple.com

Add explicit dependencies for our build verification scripts to ensure that they always run after linking has completed.

Rubber-stamped by Sam Weinig.

17:59 Changeset [46875] by simon.fraser@apple.com

2009-08-06 Simon Fraser <simon.fraser@apple.com>

Make the test a little more sloppy to try to fix sporadic failures on Windows.

  • animations/play-state.html:
17:32 Changeset [46874] by simon.fraser@apple.com

2009-08-05 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

Implement the matchMedium method on the Media interface described in the CSSOM View Module.
https://bugs.webkit.org/show_bug.cgi?id=22495

Add a new Media interface, obtainable via the AbstractView, that can
evaluate queries via its matchesMedium() method.

Test: fast/media/matchmedium-query-api.html

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl: Add Media.* files to the build.
  • css/Media.cpp: Added. (WebCore::Media::Media): (WebCore::Media::type): (WebCore::Media::matchMedium):
  • css/Media.h: Added. (WebCore::Media::create): (WebCore::Media::document):
  • css/Media.idl: Added. Media::matchMedium() uses a MediaQueryEvaluator() to test the query.
  • page/AbstractView.idl:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::media):
  • page/DOMWindow.h:
  • page/DOMWindow.idl: Add a readonly attribute for Media.
17:28 Changeset [46873] by darin@apple.com

2009-08-06 Darin Adler <darin@apple.com>

Reviewed by Mark Rowe.

  • fast/dom/gc-9-expected.txt: Generated new results.
  • fast/dom/gc-9.html: Turned off tests that are unpredictable based on what happens during garbage collection. These do represent bugs, so we want to turn them back on again once the bugs are fixed.
17:27 Changeset [46872] by pkasting@chromium.org

2009-08-06 Peter Kasting <pkasting@google.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=27323
Strip line endings at all points auto-version.sh reads data, not just
the one I happened to run into.

  • win/tools/scripts/auto-version.sh:
17:25 Changeset [46871] by pkasting@chromium.org

2009-08-06 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=28025
Add a test for .ico decoding.

  • fast/images/icon-decoding.html: Added.
  • fast/images/resources/1bit.ico: Added.
  • fast/images/resources/2entries.ico: Added.
  • fast/images/resources/32bit.ico: Added.
  • fast/images/resources/8bit.ico: Added.
  • platform/mac/fast/images/icon-decoding-expected.checksum: Added.
  • platform/mac/fast/images/icon-decoding-expected.png: Added.
  • platform/mac/fast/images/icon-decoding-expected.txt: Added.
16:46 Changeset [46870] by andersca@apple.com

2009-08-06 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler and Dan Bernstein.

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::hasHTMLView): Always return true when we're in viewless mode.
16:45 Changeset [46869] by abarth@webkit.org

2009-08-06 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=27455
Test suite for form controls' custom validation message.

  • fast/dom/domListEnumeration-expected.txt: Corrected
  • fast/dom/resources/domListEnumeration.js: Corrected
  • fast/forms/ValidityState-customError-001-expected.txt: Added.
  • fast/forms/ValidityState-customError-001.html: Added.
  • fast/forms/ValidityState-customError-002-expected.txt: Added.
  • fast/forms/ValidityState-customError-002.html: Added.
  • fast/forms/ValidityState-customError-003-expected.txt: Added.
  • fast/forms/ValidityState-customError-003.html: Added.
  • fast/forms/ValidityState-customError-004-expected.txt: Added.
  • fast/forms/ValidityState-customError-004.html: Added.

2009-08-06 Michelangelo De Simone <micdesim@gmail.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=27455
Support for a custom validation message in ValidityState and related
form controls.
http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#dom-cva-setcustomvalidity

Tests: fast/forms/ValidityState-customError-001.html

fast/forms/ValidityState-customError-002.html
fast/forms/ValidityState-customError-003.html
fast/forms/ValidityState-customError-004.html

  • html/HTMLButtonElement.idl: setCustomValidity DOM method
  • html/HTMLFieldSetElement.idl: ditto
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::setCustomValidity): ditto
  • html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElement::valueMissing): moved down
  • html/HTMLInputElement.idl: ditto
  • html/HTMLSelectElement.idl: ditto
  • html/HTMLTextAreaElement.idl:
  • html/ValidityState.h: (WebCore::ValidityState::setCustomErrorMessage): method to set custom validation message (WebCore::ValidityState::customError): validation flag
16:00 Changeset [46868] by mrowe@apple.com

Bring a little order to our otherwise out of control lives.

15:56 Changeset [46867] by mrowe@apple.com

Stop copying .idl files in to the framework resources directory.

  • WebCore.xcodeproj/project.pbxproj:
15:51 Changeset [46866] by andersca@apple.com

2009-08-06 Anders Carlsson <andersca@apple.com>

Remove WebGraphicsExtras.h include.


  • Plugins/WebNetscapePluginView.mm:
15:51 Changeset [46865] by mrowe@apple.com

Fix the build some more.

Add JSWebSocket.cpp and JSWebSocket.h to the Xcode project, and move the WebSocket-related
files and groups in to the appropriate locations.

  • WebCore.xcodeproj/project.pbxproj:
15:38 Changeset [46864] by mrowe@apple.com

Build fix.

Don't attempt to build a file that Anders just deleted.

  • WebKit.xcodeproj/project.pbxproj:
15:30 Changeset [46863] by jorlow@chromium.org

2009-08-06 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

Add WebSocket.idl
https://bugs.webkit.org/show_bug.cgi?id=27209

Add WebSocket.idl in WebCore/websockets/.
Add build systems only for GNUmakefile.am and WebCore.xcodeproj now.
Other build systems will be updated once the code is functional.

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSWebSocketConstructor.cpp: Added.
  • bindings/js/JSWebSocketConstructor.h: Added.
  • bindings/js/JSWebSocketCustom.cpp: Added.
  • websockets/WebSocket.cpp: Added.
  • websockets/WebSocket.h: Added.
  • websockets/WebSocket.idl: Added.
15:08 Changeset [46862] by andersca@apple.com

2009-08-06 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Remove WebGraphicsExtras, it is no longer used.

  • Misc/WebGraphicsExtras.c: Removed.
  • Misc/WebGraphicsExtras.h: Removed.
14:57 Changeset [46861] by simon.fraser@apple.com

2009-08-06 Simon Fraser <simon.fraser@apple.com>

Fix a test in http/tests/media that was missed in the earlier 'media' rename.

  • http/tests/media/video-play-stall.html:
14:41 Changeset [46860] by rniwa@webkit.org

2009-08-06 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

LayoutTests/editing/execCommand/boldSelection.html must be a dumpAsText test
https://bugs.webkit.org/show_bug.cgi?id=28055

This patch converts boldSelection.html to a dumpAsText and adds description on what it tests.
Namely, it tests bolding the first 21 letters of a sentence.
Since bolding must be done by adding b tag instead of a style span, we print innerHTML of the result.

  • editing/execCommand/boldSelection-expected.txt: Added.
  • editing/execCommand/boldSelection.html:
  • platform/mac/editing/execCommand/boldSelection-expected.checksum: Removed.
  • platform/mac/editing/execCommand/boldSelection-expected.png: Removed.
  • platform/mac/editing/execCommand/boldSelection-expected.txt: Removed.
  • platform/qt/editing/execCommand/boldSelection-expected.txt: Removed.
14:38 BuildingQtOnWindows edited by robert@roberthogan.net
(diff)
14:29 Changeset [46859] by jianli@chromium.org

2009-08-06 Jian Li <jianli@chromium.org>

Reviewed by Dimitri Glazkov.

[V8] Style cleaning for WorkerContextExecutionProxy.
https://bugs.webkit.org/show_bug.cgi?id=27997

Cleanup WorkerContextExecutioonProxy related files to follow
WebKit coding styles after all V8 binding codes are upstreamed.
1) Lower-case the first letter of remaining functins in class

WorkerContextExecutionProxy. Update the V8 code generator
and all other references accordingly.

2) Integrate getConstructor from WorkerContextExecutionProxy

to V8DOMWrapper.

3) Other misc changes, like removing trailing whitespaces and

sorting the include files.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
  • bindings/v8/V8DOMWrapper.cpp: (WebCore::V8DOMWrapper::getConstructorForContext): (WebCore::V8DOMWrapper::convertToV8Object):
  • bindings/v8/V8DOMWrapper.h:
  • bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::~V8WorkerContextEventListener): (WebCore::V8WorkerContextEventListener::handleEvent): (WebCore::V8WorkerContextEventListener::reportError): (WebCore::V8WorkerContextEventListener::getReceiverObject):
  • bindings/v8/V8WorkerContextObjectEventListener.cpp: (WebCore::weakObjectEventListenerCallback):
  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::handleConsoleMessage): (WebCore::WorkerContextExecutionProxy::dispose): (WebCore::WorkerContextExecutionProxy::initContextIfNeeded): (WebCore::WorkerContextExecutionProxy::convertToV8Object): (WebCore::WorkerContextExecutionProxy::convertEventToV8Object): (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object): (WebCore::WorkerContextExecutionProxy::convertWorkerContextToV8Object): (WebCore::WorkerContextExecutionProxy::toV8): (WebCore::WorkerContextExecutionProxy::forgetV8EventObject): (WebCore::WorkerContextExecutionProxy::removeEventListener):
  • bindings/v8/WorkerContextExecutionProxy.h: (WebCore::WorkerContextExecutionProxy::context): (WebCore::WorkerContextExecutionProxy::convertToV8Object):
  • bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::ACCESSOR_GETTER): (WebCore::CALLBACK_FUNC_DECL):
14:21 BuildingQtOnWindows edited by robert@roberthogan.net
(diff)
14:15 Changeset [46858] by simon.fraser@apple.com

2009-08-06 Simon Fraser <simon.fraser@apple.com>

Rubber-stamped by Dan Bernstein.

Move a video test from fast/media to media/, since fast/media is all about
CSS media queries.

  • media/video-controls-with-mutation-event-handler-expected.txt: Renamed from LayoutTests/fast/media/video-controls-with-mutation-event-handler-expected.txt.
  • media/video-controls-with-mutation-event-handler.html: Renamed from LayoutTests/fast/media/video-controls-with-mutation-event-handler.html.
14:09 Changeset [46857] by simon.fraser@apple.com

2009-08-06 Simon Fraser <simon.fraser@apple.com>

Reviewed by Dan Bernstein.

https://bugs.webkit.org/show_bug.cgi?id=28056
Change media tests to not use a variable in global scope with the name
'media', to avoid conflict with window.media.

  • media/audio-constructor-autobuffer-expected.txt:
  • media/audio-constructor-autobuffer.html:
  • media/audio-constructor-src.html:
  • media/audio-constructor.html:
  • media/audio-data-url-expected.txt:
  • media/audio-data-url.html:
  • media/audio-mpeg-supported-expected.txt:
  • media/audio-mpeg-supported.html:
  • media/media-load-event-expected.txt:
  • media/media-load-event.html:
  • media/video-can-play-type.html:
  • media/video-loop-expected.txt:
  • media/video-loop.html:
  • media/video-seek-past-end-paused-expected.txt:
  • media/video-seek-past-end-paused.html:
  • media/video-seek-past-end-playing-expected.txt:
  • media/video-seek-past-end-playing.html:
  • media/video-source-media.html:
  • media/video-source-type-params.html:
  • media/video-source-type.html:
  • media/video-source.html:
  • media/video-src-invalid-remove.html:
  • media/video-src-plus-source-expected.txt:
  • media/video-src-plus-source.html:
  • media/video-src-source.html:
  • media/video-src.html:
  • media/video-test.js: (findMediaElement): (waitForEvent): (waitForEventAndTest): (relativeURL):
  • media/video-timeupdate-during-playback.html:
13:50 Changeset [46856] by abarth@webkit.org

2009-08-06 Eric Seidel <eric@webkit.org>

No review, only changing make-js-test-wrappers.

Fix make-js-test-wrappers to ignore a few more js tests
with custom templates.

  • Scripts/make-js-test-wrappers:
13:20 Changeset [46855] by eric@webkit.org

2009-08-06 Eric Seidel <eric@webkit.org>

No review, only changing make-js-test-wrappers.

Fix make-js-test-wrappers to ignore a few more js tests
with custom templates.

  • Scripts/make-js-test-wrappers:
12:17 Changeset [46854] by abarth@webkit.org

2009-08-06 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Allow custom memory allocation control for JavaScriptCore's PolymorphicAccessStructureList struct
https://bugs.webkit.org/show_bug.cgi?id=27877

Inherits PolymorphicAccessStructureList struct from FastAllocBase because it has been instantiated by
'new' in JavaScriptCore/jit/JITStubs.cpp:1229.

  • bytecode/Instruction.h:
11:49 Changeset [46853] by bfulgham@webkit.org

2009-08-06 Brent Fulgham <bfulgham@webkit.org>

Rubber-stamped by Adam Barth.

Update my blog's address.

  • config.ini: Update Blog address.
11:25 Changeset [46852] by atwilson@chromium.org

2009-08-06 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

Refactored worker tests to share code with shared worker versions. Shared worker tests are currently disabled by default.

Worker layout tests should be refactored to enable testing SharedWorkers also.
https://bugs.webkit.org/show_bug.cgi?id=27963

  • fast/workers/resources/shared-worker-common.js: (onconnect): (gc): (handleMessage):
  • fast/workers/resources/shared-worker-create-common.js: Added. (createWorker.worker.port.onmessage): (createWorker.worker.postMessage): (createWorker):
  • fast/workers/resources/worker-context-gc.js: Added. (log): (worker.onmessage):
  • fast/workers/resources/worker-create-common.js: Added. (createWorker):
  • fast/workers/resources/worker-location.js: Added. (log): (gc): (worker.onmessage):
  • fast/workers/resources/worker-navigator.js: Added. (log): (worker.onmessage):
  • fast/workers/resources/worker-replace-global-constructor.js:
  • fast/workers/resources/worker-replace-self.js: Added. (log): (worker.onmessage):
  • fast/workers/shared-worker-context-gc-expected.txt: Added.
  • fast/workers/shared-worker-context-gc.html-disabled: Added.
  • fast/workers/shared-worker-location-expected.txt: Added.
  • fast/workers/shared-worker-location.html-disabled: Added.
  • fast/workers/shared-worker-navigator-expected.txt: Added.
  • fast/workers/shared-worker-navigator.html-disabled: Added.
  • fast/workers/shared-worker-replace-global-constructor.html-disabled:
  • fast/workers/shared-worker-replace-self-expected.txt: Added.
  • fast/workers/shared-worker-replace-self.html-disabled: Added.
  • fast/workers/worker-context-gc.html:
  • fast/workers/worker-location.html:
  • fast/workers/worker-navigator.html:
  • fast/workers/worker-replace-global-constructor.html:
  • fast/workers/worker-replace-self.html:
11:02 Changeset [46851] by darin@apple.com

2009-08-06 Darin Adler <darin@apple.com>

Fix Mac Leopard debug build.

  • platform/text/StringImpl.cpp: (WebCore::equalIgnoringCase): Removed meaningless assertion; an unsigned is always >= 0 and checking causes a warning in the newer versions of gcc.
09:43 Changeset [46850] by abarth@webkit.org

WebCore:

2009-08-06 Adam Barth <abarth@webkit.org>

Unreview rollout.

Revert 46840 because it broke the reliability tests.

  • bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::ScheduledAction): (WebCore::ScheduledAction::execute):
  • bindings/v8/ScheduledAction.h: (WebCore::ScheduledAction::ScheduledAction):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetTimeoutImpl):
  • bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::SetTimeoutOrInterval):

LayoutTests:

2009-08-06 Adam Barth <abarth@webkit.org>

Unreviewed rollout.

Revert 46840 because it broke the reliability tests.

  • http/tests/security/isolatedWorld/window-setTimeout-function-expected.txt: Removed.
  • http/tests/security/isolatedWorld/window-setTimeout-function.html: Removed.
  • http/tests/security/isolatedWorld/window-setTimeout-string-expected.txt: Removed.
  • http/tests/security/isolatedWorld/window-setTimeout-string.html: Removed.
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
09:43 Changeset [46849] by abarth@webkit.org

2009-08-06 Adam Barth <abarth@webkit.org>

Unreviewed rollout.

Revert 46840 in preparation to revert 46838, which broke the reliability tests.

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::updateDocumentWrapperCache): (WebCore::V8Proxy::initContextIfNeeded): (WebCore::V8Proxy::mainWorldContext):
  • bindings/v8/V8Proxy.h: (WebCore::V8Proxy::context):
09:37 Changeset [46848] by pfeldman@chromium.org

2009-08-06 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: move style-related utilities into InjectedScript.

http://bugs.webkit.org/show_bug.cgi?id=27939

  • inspector/front-end/DOMAgent.js: (WebInspector.CSSStyleDeclaration): (WebInspector.CSSStyleDeclaration.prototype.isPropertyImplicit): (WebInspector.CSSStyleDeclaration.prototype.styleTextWithShorthands): (WebInspector.CSSStyleDeclaration.prototype.getLonghandProperties): (WebInspector.CSSStyleDeclaration.prototype.getShorthandPriority):
  • inspector/front-end/InjectedScript.js: (InjectedScript.applyStyleText): (InjectedScript.toggleStyleEnabled): (InjectedScript._serializeStyle): (InjectedScript._getUniqueStyleProperties): (InjectedScript._getLonghandProperties): (InjectedScript._getShorthandPriority):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._update): (WebInspector.StylePropertiesSection.prototype.isPropertyOverloaded): (WebInspector.StylePropertiesSection.prototype.onpopulate): (WebInspector.StylePropertyTreeElement.prototype.get priority): (WebInspector.StylePropertyTreeElement.prototype.get value): (WebInspector.StylePropertyTreeElement.prototype):
  • inspector/front-end/utilities.js:
08:58 Changeset [46847] by hausmann@webkit.org

2009-08-06 Simon Hausmann <simon.hausmann@nokia.com>

Unreviewed build fix, add #ifdef guards around
inclusions of shared worker specific files.

  • bindings/js/JSEventTarget.cpp:
  • bindings/js/JSWorkerContextBase.cpp:
  • bindings/js/WorkerScriptController.cpp:
08:57 Changeset [46846] by hausmann@webkit.org

2009-08-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Darin Adler.

cssgrammar.cpp fails to compile with RVCT compiler
https://bugs.webkit.org/show_bug.cgi?id=27952

  • css/CSSGrammar.y: Do not convert to String to get rid of the stray memory allocation
  • platform/text/StringImpl.cpp: (WebCore::equalIgnoringCase):
  • platform/text/StringImpl.h: (WebCore::equalIgnoringCase): Add charactersEqualIgnoringCase function that works with a character pointer and length
08:30 Changeset [46845] by atwilson@chromium.org

WebCore:

2009-08-01 Drew Wilson <atwilson@google.com>

Reviewed by NOBODY (OOPS!).

Created first working implementation of SharedWorkers (execution only, no sharing).
https://bugs.webkit.org/show_bug.cgi?id=27927

Added initial implementations of SharedWorkerThread and SharedWorkerContext.
No v8 bindings yet.

  • DerivedSources.cpp: Added shared worker files.
  • DerivedSources.make: Added shared worker files.
  • GNUmakefile.am: Added shared worker files.
  • WebCore.gypi: Added shared worker files.
  • WebCore.pro: Added shared worker files.
  • WebCore.vcproj/WebCore.vcproj: Added shared worker files.
  • WebCore.xcodeproj/project.pbxproj: Added shared worker files.
  • bindings/js/JSEventTarget.cpp: (WebCore::toJS): Added code to convert from EventTarget to correct JS class. (WebCore::toEventTarget): Added code to cast from JS object to appropriate EventTarget impl class.
  • bindings/js/JSSharedWorkerConstructor.cpp: (WebCore::JSSharedWorkerConstructor::JSSharedWorkerConstructor): (WebCore::constructSharedWorker): Tweaked the constructor code to pass in the lexical global object like normal workers.
  • bindings/js/JSSharedWorkerContextCustom.cpp: Added. (WebCore::JSSharedWorkerContext::mark): Custom marking of the onconnect handler.
  • bindings/js/JSWorkerContextBase.cpp: (WebCore::toJSSharedWorkerContext): (WebCore::toJSWorkerContext): Added proper conversion to the correct WorkerContext derived class.
  • bindings/js/JSWorkerContextBase.h:
  • bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::initScript): Updated WorkerScriptController to create the correct type of binding object (JSSharedWorkerContext vs JSDedicatedWorkerContext)
  • bindings/scripts/CodeGeneratorV8.pm: Added support for SharedWorkerContext.
  • bindings/v8/DOMObjectsInclude.h: Added shared worker bindings files.
  • dom/EventNames.h: Added connect event.
  • dom/EventTarget.cpp: (WebCore::EventTarget::toSharedWorkerContext): Added API for casting to new derived class (SharedWorkerContext).
  • dom/EventTarget.h:
  • workers/AbstractWorker.cpp: (WebCore::AbstractWorker::resolveURL): Moved code that resolves/validates URLs to base class so it can be shared between dedicated/shared workers.
  • workers/AbstractWorker.h:
  • workers/DedicatedWorkerContext.cpp: (WebCore::DedicatedWorkerContext::logException): Refactored exception handling code - moved onerror handling to base class.
  • workers/DedicatedWorkerContext.h: (WebCore::DedicatedWorkerContext::isDedicatedWorkerContext):
  • workers/SharedWorker.cpp: (WebCore::SharedWorker::SharedWorker): Changed constructor to fire up worker thread.
  • workers/SharedWorker.h:
  • workers/SharedWorkerContext.cpp: Added. (WebCore::SharedWorkerContext::SharedWorkerContext): (WebCore::SharedWorkerContext::~SharedWorkerContext): (WebCore::SharedWorkerContext::logException): (WebCore::SharedWorkerContext::addMessage): Placeholder methods until we add support for sending exceptions/messages to console. (WebCore::SharedWorkerContext::dispatchConnect): (WebCore::SharedWorkerContext::thread):
  • workers/SharedWorkerContext.h: Added. (WebCore::SharedWorkerContext::create): (WebCore::SharedWorkerContext::isSharedWorkerContext): (WebCore::SharedWorkerContext::toSharedWorkerContext): (WebCore::SharedWorkerContext::setOnconnect): (WebCore::SharedWorkerContext::onconnect): (WebCore::SharedWorkerContext::name):
  • workers/SharedWorkerContext.idl: Added.
  • workers/SharedWorkerRepository.h: Added. (WebCore::SharedWorkerRepository::~SharedWorkerRepository):
  • workers/DefaultSharedWorkerRepository.cpp: Added. Implementation of core singleton class that will be used to implement sharing. (WebCore::SharedWorkerProxy::setThread): Proxy object used to handle resource loading for a given shared worker. (WebCore::SharedWorkerProxy::postTaskToLoader): (WebCore::SharedWorkerProxy::postTaskForModeToWorkerContext): Placeholder routines until we implement loading. (WebCore::SharedWorkerConnectTask::create): Creates a task to fire off a connect event on the worker thread. (WebCore::SharedWorkerConnectTask::SharedWorkerConnectTask): (WebCore::SharedWorkerConnectTask::performTask): (WebCore::SharedWorkerLoader::SharedWorkerLoader): Added helper object to load the initial script for the worker. (WebCore::SharedWorkerLoader::load): (WebCore::SharedWorkerLoader::notifyFinished): (WebCore::SharedWorkerRepository::instance): (WebCore::DefaultSharedWorkerRepository::instance): (WebCore::DefaultSharedWorkerRepository::workerScriptLoaded): Fires off the worker thread once the script is loaded. (WebCore::SharedWorkerRepository::connect): (WebCore::DefaultSharedWorkerRepository::DefaultSharedWorkerRepository): (WebCore::DefaultSharedWorkerRepository::~DefaultSharedWorkerRepository):
  • workers/DefaultSharedWorkerRepository.h: Added.
  • workers/SharedWorkerThread.cpp: Added. (WebCore::SharedWorkerThread::create): (WebCore::SharedWorkerThread::SharedWorkerThread): (WebCore::SharedWorkerThread::~SharedWorkerThread): (WebCore::SharedWorkerThread::createWorkerContext):
  • workers/SharedWorkerThread.h: Added.
  • workers/Worker.cpp: (WebCore::Worker::Worker):
  • workers/WorkerContext.cpp: (WebCore::WorkerContext::reportException):
  • workers/WorkerContext.h: (WebCore::WorkerContext::isSharedWorkerContext): (WebCore::WorkerContext::isDedicatedWorkerContext): Added APIs to determine the type of a given context.

LayoutTests:

2009-08-05 Drew Wilson <atwilson@google.com>

Reviewed by NOBODY (OOPS!).

SharedWorkers should instantiate a thread and a SharedWorkerContext
https://bugs.webkit.org/show_bug.cgi?id=27927

Added disabled tests for SharedWorker minimal functionality.

Began refactoring of dedicated worker tests to allow sharing test cases between shared and dedicated worker (will continue in another patch).

  • fast/workers/resources/shared-worker-common.js: Added.
  • fast/workers/resources/shared-worker-script-error.js: Added.
  • fast/workers/resources/worker-replace-global-constructor.js: Moved common code into shared .js file.
  • fast/workers/shared-worker-constructor.html-disabled:
  • fast/workers/shared-worker-gc-expected.txt: Added.
  • fast/workers/shared-worker-gc.html-disabled: Added.
  • fast/workers/shared-worker-load-error-expected.txt: Added.
  • fast/workers/shared-worker-load-error.html-disabled: Added.
  • fast/workers/shared-worker-replace-global-constructor-expected.txt: Added.
  • fast/workers/shared-worker-replace-global-constructor.html-disabled: Added.
  • fast/workers/shared-worker-script-error-expected.txt: Added.
  • fast/workers/shared-worker-script-error.html-disabled: Added.
  • fast/workers/shared-worker-simple-expected.txt: Added.
  • fast/workers/shared-worker-simple.html-disabled: Added.
  • fast/workers/worker-replace-global-constructor.html:
08:12 Changeset [46844] by cmarrin@apple.com

Added ENABLE_3D_CANVAS flag to build, default to off

07:59 BuildingGtk edited by oszi@inf.u-szeged.hu
(diff)
07:26 Changeset [46843] by hausmann@webkit.org

2009-08-06 Andras Becsi <becsi.andras@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] windowsKeyCodeForKeyEvent fix

Fix windowsKeyCodeForKeyEvent to determine wheter the event comes from the keypad.

  • platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::windowsKeyCodeForKeyEvent): (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
07:12 Changeset [46842] by staikos@webkit.org

2009-08-06 George Staikos <george.staikos@torchmobile.com>

Rubber-stamped by Ariya Hidayat.

Remove the dead wince/ directory that should never have gone in.

  • svg/graphics/wince: Removed.
  • svg/graphics/wince/SVGResourceFilterWince.cpp: Removed.
02:52 Changeset [46841] by pfeldman@chromium.org

2009-08-06 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Extract style editing into a separate file that is
going to be loaded in page context.

https://bugs.webkit.org/show_bug.cgi?id=27939

  • inspector/front-end/InjectedScript.js: Added. (InjectedScript.applyStyleText): (InjectedScript.setStyleText): (InjectedScript.toggleStyleEnabled): (InjectedScript.setStyleRule):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted.callback): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.StylePropertyTreeElement.prototype.): (WebInspector.StylePropertyTreeElement.prototype):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
01:27 Changeset [46840] by abarth@webkit.org

2009-08-06 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

[V8] Remove bug-bait V8Proxy::context()
https://bugs.webkit.org/show_bug.cgi?id=27826

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::updateDocumentWrapperCache): (WebCore::V8Proxy::initContextIfNeeded): (WebCore::V8Proxy::mainWorldContext):
  • bindings/v8/V8Proxy.h:
01:17 Changeset [46839] by abarth@webkit.org

2009-08-06 Adam Barth <abarth@webkit.org>

Unreviewed attempt to fix the Chromium Linux build. This function is
not used.

  • bindings/v8/OwnHandle.h:
00:42 Changeset [46838] by abarth@webkit.org

WebCore:

2009-08-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[V8] Teach ScheduledAction::execute about isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=27703

We now save a weak handle to the original context. We use that handle
to call the timeout in the right context / world.

Tests: http/tests/security/isolatedWorld/window-setTimeout-function.html

http/tests/security/isolatedWorld/window-setTimeout-string.html

  • bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::ScheduledAction): (WebCore::ScheduledAction::execute):
  • bindings/v8/ScheduledAction.h: (WebCore::ScheduledAction::ScheduledAction):
  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8Custom::WindowSetTimeoutImpl):
  • bindings/v8/custom/V8WorkerContextCustom.cpp: (WebCore::SetTimeoutOrInterval):

LayoutTests:

2009-08-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[V8] Teach ScheduledAction::execute about isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=27703

Add test coverage for the interaction between setTimeout and isolated
worlds.

  • http/tests/security/isolatedWorld/window-setTimeout-function-expected.txt: Added.
  • http/tests/security/isolatedWorld/window-setTimeout-function.html: Added.
  • http/tests/security/isolatedWorld/window-setTimeout-string-expected.txt: Added.
  • http/tests/security/isolatedWorld/window-setTimeout-string.html: Added.

08/05/09:

23:57 Changeset [46837] by abarth@webkit.org

2009-08-05 Zoltan Horvath <hzoltan@inf.u-szeged.hu>

Reviewed by Darin Adler.

Allow custom memory allocation control for JavaScriptCore's ScopeNodeData struct
https://bugs.webkit.org/show_bug.cgi?id=27875

Inherits ScopeNodeData struct from FastAllocBase because it has been instantiated by
'new' in JavaScriptCore/parser/Nodes.cpp:1848.

  • parser/Nodes.h:
23:53 Changeset [46836] by xan@webkit.org

2009-08-05 Xan Lopez <xlopez@igalia.com>

Skip new test using eventSender, since the GTK+ port does not have
it yet.

  • platform/gtk/Skipped:
23:10 Changeset [46835] by mrowe@apple.com

Versioning.

23:10 Changeset [46834] by mrowe@apple.com

New tag.

23:08 Changeset [46833] by mrowe@apple.com

Merge r46638.

22:33 Changeset [46832] by barraclough@apple.com

2009-08-05 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Add floating point support for generic ARM port.
https://bugs.webkit.org/show_bug.cgi?id=24986

  • assembler/ARMAssembler.cpp: (JSC::ARMAssembler::doubleTransfer):
  • assembler/ARMAssembler.h: (JSC::ARM::): (JSC::ARMAssembler::): (JSC::ARMAssembler::faddd_r): (JSC::ARMAssembler::fsubd_r): (JSC::ARMAssembler::fmuld_r): (JSC::ARMAssembler::fcmpd_r): (JSC::ARMAssembler::fdtr_u): (JSC::ARMAssembler::fdtr_d): (JSC::ARMAssembler::fmsr_r): (JSC::ARMAssembler::fsitod_r): (JSC::ARMAssembler::fmstat):
  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::): (JSC::MacroAssemblerARM::supportsFloatingPoint): (JSC::MacroAssemblerARM::loadDouble): (JSC::MacroAssemblerARM::storeDouble): (JSC::MacroAssemblerARM::addDouble): (JSC::MacroAssemblerARM::subDouble): (JSC::MacroAssemblerARM::mulDouble): (JSC::MacroAssemblerARM::convertInt32ToDouble): (JSC::MacroAssemblerARM::branchDouble):
  • jit/JIT.h:
22:22 Changeset [46831] by barraclough@apple.com

2009-08-05 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>

Reviewed by Gavin Barraclough.

Add JIT support for generic ARM port without optimizations.
https://bugs.webkit.org/show_bug.cgi?id=24986

All JIT optimizations are disabled.

Signed off by Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
Signed off by Gabor Loki <loki@inf.u-szeged.hu>

  • assembler/ARMAssembler.cpp: (JSC::ARMAssembler::baseIndexTransfer32):
  • assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::Imm32::Imm32):
  • assembler/MacroAssemblerARM.h: (JSC::MacroAssemblerARM::store32): (JSC::MacroAssemblerARM::move): (JSC::MacroAssemblerARM::branch32): (JSC::MacroAssemblerARM::add32): (JSC::MacroAssemblerARM::sub32): (JSC::MacroAssemblerARM::load32):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::getBytecodeIndex):
  • jit/JIT.h:
  • jit/JITInlineMethods.h: (JSC::JIT::restoreArgumentReference):
  • jit/JITOpcodes.cpp:
  • jit/JITStubs.cpp:
  • jit/JITStubs.h: (JSC::JITStackFrame::returnAddressSlot):
  • wtf/Platform.h:
22:19 Changeset [46830] by abarth@webkit.org

2009-08-05 Drew Wilson <atwilson@google.com>

Reviewed by David Levin.

Need to test throwing exceptions from Workers after calling close().
https://bugs.webkit.org/show_bug.cgi?id=27924

  • fast/workers/resources/worker-close.js:
  • fast/workers/worker-close-expected.txt:
  • fast/workers/worker-close.html:
20:50 Changeset [46829] by dglazkov@chromium.org

2009-08-05 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

[V8] Revert http://trac.webkit.org/changeset/46821, which was
landed to supplement http://trac.webkit.org/changeset/46816, but
now that the latter is reverted, the former needs the same.

  • bindings/v8/DOMObjectsInclude.h:
  • bindings/v8/DerivedSourcesAllInOne.cpp:
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
20:27 Changeset [46828] by abarth@webkit.org

2009-08-05 Joseph Pecoraro <joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Color is only reported in rgb() format; should toggle between rgb() and hex
https://bugs.webkit.org/show_bug.cgi?id=13516

New Class to Parse and Change Between Color Representations:

Representations of Colors in Raw Form. (May be Lazy Loaded):

(WebInspector.Color.prototype.get shorthex):
(WebInspector.Color.prototype.get hex):
(WebInspector.Color.prototype.set hex):
(WebInspector.Color.prototype.get rgb):
(WebInspector.Color.prototype.set rgb):
(WebInspector.Color.prototype.get hsl):
(WebInspector.Color.prototype.set hsl):
(WebInspector.Color.prototype.get nickname):
(WebInspector.Color.prototype.set nickname):
(WebInspector.Color.prototype.get rgba):
(WebInspector.Color.prototype.set rgba):
(WebInspector.Color.prototype.get hsla):
(WebInspector.Color.prototype.set hsla):

Helpers and Standard String Representations:

(WebInspector.Color.prototype.hasShortHex):
(WebInspector.Color.prototype.toRgb):
(WebInspector.Color.prototype.toHsl):
(WebInspector.Color.prototype.toShortHex):
(WebInspector.Color.prototype.toHex):
(WebInspector.Color.prototype.toRgba):
(WebInspector.Color.prototype.toHsla):
(WebInspector.Color.prototype.toNickname):

Conversion Functions to Determine Other Representations:
My Sources for all algorithms and sample data:
Wikipedia: http://en.wikipedia.org/wiki/HSV_color_space
CSS Specification: http://www.w3.org/TR/css3-color/#hsla-color

(WebInspector.Color.prototype.rgbToHex):
(WebInspector.Color.prototype.hexToRgb):
(WebInspector.Color.prototype.rgbToHsl):
(WebInspector.Color.prototype.hslToRgb.hueToRgb):
(WebInspector.Color.prototype.hslToRgb):
(WebInspector.Color.prototype.rgbaToHsla):
(WebInspector.Color.prototype.hslaToRgba):

Called from the constructor, attempts to parse and will throw an error
if it cannot parse. If simple then the "hex" value is guarenteed.
If advanced then both the "rgba" and "hsla" are guarenteed. If it is
a nickname in any way (e.g. "transparent", "black") then this is
guarenteed to be set as well.

(WebInspector.Color.prototype.parse):

Clicking on the swatch will rotate through Color Representations.

Simple: rgb -> hsl -> nickname? -> shorthex? -> hex -> (loop around)
Advanced: rgba -> hsla -> nickname? -> (loop around)

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.updateTitle.value.): (WebInspector.StylePropertyTreeElement.prototype.updateTitle):

Load Color.js:

  • inspector/front-end/inspector.html:
20:05 Changeset [46827] by abarth@webkit.org

2009-08-05 John Abd-El-Malek <jam@chromium.org>

Reviewed by Dimitri Glazkov.

Support setting event listeners for message ports in the worker process.

https://bugs.webkit.org/show_bug.cgi?id=28004

  • bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::retrieve): (WebCore::WorkerContextExecutionProxy::EventTargetToV8Object):
  • bindings/v8/WorkerContextExecutionProxy.h:
  • bindings/v8/custom/V8MessagePortCustom.cpp: (WebCore::getEventListener): (WebCore::ACCESSOR_SETTER): (WebCore::CALLBACK_FUNC_DECL):
19:39 Changeset [46826] by abarth@webkit.org

2009-08-05 Stephen White <senorblanco@chromium.org>

Reviewed by Dimitri Glazkov.

http://bugs.webkit.org/show_bug.cgi?id=28022

Minor fix for media code on chromium/skia.

  • rendering/RenderThemeChromiumSkia.cpp: (WebCore::RenderThemeChromiumSkia::paintMediaSliderTrack):
18:37 Changeset [46825] by darin@apple.com

WebCore:

2009-08-05 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Client side image maps did not handle zoom correctly.
Client side image maps did not handle border and padding correctly.

Test: fast/images/image-map-zoom.html

  • rendering/RenderImage.cpp: (WebCore::RenderImage::nodeAtPoint): Compute the values to pass in to the map element using the content box and the effective zoom.

LayoutTests:

2009-08-05 Darin Adler <darin@apple.com>

Reviewed by Dan Bernstein.

Client side image maps did not handle zoom correctly.
Client side image maps did not handle border and padding correctly.

  • fast/images/image-map-zoom-expected.txt: Added.
  • fast/images/image-map-zoom.html: Added.
18:30 Changeset [46824] by beidson@apple.com

Add more missing ResourceLoadDelegate methods for WinDRT, and remove another test from the skipped list.

17:52 WebKit Team edited by atwilson@chromium.org
(diff)
17:12 Changeset [46823] by mrowe@apple.com

Roll out r46816 as it broke many tests.

17:11 Changeset [46822] by ap@webkit.org

Reviewed by Oliver Hunt.

https://bugs.webkit.org/show_bug.cgi?id=28027
<rdar://7064428> Files with accents in names are submitted incorrectly due to use of
precomposed Unicode

  • platform/network/mac/FormDataStreamMac.mm: (WebCore::setHTTPBody): Use getFileSize() from FileSystem.h instead of custom code for getting file size. This adds path normalization necessary with some file systems on Mac. This also loses a S_IFMT check, which didn't seem important anyway.
16:47 Changeset [46821] by dglazkov@chromium.org

2009-08-05 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

[V8] Include Media into V8 bindings.

  • bindings/v8/DOMObjectsInclude.h: Added Media include.
  • bindings/v8/DerivedSourcesAllInOne.cpp: Added V8Media include.
  • bindings/v8/V8Index.cpp: Added decl for V8Media.
  • bindings/v8/V8Index.h: Added V8Media include.
16:41 Changeset [46820] by beidson@apple.com

WebKitTools:
2009-08-05 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler.

Win DRT's resource load delegate is missing didReceiveResponse
https://bugs.webkit.org/show_bug.cgi?id=28033

  • DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::didReceiveResponse):
  • DumpRenderTree/win/ResourceLoadDelegate.h:

LayoutTests:
2009-08-05 Brady Eidson <beidson@apple.com>

Reviewed by Darin Adler.

Win DRT's resource load delegate is missing didReceiveResponse
https://bugs.webkit.org/show_bug.cgi?id=28033

  • platform/win/Skipped: Remove a test that now passes


Remove platform specific results for the XFrameOptions suite which now matches cross platform results:

  • platform/win/http/tests/security: Removed.
  • platform/win/http/tests/security/XFrameOptions: Removed.
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Removed.
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Removed.
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Removed.
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow-expected.txt: Removed.
16:18 Changeset [46819] by jhoneycutt@apple.com

2009-08-04 Jon Honeycutt <jhoneycutt@apple.com>

Fix Windows layout test crashes.

PluginView::removeFromUnstartedListIfNecessary() would try to remove
any unstarted PluginView from the Page's set of unstarted plug-ins,
regardless of why the PluginView wasn't started. If we tried to start a
plug-in, but it failed to start, we would hit an assertion in
Page::removeUnstartedPlugin() that asserts that we would only modify the
unstarted plug-ins set if we were not currently starting plug-ins.

Fix this by having PluginView track whether it's waiting to be started,
and to check this before trying to remove itself from the Page's
unstarted plug-ins set.

Reviewed by Darin Adler.

  • page/Page.cpp: (WebCore::Page::removeUnstartedPlugin): Assert that the passed PluginView is in the unstarted set.
  • plugins/PluginView.cpp: (WebCore::PluginView::start): Set that we are not waiting to be started. (WebCore::PluginView::startOrAddtoUnstartedList): Set that we are waiting to be started. (WebCore::PluginView::removeFromUnstartedListIfNecessary): Check not whether we are started, but whether we are waiting to be started. (WebCore::PluginView::PluginView):
  • plugins/PluginView.h:
15:48 Changeset [46818] by jorlow@chromium.org

2009-08-05 Jeremy Orlow <jorlow@chromium.org>

Fix DOM Storage memory leak
https://bugs.webkit.org/show_bug.cgi?id=28029

Forgot to use adoptRef in one place. This caused the = operator to
increment the ref count when it shouldn't have, so StorageAreaImpl's were
never freed.

  • storage/StorageNamespaceImpl.cpp: (WebCore::StorageNamespaceImpl::storageArea):
14:51 Changeset [46817] by dglazkov@chromium.org

2009-08-05 Dimitri Glazkov <dglazkov@chromium.org>

Unreviewed, build fix.

[Chromium] Let CodeGeneratorV8.pm know that Media is ref-counted.

  • bindings/scripts/CodeGeneratorV8.pm: Added Media check to IsRefPtrType.
14:26 Changeset [46816] by simon.fraser@apple.com

2009-08-05 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

Implement the matchMedium method on the Media interface described in the CSSOM View Module.
https://bugs.webkit.org/show_bug.cgi?id=22495

Add a new Media interface, obtainable via the AbstractView, that can
evaluate queries via its matchesMedium() method.

Test: fast/media/matchmedium-query-api.html

  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl: Add Media.* files to the build.
  • css/Media.cpp: Added. (WebCore::Media::Media): (WebCore::Media::type): (WebCore::Media::matchMedium):
  • css/Media.h: Added. (WebCore::Media::create): (WebCore::Media::document):
  • css/Media.idl: Added. Media::matchMedium() uses a MediaQueryEvaluator() to test the query.
  • page/AbstractView.idl:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::media):
  • page/DOMWindow.h:
  • page/DOMWindow.idl: Add a readonly attribute for Media.
14:25 Changeset [46815] by darin@apple.com

2009-08-05 Darin Adler <darin@apple.com>

Reviewed by David Levin.

Use checked casts for render tree
https://bugs.webkit.org/show_bug.cgi?id=23522

Last patch. Makes all the casts of RenderObject use checked
casts instead of using static_cast directly.

  • accessibility/AccessibilityListBox.cpp: (WebCore::AccessibilityListBox::visibleChildren): (WebCore::AccessibilityListBox::doAccessibilityHitTest):
  • accessibility/AccessibilityListBoxOption.cpp: (WebCore::AccessibilityListBoxOption::elementRect):
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::textUnderElement): (WebCore::AccessibilityRenderObject::stringValue): (WebCore::AccessibilityRenderObject::titleUIElement): (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
  • accessibility/AccessibilitySlider.cpp: (WebCore::AccessibilitySliderThumb::elementRect):
  • dom/InputElement.cpp: (WebCore::InputElement::updatePlaceholderVisibility):
  • dom/SelectElement.cpp: (WebCore::SelectElement::scrollToSelection): (WebCore::SelectElement::recalcStyle): (WebCore::SelectElement::setRecalcListItems): (WebCore::SelectElement::menuListDefaultEventHandler): (WebCore::SelectElement::listBoxDefaultEventHandler):
  • editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply):
  • html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::renderWidgetForJSBindings):
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::reset):
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::updateWidget):
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::attach):
  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::defaultEventHandler):
  • html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::attach):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): (WebCore::HTMLInputElement::addSearchResult): (WebCore::HTMLInputElement::onSearch):
  • html/HTMLLIElement.cpp: (WebCore::HTMLLIElement::parseMappedAttribute): (WebCore::HTMLLIElement::attach):
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setReadyState): (WebCore::HTMLMediaElement::mediaPlayerDurationChanged): (WebCore::HTMLMediaElement::mediaPlayerSizeChanged): (WebCore::HTMLMediaElement::mediaPlayerRenderingCanBeAccelerated): (WebCore::HTMLMediaElement::mediaPlayerGraphicsLayer): (WebCore::HTMLMediaElement::defaultEventHandler): (WebCore::HTMLMediaElement::finishParsingChildren):
  • html/HTMLOListElement.cpp: (WebCore::HTMLOListElement::parseMappedAttribute):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::updateWidget):
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::defaultEventHandler):
  • page/DragController.cpp: (WebCore::DragController::concludeEditDrag):
  • page/EventHandler.cpp: (WebCore::EventHandler::selectCursor): (WebCore::EventHandler::capsLockStateMayHaveChanged):
  • page/Frame.cpp: (WebCore::Frame::ownerRenderer):
  • page/FrameView.cpp: (WebCore::FrameView::detachCustomScrollbars):
  • page/wince/FrameWince.cpp: (WebCore::computePageRectsForFrame):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally):
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlTimelineElement::defaultEventHandler):
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::findNextLineBreak):
  • rendering/RenderCounter.cpp: (WebCore::planCounter):
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::computeEdgeInfo): (WebCore::RenderFrameSet::setIsResizing):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::contentsBox):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateBacking): (WebCore::RenderLayerCompositor::requiresCompositingForVideo):
  • rendering/RenderListItem.cpp: (WebCore::previousListItem): (WebCore::RenderListItem::explicitValueChanged):
  • rendering/RenderObject.cpp: (WebCore::updateListMarkerNumbers):
  • rendering/RenderObjectChildList.cpp: (WebCore::updateListMarkerNumbers): (WebCore::invalidateCountersInContainer):
  • rendering/RenderScrollbarTheme.cpp: (WebCore::RenderScrollbarTheme::minimumThumbLength): (WebCore::RenderScrollbarTheme::backButtonRect): (WebCore::RenderScrollbarTheme::forwardButtonRect): (WebCore::RenderScrollbarTheme::trackRect): (WebCore::RenderScrollbarTheme::constrainTrackRectToTrackPieces): (WebCore::RenderScrollbarTheme::paintScrollbarBackground): (WebCore::RenderScrollbarTheme::paintTrackBackground): (WebCore::RenderScrollbarTheme::paintTrackPiece): (WebCore::RenderScrollbarTheme::paintButton): (WebCore::RenderScrollbarTheme::paintThumb):
  • rendering/RenderSlider.cpp: (WebCore::SliderThumbElement::defaultEventHandler):
  • rendering/RenderThemeChromiumMac.mm: (WebCore::RenderThemeChromiumMac::paintSliderThumb): (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack):
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::determineSliderThumbState):
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintSliderThumb):
  • rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintSliderThumb):
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::determineSliderThumbState):
  • rendering/SVGCharacterLayoutInfo.cpp: (WebCore::SVGCharacterLayoutInfo::addLayoutInformation):
  • rendering/SVGRootInlineBox.cpp: (WebCore::findSVGRootObject):
  • rendering/TextControlInnerElements.cpp: (WebCore::RenderTextControlInnerBlock::nodeAtPoint): (WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
  • svg/SVGImageElement.cpp: (WebCore::SVGImageElement::attach):
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::canvasResource):
  • svg/SVGTextContentElement.cpp: (WebCore::rootInlineBoxForTextContentElement):
  • wml/WMLInputElement.cpp: (WebCore::WMLInputElement::defaultEventHandler): Use checked casts.
  • rendering/RenderApplet.h:
  • rendering/RenderCounter.h:
  • rendering/RenderFieldset.h:
  • rendering/RenderFileUploadControl.h:
  • rendering/RenderFrame.h:
  • rendering/RenderFrameSet.h:
  • rendering/RenderHTMLCanvas.h:
  • rendering/RenderListBox.h:
  • rendering/RenderListItem.h:
  • rendering/RenderListMarker.h:
  • rendering/RenderMedia.h:
  • rendering/RenderMenuList.h:
  • rendering/RenderPart.h:
  • rendering/RenderPartObject.h:
  • rendering/RenderPath.h:
  • rendering/RenderSVGContainer.h:
  • rendering/RenderSVGRoot.h:
  • rendering/RenderSVGTextPath.h:
  • rendering/RenderSVGViewportContainer.h:
  • rendering/RenderScrollbar.h:
  • rendering/RenderSlider.h:
  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderTextControlSingleLine.h:
  • rendering/RenderVideo.h: Added a checked cast. Also made most members protected or private.
  • rendering/RenderBlock.h:
  • rendering/RenderInline.h:
  • rendering/RenderReplaced.h:
  • rendering/RenderSVGBlock.h:
  • rendering/RenderSVGImage.h:
  • rendering/RenderSVGInlineText.h:
  • rendering/RenderSVGText.h:
  • rendering/RenderTextControl.h: Made most members protected or private.
  • rendering/RenderInline.cpp:
  • rendering/RenderSVGContainer.cpp:
  • rendering/RenderSVGHiddenContainer.cpp:
  • rendering/RenderSVGImage.cpp:
  • rendering/RenderSVGRoot.cpp: Removed unneeded destructor.
  • rendering/RenderSVGHiddenContainer.h: Removed unneeded virtual function overrides that did the same as the default and base class.
  • rendering/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::paint): Updated to use m_viewport directly instead of using a function call. (WebCore::RenderSVGViewportContainer::applyViewportClip): Ditto. (WebCore::RenderSVGViewportContainer::viewportTransform): Ditto. (WebCore::RenderSVGViewportContainer::localToParentTransform): Ditto. (WebCore::RenderSVGViewportContainer::pointIsInsideViewportClip): Ditto.
  • rendering/RenderScrollbar.cpp: (WebCore::pseudoForScrollbarPart): Changed switch statement to use cases for all values instead of using a default case.
  • rendering/RenderTreeAsText.cpp: (WebCore::operator<<): Removed dependency on casting to types that don't have any public members we need to get at. Instead, use function names to identify the type rather than doing so much overloading. Changed to use checked casts. (WebCore::write): Ditto.
  • rendering/SVGRenderSupport.cpp: (WebCore::renderSubtreeToImage): Changed to use a checked cast and also added a comment about the fact that the code does not do sufficient type checking before doing the cast.
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::writeRenderSVGTextBox): Renamed this from operator<<. (WebCore::writeSVGInlineTextBoxes): Renamed this from writeSVGInlineText. (WebCore::writeSVGText): Renamed this from write. (WebCore::writeSVGInlineText): Ditto. (WebCore::writeSVGImage): Ditto.
  • rendering/SVGRenderTreeAsText.h: Updated for name changes. Removed unneeded default arguments.
14:14 Changeset [46814] by pkasting@chromium.org

2009-08-05 Peter Kasting <pkasting@google.com>

Reviewed by Sam Weinig.

https://bugs.webkit.org/show_bug.cgi?id=27851
Fix a pair of compiler warnings on the GTK Linux buildbot.

  • platform/image-decoders/bmp/BMPImageDecoder.cpp: (WebCore::BMPImageDecoder::processFileHeader): Don't use multi-character constants, they're not portable.
  • platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::setSize): Simpler code that also doesn't compare signed with unsigned.
14:00 Changeset [46813] by beidson@apple.com

2009-08-05 Brady Eidson <beidson@apple.com>

Rubberstamped by Mark Rowe.

As a followup to http://trac.webkit.org/changeset/46811, Windows-specific results *did* have some differences, so restoring those results.

  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Copied from platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt.
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Copied from platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt.
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Copied from platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt.
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Copied from platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt.
13:46 Changeset [46812] by beidson@apple.com

2009-08-05 Brady Eidson <beidson@apple.com>

Rubberstamped by Mark Rowe.

Actually, for all 6 of these tests Tiger now matches the cross-platform results, so removing all the Tiger results.

  • platform/mac-tiger/http/tests/loading/redirect-methods-expected.txt: Removed.
  • platform/mac-tiger/http/tests/misc/favicon-loads-with-images-disabled-expected.txt: Removed.
  • platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Removed.
  • platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Removed.
  • platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Removed.
  • platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
13:31 Changeset [46811] by beidson@apple.com

2009-08-05 Brady Eidson <beidson@apple.com>

Rubberstamped by Mark Rowe.

As a followup to http://trac.webkit.org/changeset/46809, Windows-specific results now match the cross-platform results,
so I'm removing them.

  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Removed.
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Removed.
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Removed.
  • platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
13:26 Changeset [46810] by beidson@apple.com

2009-08-05 Brady Eidson <beidson@apple.com>

Rubberstamped by Mark Rowe.

As a followup to http://trac.webkit.org/changeset/46809, update Tiger platform specific results for these tests.

  • platform/mac-tiger/http/tests/loading/redirect-methods-expected.txt:
  • platform/mac-tiger/http/tests/misc/favicon-loads-with-images-disabled-expected.txt:
13:16 Changeset [46809] by darin@chromium.org

2009-08-05 Darin Fisher <darin@chromium.org>

Reviewed by Darin Adler.

Add layoutTestController.dumpWillCacheResponse
https://bugs.webkit.org/show_bug.cgi?id=28010

willCacheResponse is only interesting for embedders of mainline WebKit on Mac.
Splitting off a new dumpWillCacheResponse allows a number of existings tests
to run across platforms.

The test that was specifically verifying willCacheResponse now calls
dumpWillCacheResponse.

  • DumpRenderTree/LayoutTestController.cpp: Add dumpWillCacheResponse (LayoutTestController::LayoutTestController): (dumpWillCacheResponseCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h: (LayoutTestController::dumpWillCacheResponse): (LayoutTestController::setDumpWillCacheResponse):
  • DumpRenderTree/mac/ResourceLoadDelegate.mm: Inspect dumpWillCacheResponse instead of dumpResourceLoadCallbacks. (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
12:56 Changeset [46808] by mrowe@apple.com

Fix two tests to not load a resource that takes five seconds to load.

Reviewed by Brady Eidson.

We achieve this by making the delay in slow-resource.pl configurable in a query parameter.
This drops the run time of each of the tests from over five seconds to less than a third
of a second.

  • http/tests/misc/DOMContentLoaded-event.html:
  • http/tests/navigation/multiple-back-forward-entries.html:
  • http/tests/navigation/resources/slow-resource.pl:
12:36 Changeset [46807] by pkasting@chromium.org

2009-08-05 Peter Kasting <pkasting@google.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26460
Return multiple icon entries from the ICO decoder as separate frames,
sorted by decreasing quality (much like the CG ICO decoder does).

As a result of this change, we can eliminate the Skia-specific setData()
hack that the Chromium port used to select the desired icon size -- now
callers can just enumerate the frames and ask for the data from the one
they like.


Under the hood, the ICO decoder now keeps vectors for a number of things
(including directory entries and image decoders) where it used to have
single members. However, callers (that I have seen) will only request
one frame from the icon, so practically there aren't going to be lots of
instantiated image decoders.

  • platform/graphics/ImageSource.h: Move |m_decoder| back to private now that Skia no longer needs to access it.
  • platform/graphics/cairo/ImageSourceCairo.cpp: (WebCore::createDecoder): Remove size argument from ICO decoder instantiation.
  • platform/graphics/skia/ImageSourceSkia.cpp: (WebCore::createDecoder): Remove size argument from ICO decoder instantiation. (WebCore::ImageSource::setData): Remove function to ask for a particular icon size.
  • platform/graphics/skia/ImageSourceSkia.h: Removed.
  • platform/graphics/wx/ImageSourceWx.cpp: (WebCore::createDecoder): Remove size argument from ICO decoder instantiation.
  • platform/image-decoders/ico/ICOImageDecoder.cpp: (WebCore::ICOImageDecoder::ICOImageDecoder): (WebCore::ICOImageDecoder::~ICOImageDecoder): Delete all instantiated per-frame decoders. (WebCore::ICOImageDecoder::setData): Send data to all instantiated per-frame decoders. (WebCore::ICOImageDecoder::isSizeAvailable): Use size from icon directory instead of PNG decoder (if applicable) so we can report it without decoding the PNG frames. (WebCore::ICOImageDecoder::size): Report frame-specific size if BMP decoder is calling. Otherwise, use size from icon directory instead of PNG decoder (if applicable). (WebCore::ICOImageDecoder::frameSizeAtIndex): Implement. (WebCore::ICOImageDecoder::setSize): Sanity check value if BMP decoder is calling. (WebCore::ICOImageDecoder::frameCount): Implement. (WebCore::ICOImageDecoder::frameBufferAtIndex): Sanity check size for PNG frames. (WebCore::ICOImageDecoder::compareEntries): Add utility function for sorting entries. (WebCore::ICOImageDecoder::setDataForPNGDecoderAtIndex): Factor out utility function for passing correct data blob to a PNG decoder. (WebCore::ICOImageDecoder::decodeWithCheckForDataEnded): Split decode() into two pieces. (WebCore::ICOImageDecoder::decodeDirectory): The first part of the old decode(). (WebCore::ICOImageDecoder::decodeAtIndex): The second part of the old decode(), split off so we avoid decoding an entry until it's requested. (WebCore::ICOImageDecoder::processDirectory): Add resizing of internal data structures based on directory contents. (WebCore::ICOImageDecoder::processDirectoryEntries): Sort entries by quality. (WebCore::ICOImageDecoder::imageTypeAtIndex): Return type to caller instead of setting a member.
  • platform/image-decoders/ico/ICOImageDecoder.h:
11:38 Changeset [46806] by abarth@webkit.org

2009-08-05 Szabo Carol <carol.szabo@nokia.com>

Reviewed by Darin Adler.

Test for https://bugs.webkit.org/show_bug.cgi?id=27942
Form Reset does not work per w3c standard when single selection
SELECT element has more than one option marked as selected.

  • fast/forms/select-reset-multiple-selections-4-single-selection-expected.txt: Added.
  • fast/forms/select-reset-multiple-selections-4-single-selection.html: Added.

2009-08-05 Szabo Carol <carol.szabo@nokia.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=27942

Test: fast/forms/select-reset-multiple-selections-4-single-selection.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::reset):

Added HTML 4.01 compliant handling of broken webpages that
specify more than one selected option for single selection SELECT
element, in a manner that emulates Firefox and is similar to IE 7

11:22 Changeset [46805] by jorlow@chromium.org

2009-08-05 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Adam Barth.

Add my name to committers.py
https://bugs.webkit.org/show_bug.cgi?id=28013

Add my name to committers.py.

  • Scripts/modules/committers.py:
08:17 Changeset [46804] by hausmann@webkit.org

2009-08-05 Andras Becsi <becsi.andras@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

WebCore.pro bugfix

Fix the gperf lines to properly include the string.h header at compilation with gperf version 3.0.3 and newer.

  • WebCore.pro:
08:14 Changeset [46803] by hausmann@webkit.org

2009-08-05 Csaba Osztrogonac <oszi@inf.u-szeged.hu>

Reviewed by Simon Hausmann.

[Qt] Fix build error caused by http://trac.webkit.org/changeset/46763

  • Api/qwebpluginfactory.h: Export macro added.
07:56 Changeset [46802] by kenneth@webkit.org

2009-08-05 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Simon Hausmann.

A minor refactoring of the Qt DRT to be a bit more similar to
the other DRTs, as well as more understandable.

Splitting up resetJSObjects into a LayoutTestController->reset()
plus a new closeRemainingWindows() method.

Added a resetToConsistentStateBeforeTesting() method to keep
the code in one place, making it easier to verify that we are
doing things properly.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): (WebCore::DumpRenderTree::open): (WebCore::DumpRenderTree::closeRemainingWindows):
  • DumpRenderTree/qt/DumpRenderTree.h:
07:51 Changeset [46801] by kenneth@webkit.org

2009-08-05 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Simon Hausmann.

Make the Qt DRT WorkQueue work similarily to the cross platform
one. This means that all items return true if they started
loading.

This change paves the way for unforking the WorkQueue, if we [Qt]
would like that.

  • DumpRenderTree/qt/WorkQueue.cpp: (WorkQueue::processWork):
  • DumpRenderTree/qt/WorkQueue.h:
  • DumpRenderTree/qt/WorkQueueItem.h:
  • DumpRenderTree/qt/jsobjects.cpp: (LoadItem::invoke): (ReloadItem::invoke): (ScriptItem::invoke): (BackForwardItem::invoke): (LayoutTestController::processWork): (LayoutTestController::maybeDump):
07:48 Changeset [46800] by kenneth@webkit.org

2009-08-04 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Simon Hausmann.

If load of a test fails, don't dump as it will be dumped
in the preceding test, resulting in a invalid incorrect layout.

  • DumpRenderTree/qt/jsobjects.cpp: (LayoutTestController::maybeDump):
07:46 Changeset [46799] by kenneth@webkit.org

2009-08-04 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Simon Hausmann.

Make the Qt DumpRenderTree more similar to the mac one.

Changes include:
1) Reset zoom factor before each test
2) Only dump the backforward list when we got other dump result
3) When we dump the render tree, and got zero result print out:

[mainFrame renderTreeAsExternalRepresentation]
and not:
[frame renderTreeAsExternalRepresentation]

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::DumpRenderTree::open): (WebCore::methodNameStringForFailedTest): (WebCore::DumpRenderTree::dump):
07:39 Changeset [46798] by cfleizach@apple.com

WebCore:

2009-08-05 Chris Fleizach <cfleizach@apple.com>

Fix Tiger build breakage.

  • accessibility/mac/AccessibilityObjectWrapper.mm:

WebKitTools:

2009-08-05 chris fleizach <cfleizach@apple.com>

Fix Tiger build breakage.

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:
05:40 EFLWebKit edited by tonikitoo@gmail.com
(diff)
04:40 Changeset [46797] by jmalonzo@webkit.org

2009-08-05 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez.

[Gtk] macros in webkit.m4 should be defined once only
https://bugs.webkit.org/show_bug.cgi?id=27929

The macros in webkit.m4 are not meant to be called multiple times
so we'll make them AC_DEFUN_ONCE. Also make AC_HEADER_STDC and AC_PROG_CXX
AC_REQUIRE to remove the automake warnings when doing autogen.sh.

Lastly, make sure CXXFLAGS and CFLAGS are defined before
AC_PROG_CXX gets expanded so it doesn't add "-g -O2" on Release builds.

  • autotools/webkit.m4:
01:13 Changeset [46796] by xan@webkit.org

2009-08-05 Xan Lopez <xlopez@igalia.com>

Revert r46714, it was making us build debug images by default.

  • autotools/webkit.m4:
Note: See TracTimeline for information about the timeline view.