Timeline



Aug 17, 2009:

11:35 PM Changeset in webkit [47419] by eric@webkit.org
  • 8 edits in trunk

2009-08-17 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Darin Adler.

Some HTMLs are modified by make-script-test-wrappers
​https://bugs.webkit.org/show_bug.cgi?id=28213

Add fast/js/const.js and fast/canvas/canvas-2d-imageData-create-nonfinite.js into
the exclude list, modified fast/dom/Geolocation/resources/TEMPLATE.html, and
re-generated wml/* and Geolocation/* .

  • fast/dom/Geolocation/enabled.html:
  • fast/dom/Geolocation/resources/TEMPLATE.html:
  • http/tests/wml/access-target-domain-deny.html:
  • http/tests/wml/access-target-path-deny.html:
  • http/tests/wml/access-target.html:

2009-08-17 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Darin Adler.

Some HTMLs are modified by make-script-test-wrappers
​https://bugs.webkit.org/show_bug.cgi?id=28213

Add fast/js/const.js and fast/canvas/canvas-2d-imageData-create-nonfinite.js into
the exclude list, modified fast/dom/Geolocation/resources/TEMPLATE.html, and
re-generated wml/* and Geolocation/* .

  • Scripts/make-script-test-wrappers:
11:26 PM Changeset in webkit [47418] by eric@webkit.org
  • 8 edits
    3 adds in trunk

2009-08-17 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Eric Seidel.

-webkit-box-orient:horizontal doesn't work on <button> tag
​https://bugs.webkit.org/show_bug.cgi?id=34445

Make a flexible button's anonymous child flexible and pass the
parent's box-orient to the anonymous child.

Also, added a renderName for anonymous flexible boxes.

  • fast/flexbox/box-orient-button-expected.txt: Added.
  • fast/flexbox/box-orient-button.html: Added.
  • fast/flexbox/resources/box-orient-button.js: Added. (setBoxOrient): (gebi):

2009-08-17 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Eric Seidel.

-webkit-box-orient:horizontal doesn't work on <button> tag
​https://bugs.webkit.org/show_bug.cgi?id=34445

Make a flexible button's anonymous child flexible and pass the
parent's box-orient to the anonymous child.

Also, added a renderName for anonymous flexible boxes.

Test: fast/flexbox/box-orient-button.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::createAnonymousBlock):
  • rendering/RenderBlock.h:
  • rendering/RenderButton.cpp: (WebCore::RenderButton::addChild): (WebCore::RenderButton::setupInnerStyle):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::renderName):

2009-08-17 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Eric Seidel.

-webkit-box-orient:horizontal doesn't work on <button> tag
​https://bugs.webkit.org/show_bug.cgi?id=34445

Make a flexible button's anonymous child flexible and pass the
parent's box-orient to the anonymous child.

Also, added a renderName for anonymous flexible boxes.

  • Scripts/make-script-test-wrappers:
11:20 PM Changeset in webkit [47417] by barraclough@apple.com
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.pri

add THE CORRECT new file to lunix builds (you idiot).

11:08 PM Changeset in webkit [47416] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

add new file to lunix builds.

10:56 PM Changeset in webkit [47415] by barraclough@apple.com
  • 1 edit in trunk/JavaScriptCore/runtime/Executable.cpp

speculative interpretoid build fixeration.

10:49 PM Changeset in webkit [47414] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore

speculative 'doze build fixeration II.

10:42 PM Changeset in webkit [47413] by barraclough@apple.com
  • 1 edit in trunk/JavaScriptCore/runtime/Collector.cpp

speculative 'doze build fixeration.

10:34 PM Changeset in webkit [47412] by barraclough@apple.com
  • 41 edits
    1 add in trunk/JavaScriptCore

No, silly runtime, AST nodes are not for you.

Reviewed by Sam Weinig.

We still use AST nodes (ScopeNodes, particularly FunctionBodyNodes) within
the runtime, which means that these nodes must be persisted outside of the
arena, contain both parser & runtime data, etc. This is all a bit of a mess.

Move functionality into a new FunctionExecutable class.

(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::markAggregate):
(JSC::CodeBlock::reparseForExceptionInfoIfNecessary):
(JSC::CodeBlock::lineNumberForBytecodeOffset):
(JSC::CodeBlock::shrinkToFit):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::getBytecodeIndex):
(JSC::CodeBlock::discardBytecode):
(JSC::CodeBlock::instructionCount):
(JSC::CodeBlock::getJITCode):
(JSC::CodeBlock::executablePool):
(JSC::CodeBlock::ownerExecutable):
(JSC::CodeBlock::extractExceptionInfo):
(JSC::CodeBlock::addFunctionDecl):
(JSC::CodeBlock::functionDecl):
(JSC::CodeBlock::numberOfFunctionDecls):
(JSC::CodeBlock::addFunctionExpr):
(JSC::CodeBlock::functionExpr):
(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::ProgramCodeBlock::ProgramCodeBlock):
(JSC::EvalCodeBlock::EvalCodeBlock):
(JSC::FunctionCodeBlock::FunctionCodeBlock):
(JSC::NativeCodeBlock::NativeCodeBlock):

  • bytecode/EvalCodeCache.h:
  • bytecode/SamplingTool.cpp:

(JSC::SamplingTool::doRun):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitNewFunction):
(JSC::BytecodeGenerator::emitNewFunctionExpression):

  • bytecompiler/BytecodeGenerator.h:
  • debugger/Debugger.cpp:

(JSC::Debugger::recompileAllJSFunctions):

  • interpreter/CachedCall.h:

(JSC::CachedCall::CachedCall):

  • interpreter/CallFrameClosure.h:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::throwException):
(JSC::Interpreter::execute):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::debug):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveLastCaller):

  • interpreter/Interpreter.h:
  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JIT.h:

(JSC::JIT::compile):

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::emit_op_new_func):
(JSC::JIT::emit_op_new_func_exp):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITStubs.h:

(JSC::):

  • parser/Nodes.cpp:

(JSC::FunctionBodyNode::reparseDataIfNecessary):

  • parser/Nodes.h:

(JSC::EvalNode::partialDestroyData):

  • parser/Parser.h:
  • profiler/ProfileGenerator.cpp:
  • profiler/Profiler.cpp:

(JSC::Profiler::createCallIdentifier):
(JSC::createCallIdentifierFromFunctionImp):

  • runtime/Arguments.h:

(JSC::Arguments::getArgumentsData):
(JSC::Arguments::Arguments):
(JSC::JSActivation::copyRegisters):

  • runtime/ArrayPrototype.cpp:

(JSC::isNumericCompareFunction):

  • runtime/CallData.h:

(JSC::):

  • runtime/Collector.cpp:

(JSC::Heap::collect):

  • runtime/ConstructData.h:

(JSC::):

  • runtime/ExceptionHelpers.cpp:

(JSC::createUndefinedVariableError):
(JSC::createInvalidParamError):
(JSC::createNotAConstructorError):
(JSC::createNotAFunctionError):
(JSC::createNotAnObjectError):

  • runtime/Executable.cpp: Added.

(JSC::EvalExecutable::generateBytecode):
(JSC::ProgramExecutable::generateBytecode):
(JSC::FunctionExecutable::generateBytecode):
(JSC::EvalExecutable::generateJITCode):
(JSC::ProgramExecutable::generateJITCode):
(JSC::FunctionExecutable::generateJITCode):
(JSC::FunctionExecutable::isHostFunction):
(JSC::FunctionExecutable::markAggregate):
(JSC::FunctionExecutable::reparseExceptionInfo):
(JSC::EvalExecutable::reparseExceptionInfo):
(JSC::FunctionExecutable::recompile):
(JSC::FunctionExecutable::FunctionExecutable):

  • runtime/Executable.h:

(JSC::ExecutableBase::~ExecutableBase):
(JSC::ExecutableBase::ExecutableBase):
(JSC::ExecutableBase::source):
(JSC::ExecutableBase::sourceID):
(JSC::ExecutableBase::lastLine):
(JSC::ExecutableBase::usesEval):
(JSC::ExecutableBase::usesArguments):
(JSC::ExecutableBase::needsActivation):
(JSC::ExecutableBase::astNode):
(JSC::ExecutableBase::generatedJITCode):
(JSC::ExecutableBase::getExecutablePool):
(JSC::EvalExecutable::EvalExecutable):
(JSC::EvalExecutable::bytecode):
(JSC::EvalExecutable::varStack):
(JSC::EvalExecutable::evalNode):
(JSC::EvalExecutable::jitCode):
(JSC::ProgramExecutable::ProgramExecutable):
(JSC::ProgramExecutable::reparseExceptionInfo):
(JSC::ProgramExecutable::bytecode):
(JSC::ProgramExecutable::programNode):
(JSC::ProgramExecutable::jitCode):
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::name):
(JSC::FunctionExecutable::bytecode):
(JSC::FunctionExecutable::generatedBytecode):
(JSC::FunctionExecutable::usesEval):
(JSC::FunctionExecutable::usesArguments):
(JSC::FunctionExecutable::parameterCount):
(JSC::FunctionExecutable::paramString):
(JSC::FunctionExecutable::isGenerated):
(JSC::FunctionExecutable::body):
(JSC::FunctionExecutable::jitCode):
(JSC::FunctionExecutable::createNativeThunk):

  • runtime/FunctionConstructor.cpp:

(JSC::constructFunction):

  • runtime/FunctionPrototype.cpp:

(JSC::functionProtoFuncToString):

  • runtime/JSActivation.cpp:

(JSC::JSActivation::JSActivation):
(JSC::JSActivation::markChildren):
(JSC::JSActivation::isDynamicScope):
(JSC::JSActivation::argumentsGetter):

  • runtime/JSActivation.h:

(JSC::JSActivation::JSActivationData::JSActivationData):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::isHostFunction):
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::~JSFunction):
(JSC::JSFunction::markChildren):
(JSC::JSFunction::getCallData):
(JSC::JSFunction::call):
(JSC::JSFunction::lengthGetter):
(JSC::JSFunction::getConstructData):
(JSC::JSFunction::construct):

  • runtime/JSFunction.h:

(JSC::JSFunction::executable):
(JSC::FunctionExecutable::make):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::numericCompareFunction):

  • runtime/JSGlobalData.h:
10:12 PM Changeset in webkit [47411] by mrowe@apple.com
  • 1 edit
    1 delete in trunk

Revert r47399 as Eric landed it in the wrong directory.

8:57 PM Changeset in webkit [47410] by Simon Fraser
  • 15 edits
    12 adds in trunk

2009-08-17 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt.

Render -webkit-mask via compositing layers when possible
​https://bugs.webkit.org/show_bug.cgi?id=28414

Implement accelerated compositing of -webkit-mask, when combined
with already-composited content.

RenderLayerBacking now creates an additional GraphicsLayer for the mask contents,
and sets this as the mask on another GraphicsLayer via the setMaskLayer() method.
GraphicsLayerCA then applies the mask using -[CALayer setMask:].

The enum values for GraphicsLayerPaintingPhase were renamed to avoid the
confusion with "mask", and a new value, GraphicsLayerPaintMask, was added which
indicates that just the mask is painting.

When painting the composited mask, we need to paint with the normal compositing
mode rather than CompositeDestinationIn, so InlineFlowBox and RenderBox now consult
layer()->hasCompositedMask() to pick the mode. If the mask is composited, they no longer
need to make transparency layers.

We no longer have to throw video rendering into software because of masks.

When a masked element has composited descendants, that element needs to
become composited so that the mask can be applied via compositing.

Tests: compositing/masks/masked-ancestor.html

compositing/masks/simple-composited-mask.html

  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::GraphicsLayer):
  • platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::maskLayer): (WebCore::GraphicsLayer::setMaskLayer): (WebCore::GraphicsLayer::paintingPhase): (WebCore::GraphicsLayer::setPaintingPhase):
  • platform/graphics/GraphicsLayerClient.h: (WebCore::):
  • platform/graphics/mac/GraphicsLayerCA.h: (WebCore::GraphicsLayerCA::):
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::setMaskLayer): (WebCore::GraphicsLayerCA::recursiveCommitChanges): (WebCore::GraphicsLayerCA::commitLayerChanges): (WebCore::GraphicsLayerCA::updateMaskLayer):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintMask):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintMaskImages):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::hasCompositedMask):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::hasCompositedMask):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::~RenderLayerBacking): (WebCore::RenderLayerBacking::destroyGraphicsLayer): (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): (WebCore::RenderLayerBacking::updateForegroundLayer): (WebCore::RenderLayerBacking::updateMaskLayer): (WebCore::RenderLayerBacking::paintingPhaseForPrimaryLayer): (WebCore::RenderLayerBacking::setContentsNeedDisplay): (WebCore::RenderLayerBacking::setContentsNeedDisplayInRect): (WebCore::RenderLayerBacking::paintIntoLayer): (WebCore::RenderLayerBacking::paintContents):
  • rendering/RenderLayerBacking.h: (WebCore::RenderLayerBacking::hasMaskLayer):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::computeCompositingRequirements): (WebCore::RenderLayerCompositor::canAccelerateVideoRendering): (WebCore::RenderLayerCompositor::requiresCompositingWhenDescendantsAreCompositing):
  • rendering/RenderLayerCompositor.h:
8:31 PM Changeset in webkit [47409] by Simon Fraser
  • 5 edits
    4 adds in trunk

2009-08-17 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt.

Layer content misplaced with compositing, z-index and overflow
​https://bugs.webkit.org/show_bug.cgi?id=28361

The foreground GraphicsLayer (used to render element foreground when the element has
negative z-order children) was misplaced when there is a clipping layer (which clips
children). The foreground layer is parented under the clipping layer so that the foreground
depth-sorts with the layer's children, so its geometry needs to be computed relative to
that clipping layer.

Also clarified some FIXME comments, and corrected a debug-only layer name.

Test: compositing/geometry/clipping-foreground.html

  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::updateSublayerList):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): (WebCore::RenderLayerBacking::updateForegroundLayer):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
7:58 PM Changeset in webkit [47408] by mrowe@apple.com
  • 3 edits in trunk/WebCore

Fix leaks of SVGElementInstance seen during regression tests.

Reviewed by Sam Weinig.

r47313 made TreeShared types start with a ref-count of 1, but SVGElementInstance was mistakenly
not updated to have a create method that adopted the initial reference. This lead to the instances
of SVGElementInstance allocated by SVGUseElement being leaked.

  • svg/SVGElementInstance.h:

(WebCore::SVGElementInstance::create):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::buildPendingResource):
(WebCore::SVGUseElement::buildInstanceTree):
(WebCore::SVGUseElement::handleDeepUseReferencing):

6:37 PM Changeset in webkit [47407] by beidson@apple.com
  • 6 edits in trunk/WebCore

Some cleanup towards ​https://bugs.webkit.org/show_bug.cgi?id=13631
Page Cache should support pages with frames.

Reviewed by Sam Weinig.

  • Re-factor all remaining page cache code out of DocumentLoader, as CachedPage/CacheFrame loads are solely the responsibility of FrameLoader.
  • Enhance some page cache related Logging to help development.
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::didCommitLoad):
(WebCore::InspectorController::identifierForInitialRequest):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::DocumentLoader):

  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::continueLoadAfterWillSubmitForm):
(WebCore::FrameLoader::loadProvisionalItemFromCachedPage):

  • loader/FrameLoader.h:

(WebCore::FrameLoader::isLoadingFromCachedPage):

6:18 PM Changeset in webkit [47406] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

2009-08-17 Brian Weinstein <​bweinstein@apple.com>

Rubber-stamped by Adele Peterson.

http/tests/misc/favicon-loads-with-images-disabled.html was passing on my machine
(when I ran all http tests), but failed on the bot, so adding it back to the
Skipped list.

  • platform/win/Skipped:
6:05 PM Changeset in webkit [47405] by mrowe@apple.com
  • 4 edits in trunk/JavaScriptCore

Fix 300,000+ leaks seen during the regression tests.

Reviewed by Darin Adler.

EvalCodeCache::get was heap-allocating an EvalExecutable instance without adopting the initial reference.
While fixing this we noticed that EvalExecutable was a RefCounted type that was sometimes stack allocated.
To make this cleaner and to prevent clients from attempting to ref a stack-allocated instance, we move the
refcounting down to a new CacheableEvalExecutable class that derives from EvalExecutable. EvalCodeCache::get
now uses CacheableEvalExecutable::create and avoids the leak.

  • bytecode/EvalCodeCache.h:

(JSC::EvalCodeCache::get):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::callEval):

  • runtime/Executable.h:

(JSC::CacheableEvalExecutable::create):
(JSC::CacheableEvalExecutable::CacheableEvalExecutable):

6:00 PM Changeset in webkit [47404] by oliver@apple.com
  • 10 edits in trunk

REGRESSION (r47292): Prototype.js is broken by ES5 Arguments changes
​https://bugs.webkit.org/show_bug.cgi?id=28341
<rdar://problem/7145615>

RS=Mark Rowe

Reverting r47292. Alas Prototype.js breaks with Arguments inheriting
from Array as ES5 attempted. Prototype.js defines $A in terms of a
function it places on (among other global objects) the Array prototype,
thus breaking $A for arrays.

5:58 PM Changeset in webkit [47403] by eric@webkit.org
  • 5 edits in trunk/WebCore

2009-08-17 Roland Steiner <​rolandsteiner@google.com>

Reviewed by Eric Seidel.

Moved implementation of isAfterContent to RenderObject
(as inline method to avoid potential performance regressions).

BUG 28376 - [Cleanup] isAfterContent() implemented twice, should be member of RenderObject
(​https://bugs.webkit.org/show_bug.cgi?id=28376)

  • rendering/RenderBox.cpp:
  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp:
  • rendering/RenderObject.h: (WebCore::RenderObject::isAfterContent):
5:49 PM Changeset in webkit [47402] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-17 Eric Seidel <​eric@webkit.org>

Reviewed by Darin Adler.

Can no longer --reset-results of a layout test directory
​https://bugs.webkit.org/show_bug.cgi?id=28336

--reset-results and --exit-after-n-failures are incompatible.

  • Scripts/run-webkit-tests:
5:40 PM Changeset in webkit [47401] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

2009-08-17 Brian Weinstein <​bweinstein@apple.com>

Rubber-stamped by Adele Peterson.

http/tests/misc/favicon-loads-with-images-disabled.html is passing on my
machine, trying to remove it from the Skipped list on Windows.

  • platform/win/Skipped:
5:24 PM Changeset in webkit [47400] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2009-08-17 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Darin Adler.

Assertion failure in WebCore::RenderHTMLCanvas::layout
​https://bugs.webkit.org/show_bug.cgi?id=12052

Don't handle run-in if the element is not a block element.

  • fast/runin/canvas-runin-expected.txt: Added.
  • fast/runin/canvas-runin.html: Added.

2009-08-17 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Darin Adler.

Assertion failure in WebCore::RenderHTMLCanvas::layout
​https://bugs.webkit.org/show_bug.cgi?id=12052

Don't handle run-in if the element is not a block element.

Test: fast/runin/nonblock-runin.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::handleRunInChild):
5:16 PM Changeset in webkit [47399] by eric@webkit.org
  • 1 edit
    6 adds in trunk

2009-08-17 Christian Plesner Hansen <​christian.plesner.hansen@gmail.com>

Reviewed by Darin Adler.

Regression test for bug fixed in
​http://codereview.chromium.org/171039. Regexps created in one
frame were not callable outside that frame.
​https://bugs.webkit.org/show_bug.cgi?id=28387

  • fast/regex/regexp-cross-frame-callable-expected.txt: Added.
  • fast/regex/regexp-cross-frame-callable.html: Added.
  • fast/regex/resources/regexp-cross-frame-callable-child.html: Added.
5:05 PM Changeset in webkit [47398] by eric@webkit.org
  • 5 edits
    3 adds in trunk

2009-08-17 Benjamin C Meyer <​benjamin.meyer@torchmobile.com>

Reviewed by Darin Adler.

Fix createImageData to raise the NOT_SUPPORTED_ERR exception when
either of the arguments are not finite.

According to
​http://www.whatwg.org/specs/web-apps/current-work/#pixel-manipulation:
"If any of the arguments to createImageData() or getImageData() are
infinite or NaN, or if the createImageData() method is invoked with
only one argument but that argument is null, the method must instead
raise a NOT_SUPPORTED_ERR exception."

Test: ​http://philip.html5.org/tests/canvas/suite/tests/2d.imageData.create.nonfinite.html

  • fast/canvas/canvas-2d-imageData-create-nonfinite-expected.txt: Added.
  • fast/canvas/canvas-2d-imageData-create-nonfinite.html: Added.
  • fast/canvas/resources/canvas-2d-imageData-create-nonfinite.js: Added.

2009-08-17 Benjamin C Meyer <​benjamin.meyer@torchmobile.com>

Reviewed by Darin Adler.

Fix createImageData to raise the NOT_SUPPORTED_ERR exception when
either of the arguments are not finite.

According to
​http://www.whatwg.org/specs/web-apps/current-work/#pixel-manipulation:
"If any of the arguments to createImageData() or getImageData() are
infinite or NaN, or if the createImageData() method is invoked with
only one argument but that argument is null, the method must instead
raise a NOT_SUPPORTED_ERR exception."

Test: ​http://philip.html5.org/tests/canvas/suite/tests/2d.imageData.create.nonfinite.html

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createImageData):
  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/CanvasRenderingContext2D.idl:
4:28 PM Changeset in webkit [47397] by jorlow@chromium.org
  • 11 edits in trunk

2009-08-17 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Fisher.

Add a way to release the storage lock
​https://bugs.webkit.org/show_bug.cgi?id=28411

Two scripts within the same origin that are accessing LocalStorage must not do
it simultaneously, according to the spec. There are some cases, however, where
a script might want to override this behavior. navigator.getStorageUpdates()
was added for this reason:
​http://dev.w3.org/html5/spec/Overview.html#manually-releasing-the-storage-mutex

Add this function to navigator and hook it up to DOM Storage.

  • page/Navigator.cpp: (WebCore::Navigator::getStorageUpdates):
  • page/Navigator.h:
  • page/Navigator.idl:
  • storage/StorageNamespace.h:
  • storage/StorageNamespaceImpl.cpp: (WebCore::StorageNamespaceImpl::unlock):
  • storage/StorageNamespaceImpl.h:

2009-08-17 Jeremy Orlow <​jorlow@chromium.org>

Reviewed by Darin Fisher.

Add a way to release the storage lock
​https://bugs.webkit.org/show_bug.cgi?id=28411

Two scripts within the same origin that are accessing LocalStorage must not do
it simultaneously, according to the spec. There are some cases, however, where
a script might want to override this behavior. navigator.getStorageUpdates()
was added for this reason:
​http://dev.w3.org/html5/spec/Overview.html#manually-releasing-the-storage-mutex

Update the test expectations to include this new element.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/navigator-detached-no-crash-expected.txt:
  • platform/mac-leopard/fast/dom/navigator-detached-no-crash-expected.txt:
4:11 PM Changeset in webkit [47396] by mrowe@apple.com
  • 3 edits in trunk/WebCore

Build fix.

CFNetwork isn't present in the framework search path on Mac OS X so we can't directly include its headers.
We include CoreServices.h, the umbrella framework that contains CFNetwork, from the prefix header which
results in the CFNetwork headers being included on Mac OS X. CoreServices.h doesn't include CFNetwork.h on
Windows though so we explicitly include this header from the prefix header when on Windows.

  • WebCorePrefix.h:
  • platform/network/cf/DNSCFNet.cpp: Remove #include that is no longer needed.
3:48 PM Changeset in webkit [47395] by ap@apple.com
  • 2 edits in trunk/WebCore

Trying a better build fix (the previous one broke Leopard bots, although it did build for me).

  • platform/network/cf/DNSCFNet.cpp: Include CFNetwork/CFNetwork.h instead.
3:30 PM Changeset in webkit [47394] by ap@apple.com
  • 2 edits in trunk/WebCore

Trying to fix Windows build.

  • platform/network/cf/DNSCFNet.cpp: Include CFNetwork/CFHost.h.
3:17 PM Changeset in webkit [47393] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

<​http://webkit.org/b/26920> bugzilla-tool dumps too much junk the the commit comment from git

Reviewed by Adam Roben.

New commit message:

Committed r12345: <​http://trac.webkit.org/changeset/12345>

  • Scripts/bugzilla-tool: (bug_comment_from_commit_text): Print out a compact, standardized commit message for both git and svn.
3:12 PM Changeset in webkit [47392] by pkasting@chromium.org
  • 19 edits in trunk

JavaScriptCore: ​https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there. This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.

Reviewed by Steve Falkenburg.

WebCore: ​https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there. This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.

Reviewed by Steve Falkenburg.

  • WebCore.vcproj/QTMovieWin.vcproj:
  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.vcproj/WebCoreGenerated.vcproj:

WebKit/win: ​https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there. This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.

Reviewed by Steve Falkenburg.

  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/InterfacesGenerated.vcproj:
  • WebKit.vcproj/WebKit.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:

WebKitTools: ​https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there. This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.

Reviewed by Steve Falkenburg.

  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/ImageDiff.vcproj:
  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3:08 PM Changeset in webkit [47391] by ap@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Geoff Garen.

​https://bugs.webkit.org/show_bug.cgi?id=28401
Add support for DNS prefetching with CFNetwork

This is just an optimization, no behavior change, so no tests.

  • platform/network/cf/DNSCFNet.cpp: (WebCore::clientCallback): (WebCore::prefetchDNS): Use async CFHostStartInfoResolution() for implementation.
2:48 PM Changeset in webkit [47390] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-17 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Unreviewed. Skip new tests.

  • platform/gtk/Skipped:
2:14 PM Changeset in webkit [47389] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=28403
Update Apache2 module list from Leopard defaults

No change in functionality, only commented out modules needed an update.

  • http/conf/apache2-httpd.conf:
1:54 PM WikiStart edited by Dimitri Glazkov
Linked to Chromium port page (diff)
1:43 PM Changeset in webkit [47388] by eric@webkit.org
  • 11 edits
    2 adds in trunk

2009-08-17 Aaron Boodman <​aa@chromium.org>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=28313: Combine ThreadableLoaderOptions::crossOriginRequestPolicy and
ThreadableLoaderOptions::crossOriginRedirectPolicy since they are always set the same way.

Also, tightened up behavior of XMLHttpRequest with cross-origin redirects and access control. We have not implemented redirects
for access control, so we should never redirect across origins. But in two edge cases, we were:

  • Asynchronous XHR: Script on origin A requests resource from origin B. Server redirects (without sending access control authorization headers) to a resource on origin A.
  • Synchronous XHR: Script on origin A requests resource from origin B. Server redirects (without sending access control authorization headers) to another resource on origin B (this time sending access control authorization headers).
  • http/tests/xmlhttprequest/access-control-and-redirects-expected.txt: Added.
  • http/tests/xmlhttprequest/access-control-and-redirects.html: Added.

2009-08-17 Aaron Boodman <​aa@chromium.org>

Reviewed by Alexey Proskuryakov.

​https://bugs.webkit.org/show_bug.cgi?id=28313: Combine ThreadableLoaderOptions::crossOriginRequestPolicy and
ThreadableLoaderOptions::crossOriginRedirectPolicy since they are always set the same way.

Also, tightened up behavior of XMLHttpRequest with cross-origin redirects and access control. We have not implemented
redirects access control, so we should never redirect across origins. But in two edge cases, we were:

  • Asynchronous XHR: Script on origin A requests resource from origin B. Server redirects (without sending access control authorization headers) to a resource on origin A.
  • Synchronous XHR: Script on origin A requests resource from origin B. Server redirects (without sending access control authorization headers) to another resource on origin B (this time sending access control authorization headers).

Test: http/tests/xmlhttprequest/access-control-and-redirects.html

  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::willSendRequest): Refactor redirect checking code into shared location. (WebCore::DocumentThreadableLoader::loadRequest): Ditto. (WebCore::DocumentThreadableLoader::isAllowedRedirect): Ditto.
  • loader/DocumentThreadableLoader.h:
  • loader/ThreadableLoader.h: (WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions): Remove ThreadableLoaderOptions::crossOriginRedirectPolicy.
  • page/EventSource.cpp: (WebCore::EventSource::connect): Ditto.
  • workers/Worker.cpp: Ditto. (WebCore::Worker::Worker): Ditto.
  • workers/WorkerContext.cpp: Ditto. (WebCore::WorkerContext::importScripts): Ditto.
  • workers/WorkerScriptLoader.cpp: (WebCore::WorkerScriptLoader::loadSynchronously): Ditto. (WebCore::WorkerScriptLoader::loadAsynchronously): Ditto.
  • workers/WorkerScriptLoader.h:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::createRequest): Ditto.
1:41 PM Changeset in webkit [47387] by Darin Adler
  • 2 edits in trunk/WebKit/qt

Try to fix Qt build again.

Patch by Darin Adler <Darin Adler> on 2009-08-17

  • WebCoreSupport/EditorClientQt.cpp: Move "using namespace".
1:36 PM Changeset in webkit [47386] by agl@chromium.org
  • 2 edits in trunk/WebCore

2009-08-17 Adam Langley <​agl@google.com>

Reviewed by Dan Bernstein (relanding of r47157).

Fix a typo in platform/graphics/skia/PlatformContextSkia.cpp

​https://bugs.webkit.org/show_bug.cgi?id=28172

This was originally fixed in r47157, however it triggered a bug in
Skia which caused Chromium Linux to fail layout tests in debug mode.
It was reverted in r47189 while we sorted it out.

The Skia bug was fixed in Skia's r321 [1] and rolled into Chromium in
Chromium's r23523. This is a reland of the original patch.

No new tests because it's a just typo fix.

[1] ​http://code.google.com/p/skia/source/detail?r=321

  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::setupPaintCommon):
1:33 PM Changeset in webkit [47385] by ddkilzer@apple.com
  • 3 edits in trunk/WebKitTools

<​http://webkit.org/b/28393> check-webkit-style: add check for use of std::max()/std::min() instead of MAX()/MIN()

Reviewed by David Levin.

  • Scripts/modules/cpp_style.py: (_ERROR_CATEGORIES): Added 'runtime/max_min_macros'. (check_max_min_macros): Added. Returns level 4 error when MAX() and MIN() macros are used in header files and C++ source files. (check_style): Added call to check_max_min_macros().
  • Scripts/modules/cpp_style_unittest.py: Added unit tests. (test_max_macro): Added. (test_min_macro): Added.
1:29 PM Changeset in webkit [47384] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-08-17 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Protect ResourceHandle for g_file_query_info_async call, using the
same technique we already use for HTTP requests that take the soup
path.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::finishedCallback): (WebCore::):
1:21 PM Changeset in webkit [47383] by mitz@apple.com
  • 2 edits in trunk/WebCore

REGRESSION (r47255): MediaWiki's (including Wikipedia) navigation pane
appears below the main content
​https://bugs.webkit.org/show_bug.cgi?id=28350

Reviewed by Darin Adler.

A particular version of the MediaWiki software detects WebKit through
user agent sniffing and imports a style sheet called KHTMLFixes.css,
which contains a single rule that was meant to work around some KHTML
bug, but currently has the sole effect of causing the float containing
the main article content to extend all the way to the left and thus push
down the left navigation pane.

  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::setCSSStyleSheet): If site specific hacks are
enabled, check if the imported style sheet is the MediaWiki
KHTMLFixes.css. If so, remove the offending rule.

1:20 PM Changeset in webkit [47382] by xan@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-17 Xan Lopez <​xlopez@igalia.com>

Reviewed by Mark Rowe.

Fix build with FAST_MALLOC_MATCH_VALIDATION enabled.

  • wtf/FastMalloc.cpp: (WTF::fastMalloc): (WTF::fastCalloc): (WTF::fastRealloc):
1:11 PM Changeset in webkit [47381] by yong.li@torchmobile.com
  • 5 edits
    1 add in trunk/WebCore/platform

2009-08-17 Yong Li <​yong.li@torchmobile.com>

Reviewed by Adam Treat.

Allow image decoders to down-sample the image directly
to scaled output buffer. This can be enabled/disabled by
macro ENABLE(IMAGE_DECODER_DOWN_SAMPLING).
Only JPEG and PNG decoders are modified to support it now.
​https://bugs.webkit.org/show_bug.cgi?id=28308

  • platform/graphics/ImageSource.cpp: (WebCore::ImageSource::setData):
  • platform/image-decoders/ImageDecoder.cpp: Added.
  • platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::ImageDecoder): (WebCore::ImageDecoder::setMaxNumPixels):
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::convertCMYKToRGBA): (WebCore::convertRGBToRGBA): (WebCore::JPEGImageDecoder::outputScanlines):
  • platform/image-decoders/jpeg/JPEGImageDecoder.h: (WebCore::JPEGImageDecoder::setSize):
  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::headerAvailable): (WebCore::PNGImageDecoder::rowAvailable):
12:56 PM Changeset in webkit [47380] by Darin Adler
  • 2 edits in trunk/WebKit/qt

Try to fix Qt build.

Patch by Darin Adler <Darin Adler> on 2009-08-17

  • WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::shouldShowDeleteInterface):
Use getAttribute(classAttr) instead of className() function.

12:47 PM Changeset in webkit [47379] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

Correct crash when processing local cancelled requests.

Reviewed by Kevin Ollivier.

No new tests. Existing fast/images/favicon-as-image.html
displays the problem.

  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::writeCallback): Add check for m_cancelled after

performing local-file processing.

(WebCore::ResourceHandleManager::downloadTimerCallback): Add

check for m_cancelled after performing local-file processing.

12:27 PM Changeset in webkit [47378] by kov@webkit.org
  • 6 edits
    1 delete in trunk/WebCore

2009-08-17 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Unreviewed. Reverts 47371, since it breaks GTK+.

  • platform/graphics/ImageSource.cpp: (WebCore::ImageSource::setData):
  • platform/image-decoders/ImageDecoder.cpp: Removed.
  • platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::ImageDecoder):
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::convertCMYKToRGBA): (WebCore::convertRGBToRGBA): (WebCore::JPEGImageDecoder::outputScanlines):
  • platform/image-decoders/jpeg/JPEGImageDecoder.h:
  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::headerAvailable): (WebCore::PNGImageDecoder::rowAvailable):
12:07 PM Changeset in webkit [47377] by sfalken@apple.com
  • 1 copy in tags/Safari-6531.11

New tag.

12:04 PM Changeset in webkit [47376] by Simon Fraser
  • 2 edits in trunk/WebKit/win

2009-08-17 Simon Fraser <Simon Fraser>

Speculative fix for Windows build bustage.

  • DOMHTMLClasses.cpp: (DOMHTMLElement::idName):
12:00 PM Changeset in webkit [47375] by sfalken@apple.com
  • 11 edits in branches/safari-4-branch/WebKitTools

Merge r47320.

11:51 AM Changeset in webkit [47374] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-08-17 Simon Fraser <Simon Fraser>

Build fix: fix float literals to avoid casting warnings.

  • rendering/MediaControlElements.cpp:
11:50 AM Changeset in webkit [47373] by sfalken@apple.com
  • 7 edits
    2 copies in branches/safari-4-branch

Merge r47312.

11:43 AM Changeset in webkit [47372] by sfalken@apple.com
  • 9 edits in branches/safari-4-branch

Merge r47311.

11:37 AM Changeset in webkit [47371] by yong.li@torchmobile.com
  • 6 edits
    1 add in trunk/WebCore

2009-08-17 Yong Li <​yong.li@torchmobile.com>

Reviewed by Adam Treat.

Allow image decoders to down-sample the image directly
to scaled output buffer. This can be enabled/disabled by
macro ENABLE(IMAGE_DECODER_DOWN_SAMPLING).
Only JPEG and PNG decoders are modified to support it now.
​https://bugs.webkit.org/show_bug.cgi?id=28308

  • platform/graphics/ImageSource.cpp: (WebCore::ImageSource::setData):
  • platform/image-decoders/ImageDecoder.cpp: Added.
  • platform/image-decoders/ImageDecoder.h: (WebCore::ImageDecoder::ImageDecoder): (WebCore::ImageDecoder::setMaxNumPixels):
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::convertCMYKToRGBA): (WebCore::convertRGBToRGBA): (WebCore::JPEGImageDecoder::outputScanlines):
  • platform/image-decoders/jpeg/JPEGImageDecoder.h: (WebCore::JPEGImageDecoder::setSize):
  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::headerAvailable): (WebCore::PNGImageDecoder::rowAvailable):
11:29 AM Changeset in webkit [47370] by Simon Fraser
  • 7 edits in trunk/WebCore

2009-08-17 Simon Fraser <Simon Fraser>

Reviewed by Eric Seidel.

Use OwnPtrs for GraphicsLayers
​https://bugs.webkit.org/show_bug.cgi?id=28399

Convert RenderLayerBacking and RenderLayerCompositor to use OwnPtrs
for their references to GraphicsLayers.

  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayer::create):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::RenderLayerBacking): (WebCore::RenderLayerBacking::createGraphicsLayer): (WebCore::RenderLayerBacking::destroyGraphicsLayer): (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): (WebCore::RenderLayerBacking::updateInternalHierarchy): (WebCore::RenderLayerBacking::updateClippingLayers): (WebCore::RenderLayerBacking::updateForegroundLayer): (WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
  • rendering/RenderLayerBacking.h: (WebCore::RenderLayerBacking::graphicsLayer): (WebCore::RenderLayerBacking::clippingLayer): (WebCore::RenderLayerBacking::ancestorClippingLayer): (WebCore::RenderLayerBacking::foregroundLayer): (WebCore::RenderLayerBacking::parentForSublayers): (WebCore::RenderLayerBacking::childForSuperlayers):
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::~RenderLayerCompositor): (WebCore::RenderLayerCompositor::rootPlatformLayer): (WebCore::RenderLayerCompositor::didMoveOnscreen): (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): (WebCore::RenderLayerCompositor::destroyRootPlatformLayer):
  • rendering/RenderLayerCompositor.h:
10:44 AM Changeset in webkit [47369] by pfeldman@chromium.org
  • 6 edits in trunk/WebCore

2009-08-17 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Reset InjectedScript styles cache on document change.

​https://bugs.webkit.org/show_bug.cgi?id=28390

  • inspector/InspectorController.cpp: (WebCore::InspectorController::close): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::resetInjectedScript):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setDocument):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/InjectedScript.js: (InjectedScript._reset):
10:41 AM Changeset in webkit [47368] by Darin Adler
  • 2 edits in trunk/WebCore
  • rendering/MediaControlElements.cpp: Removed unneeded include of CString.h,

resorted includes, renamed "doc" to "document" and fixed formatting.

Reviewed by Sam Weinig.

10:30 AM Changeset in webkit [47367] by Darin Adler
  • 12 edits in trunk/WebCore

Removed functions now unneeded due to use of Reflect to create
language bindings.

Patch by Darin Adler <Darin Adler> on 2009-08-17
Reviewed by Sam Weinig.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityParentForImageMap):
Get at usemap attribute directly.

  • editing/DeleteButtonController.cpp:

(WebCore::DeleteButtonController::createDeletionUI):
Get at id attribute directly.

  • editing/EditorCommand.cpp:

(WebCore::executeInsertHorizontalRule): Ditto.

  • html/HTMLDocument.cpp:

(WebCore::HTMLDocument::dir): Get at dir attribute of body directly.
(WebCore::HTMLDocument::setDir): Ditto.

  • html/HTMLElement.cpp: Deleted unused functions.
  • html/HTMLElement.h: Ditto.
  • html/HTMLImageElement.cpp: Deleted unused functions.

(WebCore::HTMLImageElement::alt): Changed to return const AtomicString&.
(WebCore::HTMLImageElement::addSubresourceAttributeURLs): Changed to
get at usemap attribute directly, but added a FIXME because although
it is what the old code did, it looks to not be entirely correct.

  • html/HTMLImageElement.h: Deleted unused functions.
  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::altDisplayString): Get at alt attribute directly.

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::imageMap): Get at usemap attribute directly.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::createGraphicsLayer): Get at id attribute
directly.
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer): Removed
explicit HTMLNames namespace qualification.

10:12 AM Changeset in webkit [47366] by Darin Adler
  • 2 edits in trunk/WebKit/mac

Use a HashMap instead of a list of if statements for the command
name exception map.

Patch by Darin Adler <Darin Adler> on 2009-08-17
Reviewed by Sam Weinig.

  • WebView/WebHTMLView.mm:

(createSelectorExceptionMap): Added.
(commandNameForSelector): Use createSelectorExceptionMap.

10:03 AM Changeset in webkit [47365] by Darin Adler
  • 2 edits in trunk/WebCore
  • dom/Document.cpp:

(WebCore::Document::setFocusedNode): Removed unneeded calls
to RefPtr::get.

Reviewed by Sam Weinig.

9:24 AM Changeset in webkit [47364] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2009-08-17 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Discard DOM Node bindings on any document change.

​https://bugs.webkit.org/show_bug.cgi?id=28389

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setDocument):
8:57 AM Changeset in webkit [47363] by ariya@webkit.org
  • 23 edits
    1 delete in trunk/WebCore

2009-08-13 Joseph Pecoraro <​joepeck02@gmail.com>

Reviewed by Timothy Hatcher.

Inspector: Improve Cookie DataGrid to Show Hidden Data
​https://bugs.webkit.org/show_bug.cgi?id=28269

  • English.lproj/localizedStrings.js: DataGrid Headers "Name", "Value", "Size", ...
  • WebCore.gypi: added missing files

Implemented Bindings for InspectorController.deleteCookie(name)

  • inspector/InspectorBackend.idl:
  • bindings/js/JSInspectorBackendCustom.cpp: (WebCore::JSInspectorBackend::cookies): (WebCore::JSInspectorBackend::deleteCookie):

v8 Bindings Stubs

  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8InspectorBackendCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):

Removed WebInspector.Cookie

  • inspector/front-end/Cookie.js: Removed.
  • inspector/front-end/inspector.html:
  • inspector/front-end/WebKit.qrc:

Improved DataGrid and Kept Fallback Behavior for Platforms that don't
yet provide access to raw cookies.

  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView): (WebInspector.CookieItemsView.prototype.get statusBarItems): (WebInspector.CookieItemsView.prototype.update): (WebInspector.CookieItemsView.prototype.buildCookies): (WebInspector.CookieItemsView.prototype.dataGridForCookies): (WebInspector.CookieItemsView.prototype.fallbackUpdate.callback): (WebInspector.CookieItemsView.prototype.fallbackUpdate): (WebInspector.CookieItemsView.prototype.fallbackBuildCookiesFromString): (WebInspector.CookieItemsView.prototype.fallbackDataGridForCookies): (WebInspector.CookieItemsView.prototype._deleteButtonClicked):

Interaction with the page through Injected Script (for fallback behavior)

  • inspector/front-end/DOMAgent.js: (InspectorController.getCookies):
  • inspector/front-end/InjectedScript.js: (InjectedScript.setStyleProperty): style fix (InjectedScript.getCookies):

Allow alignment of text inside DataGrids.

  • inspector/front-end/DataGrid.js: (WebInspector.DataGrid): (WebInspector.DataGridNode.prototype.createCell):
  • inspector/front-end/DatabasesPanel.js: (WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage):
  • inspector/front-end/inspector.css:

Added deleteCookie(., ., String name)
Modified getRawCookies to return a bool to know if its implemented

  • platform/CookieJar.h:

Implemented deleteCookie for Macs

  • platform/mac/CookieJar.mm: (WebCore::getRawCookies): (WebCore::deleteCookie):

Stub Implementations for Other Platforms

  • platform/haiku/CookieJarHaiku.cpp: (WebCore::getRawCookies): (WebCore::deleteCookie):
  • platform/network/chromium/CookieJarChromium.cpp: (WebCore::getRawCookies): (WebCore::deleteCookie):
  • platform/network/curl/CookieJarCurl.cpp: (WebCore::getRawCookies): (WebCore::deleteCookie):
  • platform/network/soup/CookieJarSoup.cpp: (WebCore::getRawCookies): (WebCore::deleteCookie):
  • platform/network/win/CookieJarCFNetWin.cpp: (WebCore::getRawCookies): (WebCore::deleteCookie):
  • platform/network/win/CookieJarWin.cpp: (WebCore::getRawCookies): (WebCore::deleteCookie):
  • platform/qt/CookieJarQt.cpp: (WebCore::getRawCookies): (WebCore::deleteCookie):
8:37 AM Changeset in webkit [47362] by treat@webkit.org
  • 2 edits in trunk/WebCore

Blind build fix for Leopard.

Patch by Adam Treat <​adam.treat@torchmobile.com> on 2009-08-17

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::adjustLineToPixelBoundaries):

8:07 AM Changeset in webkit [47361] by treat@webkit.org
  • 5 edits in trunk

Move adjustLineToPixelBoundaries overlapping function to GraphicsContext.cpp
and remove from GraphicsContextCairo.cpp and GraphicsContextQt.cpp.

Patch by Mike Fenton <​mike.fenton@torchmobile.com> on 2009-08-13
Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=28268

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::adjustLineToPixelBoundaries):

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:
  • platform/graphics/qt/GraphicsContextQt.cpp:
7:19 AM Changeset in webkit [47360] by treat@webkit.org
  • 2 edits in trunk/WebCore

Style fixes based on cpp_style.py and WebKit Style guide for
GraphicsContextCG.cpp

Patch by Mike Fenton <​mike.fenton@torchmobile.com> on 2009-08-13
Reviewed by Adam Treat.

​https://bugs.webkit.org/show_bug.cgi?id=28268

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::strokeArc):
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::applyStrokePattern):
(WebCore::GraphicsContext::drawPath):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipOutEllipseInRect):
(WebCore::GraphicsContext::addInnerRoundedRectClip):
(WebCore::GraphicsContext::clipToImageBuffer):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::setLineCap):
(WebCore::GraphicsContext::setLineJoin):
(WebCore::GraphicsContext::roundToDevicePixels):
(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::setURLForRect):
(WebCore::GraphicsContext::setImageInterpolationQuality):
(WebCore::GraphicsContext::imageInterpolationQuality):
(WebCore::GraphicsContext::setPlatformTextDrawingMode):
(WebCore::GraphicsContext::setCompositeOperation):

7:01 AM Changeset in webkit [47359] by treat@webkit.org
  • 5 edits in trunk/WebCore

Style fixes based on cpp_style.py and WebKit Style guide for
GraphicsContext.cpp/h, GraphicsContextCairo.cpp and GraphicsContextQt.cpp.

Patch by Mike Fenton <​mike.fenton@torchmobile.com> on 2009-08-13
Reviewed by Adam Treat.

​https://bugs.webkit.org/show_bug.cgi?id=28268

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::save):
(WebCore::GraphicsContext::restore):
(GraphicsContext::drawText):
(GraphicsContext::initFocusRing):
(GraphicsContext::focusRingBoundingRect):
(GraphicsContext::drawImage):

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::strokeArc):
(WebCore::GraphicsContext::setLineCap):
(WebCore::GraphicsContext::setLineJoin):
(WebCore::toCairoOperator):

  • platform/graphics/qt/GraphicsContextQt.cpp:
6:51 AM Changeset in webkit [47358] by treat@webkit.org
  • 2 edits in trunk/WebKitTools

Style fixes for DumpRenderTree/qt/jsobjects.cpp based on cpp_style.py and
WebKit style guide.

Patch by Mike Fenton <​mike.fenton@torchmobile.com> on 2009-08-10
Reviewed by Adam Treat.

​https://bugs.webkit.org/show_bug.cgi?id=28161

  • DumpRenderTree/qt/jsobjects.cpp:

(findFrameNamed):
(LoadItem::invoke):
(LayoutTestController::provisionalLoad):
(LayoutTestController::timerEvent):
(LayoutTestController::pauseAnimationAtTimeOnElementWithId):
(LayoutTestController::pauseTransitionAtTimeOnElementWithId):
(LayoutTestController::numberOfActiveAnimations):
(EventSender::keyDown):
(EventSender::frameUnderMouse):
(TextInputController::doCommand):

3:38 AM Writing Layout Tests for DumpRenderTree edited by cam@mcc.id.au
make-js-test-wrappers renamed to make-script-test-wrappers (diff)
12:43 AM Changeset in webkit [47357] by Darin Adler
  • 3 edits in trunk/WebCore

Change HTMLAreaElement to use OwnArrayPtr
​https://bugs.webkit.org/show_bug.cgi?id=28386

Patch by Darin Adler <Darin Adler> on 2009-08-17
Reviewed by Dan Bernstein.

  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::HTMLAreaElement): Removed unneeded initializer.
(WebCore::HTMLAreaElement::~HTMLAreaElement): Removed unneeded delete call.
(WebCore::HTMLAreaElement::parseMappedAttribute): Use the set function
instead of deletion followed by assignment.

  • html/HTMLAreaElement.h: Use OwnArrayPtr.
12:41 AM Changeset in webkit [47356] by Darin Adler
  • 2 edits in trunk/WebCore

Fix Windows build.

Patch by Darin Adler <Darin Adler> on 2009-08-17

  • dom/make_names.pl: Add back cast to (void*) needed on Windows.
12:38 AM Changeset in webkit [47355] by Darin Adler
  • 5 edits in trunk/WebCore

Move noResize from HTMLFrameElementBase to HTMLFrameElement
​https://bugs.webkit.org/show_bug.cgi?id=28384

Patch by Darin Adler <Darin Adler> on 2009-08-17
Reviewed by Dan Bernstein.

  • html/HTMLFrameElement.cpp:

(WebCore::HTMLFrameElement::HTMLFrameElement): Initialize m_noResize.
(WebCore::HTMLFrameElement::parseMappedAttribute): Set m_noResize to true
here if noresizeAttr is changed. This code was moved here from
HTMLFrameElementBase, but I added some FIXME comments.
(WebCore::HTMLFrameElement::setNoResize): Set the attribute based on
boolean argument. Moved here from HTMLFrameElementBase.

  • html/HTMLFrameElement.h: Moved noResize, setNoResize, and m_noResize

here from HTMLFrameElementBase.

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::HTMLFrameElementBase): Removed m_noResize.
(WebCore::HTMLFrameElementBase::parseMappedAttribute): Removed code to parse
noresizeAttr.

  • html/HTMLFrameElementBase.h: Removed noResize, setNoResize, and m_noResize.
12:35 AM Changeset in webkit [47354] by Darin Adler
  • 5 edits in trunk/WebCore

Tweak HTMLFrameElementBase so that m_URL can be private
​https://bugs.webkit.org/show_bug.cgi?id=28385

Patch by Darin Adler <Darin Adler> on 2009-08-17
Reviewed by Dan Bernstein.

  • html/HTMLFrameElement.cpp:

(WebCore::HTMLFrameElement::rendererIsNeeded): Removed m_URL argument.

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::isURLAllowed): Use m_URL instead of
taking an argument.
(WebCore::HTMLFrameElementBase::openURL): Removed m_URL argument.

  • html/HTMLFrameElementBase.h: Removed argument from isURLAllowed function.
  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::rendererIsNeeded): Removed m_URL argument.

12:14 AM Changeset in webkit [47353] by Darin Adler
  • 3 edits in trunk/WebCore

HTMLViewSourceDocument should use smart pointers
​https://bugs.webkit.org/show_bug.cgi?id=28378

Patch by Darin Adler <Darin Adler> on 2009-08-17
Reviewed by Dan Bernstein.

  • html/HTMLViewSourceDocument.cpp:

(WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument): Don't initialize
pointers any more since RefPtr starts 0 by default.
(WebCore::HTMLViewSourceDocument::createContainingTable): Use more specific
types for local variables.
(WebCore::HTMLViewSourceDocument::addSpanWithClassName): Return a PassRefPtr,
and use a RefPtr of a more specific type for a local variable.
(WebCore::HTMLViewSourceDocument::addLine): Use more specific types for local
variables, and use RefPtr as well.
(WebCore::HTMLViewSourceDocument::addLink): Return a PassRefPtr, and use a
RefPtr of a more specific type for a local variable.

  • html/HTMLViewSourceDocument.h: Change return types to PassRefPtr and

data member types to RefPtr.

12:12 AM Changeset in webkit [47352] by Darin Adler
  • 5 edits in trunk/WebCore

DOM attribute getter/setter functions should use const AtomicString& type
​https://bugs.webkit.org/show_bug.cgi?id=25425

Patch by Darin Adler <Darin Adler> on 2009-08-17
Reviewed by Sam Weinig.

Convert 4 more classes. These are classes I am going to make other changes
to soon, so it's good to have this use of Reflect in the IDL out of the way.

  • html/HTMLEmbedElement.idl: Use Reflect for many attributes.
  • html/HTMLFrameElement.idl: Ditto.
  • html/HTMLIFrameElement.idl: Ditto.
  • html/HTMLObjectElement.idl: Ditto.
12:09 AM Changeset in webkit [47351] by Darin Adler
  • 2 edits in trunk/WebCore

Script to create element factory needs changes to accommodate calling create
​https://bugs.webkit.org/show_bug.cgi?id=28379

Patch by Darin Adler <Darin Adler> on 2009-08-17
Reviewed by Sam Weinig.

  • dom/make_names.pl: Tweak formatting. Remove lots of unneeded quotes

around names used inside {}. Added new createWithNew property for tags
that makes the factory use a create function instead of calling new.
Renamed functions with initialize in their name to have default in their
name, since they return an array full of default values and don't themselves
initialize anything.

Aug 16, 2009:

10:26 PM Changeset in webkit [47350] by Darin Adler
  • 2 edits in trunk/WebCore

StyledElement should use ASCIICType instead of having its own toHex function
​https://bugs.webkit.org/show_bug.cgi?id=28377

Patch by Darin Adler <Darin Adler> on 2009-08-16
Reviewed by Dan Bernstein.

  • dom/StyledElement.cpp:

(WebCore::StyledElement::addCSSColor): Use isASCIIHexDigit and toASCIIHexValue.

10:24 PM Changeset in webkit [47349] by ddkilzer@apple.com
  • 2 edits in trunk/WebKit/mac

<​http://webkit.org/b/28366> WebHTMLViewInternal.h: add @class CALayer declaration

Reviewed by Simon Fraser.

Without WebKitPrefix.h, the missing @class CALayer declaration
causes a compile-time error.

  • WebView/WebHTMLViewInternal.h: Added @class CALayer declaration with USE(ACCELERATED_COMPOSITING).
10:24 PM Changeset in webkit [47348] by Darin Adler
  • 5 edits in trunk

WebCore: execCommand("InsertHorizontalRule") inserts a broken <hr> element
​https://bugs.webkit.org/show_bug.cgi?id=28375

Patch by Darin Adler <Darin Adler> on 2009-08-16
Reviewed by Dan Bernstein.

  • editing/EditorCommand.cpp:

(WebCore::executeInsertHorizontalRule): Create an HTMLHRElement
instead of just an HTMLElement.

LayoutTests: execCommand("InsertHorizontalRule") inserts a broken <hr> element
​https://bugs.webkit.org/show_bug.cgi?id=28375

Patch by Darin Adler <Darin Adler> on 2009-08-16
Reviewed by Dan Bernstein.

  • editing/execCommand/arguments-combinations-expected.txt: Updated.
  • editing/execCommand/arguments-combinations.html: Updated to expect

the <hr> element to be self-closing rather than having a separate
</hr> in the markup.

5:45 PM Changeset in webkit [47347] by Nikolas Zimmermann
  • 7 edits
    4 adds in trunk

2009-08-16 Nikolas Zimmermann <​nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] <option> element & 'onpick' events - history navigation is broken
​https://bugs.webkit.org/show_bug.cgi?id=28371

After selecting an option element with an 'onpick' event associated with a 'go' task,
the navigation is executed. When going back in history, the same 'onpick' event is fired
again. Fix that problem, add wml/option-element-onpick-recursion.html covering the bug.

Test: wml/option-element-onpick-recursion.html

  • wml/WMLOptionElement.cpp: (WebCore::WMLOptionElement::handleIntrinsicEventIfNeeded):
  • wml/WMLSelectElement.cpp: (WebCore::WMLSelectElement::WMLSelectElement): (WebCore::WMLSelectElement::selectInitialOptions):
  • wml/WMLSelectElement.h: (WebCore::WMLSelectElement::initialized):

2009-08-16 Nikolas Zimmermann <​nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] <option> element & 'onpick' events - history navigation is broken
​https://bugs.webkit.org/show_bug.cgi?id=28371

Add new test covering history navigation & 'onpick' event handling.

  • wml/option-element-onpick-recursion-expected.txt: Added.
  • wml/option-element-onpick-recursion.html: Added.
  • wml/resources/WMLTestCase.js: (createStaticWMLTestCase): (createDynamicWMLTestCase):
  • wml/resources/option-element-onpick-recursion.js: Added. (setupTestDocument): (prepareTest): (executeTest):
  • wml/resources/option-element-onpick-recursion.wml: Added.
  • wml/resources/option-element-onpick.js: (prepareTest):
5:44 PM Changeset in webkit [47346] by ddkilzer@apple.com
  • 3 edits in trunk/WebKitTools

<​http://webkit.org/b/28370> check-webkit-style: add check for 'using std::foo;' statements

Reviewed by David Levin.

In <​http://webkit.org/b/28355#c1>, it was noted that new source
files use 'using namespace std;' instead of individual
'using std::foo;' statements. This adds a level 4 check for
such statements.

  • Scripts/modules/cpp_style.py: (_ERROR_CATEGORIES): Added 'build/using_std'. (check_using_std): Added. (check_style): Added call to check_using_std().
  • Scripts/modules/cpp_style_unittest.py: (WebKitStyleTest.test_using_std): Added unit test.
5:32 PM Changeset in webkit [47345] by ddkilzer@apple.com
  • 3 edits in trunk/WebKitTools

Backed out r47343 which was mistakenly committed

  • Scripts/bugzilla-tool:
  • Scripts/modules/scm.py:
5:30 PM Changeset in webkit [47344] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

<​http://webkit.org/b/28367> bugzilla.py: replace ScriptError class with BugzillaError class

Reviewed by David Levin.

The ScriptError class doesn't exist in bugzilla.py, so any
errors print error messages about ScriptError instead of the
actual error:

NameError: global name 'ScriptError' is not defined

  • Scripts/modules/bugzilla.py: (BugzillaError): Added class. Modeled after ScriptError class in scm.py. (Bugzilla.authenticate): Changed to use BugzillaError instead of ScriptError. (Bugzilla._check_create_bug_response): Ditto.
5:30 PM Changeset in webkit [47343] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools/Scripts

WIP: bugzilla-tool: add land-commits command

4:24 PM Changeset in webkit [47342] by rik@webkit.org
  • 2 edits in trunk/WebCore

Inspector Resource filtering: keyboard Navigation always uses ALL resources
​https://bugs.webkit.org/show_bug.cgi?id=28231

Patch by Anthony Ricaud <​rik@webkit.org> on 2009-08-16
Reviewed by Timothy Hatcher.

Determine if a resource is selectable on user action.

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourceSidebarTreeElement.prototype.get selectable):

3:57 PM Changeset in webkit [47341] by ddkilzer@apple.com
  • 10 edits in trunk

<​http://webkit.org/b/28355> Replace MAX()/MIN() macros with type-safe std::max()/min() templates

Reviewed by Dan Bernstein.

WebCore:

  • accessibility/mac/AccessibilityObjectWrapper.mm: (AXAttributeStringSetSpelling): Changed MIN() to min().
  • platform/graphics/mac/FontMacATSUI.mm: (WebCore::Font::selectionRectForComplexText): Changed MAX() to max() and MIN() to min(). (WebCore::Font::floatWidthForComplexText): Ditto.
  • platform/graphics/mac/SimpleFontDataMac.mm: Added using std::max statement. (WebCore::SimpleFontData::platformInit): Changed MAX() to max().
  • platform/text/mac/TextCodecMac.cpp: (WebCore::TextCodecMac::decode): Changed MIN() to min().

WebKit/mac:

  • Plugins/WebBaseNetscapePluginStream.mm: Added using std::min statement. (WebNetscapePluginStream::deliverData): Changed MIN() to min(). Changed C-style cast to a static_cast.
  • Plugins/WebNetscapePluginView.mm: Added using std::min statement. (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]): Changed MIN() to min(). Changed C-style cast to a static_cast.
  • WebView/WebHTMLView.mm: Added using std::max statement. (-[WebHTMLView _dragImageForURL:withLabel:]): Changed MAX() to max(). (-[WebHTMLView _scaleFactorForPrintOperation:]): Ditto.
  • WebView/WebTextCompletionController.mm: Added using std::max and using std::min statements. (-[WebTextCompletionController _placePopupWindow:]): Changed type of maxWidth variable from float to CGFloat to prevent a type mismatch on x86_64. Changed MAX() to max() and MIN() to min(). Added static_cast for a constant value since CGFloat is defined as a float on i386 and as a double on x86_64.
12:27 PM Creating and Submitting Layout Tests and Patches edited by rniwa@webkit.org
(diff)
12:27 PM HowToSubmitPatch.png attached to Creating and Submitting Layout Tests and Patches by rniwa@webkit.org
Flow chart on how to submit a patch
12:25 PM Creating and Submitting Layout Tests and Patches edited by rniwa@webkit.org
(diff)
12:25 PM Creating and Submitting Layout Tests and Patches edited by rniwa@webkit.org
(diff)
12:25 PM Creating and Submitting Layout Tests and Patches edited by rniwa@webkit.org
(diff)
12:24 PM Creating and Submitting Layout Tests and Patches edited by rniwa@webkit.org
(diff)
12:23 PM Creating and Submitting Layout Tests and Patches edited by rniwa@webkit.org
(diff)
12:22 PM Creating and Submitting Layout Tests and Patches edited by rniwa@webkit.org
(diff)
12:21 PM Creating and Submitting Layout Tests and Patches edited by rniwa@webkit.org
(diff)
12:20 PM Flow chart edited by rniwa@webkit.org
(diff)
12:18 PM Flow chart edited by rniwa@webkit.org
(diff)
12:16 PM Flow chart edited by rniwa@webkit.org
adding picture (diff)
12:16 PM flowchart5.png attached to Flow chart by rniwa@webkit.org
Flow chart on how to submit a patch
12:15 PM Flow chart created by rniwa@webkit.org
initial creation
10:35 AM Changeset in webkit [47340] by Nikolas Zimmermann
  • 11 edits in trunk/WebCore

2009-08-16 Nikolas Zimmermann <​nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

[WML] Cleanup WMLIntrinsicEventHandling code
​https://bugs.webkit.org/show_bug.cgi?id=28358

Remove superflous "Event* evt" parameter from executeTask() methods. It's a leftover from the initial WML merge.

  • wml/WMLAnchorElement.cpp: (WebCore::WMLAnchorElement::defaultEventHandler):
  • wml/WMLDoElement.cpp: (WebCore::WMLDoElement::defaultEventHandler):
  • wml/WMLGoElement.cpp: (WebCore::WMLGoElement::executeTask):
  • wml/WMLGoElement.h:
  • wml/WMLIntrinsicEventHandler.cpp: (WebCore::WMLIntrinsicEventHandler::triggerIntrinsicEvent):
  • wml/WMLPrevElement.cpp: (WebCore::WMLPrevElement::executeTask):
  • wml/WMLPrevElement.h:
  • wml/WMLRefreshElement.cpp: (WebCore::WMLRefreshElement::executeTask):
  • wml/WMLRefreshElement.h:
  • wml/WMLTaskElement.h:
9:15 AM Changeset in webkit [47339] by pfeldman@chromium.org
  • 21 edits in trunk/WebCore

2009-08-16 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: A handful of DOMAgent-related fixes and cleanups.

  • renamed elementId to nodeId in operations on nodes.
  • added load listeners to frame owners in InspectorDOMAgent.
  • removed InspectorController::inspectedWindowScriptObjectCleared event.
  • preserved isViaInspector flag for 'via inspector' marker to survive styles update.
  • removed contentDocument-related logic from ElementsPanel since it is handled in

the InspectorDOMAgent.

  • removed DOM listeners unregistration and corresponding events from InspectorController.
  • made this.styles 'private' in ElementsPanel.
  • added TODO for the handleCopy processing.

​https://bugs.webkit.org/show_bug.cgi?id=28356

  • WebCore.order:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getChildNodes): (WebCore::InspectorBackend::setTextNodeValue):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp:
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::startListening): (WebCore::InspectorDOMAgent::stopListening): (WebCore::InspectorDOMAgent::handleEvent): (WebCore::InspectorDOMAgent::pushChildNodesToFrontend): (WebCore::InspectorDOMAgent::getChildNodes): (WebCore::InspectorDOMAgent::pushNodePathToFrontend): (WebCore::InspectorDOMAgent::setTextNodeValue): (WebCore::InspectorDOMAgent::buildObjectForNode): (WebCore::InspectorDOMAgent::buildArrayForContainerChildren): (WebCore::InspectorDOMAgent::innerParentNode):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorFrontend.cpp:
  • inspector/InspectorFrontend.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMDocument.prototype.addEventListener): (WebInspector.DOMDocument.prototype.removeEventListener): (WebInspector.DOMDocument.prototype._fireDomEvent): (WebInspector.DOMAgent.prototype.getChildNodesAsync.mycallback): (WebInspector.DOMAgent.prototype.getChildNodesAsync): (WebInspector.DOMAgent.prototype._setChildNodes): (WebInspector.CSSStyleDeclaration.parseRule): (WebInspector.childNodeInserted): (WebInspector.childNodeRemoved):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype.reset): (WebInspector.ElementsPanel.prototype.addStyleChange): (WebInspector.ElementsPanel.prototype.removeStyleChange): (WebInspector.ElementsPanel.prototype._updateModifiedNodes): (WebInspector.ElementsPanel.prototype.updateBreadcrumb): (WebInspector.ElementsPanel.prototype.handleCopyEvent):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.set rootDOMNode): (WebInspector.ElementsTreeOutline.prototype.findTreeElement): (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode): (WebInspector.ElementsTreeElement.prototype._updateChildren): (WebInspector.ElementsTreeElement.prototype.onexpand):
  • inspector/front-end/InjectedScript.js: (InjectedScript.addStyleSelector): (InjectedScript._serializeRule):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection):
  • inspector/front-end/inspector.js: (WebInspector.set hoveredDOMNode):
  • inspector/front-end/treeoutline.js: (TreeOutline.prototype.findTreeElement):
  • inspector/front-end/utilities.js: (Node.prototype.enclosingNodeOrSelfWithNodeNameInArray): (Node.prototype.enclosingNodeOrSelfWithClass): (isAncestorNode): (firstCommonNodeAncestor): (traverseNextNode): (traversePreviousNode): ():
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::dispatchWindowObjectAvailable):
  • page/android/InspectorControllerAndroid.cpp:
6:14 AM Changeset in webkit [47338] by zecke@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-16 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Mark Rowe.

Fix crash on ./ecma_2/RegExp/exec-002.js.
​https://bugs.webkit.org/show_bug.cgi?id=28353

Change the order of freeParenthesesDisjunctionContext and
popParenthesesDisjunctionContext on all call sites as the pop
method is accessing backTrack->lastContext which is the context
that is about to be freed.

  • yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::parenthesesDoBacktrack): (JSC::Yarr::Interpreter::backtrackParentheses):
6:14 AM Changeset in webkit [47337] by zecke@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-08-16 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Mark Rowe.

​https://bugs.webkit.org/show_bug.cgi?id=28352

Fix coding style violations. Use m_ for C++ class members. Remove
trailing whitespace on empty lines.

  • yarr/RegexInterpreter.cpp: (JSC::Yarr::Interpreter::ParenthesesDisjunctionContext::ParenthesesDisjunctionContext): (JSC::Yarr::Interpreter::tryConsumeCharacter): (JSC::Yarr::Interpreter::tryConsumeBackReference): (JSC::Yarr::Interpreter::parenthesesDoBacktrack): (JSC::Yarr::Interpreter::backtrackParentheses): (JSC::Yarr::ByteCompiler::ByteCompiler): (JSC::Yarr::ByteCompiler::compile): (JSC::Yarr::ByteCompiler::checkInput): (JSC::Yarr::ByteCompiler::assertionBOL): (JSC::Yarr::ByteCompiler::assertionEOL): (JSC::Yarr::ByteCompiler::assertionWordBoundary): (JSC::Yarr::ByteCompiler::atomPatternCharacter): (JSC::Yarr::ByteCompiler::atomCharacterClass): (JSC::Yarr::ByteCompiler::atomBackReference): (JSC::Yarr::ByteCompiler::atomParenthesesSubpatternBegin): (JSC::Yarr::ByteCompiler::atomParentheticalAssertionBegin): (JSC::Yarr::ByteCompiler::popParenthesesStack): (JSC::Yarr::ByteCompiler::closeAlternative): (JSC::Yarr::ByteCompiler::closeBodyAlternative): (JSC::Yarr::ByteCompiler::atomParenthesesEnd): (JSC::Yarr::ByteCompiler::regexBegin): (JSC::Yarr::ByteCompiler::alterantiveBodyDisjunction): (JSC::Yarr::ByteCompiler::alterantiveDisjunction): (JSC::Yarr::ByteCompiler::emitDisjunction):
5:33 AM Changeset in webkit [47336] by Nikolas Zimmermann
  • 1 edit
    1 add in trunk/LayoutTests

Not reviewed. Add missing WML specific layout test result.

Aug 15, 2009:

11:49 PM Changeset in webkit [47335] by weinig@apple.com
  • 2 edits in trunk/LayoutTests

Make Mark Rowe a bit less grumpy.

  • http/tests/history/back-to-post.php:
11:43 PM Changeset in webkit [47334] by weinig@apple.com
  • 3 edits in trunk/LayoutTests

Make http/tests/history/back-to-post.php's output a bit more reliable.

  • http/tests/history/back-to-post-expected.txt:
  • http/tests/history/back-to-post.php:
9:40 PM Changeset in webkit [47333] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-08-15 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

Optimize updateFillImages() to not add/remove clients every time
​https://bugs.webkit.org/show_bug.cgi?id=28334

Optimize the case where old and new just have a single layer pointing to the same (or no)
image.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::updateFillImages):
6:32 PM Changeset in webkit [47332] by Simon Fraser
  • 4 edits
    2 adds in trunk

2009-08-15 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson.

Implement animations of multiple text-shadows and -webkit-box-shadows.
​https://bugs.webkit.org/show_bug.cgi?id=28266

Test: transitions/multiple-shadow-transitions.html

  • page/animation/AnimationBase.cpp: (WebCore::PropertyWrapperShadow::equals): (WebCore::PropertyWrapperShadow::blend):
6:32 PM Changeset in webkit [47331] by Simon Fraser
  • 4 edits
    6 adds in trunk

2009-08-15 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson.

Make transitions work for position and size of multiple backgrounds and masks.
​https://bugs.webkit.org/show_bug.cgi?id=28266

Make background-position, background-size, -webkit-mask-position and -webkit-mask-size
properties animatable with multiple backgrounds, rather than just animating the first one.

Tests: transitions/multiple-background-size-transitions.html

transitions/multiple-background-transitions.html
transitions/multiple-mask-transitions.html

  • page/animation/AnimationBase.cpp: (WebCore::FillLayerPropertyWrapperBase::FillLayerPropertyWrapperBase): (WebCore::FillLayerPropertyWrapperBase::~FillLayerPropertyWrapperBase): (WebCore::FillLayerPropertyWrapperGetter::FillLayerPropertyWrapperGetter): (WebCore::FillLayerPropertyWrapperGetter::equals): (WebCore::FillLayerPropertyWrapper::FillLayerPropertyWrapper): (WebCore::FillLayerPropertyWrapper::blend): (WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper): (WebCore::FillLayersPropertyWrapper::equals): (WebCore::FillLayersPropertyWrapper::blend): (WebCore::ensurePropertyMap):
  • rendering/style/FillLayer.h: (WebCore::FillLayer::setXPosition): (WebCore::FillLayer::setYPosition): (WebCore::FillLayer::setSize):
5:23 PM Changeset in webkit [47330] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

Fix the build with JIT disabled.

  • runtime/Arguments.h: Only compile the jitCode method when the JIT is enabled.
  • runtime/Executable.h: Include PrototypeFunction.h so the compiler knows what

NativeFunctionWrapper is when the JIT is disabled.

5:16 PM Changeset in webkit [47329] by staikos@webkit.org
  • 3 edits
    1 add in trunk

2009-08-15 George Staikos <​george.staikos@torchmobile.com>

Reviewed by Jan Alonzo.

Don't crash in fieldset code when WML is enabled.
​https://bugs.webkit.org/show_bug.cgi?id=28012

Test: fast/wml/html-fieldset-crash.html

  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::findLegend): ++brackets
4:01 PM Changeset in webkit [47328] by weinig@apple.com
  • 3 edits in trunk/WebCore

Try and enable EventSource on Windows.

  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.vcproj/build-generated-files.sh:
3:54 PM Changeset in webkit [47327] by weinig@apple.com
  • 1 edit
    2 deletes in trunk/LayoutTests

Remove no longer correct and now failing test. document.body.onunload
has now been spec'ed in HTML5.

  • fast/events/onunload-body-property-expected.txt: Removed.
  • fast/events/onunload-body-property.html: Removed.
3:14 PM Changeset in webkit [47326] by weinig@apple.com
  • 4 edits
    6 adds in trunk

WebCore: Setting attribute event listeners to the body does not set them on the window
​https://bugs.webkit.org/show_bug.cgi?id=28343

Reviewed by Dan Bernstein.

Tests: fast/dom/Window/HTMLBodyElement-window-eventListener-attributes.html

fast/dom/Window/HTMLFrameSetElement-window-eventListener-attributes.html

  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::setOnblur): Use setWindowAttributeEventListener instead of setAttributeEventListener.
(WebCore::HTMLBodyElement::setOnerror): Ditto.
(WebCore::HTMLBodyElement::setOnfocus): Ditto.
(WebCore::HTMLBodyElement::setOnload): Ditto.
(WebCore::HTMLBodyElement::setOnbeforeunload): Ditto.
(WebCore::HTMLBodyElement::setOnmessage): Ditto.
(WebCore::HTMLBodyElement::setOnoffline): Ditto.
(WebCore::HTMLBodyElement::setOnonline): Ditto.
(WebCore::HTMLBodyElement::setOnresize): Ditto.
(WebCore::HTMLBodyElement::setOnstorage): Ditto.
(WebCore::HTMLBodyElement::setOnunload): Ditto.

  • html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::setOnblur): Ditto.
(WebCore::HTMLFrameSetElement::setOnerror): Ditto.
(WebCore::HTMLFrameSetElement::setOnfocus): Ditto.
(WebCore::HTMLFrameSetElement::setOnload): Ditto.
(WebCore::HTMLFrameSetElement::setOnbeforeunload): Ditto.
(WebCore::HTMLFrameSetElement::setOnmessage): Ditto.
(WebCore::HTMLFrameSetElement::setOnoffline): Ditto.
(WebCore::HTMLFrameSetElement::setOnonline): Ditto.
(WebCore::HTMLFrameSetElement::setOnresize): Ditto.
(WebCore::HTMLFrameSetElement::setOnstorage): Ditto.
(WebCore::HTMLFrameSetElement::setOnunload): Ditto.

LayoutTests: Setting attribute event listeners to the body does not set them on the window
​https://bugs.webkit.org/show_bug.cgi?id=28343

Reviewed by Dan Bernstein.

  • fast/dom/Window/HTMLBodyElement-window-eventListener-attributes-expected.txt: Added.
  • fast/dom/Window/HTMLBodyElement-window-eventListener-attributes.html: Added.
  • fast/dom/Window/HTMLFrameSetElement-window-eventListener-attributes-expected.txt: Added.
  • fast/dom/Window/HTMLFrameSetElement-window-eventListener-attributes.html: Added.
  • fast/dom/Window/resources/HTMLBodyElement-window-eventListener-attributes.js: Added.
  • fast/dom/Window/resources/HTMLFrameSetElement-window-eventListener-attributes.js: Added.
2:35 PM Changeset in webkit [47325] by weinig@apple.com
  • 3 edits in trunk/WebCore

Fix up some IDL comments.

Reviewed by Dan Bernstein.

  • html/HTMLBodyElement.idl:
  • html/HTMLFrameSetElement.idl:
2:25 PM Changeset in webkit [47324] by weinig@apple.com
  • 2 edits in trunk

[GTK] Added EventSource to the build (default on).
​https://bugs.webkit.org/show_bug.cgi?id=14997

Patch by Adam Bergkvist <​adam.bergkvist@ericsson.com> on 2009-08-14
Reviewed by Sam Weinig.

  • configure.ac:
2:04 PM Changeset in webkit [47323] by weinig@apple.com
  • 27 edits
    31 adds in trunk

JavaScriptCore: Added ENABLE_EVENTSOURCE flag.
​https://bugs.webkit.org/show_bug.cgi?id=14997

Patch by Adam Bergkvist <​adam.bergkvist@ericsson.com> on 2009-08-15
Reviewed by Sam Weinig.

  • Configurations/FeatureDefines.xcconfig:

WebCore: Added implementation of the EventSource object that enables
server-sent events from HTML5.
​http://dev.w3.org/html5/eventsource/
​https://bugs.webkit.org/show_bug.cgi?id=14997

Patch by Adam Bergkvist <​adam.bergkvist@ericsson.com> on 2009-08-15
Reviewed by Sam Weinig.

Tests: fast/eventsource/eventsource-attribute-listeners.html

fast/eventsource/eventsource-constructor.html
http/tests/eventsource/eventsource-bad-mime-type.html
http/tests/eventsource/eventsource-parse-event-stream.html
http/tests/eventsource/eventsource-reconnect.html
http/tests/eventsource/eventsource-status-code-states.html
http/tests/eventsource/workers/eventsource-simple.html

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::eventSource):

  • bindings/js/JSEventSourceConstructor.cpp: Added.

(WebCore::):
(WebCore::JSEventSourceConstructor::JSEventSourceConstructor):
(WebCore::constructEventSource):
(WebCore::JSEventSourceConstructor::getConstructData):

  • bindings/js/JSEventSourceConstructor.h: Added.

(WebCore::JSEventSourceConstructor::classInfo):

  • bindings/js/JSEventSourceCustom.cpp: Added.

(WebCore::JSEventSource::markChildren):
(WebCore::JSEventSource::addEventListener):
(WebCore::JSEventSource::removeEventListener):

  • bindings/js/JSEventTarget.cpp:

(WebCore::toJS):
(WebCore::toEventTarget):

  • bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::eventSource):

  • dom/EventNames.h:
  • dom/EventTarget.cpp:

(WebCore::EventTarget::toEventSource):

  • dom/EventTarget.h:
  • page/DOMWindow.idl:
  • page/EventSource.cpp: Added.

(WebCore::EventSource::EventSource):
(WebCore::EventSource::~EventSource):
(WebCore::EventSource::connect):
(WebCore::EventSource::endRequest):
(WebCore::EventSource::scheduleReconnect):
(WebCore::EventSource::reconnectTimerFired):
(WebCore::EventSource::url):
(WebCore::EventSource::readyState):
(WebCore::EventSource::close):
(WebCore::EventSource::scriptExecutionContext):
(WebCore::EventSource::addEventListener):
(WebCore::EventSource::removeEventListener):
(WebCore::EventSource::dispatchEvent):
(WebCore::EventSource::didReceiveResponse):
(WebCore::EventSource::didReceiveData):
(WebCore::EventSource::didFinishLoading):
(WebCore::EventSource::didFail):
(WebCore::EventSource::didFailRedirectCheck):
(WebCore::EventSource::parseEventStream):
(WebCore::EventSource::parseEventStreamLine):
(WebCore::EventSource::dispatchGenericEvent):
(WebCore::EventSource::dispatchMessageEvent):
(WebCore::EventSource::stop):

  • page/EventSource.h: Added.

(WebCore::EventSource::create):
(WebCore::EventSource::):
(WebCore::EventSource::setOnopen):
(WebCore::EventSource::onopen):
(WebCore::EventSource::setOnmessage):
(WebCore::EventSource::onmessage):
(WebCore::EventSource::setOnerror):
(WebCore::EventSource::onerror):
(WebCore::EventSource::toEventSource):
(WebCore::EventSource::eventListeners):
(WebCore::EventSource::refEventTarget):
(WebCore::EventSource::derefEventTarget):

  • page/EventSource.idl: Added.
  • workers/WorkerContext.idl:

WebKit/mac: Added ENABLE_EVENTSOURCE flag.
​https://bugs.webkit.org/show_bug.cgi?id=14997

Patch by Adam Bergkvist <​adam.bergkvist@ericsson.com> on 2009-08-15
Reviewed by Sam Weinig.

  • Configurations/FeatureDefines.xcconfig:

WebKitTools: Added EventSource to the build script (default on).
​https://bugs.webkit.org/show_bug.cgi?id=14997

Patch by Adam Bergkvist <​adam.bergkvist@ericsson.com> on 2009-08-14
Reviewed by Sam Weinig.

  • Scripts/build-webkit:

LayoutTests: Tests for EventSource.
​https://bugs.webkit.org/show_bug.cgi?id=14997

Patch by Adam Bergkvist <​adam.bergkvist@ericsson.com> on 2009-08-14
Reviewed by Sam Weinig.

  • fast/eventsource: Added.
  • fast/eventsource/eventsource-attribute-listeners-expected.txt: Added.
  • fast/eventsource/eventsource-attribute-listeners.html: Added.
  • fast/eventsource/eventsource-constructor-expected.txt: Added.
  • fast/eventsource/eventsource-constructor.html: Added.
  • http/tests/eventsource: Added.
  • http/tests/eventsource/eventsource-bad-mime-type-expected.txt: Added.
  • http/tests/eventsource/eventsource-bad-mime-type.html: Added.
  • http/tests/eventsource/eventsource-parse-event-stream-expected.txt: Added.
  • http/tests/eventsource/eventsource-parse-event-stream.html: Added.
  • http/tests/eventsource/eventsource-reconnect-expected.txt: Added.
  • http/tests/eventsource/eventsource-reconnect.html: Added.
  • http/tests/eventsource/eventsource-status-code-states-expected.txt: Added.
  • http/tests/eventsource/eventsource-status-code-states.html: Added.
  • http/tests/eventsource/resources: Added.
  • http/tests/eventsource/resources/bad-mime-type.asis: Added.
  • http/tests/eventsource/resources/event-stream.php: Added.
  • http/tests/eventsource/resources/reconnect.php: Added.
  • http/tests/eventsource/resources/simple-event-stream.asis: Added.
  • http/tests/eventsource/resources/status-codes.php: Added.
  • http/tests/eventsource/workers: Added.
  • http/tests/eventsource/workers/eventsource-simple-expected.txt: Added.
  • http/tests/eventsource/workers/eventsource-simple.html: Added.
  • http/tests/eventsource/workers/resources: Added.
  • http/tests/eventsource/workers/resources/simple-worker.js: Added.

(es.onmessage):
(es.onerror):

1:53 PM Changeset in webkit [47322] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-08-15 Zan Dobersek <​zandobersek@gmail.com>

Reviewed by Xan Lopez.

Fix compiler warnings.

  • webkit/webkitwebview.cpp: (clipboard_contents_received): (webkit_web_view_drag_data_get):
11:30 AM Changeset in webkit [47321] by rniwa@webkit.org
  • 2 edits in trunk/WebKitTools

Unreviewed.

Patch by Ryosuke Niwa <​rniwa@webkit.org> on 2009-08-15
Add myself to list of committers.

  • Scripts/modules/committers.py:
4:25 AM Changeset in webkit [47320] by jhoneycutt@apple.com
  • 12 edits in trunk/WebKitTools

WebKitTools: Fix layout test failures after r47312.

Reviewed by Cameron Zwarich.

  • DumpRenderTree/AccessibilityController.h:

Replaced logFocusEvents() with setLogFocusEvents(), which takes a
boolean argument to turn logging of focus events on or off.
Added a function to reset the AccessibilityController to a consistent
state.

  • DumpRenderTree/AccessibilityController.cpp:

(logFocusEventsCallback):
Call setLogFocusEvents() to enable logging.
(AccessibilityController::resetToConsistentState):
Call setLogFocusEvents() to disable logging.

  • DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:

(AccessibilityController::setLogFocusEvents):
Update stub.

  • DumpRenderTree/mac/AccessibilityControllerMac.mm:

(AccessibilityController::setLogFocusEvents):
Update stub.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebViewToConsistentStateBeforeTesting):
Call the FrameLoadDelegate's resetToConsistentState method.

  • DumpRenderTree/mac/FrameLoadDelegate.h:

Declare the resetToConsistentState method.

  • DumpRenderTree/mac/FrameLoadDelegate.mm:

(-[FrameLoadDelegate resetToConsistentState]):
Call the AccessibilityController's resetToConsistentState() function.

  • DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::~AccessibilityController):
Turn off focus event logging when the controller is destroyed.
(AccessibilityController::setLogFocusEvents):
If the caller passes false, unhook the focus event, and clear
m_focusEventHook.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebViewToConsistentStateBeforeTesting):
Call the FrameLoadDelegate's resetToConsistentState function.

  • DumpRenderTree/win/FrameLoadDelegate.h:

Declare the resetToConsistentState() function.

  • DumpRenderTree/win/FrameLoadDelegate.cpp:

(FrameLoadDelegate::resetToConsistentState):
Call the AccessibilityController's resetToConsistentState() function.

2:02 AM Changeset in webkit [47319] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2009-08-15 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Minor DOMAgent bugfixes.

​https://bugs.webkit.org/show_bug.cgi?id=28177

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::nodeForId):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMAgent):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
1:56 AM Changeset in webkit [47318] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2009-08-15 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Evaluating objects while on a breakpoint dumps string
representation instead of live object.

​https://bugs.webkit.org/show_bug.cgi?id=28280

  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.completions.this._evalInInspectedWindow): (WebInspector.ConsoleView.prototype.completions): (WebInspector.ConsoleView.prototype._reportCompletions):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame.delayedEvaluation): (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame): (WebInspector.ScriptsPanel.prototype.variablesInSelectedCallFrame):
12:31 AM Changeset in webkit [47317] by abarth@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-08-15 Maxime Simon <Maxime Simon>

Reviewed by Eric Seidel.

[Haiku] Adding two new files to WebCore/platform/haiku:
LocalizedStringsHaiku.cpp and LoggingHaiku.cpp
​https://bugs.webkit.org/show_bug.cgi?id=28129

  • platform/haiku/LocalizedStringsHaiku.cpp: Added. (WebCore::submitButtonDefaultLabel): (WebCore::inputElementAltText): (WebCore::resetButtonDefaultLabel): (WebCore::defaultLanguage): (WebCore::searchableIndexIntroduction): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (WebCore::contextMenuItemTagOpenLinkInNewWindow): (WebCore::contextMenuItemTagDownloadLinkToDisk): (WebCore::contextMenuItemTagCopyLinkToClipboard): (WebCore::contextMenuItemTagOpenImageInNewWindow): (WebCore::contextMenuItemTagDownloadImageToDisk): (WebCore::contextMenuItemTagCopyImageToClipboard): (WebCore::contextMenuItemTagOpenFrameInNewWindow): (WebCore::contextMenuItemTagCopy): (WebCore::contextMenuItemTagGoBack): (WebCore::contextMenuItemTagGoForward): (WebCore::contextMenuItemTagStop): (WebCore::contextMenuItemTagReload): (WebCore::contextMenuItemTagCut): (WebCore::contextMenuItemTagPaste): (WebCore::contextMenuItemTagNoGuessesFound): (WebCore::contextMenuItemTagIgnoreSpelling): (WebCore::contextMenuItemTagLearnSpelling): (WebCore::contextMenuItemTagSearchWeb): (WebCore::contextMenuItemTagLookUpInDictionary): (WebCore::contextMenuItemTagOpenLink): (WebCore::contextMenuItemTagIgnoreGrammar): (WebCore::contextMenuItemTagSpellingMenu): (WebCore::contextMenuItemTagShowSpellingPanel): (WebCore::contextMenuItemTagCheckSpelling): (WebCore::contextMenuItemTagCheckSpellingWhileTyping): (WebCore::contextMenuItemTagCheckGrammarWithSpelling): (WebCore::contextMenuItemTagFontMenu): (WebCore::contextMenuItemTagBold): (WebCore::contextMenuItemTagItalic): (WebCore::contextMenuItemTagUnderline): (WebCore::contextMenuItemTagOutline): (WebCore::contextMenuItemTagWritingDirectionMenu): (WebCore::contextMenuItemTagDefaultDirection): (WebCore::contextMenuItemTagLeftToRight): (WebCore::contextMenuItemTagRightToLeft): (WebCore::contextMenuItemTagInspectElement): (WebCore::searchMenuNoRecentSearchesText): (WebCore::searchMenuRecentSearchesText): (WebCore::searchMenuClearRecentSearchesText): (WebCore::unknownFileSizeText): (WebCore::AXWebAreaText): (WebCore::AXLinkText): (WebCore::AXListMarkerText): (WebCore::AXImageMapText): (WebCore::AXHeadingText): (WebCore::imageTitle): (WebCore::contextMenuItemTagTextDirectionMenu): (WebCore::AXButtonActionVerb): (WebCore::AXTextFieldActionVerb): (WebCore::AXRadioButtonActionVerb): (WebCore::AXCheckedCheckBoxActionVerb): (WebCore::AXUncheckedCheckBoxActionVerb): (WebCore::AXLinkActionVerb): (WebCore::AXDefinitionListTermText): (WebCore::AXDefinitionListDefinitionText):
  • platform/haiku/LoggingHaiku.cpp: Added. (WebCore::InitializeLoggingChannelsIfNecessary):
12:27 AM Changeset in webkit [47316] by Darin Adler
  • 2 edits in trunk/WebCore

Fix GTK build.

Patch by Darin Adler <Darin Adler> on 2009-08-15

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(fallbackObject): Pass 0 for document. Should be OK at least for now.

12:09 AM Changeset in webkit [47315] by Darin Adler
  • 2 edits in trunk/WebCore

Fix Qt build.

Patch by Darin Adler <Darin Adler> on 2009-08-15

  • dom/XMLTokenizerQt.cpp: Use create functions instead of calling new

directly to make CDATASection and Comment nodes.

Aug 14, 2009:

11:29 PM Changeset in webkit [47314] by jhoneycutt@apple.com
  • 2 edits in trunk/LayoutTests

Remove two tests from the skipped list that don't exist.

Rubber-stamped by Mark Rowe.

  • platform/win/Skipped:
11:25 PM Changeset in webkit [47313] by Darin Adler
  • 68 edits
    1 delete in trunk/WebCore

Make DOM classes start with a reference count of 1, like all other RefCounted
​https://bugs.webkit.org/show_bug.cgi?id=28068

Patch by Darin Adler <Darin Adler> on 2009-08-14
Reviewed by Sam Weinig.

First half, everything except for element classes.

  • GNUmakefile.am: Removed DocPtr.h.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/Attr.cpp:

(WebCore::Attr::Attr): Added a call to createTextChild here so callers don't
have to call it explicitly.
(WebCore::Attr::create): Added.
(WebCore::Attr::setValue): Changed to take AtomicString.
(WebCore::Attr::cloneNode): Use create.

  • dom/Attr.h: Added a create function. Made the constructor private,

and a lot of other functions private as well.

  • dom/Attribute.cpp:

(WebCore::Attribute::createAttrIfNeeded): Use Attr::create.

  • dom/CDATASection.cpp:

(WebCore::CDATASection::create): Added.
(WebCore::CDATASection::cloneNode): Use create.
(WebCore::CDATASection::virtualCreate): Ditto.

  • dom/CDATASection.h: Added a create function. Made everything private.

Removed unneeded destructor declaration.

  • dom/CharacterData.cpp:

(WebCore::CharacterData::CharacterData): Replaced the multiple constructors
with a single one that takes ConstructionType.

  • dom/CharacterData.h: Made more functions be protected and private.

Made m_data be private.

  • dom/Comment.cpp:

(WebCore::Comment::Comment): Got rid of an extra constructor.
(WebCore::Comment::create): Added.
(WebCore::Comment::cloneNode): Call create.

  • dom/Comment.h: Added a create function. Made everything private.
  • dom/ContainerNode.cpp:

(WebCore::dispatchChildInsertionEvents): Use RefPtr instead of DocPtr.
(WebCore::dispatchChildRemovalEvents): Ditto.

  • dom/ContainerNode.h: Made the constructor protected and passed

ConstructionType instead of an isElement boolean.

  • dom/DocPtr.h: Removed.
  • dom/Document.cpp:

(WebCore::Document::Document): Simplified the code that sets m_document
since it's no longer a smart pointer.
(WebCore::Document::removedLastRef): Use explicit calls to selfOnlyRef
and selfOnlyDeref instead of a DocPtr in here.
(WebCore::Document::~Document): Simplified the code that sets m_document
since it's no longer a smart pointer.
(WebCore::Document::createDocumentFragment): Call create.
(WebCore::Document::createTextNode): Ditto.
(WebCore::Document::createComment): Ditto.
(WebCore::Document::createCDATASection): Ditto.
(WebCore::Document::createProcessingInstruction): Ditto.
(WebCore::Document::createEntityReference): Ditto.
(WebCore::Document::createEditingTextNode): Ditto.
(WebCore::Document::importNode): Call Attr::create.
(WebCore::Document::createAttributeNS): Ditto.

  • dom/Document.h: Call adoptRef. Made a lot of functions private and

protected and sorted them so public functions come first.

  • dom/DocumentFragment.cpp:

(WebCore::DocumentFragment::create): Added.
(WebCore::DocumentFragment::cloneNode): Call create.

  • dom/DocumentFragment.h: Added create.
  • dom/DocumentType.cpp:

(WebCore::DocumentType::DocumentType): Pass type to Node constructor.
(WebCore::DocumentType::cloneNode): Use create.

  • dom/DocumentType.h:

(WebCore::DocumentType::create): Call adoptRef.

  • dom/EditingText.cpp:

(WebCore::EditingText::create): Added.

  • dom/EditingText.h: Added a create function. Made everything private.
  • dom/Element.cpp:

(WebCore::Element::Element): Pass CreateElementZeroRefCount to preserve
the zero reference count behavior for classes derived from Element.

  • dom/EntityReference.cpp:

(WebCore::EntityReference::create): Added.
(WebCore::EntityReference::cloneNode): Call create.

  • dom/EntityReference.h: Added create. Made everything private.
  • dom/Node.cpp:

(WebCore::Node::initialRefCount): Added. Inline helper function for
the constructor.
(WebCore::Node::isContainer): Ditto.
(WebCore::Node::isElement): Ditto.
(WebCore::Node::isText): Ditto.
(WebCore::Node::Node): Changed to take a construction type argument.
Since m_document is now a normal pointer, added a call to selfOnlyRef.
(WebCore::Node::~Node): Ditto, but selfOnlyDeref.
(WebCore::Node::setDocument): Added selfOnlyRef/Deref calls.
(WebCore::Node::appendTextContent): Use the data function instead of
calling nodeValue functions, which do the same thing in a roundabout way.

  • dom/Node.h: Made the constructor protected and replaced the multiple

arguments iwth a single ConstructionType argument. Sorted the public
things first.

  • dom/Notation.h: Made most things private.
  • dom/Notation.cpp: Removed extra constructor.
  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::create): Added.
(WebCore::ProcessingInstruction::cloneNode): Call create.

  • dom/ProcessingInstruction.h: Added create function. Made many other

members private.

  • dom/Range.cpp:

(WebCore::Range::processContents): Use DocumentFragment::create.

  • dom/Text.cpp:

(WebCore::Text::Text): Updated for base class change.
(WebCore::Text::create): Added.
(WebCore::Text::splitText): Changed to not require access to m_data.
(WebCore::Text::cloneNode): Call create.
(WebCore::Text::createRenderer): Call dataImpl.
(WebCore::Text::attach): Call data.
(WebCore::Text::recalcStyle): Call dataImpl.
(WebCore::Text::virtualCreate): Call create.
(WebCore::Text::createWithLengthLimit): Call create.
(WebCore::Text::formatForDebugger): Call data.

  • dom/Text.h: Added a create function. Made many other members private.

Renamed createNew to virtualCreate.

  • dom/XMLTokenizer.cpp:

(WebCore::XMLTokenizer::enterText): Call Text::create.

  • dom/XMLTokenizerLibxml2.cpp:

(WebCore::XMLTokenizer::cdataBlock): Call CDATASection::create.
(WebCore::XMLTokenizer::comment): Call Comment::create.

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::deleteInsignificantText):
Call data instead of string.

  • editing/CreateLinkCommand.cpp:

(WebCore::CreateLinkCommand::doApply): Call Text::create.

  • editing/EditorCommand.cpp:

(WebCore::executeInsertNode): Call DocumentFragment::create.

  • editing/SplitTextNodeCommand.cpp:

(WebCore::SplitTextNodeCommand::doApply): Call Text::create.

  • editing/markup.cpp:

(WebCore::appendStartMarkup): Call data instead of nodeValue.

  • html/HTMLDocument.h:

(WebCore::HTMLDocument::create): Call adoptRef.

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::createContextualFragment): Call DocumentFragment::create.
(WebCore::replaceChildrenWithFragment): Call data instead of string.
(WebCore::replaceChildrenWithText): Call Text::create.
(WebCore::HTMLElement::setInnerText): Call DocumentFragment::create and
Text::create.
(WebCore::HTMLElement::setOuterText): Call Text::create.

  • html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::HTMLKeygenElement): Call Text::create.

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::setText): Call Text::create.

  • html/HTMLParser.cpp:

(WebCore::HTMLParser::textCreateErrorCheck): Call Text::create.
(WebCore::HTMLParser::commentCreateErrorCheck): Call Comment::create.
(WebCore::HTMLParser::handleIsindex): Call Text::create.

  • html/HTMLViewSourceDocument.cpp:

(WebCore::HTMLViewSourceDocument::addText): Call Text::create.

  • html/HTMLViewSourceDocument.h:

(WebCore::HTMLViewSourceDocument::create): Call adoptRef.

  • loader/FTPDirectoryDocument.cpp:

(WebCore::FTPDirectoryTokenizer::appendEntry): Call Text::create.
(WebCore::FTPDirectoryTokenizer::createTDForFilename): Call Text::create.

  • loader/FTPDirectoryDocument.h:

(WebCore::FTPDirectoryDocument::create): Call adoptRef.

  • loader/ImageDocument.h:

(WebCore::ImageDocument::create): Ditto.

  • loader/MediaDocument.h:

(WebCore::MediaDocument::create): Ditto.

  • loader/PlaceholderDocument.h:

(WebCore::PlaceholderDocument::create): Ditto.

  • loader/PluginDocument.h:

(WebCore::PluginDocument::create): Ditto.

  • loader/TextDocument.h:

(WebCore::TextDocument::create): Ditto.

  • loader/loader.cpp:

(WebCore::Loader::Host::didFinishLoading): Use RefPtr instead of DocPtr.
(WebCore::Loader::Host::didFail): Ditto.

  • platform/TreeShared.h:

(WebCore::TreeShared::TreeShared): Added an initialRefCount argument,
defaulting to 1. Node still sometimes initializes it to 0 instead for now.

  • rendering/RenderText.cpp:

(WebCore::RenderText::originalText): Use dataImpl instead of string.

  • rendering/RenderTextFragment.cpp:

(WebCore::RenderTextFragment::originalText): Use dataImpl instead of string.
(WebCore::RenderTextFragment::previousCharacter): Ditto.

  • svg/SVGDocument.h:

(WebCore::SVGDocument::create): Use adoptRef.

  • svg/SVGElementInstance.cpp:

(WebCore::SVGElementInstance::SVGElementInstance): Updated to take a
PassRefPtr.

  • svg/SVGElementInstance.h: Made everything private.
  • wml/WMLDocument.h:

(WebCore::WMLDocument::create): Called adoptRef.

  • xml/XPathNamespace.cpp:

(WebCore::XPathNamespace::XPathNamespace): Take AtomicString arguments.

  • xml/XPathNamespace.h: Made everything private.
  • xml/XSLTProcessor.cpp:

(WebCore::createFragmentFromSource): Use DocumentFragment::create and
Text::create.

11:15 PM Changeset in webkit [47312] by jhoneycutt@apple.com
  • 8 edits
    2 adds in trunk

WebKitTools: Add a mechanism for logging MSAA focus events.

Part of <rdar://problem/6218721> No MSAA focus events fired for Webkit
nightly (20866)

​https://bugs.webkit.org/show_bug.cgi?id=20866

Reviewed by Oliver Hunt.

  • DumpRenderTree/AccessibilityController.cpp:

(logFocusEventsCallback):
Call the AccessibilityController's logFocusEvents() function.
(AccessibilityController::getJSClass):
Add a "logFocusEvents" function to the AccessibilityController's JS
class definition.

  • DumpRenderTree/AccessibilityController.h:

On Windows, include windows.h, and add a member variable to hold the
handle to the event hook for focus events. Add a declaration for a
function that enables logging of focus events.

  • DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:

(AccessibilityController::logFocusEvents):
Stubbed.

  • DumpRenderTree/mac/AccessibilityControllerMac.mm:

(AccessibilityController::logFocusEvents):
Stubbed.

  • DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::AccessibilityController):
(AccessibilityController::~AccessibilityController):
If we hooked the focus event, unhook it.
(logFocusEventProc):
When we receive a focus event, get the accessible object for the event,
and log its name to stdout.
(AccessibilityController::logFocusEvents):
Setup the focus event hook to listen for events in the current process.

LayoutTests: Add a layout test for <rdar://problem/6218721> No MSAA focus events
fired for Webkit nightly (20866)

​https://bugs.webkit.org/show_bug.cgi?id=20866

Reviewed by Oliver Hunt.

  • platform/win/Skipped:

Remove the blanket skipping of accessibility/, and add the individual
tests.

  • platform/win/accessibility/focus-events-expected.txt: Added.
  • platform/win/accessibility/focus-events.html: Added.
11:14 PM Changeset in webkit [47311] by jhoneycutt@apple.com
  • 9 edits in trunk

WebCore:

2009-08-13 Jon Honeycutt <​jhoneycutt@apple.com>

Part of <rdar://problem/6218721> No MSAA focus events fired for Webkit
nightly (20866)

​https://bugs.webkit.org/show_bug.cgi?id=20866

Reviewed by Oliver Hunt.

  • accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::AXObjectCache): Changed to take a pointer to its owner document. This is used by AXObjectCache::handleFocusedUIElementChanged(). (WebCore::AXObjectCache::focusedUIElementForPage): Code moved from AccessibilityRenderObject::focusedUIElement(). Modified to be a static function and to take a pointer to a Page. (WebCore::AXObjectCache::platformGenerateAXID): Moved the code to generate the next AXID from getAXID() to here. Added a #if to make this non-WIN only, because Windows has its own implementation. (WebCore::AXObjectCache::getAXID): Ensure that we generate a positive AXID, ranging from 1 to LONG_MAX.
  • accessibility/AXObjectCache.h: Add a declaration for Document and Page. Removed the declaration of AccessibilityObject, because we include the header. Reordered the declaration of Node alphabetically. Moved the typedef for AXID to AccessibilityObject. Removed some trailing whitespace. Added a member variable to hold a pointer to the owner Document. (WebCore::AXObjectCache::AXObjectCache): Changed to take a pointer to its owner Document. (WebCore::AXObjectCache::focusedUIElementForPage): Added; code moved from AccessiblityRenderObject::focusedUIElement(). Returns the focused element with respect to accessibility. (WebCore::AXObjectCache::platformGenerateAXID): Declare a function to generate an AXID. (WebCore::AXObjectCache::objectFromAXID): Return the AccessibilityObject with the given AXID.
  • accessibility/AccessibilityObject.h: Moved the typedef for AXID from AXObjectCache to here. Made the m_id member use the typedef. (WebCore::AccessibilityObject::axObjectID): Changed the return type to use the typedef. (WebCore::AccessibilityObject::setAXObjectID): Changed the argument type to use the typedef.
  • accessibility/AccessibilityRenderObject.cpp: Removed some unneeded #includes. (WebCore::AccessibilityRenderObject::focusedUIElement): Moved the code to AXObjectCache::focusedUIElementForPage(), which we now call.
  • accessibility/win/AXObjectCacheWin.cpp: (WebCore::AXObjectCache::platformGenerateAXID): Ensure that we generate an AXID that is in the range 1 to LONG_MAX. (WebCore::AXObjectCache::handleFocusedUIElementChanged): If the Document has no Page, return. If the Page has not focused element (respecting accessibility), return. Assert that the accessibility of the focused element is not ignored, and that the object's AXID will be negative and fit into a LONG when negated. Broadcast a focus event for the object.
  • dom/Document.cpp: (WebCore::Document::axObjectCache): Pass this when creating the AXObjectCache. (WebCore::Document::setFocusedNode): Call AXObjectCache::handleFocusedUIElementChanged() on Windows.

WebKit/win:

2009-08-13 Jon Honeycutt <​jhoneycutt@apple.com>

Part of <rdar://problem/6218721> No MSAA focus events fired for Webkit
nightly (20866)

​https://bugs.webkit.org/show_bug.cgi?id=20866

Reviewed by Oliver Hunt.

  • AccessibleBase.cpp: (AccessibleBase::getAccessibilityObjectForChild): If the child ID is negative, negate it and treat it as an AXID.
11:08 PM Changeset in webkit [47310] by jmalonzo@webkit.org
  • 7 edits
    1 add in trunk

2009-08-14 Jiahua Huang <​jhuangjiahua@gmail.com>

Reviewed by Jan Alonzo.

[gtk] Pasteboard/GtkClipboard can't handle the "text/html" target.
​https://bugs.webkit.org/show_bug.cgi?id=27028

Remove the improper set of enum WebKitWebViewTargetInfo
by grabbing the target infos via m_helper.

  • manual-tests/gtk/copy-htmltext.html: Added.
  • platform/Pasteboard.h:
  • platform/gtk/PasteboardGtk.cpp: (WebCore::clipboard_get_contents_cb):
  • platform/gtk/PasteboardHelper.h:

Add a function in WebKit::PasteboardHelperGtk that will return the
value of WEBKIT_WEB_VIEW_TARGET_INFO_HTML,
and WebCore::clipboard_get_contents_cb will use that.

  • WebCoreSupport/PasteboardHelperGtk.cpp: (WebKit::PasteboardHelperGtk::getWebViewTargetInfoHtml):
  • WebCoreSupport/PasteboardHelperGtk.h:
10:19 PM Changeset in webkit [47309] by jmalonzo@webkit.org
  • 2 edits in trunk

2009-08-14 Jan Michael Alonzo <​jmalonzo@webkit.org>

Rubber-stamped by Gustavo Noronha.

Initialize CFLAGS and CXXFLAGS before the main body of the
WEBKIT_INIT macro so C files don't get built with "-g -O2".

  • autotools/webkit.m4:
7:53 PM Changeset in webkit [47308] by dimich@chromium.org
  • 3 edits in trunk/LayoutTests

Not reviewed, adding new test to Skipped on gtk and Qt.
DRT on these ports does not yet support layoutTestController.overridePreference.

  • platform/gtk/Skipped: skip LayoutTests/fast/harness/use-page-cache.html
  • platform/qt/Skipped: ditto.
6:36 PM Changeset in webkit [47307] by barraclough@apple.com
  • 3 edits in trunk/JavaScriptCore
  • parser/Parser.h:

(JSC::EvalExecutable::parse):
(JSC::ProgramExecutable::parse):

  • runtime/Executable.h:

Reviewed by NOBODY (build fix).

6:20 PM Changeset in webkit [47306] by dimich@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=28324
First ever test using page cache!
The test verifies that override setting that enables page cache works correctly.
It navigates forward and then back and checks that onload is not fired again
but the timer continues firing.

Reviewed by Eric Seidel.

  • fast/harness/resources/cached-page-1.html: Added.
  • fast/harness/resources/cached-page-2.html: Added.
  • fast/harness/use-page-cache-expected.txt: Added.
  • fast/harness/use-page-cache.html: Added.
6:14 PM Changeset in webkit [47305] by Simon Fraser
  • 4 edits in trunk/WebCore

2009-08-14 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt.

Fix an assertion when bringing up the Inspector.
​https://bugs.webkit.org/show_bug.cgi?id=28318

The fix for bug 28295 assumed that image clients count the number of times
addClient/removeClient is called. That was true for CachedResource clients,
but not StyleGeneratedImage clients, which pass the call onto CSSImageGeneratorValue.

Fix by making CSSImageGeneratorValue count the number of times a client is
added/removed.

  • css/CSSCanvasValue.cpp: (WebCore::CSSCanvasValue::canvasChanged): (WebCore::CSSCanvasValue::canvasResized):
  • css/CSSImageGeneratorValue.cpp: (WebCore::CSSImageGeneratorValue::addClient): (WebCore::CSSImageGeneratorValue::removeClient): (WebCore::CSSImageGeneratorValue::getImage):
  • css/CSSImageGeneratorValue.h:
6:14 PM Changeset in webkit [47304] by barraclough@apple.com
  • 19 edits
    1 add in trunk/JavaScriptCore

Remove AST nodes from use within the Runtime (outside of parsing), stage 1
​https://bugs.webkit.org/show_bug.cgi?id=28330

Reviewed by Oliver Hunt.

Remove the EvalNode and ProgramNode from use in the runtime. They still exist
after this patch, but are hidden behind EvalExecutable and FunctionExecutable,
and are also still reachable behind CodeBlock::m_ownerNode.

The next step will be to beat back FunctionBodyNode in the same fashion.
Then remove the usage via CodeBlock, then only construct these nodes only on
demand during bytecode generation.

(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::GlobalCodeBlock::~GlobalCodeBlock):
(JSC::ProgramCodeBlock::ProgramCodeBlock):
(JSC::EvalCodeBlock::EvalCodeBlock):
(JSC::FunctionCodeBlock::FunctionCodeBlock):
(JSC::NativeCodeBlock::NativeCodeBlock):

  • bytecode/EvalCodeCache.h:

(JSC::EvalCodeCache::get):

  • debugger/Debugger.cpp:

(JSC::evaluateInGlobalCallFrame):

  • debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::evaluate):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::callEval):
(JSC::Interpreter::execute):

  • interpreter/Interpreter.h:
  • parser/Nodes.cpp:

(JSC::FunctionBodyNode::createNativeThunk):
(JSC::FunctionBodyNode::generateBytecode):
(JSC::FunctionBodyNode::bytecodeForExceptionInfoReparse):

  • parser/Parser.h:

(JSC::Parser::parse):
(JSC::Parser::reparse):
(JSC::Parser::parseFunctionFromGlobalCode):
(JSC::::parse):

  • runtime/Completion.cpp:

(JSC::checkSyntax):
(JSC::evaluate):

  • runtime/Error.cpp:

(JSC::throwError):

  • runtime/Error.h:
  • runtime/Executable.h: Added.

(JSC::TemplateExecutable::TemplateExecutable):
(JSC::TemplateExecutable::markAggregate):
(JSC::TemplateExecutable::sourceURL):
(JSC::TemplateExecutable::lineNo):
(JSC::TemplateExecutable::bytecode):
(JSC::TemplateExecutable::jitCode):
(JSC::EvalExecutable::EvalExecutable):
(JSC::ProgramExecutable::ProgramExecutable):

  • runtime/FunctionConstructor.cpp:

(JSC::constructFunction):

  • runtime/FunctionConstructor.h:
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::numericCompareFunction):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::~JSGlobalObject):
(JSC::JSGlobalObject::markChildren):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::codeBlocks):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncEval):

4:25 PM Changeset in webkit [47303] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Build fix.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::enumerate): Add the necessary .get() calls.

4:21 PM Changeset in webkit [47302] by beidson@apple.com
  • 4 edits in trunk

WebKit/mac: <rdar://problem/7091546> - Assertion failure in plugins/return-error-from-new-stream-doesnt-invoke-destroy-stream.html
on 64-bit SnowLeopard

Reviewed by Anders Carlsson.

  • Plugins/Hosted/HostedNetscapePluginStream.mm:

(WebKit::HostedNetscapePluginStream::cancelLoad): Since this might be called while the FrameLoader is switching DocumentLoaders

during the brief moment where there is no activeDocumentLoader(), accept and handle a validly null DocumentLoader.

LayoutTests: <rdar://problem/7091546> - Re-enable 3 plugins tests that now won't crash

Reviewed by Anders Carlsson.

  • platform/mac-snowleopard/Skipped:
4:18 PM Changeset in webkit [47301] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Fix leaks of NSNumber and NSMutableArray objects seen during layout tests.

Reviewed by Brady Eidson.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::enumerate): Don't leak an NSMutableArray that we allocate.

4:18 PM Changeset in webkit [47300] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Fix leaks of HostedNetscapePluginStream and NetscapePlugInStreamLoader objects seen during layout tests.

Reviewed by Anders Carlsson.

  • Plugins/Hosted/HostedNetscapePluginStream.mm:

(WebKit::HostedNetscapePluginStream::didFail): Disconnect the stream from the plug-in instance proxy
when the load fails.

3:06 PM Changeset in webkit [47299] by bfulgham@webkit.org
  • 2 edits in trunk/WebCore

Correct libcurl crash when downloading local files.
​https://bugs.webkit.org/show_bug.cgi?id=28312

Reviewed by Kevin Ollivier.

No new tests. Test is covered by fast/encoding/char-encoding-mac.html.

  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::handleLocalReceiveResponse): New static function that

performs the local setting of valid URL and firing didReceiveResponse.
This code was moved from writeCallback.

(WebCore::writeCallback): Move local file handling to static function

(above) and use the function instead.

(WebCore::readCallback): Add check

for responseFired, and handle as a local file if it was not.

2:54 PM Changeset in webkit [47298] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

Adding two more to the skipped list.
Radars 7144571 and 7144583 track exploring them.

  • platform/mac-snowleopard/Skipped:
1:54 PM Changeset in webkit [47297] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

Disable media/controls-drag-timebar.html on SnowLeopard.
<rdar://problem/7144385> tracks exploring the failure.

  • platform/mac-snowleopard/Skipped:
1:52 PM Changeset in webkit [47296] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-08-14 Maxime Simon <Maxime Simon>

Reviewed by Oliver Hunt.

[Haiku] Fix RenderThemeHaiku build.
​https://bugs.webkit.org/show_bug.cgi?id=28307

  • platform/haiku/RenderThemeHaiku.cpp: Included RenderThemeHaiku.h instead of RenderTheme.h. (WebCore::RenderThemeHaiku::paintCheckbox): Removed the wrong 'virtual' before the function. (WebCore::RenderThemeHaiku::paintRadio): Removed the wrong 'virtual' before the function.
  • platform/haiku/RenderThemeHaiku.h: Corrected wrong function definitions.
1:35 PM Changeset in webkit [47295] by eric@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2009-08-14 Maxime Simon <Maxime Simon>

Reviewed by Oliver Hunt.

[Haiku] Adding SharedBufferHaiku to WebCore.
​https://bugs.webkit.org/show_bug.cgi?id=28309

  • platform/haiku/SharedBufferHaiku.cpp: Added. (WebCore::SharedBuffer::createWithContentsOfFile):
  • platform/haiku/TemporaryLinkStubs.cpp: Removed unnecessary headers and functions. (WebCore::signedPublicKeyAndChallengeString): (WebCore::getSupportedKeySizes):
1:29 PM Changeset in webkit [47294] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-14 Eric Seidel <​eric@webkit.org>

No review. Fix 5-space indent to be 4-spaces.

  • Scripts/bugzilla-tool:
1:20 PM Changeset in webkit [47293] by Nate Chapin
  • 2 edits in trunk/WebCore

2009-08-14 Nate Chapin <Nate Chapin>

Reviewed by Dimitri Glazkov.

Ensure we're getting the right v8 context in the V8 DOMWindowEvent custom getter.

​https://bugs.webkit.org/show_bug.cgi?id=28311

This should fix Chromium failing LayoutTests/fast/events/set-event-in-another-frame.html.

  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::ACCESSOR_GETTER):
1:18 PM Changeset in webkit [47292] by oliver@apple.com
  • 10 edits in trunk

[ES5] Arguments object should inherit from Array
​https://bugs.webkit.org/show_bug.cgi?id=28298

Reviewed by Gavin Barraclough

Make the Arguments object conform to the behaviour specified in ES5.
The simple portion of this is to make Arguments use Array.prototype
as its prototype rather than Object.prototype.

The spec then requires us to set instance.constructor to the pristine
Object constructor, and instance.toString and instance.toLocaleString
to the pristine versions from Object.prototype. To do this we now
make the ObjectPrototype constructor return its toString and
toLocaleString functions (similar to the call and apply functions
from FunctionPrototype).

Oddly enough this reports itself as a slight win, but given the code
isn't hit in the tests that claim to have improved I put this down to
code motion.

12:25 PM Changeset in webkit [47291] by eric@webkit.org
  • 11 edits in trunk/WebCore

2009-08-14 Aaron Boodman <​aa@chromium.org>

Reviewed by Alexey Proskuryakov.

BUG 28134: Move the remaining parts of Access Control from XMLHttpRequest to ThreadableDocumentLoader.
​https://bugs.webkit.org/show_bug.cgi?id=28134

No new tests added since Access Control was already well tested and this is a pure refactor.

  • loader/DocumentThreadableLoader.cpp: Move a lot of the access control code from XHR in, preserving its basic strategy. Also, modify the synchronous path to not be a special case, but reuse more of the async path.

(WebCore::DocumentThreadableLoader::loadResourceSynchronously): Go through the async path and pass additional flags.
(WebCore::DocumentThreadableLoader::create): Group enum params into an options struct.
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Ditto.
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest): Brought mostly from XHR.
(WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequestWithPreflight): Ditto.
(WebCore::DocumentThreadableLoader::willSendRequest): Handle preflight case.
(WebCore::DocumentThreadableLoader::didReceiveResponse): Ditto.
(WebCore::DocumentThreadableLoader::didFinishLoading): Ditto.
(WebCore::DocumentThreadableLoader::getShouldUseCredentialStorage): Ditto.
(WebCore::DocumentThreadableLoader::preflightSuccess): Preflight handling.
(WebCore::DocumentThreadableLoader::preflightFailure): Ditto.
(WebCore::DocumentThreadableLoader::loadRequest): Common request function that handles async/sync.

  • loader/DocumentThreadableLoader.h: Group enum params into an options struct.
  • loader/ThreadableLoader.cpp: Ditto. (WebCore::ThreadableLoader::create): Ditto. (WebCore::ThreadableLoader::loadResourceSynchronously): Ditto.
  • loader/ThreadableLoader.h: Ditto. (WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions): Ditto.
  • loader/WorkerThreadableLoader.cpp: Ditto. (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):Ditto. (WebCore::WorkerThreadableLoader::loadResourceSynchronously): Ditto. (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): Ditto. (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader): Ditto.
  • loader/WorkerThreadableLoader.h: Ditto. (WebCore::WorkerThreadableLoader::create): Ditto.
  • platform/CrossThreadCopier.h: Allow ThreadableLoaderOptions to be copied across threads. (WebCore::):
  • workers/WorkerScriptLoader.cpp: More enum->struct grouping. (WebCore::WorkerScriptLoader::loadSynchronously): More enum->struct grouping. (WebCore::WorkerScriptLoader::loadAsynchronously): More enum->struct grouping.
  • xml/XMLHttpRequest.cpp: Remove all the access control code and some supporting state. (WebCore::XMLHttpRequest::XMLHttpRequest): Ditto. (WebCore::XMLHttpRequest::createRequest): Ditto. (WebCore::XMLHttpRequest::didFinishLoading): Ditto. (WebCore::XMLHttpRequest::didReceiveResponse): Ditto. (WebCore::XMLHttpRequest::didReceiveData): Ditto.
  • xml/XMLHttpRequest.h: Ditto.
11:49 AM Changeset in webkit [47290] by Darin Adler
  • 2 edits in trunk/JavaScriptGlue

Rename the confusing isObject(<class>) to inherits(<class>).
It still works on non-objects, returning false.

Patch by Darin Adler <Darin Adler> on 2009-08-14
Reviewed by Sam Weinig.

  • JSUtils.cpp:

(KJSValueToJSObject):
(KJSValueToCFTypeInternal):
Changed from isObject to inherits.

11:25 AM Changeset in webkit [47289] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

2009-08-14 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Adam Roben.

Remove media/video-played.html from the Windows skipped list, fixed
as part of ​https://bugs.webkit.org/show_bug.cgi?id=28275. Add
media/video-played-collapse.html for now.


​https://bugs.webkit.org/show_bug.cgi?id=28275

  • platform/win/Skipped:
11:12 AM Changeset in webkit [47288] by Darin Adler
  • 26 edits in trunk

JavaScriptCore: Rename the confusing isObject(<class>) to inherits(<class>).
It still works on non-objects, returning false.

Patch by Darin Adler <Darin Adler> on 2009-08-14
Reviewed by Sam Weinig.

  • runtime/ArrayConstructor.cpp:

(JSC::arrayConstructorIsArray): Removed unneeded isObject call
and updated remaining isObject call to new name, inherits.

  • runtime/JSCell.h: Renamed isObject(<class>) to inherits(<class>)

but more importantly, made it non-virtual (it was already inline)
so it is now as fast as JSObject::inherits was.

  • runtime/JSObject.h: Removed inherits function since the one

in the base class is fine as-is. Also made various JSCell functions
that should not be called on JSObject uncallable by making them
both private and not implemented.
(JSC::JSCell::inherits): Updated name.
(JSC::JSValue::inherits): Ditto.

  • debugger/Debugger.cpp:

(JSC::Debugger::recompileAllJSFunctions):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::unwindCallFrame):

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncConcat):

  • runtime/BooleanPrototype.cpp:

(JSC::booleanProtoFuncToString):
(JSC::booleanProtoFuncValueOf):

  • runtime/DateConstructor.cpp:

(JSC::constructDate):

  • runtime/DatePrototype.cpp:

(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToISOString):
(JSC::dateProtoFuncToDateString):
(JSC::dateProtoFuncToTimeString):
(JSC::dateProtoFuncToLocaleString):
(JSC::dateProtoFuncToLocaleDateString):
(JSC::dateProtoFuncToLocaleTimeString):
(JSC::dateProtoFuncGetTime):
(JSC::dateProtoFuncGetFullYear):
(JSC::dateProtoFuncGetUTCFullYear):
(JSC::dateProtoFuncToGMTString):
(JSC::dateProtoFuncGetMonth):
(JSC::dateProtoFuncGetUTCMonth):
(JSC::dateProtoFuncGetDate):
(JSC::dateProtoFuncGetUTCDate):
(JSC::dateProtoFuncGetDay):
(JSC::dateProtoFuncGetUTCDay):
(JSC::dateProtoFuncGetHours):
(JSC::dateProtoFuncGetUTCHours):
(JSC::dateProtoFuncGetMinutes):
(JSC::dateProtoFuncGetUTCMinutes):
(JSC::dateProtoFuncGetSeconds):
(JSC::dateProtoFuncGetUTCSeconds):
(JSC::dateProtoFuncGetMilliSeconds):
(JSC::dateProtoFuncGetUTCMilliseconds):
(JSC::dateProtoFuncGetTimezoneOffset):
(JSC::dateProtoFuncSetTime):
(JSC::setNewValueFromTimeArgs):
(JSC::setNewValueFromDateArgs):
(JSC::dateProtoFuncSetYear):
(JSC::dateProtoFuncGetYear):

  • runtime/FunctionPrototype.cpp:

(JSC::functionProtoFuncToString):

  • runtime/JSActivation.cpp:

(JSC::JSActivation::argumentsGetter):

  • runtime/JSValue.h:
  • runtime/RegExpConstructor.cpp:

(JSC::constructRegExp):

  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncTest):
(JSC::regExpProtoFuncExec):
(JSC::regExpProtoFuncCompile):
(JSC::regExpProtoFuncToString):

  • runtime/ScopeChain.cpp:

(JSC::ScopeChain::localDepth):

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncToString):
(JSC::stringProtoFuncMatch):
(JSC::stringProtoFuncSearch):
(JSC::stringProtoFuncSplit):
Updated to new name, inherits, from old name, isObject.

WebCore: Rename the confusing isObject(<class>) to inherits(<class>).
It still works on non-objects, returning false.

Patch by Darin Adler <Darin Adler> on 2009-08-14
Reviewed by Sam Weinig.

  • bindings/js/JSEventTarget.cpp:

(WebCore::toEventTarget):

  • bindings/js/JSGeolocationCustom.cpp:

(WebCore::createPositionCallback):
(WebCore::createPositionErrorCallback):

  • bindings/js/JSNodeFilterCustom.cpp:

(WebCore::toNodeFilter):

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::send):

  • bindings/js/JSXSLTProcessorCustom.cpp:

(WebCore::JSXSLTProcessor::importStylesheet):
(WebCore::JSXSLTProcessor::transformToFragment):
(WebCore::JSXSLTProcessor::transformToDocument):

  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::callObjCFallbackObject):

  • bridge/runtime_method.cpp:

(JSC::callRuntimeMethod):
Updated to new name, inherits, from old name, isObject.

10:58 AM Changeset in webkit [47287] by eric.carlson@apple.com
  • 4 edits
    2 moves in trunk/LayoutTests

2009-08-14 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Simon Fraser.

media/video-played.html always times out on Windows
​https://bugs.webkit.org/show_bug.cgi?id=28275

  • media/video-played-collapse.html:

Make sub-test assumptions obvious for someone reading this later.

  • media/video-played.html: Removed.
  • media/video-played-expected.txt: Removed.
  • media/video-played-ranges-1-expected.txt: Copied from LayoutTests/media/video-played-expected.txt.
  • media/video-played-ranges-1.html: Copied from LayoutTests/media/video-played.html.

Split video-played.html into video-played-ranges-1.html and video-played-ranges-2.html.

  • media/video-played-reset.html:

Make sub-test assumptions obvious for someone reading this later.

  • media/video-played.js: (logRanges):

New but not currently called. Allows all ranges to be logged for debugging.

(testRanges):

Log ranges and the amount of time each test takes when logTestTiming != 0.

(nextTest):

Record test start time when logTestTiming is true;

(startPlaying):

Run each sub-test for 100ms instead of 250ms to decrease overall test time.

(playForMillisecs.callPauseIfTimeIsReached):
(playForMillisecs):

Make error conditions trigger immediate failure instead of just logging.

8:51 AM Changeset in webkit [47286] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-08-14 Benjamin Otte <​otte@gnome.org>

Reviewed by Gustavo Noronha.

Fix webkit_web_view_set_highlight_text_matches() so that highlighting
works properly in documents with frames.

  • webkit/webkitwebview.cpp: (webkit_web_view_set_highlight_text_matches):
7:50 AM Changeset in webkit [47285] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

RVCT elftran fails to resolve QPainter::staticMetaObject coming with
QWebView::RenderHints property.

Patch by Yongjun Zhang <​yongjun.zhang@nokia.com> on 2009-08-14
Reviewed by Simon Hausmann.

This is a temporary fix and will be revereted when the right symbols
exported from Qt lib in S60.

​https://bugs.webkit.org/show_bug.cgi?id=28181

  • Api/qwebview.h:
7:44 AM Changeset in webkit [47284] by Simon Hausmann
  • 4 edits in trunk

Adding QNX as a platform. Currently only tested with Qt.

Patch by Harald Fernengel <​harald.fernengel@nokia.com> on 2009-07-31
Reviewed by Simon Hausmann.

​https://bugs.webkit.org/show_bug.cgi?id=27885

  • JavaScriptCore/runtime/Collector.cpp: Added retrieving of stack base since QNX doesn't have the pthread _nt functions
  • JavaScriptCore/wtf/Platform.h: Added WTF_PLATFORM_QNX and corresponding defines
  • WebCore/bridge/npapi.h: Build fix for missing typedefs on QNX
7:21 AM Changeset in webkit [47283] by Simon Hausmann
  • 8 edits in trunk

WebKit/qt: [Qt] Public API to configure the storage path for HTML5 localStorage
​https://bugs.webkit.org/show_bug.cgi?id=28036

Patch by Laszlo Gombos <Laszlo Gombos> on 2009-08-14
Reviewed by Simon Hausmann.

Disables LocalStorage for QtWebKit by default by setting
QWebSettings::LocalStorageEnabled to false.

Sets up a default for the LocalStorage path so that clients would only
need to enable the LocalStorageEnabled setting to turn on LocalStoragre
support.

Turn on LocalStorage support for QtLauncher and the relevant test
since LocalStorage is now disabled by default for QtWebkit.

  • Api/qwebpage.cpp:

(defaultCachePath):
(initializeApplicationCachePathIfNecessary):
(QWebPagePrivate::QWebPagePrivate):

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):
(QWebSettings::QWebSettings):
(QWebSettings::setLocalStoragePath):
(QWebSettings::localStoragePath):

  • Api/qwebsettings.h:
  • QtLauncher/main.cpp:

(main):

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::multiplePageGroupsAndLocalStorage):

WebKitTools: [Qt] Public API to configure the storage path for HTML5 localStorage
​https://bugs.webkit.org/show_bug.cgi?id=28036

Patch by Laszlo Gombos <Laszlo Gombos> on 2009-08-14
Reviewed by Simon Hausmann.

Turn on LocalStorage support for Qt DumpRenderTree since
LocalStorage is now disabled by defult for QtWebkit.

  • DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::WebPage::WebPage):

7:19 AM Changeset in webkit [47282] by yael.aharon@nokia.com
  • 7 edits in trunk

WebCore: Allow Qt API to list and to remove URL schemes that were registered as
local URL schemes.
[Qt] Allow applications to register their own local URL scheme.
​https://bugs.webkit.org/show_bug.cgi?id=28240

Patch by Yael Aharon <​yael.aharon@nokia.com> on 2009-08-14
Reviewed by Simon Hausmann.

5:54 AM Changeset in webkit [47281] by Simon Hausmann
  • 2 edits in trunk/PlanetWebKit

Add the blog of University of Szeged.
​https://bugs.webkit.org/show_bug.cgi?id=28301

Patch by Csaba Osztrogonac <​oszi@inf.u-szeged.hu> on 2009-08-14
Reviewed by Simon Hausmann.

  • config.ini:
5:05 AM Changeset in webkit [47280] by xan@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-14 Xan Lopez <​xlopez@igalia.com>

Reviewed by Jan Alonzo.

Do not unref the main webview, it's owned by its parent
container. Instead destroy the container, which should take care
of everything (not terribly important since we exit right after
that, but still).

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (main):
5:01 AM Changeset in webkit [47279] by ariya@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2009-08-14 Ariya Hidayat <​ariya.hidayat@nokia.com>

Rubber-stamped by Tor Arne Vestbø.

[Qt] Add test result after r47255.

  • platform/qt/fast/block/float/avoidance-percent-width-compat-expected.txt: Added.
  • platform/qt/fast/block/float/avoidance-percent-width-strict-expected.txt: Added.
4:49 AM Changeset in webkit [47278] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

Currently generic ARM and ARMv7 platforms work only with JSVALUE32
​https://bugs.webkit.org/show_bug.cgi?id=28300

Patch by Gabor Loki <​loki@inf.u-szeged.hu> on 2009-08-14
Reviewed by Simon Hausmann.

  • wtf/Platform.h:
4:39 AM Changeset in webkit [47277] by pfeldman@chromium.org
  • 7 edits in trunk/WebCore

2009-08-14 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Wrap console objects late (in the frontend) so that injected
script was already in place.

​https://bugs.webkit.org/show_bug.cgi?id=28297

  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage):
  • inspector/ConsoleMessage.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::addMessageToConsole): (WebCore::InspectorController::startGroup): (WebCore::InspectorController::setFrontendProxyObject):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::InspectorFrontend): (WebCore::InspectorFrontend::addMessageToConsole):
  • inspector/InspectorFrontend.h:
3:56 AM Changeset in webkit [47276] by vestbo@webkit.org
  • 1 edit in trunk/JavaScriptCore/runtime/ArrayConstructor.cpp

Try to fix the build when !JIT_OPTIMIZE_NATIVE_CALL

3:12 AM Changeset in webkit [47275] by ariya@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

2009-08-14 Ariya Hidayat <​ariya.hidayat@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Update test result after r47255.
Also while I am at it, add pixel test result.

  • platform/qt/fast/block/float/035-expected.checksum: Added.
  • platform/qt/fast/block/float/035-expected.png: Added.
  • platform/qt/fast/block/float/035-expected.txt: Adjusted.
2:17 AM Changeset in webkit [47274] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

Enable JIT on ARM for QT by default
​https://bugs.webkit.org/show_bug.cgi?id=28259

Patch by Gabor Loki <​loki@inf.u-szeged.hu> on 2009-08-14
Reviewed by Simon Hausmann.

  • wtf/Platform.h:
2:17 AM Changeset in webkit [47273] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

Enable YARR_JIT on ARM for QT by default
​https://bugs.webkit.org/show_bug.cgi?id=28259

Patch by Gabor Loki <​loki@inf.u-szeged.hu> on 2009-08-14
Reviewed by Simon Hausmann.

  • wtf/Platform.h:
12:09 AM Changeset in webkit [47272] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Remove MarkStack::drain from the JSC exports file

MarkStack::drain is now marked inline, the including it in the exports file
produces an ld warning

12:00 AM Changeset in webkit [47271] by oliver@apple.com
  • 6 edits
    3 adds in trunk

[ES5] Implement Array.isArray
​https://bugs.webkit.org/show_bug.cgi?id=28296

Reviewed by Maciej Stachowiak

Add support for Array.isArray to the Array constructor

Aug 13, 2009:

11:22 PM Changeset in webkit [47270] by Simon Fraser
  • 3 edits
    2 adds in trunk

2009-08-13 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Fix logic in RenderObject::updateFillImages() that led to incorrect client
counts if an image was used twice in the background-image property.
​https://bugs.webkit.org/show_bug.cgi?id=28295

Test: fast/backgrounds/multiple-backgrounds-assert.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::updateFillImages): Simplify the logic to call addClient()/removeClient() for every background image, but go through the new layers first to avoid removing all the clients of an image.
11:11 PM Changeset in webkit [47269] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

Remove accidentally left in debugging statement.

Reviewed by Oliver Hunt.

  • runtime/JSArray.h:

(JSC::MarkStack::drain):

10:41 PM Changeset in webkit [47268] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Attempt to fix windows build

10:35 PM Changeset in webkit [47267] by oliver@apple.com
  • 31 edits in trunk

Devirtualise marking
​https://bugs.webkit.org/show_bug.cgi?id=28294

Reviewed by Maciej Stachowiak.

Add a bit to TypeInfo to indicate that an object uses the standard
JSObject::markChildren method. This allows us to devirtualise marking
of most objects (though a branch is still needed). We also add a branch
to identify arrays thus devirtualising marking in that case as well.

In order to make the best use of this devirtualisation I've also reworked
the MarkStack::drain() logic to make the iteration more efficient.

9:31 PM Changeset in webkit [47266] by jmalonzo@webkit.org
  • 4 edits in trunk

Revert "2009-08-13 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>"

Revert ​http://trac.webkit.org/changeset/47203 as it makes the http/XHR tests fail.

6:15 PM Changeset in webkit [47265] by Darin Adler
  • 8 edits
    1 delete in trunk

JavaScriptCore: Some small bits of housekeeping.

Patch by Darin Adler <Darin Adler> on 2009-08-13
Reviewed by Mark Rowe.

project instead of private. Remove JSONObject.lut.h.

  • assembler/ARMAssembler.h: Remove unneeded WTF prefix.
  • assembler/AssemblerBufferWithConstantPool.h: Ditto.
  • bytecompiler/BytecodeGenerator.h: Ditto.
  • wtf/SegmentedVector.h: Add a "using" statement as we do

with the other WTF headers.

WebCore: Follow-up to earlier work to remove dependencies on JavaScriptCore.

Patch by Darin Adler <Darin Adler> on 2009-08-13
Reviewed by Mark Rowe.

  • ForwardingHeaders/parser/Parser.h: Removed.
  • inspector/JavaScriptDebugServer.cpp: Removed now-unneeded includes

of Parser.h.

6:11 PM Changeset in webkit [47264] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

Fix Tiger build.

Patch by Darin Adler <Darin Adler> on 2009-08-13

  • parser/Grammar.y: Use a template function so we can compile

setStatementLocation even if it comes before YYLTYPE is defined.

5:58 PM Changeset in webkit [47263] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

Too much use of void* in Grammar.y
​https://bugs.webkit.org/show_bug.cgi?id=28287

Patch by Darin Adler <Darin Adler> on 2009-08-13
Reviewed by George Staikos.

  • parser/Grammar.y: Changed all the helper functions to

take a JSGlobalData* instead of a void*. A couple formatting
tweaks that I missed when breaking this into pieces.

5:56 PM Changeset in webkit [47262] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

Another part of ​https://bugs.webkit.org/show_bug.cgi?id=28287

Patch by Darin Adler <Darin Adler> on 2009-08-13
Reviewed by George Staikos.

  • parser/Grammar.y: Reduced and sorted includes. Tweaked comment

format. Marked a few more functions inline.

5:52 PM Changeset in webkit [47261] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore: 'box-orient: block-axis' behaves like 'box-orient: horizontal', causes
an assertion failure in debug builds
​https://bugs.webkit.org/show_bug.cgi?id=28279

Reviewed by Eric Seidel.

Test: fast/flexbox/block-axis.html

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::operator EBoxOrient): Map block-axis to
vertical.

LayoutTests: 2009-08-13 Dan Bernstein <​mitz@apple.com>

Reviewed by Eric Seidel.

'box-orient: block-axis' behaves like 'box-orient: horizontal', causes
an assertion failure in debug builds
​https://bugs.webkit.org/show_bug.cgi?id=28279

  • fast/flexbox/block-axis-expected.checksum: Added.
  • fast/flexbox/block-axis-expected.png: Added.
  • fast/flexbox/block-axis-expected.txt: Added.
  • fast/flexbox/block-axis.html: Added.
5:51 PM Changeset in webkit [47260] by Simon Fraser
  • 4 edits
    2 adds in trunk

2009-08-13 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Fix crash when removing reflection on an absolutely-positioned image.
​https://bugs.webkit.org/show_bug.cgi?id=28289

Make sure we clean up the reflection layer when removing the reflection,
so that the RenderLayer tree does not contain pointers to deleted layers.

Test: fast/reflections/reflected-img-crash.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::~RenderLayer): (WebCore::RenderLayer::styleChanged): (WebCore::RenderLayer::removeReflection):
  • rendering/RenderLayer.h:
5:49 PM Changeset in webkit [47259] by Darin Adler
  • 4 edits in trunk/JavaScriptCore

Another part of ​https://bugs.webkit.org/show_bug.cgi?id=28287

Patch by Darin Adler <Darin Adler> on 2009-08-13
Reviewed by George Staikos.

  • parser/Grammar.y: Pass the number to the PropertyNode instead of

first turning it into an Identifier.

  • parser/NodeConstructors.h:

(JSC::PropertyNode::PropertyNode): Add an overload that takes a double
so the code to convert to a string can be here instead of Grammar.y.

  • parser/Nodes.h: Ditto.
5:47 PM Changeset in webkit [47258] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

Another part of ​https://bugs.webkit.org/show_bug.cgi?id=28287

Patch by Darin Adler <Darin Adler> on 2009-08-13
Reviewed by George Staikos.

  • parser/Grammar.y: Eliminate the DBG macro.
5:46 PM Changeset in webkit [47257] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

Another part of ​https://bugs.webkit.org/show_bug.cgi?id=28287

Patch by Darin Adler <Darin Adler> on 2009-08-13
Reviewed by George Staikos.

  • parser/Grammar.y: Eliminate the SET_EXCEPTION_LOCATION macro.
5:44 PM Changeset in webkit [47256] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

George asked me to break the patch from
​https://bugs.webkit.org/show_bug.cgi?id=28287
into smaller pieces and land it in stages.

Patch by Darin Adler <Darin Adler> on 2009-08-13
Reviewed by George Staikos.

  • parser/Grammar.y: Eliminate the LEXER macro.
5:40 PM Changeset in webkit [47255] by mitz@apple.com
  • 18 edits
    8 adds in trunk

WebCore: misalignment because of float:left of <div> tag
​https://bugs.webkit.org/show_bug.cgi?id=15869

Reviewed by Simon Fraser.

One section of ​http://edgar.sec.gov site draws to the right of the rest
of the content
<rdar://problem/7135951>

Tests: fast/block/float/avoidance-percent-width-compat.html

fast/block/float/avoidance-percent-width-strict.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::getClearDelta): Changed to apply the same float

avoidance logic in strict mode and in compatibility mode, which
matches Firefox and IE. Changed to compute and use the computed
width of the child, instead of ignoring non-fixed widths.

LayoutTests: misalignment because of float:left of <div> tag
​https://bugs.webkit.org/show_bug.cgi?id=15869

Reviewed by Simon Fraser.

One section of ​http://edgar.sec.gov site draws to the right of the rest
of the content
<rdar://problem/7135951>

  • fast/block/float/avoidance-percent-width-compat.html: Added.
  • fast/block/float/avoidance-percent-width-strict.html: Added.
  • platform/mac/fast/block/float/035-expected.checksum:
  • platform/mac/fast/block/float/035-expected.png:
  • platform/mac/fast/block/float/035-expected.txt:
  • platform/mac/fast/block/float/avoidance-percent-width-compat-expected.checksum: Added.
  • platform/mac/fast/block/float/avoidance-percent-width-compat-expected.png: Added.
  • platform/mac/fast/block/float/avoidance-percent-width-compat-expected.txt: Added.
  • platform/mac/fast/block/float/avoidance-percent-width-strict-expected.checksum: Added.
  • platform/mac/fast/block/float/avoidance-percent-width-strict-expected.png: Added.
  • platform/mac/fast/block/float/avoidance-percent-width-strict-expected.txt: Added.
  • platform/mac/fast/block/float/float-avoidance-expected.checksum:
  • platform/mac/fast/block/float/float-avoidance-expected.png:
  • platform/mac/fast/block/float/float-avoidance-expected.txt:
  • platform/mac/fast/overflow/004-expected.checksum:
  • platform/mac/fast/overflow/004-expected.png:
  • platform/mac/fast/overflow/004-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug106158-1-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug106158-1-expected.png:
  • platform/mac/tables/mozilla/bugs/bug106158-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug106158-2-expected.checksum:
  • platform/mac/tables/mozilla/bugs/bug106158-2-expected.png:
  • platform/mac/tables/mozilla/bugs/bug106158-2-expected.txt:
5:14 PM Changeset in webkit [47254] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-13 Eric Seidel <​eric@webkit.org>

No review, only skipping tests.

Qt: Font Sizes are wrong for font families including monospace
​https://bugs.webkit.org/show_bug.cgi?id=28288

  • platform/qt/Skipped:
4:34 PM Changeset in webkit [47253] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-13 Eric Seidel <​eric@webkit.org>

No review, correcting obvious python error seen in the commit queue.

args can be a string or an array. Assuming args is always an array results in
double-spaced text in error logs.

  • Scripts/bugzilla-tool:
4:34 PM Changeset in webkit [47252] by Darin Adler
  • 5 edits
    3 adds in trunk

WebCore: Geolocation PositionOptions does not use correct default values.
​https://bugs.webkit.org/show_bug.cgi?id=27254

Patch by Steve Block <​steveblock@google.com> on 2009-08-13
Reviewed by Darin Adler.

Sets the correct default values for the properties of the PositionOptions object
passed to Geolocation methods. See ​http://www.w3.org/TR/geolocation-API/.

Also adds checking to throw an exception if arguments of the incorrect type are
passed to Geolocation methods. Adds a layout test to test this. This test should
pass on all platforms where Geolocation is implemented.

Test: fast/dom/Geolocation/argument-types.html

  • bindings/js/JSGeolocationCustom.cpp:

(WebCore::createPositionCallback): Added. Creates the callback.
(WebCore::createPositionErrorCallback): Added. Creates the calback.
(WebCore::createPositionOptions): Added. Creates the PositionOptions object, setting defaults where required.
(WebCore::JSGeolocation::getCurrentPosition): Modified. Now uses above helper functions.
(WebCore::JSGeolocation::watchPosition): Modified. Now uses above helper functions.

  • page/Geolocation.cpp:

(WebCore::Geolocation::GeoNotifier::GeoNotifier): Modified. Asserts that PositionOptions object is present.
(WebCore::Geolocation::GeoNotifier::startTimer): Modified. Only starts timer if timeout has been set.

  • page/PositionOptions.h:

(WebCore::PositionOptions::create): Modified. Creates object with default values.
(WebCore::PositionOptions::timeout): Modified. Uses correct type.
(WebCore::PositionOptions::hasTimeout): Added. Determines whether a timeout has been set.
(WebCore::PositionOptions::setTimeout): Modified. Uses correct type.
(WebCore::PositionOptions::maximumAge): Modified. Uses correct type.
(WebCore::PositionOptions::setMaximumAge): Modified. Uses correct type.
(WebCore::PositionOptions::PositionOptions): Modified. Creates object with default values.

LayoutTests: Geolocation PositionOptions does not use correct default values.
​https://bugs.webkit.org/show_bug.cgi?id=27254

Patch by Steve Block <​steveblock@google.com> on 2009-08-13
Reviewed by Darin Adler.

Adds a layout test to check the acceptable types for arguments to Geolocation methods.

  • fast/dom/Geolocation/resources/argument-types.js: Added. Tests the types of the arguments that can be passed to Geolocation methods.
  • fast/dom/Geolocation/argument-types.html: Added. HTML wrapper for above JS test.
  • fast/dom/Geolocation/argument-types-expected.txt: Added. Expected output for above test.
4:31 PM Changeset in webkit [47251] by eric@webkit.org
  • 1 edit
    3 deletes in trunk/LayoutTests

2009-08-13 Eric Seidel <​eric@webkit.org>

Rubber-stamped by Mark Rowe.

wrong font size when css font-family includes monospace
​https://bugs.webkit.org/show_bug.cgi?id=19161

Removing results which are expected to change, but that I have no way to update.

  • platform/mac-tiger/fast/text/monospace-width-cache-expected.checksum: Removed.
  • platform/mac-tiger/fast/text/monospace-width-cache-expected.png: Removed.
  • platform/qt/fast/text/monospace-width-cache-expected.txt: Removed.
4:28 PM Changeset in webkit [47250] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-13 Eric Seidel <​eric@webkit.org>

No review, it is expected that this would change.

wrong font size when css font-family includes monospace
​https://bugs.webkit.org/show_bug.cgi?id=19161

Update Tiger results from the bot. I have no way to update the pixel results.

  • platform/mac-tiger/fast/text/monospace-width-cache-expected.txt:
4:24 PM Changeset in webkit [47249] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-08-13 David Levin <​levin@chromium.org>

Unreviewed chromium build fix.

[Chromium] Let CodeGeneratorV8.pm know that RGBColor is ref-counted.

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
4:23 PM CommitQueue edited by eric@webkit.org
(diff)
4:18 PM CommitQueue edited by eric@webkit.org
(diff)
4:08 PM CommitQueue edited by eric@webkit.org
(diff)
4:05 PM CommitQueue edited by eric@webkit.org
(diff)
4:04 PM CommitQueue edited by eric@webkit.org
(diff)
4:01 PM CommitQueue edited by eric@webkit.org
(diff)
3:59 PM CommitQueue created by eric@webkit.org
3:55 PM Changeset in webkit [47248] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-08-13 Drew Wilson <​atwilson@google.com>

Reviewed by David Levin.

Merge error in SharedWorker code
​https://bugs.webkit.org/show_bug.cgi?id=28277

Fixed merge error that prevents WebKit from compiling with SHARED_WORKERS enabled.
No new tests needed.

  • workers/DefaultSharedWorkerRepository.cpp: Removed duplicated functions.
3:54 PM WikiStart edited by eric@webkit.org
Add a link to the new commit queue page. (diff)
3:48 PM Changeset in webkit [47247] by ajwong@chromium.org
  • 2 edits in trunk/WebCore

Chromium: Show a "Playback Disabled" button on media error.
​https://bugs.webkit.org/show_bug.cgi?id=28196
Use a disabled play button when the media file cannot be played.

Patch by Kyle Prete <​kylep@chromium.org> on 2009-08-13
Reviewed by Dave Levin.

No new tests needed. Covered by LayoutTests/media/video-empty-source.html

  • rendering/RenderThemeChromiumSkia.cpp:

(WebCore::RenderThemeChromiumSkia::paintMediaPlayButton):

3:46 PM Changeset in webkit [47246] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

Try some more to fix the Windows build.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Export a new symbol.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Ditto.
3:45 PM Changeset in webkit [47245] by kov@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-13 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Unreviewed build fix. Include stdio.h for using stdout, stderr,
and fprintf.

  • DumpRenderTree/LayoutTestController.cpp:
3:42 PM Changeset in webkit [47244] by mrowe@apple.com
  • 4 edits in trunk

Try and fix the Qt build.

3:38 PM Changeset in webkit [47243] by eric@webkit.org
  • 5 edits in trunk/WebKit/gtk

2009-08-13 Zan Dobersek <​zandobersek@gmail.com>

Reviewed by Gustavo Noronha.

[GTK] Drag and drop support
​https://bugs.webkit.org/show_bug.cgi?id=23642

Adds support for drag actions in WebKitWebView and DragClient.

Defines a support structure that can hold additional drag and drop data,
such as selection data or target IDs (infos) and can be passed through
clipboard requests.

Implements DragClient functions that gather start position of the drag
and start the GTK drag.

  • WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::DragClient): (WebKit::DragClient::willPerformDragSourceAction): (WebKit::DragClient::startDrag): (WebKit::DragClient::createDragImageForLink): A small style fix.
  • WebCoreSupport/DragClientGtk.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_drag_end): (clipboard_contents_received): GtkClipboard callback. (webkit_web_view_drag_data_get): (webkit_web_view_class_init): (webkit_web_view_init):
  • webkit/webkitwebview.h: Add GTK selection targets.
3:38 PM Changeset in webkit [47242] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

Try and fix the Windows build.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Export a new symbol.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def: Ditto.
3:31 PM Changeset in webkit [47241] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-08-13 Zan Dobersek <​zandobersek@gmail.com>

Reviewed by Gustavo Noronha.

[GTK] Drag and drop support
​https://bugs.webkit.org/show_bug.cgi?id=23642

Utilizes functions that are being called upon drag and drop actions.
Uses different GTK clipboards that hold different types
of drag data - images, HTML markup, text, URL, URL label.
Also clears each clipboard before setting new data to it.

No new tests - despite some implementations, no new functionality
is added until implementations of the GTK drag and drop protocol
in WebKit part.

  • platform/gtk/ClipboardGtk.cpp: (WebCore::ClipboardGtk::ClipboardGtk): (WebCore::ClipboardGtk::~ClipboardGtk): (WebCore::getCachedImage): (WebCore::ClipboardGtk::declareAndWriteDragImage): (WebCore::ClipboardGtk::writeURL): (WebCore::ClipboardGtk::writeRange):
  • platform/gtk/ClipboardGtk.h: ClipboardGdk -> ClipboardGtk
3:27 PM Changeset in webkit [47240] by mrowe@apple.com
  • 9 edits in trunk

Roll out r47237 as it was mistakenly landed.

3:22 PM Changeset in webkit [47239] by bweinstein@apple.com
  • 9 edits in trunk/JavaScriptCore

Build fix so JavaScriptCore builds, might fail linking WebCore or WebKit. Added includes and removed a missing function from JavaScriptCore_debug.def and JavascriptCore.def.

3:22 PM Changeset in webkit [47238] by eric@webkit.org
  • 1 edit
    1 move in trunk/WebKitTools

2009-08-13 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Eric Seidel.

rename make-js-test-wrappers to make-script-test-wrappers
​https://bugs.webkit.org/show_bug.cgi?id=28212

  • Scripts/make-script-test-wrappers: Renamed from WebKitTools/Scripts/make-js-test-wrappers.
3:17 PM Changeset in webkit [47237] by bweinstein@apple.com
  • 9 edits in trunk

DRT improvements for Database stuff.

2:51 PM Changeset in webkit [47236] by Darin Adler
  • 43 edits
    1 delete in trunk

JavaScriptCore: JavaScriptCore tweaks to get ready for the parser arena
​https://bugs.webkit.org/show_bug.cgi?id=28243

Patch by Darin Adler <Darin Adler> on 2009-08-13
Reviewed by David Levin.

Eliminate dependencies on Nodes.h outside JavaScriptCore,
and cut down on them inside JavaScriptCore.

Change regular expression parsing to use identifiers as
with other strings we parse.

Fix a couple things that are needed to use const Identifier
more, which will be part of the parser arena work.

CollectorHeapIterator.h to be project-internal.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitPushNewScope): Added const.

  • bytecompiler/BytecodeGenerator.h: Ditto.
  • debugger/Debugger.cpp:

(JSC::Debugger::recompileAllJSFunctions): Moved this function
here from WebCore. Here is better since it uses so many internals.
Removed unimportant optimization for the no listener case.

  • debugger/Debugger.h: Ditto. Also removed unneeded include

and tweaked formatting and comments.

  • debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::functionName): Call asFunction instead
of doing the unchecked static_cast.
(JSC::DebuggerCallFrame::calculatedFunctionName): Ditto.

  • jit/JITStubs.cpp:

(JSC::op_call_JSFunction): Call isHostFunction on the body rather
than on the JSFunction.
(JSC::vm_lazyLinkCall): Ditto.
(JSC::op_construct_JSConstruct): Ditto.

  • parser/Grammar.y: Changed callers to use new scanRegExp with

out arguments instead of relying on state in the Lexer. And
callers that just want to skip a regular expression to use
skipRegExp.

  • parser/Lexer.cpp:

(JSC::Lexer::scanRegExp): Changed to use out arguments, and to
add a prefix argument so we can add in the "=" character as needed.
Also rewrote to streamline the logic a bit inspired by suggestions
by David Levin.
(JSC::Lexer::skipRegExp): Added. Version of the function above that
does not actually put the regular expression into a string.
(JSC::Lexer::clear): Removed code to clear m_pattern and m_flags.

  • parser/Lexer.h: Changed scanRegExp to have out arguments. Added

skipRegExp. Eliminated pattern, flags, m_pattern, and m_flags.

  • parser/NodeConstructors.h:

(JSC::RegExpNode::RegExpNode): Changed to take const Identifier&.

  • parser/Nodes.cpp:

(JSC::RegExpNode::emitBytecode): Changed since m_pattern and
m_flags are now Identifier instead of UString.
(JSC::FunctionBodyNode::make): Moved this function here instead
of putting it in the JSFunction.h header.

  • parser/Nodes.h: Changed RegExpNode to use Identifier.
  • profiler/Profiler.cpp:

(JSC::Profiler::createCallIdentifier): Changed to use isHostFunction
on the body instead of on the JSFunction object.

  • runtime/FunctionPrototype.cpp:

(JSC::functionProtoFuncToString): Ditto.

  • runtime/JSFunction.cpp:

(JSC::JSFunction::isHostFunction): Moved here from header.
(JSC::JSFunction::isHostFunctionNonInline): Added.
(JSC::JSFunction::JSFunction): Removed unneeded initialization of
m_body to 0.
(JSC::JSFunction::setBody): Moved here from header.

  • runtime/JSFunction.h: Removed unneeded includes. Moved private

constructor down to the private section. Made virtual functions
private. Removed unneeded overload of setBody and moved the body
of the function into the .cpp file. Changed assertions to use
the non-inline version of isHostFunction.

  • runtime/PropertySlot.cpp:

(JSC::PropertySlot::functionGetter): Use asFunction instead
of doing the unchecked static_cast.

  • wtf/SegmentedVector.h:

(WTF::SegmentedVector::isEmpty): Added.

WebCore: JavaScriptCore tweaks to get ready for the parser arena
​https://bugs.webkit.org/show_bug.cgi?id=28243

Patch by Darin Adler <Darin Adler> on 2009-08-13
Reviewed by David Levin.

  • ForwardingHeaders/runtime/CollectorHeapIterator.h: Removed.
  • WebCore.xcodeproj/project.pbxproj: Exposed a couple header

files as Private that are now needed to compile Mac WebKit.

  • bindings/js/JSAudioConstructor.cpp:
  • bindings/js/JSDOMBinding.cpp:
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSHTMLInputElementCustom.cpp:
  • bindings/js/JSHistoryCustom.cpp:
  • bindings/js/JSImageConstructor.cpp:
  • bindings/js/JSLazyEventListener.cpp:
  • bindings/js/JSLocationCustom.cpp:
  • bindings/js/JSMessageChannelConstructor.cpp:
  • bindings/js/JSOptionConstructor.cpp:
  • bindings/js/JSWebSocketConstructor.cpp:
  • bindings/js/JSWebSocketCustom.cpp:
  • bindings/js/JSWorkerConstructor.cpp:
  • bindings/js/JSXMLHttpRequestConstructor.cpp:
  • bridge/jni/jni_jsobject.mm:

Updated includes.

  • inspector/JavaScriptDebugServer.cpp:

(WebCore::JavaScriptDebugServer::sourceParsed):
Change to not assert if this is called with no listeners.
I don't think this was guaranteed before, and we now use
this code path when recompiling. Slightly less efficient,
but this is a one-time cost when turning on the debugger.
(WebCore::JavaScriptDebugServer::recompileAllJSFunctions):
Change to call Debugger::recompileAllJSFunctions.

WebKit/mac: * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Updated includes.

  • WebView/WebScriptDebugger.mm: Ditto.
2:38 PM Changeset in webkit [47235] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-13 Eric Seidel <​eric@webkit.org>

Rubber-stamped by Adam Roben.

REGRESSION: 6 media tests regressed while the windows bot was broken
​https://bugs.webkit.org/show_bug.cgi?id=28281

  • platform/win/Skipped:
2:36 PM Changeset in webkit [47234] by atwilson@chromium.org
  • 2 edits in trunk/WebKitTools

Unreviewed.

Patch by Drew Wilson <​atwilson@chromium.org> on 2009-08-13
Add myself to list of committers.

  • Scripts/modules/committers.py:
2:35 PM Changeset in webkit [47233] by beidson@apple.com
  • 12 edits
    2 adds in trunk

WebCore: <rdar://problem/7138591> and ​https://bugs.webkit.org/show_bug.cgi?id=28260
onhashchange property cannot be set from javascript.

Reviewed by Eric Seidel.

Test: fast/loader/onhashchange-attribute-listeners.html

  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::onhashchange):
(WebCore::HTMLBodyElement::setOnhashchange):

  • html/HTMLBodyElement.h:
  • html/HTMLBodyElement.idl:
  • html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::onhashchange):
(WebCore::HTMLFrameSetElement::setOnhashchange):

  • html/HTMLFrameSetElement.h:
  • html/HTMLFrameSetElement.idl:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::onhashchange):
(WebCore::DOMWindow::setOnhashchange):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:

LayoutTests: <rdar://problem/7138591> and ​https://bugs.webkit.org/show_bug.cgi?id=28260
onhashchange property cannot be set from javascript.

Reviewed by Eric Seidel.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/loader/onhashchange-attribute-listeners-expected.txt: Added.
  • fast/loader/onhashchange-attribute-listeners.html: Added.
2:27 PM Changeset in webkit [47232] by mrowe@apple.com
  • 3 edits in trunk/WebCore

Fix leaks of RGBColor instances from below SVGColor::rgbColor.

Reviewed by Geoff Garen.

  • svg/SVGColor.cpp:

(WebCore::SVGColor::rgbColor): Return a PassRefPtr to ensure that the newly-allocated
RGBColor is cleaned up by the caller.

  • svg/SVGColor.h:
2:12 PM Changeset in webkit [47231] by pfeldman@chromium.org
  • 35 edits in trunk/WebCore

2009-08-13 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Migrate to DOMAgent (serialized access to DOM).

​https://bugs.webkit.org/show_bug.cgi?id=28177

  • bindings/js/JSInspectorBackendCustom.cpp: (WebCore::JSInspectorBackend::highlightDOMNode): (WebCore::JSInspectorBackend::nodeForId): (WebCore::JSInspectorBackend::idForNode): (WebCore::JSInspectorBackend::wrapObject): (WebCore::JSInspectorBackend::unwrapObject): (WebCore::JSInspectorBackend::pushNodePathToFrontend): (WebCore::JSInspectorBackend::selectDatabase): (WebCore::JSInspectorBackend::selectDOMStorage):
  • bindings/js/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject):
  • bindings/js/ScriptObjectQuarantine.h:
  • bindings/js/ScriptValue.cpp: (WebCore::ScriptValue::isObject):
  • bindings/js/ScriptValue.h:
  • bindings/v8/ScriptObjectQuarantine.cpp: (WebCore::getQuarantinedScriptObject):
  • bindings/v8/ScriptObjectQuarantine.h:
  • bindings/v8/ScriptValue.h: (WebCore::ScriptValue::isObject):
  • bindings/v8/custom/V8CustomBinding.h:
  • bindings/v8/custom/V8InspectorBackendCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage):
  • inspector/ConsoleMessage.h:
  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::clearMessages): (WebCore::InspectorBackend::loaded): (WebCore::InspectorBackend::highlight): (WebCore::InspectorBackend::nodeForId): (WebCore::InspectorBackend::idForNode): (WebCore::InspectorBackend::wrapObject): (WebCore::InspectorBackend::unwrapObject): (WebCore::InspectorBackend::pushNodePathToFrontend): (WebCore::InspectorBackend::addNodesToSearchResult): (WebCore::InspectorBackend::selectDatabase): (WebCore::InspectorBackend::selectDOMStorage):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::focusNode): (WebCore::InspectorController::addMessageToConsole): (WebCore::InspectorController::clearConsoleMessages): (WebCore::InspectorController::startGroup): (WebCore::InspectorController::scriptObjectReady): (WebCore::InspectorController::setFrontendProxyObject): (WebCore::InspectorController::close): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::wrapObject): (WebCore::InspectorController::unwrapObject):
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setDocument): (WebCore::InspectorDOMAgent::handleEvent): (WebCore::InspectorDOMAgent::pushDocumentToFrontend): (WebCore::InspectorDOMAgent::pushChildNodesToFrontend): (WebCore::InspectorDOMAgent::nodeForId): (WebCore::InspectorDOMAgent::pushNodePathToFrontend): (WebCore::InspectorDOMAgent::buildObjectForNode): (WebCore::InspectorDOMAgent::buildArrayForContainerChildren): (WebCore::InspectorDOMAgent::innerParentElement):
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::bind):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::clearConsoleMessages): (WebCore::InspectorFrontend::updateFocusedNode): (WebCore::InspectorFrontend::setDocument): (WebCore::InspectorFrontend::selectDatabase): (WebCore::InspectorFrontend::selectDOMStorage): (WebCore::InspectorFrontend::addNodesToSearchResult):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype.clearMessages): (WebInspector.ConsoleView.prototype.completions): (WebInspector.ConsoleView.prototype._reportCompletions): (WebInspector.ConsoleView.prototype._messagesClicked): (WebInspector.ConsoleView.prototype.doEvalInWindow.evalCallback): (WebInspector.ConsoleView.prototype.doEvalInWindow): (WebInspector.ConsoleView.prototype._format): (WebInspector.ConsoleView.prototype._formatfunction): (WebInspector.ConsoleView.prototype._formatdate): (WebInspector.ConsoleView.prototype._formatregexp): (WebInspector.ConsoleView.prototype._formatnode): (WebInspector.ConsoleView.prototype._formatobject):
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode): (WebInspector.DOMNode.prototype._renumber): (WebInspector.DOMDocument): (WebInspector.DOMAgent): (WebInspector.DOMAgent.prototype.getChildNodesAsync): (WebInspector.DOMAgent.prototype.setAttributeAsync): (WebInspector.DOMAgent.prototype.removeAttributeAsync): (WebInspector.DOMAgent.prototype.setTextNodeValueAsync): (WebInspector.DOMAgent.prototype.nodeForId): (WebInspector.DOMAgent.prototype._setDocument): (WebInspector.DOMAgent.prototype._setChildNodes): (WebInspector.DOMAgent.prototype._bindNodes): (WebInspector.DOMAgent.prototype._childNodeInserted): (WebInspector.CSSStyleDeclaration): (WebInspector.CSSStyleDeclaration.parseRule): (WebInspector.setDocument): (InspectorController.getStyles): (InspectorController.getComputedStyle): (InspectorController.getInlineStyle): (InspectorController.applyStyleText): (InspectorController.setStyleText): (InspectorController.toggleStyleEnabled): (InspectorController.applyStyleRuleText): (InspectorController.addStyleSelector): (InspectorController.setStyleProperty): (InspectorController.getPrototypes): (InspectorController.getProperties): (InspectorController.setPropertyValue): (InspectorController.evaluate): (InspectorController.addInspectedNode): (InspectorController.performSearch): (InspectorController.searchCanceled):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged): (WebInspector.ElementsPanel.prototype.searchCanceled): (WebInspector.ElementsPanel.prototype.performSearch): (WebInspector.ElementsPanel.prototype._updateMatchesCount): (WebInspector.ElementsPanel.prototype._updateMatchesCountSoon): (WebInspector.ElementsPanel.prototype.addNodesToSearchResult):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode.restoreHighlightToHoveredNode): (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode): (WebInspector.ElementsTreeElement.prototype.updateChildren): (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
  • inspector/front-end/InjectedScript.js: (InjectedScript.applyStyleRuleText): (InjectedScript.addStyleSelector): (InjectedScript._doesSelectorAffectNode): (InjectedScript._serializeRule): (InjectedScript._serializeStyle): (InjectedScript.getProperties): (InjectedScript.evaluate): (InjectedScript.addInspectedNode): (InjectedScript.performSearch.addNodesToResults): (InjectedScript.performSearch.matchExactItems): (InjectedScript.performSearch.matchExactId.addNodesToResults.call): (InjectedScript.performSearch.matchExactId): (InjectedScript.performSearch): (InjectedScript.performSearch.matchExactTagNames): (InjectedScript.performSearch.matchExactAttributeNames): (InjectedScript.performSearch.matchPartialTagNames): (InjectedScript.performSearch.matchStartOfTagNames): (InjectedScript.performSearch.matchPartialTagNamesAndAttributeValues): (InjectedScript.performSearch.matchPartialAttributeValues): (InjectedScript.performSearch.matchStyleSelector): (InjectedScript.performSearch.matchPlainText): (InjectedScript.performSearch.matchXPathQuery): (InjectedScript.performSearch.finishedSearching): (InjectedScript.performSearch.processChunk): (InjectedScript.searchCanceled): (InjectedScript._ensureCommandLineAPIInstalled.inspectObject): (InjectedScript._ensureCommandLineAPIInstalled): (InjectedScript._resolveObject): (InjectedScript._nodeForId): (InjectedScript._objectForId): (InjectedScript._createProxyObject):
  • inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.onpopulate): (WebInspector.ObjectPropertyTreeElement.prototype.update):
  • inspector/front-end/ObjectProxy.js: (WebInspector.ObjectProxy): (WebInspector.ObjectPropertyProxy):
  • inspector/front-end/PropertiesSidebarPane.js: (WebInspector.PropertiesSidebarPane.prototype.update.callback): (WebInspector.PropertiesSidebarPane.prototype.update):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype.update.callback): (WebInspector.StylesSidebarPane.prototype.update): (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted): (WebInspector.StylePropertiesSection.prototype.editingSelectorCancelled): (WebInspector.BlankStylePropertiesSection.prototype.editingCommitted.callback): (WebInspector.BlankStylePropertiesSection.prototype.editingCommitted): (WebInspector.StylePropertyTreeElement.prototype):
  • inspector/front-end/inspector.js: (WebInspector._updateHoverHighlight): (WebInspector.loaded): (WebInspector.clearConsoleMessages): (WebInspector.selectDatabase): (WebInspector.selectDOMStorage): (WebInspector.updateFocusedNode): (WebInspector.addNodesToSearchResult):
  • inspector/front-end/utilities.js: (Object.proxyType):
  • storage/Storage.h: (WebCore::Storage::frame):
1:57 PM Changeset in webkit [47230] by mrowe@apple.com
  • 3 edits in trunk/WebCore

Fix leaks of RGBColor instances from below CSSPrimitiveValue::getRGBColorValue.

Reviewed by Geoff Garen.

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::getRGBColorValue): Return a PassRefPtr to ensure that the
newly-allocated RGBColor is cleaned up by the caller.

  • css/CSSPrimitiveValue.h:
1:56 PM Changeset in webkit [47229] by eric@webkit.org
  • 8 edits
    6 adds in trunk

2009-08-13 Eric Seidel <​eric@webkit.org>

Reviewed by David Hyatt.

wrong font size when css font-family includes monospace
​https://bugs.webkit.org/show_bug.cgi?id=19161

Update test results now that only "font-family: monospace" is 13px.
All other combinations of font-family are 16px default size.

Add two tests:
font-family-fallback-reset: catches a bug in inheriting font-family fallback.
computed-style-font-family-monospace: tests this bug, that only "font-family: monospace" is 13px.

  • fast/css/getComputedStyle/computed-style-font-family-expected.txt:
  • fast/css/getComputedStyle/computed-style-font-family-monospace-expected.txt: Added.
  • fast/css/getComputedStyle/computed-style-font-family-monospace.html: Added.
  • fast/css/getComputedStyle/font-family-fallback-reset-expected.txt: Added.
  • fast/css/getComputedStyle/font-family-fallback-reset.html: Added.
  • fast/css/getComputedStyle/resources/computed-style-font-family-monospace.js: Added. (fontSizeForFamilies):
  • fast/css/getComputedStyle/resources/font-family-fallback-reset.js: Added.
  • fast/js/method-check.html:
  • platform/mac/css1/font_properties/font_family-expected.txt:
  • platform/mac/css2.1/t1503-c522-font-family-00-b-expected.txt:
  • platform/mac/fast/text/monospace-width-cache-expected.txt:

2009-08-13 Eric Seidel <​eric@webkit.org>

Reviewed by David Hyatt.

wrong font size when css font-family includes monospace
​https://bugs.webkit.org/show_bug.cgi?id=19161

Firefox only uses fixed-width default size for exactly "font-family: monospace;".
WebKit has historically used fixed-width default size any time a
font-family includes monospace in the fallback list.

This patch corrects WebKit's behavior to match Firefox.
I also had to fix a bug in WebKit's font-family fallback behavior where
child elements would inherit parts of their parents fallback lists.

This patch is mostly just replacing all cases where we used to check for:
fontDescription.genericFontFamily() == MonospaceFamily
with:
fontDescription.useFixedDefaultSize()

Tests: fast/css/getComputedStyle/computed-style-font-family-monospace.html

fast/css/getComputedStyle/font-family-fallback-reset.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):

Deploy useFixedDefaultSize(). Also fix the bug where child
FontDescriptions would carry part of the parent font-family fallback list.

(WebCore::CSSStyleSelector::checkForGenericFamilyChange):

It's no longer alright to just check genericFontFamily(),
we have to check to make sure the changed style has a matching useFixedDefaultSize().

  • platform/graphics/FontDescription.h: (WebCore::FontDescription::useFixedDefaultSize):

Only use the fixed default size if we have one font family and it is "monospace".
"-webkit-monospace" is the internal representation of the CSS identifier "monospace".

1:48 PM Changeset in webkit [47228] by sullivan@apple.com
  • 2 edits in trunk/WebKitTools

Unreviewed.

Add myself to list of committers.

  • Scripts/modules/committers.py:
1:18 PM Changeset in webkit [47227] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-08-13 Christian Plesner Hansen <​christian.plesner.hansen@gmail.com>

Reviewed by Dimitri Glazkov.

[v8] Fix atomic string externalization crash.
Atomic string externalization assumes that all non-empty strings
can be externalized which is untrue on 64-bit. This change fixed
that.

​https://bugs.webkit.org/show_bug.cgi?id=28215

This bug causes loads of test crashes, no need to add new tests
specifically for this.

  • bindings/v8/V8Binding.cpp: (WebCore::v8StringToAtomicWebCoreString):
12:49 PM Changeset in webkit [47226] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Doc - Some cleanup on the documentation of QWebElement

Patch by Kavindra Devi Palaraja <​kavindra.palaraja@nokia.com> on 2009-08-13
Reviewed by Simon Hausmann.

  • Api/qwebelement.cpp:
12:39 PM Changeset in webkit [47225] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

Use the version of operator new that takes a JSGlobalData when allocating FuncDeclNode and FuncExprNode
from within the grammar to prevent these nodes from being leaked.

Rubber-stamped by Darin Adler.

  • parser/Grammar.y:
12:01 PM Changeset in webkit [47224] by eric@webkit.org
  • 2 edits
    1 move in trunk/WebKitTools

2009-08-13 Eric Seidel <​eric@webkit.org>

Correct spelling error in file name. No review.

  • Scripts/modules/committers_unittest.py: Renamed from WebKitTools/Scripts/modules/commiters_unittest.py.
  • Scripts/run-webkit-unittests:
11:34 AM Changeset in webkit [47223] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-13 Eric Seidel <​eric@webkit.org>

Reviewed by Simon Fraser.

REGRESSION(r47175): error running run-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=28261

Fix "Use of uninitialized value in concatenation (.) or string at
WebKitTools/Scripts/run-webkit-tests line 191." by setting
$testsPerDumpTool to 1000 by default.

  • Scripts/run-webkit-tests:
11:32 AM UsingGitWithWebKit edited by yong.li@torchmobile.com
(diff)
11:32 AM Changeset in webkit [47222] by staikos@webkit.org
  • 3 edits in trunk/WebCore

2009-08-13 George Staikos <​george.staikos@torchmobile.com>

Rubberstamped by Darin Adler.

Use ASSERT_UNUSED instead of UNUSED_PARAM

11:21 AM Changeset in webkit [47221] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-08-13 Steve Block <​steveblock@google.com>

Reviewed by Darin Adler.

Fixes a couple of bugs in SecurityOrigin::createFromDatabaseIdentifier.
​https://bugs.webkit.org/show_bug.cgi?id=28262

No new tests possible.

  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::createFromDatabaseIdentifier):
11:19 AM WebKit Team edited by dbates@webkit.org
Added myself to the wiki. (diff)
11:11 AM Changeset in webkit [47220] by Nate Chapin
  • 2 edits in trunk/WebKitTools

2009-08-13 Nate Chapin <Nate Chapin>

Unreviewed.

Add myself to list of committers.

  • Scripts/modules/committers.py:
11:09 AM Changeset in webkit [47219] by dbates@webkit.org
  • 1 edit in trunk/WebKitTools/Scripts/modules/committers.py

2009-08-13 Daniel Bates <​dbates@webkit.org>

Unreviewed.


Added 'Daniel Bates' (myself) to the list of committers.


  • Scripts/modules/committers.py:
11:07 AM WebKit Team edited by joe.mason@torchmobile.com
(diff)
11:06 AM Changeset in webkit [47218] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitTools

Unreviewed.

Add 'Brent Fulgham' to the committers list.

  • Scripts/modules/committers.py:
11:04 AM Changeset in webkit [47217] by yong.li@torchmobile.com
  • 1 edit in trunk/WebKitTools/Scripts/modules/committers.py

2009-08-13 Yong Li <​yong.li@torchmobile.com>

Unreviewed.
Added 'Yong Li' to the committers list.

  • Scripts/modules/committers.py
11:03 AM Changeset in webkit [47216] by agl@chromium.org
  • 2 edits in trunk/WebKitTools

2009-08-13 Adam Langley <​agl@chromium.org>

Review not required.

  • Scripts/modules/committers.py: Adding myself to this list because Eric told me to.
11:01 AM Changeset in webkit [47215] by bolsinga@apple.com
  • 2 edits in trunk/WebKitTools

Unreviewed.

Add 'Greg Bolsinga' to the committers list.

  • Scripts/modules/committers.py:
10:59 AM Changeset in webkit [47214] by Adam Roben
  • 2 edits in trunk/LayoutTests

Remove media/video-test.js's redundant hang timer

DRT already has a timer that does the same thing.

Reviewed by Mark Rowe.

  • media/video-test.js: Remove the hang timer, since DRT does the same

thing.

10:58 AM Changeset in webkit [47213] by Adam Roben
  • 6 edits in trunk/WebKitTools

Fix off-by-one result comparisons in media tests on Windows Debug builds

media/video-played.html seems always to time out in Windows Debug
builds. A race condition between media/video-test.js's "hang" timer and
DumpRenderTree's built-in "watchdog" timer was causing results for
media/video-played.html to be printed twice, causing all future media
tests to be compared to the previous test's results.

The fix is to make the watchdog timer got through the same code path
as calling notifyDone manually, so that the results will only get
printed once. A subsequent patch will remove video-test.js's hang
timer entirely, since it is redundant.

Fixes <​http://webkit.org/b/28265>.

Reviewed by Mark Rowe.

  • DumpRenderTree/LayoutTestController.cpp:

(LayoutTestController::waitToDumpWatchdogTimerFired): Added. Code came
from Gtk/Mac/Win's watchdog timer handlers, but we now call
notifyDone() instead of dump() so that a subsequent call to
notifyDone() won't print the results out again.

  • DumpRenderTree/LayoutTestController.h: Added

waitToDumpWatchdogTimerFired.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(waitToDumpWatchdogFired):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(waitUntilDoneWatchdogFired):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(waitUntilDoneWatchdogFired):
Changed to call waitToDumpWatchdogTimerFired.

10:55 AM Changeset in webkit [47212] by eric.carlson@apple.com
  • 2 edits in trunk/WebKitTools

Unreviewed.

Added 'Eric Carlson' to the committers list.

10:52 AM Changeset in webkit [47211] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-08-13 Dirk Schulze <​krit@webkit.org>

Reviewed by Eric Seidel.

[CAIRO] getImageData fails on a given rect bigger than the image rect

The destination image and the source image was mixed up on creating the
imageData.

This is just a clean up and doesn't affect the current behavior. It's not
possible to test this failure in a LayoutTest. Only canvas uses getImageData
at the moment and returns before calling getImageData, if the image rect does
not contain the requested rect.

  • platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::getImageData):
10:43 AM WebKit Team edited by treat@kde.org
(diff)
10:42 AM WebKit Team edited by rik@webkit.org
(diff)
10:40 AM WebKit Team edited by mrowe@apple.com
(diff)
10:38 AM Changeset in webkit [47210] by krit@webkit.org
  • 2 edits in trunk/WebKitTools

2009-08-13 Dirk Schulze <​krit@webkit.org>

Unreviewed.
Added 'Dirk Schulze' to the committers list.

  • Scripts/modules/committers.py
10:37 AM WebKit Team edited by mrowe@apple.com
(diff)
10:34 AM WebKit Team edited by yong.li@torchmobile.com
(diff)
10:18 AM Changeset in webkit [47209] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

2009-08-13 Brian Weinstein <​bweinstein@apple.com>

Rubber-stamped by Adam Roben.

Due to fixes in ​http://trac.webkit.org/changeset/47038 and ​http://trac.webkit.org/changeset/47163,
fast/events/mouse-click-events.html now passes, removing it from Skipped List.

  • platform/win/Skipped:
10:14 AM Changeset in webkit [47208] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2009-08-13 Maxime Simon <Maxime Simon>

Reviewed by Eric Seidel.

[Haiku] Adding RenderTheme to WebCore.
​https://bugs.webkit.org/show_bug.cgi?id=28258

  • platform/haiku/RenderThemeHaiku.cpp: Added. (WebCore::RenderThemeHaiku::create): (WebCore::RenderTheme::themeForPage): (WebCore::RenderThemeHaiku::RenderThemeHaiku): (WebCore::RenderThemeHaiku::~RenderThemeHaiku): (WebCore::supportsFocus): (WebCore::RenderThemeHaiku::supportsFocusRing): (WebCore::RenderThemeHaiku::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeHaiku::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeHaiku::platformActiveSelectionForegroundColor): (WebCore::RenderThemeHaiku::platformInactiveSelectionForegroundColor): (WebCore::RenderThemeHaiku::platformTextSearchHighlightColor): (WebCore::RenderThemeHaiku::systemFont): (WebCore::RenderThemeHaiku::paintCheckbox): (WebCore::RenderThemeHaiku::setCheckboxSize): (WebCore::RenderThemeHaiku::paintRadio): (WebCore::RenderThemeHaiku::setRadioSize): (WebCore::RenderThemeHaiku::adjustMenuListStyle): (WebCore::RenderThemeHaiku::paintMenuList):
  • platform/haiku/RenderThemeHaiku.h: Added. (WebCore::RenderThemeHaiku::supportsHover):
10:13 AM Changeset in webkit [47207] by kevino@webkit.org
  • 2 edits in trunk/WebKit/wx

wx build fix. Make sure that the wxWebKit dynamic library is rebuilt whenever webcore or jscore libs change.

10:08 AM Changeset in webkit [47206] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-08-13 Maxime Simon <Maxime Simon>

Reviewed by Eric Seidel.

[Haiku] Remove the "m_point" code from ContextMenuHaiku.cpp
​https://bugs.webkit.org/show_bug.cgi?id=28256

  • platform/haiku/ContextMenuHaiku.cpp: (WebCore::ContextMenuReceiver::ContextMenuReceiver): (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::appendItem): (WebCore::ContextMenu::insertItem):
9:51 AM Changeset in webkit [47205] by eric@webkit.org
  • 13 edits
    1 copy in trunk/WebCore

2009-08-13 Joseph Pecoraro <​joepeck02@gmail.com>

Reviewed by Darin Adler.

Inspector: Show Hidden Cookie Data
​https://bugs.webkit.org/show_bug.cgi?id=28185

Added new file Cookie.h to the WebCore XCode

  • WebCore.xcodeproj/project.pbxproj:

InspectorController.cookies() binding

  • bindings/js/JSInspectorBackendCustom.cpp: (WebCore::JSInspectorBackend::cookies):
  • inspector/InspectorBackend.idl:

Struct for static Cookie information
(name, value, path, domain, expires, httpOnly, secure, session)

  • platform/Cookie.h: Added. (WebCore::Cookie::Cookie):

Getter for the a list of raw Cookies
getRawCookies(., ., out Vector<Cookie>)

  • platform/CookieJar.h:

Implementation of getRawCookies for the mac platform.

  • platform/mac/CookieJar.mm: (WebCore::getRawCookies):

Stub other CookieJar implementations to satisfy the interface.

  • platform/haiku/CookieJarHaiku.cpp: (WebCore::getRawCookies):
  • platform/network/chromium/CookieJarChromium.cpp: (WebCore::getRawCookies):
  • platform/network/curl/CookieJarCurl.cpp: (WebCore::getRawCookies):
  • platform/network/soup/CookieJarSoup.cpp: (WebCore::getRawCookies):
  • platform/network/win/CookieJarCFNetWin.cpp: (WebCore::getRawCookies):
  • platform/network/win/CookieJarWin.cpp: (WebCore::getRawCookies):
  • platform/qt/CookieJarQt.cpp: (WebCore::getRawCookies):
9:43 AM Changeset in webkit [47204] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-08-13 Steve Block <​steveblock@google.com>

Reviewed by David Levin.

Disables Geolocation 'enabled' test for GTK port, as the GTK Geolocation implementation is incomplete.
​https://bugs.webkit.org/show_bug.cgi?id=27716

  • platform/gtk/Skipped: Modified. Disables Geolocation 'enabled' test.
9:36 AM Changeset in webkit [47203] by eric@webkit.org
  • 4 edits in trunk

2009-08-13 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[Gtk][REGRESSION] XHR test failures after r45558
​https://bugs.webkit.org/show_bug.cgi?id=27143

Reenable the test that is fixed by this changeset.

  • platform/gtk/Skipped:

2009-08-13 Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

[Gtk][REGRESSION] XHR test failures after r45558
​https://bugs.webkit.org/show_bug.cgi?id=27143

Fix one of the regressions caused by the new sniffing code -
disable sniffing when that behavior is explicitly requested.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::startHttp):
9:29 AM Changeset in webkit [47202] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-08-13 Patrick Mueller <​Patrick_Mueller@us.ibm.com>

Reviewed by Timothy Hatcher.

Add a new gesture in Web Inspector to remove breakpoints
​https://bugs.webkit.org/show_bug.cgi?id=19131

  • inspector/front-end/SourceFrame.js: (WebInspector.SourceFrame.prototype._documentMouseDown):
9:23 AM Changeset in webkit [47201] by eric@webkit.org
  • 10 edits in trunk

2009-08-13 Norbert Leser <​norbert.leser@nokia.com>

Reviewed by Simon Hausmann.

Symbian target components (library and executable files)
require Unique Identifiers (i.e., UID3).
These identifiers are defined in the respective project
file, conditionally for "symbian" platform.

  • WebCore.pro:

2009-08-13 Norbert Leser <​norbert.leser@nokia.com>

Reviewed by Simon Hausmann.

Symbian target components (library and executable files)
require Unique Identifiers (i.e., UID3).
These identifiers are defined in the respective project
files, conditionally for "symbian" platform.

  • QtLauncher/QtLauncher.pro:
  • tests/qwebelement/qwebelement.pro:
  • tests/qwebframe/qwebframe.pro:
  • tests/qwebhistory/qwebhistory.pro:
  • tests/qwebhistoryinterface/qwebhistoryinterface.pro:
  • tests/qwebpage/qwebpage.pro:
  • tests/qwebview/qwebview.pro:
9:16 AM Changeset in webkit [47200] by eric@webkit.org
  • 9 edits in trunk

2009-08-13 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Eric Seidel.

wrong calculation of overflow size for flexbox and table
​https://bugs.webkit.org/show_bug.cgi?id=28064

RenderFlexibleBox and RenderTable were using the width of overflow
to update height of overflow, so height became wrong value and
width was not updated. As the corresponding code of RenderBlock
was sane, I factored it out and used from RenderFlexibleBox and
RenderTable.

  • fast/reflections/reflection-overflow-scroll-expected.txt:
  • fast/reflections/reflection-overflow-scroll.html:
  • fast/reflections/resources/reflection-overflow-scroll.js:

2009-08-13 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Eric Seidel.

wrong calculation of overflow size for flexbox and table
​https://bugs.webkit.org/show_bug.cgi?id=28064

RenderFlexibleBox and RenderTable were using the width of overflow
to update height of overflow, so height became wrong value and
width was not updated. As the corresponding code of RenderBlock
was sane, I factored it out and used from RenderFlexibleBox and
RenderTable.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateOverflowWithShadowAndReflection): created from code of layoutBlock (WebCore::RenderBlock::layoutBlock):
  • rendering/RenderBlock.h:
  • rendering/RenderFlexibleBox.cpp: use updateOverflowWithShadowAndReflection (WebCore::RenderFlexibleBox::layoutBlock):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout): use updateOverflowWithShadowAndReflection
9:01 AM Changeset in webkit [47199] by Adam Roben
  • 2 edits in trunk/WebKitTools

Enable running testapi in run-javascriptcore-tests on Windows

Fixes <​http://webkit.org/b/24856> run-javascriptcore-tests should run
testapi on Windows

Reviewed by Mark Rowe.

  • Scripts/run-javascriptcore-tests: Allow testapi to run if we're in

the AppleWinWebKit configuration.

9:00 AM Changeset in webkit [47198] by Adam Roben
  • 2 edits in trunk/WebKitTools

Re-enable testapi in run-javascriptcore-tests on Mac

This seems to have been mistakenly disabled in r47089.

Rubber-stamped by Mark Rowe.

  • Scripts/run-javascriptcore-tests: Removed comment markers that were

preventing running testapi.

8:25 AM UsingGitWithWebKit edited by treat@kde.org
(diff)
8:18 AM Companies and Organizations that have contributed to WebKit edited by kov@webkit.org
(diff)
7:54 AM Changeset in webkit [47197] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

Remove the special-case for Qt wrt JSVALUE_32 introduced in
r46709. It must've been a dependency issue on the bot, as
after a manual build all the tests pass on amd64 and ia32.

Patch by Simon Hausmann <​simon.hausmann@nokia.com> on 2009-08-13
Reviewed by Ariya Hidayat.

  • wtf/Platform.h:
7:29 AM Changeset in webkit [47196] by ariya@webkit.org
  • 9 edits in trunk/LayoutTests

2009-08-13 Ariya Hidayat <​ariya.hidayat@nokia.com>

Rubber-stamped by George Staikos.

[Qt] These tests pass, update the metrics and exclude from Skipped.

  • platform/qt/Skipped:
  • platform/qt/fast/canvas/canvas-transform-identity-expected.txt:
  • platform/qt/fast/canvas/canvas-transform-infinity-expected.txt:
  • platform/qt/fast/canvas/canvas-transform-multiply-expected.txt:
  • platform/qt/fast/canvas/canvas-transform-nan-expected.txt:
  • platform/qt/fast/canvas/canvas-transform-non-invertible-expected.txt:
  • platform/qt/fast/canvas/canvas-transform-skewed-expected.txt:
  • platform/qt/fast/canvas/canvas-transforms-during-path-expected.txt:
5:53 AM Changeset in webkit [47195] by mrowe@apple.com
  • 13 edits
    1 delete in trunk/WebCore

Revert r47185, the fix for <​https://bugs.webkit.org/show_bug.cgi?id=28185>, as it broke the
Windows build in a non-obvious manner.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSInspectorBackendCustom.cpp:
  • inspector/InspectorBackend.idl:
  • platform/Cookie.h: Removed.
  • platform/CookieJar.h:
  • platform/haiku/CookieJarHaiku.cpp:

(WebCore::setCookies):
(WebCore::cookies):

  • platform/mac/CookieJar.mm:
  • platform/network/chromium/CookieJarChromium.cpp:
  • platform/network/curl/CookieJarCurl.cpp:
  • platform/network/soup/CookieJarSoup.cpp:
  • platform/network/win/CookieJarCFNetWin.cpp:
  • platform/network/win/CookieJarWin.cpp:
  • platform/qt/CookieJarQt.cpp:
5:44 AM Changeset in webkit [47194] by ariya@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2009-08-13 Ariya Hidayat <​ariya.hidayat@nokia.com>

Not reviewed: build fix (for r47192), adding new file from
​https://bugs.webkit.org/show_bug.cgi?id=28174

  • inspector/front-end/StatusBarButton.js: Added.
5:36 AM Changeset in webkit [47193] by ariya@webkit.org
  • 3 edits
    2 adds in trunk/LayoutTests

2009-08-13 Ariya Hidayat <​ariya.hidayat@nokia.com>

Rubber-stamped by Simon Hausmann.

[Qt] Test result for quadraticCurveTo.

  • platform/qt/Skipped: Exclude quadraticCurveTo test.
  • platform/qt/fast/canvas/quadraticCurveTo-expected.checksum: Added.
  • platform/qt/fast/canvas/quadraticCurveTo-expected.png: Added.
  • platform/qt/fast/canvas/quadraticCurveTo-expected.txt: Added.
5:16 AM Changeset in webkit [47192] by pfeldman@chromium.org
  • 14 edits in trunk/WebCore

2009-08-13 Mikhail Naganov <​mnaganov@chromium.org>

Reviewed by Timothy Hatcher.

Introduced StatusBarButton class that encapsulates glyphs support.
Views updated accordingly.

​https://bugs.webkit.org/show_bug.cgi?id=28174

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView): (WebInspector.CookieItemsView.prototype.get statusBarItems): Updated to retrieve DOM element from StatusBarButton instance (here and in similar getters below.) (WebInspector.CookieItemsView.prototype.hide): (WebInspector.CookieItemsView.prototype.update):
  • inspector/front-end/DOMStorageItemsView.js: (WebInspector.DOMStorageItemsView): (WebInspector.DOMStorageItemsView.prototype.get statusBarItems): (WebInspector.DOMStorageItemsView.prototype.hide): (WebInspector.DOMStorageItemsView.prototype.update):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype.get statusBarItems): (WebInspector.ElementsPanel.prototype.hide): (WebInspector.ElementsPanel.prototype._nodeSearchButtonClicked):
  • inspector/front-end/Panel.js:
  • inspector/front-end/ProfileView.js: (WebInspector.ProfileView): (WebInspector.ProfileView.prototype.get statusBarItems): (WebInspector.ProfileView.prototype._updatePercentButton): (WebInspector.ProfileView.prototype._focusClicked): (WebInspector.ProfileView.prototype._excludeClicked): (WebInspector.ProfileView.prototype._resetClicked):
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): (WebInspector.ProfilesPanel.prototype.get statusBarItems): (WebInspector.ProfilesPanel.prototype.setRecordingProfile): (WebInspector.ProfilesPanel.prototype._updateInterface):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.get statusBarItems): (WebInspector.ResourcesPanel.prototype.reset): (WebInspector.ResourcesPanel.prototype._toggleLargerResources):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.get statusBarItems): (WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsButton): (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons):
  • inspector/front-end/StatusBarButton.js: Added. (WebInspector.StatusBarButton): (WebInspector.StatusBarButton.prototype._clicked): (WebInspector.StatusBarButton.prototype.get disabled): (WebInspector.StatusBarButton.prototype.set disabled): (WebInspector.StatusBarButton.prototype.get title): (WebInspector.StatusBarButton.prototype.set title): (WebInspector.StatusBarButton.prototype.get toggled): (WebInspector.StatusBarButton.prototype.set toggled): (WebInspector.StatusBarButton.prototype.get visible): (WebInspector.StatusBarButton.prototype.set visible):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css: For uniformity, class names are always used to identify status bar buttons. Also, fixed "Reload" button style to use glyphs.
  • inspector/front-end/inspector.html:
5:15 AM Changeset in webkit [47191] by ariya@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2009-08-13 Ariya Hidayat <​ariya.hidayat@nokia.com>

Rubber-stamped by Simon Hausmann.

[Qt] Fix test result and add pixel test.

  • platform/qt/fast/canvas/canvas-zoom-expected.checksum: Added.
  • platform/qt/fast/canvas/canvas-zoom-expected.png: Added.
  • platform/qt/fast/canvas/canvas-zoom-expected.txt: Added.
4:45 AM Changeset in webkit [47190] by ariya@webkit.org
  • 4 edits
    21 adds in trunk

WebCore/ChangeLog

2009-08-12 Ariya Hidayat <​ariya.hidayat@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Add shadow support in GraphicsContext::fillRect().

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillRect): Paint shadow if necessary. (WebCore::GraphicsContext::setPlatformShadow): Inverse y offset.

LayoutTests/ChangeLog

2009-08-12 Ariya Hidayat <​ariya.hidayat@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Add pixel tests result for canvas shadow support.

  • platform/qt/Skipped: Exclude new passing tests.
  • platform/qt/fast/canvas/shadow-offset-1-expected.checksum: Added.
  • platform/qt/fast/canvas/shadow-offset-1-expected.png: Added.
  • platform/qt/fast/canvas/shadow-offset-1-expected.txt: Added.
  • platform/qt/fast/canvas/shadow-offset-2-expected.checksum: Added.
  • platform/qt/fast/canvas/shadow-offset-2-expected.png: Added.
  • platform/qt/fast/canvas/shadow-offset-2-expected.txt: Added.
  • platform/qt/fast/canvas/shadow-offset-3-expected.checksum: Added.
  • platform/qt/fast/canvas/shadow-offset-3-expected.png: Added.
  • platform/qt/fast/canvas/shadow-offset-3-expected.txt: Added.
  • platform/qt/fast/canvas/shadow-offset-4-expected.checksum: Added.
  • platform/qt/fast/canvas/shadow-offset-4-expected.png: Added.
  • platform/qt/fast/canvas/shadow-offset-4-expected.txt: Added.
  • platform/qt/fast/canvas/shadow-offset-5-expected.checksum: Added.
  • platform/qt/fast/canvas/shadow-offset-5-expected.png: Added.
  • platform/qt/fast/canvas/shadow-offset-5-expected.txt: Added.
  • platform/qt/fast/canvas/shadow-offset-6-expected.checksum: Added.
  • platform/qt/fast/canvas/shadow-offset-6-expected.png: Added.
  • platform/qt/fast/canvas/shadow-offset-6-expected.txt: Added.
  • platform/qt/fast/canvas/shadow-offset-7-expected.checksum: Added.
  • platform/qt/fast/canvas/shadow-offset-7-expected.png: Added.
  • platform/qt/fast/canvas/shadow-offset-7-expected.txt: Added.
3:17 AM Changeset in webkit [47189] by levin@chromium.org
  • 2 edits in trunk/WebCore

2009-08-13 David Levin <​levin@chromium.org>

Unreviewed build fix for Chromium Linux.

Rollback r47157 as this broke debug tests of Chromium Linux.

  • platform/graphics/skia/PlatformContextSkia.cpp: (PlatformContextSkia::setupPaintCommon):
2:59 AM Changeset in webkit [47188] by levin@chromium.org
  • 3 edits in trunk/WebCore

Unreviewed build fix for chromium.

Patch by David Levin <​levin@chromium.org> on 2009-08-13
The chromium build broke due to r47185 which added
a cookies array to inspector/InspectorBackend.idl.

  • bindings/v8/custom/V8CustomBinding.h: Added the declaration for the cookies callback.
  • bindings/v8/custom/V8InspectorBackendCustom.cpp:

(WebCore::CALLBACK_FUNC_DECL(InspectorBackendCookies)): Stubbed out an implementation

for the cookies callback.

12:33 AM Changeset in webkit [47187] by dimich@chromium.org
  • 1 edit in trunk/LayoutTests/platform/win/media/controls-drag-timebar-expected.txt

Fix for media timebar test on windows.

Note: See TracTimeline for information about the timeline view.