Timeline



Dec 12, 2009:

8:45 PM Changeset in webkit [52063] by weinig@apple.com
  • 13 edits in trunk/WebCore

Rubber-stamped by Dan Bernstein.

Fix the EXPERIMENTAL_SINGLE_VIEW_MODE build.

  • Configurations/WebCore.xcconfig:
  • page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clearDragState):

  • page/mac/DragControllerMac.mm:

(WebCore::DragController::isCopyKeyDown):

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::eventActivatedView):

  • platform/PlatformKeyboardEvent.h:
  • platform/PlatformMouseEvent.h:
  • platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

  • platform/mac/KeyEventMac.mm:

(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

  • platform/mac/PlatformMouseEventMac.mm:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):

  • platform/mac/PopupMenuMac.mm:

(WebCore::PopupMenu::show):

  • platform/mac/WidgetMac.mm:
8:26 PM Changeset in webkit [52062] by mjs@apple.com
  • 5 edits
    2 moves
    1 add in trunk/SunSpider

2009-12-12 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver Hunt.

Enable Web-hosted version of SunSpider to handle multiple versions
​https://bugs.webkit.org/show_bug.cgi?id=32478

  • make-hosted: Now generate the hosted version to be able to run both the 0.9 and the 0.9.1 test suites.
  • hosted: Modified property svn:ignore.
  • hosted/sunspider-driver.html: Removed.
  • hosted/sunspider-results.html: Removed.
  • hosted/sunspider.html:
  • hosted/versions.html: Added.
  • resources/TEMPLATE.html:
  • resources/driver-TEMPLATE.html: Copied from hosted/sunspider-driver.html.
  • resources/driver-TEMPLATE.html: Copied from hosted/sunspider-results.html.
7:59 PM Changeset in webkit [52061] by weinig@apple.com
  • 2 edits in trunk/WebCore

Rubber-stamped by Dan Bernstein.

Fix the !ENABLE(VIDEO) build.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForVideo):

7:56 PM Changeset in webkit [52060] by weinig@apple.com
  • 6 edits in trunk/WebCore

Rubber-stamped by Dan Bernstein.

Fix the !ENABLE(DATABASE) build.

  • storage/SQLTransactionClient.cpp:
  • storage/SQLTransactionClient.h:
  • storage/SQLTransactionCoordinator.cpp:
  • storage/SQLTransactionCoordinator.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopLoading):

7:28 PM Changeset in webkit [52059] by eric.carlson@apple.com
  • 22 edits in trunk

2009-12-12 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6293979> Adopt shared control drawing for <video> controls on Leopard and Windows

Use MediaControllerThemeQuickTime on Leopard.

  • rendering/RenderThemeMac.mm: (WebCore::mediaControllerTheme):

2009-12-12 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6293979> Adopt shared control drawing for <video> controls on Leopard and Windows

Regenerate layout and pixel test results for the new UI.

  • platform/mac-leopard/Skipped:
  • platform/mac-leopard/media/controls-after-reload-expected.txt:
  • platform/mac-leopard/media/controls-drag-timebar-expected.txt:
  • platform/mac-leopard/media/controls-strict-expected.txt:
  • platform/mac-leopard/media/controls-styling-expected.txt:
  • platform/mac-leopard/media/video-controls-rendering-expected.checksum:
  • platform/mac-leopard/media/video-controls-rendering-expected.png:
  • platform/mac-leopard/media/video-controls-rendering-expected.txt:
  • platform/mac-leopard/media/video-display-toggle-expected.checksum:
  • platform/mac-leopard/media/video-display-toggle-expected.png:
  • platform/mac-leopard/media/video-display-toggle-expected.txt:
  • platform/mac-leopard/media/video-no-audio-expected.txt:
  • platform/mac-leopard/media/video-zoom-controls-expected.checksum:
  • platform/mac-leopard/media/video-zoom-controls-expected.png:
  • platform/mac-leopard/media/video-zoom-controls-expected.txt:
  • platform/mac/media/audio-controls-rendering-expected.checksum:
  • platform/mac/media/audio-controls-rendering-expected.png:
  • platform/mac/media/video-zoom-expected.checksum:
  • platform/mac/media/video-zoom-expected.png:
7:02 PM Changeset in webkit [52058] by eric@webkit.org
  • 12 edits
    2 adds in trunk

2009-12-12 Kenneth Russell <​kbr@google.com>

Reviewed by Oliver Hunt.

Errors in WebGL[T]Array set() and get() methods
​https://bugs.webkit.org/show_bug.cgi?id=32456

Test: fast/canvas/webgl/bug-32456.html

  • fast/canvas/webgl/array-unit-tests.html:
  • fast/canvas/webgl/bug-32456-expected.txt: Added.
  • fast/canvas/webgl/bug-32456.html: Added.

2009-12-12 Kenneth Russell <​kbr@google.com>

Reviewed by Oliver Hunt.

Errors in WebGL[T]Array set() and get() methods
​https://bugs.webkit.org/show_bug.cgi?id=32456

Test: fast/canvas/webgl/bug-32456.html

  • bindings/js/JSWebGLFloatArrayCustom.cpp: (WebCore::JSWebGLFloatArray::set):
  • bindings/js/JSWebGLIntArrayCustom.cpp: (WebCore::JSWebGLIntArray::set):
  • bindings/js/JSWebGLShortArrayCustom.cpp: (WebCore::JSWebGLShortArray::set):
  • bindings/js/JSWebGLUnsignedByteArrayCustom.cpp: (WebCore::JSWebGLUnsignedByteArray::set):
  • bindings/js/JSWebGLUnsignedIntArrayCustom.cpp: (WebCore::JSWebGLUnsignedIntArray::set):
  • bindings/js/JSWebGLUnsignedShortArrayCustom.cpp: (WebCore::JSWebGLUnsignedShortArray::set):
  • bindings/v8/custom/V8WebGLArrayCustom.h: (WebCore::setWebGLArray):
  • html/canvas/WebGLFloatArray.idl:
  • html/canvas/WebGLUnsignedIntArray.idl:
6:18 PM Changeset in webkit [52057] by mjs@apple.com
  • 10 edits
    27 copies
    37 moves
    3 adds in trunk

2009-12-12 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver Hunt.

Give command-line sunspider the ability to handle multiple suites and versions
​https://bugs.webkit.org/show_bug.cgi?id=32477

  • Scripts/run-sunspider: Updated for changes to command-line parameters.
  • Scripts/sunspider-compare-results: ditto

2009-12-12 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver Hunt.

Give command-line sunspider the ability to handle multiple suites and versions
​https://bugs.webkit.org/show_bug.cgi?id=32477


Each suite/version's set of tests are now in a separate subdirectory of tests/, with a file named LIST
enumerating the tests. Current suites are:


sunspider-0.9 - riginal SunSpider content
sunspider-0.9.1 - SunSpider suite with a few tests fixed (and a few more to come)
ubench - "ubench" microbenchmark suite
v8-v4 - version 4 of the v8 benchmark
parse-only - some parser tests


Sunspider can now be run with the --suite= parameter to select a
suite. The default is --suite=sunspider-0.9.

  • .: Modified property svn:ignore to ignore new results directories.
  • make-hosted: Generate based on sunspider-0.9 suite.
  • resources/TEMPLATE.html: Fix an HTML compliance problem.
  • resources/sunspider-standalone-driver.js: Become aware of suite names.
  • sunspider: Modified to handle multiple suites as described above.
  • sunspider-compare-results: ditto
  • tests/LIST: Moved to tests/sunspider-0.9/ and tests/sunspider-0.9.1/
  • tests/LIST-PARSE-ONLY: Moved to parse-only/LIST
  • tests/LIST-UBENCH: Removed.
  • tests/LIST-V8: Removed.
  • tests/3d-cube.js: Moved to tests/sunspider-0.9 and tests/sunspider-0.9.1
  • tests/3d-morph.js: ditto
  • tests/3d-raytrace.js: ditto
  • tests/access-binary-trees.js: ditto
  • tests/access-fannkuch.js: ditto
  • tests/access-nbody.js: ditto
  • tests/access-nsieve.js: ditto
  • tests/bitops-3bit-bits-in-byte.js: ditto
  • tests/bitops-bits-in-byte.js: ditto
  • tests/bitops-bitwise-and.js: ditto
  • tests/bitops-nsieve-bits.js: ditto
  • tests/controlflow-recursive.js: ditto
  • tests/crypto-aes.js: ditto
  • tests/crypto-md5.js: ditto
  • tests/crypto-sha1.js: ditto
  • tests/date-format-tofte.js: ditto
  • tests/date-format-xparb.js: ditto
  • tests/math-cordic.js: ditto
  • tests/math-partial-sums.js: ditto
  • tests/math-spectral-norm.js: ditto
  • tests/regexp-dna.js: ditto
  • tests/string-base64.js: ditto
  • tests/string-fasta.js: ditto
  • tests/string-tagcloud.js: ditto
  • tests/string-unpack-code.js: ditto
  • tests/string-validate-input.js: ditto
  • tests/sunspider-0.9/: Added
  • tests/sunspider-0.9/*.js: Moved from one level up
  • tests/sunspider-0.9.1: Added.
  • tests/sunspider-0.9.1/*.js: Moved from one level up.
  • tests/v8-crypto.js: Moved to v8-v4/ directory.
  • tests/v8-deltablue.js: ditto
  • tests/v8-earley-boyer.js: ditto
  • tests/v8-raytrace.js: ditto
  • tests/v8-regexp.js: ditto
  • tests/v8-richards.js: ditto
  • tests/v8-splay.js: ditto
  • tests/v8-v4: Added.
3:12 PM Changeset in webkit [52056] by eric@webkit.org
  • 10 edits in trunk

2009-12-12 Kenneth Russell <​kbr@google.com>

Reviewed by Oliver Hunt.

Update WebGL tests to released versions
​https://bugs.webkit.org/show_bug.cgi?id=32457

  • fast/canvas/webgl/resources/utils3d.js: (initWebGL.gl.console.window.console.log): (initWebGL): (loadShader): (makeBox): (makeSphere): (processLoadObj): (doLoadObj): (doLoadImageTexture):

2009-12-12 Kenneth Russell <​kbr@google.com>

Reviewed by Oliver Hunt.

Update WebGL tests to released versions
​https://bugs.webkit.org/show_bug.cgi?id=32457

  • manual-tests/webgl/Earth.html:
  • manual-tests/webgl/ManyPlanetsDeep.html:
  • manual-tests/webgl/SpinningBox.html:
  • manual-tests/webgl/TeapotPerPixel.html:
  • manual-tests/webgl/TeapotPerVertex.html:
  • manual-tests/webgl/resources/CanvasMatrix.js: (CanvasMatrix4.prototype.getAsWebGLFloatArray):
  • manual-tests/webgl/resources/utils3d.js: (initWebGL.gl.console.window.console.log): (initWebGL): (loadShader): (makeBox): (makeSphere): (processLoadObj): (doLoadObj): (doLoadImageTexture):
1:29 PM Changeset in webkit [52055] by eric.carlson@apple.com
  • 11 edits in trunk

2009-12-12 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Darin Adler.

<rdar://problem/7453726> Pull shared UI code into WebKit

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:

2009-12-12 Eric Carlson <​eric.carlson@apple.com>

Reviewed by Darin Adler.

<rdar://problem/7453726> Pull shared UI code into WebKit

Update media tests for small change in timeline slider thumb position

  • platform/mac/media/audio-controls-rendering-expected.txt:
  • platform/mac/media/controls-after-reload-expected.txt:
  • platform/mac/media/controls-styling-expected.txt:
  • platform/mac/media/video-no-audio-expected.txt:
  • platform/mac/media/video-zoom-controls-expected.txt:
11:10 AM Changeset in webkit [52054] by christian@webkit.org
  • 2 edits in trunk/WebCore

2009-12-12 Christian Dywan <​christian@twotoasts.de>

Reviewed by Dirk Schulze.

Remove the include to SVGFEDisplacementMap.h, it's not needed at all.

  • platform/graphics/filters/FEComponentTransfer.h:
10:32 AM Changeset in webkit [52053] by mjs@apple.com
  • 2 edits in trunk/WebKitTools

Not reviewed, fixing previous comment.

Remove accidental change to sunspider-compare-results

  • Scripts/sunspider-compare-results:
10:24 AM Changeset in webkit [52052] by christian@webkit.org
  • 2 edits in trunk/WebCore

2009-12-12 Christian Dywan <​christian@twotoasts.de>

Rubber-stamped by Maciej Stachowiak.

Only include SVGFEDisplacementMap.h if SVG is enabled.

  • platform/graphics/filters/FEComponentTransfer.h:
9:52 AM Changeset in webkit [52051] by mjs@apple.com
  • 4 edits in trunk

2009-12-11 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver Hunt.

Unify codegen for forward and backward variants of branches
​https://bugs.webkit.org/show_bug.cgi?id=32463

  • jit/JIT.h: (JSC::JIT::emit_op_loop): Implemented in terms of forward variant. (JSC::JIT::emit_op_loop_if_true): ditto (JSC::JIT::emitSlow_op_loop_if_true): ditto (JSC::JIT::emit_op_loop_if_false): ditto (JSC::JIT::emitSlow_op_loop_if_false): ditto (JSC::JIT::emit_op_loop_if_less): ditto (JSC::JIT::emitSlow_op_loop_if_less): ditto
  • jit/JITOpcodes.cpp:
9:14 AM Changeset in webkit [52050] by christian@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-12-11 Christian Dywan <​christian@twotoasts.de>

Reviewed by Eric Seidel.

[GTK] Build with --disable-svg is broken
​http://bugs.webkit.org/show_bug.cgi?id=32361

  • webkit/webkitwebframe.cpp: (webkit_web_frame_pause_svg_animation): Fix ENABLE(SVG) guards.
2:20 AM Changeset in webkit [52049] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-12-12 Dirk Schulze <​krit@webkit.org>

Reviewed by Eric Seidel.

[Cairo][Qt] Alpha blending in SVG filters is wrong
​https://bugs.webkit.org/show_bug.cgi?id=32427

This patch is a follow-up to:
​http://trac.webkit.org/changeset/51950
It fixes the alpha blending for Cairo and Qt on SVG Filters.

Covered by: * LayoutTests/svg/filters/feGaussianBlur.svg

  • LayoutTests/svg/filters/feComposite.svg and others.
  • platform/graphics/cairo/ImageBufferCairo.cpp: (WebCore::ImageBuffer::platformTransformColorSpace):
  • platform/graphics/qt/ImageBufferQt.cpp: (WebCore::ImageBuffer::platformTransformColorSpace):
2:13 AM Changeset in webkit [52048] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Missing forward entries when dumping back/forward list
​https://bugs.webkit.org/show_bug.cgi?id=32470

Failing tests added to skiplist until bug fixed.

  • platform/qt/Skipped:
  • http/tests/navigation/dynamic-iframe-dynamic-form-back-entry.html added
  • http/tests/navigation/parsed-iframe-dynamic-form-back-entry.html added

Dec 11, 2009:

11:20 PM Changeset in webkit [52047] by ggaren@apple.com
  • 33 edits
    2 deletes in trunk

Rolled out my last patch because the bots were crashing

10:30 PM Changeset in webkit [52046] by weinig@apple.com
  • 3 edits in trunk/JavaScriptCore

Allow WTFs concept of the main thread to differ from pthreads when necessary.

Reviewed by Anders Carlsson.

  • wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading):
(WTF::isMainThread):

  • wtf/mac/MainThreadMac.mm:

(WTF::initializeMainThreadPlatform):
(WTF::scheduleDispatchFunctionsOnMainThread):

10:22 PM Changeset in webkit [52045] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix: Export some new symbols.

10:08 PM QtWebKit/CodeCamp200912 edited by zecke@selfish.org
Add another talk. I don't remember the name of this guy though. (diff)
10:02 PM Changeset in webkit [52044] by ggaren@apple.com
  • 2 edits in trunk/WebCore

Windows build fix: Removed an incorrect #ifdef.

  • bindings/js/GCController.cpp:
9:50 PM Changeset in webkit [52043] by eroman@chromium.org
  • 3 edits in trunk/WebCore

Unreviewed build fix.

[V8] Add a method on ScriptController to get it compiling after ​http://trac.webkit.org/changeset/52033.

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::anyPageIsProcessingUserGesture):
  • bindings/v8/ScriptController.h:
9:49 PM Changeset in webkit [52042] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix: Removed some old exports.

9:39 PM Changeset in webkit [52041] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix: Use unsigned instead of uint32_t to avoid dependencies.

  • wtf/StdLibExtras.h:

(WTF::bitCount):

9:29 PM Changeset in webkit [52040] by ggaren@apple.com
  • 32 edits
    4 adds in trunk

JavaScriptCore: Changed GC from mark-sweep to mark-allocate.

Reviewed by Sam Weinig.

Added WeakGCMap to keep WebCore blissfully ignorant about objects that
have become garbage but haven't run their destructors yet.

1% SunSpider speedup.
7.6% v8 speedup (37% splay speedup).
17% speedup on bench-alloc-nonretained.js.
18% speedup on bench-alloc-retained.js.

  • API/JSBase.cpp:

(JSGarbageCollect):

files.

  • debugger/Debugger.cpp:

(JSC::Debugger::recompileAllJSFunctions): Updated to use the Collector
iterator abstraction.

  • jsc.cpp:

(functionGC): Updated for rename.

  • runtime/Collector.cpp: Slightly reduced the number of allocations per

collection, so that small workloads only allocate on collector block,
rather than two.

(JSC::Heap::Heap): Updated to use the new allocateBlock function.

(JSC::Heap::destroy): Updated to use the new freeBlocks function.

(JSC::Heap::allocateBlock): New function to initialize a block when
allocating it.

(JSC::Heap::freeBlock): Consolidated the responsibility for running
destructors into this function.

(JSC::Heap::freeBlocks): Updated to use freeBlock.

(JSC::Heap::recordExtraCost): Sweep the heap in this reporting function,
so that allocation, which is more common, doesn't have to check extraCost.

(JSC::Heap::heapAllocate): Run destructors right before recycling a
garbage cell. This has better cache utilization than a separate sweep phase.

(JSC::Heap::resizeBlocks):
(JSC::Heap::growBlocks):
(JSC::Heap::shrinkBlocks): New set of functions for managing the size of
the heap, now that the heap doesn't maintain any information about its
size.

(JSC::isPointerAligned):
(JSC::isHalfCellAligned):
(JSC::isPossibleCell):
(JSC::isCellAligned):
(JSC::Heap::markConservatively): Cleaned up this code a bit.

(JSC::Heap::clearMarkBits):
(JSC::Heap::markedCells): Some helper functions for examining the the mark
bitmap.

(JSC::Heap::sweep): Simplified this function by using a DeadObjectIterator.

(JSC::Heap::markRoots): Reordered some operations for clarity.

(JSC::Heap::objectCount):
(JSC::Heap::addToStatistics):
(JSC::Heap::statistics): Rewrote these functions to calculate an object
count on demand, since the heap doesn't maintain this information by
itself.

(JSC::Heap::reset): New function for resetting the heap once we've
exhausted heap space.

(JSC::Heap::collectAllGarbage): This function matches the old collect()
behavior, but it's now an uncommon function used only by API.

  • runtime/Collector.h:

(JSC::CollectorBitmap::count):
(JSC::CollectorBitmap::isEmpty): Added some helper functions for managing
the collector mark bitmap.

(JSC::Heap::reportExtraMemoryCost): Changed reporting from cell equivalents
to bytes, so it's easier to understand.

  • runtime/CollectorHeapIterator.h:

(JSC::CollectorHeapIterator::CollectorHeapIterator):
(JSC::CollectorHeapIterator::operator!=):
(JSC::CollectorHeapIterator::operator*):
(JSC::CollectorHeapIterator::advance):
(JSC::::LiveObjectIterator):
(JSC::::operator):
(JSC::::DeadObjectIterator):
(JSC::::ObjectIterator): New iterators for encapsulating details about
heap layout, and what's live and dead on the heap.

  • runtime/JSArray.cpp:

(JSC::JSArray::putSlowCase):
(JSC::JSArray::increaseVectorLength): Delay reporting extra cost until
we're fully constructed, so the heap mark phase won't visit us in an
invalid state.

  • runtime/JSCell.h:

(JSC::JSCell::):
(JSC::JSCell::createDummyStructure):
(JSC::JSCell::JSCell):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h: Added a dummy cell to simplify allocation logic.
  • runtime/JSString.h:

(JSC::jsSubstring): Don't report extra cost for substrings, since they
share a buffer that's already reported extra cost.

  • runtime/Tracing.d:
  • runtime/Tracing.h: Changed these dtrace hooks not to report object

counts, since they're no longer cheap to compute.

  • runtime/UString.h: Updated for renames.
  • runtime/WeakGCMap.h: Added.

(JSC::WeakGCMap::isEmpty):
(JSC::WeakGCMap::uncheckedGet):
(JSC::WeakGCMap::uncheckedBegin):
(JSC::WeakGCMap::uncheckedEnd):
(JSC::::get):
(JSC::::take):
(JSC::::set):
(JSC::::uncheckedRemove): Mentioned above.

  • wtf/StdLibExtras.h:

(WTF::bitCount): Added a bit population count function, so the heap can
count live objects to fulfill statistics questions.

JavaScriptGlue: Changed GC from mark-sweep to mark-allocate.

Reviewed by Sam Weinig.

  • JavaScriptGlue.cpp:

(JSCollect): Updated for rename. Fixed a bug where JSGlue would not check
to avoid nested GC calls.

WebCore: Changed GC from mark-sweep to mark-allocate.

Reviewed by Sam Weinig.

  • ForwardingHeaders/runtime/WeakGCMap.h: Added.
  • bindings/js/GCController.cpp:

(WebCore::collect):
(WebCore::GCController::gcTimerFired):
(WebCore::GCController::garbageCollectNow): Updated for rename.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::removeWrappers):
(WebCore::hasCachedDOMObjectWrapperUnchecked):
(WebCore::hasCachedDOMObjectWrapper):
(WebCore::hasCachedDOMNodeWrapperUnchecked):
(WebCore::forgetDOMObject):
(WebCore::forgetDOMNode):
(WebCore::isObservableThroughDOM):
(WebCore::markDOMNodesForDocument):
(WebCore::markDOMObjectWrapper):
(WebCore::markDOMNodeWrapper):

  • bindings/js/JSDOMBinding.h: Changed DOM wrapper maps to be WeakGCMaps.

Don't ASSERT that an item must be in the WeakGCMap when its destructor
runs, since it might have been overwritten in the map first.

  • bindings/js/JSDocumentCustom.cpp:

(WebCore::toJS): Changed Document from a DOM object wrapper to a DOM node
wrapper, to simplify some code.

  • bindings/js/JSInspectedObjectWrapper.cpp:

(WebCore::JSInspectedObjectWrapper::JSInspectedObjectWrapper):
(WebCore::JSInspectedObjectWrapper::~JSInspectedObjectWrapper):

  • bindings/js/JSInspectorCallbackWrapper.cpp: Use a WeakGCMap for these

wrappers.

  • bindings/js/JSNodeCustom.cpp:

(WebCore::JSNode::markChildren): Updated for WeakGCMap and Document using
a DOM node wrapper instead of a DOM object wrapper.

  • bindings/js/JSSVGPODTypeWrapper.h:

(WebCore::JSSVGDynamicPODTypeWrapperCache::wrapperMap):
(WebCore::JSSVGDynamicPODTypeWrapperCache::lookupOrCreateWrapper):
(WebCore::JSSVGDynamicPODTypeWrapperCache::forgetWrapper):
(WebCore::::~JSSVGDynamicPODTypeWrapper): Shined a small beam of sanity
on this code. Use hashtable-based lookup in JSSVGPODTypeWrapper.h instead
of linear lookup through iteration, since that's what hashtables were
invented for. Make JSSVGPODTypeWrapper.h responsible for reomving itself
from the table, instead of its JS wrapper, to decouple these objects from
GC, and because these objects are refCounted, not solely owned by their
JS wrappers.

  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/Document.h: Adopted changes above.
8:56 PM Changeset in webkit [52039] by Dimitri Glazkov
  • 2 edits in trunk/WebCore

2009-12-11 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, build fix.

[V8] Change bindings to catch up with ​http://trac.webkit.org/changeset/52033.

  • bindings/v8/custom/V8HTMLFormElementCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): Added retrieval of calling frame and passing to the submit method.
6:43 PM Changeset in webkit [52038] by weinig@apple.com
  • 2 edits in trunk/WebCore

Put -umbrella linker flag into a variable so that it can be overridden.

Reviewed by Mark Rowe.

  • Configurations/WebCore.xcconfig:
6:31 PM Changeset in webkit [52037] by yael.aharon@nokia.com
  • 6 edits in trunk

WebKit/qt: Unreviewed build fix for Qt versions < 4.6.

  • tests/qwebframe/tst_qwebframe.cpp:
  • tests/qwebview/tst_qwebview.cpp:

WebKitTools: Unreviewed build fix for Qt versions < 4.6.
Guard every slot individually with #ifdef.

  • DumpRenderTree/qt/EventSenderQt.cpp:
  • DumpRenderTree/qt/EventSenderQt.h:
5:50 PM Changeset in webkit [52036] by hamaji@chromium.org
  • 3 edits
    4 adds in trunk

2009-12-11 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Darin Adler.

body with display:inline causes crash
​https://bugs.webkit.org/show_bug.cgi?id=32371

  • fast/inline/inline-body-crash-expected.txt: Copied from LayoutTests/fast/css-generated-content/absolute-position-inside-inline-expected.txt.
  • fast/inline/inline-body-crash.html: Added.
  • fast/inline/inline-body-with-scrollbar-crash-expected.txt: Copied from LayoutTests/fast/css-generated-content/absolute-position-inside-inline-expected.txt.
  • fast/inline/inline-body-with-scrollbar-crash.html: Added.

2009-12-11 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Darin Adler.

body with display:inline causes crash
​https://bugs.webkit.org/show_bug.cgi?id=32371

Tests: fast/inline/inline-body-crash.html

fast/inline/inline-body-with-scrollbar-crash.html

  • page/FrameView.cpp: (WebCore::FrameView::createScrollbar): (WebCore::FrameView::layout):
5:40 PM Changeset in webkit [52035] by beidson@apple.com
  • 2 edits in trunk/WebCore

Rubberstamped by Sam Weinig.

​https://webkit.org/b/22851 - Remove defunct FIXME.

  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::HTMLPlugInElement): This flag was removed completely

from the HTMLFrameOwnerElement chain of classes.

5:38 PM Changeset in webkit [52034] by Darin Adler
  • 5 edits in trunk/WebCore

Small refactoring to get rid of some extra unneeded selection-related work
in RenderLayer::scrollToOffset and separate caret and range selection
logic in FrameView::layout. This may be useful later when changing how
the range selection logic works to fix layout reentrancy problems.

Reviewed by Dan Bernstein.

  • page/Frame.cpp: Removed invalidateSelection.
  • page/Frame.h: Ditto.
  • page/FrameView.cpp:

(WebCore::FrameView::layout): Call SelectionController::setNeedsLayout
and Frame::selectionLayoutChanged instead of calling
Frame::invalidateSelection, which was just a function that called
both of those others.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollToOffset): Call
SelectionController::setNeedsLayout instead of calling
Frame::invalidateSelection. This call site only needs the caret-related
work in that first function, not the other work formerly done by
Frame::invalidateSelection. The caret works outside the normal
painting and rendering system, and the range selection highlight is
more or less inside it and doesn't need special handling when scrolling.

5:34 PM Changeset in webkit [52033] by beidson@apple.com
  • 9 edits
    5 adds in trunk

<rdar://problem/7342725> and ​https://webkit.org/b/32383
Selecting article text at sfgate.com results in spurious back/forward entries

Reviewed by Darin Adler.

WebCore:

If an iframe had a form and that form is submitted by javascript, IE and Opera don't add back/forward entries.

In the case where the frame was added dynamically via createElement(), Firefox would like to add a back entry
but has a bug that prevents this.

Therefore by a bizarre coincidence, WebKit is the loner and the only engine affected by sfgate.com's technique.

This patch changes us to willfully match IE and Opera and fixes sfgate.com in the process.

Tests: http/tests/navigation/dynamic-iframe-dynamic-form-back-entry.html

http/tests/navigation/parsed-iframe-dynamic-form-back-entry.html

Capture whether the form was submitted by javascript:

  • loader/FormState.cpp:

(WebCore::FormState::FormState):
(WebCore::FormState::create):

  • loader/FormState.h:

(WebCore::FormState::formSubmissionTrigger):

When deciding the value of the lockBackForwardList variable, take formSubmissionTrigger() into account:

  • loader/RedirectScheduler.cpp:

(WebCore::RedirectScheduler::scheduleFormSubmission):

Rearrange the public HTMLFormElement::submit() method to be called only from DOM or JS bindings,
and figure out the rest of the parameters for an internal submit() call including the formSubmissionTrigger:

  • bindings/js/JSHTMLFormElementCustom.cpp:

(WebCore::JSHTMLFormElement::submit):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::prepareSubmit):
(WebCore::HTMLFormElement::submit):

  • html/HTMLFormElement.h:

LayoutTests:

  • http/tests/navigation/dynamic-iframe-dynamic-form-back-entry-expected.txt: Added.
  • http/tests/navigation/dynamic-iframe-dynamic-form-back-entry.html: Added.
  • http/tests/navigation/parsed-iframe-dynamic-form-back-entry-expected.txt: Added.
  • http/tests/navigation/parsed-iframe-dynamic-form-back-entry.html: Added.
  • http/tests/navigation/resources/notify-done.html: Added.
  • http/tests/navigation/onload-navigation-iframe-timeout-expected.txt: Updated.
5:10 PM Changeset in webkit [52032] by ap@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=32445
REGRESSION: ​http://www.mcafee.com/japan/ displays unstyled

  • css/CSSImportRule.cpp: (WebCore::CSSImportRule::setCSSStyleSheet):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::setCSSStyleSheet): Add a quirk for mcafee.com/japan (http or https, with or without www).
5:09 PM Changeset in webkit [52031] by weinig@apple.com
  • 2 edits in trunk/WebCore

Make PlatformWheelEvent.h private instead of project.

Reviewed by Dan Bernstein.

  • WebCore.xcodeproj/project.pbxproj:
4:39 PM Changeset in webkit [52030] by cmarrin@apple.com
  • 4 edits
    5 adds in trunk/WebKit/win

Added icons for full-screen video on Windows
​https://bugs.webkit.org/show_bug.cgi?id=31318

3:49 PM Changeset in webkit [52029] by Simon Fraser
  • 3 edits in trunk/WebCore

2009-12-11 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Support reflections on composited layers
​https://bugs.webkit.org/show_bug.cgi?id=31885

First part of supporting composited reflections on compositing layers.

Rename the m_transformLayer member variable to m_structuralLayer, since it
will get used both for transform layers (for preserve-3d) and to hold a flattening
layer related to reflections, both of which have similar requirements, and are
mutually exclusive.

  • platform/graphics/mac/GraphicsLayerCA.h: primaryLayer(), hostLayerForSublayers() and layerForSuperlayer() all now return a CALayer, since m_structuralLayer isn't always a WebLayer.
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::commitLayerChanges): updateLayerPreserves3D() renamed to updateStructuralLayer()

(WebCore::GraphicsLayerCA::updateLayerNames):
New "update" method for updating layer names.

(WebCore::GraphicsLayerCA::updateSublayerList):
m_transformLayer -> m_structuralLayer. Also minor refactor to only
allocate newSublayers in one place.

(WebCore::GraphicsLayerCA::updateLayerSize):
(WebCore::GraphicsLayerCA::removeAnimationFromLayer):
(WebCore::GraphicsLayerCA::hostLayerForSublayers):
(WebCore::GraphicsLayerCA::layerForSuperlayer):
m_transformLayer -> m_structuralLayer

(WebCore::GraphicsLayerCA::updateStructuralLayer):
Call ensureStructuralLayer() which handles any deltas to the
structural layer type.

(WebCore::GraphicsLayerCA::ensureStructuralLayer):
Handle changes to the structural layer requirements

(WebCore::GraphicsLayerCA::structuralLayerPurpose):
Return an enum describing the purpose of the structural layer; for now
this only returns NoStructuralLayer or StructuralLayerForPreserves3D, but
will in future also have a value related to reflections.

3:34 PM Changeset in webkit [52028] by barraclough@apple.com
  • 17 edits in trunk/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=32454
Refactor construction of simple strings to avoid string concatenation.

Reviewed by Oliver Hunt.

Building strings through concatenation has a memory and performance cost -
a memory cost since we must over-allocate the buffer to leave space to append
into, and performance in that the string may still require reallocation (and
thus copying during construction). Instead move the full construction to
within a single function call (makeString), so that the arguments' lengths
can be calculated and an appropriate sized buffer allocated before copying
any characters.

~No performance change (~2% progression on date tests).

  • bytecode/CodeBlock.cpp:

(JSC::escapeQuotes):
(JSC::valueToSourceString):
(JSC::constantName):
(JSC::idName):
(JSC::CodeBlock::registerName):
(JSC::regexpToSourceString):
(JSC::regexpName):

  • bytecompiler/NodesCodegen.cpp:

(JSC::substitute):

  • profiler/Profiler.cpp:

(JSC::Profiler::createCallIdentifier):

  • runtime/DateConstructor.cpp:

(JSC::callDate):

  • runtime/DateConversion.cpp:

(JSC::formatDate):
(JSC::formatDateUTCVariant):
(JSC::formatTime):
(JSC::formatTimeUTC):

  • runtime/DateConversion.h:

(JSC::):

  • runtime/DatePrototype.cpp:

(JSC::dateProtoFuncToString):
(JSC::dateProtoFuncToUTCString):
(JSC::dateProtoFuncToDateString):
(JSC::dateProtoFuncToTimeString):
(JSC::dateProtoFuncToGMTString):

  • runtime/ErrorPrototype.cpp:

(JSC::errorProtoFuncToString):

  • runtime/ExceptionHelpers.cpp:

(JSC::createUndefinedVariableError):
(JSC::createErrorMessage):
(JSC::createInvalidParamError):

  • runtime/FunctionPrototype.cpp:

(JSC::insertSemicolonIfNeeded):
(JSC::functionProtoFuncToString):

  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncToString):

  • runtime/RegExpConstructor.cpp:

(JSC::constructRegExp):

  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::match):

  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncCompile):
(JSC::regExpProtoFuncToString):

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncBig):
(JSC::stringProtoFuncSmall):
(JSC::stringProtoFuncBlink):
(JSC::stringProtoFuncBold):
(JSC::stringProtoFuncFixed):
(JSC::stringProtoFuncItalics):
(JSC::stringProtoFuncStrike):
(JSC::stringProtoFuncSub):
(JSC::stringProtoFuncSup):
(JSC::stringProtoFuncFontcolor):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncAnchor):

  • runtime/UString.h:

(JSC::):
(JSC::makeString):

3:03 PM Changeset in webkit [52027] by Nate Chapin
  • 3 edits in trunk/WebKit/chromium

2009-12-11 Nate Chapin <Nate Chapin>

Reviewed by Darin Fisher.

Expose shouldHideReferrer() in WebSecurityPolicy.

​https://bugs.webkit.org/show_bug.cgi?id=32398

  • public/WebSecurityPolicy.h: Add shouldHideReferrer().
  • src/WebSecurityPolicy.cpp:
(WebKit
WebSecurityPolicy::shouldHideReferrer): Added.
2:57 PM Changeset in webkit [52026] by barraclough@apple.com
  • 6 edits in trunk/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=32400
Switch remaining cases of string addition to use ropes.

Reviewed by Oliver Hunt.

Re-landing r51975 - added toPrimitiveString method,
performs toPrimitive then subsequent toString operations.

~1% progression on Sunspidey.

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/JSString.h:

(JSC::JSString::JSString):
(JSC::JSString::appendStringInConstruct):

  • runtime/Operations.cpp:

(JSC::jsAddSlowCase):

  • runtime/Operations.h:

(JSC::jsString):
(JSC::jsAdd):

2:39 PM Changeset in webkit [52025] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2009-12-11 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

CommandsTest.assert_execute_outputs doesn't check stderr
​https://bugs.webkit.org/show_bug.cgi?id=32352

Fix assert_execute_outputs to check stderr
and then fix all the unit tests which needed to
pass stderr output.

  • Scripts/modules/commands/commandtest.py:
  • Scripts/modules/commands/download_unittest.py:
  • Scripts/modules/commands/upload_unittest.py:
2:29 PM Changeset in webkit [52024] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

2:28 PM Changeset in webkit [52023] by mrowe@apple.com
  • 1 copy in tags/Safari-532.6

New tag.

1:50 PM Changeset in webkit [52022] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-12-11 Simon Fraser <Simon Fraser>

Build fix for platforms where ACCELERATED_COMPOSITING is not defined.

  • page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::pauseAnimation):
1:35 PM Changeset in webkit [52021] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-12-11 Simon Fraser <Simon Fraser>

Build fix, no review.

Build fix for platforms where ACCELERATED_COMPOSITING is not defined.

  • page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::startAnimation):
1:31 PM Changeset in webkit [52020] by Adam Roben
  • 4 edits in trunk

Windows build fix

JavaScriptCore:

$(WebKitOutputDir)/include/private to the include path.

WebCore:

  • platform/graphics/win/WKCACFLayerRenderer.cpp: Removed #include of

non-existent header.

1:24 PM Changeset in webkit [52019] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-12-11 Simon Fraser <Simon Fraser>

Build fix, no review.

Build fix for platforms where ACCELERATED_COMPOSITING is not defined.

  • page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::startAnimation):
1:02 PM Changeset in webkit [52018] by Simon Fraser
  • 3 edits
    4 adds in trunk

2009-12-11 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Negative values for animation-delay are ignored (treated as zero)
​https://bugs.webkit.org/show_bug.cgi?id=26150

When we get the m_startTime for an animation or transition, subtract any negative
delay so the animation/transition behaves like it started in the past, per spec.

Tests: animations/negative-delay.html

transitions/negative-delay.html

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::updateStateMachine):
12:57 PM Changeset in webkit [52017] by Simon Fraser
  • 12 edits
    1 add in trunk/WebCore

2009-12-11 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Accelerated transitions broken when mixed with paused animations
​https://bugs.webkit.org/show_bug.cgi?id=32387

Synchronization of a mixture of accelerated and software animations occurs via
a callback from GraphicsLayerCA, which ends up in
AnimationControllerPrivate::receivedStartTimeResponse(). The time passed in is
the exact time at which the accelerated animations started, so is used as the
start time for all animations and transitions which are marked as waiting.

The bug was that the callback called when re-starting animations that were
paused sent back an old time value, but this was used to start normal
transitions. Therefore the transition would start with a stale start time, and
thus end prematurely.

The fix is to change the way that GraphicsLayerCA handles paused animations.
Rather than setting the beginTime of the animation, it uses a beginTime of 0
and a timeOffset that gets passed down. Thus the callbacks always come with
beginTime for 'now'.

Also clarify the role of AnimationBase::endAnimation() by splitting it into
pauseAnimation() and endAnimation(), and pass down timeOffsets, rather than
beginTimes when starting and pausing.

Manual test only, because the bug requires a non-trivial combination of
animation pausing and transitions which take time, and the bug only shows in
pixel results.

  • manual-tests/animation/transitions-and-paused-animations.html
  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::updateStateMachine):
  • page/animation/AnimationBase.h: (WebCore::AnimationBase::startAnimation): (WebCore::AnimationBase::pauseAnimation): (WebCore::AnimationBase::endAnimation):
  • page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::~ImplicitAnimation): (WebCore::ImplicitAnimation::startAnimation): (WebCore::ImplicitAnimation::endAnimation): (WebCore::ImplicitAnimation::onAnimationEnd):
  • page/animation/ImplicitAnimation.h: (WebCore::ImplicitAnimation::pauseAnimation):
  • page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::~KeyframeAnimation): (WebCore::KeyframeAnimation::startAnimation): (WebCore::KeyframeAnimation::pauseAnimation): (WebCore::KeyframeAnimation::endAnimation): (WebCore::KeyframeAnimation::onAnimationEnd):
  • page/animation/KeyframeAnimation.h:
  • platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::addAnimation): (WebCore::GraphicsLayer::pauseAnimation):
  • platform/graphics/mac/GraphicsLayerCA.h: (WebCore::GraphicsLayerCA::LayerAnimation::LayerAnimation): (WebCore::GraphicsLayerCA::AnimationProcessingAction::AnimationProcessingAction):
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::addAnimation): (WebCore::GraphicsLayerCA::removeAnimationsForKeyframes): (WebCore::GraphicsLayerCA::pauseAnimation): (WebCore::GraphicsLayerCA::updateLayerAnimations): (WebCore::GraphicsLayerCA::setAnimationOnLayer): (WebCore::GraphicsLayerCA::pauseAnimationOnLayer): (WebCore::GraphicsLayerCA::createAnimationFromKeyframes): (WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::startAnimation): (WebCore::RenderLayerBacking::startTransition): (WebCore::RenderLayerBacking::animationPaused):
  • rendering/RenderLayerBacking.h:
12:50 PM Changeset in webkit [52016] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-12-11 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[check-webkit-style] False positive for tst_QWebFrame
​https://bugs.webkit.org/show_bug.cgi?id=32436

Add an exception for function names that start with "tst_". These are
used by the Qt unit testing framework.

  • Scripts/modules/cpp_style.py:
  • Scripts/modules/cpp_style_unittest.py:
12:46 PM Changeset in webkit [52015] by Adam Roben
  • 5 edits in trunk/JavaScriptCore

Move QuartzCorePresent.h to include/private

This fixes other projects that use wtf/Platform.h

Rubber-stamped by Steve Falkenburg.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Let VS do its thang.
  • JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh: Write

QuartzCorePresent.h to $(WebKitOutputDir)/include/private.

Added $(WebKitOutputDir)/include/private to the include path.

12:38 PM Changeset in webkit [52014] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2009-12-11 Drew Wilson <​atwilson@chromium.org>

Reviewed by Darin Adler.

REGRESSION: fast/workers/dedicated-worker-lifecycle.html failing intermittently on leopard bot
​https://bugs.webkit.org/show_bug.cgi?id=29344

dedicated-worker-lifecycle.html relies on a Worker object getting GC'd, which is never guaranteed (due to conservative GC)
but is especially unreliable on Leopard, so disabling on that platform.

  • platform/mac-leopard/Skipped: disabled dedicated-worker-lifecycle.html.
12:30 PM Changeset in webkit [52013] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Fix clean builds and everything rebuilding on every build

Reviewed by Sam Weinig.

write out QuartzCorePresent.h if it exists but is older than
QuartzCore.h. Also, create the directory we write QuartzCorePresent.h
into first.

11:59 AM Changeset in webkit [52012] by bweinstein@apple.com
  • 3 edits
    2 adds in trunk

Fixes <​http://webkit.org/b/32399>.
Pan Scrolling Jumps out of frames if the initial location is in a frame that can't be scrolled.

Reviewed by Darin Adler.

WebCore:

When we initially figure out the layer that we should begin scrolling, don't try to jump out
of frames/iFrames to look at the owner document. We don't want to jump out of frames, so we
don't need that logic anymore.

Added a test to make sure that we don't pan scroll if we start to scroll in an empty
iFrame that has a scrollable owner document.

Test: platform/win/fast/events/panScroll-no-iframe-jump.html

  • dom/Node.cpp:

(WebCore::Node::defaultEventHandler):

LayoutTests:

Added a test to make sure that we don't pan scroll if we start to scroll in an empty
iFrame that has a scrollable owner document.

  • platform/win/fast/events/panScroll-no-iframe-jump-expected.txt: Added.
  • platform/win/fast/events/panScroll-no-iframe-jump.html: Added.
11:45 AM Changeset in webkit [52011] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Windows build fix for systems with spaces in their paths

  • JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh: Quote some paths.
11:33 AM Changeset in webkit [52010] by bweinstein@apple.com
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh

Copy QuartzCore header file into Include/JavaScriptCore so Platform.h can find it.

11:10 AM Changeset in webkit [52009] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Skip test that is failing because script is not executed after the
view it is on is destroyed.
See ​https://bugs.webkit.org/show_bug.cgi?id=32441

  • platform/gtk/Skipped:
10:46 AM Changeset in webkit [52008] by bweinstein@apple.com
  • 5 edits
    4 adds in trunk

Fixes <​http://webkit.org/b/32303>.
Middle-mouse button not firing mousedown DOM event when autoscroll happens.

Reviewed by Adam Roben.

WebCore:

This fix moves the pan scrolling code into Node.cpp, as part of the default event handler.
We get two wins out of this:

1) Mousedown DOM events are now fired before pan scrolling.
2) Calling event.preventDefault() on a middle mouse button will now prevent pan scrolling.


Added tests to show that middle mousedown DOM events are fired when panscrolling happens, and
that when event.preventDefault is called, pan scrolling doesn't happen.

Tests: platform/win/fast/events/panScroll-event-fired.html

platform/win/fast/events/panScroll-preventDefault.html

  • dom/Node.cpp:

(WebCore::Node::defaultEventHandler): Moved pan scrolling starting code to here.

  • page/EventHandler.cpp:

(WebCore::EventHandler::startPanScrolling): Function to initialize scrolling variables and start timer.
(WebCore::EventHandler::handleMousePressEvent): From here.

  • page/EventHandler.h:

LayoutTests:

Added tests to show that middle mousedown DOM events are fired when panscrolling happens, and
that when event.preventDefault is called, pan scrolling doesn't happen.

  • platform/win/fast/events/panScroll-event-fired-expected.txt: Added.
  • platform/win/fast/events/panScroll-event-fired.html: Added.
  • platform/win/fast/events/panScroll-preventDefault-expected.txt: Added.
  • platform/win/fast/events/panScroll-preventDefault.html: Added.
10:31 AM Changeset in webkit [52007] by cmarrin@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

forgot to save Changelog

10:29 AM Changeset in webkit [52006] by cmarrin@apple.com
  • 11 edits
    5 adds in trunk

Delay load DLLs for accelerated compositing
​https://bugs.webkit.org/show_bug.cgi?id=31856

10:24 AM Changeset in webkit [52005] by eric@webkit.org
  • 2 edits
    2 adds in trunk/WebCore

2009-12-11 Steve Block <​steveblock@google.com>

Reviewed by Darin Fisher.

Adds an Android-specific implementation of initializeMaximumHTTPConnectionCountPerHost.
​https://bugs.webkit.org/show_bug.cgi?id=31810

  • platform/network/ResourceRequestBase.cpp: Modified. Disable default implementation

of initializeMaximumHTTPConnectionCountPerHost for Android.

  • platform/network/android: Added.
  • platform/network/android/ResourceRequestAndroid.cpp: Added. (WebCore::initializeMaximumHTTPConnectionCountPerHost): Android-specific implementation.
10:16 AM Changeset in webkit [52004] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2009-12-11 Avi Drissman <​avi@chromium.org>

Reviewed by Darin Fisher.

Tickmarks in the scrollbar are not cleared for non-main frames
​https://bugs.webkit.org/show_bug.cgi?id=32385

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::stopFinding):
10:13 AM Changeset in webkit [52003] by tkent@chromium.org
  • 4 edits in trunk/WebCore

2009-12-11 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Fisher.

Add acceptTypes() method to FileChooser.
​https://bugs.webkit.org/show_bug.cgi?id=32429

This method returns an 'accept' attribute value of the
corresponding INPUT element. A ChromeClient::runOpenPanel()
implementation can refer it through a FileChooser instance to
support type-restricted file selecting.

This makes no user-visible changes for now.

  • platform/FileChooser.h: (WebCore::FileChooser::acceptTypes):
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::acceptTypes):
  • rendering/RenderFileUploadControl.h:
10:06 AM Changeset in webkit [52002] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][LayoutTestController] Output of document.write() is vanished by waitUntilDone()/notifyDone()
​https://bugs.webkit.org/show_bug.cgi?id=32437

  • platform/qt/Skipped: http/tests/misc/percent-sign-in-form-field-name.html added until bug fixed.
10:03 AM Changeset in webkit [52001] by eric@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2009-12-11 Victor Wang <​victorw@chromium.org>

Reviewed by Darin Fisher.

Changed PopupMenuChromium to keep the value selected from
keyboard when popup is closed.

The problem is Chromium does not fire the onchange event
when the popup is closed if an item is selected via
keyboard by typing the first char of the item. This makes
chromium popup not having consistent behaviours and also
behaves differently from other major browsers.
Calling popup->hide() instead of popup->hidePopup() in
PopupMenu fixes the issues as it does extra step to check
whethere there is a keyboard selection changed when closing
the popup.

​https://bugs.webkit.org/show_bug.cgi?id=32403

TEST: add a manual test as the current layout test shell
does not support sending keyboard events to popup list.

  • manual-tests/chromium/select-close-popup-value-change.html: Added.
  • platform/chromium/PopupMenuChromium.cpp: (WebCore::PopupMenu::hide):
9:31 AM Changeset in webkit [52000] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Skip two tests that require infrastructure our DRT doesn't have,
or functionality our port does not implement.

  • platform/gtk/Skipped:
9:30 AM Changeset in webkit [51999] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed. Skip a timeouter flakey test.

  • platform/qt/Skipped: fast/frames/sandboxed-iframe-storage.html added.
9:21 AM Changeset in webkit [51998] by eric@webkit.org
  • 6 edits in trunk/WebCore

2009-12-11 anton muhin <​antonm@chromium.org>

Reviewed by Adam Barth.

[v8] refactor WeakReferenceMap.
Move common bits of functionality to reduce duplication.

​https://bugs.webkit.org/show_bug.cgi?id=32389

Should be covered by buildbots.

  • bindings/v8/DOMData.h: (WebCore::DOMData::WrapperMapObjectRemover::visitDOMWrapper): (WebCore::DOMData::handleWeakObject): (WebCore::DOMData::removeObjectsFromWrapperMap):
  • bindings/v8/DOMDataStore.cpp: (WebCore::DOMDataStore::weakDOMObjectCallback): (WebCore::DOMDataStore::weakActiveDOMObjectCallback): (WebCore::DOMDataStore::weakNodeCallback): (WebCore::DOMDataStore::weakSVGElementInstanceCallback): (WebCore::DOMDataStore::weakSVGObjectWithContextCallback):
  • bindings/v8/DOMDataStore.h:
  • bindings/v8/V8DOMMap.cpp: (WebCore::visitDOMNodesInCurrentThread): (WebCore::visitDOMObjectsInCurrentThread): (WebCore::visitActiveDOMObjectsInCurrentThread): (WebCore::visitDOMSVGElementInstancesInCurrentThread): (WebCore::visitSVGObjectsInCurrentThread):
  • bindings/v8/V8DOMMap.h: (WebCore::WeakReferenceMap::removeIfPresent): (WebCore::WeakReferenceMap::clear): (WebCore::WeakReferenceMap::visit):
9:19 AM Changeset in webkit [51997] by Csaba Osztrogonác
  • 4 edits
    1 delete in trunk/LayoutTests

Rubber-stamped by Simon Hausmann.

[Qt] TouchEvent related tests have platform dependent results until all platform implement it.

  • platform/qt/fast/dom/Window/window-properties-expected.txt: TouchEvent related output added.
  • platform/qt/fast/dom/prototype-inheritance-expected.txt: TouchEvent related output added.
  • platform/qt/fast/dom/prototype-inheritance.html: Removed. (added by mistake previously)
  • platform/qt/fast/js/global-constructors-expected.txt: TouchEvent related output added.
9:15 AM Changeset in webkit [51996] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Fixed typo in test result.

  • platform/gtk/editing/execCommand/toggle-compound-styles-expected.txt:
9:14 AM Changeset in webkit [51995] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-11 anton muhin <​antonm@chromium.org>

Reviewed by Adam Barth.

[v8] in Debug builds create an additional handle scope
when doing debug build checks.
​https://bugs.webkit.org/show_bug.cgi?id=32335

Should be covered by buildbots.

  • bindings/v8/V8DOMWrapper.h: (WebCore::V8DOMWrapper::convertDOMWrapperToNative): (WebCore::V8DOMWrapper::convertDOMWrapperToNode):
9:07 AM Changeset in webkit [51994] by Csaba Osztrogonác
  • 1 edit
    4 copies in trunk/LayoutTests

Rubber-stamped by Simon Hausmann.

[Qt] TouchEvent related tests have platform dependent results until all platform implement it.
Original expected files copied.

  • platform/qt/fast/dom/Window/window-properties-expected.txt: Copied from LayoutTests/fast/dom/Window/window-properties-expected.txt.
  • platform/qt/fast/dom/prototype-inheritance-expected.txt: Copied from LayoutTests/fast/dom/prototype-inheritance-expected.txt.
  • platform/qt/fast/dom/prototype-inheritance.html: Copied from LayoutTests/fast/dom/prototype-inheritance.html.
  • platform/qt/fast/js/global-constructors-expected.txt: Copied from LayoutTests/fast/js/global-constructors-expected.txt.
8:52 AM Changeset in webkit [51993] by pfeldman@chromium.org
  • 11 edits
    1 move in trunk/WebCore

2009-12-11 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Do not use ContextMenuItem as value type in custom
context menu implementation.

​https://bugs.webkit.org/show_bug.cgi?id=32411

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSInspectorFrontendHostCustom.cpp: (WebCore::JSInspectorFrontendHost::showContextMenu):
  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::InspectorFrontendHost): (WebCore::InspectorFrontendHost::~InspectorFrontendHost): (WebCore::InspectorFrontendHost::showContextMenu): (WebCore::InspectorFrontendHost::contextMenuCleared):
  • inspector/InspectorFrontendHost.h: (WebCore::InspectorFrontendHost::MenuProvider::create): (WebCore::InspectorFrontendHost::MenuProvider::~MenuProvider): (WebCore::InspectorFrontendHost::MenuProvider::disconnect): (WebCore::InspectorFrontendHost::MenuProvider::populateContextMenu): (WebCore::InspectorFrontendHost::MenuProvider::contextMenuCleared): (WebCore::InspectorFrontendHost::MenuProvider::MenuProvider):
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::ContextMenuController): (WebCore::ContextMenuController::clearContextMenu): (WebCore::ContextMenuController::showContextMenu): (WebCore::ContextMenuController::contextMenuItemSelected):
  • page/ContextMenuController.h:
  • page/ContextMenuProvider.h: Added. (WebCore::ContextMenuProvider::~ContextMenuProvider):
  • page/ContextMenuSelectionHandler.h: Removed.
8:22 AM Changeset in webkit [51992] by Girish Ramakrishnan
  • 2 edits in trunk/WebKit/qt

[Qt] Updated QWebElement documentation

Reviewed by Tor Arne Vestbø.

findAll() returns a QWebElementCollection, not QList<QWebElement>.

8:20 AM Changeset in webkit [51991] by Simon Hausmann
  • 6 edits in trunk

WebCore: Basic cross-platform implementation of mapping platform touch events
to JavaScript touch events.

Patch by Simon Hausmann <Simon Hausmann>, Kim Grönholm <​kim.gronholm@nomovok.com> on 2009-12-11
Reviewed by Antti Koivisto.

​https://bugs.webkit.org/show_bug.cgi?id=32114

Test: fast/events/basic-touch-events.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleTouchEvent):

  • page/EventHandler.h:

WebKit/qt: Forward Qt touch events to the event handler as platform touch events.

Patch by Simon Hausmann <Simon Hausmann>, Kim Grönholm <​kim.gronholm@nomovok.com> on 2009-12-11
Reviewed by Antti Koivisto.

​https://bugs.webkit.org/show_bug.cgi?id=32114

  • Api/qwebpage.cpp:

(QWebPagePrivate::touchEvent):
(QWebPage::event):

  • Api/qwebpage_p.h:
8:19 AM Changeset in webkit [51990] by zoltan@webkit.org
  • 2 edits in trunk/WebCore

2009-12-11 Zoltan Horvath <​zoltan@webkit.org>

Reviewed by Darin Adler.

Allow custom memory allocation control for WebCore's EmptyFrameLoaderClient
​https://bugs.webkit.org/show_bug.cgi?id=32110

Inherits the following class from Noncopyable because it is
instantiated by 'new' and no need to be copyable:

class name - instantiated at: WebCore/'location'

class EmptyFrameLoaderClient - svg/graphics/SVGImage.cpp:229

  • loader/FrameLoaderClient.h:
8:17 AM Changeset in webkit [51989] by zoltan@webkit.org
  • 3 edits in trunk/WebCore

2009-12-11 Zoltan Horvath <​zoltan@webkit.org>

Reviewed by Darin Adler.

Allow custom memory allocation control for 3 classes in WebCore's svg and loader directory
​https://bugs.webkit.org/show_bug.cgi?id=32106

Inherits the following classes from Noncopyable because these are instantiated
by 'new' and no need to be copyable:

class/struct name - instantiated at: WebCore/'location'

class EmptyContextMenuClient - instantiated at: svg/graphics/SVGImage.cpp:232
class EmptyDragClient - instantiated at: svg/graphics/SVGImage.cpp:237
class SVGImageChromeClient - instantiated at: svg/graphics/SVGImage.cpp:243

  • svg/graphics/SVGImage.cpp:
  • loader/EmptyClients.h:
7:51 AM Changeset in webkit [51988] by Simon Hausmann
  • 2 edits in trunk/LayoutTests

Skip the touch tests on Windows (somehow that hunk got lost).

  • platform/win/Skipped:
7:46 AM Changeset in webkit [51987] by Simon Hausmann
  • 3 edits in trunk/WebKitTools

Added support for creating synthetic touch events with EventSender
in Qt's DumpRenderTree.

Patch by Simon Hausmann <Simon Hausmann>, Kim Grönholm <​kim.gronholm@nomovok.com> on 2009-12-11
Reviewed by Antti Koivisto.

​https://bugs.webkit.org/show_bug.cgi?id=32114

  • DumpRenderTree/qt/EventSenderQt.cpp:

(EventSender::addTouchPoint):
(EventSender::updateTouchPoint):
(EventSender::touchStart):
(EventSender::touchMove):
(EventSender::touchEnd):
(EventSender::clearTouchPoints):
(EventSender::releaseTouchPoint):
(EventSender::sendTouchEvent):

  • DumpRenderTree/qt/EventSenderQt.h:
7:39 AM Changeset in webkit [51986] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2009-12-11 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Fix a problem that JSC::gregorianDateTimeToMS() returns a negative
value for a huge year value.
​https://bugs.webkit.org/show_bug.cgi?id=32304

  • wtf/DateMath.cpp: (WTF::dateToDaysFrom1970): Renamed from dateToDayInYear, and changed the return type to double. (WTF::calculateDSTOffset): Follow the dateToDaysFrom1970() change. (WTF::timeClip): Use maxECMAScriptTime. (JSC::gregorianDateTimeToMS): Follow the dateToDaysFrom1970() change.

2009-12-11 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

Fix a problem that JSC::gregorianDateTimeToMS() returns a negative
value for a huge year value.
​https://bugs.webkit.org/show_bug.cgi?id=32304

  • fast/js/date-daysfrom1970-overflow-expected.txt: Added.
  • fast/js/date-daysfrom1970-overflow.html: Added.
  • fast/js/script-tests/date-daysfrom1970-overflow.js: Added.
7:35 AM QtWebKit/CodeCamp200912 edited by rgabor@inf.u-szeged.hu
(diff)
7:21 AM Changeset in webkit [51985] by eric@webkit.org
  • 8 edits in trunk

2009-12-11 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Darin Adler.

The values of RuntimeArray are not enumerable
​https://bugs.webkit.org/show_bug.cgi?id=29005

The indices of RuntimeArray should be enumerated like for a regular array.

  • platform/mac/fast/dom/wrapper-classes-objc-expected.txt:
  • platform/mac/fast/dom/wrapper-classes-objc.html:

2009-12-11 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Darin Adler.

The values of RuntimeArray are not enumerable
​https://bugs.webkit.org/show_bug.cgi?id=29005

The indices of RuntimeArray should be enumerated like for a regular array.

  • bridge/runtime_array.cpp: (JSC::RuntimeArray::getOwnPropertyNames):
  • bridge/runtime_array.h:

2009-12-11 Benjamin Poulain <​benjamin.poulain@nokia.com>

Reviewed by Darin Adler.

The values of RuntimeArray are not enumerable
​https://bugs.webkit.org/show_bug.cgi?id=29005

  • DumpRenderTree/mac/ObjCController.m: (+[ObjCController isSelectorExcludedFromWebScript:]): (+[ObjCController webScriptNameForSelector:]): (-[ObjCController arrayOfString]):
7:07 AM Changeset in webkit [51984] by yurys@chromium.org
  • 5 edits in trunk/WebKit/chromium

2009-12-11 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Remove obsolete message handling methods from WebDevTools* interfaces

​https://bugs.webkit.org/show_bug.cgi?id=32320

  • public/WebDevToolsAgent.h:
  • public/WebDevToolsAgentClient.h:
  • public/WebDevToolsFrontend.h:
  • public/WebDevToolsFrontendClient.h:
6:38 AM Changeset in webkit [51983] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-11 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Simon Hausmann.

[Qt] ImageDecoderQt: Fix retrieval of image file extensions

QImageReader only allows retrieving the format() before actually reading the image.

​https://bugs.webkit.org/show_bug.cgi?id=32428

  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::setData): (WebCore::ImageDecoderQt::internalDecodeSize):
6:15 AM Changeset in webkit [51982] by eric@webkit.org
  • 3 edits
    3 adds in trunk/LayoutTests

2009-12-11 Simon Hausmann <Simon Hausmann>

Reviewed by Antti Koivisto.

Added basic layout test for DOM touch events.

​https://bugs.webkit.org/show_bug.cgi?id=32114

  • fast/events/basic-touch-events-expected.txt: Added.
  • fast/events/basic-touch-events.html: Added.
  • fast/events/script-tests/basic-touch-events.js: Added. (appendEventLog): (verifyTouchEvent): (verifyTouchPoint): (singleTouchSequence): (multiTouchSequence): (touchTargets):
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/win/Skipped:
6:07 AM Changeset in webkit [51981] by eric@webkit.org
  • 15 edits
    13 adds in trunk/WebCore

2009-12-11 Simon Hausmann <Simon Hausmann>, Kim Grönholm <​kim.gronholm@nomovok.com>

Reviewed by Antti Koivisto.

Added interfaces for touch event support in JavaScript.

​https://bugs.webkit.org/show_bug.cgi?id=32114

The Touch, TouchEvent and TouchList interfaces come straight from
Android's copy of WebKit (eclaire branch).

The PlatformTouchEvent and PlatformTouchPoint code was written by
us.

No new tests added, we are just adding interfaces
with this patch.

  • WebCore.pro:
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • dom/Document.cpp: (WebCore::Document::addListenerTypeIfNeeded):
  • dom/Document.h: (WebCore::Document::):
  • dom/Document.idl:
  • dom/Element.h:
  • dom/Element.idl:
  • dom/Event.cpp: (WebCore::Event::isTouchEvent):
  • dom/Event.h:
  • dom/EventNames.h:
  • dom/Touch.cpp: Added. (WebCore::contentsX): (WebCore::contentsY): (WebCore::Touch::Touch): (WebCore::Touch::updateLocation):
  • dom/Touch.h: Added. (WebCore::Touch::create): (WebCore::Touch::frame): (WebCore::Touch::target): (WebCore::Touch::identifier): (WebCore::Touch::clientX): (WebCore::Touch::clientY): (WebCore::Touch::screenX): (WebCore::Touch::screenY): (WebCore::Touch::pageX): (WebCore::Touch::pageY):
  • dom/Touch.idl: Added.
  • dom/TouchEvent.cpp: Added. (WebCore::TouchEvent::TouchEvent): (WebCore::TouchEvent::initTouchEvent):
  • dom/TouchEvent.h: Added. (WebCore::TouchEvent::create): (WebCore::TouchEvent::touches): (WebCore::TouchEvent::targetTouches): (WebCore::TouchEvent::changedTouches): (WebCore::TouchEvent::TouchEvent): (WebCore::TouchEvent::isTouchEvent):
  • dom/TouchEvent.idl: Added.
  • dom/TouchList.cpp: Added. (WebCore::TouchList::item):
  • dom/TouchList.h: Added. (WebCore::TouchList::create): (WebCore::TouchList::length): (WebCore::TouchList::append): (WebCore::TouchList::TouchList):
  • dom/TouchList.idl: Added.
  • html/HTMLAttributeNames.in:
  • html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • platform/PlatformTouchEvent.h: Added. (WebCore::PlatformTouchEvent::PlatformTouchEvent): (WebCore::PlatformTouchEvent::touchPoints):
  • platform/PlatformTouchPoint.h: Added. (WebCore::PlatformTouchPoint::): (WebCore::PlatformTouchPoint::id): (WebCore::PlatformTouchPoint::state): (WebCore::PlatformTouchPoint::screenPos): (WebCore::PlatformTouchPoint::pos):
  • platform/qt/PlatformTouchEventQt.cpp: Added. (WebCore::PlatformTouchEvent::PlatformTouchEvent):
  • platform/qt/PlatformTouchPointQt.cpp: Added. (WebCore::PlatformTouchPoint::PlatformTouchPoint):
5:41 AM rgabor_buildbot.pdf attached to QtWebKit/CodeCamp200912 by rgabor@inf.u-szeged.hu
4:46 AM WebKit Team edited by maxime.simon@webkit.org
Add Haiku and myself. (diff)
4:20 AM Changeset in webkit [51980] by benm@google.com
  • 3 edits in trunk/WebCore

[Android] Add detachHistoryItem() to AndroidWebHistoryBridge. And the constructor takes
HistoryItem* now. As AndroidWebHistoryBridge holds a dumb pointer of HistoryItem and
HistoryItem holds a RefPtr of AndroidWebHistoryBridge, the dumb pointer needs to be cleared
when HistoryItem is deleted to avoid potential crash.
​https://bugs.webkit.org/show_bug.cgi?id=32251

Patch by Grace Kloba <​klobag@gmail.com> on 2009-12-11
Reviewed by Darin Adler.

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::~HistoryItem):

  • history/android/AndroidWebHistoryBridge.h:

(WebCore::AndroidWebHistoryBridge::AndroidWebHistoryBridge):
(WebCore::AndroidWebHistoryBridge::detachHistoryItem):

3:04 AM QtWebKit/CodeCamp200912 edited by zherczeg@inf.u-szeged.hu
(diff)
2:44 AM Changeset in webkit [51979] by ukai@chromium.org
  • 7 edits in trunk

2009-12-11 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Pavel Feldman.

Log WebSocket error to Web Inspector console.
​https://bugs.webkit.org/show_bug.cgi?id=32165

  • websocket/tests/handshake-error-expected.txt:
  • websocket/tests/handshake-fail-by-cross-origin-expected.txt:
  • websocket/tests/handshake-fail-by-sub-protocol-mismatch-expected.txt:

2009-12-11 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Pavel Feldman.

Log WebSocket error to Web Inspector console.
​https://bugs.webkit.org/show_bug.cgi?id=32165

  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didOpen): (WebCore::WebSocketChannel::appendToBuffer):
  • websockets/WebSocketHandshake.cpp: (WebCore::WebSocketHandshake::readServerHandshake): (WebCore::WebSocketHandshake::readHTTPHeaders): (WebCore::WebSocketHandshake::checkResponseHeaders):
2:09 AM QtWebKitFeatures46 edited by Simon Hausmann
(diff)
12:31 AM QtWebKit/CodeCamp200912 edited by abecsi@inf.u-szeged.hu
(diff)
12:06 AM QtWebKit/CodeCamp200912 edited by zecke@selfish.org
add bug links (diff)

Dec 10, 2009:

11:54 PM QtWebKit/CodeCamp200912 edited by zecke@selfish.org
Start documenting day 3 (diff)
11:51 PM QtWebKit/CodeCamp200912 edited by zecke@selfish.org
(diff)
7:42 PM Changeset in webkit [51978] by abarth@webkit.org
  • 5 edits in trunk/JavaScriptCore

2009-12-10 Adam Barth <​abarth@webkit.org>

No review, rolling out r51975.
​http://trac.webkit.org/changeset/51975

  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • runtime/JSString.h: (JSC::JSString::JSString): (JSC::JSString::appendStringInConstruct):
  • runtime/Operations.cpp: (JSC::jsAddSlowCase):
  • runtime/Operations.h: (JSC::jsString): (JSC::jsAdd):
7:12 PM Changeset in webkit [51977] by abarth@webkit.org
  • 3 edits
    3 adds in trunk

2009-12-10 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Mixed content shouldn't trigger for plug-ins without URLs
​https://bugs.webkit.org/show_bug.cgi?id=32384

  • http/tests/security/mixedContent/empty-url-plugin-in-frame-expected.txt: Added.
  • http/tests/security/mixedContent/empty-url-plugin-in-frame.html: Added.
  • http/tests/security/mixedContent/resources/frame-with-empty-url-plugin.html: Added.

2009-12-10 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

Mixed content shouldn't trigger for plug-ins without URLs
​https://bugs.webkit.org/show_bug.cgi?id=32384

These plug-ins cannot be controlled by active network attackers, so
there's no reason to trigger a mixed content warning.

Test: http/tests/security/mixedContent/empty-url-plugin-in-frame.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::isMixedContent):
6:22 PM Changeset in webkit [51976] by oliver@apple.com
  • 5 edits in trunk

Incorrect caching of prototype lookup with dictionary base
​https://bugs.webkit.org/show_bug.cgi?id=32402

Reviewed by Gavin Barraclough

Make sure we don't add cached prototype lookup to the proto_list
lookup chain if the top level object is a dictionary.

6:07 PM Changeset in webkit [51975] by barraclough@apple.com
  • 5 edits in trunk/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=32400
Switch remaining cases of string addition to use ropes.

Reviewed by Oliver Hunt.

~1% progression on Sunspidey.

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/JSString.h:

(JSC::JSString::JSString):
(JSC::JSString::appendStringInConstruct):

  • runtime/Operations.cpp:

(JSC::jsAddSlowCase):

  • runtime/Operations.h:

(JSC::jsString):
(JSC::jsAdd):

4:58 PM Changeset in webkit [51974] by eroman@chromium.org
  • 2 edits in trunk/WebKit/chromium

Unreviewed, build fix for chromium.

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchWillSendRequest):
4:41 PM Changeset in webkit [51973] by ap@apple.com
  • 3 edits
    3 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=32140
REGRESSION(r50072): Mailman administrative functionality is broken

Test: http/tests/misc/percent-sign-in-form-field-name.html

  • platform/network/FormDataBuilder.cpp: (WebCore::appendQuotedString): Don't encode percent sign, we never had a good reason to do that.
4:20 PM Changeset in webkit [51972] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-12-10 Eric Seidel <​eric@webkit.org>

No review, just updating unit tests to match recent checkins.

  • Scripts/modules/mock_bugzillatool.py:
    • Add missing red_core_builders_names method causing exception.
  • Scripts/modules/workqueue_unittest.py:
    • processutils is dead, use executive.py instead.
4:06 PM Changeset in webkit [51971] by eric@webkit.org
  • 17 edits in trunk

2009-12-10 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Geoffrey Garen.

Remove JSObject::getPropertyAttributes() and all usage of it.
​https://bugs.webkit.org/show_bug.cgi?id=31933

getOwnPropertyDescriptor() should be used instead.

  • JavaScriptCore.exp:
  • JavaScriptCore.order:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::getOwnPropertyDescriptor):
  • debugger/DebuggerActivation.h:
  • runtime/JSObject.cpp: (JSC::JSObject::propertyIsEnumerable):
  • runtime/JSObject.h:
  • runtime/JSVariableObject.cpp:
  • runtime/JSVariableObject.h:

2009-12-10 Kent Hansen <​kent.hansen@nokia.com>

Reviewed by Geoffrey Garen.

Remove getPropertyAttributes() from JavaScript bindings.
​https://bugs.webkit.org/show_bug.cgi?id=31933

The functionality is provided by getOwnPropertyDescriptor().

  • WebCore.order:
  • bindings/js/JSDOMWindowCustom.cpp:
  • bindings/js/JSDOMWindowShell.cpp:
  • bindings/js/JSDOMWindowShell.h:
  • bindings/scripts/CodeGeneratorJS.pm:
  • page/DOMWindow.idl:
3:55 PM Changeset in webkit [51970] by eric@webkit.org
  • 23 edits
    3 adds in trunk

2009-12-10 Kenneth Russell <​kbr@google.com>

Reviewed by Oliver Hunt.

Changed WebGLRenderingContext to synthesize GL errors rather than
raising JavaScript exceptions. Removed internal getError() calls
after each graphics call. The GraphicsContext3D maintains the
synthetic exceptions because only it has complete information
about certain conditions requiring them to be raised.

Based on idea from Ilmari Heikkinen, added create3DDebugContext()
to webgl-test.js and changed the WebGL layout tests expecting
error conditions to use it. Updated expected.txt files, which now
implicitly test the OpenGL error as it is part of the exception's
message.

Added new targeted test covering aspects of synthetic errors as
well as regression tests for bugs uncovered during its development.

Test: fast/canvas/webgl/error-reporting.html

  • fast/canvas/webgl/drawArraysOutOfBounds-expected.txt:
  • fast/canvas/webgl/drawArraysOutOfBounds.html:
  • fast/canvas/webgl/drawElementssOutOfBounds-expected.txt:
  • fast/canvas/webgl/drawElementssOutOfBounds.html:
  • fast/canvas/webgl/error-reporting-expected.txt: Added.
  • fast/canvas/webgl/error-reporting.html: Added.
  • fast/canvas/webgl/getActiveTest-expected.txt:
  • fast/canvas/webgl/incorrect-context-object-behaviour-expected.txt:
  • fast/canvas/webgl/invalidPassedParams-expected.txt:
  • fast/canvas/webgl/invalidPassedParams.html:
  • fast/canvas/webgl/null-object-behaviour-expected.txt:
  • fast/canvas/webgl/resources/webgl-test.js: (create3DDebugContext.wrap.getError): (create3DDebugContext):
  • fast/canvas/webgl/script-tests/error-reporting.js: Added.
  • fast/canvas/webgl/script-tests/getActiveTest.js:
  • fast/canvas/webgl/script-tests/incorrect-context-object-behaviour.js:
  • fast/canvas/webgl/script-tests/null-object-behaviour.js:
  • fast/canvas/webgl/script-tests/uniform-location.js:
  • fast/canvas/webgl/uniform-location-expected.txt:

2009-12-10 Kenneth Russell <​kbr@google.com>

Reviewed by Oliver Hunt.

Changed WebGLRenderingContext to synthesize GL errors rather than
raising JavaScript exceptions. Removed internal getError() calls
after each graphics call. The GraphicsContext3D maintains the
synthetic exceptions because only it has complete information
about certain conditions requiring them to be raised.

Based on idea from Ilmari Heikkinen, added create3DDebugContext()
to webgl-test.js and changed the WebGL layout tests expecting
error conditions to use it. Updated expected.txt files, which now
implicitly test the OpenGL error as it is part of the exception's
message.

Added new targeted test covering aspects of synthetic errors as
well as regression tests for bugs uncovered during its development.

Test: fast/canvas/webgl/error-reporting.html

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::sizeInBytes): (WebCore::WebGLRenderingContext::activeTexture): (WebCore::WebGLRenderingContext::attachShader): (WebCore::WebGLRenderingContext::bindAttribLocation): (WebCore::WebGLRenderingContext::bindBuffer): (WebCore::WebGLRenderingContext::bindFramebuffer): (WebCore::WebGLRenderingContext::bindRenderbuffer): (WebCore::WebGLRenderingContext::bindTexture): (WebCore::WebGLRenderingContext::bufferData): (WebCore::WebGLRenderingContext::bufferSubData): (WebCore::WebGLRenderingContext::compileShader): (WebCore::WebGLRenderingContext::createShader): (WebCore::WebGLRenderingContext::detachShader): (WebCore::WebGLRenderingContext::disableVertexAttribArray): (WebCore::WebGLRenderingContext::drawArrays): (WebCore::WebGLRenderingContext::drawElements): (WebCore::WebGLRenderingContext::enableVertexAttribArray): (WebCore::WebGLRenderingContext::framebufferRenderbuffer): (WebCore::WebGLRenderingContext::framebufferTexture2D): (WebCore::WebGLRenderingContext::getActiveAttrib): (WebCore::WebGLRenderingContext::getActiveUniform): (WebCore::WebGLRenderingContext::getBufferParameter): (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): (WebCore::WebGLRenderingContext::getParameter): (WebCore::WebGLRenderingContext::getProgramParameter): (WebCore::WebGLRenderingContext::getProgramInfoLog): (WebCore::WebGLRenderingContext::getRenderbufferParameter): (WebCore::WebGLRenderingContext::getShaderParameter): (WebCore::WebGLRenderingContext::getShaderInfoLog): (WebCore::WebGLRenderingContext::getShaderSource): (WebCore::WebGLRenderingContext::getTexParameter): (WebCore::WebGLRenderingContext::getUniform): (WebCore::WebGLRenderingContext::getUniformLocation): (WebCore::WebGLRenderingContext::getVertexAttrib): (WebCore::WebGLRenderingContext::linkProgram): (WebCore::WebGLRenderingContext::shaderSource): (WebCore::WebGLRenderingContext::texImage2D): (WebCore::WebGLRenderingContext::texSubImage2D): (WebCore::WebGLRenderingContext::uniform1f): (WebCore::WebGLRenderingContext::uniform1fv): (WebCore::WebGLRenderingContext::uniform1i): (WebCore::WebGLRenderingContext::uniform1iv): (WebCore::WebGLRenderingContext::uniform2f): (WebCore::WebGLRenderingContext::uniform2fv): (WebCore::WebGLRenderingContext::uniform2i): (WebCore::WebGLRenderingContext::uniform2iv): (WebCore::WebGLRenderingContext::uniform3f): (WebCore::WebGLRenderingContext::uniform3fv): (WebCore::WebGLRenderingContext::uniform3i): (WebCore::WebGLRenderingContext::uniform3iv): (WebCore::WebGLRenderingContext::uniform4f): (WebCore::WebGLRenderingContext::uniform4fv): (WebCore::WebGLRenderingContext::uniform4i): (WebCore::WebGLRenderingContext::uniform4iv): (WebCore::WebGLRenderingContext::uniformMatrix2fv): (WebCore::WebGLRenderingContext::uniformMatrix3fv): (WebCore::WebGLRenderingContext::uniformMatrix4fv): (WebCore::WebGLRenderingContext::useProgram): (WebCore::WebGLRenderingContext::validateProgram): (WebCore::WebGLRenderingContext::vertexAttribPointer):
  • html/canvas/WebGLRenderingContext.h: (WebCore::WebGLRenderingContext::cleanupAfterGraphicsCall):
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::getActiveAttrib): (WebCore::GraphicsContext3D::getActiveUniform): (WebCore::GraphicsContext3D::getError): (WebCore::GraphicsContext3D::synthesizeGLError):

2009-12-10 Kenneth Russell <​kbr@google.com>

Reviewed by Oliver Hunt.

Changed WebGLRenderingContext to synthesize GL errors rather than
raising JavaScript exceptions. Removed internal getError() calls
after each graphics call. The GraphicsContext3D maintains the
synthetic exceptions because only it has complete information
about certain conditions requiring them to be raised.

Based on idea from Ilmari Heikkinen, added create3DDebugContext()
to webgl-test.js and changed the WebGL layout tests expecting
error conditions to use it. Updated expected.txt files, which now
implicitly test the OpenGL error as it is part of the exception's
message.

Added new targeted test covering aspects of synthetic errors as
well as regression tests for bugs uncovered during its development.

Test: fast/canvas/webgl/error-reporting.html

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::reshape): (WebCore::GraphicsContext3DInternal::getError): (WebCore::GraphicsContext3DInternal::synthesizeGLError): (WebCore::GraphicsContext3D::getActiveAttrib): (WebCore::GraphicsContext3D::getActiveUniform): (WebCore::GraphicsContext3D::getError): (WebCore::GraphicsContext3D::synthesizeGLError):
3:47 PM Changeset in webkit [51969] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2009-12-10 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Move run_command onto Executive to make code which uses run_command testable
​https://bugs.webkit.org/show_bug.cgi?id=32396

  • Scripts/modules/executive.py:
    • Move run_command and error handlers onto Executive.
  • Scripts/modules/scm.py:
  • Scripts/modules/scm_unittest.py:
3:40 PM Changeset in webkit [51968] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-10 Stephen White <​senorblanco@chromium.org>

Reviewed by Dimitri Glazkov.

Fix for assert on Chrome/skia with SVG Filters enabled.
​https://bugs.webkit.org/show_bug.cgi?id=32394

Covered by LayoutTests/svg/W3C-SVG-1.1/filters-tile-01-b.svg and others.

  • platform/graphics/skia/ImageBufferSkia.cpp: (WebCore::ImageBuffer::platformTransformColorSpace):
3:33 PM Changeset in webkit [51967] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2009-12-10 Mike Belshe <​mike@belshe.com>

Reviewed by Darin Fisher.

Fix FrameLoader to use the new ResourceTypes properly.

​https://bugs.webkit.org/show_bug.cgi?id=32336

  • public/WebURLRequest.h: (WebKit::WebURLRequest::):
  • src/FrameLoaderClientImpl.cpp: (WebKit::setTargetTypeFromLoader): (WebKit::FrameLoaderClientImpl::dispatchWillSendRequest):
3:28 PM Changeset in webkit [51966] by hclam@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

Layout test for video element on HTTP
​https://bugs.webkit.org/show_bug.cgi?id=32333

Reviewed by Eric Carlson.

Added a new layout test that tests video element on HTTP protocol.
This test load the same video file twice. The first load will cache
the video file if caching is supported. The second load ensure
the cache works correctly.

  • http/tests/media/resources/test.mp4: Copied from LayoutTests/media/content/test.mp4.
  • http/tests/media/resources/test.ogv: Copied from LayoutTests/media/content/test.ogv.

The above two files are copied from LayoutTests/media/content because the HTTP
server is rooted at LayoutTests/http/tests. And we don't want to serve these
files with cgi because that will ruin the HTTP headers.

  • http/tests/media/video-load-twice-expected.txt: Added.
  • http/tests/media/video-load-twice.html: Added.
2:59 PM Changeset in webkit [51965] by enrica@apple.com
  • 7 edits
    2 adds in trunk

REGRESSION(4.0.4-42a12): With 2 highlighted lines of text in gmail/hotmail selecting Bold selects other 2 edit buttons automatically.
<rdar://problem/7442065>
​https://bugs.webkit.org/show_bug.cgi?id=32285

Reviewed by Darin Adler.

WebCore:

When examining the styles of the nodes after the first in a range selection, we take into
cosideration differences in style of txt nodes only.

Test: editing/execCommand/queryCommandState-02.html

  • editing/Editor.cpp:

(WebCore::Editor::selectionHasStyle):

LayoutTests:

  • editing/execCommand/queryCommandState-02-expected.txt: Added.
  • editing/execCommand/queryCommandState-02.html: Added.
  • editing/execCommand/script-tests/toggle-compound-styles.js: Fixed typo in text.
  • platform/mac/editing/execCommand/toggle-compound-styles-expected.txt: Fixed typo in text.
  • platform/qt/editing/execCommand/toggle-compound-styles-expected.txt: Fixed typo in text.
  • platform/win/editing/execCommand/toggle-compound-styles-expected.txt: Fixed typo in text.
2:13 PM Changeset in webkit [51964] by barraclough@apple.com
  • 7 edits in trunk/JavaScriptCore

​https://bugs.webkit.org/show_bug.cgi?id=32367
Add support for short Ropes (up to 3 entries) inline within JSString.
(rather than externally allocating an object to hold the rope).
Switch jsAdd of (JSString* + JSString*) to now make use of Ropes.

Reviewed by Oliver Hunt & Mark Rowe.

~1% progression on Sunspidey.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTIMachineTrampolines):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/JSString.cpp:

(JSC::JSString::resolveRope):
(JSC::JSString::toBoolean):
(JSC::JSString::getStringPropertyDescriptor):

  • runtime/JSString.h:

(JSC::JSString::Rope::Fiber::deref):
(JSC::JSString::Rope::Fiber::ref):
(JSC::JSString::Rope::Fiber::refAndGetLength):
(JSC::JSString::Rope::append):
(JSC::JSString::JSString):
(JSC::JSString::~JSString):
(JSC::JSString::value):
(JSC::JSString::tryGetValue):
(JSC::JSString::length):
(JSC::JSString::canGetIndex):
(JSC::JSString::appendStringInConstruct):
(JSC::JSString::appendValueInConstructAndIncrementLength):
(JSC::JSString::isRope):
(JSC::JSString::string):
(JSC::JSString::ropeLength):
(JSC::JSString::getStringPropertySlot):

  • runtime/Operations.h:

(JSC::jsString):
(JSC::jsAdd):
(JSC::resolveBase):

2:10 PM Changeset in webkit [51963] by Dimitri Glazkov
  • 2 edits in trunk/LayoutTests

2009-12-10 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, fixing layout test mishap.

Add a newline to the layout test.

  • http/tests/security/isolatedWorld/events-expected.txt: Added a newline at the end of the file.
2:06 PM Changeset in webkit [51962] by oliver@apple.com
  • 5 edits
    3 adds in trunk

Crash in XMLTokenizer::popCurrentNode if window.close() is called during parsing
​https://bugs.webkit.org/show_bug.cgi?id=31576

Reviewed by Alexey Proskuryakov.

Add a RefCounted wrapper object around xmlParserCtxtPtr so we can
maintain it's lifetime more effectively.

Test: fast/parser/xhtml-close-while-parsing.xhtml

1:59 PM BuildingQtOnOSX edited by piet.webkit@yahoo.com
Require qt4-mac-dev (v4.6) instead of qt4-mac (v4.5.3). See … (diff)
1:54 PM Changeset in webkit [51961] by pfeldman@chromium.org
  • 4 edits in trunk/WebCore

2009-12-10 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: debugger shortcuts don't work when
Search field or Console drawer has focus.

​https://bugs.webkit.org/show_bug.cgi?id=32392

1:42 PM Changeset in webkit [51960] by Dimitri Glazkov
  • 17 edits
    2 copies
    2 adds in trunk

WebCore:

2009-12-10 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

[V8] Events created in isolated worlds may fire in main world.
​https://bugs.webkit.org/show_bug.cgi?id=32386

Test: http/tests/security/isolatedWorld/events.html

  • WebCore.gypi: Added WorldContextHandle.
  • bindings/v8/ScriptEventListener.cpp: (WebCore::createAttributeEventListener): Added WorldContextHandle params.
  • bindings/v8/SharedPersistent.h: Fixed a few style/include issues.
  • bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::V8AbstractEventListener): Added WorldContextHandle params. (WebCore::V8AbstractEventListener::handleEvent): Adjusted context retrieval to use WorldContextHandle. (WebCore::V8AbstractEventListener::invokeEventHandler): Ditto.
  • bindings/v8/V8AbstractEventListener.h: (WebCore::V8AbstractEventListener::worldContext): Added WorldContextHandle params.
  • bindings/v8/V8EventListenerList.h: (WebCore::V8EventListenerList::findOrCreateWrapper): Ditto.
  • bindings/v8/V8LazyEventListener.cpp: (WebCore::V8LazyEventListener::V8LazyEventListener): Ditto. (WebCore::V8LazyEventListener::prepareListenerObject): Adjusted context retrieval to use WorldContextHandle.
  • bindings/v8/V8LazyEventListener.h: (WebCore::V8LazyEventListener::create): Added WorldContextHandle params.
  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::context): Refactored to use mainWorldContext(); (WebCore::V8Proxy::mainWorldContext): Added. (WebCore::toV8Context): Changed to use WorldContextHandle.
  • bindings/v8/V8Proxy.h: Added mainWorldContext decl.
  • bindings/v8/V8Utilities.cpp: (WebCore::reportException): Added an extra check to avoid crashes during frame teardown.
  • bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::V8WorkerContextEventListener): Added WorldContextHandle params.
  • bindings/v8/V8WorkerContextEventListener.h: (WebCore::V8WorkerContextEventListener::create): Added WorldContextHandle params.
  • bindings/v8/WorldContextHandle.cpp: Added.
  • bindings/v8/WorldContextHandle.h: Added.
  • bindings/v8/custom/V8CustomEventListener.cpp: (WebCore::V8EventListener::V8EventListener): Added WorldContextHandle params.
  • bindings/v8/custom/V8CustomEventListener.h: (WebCore::V8EventListener::create): Added WorldContextHandle params.

LayoutTests:

2009-12-10 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adam Barth.

[V8] Events created in isolated worlds may fire in main world.
​https://bugs.webkit.org/show_bug.cgi?id=32386

This test is relevant to both JSC and V8 isolated world implementation,
ensuring that events are fired in the right worlds.

  • http/tests/security/isolatedWorld/events.html: Added.
  • http/tests/security/isolatedWorld/events-expected.txt: Added.
1:17 PM Changeset in webkit [51959] by eric@webkit.org
  • 6 edits in trunk/WebKitTools

2009-12-09 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool needs a command to list patches needing cq+
​https://bugs.webkit.org/show_bug.cgi?id=32351

  • Scripts/modules/bugzilla.py:
    • Parse attacher_email from attachment xml.
  • Scripts/modules/bugzilla_unittest.py:
    • Test new attacher_email parsing.
  • Scripts/modules/commands/queries.py:
    • Add PatchesToCommitQueue
  • Scripts/modules/commands/queries_unittest.py:
    • Tests for PatchesToCommitQueue
  • Scripts/modules/mock_bugzillatool.py:
    • Add necessary mock methods for running PatchesToCommitQueue
1:04 PM Changeset in webkit [51958] by jhoneycutt@apple.com
  • 4 edits in trunk/WebKit/mac

Mac build fix. Unreviewed.

Re-adds code that was mistakenly removed from my last patch.

  • WebCoreSupport/WebPluginHalterClient.mm:

Add necessary #import.

  • WebView/WebDelegateImplementationCaching.h:

Declare a new overload of CallUIDelegateReturningBoolean.

  • WebView/WebDelegateImplementationCaching.mm:

(CallDelegateReturningBoolean):
Add a new overload with different arguments.
(CallUIDelegateReturningBoolean):
Ditto.

12:24 PM Changeset in webkit [51957] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

Reviewed by Xan Lopez.

Add a missing null-check, that is causing some crash reports.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::committedLoad):
11:57 AM Changeset in webkit [51956] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-10 Adam Barth <​abarth@webkit.org>

Unreviewed. Turns out every StepSequence command needs a --quiet
option.

  • Scripts/modules/stepsequence.py:
11:51 AM Changeset in webkit [51955] by andersca@apple.com
  • 4 edits in trunk/JavaScriptCore

Fix three more things found by compiling with clang++.

Reviewed by Geoffrey Garen.

  • runtime/Structure.h:

(JSC::StructureTransitionTable::reifySingleTransition):
Add the 'std' qualifier to the call to make_pair.

  • wtf/DateMath.cpp:

(WTF::initializeDates):
Incrementing a bool is deprecated according to the C++ specification.

  • wtf/PtrAndFlags.h:

(WTF::PtrAndFlags::PtrAndFlags):
Name lookup should not be done in dependent bases, so explicitly qualify the call to set.

11:33 AM Changeset in webkit [51954] by bweinstein@apple.com
  • 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Touch WebKit.idl to try and fix the Windows build.

11:23 AM Changeset in webkit [51953] by jhoneycutt@apple.com
  • 16 edits in trunk

Pass more information about a plug-in to the PluginHalterDelegate

Reviewed by Adam Roben.

WebCore:

  • loader/EmptyClients.h:

Remove this unused class.

  • page/HaltablePlugin.h:

Add new functions to return the plug-in's name and whether it is
windowed.

  • page/PluginHalter.cpp:

(WebCore::PluginHalter::timerFired):
Pass new arguments to the client.

  • page/PluginHalterClient.h:

Add new parameters.

  • plugins/PluginView.cpp:

(WebCore::PluginView::pluginName):
Return the name from the PluginPackage.

  • plugins/PluginView.h:

(WebCore::PluginView::isWindowed):

WebKit/mac:

  • Plugins/WebBaseNetscapePluginView.mm:

(WebHaltablePlugin::isWindowed):
Return false - the Mac doesn't really have windowed plug-ins.
(WebHaltablePlugin::pluginName):
Return the name from the plug-in package.

  • WebCoreSupport/WebPluginHalterClient.h:

Update for new parameters.

  • WebCoreSupport/WebPluginHalterClient.mm:

(WebPluginHalterClient::shouldHaltPlugin):
Ditto; pass them when making the delegate call.

  • WebView/WebUIDelegatePrivate.h:

Update for new parameters.

WebKit/win:

  • Interfaces/IWebPluginHalterDelegate.idl:

Add new parameters.

  • WebCoreSupport/WebPluginHalterClient.cpp:

(WebPluginHalterClient::shouldHaltPlugin):
Update for new parameters. Pass them when making the delegate call.

  • WebCoreSupport/WebPluginHalterClient.h:

Update for new parameters.

10:58 AM Changeset in webkit [51952] by bweinstein@apple.com
  • 3 edits in trunk/WebCore

Fixes <​http://webkit.org/b/31738>.
Web Inspector: Console Scope Bar should be on top of console when Console is a Panel.

Reviewed by Pavel Feldman.

When the console is set to be shown as a full panel, move the scope bar to the top
where it looks best. When it is only shown as a drawer, move it to the bottom, where
it originally was. This takes up less space as a drawer, and makes it more discoverable
and usable when it is the full panel.

  • inspector/front-end/ConsolePanel.js:

(WebInspector.ConsolePanel.prototype.show): Move filter bar to top.
(WebInspector.ConsolePanel.prototype.hide): Move filter bar back to bottom.

  • inspector/front-end/inspector.css:
9:54 AM Changeset in webkit [51951] by abarth@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

2009-12-10 Patrik Persson <​patrik.j.persson@ericsson.com>

Reviewed by Adam Barth.

Test case to verify that sandboxing 'about:blank' does not make
the containing frame sandboxed.

​https://bugs.webkit.org/show_bug.cgi?id=21288#c28

  • fast/frames/resources/sandboxed-iframe-about-blank.html: Added.
  • fast/frames/sandboxed-iframe-about-blank-expected.txt: Added.
  • fast/frames/sandboxed-iframe-about-blank.html: Added.
9:13 AM Changeset in webkit [51950] by senorblanco@chromium.org
  • 2 edits in trunk/WebCore

Fix for alpha blending in SVG Filters on Chromium/skia.
​https://bugs.webkit.org/show_bug.cgi?id=32378

Reviewed by Dirk Schulze.

Covered by LayoutTests/svg/filters/feGaussianBlur.svg and others.

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::platformTransformColorSpace):

8:44 AM Changeset in webkit [51949] by pfeldman@chromium.org
  • 2 edits in trunk/WebKit/chromium

2009-12-10 Ilya Tikhonovsky <​loislo@google.com>

Reviewed by Pavel Feldman.

Chromium: Expose devtools agent API for inspector layout tests.

​https://bugs.webkit.org/show_bug.cgi?id=32379

  • public/WebDevToolsAgent.h: (WebKit::WebDevToolsAgent::setTimelineProfilingEnabled): (WebKit::WebDevToolsAgent::evaluateInWebInspector):
6:29 AM Changeset in webkit [51948] by kov@webkit.org
  • 8 edits
    2 adds in trunk

Reviewed by Xan Lopez.

[GTK] Should provide an API to control the IconDatabase
​https://bugs.webkit.org/show_bug.cgi?id=32334

First step towards a full IconDatabase API. This provides
notification for pages with favicons, and lets clients handle
them.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::registerForIconNotification): (WebKit::FrameLoaderClient::dispatchDidReceiveIcon):
  • tests/resources/blank.ico: Added.
  • tests/testwebview.c: Added. (server_callback): (idle_quit_loop_cb): (icon_uri_changed_cb): (icon_loaded_cb): (test_webkit_web_view_icon_uri): (main):
  • webkit/webkitprivate.cpp: (closeIconDatabaseOnExit): (webkit_init):
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_get_property): (webkit_web_view_finalize): (webkit_web_view_class_init): (webkit_web_view_get_icon_uri):
  • webkit/webkitwebview.h:
5:55 AM Changeset in webkit [51947] by eric@webkit.org
  • 4 edits in trunk

2009-12-10 Eric Z. Ayers <​zundel@google.com>

Reviewed by Pavel Feldman.

DumpRenderTree has been patched so that the timeline-paint.html
unit test now runs under GTK+.

​https://bugs.webkit.org/show_bug.cgi?id=31729

  • platform/gtk/Skipped:

2009-12-10 Eric Z. Ayers <​zundel@google.com>

Reviewed by Pavel Feldman.

Implements displayWebView() to force an invalidation and repaint.
This fixes a problem running the timeline-paint.html unit test.

​https://bugs.webkit.org/show_bug.cgi?id=31729

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (displayWebView):
4:53 AM Changeset in webkit [51946] by pfeldman@chromium.org
  • 10 edits in trunk/WebCore

2009-12-10 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Add context menu actions for DOM tree.

​https://bugs.webkit.org/show_bug.cgi?id=32348

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ContextMenu.js: (WebInspector.ContextMenu): (WebInspector.ContextMenu.prototype.show): (WebInspector.ContextMenu.prototype.appendItem): (WebInspector.ContextMenu.prototype.appendSeparator): (WebInspector.ContextMenu.prototype._itemSelected): (WebInspector.contextMenuItemSelected): (WebInspector.contextMenuCleared):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline.prototype._onmouseout): (WebInspector.ElementsTreeOutline.prototype.populateContextMenu): (WebInspector.ElementsTreeElement.prototype.ondblclick): (WebInspector.ElementsTreeElement.prototype._startEditingFromEvent): (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu): (WebInspector.ElementsTreeElement.prototype._populateTextContextMenu): (WebInspector.ElementsTreeElement.prototype._startEditing): (WebInspector.ElementsTreeElement.prototype._addNewAttribute):
  • inspector/front-end/ObjectPropertiesSection.js: (WebInspector.ObjectPropertyTreeElement.prototype.ondblclick):
  • inspector/front-end/ResourceView.js: (WebInspector.ResourceView.prototype._toggleURLdecoding):
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourceSidebarTreeElement.prototype.ondblclick):
  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype):
  • inspector/front-end/inspector.js: (WebInspector.contextMenuEventFired):
  • inspector/front-end/treeoutline.js: (TreeElement.treeElementDoubleClicked):
4:05 AM Changeset in webkit [51945] by Nikolas Zimmermann
  • 20 edits in trunk/WebCore

2009-12-09 Nikolas Zimmermann <​nzimmermann@rim.com>

Reviewed by Oliver Hunt.

Filters contain some leaks in untested code
​https://bugs.webkit.org/show_bug.cgi?id=32325

Fix obvious leak in SVGFE*Lighting classes. Implement the create() idiom for
all classes in svg/graphics, that were missing it. The lighting filters aren't
implemented so far, but the associated FilterEffect objects are build, which created
these leaks.

This removes the SVG related failures in the leaks bot.

4:04 AM Changeset in webkit [51944] by Nikolas Zimmermann
  • 3 edits in trunk/LayoutTests

2009-12-10 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Skip two tests on gtk/qt that generate new results.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
2:13 AM QtBackLog edited by zecke@selfish.org
(diff)
2:13 AM QtBackLog edited by zecke@selfish.org
(diff)
1:21 AM Changeset in webkit [51943] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2009-12-10 Kenneth Russell <​kbr@google.com>

Reviewed by Oliver Hunt.

[Chromium] SporeViewer demo doesn't work in Chromium
​https://bugs.webkit.org/show_bug.cgi?id=32364

Test: fast/canvas/webgl/bug-32364.html

  • fast/canvas/webgl/bug-32364-expected.txt: Added.
  • fast/canvas/webgl/bug-32364.html: Added.

2009-12-10 Kenneth Russell <​kbr@google.com>

Reviewed by Oliver Hunt.

[Chromium] SporeViewer demo doesn't work in Chromium
​https://bugs.webkit.org/show_bug.cgi?id=32364

Test: fast/canvas/webgl/bug-32364.html

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::CALLBACK_FUNC_DECL): (WebCore::vertexAttribAndUniformHelperf): (WebCore::uniformHelperi):
12:33 AM Changeset in webkit [51942] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-10 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Convert more commands to StepSequences
​https://bugs.webkit.org/show_bug.cgi?id=32362

We should eventually convert all the commands, but I'm starting with
the easy ones.

  • Scripts/modules/commands/download.py:
12:21 AM Changeset in webkit [51941] by xan@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-10 Xan Lopez <​xlopez@igalia.com>

Reviewed by Jan Alonzo.

[GTK] editing/selection/shrink-selection-after-shift-pagedown.html failing
​https://bugs.webkit.org/show_bug.cgi?id=31103

Give focus to the webviews when we create them, since some tests expect this.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (main):
12:18 AM Changeset in webkit [51940] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-10 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool "builders are red" error should tell you which builders
​https://bugs.webkit.org/show_bug.cgi?id=32211

  • Scripts/modules/buildsteps.py:

Dec 9, 2009:

11:47 PM Changeset in webkit [51939] by mjs@apple.com
  • 4 edits
    3 adds in trunk

2009-12-09 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver Hunt.

Google reader gets stuck in the "Loading..." state and does not complete
​https://bugs.webkit.org/show_bug.cgi?id=32256
<rdar://problem/7456388>

  • jit/JITArithmetic.cpp: (JSC::JIT::emitSlow_op_jless): Fix some backward branches.

2009-12-09 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver Hunt.

Test for: Google reader gets stuck in the "Loading..." state and does not complete
​https://bugs.webkit.org/show_bug.cgi?id=32256

  • fast/js/codegen-jless-expected.txt: Added.
  • fast/js/codegen-jless.html: Added.
  • fast/js/script-tests/codegen-jless.js: Added.
11:29 PM Changeset in webkit [51938] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed. Skip a timeouter flakey test.

  • platform/qt/Skipped: fast/frames/sandboxed-iframe-scripting.html added.
11:22 PM Changeset in webkit [51937] by yurys@chromium.org
  • 2 edits in trunk/WebKit/chromium

2009-12-09 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed, build fix.

Change forward declaration of WebContextMenuData from class to
struct to match its definition. The bug was introduced by
​http://trac.webkit.org/changeset/51874

  • src/ContextMenuClientImpl.h:
10:07 PM Changeset in webkit [51936] by Beth Dakin
  • 5 edits
    8 adds in trunk

WebCore: Fix for ​https://bugs.webkit.org/show_bug.cgi?id=32346 SVG property
-webkit-shadow should apply shadow on the result after compositing
-and corresponding-
<rdar://problem/7389404>

Reviewed by Oliver Hunt.

Set a transparency layer when setting a shadow to apply the shadow
to the composite.

  • rendering/SVGRenderSupport.cpp:

(WebCore::SVGRenderBase::prepareToRenderSVGContent):
(WebCore::SVGRenderBase::finishRenderSVGContent):

LayoutTests: Tests for ​https://bugs.webkit.org/show_bug.cgi?id=32346 SVG
property -webkit-shadow should apply shadow on the result after
compositing
-and corresponding-
<rdar://problem/7389404>

Reviewed by Oliver Hunt.

New tests:

  • platform/mac/svg/css/composite-shadow-example-expected.checksum: Added.
  • platform/mac/svg/css/composite-shadow-example-expected.png: Added.
  • platform/mac/svg/css/composite-shadow-example-expected.txt: Added.
  • platform/mac/svg/css/composite-shadow-with-opacity-expected.checksum: Added.
  • platform/mac/svg/css/composite-shadow-with-opacity-expected.png: Added.
  • platform/mac/svg/css/composite-shadow-with-opacity-expected.txt: Added.
  • svg/css/composite-shadow-example.html: Added.
  • svg/css/composite-shadow-with-opacity.html: Added.

New and improved results:

  • platform/mac/svg/css/group-with-shadow-expected.checksum:
  • platform/mac/svg/css/group-with-shadow-expected.png:
7:32 PM Changeset in webkit [51935] by ap@apple.com
  • 5 edits in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=32332
WebSocket events should be dispatched synchronously

Updated websocket/tests/simple to test for the new behavior.

When Web Sockets API says that events should be queued for async dispatch, it means something
different. We should keep this in mind when dealing with other HTML5-related specs.

The model for HTML5 is that code running in response to network events (e.g. WebSocket or
XMLHttpRequest algorithms) runs in a separate thread of execution, and thus needs to post
async events as its only way to communicate with client code. As long as network events are
queued themselves (as they are in WebKit), there is no need to queue JS events for async
dispatch.

  • websockets/WebSocket.cpp: (WebCore::WebSocket::didConnect): (WebCore::WebSocket::didReceiveMessage): (WebCore::WebSocket::didClose):
7:30 PM Changeset in webkit [51934] by ap@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Oliver Hunt.

​https://bugs.webkit.org/show_bug.cgi?id=32355
Assertion failure when opening a WebSocket connection

I couldn't make a reliable test for this. Once the test from bug 32299 is landed, it
will provide partial coverage, as I was frequently seeing the assertion failure with it.

  • platform/network/SocketStreamHandleBase.cpp: (WebCore::SocketStreamHandleBase::send): It's not an error if zero if returned from platformSend() - it just means that nothing could be pushed down to the network layer, and all data was queued for later.
  • platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::readStreamCallback): This will no longer happen with SocketStream, but a client can potentially destroy the handle from any callback, so we need to check that this didn't happen. (WebCore::SocketStreamHandle::writeStreamCallback): Ditto.
5:44 PM Changeset in webkit [51933] by barraclough@apple.com
  • 6 edits in trunk

JavaScriptCore: ​https://bugs.webkit.org/show_bug.cgi?id=32228
Make destruction of ropes non-recursive to prevent stack exhaustion.
Also, pass a UString& into initializeFiber rather than a Ustring::Rep*,
since the Rep is not being ref counted this could result in usage of a
Rep with refcount zero (where the Rep comes from a temporary UString
returned from a function).

Reviewed by Oliver Hunt.

  • runtime/JSString.cpp:

(JSC::JSString::Rope::destructNonRecursive):
(JSC::JSString::Rope::~Rope):

  • runtime/JSString.h:

(JSC::JSString::Rope::initializeFiber):

  • runtime/Operations.h:

(JSC::concatenateStrings):

LayoutTests: ​https://bugs.webkit.org/show_bug.cgi?id=32228
Reenabling tests.

Reviewed by Oliver Hunt.

  • platform/win/Skipped:
4:58 PM Changeset in webkit [51932] by eric@webkit.org
  • 5 edits in trunk

2009-12-09 Marwan Al Jubeh <​marwan.aljubeh@gmail.com>

Reviewed by Adam Roben.

Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=31228
Set the WebKitOutputDir, WebKitLibrariesDir and Cygwin environment variables automatically
in Windows as part of running update_webkit.

  • building/build.html:
    • removed the reference to forgetting to set environment variables as a common source of errors on Windows. This is because this patch would make it unnecessary for the user to set these variables manually.

2009-12-09 Marwan Al Jubeh <​marwan.aljubeh@gmail.com>

Reviewed by Adam Roben.

Fixes: ​https://bugs.webkit.org/show_bug.cgi?id=31228
Set the WebKitOutputDir, WebKitLibrariesDir and Cygwin environment variables automatically
in Windows as part of running update_webkit.

  • Scripts/update-webkit:
    • Run setupAppleWinEnv() on Apple's Windows port.
  • Scripts/webkitdirs.pm:
    • Added functions that return the source directory, libraries directory and default build directory on Windows.
    • Added isWindowsNT() which tests if the current Windows version is from the Windows NT family.
    • Implemented setupAppleWinEnv() which sets the environment variables WebKitOutputDir, WebKitLibrariesDir and Cygwin to their desired values.
4:23 PM Changeset in webkit [51931] by weinig@apple.com
  • 3 edits in trunk/WebCore

Roll out 51919 and 51920. They were incorrect and unnecessary right now.

  • platform/mac/WebCoreObjCExtras.mm:

(WebCoreObjCScheduleDeallocateOnMainThread):

  • platform/network/mac/NetworkStateNotifierMac.cpp:

(WebCore::NetworkStateNotifier::NetworkStateNotifier):

3:32 PM Changeset in webkit [51930] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-09 Steve Block <​steveblock@google.com>

Reviewed by Darin Fisher.

Adds wtf/StdLibExtras.h include for DEFINE_STATIC_LOCAL in V8 ScriptState.
​https://bugs.webkit.org/show_bug.cgi?id=32330

Build fix only, no new tests.

  • bindings/v8/ScriptState.cpp: Modified. Adds wtf/StdLibExtras.h include.
3:08 PM Changeset in webkit [51929] by eric@webkit.org
  • 2 edits in trunk/WebKitSite

2009-12-09 Chris Jerdonek <​chris.jerdonek@gmail.com>

Reviewed by Darin Adler.

Added the "using std::foo" rule to the coding style guidelines.

​https://bugs.webkit.org/show_bug.cgi?id=32301

Added to the coding style guidelines the "using std::foo" rule
checked by the check-webkit-style script. Also clarified the
"using" statement guidelines that apply to implementation files.

  • coding/coding-style.html:
3:01 PM Changeset in webkit [51928] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2009-12-09 Zoltan Herczeg <​zherczeg@inf.u-szeged.hu>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=31930

Update to r51457. ASSERTs changed to COMPILE_ASSERTs.
The speedup is 25%.

  • runtime/JSGlobalData.cpp: (JSC::VPtrSet::VPtrSet):
2:54 PM Changeset in webkit [51927] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-12-09 Steve Block <​steveblock@google.com>

Reviewed by Darin Adler.

Adds ENABLE(INSPECTOR) guards around script binding methods that use types
defined only when INSPECTOR is enabled.
​https://bugs.webkit.org/show_bug.cgi?id=32328

Build fix only, no new tests.

  • bindings/js/ScriptValue.cpp: Modified. Added ENABLE(INSPECTOR) guard to ScriptValue::quarantineValue.
  • bindings/v8/ScriptObject.cpp: Modified. Added ENABLE(INSPECTOR) guard to some overloads of ScriptGlobalObject::set.
2:47 PM Changeset in webkit [51926] by eric@webkit.org
  • 10 edits
    2 adds in trunk

2009-12-09 Steve Block <​steveblock@google.com>

Reviewed by Adam Barth.

Adds Android Makefiles for building with V8.
​https://bugs.webkit.org/show_bug.cgi?id=32278

  • Android.mk: Modified. Includes Makefiles for V8.

2009-12-09 Steve Block <​steveblock@google.com>

Reviewed by Adam Barth.

Updates Android Makefiles with latest additions.
​https://bugs.webkit.org/show_bug.cgi?id=32278

  • Android.mk: Modified.
  • Android.v8.wtf.mk: Modified.

2009-12-09 Steve Block <​steveblock@google.com>

Reviewed by Adam Barth.

Adds Android Makefiles for building with V8.
Also updates existing Android Makefiles with latest additions.
​https://bugs.webkit.org/show_bug.cgi?id=32278

Build fix only, no new tests.

  • Android.derived.jscbindings.mk: Modified.
  • Android.derived.mk: Modified.
  • Android.derived.v8bindings.mk: Added.
  • Android.jscbindings.mk: Modified.
  • Android.mk: Modified.
  • Android.v8bindings.mk: Added.
2:35 PM Changeset in webkit [51925] by steveblock@google.com
  • 2 edits in trunk/WebCore

Bug 32338 - [Chromium] Fix Chromium builder by including missing GeolocationServiceChromium
​https://bugs.webkit.org/show_bug.cgi?id=32338

Patch by Jonathan Dixon <​joth@chromium.org> on 2009-12-09
Reviewed by Dimitri Glazkov.

Fix build break: re-include file dropped out by merge in ​http://trac.webkit.org/changeset/51681/trunk/WebCore/WebCore.gypi

  • WebCore.gypi: Add missing GeolocationServiceChromium.cpp
2:32 PM Changeset in webkit [51924] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-09 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Brady Eidson.

Fixed a typo in ​http://trac.webkit.org/changeset/51644 that broke
the QWebPage autotest.

No new test required.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::navigateToDifferentDocument):
2:25 PM Changeset in webkit [51923] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

exception thrown when running apply-patches
​https://bugs.webkit.org/show_bug.cgi?id=32344

The update step now takes a port option. Once we finish the Steps
refactoring, we won't have to worry about this kind of bug again.

  • Scripts/modules/commands/download.py:
2:18 PM Changeset in webkit [51922] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-09 Robert Hogan <​robert@roberthogan.net>

Reviewed by Eric Seidel.

Exclude JSSVG*.cpp generated files from --minimal and --no-svg builds.

​https://bugs.webkit.org/show_bug.cgi?id=32286

  • WebCore.pro:
2:11 PM Changeset in webkit [51921] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-09 Philippe Normand <​pnormand@igalia.com>

Reviewed by Eric Carlson.

Ogg mimetypes are incorrect
​https://bugs.webkit.org/show_bug.cgi?id=27113

The ogg extension is handled by audio/ogg instead of
application/ogg. See
​http://wiki.xiph.org/MIME_Types_and_File_Extensions

  • platform/MIMETypeRegistry.cpp: (WebCore::TypeExtensionPair::):
1:57 PM Changeset in webkit [51920] by weinig@apple.com
  • 2 edits in trunk/WebCore

Use the current run loop instead of the main runloop for the NetworkStateNotifier.

Reviewed by Anders Carlsson.

  • platform/network/mac/NetworkStateNotifierMac.cpp:

(WebCore::NetworkStateNotifier::NetworkStateNotifier):

1:55 PM Changeset in webkit [51919] by weinig@apple.com
  • 2 edits in trunk/WebCore

Use isMainThread() helper instead of pthread_main_np() != 0.

Reviewed by Anders Carlsson.

  • platform/mac/WebCoreObjCExtras.mm:

(WebCoreObjCScheduleDeallocateOnMainThread):

1:37 PM Changeset in webkit [51918] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Skip a failing test that needs DRT support to override standard
preferences.

  • platform/gtk/Skipped:
1:36 PM Changeset in webkit [51917] by darin@chromium.org
  • 5 edits in trunk/WebKit/chromium

2009-12-09 Darin Fisher <​darin@chromium.org>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=32324
[Chromium] Suppress WebFrameClient callbacks from a detached frame.

This change means that we no longer need the ClientHandle class.
FrameLoaderClient::detachedFromParent3() is called on each frame
in the frame tree from within frameDetached().

Test: http/tests/loading/gmail-assert-on-load.html

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::detachedFromParent3):
  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::create): (WebKit::WebFrameImpl::WebFrameImpl): (WebKit::WebFrameImpl::createChildFrame):
  • src/WebFrameImpl.h: (WebKit::WebFrameImpl::client): (WebKit::WebFrameImpl::dropClient):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::close):
1:31 PM Changeset in webkit [51916] by weinig@apple.com
  • 11 edits in trunk/WebCore

Add some #ifdefs to allow us to experiment with a single NSView mac WebKit.

Reviewed by Anders Carlsson.

  • page/Chrome.h:
  • page/EventHandler.h:
  • page/mac/ChromeMac.mm:
  • page/mac/DragControllerMac.mm:

(WebCore::DragController::dragOperation):

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::eventLoopHandleMouseDragged):
(WebCore::EventHandler::eventActivatedView):
(WebCore::EventHandler::passMousePressEventToSubframe):
(WebCore::EventHandler::passMouseMoveEventToSubframe):
(WebCore::EventHandler::passMouseReleaseEventToSubframe):
(WebCore::EventHandler::passWheelEventToWidget):
(WebCore::EventHandler::focusDocumentView):
(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
(WebCore::EventHandler::createDraggingClipboard):
(WebCore::isKeyboardOptionTab):
(WebCore::EventHandler::invertSenseOfTabsToLinks):
(WebCore::EventHandler::tabsToAllControls):
(WebCore::EventHandler::needsKeyboardEventDisambiguationQuirks):
(WebCore::EventHandler::accessKeyModifiers):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

  • platform/Widget.cpp:
  • platform/Widget.h:
  • platform/mac/ScrollViewMac.mm:
  • platform/mac/WidgetMac.mm:

(WebCore::Widget::Widget):
(WebCore::Widget::~Widget):
(WebCore::Widget::show):
(WebCore::Widget::hide):
(WebCore::Widget::setCursor):
(WebCore::Widget::paint):
(WebCore::Widget::setFocus):
(WebCore::Widget::setIsSelected):
(WebCore::Widget::frameRect):
(WebCore::Widget::setFrameRect):

12:36 PM Changeset in webkit [51915] by eric@webkit.org
  • 4 edits in trunk/WebCore

2009-12-09 Michael Nordman <Michael Nordman>

Reviewed by Dimitri Glazkov.

Chromium build fix.

No new tests.

  • bindings/v8/DOMData.cpp
  • bindings/v8/V8DOMWrapper.cpp
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::vertexAttribAndUniformHelperf): (WebCore::uniformHelperi): (WebCore::uniformMatrixHelper):
12:31 PM Changeset in webkit [51914] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix a bug found while trying to compile JavaScriptCore with clang++.

Reviewed by Gavin Barraclough.

  • yarr/RegexPattern.h:

(JSC::Yarr::PatternTerm::PatternTerm): Don't self assign here. Use false instead.

12:26 PM Changeset in webkit [51913] by bfulgham@webkit.org
  • 2 edits in trunk/WebKit/win

Revert incorrect commit-box update r51911.
It mistakenly set the selectAll implementation in the
deslectAll method.

  • WebFrame.cpp:

(WebFrame::deselectAll):

12:14 PM Changeset in webkit [51912] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-09 Søren Gjesse <​sgjesse@chromium.org>

Reviewed by Pavel Feldman.

[V8] Isolated world reuse failure
​https://bugs.webkit.org/show_bug.cgi?id=32306

Fixed bug introduced in r51407: (​http://trac.webkit.org/changeset/51407) which caused layout test
LayoutTests/http/tests/security/isolatedWorld/world-reuse.html to fail.

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setInjectedScriptContextDebugId): (WebCore::V8Proxy::contextDebugId):
12:06 PM Changeset in webkit [51911] by eric@webkit.org
  • 2 edits in trunk/WebKit/win

2009-12-09 Brent Fulgham <​bfulgham@webkit.org>

Reviewed by Darin Adler.

Provide an implementation for 'selectAll'
​https://bugs.webkit.org/show_bug.cgi?id=32296

  • WebFrame.cpp: (WebFrame::selectAll): Implement "SelectAll" command.
11:59 AM Changeset in webkit [51910] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-09 Patrick Scott <​phanna@email.unc.edu>

Fix the build with ENABLE_ORIENTATION_EVENTS
​https://bugs.webkit.org/show_bug.cgi?id=32321

  • page/Frame.cpp: (WebCore::Frame::sendOrientationChangeEvent):
11:52 AM Changeset in webkit [51909] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-09 Avi Drissman <​avi@chromium.org>

Reviewed by Darin Fisher.

Chromium tickmarks in scrollbar now UX approved.
​https://bugs.webkit.org/show_bug.cgi?id=32069

  • platform/chromium/ScrollbarThemeChromiumMac.mm: (WebCore::ScrollbarThemeChromiumMac::paint):
11:00 AM Changeset in webkit [51908] by andersca@apple.com
  • 2 edits in trunk/JavaScriptCore

Attempt to fix the Windows build.

Reviewed by Sam Weinig.

  • wtf/FastMalloc.h:
10:53 AM Changeset in webkit [51907] by bfulgham@webkit.org
  • 2 edits in trunk/WebKit/win

Provide an implementation for 'selectAll'
​https://bugs.webkit.org/show_bug.cgi?id=32296

Reviewed by Darin Adler.

  • WebFrame.cpp:

(WebFrame::selectAll): Implement "SelectAll" command.

10:44 AM Changeset in webkit [51906] by cmarrin@apple.com
  • 9 edits in trunk

Delay load DLLs for accelerated compositing
​https://bugs.webkit.org/show_bug.cgi?id=31856


Add logic to turn off accelerated compositing if d3d9 or QuartzCore
DLLs are not present.

10:40 AM Changeset in webkit [51905] by andersca@apple.com
  • 4 edits in trunk/JavaScriptCore

Fix some things found while trying to compile JavaScriptCore with clang++.

Reviewed by Sam Weinig.

  • wtf/FastMalloc.h:

Add correct exception specifications for the allocation/deallocation operators.

  • wtf/Vector.h:
  • wtf/VectorTraits.h:

Fix a bunch of struct/class mismatches.

10:22 AM Changeset in webkit [51904] by darin@chromium.org
  • 2 edits in trunk/WebKit/chromium

2009-12-08 Stuart Morgan <​stuartmorgan@chromium.org>

Reviewed by Darin Fisher.

Include clickCount when doing MouseEvent -> WebMouseEvent conversion
in Chromium API.

​https://bugs.webkit.org/show_bug.cgi?id=32289

  • src/WebInputEventConversion.cpp: (WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
10:11 AM Changeset in webkit [51903] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2009-12-09 Adam Barth <​abarth@webkit.org>

Unreviewed. Fix ScriptError includes. I don't understand why these
didn't throw during unit testing...

  • Scripts/modules/commands/download.py:
  • Scripts/modules/logging_unittest.py:
  • Scripts/modules/workqueue.py:
9:43 AM Changeset in webkit [51902] by Nate Chapin
  • 13 edits
    2 moves in trunk/WebCore

2009-12-09 Nate Chapin <Nate Chapin>

Reviewed by Darin Adler.

Rename dom/ClassNames to SpaceSplitString and update build files.

​https://bugs.webkit.org/show_bug.cgi?id=32250

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRules):
  • dom/ClassNames.cpp: Removed.
  • dom/ClassNames.h: Removed.
  • dom/ClassNodeList.h:
  • dom/NamedMappedAttrMap.h: (WebCore::NamedMappedAttrMap::classNames):
  • dom/SpaceSplitString.cpp: Copied from WebCore/dom/ClassNames.cpp. (WebCore::SpaceSplitStringData::createVector): (WebCore::SpaceSplitStringData::containsAll):
  • dom/SpaceSplitString.h: Copied from WebCore/dom/ClassNames.h. (WebCore::SpaceSplitStringData::SpaceSplitStringData): (WebCore::SpaceSplitString::SpaceSplitString): (WebCore::SpaceSplitString::set): (WebCore::SpaceSplitString::containsAll):
  • dom/StyledElement.h: (WebCore::StyledElement::classNames):
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::setRel):
9:28 AM Changeset in webkit [51901] by senorblanco@chromium.org
  • 8 edits in trunk/WebCore

Enable SVG filters in Chromium build.
​https://bugs.webkit.org/show_bug.cgi?id=32323

Reviewed by Darin Fisher.

Covered by SVG filter layout tests.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/DerivedSourcesAllInOne.cpp:
  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
8:59 AM QtWebKit/CodeCamp200912 edited by zecke@selfish.org
mention the performance talks (diff)
8:50 AM bbandix_drt_tools.pdf attached to QtWebKit/CodeCamp200912 by abecsi@inf.u-szeged.hu
7:26 AM Changeset in webkit [51900] by yurys@chromium.org
  • 2 edits in trunk/WebKit/chromium

2009-12-09 Yury Semikhatsky <​yurys@chromium.org>

Unreviewed, build fix.

Add return statement to default implementation of hostIdentifier method
introduced in ​http://trac.webkit.org/changeset/51897

  • public/WebDevToolsAgentClient.h: (WebKit::WebDevToolsAgentClient::hostIdentifier):
7:05 AM Changeset in webkit [51899] by yurys@chromium.org
  • 3 edits in trunk/WebKit/chromium

2009-12-09 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Add declaration of static methods that allow to dispatch
DevTools messages on the IO thread and accept WebDevToolsMessageData
argument.

​https://bugs.webkit.org/show_bug.cgi?id=32314

  • public/WebDevToolsAgent.h:
  • public/WebDevToolsAgentClient.h:
6:49 AM WkMem.pdf attached to QtWebKit/CodeCamp200912 by zherczeg@inf.u-szeged.hu
Meamory measurement using freya (valgrind)
5:27 AM Changeset in webkit [51898] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Skip a failing test introduced in r51877.

  • platform/qt/Skipped: fast/loader/input-element-page-cache-crash.html added.
5:19 AM Changeset in webkit [51897] by yurys@chromium.org
  • 6 edits
    1 copy in trunk/WebKit/chromium

2009-12-09 Yury Semikhatsky <​yurys@chromium.org>

Reviewed by Pavel Feldman.

Introduce a class for devtools message data

​https://bugs.webkit.org/show_bug.cgi?id=32314

  • WebKit.gyp:
  • public/WebDevToolsAgent.h:
  • public/WebDevToolsAgentClient.h: (WebKit::WebDevToolsAgentClient::sendMessageToFrontend): (WebKit::WebDevToolsAgentClient::forceRepaint): (WebKit::WebDevToolsAgentClient::hostIdentifier): (WebKit::WebDevToolsAgentClient::runtimeFeatureStateChanged):
  • public/WebDevToolsFrontend.h:
  • public/WebDevToolsFrontendClient.h: (WebKit::WebDevToolsFrontendClient::sendMessageToAgent):
  • public/WebDevToolsMessageData.h: Added.
5:15 AM ARM-JIT.pdf attached to QtWebKit/CodeCamp200912 by zherczeg@inf.u-szeged.hu
ARM-JIT in nutshell
5:04 AM Changeset in webkit [51896] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2009-12-09 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Fix typo in the Skipped list s/.htm/.html/ in the last test I added.

  • platform/mac-snowleopard/Skipped:
3:34 AM QtWebKit/CodeCamp200912 edited by vestbo@webkit.org
(diff)
2:09 AM QtWebKit/CodeCamp200912 edited by akiss@inf.u-szeged.hu
(diff)
2:05 AM akiss-uszintro.pdf attached to QtWebKit/CodeCamp200912 by akiss@inf.u-szeged.hu
Intro to #u-szeged
1:54 AM WebKit Team edited by xan@webkit.org
(diff)
1:39 AM Changeset in webkit [51895] by abarth@webkit.org
  • 4 edits
    1 delete in trunk/WebKitTools

2009-12-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Remove unused PatchCollection class
​https://bugs.webkit.org/show_bug.cgi?id=32312

It's dead code.

  • Scripts/modules/patchcollection.py:
  • Scripts/modules/patchcollection_unittest.py: Removed.
1:29 AM Changeset in webkit [51894] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-09 Adam Barth <​abarth@webkit.org>

Unreviewed "build" fix. CheckStyle needs a --no-upate option.

  • Scripts/modules/commands/download.py:
1:24 AM Changeset in webkit [51893] by abarth@webkit.org
  • 4 edits
    1 add in trunk/WebKitTools

2009-12-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Convert Build to use Sequence
​https://bugs.webkit.org/show_bug.cgi?id=32310

So much prettier.

  • Scripts/modules/buildsteps.py:
  • Scripts/modules/commands/download.py:
  • Scripts/modules/landingsequence.py:
  • Scripts/modules/stepsequence.py: Added.
1:17 AM Changeset in webkit [51892] by oliver@apple.com
  • 3 edits in trunk/WebCore

Build fix

12:26 AM Changeset in webkit [51891] by abarth@webkit.org
  • 1 edit
    1 add in trunk/WebKitTools

2009-12-09 Adam Barth <​abarth@webkit.org>

Add missing file.

  • Scripts/modules/executive.py: Added.
12:24 AM Changeset in webkit [51890] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-09 Adam Barth <​abarth@webkit.org>

Unreviewed "build" fix.

  • Scripts/modules/landingsequence.py:
12:20 AM Changeset in webkit [51889] by abarth@webkit.org
  • 12 edits
    1 delete in trunk/WebKitTools

2009-12-09 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Implement abstract Steps
​https://bugs.webkit.org/show_bug.cgi?id=32212

This is a fairly disruptive change that refactors how we build
commands. Instead of using a landing sequence, we can now assemble a
sequence of steps directly. We still use the landing sequence in the
interim, but this will be removed soon.

  • Scripts/bugzilla-tool:
  • Scripts/modules/buildsteps.py:
  • Scripts/modules/commands/download.py:
  • Scripts/modules/commands/early_warning_system.py:
  • Scripts/modules/commands/queues.py:
  • Scripts/modules/commands/queues_unittest.py:
  • Scripts/modules/landingsequence.py:
  • Scripts/modules/mock_bugzillatool.py:
  • Scripts/modules/processutils.py: Removed.
  • Scripts/modules/scm.py:
  • Scripts/modules/scm_unittest.py:
  • Scripts/modules/webkitport.py:

Dec 8, 2009:

11:51 PM Changeset in webkit [51888] by eric@webkit.org
  • 11 edits in trunk/WebKitTools

2009-12-08 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

run_command and ScriptError should move into processutils.py
​https://bugs.webkit.org/show_bug.cgi?id=32305

Turns out there are a zillion callers to run_command.

  • Scripts/modules/commands/download.py:
  • Scripts/modules/commands/early_warning_system.py:
  • Scripts/modules/commands/queues.py:
  • Scripts/modules/landingsequence.py:
  • Scripts/modules/logging_unittest.py:
  • Scripts/modules/processutils.py:
  • Scripts/modules/scm.py:
  • Scripts/modules/scm_unittest.py:
  • Scripts/modules/workqueue.py:
  • Scripts/modules/workqueue_unittest.py:
7:43 PM Changeset in webkit [51887] by mjs@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Remove stray conflict marker.

7:39 PM Changeset in webkit [51886] by ukai@chromium.org
  • 7 edits
    3 adds in trunk

2009-12-08 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Darin Adler.

WebSocket allow space (U+0020) in sub protocol name.
​https://bugs.webkit.org/show_bug.cgi?id=32266

Skipped sub-protocol-with-space.html for now until new pywebsocket is
landed.

  • websocket/tests/bad-sub-protocol-expected.txt:
  • websocket/tests/script-tests/bad-sub-protocol.js:
  • websocket/tests/script-tests/sub-protocol-with-space.js: Added.
  • websocket/tests/sub-protocol-with-space-expected.txt: Added.
  • websocket/tests/sub-protocol-with-space.html: Added.

2009-12-08 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Darin Adler.

WebSocket allow space (U+0020) in sub protocol name.
​https://bugs.webkit.org/show_bug.cgi?id=32266

Test: websocket/tests/sub-protocol-with-space.html

  • websockets/WebSocket.cpp: (WebCore::isValidProtocolString):
7:20 PM Changeset in webkit [51885] by ukai@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

2009-12-08 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Darin Adler.

Add tests that WebSocket-Protocol: is ignored if protocol was not specified.
​https://bugs.webkit.org/show_bug.cgi?id=32267

  • websocket/tests/script-tests/websocket-protocol-ignored.js: Added.
  • websocket/tests/websocket-protocol-ignored-expected.txt: Added.
  • websocket/tests/websocket-protocol-ignored.html: Added.
6:38 PM Changeset in webkit [51884] by eric@webkit.org
  • 14 edits
    7 adds in trunk

2009-12-08 Peterson Trethewey <​petersont@google.com>

Reviewed by Oliver Hunt.

Implement WebGLUniformLocation and change API to use it.
​https://bugs.webkit.org/show_bug.cgi?id=31173

  • fast/canvas/webgl/resources/structUniformShader.vert: Added.
  • fast/canvas/webgl/script-tests/uniform-location.js: Added.
  • fast/canvas/webgl/uniform-location-expected.txt: Added.
  • fast/canvas/webgl/uniform-location.html: Added.

2009-12-08 Peterson Trethewey <​petersont@google.com>

Reviewed by Oliver Hunt.

Implement WebGLUniformLocation and change API to use it.
​https://bugs.webkit.org/show_bug.cgi?id=31173

Test: fast/canvas/webgl/uniform-location.html

  • DerivedSources.make:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::JSWebGLRenderingContext::getProgramParameter): (WebCore::JSWebGLRenderingContext::getUniform): (WebCore::functionForUniform): (WebCore::dataFunctionf): (WebCore::dataFunctioni): (WebCore::dataFunctionMatrix):
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/DerivedSourcesAllInOne.cpp:
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::toWebGLUniformLocation): (WebCore::): (WebCore::CALLBACK_FUNC_DECL): (WebCore::isFunctionToCallForAttribute): (WebCore::vertexAttribAndUniformHelperf): (WebCore::uniformHelperi): (WebCore::uniformMatrixHelper):
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getUniform): (WebCore::WebGLRenderingContext::getUniformLocation): (WebCore::WebGLRenderingContext::uniform1f): (WebCore::WebGLRenderingContext::uniform1fv): (WebCore::WebGLRenderingContext::uniform1i): (WebCore::WebGLRenderingContext::uniform1iv): (WebCore::WebGLRenderingContext::uniform2f): (WebCore::WebGLRenderingContext::uniform2fv): (WebCore::WebGLRenderingContext::uniform2i): (WebCore::WebGLRenderingContext::uniform2iv): (WebCore::WebGLRenderingContext::uniform3f): (WebCore::WebGLRenderingContext::uniform3fv): (WebCore::WebGLRenderingContext::uniform3i): (WebCore::WebGLRenderingContext::uniform3iv): (WebCore::WebGLRenderingContext::uniform4f): (WebCore::WebGLRenderingContext::uniform4fv): (WebCore::WebGLRenderingContext::uniform4i): (WebCore::WebGLRenderingContext::uniform4iv): (WebCore::WebGLRenderingContext::uniformMatrix2fv): (WebCore::WebGLRenderingContext::uniformMatrix3fv): (WebCore::WebGLRenderingContext::uniformMatrix4fv):
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLRenderingContext.idl:
  • html/canvas/WebGLUniformLocation.cpp: Added. (WebCore::WebGLUniformLocation::create): (WebCore::WebGLUniformLocation::WebGLUniformLocation):
  • html/canvas/WebGLUniformLocation.h: Added. (WebCore::WebGLUniformLocation::~WebGLUniformLocation): (WebCore::WebGLUniformLocation::program): (WebCore::WebGLUniformLocation::location):
  • html/canvas/WebGLUniformLocation.idl: Added.
5:43 PM Changeset in webkit [51883] by agl@chromium.org
  • 3 edits
    2 adds in trunk

2009-12-08 Adam Langley <​agl@google.com>

Reviewed by Darin Adler.

Fix assertion failure in WebCore::RenderBlock::startDelayUpdateScrollInfo

startDelayUpdateScrollInfo calls a function that can end up calling
startDelayUpdateScrollInfo again. However, it's static state is
inconsistent when this happens leading to an assertion failure (or
probably a memory leak if assertions are off).

Thanks to Robert Swiecki for the test case.

​https://bugs.webkit.org/show_bug.cgi?id=32172
​http://code.google.com/p/chromium/issues/detail?id=28880

Test: fast/css/recursive-delay-update-scroll.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::finishDelayUpdateScrollInfo):

2009-12-08 Adam Langley <​agl@google.com>

Reviewed by Darin Adler.

Fix assertion failure in WebCore::RenderBlock::startDelayUpdateScrollInfo

startDelayUpdateScrollInfo calls a function that can end up calling
startDelayUpdateScrollInfo again. However, it's static state is
inconsistent when this happens leading to an assertion failure (or
probably a memory leak if assertions are off).

Thanks to Robert Swiecki for the test case.

​https://bugs.webkit.org/show_bug.cgi?id=32172
​http://code.google.com/p/chromium/issues/detail?id=28880

  • fast/css/recursive-delay-update-scroll.html: Added.
  • fast/css/recursive-delay-update-scroll-expected.txt: Added.
5:29 PM Changeset in webkit [51882] by mjs@apple.com
  • 9 edits
    1 copy in trunk/JavaScriptCore

move code generation portions of Nodes.cpp to bytecompiler directory
​https://bugs.webkit.org/show_bug.cgi?id=32284

Reviewed by Darin Adler.

  • bytecompiler/NodesCodegen.cpp: Copied from parser/Nodes.cpp. Removed parts that

are not about codegen.

  • parser/Nodes.cpp: Removed everything that is about codegen.

Update build systems:

4:59 PM Changeset in webkit [51881] by sfalken@apple.com
  • 2 edits in trunk/WebCore

WebCore source level debugging on Windows not reliable in some cases
​https://bugs.webkit.org/show_bug.cgi?id=32297

Reviewed by Adam Roben.

Customized pdb file name/location for WebCore static library.

  • WebCore.vcproj/WebCoreCommon.vsprops: Add ProgramDataBaseFileName.
4:52 PM Changeset in webkit [51880] by kevino@webkit.org
  • 14 edits
    1 add in trunk

Reviewed by Kevin Ollivier.

[wx] Mac plugins support.

​https://bugs.webkit.org/show_bug.cgi?id=32236

4:40 PM Changeset in webkit [51879] by Simon Fraser
  • 2 edits in trunk/WebKit/mac

2009-12-08 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

<rdar://problem/7295070> WebKit video fullscreen keeps playing after closing the window

Fix a leak of the QTMovieView when exiting fullscreen video, and remove the
old workaround.

  • WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController windowDidLoad]): Set the movie view as the contentView directly. (-[WebVideoFullscreenController setMediaElement:WebCore::]): Cast the contentView to a movie view. (-[WebVideoFullscreenController windowDidExitFullscreen]): Remove the old workaround.
4:14 PM Changeset in webkit [51878] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2009-12-08 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Skip another failing media test, that I already mentioned in the bug report.

  • platform/mac-snowleopard/Skipped:
4:08 PM Changeset in webkit [51877] by beidson@apple.com
  • 3 edits
    2 adds in trunk

Navigating to a cached page can result in accessing a destroyed HTMLInputElement.
<rdar://problem/6856662> and ​https://webkit.org/b/32293

Reviewed by Darin Adler.

WebCore:

Test: fast/loader/input-element-page-cache-crash.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseMappedAttribute): Make sure to unregister for the activation

callback after the new m_autocomplete setting has been stored so the unregistration actually
takes place.

LayoutTests:

  • fast/loader/input-element-page-cache-crash-expected.txt: Added.
  • fast/loader/input-element-page-cache-crash.html: Added.
3:54 PM Changeset in webkit [51876] by levin@chromium.org
  • 3 edits in trunk/WebKitTools

[check-webkit-style] False positive for DEFINE_OPCODE(op_jtrue) {
​https://bugs.webkit.org/show_bug.cgi?id=32193

Reviewed by Adam Barth.

  • Scripts/modules/cpp_style.py: For the function { rule, if there is space at the beginning of line, ignore lines which then have a macro.
  • Scripts/modules/cpp_style_unittest.py: Add tests to verify the new behavior.
3:27 PM Changeset in webkit [51875] by dimich@chromium.org
  • 14 edits
    5 deletes in trunk

Revert and reopen "Add asserts to RefCounted to make sure ref/deref happens on the right thread."
It may have caused massive increase of reported leaks on the bots.
​https://bugs.webkit.org/show_bug.cgi?id=31639

Rubber-stamped by David Levin.

JavaScriptCore:

(JSC::Structure::Structure):

  • wtf/RefCounted.h:

(WTF::RefCountedBase::ref):
(WTF::RefCountedBase::hasOneRef):
(WTF::RefCountedBase::refCount):
(WTF::RefCountedBase::derefBase):

  • wtf/ThreadVerifier.h: Removed.

JavaScriptGlue:

  • ForwardingHeaders/wtf/ThreadVerifier.h: Removed.

WebCore:

  • ForwardingHeaders/wtf/ThreadVerifier.h: Removed.
  • loader/icon/IconRecord.cpp:

(WebCore::IconRecord::IconRecord):

  • platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::SharedBuffer):

  • platform/text/StringImpl.cpp:

(WebCore::StringImpl::StringImpl):

WebKit/mac:

  • ForwardingHeaders/wtf/ThreadVerifier.h: Removed.

WebKitTools:

  • DumpRenderTree/ForwardingHeaders/wtf/ThreadVerifier.h: Removed.
2:45 PM WebInspector edited by timothy@apple.com
(diff)
2:43 PM Changeset in webkit [51874] by pfeldman@chromium.org
  • 14 edits
    1 copy in trunk

2009-12-08 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Darin Fisher.

Chromium: support custom WebCore context menu items in Chromium port.

​https://bugs.webkit.org/show_bug.cgi?id=32277

WebCore:

  • platform/ContextMenu.h:
  • platform/ContextMenuItem.h: (WebCore::PlatformMenuItemDescription::PlatformMenuItemDescription):
  • platform/chromium/ContextMenuChromium.cpp: (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::itemCount): (WebCore::ContextMenu::insertItem): (WebCore::ContextMenu::appendItem): (WebCore::ContextMenu::itemWithAction): (WebCore::ContextMenu::itemAtIndex): (WebCore::ContextMenu::platformDescription):
  • platform/chromium/ContextMenuItemChromium.cpp: (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::releasePlatformDescription): (WebCore::ContextMenuItem::type): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::title): (WebCore::ContextMenuItem::checked): (WebCore::ContextMenuItem::enabled): (WebCore::ContextMenuItem::setType): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::setTitle): (WebCore::ContextMenuItem::setChecked): (WebCore::ContextMenuItem::setEnabled):

WebKit/chromium:

  • public/WebContextMenuData.h:
  • public/WebPopupMenuInfo.h: (WebKit::WebPopupMenuInfo::Item::):
  • public/WebView.h:
  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::executeCustomContextMenuAction):
  • src/WebViewImpl.h:
2:42 PM Changeset in webkit [51873] by Nikolas Zimmermann
  • 3 edits in trunk/LayoutTests

2009-12-08 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Skip fast/repaint/block-selection-gap-in-table-cell.html (generates new result) to turn Qt/Gtk builds green again.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
1:58 PM Changeset in webkit [51872] by agl@chromium.org
  • 2 edits in trunk/WebCore

2009-12-08 Adam Langley <​agl@google.com>

Reviewed by Dimitri Glazkov.

Chromium Linux: set default scrollbar colours.

This is so that layout tests have sane defaults for the scrollbar
colours, even if the API user doesn't set any.

This is a fix due to r51827.

​https://bugs.webkit.org/show_bug.cgi?id=32287

This is very well covered by existing layout tests.

  • rendering/RenderThemeChromiumLinux.cpp:
1:35 PM Changeset in webkit [51871] by kov@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

Make WebKit build correctly on FreeBSD, IA64, and Alpha.
Based on work by Petr Salinger <​Petr.Salinger@seznam.cz>,
and Colin Watson <​cjwatson@ubuntu.com>.

  • wtf/Platform.h:
1:14 PM Changeset in webkit [51870] by Beth Dakin
  • 2 edits in trunk/WebCore

Fix for <rdar://problem/7397808> Crash occurs at
RenderObject::containingBlock() as I type in the Google Search
field (during page load)

Reviewed by Sam Weinig.

  • editing/Editor.cpp:

(WebCore::Editor::insideVisibleArea): ownerRenderer() needs to be
null checked.

12:25 PM Changeset in webkit [51869] by dimich@chromium.org
  • 14 edits
    5 adds in trunk

Add asserts to RefCounted to make sure ref/deref happens on the right thread.
​https://bugs.webkit.org/show_bug.cgi?id=31639

Reviewed by Darin Adler.

JavaScriptCore:

  • runtime/Structure.cpp:

(JSC::Structure::Structure): Disable thread verification on this class since it uses addressOfCount().

  • wtf/RefCounted.h:

(WTF::RefCountedBase::ref): Add ASSERT.
(WTF::RefCountedBase::hasOneRef): Ditto.
(WTF::RefCountedBase::refCount): Ditto.
(WTF::RefCountedBase::derefBase): Ditto.
(WTF::RefCountedBase::disableThreadVerification): delegate to ThreadVerifier method.

  • wtf/ThreadVerifier.h: Added.

(WTF::ThreadVerifier::ThreadVerifier): New Debug-only class to verify that ref/deref of RefCounted is done on the same thread.
(WTF::ThreadVerifier::activate): Activates checks. Called when ref count becomes above 2.
(WTF::ThreadVerifier::deactivate): Deactivates checks. Called when ref count drops below 2.
(WTF::ThreadVerifier::disableThreadVerification): used on objects that should not be checked (StringImpl etc)
(WTF::ThreadVerifier::verifyThread):

JavaScriptGlue:

  • ForwardingHeaders/wtf/ThreadVerifier.h: Added.

WebCore:

  • loader/icon/IconRecord.cpp:

(WebCore::IconRecord::IconRecord): Disable thread verification for this class because of its cross-thread use in IconDatabase.

  • platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::SharedBuffer): Ditto.

  • platform/text/StringImpl.cpp:

(WebCore::StringImpl::StringImpl): Disable thread verification for this class, add FIXME to enforce proper usage via crossThreadString.

  • ForwardingHeaders/wtf/ThreadVerifier.h: Added.

WebKit/mac:

  • ForwardingHeaders/wtf/ThreadVerifier.h: Added.

WebKitTools:

  • DumpRenderTree/ForwardingHeaders/wtf/ThreadVerifier.h: Added.
11:16 AM Changeset in webkit [51868] by ajwong@chromium.org
  • 2 edits in trunk/WebKit/chromium

Not reviewed: Chromium build fix.

r51859 changed the case for some of the ResourceRequest::TargetType
enums.

  • src/FrameLoaderClientImpl.cpp:

(WebKit::determineTargetTypeFromLoader):

10:59 AM Changeset in webkit [51867] by Adam Roben
  • 2 edits in trunk/WebKit/win

Windows build fix

  • Interfaces/WebKit.idl: Touched this to force Interfaces.vcproj to rebuild.
10:55 AM Changeset in webkit [51866] by levin@chromium.org
  • 3 edits in trunk/WebKitTools

[check-webkit-style] False positive for camel case of JSC op codes
​https://bugs.webkit.org/show_bug.cgi?id=32192

Reviewed by Adam Barth.

  • Scripts/modules/cpp_style.py: Added an exception for the JSC op code functions and const_iterator as well since I noticed a false positive there when testing the fix.
  • Scripts/modules/cpp_style_unittest.py: Added tests for these changes.
10:44 AM Changeset in webkit [51865] by abarth@webkit.org
  • 7 edits
    2 adds in trunk

2009-12-08 John Gregg <​johnnyg@google.com>

Reviewed by Adam Barth.

​https://bugs.webkit.org/show_bug.cgi?id=31886

Test for accessing the notificationCenter of a window after it's closed.

  • fast/notifications/notification-after-close-expected.txt: Added.
  • fast/notifications/notification-after-close.html: Added.

2009-12-08 John Gregg <​johnnyg@google.com>

Reviewed by Adam Barth.

Inform the NotificationCenter when its window goes away in the same
manner as other DOMWindow fields, and prevent invalid operations on
it after that happens.

As part of this, change the V8 bindings for notifications to call
through the NotificationCenter rather than doing those operations
itself.

​https://bugs.webkit.org/show_bug.cgi?id=31886

Test: fast/notifications/notification-after-close.html

  • bindings/v8/custom/V8NotificationCenterCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • notifications/Notification.cpp: (WebCore::Notification::Notification):
  • notifications/NotificationCenter.cpp: (WebCore::NotificationCenter::checkPermission): (WebCore::NotificationCenter::requestPermission):
  • notifications/NotificationCenter.h: (WebCore::NotificationCenter::createHTMLNotification): (WebCore::NotificationCenter::createNotification): (WebCore::NotificationCenter::disconnectFrame):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::clear):
10:44 AM CommitQueue edited by abarth@webkit.org
(diff)
9:37 AM Changeset in webkit [51864] by mitz@apple.com
  • 4 edits
    4 adds in trunk

WebCore: Fixed block selection gap repainting in table cells

Reviewed by John Sullivan.

Test: fast/repaint/block-selection-gap-in-table-cell.html

This recently-introduced regression exposed the fact that
RenderTableCell did not override offsetFromContainer() to adjust for
the fact that table cells’ coordinates are relative to the table
section, not the table row. With this fixed, RenderTableCell no longer
needs to override mapLocalToContainer() and mapAbsoluteToLocalPoint(),
since the base class implementations of those use offsetFromContainer().

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::offsetFromContainer):

  • rendering/RenderTableCell.h:

LayoutTests: Added a test of block selection gap repainting in table cells

Reviewed by John Sullivan.

  • fast/repaint/block-selection-gap-in-table-cell.html: Added.
  • platform/mac/fast/repaint/block-selection-gap-in-table-cell-expected.checksum: Added.
  • platform/mac/fast/repaint/block-selection-gap-in-table-cell-expected.png: Added.
  • platform/mac/fast/repaint/block-selection-gap-in-table-cell-expected.txt: Added.
9:35 AM Changeset in webkit [51863] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

2009-12-08 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Sane way to force a rebuild on all win slaves, according to Adam Roben.

  • WebCorePrefix.h:
9:32 AM Changeset in webkit [51862] by mitz@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Correct Bugzilla link

9:31 AM Changeset in webkit [51861] by mitz@apple.com
  • 2 edits in trunk/WebCore

Build fix

  • loader/loader.cpp:

(WebCore::cachedResourceTypeToTargetType):

9:08 AM Changeset in webkit [51860] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

2009-12-08 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Touch svgtags.in to eventually fix the win debug build.

  • svg/svgtags.in:
9:04 AM Changeset in webkit [51859] by eric@webkit.org
  • 4 edits in trunk/WebCore

2009-12-08 Mike Belshe <​mike@belshe.com>

Reviewed by Darin Fisher.

​https://bugs.webkit.org/show_bug.cgi?id=32152
Update the ResourceRequest::RequestType. This previously
was specific to Chromium. Moved into ResourceRequestBase, enabling
more specificity about the type (which is otherwise only known to the
loader), and also making this information available to all platforms.
Any platform with a network layer which can utilize this information
may want to use it for prioritization.

Note to Chromium glue: TargetIsSubResource renamed to TargetIsSubresource.

  • loader/loader.cpp: (WebCore::Loader::Loader): (WebCore::CachedResourceTypeToTargetType): (WebCore::Loader::Host::servePendingRequests):
  • platform/network/ResourceRequestBase.h: (WebCore::ResourceRequestBase::): (WebCore::ResourceRequestBase::targetType): (WebCore::ResourceRequestBase::setTargetType): (WebCore::ResourceRequestBase::ResourceRequestBase):
  • platform/network/chromium/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest):
8:55 AM Changeset in webkit [51858] by eric@webkit.org
  • 4 edits
    7 adds in trunk

2009-12-08 Steve Block <​steveblock@google.com>

Reviewed by Adam Barth.

[Android] Adds Makefiles for Android port.
​https://bugs.webkit.org/show_bug.cgi?id=31325

  • Android.mk: Added.

2009-12-08 Steve Block <​steveblock@google.com>

Reviewed by Adam Barth.

[Android] Adds Makefiles for Android port.
​https://bugs.webkit.org/show_bug.cgi?id=31325

  • Android.mk: Added.
  • Android.v8.wtf.mk: Added.

2009-12-08 Steve Block <​steveblock@google.com>

Reviewed by Adam Barth.

[Android] Adds Makefiles for Android port.
​https://bugs.webkit.org/show_bug.cgi?id=31325

Build system change only. No tests possible.

  • Android.derived.jscbindings.mk: Added.
  • Android.derived.mk: Added.
  • Android.jscbindings.mk: Added.
  • Android.mk: Added.
  • WebCorePrefix.h: Modified. Sets up some flags and adds a header required for building on Android.
8:55 AM Changeset in webkit [51857] by sullivan@apple.com
  • 2 edits in trunk/WebKit/win

Split two-clause assertions into two separate assertions.

Reviewed by Dan Bernstein

  • DOMHTMLClasses.cpp:

(DOMHTMLInputElement::isTextField):
Split a two-clause assertion into two separate assertions.
(DOMHTMLInputElement::rectOnScreen):
Added the two assertions here that all other functions in this group shared.
(DOMHTMLInputElement::selectedRange):
Split a two-clause assertion into two separate assertions.
(DOMHTMLInputElement::setAutofilled):
Split a two-clause assertion into two separate assertions.
(DOMHTMLInputElement::isAutofilled):
Split a two-clause assertion into two separate assertions.

8:36 AM Changeset in webkit [51856] by christian@webkit.org
  • 4 edits in trunk

2009-12-08 Christian Dywan <​christian@twotoasts.de>

Reviewed by Xan Lopez.

  • configure.ac: Require only libSoup 2.27.91 but check for 2.29.3 and define HAVE_LIBSOUP_2_29_3 in that case.
8:28 AM Changeset in webkit [51855] by Nikolas Zimmermann
  • 10 edits in trunk

2009-12-08 Nikolas Zimmermann <​nzimmermann@rim.com>

Rubber-stamped by Maciej Stachowiak.

Turn on (SVG) Filters for Win.
​https://bugs.webkit.org/show_bug.cgi?id=32224

8:17 AM Changeset in webkit [51854] by christian@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-12-08 Christian Dywan <​christian@twotoasts.de>

Reviewed by Gustavo Noronha Silva.

Point out the meaning of "Content-Disposition" when implementing the
mime-type-policy-decision-requested signal.

  • webkit/webkitwebview.cpp: (webkit_web_view_class_init):
7:58 AM Changeset in webkit [51853] by kov@webkit.org
  • 2 edits in trunk

Rubber-stamped by Xan Lopez.

Late post-release version bump.

  • configure.ac:
7:33 AM Changeset in webkit [51852] by eric@webkit.org
  • 5 edits in trunk/LayoutTests

2009-12-08 Kent Tamura <​tkent@chromium.org>

Reviewed by Darin Adler.

These test results should not have platform-dependent pixel values.
​https://bugs.webkit.org/show_bug.cgi?id=32265

Change is75PercentOf() so that it doesn't show pixel values when
the check is passed.

  • fast/replaced/table-percent-height-expected.txt:
  • fast/replaced/table-percent-height-text-controls-expected.txt:
  • fast/replaced/table-percent-height-text-controls.html:
  • fast/replaced/table-percent-height.html:
7:20 AM Changeset in webkit [51851] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2009-12-08 Carol Szabo <​carol.szabo@nokia.com>

Reviewed by Darin Adler.

CSS Counter Nesting still does not work according to the spec.
​https://bugs.webkit.org/show_bug.cgi?id=31723

  • fast/css/counters/nesting-expected.txt: Added.
  • fast/css/counters/nesting.html: Added. This test tests compliance with the CSS2.1 counter scoping and nesting rules.

2009-12-08 Carol Szabo <​carol.szabo@nokia.com>

Reviewed by Darin Adler.

CSS Counter Nesting still does not work according to the spec.
​https://bugs.webkit.org/show_bug.cgi?id=31723

Test: fast/css/counters/nesting.html

  • rendering/RenderCounter.cpp: (WebCore::findPlaceForCounter): Replaced the faulty counter insertion algorithm with one that works.
7:08 AM Changeset in webkit [51850] by sullivan@apple.com
  • 7 edits in trunk

Add isAutofilled getter to match existing setter.

Reviewed by Ada Chan.

WebCore:

  • bindings/objc/DOMHTML.mm:

(-[DOMHTMLInputElement _isAutofilled]):
Implemented new cover function.

  • bindings/objc/DOMPrivate.h:

Declared new cover function.

WebKit/win:

  • DOMHTMLClasses.cpp:

(DOMHTMLInputElement::isAutofilled):
Implemented new cover function.

  • DOMHTMLClasses.h:

Declared new cover function.

  • Interfaces/DOMPrivate.idl:

Declared new interface.

7:02 AM Changeset in webkit [51849] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Put test into skiplist because of missing layoutTestController.evaluateInWebInspector().

  • platform/qt/Skipped: inspector/cookie-resource-match.html added.
6:58 AM Changeset in webkit [51848] by eric@webkit.org
  • 4 edits
    1 add in trunk

2009-12-08 Dominik Röttsches <​dominik.roettsches@access-company.com>

Reviewed by Gustavo Noronha Silva.

[Gtk] Create a TextBreakIterator implementation based on GLib (without ICU)
​https://bugs.webkit.org/show_bug.cgi?id=31469

Removing hybrid configuration for --with-unicode-backend=glib
ICU not required anymore.

  • autotools/webkit.m4:

2009-12-08 Dominik Röttsches <​dominik.roettsches@access-company.com>

Reviewed by Gustavo Noronha Silva.

[Gtk] Create a TextBreakIterator implementation based on GLib (without ICU)
​https://bugs.webkit.org/show_bug.cgi?id=31469

Added a TextBreakIterator implementation based on GLib and pango,
which allows compiling WebCore without ICU.

  • GNUmakefile.am:
  • platform/text/gtk/TextBreakIteratorGtk.cpp: Added. (WebCore::): (WebCore::setUpIterator): (WebCore::characterBreakIterator): (WebCore::cursorMovementIterator): (WebCore::wordBreakIterator): (WebCore::lineBreakIterator): (WebCore::sentenceBreakIterator): (WebCore::textBreakFirst): (WebCore::textBreakLast): (WebCore::textBreakNext): (WebCore::textBreakPrevious): (WebCore::textBreakPreceding): (WebCore::textBreakFollowing): (WebCore::textBreakCurrent): (WebCore::isTextBreak):
6:35 AM Changeset in webkit [51847] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2009-12-08 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Update Gtk's custom prototype-inheritance-2-expected.txt, after enabling filters
(As gtk builds with geolocation, unlike the other platforms, it needs its own results)

This turns the Gtk slave to green again.

  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
6:09 AM QtWebKit/CodeCamp200912 edited by tapani.mikola@nokia.com
(diff)
6:02 AM QtWebKit edited by tapani.mikola@nokia.com
(diff)
5:56 AM QtWebKit/CodeCamp200912 created by tapani.mikola@nokia.com
5:21 AM Changeset in webkit [51846] by eric@webkit.org
  • 11 edits
    2 adds in trunk

2009-12-08 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Change the way cookies are retrieved in the WebInspector frontend.

Moved the cookie filtering from the native code into the frontend so that
all cookies can be retrieved regardless of the associated domain
(required for certain audits to run.)
​https://bugs.webkit.org/show_bug.cgi?id=32160

  • inspector/cookie-resource-match-expected.txt: Added.
  • inspector/cookie-resource-match.html: Added.

2009-12-08 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Change the way cookies are retrieved in the WebInspector frontend.

Moved the cookie filtering from the native code into the frontend so that
all cookies can be retrieved regardless of the associated domain
(required for certain audits to run.)
​https://bugs.webkit.org/show_bug.cgi?id=32160

Test: inspector/cookie-resource-match.html

  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getCookies):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::getCookies):
  • inspector/InspectorController.h:
  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype.update.callback): (WebInspector.CookieItemsView.prototype.update): (WebInspector.CookieItemsView.prototype._cookiesForDomain):
  • inspector/front-end/DOMAgent.js: (WebInspector.Cookies.getCookiesAsync): (WebInspector.Cookies.cookieMatchesResourceURL): (WebInspector.Cookies.cookieDomainMatchesResourceDomain):
  • inspector/front-end/Resource.js: (WebInspector.Resource): (WebInspector.Resource.prototype.get documentURL): (WebInspector.Resource.prototype.set documentURL):
  • inspector/front-end/inspector.js: (WebInspector.addResource):
4:55 AM Changeset in webkit [51845] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

2009-12-08 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Touch svgtags.in, in order to force SVGNames.* regeneration. Praying for gtk bot to be fixed :-)

  • svg/svgtags.in:
4:30 AM Changeset in webkit [51844] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

2009-12-08 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Trying to force a rebuild on the Gtk slave. If that doesn't work, someone must force a rebuild from scratch.

  • bindings/scripts/CodeGeneratorJS.pm:
3:51 AM Changeset in webkit [51843] by Nikolas Zimmermann
  • 6 edits in trunk

2009-12-08 Nikolas Zimmermann <​nzimmermann@rim.com>

Rubber-stamped by Maciej Stachowiak.

Turn on (SVG) Filters for Gtk.
​https://bugs.webkit.org/show_bug.cgi?id=32224

3:21 AM Changeset in webkit [51842] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2009-12-08 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Skip some tests that fail for a longer period on the SnowLeopard bot. Filed two bugs, notifying the authors.

  • platform/mac-snowleopard/Skipped:
2:58 AM Changeset in webkit [51841] by Nikolas Zimmermann
  • 4 edits in trunk/LayoutTests

2009-12-08 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Oops forgot to update three results -> Qt slave green again.

  • platform/qt/svg/filters/feGaussianBlur-expected.txt:
  • platform/qt/svg/filters/feMerge-wrong-input-expected.txt:
  • platform/qt/svg/filters/feOffset-expected.txt:
2:47 AM Changeset in webkit [51840] by Nikolas Zimmermann
  • 11 edits in trunk/LayoutTests

2009-12-08 Nikolas Zimmermann <​nzimmermann@rim.com>

Not reviewed. Now that the Qt slave has been rebuilt, reenable all tests that failed
because of the build problems (Qt slave didn't rebuild all files with ENABLE_FILTERS set).

Update some Qt specfic filter test results.

  • platform/qt/Skipped:
  • platform/qt/svg/filters/feComposite-expected.txt:
  • platform/qt/svg/filters/feMerge-expected.txt:
  • platform/qt/svg/filters/feTile-expected.txt:
  • platform/qt/svg/filters/shadow-on-filter-expected.txt:
  • platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt:
  • platform/qt/svg/filters/sourceAlpha-expected.txt:
  • platform/qt/svg/filters/subRegion-in-userSpace-expected.txt:
  • platform/qt/svg/filters/subRegion-one-effect-expected.txt:
  • platform/qt/svg/filters/subRegion-two-effects-expected.txt:
2:19 AM Changeset in webkit [51839] by pfeldman@chromium.org
  • 22 edits
    2 copies in trunk/WebCore

2009-12-06 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: provide custom context menu in the front-end window.

​https://bugs.webkit.org/show_bug.cgi?id=32200

  • English.lproj/localizedStrings.js:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSInspectorFrontendHostCustom.cpp: (WebCore::JSInspectorFrontendHost::showContextMenu):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::contextMenuItemSelected): (WebCore::InspectorFrontend::contextMenuCleared):
  • inspector/InspectorFrontend.h:
  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::InspectorFrontendHost): (WebCore::InspectorFrontendHost::~InspectorFrontendHost): (WebCore::InspectorFrontendHost::showContextMenu): (WebCore::InspectorFrontendHost::contextMenuItemSelected): (WebCore::InspectorFrontendHost::contextMenuCleared):
  • inspector/InspectorFrontendHost.h: (WebCore::InspectorFrontendHost::MenuSelectionHandler::create): (WebCore::InspectorFrontendHost::MenuSelectionHandler::~MenuSelectionHandler): (WebCore::InspectorFrontendHost::MenuSelectionHandler::disconnect): (WebCore::InspectorFrontendHost::MenuSelectionHandler::contextMenuItemSelected): (WebCore::InspectorFrontendHost::MenuSelectionHandler::contextMenuCleared): (WebCore::InspectorFrontendHost::MenuSelectionHandler::MenuSelectionHandler):
  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/ContextMenu.js: Added.
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.documentContextMenu):
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::ContextMenuController): (WebCore::ContextMenuController::clearContextMenu): (WebCore::ContextMenuController::handleContextMenuEvent): (WebCore::ContextMenuController::showContextMenu): (WebCore::ContextMenuController::createContextMenu): (WebCore::ContextMenuController::contextMenuItemSelected):
  • page/ContextMenuController.h:
  • page/ContextMenuSelectionHandler.h: Added. (WebCore::ContextMenuSelectionHandler::ContextMenuSelectionHandler): (WebCore::ContextMenuSelectionHandler::~ContextMenuSelectionHandler):
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded):
  • platform/ContextMenuItem.h:
2:04 AM Changeset in webkit [51838] by Csaba Osztrogonác
  • 2 edits in trunk/WebCore

Rubber-stamped by Kenneth Rohde Christiansen.

Patch by Andras Becsi <​abecsi@inf.u-szeged.hu> on 2009-12-08
[Qt] Build fix of duplicated platform/graphics/filters/FEGaussianBlur.cpp in WebCore.pro after enabled svg filters.

No new tests needed.

  • WebCore.pro:
12:32 AM Changeset in webkit [51837] by ukai@chromium.org
  • 1 edit
    10 adds in trunk/LayoutTests

2009-12-08 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Darin Adler.

Add tests that WebSocket protocol argument works.
​https://bugs.webkit.org/show_bug.cgi?id=3178

  • websocket/tests/bad-sub-protocol-expected.txt: Added.
  • websocket/tests/bad-sub-protocol.html: Added.
  • websocket/tests/handshake-fail-by-sub-protocol-mismatch-expected.txt: Added.
  • websocket/tests/handshake-fail-by-sub-protocol-mismatch.html: Added.
  • websocket/tests/protocol-test_wsh.py: Added.
  • websocket/tests/script-tests/bad-sub-protocol.js: Added.
  • websocket/tests/script-tests/handshake-fail-by-sub-protocol-mismatch.js: Added.
  • websocket/tests/script-tests/sub-protocol.js: Added.
  • websocket/tests/sub-protocol-expected.txt: Added.
  • websocket/tests/sub-protocol.html: Added.
Note: See TracTimeline for information about the timeline view.