Timeline


and

12/22/09:

23:54 Changeset [52522] by dbates@webkit.org

2009-12-22 Daniel Bates <dbates@rim.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=32680

Fixes an issue in builtDylibPathForName so that it returns the correct
path to the built QtWebKit library on the Qt Windows port. Currently,
it returns the path to the file named QtWebKit.dll but this file does
not exist on the Qt Windows build. Instead, the file is named
QtWebKit4.dll.

  • Scripts/webkitdirs.pm:
23:28 Changeset [52521] by dbates@webkit.org

2009-12-22 Daniel Bates <dbates@webkit.org>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=32799

Renames enums in RenderStyleConstants::EListStyleType to conform to
the WebKit Code Style Guidelines.

No functionality was changed. So, no new tests.

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EListStyleType):
  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::styleDidChange):
  • rendering/RenderListMarker.cpp: (WebCore::listMarkerText): (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::calcPrefWidths): (WebCore::RenderListMarker::updateMargins): (WebCore::RenderListMarker::getRelativeMarkerRect):
  • rendering/style/RenderStyle.h: (WebCore::InheritedFlags::initialListStyleType):
  • rendering/style/RenderStyleConstants.h: (WebCore::):
22:08 Changeset [52520] by eric@webkit.org

2009-12-22 Marc-Antoine Ruel <maruel@chromium.org>

Reviewed by Adam Roben.

Remove the only dependency on perl-libwin32 in cygwin

  • Scripts/num-cpus:
19:59 Changeset [52519] by eric@webkit.org

2009-12-22 James Su <suzhe@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Keyboard shortcut in dropdown not working.
https://bugs.webkit.org/show_bug.cgi?id=32008

Consider PlatformKeyboardEvent::Char type event as character type
event on all platforms. It fixes the "type ahead find" feature
of the popup listbox on Linux and Mac platforms.

Merge the case-sensitive type ahead find fix from
WebCore/dom/SelectElement.cpp. See
https://bugs.webkit.org/show_bug.cgi?id=29103

  • platform/chromium/PopupMenuChromium.cpp: (WebCore::isCharacterTypeEvent):
19:52 QtWebKitBackportingFixes edited by laszlo.1.gombos@nokia.com
(diff)
18:26 Changeset [52518] by eric@webkit.org

2009-12-22 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Eric Seidel.

[Qt] The "Search" input type is not rendered correctly when styled.
https://bugs.webkit.org/show_bug.cgi?id=32417

There are no new tests because only pixel tests may be affected by
this change and those changes can only be done on the build bot.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::paintSearchField): Since currently we paint the Search control as a QLineEdit, I have deferred painting to WebCore, as in the case of the text input so that the painting is consistent.
18:19 Changeset [52517] by eric@webkit.org

2009-12-22 Kenneth Russell <kbr@google.com>

Reviewed by Eric Seidel.

[Chromium] Garbage in transparent regions of images uploaded as textures
https://bugs.webkit.org/show_bug.cgi?id=32888

  • fast/canvas/webgl/bug-32888-expected.txt: Added.
  • fast/canvas/webgl/bug-32888.html: Added.
  • fast/canvas/webgl/resources/bug-32888-texture.png: Added.

2009-12-22 Kenneth Russell <kbr@google.com>

Reviewed by Eric Seidel.

[Chromium] Garbage in transparent regions of images uploaded as textures
https://bugs.webkit.org/show_bug.cgi?id=32888

Test: fast/canvas/webgl/bug-32888.html (works in Safari / DumpRenderTree)

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3D::texImage2D):
18:11 Changeset [52516] by eric@webkit.org

2009-12-22 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

https://bugs.webkit.org/show_bug.cgi?id=32121
[Qt] implement ImageDecoderQt::clearFrameBufferCache().

  • platform/graphics/qt/ImageDecoderQt.cpp: (WebCore::ImageDecoderQt::initializeDecoder): (WebCore::ImageDecoderQt::setData): (WebCore::ImageDecoderQt::clearFrameBufferCache):
  • platform/graphics/qt/ImageDecoderQt.h:
18:04 Changeset [52515] by eric@webkit.org

2009-12-22 Nayan Kumar K <nayankk@gmail.com>

Reviewed by Eric Seidel.

Fix assert failure with WML pages having 'Refresh' task in
'onenterforward' event.

https://bugs.webkit.org/show_bug.cgi?id=30989

Writing Layout test is not possible. Please refer to the discussion
in bug id #30989. A sample test case is attached in BugZilla.

  • wml/WMLCardElement.cpp: (WebCore::WMLCardElement::handleIntrinsicEventIfNeeded):
17:34 Changeset [52514] by agl@chromium.org

2009-12-22 Adam Langley <agl@google.com>

Build fix: not reviewed.

r52504 (https://bugs.webkit.org/show_bug.cgi?id=32845) broke the
Chromium build on Windows and Mac due to a misplaced #endif. The
buildbot didn't find the problem because it runs on Linux.

Have verified this patch with the author of the above.

  • src/GraphicsContext3D.cpp:
17:20 Changeset [52513] by darin@apple.com

Removed DataGrid from results.

  • fast/dom/Window/window-properties-expected.txt: Removed DataGrid classes.
  • fast/dom/prototype-inheritance-2-expected.txt: Ditto.
  • fast/dom/prototype-inheritance-expected.txt: Ditto.
  • fast/js/global-constructors-expected.txt: Ditto.
17:18 Changeset [52512] by darin@apple.com

Disabled DataGrid tests.

  • fast/dom/HTMLDataGridElement/DataGridColumns-basic.html: Removed.
  • fast/dom/HTMLDataGridElement/DataGridColumns-basic.html-disabled: Copied from fast/dom/HTMLDataGridElement/DataGridColumns-basic.html.
  • fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html: Removed.
  • fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html-disabled: Copied from fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html.
  • fast/dom/HTMLDataGridElement/DataGridColumns-dom.html: Removed.
  • fast/dom/HTMLDataGridElement/DataGridColumns-dom.html-disabled: Copied from fast/dom/HTMLDataGridElement/DataGridColumns-dom.html.
  • fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html: Removed.
  • fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html-disabled: Copied from fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html.
16:49 Changeset [52511] by darin@apple.com

ASSERTION FAILED: m_numNodeListCaches
https://bugs.webkit.org/show_bug.cgi?id=19526
<rdar://problem/7431572>

Reviewed by Sam Weinig.

WebCore:

Test: fast/dom/NodeList/adoptNode-node-list-cache.html

  • dom/Node.cpp:

(WebCore::Node::setDocument): Call removeNodeListCache on the old
document and addNodeListCache on the new one if moving a node that
has node lists.

LayoutTests:

  • fast/dom/NodeList/adoptNode-node-list-cache-expected.txt: Added.
  • fast/dom/NodeList/adoptNode-node-list-cache.html: Added.
  • fast/dom/NodeList/resources: Added.
  • fast/dom/NodeList/resources/adoptNode-node-list-cache-subframe.html: Added.
16:48 Changeset [52510] by darin@apple.com

Another try at fixing Windows build.

  • WebKitPrefix.cpp: Touch it.
16:36 EFLWebKit edited by afonso.costa@openbossa.org
(diff)
16:26 Changeset [52509] by darin@apple.com

First cut at fixing Windows build.

  • WebCorePrefix.cpp: Touch it.
15:59 Changeset [52508] by darin@apple.com
  • pywebsocket/mod_pywebsocket: Added property svn:ignore to ignore

generated ".pyc" files.

15:53 Changeset [52507] by darin@apple.com

Turn off datagrid by default, at least for all platforms Apple ships.
The datagrid implementation isn't ready for general web use yet.

Reviewed by Mark Rowe.

JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig: Turn off datagrid by default.

WebCore:

  • Configurations/FeatureDefines.xcconfig: Turn off datagrid by default.
  • WebCore.vcproj/WebCoreCommon.vsprops: Ditto.
  • WebCore.vcproj/build-generated-files.sh: Ditto.
  • page/DOMWindow.idl: Sorted things here to touch the file to give

the Windows build a slightly better chance of success.

WebKit/mac:

  • Configurations/FeatureDefines.xcconfig: Turn off datagrid by default.

WebKit/win:

  • WebKit.vcproj/WebKit.vcproj: Turn off datagrid by default.

WebKitTools:

  • Scripts/build-webkit: Turn off datagrid by default.
15:50 Changeset [52506] by eric@webkit.org

2009-12-22 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Upstream platform-specific variant of
plugins/get-url-with-blank-target.html . There is some uncertainty
over which behavior is correct - Chromium's and Safari/Win in this
test, or Safari/Mac in the generic test. See
https://bugs.webkit.org/show_bug.cgi?id=32886 for the bug to converge
the two.
This patch is bug https://bugs.webkit.org/show_bug.cgi?32762 .

  • platform/chromium/plugins/get-url-with-blank-target-expected.txt: Added.
  • platform/chromium/plugins/get-url-with-blank-target.html: Added.
15:35 QtWebKitBackportingFixes edited by laszlo.1.gombos@nokia.com
(diff)
15:31 QtWebKitBackportingFixes edited by laszlo.1.gombos@nokia.com
(diff)
15:19 QtWebKitBackportingFixes edited by laszlo.1.gombos@nokia.com
(diff)
15:12 Changeset [52505] by eric@webkit.org

2009-12-22 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Upstream a bunch of forms tests from chromium.org.
https://bugs.webkit.org/show_bug.cgi?id=32755

  • fast/forms/basic-selects.html: Added.
  • fast/forms/basic-textareas-quirks.html: Added.
  • fast/forms/document-write-empty-expected.txt: Added.
  • fast/forms/document-write-empty.html: Added.
  • fast/forms/form-action-expected.txt: Added.
  • fast/forms/form-action.html: Added.
  • fast/forms/lazy-event-listener-scope-chain-expected.txt: Added.
  • fast/forms/lazy-event-listener-scope-chain.html: Added.
  • fast/forms/resources/logo.gif: Added.
  • fast/forms/selected-index-value-expected.txt: Added.
  • fast/forms/selected-index-value.html: Added.
  • fast/forms/style-display-none-expected.txt: Added.
  • fast/forms/style-display-none.html: Added.
  • platform/mac/fast/forms/basic-selects-expected.checksum: Added.
  • platform/mac/fast/forms/basic-selects-expected.png: Added.
  • platform/mac/fast/forms/basic-selects-expected.txt: Added.
  • platform/mac/fast/forms/basic-textareas-quirks-expected.checksum:
  • platform/mac/fast/forms/basic-textareas-quirks-expected.png:
  • platform/mac/fast/forms/basic-textareas-quirks-expected.txt:
15:00 Changeset [52504] by eric@webkit.org

2009-12-22 Kenneth Russell <kbr@google.com>

Reviewed by Eric Seidel.

[Chromium] WebGL crashes intermittently on Linux
https://bugs.webkit.org/show_bug.cgi?id=32845

The dlclose'ing of libGL.so.1 and dlopen'ing of it each time a
GraphicsContext3D was created was occasionally causing it to be
re-mapped at a different base address. Since GLEW is not
re-initialized every time, primarily for performance reasons, its
cached function pointers were pointing to garbage. Stopped closing
and re-opening libGL.so.1 each time; now it is loaded lazily, when
the first 3D context is created. Also reused the X display
connection since the GLX routines' correctness might hinge upon it
not resulting in a change of GL implementation.

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GLConnection::chooseFBConfig): (WebCore::GraphicsContext3DInternal::GLConnection::createNewContext): (WebCore::GraphicsContext3DInternal::GLConnection::createPbuffer): (WebCore::GraphicsContext3DInternal::GLConnection::destroyPbuffer): (WebCore::GraphicsContext3DInternal::GLConnection::makeCurrent): (WebCore::GraphicsContext3DInternal::GLConnection::destroyContext): (WebCore::GraphicsContext3DInternal::GLConnection::getCurrentContext): (WebCore::GraphicsContext3DInternal::GLConnection::GLConnection): (WebCore::GraphicsContext3DInternal::GLConnection::tryLoad): (WebCore::GraphicsContext3DInternal::GLConnection::create): (WebCore::GraphicsContext3DInternal::GLConnection::~GLConnection): (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::makeContextCurrent):
14:33 Changeset [52503] by eric@webkit.org

2009-12-22 Steve Block <steveblock@google.com>

Reviewed by David Levin.

Updates Android's scheduleDispatchFunctionsOnMainThread() to use new
AndroidThreading class, rather than using JavaSharedClient directly.
This fixes the current layering violation.
https://bugs.webkit.org/show_bug.cgi?id=32651

The pattern is copied from Chromium, which uses the ChromiumThreading
class. This patch also fixes the style in ChromiumThreading.h.

  • wtf/android/AndroidThreading.h: Added. Declares AndroidThreading.
  • wtf/android/MainThreadAndroid.cpp: Modified (WTF::scheduleDispatchFunctionsOnMainThread): Uses AndroidThreading.
  • wtf/chromium/ChromiumThreading.h: Modified. Fixes style.
14:26 Changeset [52502] by eric@webkit.org

2009-12-22 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Add platform-specific chromium test.
https://bugs.webkit.org/show_bug.cgi?id=32741

  • platform/chromium/fast/dom/interval-expected.txt: Added.
  • platform/chromium/fast/dom/interval.html: Added.
14:18 Changeset [52501] by eric@webkit.org

2009-12-22 Eric Seidel <eric@webkit.org>

Reviewed by Darin Adler.

validate-committer-lists fails when run from an SVN checkout
https://bugs.webkit.org/show_bug.cgi?id=31974

  • Scripts/validate-committer-lists:
    • Make it print a warning message instead of throwing an exception when running from an SVN checkout.
14:05 Changeset [52500] by barraclough@apple.com

Fix a couple of problems with UntypedPtrAndBitfield.

Reviewed by Sam Weinig.

Add a m_leaksPtr to reduce false positives from leaks in debug builds
(this isn't perfect because we'd like a solution for release builds,
but this is now at least as good as a PtrAndFlags would be).

Switch SmallStringsto use a regular string for the base, rather than
a static one. UntypedPtrAndBitfield assumes all strings are at least
8 byte aligned; this migt not be true of static strings. Shared buffers
are heap allocated, as are all UStringImpls other than static strings.
Static strings cannot end up being the owner string of substrings,
since the only static strings are length 0.

  • runtime/SmallStrings.cpp:

(JSC::SmallStringsStorage::SmallStringsStorage):

  • runtime/UStringImpl.h:

(JSC::UntypedPtrAndBitfield::UntypedPtrAndBitfield):
(JSC::UStringImpl::UStringImpl):

13:59 Changeset [52499] by darin@apple.com

Rubber stamped by Dan Bernstein.

  • page/FrameView.h: Removed incorrect comment.
13:47 QtWebKitBackportingFixes edited by laszlo.1.gombos@nokia.com
(diff)
13:44 Changeset [52498] by eric@webkit.org

2009-12-22 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Add platform-specific chromium test.
https://bugs.webkit.org/show_bug.cgi?id=32741

  • platform/chromium/fast/dom/interval-expected.txt: Added.
  • platform/chromium/fast/dom/interval.html: Added.
13:42 QtWebKitBackportingFixes edited by laszlo.1.gombos@nokia.com
(diff)
13:40 QtWebKitBackportingFixes edited by laszlo.1.gombos@nokia.com
(diff)
13:36 Changeset [52497] by eric@webkit.org

2009-12-22 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

Attempting to upstream xss-inactive-closure test from the Chromium
test suite. https://bugs.webkit.org/show_bug.cgi?id=32691 .

  • http/tests/security/listener/resources/xss-inactive-closure-child-2.html: Added.
  • http/tests/security/listener/resources/xss-inactive-closure-child.html: Added.
  • http/tests/security/listener/xss-inactive-closure-expected.txt: Added.
  • http/tests/security/listener/xss-inactive-closure.html: Added.
13:18 Changeset [52496] by eric@webkit.org

2009-12-22 Philippe Normand <pnormand@igalia.com>

Reviewed by Adam Barth.

check-webkit-style should not warn about NULL usage in g_object_{get,set}
https://bugs.webkit.org/show_bug.cgi?id=32858

  • Scripts/modules/cpp_style.py:
  • Scripts/modules/cpp_style_unittest.py:
12:09 Changeset [52495] by pfeldman@chromium.org

2009-12-22 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: simplify highlighter definition.

https://bugs.webkit.org/show_bug.cgi?id=32869

WebCore:

  • inspector/front-end/CSSSourceSyntaxHighlighter.js: (WebInspector.CSSSourceSyntaxHighlighter):
  • inspector/front-end/JavaScriptSourceSyntaxHighlighter.js: (WebInspector.JavaScriptSourceSyntaxHighlighter.): (WebInspector.JavaScriptSourceSyntaxHighlighter):
  • inspector/front-end/SourceSyntaxHighlighter.js: (WebInspector.SourceSyntaxHighlighter.prototype.lex):
  • inspector/front-end/utilities.js: ():

LayoutTests:

  • inspector/syntax-highlight-css-expected.txt:
  • inspector/syntax-highlight-javascript-expected.txt:
  • inspector/syntax-highlight.js: (frontend_dumpSyntaxHighlight):
11:26 Changeset [52494] by darin@apple.com

Reentrancy problem with selection in some edge cases.
https://bugs.webkit.org/show_bug.cgi?id=32842
rdar://problem/7449974

Reviewed by Sam Weinig.

WebCore:

Test: fast/forms/selection-layout-reentry-strange-case.html

Move the selection display update process done in the
selectionLayoutChanged function into the layout timer
instead of doing it immediately when selection changes occur.

  • editing/SelectionController.cpp:

(WebCore::SelectionController::SelectionController):
Initialize m_needsDisplayUpdate to false.
(WebCore::SelectionController::setSelection): Call
the new setNeedsDisplayUpdate function instead of the old
badly named Frame::selectionLayoutChanged function.
(WebCore::SelectionController::setNeedsDisplayUpdate):
Set m_needsDisplayUpdate. If it is just becoming true, then
call FrameView::scheduleRelayout.

  • editing/SelectionController.h: Added setNeedsDisplayUpdate,

needsDisplayUpdate, and m_needsDisplayUpdate.

  • page/Frame.cpp:

(WebCore::Frame::setCaretVisible): Call setNeedsDisplayUpdate.
(WebCore::Frame::selectionLayoutChanged): Call
setNeedsDisplayUpdate to set it to false, since this is the
function that performs "selection display update". Later I want
to rename this function.

  • page/FrameView.cpp:

(WebCore::FrameView::needsLayout): Add a new clause, since
we need a call to layout if needsDisplayUpdate is true.

LayoutTests:

  • fast/forms/selection-layout-reentry-strange-case-expected.txt: Added.
  • fast/forms/selection-layout-reentry-strange-case.html: Added.
  • platform/mac/accessibility/frame-with-title-expected.txt: Updated since

the number of layouts is now different.

11:17 QtWebKitPerformanceWork edited by dbates@webkit.org
Added WebKit and Git prerequisite (diff)
11:17 QtWebKitBackportingFixes edited by laszlo.1.gombos@nokia.com
(diff)
10:58 Changeset [52493] by eric@webkit.org

2009-12-22 Kwang Yul Seo <skyul@company100.net>

Reviewed by Darin Adler.

RVCT (ARMCC_VERSION < 400000) does not provide strcasecmp and strncasecmp
https://bugs.webkit.org/show_bug.cgi?id=32857

Add implementation of strcasecmp and strncasecmp for RVCT < 4.0
because earlier versions of RVCT 4.0 does not provide these functions.

  • wtf/StringExtras.cpp: Added. (strcasecmp): (strncasecmp):
  • wtf/StringExtras.h:
10:51 Changeset [52492] by eric@webkit.org

2009-12-22 Kwang Yul Seo <skyul@company100.net>

Reviewed by Darin Adler.

Allocate RemoteFontStream on the heap
https://bugs.webkit.org/show_bug.cgi?id=32850

RemoteFontStream is allocated on the stack, so its memory is freed
immediately when FontCustomPlatformData::createFontCustomPlatformData
returns.

SkTypeface::CreateFromStream increments the reference count, but it keeps
the pointer to the memory allocated on the stack which is not valid
anymore.

RemoteFontStream is a descendant of SkRefCount and SkRefCount::unref
invokes SkDELETE(this) internally once the reference count reaches zero.
This means that SkRefCount-ed instances must be allocated on the heap.

  • platform/graphics/chromium/FontCustomPlatformData.cpp: (WebCore::createFontCustomPlatformData):
10:43 Changeset [52491] by eric@webkit.org

2009-12-22 Kwang Yul Seo <skyul@company100.net>

Reviewed by Darin Adler.

when condition COMPILER(RVCT) is fulfilled, we are trying to free a pointer to array allocated on the stack
https://bugs.webkit.org/show_bug.cgi?id=32861

Don't free the pointer for COMPILER(RVCT).

  • dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::error):
10:38 QtWebKitBackportingFixes edited by laszlo.1.gombos@nokia.com
(diff)
10:36 Changeset [52490] by eric@webkit.org

2009-12-22 Kwang Yul Seo <skyul@company100.net>

Reviewed by Darin Adler.

Define ALWAYS_INLINE and WTF_PRIVATE_INLINE to forceinline for RVCT
https://bugs.webkit.org/show_bug.cgi?id=32853

Use forceinline forces RVCT to compile a C or C++ function
inline. The compiler attempts to inline the function, regardless of
the characteristics of the function.

  • wtf/AlwaysInline.h:
  • wtf/FastMalloc.h:
10:32 QtWebKitBackportingFixes edited by laszlo.1.gombos@nokia.com
(diff)
10:32 QtWebKitBackportingFixes edited by laszlo.1.gombos@nokia.com
(diff)
10:28 QtWebKitBackportingFixes edited by laszlo.1.gombos@nokia.com
(diff)
10:05 QtWebKitBackportingFixes edited by laszlo.1.gombos@nokia.com
(diff)
09:40 QtWebKitBackportingFixes edited by laszlo.1.gombos@nokia.com
(diff)
09:39 Changeset [52489] by weinig@apple.com

Rubber-stamped by Dan Bernstein.

Remove no longer necessary experimental single view #ifdefs from Widget and
ScrollView.

  • page/Chrome.h:
  • page/mac/ChromeMac.mm:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::wheelEvent):

  • platform/Widget.cpp:
  • platform/Widget.h:
  • platform/mac/ScrollViewMac.mm:
  • platform/mac/WidgetMac.mm:
09:33 Changeset [52488] by eric@webkit.org

2009-12-22 Yaar Schnitman <yaar@chromium.org>

Reviewed by Darin Fisher.

autoComplete and getElementById methods for WebKit API

https://bugs.webkit.org/show_bug.cgi?id=32866

  • public/WebDocument.h:
  • public/WebInputElement.h:
  • src/WebDocument.cpp: (WebKit::WebDocument::getElementById):
  • src/WebInputElement.cpp: (WebKit::WebInputElement::autoComplete):
09:32 QtWebKitBackportingFixes edited by yael.aharon@nokia.com
(diff)
08:21 Changeset [52487] by pfeldman@chromium.org

2009-12-21 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Do not lose original request for non-main resource redirects.

https://bugs.webkit.org/show_bug.cgi?id=32678

  • inspector/InspectorResource.cpp: (WebCore::InspectorResource::appendRedirect):
  • inspector/front-end/Resource.js: (WebInspector.Resource):
  • inspector/front-end/inspector.js: (WebInspector.updateResource):
05:13 Changeset [52486] by hausmann@webkit.org

Rubber-stamped by Holger Freyther.

.:

Adjusted path to QtLauncher.

  • WebKit.pro:

WebKit/qt:

Moved QtLauncher to WebKitTools/

  • QtLauncher: Removed.
  • QtLauncher/QtLauncher.pro: Removed.
  • QtLauncher/main.cpp: Removed.

WebKitTools:

Moved QtLauncher from WebKit/qt.

  • QtLauncher: Copied from WebKit/qt/QtLauncher.
  • QtLauncher/QtLauncher.pro:

12/21/09:

23:46 Changeset [52485] by ossy@webkit.org

[Qt] Skip layoutTestController.notifyDone() related test until fix.
https://bugs.webkit.org/show_bug.cgi?id=31626

  • platform/qt/Skipped: http/tests/misc/set-window-opener-to-null.html added.
23:04 Changeset [52484] by eric@webkit.org

2009-12-21 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Upstream chrome/fast/events/iframe-onload-remove-self-no-crash.html .
https://bugs.webkit.org/show_bug.cgi?id=32742 .

  • fast/frames/iframe-onload-remove-self-no-crash-expected.txt: Added.
  • fast/frames/iframe-onload-remove-self-no-crash.html: Added.
  • fast/frames/resources/iframe-onload-remove-self-no-crash-child.html: Added.
  • fast/frames/resources/iframe-onload-remove-self-no-crash.js: Added. (onWindowLoad):
22:57 Changeset [52483] by eric@webkit.org

2009-12-21 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

Use ASSERT instead of assert in image-decoders
https://bugs.webkit.org/show_bug.cgi?id=32852

Other decoders use WTF's ASSERT macro.
Follow this convention.

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::decode):
  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::headerAvailable):
22:54 Changeset [52482] by hausmann@webkit.org

Prospective GTK build fix: Add UStringImpl.cpp/h to the build.

  • GNUmakefile.am:
22:53 Changeset [52481] by hausmann@webkit.org

Fix the Qt build, add UStringImpl.cpp to the build.

22:46 Changeset [52480] by abarth@webkit.org

2009-12-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Automate the process of calling prepare-ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=32816

This patch automates the process of creating a bug and patch and
uploading it to bugzilla. The first cut just calls
prepare-ChangeLog.

This patch required some refactoring of upload.py to the Step
model, but that's worth doing anyway.

  • Scripts/bugzilla-tool:
  • Scripts/modules/buildsteps.py:
  • Scripts/modules/commands/download.py:
  • Scripts/modules/commands/upload.py:
  • Scripts/modules/commands/upload_unittest.py:
  • Scripts/modules/mock_bugzillatool.py:
21:44 Changeset [52479] by eric@webkit.org

2009-12-21 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

Use vsnprintf instead of vasprintf for RVCT.
https://bugs.webkit.org/show_bug.cgi?id=32851

RVCT does not support vasprint, so use vsnprintf instead.

  • dom/XMLTokenizerLibxml2.cpp: (WebCore::XMLTokenizer::error):
20:47 Changeset [52478] by ukai@chromium.org

2009-12-21 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

Invalid url should raise SYNTAX_ERR exception.
https://bugs.webkit.org/show_bug.cgi?id=32700

  • websocket/tests/bad-sub-protocol-expected.txt: add CONSOLE MESSAGEs
  • websocket/tests/script-tests/url-parsing.js: add invalid url tests. Also changed url from ws://127.0.0.1/ to ws://127.0.0.1:8880/websocket/tests/simple to make it sure no errors on console message for these tests by not receiving unexpected response from 127.0.0.1:80
  • websocket/tests/url-parsing-expected.txt:

2009-12-21 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

Invalid url should raise SYNTAX_ERR exception.
https://bugs.webkit.org/show_bug.cgi?id=32700

Check url is valid in WebSocket::connect.
Also log the detailed reason of websocket failures to console.

  • websockets/WebSocket.cpp: (WebCore::encodeProtocolString): (WebCore::WebSocket::connect):
20:31 Changeset [52477] by eric@webkit.org

2009-12-21 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

Upstream a test from chromium.org.
https://bugs.webkit.org/show_bug.cgi?id=32761

  • http/tests/misc/resources/content-iframe.html: Added.
  • http/tests/misc/set-window-opener-to-null-expected.txt: Added.
  • http/tests/misc/set-window-opener-to-null.html: Added.
19:36 Changeset [52476] by bweinstein@apple.com

Build fix for Windows Debug, if this breaks Release I will roll it out.

19:01 Changeset [52475] by bweinstein@apple.com

Should be final part of the Windows build fix.

19:00 Changeset [52474] by mrowe@apple.com

Don't allocate a WebGeolocationControllerClient unless that compile-time setting is enabled.

Reviewed by Sam Weinig.

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):

18:49 Changeset [52473] by mrowe@apple.com

Update WebKitSystemInterface.

Reviewed by Samuel Weinig.

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
18:41 Changeset [52472] by bweinstein@apple.com

Hopefully closer to a build fix. JavaScriptCore will build now.

18:25 Changeset [52471] by barraclough@apple.com

Windows Build fix part 5.

18:04 Changeset [52470] by barraclough@apple.com

Fix breakage of world introduced in build fix to r52463.

Reviewed by NOBODY (build fix).

  • runtime/UStringImpl.h:
18:03 Changeset [52469] by andersca@apple.com

Make sure that we check for the right thread.

Reviewed by Sam Weinig.

  • platform/mac/WebCoreObjCExtras.mm:

(WebCoreObjCScheduleDeallocateOnMainThread):

17:35 QtWebKitPerformanceWork edited by dbates@webkit.org
Change formatting to outline mode (diff)
17:31 QtWebKitPerformanceWork edited by dbates@webkit.org
Add section Common Windows Errors and describe port 80 already in use … (diff)
17:28 Changeset [52468] by barraclough@apple.com

unreviewed windows build fix #4

17:21 Changeset [52467] by barraclough@apple.com

unreviewed windows build fix #3

17:08 Changeset [52466] by barraclough@apple.com

unreviewed windows build fix #2

16:57 Changeset [52465] by enrica@apple.com

WebCore: REGRESSION(4.0.4-ToT): Indent deletes non highlighted text in gmail.
<rdar://problem/7489326>
https://bugs.webkit.org/show_bug.cgi?id=32843

Reviewed by Maciej Stachowiak.

The fix for 7442387 did not handle the case where the end of paragraph
is not a descendant of the computed outer block.
Updated editing/execCommand/indent-with-style2.html to cover this case too.

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):

LayoutTests: REGRESSION(4.0.4-ToT): Indent deletes non highlighted text in gmail.
<rdar://problem/7489326>
https://bugs.webkit.org/show_bug.cgi?id=32843

Reviewed by Maciej Stachowiak.

The fix for 7442387 did not handle the case where the end of paragraph
is not a descendant of the computed outer block.
Updated editing/execCommand/indent-with-style2.html to cover this case too.

  • editing/execCommand/indent-with-style2-expected.txt:
  • editing/execCommand/indent-with-style2.html:
16:53 Changeset [52464] by barraclough@apple.com

unreviewed windows build fix #1

16:47 QtWebKitPerformanceWork edited by dbates@webkit.org
Rewrote the sentence that starts "When starting the 'http_server'...", so … (diff)
16:41 QtWebKitPerformanceWork edited by dbates@webkit.org
Added section Prerequisites to mention (diff)
16:38 Changeset [52463] by barraclough@apple.com

https://bugs.webkit.org/show_bug.cgi?id=32831
Replace UString::Rep implementation, following introduction of ropes to JSC.

Reviewed by Darin Adler.

JavaScriptCore:

  • Remove redundant overcapacity mechanisms.
  • Reduce memory cost of Rep's.
  • Add an inline storage mechanism akin to that in WebCore's StringImpl.

~1% Sunspider progression.

(JSC::JSString::resolveRope):

  • runtime/SmallStrings.cpp:

(JSC::SmallStringsStorage::SmallStringsStorage):

  • runtime/UString.cpp:

(JSC::initializeUString):
(JSC::createRep):
(JSC::UString::createFromUTF8):
(JSC::UString::createUninitialized):
(JSC::UString::spliceSubstringsWithSeparators):
(JSC::UString::replaceRange):
(JSC::UString::ascii):
(JSC::UString::operator=):
(JSC::UString::toStrictUInt32):
(JSC::equal):

  • runtime/UString.h:

(JSC::UString::isEmpty):
(JSC::UString::cost):
(JSC::makeString):

  • runtime/UStringImpl.cpp: Added.

(JSC::UStringImpl::baseSharedBuffer):
(JSC::UStringImpl::sharedBuffer):
(JSC::UStringImpl::destroy):
(JSC::UStringImpl::computeHash):

  • runtime/UStringImpl.h: Added.

(JSC::UntypedPtrAndBitfield::UntypedPtrAndBitfield):
(JSC::UntypedPtrAndBitfield::asPtr):
(JSC::UntypedPtrAndBitfield::operator&=):
(JSC::UntypedPtrAndBitfield::operator|=):
(JSC::UntypedPtrAndBitfield::operator&):
(JSC::UStringImpl::create):
(JSC::UStringImpl::createCopying):
(JSC::UStringImpl::createUninitialized):
(JSC::UStringImpl::data):
(JSC::UStringImpl::size):
(JSC::UStringImpl::cost):
(JSC::UStringImpl::hash):
(JSC::UStringImpl::computedHash):
(JSC::UStringImpl::setHash):
(JSC::UStringImpl::identifierTable):
(JSC::UStringImpl::setIdentifierTable):
(JSC::UStringImpl::ref):
(JSC::UStringImpl::deref):
(JSC::UStringImpl::allocChars):
(JSC::UStringImpl::copyChars):
(JSC::UStringImpl::computeHash):
(JSC::UStringImpl::null):
(JSC::UStringImpl::empty):
(JSC::UStringImpl::checkConsistency):
(JSC::UStringImpl::):
(JSC::UStringImpl::UStringImpl):
(JSC::UStringImpl::operator new):
(JSC::UStringImpl::bufferOwnerString):
(JSC::UStringImpl::bufferOwnership):
(JSC::UStringImpl::isStatic):

JavaScriptGlue:

  • ForwardingHeaders/wtf/PossiblyNull.h: Added.
    • add forwarding header.

WebCore:

  • ForwardingHeaders/runtime/UStringImpl.h: Added.
    • add forwarding header.
  • platform/text/StringImpl.cpp:

(WebCore::StringImpl::ustring):

  • order of arguments to UString::Rep constructor for shared strings changed.
15:50 Changeset [52462] by eric@webkit.org

2009-12-21 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

Upstream a bunch of platform-specific Chromium plugin tests.
https://bugs.webkit.org/show_bug.cgi?id=32751

  • platform/chromium/plugins/call-as-function-expected.txt: Added.
  • platform/chromium/plugins/call-as-function.html: Added.
  • platform/chromium/plugins/get-url-with-iframe-target-no-crash-expected.txt: Added.
  • platform/chromium/plugins/get-url-with-iframe-target-no-crash.html: Added.
  • platform/chromium/plugins/multiple-plugins-expected.txt: Added.
  • platform/chromium/plugins/multiple-plugins.html: Added.
  • platform/chromium/plugins/nested-plugin-objects-expected.txt: Added.
  • platform/chromium/plugins/nested-plugin-objects.html: Added.
  • platform/chromium/plugins/refcount-leaks-expected.txt: Added.
  • platform/chromium/plugins/refcount-leaks.html: Added.
  • platform/chromium/plugins/return-npobject-expected.txt: Added.
  • platform/chromium/plugins/return-npobject.html: Added.
  • platform/chromium/plugins/script-object-invoke-expected.txt: Added.
  • platform/chromium/plugins/script-object-invoke.html: Added.
15:42 Changeset [52461] by eric@webkit.org

2009-12-21 Dirk Pranke <dpranke@chromium.org>

Reviewed by Darin Adler.

Upstream a test to ensure we handle variations on "javascript:" URL
correctly.

https://bugs.webkit.org/show_bug.cgi?id=32740

  • fast/dom/xss-DENIED-javascript-variations-expected.txt: Added.
  • fast/dom/xss-DENIED-javascript-variations.html: Added.
15:39 Changeset [52460] by mrowe@apple.com

Update WebKitSystemInterface.

Reviewed by Samuel Weinig.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
15:15 Changeset [52459] by japhet@chromium.org

2009-12-18 Nate Chapin <japhet@chromium.org>

Reviewed by Adam barth.

Generate V8 bindings non-constructor callback declarations
in CodeGeneratorV8.pm instead of manually declaring them in
V8CustomBinding.h.

https://bugs.webkit.org/show_bug.cgi?id=32638

15:00 Changeset [52458] by japhet@chromium.org

2009-12-21 Nate Chapin <japhet@chromium.org>

Unreviewed, build fix.

Cleared instead of deleted some layout test files, making them fail. Delete them for real.

  • http/tests/navigation/image-load-in-beforeunload-handler-expected.txt: Removed.
  • http/tests/navigation/image-load-in-beforeunload-handler.html: Removed.
  • http/tests/navigation/image-load-in-unload-handler-expected.txt: Removed.
  • http/tests/navigation/image-load-in-unload-handler.html: Removed.
  • http/tests/navigation/resources/wait-then-notify-done.html: Removed.
14:52 Changeset [52457] by darin@apple.com
  • Scripts/do-webcore-rename: Did a rename, so checking in the

version of the script I used.

14:39 Changeset [52456] by japhet@chromium.org

2009-12-21 Nate Chapin <japhet@chromium.org>

Rubber-stamped by Darin Adler.

Revert r52446 due to crashiness.

https://bugs.webkit.org/show_bug.cgi?id=32839

  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::loadRequest):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::loadURL): (WebCore::FrameLoader::loadWithDocumentLoader): (WebCore::FrameLoader::stopAllLoaders): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::pageHidden):
  • loader/FrameLoader.h: (WebCore::FrameLoader::suppressOpenerInNewFrame):
  • loader/Request.cpp: (WebCore::Request::Request): (WebCore::Request::~Request):
  • loader/Request.h:
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
  • loader/SubresourceLoader.h:
  • loader/loader.cpp: (WebCore::Loader::load): (WebCore::Loader::cancelRequests): (WebCore::Loader::Host::servePendingRequests): (WebCore::Loader::Host::cancelPendingRequests): (WebCore::Loader::Host::cancelRequests):
14:12 Changeset [52455] by eric@webkit.org

2009-12-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Update status-bubble to show all the queues
https://bugs.webkit.org/show_bug.cgi?id=32838

Also, move statusbubble over to use memcache.

  • QueueStatusServer/handlers/statusbubble.py:
  • QueueStatusServer/templates/statusbubble.html:
13:26 Changeset [52454] by pkasting@chromium.org

Add support for V8 Date binding.
https://bugs.webkit.org/show_bug.cgi?id=32699

Patch by Kent Tamura <tkent@chromium.org> on 2009-12-19
Reviewed by Adam Barth.

This implements the same behavior as the recent change of
CodeGeneratorJS.pm and JSDOMBinding.cpp.

  • bindings/scripts/CodeGeneratorV8.pm: Produce toWebCoreDate() or v8DateOrNull() for Date type.
  • bindings/v8/V8Binding.cpp:

(WebCore::toWebCoreDate):

Converts a JavaScript object to a double representing Date.

(WebCore::v8DateOrNull):

Converts a double representing Date to a JavaScript Date object or null.

  • bindings/v8/V8Binding.h: Declare toWebCoreDate() and v8DateOrNull().
  • html/HTMLInputElement.idl: Delete V8_BINGIN exclusion for valueAsDate.
12:19 Changeset [52453] by eric@webkit.org

2009-12-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Delete the boring "Empty queue" status messages in QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=32818

  • QueueStatusServer/app.yaml:
  • QueueStatusServer/cron.yaml:
  • QueueStatusServer/handlers/gc.py:
  • QueueStatusServer/main.py:
12:18 Changeset [52452] by hausmann@webkit.org

Doc: Minor fixes to language.

Patch by David Boddie <dboddie@trolltech.com> on 2009-12-21
Reviewed by Simon Hausmann.

  • Api/qwebpage.cpp:
12:15 Changeset [52451] by darin@apple.com

Renamed m_sel to m_selection. Used do-webcore-rename.

Reviewed by Mark Rowe.

  • editing/SelectionController.cpp:

(WebCore::SelectionController::setSelection):
(WebCore::SelectionController::nodeWillBeRemoved):
(WebCore::SelectionController::willBeModified):
(WebCore::SelectionController::directionOfEnclosingBlock):
(WebCore::SelectionController::modifyExtendingRight):
(WebCore::SelectionController::modifyExtendingForward):
(WebCore::SelectionController::modifyMovingRight):
(WebCore::SelectionController::modifyMovingForward):
(WebCore::SelectionController::modifyExtendingLeft):
(WebCore::SelectionController::modifyExtendingBackward):
(WebCore::SelectionController::modifyMovingLeft):
(WebCore::SelectionController::modifyMovingBackward):
(WebCore::SelectionController::modify):
(WebCore::SelectionController::expandUsingGranularity):
(WebCore::SelectionController::xPosForVerticalArrowNavigation):
(WebCore::SelectionController::setBase):
(WebCore::SelectionController::setExtent):
(WebCore::SelectionController::layout):
(WebCore::SelectionController::caretRenderer):
(WebCore::SelectionController::invalidateCaretRect):
(WebCore::SelectionController::paintCaret):
(WebCore::SelectionController::debugRenderer):
(WebCore::SelectionController::contains):
(WebCore::SelectionController::selectAll):
(WebCore::SelectionController::formatForDebugger):
(WebCore::SelectionController::showTreeForThis):

  • editing/SelectionController.h:
  • editing/gtk/SelectionControllerGtk.cpp:

(WebCore::SelectionController::notifyAccessibilityForSelectionChange):

  • editing/mac/SelectionControllerMac.mm:

(WebCore::SelectionController::notifyAccessibilityForSelectionChange):
Let the script do its thing. Made sure no tests broke.

12:11 Changeset [52450] by eric@webkit.org

2009-12-21 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Darin Adler.

Inconsistent use of counterName and identifier in CSS counter code and loss of information about the counter type.
https://bugs.webkit.org/show_bug.cgi?id=31814

No new tests because there are no functional changes in this patch.

  • rendering/CounterNode.cpp: (WebCore::CounterNode::CounterNode): (WebCore::CounterNode::computeCountInParent): (WebCore::showTreeAndMark):
  • rendering/RenderCounter.cpp: (WebCore::planCounter): (WebCore::findPlaceForCounter): (WebCore::makeCounterNode): (WebCore::RenderCounter::originalText): Changed to use identifier instead of counterName and actsAsReset or hasResetType, as appropriate instead of isReset.
  • rendering/CounterNode.h: (WebCore::CounterNode::actsAsReset): (WebCore::CounterNode::hasResetType):
12:00 Changeset [52449] by krit@webkit.org

2009-12-21 Dirk Schulze <krit@webkit.org>

Reviewed by Darin Adler and Nikolas Zimmermann.

Speed-up SVG Masking
https://bugs.webkit.org/show_bug.cgi?id=32738

This patch makes SVG Masking faster. The luminance calculaton of the ImageBuffer,
that is created by pixel manipulation, got optimized. The ImageBuffer and it's
luminance is created once now, not on every call of applyMask.
The size of the intermediate ImageBuffer depends on the visible area now and is
clipped by the mask rect.


The patch doesn't change functionality so no new tests needed.
The new ImageBuffer handling in Mask causes two updates of test results. The pixel
tests and LayoutTests pass, but the checksum doesn't match.

  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
  • svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::applyMask):

2009-12-21 Dirk Schulze <krit@webkit.org>

Reviewed by Darin Adler and Nikolas Zimmermann.

Speed-up SVG Masking
https://bugs.webkit.org/show_bug.cgi?id=32738

Update pixel test results for two SVG masking operations. They don't fail
and there is no noticable difference between the old and new results. But
Masking uses smaller ImageBuffers now and that changed the checksum.

  • platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/mac/svg/batik/masking/maskRegions-expected.checksum:
  • platform/mac/svg/batik/masking/maskRegions-expected.png:
10:58 Changeset [52448] by eric@webkit.org

2009-12-21 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

Test that dragging an SVG as <img> doesn't crash the browser.
Note that this only works in debug mode as it's a failing assert.

https://bugs.webkit.org/show_bug.cgi?id=32511

  • fast/images/drag-svg-as-image.html: Added.
  • platform/qt/Skipped: fast/images/drag-svg-as-image.html added.

2009-12-21 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

Fix assertion failure when dragging an SVG image.
https://bugs.webkit.org/show_bug.cgi?id=32511

Test: fast/images/drag-svg-as-image.html

  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::filenameExtension): Return "svg"
  • svg/graphics/SVGImage.h:
09:58 Changeset [52447] by philn@webkit.org

Reviewed by Xan Lopez.

[GTK] G_OBJECT() cast is not necessary for signals connection and properties access
https://bugs.webkit.org/show_bug.cgi?id=32661

Removed useless calls to the G_OBJECT() macro and replaced NULL
occurences with a SENTINEL macro.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::hasVideo): (WebCore::MediaPlayerPrivate::hasAudio): (WebCore::MediaPlayerPrivate::setVolume): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
09:51 UsingGitWithWebKit edited by aroben@apple.com
Explain why one might want to "track the Subversion repository" (diff)
08:55 Changeset [52446] by japhet@chromium.org

2009-12-21 Nate Chapin <japhet@chromium.org>

Reviewed by Darin Adler.

If an image load is started during an unload or beforeunload event, run it
asynchronously (and allow it to outlive its page) so navigation can continue
while the load completes.

https://bugs.webkit.org/show_bug.cgi?id=30457

Tests: http/tests/navigation/image-load-in-beforeunload-handler.html

http/tests/navigation/image-load-in-unload-handler.html

  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::loadRequest):
  • loader/FrameLoader.cpp: Rename m_unloadEventBeingDispatched to m_isDispatchingUnloadEvent. (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::loadURL): (WebCore::FrameLoader::loadWithDocumentLoader): (WebCore::FrameLoader::stopAllLoaders): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Set m_isDispatchingBeforeUnloadEvent. (WebCore::FrameLoader::pageHidden):
  • loader/FrameLoader.h: (WebCore::FrameLoader::isDispatchingUnloadFamilyEvent): Added.
  • loader/Request.cpp: (WebCore::Request::Request): Add OutlivePagePolicy to constructor parameters
  • loader/Request.h: (WebCore::): Add OutlivePagePolicy enum. (WebCore::Request::shouldOutlivePage): Added. (WebCore::Request::frame): Added.
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): Change one of the security checks to an outlive page check.
  • loader/SubresourceLoader.h:
  • loader/loader.cpp: (WebCore::Loader::load): Add OutlivePagePolicy to Request constructor call,

ensure requests that should outlive page are done asynchronously.

(WebCore::Loader::cancelRequests): Remove ending ASSERT since it will now be hard to predict how

many requests might possibly outlive a cancel in every case.

(WebCore::Loader::Host::servePendingRequests): Use the correct frame in the case of a request outliving its page.
(WebCore::Loader::Host::cancelPendingRequests): Ensure we don't cancel request that should outlive their page.
(WebCore::Loader::Host::cancelRequests): Ensure we don't cancel request that should outlive their page.

08:34 Changeset [52445] by philn@webkit.org

Rubber-stamped by Xan Lopez.

  • platform/gtk/Skipped: Unskip test fixed by patch from Bug 24001.
07:06 Changeset [52444] by vestbo@webkit.org

[Qt] Clean up the WebKit layer unit-tests

Reviewed by Simon Hausmann.

  • Use tests.pri for common options
  • Standardize file naming
  • Move all resources to 'resources' subdir
  • Standardize how TESTS_SOURCE_DIR is used
  • Get rid of UID3 for symbian (autogenerated)
  • Don't build app bundles on Mac OS X
  • tests/benchmarks/loading/loading.pro: Added.
  • tests/benchmarks/loading/tst_loading.pro: Removed.
  • tests/benchmarks/painting/painting.pro: Added.
  • tests/benchmarks/painting/tst_painting.pro: Removed.
  • tests/qgraphicswebview/qgraphicswebview.pro:
  • tests/qwebelement/qwebelement.pro:
  • tests/qwebelement/qwebelement.qrc: Removed.
  • tests/qwebelement/resources/image.png: Renamed from WebKit/qt/tests/qwebelement/image.png.
  • tests/qwebelement/resources/style.css: Renamed from WebKit/qt/tests/qwebelement/style.css.
  • tests/qwebelement/resources/style2.css: Renamed from WebKit/qt/tests/qwebelement/style2.css.
  • tests/qwebelement/tst_qwebelement.qrc: Added.
  • tests/qwebframe/qwebframe.pro:
  • tests/qwebframe/qwebframe.qrc: Removed.
  • tests/qwebframe/resources/image.png: Renamed from WebKit/qt/tests/qwebframe/image.png.
  • tests/qwebframe/resources/style.css: Renamed from WebKit/qt/tests/qwebframe/style.css.
  • tests/qwebframe/resources/test1.html: Renamed from WebKit/qt/tests/qwebframe/test1.html.
  • tests/qwebframe/resources/test2.html: Renamed from WebKit/qt/tests/qwebframe/test2.html.
  • tests/qwebframe/resources/testiframe.html: Renamed from WebKit/qt/tests/qwebframe/testiframe.html.
  • tests/qwebframe/resources/testiframe2.html: Renamed from WebKit/qt/tests/qwebframe/testiframe2.html.
  • tests/qwebframe/tst_qwebframe.cpp:
  • tests/qwebframe/tst_qwebframe.qrc: Added.
  • tests/qwebhistory/qwebhistory.pro:
  • tests/qwebhistory/resources/page1.html: Renamed from WebKit/qt/tests/qwebhistory/data/page1.html.
  • tests/qwebhistory/resources/page2.html: Renamed from WebKit/qt/tests/qwebhistory/data/page2.html.
  • tests/qwebhistory/resources/page3.html: Renamed from WebKit/qt/tests/qwebhistory/data/page3.html.
  • tests/qwebhistory/resources/page4.html: Renamed from WebKit/qt/tests/qwebhistory/data/page4.html.
  • tests/qwebhistory/resources/page5.html: Renamed from WebKit/qt/tests/qwebhistory/data/page5.html.
  • tests/qwebhistory/resources/page6.html: Renamed from WebKit/qt/tests/qwebhistory/data/page6.html.
  • tests/qwebhistory/tst_qwebhistory.cpp:

(tst_QWebHistory::):

  • tests/qwebhistory/tst_qwebhistory.qrc:
  • tests/qwebhistoryinterface/qwebhistoryinterface.pro:
  • tests/qwebinspector/qwebinspector.pro:
  • tests/qwebpage/qwebpage.pro:
  • tests/qwebpage/resources/frame_a.html: Renamed from WebKit/qt/tests/qwebpage/frametest/frame_a.html.
  • tests/qwebpage/resources/iframe.html: Renamed from WebKit/qt/tests/qwebpage/frametest/iframe.html.
  • tests/qwebpage/resources/iframe2.html: Renamed from WebKit/qt/tests/qwebpage/frametest/iframe2.html.
  • tests/qwebpage/resources/iframe3.html: Renamed from WebKit/qt/tests/qwebpage/frametest/iframe3.html.
  • tests/qwebpage/resources/index.html: Renamed from WebKit/qt/tests/qwebpage/frametest/index.html.
  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::backActionUpdate):
(tst_QWebPage::frameAt):
(tst_QWebPage::errorPageExtensionInFrameset):
(tst_QWebPage::screenshot):

  • tests/qwebpage/tst_qwebpage.qrc:
  • tests/qwebplugindatabase/qwebplugindatabase.pro:
  • tests/qwebview/qwebview.pro:
  • tests/qwebview/resources/frame_a.html: Renamed from WebKit/qt/tests/qwebview/data/frame_a.html.
  • tests/qwebview/resources/index.html: Renamed from WebKit/qt/tests/qwebview/data/index.html.
  • tests/qwebview/tst_qwebview.cpp:

(tst_QWebView::reusePage):
(tst_QWebView::crashTests):

  • tests/qwebview/tst_qwebview.qrc:
  • tests/resources/image2.png: Renamed from WebKit/qt/tests/qwebframe/resources/image2.png.
  • tests/tests.pri: Added.
  • tests/tests.pro:
06:44 Changeset [52443] by aroben@apple.com

Fix non-ACCELERATED_COMPOSITING builds

  • WebPreferences.cpp:

(WebPreferences::acceleratedCompositingEnabled): Guard use of
WKCACFLayerRenderer with USE(ACCELERATED_COMPOSITING).

06:36 Changeset [52442] by aroben@apple.com

Add IWebPreferencesPrivate::[set]AcceleratedCompositingEnabled

Fixes <http://webkit.org/b/32745>.

Reviewed by Ada Chan.

  • Interfaces/IWebPreferencesPrivate.idl: Added

[set]AcceleratedCompositingEnabled.

  • Interfaces/WebKit.idl: Touched to force a build.
  • WebPreferenceKeysPrivate.h: Added

WebKitAcceleratedCompositingEnabledPreferenceKey.

  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings): Make accelerated
compositing be on by default.
(WebPreferences::setAcceleratedCompositingEnabled): Store the new
value.
(WebPreferences::acceleratedCompositingEnabled): If accelerated
compositing isn't available, return false. Otherwise, return the value
stored in preferences.

  • WebPreferences.h: Added [set]AcceleratedCompositingAvailable.
  • WebView.cpp:

(WebView::notifyPreferencesChanged): Just pass the value from
WebPreferences on down.

06:36 Changeset [52441] by aroben@apple.com

Fix Windows build warnings

  • WebCore.vcproj/WebCore.vcproj: Exclude SVG files from the build that

are compiled via SVGAllInOne.cpp.

03:10 Changeset [52440] by pfeldman@chromium.org

2009-12-20 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Can’t copy outer html of selected node.
Also adds "Copy as HTML" context menu item.

https://bugs.webkit.org/show_bug.cgi?id=32802

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
  • inspector/front-end/inspector.js: (WebInspector.documentCanCopy):
03:00 Changeset [52439] by pfeldman@chromium.org

2009-12-20 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Eric Seidel.

Web Inspector: extract syntax highlighters into separate files.

https://bugs.webkit.org/show_bug.cgi?id=32803

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/CSSSourceSyntaxHighlighter.js: Added. (WebInspector.CSSSourceSyntaxHighlighter):
  • inspector/front-end/JavaScriptSourceSyntaxHighlighter.js: Added. (WebInspector.JavaScriptSourceSyntaxHighlighter): (WebInspector.JavaScriptSourceSyntaxHighlighter.):
  • inspector/front-end/SourceFrame.js:
  • inspector/front-end/SourceSyntaxHighlighter.js: Added. (WebInspector.SourceSyntaxHighlighter): (WebInspector.SourceSyntaxHighlighter.prototype.createSpan): (WebInspector.SourceSyntaxHighlighter.prototype.process.processChunk): (WebInspector.SourceSyntaxHighlighter.prototype.process.moveToNextLine): (WebInspector.SourceSyntaxHighlighter.prototype.process): (WebInspector.SourceSyntaxHighlighter.prototype.lex): (WebInspector.SourceSyntaxHighlighter.prototype.appendNonToken): (WebInspector.SourceSyntaxHighlighter.prototype.syntaxHighlightNode):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
01:48 Changeset [52438] by jchaffraix@webkit.org

defersLoading is disabled in current libcURL.
https://bugs.webkit.org/show_bug.cgi?id=32707

Patch by Julien Chaffraix <jchaffraix@pleyo.com> on 2009-12-18
Reviewed by Darin Adler.

Basically this change reverts r49577 that was totally wrong.
According to curlver.h, LIBCURL_VERSION_NUM is a
"6-digit (24 bits) hexadecimal number".

The check should be against 0x071200 (7.18) as it was originally the case.

  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::ResourceHandleManager::initializeHandle): Use the right check.

  • platform/network/curl/ResourceHandleCurl.cpp:

(WebCore::ResourceHandle::setDefersLoading): Ditto. Also removed a print
to use a LOG_ERROR instead.

01:07 Changeset [52437] by eric@webkit.org

2009-12-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Exception on queue status server
https://bugs.webkit.org/show_bug.cgi?id=32812

Turns out we need to pass the id to the filter.

  • QueueStatusServer/filters/webkit_extras.py:
  • QueueStatusServer/templates/patch.html:
  • QueueStatusServer/templates/recentstatus.html:

12/20/09:

23:29 Changeset [52436] by hamaji@chromium.org

2009-12-20 Chris Jerdonek <chris.jerdonek@gmail.com>

Reviewed by Eric Seidel.

Created "style" folder for code supporting check-webkit-style.

  • Scripts/modules/style: Added.
23:24 Changeset [52435] by eric@webkit.org

2009-12-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

REGRESSION: error when running commit-queue
https://bugs.webkit.org/show_bug.cgi?id=32806

Fix typo and add test!

  • Scripts/modules/bugzilla.py:
  • Scripts/modules/bugzilla_unittest.py:
22:20 Changeset [52434] by tkent@chromium.org

2009-12-20 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

A test for Date binding.
https://bugs.webkit.org/show_bug.cgi?id=32698

  • fast/forms/input-valueasdate-expected.txt: Added.
  • fast/forms/input-valueasdate.html: Added.
  • fast/forms/script-tests/input-valueasdate.js: Added.

2009-12-20 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Add support for JavaScriptCore Date binding.
https://bugs.webkit.org/show_bug.cgi?id=32698

This is needed for HTMLInputElement::valueAsDate and
HTMLTimeElement::valueAsDate.

A Date instance is mapped to a double value in C++.

  • If null or undefined is set to a JavaScript property, C++ setter function receives NaN.
  • If a getter C++ function returns NaN or infinity, a JavaScript property returns null.

Test: fast/forms/input-valueasdate.html

  • bindings/js/JSDOMBinding.cpp: (WebCore::jsDateOrNull): Implement the above. (WebCore::valueToDate): ditto.
  • bindings/js/JSDOMBinding.h: Declare them.
  • bindings/scripts/CodeGeneratorJS.pm: Produce jsDateOrNull() or valueToDate() for Date type.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueAsDate): Temporal implementation. (WebCore::HTMLInputElement::setValueAsDate): ditto.
  • html/HTMLInputElement.h:
  • html/HTMLInputElement.idl: Declare valueAsDate.
22:16 Changeset [52433] by eric@webkit.org

2009-12-20 Chris Jerdonek <chris.jerdonek@gmail.com>

Reviewed by Darin Adler.

Removed outdated contact information from bug life cycle page.

https://bugs.webkit.org/show_bug.cgi?id=32494

  • quality/lifecycle.html:
20:57 Changeset [52432] by eric@webkit.org

2009-12-20 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Introduce the followings:

  • ::-webkit-inner-spin-button pseudo CSS selector
  • ::-webkit-outer-spin-button pseudo CSS selector
  • new appearance type: inner-spin-button
  • new appearance type: outer-spin-button

They're going to be used for <input type=number> UI.
https://bugs.webkit.org/show_bug.cgi?id=31821

Inner-spin-button will be used for Windows, and outer-spin-button
will be used for Mac. A spin-button will represent a pair of an
increasing button part and a decreasing button part. SpinUpState,
which is defined in ThemeTypes.h, will be used to distinguish
these two parts.

The outer-spin-button implementation will use NSStepperCell.
NSStepperCell represents the pair of the parts and we can't draw them
independently. So a spin-button also represents the pair of the parts.

This change has no tests. The following changes with tests will cover.

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
  • css/CSSValueKeywords.in:
  • css/html.css:
  • platform/ThemeTypes.h: (WebCore::ControlState): Add SpinUpState. (WebCore::ControlPart): Add InnerSpinButtonPart and OuterSpinButtonPart.
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::paint): (WebCore::RenderTheme::adjustInnerSpinButtonStyle): Add an empty implementation. (WebCore::RenderTheme::adjustOuterSpinButtonStyle): Add an empty implementation.
  • rendering/RenderTheme.h: (WebCore::RenderTheme::paintInnerSpinButton): Add an empty implementation. (WebCore::RenderTheme::paintOuterSpinButton): Add an empty implementation.
  • rendering/style/RenderStyleConstants.h: (WebCore::PseudoId): Add INNER_SPIN_BUTTON and OUTER_SPIN_BUTTON.
19:17 Changeset [52431] by eric@webkit.org

2009-12-20 Nayan Kumar K <nayankk@gmail.com>

Reviewed by Darin Adler.

Fix for compilation errors in WML module, due to the changeset #52314.
https://bugs.webkit.org/show_bug.cgi?id=32786

No new tests, this is compilation error fix.

  • wml/WMLDocument.cpp:
  • wml/WMLPageState.cpp:
  • wml/WMLPageState.h:
18:57 Changeset [52430] by abarth@webkit.org

2009-12-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Optimize status updates for new dashboard
https://bugs.webkit.org/show_bug.cgi?id=32797

This patch makes the queues slightly more chatty with the web service.
Also, this patch introduces some testing for the queues!

  • Scripts/modules/commands/early_warning_system.py:
  • Scripts/modules/commands/early_warning_system_unittest.py: Added.
  • Scripts/modules/commands/queues.py:
  • Scripts/modules/commands/queues_unittest.py:
  • Scripts/modules/commands/queuestest.py: Added.
  • Scripts/modules/mock_bugzillatool.py:
  • Scripts/modules/patchcollection.py:
  • Scripts/modules/queueengine.py:
  • Scripts/run-webkit-unittests:
18:42 Changeset [52429] by eric@webkit.org

2009-12-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Prepare QueueStatusServer for new status messages
https://bugs.webkit.org/show_bug.cgi?id=32805

  • QueueStatusServer/handlers/recentstatus.py:
  • QueueStatusServer/index.html: Removed.
  • QueueStatusServer/model/attachment.py:
  • QueueStatusServer/model/queues.py: Added.
  • QueueStatusServer/templates/recentstatus.html: Added.
15:51 Changeset [52428] by xan@webkit.org

2009-12-20 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Unset the adjustments in our FrameView when detaching from
parent. Fixes some crashers when transitioning to a new page from
a scrolled page.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::detachedFromParent2):
14:00 QtWebKitAPI edited by hausmann@webkit.org
(diff)
12:50 Changeset [52427] by mitz@apple.com

<rdar://problem/7487689> REGRESSION (r52203): Inspector console uses
Monaco on Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=32775

Reviewed by Mark Rowe.

  • inspector/front-end/inspector.css: Use the default monospace family

and size.

12:07 Changeset [52426] by kov@webkit.org

Reviewed by Xan Lopez.

Remove emission of signal that does not exist.

  • WebCoreSupport/InspectorClientGtk.cpp:

(WebKit::InspectorClient::inspectorDestroyed):
(WebKit::InspectorClient::webViewDestroyed):

11:31 Changeset [52425] by kov@webkit.org

Reviewed by Xan Lopez.

Provides a new API to copy WebKitWebHistoryItem objects.

  • webkit/webkitwebhistoryitem.cpp:

(webkit_web_history_item_copy):

  • webkit/webkitwebhistoryitem.h:
10:46 Changeset [52424] by xan@webkit.org

2009-12-20 Xan Lopez <xlopez@igalia.com>

Rubber-stamped by Gustavo Noronha.

Disable the page cache by default since:

  • It was previously off by default.
  • There are still some issues when enabling it.
  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init):
10:22 Changeset [52423] by eric@webkit.org

2009-12-20 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Adam Barth.

[check-webkit-style] static_cast is not misnamed!
https://bugs.webkit.org/show_bug.cgi?id=32796

  • Scripts/modules/cpp_style.py:
  • Scripts/modules/cpp_style_unittest.py:
10:07 Changeset [52422] by kov@webkit.org

2009-12-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Reviewed by Xan Lopez.

Make sure we get the URI that is being loaded when updating
WebKitWebFrame's knowledge of it. This was causing problems now
that page cache is enabled.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidCommitLoad):
  • tests/testloading.c: (load_goback_status_changed_cb): (load_wentback_status_changed_cb): (test_loading_goback): (main):
09:39 Changeset [52421] by eric@webkit.org

2009-12-20 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Xan Lopez.

[GTK] Remove more GTK+ and GLib headers from WebCore
https://bugs.webkit.org/show_bug.cgi?id=32795

Remove most GTK+ and GLib includes from WebCore headers.

  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
  • platform/gtk/PasteboardHelper.h:
  • platform/gtk/RenderThemeGtk.cpp:
  • platform/gtk/RenderThemeGtk.h:
  • platform/gtk/ScrollbarGtk.cpp:
  • platform/gtk/ScrollbarThemeGtk.h:
  • platform/gtk/gtk2drawing.c:
  • platform/gtk/gtkdrawing.h:
09:06 Changeset [52420] by kevino@webkit.org

[wx] build fixes after recent changes.

08:26 Changeset [52419] by eric@webkit.org

2009-12-20 Alejandro G. Castro <alex@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Failing test platform/gtk/editing/pasteboard/middle-button-paste.html
https://bugs.webkit.org/show_bug.cgi?id=32788

Avoid using fixed values when moving mouse.

  • platform/gtk/editing/pasteboard/middle-button-paste-expected.txt:
  • platform/gtk/editing/pasteboard/middle-button-paste.html:

2009-12-20 Alejandro G. Castro <alex@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Failing test platform/gtk/editing/pasteboard/middle-button-paste.html
https://bugs.webkit.org/show_bug.cgi?id=32788

Do not increase the click count if we are using a different button.

  • DumpRenderTree/gtk/EventSender.cpp:
07:53 Changeset [52418] by eric@webkit.org

2009-12-20 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

[GTK] Cache control APIs
https://bugs.webkit.org/show_bug.cgi?id=24001

Original patch by Bobby Powers <bobby@laptop.org>

Added new API to specify cache models for GTK port.

  • webkit/webkitprivate.cpp: (webkit_init): set a default cache model.
  • webkit/webkitwebview.cpp:
  • webkit/webkitwebview.h: (webkit_set_cache_model): Added function. (webkit_get_cache_model): Added function.
07:45 Changeset [52417] by kov@webkit.org

Reviewed by Xan Lopez.

Hopefully fix the assertion we are hitting by not forcing updating
the state of scrollbars when setting the adjustments. This was
leading to a premature layout.

fast/dom/open-and-close-by-DOM.html
fast/dom/Window/closure-access-after-navigation-window.html
fast/harness/use-page-cache.html

  • platform/gtk/ScrollViewGtk.cpp:

(WebCore::ScrollView::setGtkAdjustments):

04:58 Changeset [52416] by xan@webkit.org

2009-12-20 Xan Lopez <xlopez@igalia.com>

Revert the previous patch, it introduces some failures in the
bots.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::committedLoad): (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
04:41 Changeset [52415] by pfeldman@chromium.org

2009-12-20 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Darin Adler.

Web Inspector: Constrain the number of messages the inspector shows.

https://bugs.webkit.org/show_bug.cgi?id=20919

  • English.lproj/localizedStrings.js:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::addConsoleMessage): (WebCore::InspectorController::clearConsoleMessages): (WebCore::InspectorController::populateScriptObjects):
  • inspector/InspectorController.h:
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::updateConsoleMessageExpiredCount):
  • inspector/InspectorFrontend.h:
  • inspector/front-end/inspector.js: (WebInspector.updateConsoleMessageExpiredCount):
04:27 Changeset [52414] by xan@webkit.org

2009-12-20 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] crash when loading new page
https://bugs.webkit.org/show_bug.cgi?id=32752

Wait until the document is attached to adjust our alignments,
since we need to make sure the FrameView in the document content
render object matches the newly created FrameView for the new
page, otherwise we'll try to relayout the wrong view.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::committedLoad): (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
04:18 Changeset [52413] by eric@webkit.org

2009-12-20 Alejandro G. Castro <alex@igalia.com>

Reviewed by Gustavo Noronha Silva.

  • platform/gtk/editing/pasteboard/middle-button-paste-expected.txt:
  • platform/gtk/editing/pasteboard/middle-button-paste.html:
04:02 Changeset [52412] by kov@webkit.org

Reviewed by Xan Lopez.

Create a new WebKitDataSource object when attaching to a frame, if
one does not exist. This may happen when we are fetching data from
the page cache.

  • WebCoreSupport/DocumentLoaderGtk.cpp:

(WebKit::DocumentLoader::attachToFrame):
(WebKit::DocumentLoader::unrefDataSource):

02:46 Changeset [52411] by kov@webkit.org

Rubber-stamped by Xan Lopez.

Make sure the text encoding machinery is initialized from the main
frame, before opening the icon database.

  • webkit/webkitprivate.cpp:

(webkit_init):

02:27 Changeset [52410] by eric@webkit.org

2009-12-20 Dirk Pranke <dpranke@chromium.org>

Reviewed by Darin Adler.

Upstreaming two plugin tests from chromium.org.
https://bugs.webkit.org/show_bug.cgi?id=32750

  • plugins/get-file-url-expected.txt: Added.
  • plugins/get-file-url.html: Added.
  • plugins/get-url-with-iframe-target-expected.txt: Added.
  • plugins/get-url-with-iframe-target.html: Added.
  • plugins/resources/get-file-url-subframe.html: Added.
02:18 Changeset [52409] by eric@webkit.org

2009-12-20 Dirk Pranke <dpranke@chromium.org>

Reviewed by Darin Adler.

Upstream a test from chromium.org that verifies that calling
document.clear() from an external script doesn't crash the browser.
https://bugs.webkit.org/show_bug.cgi?id=32743

  • fast/dom/document-clear-expected.txt: Added.
  • fast/dom/document-clear.html: Added.
  • fast/dom/resources/document-clear.js: Added.
02:10 Changeset [52408] by eric@webkit.org

2009-12-20 Dirk Pranke <dpranke@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=32735

Upstream a test from chromium.org - ensure that creating a
new Image is actually creating an HTML image element, regardless
of the doctype.

  • svg/custom/new-image-is-html-element-expected.txt: Added.
  • svg/custom/new-image-is-html-element.svg: Added.
02:01 Changeset [52407] by eric@webkit.org

2009-12-20 Dirk Pranke <dpranke@fila-macpro.mtv.corp.google.com>

Reviewed by Darin Adler.

upstream test from chromium.org - this tests simulating italic
on glyphs that don't have an italic version.

https://bugs.webkit.org/show_bug.cgi?id=32693

  • fast/text/fake-italic.html: Added.
  • platform/mac/fast/text/fake-italic-expected.checksum: Added.
  • platform/mac/fast/text/fake-italic-expected.png: Added.
  • platform/mac/fast/text/fake-italic-expected.txt: Added.
01:52 Changeset [52406] by eric@webkit.org

2009-12-20 Andrei Popescu <andreip@google.com>

Reviewed by Adam Barth.

[Android] Android needs implementation of setCookies, cookies and cookiesEnabled functions.
https://bugs.webkit.org/show_bug.cgi?id=32559

Add implementation of the cookie functions.
Fix a crash caused by dereferencing a 0 MainResourceLoader pointer
in ResourceHandle::start().

No new tests, this is platform code.

  • platform/android/PlatformBridge.h:
  • platform/network/android/AuthenticationChallenge.h: Added.
  • platform/network/android/CookieJarAndroid.cpp: Added. (WebCore::setCookies): (WebCore::cookies): (WebCore::cookiesEnabled):
  • platform/network/android/ResourceHandleAndroid.cpp: (WebCore::ResourceHandle::start):
01:47 Changeset [52405] by abarth@webkit.org

2009-12-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[QueueStatusServer] Add a per-patch details page
https://bugs.webkit.org/show_bug.cgi?id=32784

This is a first cut at a per-patch details page. I'm sure we'll have
to iterate.

  • QueueStatusServer/filters/webkit_extras.py:
  • QueueStatusServer/handlers/patch.py: Added.
  • QueueStatusServer/index.yaml:
  • QueueStatusServer/main.py:
  • QueueStatusServer/model/attachment.py:
  • QueueStatusServer/stylesheets/dashboard.css:
  • QueueStatusServer/templates/dashboard.html:
  • QueueStatusServer/templates/patch.html: Added.
00:27 Changeset [52404] by abarth@webkit.org

2009-12-20 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Use memcache to make dashboard to fast
https://bugs.webkit.org/show_bug.cgi?id=32780

  • QueueStatusServer/app.yaml:
  • QueueStatusServer/handlers/dashboard.py:
  • QueueStatusServer/handlers/updatestatus.py:
  • QueueStatusServer/model/attachment.py: Added.

12/19/09:

23:48 Changeset [52403] by eric@webkit.org

2009-12-19 Eric Seidel <eric@webkit.org>

No review, rolling out r52395.
http://trac.webkit.org/changeset/52395

  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
  • svg/SVGMaskElement.h:
  • svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::applyMask):
  • svg/graphics/SVGResourceMasker.h:
23:36 Changeset [52402] by abarth@webkit.org

2009-12-19 Adam Barth <abarth@webkit.org>

No review, rolling out r52399.
http://trac.webkit.org/changeset/52399

  • websocket/tests/bad-sub-protocol-expected.txt:
  • websocket/tests/script-tests/url-parsing.js:
  • websocket/tests/url-parsing-expected.txt:

2009-12-19 Adam Barth <abarth@webkit.org>

No review, rolling out r52399.
http://trac.webkit.org/changeset/52399

  • websockets/WebSocket.cpp: (WebCore::WebSocket::connect):
23:22 Changeset [52401] by abarth@webkit.org

2009-12-19 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add a test for window.open and JavaScript URLs.

  • http/tests/security/xss-DENIED-window-open-javascript-url-expected.txt: Added.
  • http/tests/security/xss-DENIED-window-open-javascript-url.html: Added.

2009-12-19 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Added a missing "not".

Test: http/tests/security/xss-DENIED-window-open-javascript-url.html

  • bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::createWindow):
22:55 Changeset [52400] by bfulgham@webkit.org

Provide an example implementation for printing under Windows.
http://bugs.webkit.org/show_bug.cgi?id=32504.`

Reviewed by Adam Roben.

  • WinLauncher/PrintWebUIDelegate.cpp: Added.

(PrintWebUIDelegate::QueryInterface):
(PrintWebUIDelegate::AddRef):
(PrintWebUIDelegate::Release):
(PrintWebUIDelegate::webViewPrintingMarginRect):

  • WinLauncher/PrintWebUIDelegate.h: Added.

(PrintWebUIDelegate::PrintWebUIDelegate):
(PrintWebUIDelegate::createWebViewWithRequest):
(PrintWebUIDelegate::webViewShow):
(PrintWebUIDelegate::webViewClose):
(PrintWebUIDelegate::webViewFocus):
(PrintWebUIDelegate::webViewUnfocus):
(PrintWebUIDelegate::webViewFirstResponder):
(PrintWebUIDelegate::makeFirstResponder):
(PrintWebUIDelegate::setStatusText):
(PrintWebUIDelegate::webViewStatusText):
(PrintWebUIDelegate::webViewAreToolbarsVisible):
(PrintWebUIDelegate::setToolbarsVisible):
(PrintWebUIDelegate::webViewIsStatusBarVisible):
(PrintWebUIDelegate::setStatusBarVisible):
(PrintWebUIDelegate::webViewIsResizable):
(PrintWebUIDelegate::setResizable):
(PrintWebUIDelegate::setFrame):
(PrintWebUIDelegate::webViewFrame):
(PrintWebUIDelegate::setContentRect):
(PrintWebUIDelegate::webViewContentRect):
(PrintWebUIDelegate::runJavaScriptAlertPanelWithMessage):
(PrintWebUIDelegate::runJavaScriptConfirmPanelWithMessage):
(PrintWebUIDelegate::runJavaScriptTextInputPanelWithPrompt):
(PrintWebUIDelegate::runBeforeUnloadConfirmPanelWithMessage):
(PrintWebUIDelegate::runOpenPanelForFileButtonWithResultListener):
(PrintWebUIDelegate::mouseDidMoveOverElement):
(PrintWebUIDelegate::contextMenuItemsForElement):
(PrintWebUIDelegate::validateUserInterfaceItem):
(PrintWebUIDelegate::shouldPerformAction):
(PrintWebUIDelegate::dragDestinationActionMaskForDraggingInfo):
(PrintWebUIDelegate::willPerformDragDestinationAction):
(PrintWebUIDelegate::dragSourceActionMaskForPoint):
(PrintWebUIDelegate::willPerformDragSourceAction):
(PrintWebUIDelegate::contextMenuItemSelected):
(PrintWebUIDelegate::hasCustomMenuImplementation):
(PrintWebUIDelegate::trackCustomPopupMenu):
(PrintWebUIDelegate::measureCustomMenuItem):
(PrintWebUIDelegate::drawCustomMenuItem):
(PrintWebUIDelegate::addCustomMenuDrawingData):
(PrintWebUIDelegate::cleanUpCustomMenuDrawingData):
(PrintWebUIDelegate::canTakeFocus):
(PrintWebUIDelegate::takeFocus):
(PrintWebUIDelegate::registerUndoWithTarget):
(PrintWebUIDelegate::removeAllActionsWithTarget):
(PrintWebUIDelegate::setActionTitle):
(PrintWebUIDelegate::undo):
(PrintWebUIDelegate::redo):
(PrintWebUIDelegate::canUndo):
(PrintWebUIDelegate::canRedo):
(PrintWebUIDelegate::printFrame):
(PrintWebUIDelegate::ftpDirectoryTemplatePath):
(PrintWebUIDelegate::webViewHeaderHeight):
(PrintWebUIDelegate::webViewFooterHeight):
(PrintWebUIDelegate::drawHeaderInRect):
(PrintWebUIDelegate::drawFooterInRect):
(PrintWebUIDelegate::canRunModal):
(PrintWebUIDelegate::createModalDialog):
(PrintWebUIDelegate::runModal):
(PrintWebUIDelegate::isMenuBarVisible):
(PrintWebUIDelegate::setMenuBarVisible):
(PrintWebUIDelegate::runDatabaseSizeLimitPrompt):
(PrintWebUIDelegate::paintCustomScrollbar):
(PrintWebUIDelegate::paintCustomScrollCorner):

  • WinLauncher/WinLauncher.cpp: Add new UI delegate for print support.

(WinLauncherWebHost::updateAddressBar): check-webkit-style fixes.
(WinLauncherWebHost::QueryInterface): check-webkit-style fixes.
(WinLauncherWebHost::AddRef): check-webkit-style fixes.
(WinLauncherWebHost::Release): check-webkit-style fixes.
(resizeSubViews): check-webkit-style fixes.
(_tWinMain): check-webkit-style fixes.
(MyRegisterClass): check-webkit-style fixes.
(InitInstance): check-webkit-style fixes.
(AbortProc): New print support function.
(getPrinterDC): New print support function.
(initDocStruct): New print support function.
(PrintView): New printing implementation.
(WndProc): Add support for printing.
(MyEditProc): check-webkit-style fixes.
(About): check-webkit-style fixes.
(loadURL): check-webkit-style fixes.

  • WinLauncher/WinLauncher.h:

(WinLauncherWebHost::WinLauncherWebHost):
(WinLauncherWebHost::didStartProvisionalLoadForFrame):
(WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
(WinLauncherWebHost::didFailProvisionalLoadWithError):
(WinLauncherWebHost::didCommitLoadForFrame):
(WinLauncherWebHost::didReceiveTitle):
(WinLauncherWebHost::didReceiveIcon):
(WinLauncherWebHost::didFinishLoadForFrame):
(WinLauncherWebHost::didFailLoadWithError):
(WinLauncherWebHost::didChangeLocationWithinPageForFrame):
(WinLauncherWebHost::willPerformClientRedirectToURL):
(WinLauncherWebHost::didCancelClientRedirectForFrame):
(WinLauncherWebHost::willCloseFrame):
(WinLauncherWebHost::windowScriptObjectAvailable):

  • WinLauncher/WinLauncher.rc: Add menu entry for printing.
  • WinLauncher/WinLauncher.vcproj: Add new files.
  • WinLauncher/resource.h: Add menu entry for printing.
19:30 Changeset [52399] by ukai@chromium.org

2009-12-19 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

Invalid url should raise SYNTAX_ERR exception.
https://bugs.wbekit.org/show_bug.cgi?id=32700

  • websocket/tests/bad-sub-protocol-expected.txt: add CONSOLE MESSAGEs
  • websocket/tests/script-tests/url-parsing.js: add invalid url tests. Also changed url from ws://127.0.0.1/ to ws://127.0.0.1:8880/websocket/tests/simple to make it sure no errors on console message for these tests by not receiving unexpected response from 127.0.0.1:80.
  • websocket/tests/url-parsing-expected.txt:

2009-12-19 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

Invalid url should raise SYNTAX_ERR exception.
https://bugs.webkit.org/show_bug.cgi?id=32700

Check url is valid in WebSocket::connect.
Also log the detailed reason of websocket failures to console.

  • websockets/WebSocket.cpp: (WebCore::WebSocket::connect):
18:40 Changeset [52398] by abarth@webkit.org

2009-12-19 Adam Barth <abarth@webkit.org>

Unreviewed. Tweak the CSS to make the dashboard prettier.

  • QueueStatusServer/stylesheets/dashboard.css:
  • QueueStatusServer/templates/dashboard.html:
18:32 Changeset [52397] by mitz@apple.com

REGRESSION: Up/down arrow keys do not step numeric CSS property values
https://bugs.webkit.org/show_bug.cgi?id=32776

Reviewed by Darin Adler.

  • inspector/front-end/inspector.js:

(WebInspector.documentKeyDown): Call the focused element’s
handleKeyEvent method.

17:37 Changeset [52396] by abarth@webkit.org

2009-12-19 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

QueueStatusServer needs a human readable dashboard
https://bugs.webkit.org/show_bug.cgi?id=32769

Here is a first cut at the dashboard. There's a lot left to do.

  • QueueStatusServer/filters/webkit_extras.py:
  • QueueStatusServer/handlers/dashboard.py: Added.
  • QueueStatusServer/handlers/patchstatus.py:
  • QueueStatusServer/handlers/recentstatus.py:
  • QueueStatusServer/handlers/showresults.py:
  • QueueStatusServer/handlers/statusbubble.py:
  • QueueStatusServer/handlers/updatestatus.py:
  • QueueStatusServer/main.py:
  • QueueStatusServer/model/init.py: Copied from WebKitTools/QueueStatusServer/filters/init.py.
  • QueueStatusServer/model/queuestatus.py: Renamed from WebKitTools/QueueStatusServer/model.py.
  • QueueStatusServer/stylesheets/dashboard.css: Added.
  • QueueStatusServer/templates/dashboard.html: Added.
  • QueueStatusServer/templates/statusbubble.html: Renamed from WebKitTools/QueueStatusServer/status_bubble.html.
  • QueueStatusServer/templates/updatestatus.html: Renamed from WebKitTools/QueueStatusServer/update_status.html.
17:30 BuildingOnWindows edited by dbates@webkit.org
Add notice of change made in changeset 51399 that requires Safari 4.0.4 to … (diff)
13:58 Changeset [52395] by eric@webkit.org

2009-12-19 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Speed-up SVG Masking
https://bugs.webkit.org/show_bug.cgi?id=32738

This patch makes SVG Masking faster. At the moment we create a new ImageBuffer
and copy the complete pixel array. That is rather inefficient. This patch
uses the mask image directly.
It also bounds the direct pixel manipultation to the viewable area to minimize
the calculation of the mask.

No change in functionality. So no new test.

  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent):
  • svg/SVGMaskElement.h:
  • svg/graphics/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::applyMask):
  • svg/graphics/SVGResourceMasker.h:
13:35 Changeset [52394] by eric@webkit.org

2009-12-19 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Add tests to check filter, mask, clip, opacity and marker ordering
https://bugs.webkit.org/show_bug.cgi?id=14010

Tests the right order of filter and clipper/masker aplied to a SVG
object.

  • platform/mac/svg/filters/filter-clip-expected.checksum: Added.
  • platform/mac/svg/filters/filter-clip-expected.png: Added.
  • platform/mac/svg/filters/filter-clip-expected.txt: Added.
  • svg/filters/filter-clip.svg: Added.

2009-12-19 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Add tests to check filter, mask, clip, opacity and marker ordering
https://bugs.webkit.org/show_bug.cgi?id=14010

The right ordering for applying effects on objects in SVG is filters,
clipper/masker and opacity. This patch fixes the order of filter and
clipper/masker. Opacity and marker need another test.
This change is according to the SVG Specification:
http://www.w3.org/TR/SVG11/render.html#Elements

Test: svg/filters/filter-clip.svg

  • rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderBase::prepareToRenderSVGContent):
12:53 Changeset [52393] by eric@webkit.org

2009-12-19 Daniel Bates <dbates@webkit.org>

Reviewed by Timothy Hatcher.

https://bugs.webkit.org/show_bug.cgi?id=32462

Added --inspector-frontend flag to build-webkit to copy any changes
to the inspector front-end files to the built WebCore framework. This
will make inspector development more consistent with the rest of
WebKit development.

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:
10:55 Changeset [52392] by eric@webkit.org

2009-12-19 Evan Martin <evan@chromium.org>

Reviewed by Gustavo Noronha Silva.

Revert my attempt at making --disable-geolocation work; it is
more complicated than I anticipated. (It passed on the build bots
because they build with --enable-geolocation.)

  • GNUmakefile.am:
10:52 Changeset [52391] by otte@webkit.org

add forgotten file

10:45 Changeset [52390] by otte@webkit.org

Rebaselined test after revision 52335.

10:37 Changeset [52389] by eric@webkit.org

2009-12-19 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

Tests for https://bugs.webkit.org/show_bug.cgi?id=28153
can't middle-button paste within a single window

  • LayoutTests/platform/gtk/editing/pasteboard/middle-button-paste-expected.txt: Added
  • LayoutTests/platform/gtk/editing/pasteboard/middle-button-paste.html: Adeed

2009-12-19 Alejandro G. Castro <alex@igalia.com>

Reviewed by Xan Lopez.

Fixed the problem when pasting in the same window with the
middle-button, now we store a reference to the range instead of
requesting it every time, and we do not release it until the
clipboard is requested.
https://bugs.webkit.org/show_bug.cgi?id=28153

  • WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp:
  • WebKit/gtk/WebCoreSupport/EditorClientGtk.h:
10:30 Changeset [52388] by eric@webkit.org

2009-12-19 MORITA Hajime <morrita@gmail.com>

Reviewed by Darin Adler.

WebCore::Range::surroundContents NULL pointer crash.

https://bugs.webkit.org/show_bug.cgi?id=31684

  • fast/dom/Range/31684-expected.txt: Added.
  • fast/dom/Range/31684.html: Added.
  • fast/dom/Range/script-tests/31684.js: Added.

2009-12-19 MORITA Hajime <morrita@gmail.com>

Reviewed by Darin Adler.

WebCore::Range::surroundContents NULL pointer crash.

https://bugs.webkit.org/show_bug.cgi?id=31684

Test: fast/dom/Range/31684.html

  • dom/Range.cpp: (WebCore::Range::surroundContents): throw exception when parentOfNewParent->parentNode() is NULL.
10:24 Changeset [52387] by kov@webkit.org

Reviewed by Xan Lopez.

Protect download objects when reporting errors, to make sure the
download stays alive between the status change notification, and
the error signal emission.

  • webkit/webkitdownload.cpp:

(webkit_download_error):

10:08 Changeset [52386] by christian@webkit.org

2009-12-19 Christian Dywan <christian@twotoasts.de>

Reviewed by Gustavo Noronha Silva.

Don't use an icon for all spelling guess menu items.

  • platform/gtk/ContextMenuItemGtk.cpp: (WebCore::gtkStockIDFromContextMenuAction):
09:23 Changeset [52385] by abarth@webkit.org

2009-12-19 Adam Barth <abarth@webkit.org>

Unreviewed fixes for me being terrible at python.

  • Scripts/modules/bugzilla.py:
  • Scripts/run-webkit-unittests:
08:24 Changeset [52384] by kov@webkit.org

2009-12-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Unreviewed build fix. Missing \.

  • GNUmakefile.am:
07:16 Changeset [52383] by eric@webkit.org

2009-12-19 Evan Martin <evan@chromium.org>

Reviewed by Gustavo Noronha Silva.

Add a couple of WebKitGtk files to .gitignore.

  • .gitignore:
03:52 Changeset [52382] by eric@webkit.org

2009-12-19 Evan Martin <evan@chromium.org>

Reviewed by Gustavo Noronha Silva.

Make --disable-geolocation and --disable-svg work, by conditionally
building the relevant files.

  • GNUmakefile.am:

12/18/09:

23:14 Changeset [52381] by abarth@webkit.org

2009-12-18 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Split QueueStatus server into modules
https://bugs.webkit.org/show_bug.cgi?id=32768

One monolithic file is no good.

  • QueueStatusServer/app.yaml:
  • QueueStatusServer/handlers/init.py: Copied from WebKitTools/QueueStatusServer/filters/init.py.
  • QueueStatusServer/handlers/patchstatus.py: Added.
  • QueueStatusServer/handlers/recentstatus.py: Added.
  • QueueStatusServer/handlers/showresults.py: Added.
  • QueueStatusServer/handlers/statusbubble.py: Added.
  • QueueStatusServer/handlers/updatestatus.py: Added.
  • QueueStatusServer/main.py: Added.
  • QueueStatusServer/model.py: Added.
  • QueueStatusServer/queue_status.py: Removed.
23:12 Changeset [52380] by eric@webkit.org

2009-12-18 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

[Chromium] Eliminate redundant data copy in GraphicsContext3D readback
https://bugs.webkit.org/show_bug.cgi?id=32763

Eliminated useless creation of a CGBitmapContext and from there a
CGImage. Now create CGImage directly from data. Also changed
readPixels parameters and CGImage alpha info to try to avoid byte
swapping, and disabled interpolation when drawing the GL content.
Some test cases run twice as fast with these changes, though more
work is needed to achieve desired performance.

No test case; performance optimization only. Ran WebGL demos from
Khronos site to verify changes.

  • src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::reshape): (WebCore::GraphicsContext3DInternal::beginPaint):
22:40 Changeset [52379] by eric@webkit.org

2009-12-18 Peter Kasting <pkasting@google.com>

Reviewed by Simon Fraser.

Add a comment about some confusing code that otherwise would look like
it might be a bug.
https://bugs.webkit.org/show_bug.cgi?id=32534

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateScrollInfoAfterLayout):
22:33 Changeset [52378] by abarth@webkit.org

2009-12-18 Adam Barth <abarth@webkit.org>

Rubber stamped by Eric Seidel.

Renamed WorkQueue to QueueEngine. WorkQueue is not a queue.

  • Scripts/modules/commands/queues.py:
  • Scripts/modules/queueengine.py: Added.
  • Scripts/modules/queueengine_unittest.py: Added.
  • Scripts/modules/stepsequence.py:
  • Scripts/modules/workqueue.py: Removed.
  • Scripts/modules/workqueue_unittest.py: Removed.
22:05 Changeset [52377] by abarth@webkit.org

2009-12-18 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add watches for EWS
https://bugs.webkit.org/show_bug.cgi?id=32767

dglazkov wanted to be added.

  • Scripts/modules/bugzilla.py:
  • Scripts/modules/commands/early_warning_system.py:
  • Scripts/modules/commands/queues.py:
22:02 Changeset [52376] by mitz@apple.com

Updated localizable strings after r52368

  • English.lproj/Localizable.strings:
21:14 Changeset [52375] by zimmermann@webkit.org

2009-12-18 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Messed up the XCode file, trying to fix.

  • WebCore.xcodeproj/project.pbxproj:
20:44 Changeset [52374] by zimmermann@webkit.org

2009-12-18 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed, fix typos in WebCore.xcodeproj.

  • WebCore.xcodeproj/project.pbxproj:
20:34 Changeset [52373] by zimmermann@webkit.org

2009-12-18 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Eric Seidel.

SVGAngle / SVGPreserveAspectRatio should be POD types
https://bugs.webkit.org/show_bug.cgi?id=32758

Convert SVGAngle / SVGPreserveAspectRatio to be non-refcounted types, just
like it has been done for SVGMatrix / SVGLength before.

This patch prepares removing the special DOMObjectWithSVGContext hack.
No change in functionality, thus no new tests.

18:34 Changeset [52372] by dumi@chromium.org

Chromium build fix, no review.

  • storage/chromium/DatabaseTrackerChromium.cpp:
18:04 Changeset [52371] by bfulgham@webkit.org

Build fix, no review.

  • platform/graphics/win/FontCacheWin.cpp:

(WebCore::FontCache::createFontPlatformData): Correct my typo

on the CG build.

18:03 Changeset [52370] by dumi@chromium.org

Make DatabaseTrackerChromium::removeOpenDatabase() send and IPC on
the main thread when a database is being closed.

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=32627

  • storage/chromium/DatabaseTrackerChromium.cpp:

(WebCore::removeOpenDatabaseOnMainThread):
(WebCore::DatabaseTracker::removeOpenDatabase):

17:59 Changeset [52369] by bfulgham@webkit.org

Build fix, no review.

  • page/win/FrameCairoWin.cpp: Add missing include.
  • platform/graphics/win/FontCacheWin.cpp:

(WebCore::FontCache::createFontPlatformData): Conditionalize

Safari-only call.

17:56 Changeset [52368] by weinig@apple.com

Add Mac WebKit side of the client based geolocation provider.

Reviewed by Dan Bernstein.

WebKit:

  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

  • Misc/WebKitErrors.m:

(registerErrors): Add Geolocation errors.

  • Misc/WebKitErrorsPrivate.h:
  • WebCoreSupport/WebGeolocationControllerClient.h: Added.

(WebGeolocationControllerClient::webView):

  • WebCoreSupport/WebGeolocationControllerClient.mm: Added.

(WebGeolocationControllerClient::WebGeolocationControllerClient):
(WebGeolocationControllerClient::startUpdating):
(WebGeolocationControllerClient::stopUpdating):
(WebGeolocationControllerClient::lastPosition):
Add implementation of the WebGeolocationControllerClient.

  • WebView/WebGeolocationPosition.h: Added.
  • WebView/WebGeolocationPosition.mm: Added.

(-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
(core):
(-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):

  • WebView/WebGeolocationPositionInternal.h: Added.

Add an Objective-C wrapper for GeolocationPosition.

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): Set the GeolocationControllerClient.
(-[WebView _setGeolocationProvider:]): Set the GeolocationProvider
(-[WebView _geolocationProvider]): Return the GeolocationProvider.
(-[WebView _geolocationDidChangePosition:]): Notify WebCore that the position changed.
(-[WebView _geolocationDidFailWithError:]): Notify WebCore that an error occured.

  • WebView/WebViewData.h:
  • WebView/WebViewPrivate.h:
17:27 Changeset [52367] by dumi@chromium.org

Move some code related to database closing from the destructor to
the close() method. This would allow us to do things such as post
tasks to other threads when a database closes, which cannot be
done now, because we cannot increment the ref count to a database
object when we're in its destructor.

Reviewed by Dmitry Titov.

https://bugs.webkit.org/show_bug.cgi?id=32626

  • storage/Database.cpp:

(WebCore::Database::~Database):
(WebCore::Database::close):

16:47 Changeset [52366] by eric@webkit.org

2009-12-18 Peter Kasting <pkasting@google.com>

Reviewed by Adam Barth.

Chromium build fix
https://bugs.webkit.org/show_bug.cgi?id=32756

  • public/WebAccessibilityRole.h: (WebKit::):
  • src/AssertMatchingEnums.cpp:
16:40 Changeset [52365] by mrowe@apple.com

Merge r52344.

16:40 Changeset [52364] by mrowe@apple.com

Merge r52342.

16:40 Changeset [52363] by mrowe@apple.com

Merge r52338.

16:40 Changeset [52362] by mrowe@apple.com

Merge r52336.

16:40 Changeset [52361] by mrowe@apple.com

Merge r52331.

16:40 Changeset [52360] by mrowe@apple.com

Merge r52330.

16:40 Changeset [52359] by mrowe@apple.com

Merge r52325.

16:39 Changeset [52358] by mrowe@apple.com

Merge r52298.

16:39 Changeset [52357] by mrowe@apple.com

Versioning.

16:33 Changeset [52356] by eric@webkit.org

2009-12-18 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

REGRESSION(52325) Chromium build broken due to link failure
https://bugs.webkit.org/show_bug.cgi?id=32753

  • WebCoreSupport/WebSystemInterface.m:
    • Chromium Mac builds use this file, but do not enable Pre-compiled Header (PCH) files so that Chromium build bots can take advantage of the faster distcc 3. Eventually all mac builds will likely use distcc, but for now we'll add Platform.h here and document its usage so it's not removed by accident.
16:29 Changeset [52355] by eric@webkit.org

2009-12-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Move some build decisions from Qt build system into source files
https://bugs.webkit.org/show_bug.cgi?id=31956

  • JavaScriptCore.pri: Compile files unconditionally
  • jit/ExecutableAllocatorPosix.cpp: Guard with PLATFORM(UNIX) && !PLATFORM(SYMBIAN)
  • jit/ExecutableAllocatorWin.cpp: Guard with PLATFORM(WIN_OS)
  • runtime/MarkStackPosix.cpp: Guard with PLATFORM(UNIX) && !PLATFORM(SYMBIAN)
  • runtime/MarkStackSymbian.cpp: Guard with PLATFORM(SYMBIAN)
  • runtime/MarkStackWin.cpp: Guard with PLATFORM(WIN_OS)
  • wtf/Platform.h: Guard ENABLE_JSC_MULTIPLE_THREADS with ENABLE_SINGLE_THREADED for the Qt port
  • wtf/ThreadingNone.cpp: Guard with ENABLE(SINGLE_THREADED)
  • wtf/qt/ThreadingQt.cpp: Guard with !ENABLE(SINGLE_THREADED)
16:22 Changeset [52354] by simon.fraser@apple.com

2009-12-18 Simon Fraser <simon.fraser@apple.com>

Reviewed by Darin Adler.

Crash when accessing webkitTransition property after setting webkitTransitionProperty with invalid value.
https://bugs.webkit.org/show_bug.cgi?id=31559

Fix an array bounds error when accessing the CSS value for a shorthand property that takes
a comma-separated list, after the list for one of the component properties has been set to a different length.

Test: fast/css/shorthand-mismatched-list-crash.html

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue):
16:09 Changeset [52353] by mrowe@apple.com

New tag.

16:05 Changeset [52352] by jhoneycutt@apple.com

REGRESSION(r52233): MSAA: Accessibility role of lists is wrong

https://bugs.webkit.org/show_bug.cgi?id=32736

Reviewed by Adam Roben.

WebCore:

Test: platform/win/accessibility/list-role.html

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::roleValueForMSAA):
Return roleValue(), rather than m_role, as subclasses may override it.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::roleValueForMSAA):
Fallback to roleValue(), rather than m_role, as it may be overriden.

LayoutTests:

  • platform/win/accessibility/list-role-expected.txt: Added.
  • platform/win/accessibility/list-role.html: Added.

Verify that lists return the "list" role.

16:05 Changeset [52351] by jhoneycutt@apple.com

MSAA: Accessibility role of list items is wrong

https://bugs.webkit.org/show_bug.cgi?id=32688

Reviewed by Adam Roben.

WebCore:

Test: platform/win/accessibility/list-item-role.html

  • accessibility/AccessibilityObject.h:

(WebCore::):
Add a ListItemRole to the enum.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::msaaRoleForRenderer):
Return the role for the RenderObject, or UnknownRole if unknown.
(WebCore::AccessibilityRenderObject::roleValueForMSAA):
Call msaaRoleForRenderer() to get the role. If it is UnknownRole, fall
back to m_role.

WebKit/win:

  • AccessibleBase.cpp:

(MSAARole):
Make the WebCore list item role map to the MSAA list item role.

LayoutTests:

  • platform/win/accessibility/list-item-role-expected.txt: Added.
  • platform/win/accessibility/list-item-role.html: Added.

Verify that the list item role is "list item".

16:05 Changeset [52350] by jhoneycutt@apple.com

MSAA: Accessibility role of list markers is wrong

https://bugs.webkit.org/show_bug.cgi?id=32687

Reviewed by Adam Roben.

WebKit/win:

  • AccessibleBase.cpp:

(MSAARole):
Make the WebCore list marker role map to the MSAA static text role.

LayoutTests:

  • platform/win/accessibility/list-marker-role-expected.txt: Added.
  • platform/win/accessibility/list-marker-role.html: Added.

Verify that the list marker role is "text".

16:00 Changeset [52349] by simon.fraser@apple.com

2009-12-18 Simon Fraser <simon.fraser@apple.com>

Reviewed by Mark Rowe.

Remove WebCore.ClientBasedGeolocation.exp from Sources, and remove two IDL files from Resources.

  • WebCore.xcodeproj/project.pbxproj:
15:57 Changeset [52348] by bweinstein@apple.com

Build fix part II, this time it's personal.x

15:46 Changeset [52347] by bweinstein@apple.com

First step at a Windows build fix, get it to link JavaScriptCore. Might fail later.

14:59 Changeset [52346] by barraclough@apple.com

Add createNonCopying method to UString to make replace constructor passed bool,
to make behaviour more explicit. Add createFromUTF8 to UString (wrapping method
on UString::Rep), since other cases of transliteration (e.g. from ascii) are
performed in UString constructors. Add/use setHash & size() accessors on Rep,
rather than accessing _hash/len directly.

Reviewed by Sam Weinig.

  • API/JSClassRef.cpp:

(OpaqueJSClass::OpaqueJSClass):

  • API/OpaqueJSString.cpp:

(OpaqueJSString::ustring):

(JSC::arrayProtoFuncToString):

  • runtime/Identifier.cpp:

(JSC::Identifier::equal):
(JSC::CStringTranslator::translate):
(JSC::UCharBufferTranslator::translate):
(JSC::Identifier::addSlowCase):

  • runtime/JSString.cpp:

(JSC::JSString::resolveRope):

  • runtime/JSString.h:

(JSC::JSString::Rope::Fiber::refAndGetLength):
(JSC::JSString::Rope::append):

  • runtime/StringBuilder.h:

(JSC::StringBuilder::release):

  • runtime/StringConstructor.cpp:

(JSC::stringFromCharCodeSlowCase):

  • runtime/StringPrototype.cpp:

(JSC::substituteBackreferencesSlow):
(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncLink):

  • runtime/UString.cpp:

(JSC::UString::UString):
(JSC::UString::createNonCopying):
(JSC::UString::createFromUTF8):

  • runtime/UString.h:

(JSC::UString::Rep::setHash):
(JSC::UString::~UString):
(JSC::makeString):

14:51 Changeset [52345] by weinig@apple.com

Fix mac Geolocation build.

  • DerivedSources.make:
  • WebCore.ClientBasedGeolocation.exp: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • page/Geolocation.h:
  • page/GeolocationError.h:

(WebCore::GeolocationError::GeolocationError):

  • page/GeolocationPosition.h:
14:44 Changeset [52344] by weinig@apple.com

Fix preference key name.

Reviewed by Anders Carlsson.

  • WebView/WebPreferenceKeysPrivate.h:
14:18 Changeset [52343] by ggaren@apple.com

Changed Register constructors to assignment operators, to streamline
moving values into registers. (In theory, there's no difference between
the two, since the constructor should just inline away, but there seems
to be a big difference in the addled mind of the GCC optimizer.)

Reviewed by Cameron Zwarich and Gavin Barraclough.

In the interpreter, this is a 3.5% SunSpider speedup and a 1K-2K
reduction in stack usage per privateExecute stack frame.

  • interpreter/CallFrame.h:

(JSC::ExecState::setCalleeArguments):
(JSC::ExecState::setCallerFrame):
(JSC::ExecState::setScopeChain):
(JSC::ExecState::init):
(JSC::ExecState::setArgumentCount):
(JSC::ExecState::setCallee):
(JSC::ExecState::setCodeBlock): Added a little bit of casting so these
functions could use the new Register assignment operators.

  • interpreter/Register.h:

(JSC::Register::withInt):
(JSC::Register::Register):
(JSC::Register::operator=): Swapped in assignment operators for constructors.

14:05 Changeset [52342] by andersca@apple.com

Pass preference to plug-in host.

Reviewed by Sam Weinig.

  • Plugins/Hosted/NetscapePluginHostManager.mm:

(WebKit::NetscapePluginHostManager::spawnPluginHost):

13:57 Changeset [52341] by bweinstein@apple.com

Fixes <http://webkit.org/b/32613>.
REGRESSION (r52008): Middle-clicking on a linked image starts a pan scroll,
but should follow the link instead.

Reviewed by Adam Roben.

WebCore:

The node itself isn't the only possible node that can be a link (that was the
original check), any of its ancestors could be links as well, we need to climb
up the tree to see. Created a new function (enclosingAnchorNode), that finds a
node's enclosing anchor element (if it exists), that we can share between RenderLayer
and Node, and also added tests that test pan scrolling behavior in image maps.

Tests: platform/win/fast/events/panScroll-image-no-scroll.html

platform/win/fast/events/panScroll-imageMap-href-no-scroll.html
platform/win/fast/events/panScroll-imageMap-noHref-scroll.html

  • dom/Node.cpp:

(WebCore::Node::enclosingAnchorNode):
(WebCore::Node::defaultEventHandler):

  • dom/Node.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTest):

LayoutTests:

Added tests that test pan scrolling behavior when you middle click on images with
links, and if you click on parts on image maps that are links, and that aren't.

  • platform/win/fast/events/panScroll-image-no-scroll-expected.txt: Added.
  • platform/win/fast/events/panScroll-image-no-scroll.html: Added.
  • platform/win/fast/events/panScroll-imageMap-href-no-scroll-expected.txt: Added.
  • platform/win/fast/events/panScroll-imageMap-href-no-scroll.html: Added.
  • platform/win/fast/events/panScroll-imageMap-noHref-scroll-expected.txt: Added.
  • platform/win/fast/events/panScroll-imageMap-noHref-scroll.html: Added.
13:55 Changeset [52340] by ariya@webkit.org

2009-12-18 Ariya Hidayat <ariya.hidayat@gmail.com>

Build fix, not reviewed.

  • QtLauncher/main.cpp: (MainWindow::setTouchMocking): Leave setTouchMocking as an empty function for Qt < 4.6 so that moc still creates a slot for that. Otherwise, it would have generated a linker error.
13:45 Changeset [52339] by eric@webkit.org

2009-12-18 Eric Seidel <eric@webkit.org>

Reviewed by David Levin.

move bugzilla.py off of urllib2
https://bugs.webkit.org/show_bug.cgi?id=32729

  • Scripts/modules/bugzilla.py: use mechanize for all url fetching.
13:43 Changeset [52338] by andersca@apple.com

Add WKPCRunSyncOpenPanel implementation.

Reviewed by Sam Weinig.

  • Plugins/Hosted/NetscapePluginHostProxy.mm:

(WKPCRunSyncOpenPanel):

  • Plugins/Hosted/WebKitPluginClient.defs:
  • Plugins/Hosted/WebKitPluginHost.defs:
13:18 Changeset [52337] by eric@webkit.org

2009-12-18 Yongjun Zhang <yongjun.zhang@nokia.com>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=32713
[Qt] make wtf/Assertions.h compile in winscw compiler.

Add string arg before ellipsis to help winscw compiler resolve variadic
macro definitions in wtf/Assertions.h.

  • wtf/Assertions.h:
13:17 Changeset [52336] by andersca@apple.com

Add a useProxiedOpenPanel WebPreference and tunnel it through to the plug-in host.

Reviewed by Sam Weinig.

  • Plugins/Hosted/NetscapePluginHostManager.h:
  • Plugins/Hosted/NetscapePluginHostManager.mm:

(WebKit::NetscapePluginHostManager::hostForPackage):
(WebKit::NetscapePluginHostManager::spawnPluginHost):
(WebKit::NetscapePluginHostManager::instantiatePlugin):

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences usesProxiedOpenPanel]):
(-[WebPreferences setUsesProxiedOpenPanel:]):

  • WebView/WebPreferencesPrivate.h:
12:50 Changeset [52335] by otte@webkit.org

[GTK] RemoveDashboard support. It's useless.

  • configure.ac:
12:46 Changeset [52334] by ggaren@apple.com

Fixed intermittent failure seen on Windows buildbot, and in other JSC
API clients.

Reviewed by Adam Roben.

Added a WeakGCPtr class and changed OpaqueJSClass::cachedPrototype to
use it, to avoid vending a stale object as a prototype.

  • API/JSClassRef.cpp:

(OpaqueJSClassContextData::OpaqueJSClassContextData):
(OpaqueJSClass::prototype):

  • API/JSClassRef.h: Use WeakGCPtr.
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/WeakGCPtr.h: Added.

(JSC::WeakGCPtr::WeakGCPtr):
(JSC::WeakGCPtr::get):
(JSC::WeakGCPtr::clear):
(JSC::WeakGCPtr::operator*):
(JSC::WeakGCPtr::operator->):
(JSC::WeakGCPtr::operator!):
(JSC::WeakGCPtr::operator bool):
(JSC::WeakGCPtr::operator UnspecifiedBoolType):
(JSC::WeakGCPtr::assign):
(JSC::::operator):
(JSC::operator==):
(JSC::operator!=):
(JSC::static_pointer_cast):
(JSC::const_pointer_cast):
(JSC::getPtr): Added WeakGCPtr to the project.

12:45 Changeset [52333] by bweinstein@apple.com

Add a needed export to fix the Windows build.

12:42 Changeset [52332] by christian@webkit.org

2009-12-18 Christian Dywan <christian@twotoasts.de>

Reviewed by Xan Lopez.

[GTK] context menu overriding API is very limited
https://bugs.webkit.org/show_bug.cgi?id=27546

Omit SearchWeb from the context menu in the GTK+ port.

  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate):
12:41 Changeset [52331] by weinig@apple.com

Add export the new symbol in WebCoreSystemInterface.

Reviewed by Anders Carlsson.

  • WebCore.base.exp:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
12:26 Changeset [52330] by weinig@apple.com

Forward declare NSMutableArray when not compiling for Objective-C.

Reviewed by Anders Carlsson.

  • platform/mac/WebCoreSystemInterface.h:
12:02 Changeset [52329] by barraclough@apple.com

JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=32720

Reviewed by Sam Weinig.

  • JavaScriptCore.exp:
    • Remove exports for UString::append
  • JavaScriptCore.xcodeproj/project.pbxproj:
    • Make StringBuilder a private header (was project).

WebCore: https://bugs.webkit.org/show_bug.cgi?id=32720
Replace UString addition/append with use of JSC::StringBuilder.

Reviewed by Sam Weinig.

  • ForwardingHeaders/runtime/StringBuilder.h: Added.
  • bindings/js/ScriptString.h:

(WebCore::ScriptString::operator+=):

  • bridge/jni/jni_runtime.cpp:

(appendClassName):
(JavaMethod::signature):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::addProfileFinishedMessageToConsole):
(WebCore::InspectorController::addStartProfilingMessageToConsole):
(WebCore::InspectorController::getCurrentUserInitiatedProfileName):

11:55 Changeset [52328] by eric@webkit.org

2009-12-18 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Gustavo Noronha Silva.

[GTK] GRefPtr does not take a reference when assigned a raw pointer
https://bugs.webkit.org/show_bug.cgi?id=32709

Ensure that when assigning a raw pointer to a GRefPtr, the reference
count is incremented. Also remove the GRefPtr conversion overload as
GRefPtr types have necessarily incompatible reference counting.

  • wtf/gtk/GRefPtr.h: (WTF::GRefPtr::operator=):
11:43 Changeset [52327] by eric@webkit.org

2009-12-18 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Index validation for drawElements examines too many indices
https://bugs.webkit.org/show_bug.cgi?id=32692

  • fast/canvas/webgl/bug-32692-expected.txt: Added.
  • fast/canvas/webgl/bug-32692.html: Added.

2009-12-18 Kenneth Russell <kbr@google.com>

Reviewed by Darin Fisher.

Index validation for drawElements examines too many indices
https://bugs.webkit.org/show_bug.cgi?id=32692

Test: fast/canvas/webgl/bug-32692.html

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::validateIndexArrayPrecise):
11:36 Changeset [52326] by kov@webkit.org

2009-12-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>

Rubber-stamped by Xan Lopez.

Disable page cache for tests.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (copyWebSettingKey): (LayoutTestController::overridePreference):
11:22 Changeset [52325] by weinig@apple.com

WebCore: Update WebKitSystemInterface for <rdar://problem/7237059>.

Reviewed by Anders Carlsson.

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

WebKit/mac: Update WebKitSystemInterface for <rdar://problem/7237059>.

Reviewed by Anders Carlsson.

  • WebCoreSupport/WebSystemInterface.m:

(InitWebCoreSystemInterface):

WebKitLibraries: Update WebKitSystemInterface for <rdar://problem/7237059>.

Reviewed by Anders Carlsson.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
11:16 Changeset [52324] by bweinstein@apple.com

Rubber-stamped by Adam Roben.

Add expected failing results for fast/dom/Element/id-in-deleteutton.html.
The progress of fixing the failure is being tracked by:
<https://bugs.webkit.org/show_bug.cgi?id=32727>.

  • platform/win/fast/dom/Element: Added.
  • platform/win/fast/dom/Element/id-in-deletebutton-expected.txt: Added.
10:48 Changeset [52323] by xan@webkit.org

2009-12-18 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

Fix gtk-doc of webkit_web_resource_new.

  • webkit/webkitwebresource.cpp:
10:35 Changeset [52322] by aroben@apple.com

GTK build fix

  • plugins/gtk/PluginViewGtk.cpp: Added #include.
10:00 Changeset [52321] by aroben@apple.com

Build fixes

WebCore: Chromium build fix

  • platform/chromium/PopupMenuChromium.cpp: Added #include.

WebKit/chromium: Chromium build fix

  • src/ChromiumBridge.cpp:
  • src/WebPluginContainerImpl.cpp:
  • src/WebViewImpl.cpp:

Added #includes.

WebKit/qt: Qt build fix

  • Api/qwebpage.cpp: Added #include.
09:54 Changeset [52320] by aroben@apple.com

Chromium build fix

  • html/HTMLLinkElement.cpp: Added #include.
09:52 Changeset [52319] by aroben@apple.com

Qt build fix

WebCore:

  • platform/qt/RenderThemeQt.cpp:
  • plugins/qt/PluginDataQt.cpp:
  • plugins/qt/PluginViewQt.cpp:

Added #includes.

WebKit/qt:

  • Api/qwebpage.cpp:

Added #includes.

09:47 Changeset [52318] by ukai@chromium.org

2009-12-18 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by David Levin.

Check one space before end of line comments.
https://bugs.webkit.org/show_bug.cgi?id=32597

Fix to check one space before end of line comments in whitespace and build/header_guard.
Also fix build/header_guard to use WebKit header guard defines.

  • Scripts/modules/cpp_style.py:
  • Scripts/modules/cpp_style_unittest.py:
09:47 Changeset [52317] by aroben@apple.com

V8 build fix

  • bindings/v8/custom/V8DOMWindowCustom.cpp: Added #include.
09:45 Changeset [52316] by aroben@apple.com

GTK build fix

  • webkit/webkitprivate.cpp: Added #include.
09:42 Changeset [52315] by aroben@apple.com

GTK (and others?) build fix

  • platform/text/StringImpl.h: Added #include.
09:38 Changeset [52314] by aroben@apple.com

Reduce #includes in a few high-use headers

Removed unnecessary #includes in these headers:

  • Frame.h
  • FrameWin.h
  • Node.h
  • Page.h
  • StringImpl.h

The rest of the patch is all adding #includes to source files that now
require them.

Fixes <http://webkit.org/b/32718>.

Rubber-stamped by Anders Carlsson.

WebCore:

  • dom/Node.h:
  • page/Frame.h:
  • page/Page.h:
  • page/win/FrameWin.h:
  • platform/text/StringImpl.h:

Removed unnecessary #includes.

  • accessibility/win/AXObjectCacheWin.cpp:
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSDOMWindowCustom.cpp:
  • dom/Document.cpp:
  • dom/InputElement.cpp:
  • dom/Node.cpp:
  • dom/SelectElement.cpp:
  • editing/EditorCommand.cpp:
  • html/HTMLFormControlElement.cpp:
  • html/HTMLFormElement.cpp:
  • html/HTMLMediaElement.cpp:
  • html/HTMLParser.cpp:
  • html/HTMLTextAreaElement.cpp:
  • html/HTMLVideoElement.cpp:
  • inspector/InspectorController.cpp:
  • loader/FrameLoader.cpp:
  • loader/HistoryController.cpp:
  • loader/appcache/ApplicationCacheGroup.cpp:
  • page/Console.cpp:
  • page/EventHandler.cpp:
  • page/Frame.cpp:
  • page/FrameView.cpp:
  • page/Navigator.cpp:
  • page/PageGroup.cpp:
  • page/Settings.cpp:
  • page/mac/EventHandlerMac.mm:
  • platform/KURL.h:
  • platform/ScrollbarThemeComposite.cpp:
  • platform/cf/BinaryPropertyList.cpp:
  • platform/graphics/mac/GraphicsLayerCA.h:
  • platform/graphics/win/WKCACFLayerRenderer.cpp:
  • platform/mac/PopupMenuMac.mm:
  • platform/mac/WidgetMac.mm:
  • platform/network/cf/DNSCFNet.cpp:
  • platform/text/StringImpl.cpp:
  • platform/win/FileSystemWin.cpp:
  • platform/win/PlatformScreenWin.cpp:
  • platform/win/PopupMenuWin.cpp:
  • platform/win/WidgetWin.cpp:
  • plugins/PluginView.cpp:
  • plugins/win/PluginViewWin.cpp:
  • rendering/InlineTextBox.cpp:
  • rendering/RenderBox.cpp:
  • rendering/RenderFileUploadControl.cpp:
  • rendering/RenderInline.cpp:
  • rendering/RenderLayerCompositor.cpp:
  • rendering/RenderObject.cpp:
  • rendering/RootInlineBox.cpp:
  • storage/DatabaseTracker.cpp:
  • storage/DatabaseTracker.h:
  • storage/SQLTransactionClient.cpp:
  • svg/graphics/SVGImage.cpp:

Added now-needed #includes.

WebKit/mac:

Add #includes needed after WebCore clean-up

  • WebView/WebFrame.mm:
  • WebView/WebFrameView.mm:
  • WebView/WebView.mm:

WebKit/win:

Add #includes needed after WebCore clean-up

  • WebCoreSupport/WebContextMenuClient.cpp:
  • WebDataSource.cpp:
  • WebHTMLRepresentation.cpp:
  • WebView.cpp:
  • WebView.h:
09:06 Changeset [52313] by hausmann@webkit.org

[Qt] Clean up the qmake build system to distinguish between trunk builds and package builds

Reviewed by Tor Arne Vestbø.

https://bugs.webkit.org/show_bug.cgi?id=32716

.:

  • WebKit.pri: Use standalone_package instead of QTDIR_build

JavaScriptCore:

  • pcre/pcre.pri: Use standalone_package instead of QTDIR_build

WebCore:

Introduce standalone_package as config that is set when QTDIR_build is set or when
the directory for the generated files is present.

Renamed uses of QTDIR_build that apply to generic package builds to use standalone_package.
Others remain as they are specific to building inside Qt.

  • WebCore.pro:
08:56 QtWebKitPerformanceWork edited by dbates@webkit.org
Minor spelling correction (diff)
08:40 Changeset [52312] by eric@webkit.org

2009-12-18 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Darin Adler.

New test cases for isId support.
https://bugs.webkit.org/show_bug.cgi?id=5578

  • dom/xhtml/level3/core/attrisid04-expected.txt:
  • dom/xhtml/level3/core/attrisid04.js: (setUpPage):
  • dom/xhtml/level3/core/attrisid05-expected.txt:
  • dom/xhtml/level3/core/attrisid05.js: (setUpPage):
  • fast/dom/Element/attrisid-extra01-expected.txt: Added.
  • fast/dom/Element/attrisid-extra01.html: Added.
  • fast/dom/Element/id-in-applet-expected.txt: Added.
  • fast/dom/Element/id-in-applet.html: Added.
  • fast/dom/Element/id-in-deletebutton-expected.txt: Added.
  • fast/dom/Element/id-in-deletebutton.html: Added.
  • fast/dom/Element/id-in-formcollection-expected.txt: Added.
  • fast/dom/Element/id-in-formcollection.html: Added.
  • fast/dom/Element/id-in-frame-expected.txt: Added.
  • fast/dom/Element/id-in-frame.html: Added.
  • fast/dom/Element/id-in-frameset-expected.txt: Added.
  • fast/dom/Element/id-in-frameset.html: Added.
  • fast/dom/Element/id-in-getelement01-expected.txt: Added.
  • fast/dom/Element/id-in-getelement01.html: Added.
  • fast/dom/Element/id-in-insert-hr-expected.txt: Added.
  • fast/dom/Element/id-in-insert-hr.html: Added.
  • fast/dom/Element/id-in-map-expected.txt: Added.
  • fast/dom/Element/id-in-map.html: Added.
  • fast/dom/Element/id-in-param-expected.txt: Added.
  • fast/dom/Element/id-in-param.html: Added.

2009-12-18 Shu Chang <Chang.Shu@nokia.com>

Reviewed by Darin Adler.

Implemented isId as specified by DOM Level 3. See detailed description below.
https://bugs.webkit.org/show_bug.cgi?id=5578

Added isId property and implementation:
Tests: dom/xhtml/level3/core/attrisid01-07.xhtml

fast/dom/Element/attrisid-extra01.html

  • dom/Attr.cpp: (WebCore::Attr::isId):
  • dom/Attr.h:
  • dom/Attr.idl:

Replaced instances of HTMLNames::idAttr with Element::idAttributeName()
for the reason that id attribute name could be customized to a different
string other than "id". A test case is associated to each code change.

  • dom/Document.cpp: (WebCore::Document::getElementById): Test: fast/dom/Element/id-in-getelement01.html
  • dom/Element.cpp: Tests: dom/xhtml/level3/core/attrisid01-07.xhtml (WebCore::Element::setAttribute): (WebCore::Element::setAttributeMap): (WebCore::Element::insertedIntoDocument): (WebCore::Element::removedFromDocument): (WebCore::Element::formatForDebugger): (WebCore::Element::rareIDAttributeName):
  • dom/Element.h: Added function idAttributeName(). (WebCore::Element::idAttributeName):
  • dom/ElementRareData.h: Added member variable to store customized id name in ElementRareData. (WebCore::ElementRareData::ElementRareData):
  • dom/NamedAttrMap.cpp: Tests: dom/xhtml/level3/core/attrisid01-07.xhtml (WebCore::NamedNodeMap::setNamedItem): (WebCore::NamedNodeMap::removeNamedItem): (WebCore::NamedNodeMap::setAttributes):
  • dom/Node.cpp: Removed ASSERT as it may not hold any more. (WebCore::Node::querySelector):
  • dom/SelectorNodeList.cpp: Removed ASSERT as it may not hold any more. (WebCore::createSelectorNodeList):
  • dom/StyledElement.cpp: Tests: dom/xhtml/level3/core/attrisid01-07.xhtml (WebCore::StyledElement::parseMappedAttribute):
  • editing/DeleteButtonController.cpp: Test: fast/dom/Element/id-in-deletebutton.html (WebCore::DeleteButtonController::createDeletionUI):
  • editing/EditorCommand.cpp: Test: fast/dom/Element/id-in-insert-hr.html (WebCore::executeInsertHorizontalRule):
  • html/HTMLAppletElement.cpp: Test: fast/dom/Element/id-in-applet.html (WebCore::HTMLAppletElement::parseMappedAttribute): (WebCore::HTMLAppletElement::createRenderer):
  • html/HTMLCollection.cpp: (WebCore::HTMLCollection::checkForNameMatch): Test: fast/forms/select-namedItem.html (WebCore::HTMLCollection::updateNameCache): Test: fast/dom/collection-namedItem-via-item.html
  • html/HTMLDataGridColElement.cpp: (WebCore::HTMLDataGridColElement::ensureColumn): Test: fast/dom/HTMLDataGridElement/DataGridColumns-dom.html (WebCore::HTMLDataGridColElement::parseMappedAttribute): Test: fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html
  • html/HTMLElement.cpp: (WebCore::HTMLElement::parseMappedAttribute):
  • html/HTMLFormCollection.cpp: Test: fast/dom/Element/id-in-formcollection.html (WebCore::HTMLFormCollection::getNamedFormItem): (WebCore::HTMLFormCollection::nextNamedItem): (WebCore::HTMLFormCollection::updateNameCache):
  • html/HTMLFrameElementBase.cpp: Test: fast/dom/Element/id-in-frame.html (WebCore::HTMLFrameElementBase::parseMappedAttribute): (WebCore::HTMLFrameElementBase::setNameAndOpenURL):
  • html/HTMLImageElement.cpp: Test: fast/dom/Element/id-in-deletebutton.html (WebCore::HTMLImageElement::parseMappedAttribute):
  • html/HTMLMapElement.cpp: Test: fast/dom/Element/id-in-map.html (WebCore::HTMLMapElement::parseMappedAttribute):
  • html/HTMLNameCollection.cpp: Test: fast/dom/Element/id-in-frameset.html (WebCore::HTMLNameCollection::itemAfter):
  • html/HTMLObjectElement.cpp: Test: fast/dom/HTMLDocument/object-by-name-or-id.html (WebCore::HTMLObjectElement::parseMappedAttribute):
  • html/HTMLParamElement.cpp: Test: fast/dom/Element/id-in-param.html (WebCore::HTMLParamElement::parseMappedAttribute):
  • loader/CachedFont.cpp: Test: svg/custom/acid3-test-77.html (WebCore::CachedFont::getSVGFontById):
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::createGraphicsLayer): Debug-only code
  • rendering/SVGRenderTreeAsText.cpp: Test: svg/text/text-gradient-positioning.svg (WebCore::writeRenderResources):
  • svg/SVGElement.cpp: Test: svg/custom/acid3-test-77.html (WebCore::SVGElement::insertedIntoDocument):
  • svg/SVGStyledElement.cpp: Test: svg/custom/js-update-image-and-display.svg (WebCore::SVGStyledElement::isKnownAttribute):
  • wml/WMLElement.cpp: (WebCore::WMLElement::parseMappedAttribute):
07:04 Changeset [52311] by eric@webkit.org

2009-12-18 Joe Ligman <joseph.ligman@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Add new API to QWebFrame to scrollRecursively starting with any css overflow
then checking current frame and then ancestors
https://bugs.webkit.org/show_bug.cgi?id=32668

  • Api/qwebframe.cpp: (QWebFramePrivate::scrollOverflow): (QWebFrame::scrollRecursively):
  • Api/qwebframe.h:
  • Api/qwebframe_p.h:
  • tests/qwebframe/qwebframe.qrc:
  • tests/qwebframe/testiframe.html: Added.
  • tests/qwebframe/testiframe2.html: Added.
  • tests/qwebframe/tst_qwebframe.cpp:
06:03 Changeset [52310] by hausmann@webkit.org

[Qt] Fix the build on Symbian.

Reviewed by Tor Arne Vestbø.

Use QFont::lastRestortFamily() instead of QFont::lastRestortFont(),
which is a missing symbol in Qt 4.6.0 on Symbian.

Functionally they should be equivalent, according to the source.

  • platform/graphics/qt/FontCacheQt.cpp:

(WebCore::FontCache::getLastResortFallbackFont):

06:01 Changeset [52309] by philn@webkit.org

2009-12-18 Philippe Normand <pnormand@igalia.com>

Reviewed by Xan Lopez.

[GTK] segfault during controls initialization if not GTK theme is present.
https://bugs.webkit.org/show_bug.cgi?id=32705

Create empty images for the controls if no GTK theme is set.

  • platform/graphics/gtk/ImageGtk.cpp: (WebCore::getThemeIconFileName): (WebCore::loadImageFromFile):
05:38 Changeset [52308] by kov@webkit.org

Revert r52305, since it breaks many http tests. We will try a better
solution for Soup.

05:32 Changeset [52307] by hausmann@webkit.org

[Qt] Fix infinite recursion in touch mocking.

Reviewed by Tor Arne Vestbø.

Don't send the fake touch events to the view, as that'll trigger the
event filter again.

  • QtLauncher/main.cpp:

(MainWindow::sendTouchEvent):

04:00 Changeset [52306] by eric@webkit.org

2009-12-18 Kalle Vahlman <kalle.vahlman@movial.com> and Alejandro G. Castro <alex@igalia.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Add enable-page-cache property to WebSettings for disabling the Page Cache

  • webkit/webkitwebsettings.cpp: (_WebKitWebSettingsPrivate::): (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): (_WebKitWebSettingsPrivate::webkit_web_settings_set_property): (_WebKitWebSettingsPrivate::webkit_web_settings_get_property): (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
  • webkit/webkitwebview.cpp:
02:51 Changeset [52305] by otte@webkit.org

Remove the fragment identifier from url before passing it to libsoup.

In newer releases libsoup emits a warning when it gets handed a
fragment.

02:37 Changeset [52304] by eric@webkit.org

2009-12-18 Martin Robinson <martin.james.robinson@gmail.com>

Reviewed by Gustavo Noronha Silva.

[GTK] Compile warning from line 29 of GRefPtr.cpp
https://bugs.webkit.org/show_bug.cgi?id=32703

Fix memory leak and compiler warning in GRefPtr GHashTable template
specialization.

  • wtf/gtk/GRefPtr.cpp: (WTF::refGPtr):
01:50 Changeset [52303] by eric@webkit.org

2009-12-18 Alejandro G. Castro <alex@igalia.com>

Reviewed by Darin Adler.

REGRESSION (r38898): Using the up arrow in a textarea gets "stuck"
at the beginning.
https://bugs.webkit.org/show_bug.cgi?id=31920

Added test showing the problem described in the bug.

  • editing/selection/wrapped-line-caret-3.html:
  • editing/selection/wrapped-line-caret-3-expected.txt:

2009-12-18 Alejandro G. Castro <alex@igalia.com>

Reviewed by Darin Adler.

REGRESSION (r38898): Using the up arrow in a textarea gets "stuck"
at the beginning.
https://bugs.webkit.org/show_bug.cgi?id=31920

Moving up from a position after the end of the previous lines
should use UPSTREAM affinity to render the caret in the previous
line.

Test: editing/selection/wrapped-line-caret-3.html

  • rendering/RenderText.cpp: (WebCore::RenderText::positionForPoint):
Note: See TracTimeline for information about the timeline view.