Timeline



May 22, 2010:

11:59 PM Changeset in webkit [60029] by mjs@apple.com
  • 3 edits in trunk/LayoutTests

2010-05-22 Maciej Stachowiak <mjs@apple.com>

Reviewed by Mark Rowe.

Fix fast/js/global-recursion-on-full-stack.html to no longer depend on where exactly the stack overflow occurs.
https://bugs.webkit.org/show_bug.cgi?id=39558

  • fast/js/global-recursion-on-full-stack-expected.txt:
  • fast/js/global-recursion-on-full-stack.html:
11:45 PM Changeset in webkit [60028] by jparent@chromium.org
  • 2 edits in trunk/WebCore

REGRESSION: xssAuditor tests failing in Chromium.
https://bugs.webkit.org/show_bug.cgi?id=39560

Reviewed by Adam Barth.

Follow up to r0014. Make if statement in V8 bindings match the one from jsc version.

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::evaluate):

7:11 PM Changeset in webkit [60027] by mjs@apple.com
  • 1 edit
    2 deletes in trunk/LayoutTests

2010-05-22 Maciej Stachowiak <mjs@apple.com>

Reviewed by Dan Bernstein.

Remove recently added test "arobens-test" because it is invalid
https://bugs.webkit.org/show_bug.cgi?id=39555


The test below was based on a false assuption (that document.write propagates exceptions)
and was testing for incorrect behavior. The newly added fast/dom/nested-script-exceptions.html
tests for the correct behavior.

  • inspector/arobens-test-expected.txt: Removed.
  • inspector/arobens-test.html: Removed.
5:34 PM Changeset in webkit [60026] by mjs@apple.com
  • 5 edits
    2 adds in trunk

REGRESSION(r59977): platform/mac/fast/AppleScript/001.html failure
https://bugs.webkit.org/show_bug.cgi?id=39531

Reviewed by Mark Rowe.

Revert r59977 and r59943. These changes caused some exceptions to no longer be
reported in the inspector; I can't tell what they were originally trying to fix
so I am not sure how to fix them other than by reverting.

WebCore:

Covered by existing test platform/mac/fast/AppleScript/001.html, and
also added fast/dom/nested-script-exceptions.html to demonstrate the wider
consequences of the original change.

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::ScriptController):
(WebCore::ScriptController::evaluateInWorld):

  • bindings/js/ScriptController.h:

LayoutTests:

Unskipped the test that was broken, and also added a new test.

  • fast/dom/nested-script-exceptions-expected.txt: Added.
  • fast/dom/nested-script-exceptions.html: Added. Shows that inspector functionality

would break in a meaningful way if the reverted change was allowed to stand.

  • platform/mac/Skipped:
5:27 PM Changeset in webkit [60025] by eric@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2010-05-22 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Add DragData
https://bugs.webkit.org/show_bug.cgi?id=39469

As BREW MP does not support dragging, add dummy implementation of DragData.

  • platform/DragData.h:
  • platform/brew/DragDataBrew.cpp: Added. (WebCore::DragData::canSmartReplace): (WebCore::DragData::containsColor): (WebCore::DragData::containsPlainText): (WebCore::DragData::asPlainText): (WebCore::DragData::asColor): (WebCore::DragData::createClipboard): (WebCore::DragData::containsCompatibleContent): (WebCore::DragData::containsURL): (WebCore::DragData::asURL): (WebCore::DragData::asFragment): (WebCore::DragData::asFilenames): (WebCore::DragData::containsFiles):
5:13 PM Changeset in webkit [60024] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2010-05-22 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Add dummy Icon
https://bugs.webkit.org/show_bug.cgi?id=39468

Add dummy implementation of Icon.

  • platform/graphics/brew/IconBrew.cpp: Added. (WebCore::Icon::~Icon): (WebCore::Icon::createIconForFiles): (WebCore::Icon::paint):
4:46 PM Changeset in webkit [60023] by eric@webkit.org
  • 6 edits in trunk

2010-05-22 Justin Schuh <jschuh@chromium.org>

Reviewed by Nate Chapin.

Remove and simplify custom bindings for Node
https://bugs.webkit.org/show_bug.cgi?id=39467

Child manipulation methods now throw security exception instead of
not implemented exception.

  • http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:

2010-05-22 Justin Schuh <jschuh@chromium.org>

Reviewed by Nate Chapin.

Remove and simplify custom bindings for Node
https://bugs.webkit.org/show_bug.cgi?id=39467

Custom bindings for nodeValue and textContent are no longer needed,
and child manipulators are simplified because origin checks were moved
out of the bindings by: http://trac.webkit.org/changeset/59866

  • bindings/js/JSNodeCustom.cpp: (WebCore::JSNode::insertBefore): (WebCore::JSNode::replaceChild): (WebCore::JSNode::removeChild): (WebCore::JSNode::appendChild):
  • bindings/v8/custom/V8NodeCustom.cpp: (WebCore::V8Node::insertBeforeCallback): (WebCore::V8Node::replaceChildCallback): (WebCore::V8Node::removeChildCallback): (WebCore::V8Node::appendChildCallback):
  • dom/Node.idl:
4:26 PM Changeset in webkit [60022] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-05-22 Justin Schuh <jschuh@chromium.org>

Reviewed by Nate Chapin.

Remove custom bindings for NamedNodeMap.setNamedItem and .setNamedItemNS
https://bugs.webkit.org/show_bug.cgi?id=39462

Custom bindings are no longer needed because origin checks were moved
out of the bindings by: http://trac.webkit.org/changeset/59866

Behavior isn't changed and is covered by existing tests.

  • bindings/js/JSNamedNodeMapCustom.cpp:
  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:
  • dom/NamedNodeMap.idl:
3:50 PM Changeset in webkit [60021] by dbates@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

2010-05-22 Daniel Bates <dbates@rim.com>

Unreviewed; fix bug URL in change log.

Inadvertently referenced the wrong bug URL in the change log for change-set
60019 <http://trac.webkit.org/changeset/60019>. The bug URL should have been
<https://bugs.webkit.org/show_bug.cgi?id=39339> not <https://bugs.webkit.org/show_bug.cgi?id=39448>.

3:44 PM Changeset in webkit [60020] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-22 Adam Barth <abarth@webkit.org>

Unreviewed.

Re-order Yong's email addresses because his gmail account is the one he
uses for bugs.webkit.org.

  • Scripts/webkitpy/common/config/committers.py:
3:42 PM Changeset in webkit [60019] by dbates@webkit.org
  • 8 edits
    1 delete in trunk/WebCore

2010-05-22 Daniel Bates <dbates@rim.com>

No review, rolling out 60017.
http://trac.webkit.org/changeset/60017
https://bugs.webkit.org/show_bug.cgi?id=39448

Rolling out since this broke the build on the Windows and Qt bots.
Need to look into this some more.

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/ScriptControllerBase.h: Removed.
  • bindings/js/ScriptController.h: (WebCore::):
  • bindings/v8/ScriptController.h: (WebCore::):
3:15 PM Changeset in webkit [60018] by dbates@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

2010-05-22 Daniel Bates <dbates@rim.com>

Unreviewed; fix change log order.

Update-webkit failed to move my change log to the top of the file
before my commit in changeset 60017 <http://trac.webkit.org/changeset/60017>,
so I am manually moving it to the correct place.

3:08 PM Changeset in webkit [60017] by dbates@webkit.org
  • 8 edits
    1 add in trunk/WebCore

2010-05-22 Yong Li <yoli@rim.com>

Reviewed by Darin Adler.

Fix a crash when XHTMLMP is enabled. The frame pointer in Document
ctor can be null.
https://bugs.webkit.org/show_bug.cgi?id=39448

No new tests because it is obvious and it must be reproduced with
XHTMLMP enabled.

  • dom/Document.cpp: (WebCore::Document::Document):
3:04 PM Changeset in webkit [60016] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-22 Yong Li <yoli@rim.com>

Reviewed by Darin Adler.

Fix a crash when XHTMLMP is enabled. The frame pointer in Document
ctor can be null.
https://bugs.webkit.org/show_bug.cgi?id=39448

No new tests because it is obvious and it must be reproduced with
XHTMLMP enabled.

  • dom/Document.cpp: (WebCore::Document::Document):
2:40 PM Changeset in webkit [60015] by dbates@webkit.org
  • 2 edits
    1 add in trunk/WebKitTools

2010-05-22 Daniel Bates <dbates@rim.com>

Reviewed by Chris Jerdonek.

Add infrastructure to parse SVN property changes
https://bugs.webkit.org/show_bug.cgi?id=38885

Adds function VCSUtils::parseSvnDiffFooter to parse an SVN footer
that consists of one or more properties.

Note, the first line of an SVN footer begins with "Property changes on".

  • Scripts/VCSUtils.pm:
    • Added function parseSvnDiffFooter. Will use this function towards resolving Bug #39409 <https://bugs.webkit.org/show_bug.cgi?id=39409>.
    • Removed FIXME comment above function parseSvnProperty, since it is being used by parseSvnDiffFooter.
  • Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl: Added.
    • Added unit tests.
1:50 PM Changeset in webkit [60014] by dbates@webkit.org
  • 8 edits
    3 adds in trunk

2010-05-22 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

REGRESSION (r56295): Can't create a new wave on Google Wave
https://bugs.webkit.org/show_bug.cgi?id=39249

Instead of just using the source code portion of a JavaScript URL to
detect an XSS attack, we now include the JavaScript URL schema. This
reduces the chance of a false positive by providing additional context.

Test: http/tests/security/xssAuditor/javascript-link-safe.html

  • WebCore.base.exp: Updated exported symbols as necessary.
  • bindings/ScriptControllerBase.cpp: (WebCore::ScriptController::executeScript): Added parameter shouldAllowXSS. (WebCore::ScriptController::executeIfJavaScriptURL): Ditto.
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld): Ditto. (WebCore::ScriptController::evaluate): Ditto. (WebCore::ScriptController::executeScriptInWorld): Ditto.
  • bindings/js/ScriptController.h: Added enum ShouldAllowXSS. (WebCore::):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::evaluate): Added parameter shouldAllowXSS.
  • bindings/v8/ScriptController.h: Added enum ShouldAllowXSS. (WebCore::):

2010-05-22 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

REGRESSION (r56295): Can't create a new wave on Google Wave
https://bugs.webkit.org/show_bug.cgi?id=39249

Added a test to ensure that we don't raise an alarm when the source code
portion of a JavaScript URL matches some substring of the page URL or
post data.

Our existing test coverage ensures that we raise an alarm when the entire
JavaScript URL matches some substring of the page URL or post data.

  • http/tests/security/xssAuditor/javascript-link-safe-expected.txt: Added.
  • http/tests/security/xssAuditor/javascript-link-safe.html: Added.
  • http/tests/security/xssAuditor/resources/javascript-link-safe.html: Added.
1:45 PM Changeset in webkit [60013] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-22 Jeremy Moskovich <jeremy@chromium.org>

Reviewed by Eric Seidel.

Document RenderObject::m_hasOverflowClip.

https://bugs.webkit.org/show_bug.cgi?id=39425

No new functionality, so no new tests.

  • rendering/RenderObject.h:
1:15 PM Changeset in webkit [60012] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2010-05-22 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Add DragController
https://bugs.webkit.org/show_bug.cgi?id=39400

Add DragController for BREW MP.

  • page/brew/DragControllerBrew.cpp: Added. (WebCore::DragController::isCopyKeyDown): (WebCore::DragController::dragOperation): (WebCore::DragController::maxDragImageSize): (WebCore::DragController::cleanupAfterSystemDrag):
1:03 PM Changeset in webkit [60011] by eric@webkit.org
  • 6 edits in trunk

2010-05-22 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Eric Seidel.

[EFL] Build fix (always compile libraries with -fPIC when compiler
is gcc; always define WTF_USE_PTHREADS).
http://webkit.org/b/39235

  • cmake/OptionsCommon.cmake:
  • cmake/OptionsEfl.cmake:
  • cmake/WebKitHelpers.cmake:

2010-05-22 Leandro Pereira <leandro@profusion.mobi>

Reviewed by Eric Seidel.

[EFL] Build fix (update source code lists).
http://webkit.org/b/39235

  • CMakeLists.txt:
12:12 PM Changeset in webkit [60010] by Martin Robinson
  • 5 edits in trunk

2010-05-22 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] webkit_web_view_drag_end should call EventHandler::dragSourceEndedAt
https://bugs.webkit.org/show_bug.cgi?id=39465

Added a helper function for converting a GDK action bitmask into a DragOperation bitmask.

No new tests as behavior has not changed.

  • platform/gtk/ClipboardUtilitiesGtk.cpp: (WebCore::gdkDragActionToDragOperation): Added.
  • platform/gtk/ClipboardUtilitiesGtk.h:

2010-05-22 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] webkit_web_view_drag_end should call EventHandler::dragSourceEndedAt
https://bugs.webkit.org/show_bug.cgi?id=39465

Properly call EventHandler::dragSourceEndedAt so that dragEnd events are processed in the DOM.
dragSourceEndedAt is responsible for calling the dragEnd DOM event as well as cleaning up assets
(such as the Clipboard) associated with the drag source.

  • webkit/webkitwebview.cpp: (webkit_web_view_drag_end): Remember to call dragSourceEndedAt here.
12:10 PM Changeset in webkit [60009] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-22 Patrick Gansterer <paroga@paroga.com>

Reviewed by Eric Seidel.

[Qt] Cleanup SharedBuffer::createWithContentsOfFile
https://bugs.webkit.org/show_bug.cgi?id=38917

  • platform/qt/SharedBufferQt.cpp: (WebCore::SharedBuffer::createWithContentsOfFile):
11:14 AM Changeset in webkit [60008] by Martin Robinson
  • 4 edits
    2 adds in trunk

2010-05-22 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] WebKit/gtk/WebCoreSupport/DragClientGtk::startDrag should use the Clipboard::sourceOperation
https://bugs.webkit.org/show_bug.cgi?id=39459

Add ClipboardUtilitiesGtk, a container for GTK+/WebCore clipboard utility functions.
Initially add a function which converts a WebCore::DragOperation to a bitmask of
GdkDragActions.

No new tests, because behavior has not changed.

  • GNUmakefile.am:
  • platform/gtk/ClipboardUtilitiesGtk.cpp: Added. (WebCore::dragOperationToGdkDragActions): Added.
  • platform/gtk/ClipboardUtilitiesGtk.h: Added.

2010-05-22 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] WebKit/gtk/WebCoreSupport/DragClientGtk::startDrag should use the Clipboard::sourceOperation
https://bugs.webkit.org/show_bug.cgi?id=39459

  • WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::startDrag): Use Clipboard::sourceOperation instead of trying to figure out the GdkDragAction manually. The DOM may have changed the appropriate list of actions anyhow.
10:59 AM Changeset in webkit [60007] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-22 Eric Seidel <eric@webkit.org>

Unreviewed, fixing test results only.

Disable compositing tests on the commit-queue as a workaround for bug 38912
https://bugs.webkit.org/show_bug.cgi?id=39067

  • Scripts/webkitpy/tool/steps/steps_unittest.py:
    • Update test results after my previous change.
10:55 AM Changeset in webkit [60006] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-22 Eric Seidel <eric@webkit.org>

Unreviewed.

Disable compositing tests on the commit-queue as a workaround for bug 38912
https://bugs.webkit.org/show_bug.cgi?id=39067

  • Scripts/webkitpy/tool/steps/runtests.py:
    • Disable all of compositing, not just compositing/iframes
10:17 AM Changeset in webkit [60005] by tkent@chromium.org
  • 8 edits in trunk

2010-05-22 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Link resources and load Ahem font for Windows
https://bugs.webkit.org/show_bug.cgi?id=39473

  • WebKit.gyp: Add net and webkit resources for Windows. Copy AHEM.TTF to DumpRenderTree.exe directory.

2010-05-22 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Link resources and load Ahem font for Windows
https://bugs.webkit.org/show_bug.cgi?id=39473

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (main): Call platformInit().
  • DumpRenderTree/chromium/TestShell.h: Declare platformInit(). It is not related to TestShell class, but the implementation of paltformInit() is placed at TestShell*.{cpp,mm}.
  • DumpRenderTree/chromium/TestShellGtk.cpp: (platformInit):
  • DumpRenderTree/chromium/TestShellMac.mm: (platformInit):
  • DumpRenderTree/chromium/TestShellWin.cpp: (platformInit):
    • Make stdout/stderr binary mode
    • Load Ahem font
8:58 AM Changeset in webkit [60004] by Simon Fraser
  • 1 edit
    10 moves
    1 add in trunk/LayoutTests

2010-05-22 Simon Fraser <Simon Fraser>

Add test results for Mac; no review.

Add platform-independent test results for new tiling tests, and move them into their own directory.

  • compositing/tiling/huge-layer-add-remove-child-expected.txt: Renamed from LayoutTests/platform/win/compositing/huge-layer-add-remove-child-expected.txt.
  • compositing/tiling/huge-layer-add-remove-child.html: Renamed from LayoutTests/compositing/huge-layer-add-remove-child.html.
  • compositing/tiling/huge-layer-expected.txt: Renamed from LayoutTests/platform/win/compositing/huge-layer-expected.txt.
  • compositing/tiling/huge-layer-resize-expected.txt: Renamed from LayoutTests/platform/win/compositing/huge-layer-resize-expected.txt.
  • compositing/tiling/huge-layer-resize.html: Renamed from LayoutTests/compositing/huge-layer-resize.html.
  • compositing/tiling/huge-layer-with-layer-children-expected.txt: Renamed from LayoutTests/platform/win/compositing/huge-layer-with-layer-children-expected.txt.
  • compositing/tiling/huge-layer-with-layer-children-resize-expected.txt: Renamed from LayoutTests/platform/win/compositing/huge-layer-with-layer-children-resize-expected.txt.
  • compositing/tiling/huge-layer-with-layer-children-resize.html: Renamed from LayoutTests/compositing/huge-layer-with-layer-children-resize.html.
  • compositing/tiling/huge-layer-with-layer-children.html: Renamed from LayoutTests/compositing/huge-layer-with-layer-children.html.
  • compositing/tiling/huge-layer.html: Renamed from LayoutTests/compositing/huge-layer.html.
8:48 AM Changeset in webkit [60003] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

Skip platform/mac/fast/AppleScript/001.html
https://bugs.webkit.org/show_bug.cgi?id=39531

  • platform/mac/Skipped:
2:46 AM Changeset in webkit [60002] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed. Update GTK specific expected file after r59968.

  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt: updated.
12:43 AM Changeset in webkit [60001] by abarth@webkit.org
  • 5 edits in trunk/WebCore

2010-05-21 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Parse attributes with HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=39520

This patch lets the HTML5 lexer parse attributes, as in
<div attr="foo"></div>. This patch is on the critical path to running
the html5lib tests.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
  • html/HTML5Lexer.h:
  • html/HTML5Token.h: (WebCore::HTML5Token::beginStartTag): (WebCore::HTML5Token::beginEndTag): (WebCore::HTML5Token::addNewAttribute): (WebCore::HTML5Token::appendToAttributeName): (WebCore::HTML5Token::appendToAttributeValue): (WebCore::HTML5Token::attributes):
  • html/HTML5Tokenizer.cpp: (WebCore::convertToOldStyle):

May 21, 2010:

11:44 PM Changeset in webkit [60000] by mrowe@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

60,000!

  • ChangeLog: Point out revision 60,000.
11:44 PM Changeset in webkit [59999] by mrowe@apple.com
  • 1 edit in branches/safari-533-branch/WebCore/rendering/style/RenderStyle.h

Merge r59960.

11:43 PM Changeset in webkit [59998] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore/rendering

Merge r59959.

11:43 PM Changeset in webkit [59997] by mrowe@apple.com
  • 1 edit in branches/safari-533-branch/WebCore/rendering/RenderThemeSafari.cpp

Merge r59958.

11:43 PM Changeset in webkit [59996] by mrowe@apple.com
  • 57 edits in branches/safari-533-branch

Merge r59956.

11:39 PM Changeset in webkit [59995] by mrowe@apple.com
  • 4 edits
    1 add in branches/safari-533-branch/WebCore

Merge r59904.

11:39 PM Changeset in webkit [59994] by mrowe@apple.com
  • 10 edits in branches/safari-533-branch

Merge r59966.

11:39 PM Changeset in webkit [59993] by mrowe@apple.com
  • 3 edits
    4 adds in branches/safari-533-branch

Merge r59950.

11:39 PM Changeset in webkit [59992] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59897.

11:39 PM Changeset in webkit [59991] by mrowe@apple.com
  • 4 edits
    2 adds in branches/safari-533-branch

Merge r59962.

10:00 PM Changeset in webkit [59990] by mrowe@apple.com
  • 5 edits in trunk

Versioning.

9:58 PM Changeset in webkit [59989] by mrowe@apple.com
  • 1 copy in tags/Safari-534

New tag.

9:23 PM Changeset in webkit [59988] by hyatt@apple.com
  • 11 edits in trunk/WebCore

Preparation for support of column-span, which will be implemented using continuations. When a block splits an inline, a
continuation chain is created of the form inline -> anonymous block -> inline. The middle block is always anonymous. When a column-span
splits the blocks in a multi-column block, it will create a similar chain: block -> anonymous block -> block. Enclosing split elements
directly connect to their continuations, so their chains will look like inline -> inline or block -> block.

Reviewed by Dan Bernstein.

This patch changes the member variable in RenderBlock, m_inlineContinuation, to simply be m_continuation and loosens up the type on it
to RenderBoxModelObject. This reflects the fact that the continuation of the block can now be another block and isn't always simply an inline.

Some renames have been done for cleanup:

isInlineContinuation -> isInlineElementContinuation to emphasize that this is a split non-anonymous element.
inlineContinuation -> inlineElementContinuation, again to emphasize that the inline is not anonymous.


Some new methods have been added:

isBlockElementContinuation - just like isInlineElementContinuation but for split block elements.
blockElementContinuation - just like inlineElementContinuation but for split block elements.
virtualContinuation - A way to just walk an entire continuation chain of mixed types (blocks and inlines) using their common base class.
isAnonymousBlockContinuation - A method for asking if a RenderBlock is an anonymous block in the continuation chain (the guy in the middle).


Code that was specific to the anonymous blocks in a continuation chain has been patched to ask isAnonymousBlockContinuation, so that it won't
incorrectly apply to non-anonymous blocks in the future. Where possible, code that really didn't care about being an inline vs. a block has
been broadened so that it will work with block continuations as well.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::lastChildConsideringContinuation):
(WebCore::startOfContinuations):
(WebCore::endOfContinuations):
(WebCore::childBeforeConsideringContinuations):
(WebCore::firstChildIsInlineContinuation):
(WebCore::AccessibilityRenderObject::nextSibling):
(WebCore::AccessibilityRenderObject::anchorElement):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
(WebCore::InlineFlowBox::paint):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::RenderBlock):
(WebCore::RenderBlock::destroy):
(WebCore::RenderBlock::removeLeftoverAnonymousBlock):
(WebCore::RenderBlock::removeChild):
(WebCore::RenderBlock::paintObject):
(WebCore::RenderBlock::inlineElementContinuation):
(WebCore::RenderBlock::blockElementContinuation):
(WebCore::RenderBlock::addContinuationWithOutline):
(WebCore::RenderBlock::absoluteRects):
(WebCore::RenderBlock::absoluteQuads):
(WebCore::RenderBlock::rectWithOutlineForRepaint):
(WebCore::RenderBlock::hoverAncestor):
(WebCore::RenderBlock::updateDragState):
(WebCore::RenderBlock::outlineStyleForRepaint):
(WebCore::RenderBlock::updateHitTestResult):
(WebCore::RenderBlock::addFocusRingRects):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::continuation):
(WebCore::RenderBlock::setContinuation):
(WebCore::RenderBlock::virtualContinuation):
(WebCore::RenderBlock::isAnonymousBlockContinuation):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::inlineElementContinuation):
(WebCore::RenderInline::styleDidChange):
(WebCore::nextContinuation):
(WebCore::RenderInline::splitInlines):
(WebCore::RenderInline::positionForPoint):
(WebCore::RenderInline::updateHitTestResult):

  • rendering/RenderInline.h:

(WebCore::RenderInline::setContinuation):
(WebCore::RenderInline::virtualContinuation):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isElementContinuation):
(WebCore::RenderObject::isInlineElementContinuation):
(WebCore::RenderObject::isBlockElementContinuation):
(WebCore::RenderObject::virtualContinuation):

  • rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::updateBeforeAfterContent):

  • rendering/RenderRubyBase.cpp:

(WebCore::RenderRubyBase::moveBlockChildren):

8:16 PM Changeset in webkit [59987] by jamesr@google.com
  • 5 edits
    186 copies
    191 adds in trunk/LayoutTests

2010-05-21 James Robinson <jamesr@chromium.org>

Unreviewed pixel rebaseline

Update pixel test expectations for LayoutTests/svg to account for Leopard-SnowLeopard differences
https://bugs.webkit.org/show_bug.cgi?id=39317

This patch fixes the pixel test expecations for svg/ tests to work on Snow Leopard.
Specifically, for each test that currently passes on Leopard with -p --tolerance=0,
but fails with small diffs on Snow Leopard, the old expectation is moved from
platform/mac to platform/mac-leopard and a new expecation is added in
platform/mac.

  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-36-t-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-37-t-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-37-t-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-37-t-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-37-t-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-39-t-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-39-t-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-41-t-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-41-t-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-46-t-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-46-t-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-46-t-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-46-t-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-60-t-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-60-t-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-60-t-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-60-t-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-61-t-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-61-t-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-61-t-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-61-t-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-62-t-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-62-t-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-62-t-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-62-t-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-63-t-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-63-t-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-63-t-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-63-t-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-65-t-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-65-t-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-65-t-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-65-t-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-66-t-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-66-t-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-66-t-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-66-t-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-67-t-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-67-t-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-67-t-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-67-t-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-68-t-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-68-t-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-68-t-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-68-t-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-69-t-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-69-t-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-69-t-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-69-t-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-70-t-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-70-t-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-70-t-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-70-t-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-77-t-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-77-t-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-77-t-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-77-t-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-78-t-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-78-t-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-78-t-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-78-t-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-80-t-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-81-t-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-81-t-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-81-t-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-81-t-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-83-t-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-83-t-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-83-t-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-83-t-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/coords-units-01-b-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/coords-units-01-b-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/coords-units-01-b-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/coords-units-01-b-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/coords-units-02-b-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/coords-units-02-b-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/coords-units-02-b-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/coords-units-02-b-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/coords-units-03-b-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/coords-units-03-b-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/coords-units-03-b-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/coords-units-03-b-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-image-01-b-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/linking-a-05-t-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/linking-a-05-t-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/linking-a-05-t-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/linking-a-05-t-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/linking-uri-01-b-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/linking-uri-01-b-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/linking-uri-01-b-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/linking-uri-01-b-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/linking-uri-02-b-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/linking-uri-02-b-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/linking-uri-02-b-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/linking-uri-02-b-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/linking-uri-03-t-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/linking-uri-03-t-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/linking-uri-03-t-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/linking-uri-03-t-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/script-handle-01-b-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/script-handle-01-b-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/script-handle-01-b-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/script-handle-01-b-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/struct-frag-06-t-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/struct-frag-06-t-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/struct-frag-06-t-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/struct-frag-06-t-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/text-text-04-t-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-text-04-t-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/text-text-04-t-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-text-04-t-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/text-text-05-t-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-text-05-t-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/text-text-05-t-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-text-05-t-expected.png.
  • platform/mac-leopard/svg/W3C-SVG-1.1/text-tselect-02-f-expected.checksum: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-tselect-02-f-expected.checksum.
  • platform/mac-leopard/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png.
  • platform/mac-leopard/svg/batik: Added.
  • platform/mac-leopard/svg/batik/filters: Added.
  • platform/mac-leopard/svg/batik/filters/feTile-expected.checksum: Copied from LayoutTests/platform/mac/svg/batik/filters/feTile-expected.checksum.
  • platform/mac-leopard/svg/batik/filters/feTile-expected.png: Copied from LayoutTests/platform/mac/svg/batik/filters/feTile-expected.png.
  • platform/mac-leopard/svg/batik/paints: Added.
  • platform/mac-leopard/svg/batik/paints/patternRegions-expected.checksum: Copied from LayoutTests/platform/mac/svg/batik/paints/patternRegions-expected.checksum.
  • platform/mac-leopard/svg/batik/paints/patternRegions-expected.png: Copied from LayoutTests/platform/mac/svg/batik/paints/patternRegions-expected.png.
  • platform/mac-leopard/svg/batik/text: Added.
  • platform/mac-leopard/svg/batik/text/textAnchor3-expected.checksum: Copied from LayoutTests/platform/mac/svg/batik/text/textAnchor3-expected.checksum.
  • platform/mac-leopard/svg/batik/text/textAnchor3-expected.png: Copied from LayoutTests/platform/mac/svg/batik/text/textAnchor3-expected.png.
  • platform/mac-leopard/svg/batik/text/textLayout-expected.checksum: Copied from LayoutTests/platform/mac/svg/batik/text/textLayout-expected.checksum.
  • platform/mac-leopard/svg/batik/text/textLayout-expected.png: Copied from LayoutTests/platform/mac/svg/batik/text/textLayout-expected.png.
  • platform/mac-leopard/svg/batik/text/textLength-expected.checksum: Copied from LayoutTests/platform/mac/svg/batik/text/textLength-expected.checksum.
  • platform/mac-leopard/svg/batik/text/textLength-expected.png: Copied from LayoutTests/platform/mac/svg/batik/text/textLength-expected.png.
  • platform/mac-leopard/svg/batik/text/textOnPath-expected.checksum: Copied from LayoutTests/platform/mac/svg/batik/text/textOnPath-expected.checksum.
  • platform/mac-leopard/svg/batik/text/textOnPath-expected.png: Copied from LayoutTests/platform/mac/svg/batik/text/textOnPath-expected.png.
  • platform/mac-leopard/svg/batik/text/textOnPath2-expected.checksum: Copied from LayoutTests/platform/mac/svg/batik/text/textOnPath2-expected.checksum.
  • platform/mac-leopard/svg/batik/text/textOnPath2-expected.png: Copied from LayoutTests/platform/mac/svg/batik/text/textOnPath2-expected.png.
  • platform/mac-leopard/svg/batik/text/textOnPathSpaces-expected.checksum: Copied from LayoutTests/platform/mac/svg/batik/text/textOnPathSpaces-expected.checksum.
  • platform/mac-leopard/svg/batik/text/textOnPathSpaces-expected.png: Copied from LayoutTests/platform/mac/svg/batik/text/textOnPathSpaces-expected.png.
  • platform/mac-leopard/svg/batik/text/textPCDATA-expected.checksum: Copied from LayoutTests/platform/mac/svg/batik/text/textPCDATA-expected.checksum.
  • platform/mac-leopard/svg/batik/text/textPCDATA-expected.png: Copied from LayoutTests/platform/mac/svg/batik/text/textPCDATA-expected.png.
  • platform/mac-leopard/svg/batik/text/textProperties-expected.checksum: Copied from LayoutTests/platform/mac/svg/batik/text/textProperties-expected.checksum.
  • platform/mac-leopard/svg/batik/text/textProperties-expected.png: Copied from LayoutTests/platform/mac/svg/batik/text/textProperties-expected.png.
  • platform/mac-leopard/svg/batik/text/verticalTextOnPath-expected.checksum: Copied from LayoutTests/platform/mac/svg/batik/text/verticalTextOnPath-expected.checksum.
  • platform/mac-leopard/svg/batik/text/verticalTextOnPath-expected.png: Copied from LayoutTests/platform/mac/svg/batik/text/verticalTextOnPath-expected.png.
  • platform/mac-leopard/svg/batik/text/xmlSpace-expected.checksum: Copied from LayoutTests/platform/mac/svg/batik/text/xmlSpace-expected.checksum.
  • platform/mac-leopard/svg/batik/text/xmlSpace-expected.png: Copied from LayoutTests/platform/mac/svg/batik/text/xmlSpace-expected.png.
  • platform/mac-leopard/svg/custom/altglyph-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/altglyph-expected.checksum.
  • platform/mac-leopard/svg/custom/altglyph-expected.png: Copied from LayoutTests/platform/mac/svg/custom/altglyph-expected.png.
  • platform/mac-leopard/svg/custom/baseval-animval-equality-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/baseval-animval-equality-expected.checksum.
  • platform/mac-leopard/svg/custom/baseval-animval-equality-expected.png: Copied from LayoutTests/platform/mac/svg/custom/baseval-animval-equality-expected.png.
  • platform/mac-leopard/svg/custom/clip-path-referencing-use-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/clip-path-referencing-use-expected.checksum.
  • platform/mac-leopard/svg/custom/clip-path-referencing-use-expected.png: Copied from LayoutTests/platform/mac/svg/custom/clip-path-referencing-use-expected.png.
  • platform/mac-leopard/svg/custom/clip-path-referencing-use2-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/clip-path-referencing-use2-expected.checksum.
  • platform/mac-leopard/svg/custom/clip-path-referencing-use2-expected.png: Copied from LayoutTests/platform/mac/svg/custom/clip-path-referencing-use2-expected.png.
  • platform/mac-leopard/svg/custom/dominant-baseline-hanging-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/dominant-baseline-hanging-expected.checksum.
  • platform/mac-leopard/svg/custom/dominant-baseline-hanging-expected.png: Copied from LayoutTests/platform/mac/svg/custom/dominant-baseline-hanging-expected.png.
  • platform/mac-leopard/svg/custom/feComponentTransfer-Discrete-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/feComponentTransfer-Discrete-expected.checksum.
  • platform/mac-leopard/svg/custom/feComponentTransfer-Discrete-expected.png: Copied from LayoutTests/platform/mac/svg/custom/feComponentTransfer-Discrete-expected.png.
  • platform/mac-leopard/svg/custom/feComponentTransfer-Gamma-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/feComponentTransfer-Gamma-expected.checksum.
  • platform/mac-leopard/svg/custom/feComponentTransfer-Gamma-expected.png: Copied from LayoutTests/platform/mac/svg/custom/feComponentTransfer-Gamma-expected.png.
  • platform/mac-leopard/svg/custom/feComponentTransfer-Linear-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/feComponentTransfer-Linear-expected.checksum.
  • platform/mac-leopard/svg/custom/feComponentTransfer-Linear-expected.png: Copied from LayoutTests/platform/mac/svg/custom/feComponentTransfer-Linear-expected.png.
  • platform/mac-leopard/svg/custom/feComponentTransfer-Table-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/feComponentTransfer-Table-expected.checksum.
  • platform/mac-leopard/svg/custom/feComponentTransfer-Table-expected.png: Copied from LayoutTests/platform/mac/svg/custom/feComponentTransfer-Table-expected.png.
  • platform/mac-leopard/svg/custom/fill-fallback-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/fill-fallback-expected.checksum.
  • platform/mac-leopard/svg/custom/fill-fallback-expected.png: Copied from LayoutTests/platform/mac/svg/custom/fill-fallback-expected.png.
  • platform/mac-leopard/svg/custom/getPresentationAttribute-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/getPresentationAttribute-expected.checksum.
  • platform/mac-leopard/svg/custom/getPresentationAttribute-expected.png: Copied from LayoutTests/platform/mac/svg/custom/getPresentationAttribute-expected.png.
  • platform/mac-leopard/svg/custom/getsvgdocument-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/getsvgdocument-expected.checksum.
  • platform/mac-leopard/svg/custom/getsvgdocument-expected.png: Copied from LayoutTests/platform/mac/svg/custom/getsvgdocument-expected.png.
  • platform/mac-leopard/svg/custom/image-parent-translation-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/image-parent-translation-expected.checksum.
  • platform/mac-leopard/svg/custom/image-parent-translation-expected.png: Copied from LayoutTests/platform/mac/svg/custom/image-parent-translation-expected.png.
  • platform/mac-leopard/svg/custom/invalid-fill-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/invalid-fill-expected.checksum.
  • platform/mac-leopard/svg/custom/invalid-fill-expected.png: Copied from LayoutTests/platform/mac/svg/custom/invalid-fill-expected.png.
  • platform/mac-leopard/svg/custom/invalid-fill-hex-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/invalid-fill-hex-expected.checksum.
  • platform/mac-leopard/svg/custom/invalid-fill-hex-expected.png: Copied from LayoutTests/platform/mac/svg/custom/invalid-fill-hex-expected.png.
  • platform/mac-leopard/svg/custom/invisible-text-after-scrolling-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/invisible-text-after-scrolling-expected.checksum.
  • platform/mac-leopard/svg/custom/invisible-text-after-scrolling-expected.png: Copied from LayoutTests/platform/mac/svg/custom/invisible-text-after-scrolling-expected.png.
  • platform/mac-leopard/svg/custom/percentage-of-html-parent-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/percentage-of-html-parent-expected.checksum.
  • platform/mac-leopard/svg/custom/percentage-of-html-parent-expected.png: Copied from LayoutTests/platform/mac/svg/custom/percentage-of-html-parent-expected.png.
  • platform/mac-leopard/svg/custom/pointer-events-image-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/pointer-events-image-expected.checksum.
  • platform/mac-leopard/svg/custom/pointer-events-image-expected.png: Copied from LayoutTests/platform/mac/svg/custom/pointer-events-image-expected.png.
  • platform/mac-leopard/svg/custom/pointer-events-text-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/pointer-events-text-expected.checksum.
  • platform/mac-leopard/svg/custom/pointer-events-text-expected.png: Copied from LayoutTests/platform/mac/svg/custom/pointer-events-text-expected.png.
  • platform/mac-leopard/svg/custom/relative-sized-content-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/relative-sized-content-expected.checksum.
  • platform/mac-leopard/svg/custom/relative-sized-content-expected.png: Copied from LayoutTests/platform/mac/svg/custom/relative-sized-content-expected.png.
  • platform/mac-leopard/svg/custom/relative-sized-deep-shadow-tree-content-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/relative-sized-deep-shadow-tree-content-expected.checksum.
  • platform/mac-leopard/svg/custom/relative-sized-deep-shadow-tree-content-expected.png: Copied from LayoutTests/platform/mac/svg/custom/relative-sized-deep-shadow-tree-content-expected.png.
  • platform/mac-leopard/svg/custom/relative-sized-shadow-tree-content-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/relative-sized-shadow-tree-content-expected.checksum.
  • platform/mac-leopard/svg/custom/relative-sized-shadow-tree-content-expected.png: Copied from LayoutTests/platform/mac/svg/custom/relative-sized-shadow-tree-content-expected.png.
  • platform/mac-leopard/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.checksum.
  • platform/mac-leopard/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png: Copied from LayoutTests/platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png.
  • platform/mac-leopard/svg/custom/rootmost-svg-xy-attrs-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/rootmost-svg-xy-attrs-expected.checksum.
  • platform/mac-leopard/svg/custom/rootmost-svg-xy-attrs-expected.png: Copied from LayoutTests/platform/mac/svg/custom/rootmost-svg-xy-attrs-expected.png.
  • platform/mac-leopard/svg/custom/shape-rendering-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/shape-rendering-expected.checksum.
  • platform/mac-leopard/svg/custom/shape-rendering-expected.png: Copied from LayoutTests/platform/mac/svg/custom/shape-rendering-expected.png.
  • platform/mac-leopard/svg/custom/stroke-fallback-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/stroke-fallback-expected.checksum.
  • platform/mac-leopard/svg/custom/stroke-fallback-expected.png: Copied from LayoutTests/platform/mac/svg/custom/stroke-fallback-expected.png.
  • platform/mac-leopard/svg/custom/svg-float-border-padding-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/svg-float-border-padding-expected.checksum.
  • platform/mac-leopard/svg/custom/svg-float-border-padding-expected.png: Copied from LayoutTests/platform/mac/svg/custom/svg-float-border-padding-expected.png.
  • platform/mac-leopard/svg/filters/feGaussianBlur-expected.checksum: Copied from LayoutTests/platform/mac/svg/filters/feGaussianBlur-expected.checksum.
  • platform/mac-leopard/svg/filters/feGaussianBlur-expected.png: Copied from LayoutTests/platform/mac/svg/filters/feGaussianBlur-expected.png.
  • platform/mac-leopard/svg/filters/shadow-on-filter-expected.checksum: Copied from LayoutTests/platform/mac/svg/filters/shadow-on-filter-expected.checksum.
  • platform/mac-leopard/svg/filters/shadow-on-filter-expected.png: Copied from LayoutTests/platform/mac/svg/filters/shadow-on-filter-expected.png.
  • platform/mac-leopard/svg/hixie/links: Added.
  • platform/mac-leopard/svg/text/kerning-expected.checksum: Copied from LayoutTests/platform/mac/svg/text/kerning-expected.checksum.
  • platform/mac-leopard/svg/text/kerning-expected.png: Copied from LayoutTests/platform/mac/svg/text/kerning-expected.png.
  • platform/mac-leopard/svg/text/multichar-glyph-expected.checksum: Copied from LayoutTests/platform/mac/svg/text/multichar-glyph-expected.checksum.
  • platform/mac-leopard/svg/text/multichar-glyph-expected.png: Copied from LayoutTests/platform/mac/svg/text/multichar-glyph-expected.png.
  • platform/mac-leopard/svg/text/text-repaint-rects-expected.checksum: Copied from LayoutTests/platform/mac/svg/text/text-repaint-rects-expected.checksum.
  • platform/mac-leopard/svg/text/text-repaint-rects-expected.png: Copied from LayoutTests/platform/mac/svg/text/text-repaint-rects-expected.png.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-37-t-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-37-t-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-39-t-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-41-t-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-46-t-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-46-t-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-60-t-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-60-t-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-61-t-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-61-t-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-62-t-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-62-t-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-63-t-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-63-t-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-65-t-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-65-t-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-66-t-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-66-t-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-67-t-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-67-t-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-68-t-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-68-t-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-69-t-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-69-t-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-70-t-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-70-t-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-77-t-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-77-t-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-78-t-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-78-t-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-81-t-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-81-t-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-83-t-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-83-t-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/coords-units-01-b-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/coords-units-01-b-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/coords-units-02-b-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/coords-units-02-b-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/coords-units-03-b-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/coords-units-03-b-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/linking-a-05-t-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/linking-a-05-t-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/linking-uri-01-b-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/linking-uri-01-b-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/linking-uri-02-b-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/linking-uri-02-b-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/linking-uri-03-t-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/linking-uri-03-t-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/script-handle-01-b-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/script-handle-01-b-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-06-t-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-06-t-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/text-text-04-t-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/text-text-04-t-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/text-text-05-t-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/text-text-05-t-expected.png: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/text-tselect-02-f-expected.checksum: Replaced.
  • platform/mac/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png: Replaced.
  • platform/mac/svg/batik/filters/feTile-expected.checksum: Replaced.
  • platform/mac/svg/batik/filters/feTile-expected.png: Replaced.
  • platform/mac/svg/batik/paints/patternRegions-expected.checksum: Replaced.
  • platform/mac/svg/batik/paints/patternRegions-expected.png: Replaced.
  • platform/mac/svg/batik/text/textAnchor3-expected.checksum: Replaced.
  • platform/mac/svg/batik/text/textAnchor3-expected.png: Replaced.
  • platform/mac/svg/batik/text/textLayout-expected.checksum: Replaced.
  • platform/mac/svg/batik/text/textLayout-expected.png: Replaced.
  • platform/mac/svg/batik/text/textLength-expected.checksum: Replaced.
  • platform/mac/svg/batik/text/textLength-expected.png: Replaced.
  • platform/mac/svg/batik/text/textOnPath-expected.checksum: Replaced.
  • platform/mac/svg/batik/text/textOnPath-expected.png: Replaced.
  • platform/mac/svg/batik/text/textOnPath2-expected.checksum: Replaced.
  • platform/mac/svg/batik/text/textOnPath2-expected.png: Replaced.
  • platform/mac/svg/batik/text/textOnPathSpaces-expected.checksum: Replaced.
  • platform/mac/svg/batik/text/textOnPathSpaces-expected.png: Replaced.
  • platform/mac/svg/batik/text/textPCDATA-expected.checksum: Replaced.
  • platform/mac/svg/batik/text/textPCDATA-expected.png: Replaced.
  • platform/mac/svg/batik/text/textProperties-expected.checksum: Replaced.
  • platform/mac/svg/batik/text/textProperties-expected.png: Replaced.
  • platform/mac/svg/batik/text/verticalTextOnPath-expected.checksum: Replaced.
  • platform/mac/svg/batik/text/verticalTextOnPath-expected.png: Replaced.
  • platform/mac/svg/batik/text/xmlSpace-expected.checksum: Replaced.
  • platform/mac/svg/batik/text/xmlSpace-expected.png: Replaced.
  • platform/mac/svg/custom/altglyph-expected.checksum: Replaced.
  • platform/mac/svg/custom/altglyph-expected.png: Replaced.
  • platform/mac/svg/custom/baseval-animval-equality-expected.checksum: Replaced.
  • platform/mac/svg/custom/baseval-animval-equality-expected.png: Replaced.
  • platform/mac/svg/custom/clip-path-referencing-use-expected.checksum: Replaced.
  • platform/mac/svg/custom/clip-path-referencing-use-expected.png: Replaced.
  • platform/mac/svg/custom/clip-path-referencing-use2-expected.checksum: Replaced.
  • platform/mac/svg/custom/clip-path-referencing-use2-expected.png: Replaced.
  • platform/mac/svg/custom/container-opacity-clip-viewBox-expected.checksum:
  • platform/mac/svg/custom/container-opacity-clip-viewBox-expected.png:
  • platform/mac/svg/custom/dominant-baseline-hanging-expected.checksum: Replaced.
  • platform/mac/svg/custom/dominant-baseline-hanging-expected.png: Replaced.
  • platform/mac/svg/custom/feComponentTransfer-Discrete-expected.checksum: Replaced.
  • platform/mac/svg/custom/feComponentTransfer-Discrete-expected.png: Replaced.
  • platform/mac/svg/custom/feComponentTransfer-Gamma-expected.checksum: Replaced.
  • platform/mac/svg/custom/feComponentTransfer-Gamma-expected.png: Replaced.
  • platform/mac/svg/custom/feComponentTransfer-Linear-expected.checksum: Replaced.
  • platform/mac/svg/custom/feComponentTransfer-Linear-expected.png: Replaced.
  • platform/mac/svg/custom/feComponentTransfer-Table-expected.checksum: Replaced.
  • platform/mac/svg/custom/feComponentTransfer-Table-expected.png: Replaced.
  • platform/mac/svg/custom/fill-fallback-expected.checksum: Replaced.
  • platform/mac/svg/custom/fill-fallback-expected.png: Replaced.
  • platform/mac/svg/custom/getPresentationAttribute-expected.checksum: Replaced.
  • platform/mac/svg/custom/getPresentationAttribute-expected.png: Replaced.
  • platform/mac/svg/custom/getsvgdocument-expected.checksum: Replaced.
  • platform/mac/svg/custom/getsvgdocument-expected.png: Replaced.
  • platform/mac/svg/custom/image-parent-translation-expected.checksum: Replaced.
  • platform/mac/svg/custom/image-parent-translation-expected.png: Replaced.
  • platform/mac/svg/custom/invalid-fill-expected.checksum: Replaced.
  • platform/mac/svg/custom/invalid-fill-expected.png: Replaced.
  • platform/mac/svg/custom/invalid-fill-hex-expected.checksum: Replaced.
  • platform/mac/svg/custom/invalid-fill-hex-expected.png: Replaced.
  • platform/mac/svg/custom/invisible-text-after-scrolling-expected.checksum: Replaced.
  • platform/mac/svg/custom/invisible-text-after-scrolling-expected.png: Replaced.
  • platform/mac/svg/custom/percentage-of-html-parent-expected.checksum: Replaced.
  • platform/mac/svg/custom/percentage-of-html-parent-expected.png: Replaced.
  • platform/mac/svg/custom/pointer-events-image-expected.checksum: Replaced.
  • platform/mac/svg/custom/pointer-events-image-expected.png: Replaced.
  • platform/mac/svg/custom/pointer-events-text-expected.checksum: Replaced.
  • platform/mac/svg/custom/pointer-events-text-expected.png: Replaced.
  • platform/mac/svg/custom/relative-sized-content-expected.checksum: Replaced.
  • platform/mac/svg/custom/relative-sized-content-expected.png: Replaced.
  • platform/mac/svg/custom/relative-sized-deep-shadow-tree-content-expected.checksum: Replaced.
  • platform/mac/svg/custom/relative-sized-deep-shadow-tree-content-expected.png: Replaced.
  • platform/mac/svg/custom/relative-sized-shadow-tree-content-expected.checksum: Replaced.
  • platform/mac/svg/custom/relative-sized-shadow-tree-content-expected.png: Replaced.
  • platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.checksum: Replaced.
  • platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png: Replaced.
  • platform/mac/svg/custom/rootmost-svg-xy-attrs-expected.checksum: Replaced.
  • platform/mac/svg/custom/rootmost-svg-xy-attrs-expected.png: Replaced.
  • platform/mac/svg/custom/shape-rendering-expected.checksum: Replaced.
  • platform/mac/svg/custom/shape-rendering-expected.png: Replaced.
  • platform/mac/svg/custom/stroke-fallback-expected.checksum: Replaced.
  • platform/mac/svg/custom/stroke-fallback-expected.png: Replaced.
  • platform/mac/svg/custom/svg-float-border-padding-expected.checksum: Replaced.
  • platform/mac/svg/custom/svg-float-border-padding-expected.png: Replaced.
  • platform/mac/svg/filters/feGaussianBlur-expected.checksum: Replaced.
  • platform/mac/svg/filters/feGaussianBlur-expected.png: Replaced.
  • platform/mac/svg/filters/shadow-on-filter-expected.checksum: Replaced.
  • platform/mac/svg/filters/shadow-on-filter-expected.png: Replaced.
  • platform/mac/svg/hixie/links/003-broken-expected.checksum:
  • platform/mac/svg/hixie/links/003-broken-expected.png:
  • platform/mac/svg/text/kerning-expected.checksum: Replaced.
  • platform/mac/svg/text/kerning-expected.png: Replaced.
  • platform/mac/svg/text/multichar-glyph-expected.checksum: Replaced.
  • platform/mac/svg/text/multichar-glyph-expected.png: Replaced.
  • platform/mac/svg/text/text-repaint-rects-expected.checksum: Replaced.
  • platform/mac/svg/text/text-repaint-rects-expected.png: Replaced.
8:04 PM Changeset in webkit [59986] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-05-21 Eric Seidel <eric@webkit.org>

Unreviewed, EWS build fix only.

QueueStatusServer returns 500 error when EWS bots post empty queues
https://bugs.webkit.org/show_bug.cgi?id=39523

Mac python seems to have some built-in timezone support
however other python installs don't. So we need to ignore
timezones in our parsing.

Date parsing is tested by existing unit tests.

  • QueueStatusServer/handlers/updateworkitems.py:
    • Fix typo causing exception on server.
  • Scripts/webkitpy/common/net/bugzilla.py:
    • Fix exception due to python's lack of timezone support.
6:56 PM Changeset in webkit [59985] by eric@webkit.org
  • 4 edits in trunk/WebKitTools

2010-05-21 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

QueueStatusServer returns 500 error when EWS bots post empty queues
https://bugs.webkit.org/show_bug.cgi?id=39523

updateworkitems handler was raising an exception because
int() couldn't convert "" to a number.

I attempted to unit test this but we don't yet have a system by
which to load unit tests for appengine classes which depend on
google.appengine libraries which are not in the python default install.

We'll need to write a wrapper script to load those into the python path
and then run the unit test files.

  • QueueStatusServer/handlers/statusbubble.py:
    • Hide cr-win-ews since we're not currently running this bot.
  • QueueStatusServer/handlers/updateworkitems.py:
    • Fix the parsing logic to be able to understand "".
  • Scripts/webkitpy/common/net/statusserver.py:
    • Only log the work items posted to the server to the debug log channel.
6:55 PM Changeset in webkit [59984] by mrowe@apple.com
  • 8 edits
    2 adds in trunk

Teach WebKit2 to build in the Production configuration.

Reviewed by Oliver Hunt.

WebCore:

  • Configurations/WebCore.xcconfig: Pass -allowable_client to the linker in all configurations.

WebKit2:

  • Configurations/Base.xcconfig: Restrict WebKit2 to Intel, and disable the order file.
  • Configurations/BaseTarget.xcconfig: Fix the path to the umbrella framework directory.

This path is used to locate WebCore.framework, so it needs to be relative to WebKit.framework
rather than WebKit2.framework.

  • Configurations/WebKit2.xcconfig: Update the install path. Add an exports file.
  • Configurations/WebProcess.xcconfig: Update the install path.
  • WebKit2.xcodeproj/project.pbxproj: Add a Production configuration.
  • mac/WebKit2.exp: Added.
6:49 PM Changeset in webkit [59983] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

"asm volatile" isn't valid outside of functions.

Reviewed by Gavin Barraclough.

6:23 PM Changeset in webkit [59982] by cmarrin@apple.com
  • 8 edits
    14 adds in trunk

Implement tiled compositing layers on Windows
https://bugs.webkit.org/show_bug.cgi?id=39461


This adds a tiling implementation similar (from a GraphicsLayer standpoint)
to the one for Mac. But where Mac uses the existing CATiledLayer, I've had
to implement one. If a layer is greater then 2k x 2k, I split it into an
array of 512 x 512 tiles. These tiles are positioned in the correct place
for the TiledLayer's content. When setNeedsDisplay is called on the TiledLayer
the tiles' setNeedDisplay methods are called. Each tile clips and positions the
CGContext appropriately and then renders the layer.


I also got rid of all frame()/setFrame() API to reduce the number of calls to
override for tiling.


Much optimization is possible. Most significantly right now all tiles are
rendered whether visible or not. We need to only render tiles that are
currently visible.

Tests: compositing/huge-layer-add-remove-child.html

compositing/huge-layer-resize.html
compositing/huge-layer-with-layer-children-resize.html
compositing/huge-layer-with-layer-children.html
compositing/huge-layer.html

6:17 PM Changeset in webkit [59981] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-21 Eric Seidel <eric@webkit.org>

Unreviewed, fixing the commit-queue to run again.

Make the EWSes report queue position in white bubbles
https://bugs.webkit.org/show_bug.cgi?id=39519

  • Scripts/webkitpy/common/net/statusserver.py:
    • Fix exception in _post_work_items_to_server when passed integers. Unfortunately we have no good way to mock the Browser object yet, and after several attempts I was not able to create a good one, so no tests. :(
5:55 PM Changeset in webkit [59980] by barraclough@apple.com
  • 4 edits in trunk/JavaScriptCore

Unreviewed build fix.

Interpreter fix following r59974.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • runtime/JSPropertyNameIterator.cpp:

(JSC::JSPropertyNameIterator::get):

  • runtime/JSPropertyNameIterator.h:
5:31 PM Changeset in webkit [59979] by ojan@chromium.org
  • 3 edits in trunk/WebKitTools

2010-05-14 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

webkit-patch land --squash commits too much if branch is not up to date
https://bugs.webkit.org/show_bug.cgi?id=38852

  • Scripts/webkitpy/common/checkout/scm.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
5:27 PM Changeset in webkit [59978] by eric@webkit.org
  • 9 edits in trunk/WebKitTools

2010-05-21 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Make the EWSes report queue position in white bubbles
https://bugs.webkit.org/show_bug.cgi?id=39519

This also fixes sorting of commit-queue patches
to be in order of patch attachment.
https://bugs.webkit.org/show_bug.cgi?id=33395

This makes the various Queues post what patches they are about to process
so that we can display a list of patches on status server pages, as well
as report queue position in status bubbles.

This is the first step towards creating a control-channel for the queues.
Next step will be to have them read back the patches in order from the server
and finally we will add the ability for the server to control that order.

  • Scripts/webkitpy/common/net/bugzilla.py:
    • Teach bugzilla how to parse attach_date for attachments.
  • Scripts/webkitpy/common/net/bugzilla_unittest.py:
    • Test that we're parsing dates correctly. This may have timezone issues for non-PST contributers, unsure.
  • Scripts/webkitpy/common/net/statusserver.py:
    • Post work items to the status server for display.
  • Scripts/webkitpy/tool/bot/patchcollection.py:
    • Call StatusServer.update_work_items
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
    • Update unit test results now that we're posting work item list.
  • Scripts/webkitpy/tool/commands/queues.py:
    • Call StatusSever.update_work_items
    • Sort patches so that the server's list understands that the commit-queue gives priority to rollout patches.
    • I also fixed patch sorting per bug 33395 while I was here.
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
    • Update results after update_work_items changes.
    • Test attachment sorting.
  • Scripts/webkitpy/tool/mocktool.py:
    • Add mock for update_work_items
5:00 PM Changeset in webkit [59977] by ggaren@apple.com
  • 3 edits
    2 adds in trunk

2010-05-21 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

Fixed a typo in my last commit: Reset m_inEvaluateInWorld to
wasInEvaluateInWorld, rather than false, to avoid stomping the old value
when it's true.
https://bugs.webkit.org/show_bug.cgi?id=39518

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld):

2010-05-21 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

Added a test for a typo in my last commit.
https://bugs.webkit.org/show_bug.cgi?id=39518

  • inspector/arobens-test-expected.txt: Added.
  • inspector/arobens-test.html: Added. Verify that the first script evaluation doesn't stomp over the bit of state saying that we're a nested script evaluation.
4:55 PM Changeset in webkit [59976] by jparent@chromium.org
  • 7 edits in trunk/LayoutTests

Unreviewed. Updating test expectations for chromium due to http://trac.webkit.org/changeset/59968.

  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
4:52 PM Changeset in webkit [59975] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Interpreter fix following r59939.

Rubber stamped by Oliver Hunt.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

4:49 PM Changeset in webkit [59974] by barraclough@apple.com
  • 15 edits in trunk/JavaScriptCore

Unreviewed build fix.

Patch by David Levin <levin@chromium.org> on 2010-05-21

  • wtf/SizeLimits.cpp: Removed a check while I figure out how to write it properly.
4:37 PM Changeset in webkit [59973] by jparent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

Updating Chromium test_expectations to mark drop-link test as failing in win debug.

  • platform/chromium/test_expectations.txt:
4:34 PM Changeset in webkit [59972] by victorw@chromium.org
  • 1 edit
    7 adds in trunk/LayoutTests

2010-05-21 Victor Wang <victorw@chromium.org>

Unreviewed. Update test expectations for chromium.

  • platform/chromium-linux/fast/lists/alpha-boundary-values-expected.checksum: Added.
  • platform/chromium-linux/fast/lists/alpha-boundary-values-expected.png: Added.
  • platform/chromium-mac/fast/lists/alpha-boundary-values-expected.checksum: Added.
  • platform/chromium-mac/fast/lists/alpha-boundary-values-expected.png: Added.
  • platform/chromium-win/fast/lists/alpha-boundary-values-expected.checksum: Added.
  • platform/chromium-win/fast/lists/alpha-boundary-values-expected.png: Added.
  • platform/chromium-win/fast/lists/alpha-boundary-values-expected.txt: Added.
4:19 PM Changeset in webkit [59971] by jparent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

Updating Chromium test_expectations to mark two websockets tests as failing in debug mode.

  • platform/chromium/test_expectations.txt:
4:15 PM Changeset in webkit [59970] by levin@chromium.org
  • 2 edits in trunk/JavaScriptCore

Unreviewed build fix.

  • wtf/SizeLimits.cpp: Removed a check while I figure out how to write it properly.
4:06 PM Changeset in webkit [59969] by levin@chromium.org
  • 5 edits
    1 add in trunk/JavaScriptCore

Enforce size constraints on various data structures in JavaScriptCore/wtf.
https://bugs.webkit.org/show_bug.cgi?id=39327

Reviewed by Darin Adler.

I only modified the default build for OSX and Chromium's build file to include WTFCompileAsserts.cpp
as those should be sufficient to catch regressions on the size of the data structures.

  • JavaScriptCore.gypi: Added the WTFCompileAsserts.cpp file.
  • JavaScriptCore.xcodeproj/project.pbxproj: Added the WTFCompileAsserts.cpp file.
  • runtime/UString.cpp: Added a compile assert for UString size.
  • wtf/SizeLimits.cpp: Added compile asserts for data structures that didn't have cpp files.
  • wtf/text/StringImpl.cpp: Added a compile assert for StringImpl size.
3:45 PM Changeset in webkit [59968] by hyatt@apple.com
  • 11 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=39516, back end support for column-span property.

Reviewed by Dan Bernstein.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

  • rendering/style/RenderStyle.h:

(WebCore::InheritedFlags::columnSpan):
(WebCore::InheritedFlags::setColumnSpan):
(WebCore::InheritedFlags::initialColumnSpan):

  • rendering/style/StyleMultiColData.cpp:

(WebCore::StyleMultiColData::StyleMultiColData):
(WebCore::StyleMultiColData::operator==):

  • rendering/style/StyleMultiColData.h:
3:31 PM Changeset in webkit [59967] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed. Skip failing test until fix.

[Qt] need an implementation of LayoutTestController::computedStyleIncludingVisitedInfo
https://bugs.webkit.org/show_bug.cgi?id=37759

The implementation of LayoutTestController::computedStyleIncludingVisitedInfo
is incorrect now, this bug was revealed by r59956.

  • platform/qt/Skipped: fast/history/self-is-visited.html skipped.
3:19 PM Changeset in webkit [59966] by jer.noble@apple.com
  • 10 edits in trunk

2010-05-21 Jer Noble <jer.noble@apple.com>

Reviewed by Anders Carlsson.

Disable full-screen video on Windows
https://bugs.webkit.org/show_bug.cgi?id=39506
rdar://problem/8012516


Disable full-screen video through MediaPlayerPrivateVisualContext since
we no longer use GWorlds and QuickTime's built in full-screen support.


Media layout tests updated with new expected results.


  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::supportsFullscreen):

2010-05-21 Jer Noble <jer.noble@apple.com>

Reviewed by Anders Carlsson.

Disable full-screen video on Windows
https://bugs.webkit.org/show_bug.cgi?id=39506
rdar://problem/8012516

Disable full-screen video through MediaPlayerPrivateVisualContext since
we no longer use GWorlds and QuickTime's built in full-screen support.


Media layout tests updated with new expected results.

  • platform/win/media/controls-after-reload-expected.txt:
  • platform/win/media/controls-drag-timebar-expected.txt:
  • platform/win/media/controls-strict-expected.txt:
  • platform/win/media/controls-styling-expected.txt:
  • platform/win/media/video-controls-rendering-expected.txt:
  • platform/win/media/video-display-toggle-expected.txt:
  • platform/win/media/video-no-audio-expected.txt:
3:02 PM Changeset in webkit [59965] by crogers@google.com
  • 3 edits in branches/audio/WebCore/audio

Make sure that AudioMixerInputNodes are properly reference-counted

3:02 PM Changeset in webkit [59964] by crogers@google.com
  • 2 edits in branches/audio/WebCore/audio

Make sure ConvolverNode keeps reference to its buffer

3:02 PM Changeset in webkit [59963] by crogers@google.com
  • 12 edits in branches/audio/WebCore/audio

More properly reference-count AudioBuffer objects

  • don't let them leak - they'll now be garbage collected
  • but release the memory used by the buffer early (when the context goes away)
2:49 PM Changeset in webkit [59962] by Simon Fraser
  • 4 edits
    2 adds in trunk

2010-05-21 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Avoid creating huge tiled layers with accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=39515

Constrain the size of huge composited layers, to avoid bad behavior. We only
need to do this if we detect that we need a tiled layer, since we'll make tiled
layers for elements over a certain size that need to draw already.

Constrain the size by attempting to shrink the longer dimension first.

Test: compositing/geometry/huge-layer.html

  • platform/graphics/mac/GraphicsLayerCA.h:
  • platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::updateLayerPosition): (WebCore::GraphicsLayerCA::updateLayerSize): (WebCore::GraphicsLayerCA::constrainedSize):
2:49 PM Rebaseline edited by victorw@chromium.org
(diff)
2:31 PM Changeset in webkit [59961] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix interpreter build.

Reviewed by NOBODY (build fix).

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

2:24 PM Changeset in webkit [59960] by hyatt@apple.com
  • 1 edit in trunk/WebCore/rendering/style/RenderStyle.h

Back out unintended RenderStyle checkin just now.

2:23 PM Changeset in webkit [59959] by hyatt@apple.com
  • 2 edits in trunk/WebCore/rendering

Fix Windows Chromium build bustage.

2:13 PM Changeset in webkit [59958] by hyatt@apple.com
  • 1 edit in trunk/WebCore/rendering/RenderThemeSafari.cpp

Fix Windows build bustage.

1:58 PM Changeset in webkit [59957] by alex
  • 2 edits in trunk/LayoutTests

2010-05-21 Alejandro G. Castro <alex@igalia.com>

Rubber-stamped by Xan Lopez.

Updated test results, added web sockets lines.

  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
1:56 PM Changeset in webkit [59956] by hyatt@apple.com
  • 57 edits in trunk

WebCore: https://bugs.webkit.org/show_bug.cgi?id=39420, :visited not working with background-color.

Reviewed by Dan Bernstein.

Make the RenderStyle color accessors private. This forces callers to use visitedDependentColor
instead (or to make the decision to become friends of the RenderStyle class in order to get access
to the real style information).

Modified history/self-is-visited.html to also test background colors.

  • WebCore.base.exp:
  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::isTableExposableThroughAccessibility):

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(AXAttributeStringSetStyle):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::currentColorOrValidColor):

  • css/CSSComputedStyleDeclaration.h:
  • css/SVGCSSStyleSelector.cpp:

(WebCore::colorFromSVGColorCSSValue):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::editingStyleAtPosition):
(WebCore::prepareEditingStyleToApplyAt):
(WebCore::removeStylesAddedByNode):
(WebCore::fontColorChangesComputedStyle):
(WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):

  • editing/ApplyStyleCommand.h:

(WebCore::):

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::moveParagraphs):
(WebCore::CompositeEditCommand::breakOutOfEmptyListItem):

  • editing/DeleteButtonController.cpp:

(WebCore::isDeletableElement):

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::saveTypingStyleState):

  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion):

  • editing/RemoveFormatCommand.cpp:

(WebCore::RemoveFormatCommand::doApply):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::handleStyleSpansBeforeInsertion):
(WebCore::ReplaceSelectionCommand::handleStyleSpans):
(WebCore::ReplaceSelectionCommand::doApply):

  • editing/SelectionController.cpp:

(WebCore::SelectionController::paintCaret):

  • editing/markup.cpp:

(WebCore::createMarkup):

  • page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::ensurePropertyMap):

  • page/animation/AnimationBase.h:
  • page/mac/FrameMac.mm:

(WebCore::Frame::fontAttributesForSelectionStart):

  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::paint):
(WebCore::EllipsisBox::paintSelection):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::paintRootBoxDecorations):
(WebCore::RenderBox::paintBoxDecorationsWithSize):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBoxShadow):

  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::paintBoxDecorations):

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::paintObject):

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::paintColumnBorder):
(WebCore::RenderFrameSet::paintRowBorder):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::paintReplaced):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::rendererBackgroundColor):

  • rendering/RenderLayerBacking.h:
  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):

  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::paint):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::itemStyle):
(WebCore::RenderMenuList::itemBackgroundColor):
(WebCore::RenderMenuList::menuStyle):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::selectionBackgroundColor):
(WebCore::RenderObject::selectionForegroundColor):

  • rendering/RenderSVGResource.cpp:

(WebCore::RenderSVGResource::adjustColorForPseudoRules):
(WebCore::RenderSVGResource::fillPaintingResource):
(WebCore::RenderSVGResource::strokePaintingResource):

  • rendering/RenderSVGResource.h:
  • rendering/RenderTable.cpp:

(WebCore::RenderTable::paintBoxDecorations):

  • rendering/RenderTable.h:

(WebCore::RenderTable::bgColor):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintBackgroundsBehindCell):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::adjustInnerTextStyle):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::menuStyle):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::isControlStyled):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMenuListButton):

  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):
(WebCore::write):

  • rendering/RenderTreeAsText.h:
  • rendering/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::paintSelection):

  • rendering/SVGRenderTreeAsText.cpp:

(WebCore::writeRenderSVGTextBox):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::colorIncludingFallback):
(WebCore::RenderStyle::visitedDependentColor):

  • rendering/style/RenderStyle.h:

(WebCore::):
(WebCore::InheritedFlags::hasBackground):
(WebCore::InheritedFlags::borderLeftStyle):
(WebCore::InheritedFlags::borderRightStyle):
(WebCore::InheritedFlags::borderTopStyle):
(WebCore::InheritedFlags::borderBottomStyle):
(WebCore::InheritedFlags::textShadow):
(WebCore::InheritedFlags::textStrokeWidth):
(WebCore::InheritedFlags::hasNormalColumnGap):
(WebCore::InheritedFlags::borderLeftColor):
(WebCore::InheritedFlags::borderRightColor):
(WebCore::InheritedFlags::borderTopColor):
(WebCore::InheritedFlags::borderBottomColor):
(WebCore::InheritedFlags::backgroundColor):
(WebCore::InheritedFlags::color):
(WebCore::InheritedFlags::columnRuleColor):
(WebCore::InheritedFlags::outlineColor):
(WebCore::InheritedFlags::textFillColor):
(WebCore::InheritedFlags::textStrokeColor):

  • svg/SVGAnimationElement.cpp:

(WebCore::adjustForCurrentColor):

WebKit/mac: https://bugs.webkit.org/show_bug.cgi?id=39420

Reviewed by Dan Bernstein.

Make sure everyone who needs to is using visitedDependentColor rather than accessing styles
directly.

  • Misc/WebNSAttributedStringExtras.mm:

(+[NSAttributedString _web_attributedStringFromRange:]):

  • WebView/WebFrame.mm:

(-[WebFrame _bodyBackgroundColor]):

1:52 PM Changeset in webkit [59955] by ggaren@apple.com
  • 17 edits
    1 copy in trunk/JavaScriptCore

2010-05-21 Geoffrey Garen <ggaren@apple.com>

Reviewed by Gavin Barraclough.

Split out JITCall32_64.cpp, and tightened up some #ifdefs in the hopes
of improving compile times.
https://bugs.webkit.org/show_bug.cgi?id=39507

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • jit/JIT.cpp:
  • jit/JITArithmetic.cpp:
  • jit/JITArithmetic32_64.cpp:
  • jit/JITCall.cpp:
  • jit/JITCall32_64.cpp: Copied from jit/JITCall.cpp.
  • jit/JITOpcodes.cpp:
  • jit/JITOpcodes32_64.cpp:
  • jit/JITPropertyAccess.cpp:
  • jit/JITPropertyAccess32_64.cpp:
  • jit/JITStubs.cpp:
1:47 PM Changeset in webkit [59954] by chang.shu@nokia.com
  • 6 edits
    991 adds in trunk/LayoutTests

2010-05-14 Chang Shu <chang.shu@nokia.com>

Reviewed by Eric Seidel.

Import Philip Taylor's HTML5 <canavs> test suite from
http://philip.html5.org/tests/canvas/suite/tests. These
test cases are skipped for now.
https://bugs.webkit.org/show_bug.cgi?id=20553

  • fast/canvas/philip: Added.
  • fast/canvas/philip/fonts: Added.
  • fast/canvas/philip/fonts/CanvasTest.sfd: Added.
  • fast/canvas/philip/fonts/CanvasTest.ttf: Added.
  • fast/canvas/philip/images: Added.
  • fast/canvas/philip/images/anim-gr.gif: Added.
  • fast/canvas/philip/images/anim-gr.png: Added.
  • fast/canvas/philip/images/anim-poster-gr.png: Added.
  • fast/canvas/philip/images/background.png: Added.
  • fast/canvas/philip/images/broken.png: Added.
  • fast/canvas/philip/images/ggrr-256x256.png: Added.
  • fast/canvas/philip/images/green-16x16.png: Added.
  • fast/canvas/philip/images/green-1x1.png: Added.
  • fast/canvas/philip/images/green-256x256.png: Added.
  • fast/canvas/philip/images/green-2x2.png: Added.
  • fast/canvas/philip/images/green.png: Added.
  • fast/canvas/philip/images/grgr-256x256.png: Added.
  • fast/canvas/philip/images/red-16x16.png: Added.
  • fast/canvas/philip/images/red.png: Added.
  • fast/canvas/philip/images/redtransparent.png: Added.
  • fast/canvas/philip/images/rgrg-256x256.png: Added.
  • fast/canvas/philip/images/rrgg-256x256.png: Added.
  • fast/canvas/philip/images/transparent.png: Added.
  • fast/canvas/philip/images/transparent50.png: Added.
  • fast/canvas/philip/images/yellow.png: Added.
  • fast/canvas/philip/images/yellow75.png: Added.
  • fast/canvas/philip/tests: Added.
  • fast/canvas/philip/tests.css: Added.
  • fast/canvas/philip/tests/.reportgen.html.swp: Added.
  • fast/canvas/philip/tests/.reportgen.js.swp: Added.
  • fast/canvas/philip/tests/2d.canvas.readonly.html: Added.
  • fast/canvas/philip/tests/2d.canvas.reference.html: Added.
  • fast/canvas/philip/tests/2d.clearRect.basic.html: Added.
  • fast/canvas/philip/tests/2d.clearRect.clip.html: Added.
  • fast/canvas/philip/tests/2d.clearRect.globalalpha.html: Added.
  • fast/canvas/philip/tests/2d.clearRect.globalcomposite.html: Added.
  • fast/canvas/philip/tests/2d.clearRect.negative.html: Added.
  • fast/canvas/philip/tests/2d.clearRect.nonfinite.html: Added.
  • fast/canvas/philip/tests/2d.clearRect.path.html: Added.
  • fast/canvas/philip/tests/2d.clearRect.shadow.html: Added.
  • fast/canvas/philip/tests/2d.clearRect.transform.html: Added.
  • fast/canvas/philip/tests/2d.clearRect.zero.html: Added.
  • fast/canvas/philip/tests/2d.composite.canvas.copy.html: Added.
  • fast/canvas/philip/tests/2d.composite.canvas.copy.png: Added.
  • fast/canvas/philip/tests/2d.composite.canvas.destination-atop.html: Added.
  • fast/canvas/philip/tests/2d.composite.canvas.destination-atop.png: Added.
  • fast/canvas/philip/tests/2d.composite.canvas.destination-in.html: Added.
  • fast/canvas/philip/tests/2d.composite.canvas.destination-in.png: Added.
  • fast/canvas/philip/tests/2d.composite.canvas.destination-out.html: Added.
  • fast/canvas/philip/tests/2d.composite.canvas.destination-out.png: Added.
  • fast/canvas/philip/tests/2d.composite.canvas.destination-over.html: Added.
  • fast/canvas/philip/tests/2d.composite.canvas.destination-over.png: Added.
  • fast/canvas/philip/tests/2d.composite.canvas.lighter.html: Added.
  • fast/canvas/philip/tests/2d.composite.canvas.lighter.png: Added.
  • fast/canvas/philip/tests/2d.composite.canvas.source-atop.html: Added.
  • fast/canvas/philip/tests/2d.composite.canvas.source-atop.png: Added.
  • fast/canvas/philip/tests/2d.composite.canvas.source-in.html: Added.
  • fast/canvas/philip/tests/2d.composite.canvas.source-in.png: Added.
  • fast/canvas/philip/tests/2d.composite.canvas.source-out.html: Added.
  • fast/canvas/philip/tests/2d.composite.canvas.source-out.png: Added.
  • fast/canvas/philip/tests/2d.composite.canvas.source-over.html: Added.
  • fast/canvas/philip/tests/2d.composite.canvas.source-over.png: Added.
  • fast/canvas/philip/tests/2d.composite.canvas.xor.html: Added.
  • fast/canvas/philip/tests/2d.composite.canvas.xor.png: Added.
  • fast/canvas/philip/tests/2d.composite.clip.copy.html: Added.
  • fast/canvas/philip/tests/2d.composite.clip.destination-atop.html: Added.
  • fast/canvas/philip/tests/2d.composite.clip.destination-in.html: Added.
  • fast/canvas/philip/tests/2d.composite.clip.destination-out.html: Added.
  • fast/canvas/philip/tests/2d.composite.clip.destination-over.html: Added.
  • fast/canvas/philip/tests/2d.composite.clip.lighter.html: Added.
  • fast/canvas/philip/tests/2d.composite.clip.source-atop.html: Added.
  • fast/canvas/philip/tests/2d.composite.clip.source-in.html: Added.
  • fast/canvas/philip/tests/2d.composite.clip.source-out.html: Added.
  • fast/canvas/philip/tests/2d.composite.clip.source-over.html: Added.
  • fast/canvas/philip/tests/2d.composite.clip.xor.html: Added.
  • fast/canvas/philip/tests/2d.composite.globalAlpha.canvas.html: Added.
  • fast/canvas/philip/tests/2d.composite.globalAlpha.canvaspattern.html: Added.
  • fast/canvas/philip/tests/2d.composite.globalAlpha.default.html: Added.
  • fast/canvas/philip/tests/2d.composite.globalAlpha.fill.html: Added.
  • fast/canvas/philip/tests/2d.composite.globalAlpha.image.html: Added.
  • fast/canvas/philip/tests/2d.composite.globalAlpha.imagepattern.html: Added.
  • fast/canvas/philip/tests/2d.composite.globalAlpha.invalid.html: Added.
  • fast/canvas/philip/tests/2d.composite.globalAlpha.range.html: Added.
  • fast/canvas/philip/tests/2d.composite.image.copy.html: Added.
  • fast/canvas/philip/tests/2d.composite.image.copy.png: Added.
  • fast/canvas/philip/tests/2d.composite.image.destination-atop.html: Added.
  • fast/canvas/philip/tests/2d.composite.image.destination-atop.png: Added.
  • fast/canvas/philip/tests/2d.composite.image.destination-in.html: Added.
  • fast/canvas/philip/tests/2d.composite.image.destination-in.png: Added.
  • fast/canvas/philip/tests/2d.composite.image.destination-out.html: Added.
  • fast/canvas/philip/tests/2d.composite.image.destination-out.png: Added.
  • fast/canvas/philip/tests/2d.composite.image.destination-over.html: Added.
  • fast/canvas/philip/tests/2d.composite.image.destination-over.png: Added.
  • fast/canvas/philip/tests/2d.composite.image.lighter.html: Added.
  • fast/canvas/philip/tests/2d.composite.image.lighter.png: Added.
  • fast/canvas/philip/tests/2d.composite.image.source-atop.html: Added.
  • fast/canvas/philip/tests/2d.composite.image.source-atop.png: Added.
  • fast/canvas/philip/tests/2d.composite.image.source-in.html: Added.
  • fast/canvas/philip/tests/2d.composite.image.source-in.png: Added.
  • fast/canvas/philip/tests/2d.composite.image.source-out.html: Added.
  • fast/canvas/philip/tests/2d.composite.image.source-out.png: Added.
  • fast/canvas/philip/tests/2d.composite.image.source-over.html: Added.
  • fast/canvas/philip/tests/2d.composite.image.source-over.png: Added.
  • fast/canvas/philip/tests/2d.composite.image.xor.html: Added.
  • fast/canvas/philip/tests/2d.composite.image.xor.png: Added.
  • fast/canvas/philip/tests/2d.composite.operation.casesensitive.html: Added.
  • fast/canvas/philip/tests/2d.composite.operation.clear.html: Added.
  • fast/canvas/philip/tests/2d.composite.operation.darker.html: Added.
  • fast/canvas/philip/tests/2d.composite.operation.default.html: Added.
  • fast/canvas/philip/tests/2d.composite.operation.get.html: Added.
  • fast/canvas/philip/tests/2d.composite.operation.highlight.html: Added.
  • fast/canvas/philip/tests/2d.composite.operation.nullsuffix.html: Added.
  • fast/canvas/philip/tests/2d.composite.operation.over.html: Added.
  • fast/canvas/philip/tests/2d.composite.operation.unrecognised.html: Added.
  • fast/canvas/philip/tests/2d.composite.solid.copy.html: Added.
  • fast/canvas/philip/tests/2d.composite.solid.copy.png: Added.
  • fast/canvas/philip/tests/2d.composite.solid.destination-atop.html: Added.
  • fast/canvas/philip/tests/2d.composite.solid.destination-atop.png: Added.
  • fast/canvas/philip/tests/2d.composite.solid.destination-in.html: Added.
  • fast/canvas/philip/tests/2d.composite.solid.destination-in.png: Added.
  • fast/canvas/philip/tests/2d.composite.solid.destination-out.html: Added.
  • fast/canvas/philip/tests/2d.composite.solid.destination-out.png: Added.
  • fast/canvas/philip/tests/2d.composite.solid.destination-over.html: Added.
  • fast/canvas/philip/tests/2d.composite.solid.destination-over.png: Added.
  • fast/canvas/philip/tests/2d.composite.solid.lighter.html: Added.
  • fast/canvas/philip/tests/2d.composite.solid.lighter.png: Added.
  • fast/canvas/philip/tests/2d.composite.solid.source-atop.html: Added.
  • fast/canvas/philip/tests/2d.composite.solid.source-atop.png: Added.
  • fast/canvas/philip/tests/2d.composite.solid.source-in.html: Added.
  • fast/canvas/philip/tests/2d.composite.solid.source-in.png: Added.
  • fast/canvas/philip/tests/2d.composite.solid.source-out.html: Added.
  • fast/canvas/philip/tests/2d.composite.solid.source-out.png: Added.
  • fast/canvas/philip/tests/2d.composite.solid.source-over.html: Added.
  • fast/canvas/philip/tests/2d.composite.solid.source-over.png: Added.
  • fast/canvas/philip/tests/2d.composite.solid.xor.html: Added.
  • fast/canvas/philip/tests/2d.composite.solid.xor.png: Added.
  • fast/canvas/philip/tests/2d.composite.transparent.copy.html: Added.
  • fast/canvas/philip/tests/2d.composite.transparent.copy.png: Added.
  • fast/canvas/philip/tests/2d.composite.transparent.destination-atop.html: Added.
  • fast/canvas/philip/tests/2d.composite.transparent.destination-atop.png: Added.
  • fast/canvas/philip/tests/2d.composite.transparent.destination-in.html: Added.
  • fast/canvas/philip/tests/2d.composite.transparent.destination-in.png: Added.
  • fast/canvas/philip/tests/2d.composite.transparent.destination-out.html: Added.
  • fast/canvas/philip/tests/2d.composite.transparent.destination-out.png: Added.
  • fast/canvas/philip/tests/2d.composite.transparent.destination-over.html: Added.
  • fast/canvas/philip/tests/2d.composite.transparent.destination-over.png: Added.
  • fast/canvas/philip/tests/2d.composite.transparent.lighter.html: Added.
  • fast/canvas/philip/tests/2d.composite.transparent.lighter.png: Added.
  • fast/canvas/philip/tests/2d.composite.transparent.source-atop.html: Added.
  • fast/canvas/philip/tests/2d.composite.transparent.source-atop.png: Added.
  • fast/canvas/philip/tests/2d.composite.transparent.source-in.html: Added.
  • fast/canvas/philip/tests/2d.composite.transparent.source-in.png: Added.
  • fast/canvas/philip/tests/2d.composite.transparent.source-out.html: Added.
  • fast/canvas/philip/tests/2d.composite.transparent.source-out.png: Added.
  • fast/canvas/philip/tests/2d.composite.transparent.source-over.html: Added.
  • fast/canvas/philip/tests/2d.composite.transparent.source-over.png: Added.
  • fast/canvas/philip/tests/2d.composite.transparent.xor.html: Added.
  • fast/canvas/philip/tests/2d.composite.transparent.xor.png: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.fill.copy.html: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.fill.copy.png: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.fill.destination-atop.html: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.fill.destination-atop.png: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.fill.destination-in.html: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.fill.destination-in.png: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.fill.source-in.html: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.fill.source-in.png: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.fill.source-out.html: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.fill.source-out.png: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.image.copy.html: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.image.copy.png: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.image.destination-atop.html: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.image.destination-atop.png: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.image.destination-in.html: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.image.destination-in.png: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.image.source-in.html: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.image.source-in.png: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.image.source-out.html: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.image.source-out.png: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.nocontext.copy.html: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.nocontext.copy.png: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.nocontext.destination-atop.html: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.nocontext.destination-atop.png: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.nocontext.destination-in.html: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.nocontext.destination-in.png: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.nocontext.source-in.html: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.nocontext.source-in.png: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.nocontext.source-out.html: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.nocontext.source-out.png: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.pattern.copy.html: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.pattern.copy.png: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.pattern.destination-atop.html: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.pattern.destination-atop.png: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.pattern.destination-in.html: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.pattern.destination-in.png: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.pattern.source-in.html: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.pattern.source-in.png: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.pattern.source-out.html: Added.
  • fast/canvas/philip/tests/2d.composite.uncovered.pattern.source-out.png: Added.
  • fast/canvas/philip/tests/2d.coordinatespace.html: Added.
  • fast/canvas/philip/tests/2d.coordinatespace.png: Added.
  • fast/canvas/philip/tests/2d.drawImage.3arg.html: Added.
  • fast/canvas/philip/tests/2d.drawImage.5arg.html: Added.
  • fast/canvas/philip/tests/2d.drawImage.9arg.basic.html: Added.
  • fast/canvas/philip/tests/2d.drawImage.9arg.destpos.html: Added.
  • fast/canvas/philip/tests/2d.drawImage.9arg.destsize.html: Added.
  • fast/canvas/philip/tests/2d.drawImage.9arg.sourcepos.html: Added.
  • fast/canvas/philip/tests/2d.drawImage.9arg.sourcesize.html: Added.
  • fast/canvas/philip/tests/2d.drawImage.alpha.html: Added.
  • fast/canvas/philip/tests/2d.drawImage.animated.apng.html: Added.
  • fast/canvas/philip/tests/2d.drawImage.animated.gif.html: Added.
  • fast/canvas/philip/tests/2d.drawImage.animated.poster.html: Added.
  • fast/canvas/philip/tests/2d.drawImage.broken.html: Added.
  • fast/canvas/philip/tests/2d.drawImage.canvas.html: Added.
  • fast/canvas/philip/tests/2d.drawImage.clip.html: Added.
  • fast/canvas/philip/tests/2d.drawImage.composite.html: Added.
  • fast/canvas/philip/tests/2d.drawImage.floatsource.html: Added.
  • fast/canvas/philip/tests/2d.drawImage.incomplete.html: Added.
  • fast/canvas/philip/tests/2d.drawImage.negativedest.html: Added.
  • fast/canvas/philip/tests/2d.drawImage.negativedir.html: Added.
  • fast/canvas/philip/tests/2d.drawImage.negativesource.html: Added.
  • fast/canvas/philip/tests/2d.drawImage.nonfinite.html: Added.
  • fast/canvas/philip/tests/2d.drawImage.nowrap.html: Added.
  • fast/canvas/philip/tests/2d.drawImage.null.html: Added.
  • fast/canvas/philip/tests/2d.drawImage.outsidesource.html: Added.
  • fast/canvas/philip/tests/2d.drawImage.path.html: Added.
  • fast/canvas/philip/tests/2d.drawImage.self.1.html: Added.
  • fast/canvas/philip/tests/2d.drawImage.self.2.html: Added.
  • fast/canvas/philip/tests/2d.drawImage.transform.html: Added.
  • fast/canvas/philip/tests/2d.drawImage.wrongtype.html: Added.
  • fast/canvas/philip/tests/2d.drawImage.zerocanvas.html: Added.
  • fast/canvas/philip/tests/2d.drawImage.zerosource.html: Added.
  • fast/canvas/philip/tests/2d.fillRect.basic.html: Added.
  • fast/canvas/philip/tests/2d.fillRect.clip.html: Added.
  • fast/canvas/philip/tests/2d.fillRect.negative.html: Added.
  • fast/canvas/philip/tests/2d.fillRect.nonfinite.html: Added.
  • fast/canvas/philip/tests/2d.fillRect.path.html: Added.
  • fast/canvas/philip/tests/2d.fillRect.shadow.html: Added.
  • fast/canvas/philip/tests/2d.fillRect.transform.html: Added.
  • fast/canvas/philip/tests/2d.fillRect.zero.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.default.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.get.semitransparent.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.get.solid.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.get.transparent.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.invalidstring.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.invalidtype.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.current.basic.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.current.changed.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.current.removed.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.current.removed.png: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.hex3.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.hex3.png: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.hex6.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.hex6.png: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.hsl-1.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.hsl-1.png: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.hsl-2.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.hsl-2.png: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.hsl-3.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.hsl-3.png: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.hsl-4.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.hsl-4.png: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.hsl-5.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.hsl-5.png: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.hsl-clamp-1.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.hsl-clamp-1.png: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.hsl-clamp-2.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.hsl-clamp-2.png: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.hsl-clamp-3.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.hsl-clamp-3.png: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.hsl-clamp-4.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.hsl-clamp-4.png: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.hsla-1.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.hsla-1.png: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.hsla-2.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.hsla-2.png: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.hsla-clamp-1.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.hsla-clamp-1.png: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.hsla-clamp-2.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.hsla-clamp-2.png: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.hsla-clamp-3.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.hsla-clamp-3.png: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.hsla-clamp-4.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.hsla-clamp-4.png: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.hsla-clamp-5.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.hsla-clamp-5.png: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.hsla-clamp-6.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.hsla-clamp-6.png: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.html4.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.html4.png: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.invalid.hex1.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.invalid.hex2.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.invalid.hex3.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.invalid.hex4.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.invalid.hex5.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.invalid.hex6.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.invalid.hex7.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.invalid.hex8.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.invalid.hsl-1.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.invalid.hsl-2.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.invalid.hsl-3.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.invalid.hsl-4.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.invalid.hsl-5.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.invalid.hsla-1.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.invalid.hsla-2.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.invalid.name-1.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.invalid.name-2.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.invalid.name-3.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-1.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-2.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-3.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-4.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-5.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-6.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-7.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-1.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-2.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-3.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-4.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-5.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.rgb-clamp-1.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.rgb-clamp-1.png: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.rgb-clamp-2.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.rgb-clamp-2.png: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.rgb-clamp-3.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.rgb-clamp-3.png: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.rgb-clamp-4.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.rgb-clamp-4.png: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.rgb-clamp-5.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.rgb-clamp-5.png: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.rgb-num.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.rgb-num.png: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.rgb-percent.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.rgb-percent.png: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.rgba-clamp-1.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.rgba-clamp-1.png: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.rgba-clamp-2.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.rgba-clamp-2.png: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.rgba-num-1.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.rgba-num-1.png: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.rgba-num-2.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.rgba-num-2.png: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.rgba-percent.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.rgba-percent.png: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.rgba-solid-1.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.rgba-solid-1.png: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.rgba-solid-2.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.rgba-solid-2.png: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.svg-1.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.svg-1.png: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.svg-2.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.svg-2.png: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.system.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.transparent-1.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.transparent-1.png: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.transparent-2.html: Added.
  • fast/canvas/philip/tests/2d.fillStyle.parse.transparent-2.png: Added.
  • fast/canvas/philip/tests/2d.getcontext.exists.html: Added.
  • fast/canvas/philip/tests/2d.getcontext.shared.html: Added.
  • fast/canvas/philip/tests/2d.getcontext.unique.html: Added.
  • fast/canvas/philip/tests/2d.gradient.empty.html: Added.
  • fast/canvas/philip/tests/2d.gradient.interpolate.alpha.html: Added.
  • fast/canvas/philip/tests/2d.gradient.interpolate.alpha.png: Added.
  • fast/canvas/philip/tests/2d.gradient.interpolate.colour.html: Added.
  • fast/canvas/philip/tests/2d.gradient.interpolate.colour.png: Added.
  • fast/canvas/philip/tests/2d.gradient.interpolate.colouralpha.html: Added.
  • fast/canvas/philip/tests/2d.gradient.interpolate.colouralpha.png: Added.
  • fast/canvas/philip/tests/2d.gradient.interpolate.multiple.html: Added.
  • fast/canvas/philip/tests/2d.gradient.interpolate.multiple.png: Added.
  • fast/canvas/philip/tests/2d.gradient.interpolate.outside.html: Added.
  • fast/canvas/philip/tests/2d.gradient.interpolate.overlap.html: Added.
  • fast/canvas/philip/tests/2d.gradient.interpolate.overlap.png: Added.
  • fast/canvas/philip/tests/2d.gradient.interpolate.overlap2.html: Added.
  • fast/canvas/philip/tests/2d.gradient.interpolate.solid.html: Added.
  • fast/canvas/philip/tests/2d.gradient.interpolate.vertical.html: Added.
  • fast/canvas/philip/tests/2d.gradient.interpolate.vertical.png: Added.
  • fast/canvas/philip/tests/2d.gradient.interpolate.zerosize.html: Added.
  • fast/canvas/philip/tests/2d.gradient.linear.nonfinite.html: Added.
  • fast/canvas/philip/tests/2d.gradient.linear.transform.1.html: Added.
  • fast/canvas/philip/tests/2d.gradient.linear.transform.2.html: Added.
  • fast/canvas/philip/tests/2d.gradient.linear.transform.3.html: Added.
  • fast/canvas/philip/tests/2d.gradient.object.compare.html: Added.
  • fast/canvas/philip/tests/2d.gradient.object.crosscanvas.html: Added.
  • fast/canvas/philip/tests/2d.gradient.object.invalidcolour.html: Added.
  • fast/canvas/philip/tests/2d.gradient.object.invalidoffset.html: Added.
  • fast/canvas/philip/tests/2d.gradient.object.return.html: Added.
  • fast/canvas/philip/tests/2d.gradient.object.update.html: Added.
  • fast/canvas/philip/tests/2d.gradient.radial.cone.behind.html: Added.
  • fast/canvas/philip/tests/2d.gradient.radial.cone.beside.html: Added.
  • fast/canvas/philip/tests/2d.gradient.radial.cone.bottom.html: Added.
  • fast/canvas/philip/tests/2d.gradient.radial.cone.cylinder.html: Added.
  • fast/canvas/philip/tests/2d.gradient.radial.cone.front.html: Added.
  • fast/canvas/philip/tests/2d.gradient.radial.cone.shape1.html: Added.
  • fast/canvas/philip/tests/2d.gradient.radial.cone.shape2.html: Added.
  • fast/canvas/philip/tests/2d.gradient.radial.cone.top.html: Added.
  • fast/canvas/philip/tests/2d.gradient.radial.equal.html: Added.
  • fast/canvas/philip/tests/2d.gradient.radial.inside1.html: Added.
  • fast/canvas/philip/tests/2d.gradient.radial.inside2.html: Added.
  • fast/canvas/philip/tests/2d.gradient.radial.inside3.html: Added.
  • fast/canvas/philip/tests/2d.gradient.radial.negative.html: Added.
  • fast/canvas/philip/tests/2d.gradient.radial.nonfinite.html: Added.
  • fast/canvas/philip/tests/2d.gradient.radial.outside1.html: Added.
  • fast/canvas/philip/tests/2d.gradient.radial.outside2.html: Added.
  • fast/canvas/philip/tests/2d.gradient.radial.outside3.html: Added.
  • fast/canvas/philip/tests/2d.gradient.radial.touch1.html: Added.
  • fast/canvas/philip/tests/2d.gradient.radial.touch2.html: Added.
  • fast/canvas/philip/tests/2d.gradient.radial.touch3.html: Added.
  • fast/canvas/philip/tests/2d.gradient.radial.transform.1.html: Added.
  • fast/canvas/philip/tests/2d.gradient.radial.transform.2.html: Added.
  • fast/canvas/philip/tests/2d.gradient.radial.transform.3.html: Added.
  • fast/canvas/philip/tests/2d.imageData.create1.basic.html: Added.
  • fast/canvas/philip/tests/2d.imageData.create1.initial.html: Added.
  • fast/canvas/philip/tests/2d.imageData.create1.type.html: Added.
  • fast/canvas/philip/tests/2d.imageData.create1.zero.html: Added.
  • fast/canvas/philip/tests/2d.imageData.create2.basic.html: Added.
  • fast/canvas/philip/tests/2d.imageData.create2.initial.html: Added.
  • fast/canvas/philip/tests/2d.imageData.create2.large.html: Added.
  • fast/canvas/philip/tests/2d.imageData.create2.negative.html: Added.
  • fast/canvas/philip/tests/2d.imageData.create2.nonfinite.html: Added.
  • fast/canvas/philip/tests/2d.imageData.create2.round.html: Added.
  • fast/canvas/philip/tests/2d.imageData.create2.tiny.html: Added.
  • fast/canvas/philip/tests/2d.imageData.create2.type.html: Added.
  • fast/canvas/philip/tests/2d.imageData.create2.zero.html: Added.
  • fast/canvas/philip/tests/2d.imageData.get.basic.html: Added.
  • fast/canvas/philip/tests/2d.imageData.get.clamp.html: Added.
  • fast/canvas/philip/tests/2d.imageData.get.length.html: Added.
  • fast/canvas/philip/tests/2d.imageData.get.nonfinite.html: Added.
  • fast/canvas/philip/tests/2d.imageData.get.nonpremul.html: Added.
  • fast/canvas/philip/tests/2d.imageData.get.order.alpha.html: Added.
  • fast/canvas/philip/tests/2d.imageData.get.order.cols.html: Added.
  • fast/canvas/philip/tests/2d.imageData.get.order.rgb.html: Added.
  • fast/canvas/philip/tests/2d.imageData.get.order.rows.html: Added.
  • fast/canvas/philip/tests/2d.imageData.get.range.html: Added.
  • fast/canvas/philip/tests/2d.imageData.get.source.negative.html: Added.
  • fast/canvas/philip/tests/2d.imageData.get.source.outside.html: Added.
  • fast/canvas/philip/tests/2d.imageData.get.source.size.html: Added.
  • fast/canvas/philip/tests/2d.imageData.get.tiny.html: Added.
  • fast/canvas/philip/tests/2d.imageData.get.type.html: Added.
  • fast/canvas/philip/tests/2d.imageData.get.unaffected.html: Added.
  • fast/canvas/philip/tests/2d.imageData.get.zero.html: Added.
  • fast/canvas/philip/tests/2d.imageData.object.ctor.html: Added.
  • fast/canvas/philip/tests/2d.imageData.object.nan.html: Added.
  • fast/canvas/philip/tests/2d.imageData.object.properties.html: Added.
  • fast/canvas/philip/tests/2d.imageData.object.readonly.html: Added.
  • fast/canvas/philip/tests/2d.imageData.object.round.html: Added.
  • fast/canvas/philip/tests/2d.imageData.object.set.html: Added.
  • fast/canvas/philip/tests/2d.imageData.object.string.html: Added.
  • fast/canvas/philip/tests/2d.imageData.object.undefined.html: Added.
  • fast/canvas/philip/tests/2d.imageData.object.wrap.html: Added.
  • fast/canvas/philip/tests/2d.imageData.put.alpha.html: Added.
  • fast/canvas/philip/tests/2d.imageData.put.alpha.png: Added.
  • fast/canvas/philip/tests/2d.imageData.put.basic.html: Added.
  • fast/canvas/philip/tests/2d.imageData.put.clip.html: Added.
  • fast/canvas/philip/tests/2d.imageData.put.created.html: Added.
  • fast/canvas/philip/tests/2d.imageData.put.cross.html: Added.
  • fast/canvas/philip/tests/2d.imageData.put.dirty.negative.html: Added.
  • fast/canvas/philip/tests/2d.imageData.put.dirty.outside.html: Added.
  • fast/canvas/philip/tests/2d.imageData.put.dirty.rect1.html: Added.
  • fast/canvas/philip/tests/2d.imageData.put.dirty.rect2.html: Added.
  • fast/canvas/philip/tests/2d.imageData.put.dirty.zero.html: Added.
  • fast/canvas/philip/tests/2d.imageData.put.modified.html: Added.
  • fast/canvas/philip/tests/2d.imageData.put.nonfinite.html: Added.
  • fast/canvas/philip/tests/2d.imageData.put.null.html: Added.
  • fast/canvas/philip/tests/2d.imageData.put.path.html: Added.
  • fast/canvas/philip/tests/2d.imageData.put.unaffected.html: Added.
  • fast/canvas/philip/tests/2d.imageData.put.unchanged.html: Added.
  • fast/canvas/philip/tests/2d.imageData.put.wrongtype.html: Added.
  • fast/canvas/philip/tests/2d.line.cap.butt.html: Added.
  • fast/canvas/philip/tests/2d.line.cap.closed.html: Added.
  • fast/canvas/philip/tests/2d.line.cap.invalid.html: Added.
  • fast/canvas/philip/tests/2d.line.cap.open.html: Added.
  • fast/canvas/philip/tests/2d.line.cap.round.html: Added.
  • fast/canvas/philip/tests/2d.line.cap.square.html: Added.
  • fast/canvas/philip/tests/2d.line.cap.valid.html: Added.
  • fast/canvas/philip/tests/2d.line.cross.html: Added.
  • fast/canvas/philip/tests/2d.line.defaults.html: Added.
  • fast/canvas/philip/tests/2d.line.join.bevel.html: Added.
  • fast/canvas/philip/tests/2d.line.join.closed.html: Added.
  • fast/canvas/philip/tests/2d.line.join.invalid.html: Added.
  • fast/canvas/philip/tests/2d.line.join.miter.html: Added.
  • fast/canvas/philip/tests/2d.line.join.open.html: Added.
  • fast/canvas/philip/tests/2d.line.join.parallel.html: Added.
  • fast/canvas/philip/tests/2d.line.join.round.html: Added.
  • fast/canvas/philip/tests/2d.line.join.valid.html: Added.
  • fast/canvas/philip/tests/2d.line.miter.acute.html: Added.
  • fast/canvas/philip/tests/2d.line.miter.exceeded.html: Added.
  • fast/canvas/philip/tests/2d.line.miter.invalid.html: Added.
  • fast/canvas/philip/tests/2d.line.miter.lineedge.html: Added.
  • fast/canvas/philip/tests/2d.line.miter.obtuse.html: Added.
  • fast/canvas/philip/tests/2d.line.miter.rightangle.html: Added.
  • fast/canvas/philip/tests/2d.line.miter.valid.html: Added.
  • fast/canvas/philip/tests/2d.line.miter.within.html: Added.
  • fast/canvas/philip/tests/2d.line.union.html: Added.
  • fast/canvas/philip/tests/2d.line.width.basic.html: Added.
  • fast/canvas/philip/tests/2d.line.width.invalid.html: Added.
  • fast/canvas/philip/tests/2d.line.width.scaledefault.html: Added.
  • fast/canvas/philip/tests/2d.line.width.transformed.html: Added.
  • fast/canvas/philip/tests/2d.line.width.valid.html: Added.
  • fast/canvas/philip/tests/2d.missingargs.html: Added.
  • fast/canvas/philip/tests/2d.path.arc.angle.1.html: Added.
  • fast/canvas/philip/tests/2d.path.arc.angle.2.html: Added.
  • fast/canvas/philip/tests/2d.path.arc.angle.3.html: Added.
  • fast/canvas/philip/tests/2d.path.arc.angle.4.html: Added.
  • fast/canvas/philip/tests/2d.path.arc.angle.5.html: Added.
  • fast/canvas/philip/tests/2d.path.arc.angle.6.html: Added.
  • fast/canvas/philip/tests/2d.path.arc.empty.html: Added.
  • fast/canvas/philip/tests/2d.path.arc.end.html: Added.
  • fast/canvas/philip/tests/2d.path.arc.negative.html: Added.
  • fast/canvas/philip/tests/2d.path.arc.nonempty.html: Added.
  • fast/canvas/philip/tests/2d.path.arc.nonfinite.html: Added.
  • fast/canvas/philip/tests/2d.path.arc.scale.1.html: Added.
  • fast/canvas/philip/tests/2d.path.arc.scale.2.html: Added.
  • fast/canvas/philip/tests/2d.path.arc.selfintersect.1.html: Added.
  • fast/canvas/philip/tests/2d.path.arc.selfintersect.2.html: Added.
  • fast/canvas/philip/tests/2d.path.arc.shape.1.html: Added.
  • fast/canvas/philip/tests/2d.path.arc.shape.2.html: Added.
  • fast/canvas/philip/tests/2d.path.arc.shape.3.html: Added.
  • fast/canvas/philip/tests/2d.path.arc.shape.4.html: Added.
  • fast/canvas/philip/tests/2d.path.arc.shape.5.html: Added.
  • fast/canvas/philip/tests/2d.path.arc.twopie.1.html: Added.
  • fast/canvas/philip/tests/2d.path.arc.twopie.2.html: Added.
  • fast/canvas/philip/tests/2d.path.arc.twopie.3.html: Added.
  • fast/canvas/philip/tests/2d.path.arc.twopie.4.html: Added.
  • fast/canvas/philip/tests/2d.path.arc.zero.1.html: Added.
  • fast/canvas/philip/tests/2d.path.arc.zero.2.html: Added.
  • fast/canvas/philip/tests/2d.path.arc.zeroradius.html: Added.
  • fast/canvas/philip/tests/2d.path.arcTo.coincide.1.html: Added.
  • fast/canvas/philip/tests/2d.path.arcTo.coincide.2.html: Added.
  • fast/canvas/philip/tests/2d.path.arcTo.collinear.1.html: Added.
  • fast/canvas/philip/tests/2d.path.arcTo.collinear.2.html: Added.
  • fast/canvas/philip/tests/2d.path.arcTo.collinear.3.html: Added.
  • fast/canvas/philip/tests/2d.path.arcTo.ensuresubpath.1.html: Added.
  • fast/canvas/philip/tests/2d.path.arcTo.ensuresubpath.2.html: Added.
  • fast/canvas/philip/tests/2d.path.arcTo.negative.html: Added.
  • fast/canvas/philip/tests/2d.path.arcTo.nonfinite.html: Added.
  • fast/canvas/philip/tests/2d.path.arcTo.scale.html: Added.
  • fast/canvas/philip/tests/2d.path.arcTo.shape.curve1.html: Added.
  • fast/canvas/philip/tests/2d.path.arcTo.shape.curve2.html: Added.
  • fast/canvas/philip/tests/2d.path.arcTo.shape.end.html: Added.
  • fast/canvas/philip/tests/2d.path.arcTo.shape.start.html: Added.
  • fast/canvas/philip/tests/2d.path.arcTo.transformation.html: Added.
  • fast/canvas/philip/tests/2d.path.arcTo.zero.1.html: Added.
  • fast/canvas/philip/tests/2d.path.arcTo.zero.2.html: Added.
  • fast/canvas/philip/tests/2d.path.beginPath.html: Added.
  • fast/canvas/philip/tests/2d.path.bezierCurveTo.basic.html: Added.
  • fast/canvas/philip/tests/2d.path.bezierCurveTo.ensuresubpath.1.html: Added.
  • fast/canvas/philip/tests/2d.path.bezierCurveTo.ensuresubpath.2.html: Added.
  • fast/canvas/philip/tests/2d.path.bezierCurveTo.nonfinite.html: Added.
  • fast/canvas/philip/tests/2d.path.bezierCurveTo.scaled.html: Added.
  • fast/canvas/philip/tests/2d.path.bezierCurveTo.shape.html: Added.
  • fast/canvas/philip/tests/2d.path.clip.basic.1.html: Added.
  • fast/canvas/philip/tests/2d.path.clip.basic.2.html: Added.
  • fast/canvas/philip/tests/2d.path.clip.empty.html: Added.
  • fast/canvas/philip/tests/2d.path.clip.intersect.html: Added.
  • fast/canvas/philip/tests/2d.path.clip.unaffected.html: Added.
  • fast/canvas/philip/tests/2d.path.clip.winding.1.html: Added.
  • fast/canvas/philip/tests/2d.path.clip.winding.2.html: Added.
  • fast/canvas/philip/tests/2d.path.closePath.empty.html: Added.
  • fast/canvas/philip/tests/2d.path.closePath.newline.html: Added.
  • fast/canvas/philip/tests/2d.path.closePath.nextpoint.html: Added.
  • fast/canvas/philip/tests/2d.path.fill.closed.basic.html: Added.
  • fast/canvas/philip/tests/2d.path.fill.closed.unaffected.html: Added.
  • fast/canvas/philip/tests/2d.path.fill.overlap.html: Added.
  • fast/canvas/philip/tests/2d.path.fill.overlap.png: Added.
  • fast/canvas/philip/tests/2d.path.fill.winding.add.html: Added.
  • fast/canvas/philip/tests/2d.path.fill.winding.subtract.1.html: Added.
  • fast/canvas/philip/tests/2d.path.fill.winding.subtract.2.html: Added.
  • fast/canvas/philip/tests/2d.path.fill.winding.subtract.3.html: Added.
  • fast/canvas/philip/tests/2d.path.initial.html: Added.
  • fast/canvas/philip/tests/2d.path.isPointInPath.arc.html: Added.
  • fast/canvas/philip/tests/2d.path.isPointInPath.basic.1.html: Added.
  • fast/canvas/philip/tests/2d.path.isPointInPath.basic.2.html: Added.
  • fast/canvas/philip/tests/2d.path.isPointInPath.bezier.html: Added.
  • fast/canvas/philip/tests/2d.path.isPointInPath.bigarc.html: Added.
  • fast/canvas/philip/tests/2d.path.isPointInPath.edge.html: Added.
  • fast/canvas/philip/tests/2d.path.isPointInPath.empty.html: Added.
  • fast/canvas/philip/tests/2d.path.isPointInPath.nonfinite.html: Added.
  • fast/canvas/philip/tests/2d.path.isPointInPath.outside.html: Added.
  • fast/canvas/philip/tests/2d.path.isPointInPath.subpath.html: Added.
  • fast/canvas/philip/tests/2d.path.isPointInPath.transform.1.html: Added.
  • fast/canvas/philip/tests/2d.path.isPointInPath.transform.2.html: Added.
  • fast/canvas/philip/tests/2d.path.isPointInPath.transform.3.html: Added.
  • fast/canvas/philip/tests/2d.path.isPointInPath.unclosed.html: Added.
  • fast/canvas/philip/tests/2d.path.isPointInPath.winding.html: Added.
  • fast/canvas/philip/tests/2d.path.lineTo.basic.html: Added.
  • fast/canvas/philip/tests/2d.path.lineTo.ensuresubpath.1.html: Added.
  • fast/canvas/philip/tests/2d.path.lineTo.ensuresubpath.2.html: Added.
  • fast/canvas/philip/tests/2d.path.lineTo.nextpoint.html: Added.
  • fast/canvas/philip/tests/2d.path.lineTo.nonfinite.html: Added.
  • fast/canvas/philip/tests/2d.path.moveTo.basic.html: Added.
  • fast/canvas/philip/tests/2d.path.moveTo.multiple.html: Added.
  • fast/canvas/philip/tests/2d.path.moveTo.newsubpath.html: Added.
  • fast/canvas/philip/tests/2d.path.moveTo.nonfinite.html: Added.
  • fast/canvas/philip/tests/2d.path.quadraticCurveTo.basic.html: Added.
  • fast/canvas/philip/tests/2d.path.quadraticCurveTo.ensuresubpath.1.html: Added.
  • fast/canvas/philip/tests/2d.path.quadraticCurveTo.ensuresubpath.2.html: Added.
  • fast/canvas/philip/tests/2d.path.quadraticCurveTo.nonfinite.html: Added.
  • fast/canvas/philip/tests/2d.path.quadraticCurveTo.scaled.html: Added.
  • fast/canvas/philip/tests/2d.path.quadraticCurveTo.shape.html: Added.
  • fast/canvas/philip/tests/2d.path.rect.basic.html: Added.
  • fast/canvas/philip/tests/2d.path.rect.closed.html: Added.
  • fast/canvas/philip/tests/2d.path.rect.end.1.html: Added.
  • fast/canvas/philip/tests/2d.path.rect.end.2.html: Added.
  • fast/canvas/philip/tests/2d.path.rect.negative.html: Added.
  • fast/canvas/philip/tests/2d.path.rect.newsubpath.html: Added.
  • fast/canvas/philip/tests/2d.path.rect.nonfinite.html: Added.
  • fast/canvas/philip/tests/2d.path.rect.selfintersect.html: Added.
  • fast/canvas/philip/tests/2d.path.rect.winding.html: Added.
  • fast/canvas/philip/tests/2d.path.rect.zero.1.html: Added.
  • fast/canvas/philip/tests/2d.path.rect.zero.2.html: Added.
  • fast/canvas/philip/tests/2d.path.rect.zero.3.html: Added.
  • fast/canvas/philip/tests/2d.path.rect.zero.4.html: Added.
  • fast/canvas/philip/tests/2d.path.rect.zero.5.html: Added.
  • fast/canvas/philip/tests/2d.path.rect.zero.6.html: Added.
  • fast/canvas/philip/tests/2d.path.stroke.empty.html: Added.
  • fast/canvas/philip/tests/2d.path.stroke.overlap.html: Added.
  • fast/canvas/philip/tests/2d.path.stroke.overlap.png: Added.
  • fast/canvas/philip/tests/2d.path.stroke.prune.arc.html: Added.
  • fast/canvas/philip/tests/2d.path.stroke.prune.closed.html: Added.
  • fast/canvas/philip/tests/2d.path.stroke.prune.corner.html: Added.
  • fast/canvas/philip/tests/2d.path.stroke.prune.curve.html: Added.
  • fast/canvas/philip/tests/2d.path.stroke.prune.line.html: Added.
  • fast/canvas/philip/tests/2d.path.stroke.prune.rect.html: Added.
  • fast/canvas/philip/tests/2d.path.stroke.scale1.html: Added.
  • fast/canvas/philip/tests/2d.path.stroke.scale2.html: Added.
  • fast/canvas/philip/tests/2d.path.stroke.skew.html: Added.
  • fast/canvas/philip/tests/2d.path.stroke.unaffected.html: Added.
  • fast/canvas/philip/tests/2d.path.stroke.union.html: Added.
  • fast/canvas/philip/tests/2d.path.transformation.basic.html: Added.
  • fast/canvas/philip/tests/2d.path.transformation.changing.html: Added.
  • fast/canvas/philip/tests/2d.path.transformation.multiple.html: Added.
  • fast/canvas/philip/tests/2d.pattern.animated.gif.html: Added.
  • fast/canvas/philip/tests/2d.pattern.basic.canvas.html: Added.
  • fast/canvas/philip/tests/2d.pattern.basic.image.html: Added.
  • fast/canvas/philip/tests/2d.pattern.basic.nocontext.html: Added.
  • fast/canvas/philip/tests/2d.pattern.basic.type.html: Added.
  • fast/canvas/philip/tests/2d.pattern.basic.zerocanvas.html: Added.
  • fast/canvas/philip/tests/2d.pattern.crosscanvas.html: Added.
  • fast/canvas/philip/tests/2d.pattern.image.broken.html: Added.
  • fast/canvas/philip/tests/2d.pattern.image.incomplete.html: Added.
  • fast/canvas/philip/tests/2d.pattern.image.null.html: Added.
  • fast/canvas/philip/tests/2d.pattern.image.string.html: Added.
  • fast/canvas/philip/tests/2d.pattern.image.undefined.html: Added.
  • fast/canvas/philip/tests/2d.pattern.modify.canvas1.html: Added.
  • fast/canvas/philip/tests/2d.pattern.modify.canvas2.html: Added.
  • fast/canvas/philip/tests/2d.pattern.modify.image1.html: Added.
  • fast/canvas/philip/tests/2d.pattern.modify.image2.html: Added.
  • fast/canvas/philip/tests/2d.pattern.paint.norepeat.basic.html: Added.
  • fast/canvas/philip/tests/2d.pattern.paint.norepeat.coord1.html: Added.
  • fast/canvas/philip/tests/2d.pattern.paint.norepeat.coord2.html: Added.
  • fast/canvas/philip/tests/2d.pattern.paint.norepeat.coord3.html: Added.
  • fast/canvas/philip/tests/2d.pattern.paint.norepeat.outside.html: Added.
  • fast/canvas/philip/tests/2d.pattern.paint.orientation.canvas.html: Added.
  • fast/canvas/philip/tests/2d.pattern.paint.orientation.image.html: Added.
  • fast/canvas/philip/tests/2d.pattern.paint.repeat.basic.html: Added.
  • fast/canvas/philip/tests/2d.pattern.paint.repeat.coord1.html: Added.
  • fast/canvas/philip/tests/2d.pattern.paint.repeat.coord2.html: Added.
  • fast/canvas/philip/tests/2d.pattern.paint.repeat.coord3.html: Added.
  • fast/canvas/philip/tests/2d.pattern.paint.repeat.outside.html: Added.
  • fast/canvas/philip/tests/2d.pattern.paint.repeatx.basic.html: Added.
  • fast/canvas/philip/tests/2d.pattern.paint.repeatx.coord1.html: Added.
  • fast/canvas/philip/tests/2d.pattern.paint.repeatx.outside.html: Added.
  • fast/canvas/philip/tests/2d.pattern.paint.repeaty.basic.html: Added.
  • fast/canvas/philip/tests/2d.pattern.paint.repeaty.coord1.html: Added.
  • fast/canvas/philip/tests/2d.pattern.paint.repeaty.outside.html: Added.
  • fast/canvas/philip/tests/2d.pattern.repeat.case.html: Added.
  • fast/canvas/philip/tests/2d.pattern.repeat.empty.html: Added.
  • fast/canvas/philip/tests/2d.pattern.repeat.null.html: Added.
  • fast/canvas/philip/tests/2d.pattern.repeat.nullsuffix.html: Added.
  • fast/canvas/philip/tests/2d.pattern.repeat.undefined.html: Added.
  • fast/canvas/philip/tests/2d.pattern.repeat.unrecognised.html: Added.
  • fast/canvas/philip/tests/2d.scaled.html: Added.
  • fast/canvas/philip/tests/2d.scaled.png: Added.
  • fast/canvas/philip/tests/2d.shadow.alpha.1.html: Added.
  • fast/canvas/philip/tests/2d.shadow.alpha.2.html: Added.
  • fast/canvas/philip/tests/2d.shadow.alpha.2.png: Added.
  • fast/canvas/philip/tests/2d.shadow.alpha.3.html: Added.
  • fast/canvas/philip/tests/2d.shadow.alpha.3.png: Added.
  • fast/canvas/philip/tests/2d.shadow.alpha.4.html: Added.
  • fast/canvas/philip/tests/2d.shadow.alpha.4.png: Added.
  • fast/canvas/philip/tests/2d.shadow.alpha.5.html: Added.
  • fast/canvas/philip/tests/2d.shadow.alpha.5.png: Added.
  • fast/canvas/philip/tests/2d.shadow.attributes.shadowBlur.initial.html: Added.
  • fast/canvas/philip/tests/2d.shadow.attributes.shadowBlur.invalid.html: Added.
  • fast/canvas/philip/tests/2d.shadow.attributes.shadowBlur.valid.html: Added.
  • fast/canvas/philip/tests/2d.shadow.attributes.shadowColor.initial.html: Added.
  • fast/canvas/philip/tests/2d.shadow.attributes.shadowColor.invalid.html: Added.
  • fast/canvas/philip/tests/2d.shadow.attributes.shadowColor.valid.html: Added.
  • fast/canvas/philip/tests/2d.shadow.attributes.shadowOffset.initial.html: Added.
  • fast/canvas/philip/tests/2d.shadow.attributes.shadowOffset.invalid.html: Added.
  • fast/canvas/philip/tests/2d.shadow.attributes.shadowOffset.valid.html: Added.
  • fast/canvas/philip/tests/2d.shadow.blur.high.html: Added.
  • fast/canvas/philip/tests/2d.shadow.blur.high.png: Added.
  • fast/canvas/philip/tests/2d.shadow.blur.low.html: Added.
  • fast/canvas/philip/tests/2d.shadow.blur.low.png: Added.
  • fast/canvas/philip/tests/2d.shadow.canvas.alpha.html: Added.
  • fast/canvas/philip/tests/2d.shadow.canvas.alpha.png: Added.
  • fast/canvas/philip/tests/2d.shadow.canvas.basic.html: Added.
  • fast/canvas/philip/tests/2d.shadow.canvas.transparent.1.html: Added.
  • fast/canvas/philip/tests/2d.shadow.canvas.transparent.2.html: Added.
  • fast/canvas/philip/tests/2d.shadow.clip.1.html: Added.
  • fast/canvas/philip/tests/2d.shadow.clip.2.html: Added.
  • fast/canvas/philip/tests/2d.shadow.clip.3.html: Added.
  • fast/canvas/philip/tests/2d.shadow.composite.1.html: Added.
  • fast/canvas/philip/tests/2d.shadow.composite.2.html: Added.
  • fast/canvas/philip/tests/2d.shadow.composite.3.html: Added.
  • fast/canvas/philip/tests/2d.shadow.enable.blur.html: Added.
  • fast/canvas/philip/tests/2d.shadow.enable.off.1.html: Added.
  • fast/canvas/philip/tests/2d.shadow.enable.off.2.html: Added.
  • fast/canvas/philip/tests/2d.shadow.enable.x.html: Added.
  • fast/canvas/philip/tests/2d.shadow.enable.y.html: Added.
  • fast/canvas/philip/tests/2d.shadow.gradient.alpha.html: Added.
  • fast/canvas/philip/tests/2d.shadow.gradient.alpha.png: Added.
  • fast/canvas/philip/tests/2d.shadow.gradient.basic.html: Added.
  • fast/canvas/philip/tests/2d.shadow.gradient.transparent.1.html: Added.
  • fast/canvas/philip/tests/2d.shadow.gradient.transparent.2.html: Added.
  • fast/canvas/philip/tests/2d.shadow.image.alpha.html: Added.
  • fast/canvas/philip/tests/2d.shadow.image.alpha.png: Added.
  • fast/canvas/philip/tests/2d.shadow.image.basic.html: Added.
  • fast/canvas/philip/tests/2d.shadow.image.scale.html: Added.
  • fast/canvas/philip/tests/2d.shadow.image.section.html: Added.
  • fast/canvas/philip/tests/2d.shadow.image.transparent.1.html: Added.
  • fast/canvas/philip/tests/2d.shadow.image.transparent.2.html: Added.
  • fast/canvas/philip/tests/2d.shadow.offset.negativeX.html: Added.
  • fast/canvas/philip/tests/2d.shadow.offset.negativeY.html: Added.
  • fast/canvas/philip/tests/2d.shadow.offset.positiveX.html: Added.
  • fast/canvas/philip/tests/2d.shadow.offset.positiveY.html: Added.
  • fast/canvas/philip/tests/2d.shadow.outside.html: Added.
  • fast/canvas/philip/tests/2d.shadow.pattern.alpha.html: Added.
  • fast/canvas/philip/tests/2d.shadow.pattern.alpha.png: Added.
  • fast/canvas/philip/tests/2d.shadow.pattern.basic.html: Added.
  • fast/canvas/philip/tests/2d.shadow.pattern.transparent.1.html: Added.
  • fast/canvas/philip/tests/2d.shadow.pattern.transparent.2.html: Added.
  • fast/canvas/philip/tests/2d.shadow.stroke.basic.html: Added.
  • fast/canvas/philip/tests/2d.shadow.stroke.cap.1.html: Added.
  • fast/canvas/philip/tests/2d.shadow.stroke.cap.2.html: Added.
  • fast/canvas/philip/tests/2d.shadow.stroke.join.1.html: Added.
  • fast/canvas/philip/tests/2d.shadow.stroke.join.2.html: Added.
  • fast/canvas/philip/tests/2d.shadow.stroke.join.3.html: Added.
  • fast/canvas/philip/tests/2d.shadow.transform.1.html: Added.
  • fast/canvas/philip/tests/2d.shadow.transform.2.html: Added.
  • fast/canvas/philip/tests/2d.state.saverestore.bitmap.html: Added.
  • fast/canvas/philip/tests/2d.state.saverestore.clip.html: Added.
  • fast/canvas/philip/tests/2d.state.saverestore.fillStyle.html: Added.
  • fast/canvas/philip/tests/2d.state.saverestore.font.html: Added.
  • fast/canvas/philip/tests/2d.state.saverestore.globalAlpha.html: Added.
  • fast/canvas/philip/tests/2d.state.saverestore.globalCompositeOperation.html: Added.
  • fast/canvas/philip/tests/2d.state.saverestore.lineCap.html: Added.
  • fast/canvas/philip/tests/2d.state.saverestore.lineJoin.html: Added.
  • fast/canvas/philip/tests/2d.state.saverestore.lineWidth.html: Added.
  • fast/canvas/philip/tests/2d.state.saverestore.miterLimit.html: Added.
  • fast/canvas/philip/tests/2d.state.saverestore.path.html: Added.
  • fast/canvas/philip/tests/2d.state.saverestore.shadowBlur.html: Added.
  • fast/canvas/philip/tests/2d.state.saverestore.shadowColor.html: Added.
  • fast/canvas/philip/tests/2d.state.saverestore.shadowOffsetX.html: Added.
  • fast/canvas/philip/tests/2d.state.saverestore.shadowOffsetY.html: Added.
  • fast/canvas/philip/tests/2d.state.saverestore.stack.html: Added.
  • fast/canvas/philip/tests/2d.state.saverestore.stackdepth.html: Added.
  • fast/canvas/philip/tests/2d.state.saverestore.strokeStyle.html: Added.
  • fast/canvas/philip/tests/2d.state.saverestore.textAlign.html: Added.
  • fast/canvas/philip/tests/2d.state.saverestore.textBaseline.html: Added.
  • fast/canvas/philip/tests/2d.state.saverestore.transformation.html: Added.
  • fast/canvas/philip/tests/2d.state.saverestore.underflow.html: Added.
  • fast/canvas/philip/tests/2d.strokeRect.basic.html: Added.
  • fast/canvas/philip/tests/2d.strokeRect.clip.html: Added.
  • fast/canvas/philip/tests/2d.strokeRect.globalalpha.html: Added.
  • fast/canvas/philip/tests/2d.strokeRect.globalcomposite.html: Added.
  • fast/canvas/philip/tests/2d.strokeRect.negative.html: Added.
  • fast/canvas/philip/tests/2d.strokeRect.nonfinite.html: Added.
  • fast/canvas/philip/tests/2d.strokeRect.path.html: Added.
  • fast/canvas/philip/tests/2d.strokeRect.shadow.html: Added.
  • fast/canvas/philip/tests/2d.strokeRect.transform.html: Added.
  • fast/canvas/philip/tests/2d.strokeRect.zero.1.html: Added.
  • fast/canvas/philip/tests/2d.strokeRect.zero.2.html: Added.
  • fast/canvas/philip/tests/2d.strokeRect.zero.3.html: Added.
  • fast/canvas/philip/tests/2d.strokeRect.zero.4.html: Added.
  • fast/canvas/philip/tests/2d.strokeRect.zero.5.html: Added.
  • fast/canvas/philip/tests/2d.strokeStyle.default.html: Added.
  • fast/canvas/philip/tests/2d.text.align.default.html: Added.
  • fast/canvas/philip/tests/2d.text.align.invalid.html: Added.
  • fast/canvas/philip/tests/2d.text.align.valid.html: Added.
  • fast/canvas/philip/tests/2d.text.baseline.default.html: Added.
  • fast/canvas/philip/tests/2d.text.baseline.invalid.html: Added.
  • fast/canvas/philip/tests/2d.text.baseline.valid.html: Added.
  • fast/canvas/philip/tests/2d.text.draw.align.center.html: Added.
  • fast/canvas/philip/tests/2d.text.draw.align.end.ltr.html: Added.
  • fast/canvas/philip/tests/2d.text.draw.align.end.rtl.html: Added.
  • fast/canvas/philip/tests/2d.text.draw.align.left.html: Added.
  • fast/canvas/philip/tests/2d.text.draw.align.right.html: Added.
  • fast/canvas/philip/tests/2d.text.draw.align.start.ltr.html: Added.
  • fast/canvas/philip/tests/2d.text.draw.align.start.rtl.html: Added.
  • fast/canvas/philip/tests/2d.text.draw.baseline.alphabetic.html: Added.
  • fast/canvas/philip/tests/2d.text.draw.baseline.bottom.html: Added.
  • fast/canvas/philip/tests/2d.text.draw.baseline.hanging.html: Added.
  • fast/canvas/philip/tests/2d.text.draw.baseline.ideographic.html: Added.
  • fast/canvas/philip/tests/2d.text.draw.baseline.middle.html: Added.
  • fast/canvas/philip/tests/2d.text.draw.baseline.top.html: Added.
  • fast/canvas/philip/tests/2d.text.draw.fill.basic.html: Added.
  • fast/canvas/philip/tests/2d.text.draw.fill.basic.png: Added.
  • fast/canvas/philip/tests/2d.text.draw.fill.maxWidth.bound.html: Added.
  • fast/canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface.html: Added.
  • fast/canvas/philip/tests/2d.text.draw.fill.maxWidth.large.html: Added.
  • fast/canvas/philip/tests/2d.text.draw.fill.maxWidth.large.png: Added.
  • fast/canvas/philip/tests/2d.text.draw.fill.maxWidth.small.html: Added.
  • fast/canvas/philip/tests/2d.text.draw.fill.maxWidth.zero.html: Added.
  • fast/canvas/philip/tests/2d.text.draw.fill.rtl.html: Added.
  • fast/canvas/philip/tests/2d.text.draw.fill.rtl.png: Added.
  • fast/canvas/philip/tests/2d.text.draw.fill.unaffected.html: Added.
  • fast/canvas/philip/tests/2d.text.draw.fontface.html: Added.
  • fast/canvas/philip/tests/2d.text.draw.fontface.notinpage.html: Added.
  • fast/canvas/philip/tests/2d.text.draw.fontface.repeat.html: Added.
  • fast/canvas/philip/tests/2d.text.draw.kern.consistent.html: Added.
  • fast/canvas/philip/tests/2d.text.draw.space.basic.html: Added.
  • fast/canvas/philip/tests/2d.text.draw.space.collapse.end.html: Added.
  • fast/canvas/philip/tests/2d.text.draw.space.collapse.nonspace.html: Added.
  • fast/canvas/philip/tests/2d.text.draw.space.collapse.other.html: Added.
  • fast/canvas/philip/tests/2d.text.draw.space.collapse.space.html: Added.
  • fast/canvas/philip/tests/2d.text.draw.space.collapse.start.html: Added.
  • fast/canvas/philip/tests/2d.text.draw.stroke.basic.html: Added.
  • fast/canvas/philip/tests/2d.text.draw.stroke.basic.png: Added.
  • fast/canvas/philip/tests/2d.text.draw.stroke.unaffected.html: Added.
  • fast/canvas/philip/tests/2d.text.font.default.html: Added.
  • fast/canvas/philip/tests/2d.text.font.parse.basic.html: Added.
  • fast/canvas/philip/tests/2d.text.font.parse.complex.html: Added.
  • fast/canvas/philip/tests/2d.text.font.parse.invalid.html: Added.
  • fast/canvas/philip/tests/2d.text.font.parse.size.percentage.default.html: Added.
  • fast/canvas/philip/tests/2d.text.font.parse.size.percentage.html: Added.
  • fast/canvas/philip/tests/2d.text.font.parse.system.html: Added.
  • fast/canvas/philip/tests/2d.text.measure.width.basic.html: Added.
  • fast/canvas/philip/tests/2d.text.measure.width.empty.html: Added.
  • fast/canvas/philip/tests/2d.text.measure.width.space.html: Added.
  • fast/canvas/philip/tests/2d.transformation.order.html: Added.
  • fast/canvas/philip/tests/2d.transformation.rotate.direction.html: Added.
  • fast/canvas/philip/tests/2d.transformation.rotate.nonfinite.html: Added.
  • fast/canvas/philip/tests/2d.transformation.rotate.radians.html: Added.
  • fast/canvas/philip/tests/2d.transformation.rotate.wrap.html: Added.
  • fast/canvas/philip/tests/2d.transformation.rotate.wrapnegative.html: Added.
  • fast/canvas/philip/tests/2d.transformation.rotate.zero.html: Added.
  • fast/canvas/philip/tests/2d.transformation.scale.basic.html: Added.
  • fast/canvas/philip/tests/2d.transformation.scale.large.html: Added.
  • fast/canvas/philip/tests/2d.transformation.scale.multiple.html: Added.
  • fast/canvas/philip/tests/2d.transformation.scale.negative.html: Added.
  • fast/canvas/philip/tests/2d.transformation.scale.nonfinite.html: Added.
  • fast/canvas/philip/tests/2d.transformation.scale.zero.html: Added.
  • fast/canvas/philip/tests/2d.transformation.setTransform.multiple.html: Added.
  • fast/canvas/philip/tests/2d.transformation.setTransform.nonfinite.html: Added.
  • fast/canvas/philip/tests/2d.transformation.setTransform.skewed.html: Added.
  • fast/canvas/philip/tests/2d.transformation.transform.identity.html: Added.
  • fast/canvas/philip/tests/2d.transformation.transform.multiply.html: Added.
  • fast/canvas/philip/tests/2d.transformation.transform.nonfinite.html: Added.
  • fast/canvas/philip/tests/2d.transformation.transform.skewed.html: Added.
  • fast/canvas/philip/tests/2d.transformation.translate.basic.html: Added.
  • fast/canvas/philip/tests/2d.transformation.translate.nonfinite.html: Added.
  • fast/canvas/philip/tests/2d.voidreturn.html: Added.
  • fast/canvas/philip/tests/clear-100x50.png: Added.
  • fast/canvas/philip/tests/context.casesensitive.html: Added.
  • fast/canvas/philip/tests/context.emptystring.html: Added.
  • fast/canvas/philip/tests/context.unrecognised.badname.html: Added.
  • fast/canvas/philip/tests/context.unrecognised.badsuffix.html: Added.
  • fast/canvas/philip/tests/context.unrecognised.nullsuffix.html: Added.
  • fast/canvas/philip/tests/context.unrecognised.unicode.html: Added.
  • fast/canvas/philip/tests/fallback.basic.html: Added.
  • fast/canvas/philip/tests/fallback.multiple.html: Added.
  • fast/canvas/philip/tests/fallback.nested.html: Added.
  • fast/canvas/philip/tests/green-100x50.png: Added.
  • fast/canvas/philip/tests/initial.colour.html: Added.
  • fast/canvas/philip/tests/initial.colour.png: Added.
  • fast/canvas/philip/tests/initial.reset.2dstate.html: Added.
  • fast/canvas/philip/tests/initial.reset.clip.html: Added.
  • fast/canvas/philip/tests/initial.reset.different.html: Added.
  • fast/canvas/philip/tests/initial.reset.different.png: Added.
  • fast/canvas/philip/tests/initial.reset.gradient.html: Added.
  • fast/canvas/philip/tests/initial.reset.path.html: Added.
  • fast/canvas/philip/tests/initial.reset.path.png: Added.
  • fast/canvas/philip/tests/initial.reset.pattern.html: Added.
  • fast/canvas/philip/tests/initial.reset.same.html: Added.
  • fast/canvas/philip/tests/initial.reset.same.png: Added.
  • fast/canvas/philip/tests/initial.reset.transform.html: Added.
  • fast/canvas/philip/tests/security.dataURI.html: Added.
  • fast/canvas/philip/tests/security.drawImage.canvas.html: Added.
  • fast/canvas/philip/tests/security.drawImage.image.html: Added.
  • fast/canvas/philip/tests/security.pattern.canvas.fillStyle.html: Added.
  • fast/canvas/philip/tests/security.pattern.canvas.strokeStyle.html: Added.
  • fast/canvas/philip/tests/security.pattern.canvas.timing.html: Added.
  • fast/canvas/philip/tests/security.pattern.create.html: Added.
  • fast/canvas/philip/tests/security.pattern.cross.html: Added.
  • fast/canvas/philip/tests/security.pattern.image.fillStyle.html: Added.
  • fast/canvas/philip/tests/security.pattern.image.strokeStyle.html: Added.
  • fast/canvas/philip/tests/security.reset.html: Added.
  • fast/canvas/philip/tests/size.attributes.default.html: Added.
  • fast/canvas/philip/tests/size.attributes.default.png: Added.
  • fast/canvas/philip/tests/size.attributes.get.html: Added.
  • fast/canvas/philip/tests/size.attributes.get.png: Added.
  • fast/canvas/philip/tests/size.attributes.idl.html: Added.
  • fast/canvas/philip/tests/size.attributes.idl.set.zero.html: Added.
  • fast/canvas/philip/tests/size.attributes.parse.decimal.html: Added.
  • fast/canvas/philip/tests/size.attributes.parse.decimal.png: Added.
  • fast/canvas/philip/tests/size.attributes.parse.em.html: Added.
  • fast/canvas/philip/tests/size.attributes.parse.em.png: Added.
  • fast/canvas/philip/tests/size.attributes.parse.empty.html: Added.
  • fast/canvas/philip/tests/size.attributes.parse.empty.png: Added.
  • fast/canvas/philip/tests/size.attributes.parse.exp.html: Added.
  • fast/canvas/philip/tests/size.attributes.parse.exp.png: Added.
  • fast/canvas/philip/tests/size.attributes.parse.hex.html: Added.
  • fast/canvas/philip/tests/size.attributes.parse.junk.html: Added.
  • fast/canvas/philip/tests/size.attributes.parse.junk.png: Added.
  • fast/canvas/philip/tests/size.attributes.parse.minus.html: Added.
  • fast/canvas/philip/tests/size.attributes.parse.minus.png: Added.
  • fast/canvas/philip/tests/size.attributes.parse.octal.html: Added.
  • fast/canvas/philip/tests/size.attributes.parse.octal.png: Added.
  • fast/canvas/philip/tests/size.attributes.parse.onlyspace.html: Added.
  • fast/canvas/philip/tests/size.attributes.parse.onlyspace.png: Added.
  • fast/canvas/philip/tests/size.attributes.parse.percent.html: Added.
  • fast/canvas/philip/tests/size.attributes.parse.percent.png: Added.
  • fast/canvas/philip/tests/size.attributes.parse.plus.html: Added.
  • fast/canvas/philip/tests/size.attributes.parse.plus.png: Added.
  • fast/canvas/philip/tests/size.attributes.parse.space.html: Added.
  • fast/canvas/philip/tests/size.attributes.parse.space.png: Added.
  • fast/canvas/philip/tests/size.attributes.parse.trailingjunk.html: Added.
  • fast/canvas/philip/tests/size.attributes.parse.trailingjunk.png: Added.
  • fast/canvas/philip/tests/size.attributes.parse.whitespace.html: Added.
  • fast/canvas/philip/tests/size.attributes.parse.whitespace.png: Added.
  • fast/canvas/philip/tests/size.attributes.parse.zero.html: Added.
  • fast/canvas/philip/tests/size.attributes.reflect.setcontent.html: Added.
  • fast/canvas/philip/tests/size.attributes.reflect.setcontent.png: Added.
  • fast/canvas/philip/tests/size.attributes.reflect.setidl.html: Added.
  • fast/canvas/philip/tests/size.attributes.reflect.setidl.png: Added.
  • fast/canvas/philip/tests/size.attributes.reflect.setidlzero.html: Added.
  • fast/canvas/philip/tests/size.attributes.removed.html: Added.
  • fast/canvas/philip/tests/size.attributes.removed.png: Added.
  • fast/canvas/philip/tests/size.attributes.set.html: Added.
  • fast/canvas/philip/tests/size.attributes.set.png: Added.
  • fast/canvas/philip/tests/size.attributes.setAttribute.decimal.html: Added.
  • fast/canvas/philip/tests/size.attributes.setAttribute.decimal.png: Added.
  • fast/canvas/philip/tests/size.attributes.setAttribute.em.html: Added.
  • fast/canvas/philip/tests/size.attributes.setAttribute.em.png: Added.
  • fast/canvas/philip/tests/size.attributes.setAttribute.empty.html: Added.
  • fast/canvas/philip/tests/size.attributes.setAttribute.empty.png: Added.
  • fast/canvas/philip/tests/size.attributes.setAttribute.exp.html: Added.
  • fast/canvas/philip/tests/size.attributes.setAttribute.exp.png: Added.
  • fast/canvas/philip/tests/size.attributes.setAttribute.hex.html: Added.
  • fast/canvas/philip/tests/size.attributes.setAttribute.junk.html: Added.
  • fast/canvas/philip/tests/size.attributes.setAttribute.junk.png: Added.
  • fast/canvas/philip/tests/size.attributes.setAttribute.minus.html: Added.
  • fast/canvas/philip/tests/size.attributes.setAttribute.minus.png: Added.
  • fast/canvas/philip/tests/size.attributes.setAttribute.octal.html: Added.
  • fast/canvas/philip/tests/size.attributes.setAttribute.octal.png: Added.
  • fast/canvas/philip/tests/size.attributes.setAttribute.onlyspace.html: Added.
  • fast/canvas/philip/tests/size.attributes.setAttribute.onlyspace.png: Added.
  • fast/canvas/philip/tests/size.attributes.setAttribute.percent.html: Added.
  • fast/canvas/philip/tests/size.attributes.setAttribute.percent.png: Added.
  • fast/canvas/philip/tests/size.attributes.setAttribute.plus.html: Added.
  • fast/canvas/philip/tests/size.attributes.setAttribute.plus.png: Added.
  • fast/canvas/philip/tests/size.attributes.setAttribute.space.html: Added.
  • fast/canvas/philip/tests/size.attributes.setAttribute.space.png: Added.
  • fast/canvas/philip/tests/size.attributes.setAttribute.trailingjunk.html: Added.
  • fast/canvas/philip/tests/size.attributes.setAttribute.trailingjunk.png: Added.
  • fast/canvas/philip/tests/size.attributes.setAttribute.whitespace.html: Added.
  • fast/canvas/philip/tests/size.attributes.setAttribute.whitespace.png: Added.
  • fast/canvas/philip/tests/size.attributes.setAttribute.zero.html: Added.
  • fast/canvas/philip/tests/size.attributes.style.html: Added.
  • fast/canvas/philip/tests/size.attributes.style.png: Added.
  • fast/canvas/philip/tests/toDataURL.arguments.1.html: Added.
  • fast/canvas/philip/tests/toDataURL.arguments.2.html: Added.
  • fast/canvas/philip/tests/toDataURL.arguments.3.html: Added.
  • fast/canvas/philip/tests/toDataURL.bogustype.html: Added.
  • fast/canvas/philip/tests/toDataURL.default.html: Added.
  • fast/canvas/philip/tests/toDataURL.jpeg.alpha.html: Added.
  • fast/canvas/philip/tests/toDataURL.jpeg.alpha.png: Added.
  • fast/canvas/philip/tests/toDataURL.jpeg.primarycolours.html: Added.
  • fast/canvas/philip/tests/toDataURL.jpeg.primarycolours.png: Added.
  • fast/canvas/philip/tests/toDataURL.jpeg.quality.basic.html: Added.
  • fast/canvas/philip/tests/toDataURL.jpeg.quality.basic.png: Added.
  • fast/canvas/philip/tests/toDataURL.jpeg.quality.notnumber.html: Added.
  • fast/canvas/philip/tests/toDataURL.jpeg.quality.outsiderange.html: Added.
  • fast/canvas/philip/tests/toDataURL.lowercase.ascii.html: Added.
  • fast/canvas/philip/tests/toDataURL.lowercase.unicode.html: Added.
  • fast/canvas/philip/tests/toDataURL.nocontext.html: Added.
  • fast/canvas/philip/tests/toDataURL.png.complexcolours.html: Added.
  • fast/canvas/philip/tests/toDataURL.png.complexcolours.png: Added.
  • fast/canvas/philip/tests/toDataURL.png.html: Added.
  • fast/canvas/philip/tests/toDataURL.png.primarycolours.html: Added.
  • fast/canvas/philip/tests/toDataURL.png.primarycolours.png: Added.
  • fast/canvas/philip/tests/toDataURL.unrecognised.html: Added.
  • fast/canvas/philip/tests/toDataURL.zerosize.html: Added.
  • fast/canvas/philip/tests/type.delete.html: Added.
  • fast/canvas/philip/tests/type.exists.html: Added.
  • fast/canvas/philip/tests/type.extend.html: Added.
  • fast/canvas/philip/tests/type.name.html: Added.
  • fast/canvas/philip/tests/type.prototype.html: Added.
  • fast/canvas/philip/tests/type.replace.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
1:25 PM Changeset in webkit [59953] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed. Update Qt specific expected file after r59941.

  • platform/qt/fast/dom/prototype-inheritance-expected.txt: updated.
1:20 PM Changeset in webkit [59952] by alex
  • 2 edits in trunk/LayoutTests

2010-05-21 Alejandro G. Castro <alex@igalia.com>

Rubber-stamped by Xan Lopez.

Updated test results.

  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
1:07 PM Changeset in webkit [59951] by Csaba Osztrogonác
  • 2 edits in trunk/JavaScriptCore

Unreviewed buildfix for Qt after r59941.

  • JavaScriptCore.pro: missing runtime/JSObjectWithGlobalObject.cpp added to SOURCES.
12:53 PM Changeset in webkit [59950] by Beth Dakin
  • 3 edits
    4 adds in trunk

WebCore: Fix for <rdar://problem/8009118> Crash in WebCore::toAlphabetic()
while running MangleMe
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=39508

Reviewed by Darin Adler.

The math was slightly off here, and we wound up trying to access an
array at index -1 in some cases. We need to decrement numberShadow
rather than subtracting one from the result of the modulo
operation.

  • rendering/RenderListMarker.cpp:

(WebCore::toAlphabeticOrNumeric):

LayoutTests: Test for <rdar://problem/8009118> Crash in WebCore::toAlphabetic()
while running MangleMe
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=39508

Reviewed by Darin Adler.

  • fast/lists/alpha-boundary-values.html: Added.
  • platform/mac/fast/lists/alpha-boundary-values-expected.checksum: Added.
  • platform/mac/fast/lists/alpha-boundary-values-expected.png: Added.
  • platform/mac/fast/lists/alpha-boundary-values-expected.txt: Added.
12:20 PM Changeset in webkit [59949] by oliver@apple.com
  • 2 edits in trunk/WebCore

Qt buildfix #2

12:11 PM Changeset in webkit [59948] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix #3

12:06 PM Changeset in webkit [59947] by oliver@apple.com
  • 3 edits in trunk/WebCore

Qt buildfix #1

12:04 PM Changeset in webkit [59946] by crogers@google.com
  • 2 edits in branches/audio/WebCore/audio

Some stopgap sanity checks in resampler to avoid crashes - until this code can really be cleaned up

12:04 PM Changeset in webkit [59945] by crogers@google.com
  • 8 edits in branches/audio/WebCore/audio

Don't rely on garbage collection of AudioContext for audio to stop playing when page unloads

  • also don't use object composition of AudioOutputNode in AudioContext - use RefPtr instead since this can be wrapped in a javascript wrapper!
11:57 AM Changeset in webkit [59944] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix #2

11:56 AM Changeset in webkit [59943] by ggaren@apple.com
  • 3 edits in trunk/WebCore

Fixed failure seen on buildbot (due to flaky test).

Reviewed by Oliver Hunt.

Don't report an exception in a nested script evaluation -- just pass the
exception on to our caller. Our caller can decide to report the exception,
if it fully propagates -- but we don't want to report an exception that's
going to get caught.

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::ScriptController):
(WebCore::ScriptController::evaluateInWorld):

  • bindings/js/ScriptController.h:
11:42 AM Changeset in webkit [59942] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix #1

11:19 AM Changeset in webkit [59941] by oliver@apple.com
  • 114 edits
    3 adds in trunk

2010-05-21 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

All callable objects should have a global object reference
https://bugs.webkit.org/show_bug.cgi?id=39495

All objects that may ever return a value other CallTypeNone
or ConstructTypeNone now get a global object in their constructor
and store that in their first anonymous slot. We add a new type
JSObjectWithGlobalObject to allow us to share this logic as much
as possible, however some objects have specific inheritance
requirements so we can't just use it universally.

To enforce this requirement JSValue::getCallData and getConstructData
make use of a new "isValidCallee" function to assert that any object
that returns a value other than CallType/ConstructTypeNone has a
global object in anonymous slot 0.

In order to ensure that static function slots are converted into
function objects with the correct global object, all prototype objects
and other classes with static function slots also gain a global object
reference. Happily this fixes the long standing issue where host
function objects get a prototype from the lexical global object of the
first function that calls them, instead of the global object that they
are defined on.

  • API/JSCallbackConstructor.cpp: (JSC::JSCallbackConstructor::JSCallbackConstructor):
  • API/JSCallbackConstructor.h:
  • API/JSCallbackFunction.cpp: (JSC::JSCallbackFunction::JSCallbackFunction):
  • API/JSCallbackFunction.h:
  • API/JSCallbackObject.cpp: (JSC::):
  • API/JSCallbackObject.h:
  • API/JSCallbackObjectFunctions.h: (JSC::::JSCallbackObject): (JSC::::staticFunctionGetter):
  • API/JSClassRef.cpp: (OpaqueJSClass::prototype):
  • API/JSContextRef.cpp:
  • API/JSObjectRef.cpp: (JSObjectMake): (JSObjectMakeFunctionWithCallback): (JSObjectMakeConstructor): (JSObjectGetPrivate): (JSObjectSetPrivate): (JSObjectGetPrivateProperty): (JSObjectSetPrivateProperty): (JSObjectDeletePrivateProperty):
  • API/JSValueRef.cpp: (JSValueIsObjectOfClass):
  • API/JSWeakObjectMapRefPrivate.cpp:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • JavaScriptCore.exp:
  • JavaScriptCore.gypi:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
  • jsc.cpp: (GlobalObject::GlobalObject):
  • runtime/ArrayConstructor.cpp: (JSC::ArrayConstructor::ArrayConstructor):
  • runtime/ArrayConstructor.h:
  • runtime/ArrayPrototype.cpp: (JSC::ArrayPrototype::ArrayPrototype):
  • runtime/ArrayPrototype.h: (JSC::ArrayPrototype::createStructure):
  • runtime/BooleanConstructor.cpp: (JSC::BooleanConstructor::BooleanConstructor):
  • runtime/BooleanConstructor.h:
  • runtime/BooleanPrototype.cpp: (JSC::BooleanPrototype::BooleanPrototype):
  • runtime/BooleanPrototype.h:
  • runtime/DateConstructor.cpp: (JSC::DateConstructor::DateConstructor):
  • runtime/DateConstructor.h:
  • runtime/DatePrototype.cpp: (JSC::DatePrototype::DatePrototype):
  • runtime/DatePrototype.h:
  • runtime/ErrorConstructor.cpp: (JSC::ErrorConstructor::ErrorConstructor):
  • runtime/ErrorConstructor.h:
  • runtime/ErrorPrototype.cpp: (JSC::ErrorPrototype::ErrorPrototype):
  • runtime/ErrorPrototype.h:
  • runtime/FunctionConstructor.cpp: (JSC::FunctionConstructor::FunctionConstructor):
  • runtime/FunctionConstructor.h:
  • runtime/FunctionPrototype.cpp: (JSC::FunctionPrototype::FunctionPrototype): (JSC::FunctionPrototype::addFunctionProperties):
  • runtime/FunctionPrototype.h:
  • runtime/GlobalEvalFunction.cpp: (JSC::GlobalEvalFunction::GlobalEvalFunction):
  • runtime/GlobalEvalFunction.h:
  • runtime/InternalFunction.cpp: (JSC::InternalFunction::InternalFunction):
  • runtime/InternalFunction.h:
  • runtime/JSCell.h: (JSC::JSValue::getCallData): (JSC::JSValue::getConstructData):
  • runtime/JSFunction.cpp: (JSC::JSFunction::JSFunction):
  • runtime/JSFunction.h:
  • runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset):
  • runtime/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObject):
  • runtime/JSONObject.cpp: (JSC::JSONObject::JSONObject):
  • runtime/JSONObject.h:
  • runtime/JSObject.h:
  • runtime/JSObjectWithGlobalObject.cpp: Added. (JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject):
  • runtime/JSObjectWithGlobalObject.h: Added. (JSC::JSObjectWithGlobalObject::createStructure): (JSC::JSObjectWithGlobalObject::JSObjectWithGlobalObject):
  • runtime/JSValue.cpp: (JSC::JSValue::isValidCallee):
  • runtime/JSValue.h:
  • runtime/Lookup.cpp: (JSC::setUpStaticFunctionSlot):
  • runtime/MathObject.cpp: (JSC::MathObject::MathObject):
  • runtime/MathObject.h:
  • runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::NativeErrorConstructor):
  • runtime/NativeErrorConstructor.h:
  • runtime/NativeErrorPrototype.cpp: (JSC::NativeErrorPrototype::NativeErrorPrototype):
  • runtime/NativeErrorPrototype.h:
  • runtime/NumberConstructor.cpp: (JSC::NumberConstructor::NumberConstructor):
  • runtime/NumberConstructor.h:
  • runtime/NumberPrototype.cpp: (JSC::NumberPrototype::NumberPrototype):
  • runtime/NumberPrototype.h:
  • runtime/ObjectConstructor.cpp: (JSC::ObjectConstructor::ObjectConstructor):
  • runtime/ObjectConstructor.h:
  • runtime/ObjectPrototype.cpp: (JSC::ObjectPrototype::ObjectPrototype):
  • runtime/ObjectPrototype.h:
  • runtime/PrototypeFunction.cpp: (JSC::PrototypeFunction::PrototypeFunction):
  • runtime/PrototypeFunction.h:
  • runtime/RegExpConstructor.cpp: (JSC::RegExpConstructor::RegExpConstructor): (JSC::constructRegExp):
  • runtime/RegExpConstructor.h:
  • runtime/RegExpObject.cpp: (JSC::RegExpObject::RegExpObject):
  • runtime/RegExpObject.h:
  • runtime/RegExpPrototype.cpp: (JSC::RegExpPrototype::RegExpPrototype):
  • runtime/RegExpPrototype.h:
  • runtime/StringConstructor.cpp: (JSC::StringConstructor::StringConstructor):
  • runtime/StringConstructor.h:
  • runtime/StringPrototype.cpp: (JSC::StringPrototype::StringPrototype):
  • runtime/StringPrototype.h:

2010-05-21 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

All callable objects should have a global object reference
https://bugs.webkit.org/show_bug.cgi?id=39495

Update expected results as we now give all function objects
get their prototypes from the correct global object.

  • fast/dom/prototype-inheritance-expected.txt:

2010-05-21 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

All callable objects should have a global object reference
https://bugs.webkit.org/show_bug.cgi?id=39495

Update the bindings generator to give prototype objects a
global object. Update all the manually written JSObject
subclasses to pass a global object.

  • ForwardingHeaders/runtime/JSObjectWithGlobalObject.h: Added.
  • WebCore.PluginHostProcess.exp:
  • bindings/js/JSDOMBinding.cpp: (WebCore::objectToStringFunctionGetter):
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::nonCachingStaticFunctionGetter):
  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::setWindow):
  • bindings/js/JSHistoryCustom.cpp: (WebCore::nonCachingStaticBackFunctionGetter): (WebCore::nonCachingStaticForwardFunctionGetter): (WebCore::nonCachingStaticGoFunctionGetter):
  • bindings/js/JSLocationCustom.cpp: (WebCore::nonCachingStaticReplaceFunctionGetter): (WebCore::nonCachingStaticReloadFunctionGetter): (WebCore::nonCachingStaticAssignFunctionGetter):
  • bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::initScript):
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/c/CRuntimeObject.cpp: (JSC::Bindings::CRuntimeObject::CRuntimeObject):
  • bridge/c/CRuntimeObject.h:
  • bridge/c/c_instance.cpp: (JSC::Bindings::CInstance::newRuntimeObject): (JSC::Bindings::CRuntimeMethod::CRuntimeMethod): (JSC::Bindings::CInstance::getMethod):
  • bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::newRuntimeObject): (JavaRuntimeMethod::JavaRuntimeMethod): (JavaInstance::getMethod):
  • bridge/jni/jsc/JavaRuntimeObject.cpp: (JSC::Bindings::JavaRuntimeObject::JavaRuntimeObject):
  • bridge/jni/jsc/JavaRuntimeObject.h:
  • bridge/jsc/BridgeJSC.cpp: (JSC::Bindings::Instance::newRuntimeObject):
  • bridge/objc/ObjCRuntimeObject.h:
  • bridge/objc/ObjCRuntimeObject.mm: (JSC::Bindings::ObjCRuntimeObject::ObjCRuntimeObject):
  • bridge/objc/objc_class.mm: (JSC::Bindings::ObjcClass::fallbackObject):
  • bridge/objc/objc_instance.mm: (ObjcInstance::newRuntimeObject): (ObjCRuntimeMethod::ObjCRuntimeMethod): (ObjcInstance::getMethod):
  • bridge/objc/objc_runtime.h:
  • bridge/objc/objc_runtime.mm: (JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):
  • bridge/runtime_method.cpp: (JSC::RuntimeMethod::RuntimeMethod):
  • bridge/runtime_method.h:
  • bridge/runtime_object.cpp: (JSC::Bindings::RuntimeObject::RuntimeObject):
  • bridge/runtime_object.h:

2010-05-21 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

All callable objects should have a global object reference
https://bugs.webkit.org/show_bug.cgi?id=39495

Update the plugin proxy to handle the need for global object.

  • Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::newRuntimeObject): (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod): (WebKit::ProxyInstance::getMethod):
  • Plugins/Hosted/ProxyRuntimeObject.h:
  • Plugins/Hosted/ProxyRuntimeObject.mm: (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
11:14 AM Changeset in webkit [59940] by victorw@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-21 Victor Wang <victorw@chromium.org>

Unremivewed. Update test expecations for chromium.

  • platform/chromium/test_expectations.txt:
10:20 AM Changeset in webkit [59939] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

2010-05-21 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Need a short description and bug URL (OOPS!)


Removed the unused entry in the CallFrame, and reordered CallFrame
writes on the hot path to be in forwards order.


SunSpider says 0.3% faster.

  • interpreter/RegisterFile.h: (JSC::RegisterFile::):
  • jit/JITCall.cpp: (JSC::JIT::compileOpCall):
9:55 AM Changeset in webkit [59938] by eric@webkit.org
  • 4 edits in trunk

2010-05-21 Robin Cao <robin.cao@torchmobile.com.cn>

Reviewed by Adam Roben.

fast/dom/HTMLObjectElement/children-changed.html times out on Windows run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=31315

  • platform/win/Skipped: The test should pass now.

2010-05-21 Robin Cao <robin.cao@torchmobile.com.cn>

Reviewed by Adam Roben.

fast/dom/HTMLObjectElement/children-changed.html times out on Windows run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=31315

  • DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::didFailProvisionalLoadWithError): Need to invoke locationChangeDone here as mac port does.
9:31 AM Changeset in webkit [59937] by steveblock@google.com
  • 2 edits in trunk/WebKit2

Unreviewed build fix for WebKit2

9:27 AM Changeset in webkit [59936] by jparent@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

Updating Chromium test_expectations for newly added test,
svg/animations/animate-points.html which uses unsupported API.

  • platform/chromium/test_expectations.txt:
9:06 AM Changeset in webkit [59935] by steveblock@google.com
  • 22 edits
    3 adds in trunk

2010-05-21 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Add DeviceOrientation and DeviceOrientationClient
https://bugs.webkit.org/show_bug.cgi?id=39479

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl):

2010-05-21 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Add DeviceOrientation and DeviceOrientationClient
https://bugs.webkit.org/show_bug.cgi?id=39479

  • Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate):

2010-05-21 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Add DeviceOrientation and DeviceOrientationClient
https://bugs.webkit.org/show_bug.cgi?id=39479

  • webkit/webkitwebview.cpp: (webkit_web_view_init):

2010-05-21 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Add DeviceOrientation and DeviceOrientationClient
https://bugs.webkit.org/show_bug.cgi?id=39479

  • WebView.cpp: (WebView::initWithFrame):

2010-05-21 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Add DeviceOrientation and DeviceOrientationClient
https://bugs.webkit.org/show_bug.cgi?id=39479

  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):

2010-05-21 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Add DeviceOrientation and DeviceOrientationClient
https://bugs.webkit.org/show_bug.cgi?id=39479

The page owns a DeviceOrientation object, which has a pointer to a
DeviceOrientationClient object provided by the embedder. The
DeviceOrientation object forwards requests to start listening to
orientation to the client, and when updates are available, fires a
DeviceOrientationEvent on the window object.

No new tests are possible at this time as the implementation is
incomplete. Future patches will add LayoutTestController methods
to provide mock orientation events to test this.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.base.exp:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DeviceOrientation.cpp: Added. (WebCore::DeviceOrientation::DeviceOrientation): (WebCore::DeviceOrientation::onDeviceOrientationChange):
  • dom/DeviceOrientation.h: Added.
  • dom/DeviceOrientationClient.h: Added. (WebCore::DeviceOrientationClient::~DeviceOrientationClient):
  • page/Page.cpp: (WebCore::Page::Page):
  • page/Page.h: (WebCore::Page::deviceOrientation):
  • svg/graphics/SVGImage.cpp: (WebCore::SVGImage::dataChanged):
8:28 AM Changeset in webkit [59934] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-21 Tasuku Suzuki <tasuku.suzuki@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Fix compilation with QT_NO_GRAPHICSEFFECT
https://bugs.webkit.org/show_bug.cgi?id=38324

  • platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::flushChanges):
8:01 AM Changeset in webkit [59933] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-21 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Darin Fisher.

Fix the HistoryController::pushState.

It should be possible to call the pushState method from
the first page in a window.

history.pushState doesn't work for the first page in a window.
https://bugs.webkit.org/show_bug.cgi?id=39418

  • loader/HistoryController.cpp: (WebCore::HistoryController::pushState):
7:44 AM QtWebKitJournal edited by Simon Hausmann
(diff)
7:44 AM Changeset in webkit [59932] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-21 Victoria Kirst <vrk@google.com>

Reviewed by David Levin.

[chromium] Fix slider status when buffering
https://bugs.webkit.org/show_bug.cgi?id=39370
Adjusts the buffering bar to be aligned with the slider thumb.

No new tests. (Covered by existing layout tests.)

  • rendering/RenderMediaControlsChromium.cpp: (WebCore::paintMediaSlider): Added logic to align the buffering bar with the thumb. Half of the thumb image is transparent, so the buffer bar is adjusted to fill in this gap.
7:42 AM QtWebKitJournal edited by Simon Hausmann
(diff)
7:40 AM QtWebKitJournal edited by Simon Hausmann
(diff)
7:21 AM Changeset in webkit [59931] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-21 Jesus Sanchez-Palencia <jesus@webkit.org>

Reviewed by Eric Seidel.

Extra processesArguments() calls in Document::processViewport
https://bugs.webkit.org/show_bug.cgi?id=39358

The viewport arguments are only needed when there is a frame->page(),
therefore we don't need to always call processArguments().

  • dom/Document.cpp: (WebCore::Document::processViewport):
6:42 AM Changeset in webkit [59930] by eric@webkit.org
  • 3 edits
    3 adds
    1 delete in trunk/JavaScriptCore

2010-05-21 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Split the QScriptValue autotest into smaller chunks.

File tst_qscriptvalue_generated.cpp was huge and it was difficult to compile
it with MSVS2008, because of the code optimization.

Tests were splited into a few files for better use of distributed
compilation.
Repeated calls to insert() and operator<<() where replaced by loops,
that should reduce time of code optimizing.

New files were generated by the same application, test logic wasn't changed.

[Qt] The QScriptValue autotest should be refactored.
https://bugs.webkit.org/show_bug.cgi?id=38987

  • qt/tests/qscriptvalue/qscriptvalue.pro:
  • qt/tests/qscriptvalue/tst_qscriptvalue.h:
  • qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp: Removed.
  • qt/tests/qscriptvalue/tst_qscriptvalue_generated_init.cpp: Added. (tst_QScriptValue::initScriptValues):
  • qt/tests/qscriptvalue/tst_qscriptvalue_generated_istype.cpp: Added. (tst_QScriptValue::isValid_initData): (tst_QScriptValue::isValid_makeData): (tst_QScriptValue::isValid_test): (tst_QScriptValue::isBool_initData): (tst_QScriptValue::isBool_makeData): (tst_QScriptValue::isBool_test): (tst_QScriptValue::isBoolean_initData): (tst_QScriptValue::isBoolean_makeData): (tst_QScriptValue::isBoolean_test): (tst_QScriptValue::isNumber_initData): (tst_QScriptValue::isNumber_makeData): (tst_QScriptValue::isNumber_test): (tst_QScriptValue::isFunction_initData): (tst_QScriptValue::isFunction_makeData): (tst_QScriptValue::isFunction_test): (tst_QScriptValue::isNull_initData): (tst_QScriptValue::isNull_makeData): (tst_QScriptValue::isNull_test): (tst_QScriptValue::isString_initData): (tst_QScriptValue::isString_makeData): (tst_QScriptValue::isString_test): (tst_QScriptValue::isUndefined_initData): (tst_QScriptValue::isUndefined_makeData): (tst_QScriptValue::isUndefined_test): (tst_QScriptValue::isObject_initData): (tst_QScriptValue::isObject_makeData): (tst_QScriptValue::isObject_test):
  • qt/tests/qscriptvalue/tst_qscriptvalue_generated_totype.cpp: Added. (tst_QScriptValue::toString_initData): (tst_QScriptValue::toString_makeData): (tst_QScriptValue::toString_test): (tst_QScriptValue::toNumber_initData): (tst_QScriptValue::toNumber_makeData): (tst_QScriptValue::toNumber_test): (tst_QScriptValue::toBool_initData): (tst_QScriptValue::toBool_makeData): (tst_QScriptValue::toBool_test): (tst_QScriptValue::toBoolean_initData): (tst_QScriptValue::toBoolean_makeData): (tst_QScriptValue::toBoolean_test): (tst_QScriptValue::toInteger_initData): (tst_QScriptValue::toInteger_makeData): (tst_QScriptValue::toInteger_test): (tst_QScriptValue::toInt32_initData): (tst_QScriptValue::toInt32_makeData): (tst_QScriptValue::toInt32_test): (tst_QScriptValue::toUInt32_initData): (tst_QScriptValue::toUInt32_makeData): (tst_QScriptValue::toUInt32_test): (tst_QScriptValue::toUInt16_initData): (tst_QScriptValue::toUInt16_makeData): (tst_QScriptValue::toUInt16_test):
6:18 AM Changeset in webkit [59929] by Philippe Normand
  • 2 edits
    1 add in trunk/WebCore

2010-05-17 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Carlson.

[GStreamer] video painting support on mac port
https://bugs.webkit.org/show_bug.cgi?id=39206

ImageGStreamer support for mac port. A CG Image is created using
the GstBuffer data. It can then be painted by the gstreamer player.

  • platform/graphics/gstreamer/ImageGStreamer.h:
  • platform/graphics/gstreamer/ImageGStreamerCG.mm: Added. (ImageGStreamer::createImage): (ImageGStreamer::ImageGStreamer): (ImageGStreamer::~ImageGStreamer):
5:55 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
5:53 AM Changeset in webkit [59928] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2010-05-21 Robin Cao <robin.cao@torchmobile.com.cn>

Reviewed by Eric Seidel.

animateTransform does not work on gradientTransform
https://bugs.webkit.org/show_bug.cgi?id=38115

Tests if gradientTransform of a gradient is animateable.

  • svg/animations/animate-gradient-transform-expected.txt: Added.
  • svg/animations/animate-gradient-transform.html: Added.
  • svg/animations/script-tests/animate-gradient-transform.js: Added. (sample1): (sample2): (sample3): (executeTest):

2010-05-21 Robin Cao <robin.cao@torchmobile.com.cn>

Reviewed by Eric Seidel.

animateTransform does not work on gradientTransform
https://bugs.webkit.org/show_bug.cgi?id=38115

Tests: svg/animations/animate-gradient-transform.html

  • svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::hasValidTarget): Check if the target element is gradient. (WebCore::transformListFor): Ditto. (WebCore::SVGAnimateTransformElement::resetToBaseValue): Ditto. (WebCore::SVGAnimateTransformElement::applyResultsToTarget): Ditto.
5:15 AM Changeset in webkit [59927] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-21 Young Han Lee <joybro@company100.net>

Reviewed by Eric Seidel.

Fix guard around DatabaseSync
https://bugs.webkit.org/show_bug.cgi?id=38897

  • storage/DatabaseSync.cpp:
4:59 AM Changeset in webkit [59926] by steveblock@google.com
  • 56 edits
    1 move
    1 delete in trunk/LayoutTests

Geolocation LayoutTests should use standard template pattern
https://bugs.webkit.org/show_bug.cgi?id=39301

4:14 AM Changeset in webkit [59925] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Prospective Qt/Mac build fix

My cpp is paranoid and doesn't like #if Q_WS_MAC:
error: #if with no expression

  • page/qt/EventHandlerQt.cpp:
4:03 AM Changeset in webkit [59924] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-21 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Eric Seidel.

[EFL] Update Localized Strings. Remove markers from strings
since we are not using them and they are only polluting output.
https://bugs.webkit.org/show_bug.cgi?id=39371

No new tests required.

  • platform/efl/LocalizedStringsEfl.cpp: (WebCore::contextMenuItemTagOpenLinkInNewWindow): (WebCore::contextMenuItemTagDownloadLinkToDisk): (WebCore::contextMenuItemTagCopyLinkToClipboard): (WebCore::contextMenuItemTagOpenImageInNewWindow): (WebCore::contextMenuItemTagDownloadImageToDisk): (WebCore::contextMenuItemTagCopyImageToClipboard): (WebCore::contextMenuItemTagOpenFrameInNewWindow): (WebCore::contextMenuItemTagSelectAll): (WebCore::contextMenuItemTagUnicode): (WebCore::contextMenuItemTagInputMethods): (WebCore::contextMenuItemTagGoBack): (WebCore::contextMenuItemTagGoForward): (WebCore::contextMenuItemTagReload): (WebCore::contextMenuItemTagIgnoreSpelling): (WebCore::contextMenuItemTagLearnSpelling): (WebCore::contextMenuItemTagSearchWeb): (WebCore::contextMenuItemTagLookUpInDictionary): (WebCore::contextMenuItemTagOpenLink): (WebCore::contextMenuItemTagIgnoreGrammar): (WebCore::contextMenuItemTagSpellingMenu): (WebCore::contextMenuItemTagCheckSpelling): (WebCore::contextMenuItemTagCheckGrammarWithSpelling): (WebCore::contextMenuItemTagFontMenu): (WebCore::contextMenuItemTagOutline): (WebCore::contextMenuItemTagInspectElement): (WebCore::searchMenuClearRecentSearchesText): (WebCore::missingPluginText): Add missing message. (WebCore::multipleFileUploadText): (WebCore::crashedPluginText):
3:34 AM Changeset in webkit [59923] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-21 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Eric Seidel.

[EF] Fix support for focus ring.
https://bugs.webkit.org/show_bug.cgi?id=39387

No new tests required.

  • html/HTMLAnchorElement.cpp: Add EFL to #ifdef (WebCore::HTMLAnchorElement::isMouseFocusable):
2:56 AM Changeset in webkit [59922] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-21 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Add missing localized string symbols.
https://bugs.webkit.org/show_bug.cgi?id=39394

Add missingPluginText and crashedPluginText.

  • platform/brew/LocalizedStringsBrew.cpp: (WebCore::missingPluginText): (WebCore::crashedPluginText):
2:40 AM Changeset in webkit [59921] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-05-21 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

Add COMPILER(MSVC) guard for strnstr
https://bugs.webkit.org/show_bug.cgi?id=39397

BREWMP uses MSVC for simulator build, but it is not OS(WINDOWS).
Add COMPILER(MSVC) guard for strnstr.

  • wtf/StringExtras.h:
2:24 AM Changeset in webkit [59920] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-05-21 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Add !PLATFORM(BREWMP) guard for isMainThread
https://bugs.webkit.org/show_bug.cgi?id=39396

BREWMP sets ENABLE(SINGLE_THREADED), so it uses isMainThread from ThreadingNone.cpp.
Exclude isMainThread in MainThread.cpp.

  • wtf/MainThread.cpp:
2:23 AM Changeset in webkit [59919] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Symbian build fix.

[Qt] Updated the wins def file with one new export.

The DRT symbols are still missing, but I can't build DRT ;(

  • symbian/bwins/QtWebKitu.def:
1:52 AM Changeset in webkit [59918] by steveblock@google.com
  • 2 edits in trunk/WebCore

Calls to CallJNIMethodIDA() in JavaInstance::invokeMethod() are required on Android

12:57 AM Changeset in webkit [59917] by tony@chromium.org
  • 9 edits
    1 add
    9 deletes in trunk

2010-05-20 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

escape link text when copying or dragging links on win or chromium
https://bugs.webkit.org/show_bug.cgi?id=39413

  • editing/pasteboard/drop-link-expected.txt: Added.
  • editing/pasteboard/drop-link.html:
  • platform/chromium-linux/editing/pasteboard/drop-link-expected.checksum: Removed.
  • platform/chromium-linux/editing/pasteboard/drop-link-expected.png: Removed.
  • platform/chromium-linux/editing/pasteboard/drop-link-expected.txt: Removed.
  • platform/chromium-win/editing/pasteboard/drop-link-expected.checksum: Removed.
  • platform/chromium-win/editing/pasteboard/drop-link-expected.png: Removed.
  • platform/chromium-win/editing/pasteboard/drop-link-expected.txt: Removed.
  • platform/mac/editing/pasteboard/drop-link-expected.checksum: Removed.
  • platform/mac/editing/pasteboard/drop-link-expected.png: Removed.
  • platform/mac/editing/pasteboard/drop-link-expected.txt: Removed.

2010-05-20 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

escape link text when copying or dragging links on win or chromium
https://bugs.webkit.org/show_bug.cgi?id=39413

  • editing/markup.cpp: (WebCore::urlToMarkup):
  • editing/markup.h:
  • platform/chromium/ClipboardUtilitiesChromium.cpp:
  • platform/chromium/ClipboardUtilitiesChromium.h:
  • platform/win/ClipboardUtilitiesWin.cpp:
  • platform/win/ClipboardUtilitiesWin.h:

May 20, 2010:

11:17 PM Changeset in webkit [59916] by dbates@webkit.org
  • 2 edits in trunk/WebKitSite

2010-05-20 Daniel Bates <dbates@rim.com>

Rubber-stamped by Simon Fraser.

Spelling correction; change "acces" [sic] to "access".

  • quality/lifecycle.html:
11:10 PM Changeset in webkit [59915] by Philippe Normand
  • 5 edits
    2 adds in trunk/WebCore

2010-05-18 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Carlson.

[GStreamer] PlatformMedia support
https://bugs.webkit.org/show_bug.cgi?id=39300

Basic support for PlatformMedia in the gst player. The
PlatformMedia object contains a GStreamerGWorld object. That
object is empty for now. XOverlay features will be added later
on for easy review sake.

  • GNUmakefile.am:
  • platform/graphics/MediaPlayer.h: (WebCore::PlatformMedia::):
  • platform/graphics/gstreamer/GStreamerGWorld.cpp: Added. (WebCore::GStreamerGWorld::createGWorld): (WebCore::GStreamerGWorld::GStreamerGWorld): (WebCore::GStreamerGWorld::~GStreamerGWorld):
  • platform/graphics/gstreamer/GStreamerGWorld.h: Added.
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::platformMedia): (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
10:58 PM Changeset in webkit [59914] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2010-05-20 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Add dummy SSLKeyGenerator
https://bugs.webkit.org/show_bug.cgi?id=39403

Add dummy implementation of SSLKeyGenerator.

  • platform/brew/SSLKeyGeneratorBrew.cpp: Added. (WebCore::WebCore::getSupportedKeySizes): (WebCore::WebCore::signedPublicKeyAndChallengeString):
10:23 PM Changeset in webkit [59913] by mrowe@apple.com
  • 4 edits in trunk

<rdar://problem/7848154> Remove the dependency on Foundation's private COCOA_FORMAL_PROTOCOLS_2 define.

Rubber-stamped by Dan Bernstein.

WebCore:

  • platform/mac/EmptyProtocolDefinitions.h:

WebKitTools:

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:
10:15 PM Changeset in webkit [59912] by Simon Fraser
  • 3 edits in trunk/WebKit/win

2010-05-20 Simon Fraser <Simon Fraser>

Build fix, no review.

Fix the non-accelerated-compositing Windows build with some
#if USE(ACCELERATED_COMPOSITING) loving.

  • WebView.cpp:
  • WebView.h:
10:09 PM Changeset in webkit [59911] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2010-05-20 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Add Editor
https://bugs.webkit.org/show_bug.cgi?id=39404

Implement Editor::newGeneralClipboard.

  • editing/brew/EditorBrew.cpp: Added. (WebCore::Editor::newGeneralClipboard):
9:49 PM Changeset in webkit [59910] by Simon Fraser
  • 6 edits in trunk

2010-05-20 Simon Fraser <Simon Fraser>

Reviewed by Adam Roben.

Avoid flushing CA layers when a layout is pending
https://bugs.webkit.org/show_bug.cgi?id=39463
<rdar://problem/7999463>

Avoid rendering the compositing layers to the screen if there's a layout pending,
since the layer tree not in a state that should be presented to the user.

This fixes flashes in some types of content that dynamically add and remove layers.

Do this by adding a WKCACFLayerRendererClient for WKCACFLayerRenderer, which it can
call through to ask whether now is a good time to render. If not, it schedules
another render soon.

  • platform/graphics/win/WKCACFLayerRenderer.h: (WebCore::WKCACFLayerRendererClient::~WKCACFLayerRendererClient):
  • platform/graphics/win/WKCACFLayerRenderer.cpp: (WebCore::WKCACFLayerRenderer::acceleratedCompositingAvailable): (WebCore::WKCACFLayerRenderer::create): (WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): (WebCore::WKCACFLayerRenderer::render):
9:41 PM Changeset in webkit [59909] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-20 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Don't include CoreFoundation.h when building for BREW MP
https://bugs.webkit.org/show_bug.cgi?id=39405

Add !defined(BUILDING_BREWMP) guard for CoreFoundation.h.

  • WebCorePrefix.h:
9:19 PM Changeset in webkit [59908] by eric@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-05-20 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Use skia as BREW MP's graphics backend.
https://bugs.webkit.org/show_bug.cgi?id=39407

Define WTF_PLATFORM_SKIA=1 for BREW MP.

  • wtf/Platform.h:
8:56 PM Changeset in webkit [59907] by eric@webkit.org
  • 1 edit
    2 adds in trunk/WebCore

2010-05-20 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

[BREWMP] Add ScrollTheme
https://bugs.webkit.org/show_bug.cgi?id=39406

As BREW MP always uses frame flattening, there is no need to render scorllbars.
Use the default scrollbar theme with thickness 0.

  • platform/brew/ScrollbarThemeBrew.cpp: Added. (WebCore::ScrollbarTheme::nativeTheme): (WebCore::ScrollbarThemeBrew::~ScrollbarThemeBrew):
  • platform/brew/ScrollbarThemeBrew.h: Added.
8:42 PM Changeset in webkit [59906] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-20 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Daniel Bates.

Look in /proc/registry64 for the Platform SDK on 64-bit Windows.
https://bugs.webkit.org/show_bug.cgi?id=39296

The build-webkit script failed for me on Vista 64. A web search turned
up this blog post with a patch that worked for me:
http://www.nicholaswilson.me.uk/2010/04/hacking-webkit-fail/

  • Scripts/webkitdirs.pm:
8:39 PM Changeset in webkit [59905] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

Fixed naming mixup: it's op_call_put_result, not ret_result.

Reviewed by Beth Dakin.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

8:20 PM Changeset in webkit [59904] by jhoneycutt@apple.com
  • 4 edits
    1 add in trunk/WebCore

REGRESSION(r53637): DivX plug-in fails to start until window is resized
https://bugs.webkit.org/show_bug.cgi?id=39457
<rdar://problem/8006102>

Before r53637, we called Widget::move() (which caused us to call
NPP_SetWindow) before painting a plug-in. r53637 removed the call to
Widget::move(), and we end up never calling NPP_SetWindow for plug-ins
with the "DeferFirstSetWindowCall" quirk, including the DivX plug-in.

Reviewed by Simon Fraser.

  • manual-tests/divx-plugin-fails-to-draw.html: Added.
  • plugins/PluginView.cpp:

(WebCore::PluginView::PluginView):
Initialize new member to false.

  • plugins/PluginView.h:

Added new member.

  • plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::paint):
Call setNPWindowRect() before painting to ensure that NPP_SetWindow gets
called.
(WebCore::PluginView::setNPWindowRect):
Set m_haveCalledSetWindow.

8:06 PM Changeset in webkit [59903] by ukai@chromium.org
  • 7 edits in trunk

2010-05-20 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket handshake incompatible change in draft-hixie-thewebsocketprotocol-76
https://bugs.webkit.org/show_bug.cgi?id=35572

Fix LayoutTests for new WebSocket protocol.
It requires https://bugs.webkit.org/show_bug.cgi?id=38034 to pass websocket tests.

  • websocket/tests/handshake-error-expected.txt: Update expected data.
  • websocket/tests/handshake-error_wsh.py: Without CRLF, the wsh will sends "ThisWillCauseHandshakeErrorHTTP/1.1 101 WebSocket Protocol Handshake\r\n", which is legal for the first line of draft 76 WebSocket opening handshake. (4.1 Opening Handhshake, step 28 to 30). To fail handshake, it needs \r\n.
  • websocket/tests/long-invalid-header-expected.txt: Originally, it expects Upgrade header after status line. In draft 76, order is not important. But "pppp..\r\n" would fail because it misses ":" (end of name) before \r.

2010-05-20 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

WebSocket handshake incompatible change in draft-hixie-thewebsocketprotocol-76
https://bugs.webkit.org/show_bug.cgi?id=35572

WebSocket opening handshake is changed. New protocol draft could be found at http://www.whatwg.org/specs/web-socket-protocol/
It requires https://bugs.webkit.org/show_bug.cgi?id=38034 to pass websocket tests.

  • websockets/WebSocketHandshake.cpp: (WebCore::extractResponseCode): add lineLength parameter to return length of status line. (WebCore::hostName): Added. (WebCore::generateSecWebSocketKey): Added. (WebCore::generateKey3): Added. (WebCore::setChallengeNumber): Added. (WebCore::generateChallengeResponseExpected): Added. (WebCore::WebSocketHandshake::WebSocketHandshake): generate challenge response key and expected data. (WebCore::WebSocketHandshake::clientLocation): use hostName. (WebCore::WebSocketHandshake::clientHandshakeMessage): changed for draft 76 spec. (WebCore::WebSocketHandshake::clientHandshakeRequest): (WebCore::WebSocketHandshake::readServerHandshake): changed for draft 76 spec. m_mode is managed in this method. (WebCore::WebSocketHandshake::readHTTPHeaders): change error log messages. (WebCore::WebSocketHandshake::processHeaders): chagned for draft 76 spec. (WebCore::WebSocketHandshake::checkResponseHeaders): return boolean whether response header is ok or not and not change m_mode in it.
  • websockets/WebSocketHandshake.h:
8:04 PM Changeset in webkit [59902] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-20 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

ThreadedMessageQueue should use with_statement for exception safety
https://bugs.webkit.org/show_bug.cgi?id=39233

  • Scripts/webkitpy/common/thread/threadedmessagequeue.py:
7:52 PM Changeset in webkit [59901] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-05-20 Viet-Trung Luu <viettrungluu@chromium.org>

Reviewed by Darin Fisher.

[Chromium] Don't rely on focused node to route mouse events to plugins.
https://bugs.webkit.org/show_bug.cgi?id=39375
http://crbug.com/43935

On mouse down, do a hit test and check if a plugin was hit. If so, then
save the node for future mouse events (until mouse up or capture lost).

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::WebViewImpl): (WebKit::WebViewImpl::mouseDown): (WebKit::WebViewImpl::handleInputEvent): (WebKit::WebViewImpl::mouseCaptureLost):
  • src/WebViewImpl.h: Remove m_haveMouseCapture; add m_mouseCaptureNode.
7:44 PM Changeset in webkit [59900] by victorw@chromium.org
  • 2 edits
    4 adds in trunk/LayoutTests

2010-05-20 Victor Wang <victorw@chromium.org>

Unreviewed. Update test expectations for chromium.

  • platform/chromium-linux/fast/css/font-face-in-shadow-DOM-expected.checksum: Added.
  • platform/chromium-linux/fast/css/font-face-in-shadow-DOM-expected.png: Added.
  • platform/chromium-win/fast/css/font-face-in-shadow-DOM-expected.checksum: Added.
  • platform/chromium-win/fast/css/font-face-in-shadow-DOM-expected.png: Added.
  • platform/chromium/test_expectations.txt:
7:34 PM Changeset in webkit [59899] by eric@webkit.org
  • 4 edits in trunk/LayoutTests

2010-05-20 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

fast/canvas/webgl/texture-npot.html failed on leopard bot
https://bugs.webkit.org/show_bug.cgi?id=39128

  • fast/canvas/webgl/texture-npot-expected.txt: Adding the failed test cases back.
  • fast/canvas/webgl/texture-npot.html:
  • platform/mac-leopard/Skipped: Skip texture-npot.html on leopard for now.
7:19 PM Changeset in webkit [59898] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-05-20 Dominic Mazzoni <dmazzoni@chromium.org>

Reviewed by Darin Fisher.

Add headingLevel and setFocused methods.

https://bugs.webkit.org/show_bug.cgi?id=39238

  • public/WebAccessibilityObject.h:
  • src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::headingLevel): (WebKit::WebAccessibilityObject::setFocused):
7:14 PM Changeset in webkit [59897] by Adam Roben
  • 2 edits in trunk/WebCore

Stop leaking all CACFContexts

Fixes <http://webkit.org/b/39466> <rdar://problem/8007141>.

Reviewed by Simon Fraser.

  • platform/graphics/win/WKCACFContextFlusher.cpp:

(WebCore::WKCACFContextFlusher::addContext): Only retain the context
when we first add it to the m_contexts set. Otherwise we'll retain the
same context multiple times, causing it to leak.

7:02 PM Changeset in webkit [59896] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-05-20 Diego Gonzalez <diegohcg@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QtTestBrowser does not support websites which requires HTTP Authentication via dialogs
https://bugs.webkit.org/show_bug.cgi?id=38456

  • QtTestBrowser/webpage.cpp: (WebPage::WebPage): (WebPage::authenticationRequired):
  • QtTestBrowser/webpage.h:
7:01 PM Changeset in webkit [59895] by ggaren@apple.com
  • 6 edits in trunk/JavaScriptCore

2010-05-20 Geoffrey Garen <ggaren@apple.com>

Reviewed by Oliver Hunt.

Whittling away at CodeBlock use: Removed a little wonkiness in closure lookup
https://bugs.webkit.org/show_bug.cgi?id=39444


Calculate all lookup depths at compile time. I'm not sure why we couldn't
do this before, but whatever the reason, it seems to be gone now.

  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::findScopedProperty):
  • bytecompiler/BytecodeGenerator.h:
  • interpreter/Interpreter.cpp: (JSC::Interpreter::resolveSkip): (JSC::Interpreter::resolveGlobalDynamic): (JSC::Interpreter::privateExecute):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_get_scoped_var): (JSC::JIT::emit_op_put_scoped_var): (JSC::JIT::emit_op_resolve_skip): (JSC::JIT::emit_op_resolve_global_dynamic): (JSC::JIT::emitSlow_op_resolve_global_dynamic):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_get_scoped_var): (JSC::JIT::emit_op_put_scoped_var): (JSC::JIT::emit_op_resolve_skip):
6:45 PM Changeset in webkit [59894] by eric@webkit.org
  • 2 edits
    1 add in trunk/WebCore

2010-05-20 Young Han Lee <joybro@company100.net>

Reviewed by Darin Adler.

Create filenameFromString for all ports except GTK and EFL.
https://bugs.webkit.org/show_bug.cgi?id=39348

  • platform/FileSystem.cpp: Added. (WebCore::filenameFromString):
  • platform/FileSystem.h:
6:42 PM Changeset in webkit [59893] by mrowe@apple.com
  • 5 edits in branches/safari-533-branch

Versioning.

6:41 PM Changeset in webkit [59892] by mrowe@apple.com
  • 1 copy in tags/Safari-533.10

New tag.

6:40 PM Changeset in webkit [59891] by mthole@apple.com
  • 2 edits in trunk/WebKit/mac

When using a scale factor > 1, scrollbars sometimes appear when not necessary
https://bugs.webkit.org/show_bug.cgi?id=39458

Reviewed by Dave Hyatt.

  • WebView/WebDynamicScrollBarsView.mm:

(-[WebDynamicScrollBarsView updateScrollers]): Round up non-integral sizes from AppKit
so that they can be compared against the integral document size.

6:19 PM Changeset in webkit [59890] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebCore

2010-05-20 Young Han Lee <joybro@company100.net>

Reviewed by Darin Adler.

Port SharedBuffer to POSIX.
https://bugs.webkit.org/show_bug.cgi?id=39283

  • platform/posix/SharedBufferPOSIX.cpp: Added. (WebCore::SharedBuffer::createWithContentsOfFile):
6:19 PM Changeset in webkit [59889] by mrowe@apple.com
  • 13 edits
    4 adds in branches/safari-533-branch

Merge r59876.

6:06 PM Changeset in webkit [59888] by eric@webkit.org
  • 7 edits in trunk

2010-05-20 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Map RGBA4/RGB5_A1 to RGBA and RGB565 to RGB in RenderbufferStorage
https://bugs.webkit.org/show_bug.cgi?id=39077

  • fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Add the test cases for color renderbuffer creation and attachment to framebuffer.
  • fast/canvas/webgl/framebuffer-object-attachment.html: Ditto.

2010-05-20 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Map RGBA4/RGB5_A1 to RGBA and RGB565 to RGB in RenderbufferStorage
https://bugs.webkit.org/show_bug.cgi?id=39077

  • platform/graphics/mac/GraphicsContext3DMac.cpp: (WebCore::GraphicsContext3D::renderbufferStorage): Mapping the enums.

2010-05-20 Zhenyao Mo <zmo@google.com>

Reviewed by Dimitri Glazkov.

Map RGBA4/RGB5_A1 to RGBA and RGB565 to RGB in RenderbufferStorage
https://bugs.webkit.org/show_bug.cgi?id=39077

  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::renderbufferStorage): Mapping the enums.
6:05 PM Changeset in webkit [59887] by mrowe@apple.com
  • 3 edits in branches/safari-533-branch/WebKit/mac

Merge r59793.

6:05 PM Changeset in webkit [59886] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59853.

6:05 PM Changeset in webkit [59885] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59873.

6:04 PM Changeset in webkit [59884] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59871.

6:04 PM Changeset in webkit [59883] by mrowe@apple.com
  • 5 edits in branches/safari-533-branch/WebCore

Merge r59854.

6:04 PM Changeset in webkit [59882] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59864.

6:04 PM Changeset in webkit [59881] by mrowe@apple.com
  • 4 edits
    2 adds in branches/safari-533-branch

Merge r59795.

6:04 PM Changeset in webkit [59880] by mrowe@apple.com
  • 2 edits
    3 adds in branches/safari-533-branch

Merge r59859.

6:04 PM Changeset in webkit [59879] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59732.

6:04 PM Changeset in webkit [59878] by mrowe@apple.com
  • 4 edits in branches/safari-533-branch/WebCore

Merge r59731.

6:04 PM Changeset in webkit [59877] by mrowe@apple.com
  • 5 edits
    3 adds in branches/safari-533-branch

Merge r59798.

5:37 PM Changeset in webkit [59876] by mitz@apple.com
  • 13 edits
    4 adds in trunk

<rdar://problem/8007953> Textarea using custom font appears blank

Reviewed by Dave Hyatt.

WebCore:

Test: fast/css/font-face-in-shadow-DOM.html

When a remote font is loaded, CSSFontSelector forces a style recalc, which replaces all
RenderSyles that have FontFallbackLists referencing the placeholder font with fresh
RenderStyles. However, it does not descend into shadow DOM trees, so those may end up with
styles that still reference the placeholder font.

The fix is to add RenderObject::requiresForcedStyleRecalcPropagation() and have it return
true from renderers that maintain shadow DOM trees or otherwise keep their own RenderStyles.

  • dom/Element.cpp:

(WebCore::Element::recalcStyle): Check if forced style recalc needs to propagated.

  • rendering/RenderButton.h:

(WebCore::RenderButton::requiresForcedStyleRecalcPropagation):

  • rendering/RenderDataGrid.h:

(WebCore::RenderDataGrid::requiresForcedStyleRecalcPropagation):

  • rendering/RenderFileUploadControl.h:

(WebCore::RenderFileUploadControl::requiresForcedStyleRecalcPropagation):

  • rendering/RenderListItem.h:

(WebCore::RenderListItem::requiresForcedStyleRecalcPropagation):

  • rendering/RenderMedia.h:

(WebCore::RenderMedia::requiresForcedStyleRecalcPropagation):

  • rendering/RenderMenuList.h:

(WebCore::RenderMenuList::RenderMenuList::requiresForcedStyleRecalcPropagation):

  • rendering/RenderObject.h:

(WebCore::RenderObject::requiresForcedStyleRecalcPropagation):

  • rendering/RenderProgress.h:

(WebCore::RenderProgress::requiresForcedStyleRecalcPropagation):

  • rendering/RenderSlider.h:

(WebCore::RenderSlider::requiresForcedStyleRecalcPropagation):

  • rendering/RenderTextControl.h:

(WebCore::RenderTextControl::requiresForcedStyleRecalcPropagation):

LayoutTests:

  • fast/css/font-face-in-shadow-DOM.html: Added.
  • platform/mac/fast/css/font-face-in-shadow-DOM-expected.checksum: Added.
  • platform/mac/fast/css/font-face-in-shadow-DOM-expected.png: Added.
  • platform/mac/fast/css/font-face-in-shadow-DOM-expected.txt: Added.
4:58 PM Changeset in webkit [59875] by mrowe@apple.com
  • 10 edits in branches/safari-533-branch/WebCore

Merge r59776.

4:57 PM Changeset in webkit [59874] by mrowe@apple.com
  • 11 edits
    1 move
    1 delete in branches/safari-533-branch/WebCore

Merge r59677.

4:02 PM Changeset in webkit [59873] by jer.noble@apple.com
  • 2 edits in trunk/WebCore

No review; build fix only.

When WTF_USE_ACCELERATED_COMPOSITING is turned off, MediaPlayerPrivateQuickTimeVisualContext.cpp
must include CoreGraphics/CGContext.h.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
3:51 PM Changeset in webkit [59872] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-05-20 Martin Robinson <mrobinson@igalia.com>

Not reviewed.

Tests that use Geolocation.getCurrentPosition fail
https://bugs.webkit.org/show_bug.cgi?id=39454

  • platform/gtk/Skipped: Skip failing tests until this bug is resolved.
3:41 PM Changeset in webkit [59871] by jer.noble@apple.com
  • 2 edits in trunk/WebCore

2010-05-20 Jer Noble <jer.noble@apple.com>

Reviewed by Sam Weinig.

Video elements show no video on Windows machines that do not support accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=39446
rdar://problem/7999794

Implement the paint() method in MediaPlayerPrivateQuickTimeVisualContext. The visual context should
be set up in load() and torn down in the destructor (as opposed to setUpVideoRendering and
tearDownVideoRendering, which won't get called in a non-accelerated compositing case).


  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::~MediaPlayerPrivateQuickTimeVisualContext): (WebCore::MediaPlayerPrivateQuickTimeVisualContext::load): (WebCore::MediaPlayerPrivateQuickTimeVisualContext::paint): (WebCore::MediaPlayerPrivateQuickTimeVisualContext::visualContextTimerFired): (WebCore::MediaPlayerPrivateQuickTimeVisualContext::retrieveCurrentImage): (WebCore::MediaPlayerPrivateQuickTimeVisualContext::setUpVideoRendering): (WebCore::MediaPlayerPrivateQuickTimeVisualContext::tearDownVideoRendering):
3:32 PM Changeset in webkit [59870] by victorw@chromium.org
  • 5 edits in trunk

2010-05-20 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

Added method to WebSecurityOrigin for invoking
SecurityOrigin::canAccessPasswordManager.
https://bugs.webkit.org/show_bug.cgi?id=38916

  • public/WebSecurityOrigin.h:
  • src/WebSecurityOrigin.cpp: (WebKit::WebSecurityOrigin::canAccessPasswordManager):

2010-05-20 Abhishek Arya <inferno@chromium.org>

Reviewed by Adam Barth.

Added a method to check if the security origin can access
password manager.
https://bugs.webkit.org/show_bug.cgi?id=38916

  • page/SecurityOrigin.h: (WebCore::SecurityOrigin::canAccessPasswordManager):
3:27 PM Changeset in webkit [59869] by victorw@chromium.org
  • 2 edits
    4 adds in trunk/LayoutTests

2010-05-20 Victor Wang <victorw@chromium.org>

Unreviewed. Update test expectations for chromium.

  • platform/chromium-mac/svg/filters/feLighting-crash-expected.checksum: Added.
  • platform/chromium-mac/svg/filters/feLighting-crash-expected.png: Added.
  • platform/chromium-win/svg/filters/feLighting-crash-expected.checksum: Added.
  • platform/chromium-win/svg/filters/feLighting-crash-expected.png: Added.
  • platform/chromium/test_expectations.txt:
3:17 PM Changeset in webkit [59868] by Darin Adler
  • 12 edits in trunk

2010-05-20 Darin Adler <Darin Adler>

Reviewed by Eric Seidel.

Fix warnings seen on the buildbots today
https://bugs.webkit.org/show_bug.cgi?id=39368

  • profiler/ProfileNode.cpp: (JSC::getCount): Removed unneeded initialization of global variable. These are all initialized to zero anyway, so no need to try to initialize it and get a warning.
  • wtf/CurrentTime.cpp: (WTF::currentTime): Removed unused global variable.

2010-05-20 Darin Adler <Darin Adler>

Reviewed by Eric Seidel.

Fix warnings seen on the buildbots today
https://bugs.webkit.org/show_bug.cgi?id=39368

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::pruneUnretainedIcons): Use the type "long long" for things being printed with "%lli". There is no guaranteed that int64_t is the same thing as long long.
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): Added parentheses as suggested by warnings in newer versions of GCC.
  • platform/ContextMenu.cpp: Fix #if around the functions to match the #if around the call sites to avoid unused function warning.
  • platform/graphics/gtk/ImageGtk.cpp: (WebCore::Image::loadPlatformResource): Use NULL to end a variable argument list rather than 0. This is a case where the WebKit "use 0 instead of NULL" guideline is incorrect and won't work properly.
  • platform/win/SystemTimeWin.cpp: (WebCore::userIdleTime): Removed unnecessary initialization of LASTINPUTINFO.
  • platform/win/WebCoreInstanceHandle.h: Added property svn:eol-style. Made functions inline instead of static. It's not correct to have functions with internal linkage in a header file. Marking them inline makes more sense.
  • plugins/win/PluginMessageThrottlerWin.cpp: (WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin): Reordered the initializers to match the order of the data members from the class definition.
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::paintIntoTransformedContext): Initialized all the fields of WINDOWPOS. I know this goes against the traditions of Windows programming, but it's correct and silences the warning. Also removed the unneeded separate code path for non-WinCE platforms that translates only the corner of the window rectangle; the WinCE version is correct for normal Windows as well. Not sure why this wasn't caught when the code was originally checked in.
3:05 PM Changeset in webkit [59867] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-05-20 Martin Robinson <mrobinson@igalia.com>

Not reviewed.

https://bugs.webkit.org/show_bug.cgi?id=39388
Re-enable geolocation tests on GTK+ now that this bug is closed.

  • platform/gtk/Skipped: Re-enable geolocation tests.
2:56 PM Changeset in webkit [59866] by yaar@chromium.org
  • 29 edits
    2 adds in trunk

2010-05-20 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Moving frame.src checks out of the bindings
https://bugs.webkit.org/show_bug.cgi?id=37815

Moved JavaScript frame.src checks out of bindings and into
HTMLFrameElementBase. Added main thread state stack to JavaScriptCore
so ExecState is available inside core DOM. Updated affected bindings
(except for GObject, which will need to be updated to avoid origin
failures inside native code).

  • Android.jscbindings.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSCallbackData.cpp: (WebCore::JSCallbackData::invokeCallback):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent):
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript):
  • bindings/js/JSMainThreadExecState.cpp: Added.
  • bindings/js/JSMainThreadExecState.h: Added. (WebCore::JSMainThreadExecState::currentState): (WebCore::JSMainThreadExecState::call): (WebCore::JSMainThreadExecState::evaluate): (WebCore::JSMainThreadExecState::JSMainThreadExecState): (WebCore::JSMainThreadExecState::~JSMainThreadExecState): (WebCore::JSMainThreadNullState::JSMainThreadNullState):
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::executeFunctionInContext): (WebCore::ScheduledAction::execute):
  • bindings/js/ScheduledAction.h:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld): (WebCore::ScriptController::canAccessFromCurrentOrigin):
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::call):
  • bindings/objc/ObjCEventListener.mm:
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]):
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/test/ObjC/DOMTestCallback.mm: (-[DOMTestCallback callbackWithClass1Param:]): (-[DOMTestCallback callbackWithClass2Param:strArg:]): (-[DOMTestCallback callbackWithNonBoolReturnType:]): (-[DOMTestCallback customCallback:class6Param:]):
  • bindings/scripts/test/ObjC/DOMTestInterface.mm:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj readOnlyIntAttr]): (-[DOMTestObj readOnlyStringAttr]): (-[DOMTestObj readOnlyTestObjAttr]): (-[DOMTestObj intAttr]): (-[DOMTestObj setIntAttr:]): (-[DOMTestObj longLongAttr]): (-[DOMTestObj setLongLongAttr:]): (-[DOMTestObj unsignedLongLongAttr]): (-[DOMTestObj setUnsignedLongLongAttr:]): (-[DOMTestObj stringAttr]): (-[DOMTestObj setStringAttr:]): (-[DOMTestObj testObjAttr]): (-[DOMTestObj setTestObjAttr:]): (-[DOMTestObj attrWithException]): (-[DOMTestObj setAttrWithException:]): (-[DOMTestObj attrWithSetterException]): (-[DOMTestObj setAttrWithSetterException:]): (-[DOMTestObj attrWithGetterException]): (-[DOMTestObj setAttrWithGetterException:]): (-[DOMTestObj customAttr]): (-[DOMTestObj setCustomAttr:]): (-[DOMTestObj scriptStringAttr]): (-[DOMTestObj voidMethod]): (-[DOMTestObj voidMethodWithArgs:strArg:objArg:]): (-[DOMTestObj intMethod]): (-[DOMTestObj intMethodWithArgs:strArg:objArg:]): (-[DOMTestObj objMethod]): (-[DOMTestObj objMethodWithArgs:strArg:objArg:]): (-[DOMTestObj methodThatRequiresAllArgs:objArg:]): (-[DOMTestObj methodThatRequiresAllArgsAndThrows:objArg:]): (-[DOMTestObj serializedValue:]): (-[DOMTestObj methodWithException]): (-[DOMTestObj customMethod]): (-[DOMTestObj customMethodWithArgs:strArg:objArg:]): (-[DOMTestObj customArgsAndException:]): (-[DOMTestObj addEventListener:listener:useCapture:]): (-[DOMTestObj removeEventListener:listener:useCapture:]): (-[DOMTestObj withDynamicFrame]): (-[DOMTestObj withDynamicFrameAndArg:]): (-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]): (-[DOMTestObj withDynamicFrameAndUserGesture:]): (-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]): (-[DOMTestObj withScriptStateVoid]): (-[DOMTestObj withScriptStateObj]): (-[DOMTestObj withScriptStateVoidException]): (-[DOMTestObj withScriptStateObjException]): (-[DOMTestObj methodWithOptionalArg:]): (-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]): (-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::canAccessFromCurrentOrigin):
  • bindings/v8/ScriptController.h:
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::isURLAllowed):

2010-05-20 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Moving frame.src checks out of the bindings
https://bugs.webkit.org/show_bug.cgi?id=37815

  • http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
  • http/tests/security/xss-DENIED-iframe-src-alias.html:
2:55 PM Changeset in webkit [59865] by kdecker@apple.com
  • 3 edits in trunk/WebKit/mac

Reviewed by Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=39441
<rdar://problem/7985715> Flash context menu is both horizontally and vertically offset from point of click
<rdar://problem/7986109> Youtube video controller UI entirely missing
<rdar://problem/7986154> Flash content paints at horizontally and vertically shifted locations (within the plug-in region)

  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView updateAndSetWindow]): The base coordinates of a window and it's contentView happen to be the equal at a userSpaceScaleFactor of 1. For non-1.0 scale factors this assumption is false. Accordingly we now convert to the window contentView coordinate system when computing bounds in "window" and the visible rect.
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]): Ditto.
2:30 PM Changeset in webkit [59864] by Adam Roben
  • 2 edits in trunk/WebCore

Fix an HRGN leak in WKCACFLayerRenderer

Fixes <http://webkit.org/b/39312> <rdar://problem/7998728> REGRESSION
(r53686-r55990): Graphics corruption when watching video (affects
youtube.com)

Reviewed by Darin Adler.

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::getDirtyRects): Use an OwnPtr to hold the HRGN we allocate.
That way we don't have to remember to destroy it (as we were
forgetting to do) when we bail out of this function early.

2:20 PM Changeset in webkit [59863] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2010-05-20 Geoffrey Garen <ggaren@apple.com>

Reviewed by Darin Adler.

Removed some reliance on callFame[CodeBlock] by storing CodeBlock in a
local variable in the Interpreter.
https://bugs.webkit.org/show_bug.cgi?id=39447

Small speedup on SunSpider in Interpreter mode.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • jsc.cpp:
  • wtf/Platform.h:
1:49 PM Changeset in webkit [59862] by darin@chromium.org
  • 11 edits in trunk

2010-05-20 Darin Fisher <darin@chromium.org>

Reviewed by Nate Chapin.

[chromium] Provide a way to catch exceptions thrown while interacting
with a NPObject via WebBindings methods.
https://bugs.webkit.org/show_bug.cgi?id=39378

This change also includes a small bit of cleanup in V8NPObject and
friends. I moved code into the WebCore namespace where appropriate.


In _NPN_Invoke, I also moved the call to _NPN_Evaluate outside of the
context scope. I did this to avoid having nested ExceptionCatcher
objects, which is not strictly necessary, but it seemed cleaner.
_NPN_Evaluate already takes care of creating a context scope.

  • bindings/v8/NPV8Object.cpp: (WebCore::v8ObjectToNPObject): (WebCore::npCreateV8ScriptObject): (_NPN_Invoke): (_NPN_InvokeDefault): (_NPN_Evaluate): (_NPN_EvaluateHelper): (_NPN_GetProperty): (_NPN_SetProperty): (_NPN_RemoveProperty): (_NPN_HasProperty): (_NPN_HasMethod): (_NPN_SetException): (_NPN_Enumerate): (_NPN_Construct):
  • bindings/v8/NPV8Object.h:
  • bindings/v8/V8NPObject.cpp:
  • bindings/v8/V8NPObject.h:
  • bindings/v8/V8NPUtils.cpp: (WebCore::convertV8ObjectToNPVariant): (WebCore::pushExceptionHandler): (WebCore::popExceptionHandler): (WebCore::ExceptionCatcher::ExceptionCatcher): (WebCore::ExceptionCatcher::~ExceptionCatcher):
  • bindings/v8/V8NPUtils.h:
  • bindings/v8/npruntime.cpp:
1:20 PM Changeset in webkit [59861] by Martin Robinson
  • 3 edits in trunk/WebKitTools

2010-05-20 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

editingBehavior settings needs to be set back to a reasonable default between tests
https://bugs.webkit.org/show_bug.cgi?id=39433

For now, hard code the default setting during reset, so that the serialized
version of the setting stays in sync with expectations.

  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): Reset editing behavior to the appropriate platform default.
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): Ditto.
1:12 PM Changeset in webkit [59860] by barraclough@apple.com
  • 12 edits in trunk/JavaScriptCore

Bug 39408 - Unify JIT/interpreter return behaviour.

Reviewed by Oliver Hunt.

Presently the JIT and the interpreter have differing implementations in how
they handle storing the result of a function call back to the register file.
In both cases the op_call ( / _eval / _varargs / op_construct) opcode has an
operand indicating the VM register in which the result should be stored.
The JIT plants code after the call to store the result, so the value will be
stored as soon as the callee has returned. In the interpreter the call
passes the return value register id into the callee via the callee callframe,
and the callee is responsible for writing the result back into its callers
register file after it has restored the parents callframe pointer, but before
returning.

Instead, move the task of writing the call result to the register file into a
new opcode (op_call_put_result), and after returning the callee should leave
the return value in a canonical location. In the case of the interpreter,
this canonical location is a local variable in privateExecute
(functionReturnValue), in the case of the JIT this is the normal return value
registers (regT0, or regT1:regT0 in JSVALUE32_64). op_call_put_result stores
the result from the canonical location to the registerfile.

In addition to unifying JIT & interpreter behaviour this change allows us to
remove a slot from the callframe, omit the write of the result where the
return value from the call is not used, and provides a 2% speedup on sunspider
in the interpreter.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallVarargs):
(JSC::BytecodeGenerator::emitConstruct):

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::finalDestinationOrIgnored):

  • bytecompiler/NodesCodegen.cpp:

(JSC::NewExprNode::emitBytecode):
(JSC::FunctionCallValueNode::emitBytecode):
(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::FunctionCallBracketNode::emitBytecode):
(JSC::FunctionCallDotNode::emitBytecode):
(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::ApplyFunctionCallDotNode::emitBytecode):

  • interpreter/CallFrame.h:

(JSC::ExecState::init):
(JSC::ExecState::noCaller):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::throwException):
(JSC::Interpreter::privateExecute):

  • interpreter/RegisterFile.h:

(JSC::RegisterFile::):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

  • jit/JIT.h:
  • jit/JITCall.cpp:

(JSC::JIT::compileOpCallSetupArgs):
(JSC::JIT::compileOpConstructSetupArgs):
(JSC::JIT::emit_op_call_put_result):
(JSC::JIT::compileOpCallVarargs):
(JSC::JIT::compileOpCallVarargsSlowCase):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::compileOpCallVarargsSetupArgs):

1:10 PM Changeset in webkit [59859] by steveblock@google.com
  • 2 edits
    3 adds in trunk

2010-05-20 Marcus Bulach <bulach@chromium.org>

Reviewed by Steve Block.

Ensure timers are stopped on Geolocation::disconnectFrame()
https://bugs.webkit.org/show_bug.cgi?id=39388

fast/dom/Geolocation/notimer-after-unload.html, plus it should be possible to re-enable Gtk LayoutTests.

  • page/Geolocation.cpp: (WebCore::Geolocation::disconnectFrame):
12:44 PM Changeset in webkit [59858] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitTools

Build fix. No review.

The WebKitAPITest targets do not use the "_debug" suffix needed
by the WinCairo port. Added Debug_Cairo target to correct this.

  • WebKitAPITest/WebKitAPITest.vcproj:
12:32 PM Changeset in webkit [59857] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-05-20 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

editingBehavior settings needs to be set back to a reasonable default between tests
https://bugs.webkit.org/show_bug.cgi?id=39433

I forgot to revert the expected results for this test after reverting it.

  • editing/selection/extend-selection-after-double-click-expected.txt:
12:18 PM Changeset in webkit [59856] by jamesr@google.com
  • 3 edits
    2 adds in trunk

2010-05-20 James Robinson <jamesr@chromium.org>

Reviewed by Eric Seidel.

Ensures styles are up-to-date before determining selection
https://bugs.webkit.org/show_bug.cgi?id=39389

This adds a call to document::updateStyleIfNeeded() to
Frame::notifyRendererOfSelectionChange(). Without this call, if there
is a pending style update that will detach part of the DOM and the
the selection is within that part of the DOM when
notifyRendererOfSeletionChange is called, the rootEditableElement
algorithm ends up walking through detached parts of the render tree.

Test: editing/selection/focus-and-display-none.html

  • page/Frame.cpp: (WebCore::Frame::notifyRendererOfSelectionChange):

2010-05-20 James Robinson <jamesr@chromium.org>

Reviewed by Eric Seidel.

Tests putting focus into a textarea and setting display:none
https://bugs.webkit.org/show_bug.cgi?id=39389

  • editing/selection/focus-and-display-none-expected.txt: Added.
  • editing/selection/focus-and-display-none.html: Added.
12:14 PM Changeset in webkit [59855] by bfulgham@webkit.org
  • 2 edits in trunk/WebKit/win

[WinCairo] Correct scaling for print preview
https://bugs.webkit.org/show_bug.cgi?id=39329

Reviewed by Adam Roben.

Cairo does not properly deal with Windows HDCs that have been
scaled using MM_ANISOTROPIC mapping mode, and a WindowExt and
ViewportExt setting.
(see http://bugs.freedesktop.org/show_bug.cgi?id=28161)

Instead, reset the HDC's WorldTransform to be unscaled, then
scale the cairo context to the desired scaling, and perform
the drawing operation.

  • WebFrame.cpp:

(WebFrame::drawHeader): Use pre-positioned context to simplify

this method.

(WebFrame::drawFooter): Use pre-positioned context to simplify

this method.

(WebFrame::spoolPage): Revise scaling logic to turn off HDC

scaling, and scale using only Cairo. Revert scaling at end
so that user-defined GDI-based routines (e.g., header/footer)
will draw in the right position.

(WebFrame::spoolPages): Identify print preview case, and

retrieve scaling factors from preview context. Set the
Cairo context to use these factors during the spoolPage
operation.

11:51 AM Changeset in webkit [59854] by Adam Roben
  • 5 edits in trunk/WebCore

Remove code that fetched, but did nothing useful with, a CFDictionary in MediaPlayerPrivateQuickTimeVisualContext

I also removed the code in QTPixelBuffer that vended the dictionary.

Fixes <http://webkit.org/b/39435> <rdar://problem/8009278>
QTPixelBuffer passes CFDictionaries across the DLL boundary, which can
lead to crashes

Reviewed by Darin Adler.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::retrieveCurrentImage):
Deleted code that fetched the attachments dictionary, which was never
used other than to pass it to CFRetain/CFRelease, which could be
enough to cause a crash due to incompatible copies of
CoreFoundation.dll.

  • platform/graphics/win/QTMovieVisualContext.h: Added a now-needed

forward declaration.

  • platform/graphics/win/QTPixelBuffer.cpp:
  • platform/graphics/win/QTPixelBuffer.h:

Removed the now-unused attachments function.

11:51 AM Changeset in webkit [59853] by Adam Roben
  • 2 edits in trunk/WebCore

Fix a CFData leak in MediaPlayerPrivateQuickTimeVisualContext

Fixes <http://webkit.org/b/39432> <rdar://problem/8008992>

Reviewed by Ada Chan

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::QTCFDictionaryCreateWithDataCallback): Use a RetainPtr to
hold the CFData we allocate so it will get released when this function
is exited. Also pass kCFAllocatorNull as the bytes deallocator to
CFDataCreateWithBytesNoCopy so that CF doesn't try to deallocate the
bytes we pass to it.

11:36 AM Changeset in webkit [59852] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-05-20 Martin Robinson <mrobinson@igalia.com>

Reviewed by Ojan Vafai.

editingBehavior settings needs to be set back to a reasonable default between tests
https://bugs.webkit.org/show_bug.cgi?id=39433

Revert the changes from r59840 to this test until there is a method
in the WebKit APIs to consistently reset the editingBehavior setting
to a reasonable default.

11:32 AM Changeset in webkit [59851] by jianli@chromium.org
  • 2 edits in trunk/WebCore

Rename GenericTask* to CrossThreadTask* in CrossThreadTask.h.
https://bugs.webkit.org/show_bug.cgi?id=39437

Reviewed by David Levin.

  • dom/CrossThreadTask.h:

(WebCore::):
(WebCore::CrossThreadTask1::create):
(WebCore::CrossThreadTask1::CrossThreadTask1):
(WebCore::CrossThreadTask2::create):
(WebCore::CrossThreadTask2::CrossThreadTask2):
(WebCore::CrossThreadTask3::create):
(WebCore::CrossThreadTask3::CrossThreadTask3):
(WebCore::CrossThreadTask4::create):
(WebCore::CrossThreadTask4::CrossThreadTask4):
(WebCore::CrossThreadTask5::create):
(WebCore::CrossThreadTask5::CrossThreadTask5):
(WebCore::CrossThreadTask6::create):
(WebCore::CrossThreadTask6::CrossThreadTask6):
(WebCore::CrossThreadTask7::create):
(WebCore::CrossThreadTask7::CrossThreadTask7):
(WebCore::CrossThreadTask8::create):
(WebCore::CrossThreadTask8::CrossThreadTask8):
(WebCore::createCallbackTask):

11:31 AM Changeset in webkit [59850] by victorw@chromium.org
  • 2 edits in trunk/LayoutTests

2010-05-20 Victor Wang <victorw@chromium.org>

Unreviewed. Update test expectations from chromium.

  • platform/chromium/test_expectations.txt:
10:57 AM Changeset in webkit [59849] by jianli@chromium.org
  • 16 edits
    1 move in trunk

Rename GenericWorkerTask.h to CrossThreadTask.h and move it to dom directory.
https://bugs.webkit.org/show_bug.cgi?id=39135

Reviewed by David Levin.

WebCore:

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/CrossThreadTask.h: Renamed from WebCore/workers/GenericWorkerTask.h.
  • html/FileStreamProxy.cpp:
  • loader/WorkerThreadableLoader.cpp:
  • websockets/WorkerThreadableWebSocketChannel.cpp:
  • workers/DefaultSharedWorkerRepository.cpp:
  • workers/WorkerMessagingProxy.cpp:
  • workers/WorkerScriptLoader.cpp:

WebKit/chromium:

  • src/WebSharedWorkerImpl.cpp:
  • src/WebWorkerBase.cpp:
  • src/WebWorkerClientImpl.cpp:
  • src/WebWorkerImpl.cpp:
10:52 AM EFLWebKit edited by leandro@profusion.mobi
(diff)
10:44 AM Changeset in webkit [59848] by adele@apple.com
  • 2 edits in trunk/WebCore

Remove the Safari welcome page site-specific quirk, since its no longer needed.

Reviewed by Mark Rowe.

  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::cssRules):
10:37 AM Changeset in webkit [59847] by steveblock@google.com
  • 34 edits
    11 adds in trunk

2010-05-20 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Provide bindings for DeviceOrientation
https://bugs.webkit.org/show_bug.cgi?id=39210

Adds ENABLE_DEVICE_ORIENTATION to XCode project file, always disabled.

  • Configurations/FeatureDefines.xcconfig:

2010-05-20 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Provide bindings for DeviceOrientation
https://bugs.webkit.org/show_bug.cgi?id=39210

Adds ENABLE_DEVICE_ORIENTATION to VisualStudio project files, always disabled.

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

2010-05-20 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Provide bindings for DeviceOrientation
https://bugs.webkit.org/show_bug.cgi?id=39210

Adds ENABLE_DEVICE_ORIENTATION to XCode project file, always disabled.

  • Configurations/FeatureDefines.xcconfig:

2010-05-20 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Provide bindings for DeviceOrientation
https://bugs.webkit.org/show_bug.cgi?id=39210

Tests: fast/dom/DeviceOrientation/window-property.html

fast/dom/Window/window-properties-on-device-orientation.html

Adds bindings for DeviceOrientation as defined in
http://dev.w3.org/geo/api/spec-source-orientation.html
This is guarded by ENABLE(DEVICE_ORIENTATION) which is currently disabled on
all platforms but Android.

  • Android.derived.jscbindings.mk:
  • Android.derived.v8bindings.mk:
  • Android.mk:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pri:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSEventCustom.cpp: (WebCore::toJS):
  • bindings/v8/custom/V8EventCustom.cpp: (WebCore::toV8):
  • dom/DeviceOrientationEvent.cpp: Added. (WebCore::DeviceOrientationEvent::DeviceOrientationEvent): (WebCore::DeviceOrientationEvent::initDeviceOrientationEvent):
  • dom/DeviceOrientationEvent.h: Added. (WebCore::DeviceOrientationEvent::create): (WebCore::DeviceOrientationEvent::alpha): (WebCore::DeviceOrientationEvent::beta): (WebCore::DeviceOrientationEvent::gamma): (WebCore::DeviceOrientationEvent::isDeviceOrientationEvent):
  • dom/DeviceOrientationEvent.idl: Added.
  • dom/Event.cpp: (WebCore::Event::isDeviceOrientationEvent):
  • dom/Event.h:
  • dom/EventNames.h:
  • page/DOMWindow.h:
  • page/DOMWindow.idl:

2010-05-20 Steve Block <steveblock@google.com>

Reviewed by Jeremy Orlow.

Provide bindings for DeviceOrientation
https://bugs.webkit.org/show_bug.cgi?id=39210

Modifies existing fast/dom/Window tests to skip window.ondeviceorientation until
it is widely supported.
Adds new fast/dom/Window/window-properties-on-device-orientation.html to test
type and presence of window.ondeviceorientation.
Adds new fast/dom/DeviceOrientation directory and initial test.
Adds all DeviceOrientation tests to all skipped lists.

  • fast/dom/DeviceOrientation: Added.
  • fast/dom/DeviceOrientation/script-tests: Added.
  • fast/dom/DeviceOrientation/script-tests/TEMPLATE.html: Added.
  • fast/dom/DeviceOrientation/script-tests/window-property.js: Added. (hasOnDeviceOrientationProperty):
  • fast/dom/DeviceOrientation/window-property-expected.txt: Added.
  • fast/dom/DeviceOrientation/window-property.html: Added.
  • fast/dom/Window/script-tests/window-property-descriptors.js:
  • fast/dom/Window/window-properties-on-device-orientation-expected.txt: Added.
  • fast/dom/Window/window-properties-on-device-orientation.html: Added.
  • fast/dom/Window/window-properties.html:
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
10:26 AM Changeset in webkit [59846] by kenneth@webkit.org
  • 2 edits in trunk/WebCore

Use 0.15 as text drag delay when Q_WS_MAC is defined, which is
consistent with the Mac OS X platform.

Rubberstamped by Antti Koivisto.

  • page/qt/EventHandlerQt.cpp:
10:24 AM Changeset in webkit [59845] by Martin Robinson
  • 2 edits in trunk/WebKit/win

2010-05-20 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Touch WebKit.idl to ensure that interfaces rebuild.

  • Interfaces/WebKit.idl: Touched.
10:15 AM Changeset in webkit [59844] by Martin Robinson
  • 2 edits in trunk/WebKitTools

2010-05-20 Martin Robinson <mrobinson@igalia.com>

Reviewed by Ojan Vafai.

editing/selection/extend-selection-after-double-click.html crashes on the Leopard Intel release bot
https://bugs.webkit.org/show_bug.cgi?id=39431

  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setEditingBehavior): Prevent a double-free by not having this variable be in the auto-release pool.
9:48 AM Changeset in webkit [59843] by Martin Robinson
  • 3 edits in trunk/WebKit/win

2010-05-20 Martin Robinson <mrobinson@igalia.com>

Reviewed by Adam Roben.

Fix the Windows build and move new IDL declarations to the bottom of the file.

  • Interfaces/IWebPreferences.idl: Move new API to the bottom of the IDL file to prevent vtable mismatch.
  • WebPreferences.cpp: (WebPreferences::setEditingBehavior): Change the type of the parameter to setEditingBehavior to the proper type.
9:19 AM Changeset in webkit [59842] by Martin Robinson
  • 2 edits in trunk/WebKit/win

2010-05-20 Martin Robinson <mrobinson@igalia.com>

Unreviewed.

Fix the Windows build.

  • WebView.cpp: (WebView::notifyPreferencesChanged): Change behavior to 'editingBehavior'.
9:11 AM Changeset in webkit [59841] by tkent@chromium.org
  • 1 edit in trunk/WebKit/win/Interfaces/WebKit.idl

Unreviewed. Touch WebKit.idl as usual.

8:48 AM Changeset in webkit [59840] by Martin Robinson
  • 32 edits in trunk

2010-05-20 Martin Robinson <Martin Robinson>

Reviewed by Ojan Vafai.

Expose the editing behavior setting in DRT to test all editing code paths
https://bugs.webkit.org/show_bug.cgi?id=38603

  • editing/selection/extend-selection-after-double-click.html: Use the new DRT support for changing editing behavior.
  • editing/selection/extend-selection-after-double-click-expected.txt: Update expected results to reflect both behaviors.

2010-05-20 Martin Robinson <Martin Robinson>

Reviewed by Ojan Vafai.

Expose the editing behavior setting in DRT to test all editing code paths
https://bugs.webkit.org/show_bug.cgi?id=38603

  • public/WebSettings.h: (WebKit::WebSettings::): Added an enum for EditingBehavior types.
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setEditingBehavior): Added.
  • src/WebSettingsImpl.h:

2010-05-20 Martin Robinson <Martin Robinson>

Reviewed by Ojan Vafai.

Expose the editing behavior setting in DRT to test all editing code paths
https://bugs.webkit.org/show_bug.cgi?id=38603

  • WebView/WebFrame.mm: (core):
  • WebView/WebFrameInternal.h: Added a conversion method from the API enum to the WebCore enum.
  • WebView/WebPreferenceKeysPrivate.h: Added a preference key for the new setting.
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): Initialize the EditingBehavior to Mac style. (-[WebPreferences editingBehavior]): Added. (-[WebPreferences setEditingBehavior:]): Added.
  • WebView/WebPreferencesPrivate.h: Added the new API points to the private API.
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): Set the editing behavior via the WebPreferences setting.

2010-05-20 Martin Robinson <Martin Robinson>

Reviewed by Ojan Vafai.

Expose the editing behavior setting in DRT to test all editing code paths
https://bugs.webkit.org/show_bug.cgi?id=38603

Expose the EditingBehavior setting in the Windows API.

  • Interfaces/IWebPreferences.idl: Add the API point for setting the editing behavior.
  • WebPreferenceKeysPrivate.h: Add a key for the editing behavior setting.
  • WebPreferences.cpp: (WebPreferences::editingBehavior): Added. (WebPreferences::setEditingBehavior): Added.
  • WebPreferences.h: Add method declarations.
  • WebView.cpp: (WebView::notifyPreferencesChanged): Update the WebCore setting based on the WebPreferences setting.

2010-05-20 Martin Robinson <Martin Robinson>

Reviewed by Ojan Vafai.

Expose the editing behavior setting in DRT to test all editing code paths
https://bugs.webkit.org/show_bug.cgi?id=38603

  • DumpRenderTree/LayoutTestController.cpp: (setEditingBehaviorCallback): Added. (LayoutTestController::staticFunctions): Expose the setEditingBehaviorCallback function.
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/chromium/LayoutTestController.cpp: Add callback method for setting editing behavior.
  • DumpRenderTree/chromium/LayoutTestController.h: Declaration for this method.
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setEditingBehavior): Implementation of editing behavior control.
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setEditingBehavior): Ditto
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setEditingBehavior): Added stub implementation of editing behavior control.
  • DumpRenderTree/qt/LayoutTestControllerQt.h: (LayoutTestController::setEditingBehavior): Add slot for controlling editor behavior.
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::setEditingBehavior): Implementation of editing behavior control.
  • DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::setEditingBehavior): Added stub implementation of editing behavior control.
8:46 AM Changeset in webkit [59839] by tkent@chromium.org
  • 2 edits in trunk/WebKitTools

2010-05-20 Kent Tamura <tkent@chromium.org>

Reviewed by Eric Seidel.

[DRT/Chromium] Increase the time out value
https://bugs.webkit.org/show_bug.cgi?id=39203

Change the time out value of Chromium DRT to 30 seconds, which is
the same as other ports.
If a DRT process exits before new-run-webkit-tests detects time
out, new-run-webkit-tests assumes the DRT process crashed.

  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::layoutTestTimeout): Change the time out value from 10 seconds to 30 seconds.
8:22 AM Changeset in webkit [59838] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-05-20 Janne Koskinen <janne.p.koskinen@digia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] WINSCW compile fix for qwebframe test
https://bugs.webkit.org/show_bug.cgi?id=38722

WINSCW cannot determine template type up the hierarchy
to common base class.

  • tests/qwebframe/tst_qwebframe.cpp:
8:13 AM Changeset in webkit [59837] by Simon Hausmann
  • 2 edits in trunk/WebCore

Fix painting when using clipToImageBuffer()

Reviewed by Simon Hausmann.

When we apply the transform of the parent painter to the painter of
the transparency layer, we adopt its coordinate system, thus offset
should not be in page coordinates, but in the coordinate system of
the parent painter.

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::TransparencyLayer::TransparencyLayer):

8:01 AM Changeset in webkit [59836] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-05-20 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

Remove unused "old style" private APIs

These symbols were introduced after QtWebKit v4.6
so no-one should be using them

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
7:21 AM Changeset in webkit [59835] by agl@chromium.org
  • 3 edits
    2 adds in trunk

2010-05-20 Adam Langley <agl@chromium.org>

Reviewed by David Levin.

[chromium] Avoid crash when msttcorefonts aren't provided

https://bugs.webkit.org/show_bug.cgi?id=39015
http://code.google.com/p/chromium/issues/detail?id=43831

  • platform/graphics/chromium/FontCacheLinux.cpp: (WebCore::FontCache::createFontPlatformData):
7:15 AM Changeset in webkit [59834] by zherczeg@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Update Qt specific expected file.

  • platform/qt/svg/filters/feLighting-crash-expected.txt:
6:56 AM Changeset in webkit [59833] by eric@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-05-20 Rajiv Ramanasankaran <rajiv.ramanasankaran@nokia.com>

Reviewed by Simon Hausmann.

[Qt] QWebPage::inputMethodQuery() returns wrong values for Qt::ImCursorPosition, Qt::ImAnchorPosition
https://bugs.webkit.org/show_bug.cgi?id=38779

The earlier implementation was written with the assumption that in this scenario the
anchor position always corresponds to the START index and that the current cursor position
always corresponds to the END index in WebKit.

Updated the implementation of QWebPage::inputMethodQuery(Qt::ImCursorPosition) and
QWebPage::inputMethodQuery(Qt::ImAnchorPosition) for the case where the Editor is not in
composition mode. In the non-composition mode, the Anchor and the Current cursor positions
correspond to the Base and Extent position offsets in WebKit.

Also added the auto-tests for the RIGHT to LEFT and LEFT to RIGHT selections.

  • Api/qwebpage.cpp: (QWebPage::inputMethodQuery): Now returning correct values for Qt::ImCursorPosition and Qt::ImAnchorPosition when the Editor is not in composition mode.
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods): Added auto-tests for RIGHT to LEFT and LEFT to RIGHT selections
6:53 AM Changeset in webkit [59832] by zherczeg@webkit.org
  • 3 edits
    5 adds in trunk

WebCore: Fix a crash caused by feLigthing::apply()
https://bugs.webkit.org/show_bug.cgi?id=39004

Reviewed by Dirk Schulze.

Make FELighting::apply() similar to other filters' applies
to avoid an assertion fail in putUnmultipliedImageData(),
when effectDrawingRect has negative location (x or y is less than 0).

Test: svg/filters/feLighting-crash.svg

  • svg/graphics/filters/SVGFELighting.cpp:

(WebCore::FELighting::apply):

LayoutTests: In case of lighting SVG effects, a wider output rectangle
than the input image size should not cause crash.
https://bugs.webkit.org/show_bug.cgi?id=39004

Reviewed by Dirk Schulze.

  • platform/mac/svg/filters/feLighting-crash-expected.checksum: Added.
  • platform/mac/svg/filters/feLighting-crash-expected.png: Added.
  • platform/mac/svg/filters/feLighting-crash-expected.txt: Added.
  • platform/qt/svg/filters/feLighting-crash-expected.txt: Added.
  • svg/filters/feLighting-crash.svg: Added.
6:43 AM Changeset in webkit [59831] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-05-20 Luiz Agostini <luiz.agostini@openbossa.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Skipping popup focus test for maemo
https://bugs.webkit.org/show_bug.cgi?id=39314

Skipping popup focus test for maemo in qwebframe auto test.

The test method tst_QWebFrame::popupFocus() was testing popup focus AND input
field focus. The input field focus has been removed from the method popupFocus()
and a new test method named inputFieldFocus() has been added. Finally the test
method popupFocus() has been skipped for maemo.

  • tests/qwebframe/tst_qwebframe.cpp:
6:02 AM Changeset in webkit [59830] by cevans@google.com
  • 2 edits in trunk/WebKitTools

Unreviewed.

Marking myself as a committer.

4:48 AM Changeset in webkit [59829] by Chris Jerdonek
  • 6 edits in trunk

2010-05-20 Chris Jerdonek <Chris Jerdonek>

Reviewed by Eric Seidel.

Modified FrameLoader::urlSelected() to accept a KURL instead of a
ResourceRequest.

https://bugs.webkit.org/show_bug.cgi?id=39320

Since ResourceRequest has non-explicit single-parameter constructors for
String and KURL, urlSelected() previously accepted any of String, KURL,
and ResourceRequest. This revision changes urlSelected() to accept only
a KURL to make the API tighter and easier to refactor.

No new functionality, so no new tests.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::urlSelected):
    • Changed the public overload to accept a KURL instead of a ResourceRequest.
  • loader/FrameLoader.h:
    • Changed the public overload to accept a KURL instead of a ResourceRequest.
  • wml/WMLAElement.cpp: (WebCore::WMLAElement::defaultEventHandler):
    • Updated the call to urlSelected().

2010-05-20 Chris Jerdonek <Chris Jerdonek>

Reviewed by Eric Seidel.

Modified FrameLoader::urlSelected() to accept a KURL instead of a
ResourceRequest.

https://bugs.webkit.org/show_bug.cgi?id=39320

Since ResourceRequest has non-explicit single-parameter constructors for
String and KURL, urlSelected() previously accepted any of String, KURL,
and ResourceRequest. This revision changes urlSelected() to accept only
a KURL to make the API tighter and easier to refactor.

  • WebCoreSupport/WebContextMenuClient.cpp: (WebContextMenuClient::searchWithGoogle):
    • Updated the call to urlSelected().
4:07 AM Changeset in webkit [59828] by morrita@google.com
  • 5 edits
    2 adds in trunk

2010-05-20 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

2x execCommand ReadAV@NULL
https://bugs.webkit.org/show_bug.cgi?id=35791

This test passes if it doesn't crash.

  • editing/execCommand/35791-expected.txt: Added.
  • editing/execCommand/35791.html: Added.

2010-05-20 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

2x execCommand ReadAV@NULL
https://bugs.webkit.org/show_bug.cgi?id=35791

In applyBlockStyle(), a node which is referred from
nextParagraphStart sometimes removed from the document and goes
orphan, and that causes an assertion failed. This is because
moveParagraphs() replaces the node with a new one with some new
styles applied. So we re-compute nextParagraphStart in that case.

Test: editing/execCommand/35791.html

  • dom/Position.h: (WebCore::Position::isOrphan):
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle):
  • editing/VisiblePosition.h: (WebCore::VisiblePosition::isOrphan):
4:04 AM Changeset in webkit [59827] by Simon Hausmann
  • 2 edits in trunk/WebKitTools

[Qt] Weekly binary builds on Mac OS X don't work when launched in the Finder
https://bugs.webkit.org/show_bug.cgi?id=37273

Reviewed by Tor Arne Vestbo.

  • QtTestBrowser/QtTestBrowser.pro: Build QtLauncher as bundle in package builds
2:06 AM Changeset in webkit [59826] by steveblock@google.com
  • 3 edits in trunk/WebCore

2010-05-20 Steve Block <steveblock@google.com>

Reviewed by Eric Seidel.

PluginView contains JSC-specific code
https://bugs.webkit.org/show_bug.cgi?id=38907

Build fix only, no new tests.

  • plugins/PluginView.cpp: (WebCore::PluginView::start): (WebCore::PluginView::stop): (WebCore::PluginView::performRequest):
  • plugins/PluginView.h:
1:44 AM Changeset in webkit [59825] by Philippe Normand
  • 2 edits in trunk/WebCore

2010-05-17 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Seidel.

[GStreamer] enable gst support if USE_GSTREAMER macro is defined
https://bugs.webkit.org/show_bug.cgi?id=39205

Include gstreamer private player in the build when the
USE_GSTREAMER macro is enabled.

  • platform/graphics/MediaPlayer.cpp: (WebCore::installedMediaEngines):
1:28 AM Changeset in webkit [59824] by ukai@chromium.org
  • 2 edits in trunk/WebKitTools

Unreviewed fix for websocket test failures.

  • Scripts/new-run-webkit-websocketserver: options is named parameter for factory.get().
1:23 AM QtWebKitTriageRoster edited by Simon Hausmann
(diff)
12:45 AM Changeset in webkit [59823] by ukai@chromium.org
  • 2 edits in trunk/WebKitTools

2010-05-20 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Shinichiro Hamaji.

Chromium: Add --chromium option to new-run-webkit-websocketserver
https://bugs.webkit.org/show_bug.cgi?id=37664

Missed to pass options to factory.get() in r59595

  • Scripts/new-run-webkit-websocketserver: Pass options to factory.get().

May 19, 2010:

10:59 PM Changeset in webkit [59822] by eric@webkit.org
  • 9 edits in trunk

2010-05-19 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Darin Fisher.

Implementing hardware accelerated compositing of layers for Chromium.
Completely removed the existing software compositing path to replace
it with code implemented using OpenGL.
https://bugs.webkit.org/show_bug.cgi?id=38783

Tests: Covered by existing compositing tests.

  • WebCore.gyp/WebCore.gyp:
  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::~GraphicsLayerChromium): (WebCore::GraphicsLayerChromium::updateLayerDrawsContent): (WebCore::GraphicsLayerChromium::updateContentsRect):
  • platform/graphics/chromium/LayerChromium.cpp: (WebCore::LayerChromium::LayerChromium): (WebCore::LayerChromium::~LayerChromium): (WebCore::LayerChromium::updateGraphicsContext): (WebCore::LayerChromium::drawsContentUpdated): (WebCore::LayerChromium::updateContents): (WebCore::LayerChromium::setContents): (WebCore::LayerChromium::setBackingStoreSize): (WebCore::LayerChromium::setBounds): (WebCore::LayerChromium::setNeedsDisplay):
  • platform/graphics/chromium/LayerChromium.h: (WebCore::LayerChromium::contentsDirty): (WebCore::LayerChromium::drawsContent):
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::): (WebCore::checkGLError): (WebCore::loadShader): (WebCore::loadShaderProgram): (WebCore::toGLMatrix): (WebCore::orthoMatrix): (WebCore::createLayerTexture): (WebCore::LayerRendererChromium::create): (WebCore::LayerRendererChromium::LayerRendererChromium): (WebCore::LayerRendererChromium::~LayerRendererChromium): (WebCore::LayerRendererChromium::drawTexturedQuad): (WebCore::LayerRendererChromium::drawLayers): (WebCore::LayerRendererChromium::getTextureId): (WebCore::LayerRendererChromium::assignTextureForLayer): (WebCore::LayerRendererChromium::freeLayerTexture): (WebCore::LayerRendererChromium::drawDebugBorder): (WebCore::LayerRendererChromium::isLayerVisible): (WebCore::LayerRendererChromium::compositeLayersRecursive): (WebCore::LayerRendererChromium::makeContextCurrent): (WebCore::LayerRendererChromium::initGL): (WebCore::LayerRendererChromium::bindCommonAttribLocation): (WebCore::LayerRendererChromium::initializeSharedGLObjects):
  • platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::):

2010-05-19 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Darin Fisher.

Modifying WebViewImpl to support new hardware compositing for
LayerChromium layers.
https://bugs.webkit.org/show_bug.cgi?id=38783

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::paint): (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): (WebKit::WebViewImpl::updateRootLayerContents): (WebKit::WebViewImpl::setRootLayerNeedsDisplay):
10:38 PM Changeset in webkit [59821] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-19 Eric Seidel <eric@webkit.org>

Reviewed by Adam Roben.

WinEWS should build Debug instead of Release
https://bugs.webkit.org/show_bug.cgi?id=39242

This is a workaround for
https://bugs.webkit.org/show_bug.cgi?id=39197
Adam Roben and Brian Weinstein believe this may
also make building faster since Debug builds
take less time to link.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
10:36 PM Changeset in webkit [59820] by barraclough@apple.com
  • 9 edits in trunk/JavaScriptCore

Errk! rename op_constructor_ret as requested in review of Bug 39399.

Reviewed by Geoff Garen.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitReturn):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

  • jit/JIT.h:
  • jit/JITCall.cpp:

(JSC::JIT::emit_op_ret_object_or_this):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_ret_object_or_this):

10:35 PM Changeset in webkit [59819] by tony@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-05-19 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] disable spelling suggestions if spellcheck=false
https://bugs.webkit.org/show_bug.cgi?id=39402

This is the Chromium fix for bug 25639 that was fixed in the
other ports in r59585.

  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
10:02 PM Changeset in webkit [59818] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

2010-05-19 Mario Sanchez Prada <msanchez@igalia.com>

Reviewed by Darin Adler.

Misleading variable name in a11y test
https://bugs.webkit.org/show_bug.cgi?id=38465

Use a more appropriate variable name for the return
value of accessibilityController.rootElement

  • accessibility/aria-controls-with-tabs.html:
9:57 PM Changeset in webkit [59817] by barraclough@apple.com
  • 11 edits in trunk/JavaScriptCore

Bug 39399 - Move responsibility for verifying constructors return objects from the caller to the callee.

Reviewed by Geoff Garen.

This is a necessary step to move object creation from caller to callee.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump):

  • bytecode/Opcode.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitReturn):
(JSC::BytecodeGenerator::emitConstruct):

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::isConstructor):

  • bytecompiler/NodesCodegen.cpp:

(JSC::FunctionBodyNode::emitBytecode):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::privateExecute):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:
  • jit/JITCall.cpp:

(JSC::JIT::emit_op_constructor_ret):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_constructor_ret):

9:37 PM Changeset in webkit [59816] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-19 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Timothy Hatcher.

Maintain focus on help screen while it's active.
https://bugs.webkit.org/show_bug.cgi?id=39237

9:18 PM Changeset in webkit [59815] by eric@webkit.org
  • 4 edits in trunk

2010-05-19 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Crash fix in the HistoryController.

The problem was casued by a documented feature of the QWebFrame::setHtml().
The method doesn't affect a browsing history (doesn't create a HistoryItem instance), so
m_currentItem and m_previousItem are not set.

A null check was added.

[Qt] The QWebPage crashes on history.pushState().
https://bugs.webkit.org/show_bug.cgi?id=38840

  • loader/HistoryController.cpp: (WebCore::HistoryController::pushState): (WebCore::HistoryController::replaceState):

2010-05-19 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

Crash fix in the HistoryController.

The problem was casued by a documented feature of the QWebFrame::setHtml().
The method doesn't affect a browsing history (doesn't create a HistoryItem instance), so
m_currentItem and m_previousItem are not set.

A null check was added.

[Qt] The QWebPage crashes on history.pushState().
https://bugs.webkit.org/show_bug.cgi?id=38840

  • tests/qwebhistory/tst_qwebhistory.cpp: (tst_QWebHistory::popPushState_data): (tst_QWebHistory::popPushState):
8:24 PM Changeset in webkit [59814] by darin@chromium.org
  • 11 edits in trunk

2010-05-19 Darin Fisher <darin@chromium.org>

Revert r59790 due to failing Chromium npruntime tests.

  • bindings/v8/NPV8Object.cpp: (v8ObjectToNPObject): (npCreateV8ScriptObject): (_NPN_Invoke): (_NPN_InvokeDefault): (_NPN_Evaluate): (_NPN_EvaluateHelper): (_NPN_GetProperty): (_NPN_SetProperty): (_NPN_RemoveProperty): (_NPN_HasProperty): (_NPN_HasMethod): (_NPN_SetException): (_NPN_Enumerate): (_NPN_Construct):
  • bindings/v8/NPV8Object.h:
  • bindings/v8/V8NPObject.cpp: (forgetV8ObjectForNPObject):
  • bindings/v8/V8NPObject.h:
  • bindings/v8/V8NPUtils.cpp: (convertV8ObjectToNPVariant): (getStringIdentifier):
  • bindings/v8/V8NPUtils.h:
  • bindings/v8/npruntime.cpp:
8:22 PM Changeset in webkit [59813] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix windows build II.

Reviewed by NOBODY (build fix).

8:12 PM Changeset in webkit [59812] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix windows build.

Reviewed by NOBODY (build fix).

7:38 PM Changeset in webkit [59811] by barraclough@apple.com
  • 15 edits in trunk

JavaScriptCore: Bug 39393 - JSFunction need not be a subclass of InternalFunction.

Reviewed by Oliver Hunt.

re-landing r59800.

(JSC::Interpreter::retrieveCaller):
(JSC::Interpreter::findFunctionCallFrame):

  • interpreter/Interpreter.h:
  • profiler/Profiler.cpp:

(JSC::Profiler::createCallIdentifier):

  • runtime/FunctionPrototype.cpp:

(JSC::functionProtoFuncToString):

  • runtime/JSFunction.cpp:

(JSC::):
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::name):
(JSC::JSFunction::displayName):
(JSC::JSFunction::calculatedDisplayName):

  • runtime/JSFunction.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::putDirectFunction):
(JSC::JSObject::putDirectFunctionWithoutTransition):

  • runtime/JSObject.h:
  • runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

WebCore: Rubber Stamped by Sam Weinig.

JSFunctions are no longer a subclass of InternalFunction.

  • bindings/js/ScriptCallStack.cpp:

(WebCore::ScriptCallStack::ScriptCallStack):
(WebCore::ScriptCallStack::initialize):

  • bindings/js/ScriptCallStack.h:
7:35 PM Changeset in webkit [59810] by mrowe@apple.com
  • 9 edits
    2 copies
    3 adds in branches/safari-533-branch

Merge r59719.

7:35 PM Changeset in webkit [59809] by mrowe@apple.com
  • 3 edits in branches/safari-533-branch/WebCore

Merge r59674.

7:35 PM Changeset in webkit [59808] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59684.

7:35 PM Changeset in webkit [59807] by mrowe@apple.com
  • 3 edits
    1 move in branches/safari-533-branch/WebCore

Merge r59683.

7:35 PM Changeset in webkit [59806] by mrowe@apple.com
  • 2 edits
    1 add in branches/safari-533-branch/WebCore

Merge r59682.

7:35 PM Changeset in webkit [59805] by mrowe@apple.com
  • 15 edits
    1 delete in branches/safari-533-branch/WebCore

Merge r59724.

7:35 PM Changeset in webkit [59804] by mrowe@apple.com
  • 3 edits in branches/safari-533-branch/WebCore

Merge r59716.

7:34 PM Changeset in webkit [59803] by mrowe@apple.com
  • 3 edits in branches/safari-533-branch/WebCore

Merge r59680.

7:34 PM Changeset in webkit [59802] by mrowe@apple.com
  • 6 edits in branches/safari-533-branch

Merge r59678.

6:15 PM Changeset in webkit [59801] by barraclough@apple.com
  • 11 edits in trunk/JavaScriptCore

Reverting r59800, this b0rked stuff.

Reviewed by NOBODY (build fix).

(JSC::Interpreter::retrieveCaller):
(JSC::Interpreter::findFunctionCallFrame):

  • interpreter/Interpreter.h:
  • profiler/Profiler.cpp:

(JSC::Profiler::createCallIdentifier):

  • runtime/FunctionPrototype.cpp:

(JSC::functionProtoFuncToString):

  • runtime/JSFunction.cpp:

(JSC::):
(JSC::JSFunction::JSFunction):

  • runtime/JSFunction.h:
  • runtime/JSObject.cpp:
  • runtime/JSObject.h:
  • runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

6:01 PM Changeset in webkit [59800] by barraclough@apple.com
  • 11 edits in trunk/JavaScriptCore

Bug 39393 - JSFunction need not be a subclass of InternalFunction.

Reviewed by Oliver Hunt.

This may prevent us from introducing a more useful parent class to
JSFunction, e.g. a JSObject that holds an executable, which could
also reference an eval or program executable.

(JSC::Interpreter::retrieveCaller):
(JSC::Interpreter::findFunctionCallFrame):

  • interpreter/Interpreter.h:
  • profiler/Profiler.cpp:

(JSC::Profiler::createCallIdentifier):

  • runtime/FunctionPrototype.cpp:

(JSC::functionProtoFuncToString):

  • runtime/JSFunction.cpp:

(JSC::):
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::name):
(JSC::JSFunction::displayName):
(JSC::JSFunction::calculatedDisplayName):

  • runtime/JSFunction.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::putDirectFunction):
(JSC::JSObject::putDirectFunctionWithoutTransition):

  • runtime/JSObject.h:
  • runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

5:54 PM Changeset in webkit [59799] by victorw@chromium.org
  • 4 edits
    6 adds
    1 delete in trunk/LayoutTests

2010-05-19 Victor Wang <victorw@chromium.org>

Unreviewed. Update Chromium test expectations.

  • platform/chromium-linux/fast/multicol/layers-split-across-columns-expected.checksum: Added.
  • platform/chromium-linux/fast/multicol/layers-split-across-columns-expected.png: Added.
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum:
  • platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png: Removed.
  • platform/chromium-mac/fast/multicol/layers-split-across-columns-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/layers-in-multicol-expected.txt:
  • platform/chromium-win/fast/multicol/layers-split-across-columns-expected.checksum: Added.
  • platform/chromium-win/fast/multicol/layers-split-across-columns-expected.png: Added.
  • platform/chromium-win/fast/multicol/layers-split-across-columns-expected.txt: Added.
  • platform/chromium-win/fast/multicol/nested-columns-expected.txt:
5:30 PM Changeset in webkit [59798] by oliver@apple.com
  • 5 edits
    3 adds in trunk

2010-05-19 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

emitJumpIfNotJSCell should special case constant immediate values
https://bugs.webkit.org/show_bug.cgi?id=39392
<rdar://problem/8001324>

Make emitJumpSlowCaseIfNotJSCell special case constant immediate
values, in addition to the immediate JSCell optimisation.

Also add assertions to make sure no one else produces code that
attempts to load constants from the register file.

  • jit/JITInlineMethods.h: (JSC::JIT::emitJumpSlowCaseIfNotJSCell):
  • jit/JSInterfaceJIT.h: (JSC::JSInterfaceJIT::emitJumpIfNotJSCell): (JSC::JSInterfaceJIT::emitLoadInt32): (JSC::JSInterfaceJIT::tagFor): (JSC::JSInterfaceJIT::payloadFor): (JSC::JSInterfaceJIT::emitLoadDouble): (JSC::JSInterfaceJIT::addressFor):
  • jit/ThunkGenerators.cpp:

2010-05-19 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

emitJumpIfNotJSCell should special case constant immediate values
https://bugs.webkit.org/show_bug.cgi?id=39392

Add tests for immediate constants being used where cells are expected.

  • fast/js/immediate-constant-instead-of-cell-expected.txt: Added.
  • fast/js/immediate-constant-instead-of-cell.html: Added.
  • fast/js/script-tests/immediate-constant-instead-of-cell.js: Added. ():
5:23 PM Changeset in webkit [59797] by jianli@chromium.org
  • 6 edits
    1 add in trunk

Refactor text encoding detection logic in FileReader.
https://bugs.webkit.org/show_bug.cgi?id=39131

Reviewed by Alexey Proskuryakov.

WebCore:

Changed FileReader::convertToText to call TextResourceDecoder::decode to
detect the encoding from BOM and decode the text. Though the File API
spec says that the supplied encoding should be used if it is valid, we
choose to ignore this requirement in order to be consistent with how
WebKit decodes the web content: always has the BOM override the provided
encoding.

  • html/FileReader.cpp:

(WebCore::FileReader::convertToText):

  • html/FileReader.h:

LayoutTests:

Add more test coverage for FileReader.

  • fast/files/file-reader-expected.txt:
  • fast/files/file-reader.html:
  • fast/files/resources/binary-file: Added.
5:19 PM Changeset in webkit [59796] by Martin Robinson
  • 2 edits in trunk/LayoutTests

Not reviewed.

https://bugs.webkit.org/show_bug.cgi?id=39388

Disabling geolocation tests until blockers are fixed.

  • platform/gtk/Skipped: Skipping geolocation tests for now.
4:59 PM Changeset in webkit [59795] by yaar@chromium.org
  • 4 edits
    2 adds in trunk

2010-05-19 Abhishek Arya <inferno@chromium.org>

Reviewed by David Hyatt.

Check that the node is a text node before doing a static cast
to a Text class pointer.
https://bugs.webkit.org/show_bug.cgi?id=38626

Test: fast/text/text-transform-nontext-node-crash.xhtml

  • rendering/RenderText.cpp: (WebCore::RenderText::originalText):
  • rendering/RenderTextFragment.cpp: (WebCore::RenderTextFragment::originalText): (WebCore::RenderTextFragment::previousCharacter):

2010-05-19 Abhishek Arya <inferno@chromium.org>

Reviewed by David Hyatt.

Tests that text transformation applied to a non-text node
does not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=38626

  • fast/text/text-transform-nontext-node-crash-expected.txt: Added.
  • fast/text/text-transform-nontext-node-crash.xhtml: Added.
4:52 PM Changeset in webkit [59794] by yaar@chromium.org
  • 4 edits in trunk/WebCore

2010-05-19 Yaar Schnitman <yaar@chromium.org>

Reviewed by Eric Seidel.

Fixed warnings by JSC overloads changes. Also updated the binding reference files for JSC.
https://bugs.webkit.org/show_bug.cgi?id=39390

  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/test/JS/JSTestInterface.cpp: (WebCore::):
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::):
4:39 PM Changeset in webkit [59793] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

<rdar://problem/8004528>
REGRESSION: Coordinate system for Core Animation NPAPI plug-ins is flipped with accelerated compositing turned on

Reviewed by Kevin Decker and Simon Fraser.

When needed, create a new CALayer and set it's geometry to be flipped. Add the plug-in layer as a sublayer and then return
the newly created layer.

  • Plugins/Hosted/WebHostedNetscapePluginView.mm:

(-[WebHostedNetscapePluginView createPlugin]):

  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView createPlugin]):

4:28 PM Changeset in webkit [59792] by Martin Robinson
  • 3 edits
    1 add in trunk/LayoutTests

2010-05-19 Martin Robinson <mrobinson@igalia.com>

Not reviewed.

Updated multi-column test baselines.

  • platform/gtk/fast/multicol/layers-in-multicol-expected.txt: Updated.
  • platform/gtk/fast/multicol/layers-split-across-columns-expected.txt: Added.
  • platform/gtk/fast/multicol/nested-columns-expected.txt: Updated.
4:24 PM Changeset in webkit [59791] by ggaren@apple.com
  • 4 edits in trunk/JavaScriptCore

2010-05-19 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Slight refactoring to CodeBlock bytecode access
https://bugs.webkit.org/show_bug.cgi?id=39384

  • bytecode/CodeBlock.h: (JSC::CodeBlock::bytecodeOffset):
  • interpreter/CallFrame.h: (JSC::ExecState::returnPC):
  • interpreter/Interpreter.cpp: (JSC::Interpreter::unwindCallFrame): (JSC::Interpreter::retrieveLastCaller): Moved bytecode access into a CodeBlock helper function. Changed CallFrame to accurately represent how the returnPC is stored in JIT vs Interpreter.
3:59 PM Changeset in webkit [59790] by darin@chromium.org
  • 11 edits in trunk

2010-05-19 Darin Fisher <darin@chromium.org>

Reviewed by Nate Chapin.

[chromium] Provide a way to catch exceptions thrown while interacting
with a NPObject via WebBindings methods.
https://bugs.webkit.org/show_bug.cgi?id=39378

This change also includes a small bit of cleanup in V8NPObject and
friends. I moved code into the WebCore namespace where appropriate.


In _NPN_Invoke, I also moved the call to _NPN_Evaluate outside of the
context scope. I did this to avoid having nested ExceptionCatcher
objects, which is not strictly necessary, but it seemed cleaner.
_NPN_Evaluate already takes care of creating a context scope.

  • bindings/v8/NPV8Object.cpp: (WebCore::v8ObjectToNPObject): (WebCore::npCreateV8ScriptObject): (_NPN_Invoke): (_NPN_InvokeDefault): (_NPN_Evaluate): (_NPN_EvaluateHelper): (_NPN_GetProperty): (_NPN_SetProperty): (_NPN_RemoveProperty): (_NPN_HasProperty): (_NPN_HasMethod): (_NPN_SetException): (_NPN_Enumerate): (_NPN_Construct):
  • bindings/v8/NPV8Object.h:
  • bindings/v8/V8NPObject.cpp:
  • bindings/v8/V8NPObject.h:
  • bindings/v8/V8NPUtils.cpp: (WebCore::convertV8ObjectToNPVariant): (WebCore::pushExceptionHandler): (WebCore::popExceptionHandler): (WebCore::ExceptionCatcher::~ExceptionCatcher):
  • bindings/v8/V8NPUtils.h:
  • bindings/v8/npruntime.cpp:
3:43 PM Changeset in webkit [59789] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-05-19 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

  • DumpRenderTree/chromium/NotificationPresenter.cpp: (NotificationPresenter::show):
3:43 PM Changeset in webkit [59788] by yaar@chromium.org
  • 29 edits
    2 deletes in trunk

2010-05-19 Yaar Schnitman <yaar@chromium.org>

Unreviewed, rolling out r59769.
http://trac.webkit.org/changeset/59769
https://bugs.webkit.org/show_bug.cgi?id=37815

Broke GTK again

  • Android.jscbindings.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSCallbackData.cpp: (WebCore::JSCallbackData::invokeCallback):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent):
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript):
  • bindings/js/JSMainThreadExecState.cpp: Removed.
  • bindings/js/JSMainThreadExecState.h: Removed.
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::executeFunctionInContext): (WebCore::ScheduledAction::execute):
  • bindings/js/ScheduledAction.h:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld):
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::call):
  • bindings/objc/ObjCEventListener.mm:
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]):
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/test/ObjC/DOMTestCallback.mm: (-[DOMTestCallback callbackWithClass1Param:]): (-[DOMTestCallback callbackWithClass2Param:strArg:]): (-[DOMTestCallback callbackWithNonBoolReturnType:]): (-[DOMTestCallback customCallback:class6Param:]):
  • bindings/scripts/test/ObjC/DOMTestInterface.mm:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj readOnlyIntAttr]): (-[DOMTestObj readOnlyStringAttr]): (-[DOMTestObj readOnlyTestObjAttr]): (-[DOMTestObj intAttr]): (-[DOMTestObj setIntAttr:]): (-[DOMTestObj longLongAttr]): (-[DOMTestObj setLongLongAttr:]): (-[DOMTestObj unsignedLongLongAttr]): (-[DOMTestObj setUnsignedLongLongAttr:]): (-[DOMTestObj stringAttr]): (-[DOMTestObj setStringAttr:]): (-[DOMTestObj testObjAttr]): (-[DOMTestObj setTestObjAttr:]): (-[DOMTestObj attrWithException]): (-[DOMTestObj setAttrWithException:]): (-[DOMTestObj attrWithSetterException]): (-[DOMTestObj setAttrWithSetterException:]): (-[DOMTestObj attrWithGetterException]): (-[DOMTestObj setAttrWithGetterException:]): (-[DOMTestObj customAttr]): (-[DOMTestObj setCustomAttr:]): (-[DOMTestObj scriptStringAttr]): (-[DOMTestObj voidMethod]): (-[DOMTestObj voidMethodWithArgs:strArg:objArg:]): (-[DOMTestObj intMethod]): (-[DOMTestObj intMethodWithArgs:strArg:objArg:]): (-[DOMTestObj objMethod]): (-[DOMTestObj objMethodWithArgs:strArg:objArg:]): (-[DOMTestObj methodThatRequiresAllArgs:objArg:]): (-[DOMTestObj methodThatRequiresAllArgsAndThrows:objArg:]): (-[DOMTestObj serializedValue:]): (-[DOMTestObj methodWithException]): (-[DOMTestObj customMethod]): (-[DOMTestObj customMethodWithArgs:strArg:objArg:]): (-[DOMTestObj customArgsAndException:]): (-[DOMTestObj addEventListener:listener:useCapture:]): (-[DOMTestObj removeEventListener:listener:useCapture:]): (-[DOMTestObj withDynamicFrame]): (-[DOMTestObj withDynamicFrameAndArg:]): (-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]): (-[DOMTestObj withDynamicFrameAndUserGesture:]): (-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]): (-[DOMTestObj withScriptStateVoid]): (-[DOMTestObj withScriptStateObj]): (-[DOMTestObj withScriptStateVoidException]): (-[DOMTestObj withScriptStateObjException]): (-[DOMTestObj methodWithOptionalArg:]): (-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]): (-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
  • bindings/v8/ScriptController.cpp:
  • bindings/v8/ScriptController.h:
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::isURLAllowed):

2010-05-19 Yaar Schnitman <yaar@chromium.org>

Unreviewed, rolling out r59769.
http://trac.webkit.org/changeset/59769
https://bugs.webkit.org/show_bug.cgi?id=37815

Broke GTK again

  • http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
  • http/tests/security/xss-DENIED-iframe-src-alias.html:
3:36 PM Changeset in webkit [59787] by dpranke@chromium.org
  • 7 edits
    4 deletes in trunk

2010-05-19 Dirk Pranke <dpranke@chromium.org>

Try again to roll out r58765

  • fast/notifications/notifications-replace-expected.txt: Removed.
  • fast/notifications/notifications-replace.html: Removed.
  • fast/notifications/notifications-rtl-expected.txt: Removed.
  • fast/notifications/notifications-rtl.html: Removed.

2010-05-19 Dirk Pranke <dpranke@chromium.org>

Try again to roll out r58675.

  • notifications/Notification.h:
  • notifications/Notification.idl:

2010-05-19 Dirk Pranke <dpranke@chromium.org>

Try again to roll out r58765.

  • public/WebNotification.h:
  • src/WebNotification.cpp:
2:53 PM Changeset in webkit [59786] by enrica@apple.com
  • 3 edits
    2 adds in trunk

WebCore: REGRESSION (r59385) crash destroying inline renderers
https://bugs.webkit.org/show_bug.cgi?id=39143
<rdar://problem/8003662>

Reviewed by Dave Hyatt.

The goal of r59385 was to make sure that the layout of block after all its children had been removed produced the identical result
as the one of a newly created empty block. In order to do so, we had to make sure that the m_inlineChildren flag was reset to true when
the block had no children (as it is upon creation).
I discovered that, by doing that for anonymous blocks it leads removeChild to conclude that the anonymous children can be removed,
without considering that the anonymous block could be part of a continuation chain. For this reason, when RenderInline::destroy()
tries to remove the continuations we are effectively deleting a renderer that had been deleted already.

Test: fast/inline-block/anonymous-block-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock): resetting the flag m_inlineChildren only for non anonymous blocks otherwise we incurr in
a double deletion of the renderer that causes the crash.

LayoutTests: REGRESSION (r59385) crash destroying inline renderers
https://bugs.webkit.org/show_bug.cgi?id=39143
<rdar://problem/8003662>

Reviewed by Dave Hyatt.

  • fast/inline-block/anonymous-block-crash-expected.txt: Added.
  • fast/inline-block/anonymous-block-crash.html: Added.
2:30 PM Changeset in webkit [59785] by dpranke@chromium.org
  • 7 edits
    4 adds in trunk

2010-05-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r59782.
http://trac.webkit.org/changeset/59782
https://bugs.webkit.org/show_bug.cgi?id=39379

broke DRT build (Requested by dpranke on #webkit).

  • fast/notifications/notifications-replace-expected.txt: Added.
  • fast/notifications/notifications-replace.html: Added.
  • fast/notifications/notifications-rtl-expected.txt: Added.
  • fast/notifications/notifications-rtl.html: Added.

2010-05-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r59782.
http://trac.webkit.org/changeset/59782
https://bugs.webkit.org/show_bug.cgi?id=39379

broke DRT build (Requested by dpranke on #webkit).

  • notifications/Notification.h: (WebCore::Notification::dir): (WebCore::Notification::setDir): (WebCore::Notification::replaceId): (WebCore::Notification::setReplaceId):
  • notifications/Notification.idl:

2010-05-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r59782.
http://trac.webkit.org/changeset/59782
https://bugs.webkit.org/show_bug.cgi?id=39379

broke DRT build (Requested by dpranke on #webkit).

  • public/WebNotification.h:
  • src/WebNotification.cpp: (WebKit::WebNotification::dir): (WebKit::WebNotification::replaceId):
2:03 PM Changeset in webkit [59784] by hyatt@apple.com
  • 8 edits
    4 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=21049, opacity and position:relative fail in multi-column layouts.

Reviewed by Oliver Hunt.

Make layers split painting across columns just as normal flow content does. This is actually very
challenging, since intermediate multicol layers can exist between a child that has to be split and
its enclosing stacking context.

In order to properly paginate layers, a bit is set on all pagination roots, i.e., layers that will get
split and thus split any descendant layers that they are also responsible for painting. For a paginated
root, we walk up the layer hierarchy and collect all intermediate multicol blocks between the child
and the enclosing stacking context.

We then recur from the outside in, applying clipping and translation as we break up the layer into strips.

Composited layers remain unsplittable and have a hacked offset still in order to be placed in the right
column.

Painting and hit testing of columns has been simplified in all of the functions to use the x position of
the column rect instead of trying to increment an x offset by adding in widths and column gaps. This
makes those functions directionality-independent (and the LTR/RTL code paths are now the same).

Fix repainting of columns as well to make sure rects are split across columns only after relative position
and transforms have been applied.

Added fast/multicol/layers-split-across-columns.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintColumnContents):
(WebCore::RenderBlock::adjustRectForColumns):
(WebCore::RenderBlock::adjustForColumns):

  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeRectForRepaint):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::updatePagination):
(WebCore::RenderLayer::updateLayerPosition):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintList):
(WebCore::RenderLayer::paintPaginatedChildLayer):
(WebCore::RenderLayer::paintChildLayerIntoColumns):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestList):
(WebCore::RenderLayer::hitTestPaginatedChildLayer):
(WebCore::RenderLayer::hitTestChildLayerColumns):

  • rendering/RenderLayer.h:

(WebCore::RenderLayer::):
(WebCore::RenderLayer::isPaginated):

1:54 PM Changeset in webkit [59783] by eric@webkit.org
  • 6 edits in trunk/WebKit/gtk

2010-05-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r59240.
http://trac.webkit.org/changeset/59240
https://bugs.webkit.org/show_bug.cgi?id=39377

"Might cause crashes in GTK+ bots" (Requested by xan_ on
#webkit).

  • WebCoreSupport/ContextMenuClientGtk.cpp: (WebKit::inputMethodsMenuItem):
  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::setInputMethodState): (WebKit::EditorClient::respondToChangedSelection): (WebKit::EditorClient::handleInputMethodKeydown): (WebKit::EditorClient::EditorClient): (WebKit::EditorClient::~EditorClient):
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::postCommitFrameViewSetup):
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (destroy_menu_cb): (webkit_web_view_forward_context_menu_event): (webkit_web_view_key_release_event): (webkit_web_view_button_release_event): (webkit_web_view_focus_in_event): (webkit_web_view_focus_out_event): (webkit_web_view_realize): (webkit_web_view_set_scroll_adjustments): (webkit_web_view_dispose): (webkit_web_view_finalize): (webViewGetDPI): (webkit_web_view_screen_changed): (webkit_web_view_query_tooltip): (webkit_web_view_get_im_context): (webkit_web_view_update_settings): (webkit_web_view_init): (webkit_web_view_set_settings): (webkit_web_view_get_settings): (webkit_web_view_get_inspector): (webkit_web_view_set_window_features): (webkit_web_view_get_window_features): (webkit_web_view_get_back_forward_list): (webkit_web_view_zoom_in): (webkit_web_view_zoom_out): (webkit_web_view_get_encoding): (webkit_web_view_get_custom_encoding): (webkit_web_view_add_resource): (webkit_web_view_get_resource): (webkit_web_view_get_main_resource): (webkit_web_view_clear_resources): (webkit_web_view_get_subresources): (webkit_web_view_set_tooltip_text): (webkit_web_view_get_icon_uri):
1:41 PM Changeset in webkit [59782] by dpranke@chromium.org
  • 7 edits
    4 deletes in trunk

2010-05-18 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Attempt to revert r58765 to see if it was causing a performance
regression.

https://bugs.webkit.org/show_bug.cgi?id=39328

  • fast/notifications/notifications-replace-expected.txt: Removed.
  • fast/notifications/notifications-replace.html: Removed.
  • fast/notifications/notifications-rtl-expected.txt: Removed.
  • fast/notifications/notifications-rtl.html: Removed.

2010-05-18 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Attempt to revert r58765 to see if it was causing a performance
regression.

https://bugs.webkit.org/show_bug.cgi?id=39328

  • notifications/Notification.h:
  • notifications/Notification.idl:

2010-05-18 Dirk Pranke <dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Attempt to revert r58765 to see if it was causing a performance
regression.

https://bugs.webkit.org/show_bug.cgi?id=39328

  • public/WebNotification.h:
  • src/WebNotification.cpp:
1:35 PM Changeset in webkit [59781] by ggaren@apple.com
  • 4 edits in trunk/JavaScriptCore

2010-05-19 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Don't build the Interpreter into JIT builds.
https://bugs.webkit.org/show_bug.cgi?id=39373

SunSpider says no change.

  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute):
  • interpreter/Interpreter.h:
  • wtf/Platform.h:
12:17 PM Changeset in webkit [59780] by kevino@webkit.org
  • 3 edits in trunk/WebCore

Reviewed by Kevin Ollivier.

[wx] Ensure m_nsFont is initialized properly, and tweak fallback font handling
to handle more cases.
https://bugs.webkit.org/show_bug.cgi?id=39365

12:08 PM Changeset in webkit [59779] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-19 Marcus Bulach <bulach@chromium.org>

Reviewed by Eric Seidel.

Fixes Windows Qt Release post r59772.
https://bugs.webkit.org/show_bug.cgi?id=39369

  • platform/GeolocationService.cpp:
12:02 PM Changeset in webkit [59778] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-19 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add support for handling basic <script> tags in the HTML5 Parser
https://bugs.webkit.org/show_bug.cgi?id=39350

WebKit currently executes scripts from HTMLTokenizer in one giagantic
hack. HTML 5 requires that we execute scripts from the tree-builders/parser.

It will take me a while to re-factor enough of HTMLTokenizer to be able to
move the script execution logic without breaking things. In the interest
of allowing Adam to continue improving the HTML 5 lexer I've added this
very basic (and very incomplete) <script> support to the HTML 5 parser code
path so the he can run the HTML5 parser test suite.

<script> support is tested by most of the layout tests.

  • dom/ScriptElement.cpp: (WebCore::useHTML5Parser): (WebCore::ScriptElement::finishParsingChildren):
11:28 AM Changeset in webkit [59777] by ggaren@apple.com
  • 13 edits in trunk/JavaScriptCore

Standardized naming: "bytecode offset" wins; "bytecode index" loses.

Reviewed by Gavin Barraclough.

Also renamed getBytecodeOffset to bytecodeOffset, to match the WebKit
naming style.

  • bytecode/CodeBlock.h:

(JSC::CallReturnOffsetToBytecodeOffset::CallReturnOffsetToBytecodeOffset):
(JSC::getCallReturnOffset):
(JSC::CodeBlock::bytecodeOffset):
(JSC::CodeBlock::callReturnIndexVector):

  • interpreter/Interpreter.cpp:

(JSC::bytecodeOffsetForPC):

  • jit/JIT.cpp:

(JSC::JIT::JIT):
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileLinkPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):

  • jit/JIT.h:

(JSC::CallRecord::CallRecord):
(JSC::JumpTable::JumpTable):
(JSC::SwitchRecord::SwitchRecord):

  • jit/JITCall.cpp:

(JSC::JIT::compileOpCallVarargsSlowCase):
(JSC::JIT::compileOpCall):

  • jit/JITInlineMethods.h:

(JSC::JIT::emitNakedCall):
(JSC::JIT::addSlowCase):
(JSC::JIT::addJump):
(JSC::JIT::emitJumpSlowToHot):
(JSC::JIT::isLabeled):
(JSC::JIT::map):
(JSC::JIT::unmap):
(JSC::JIT::isMapped):
(JSC::JIT::getMappedPayload):
(JSC::JIT::getMappedTag):
(JSC::JIT::emitGetVirtualRegister):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):
(JSC::JIT::emit_op_switch_string):
(JSC::JIT::emit_op_new_error):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_mov):
(JSC::JIT::emit_op_get_global_var):
(JSC::JIT::emit_op_put_global_var):
(JSC::JIT::emit_op_get_scoped_var):
(JSC::JIT::emit_op_put_scoped_var):
(JSC::JIT::emit_op_to_primitive):
(JSC::JIT::emit_op_resolve_global):
(JSC::JIT::emit_op_to_jsnumber):
(JSC::JIT::emit_op_catch):
(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):
(JSC::JIT::emit_op_switch_string):
(JSC::JIT::emit_op_new_error):
(JSC::JIT::emit_op_convert_this):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_method_check):
(JSC::JIT::emitSlow_op_method_check):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_method_check):
(JSC::JIT::emitSlow_op_method_check):
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_get_by_pname):

  • jit/JITStubCall.h:

(JSC::JITStubCall::call):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

11:03 AM Changeset in webkit [59776] by andersca@apple.com
  • 10 edits in trunk/WebCore

2010-05-19 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Move member variables from NamedMappedAttrMap to its base class NamedNodeMap
https://bugs.webkit.org/show_bug.cgi?id=39367
<rdar://problem/8003304>

This lets us get rid of the vtable pointer in NamedNodeMap which saves 8 bytes, and also allows us to
fit the m_mappedAttributeCount unsigned int in the RefCounted padding (in 64-bit).


The net result is that we shrink the NamedMappedAttrMap size by 16 bytes, while keeping the size of NamedNodeMap the same.

  • dom/Element.cpp: (WebCore::Element::createAttributeMap):
  • dom/Element.h:
  • dom/NamedMappedAttrMap.cpp:
  • dom/NamedMappedAttrMap.h: (WebCore::NamedMappedAttrMap::NamedMappedAttrMap):
  • dom/NamedNodeMap.cpp: (WebCore::NamedNodeMap::clearAttributes):
  • dom/NamedNodeMap.h: (WebCore::NamedNodeMap::NamedNodeMap):
  • dom/Node.cpp: (WebCore::Node::dumpStatistics):
  • dom/StyledElement.cpp:
  • dom/StyledElement.h:
10:58 AM Changeset in webkit [59775] by weinig@apple.com
  • 2 edits in trunk/WebCore

Use ASSERT_UNUSED instead of UNUSED_PARAM.

Reviewed by Anders Carlsson.

  • dom/Attribute.cpp:

(WebCore::Attribute::unbindAttr):

10:57 AM Changeset in webkit [59774] by jianli@chromium.org
  • 3 edits in trunk/WebKit/chromium

Remove obsolete ChromiumBridge code that routes FileSystem calls to WebKitClient.
https://bugs.webkit.org/show_bug.cgi?id=39332

Reviewed by Darin Fisher.

  • public/WebKitClient.h:
  • src/ChromiumBridge.cpp:

(WebCore::ChromiumBridge::fileExists):
(WebCore::ChromiumBridge::deleteFile):
(WebCore::ChromiumBridge::deleteEmptyDirectory):
(WebCore::ChromiumBridge::getFileSize):
(WebCore::ChromiumBridge::getFileModificationTime):
(WebCore::ChromiumBridge::directoryName):
(WebCore::ChromiumBridge::pathByAppendingComponent):
(WebCore::ChromiumBridge::makeAllDirectories):
(WebCore::ChromiumBridge::getAbsolutePath):
(WebCore::ChromiumBridge::isDirectory):
(WebCore::ChromiumBridge::filePathToURL):

10:48 AM Changeset in webkit [59773] by weinig@apple.com
  • 292 edits
    1 delete in trunk/WebCore

Complete the merge of MappedAttribute and Attribute.

Rubber-stamped by Anders Carlsson.

Files elided for brevity.

10:38 AM Changeset in webkit [59772] by eric@webkit.org
  • 6 edits
    2 adds in trunk

2010-05-19 Marcus Bulach <bulach@chromium.org>

Reviewed by Steve Block.

[chromium] Adds supports for layout tests using GeolocationServiceMock.
https://bugs.webkit.org/show_bug.cgi?id=39081

Allows injection of GeolocationServiceMock factory.

Tests: existing fast/dom/Geolocation/*

  • platform/GeolocationService.cpp: (WebCore::GeolocationService::useMock): (WebCore::GeolocationService::useMockFactory):
  • platform/GeolocationService.h:
  • platform/chromium/GeolocationServiceChromium.cpp: (WebCore::GeolocationServiceChromium::GeolocationServiceChromium):

2010-05-19 Marcus Bulach <bulach@chromium.org>

Reviewed by Steve Block.

[chromium] Adds supports for layout tests using GeolocationServiceMock.
https://bugs.webkit.org/show_bug.cgi?id=39081

Allows injection of GeolocationServiceMock factory.
Tests: existing fast/dom/Geolocation/*

  • WebKit.gyp:
  • public/WebGeolocationServiceMock.h: Added.
  • src/WebGeolocationServiceMock.cpp: Added. (WebCore::GeolocationServiceChromiumMock::create): (WebCore::GeolocationServiceChromiumMock::GeolocationServiceChromiumMock): (WebCore::GeolocationServiceChromiumMock::startUpdating): (WebCore::GeolocationServiceChromiumMock::stopUpdating): (WebCore::GeolocationServiceChromiumMock::lastPosition): (WebCore::GeolocationServiceChromiumMock::lastError): (WebCore::GeolocationServiceChromiumMock::geolocationServicePositionChanged): (WebCore::GeolocationServiceChromiumMock::geolocationServiceErrorOccurred): (WebKit::WebGeolocationServiceMock::setMockGeolocationPosition): (WebKit::WebGeolocationServiceMock::setMockGeolocationError):
10:23 AM Changeset in webkit [59771] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-19 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

user.py throws exception when readline module is missing
https://bugs.webkit.org/show_bug.cgi?id=39239

  • Scripts/webkitpy/common/system/user.py:
    • The error handling path requires the "sys" module, so added an import sys at the top of the file.
9:38 AM Changeset in webkit [59770] by Martin Robinson
  • 1 edit
    4 adds in trunk/LayoutTests

2010-05-19 Martin Robinson <mrobinson@igalia.com>

Not reviewed.

Add baselines for new multi-column tests.

  • platform/gtk/fast/multicol/column-count-with-rules-expected.txt: Added.
  • platform/gtk/fast/multicol/layers-in-multicol-expected.txt: Added.
  • platform/gtk/fast/multicol/nested-columns-expected.txt: Added.
9:16 AM Changeset in webkit [59769] by yaar@chromium.org
  • 29 edits
    2 adds in trunk

2010-05-19 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Moving frame.src checks out of the bindings
https://bugs.webkit.org/show_bug.cgi?id=37815

Moved JavaScript frame.src checks out of bindings and into
HTMLFrameElementBase. Added main thread state stack to JavaScriptCore
so ExecState is available inside core DOM. Updated affected bindings
(except for GObject, which will need to be updated to avoid origin
failures inside native code).

  • Android.jscbindings.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSCallbackData.cpp: (WebCore::JSCallbackData::invokeCallback):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent):
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript):
  • bindings/js/JSMainThreadExecState.cpp: Added.
  • bindings/js/JSMainThreadExecState.h: Added. (WebCore::JSMainThreadExecState::currentState): (WebCore::JSMainThreadExecState::call): (WebCore::JSMainThreadExecState::evaluate): (WebCore::JSMainThreadExecState::JSMainThreadExecState): (WebCore::JSMainThreadExecState::~JSMainThreadExecState): (WebCore::JSMainThreadNullState::JSMainThreadNullState):
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::executeFunctionInContext): (WebCore::ScheduledAction::execute):
  • bindings/js/ScheduledAction.h:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld): (WebCore::ScriptController::canAccessFromCurrentOrigin):
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::call):
  • bindings/objc/ObjCEventListener.mm:
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]):
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/test/ObjC/DOMTestCallback.mm: (-[DOMTestCallback callbackWithClass1Param:]): (-[DOMTestCallback callbackWithClass2Param:strArg:]): (-[DOMTestCallback callbackWithNonBoolReturnType:]): (-[DOMTestCallback customCallback:class6Param:]):
  • bindings/scripts/test/ObjC/DOMTestInterface.mm:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj readOnlyIntAttr]): (-[DOMTestObj readOnlyStringAttr]): (-[DOMTestObj readOnlyTestObjAttr]): (-[DOMTestObj intAttr]): (-[DOMTestObj setIntAttr:]): (-[DOMTestObj longLongAttr]): (-[DOMTestObj setLongLongAttr:]): (-[DOMTestObj unsignedLongLongAttr]): (-[DOMTestObj setUnsignedLongLongAttr:]): (-[DOMTestObj stringAttr]): (-[DOMTestObj setStringAttr:]): (-[DOMTestObj testObjAttr]): (-[DOMTestObj setTestObjAttr:]): (-[DOMTestObj attrWithException]): (-[DOMTestObj setAttrWithException:]): (-[DOMTestObj attrWithSetterException]): (-[DOMTestObj setAttrWithSetterException:]): (-[DOMTestObj attrWithGetterException]): (-[DOMTestObj setAttrWithGetterException:]): (-[DOMTestObj customAttr]): (-[DOMTestObj setCustomAttr:]): (-[DOMTestObj scriptStringAttr]): (-[DOMTestObj voidMethod]): (-[DOMTestObj voidMethodWithArgs:strArg:objArg:]): (-[DOMTestObj intMethod]): (-[DOMTestObj intMethodWithArgs:strArg:objArg:]): (-[DOMTestObj objMethod]): (-[DOMTestObj objMethodWithArgs:strArg:objArg:]): (-[DOMTestObj methodThatRequiresAllArgs:objArg:]): (-[DOMTestObj methodThatRequiresAllArgsAndThrows:objArg:]): (-[DOMTestObj serializedValue:]): (-[DOMTestObj methodWithException]): (-[DOMTestObj customMethod]): (-[DOMTestObj customMethodWithArgs:strArg:objArg:]): (-[DOMTestObj customArgsAndException:]): (-[DOMTestObj addEventListener:listener:useCapture:]): (-[DOMTestObj removeEventListener:listener:useCapture:]): (-[DOMTestObj withDynamicFrame]): (-[DOMTestObj withDynamicFrameAndArg:]): (-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]): (-[DOMTestObj withDynamicFrameAndUserGesture:]): (-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]): (-[DOMTestObj withScriptStateVoid]): (-[DOMTestObj withScriptStateObj]): (-[DOMTestObj withScriptStateVoidException]): (-[DOMTestObj withScriptStateObjException]): (-[DOMTestObj methodWithOptionalArg:]): (-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]): (-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::canAccessFromCurrentOrigin):
  • bindings/v8/ScriptController.h:
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::isURLAllowed):

2010-05-19 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Moving frame.src checks out of the bindings
https://bugs.webkit.org/show_bug.cgi?id=37815

  • http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
  • http/tests/security/xss-DENIED-iframe-src-alias.html:
9:11 AM Changeset in webkit [59768] by chang.shu@nokia.com
  • 12 edits
    3 adds in trunk

2010-05-19 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

CanvasRenderingContext2D's property getters that return colors should
serialize them in accordance with the HTML5 spec (4.8.11.1.4)
Setters should ignore invalid colors.

Also, shadowColor should initially be transparent black (4.8.11.1.6)

https://bugs.webkit.org/show_bug.cgi?id=38845

Refactored CanvasStyle to store an RGBA32 instead of RGBA components and/or the color string.

Spec links:
http://www.whatwg.org/specs/web-apps/current-work/#serialization-of-a-color
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-shadowcolor

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::State::State): (WebCore::CanvasRenderingContext2D::shadowColor): (WebCore::CanvasRenderingContext2D::setShadowColor): (WebCore::CanvasRenderingContext2D::setShadow): (WebCore::CanvasRenderingContext2D::clearShadow): (WebCore::CanvasRenderingContext2D::applyShadow):
  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/CanvasStyle.cpp: (WebCore::CanvasStyle::CanvasStyle): (WebCore::CanvasStyle::create): (WebCore::CanvasStyle::applyStrokeColor): (WebCore::CanvasStyle::applyFillColor):
  • html/canvas/CanvasStyle.h: (WebCore::CanvasStyle::create): (WebCore::CanvasStyle::color): (WebCore::CanvasStyle::): (WebCore::CanvasStyle::CMYKAValues::CMYKAValues):
  • platform/graphics/Color.cpp: (WebCore::Color::serialized):
  • platform/graphics/Color.h:

2010-05-19 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Darin Adler.

Added a test to verify proper color serialization in CanvasRenderingContext2D's getters.
https://bugs.webkit.org/show_bug.cgi?id=38845

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#serialization-of-a-color

  • fast/canvas/canvas-color-serialization-expected.txt: Added.
  • fast/canvas/canvas-color-serialization.html: Added.
  • fast/canvas/canvas-set-properties-with-non-invertible-ctm-expected.txt: Updated baseline.
  • fast/canvas/script-tests/canvas-color-serialization.js: Added. (trySettingStrokeStyle): (trySettingFillStyle): (trySettingShadowColor): (trySettingColor): (trySettingStrokeColorWithSetter): (trySettingFillColorWithSetter): (trySettingShadowWithSetter): (trySettingColorWithSetter): (trySettingFillColorRGBA): (trySettingStrokeColorRGBA): (trySettingShadowRGBA): (trySettingRGBA): (trySettingFillColorCMYKA): (trySettingStrokeColorCMYKA): (trySettingShadowCMYKA): (trySettingCMYKA): (trySettingFillColorWithOverrideAlpha): (trySettingStrokeColorWithOverrideAlpha): (trySettingShadowWithOverrideAlpha): (trySettingColorWithOverrideAlpha): (trySettingFillColorGrayLevel): (trySettingStrokeColorGrayLevel): (trySettingShadowGrayLevel): (trySettingGrayLevel): (trySettingFillColorGrayLevelWithAlpha): (trySettingStrokeColorGrayLevelWithAlpha): (trySettingShadowGrayLevelWithAlpha): (trySettingGrayLevelWithAlpha): (tryClearShadowAfterSettingColor): (checkDefaultValue):
  • fast/canvas/script-tests/canvas-set-properties-with-non-invertible-ctm.js:
  • fast/dom/canvasContext2d-element-attribute-js-null-expected.txt: Updated baseline.
  • fast/dom/canvasContext2d-element-attribute-js-null.html:
8:55 AM Changeset in webkit [59767] by chang.shu@nokia.com
  • 3 edits
    3 adds in trunk

2010-05-19 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Simon Hausmann.

[Qt] REGRESSION: CoolClock isn't rendered properly

https://bugs.webkit.org/show_bug.cgi?id=38526

CanvasRenderingContext2D's arc() should connect to the previous point
with a straight line (HTML5 spec 4.8.11.1.8), but if the path is empty
to begin with, we don't want a line back to (0,0)
This also fixes the rendering artifact discussed in bug 36226.

Spec link:
http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-arc

Test: fast/canvas/canvas-arc-connecting-line.html

  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArc):

2010-05-19 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Simon Hausmann.

Add test to verify that CanvasRenderingContext2D's arc() connects arcs
by a straight line (unless it's the first element in the path.)
https://bugs.webkit.org/show_bug.cgi?id=38526

  • fast/canvas/canvas-arc-connecting-line-expected.txt: Added.
  • fast/canvas/canvas-arc-connecting-line.html: Added.
  • fast/canvas/script-tests/canvas-arc-connecting-line.js: Added. (deg2rad):
8:20 AM Changeset in webkit [59766] by abecsi@webkit.org
  • 3 edits
    3 adds in trunk

The backtrackParenthesesOnceEnd function should store the start position
of the subpattern's non-greedy match at the place of the subpattern's
start index in the output array instead of the place of the
subpattern's end index.
Add layout test for checking of non-greedy matching of subpattern in
regular expressions.
https://bugs.webkit.org/show_bug.cgi?id=39289

Patch by Peter Varga <pvarga@inf.u-szeged.hu> on 2010-05-19
Reviewed by Darin Adler.

JavaScriptCore:

  • yarr/RegexInterpreter.cpp:

(JSC::Yarr::Interpreter::backtrackParenthesesOnceEnd):

LayoutTests:

  • fast/js/regexp-non-greedy-parentheses-expected.txt: Added.
  • fast/js/regexp-non-greedy-parentheses.html: Added.
  • fast/js/script-tests/regexp-non-greedy-parentheses.js: Added.
8:14 AM Changeset in webkit [59765] by antti.j.koivisto@nokia.com
  • 5 edits in trunk

[Qt] TiledBackingStore updates broken when not using resizesToContents mode
https://bugs.webkit.org/show_bug.cgi?id=39359

Rubber-stamped by Kenneth Rohde Christiansen.

Put the back logic that was lost in refactoring.

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::visibleRectForTiledBackingStore):

  • WebCoreSupport/PageClientQt.cpp:

(WebCore::PageClientQGraphicsWidget::graphicsItemVisibleRect):

  • WebCoreSupport/PageClientQt.h:

(WebCore::PageClientQWidget::viewResizesToContentsEnabled):
(WebCore::PageClientQGraphicsWidget::viewResizesToContentsEnabled):

8:13 AM Changeset in webkit [59764] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-05-19 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r59758.
http://trac.webkit.org/changeset/59758
https://bugs.webkit.org/show_bug.cgi?id=39361

This patch adds a test that fails on Leopard (Requested by
abarth on #webkit).

  • fast/canvas/webgl/texture-npot-expected.txt:
  • fast/canvas/webgl/texture-npot.html:
8:04 AM Changeset in webkit [59763] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Symbian build fix.

[Qt] Updated the def file with exports needed for DumpRenderTree.

  • symbian/eabi/QtWebKitu.def:
6:25 AM Changeset in webkit [59762] by apavlov@chromium.org
  • 5 edits in trunk/WebCore

2010-05-19 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Jeremy Orlow.

Fix whitespace for the bug 38906
https://bugs.webkit.org/show_bug.cgi?id=39351

No new tests required (no code change).

  • css/CSSParser.cpp: (WebCore::CSSParser::~CSSParser): (WebCore::CSSParser::setupParser): (WebCore::CSSParser::parseSheet): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseSelector): (WebCore::unitFromString): (WebCore::CSSParser::checkForOrphanedUnits): (WebCore::CSSParser::parseWCSSInputProperty): (WebCore::CSSParser::parseFillShorthand): (WebCore::CSSParser::parseAnimationShorthand): (WebCore::CSSParser::parseTransitionShorthand): (WebCore::CSSParser::parseShorthand): (WebCore::CSSParser::parse4Values): (WebCore::CSSParser::parseAttr): (WebCore::CSSParser::parseFillPositionXY): (WebCore::CSSParser::parseFillPosition): (WebCore::CSSParser::parseFillRepeat): (WebCore::CSSParser::parseFillProperty): (WebCore::CSSParser::parseAnimationTimingFunction): (WebCore::CSSParser::parseAnimationProperty): (WebCore::CSSParser::parseDashboardRegions): (WebCore::CSSParser::parseCounterContent): (WebCore::CSSParser::parseShape): (WebCore::CSSParser::parseFont): (WebCore::CSSParser::parseFontFamily): (WebCore::CSSParser::parseFontFaceSrc): (WebCore::parseInt): (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseShadow): (WebCore::CSSParser::parseReflect): (WebCore::BorderImageParseContext::commitNumber): (WebCore::BorderImageParseContext::commitBorderImage): (WebCore::CSSParser::parseBorderImage): (WebCore::CSSParser::parseCounter): (WebCore::parseGradientPoint): (WebCore::parseGradientColorStop): (WebCore::CSSParser::parseGradient): (WebCore::CSSParser::parseCanvas): (WebCore::CSSParser::parseTransform): (WebCore::CSSParser::parseTransformOrigin): (WebCore::CSSParser::parsePerspectiveOrigin): (WebCore::CSSParser::text): (WebCore::CSSParser::createRuleList): (WebCore::CSSParser::createVariablesRule): (WebCore::CSSParser::parseVariable): (WebCore::CSSParser::parsePropertyWithResolvedVariables): (WebCore::CSSParser::checkForVariables): (WebCore::CSSParser::createKeyframeRule):
  • css/CSSParser.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::setFrontend): (WebCore::InspectorController::show): (WebCore::InspectorController::unbindAllResources): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::scriptImported): (WebCore::InspectorController::getCurrentUserInitiatedProfileName): (WebCore::InspectorController::removeBreakpoint): (WebCore::drawOutlinedQuad): (WebCore::InspectorController::stopTiming):
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::didRemoveDOMNode): (WebCore::InspectorDOMAgent::getStyles): (WebCore::InspectorDOMAgent::applyStyleText):
6:24 AM Changeset in webkit [59761] by kenneth@webkit.org
  • 2 edits in trunk/WebKit/qt

When creating the UA, do not sassmue the language code is a
two-letter iso639-1 code.

Patch by Denis Dzyubenko <denis.dzyubenko@nokia.com> on 2010-05-19
Reviewed by Kenneth Rohde Christiansen.

  • Api/qwebpage.cpp:

(QWebPage::userAgentForUrl):

4:44 AM Changeset in webkit [59760] by antti.j.koivisto@nokia.com
  • 4 edits in trunk/WebKit/qt

[Qt] Move visible rect calculation from QGraphicsWebViewPrivate to PageClientQGraphicsWidget
https://bugs.webkit.org/show_bug.cgi?id=39294

Reviewed by Kenneth Rohde Christiansen.

  • Api/qgraphicswebview.cpp:
  • WebCoreSupport/PageClientQt.cpp:

(WebCore::PageClientQGraphicsWidget::graphicsItemVisibleRect):

  • WebCoreSupport/PageClientQt.h:
4:43 AM Changeset in webkit [59759] by eric@webkit.org
  • 3 edits in trunk

2010-05-19 Dan Winship <danw@gnome.org>

Reviewed by Xan Lopez.

[GTK] Install introspection files in our prefix, not
gobject-introspection's prefix

  • GNUmakefile.am:
  • configure.ac:
3:59 AM Changeset in webkit [59758] by eric@webkit.org
  • 3 edits in trunk/LayoutTests

2010-05-19 Zhenyao Mo <zmo@google.com>

Reviewed by Darin Adler.

fast/canvas/webgl/texture-npot.html failed on leopard bot
https://bugs.webkit.org/show_bug.cgi?id=39128

  • fast/canvas/webgl/texture-npot-expected.txt: Skip pixel (0, 0); print out actual color when failing.
  • fast/canvas/webgl/texture-npot.html: Ditto.
3:48 AM Changeset in webkit [59757] by eric@webkit.org
  • 2 edits in trunk/WebCore

2010-05-19 Steve Block <steveblock@google.com>

Reviewed by Nate Chapin.

V8 code generator does not add ENABLE guards around attribute getters and setters
https://bugs.webkit.org/show_bug.cgi?id=39222

No new tests, build fix only.

  • bindings/scripts/CodeGeneratorV8.pm:
3:17 AM Changeset in webkit [59756] by jorlow@chromium.org
  • 2 edits in trunk/WebCore

2010-05-19 Jeremy Orlow <jorlow@chromium.org>

Unreviewed build fix for Chromium.

  • storage/IndexedDatabaseImpl.cpp:
3:04 AM Changeset in webkit [59755] by jorlow@chromium.org
  • 16 edits
    4 copies in trunk

2010-05-17 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

Hook Chromium's WebIndexedDatabaseImpl up to IndexedDatabaseImpl
https://bugs.webkit.org/show_bug.cgi?id=39216

All of these functions are supposed to be passing around the origin since
the caller of IndexedDatabaseImpl might not be able to pass in a Frame*
object. I tried to fix this in an ealier patch, but obviously messed up.

Also change passing security origin strings to passing SecurityOrigin
objects.

No behavior change because Chromium was emulating the old behavior before
even though the code wasn't properly hooked up.

  • storage/IndexedDatabase.h:
  • storage/IndexedDatabaseImpl.cpp: (WebCore::IndexedDatabaseImpl::open):
  • storage/IndexedDatabaseImpl.h:
  • storage/IndexedDatabaseRequest.cpp: (WebCore::IndexedDatabaseRequest::open):

2010-05-17 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Darin Fisher.

Hook Chromium's WebIndexedDatabaseImpl up to IndexedDatabaseImpl
https://bugs.webkit.org/show_bug.cgi?id=39216

WebImpl is for re-entering the WebKit layer from the browser layer.
Thus the previous IDBCallbacksProxy was mis-named (and should have been
WebIDBCallbacksImpl). This patch renames it and then implements the
proper proxy (which is for going from WebCore to WebKit).

Also change using security origin strings to using WebSecurityOrigin
objects.

This patch also implements the glue between WebIndexedDatabaseImpl and
IndexedDatabaseImpl.

  • WebKit.gyp:
  • src/IDBCallbacksProxy.cpp: (WebCore::IDBCallbacksProxy::create): (WebCore::IDBCallbacksProxy::IDBCallbacksProxy): (WebCore::IDBCallbacksProxy::onError): (WebCore::IDBCallbacksProxy::onSuccess):
  • src/IDBCallbacksProxy.h:
  • src/IndexedDatabaseProxy.cpp: (WebCore::IndexedDatabaseProxy::open):
  • src/IndexedDatabaseProxy.h:
  • src/WebIDBCallbacksImpl.cpp: Added. (WebCore::WebIDBCallbacksImpl::WebIDBCallbacksImpl): (WebCore::WebIDBCallbacksImpl::~WebIDBCallbacksImpl): (WebCore::WebIDBCallbacksImpl::onError): (WebCore::WebIDBCallbacksImpl::onSuccess):
  • src/WebIDBCallbacksImpl.h: Added.
  • src/WebIDBDatabaseImpl.cpp: Added. (WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl): (WebKit::WebIDBDatabaseImpl::~WebIDBDatabaseImpl):
  • src/WebIDBDatabaseImpl.h: Added.
  • src/WebIndexedDatabaseImpl.cpp: (WebKit::WebIndexedDatabaseImpl::WebIndexedDatabaseImpl): (WebKit::WebIndexedDatabaseImpl::open):
  • src/WebIndexedDatabaseImpl.h:
2:37 AM Changeset in webkit [59754] by eric@webkit.org
  • 4 edits in trunk

2010-05-19 Ben Murdoch <benm@google.com>

Reviewed by Darin Adler.

Touch events are marked DontEnum in DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=39118

Update the expected results for enumerating the window object
properties now touch event listeners are no longer marked DontEnum.

  • platform/qt/fast/dom/Window/window-properties-expected.txt:

2010-05-19 Ben Murdoch <benm@google.com>

Reviewed by Darin Adler.

Touch events are marked DontEnum in DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=39118

Touch events are the only attribute event listeners on the
window object that are marked DontEnum. For consistency allow
them to be enumerated.

  • page/DOMWindow.idl: Remove DontEnum from touchcancel, touchend,

touchstart and touchmove attributes.

1:38 AM Changeset in webkit [59753] by Simon Hausmann
  • 2 edits in trunk/WebCore

[Qt] Fix build warning

NamedAttrMap.h has been renamed to NamedNodeMap.h

  • WebCore.pro:
1:22 AM Changeset in webkit [59752] by eric@webkit.org
  • 1 edit
    5 adds in trunk/WebCore

2010-05-19 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add an HTML parsing benchmark
https://bugs.webkit.org/show_bug.cgi?id=39338

This benchmark parses the HTML5 specification 10 times and
reports how long it takes. It does this 21 times, discarding
the first warm-up run, and then prints the average time and
standard deviation.

Sharking the benchmark correctly shows over 60% of the time spent under HTMLTokenizer::write().
The numbers from the benchmark are rather consistent. On my
Mac Book Pro, I consistently see standard deviations < 2% of total time.

  • benchmarks/parser/html-parser.html: Added.
  • benchmarks/parser/resources/html5.html: Added.
12:33 AM Changeset in webkit [59751] by yuzo@google.com
  • 12 edits
    2 deletes in trunk

2010-05-18 Yuzo Fujishima <yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Make CSS Parser properly handle only-for-pages pseudo-classes.

https://bugs.webkit.org/show_bug.cgi?id=38731

  • fast/css/misplaced-paged-media-pseudo-expected.txt: Removed.
  • fast/css/misplaced-paged-media-pseudo.html: Removed.
  • printing/page-rule-css-text-expected.txt:
  • printing/page-rule-css-text.html:
  • printing/pseudo-class-outside-page-expected.txt:
  • printing/pseudo-class-outside-page.html:

2010-05-18 Yuzo Fujishima <yuzo@google.com>

Reviewed by Shinichiro Hamaji.

Make CSS Parser properly handle only-for-pages pseudo-classes.

A new Match category, PagePseudoClass, is introduced to distinguish
only-for-pages pseudo-classes from others. A new symbol, pseudo_page,
is introduced to handle them separately.

https://bugs.webkit.org/show_bug.cgi?id=38731

  • css/CSSGrammar.y:
  • css/CSSParser.cpp: (WebCore::CSSParser::createMarginAtRule):
  • css/CSSParser.h:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): (WebCore::CSSSelector::selectorText):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
12:26 AM Changeset in webkit [59750] by abarth@webkit.org
  • 5 edits in trunk/WebCore

2010-05-19 Adam Barth <abarth@webkit.org>

Reviewed by David Hyatt.

Change the API of nextToken to distinguish between emitting a token and just running out of input
https://bugs.webkit.org/show_bug.cgi?id=39349

I'm not sure there's a functional difference with this patch yet, but
as discussed with Eric, we need this to handle attributes.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::reset): (WebCore::HTML5Lexer::nextToken):
  • html/HTML5Lexer.h:
  • html/HTML5Token.h: (WebCore::HTML5Token::HTML5Token): (WebCore::HTML5Token::clear): (WebCore::HTML5Token::beginStartTag): (WebCore::HTML5Token::beginEndTag): (WebCore::HTML5Token::beginCharacter):
  • html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::write):
12:19 AM Changeset in webkit [59749] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-05-18 Eric Seidel <eric@webkit.org>

Reviewed by Maciej Stachowiak.

Refactor HTMLTokenizer::write to make it more readable and split out the lexer bits from flow control bits
https://bugs.webkit.org/show_bug.cgi?id=39318

No functional changes, only moving code into smaller functions.

This code is already covered by numerous layout tests.

HTML parsing benchmark shows this to be a wash.

  • dom/Tokenizer.h:
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::advance):
    • New funtion to encapulate code which will move into HTMLLexer eventually.
    • Use ALWAYS_INLINE to make sure compilers inline this large function (otherwise this patch is a regression).

(WebCore::HTMLTokenizer::willWriteHTML):

  • New function to handle calling any pre-write delegates.

(WebCore::HTMLTokenizer::didWriteHTML):

  • New function to handle calling any post-write delegates.

(WebCore::HTMLTokenizer::write):

  • Call the new functions.
  • html/HTMLTokenizer.h:

May 18, 2010:

11:45 PM Changeset in webkit [59748] by alex
  • 2 edits in trunk/LayoutTests

2010-05-18 Alejandro G. Castro <alex@igalia.com>

Unreviewed, skip test.

Skipping fast/workers/storage
https://bugs.webkit.org/show_bug.cgi?id=39346

  • platform/gtk/Skipped:
11:30 PM Changeset in webkit [59747] by abarth@webkit.org
  • 5 edits in trunk/WebCore

2010-05-18 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Make the HTML5 parser correctly parse <div>Hello</div>
https://bugs.webkit.org/show_bug.cgi?id=39345

Again, this patch is covered by a large number of LayoutTests.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::HTML5Lexer): (WebCore::HTML5Lexer::reset): (WebCore::HTML5Lexer::nextToken): (WebCore::HTML5Lexer::emitCommentToken): (WebCore::HTML5Lexer::emitCharacter): (WebCore::HTML5Lexer::emitCurrentTagToken):
  • html/HTML5Lexer.h:
  • html/HTML5Token.h: (WebCore::HTML5Token::beginCharacter): (WebCore::HTML5Token::appendToCharacter): (WebCore::HTML5Token::characters):
  • html/HTML5Tokenizer.cpp: (WebCore::convertToOldStyle):
11:04 PM Changeset in webkit [59746] by barraclough@apple.com
  • 15 edits in trunk/JavaScriptCore

Bug 39343 - Dynamically generate a native call thunk per NativeFunction

Reviewed by Geoff Garen.

https://bugs.webkit.org/show_bug.cgi?id=39252 regressed performance on i386,
by adding an extra indirection to making a native call. By introducing per-
NativeFunction thunks we can hard code the function pointer into the thunk
so that it need not be loaded from the callee.

  • jit/JIT.h:

(JSC::JIT::compileCTINativeCall):

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileCTINativeCall):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTINativeCall):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitSlow_op_get_by_val):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emitSlow_op_get_by_val):

  • jit/JITStubs.cpp:

(JSC::JITThunks::ctiStub):
(JSC::JITThunks::hostFunctionStub):

  • jit/JITStubs.h:
  • jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::finalize):

  • jit/ThunkGenerators.cpp:

(JSC::charCodeAtThunkGenerator):
(JSC::charAtThunkGenerator):
(JSC::fromCharCodeThunkGenerator):
(JSC::sqrtThunkGenerator):
(JSC::powThunkGenerator):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::JSFunction):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::getHostFunction):

  • runtime/JSGlobalData.h:

(JSC::JSGlobalData::getCTIStub):

  • runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

  • runtime/StringConstructor.cpp:

(JSC::StringConstructor::StringConstructor):

  • wtf/Platform.h:
10:30 PM Changeset in webkit [59745] by abarth@webkit.org
  • 5 edits in trunk/WebCore

2010-05-18 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Make the HTML5 parser actually parse <div></div>
https://bugs.webkit.org/show_bug.cgi?id=39342

This patch is covered by every LayoutTest. Yes. All of them. :)

  • html/HTML5Lexer.cpp: (WebCore::toLowerCase): (WebCore::HTML5Lexer::HTML5Lexer): (WebCore::HTML5Lexer::nextToken): (WebCore::HTML5Lexer::emitCharacter):
  • html/HTML5Lexer.h:
  • html/HTML5Token.h: (WebCore::HTML5Token::HTML5Token): (WebCore::HTML5Token::beginStartTag): (WebCore::HTML5Token::beginEndTag): (WebCore::HTML5Token::appendToName): (WebCore::HTML5Token::type): (WebCore::HTML5Token::name): (WebCore::HTML5Token::selfClosing): (WebCore::HTML5Token::attrs):
  • html/HTML5Tokenizer.cpp: (WebCore::convertToOldStyle): (WebCore::HTML5Tokenizer::write):
10:27 PM Changeset in webkit [59744] by tkent@chromium.org
  • 5 edits in trunk

[DRT/Chromium] Fix a repaint issue and textarea tests
https://bugs.webkit.org/show_bug.cgi?id=39054

Reviewed by Dimitri Glazkov.

WebKit/chromium:

  • DEPS: Update to Chromium r47248 to use a fix for CommandLine assertion and textAreaResizeCorner.png
  • WebKit.gyp: Add textAreaResizeCorner.png as a Mac resource

WebKitTools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::canvas): Remove m_paintRect initialization in canvas().

This line updated m_paintRect unexpectedly during paintRect().
We don't need to initialize m_paintRect because show() does it.

10:12 PM Changeset in webkit [59743] by tony@chromium.org
  • 6 edits in trunk/WebKitTools

2010-05-18 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

[chromium] new-run-webkit-tests --use-drt should run on Linux
https://bugs.webkit.org/show_bug.cgi?id=37845

  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
10:10 PM Changeset in webkit [59742] by ggaren@apple.com
  • 25 edits
    2 adds in trunk

JavaScriptCore: Simplified handling of 'arguments' -- 1.2% SunSpider speedup
https://bugs.webkit.org/show_bug.cgi?id=39200

Reviewed by Darin Adler.

Removed the reserved OptionalCalleeArguments slot from the CallFrame.
Now, slots for 'arguments' are allocated and initialized only by
functions that might need them.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dump): Updated for new bytecode operands.

(JSC::CodeBlock::CodeBlock):

  • bytecode/CodeBlock.h:

(JSC::unmodifiedArgumentsRegister): Added a helper function for mapping
from the arguments register to its unmodified counterpart.

(JSC::CodeBlock::setArgumentsRegister):
(JSC::CodeBlock::argumentsRegister):
(JSC::CodeBlock::usesArguments): Changed from a "usesArguments" bool to
an optional int index representing the arguments register.

  • bytecode/Opcode.h: Updated for new bytecode operands.
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::addVar): Factored out a helper function for
allocating an anonymous var.

(JSC::BytecodeGenerator::BytecodeGenerator): Merged / simplified some
arguments vs activation logic, and added code to allocate the arguments
registers when needed.

(JSC::BytecodeGenerator::createArgumentsIfNecessary): Updated for new bytecode operands.

(JSC::BytecodeGenerator::emitCallEval): No need to create the arguments
object before calling eval; the activation object will lazily create the
arguments object if eval resolves it.

(JSC::BytecodeGenerator::emitReturn): Updated for new bytecode operands.

(JSC::BytecodeGenerator::emitPushScope):
(JSC::BytecodeGenerator::emitPushNewScope): Ditto emitCallEval.

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::addVar): Factored out a helper function for
allocating an anonymous var.

(JSC::BytecodeGenerator::registerFor): No more need for special handling
of the arguments registers; they're allocated just like normal registers
now.

  • interpreter/CallFrame.h:

(JSC::ExecState::callerFrame):
(JSC::ExecState::init):

  • interpreter/CallFrameClosure.h:

(JSC::CallFrameClosure::resetCallFrame): Nixed optionalCalleeArguments.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveArguments): Opcodes accessing 'arguments' now
take operands specifying registers, just like all other opcodes.
JSActivation::copyRegisters is no longer responsible for tearing off the
arguments object; instead, the VM is responsible for both.

Also, a behavior change: Each access to f.arguments creates a new object,
unless f itself uses 'arguments'. This matches Chrome, and is necessary
for the optimization. f.arguments is a nonstandard, deprecated feature,
so high fidelity to a given implementation is not necessarily a goal.
Also, as illustrated by the new test case, the identity of f.arguments
has been broken since 2008, except in the case where f itself accesses
f.arguments -- but nobody seemed to notice. So, hopefully this change won't
break the web.

  • interpreter/Register.h: Nixed the special arguments accessor. It's no

longer needed.

  • interpreter/RegisterFile.h:

(JSC::RegisterFile::):

  • jit/JITCall.cpp:

(JSC::JIT::compileOpCallInitializeCallFrame):
(JSC::JIT::compileOpCall):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_tear_off_activation):
(JSC::JIT::emit_op_tear_off_arguments):
(JSC::JIT::emit_op_create_arguments):
(JSC::JIT::emit_op_init_arguments):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_tear_off_activation):
(JSC::JIT::emit_op_tear_off_arguments):
(JSC::JIT::emit_op_create_arguments):
(JSC::JIT::emit_op_init_arguments): The actual optimization: Removed
OptionalCalleeArguments from the callframe slot. Now, it doesn't need
to be initialized for most calls.

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITStubs.h:

(JSC::): Updated stubs to support arbitrary 'arguments' registers,
instead of hard-coding something in the call frame.

  • runtime/Arguments.h:

(JSC::JSActivation::copyRegisters): Removed some obfuscatory abstraction.

  • runtime/Executable.h:

(JSC::FunctionExecutable::generatedByteCode): Added a helper for accessing
the 'arguments' register. In a future patch, that kind of data should
probably move out of CodeBlock and into Executable.

  • runtime/JSActivation.cpp:

(JSC::JSActivation::getOwnPropertySlot):
(JSC::JSActivation::argumentsGetter):

  • runtime/JSActivation.h: Simplified / fixed access to 'arguments' via

the activation object. It now implements the same behavior implemented
by optimized variable access in the VM. This simplifies some other
things, too -- like eval code generation.

LayoutTests: Simplified handling of 'arguments' -- 1.2% SunSpider speedup
https://bugs.webkit.org/show_bug.cgi?id=39200

Reviewed by Darin Adler.

  • fast/js/function-dot-arguments-expected.txt:
  • fast/js/script-tests/function-dot-arguments.js:

(argumentsIdentity): Updated to match new behavior.

  • fast/js/function-dot-arguments2-expected.txt:
  • fast/js/function-dot-arguments2.html: New tests for some things that

weren't covered before.

  • fast/js/global-recursion-on-full-stack.html: Rejiggered the stack

usage in this test. Since stack usage is more efficient now, you
need a slightly different usage pattern to hit the exact thing this
test wanted to test.

  • fast/js/kde/script-tests/function_arguments.js:

(f): Updated to more specifically test what this was trying to test,
to avoid just testing the identity of f.arguments.

9:24 PM Changeset in webkit [59741] by tkent@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed test fix.

fast/css/pseudo-required-optional-unapplied.html failure with ENABLE_METER_TAG
https://bugs.webkit.org/show_bug.cgi?id=39341

Remove test elements at the end of the test because dumpAsText() output
for <meter> depends on ENABLE_METER_TAG.

  • fast/css/pseudo-required-optional-unapplied-expected.txt:
  • fast/css/pseudo-required-optional-unapplied.html:
  • platform/qt/Skipped:
8:54 PM Changeset in webkit [59740] by tkent@chromium.org
  • 1 edit in trunk/LayoutTests/platform/qt/Skipped

Unreviewed. Add pseudo-required-optional-unapplied.html to qt/Skipped.
https://bugs.webkit.org/show_bug.cgi?id=39341

8:30 PM Changeset in webkit [59739] by tony@chromium.org
  • 3 edits
    2 adds in trunk

2010-05-18 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

REGRESSION: crash in WebCore::CompositeEditCommand::splitTreeToNode when indenting in an empty li
https://bugs.webkit.org/show_bug.cgi?id=38232

  • editing/execCommand/crash-indenting-list-item-expected.txt: Added.
  • editing/execCommand/crash-indenting-list-item.html: Added.

2010-05-18 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

REGRESSION: crash in WebCore::CompositeEditCommand::splitTreeToNode when indenting in an empty li
https://bugs.webkit.org/show_bug.cgi?id=38232

Test: editing/execCommand/crash-indenting-list-item.html

  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::tryIndentingAsListItem): (WebCore::IndentOutdentCommand::indentIntoBlockquote):
8:15 PM Changeset in webkit [59738] by tkent@chromium.org
  • 4 edits
    2 adds in trunk

':optional' pseudo selector should not be applied to <keygen> and <progress>
https://bugs.webkit.org/show_bug.cgi?id=39292

Reviewed by Darin Adler.

WebCore:

Test: fast/css/pseudo-required-optional-unapplied.html

  • html/HTMLKeygenElement.h:

(WebCore::HTMLKeygenElement::isOptionalFormControl):

Add isOptionalFormControl() returning false.
HTMLKeygenElement inherits HTMLSelectElement, which should return true
for isOptionalFormControl(). However, <keygen> is not :optional
according to the standard.

  • html/HTMLProgressElement.h: Remove isOptionalFormControl().

LayoutTests:

Add a test for non-optional form elements.

  • fast/css/pseudo-required-optional-unapplied-expected.txt: Added.
  • fast/css/pseudo-required-optional-unapplied.html: Added.
7:59 PM Changeset in webkit [59737] by tkent@chromium.org
  • 4 edits in trunk/WebKitTools

2010-05-18 Kent Tamura <tkent@chromium.org>

Reviewed by Dimitri Glazkov.

[DRT/Chromium] Fix some initialization/reset issues
https://bugs.webkit.org/show_bug.cgi?id=39281

  • DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::reset): Reset m_userStyleSheetLocation.
  • DumpRenderTree/chromium/LayoutTestController.h: Remove unused variable, m_workQueueFrozen. (LayoutTestController::WorkQueue::WorkQueue): Initialize m_frozen.
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetTestController): Reset WebSettings too.
7:57 PM Changeset in webkit [59736] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-05-18 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement the DOCTYPE states for the HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=39335

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken): (WebCore::emitCurrentDoctypeToken):
  • html/HTML5Lexer.h:
7:33 PM Changeset in webkit [59735] by tony@chromium.org
  • 3 edits
    1 add in trunk

2010-05-18 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] ignore IME events if the keydown event was prevented
https://bugs.webkit.org/show_bug.cgi?id=37692

A manual test to verify the IME behavior since the existing methods of
textInputController test at a lower level than the fix.

  • manual-tests/ime-keydown-preventdefault.html: Added.

2010-05-18 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] ignore IME events if the keydown event was prevented
https://bugs.webkit.org/show_bug.cgi?id=37692

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleCompositionEvent):
7:26 PM Changeset in webkit [59734] by weinig@apple.com
  • 2 edits in trunk/WebCore

Fix the build for platforms that don't always include UnusedParam.h

  • dom/Attribute.cpp:
7:24 PM Changeset in webkit [59733] by morrita@google.com
  • 7 edits in trunk

2010-05-18 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

[Chromium] Windows: Determinate progress bar should have glossy overlay
https://bugs.webkit.org/show_bug.cgi?id=39269

  • Moved animation code from RenderThemeChromiumWin to chromium tree because it should be behind the theme implementation, which lives in chromium tree.
  • Passed current time to the bridge, which will be used to compute the state of the theme animation.

No new tests, animation effect can be confirmed only manually.

  • platform/chromium/ChromiumBridge.h:
  • rendering/RenderProgress.h: (WebCore::RenderProgress::animationStartTime): Added.
  • rendering/RenderThemeChromiumWin.cpp: (WebCore::RenderThemeChromiumWin::animationDurationForProgressBar): (WebCore::RenderThemeChromiumWin::paintProgressBar):

2010-05-18 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

[Chromium] Windows: Determinate progress bar should have glossy overlay
https://bugs.webkit.org/show_bug.cgi?id=39269

Changed WebThemeEngine::drawProgressBar() signature to delegate
theme implementation detail to the engine.
Chromium side will come to http://crbug.com/44430.

No new tests, animation effect can be confirmed only manually.

  • public/WebThemeEngine.h: (WebKit::WebThemeEngine::paintProgressBar):
  • src/ChromiumBridge.cpp: (WebCore::ChromiumBridge::paintProgressBar):
7:18 PM QtWebKitBackportingFixes edited by Laszlo Gombos
(diff)
7:12 PM Changeset in webkit [59732] by weinig@apple.com
  • 2 edits in trunk/WebCore

Fix release build.

  • dom/Attribute.cpp:

(WebCore::Attribute::unbindAttr):

6:56 PM Changeset in webkit [59731] by weinig@apple.com
  • 4 edits in trunk/WebCore

Move Attr pointer from Attribute to a global HashMap.
https://bugs.webkit.org/show_bug.cgi?id=39337
<rdar://problem/8001168>

Reviewed by Maciej Stachowiak.

Shaves another word off of Attribute.

  • dom/Attr.cpp:

(WebCore::Attr::Attr):
(WebCore::Attr::~Attr):

  • dom/Attribute.cpp:

(WebCore::attributeAttrMap):
(WebCore::Attribute::attr):
(WebCore::Attribute::createAttrIfNeeded):
(WebCore::Attribute::bindAttr):
(WebCore::Attribute::unbindAttr):

  • dom/Attribute.h:

(WebCore::Attribute::Attribute):

6:52 PM Changeset in webkit [59730] by jamesr@google.com
  • 5 edits
    52 adds in trunk/LayoutTests

2010-05-18 James Robinson <jamesr@chromium.org>

Unreviewed.

Add leopard-specific pixel results for more tests that need them
https://bugs.webkit.org/show_bug.cgi?id=39325

This adds new Leopard baselines for all tests that currently
pass with tolerance=0 on Snow Leopard but fail on Leopard
with an image diff of <= 0.1%. These tests previously had
expectations in platform/mac that were Snow Leopard specific.

  • platform/mac-leopard/animations: Added.
  • platform/mac-leopard/animations/3d: Added.
  • platform/mac-leopard/animations/3d/change-transform-in-end-event-expected.checksum: Added.
  • platform/mac-leopard/animations/3d/change-transform-in-end-event-expected.png: Added.
  • platform/mac-leopard/compositing/animation: Added.
  • platform/mac-leopard/compositing/animation/state-at-end-event-transform-layer-expected.checksum: Added.
  • platform/mac-leopard/compositing/animation/state-at-end-event-transform-layer-expected.png: Added.
  • platform/mac-leopard/compositing/compositing-visible-descendant-expected.checksum: Added.
  • platform/mac-leopard/compositing/compositing-visible-descendant-expected.png: Added.
  • platform/mac-leopard/compositing/geometry/abs-position-inside-opacity-expected.checksum: Added.
  • platform/mac-leopard/compositing/geometry/abs-position-inside-opacity-expected.png: Added.
  • platform/mac-leopard/compositing/geometry/fixed-position-expected.checksum: Added.
  • platform/mac-leopard/compositing/geometry/fixed-position-expected.png: Added.
  • platform/mac-leopard/compositing/geometry/horizontal-scroll-composited-expected.checksum: Added.
  • platform/mac-leopard/compositing/geometry/horizontal-scroll-composited-expected.png: Added.
  • platform/mac-leopard/compositing/geometry/partial-layout-update-expected.checksum: Added.
  • platform/mac-leopard/compositing/geometry/partial-layout-update-expected.png: Added.
  • platform/mac-leopard/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.checksum: Added.
  • platform/mac-leopard/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.png: Added.
  • platform/mac-leopard/compositing/geometry/vertical-scroll-composited-expected.checksum: Added.
  • platform/mac-leopard/compositing/geometry/vertical-scroll-composited-expected.png: Added.
  • platform/mac-leopard/compositing/iframes/iframe-copy-on-scroll-expected.checksum: Added.
  • platform/mac-leopard/compositing/iframes/iframe-copy-on-scroll-expected.png: Added.
  • platform/mac-leopard/compositing/masks: Added.
  • platform/mac-leopard/compositing/masks/direct-image-mask-expected.checksum: Added.
  • platform/mac-leopard/compositing/masks/direct-image-mask-expected.png: Added.
  • platform/mac-leopard/compositing/overflow/fixed-position-ancestor-clip-expected.checksum: Added.
  • platform/mac-leopard/compositing/overflow/fixed-position-ancestor-clip-expected.png: Added.
  • platform/mac-leopard/compositing/reflections/reflection-in-composited-expected.checksum: Added.
  • platform/mac-leopard/compositing/reflections/reflection-in-composited-expected.png: Added.
  • platform/mac-leopard/compositing/reflections/reflection-ordering-expected.checksum: Added.
  • platform/mac-leopard/compositing/reflections/reflection-ordering-expected.png: Added.
  • platform/mac-leopard/compositing/repaint/content-into-overflow-expected.checksum: Added.
  • platform/mac-leopard/compositing/repaint/content-into-overflow-expected.png: Added.
  • platform/mac-leopard/compositing/repaint/layer-repaint-expected.checksum: Added.
  • platform/mac-leopard/compositing/repaint/layer-repaint-expected.png: Added.
  • platform/mac-leopard/compositing/repaint/opacity-between-absolute-expected.checksum: Added.
  • platform/mac-leopard/compositing/repaint/opacity-between-absolute-expected.png: Added.
  • platform/mac-leopard/compositing/repaint/opacity-between-absolute2-expected.checksum: Added.
  • platform/mac-leopard/compositing/repaint/opacity-between-absolute2-expected.png: Added.
  • platform/mac-leopard/fast/borders: Added.
  • platform/mac-leopard/fast/borders/svg-as-border-image-2-expected.checksum: Added.
  • platform/mac-leopard/fast/borders/svg-as-border-image-2-expected.png: Added.
  • platform/mac-leopard/fast/borders/svg-as-border-image-expected.checksum: Added.
  • platform/mac-leopard/fast/borders/svg-as-border-image-expected.png: Added.
  • platform/mac-leopard/fast/forms/placeholder-stripped-expected.checksum: Added.
  • platform/mac-leopard/fast/forms/placeholder-stripped-expected.png: Added.
  • platform/mac-leopard/fast/multicol: Added.
  • platform/mac-leopard/fast/multicol/column-count-with-rules-expected.checksum: Added.
  • platform/mac-leopard/fast/multicol/column-count-with-rules-expected.png: Added.
  • platform/mac-leopard/media/controls-strict-expected.checksum:
  • platform/mac-leopard/media/controls-strict-expected.png:
  • platform/mac-leopard/media/video-display-toggle-expected.checksum:
  • platform/mac-leopard/media/video-display-toggle-expected.png:
  • platform/mac-leopard/media/video-replaces-poster-expected.checksum: Added.
  • platform/mac-leopard/media/video-replaces-poster-expected.png: Added.
6:32 PM Changeset in webkit [59729] by jpetsovits@rim.com
  • 1 edit
    2 adds in trunk/WebCore

2010-05-18 Jakob Petsovits <jpetsovits@rim.com>

Unreviewed, forgot to svn add source file in r59619.
http://trac.webkit.org/changeset/59619

  • platform/image-decoders/openvg: Added.
  • platform/image-decoders/openvg/ImageDecoderOpenVG.cpp: Added. (WebCore::RGBA32Buffer::asNewNativeImage):
6:16 PM Changeset in webkit [59728] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-05-18 Martin Robinson <mrobinson@igalia.com>

Not reviewed.

[GTK] fast/dom/Geolocation/enabled.html is crashing on the bots
https://bugs.webkit.org/show_bug.cgi?id=39326

  • platform/gtk/Skipped: Skip another test causing crashes.
6:05 PM Changeset in webkit [59727] by yaar@chromium.org
  • 29 edits
    2 deletes in trunk

2010-05-18 Yaar Schnitman <yaar@chromium.org>

Unreviewed, rolling out r59693.
http://trac.webkit.org/changeset/59693
https://bugs.webkit.org/show_bug.cgi?id=37815

Broke GTK Release

  • Android.jscbindings.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSCallbackData.cpp: (WebCore::JSCallbackData::invokeCallback):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent):
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript):
  • bindings/js/JSMainThreadExecState.cpp: Removed.
  • bindings/js/JSMainThreadExecState.h: Removed.
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::executeFunctionInContext): (WebCore::ScheduledAction::execute):
  • bindings/js/ScheduledAction.h:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld):
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::call):
  • bindings/objc/ObjCEventListener.mm:
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]):
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/test/ObjC/DOMTestCallback.mm: (-[DOMTestCallback callbackWithClass1Param:]): (-[DOMTestCallback callbackWithClass2Param:strArg:]): (-[DOMTestCallback callbackWithNonBoolReturnType:]): (-[DOMTestCallback customCallback:class6Param:]):
  • bindings/scripts/test/ObjC/DOMTestInterface.mm:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj readOnlyIntAttr]): (-[DOMTestObj readOnlyStringAttr]): (-[DOMTestObj readOnlyTestObjAttr]): (-[DOMTestObj intAttr]): (-[DOMTestObj setIntAttr:]): (-[DOMTestObj longLongAttr]): (-[DOMTestObj setLongLongAttr:]): (-[DOMTestObj unsignedLongLongAttr]): (-[DOMTestObj setUnsignedLongLongAttr:]): (-[DOMTestObj stringAttr]): (-[DOMTestObj setStringAttr:]): (-[DOMTestObj testObjAttr]): (-[DOMTestObj setTestObjAttr:]): (-[DOMTestObj attrWithException]): (-[DOMTestObj setAttrWithException:]): (-[DOMTestObj attrWithSetterException]): (-[DOMTestObj setAttrWithSetterException:]): (-[DOMTestObj attrWithGetterException]): (-[DOMTestObj setAttrWithGetterException:]): (-[DOMTestObj customAttr]): (-[DOMTestObj setCustomAttr:]): (-[DOMTestObj scriptStringAttr]): (-[DOMTestObj voidMethod]): (-[DOMTestObj voidMethodWithArgs:strArg:objArg:]): (-[DOMTestObj intMethod]): (-[DOMTestObj intMethodWithArgs:strArg:objArg:]): (-[DOMTestObj objMethod]): (-[DOMTestObj objMethodWithArgs:strArg:objArg:]): (-[DOMTestObj methodThatRequiresAllArgs:objArg:]): (-[DOMTestObj methodThatRequiresAllArgsAndThrows:objArg:]): (-[DOMTestObj serializedValue:]): (-[DOMTestObj methodWithException]): (-[DOMTestObj customMethod]): (-[DOMTestObj customMethodWithArgs:strArg:objArg:]): (-[DOMTestObj customArgsAndException:]): (-[DOMTestObj addEventListener:listener:useCapture:]): (-[DOMTestObj removeEventListener:listener:useCapture:]): (-[DOMTestObj withDynamicFrame]): (-[DOMTestObj withDynamicFrameAndArg:]): (-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]): (-[DOMTestObj withDynamicFrameAndUserGesture:]): (-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]): (-[DOMTestObj withScriptStateVoid]): (-[DOMTestObj withScriptStateObj]): (-[DOMTestObj withScriptStateVoidException]): (-[DOMTestObj withScriptStateObjException]): (-[DOMTestObj methodWithOptionalArg:]): (-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]): (-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
  • bindings/v8/ScriptController.cpp:
  • bindings/v8/ScriptController.h:
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::isURLAllowed):

2010-05-18 Yaar Schnitman <yaar@chromium.org>

Unreviewed, rolling out r59693.
http://trac.webkit.org/changeset/59693
https://bugs.webkit.org/show_bug.cgi?id=37815

Broke GTK Release

  • http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
  • http/tests/security/xss-DENIED-iframe-src-alias.html:
5:57 PM Changeset in webkit [59726] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-05-18 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement comment states for HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=39334

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken):
5:52 PM Changeset in webkit [59725] by dpranke@chromium.org
  • 11 edits
    23 adds in trunk/WebKitTools

2010-05-18 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: implement '--reset-results' flag to complement
the '--new-baseline' flag. '--new-baseline' will always write the
results into the platform directory; '--reset-results' will update the
existing baseline wherever it happens to be. Both sets of behavior
are useful in different circumstances.

https://bugs.webkit.org/show_bug.cgi?id=38879

  • Scripts/webkitpy/layout_tests/data/image/canvas-bg.html: Added.
  • Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.checksum: Added.
  • Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.png: Added.
  • Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.txt: Added.
  • Scripts/webkitpy/layout_tests/data/image/canvas-zoom.html: Added.
  • Scripts/webkitpy/layout_tests/data/misc/crash-expected.txt: Added.
  • Scripts/webkitpy/layout_tests/data/misc/crash.html: Added.
  • Scripts/webkitpy/layout_tests/data/misc/missing-expectation.html: Added.
  • Scripts/webkitpy/layout_tests/data/misc/passing-expected.txt: Added.
  • Scripts/webkitpy/layout_tests/data/misc/passing.html: Added.
  • Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.checksum: Added.
  • Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.png: Added.
  • Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.txt: Added.
  • Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt: Added.
  • Scripts/webkitpy/layout_tests/data/text/article-element-expected.txt: Added.
  • Scripts/webkitpy/layout_tests/data/text/article-element.html: Added.
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  • Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  • Scripts/webkitpy/layout_tests/test_types/text_diff.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/dryrun.py:
5:50 PM QtWebKitBackportingFixes edited by Laszlo Gombos
(diff)
5:42 PM Changeset in webkit [59724] by andersca@apple.com
  • 15 edits
    1 delete in trunk/WebCore

2010-05-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Move all member variables from MappedAttribute to Attribute.
https://bugs.webkit.org/show_bug.cgi?id=39336
<rdar://problem/8000853>

This saves one word because we no longer have any virtual member functions in Attribute, and
thus no vtable pointer.


I plan to remove MappedAttribute altogether in a subsequent commit.

  • Android.mk:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::styleForElement):
  • dom/Attribute.cpp: (WebCore::Attribute::clone):
  • dom/Attribute.h: (WebCore::Attribute::create): (WebCore::Attribute::style): (WebCore::Attribute::decl): (WebCore::Attribute::setDecl): (WebCore::Attribute::isMappedAttribute): (WebCore::Attribute::Attribute):
  • dom/MappedAttribute.cpp: Removed.
  • dom/MappedAttribute.h: (WebCore::MappedAttribute::create): (WebCore::MappedAttribute::MappedAttribute): (WebCore::toMappedAttribute):
  • dom/NamedMappedAttrMap.cpp: (WebCore::NamedMappedAttrMap::declCount): (WebCore::NamedMappedAttrMap::mapsEquivalent):
  • dom/StyledElement.cpp: (WebCore::StyledElement::attributeChanged):
  • svg/SVGSVGElement.cpp: (WebCore::updateCSSForAttribute):
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::getPresentationAttribute):
5:36 PM Changeset in webkit [59723] by jamesr@google.com
  • 1 edit
    36 adds in trunk/LayoutTests

2010-05-18 James Robinson <jamesr@chromium.org>

Unreviewed.

Add leopard-specific pixel results for tests that need them
https://bugs.webkit.org/show_bug.cgi?id=39325

This adds new Leopard baselines for all tests that currently
pass with tolerance=0 on Snow Leopard but fail on Leopard
with an image diff of <= 0.01%. These tests previously had
expectations in platform/mac that were Snow Leopard specific.

  • platform/mac-leopard/compositing/color-matching: Added.
  • platform/mac-leopard/compositing/color-matching/pdf-image-match-expected.checksum: Added.
  • platform/mac-leopard/compositing/color-matching/pdf-image-match-expected.png: Added.
  • platform/mac-leopard/compositing/reflections: Added.
  • platform/mac-leopard/compositing/reflections/simple-composited-reflections-expected.checksum: Added.
  • platform/mac-leopard/compositing/reflections/simple-composited-reflections-expected.png: Added.
  • platform/mac-leopard/compositing/repaint/overflow-into-content-expected.checksum: Added.
  • platform/mac-leopard/compositing/repaint/overflow-into-content-expected.png: Added.
  • platform/mac-leopard/editing/pasteboard: Added.
  • platform/mac-leopard/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.checksum: Added.
  • platform/mac-leopard/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png: Added.
  • platform/mac-leopard/fast/css: Added.
  • platform/mac-leopard/fast/css/pseudo-cache-stale-expected.checksum: Added.
  • platform/mac-leopard/fast/css/pseudo-cache-stale-expected.png: Added.
  • platform/mac-leopard/fast/frames: Added.
  • platform/mac-leopard/fast/frames/take-focus-from-iframe-expected.checksum: Added.
  • platform/mac-leopard/fast/frames/take-focus-from-iframe-expected.png: Added.
  • platform/mac-leopard/fast/repaint: Added.
  • platform/mac-leopard/fast/repaint/fixed-child-move-after-scroll-expected.checksum: Added.
  • platform/mac-leopard/fast/repaint/fixed-child-move-after-scroll-expected.png: Added.
  • platform/mac-leopard/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.checksum: Added.
  • platform/mac-leopard/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png: Added.
  • platform/mac-leopard/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.checksum: Added.
  • platform/mac-leopard/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png: Added.
  • platform/mac-leopard/fast/repaint/fixed-move-after-scroll-expected.checksum: Added.
  • platform/mac-leopard/fast/repaint/fixed-move-after-scroll-expected.png: Added.
  • platform/mac-leopard/fast/text/format-control-expected.checksum: Added.
  • platform/mac-leopard/fast/text/format-control-expected.png: Added.
  • platform/mac-leopard/plugins: Added.
  • platform/mac-leopard/plugins/qt-qwidget-plugin-expected.checksum: Added.
  • platform/mac-leopard/plugins/qt-qwidget-plugin-expected.png: Added.
  • platform/mac-leopard/transforms/svg-vs-css-expected.checksum: Added.
  • platform/mac-leopard/transforms/svg-vs-css-expected.png: Added.
  • platform/mac-leopard/transitions: Added.
  • platform/mac-leopard/transitions/move-after-transition-expected.checksum: Added.
  • platform/mac-leopard/transitions/move-after-transition-expected.png: Added.
5:36 PM Changeset in webkit [59722] by tony@chromium.org
  • 3 edits
    1 add in trunk

2010-05-18 Tony Chang <tony@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24943
Command-B and Command-I do not generate keydown events in contentEditable regions.

  • manual-tests/style-keypress-events.html: Added.

2010-05-18 Tony Chang <tony@chromium.org>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=24943
Command-B and Command-I do not generate keydown events in contentEditable regions.

Manual test because performKeyEquivalent is not called by DRT.

Test: manual-tests/style-keypress-events.html

  • WebView/WebHTMLView.mm: (-[WebHTMLView performKeyEquivalent:]): Move style key handling until after webcore gets a chance to handle the event
5:31 PM Changeset in webkit [59721] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-05-18 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add more state to the HTML5 lexer
https://bugs.webkit.org/show_bug.cgi?id=39333

This code is just transliteration from the spec.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::HTML5Lexer): (WebCore::HTML5Lexer::nextToken):
  • html/HTML5Lexer.h:
4:55 PM Changeset in webkit [59720] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-05-18 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement two more lexer states
https://bugs.webkit.org/show_bug.cgi?id=39298

No tests because Eric is still working on wiring up the lexer to the
test harness.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::nextToken): (WebCore::HTML5Lexer::emitParseError): (WebCore::HTML5Lexer::emitCurrentTagToken):
  • html/HTML5Lexer.h:
4:53 PM Changeset in webkit [59719] by beidson@apple.com
  • 10 edits
    1 copy
    4 adds in trunk

Repro crash with many Google image search results
<rdar://problem/7685669> and https://bugs.webkit.org/show_bug.cgi?id=39323

Reviewed by Maciej Stachowiak.

WebCore:

When an iframe has a plugin resource as its src, that case bypassed the plugin sandboxing checks and continued to load
the data for the plugin resource. It handed that data off to a nonexistent Widget, causing a null deref and the crash.

By replacing PluginDocuments in sandboxes iframes with a new "SinkDocument" that just acts as a data sink, we prevent the
crash and also prevent actually loading the plugin binaries.

I filed https://bugs.webkit.org/show_bug.cgi?id=39330 to follow up and let us cancel the load as soon as we know we should.

Test: fast/loader/sandboxed-plugin-crash.html

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::begin): If the created document is a PluginDocument and the plugin sandbox flag is set,

replace it with a SinkDocument.

  • loader/PluginDocument.h:

(WebCore::PluginDocument::isPluginDocument): Make public (it was already public at the Document.h level).

Add a simple document/tokenizer pair that simply presents a blank HTML document and acts as a data sink for whatever
data is handed to it:

  • loader/SinkDocument.cpp: Added.

(WebCore::SinkTokenizer::SinkTokenizer):
(WebCore::SinkTokenizer::write):
(WebCore::SinkTokenizer::isWaitingForScripts):
(WebCore::SinkTokenizer::wantsRawData):
(WebCore::SinkTokenizer::writeRawData):
(WebCore::SinkTokenizer::stopParsing):
(WebCore::SinkTokenizer::finish):
(WebCore::SinkDocument::SinkDocument):
(WebCore::SinkDocument::createTokenizer):

  • loader/SinkDocument.h: Added.

(WebCore::SinkDocument::create):

LayoutTests:

  • fast/loader/resources/test.swf: Copied from LayoutTests/fast/replaced/resources/test.swf.
  • fast/loader/sandboxed-plugin-crash-expected.txt: Added.
  • fast/loader/sandboxed-plugin-crash.html: Added.
3:53 PM Changeset in webkit [59718] by Martin Robinson
  • 2 edits in trunk/LayoutTests

2010-05-18 Martin Robinson <mrobinson@igalia.com>

No review necessary.

[GTK] fast/dom/Geolocation/enabled.html is crashing on the bots
https://bugs.webkit.org/show_bug.cgi?id=39326

  • platform/gtk/Skipped: Skip the crashing tests.
3:47 PM Changeset in webkit [59717] by Laszlo Gombos
  • 2 edits in trunk/WebKit/qt

2010-05-18 Laszlo Gombos <Laszlo Gombos>

Symbian build fix.

[Qt] Updated the def file with new exports after r59335.

  • symbian/eabi/QtWebKitu.def:
3:38 PM Changeset in webkit [59716] by weinig@apple.com
  • 3 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=39321
Reduce the size of ListHashSets used by Document
<rdar://problem/7999388>

Reviewed by Anders Carlsson.

Reduce Membuster peak memory usage by ~450K by reducing the pool sizes
of the ListHashSets used by Document.

  • dom/Document.cpp:

(WebCore::Document::addStyleSheetCandidateNode):
(WebCore::Document::recalcStyleSelector):

  • dom/Document.h:
3:29 PM Changeset in webkit [59715] by jianli@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

Updated WebCore/Change to correct the bug link.

3:14 PM Changeset in webkit [59714] by Martin Robinson
  • 2 edits in trunk/WebKit/gtk

2010-05-18 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] DragClientGtk::startDrag leaks GdkEvents
https://bugs.webkit.org/show_bug.cgi?id=39322

  • WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::startDrag): Properly clean up allocated GdkEvent.
2:59 PM Changeset in webkit [59713] by kenneth@webkit.org
  • 2 edits in trunk/WebCore

Return null when creating an ImageBuffer failed, due to for
instance a nulled pixmap.

Rubberstamped by Simon Hausmann.

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::ImageBufferData::ImageBufferData):
(WebCore::ImageBuffer::ImageBuffer):

2:55 PM Changeset in webkit [59712] by jianli@chromium.org
  • 7 edits in trunk

Fix bug 39285: fast/files/file-reader.html is timing out on all mac bots.
https://bugs.webkit.org/show_bug.cgi?id=39135

Reviewed by Dmitry Titov.

WebCore:

The timeout is caused by 59659 that changed the GC timer to 0 and thus
triggered a bug in FileReader code. The fix is to add more states so
that hasPendingActivity() can do the check correctly.

  • html/FileReader.cpp:

(WebCore::FileReader::FileReader):
(WebCore::FileReader::hasPendingActivity):
(WebCore::FileReader::readInternal):
(WebCore::FileReader::terminate):
(WebCore::FileReader::didStart):
(WebCore::FileReader::didGetSize):
(WebCore::FileReader::didRead):
(WebCore::FileReader::didFinish):
(WebCore::FileReader::didFail):
(WebCore::FileReader::readyState):
(WebCore::FileReader::result):

  • html/FileReader.h:

(WebCore::FileReader::):

LayoutTests:

Re-enale the file reader test.

  • fast/files/file-reader-expected.txt:
  • fast/files/file-reader.html:
  • platform/mac/Skipped:
2:37 PM Changeset in webkit [59711] by Simon Fraser
  • 3 edits in trunk/WebCore

2010-05-18 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Clean up GraphicsLayer naming code
https://bugs.webkit.org/show_bug.cgi?id=39316

Move code that generates a name for the GraphicsLayer (used in debug builds only) into
a new nameForLayer() method. Use it when naming the foreground layer.

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::createGraphicsLayer): (WebCore::RenderLayerBacking::updateForegroundLayer): (WebCore::RenderLayerBacking::nameForLayer):
  • rendering/RenderLayerBacking.h:
2:22 PM Changeset in webkit [59710] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533-branch

Merge r59556.

2:22 PM Changeset in webkit [59709] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533-branch

Merge r59495.

2:22 PM Changeset in webkit [59708] by mrowe@apple.com
  • 9 edits in branches/safari-533-branch/WebCore

Merge r59576.

2:22 PM Changeset in webkit [59707] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533-branch

Merge r59486.

2:22 PM Changeset in webkit [59706] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59577.

2:22 PM Changeset in webkit [59705] by mrowe@apple.com
  • 3 edits
    1 add in branches/safari-533-branch/WebCore

Merge r59610.

2:22 PM Changeset in webkit [59704] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59609.

2:22 PM Changeset in webkit [59703] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533-branch

Merge r59516.

2:21 PM Changeset in webkit [59702] by mrowe@apple.com
  • 1 edit
    1 add in branches/safari-533-branch/LayoutTests

Merge r59444.

2:21 PM Changeset in webkit [59701] by mrowe@apple.com
  • 3 edits
    4 adds in branches/safari-533-branch

Merge r59443.

2:21 PM Changeset in webkit [59700] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533-branch

Merge r59390.

2:21 PM Changeset in webkit [59699] by mrowe@apple.com
  • 3 edits
    2 adds in branches/safari-533-branch

Merge r59591.

2:21 PM Changeset in webkit [59698] by mrowe@apple.com
  • 11 edits in branches/safari-533-branch/WebCore

Merge r59629.

2:21 PM Changeset in webkit [59697] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/WebCore

Merge r59583.

2:21 PM Changeset in webkit [59696] by mrowe@apple.com
  • 6 edits in branches/safari-533-branch

Merge r59514.

2:21 PM Changeset in webkit [59695] by mrowe@apple.com
  • 2 edits in branches/safari-533-branch/JavaScriptCore

Merge r59587.

2:20 PM Changeset in webkit [59694] by mrowe@apple.com
  • 7 edits in branches/safari-533-branch

Merge r59547.

2:15 PM Changeset in webkit [59693] by yaar@chromium.org
  • 29 edits
    2 adds in trunk

2010-05-18 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Moving frame.src checks out of the bindings
https://bugs.webkit.org/show_bug.cgi?id=37815

Moved JavaScript frame.src checks out of bindings and into
HTMLFrameElementBase. Added main thread state stack to JavaScriptCore
so ExecState is available inside core DOM. Updated affected bindings
(except for GObject, which will need to be updated to avoid origin
failures inside native code).

  • Android.jscbindings.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSCallbackData.cpp: (WebCore::JSCallbackData::invokeCallback):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent):
  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::InjectedScriptHost::createInjectedScript):
  • bindings/js/JSMainThreadExecState.cpp: Added.
  • bindings/js/JSMainThreadExecState.h: Added. (WebCore::JSMainThreadExecState::currentState): (WebCore::JSMainThreadExecState::call): (WebCore::JSMainThreadExecState::evaluate): (WebCore::JSMainThreadExecState::JSMainThreadExecState): (WebCore::JSMainThreadExecState::~JSMainThreadExecState): (WebCore::JSMainThreadNullState::JSMainThreadNullState):
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::executeFunctionInContext): (WebCore::ScheduledAction::execute):
  • bindings/js/ScheduledAction.h:
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::evaluateInWorld): (WebCore::ScriptController::canAccessFromCurrentOrigin):
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::call):
  • bindings/objc/ObjCEventListener.mm:
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]):
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/test/ObjC/DOMTestCallback.mm: (-[DOMTestCallback callbackWithClass1Param:]): (-[DOMTestCallback callbackWithClass2Param:strArg:]): (-[DOMTestCallback callbackWithNonBoolReturnType:]): (-[DOMTestCallback customCallback:class6Param:]):
  • bindings/scripts/test/ObjC/DOMTestInterface.mm:
  • bindings/scripts/test/ObjC/DOMTestObj.mm: (-[DOMTestObj readOnlyIntAttr]): (-[DOMTestObj readOnlyStringAttr]): (-[DOMTestObj readOnlyTestObjAttr]): (-[DOMTestObj intAttr]): (-[DOMTestObj setIntAttr:]): (-[DOMTestObj longLongAttr]): (-[DOMTestObj setLongLongAttr:]): (-[DOMTestObj unsignedLongLongAttr]): (-[DOMTestObj setUnsignedLongLongAttr:]): (-[DOMTestObj stringAttr]): (-[DOMTestObj setStringAttr:]): (-[DOMTestObj testObjAttr]): (-[DOMTestObj setTestObjAttr:]): (-[DOMTestObj attrWithException]): (-[DOMTestObj setAttrWithException:]): (-[DOMTestObj attrWithSetterException]): (-[DOMTestObj setAttrWithSetterException:]): (-[DOMTestObj attrWithGetterException]): (-[DOMTestObj setAttrWithGetterException:]): (-[DOMTestObj customAttr]): (-[DOMTestObj setCustomAttr:]): (-[DOMTestObj scriptStringAttr]): (-[DOMTestObj voidMethod]): (-[DOMTestObj voidMethodWithArgs:strArg:objArg:]): (-[DOMTestObj intMethod]): (-[DOMTestObj intMethodWithArgs:strArg:objArg:]): (-[DOMTestObj objMethod]): (-[DOMTestObj objMethodWithArgs:strArg:objArg:]): (-[DOMTestObj methodThatRequiresAllArgs:objArg:]): (-[DOMTestObj methodThatRequiresAllArgsAndThrows:objArg:]): (-[DOMTestObj serializedValue:]): (-[DOMTestObj methodWithException]): (-[DOMTestObj customMethod]): (-[DOMTestObj customMethodWithArgs:strArg:objArg:]): (-[DOMTestObj customArgsAndException:]): (-[DOMTestObj addEventListener:listener:useCapture:]): (-[DOMTestObj removeEventListener:listener:useCapture:]): (-[DOMTestObj withDynamicFrame]): (-[DOMTestObj withDynamicFrameAndArg:]): (-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]): (-[DOMTestObj withDynamicFrameAndUserGesture:]): (-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]): (-[DOMTestObj withScriptStateVoid]): (-[DOMTestObj withScriptStateObj]): (-[DOMTestObj withScriptStateVoidException]): (-[DOMTestObj withScriptStateObjException]): (-[DOMTestObj methodWithOptionalArg:]): (-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]): (-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::canAccessFromCurrentOrigin):
  • bindings/v8/ScriptController.h:
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::isURLAllowed):

2010-05-18 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

Moving frame.src checks out of the bindings
https://bugs.webkit.org/show_bug.cgi?id=37815

  • http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
  • http/tests/security/xss-DENIED-iframe-src-alias.html:
2:11 PM Changeset in webkit [59692] by crogers@google.com
  • 13 edits
    2 copies
    2 adds in branches/audio

Add initial implementation for JavascriptAudioSourceNode

  • this is very experimental to get us quickly up and running
  • fix AudioContext to not use static global for timing!
  • unfinished steps at getting V8 bindings working again
1:52 PM Changeset in webkit [59691] by atwilson@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed: Speculative build fix for Chromium win.

  • platform/graphics/skia/SkiaFontWin.cpp: Properly set inlineCapacity.
1:39 PM Changeset in webkit [59690] by atwilson@chromium.org
  • 2 edits in trunk/WebCore

Unreviewed fix for Chromium build break.

  • platform/graphics/skia/SkiaFontWin.cpp: Now set inlineCapacity param.
1:22 PM Changeset in webkit [59689] by dimich@chromium.org
  • 8 edits in trunk

DragData::asURL() shouldn't do file validity checks
https://bugs.webkit.org/show_bug.cgi?id=38711

Patch by Daniel Cheng <dcheng@chromium.org> on 2010-05-18
Reviewed by Darin Adler, Jian Li.

WebCore:

There's no point to trying to make sure the file is valid in
DragData::asURL(). It's better to ask for forgiveness than to ask for
permission, since asking for permission is prone to race conditions
and results in unnecessary I/O. Consumers of this function either:

  • need to verify the file exists themselves (e.g. the loader)
  • don't care about file validity (rich text drag-and-drop)
  • platform/chromium/DragDataChromium.cpp:

(WebCore::DragData::asURL):

WebKit/mac:

Change [NSPasteboard _web_bestURL] to still return a file URL for paths
that don't exist. Callers who care about the existence of the file or
whether or not it is a directory should check themselves when they
want to use the file. The directory check has been left in for now,
since the Mac implementation of ResourceHandle, which uses this function
indirectly via DragController::performDrag) handles directories somewhat
non-intuitively: it opens the parent directory in the Finder, rather
than opening the directory itself.

  • Misc/WebNSPasteboardExtras.mm:

(-[NSPasteboard _web_bestURL]):

LayoutTests:

Several layout tests depended on the fact that dropping a file would
never trigger navigation. This never happened to occur in the past,
since it just so happened that the filenames used in the tests never
resolved to files that exist. Since DragData::asURL() no longer tries
to verify file existence, the layout tests were updated to either
suppress navigation or log any navigation that should occur as part of
the test.

  • editing/pasteboard/file-input-files-access-expected.txt:
  • editing/pasteboard/script-tests/file-input-files-access.js:

(runTest.window.onbeforeunload):
(runTest):

  • http/tests/security/clipboard/script-tests/clipboard-file-access.js:
1:21 PM Changeset in webkit [59688] by timothy@apple.com
  • 12 edits in trunk/WebCore

Fix a handful of various localization issues in the Web Inspector.

  • Localize strings that where not localized.
  • Make WebInspector.UIString work without bind.
  • Always pass WebInspector.UIString to Number.secondsToString and Number.bytesToString.
  • Never pass a variable to WebInspector.UIString, since that prevents auto-generation.
  • Use an ellipsis instead of three periods.

https://webkit.org/b/39303
rdar://problem/7997101

Reviewed by Adam Roben.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.GzipRule.prototype.doRun):
(WebInspector.AuditRules.CookieSizeRule.prototype.processCookies):
(WebInspector.AuditRules.StaticCookielessRule.prototype.processCookies):

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView):

  • inspector/front-end/ImageView.js:

(WebInspector.ImageView.prototype.contentTabSelected):

  • inspector/front-end/ProfileDataGridTree.js:

(WebInspector.ProfileDataGridNode.prototype.get data.formatMilliseconds):
(WebInspector.ProfileDataGridNode.prototype.get data):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourceTimeCalculator.prototype.formatValue):
(WebInspector.ResourceTransferTimeCalculator.prototype.formatValue):
(WebInspector.ResourceTransferDurationCalculator.prototype.formatValue):
(WebInspector.ResourceTransferSizeCalculator.prototype.formatValue):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._registerShortcuts):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype._contextMenu):

  • inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewCalculator):
(WebInspector.TimelineOverviewCalculator.prototype.formatValue):

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel):
(WebInspector.TimelineCalculator):
(WebInspector.TimelineCalculator.prototype.formatValue):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generateAggregatedInfo):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendTextRow):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendElementRow):

  • inspector/front-end/inspector.js:

(WebInspector.loaded):
(WebInspector.setRecordingProfile):
(WebInspector.UIString):

1:16 PM Changeset in webkit [59687] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2010-05-18 Eric Seidel <eric@webkit.org>

Reviewed by Adam Roben.

Add an --html5-parser option to DumpRenderTree to allow testing the new HTML5Lexer
https://bugs.webkit.org/show_bug.cgi?id=39311

This flag allows us to run the new HTML5Lexer code.
Right now all documents parse as empty documents, but
now that we're able to run the code we can fix that.

Once we're able to lex a few basic documents I'll add
an --html5-parser flag to run-webkit-tests so that we test
running all of the layout tests with the HTML5 parser.

  • DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues): (initializeGlobalsFromCommandLineOptions):
1:13 PM Changeset in webkit [59686] by weinig@apple.com
  • 2 edits in trunk/WebCore

Another attempt to fix the build.

  • css/CSSCursorImageValue.cpp:
12:48 PM QtWebKitTriageRoster edited by Simon Hausmann
(diff)
12:46 PM QtWebKitBugs edited by Simon Hausmann
(diff)
12:45 PM Changeset in webkit [59685] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

Try to fix the windows build.

  • API/JSStringRefBSTR.cpp:
12:33 PM Changeset in webkit [59684] by Adam Roben
  • 2 edits in trunk/WebCore

Make accelerated compositing work on machines that don't support hardware vertex processing

Fixes <http://webkit.org/b/39299> <rdar://problem/7997692> Accelerated
compositing on Windows doesn't work on machines that don't support
hardware vertex processing, but should

Reviewed by Eric Carlson.

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::createRenderer): Query the device
capabilities to decide whether to request hardware or software vertex
processing.

12:33 PM Changeset in webkit [59683] by Adam Roben
  • 3 edits
    1 move in trunk/WebCore

Make WKCACFLayerRenderer robust against temporary failure of Direct3DCreate9 and IDirect3D9::CreateDevice

For a short time after waking from sleep, Direct3DCreate9() will
return an IDirect3D9 for which IDirect3D9::CreateDevice will always
fail. Also during this time period, IDirect3D9::CreateDevice
will fail even for non-bad IDirect3D9s. (It will later start
succeeding.) WKCACFLayerRenderer now works around this behavior by
detecting when it might be in this situation and calling these
functions again later.

Fixes <http://webkit.org/b/39297> <rdar://problem/7997431> WebView
doesn't repaint until page reloads when page using hardware
acceleration loads just after waking from sleep

Reviewed by John Sullivan.

  • manual-tests/crash-and-no-repaint-after-wake-from-sleep.html:

Renamed from WebCore/manual-tests/crash-after-wake-from-sleep.html.
Modified to also include instructions for reproducing this bug.

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): Replaced
m_triedToCreateD3DRenderer with m_mightBeAbleToCreateDeviceLater. The
new member is initialized to true, since we haven't even tried to
create a device once yet.
(WebCore::WKCACFLayerRenderer::createRenderer): If we already have a
D3D device, or we don't have one and are sure that we won't be able to
create one later, just return the previously-created device, if any.
We assume that we won't be able to create a device later if this
function fails, unless the function fails due to CreateDevice failing.
As noted above, CreateDevice will sometimes temporarily fail and then
later start working again. When CreateDevice fails, we also assume
that we might have a bad IDirect3D9, so we get rid of the one we have
so a new (and hopefully non-bad) one will be allocated later.
(WebCore::WKCACFLayerRenderer::destroyRenderer): Reset
m_mightBeAbleToCreateDeviceLater to true, since we no longer have a
device.
(WebCore::WKCACFLayerRenderer::paint): Before trying to paint, try to
create our D3D device and renderer. If this fails, we bail out, but if
we think we might be able to create a device later we schedule another
paint (via renderSoon()) so that we'll try again soon.

  • platform/graphics/win/WKCACFLayerRenderer.h: Replaced

m_triedToCreateD3DRenderer with m_mightBeAbleToCreateDeviceLater.

12:32 PM Changeset in webkit [59682] by Adam Roben
  • 2 edits
    1 add in trunk/WebCore

Fix a crash when a page that uses accelerated compositing loads soon after the computer wakes from sleep

The set-up:

For a short time after waking from sleep, IDirect3D9::CreateDevice
will fail. This caused WKCACFLayerRenderer::createRenderer to fail,
and meant that WKCACFLayerRenderer never allocated a root layer.
WebView wouldn't notice that createRenderer failed, and would go ahead
and try to use the root layer anyway, resulting in a crash.

The fix:

We now allocate the root layer (and all the other members of
WKCACFLayerRenderer that aren't dependent on having an
IDirect3DDevice9) in WKCACFLayerRenderer's constructor. This way the
layers will always be present, even when creating the D3D device
fails.

There are two remaining problems:

1) This results in slightly more memory usage in the case where

CreateDevice fails.

2) Once we get into this bad state, the WebView doesn't repaint

until we navigate somewhere else.

(2) is covered by
<http://webkit.org/b/39297>/<rdar://problem/7997431>. We'll fix it by
retrying CreateDevice later in hopes that it will succeed after more
time has passed. This will in turn fix (1). (We should never end up in
a case where CreateDevice fails forever because we already did some
preliminary checks in acceleratedCompositingAvailable().)

Fixes <http://webkit.org/b/39295> <rdar://problem/7971319> Crash
(preceded by assertion) in WKCACFLayerRenderer::setNeedsDisplay when
computer wakes from sleep on particular page

Reviewed by John Sullivan.

  • manual-tests/crash-after-wake-from-sleep.html: Added. This

is the Poster Circle demo from webkit.org/blog, but modified to
automatically reload every 5 seconds and with instructions to put the
computer to sleep and wake it up again.

  • platform/graphics/win/WKCACFLayerRenderer.cpp:

(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): Moved code to
initialize m_context, m_renderContext, and m_*Layer here...
(WebCore::WKCACFLayerRenderer::createRenderer): ...from here.

12:32 PM Changeset in webkit [59681] by Adam Roben
  • 2 edits in trunk/WebCore

Remove an unused member variable from WKCACFLayerRenderer

Rubber-stamped by Ada Chan.

  • platform/graphics/win/WKCACFLayerRenderer.h: Removed m_viewLayer,

which is unused.

12:25 PM Changeset in webkit [59680] by andersca@apple.com
  • 3 edits in trunk/WebCore

2010-05-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Allocate the m_preloads list hash set dynamically and free it when done.
https://bugs.webkit.org/show_bug.cgi?id=39309
<rdar://problem/7998495>

This saves about 6000 bytes on a fully loaded document.

  • loader/DocLoader.cpp: (WebCore::DocLoader::requestPreload): (WebCore::DocLoader::clearPreloads):
  • loader/DocLoader.h:
12:16 PM Changeset in webkit [59679] by andersca@apple.com
  • 2 edits in trunk/WebCore

Revert unintended indentation and unnecessary nested name specifier.

  • rendering/RenderBlock.cpp:

(WebCore::clipOutPositionedObjects):
(WebCore::RenderBlock::insertPositionedObject):

11:58 AM Changeset in webkit [59678] by andersca@apple.com
  • 6 edits in trunk

2010-05-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add an inlineCapacity template parameter to ListHashSet and use it to shrink the positioned object list hash set.
https://bugs.webkit.org/show_bug.cgi?id=39304
<rdar://problem/7998366>

Add an inlineCapacity template parameter to ListHashSet.

  • wtf/ListHashSet.h: (WTF::::ListHashSet): (WTF::::operator): (WTF::::swap): (WTF::::~ListHashSet): (WTF::::size): (WTF::::capacity): (WTF::::isEmpty): (WTF::::begin): (WTF::::end): (WTF::::find): (WTF::::contains): (WTF::::add): (WTF::::insertBefore): (WTF::::remove): (WTF::::clear): (WTF::::unlinkAndDelete): (WTF::::appendNode): (WTF::::insertNodeBefore): (WTF::::deleteAllNodes): (WTF::::makeIterator): (WTF::::makeConstIterator): (WTF::deleteAllValues):

2010-05-18 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Add an inlineCapacity template parameter to ListHashSet and use it to shrink the positioned object list hash set.
https://bugs.webkit.org/show_bug.cgi?id=39304
<rdar://problem/7998366>

Set the inlineCapacity for the positionedObjects ListHashSet to 4 instead of 256. Since a RenderBlock usually has
few positioned objects, this saves memory.

  • WebCore.base.exp:
  • rendering/RenderBlock.cpp: (WebCore::clipOutPositionedObjects): (WebCore::RenderBlock::insertPositionedObject):
  • rendering/RenderBlock.h: (WebCore::RenderBlock::positionedObjects):
11:43 AM Changeset in webkit [59677] by weinig@apple.com
  • 11 edits
    2 moves in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=39258
Remove NamedAttrMap residual gunk

Reviewed by Darin Adler.

Replace NamedAttrMap.h/cpp with NamedNodeMap.h/cpp which was the class
it contained.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/v8/custom/V8NamedNodesCollection.cpp:
  • dom/NamedAttrMap.cpp: Removed.
  • dom/NamedAttrMap.h: Removed.
  • dom/NamedNodeMap.cpp: Copied from dom/NamedAttrMap.cpp.
  • dom/NamedNodeMap.h: Replaced with dom/NamedAttrMap.h.
  • editing/ReplaceNodeWithSpanCommand.cpp:
  • platform/chromium/ClipboardChromium.cpp:
11:32 AM Changeset in webkit [59676] by loki@webkit.org
  • 5 edits in trunk/JavaScriptCore

Fix the interpreter after r59637
https://bugs.webkit.org/show_bug.cgi?id=39287

Reviewed by Darin Adler.

  • runtime/Executable.h:
  • runtime/JSFunction.cpp:

(JSC::JSFunction::JSFunction):
(JSC::JSFunction::getCallData):

  • runtime/JSGlobalData.cpp:
  • runtime/JSGlobalData.h:
11:28 AM Changeset in webkit [59675] by jianli@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Build fix. Disable file-reader.html for more investigation.

  • platform/mac/Skipped:
11:28 AM Changeset in webkit [59674] by beidson@apple.com
  • 3 edits in trunk/WebCore

<rdar://problem/7993468> REGRESSION (r58586): Audio doesn't play on first click of play button at NPR.org

Reviewed by Eric Carlson.

NPR swallows the first mouse click on the play button, calls load() on the element, then waits for the
canplay event to come in before calling play itself.

After the site specific hack added in r58586, we disallowed play() from within the canplay event handler.
By tracking whether a load() was triggered by a user gesture, we can differentiate between the original
canplay event that we meant to ignore and the one resulting from the first mouse click which we want to honor.

No new tests. (Currently no way to test such site specific hack behavior)

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::load): Set the m_loadInitiatedByUserGesture flag
(WebCore::HTMLMediaElement::play): Only apply the site specific hack if the load wasn't initiated by a user gesture.

  • html/HTMLMediaElement.h:
11:09 AM Changeset in webkit [59673] by jpetsovits@rim.com
  • 3 edits in trunk/WebCore

2010-05-18 Jakob Petsovits <jpetsovits@rim.com>

Reviewed by Dirk Schulze.

[OpenVG] Fix stupid build errors from the OpenVG Path commit
https://bugs.webkit.org/show_bug.cgi?id=39228

  • platform/graphics/openvg/PainterOpenVG.cpp: (WebCore::PainterOpenVG::clipPath):
  • platform/graphics/openvg/PathOpenVG.cpp: (WebCore::Path::transform):
10:30 AM Changeset in webkit [59672] by jianli@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed. Build fix. Disable test cases in file-reader.html that
cause time-out in mac bot for further investigation.

  • fast/files/file-reader-expected.txt:
  • fast/files/file-reader.html:
10:27 AM Changeset in webkit [59671] by jparent@chromium.org
  • 3 edits in trunk/BugsSite

Rietveld review page should dedicate more space to Rietveld, less to high level comments form.

Reviewed by Ojan Vafai.

https://bugs.webkit.org/show_bug.cgi?id=39244

  • template/en/custom/attachment/reviewform.html.tmpl:

Delete a random BR amongst the hidden elements that was causing extra whitespace.

  • template/en/custom/attachment/rietveldreview.html.tmpl:

Increase size of Rietveld frame to 80%, from 60%.

9:18 AM Changeset in webkit [59670] by Chris Jerdonek
  • 3 edits in trunk/WebCore

2010-05-18 Chris Jerdonek <Chris Jerdonek>

Reviewed by Darin Adler.

Refactored FrameLoader::isDocumentSandboxed() from a private member function
to a static, non-member, non-friend function.

https://bugs.webkit.org/show_bug.cgi?id=39157

Making this function non-private lets us make FrameLoader::createWindow()
a non-member function in a subsequent patch. We also made it non-member
rather than member to increase encapsulation and limit the number of
public functions with access to private FrameLoader data.

No new functionality, so no new tests.

  • loader/FrameLoader.cpp: (WebCore::isDocumentSandboxed):
    • Moved this function from a private member function of FrameLoader to a static, non-member, non-friend function.

(WebCore::FrameLoader::createWindow):

  • Updated the call to isDocumentSandboxed().

(WebCore::FrameLoader::submitForm):

  • Updated the call to isDocumentSandboxed().

(WebCore::FrameLoader::requestObject):

  • Updated the call to isDocumentSandboxed().

(WebCore::FrameLoader::shouldAllowNavigation):

  • Updated the call to isDocumentSandboxed().
  • loader/FrameLoader.h:
    • Removed isDocumentSandboxed() and added a FIXME to move createWindow() out of the FrameLoader class.
7:07 AM Changeset in webkit [59669] by Simon Hausmann
  • 5 edits in trunk

[Qt] Fix http/tests/xmlhttprequest/cross-origin-no-authorization.html

2010-05-08 Robert Hogan <robert@roberthogan.net>

Reviewed by Simon Hausmann.

[Qt] Fix http/tests/xmlhttprequest/cross-origin-no-authorization.html

and http/tests/xmlhttprequest/cross-origin-authorization.html

QHttpNetworkRequest adds Authorization and Cookie headers to XHRs
without knowing if this is valid behaviour or not. In order to allow
Qt to decide whether Cookie/Authorization headers should be added
to an XHR QtWebKit needs to use an attribute added to QNetworkRequest.
These new attributes are: QNetworkRequest::CookieLoadControlAttribute,
QNetworkRequest::CookieSaveControlAttribute,and
QNetworkRequest::AuthenticationReuseControlAttribute.

QtWebKit will set QNetworkRequest::AuthenticationReuseControlAttribute to false
unless withCredentials is set to true in the XHR.

QtWebkit will set CookieLoad/SaveControlAttribute to false unless withCredentials
is set to true in the XHR.

Qt will pass the values onto QHttpNetworkRequest and this will permit
the Qt network access processing to decide whether or not to add either
or both of the Cookie/Authorisation headers, and whether to save cookies
returned from such requests. By default the attribute
will always be true so unless QtWebKit sets it to false normal
header processing is unaffected.

There are platform-specific results for cross-origin-no-authorization.html:

  1. Qt's DRT does not capture the final 'DONE'.
  2. QNetworkReplyHandler.cpp's ignoreHttpError() means that async requests do not execute didFail() when they receive a 401 HTTP response. This results in async tests passing with '401 Authorisation required' rather than 'received error event'.

The Qt part of these changes was merged at: http://gitorious.org/qt/qt/merge_requests/592

In order to properly support the tests, Qt's DRT needs to use one
NetworkAccessManager for all pages. This allows it to use cached
credentials where appropriate.

The tests now pass when run individually but there seems to be a problem with
leaking the results of requests across tests when run with the others in
http/tests. This will be addressed in a separate patch.

https://bugs.webkit.org/show_bug.cgi?id=32967

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::WebPage): (WebCore::DumpRenderTree::DumpRenderTree):
  • DumpRenderTree/qt/DumpRenderTreeQt.h:
  • platform/network/qt/ResourceRequestQt.cpp: (WebCore::ResourceRequest::toNetworkRequest):
  • platform/qt/Skipped: Group together the tests that are waiting for 4.7 to be unskipped.
  • platform/qt/http/tests/xmlhttprequest/cross-origin-no-authorization-expected.txt: Added.
6:25 AM Changeset in webkit [59668] by zherczeg@webkit.org
  • 2 edits in trunk/WebCore

[Qt] Implementing clipToImageBuffer for Qt port.
https://bugs.webkit.org/show_bug.cgi?id=24289

Reviewed by Kenneth Rohde Christiansen.

The implementation combines pixmap layers and destinationIn
composition mode.

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::TransparencyLayer::TransparencyLayer):
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
(WebCore::GraphicsContext::savePlatformState):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::inTransparencyLayer):
(WebCore::GraphicsContext::beginTransparencyLayer):
(WebCore::GraphicsContext::endTransparencyLayer):
(WebCore::GraphicsContext::clipToImageBuffer):

4:04 AM Changeset in webkit [59667] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-05-18 Eric Seidel <eric@webkit.org>

Unreviewed build fix.

Make it possible to enable the new HTML5Tokenizer for testing
https://bugs.webkit.org/show_bug.cgi?id=39275

  • WebCore.gypi:
    • Fix HTMLLexer.* -> HTML5Lexer.*
  • WebCore.vcproj/WebCore.vcproj:
    • Add HTML5Lexer and HTML5Tokenizer to project.
3:40 AM Changeset in webkit [59666] by ukai@chromium.org
  • 3 edits in trunk/WebKitTools

2010-05-18 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Eric Seidel.

run_webkit_tests_unittest fails on SnowLeopard
https://bugs.webkit.org/show_bug.cgi?id=39279

  • Scripts/webkitpy/layout_tests/port/base.py: Return copy of os.environ.
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Check os.environ was not modified.
3:38 AM Changeset in webkit [59665] by eric@webkit.org
  • 4 edits in trunk/WebCore

2010-05-18 Eric Seidel <eric@webkit.org>

Unreviewed build fix.

Make it possible to enable the new HTML5Tokenizer for testing
https://bugs.webkit.org/show_bug.cgi?id=39275

  • dom/NamedAttrMap.cpp: (WebCore::NamedNodeMap::setNamedItemNS):
    • Move this to the .cpp file so as to avoid needing to include "Node.h" in the header.
  • dom/NamedAttrMap.h:
  • html/HTML5Token.h:
    • Remove #include "String.h" which was wrong. Adam meant "PlatformString.h"
    • Remove unneeded #include "Node.h", it was only needed because NamedAttrMap.h was incorrectly depending on Node.h but not including it. It didn't actually need Node.h except for one inlined method setNamedItemNS, so I moved setNamedItemNS into the .cpp to get rid of the Node.h requirement.
3:17 AM Changeset in webkit [59664] by eric@webkit.org
  • 20 edits
    2 copies in trunk

2010-05-18 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Make it possible to enable the new HTML5Tokenizer for testing
https://bugs.webkit.org/show_bug.cgi?id=39275

I added html5ParserEnabled to Settings so that we can enable/disable
the HTML5 parser for testing.

I also ripped out a bunch of dead code from HTML5Lexer.

I had to add HTML5Lexer/HTML5Tokenizer to all build systems so that
the build wouldn't fail now that we reference these classes from HTMLDocument.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::reset): (WebCore::isWhitespace): (WebCore::HTML5Lexer::nextToken):
  • html/HTML5Lexer.h:
  • html/HTML5Tokenizer.cpp: Added. (WebCore::HTML5Tokenizer::HTML5Tokenizer): (WebCore::HTML5Tokenizer::~HTML5Tokenizer): (WebCore::HTML5Tokenizer::begin): (WebCore::HTML5Tokenizer::write): (WebCore::HTML5Tokenizer::end): (WebCore::HTML5Tokenizer::finish): (WebCore::HTML5Tokenizer::isWaitingForScripts):
  • html/HTML5Tokenizer.h: Added.
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::createTokenizer):
  • html/HTMLTokenizer.h:
  • html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createTokenizer):
  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h: (WebCore::Settings::setHTML5ParserEnabled): (WebCore::Settings::html5ParserEnabled):

2010-05-18 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth (and Maciej Stachowiak).

Make it possible to enable the new HTML5Tokenizer for testing
https://bugs.webkit.org/show_bug.cgi?id=39275

Expose the WebCore::Settings::html5ParserEnabled as a private WebKit setting.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (-[WebPreferences html5ParserEnabled]): (-[WebPreferences setHTML5ParserEnabled:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):
2:08 AM Changeset in webkit [59663] by abarth@webkit.org
  • 4 edits
    1 add in trunk/WebCore

2010-05-18 Maciej Stachowiak <mjs@apple.com>

Not reviewed, build fix.

Attempt to fix build for v8 bindings (untested).

  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::clearWindowShell):
  • bindings/v8/ScriptController.h:
2:04 AM Changeset in webkit [59662] by mjs@apple.com
  • 3 edits in trunk/WebCore

Not reviewed, build fix.

Attempt to fix build for v8 bindings (untested).

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::clearWindowShell):

  • bindings/v8/ScriptController.h:
1:52 AM Changeset in webkit [59661] by ukai@chromium.org
  • 4 edits
    1 add in trunk/WebKitTools

2010-05-18 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Eric Seidel.

Chromium: new-run-webkit-httpd fails to setup_mount
https://bugs.webkit.org/show_bug.cgi?id=39257

  • Scripts/webkitpy/common/system/executive.py: Assert type of args in run_command.
  • Scripts/webkitpy/common/system/executive_unittest.py: Add test_run_command_args_type
  • Scripts/webkitpy/layout_tests/port/chromium_win.py: Executive.run_command takes array for command line.
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Test if setup_environ_for_server() run setup_mount.bat.
1:42 AM Changeset in webkit [59660] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

Fix QWebHistory serialization.

Patch by Jedrzej Nowacki <jedrzej.nowacki@nokia.com> on 2010-05-18
Reviewed by Simon Hausmann.

Regression was caused by bug 33224. The streaming function
should generate a documentSequenceNumber for all loaded values.

[Qt] tst_QWebHistory::serialize_2() fails
https://bugs.webkit.org/show_bug.cgi?id=37322

  • Api/qwebhistory.cpp:

(operator>>):

1:09 AM Changeset in webkit [59659] by mjs@apple.com
  • 5 edits in trunk/WebCore

2010-05-17 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver Hunt.

GC more promptly when navigating to a new inner window, but not at all when it went in the page cache
https://bugs.webkit.org/show_bug.cgi?id=39254
<rdar://problem/7996370>

~1% PLT speedup
~4% iBench HTML speedup

  • bindings/js/GCController.cpp: (WebCore::GCController::garbageCollectSoon): Change back to a 0 delay timer instead of 0.5 second.
  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::clearWindowShell): Add a new boolean parameter. Don't garbageColectSoon if the page is going into the page cache.
  • bindings/js/ScriptController.h: Prototype change for above.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): Indicate when the page is going into the page cache.
12:24 AM Changeset in webkit [59658] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-05-18 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Implement ScriptData states for HTML5Lexer
https://bugs.webkit.org/show_bug.cgi?id=39273

This patch implements more of the lexer states according to the HTML5
specification. Currently, this code is compiled by not tested. We're
working on bringing up a test harness in parallel with transliterating
the spec into code.

  • html/HTML5Lexer.cpp: (WebCore::HTML5Lexer::tokenize): (WebCore::HTML5Lexer::temporaryBufferIs):
  • html/HTML5Lexer.h: (WebCore::HTML5Lexer::):
12:00 AM Changeset in webkit [59657] by eric@webkit.org
  • 2 edits
    2 moves in trunk/WebCore

2010-05-17 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Rename HTML5Tokenzier to HTML5Lexer so that we can add a new HTML5Tokenizer which implements Tokenizer
https://bugs.webkit.org/show_bug.cgi?id=39272

Strictly a rename, no functionality change.

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTML5Lexer.cpp: Added.
  • html/HTML5Lexer.h: Added.
  • html/HTML5Tokenizer.cpp: Removed.
  • html/HTML5Tokenizer.h: Removed.
Note: See TracTimeline for information about the timeline view.